Dev 31 - implemented Help page

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure all the tests are still passing.
[x] Make sure the test coverage is still 100%.
[x] Make sure your source branch is correct.
[x] Make sure your destination branch is devel.
[x] Make sure the name of the PR has a correct DEV-# identification prefix.
[ ] Make sure you reviewed all your changes and they look correct.
[x] Make sure all the commits have a correct format.
[x] Make sure you refer related issues for you PR.
[x] Make sure you add KovDimaY as a reviewer and assignee of your PR.

Take a look at the Issue #52

Coverage remained the same at 100.0% when pulling 7db8698e7e143990dde7f109db5af10c05686d3e on DEV-31 into cdc2b11bfd9ddc8d97a74af493eb10c0ef3c6cc1 on devel.


migrate string-refs in search_results.jsx

Summary
change this.refs into React.createRef
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/15619
Related Pull Requests
https://github.com/mattermost/mattermost-webapp/pull/5753

Hello @VolatianaYuliana,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.


Generalisation of grasp generation

This pull request is working towards generalising the grasp generator.

It fixes up some on the visualisations that were not working due to api changes.
added panda config
added grasp generation for cylinders
generalised pre grasp approach and post grasp retreat
integrated planner to use the planGraspsAndPick() function with this.

Please ping us after this is no longer a WIP

So much of this PR is deleting current functionality - please add a description to this PR of why you think this is necessary / what this PR does

Ok, @davetcoleman , this is the final state of the pull-request in this gsoc project.
I believe it's an improvement over the old state which hard-coded jaco in a number of places.
The code is far from perfect, and the demo for the tutorial does not look good yet, but I believe we should merge the request and move the repository to ros-planning.
While doing so, please add a comment to the README.md that makes it clear that code in this repository is work in progress and is not expected to work reliably yet.

A pull request of this size absolutely should have a description at the top

Hi, @davetcoleman
I have either handled the comment or replied to it.
Please take a look.

Unfortunately @mlautman and myself have put a lot of work into this package in the past few weeks and your changes are fairly out of sync with master... I'm not sure if we'll be able to merge in most of this. Also please see the new code location https://github.com/PickNikRobotics/moveit_grasps/
https://github.com/PickNikRobotics/moveit_grasps/graphs/code-frequency

that's ok, please let me know if and how can I contribute to that. I did spend a fair amount of time on this and would like to continue working on grasping.


Does it really make sence? :: (3 - 1 + 1)

Challenge http://www.freecodecamp.com/challenges/waypoint-add-your-javascript-slot-machine-slots has an issue. Please describe how to reproduce it, and include links to screenshots if possible.

Thanks for posting an issue!
Can you post a screenshot and explain exactly what the issue is?

closing as stale. Please feel free to reopen if issue still persists.


Add zh translation for blog VPA v1.27

I started a PR to translate https://kubernetes.io/blog/2023/05/12/in-place-pod-resize-alpha/ into Chinese.

@tengqm  Thanks for the detailed review. Updated.

/label tide/merge-method-squash
/approve

Thanks.
/lgtm


Class version updated to JDK9 (53.0) while exporting jar with Recaf using JDK8

I'm using Oracle JDK 1.8.0_333 to run Recaf but if edit bytecode inside a Jar and export it I get some class updated to JDK9 (53.0) and I can't run the jar with Java 1.8
Exception
Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.UnsupportedClassVersionError: org/bouncycastle/jce/provider/BouncyCastleProvider has been compiled by a more recent version of the Java Runtime (class file version 53.0), this version of the Java Runtime only recognizes class file versions up to 52.0
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:473)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
	at java.lang.Class.getDeclaredMethods0(Native Method)
	at java.lang.Class.privateGetDeclaredMethods(Class.java:2701)
	at java.lang.Class.privateGetMethodRecursive(Class.java:3048)
	at java.lang.Class.getMethod0(Class.java:3018)
	at java.lang.Class.getMethod(Class.java:1784)
	at sun.launcher.LauncherHelper.validateMainClass(LauncherHelper.java:650)
	at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:632)

Screenshots

Recaf does not update any class versions, send sample and we will take a look (if you have legal rights, if you don't, make a PoC).
To do that, join our Discord

That's weird I checked the mentioned class version before and after editing and it's definitely updated
does has anything to do with the de-compiler config choice?
I will try to make a POC but I'm not sure I can reproduce it
file org/bouncycastle/jce/provider/BouncyCastleProvider.class
org/bouncycastle/jce/provider/BouncyCastleProvider.class: compiled Java class data, version 49.0 (Java 1.5)

That's weird I checked the mentioned class version before and after editing and it's definitely updated
does has anything to do with the de-compiler config choice?
I will try to make a POC but I'm not sure I can reproduce it
file org/bouncycastle/jce/provider/BouncyCastleProvider.class
org/bouncycastle/jce/provider/BouncyCastleProvider.class: compiled Java class data, version 49.0 (Java 1.5)

https://github.com/Col-E/Recaf/blob/master/src/main/java/me/coley/recaf/ui/controls/text/JavaEditorPane.java#L117
Recaf will use whatever version the class had before, but it will bump it if javac does not support it.
Minimum version Recaf requires is JDK 8, thus, it should not change anything

If you're willing, you can clone the project and open it in an IDE. Then set a breakpoint on the line where xxDark mentions. That would let you inspect where the wrong version is coming from and you can provide additional details from that.
For me, I've not personally encountered this (WorksForMe:tm:) so I'm not sure where its getting the wrong value from.

This is caused by the multi-class version feature.

https://docs.oracle.com/javase/10/docs/specs/jar/jar.html#multi-release-jar-files

Ah, so the workspace model needs to be updated.... 🙃

Closing as 4.X is the only branch we're working on going forward. It supports muli-release jars.


Facing an issue with custome handler to e

@xabbuh @Tobion
I'm facing one issue in Symfony 5.1.2. I need to use a monolog custom handler but after updated changes when I running the cache clear command PHP process going too high. Please review the below code and give your help/suggestion for the same.
config/packages/prod/monolog.yaml
monolog:
    channels: ['db']
    handlers:
        main:
            type: fingers_crossed
            action_level: error
            handler: nested
            excluded_http_codes: [404, 405]
            buffer_size: 50 # How many messages should be saved? Prevent memory leaks
        nested:
            type: stream
            path: "%kernel.logs_dir%/%kernel.environment%.log"
            level: debug
        console:
            type: console
            process_psr_3_messages: false
            channels: ["!event", "!doctrine"]
        db:
            type: service
            id: app.monolog.db_handler
            channels: [db, doctrine]

config/services.yaml
App\EventListener\DatabaseActivitySubscriber:
  tags:
    - { name: 'doctrine.event_subscriber' }
app.monolog.db_handler:
  class: App\Handler\MonologDBHandler
  arguments<EMAIL_ADDRESS>

Hello @all
Does anyone have idea for the above issue?

What's the issue? I don't understand the problem description.
Also in the GitHub repository we only discuss about Symfony bugs and new features. For questions about using Symfony, please use any of the support alternatives shown in http://symfony.com/support Thanks!

@Tobion
Thanks for the replay.
When I add customer handler "db" it's generating an issue. When I try to cache clear on the production environment after adding this code PHP service process going too high and it's using 100% memory of the server. after a few mins, it's automatically killed.

I don't think we can help you here without seeing your custom App\Handler\MonologDBHandler. Again, for support questions please use the appropriate channels.

@Tobion
This issue is occurring when I define handler on monolog.yml
I've asked this to Symfony support they told me it's a monolog side issue.
/**
     * MonologDBHandler constructor.
     *
     * @param EntityManagerInterface|null $entityManager
     */
    public function __construct(EntityManagerInterface $entityManager = null)
    {
        parent::__construct();

        $this->entityManager = $entityManager;
    }

    /**
     * Called when writing to our database
     * @param array $record
     */
    protected function write(array $record): void
    {
        //echo $record['channel'];exit;
        if (!$this->initialized) {
            $this->initialize();
        }

        if ($this->channel != $record['channel']) {
            return;
        }

        $logEntry = new SystemLogs();
        $logEntry->setUser($record['context']['user']);
        $logEntry->setDescription($record['message']);
        $this->entityManager->persist($logEntry);
        $this->entityManager->flush();
    }

    private function initialize()
    {
        $this->initialized = true;
    }

@ankit-ilogix I suspect an infinite lop, where your Doctrine logs are sent through your DB-based logging, which means that writing the logs triggers more logging calls.

@stof
May be but this issue is only occurring when I run console command.  It's working fine on browser.


Manually search methods instead of using Class.getDeclaredMethod()

Class.getDeclaredMethod() will throw NoSuchMethodException when not found which requires the JDK to build a stacktrace, etc. This causes an unnecessary performance loss.
Note: this is currently a speculative change. This new code behaves somewhat differently than Class.getDeclaredMethod() but all tests pass.

How measurable is the performance impact? I find it surprising that it would matter in practice. Generally, the number of classes that an application exposes via JMX is "small".

We're not certain exactly what's going on tbh. A few thoughts:

The way Airlift processes Guice all Modules usually run twice, once for Config and once for the main application
The previous code is prone to lots of stacktraces in classes with a) a lot of methods and b) a deep hierarchy

I believe there is a significant potential for 1000s of stacktraces to be generated during Guice processing.
Maybe we can build a one-off version of JMXUtils that we can test with?

@martint and @jklamer I added a cache of a class's declared methods to avoid some redundant lookups.

Thanks @martint - do you mind doing a release soon?


Omit EventID

Since the hash can not be recovered, if the eventID is replaced with the hash and hence an existing id is shadowed.

Perfect, @Echsecutor!
I also just removed eventID fro our algorithm description.


Circular dependencies in v2

Do you want to request a feature or report a bug?

Bug
What is the current behavior?
Modules have no exports when they are circularly imported.
In the example given below, b.js can't access the exported variable a of index.js.
If the current behavior is a bug, please provide the steps to reproduce.

Use the code from this gist:
https://gist.github.com/gustavohenke/835d64b4049b2c71eeba811fceb8c481
then:
webpack
node bundle.js
// will print undefined

What is the expected behavior?
The currently exported variables should be available, even though there's a circular dependency,
just like plain CommonJS does.
In the above example, running the bundle file should print 123.
Please mention other relevant information such as the browser version, Node.js version, Operating System and programming language.
Using Windows 10 and Node v6.7.0, with plain JavaScript.
No browser used.

I should also note that when using commonjs modules this is not a problem.

You are right.
/* harmony import */ var __WEBPACK_IMPORTED_MODULE_0__a__ = __webpack_require__(0);
/* harmony import */ var __WEBPACK_IMPORTED_MODULE_1__b__ = __webpack_require__(1);
/* harmony import */ var __WEBPACK_IMPORTED_MODULE_1__b___default = __webpack_require__.n(__WEBPACK_IMPORTED_MODULE_1__b__);
/* harmony namespace reexport (by provided) */ __webpack_require__.d(exports, "a", function() { return __WEBPACK_IMPORTED_MODULE_0__a__["a"]; });
/* harmony namespace reexport (unknown) */ for(var __WEBPACK_IMPORT_KEY__ in __WEBPACK_IMPORTED_MODULE_1__b__) if(__WEBPACK_IMPORT_KEY__ !== 'default') (function(key) { __webpack_require__.d(exports, key, function() { return __WEBPACK_IMPORTED_MODULE_1__b__[key]; }) }(__WEBPACK_IMPORT_KEY__));

should be emitted as
/* harmony import */ var __WEBPACK_IMPORTED_MODULE_0__a__ = __webpack_require__(0);
/* harmony namespace reexport (by provided) */ __webpack_require__.d(exports, "a", function() { return __WEBPACK_IMPORTED_MODULE_0__a__["a"]; });
/* harmony import */ var __WEBPACK_IMPORTED_MODULE_1__b__ = __webpack_require__(1);
/* harmony import */ var __WEBPACK_IMPORTED_MODULE_1__b___default = __webpack_require__.n(__WEBPACK_IMPORTED_MODULE_1__b__);
/* harmony namespace reexport (unknown) */ for(var __WEBPACK_IMPORT_KEY__ in __WEBPACK_IMPORTED_MODULE_1__b__) if(__WEBPACK_IMPORT_KEY__ !== 'default') (function(key) { __webpack_require__.d(exports, key, function() { return __WEBPACK_IMPORTED_MODULE_1__b__[key]; }) }(__WEBPACK_IMPORT_KEY__));

So the order is incorrect. Thanks for reporting.


Timeout Warning

User Story
As a site user, in order to make an informed decisions about my session on the site, I would like to be able to know when I'm about to be logged out from anywhere on the site.
Acceptance criteria:

[x] The system displays a 2 minute countdown warning message before the user is logged out due to inactivity on either application, while they are on any part of the site (Pages, Rails or Phoenix)
[x] The user can extend their session and they remain logged in on both applications
[x] The user can end their session and they are logged out right away from both applications
[x] If the user takes no action, the system logs them out in 2 minutes from both applications

[x] The user is taken to a login page with a message displaying saying that the user was logged out due to inactivity

Definition of Done
Doing (dev team)

[x] Code complete
[x] Code is organized appropriately
[x] Any known trade offs are documented in the associated GH issue
[x] Code is documented, modules, shared functions, etc.
[x] Automated testing has been added or updated in response to changes in this PR
[x] The feature is smoke tested to confirm it meets requirements
[x] Database changes have been peer reviewed for index changes and performance bottlenecks
[x] PR that changes or adds UI

[x] include a screenshot of the WAVE report for the altered pages
[x] Confirm changes were validated for mobile responsiveness

[x] PR approved / Peer reviewed
[x] Security scans passed
[x] Automate accessibility tests passed
[x] Build process and deployment is automated and repeatable
[x] Feature toggles if appropriate
[x] Deploy to staging
[x] Move card to testing column in the board

Staging

[x] Usability testing: mobile and desktop (Tracy or Marni)
[ ] Accessibility tested (Marni)

[ ]  Keyboard navigation
[ ]  Focus confirmed
[ ] Color contrast compliance
[ ] Screen reader testing

[x] Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)

[x] Windows/Chrome
[x] Windows/Edge
[x] Mac/Chrome
[x] Mac/Safari
[x] iOS/Safari

[x] AC review (Renata)
[ ] ~Deploy to production (production-like environment for eval capability) (dev team)~
[x] Move to production column in the board

Production

[ ] User and security documentation has been reviewed for necessary updates (Renata/Tracy/Dev team)
[ ] PO / PM approved (Jarah or Renata)
[ ] AC is met and it works as expected (Jarah or Renata)
[ ] Move to done column in the board (Jarah or Renata)

Verify if timeout is handled properly when multiple tabs are used.

@TCKapGrp The timeout warning works for me as expected.

@cpreisinger UX seems off for me here. It renews the session simply when I move my mouse and not when I click the blue button. This is not the expected outcome for me and can cause confusion for users of all types. Should the message also contain notes about their current progress being autosaved?
Cannot perform A11y testing because the timeout disappears on mouse movement. Shouldn't the modal also have a "yes log me out" type option as well?

@mhotch24 Can you please re-test this, it works for me as expected. The countdown modal remains open when I move my mouse.
Re: modal copy, for the purpose of this user story, the message is accurate, but we will want to revisit it as part of holistic testing and during fit and finish updates.
Re: logout option on the modal, I'm not sure it is needed, since the users are able to logout from the main screen.

@r-bartlett-gsa The user doesn't have to click on the button in order for the session to continue. They can click anywhere. That wasn't the expected outcome for me but if you are ok with it that way I understand. I still think the Logout option makes sense so perhaps for next version.
Accessibility testing cannot be performed for the reason stated above. When I click to launch the testing tool the session continues. I suggest making this function correctly so we can do proper A11y testing.

@mhotch24 Can you please elaborate on "I suggest making this function correctly so we can do proper A11y testing."
In your first message you say that the modal disappears (the session renews) on mouse movement, but in the second you say that it disappears when you click anywhere on the screen. Can you please clarify.

@r-bartlett-gsa For me, the mouse doesn't need to click the blue button in order to deactivate the timeout. If we make that the function and not the mouse on-click, I will be able to do accessibility testing. So by making it only the button that triggers the event (as I was personally expecting) I will be able to do proper A11y testing.

@stepchud To summarize the conversation above, this needs to be updated so the session renews only when the user clicks on the modal button. Currently the session renews on click anywhere on the screen and that is preventing accessibility testing.

The requirements for updating the session timeout (before the warning modal appears) say that any mouse click or keypress on the page should renew the session. Are you saying that the timeout should renew differently when the modal appears than it does when the user is navigating the site normally? @r-bartlett-gsa

@stepchud From usability perspective I agree that the user should be able to click anywhere and renew the session, but @mhotch24 was indicating that she's not able to test the modal because of how it currently works.

We could change the modal to say click anywhere or press any key to continue your session? I think we can also disable the other event listeners and require pressing the button with a mouse or keyboard enter if that's what you want.

@mhotch24, is there another way to test the accessibility for this without changing the requirements for how the session is renewed? Is there a setting within the accessibility testing tool that you are using that would not require to click in order to launch it, or would you be able to launch the tool before the modal appears?

@r-bartlett-gsa I can do a code review but we won't be able to do proper screenreader testing. Let me know how to proceed.

@mhotch24 Before we decide on how to proceed, I'm still curious about the following, since most screen readers can be launched and controlled using keyboard shortcuts

Is there a setting within the accessibility testing tool that you are using that would not require to click in order to launch it, or would you be able to launch the tool before the modal appears?

@r-bartlett-gsa The testing process requires me to launch the testing tool. It's not that the user can't launch the screenreader. These are separate things.

@r-bartlett-gsa The testing process requires me to launch the testing tool. It's not that the user can't launch the screenreader. These are separate things.

@mhotch24 My question was not about the user, it was whether you can launch the screenreader using keyboard shortcuts in order to test this properly. And yes, we can call this done at this time, but there might be other instances in the future that will require you to launch your testing tools without clicking, and we will definitely need to test this again before launch, so I would recommend you to looking into this.

Yes. I'm good to test.


Train lf accuracy higher than execution accuracy

Hi,
When running the script, it is surprised to see that after several iterations (<3), the training logical form accuracy becomes higher than the training execution accuracy, which confuses me a lot.
May I ask what is the reason behind it? I am confused for several days and could not figure it out. Thank you for any help in advance!

Hi @vincentlux
This might happen due to instability of DBEngine class which activates except in following code.
https://github.com/naver/sqlova/blob/7a8636d6d0c9a46b32b6d00eccaafeea1aab5e3b/sqlova/utils/utils_wikisql.py#L1646-L1670
DBEngine class is modified from SQLNet code which is based on original WikiSQL evaluation code (I guess).
I'll check whether this still happens when DBEngine from WikiSQL evaluation code is employed.
Thanks!
Wonseok

Hi Wonseok,
Thanks for the quick response! This is interesting and I will also check with using the option you suggested. Thanks!

@vincentlux I found the problem. It is caused by the wrong ordering of predicted where-column.
For example, when the ground truth is
{'sel': 1, 'conds': [[6, 0, 'at&t center 18,797'], [0, 2, 57]], 'agg': 0}
the previous prediction in train function could be
{'agg': 0, 'sel': 1, 'conds': [[0, 0, 'at&t center 18,797'], [6, 2, '57']]}
During the test, there is no problem as this issue is caused by the use of ground-truth during the training which makes the debugging difficult.
I have updated the code. Please let me know if the problem still happens.
Wonseok


Route 53 provider gets confused by private zones

I have two hosted zones in Route 53 for the same domain, one is public and one is private. lego is trying to set the Route53 verification on the wrong zone so it fails to verify.

Hmm, so when we do the explicit lookup, we are getting 2 returned, but the private appears first? I wonder if we can pass a filter to Amazon to only return public, or if we just need to check how many are returned and if they are public.

From what I can determine from the API, there's no filter. You have to post
filter on .Config.PrivateZone
On Apr 16 2016, at 9:10 pm, LukeH<EMAIL_ADDRESS>wrote:

Hmm, so when we do the explicit lookup, we are getting 2 returned, but the
private appears first? I wonder if we can pass a filter to Amazon to only
return public, or if we just need to check how many are returned and if they
are public.

—
You are receiving this because you authored the thread.
Reply to this email directly or [view it on GitHub](https://github.com/xenolf/
lego/issues/192#issuecomment-210792319)![](https://github.com/notifications/be
acon/AAH5wNciy87jL84djpZRYJd4R_o5Rs2Iks5p4MOygaJpZM4II4pH.gif)

Route 53 is tricky in that regard as it also allows multiple public zones with the same name. In that case we currently may end up provisioning the authorization record to a zone that is not "active" (as in the domain registrar's name server doesn't point to it).
How about letting users pass the Hosted Zone ID when requesting a certificate using Route 53?

Ahh, allowing ID is a sure fire way for success. Interesting point that there could be multiple identically named zones. How much extra work if we wanted to establish the correct zone though. (also, heads up, not currently working on this)


some additions and corrections

Thanks for the PR!
To be honest, I've forgotten that I've even pushed this to a public repo, but I am planning into getting it in to the next Debian release so it's nice to see that someone else cares as well! Merging request...


Find() does not use TableName() when used as interface

First of all, I am aware of #891, #887 etc.
I have defined many structs for each table, all of those implement an interface.
I have to use TableName() function for xorm to get correct name. This works fine with e.g. Get(), however Find() says Table not found.
type DBType interface {
	PrimaryKey() string
	TableName() string
	Slice() []DBType
}

type user struct {
   Id   int64  `json:"id"`
   Name string `json:"name"`
}

func (*user) TableName() string {
	return "mydifferentusertablename"
}
func (*user) PrimaryKey() string {
	return "id"
}
func (*user) Slice() []DBType {
	return []DBType{&user{}}
}

var record = DBType{&user{}}

slice := record.Slice()

Get() works:
_, err = engine.Get(slice[0])
if err != nil {
	log.Print(err)
}

Find() does not:
err = engine.Find(slice)
if err != nil {
	log.Print(err)
}

Regular struct (not via interface) works:
data := make([]user, 0)
err = engine.Find(data)
if err != nil {
	log.Print(err)
}

Reasons why I need this, can be found on SO, I will not repeat those here.

Currently You should use &slice as a parameter of Find.

Did you mean?
slice := record.Slice()
err = engine.Find(&slice)
...

If so, it does not work. Already tried that before creating this issue.


Mt classes

Added subjects and classes as tags to filter by from the UCSB API. Make sure to input the API key in explore's API_KEY variable in slack, this isn't supposed to be public so I didn't push to github, will need to make issue for making it a private variable.

Hey Meron there is a conflict before we can merge.


Make Line-Width Less on Hover ( Mobile Screen)

When Menu items are hovered on Small Screens or Tablets, the line width looks bad.
Please decrease the line width, say below Tracks in snapshot

I would like to work on this. Also I suggest for mobile version all borders should be visible not just bottom because they are visible only when these links are clicked. May be like this

and border bottom only will look like this

@poush @aayusharora Yes, for the mobile version could we go with something bigger instead of the underline? Actually, before we had a gray background for this feature, but it is not there somehow.
It would be great to get the gray background back again.


Is the existing code sufficient to handle the task?

Hello, I noticed from the readme that you haven't uploaded the complete code yet. I would like to ask, as I already have a complete 3D scene graph as well as some processed sparse point clouds for prompts, whether the existing code is sufficient for me to complete the 3DSAM task?

Also, I have another small question: Are there any methods to obtain 3D masks without interactive clicking? As I mentioned earlier, I have already obtained some prompt points of the object, and I want to know if it is possible to get a 3D mask without manually clicking on the GUI?


Stream announcements are iffy at best

Semi fixed by https://github.com/Nincodedo/Ninbot/commit/d29445a9ede3d4d2553399daebb867695a9eda8a


Removing inline Table.ToNavigationTable definition

Updating to follow the TripPin tutorial's part 5 which links to helper function code instead of embedding it inline in the tutorial page.
(This eases maintainability, potentially reducing the number of places that need to be updated if a future edit is made to one of these helper functions.)

@ptyx507x - Could you review this PR?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@ShannonLeavitt we need an engineer to review these code changes. Could you please assign this to @mattmasson ?

#assign: @mattmasson
@mattmasson - please review and approve if you'd like these changes merged.

#request-review: @mattmasson

#assign-reviewer: @mattmasson

#sign-off


Can we have animation when calling showHeader ?

i would like show header back how they went up, right now its coming as static one when calling show header

Adding
Animated.timing(positionY,{
toValue:0,useNativeDriver:true,
}).start()
in showheader functions solves this problem


Pin packages with Niv

Resolves #1

Thank you,
I cloned it down fresh and the PR works on my laptop.
There might be some edge cases it always hard to know but im going to merge it because its a lot better than what is currently present.


Eureka dashboard NEP if host contain underscore

In EurekaController
private void populateNavbar(HttpServletRequest request, Map<String, Object> model) {
		Map<String, String> replicas = new LinkedHashMap<>();
		List<PeerEurekaNode> list = getServerContext().getPeerEurekaNodes().getPeerNodesView();
		for (PeerEurekaNode node : list) {
			try {
                               // Service URL here may contain underscore, then uri.getHost() return NULL
				URI uri = new URI(node.getServiceUrl());
				String href = scrubBasicAuth(node.getServiceUrl());
				replicas.put(uri.getHost(), href);
			}
			catch (Exception ex) {
				// ignore?
			}
		}
		model.put("replicas", replicas.entrySet());
	}

I know the underscore in host is illegal, but this is very common in docker env.

This may solve these problems once for all

There are many places in spring-cloud-netflix where valid URI's are needed. Our recommendation is to not have underscores in hostnames. We won't be implementing anything like you linked to above.


Change EpicsAdapter constructor args to match tickit changes

The db_file parameter has been changed to an optional parameter.

Wait until a new tickit release is made before merging.


feat: Add a speak(string id, string text) method to TTSQueue that cal…

…ls the Dart API to speak if no speak is enqueued, otherwise enqueue it for after the utterance

@kevmo314 Doesn't seem like it's able to auto merge. Not sure if you wanna over ride it or if changes need to be made to the dart code?


How do I install the C# extension on linux?

The command on the app page doesn't work.

@NewGuy11 If you are asking how to install the extension -- extensions in VS Code from the extensions panel -- click the square icon on the left side bar (see here for more info). Then search for 'C#' in the marketplace.

@gregg-miskelly Thanks! Turns out I already had it installed, just didn't know where to look.


Fun loading

What about bringing more fun while users waiting for page analyzing, so instead of showing boring messages 'Launching Chrome', Waiting..., we can add smth like parrot.live
[

bad idea...


passing update_attributes options missing in 2.4.5

I thought passing options to update_attributes was supported in the past (around 2.2.x i think).  I see support for this on github, but it is missing from 2.4.5.  was this removed for some reason, or am i mistaken as to when this became supported?

I was just about to post the same issue.
user.update_attributes(attributes, as: :admin)

Gives me
wrong number of arguments (2 for 1)
        @ ~/.rvm/gems/ruby-1.9.3-p0/gems/mongoid-2.4.5/lib/mongoid/persistence.rb:119:in `update_attributes'

Yeah it's in master, but somehow didn't get pulled back to 2.4.0-stable.


Fixed gdb server not being accessible via localhost

When --allow-remote was not set, GDBServer was setting the socket's host to "localhost" only after it was inited. This bug was introduced in #455. Aside from being a problem for users, this caused gdb_test.py to fail. (Not sure why #455 still passed in CI.)

/morph test


Add getting started section to README

README update
Please add a getting started section to the README so the folks know how to start this project.

Added Getting Started section to README


fix(helm): Retry Conflict error for createResource, deleteResource

kubernetes might at any time throw 409 Conflict Error codes. Clients
are supposed to retry when this happens. As an example, see
kubernetes/issues/67761 where such an issues might happen when the
cluster manipulates a projects's ResourceQuotas.
Catch such Conflict Errors on createResource and deleteResource and
retry before giving up. Due to the more complex logic and focus on
kubernetes/issues/67761, this patch purposefully omits possibly
needed changes to updateResource and instead defers them to another
patch if required in the future.
Closes issue #9710
Signed-off-by: Andreas Karis<EMAIL_ADDRESS>
What this PR does / why we need it:
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[x] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

You can use fixes #9710 to associate  your issue

Does the repository have some documentation for how to write and run unit tests? I'd like to cover this in a test :-)

Does the repository have some documentation for how to write and run unit tests?

https://helm.sh/docs/community/developers/
https://golang.org/pkg/testing/

Hey there! I noticed that you mentioned to several other projects in the issue that came to the same conclusion. Because of that I’m curious if this is code you wrote yourself or if it’s been ripped from another program. If the latter we may need to ensure we do some legal due diligence.

Hey there! I noticed that you mentioned several other projects that came to the same conclusion. Because of that I’m curious if this is code you wrote yourself or if it’s been ripped from another program. If the latter we may need to ensure we do some legal due diligence.

Hey!
For better or for worse ( ;-) ) it's code that I came up with myself.
Andreas

Hi,
Is there anything else that needs to be done to move this forward? Our customers are being affected by the lack of retries in helm (https://bugzilla.redhat.com/show_bug.cgi?id=1934604) and I'd like to make progress on this. I am happy to change / improve this pull request.
@cndoit18
Thanks!

Andreas

Hi,
Is there anything else that needs to be done to move this forward? Our customers are being affected by the lack of retries in helm (https://bugzilla.redhat.com/show_bug.cgi?id=1934604) and I'd like to make progress on this. I am happy to change / improve this pull request.
@cndoit18
Thanks!

Andreas

I do not have the authority, you can ask the community

Sorry, my bad, I thought you were a member of the project :-)  Thanks for reviewing this, then.
@bacongobbler What are the next steps? :-)

Sorry, my bad, I thought you were a member of the project :-) Thanks for reviewing this, then.
@bacongobbler What are the next steps? :-)

You will need to get approvals from two members, which is expected to be a long wait.

I will bring it up on the community call today to bring some attention

As discussed in the dev call, it would be great to understand

Who is impacted by this bug
How to test/reproduce the issue
What is the severity of this issue (blocker, workaround available, totally breaks Helm usage, etc)

As far as I can tell, this particular Kubernetes issue has been open since 2018. This is the first time it's been brought to the attention of the maintainers since it was opened, so it's unclear how many people are impacted by this issue and whether it needs to be expedited to Helm 3.6.1, or if it can be triaged for Helm 3.7.0 (to be released Sept 9th as per HIP 2).
In addition, if you can provide a way where reviewers can reproduce the issue and test the solution against the bug, that would be helpful as well.
Thanks!

This is the bugzilla issue to provide some context on this: https://bugzilla.redhat.com/show_bug.cgi?id=1934604. The customer reporting will like to stay anonymous but basically is a global semiconductor manufacturer. I was easily able to recreate using gitlab chart (gitlab repo: https://charts.gitlab.io/ ) in OpenShift 4.6 and 4.7 with the following script:
`cat test_gitlab.sh
#!/usr/bin/env bash
set -e
while true; do
helm install --debug gitlab gitlab/gitlab --timeout 600s --set global.hosts.domain=example.com --set global.hosts.externalIP=<IP_ADDRESS> --set<EMAIL_ADDRESS>sleep 5
helm uninstall gitlab
done`
To set the test I run this:
`#!/usr/bin/env bash
set -e
oc new-project gitlab
oc apply -f quota.yaml
oc apply -f cpu_limit.yaml
oc adm policy add-scc-to-user privileged -z default
oc adm policy add-scc-to-user privileged -z gitlab-shared-secrets`
Here is the quota resource:
bash-5.1$ cat quota.yaml  apiVersion: v1 kind: ResourceQuota metadata:   name: quota spec:   hard:     configmaps: "62"     limits.cpu: "170"     limits.memory: 260Gi     openshift.io/imagestreams: "0"     persistentvolumeclaims: "50"     pods: "100"     replicationcontrollers: "50"     requests.cpu: "71"     requests.memory: 205Gi     requests.storage: 350Gi     limits.cpu: "71"     limits.memory: 205Gi     requests.storage: 350Gi     resourcequotas: "1"     secrets: "512"     services: "70"     services.nodeports: "5"
Here is the limits resource:
`bash-5.1$ cat cpu_limit.yaml
apiVersion: v1
kind: LimitRange
metadata:
name: cpu-limit-range
spec:
limits:

default:
memory: 256Mi
cpu: 125m
defaultRequest:
cpu: 125m
memory: 128Mi
type: Container`

Hi,
Apart from this and the master branch having diverged, how does the helm project deal with upstream contributions?
Because this pull request has been open for 3 months now. I'm open to discussing the fix, I'm open to modifying it, I'm even open to dropping it (though I would have a lot of valid arguments against dropping it).
Instead, this pull request has been kind of ignored for the last 3 months (the same goes for any other contribution which I made around that time). In other Open Source projects, I am used to seeing some fruitful discussion around any outside contribution and some welcoming attitude towards people who are willing to contribute to the project.
My hurt pride aside (I'm kidding, really), I am just wondering about the workflow and how we'd ever fix https://bugzilla.redhat.com/show_bug.cgi?id=1934604 or any other issue  or part that might be improved that one found in helm.
@bacongobbler Is the (current version) of the helm project on the backburner?

Andreas

I would also love to see some sort of reaction/discussion on this PR since I'm heavily affected by the issue it addresses. Thanks for your time.

Gerd

Is there any change this PR gets merged soon?

Any chance this will be merged soon?

We are facing the similar issue when we upgraded the kube to 1.20.15 and moved to Kube services to Binary. It would be great if get some update on merging this PR soon?

Is there any chance this will be merged? We are using OpenShift 4.10 and we are greatly impacted by this, a lot of our services are deployed by using helm and we experience this issue a lot.
Is there at least some sensible work around for the time being?

We are yet another team that is looking forward to this PR being merged!

Hey @mattfarina , Milestone 3.11.0 was closed and this PR from 2021 is still open, is it going to be merged for Milestone 3.12.0 by May 10, 2023?
Thanks

Hi, I got the same issue.
Error: release cm-consumer failed, and has been uninstalled due to atomic being set: Operation cannot be fulfilled on resourcequotas "object-counts": the object has been modified; please apply your changes to the latest version and try again
helm.go:84: [debug] Operation cannot be fulfilled on resourcequotas "object-counts": the object has been modified; please apply your changes to the latest version and try again

Is there a client side fix planned?

We see this problem very often in many different deployments. Is it planned to be merged? Thanks

@mattfarina any reason why this keeps getting pushed to next release and isn't merging? This is an issue we're facing since at least 3 years, and we are using forked helm-idk with this PR as patch applied to it since almost 2-3 years and it is working perfectly fine for us. But, due to nature of maintaining fork, it is becoming very cumbersome.
In fact, due to delay in merge, this PR is actually outdated and needs conflict resolution, which I am sure we can get it done, as it is simple enough, provided there is no issue with actual logic or test.

I rebased it again and I also sent an email to Matt. With that said, I'm totally open to changes (especially to the unit tests), so please let me know what you think

Hi. Please merge this PR

Note, the force push was used to kick-off CI and did not change any code (as can be seen in the diff provided by GitHub).


Support for AMS 0.9x

Hi @adamcrown, thank you for open sourcing this! I came here via the issue on AMS.. wondering if adding support for AMS 0.9x is something you'd consider? Or is it something you'd expect to work out of the box?

Hi @oyeanuj. I'd certainly be happy to take a PR as long as we don't break support for the later versions.
I wouldn't mind writing myself either, but at this point I can't make any promises as to when that would happen.

+1! I am seeing that it currently does not suport


680 Fix change event reference for recent submission

Fixes #680
I've updated the event change references to valid ones so the onPaginationChange(event) functions properly. Tested my additions in my local environment.
NOTE: The following error was reported before my changes but seems rather strange that this particular error is still present in my console given I've seen the pattern I used elsewhere in the code base without such an error. It's unclear to me why paginationConfig properties throw an error when attempting to be set. Would be great to get some insight on this:
core.js:4002 ERROR TypeError: Cannot read property 'currentPage' of undefined     at CollectionPageComponent.push../src/app/+collection-page/collection-page.component.ts.CollectionPageComponent.onPaginationChange (collection-page.component.ts:112)     at SafeSubscriber._next (collection-page.component.ts:102)     at SafeSubscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.SafeSubscriber.__tryOrUnsub (Subscriber.js:194)     at SafeSubscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.SafeSubscriber.next (Subscriber.js:132)     at Subscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber._next (Subscriber.js:76)     at Subscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber.next (Subscriber.js:53)     at TakeSubscriber.push../node_modules/rxjs/_esm5/internal/operators/take.js.TakeSubscriber._next (take.js:40)     at TakeSubscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber.next (Subscriber.js:53)     at BehaviorSubject.push../node_modules/rxjs/_esm5/internal/BehaviorSubject.js.BehaviorSubject._subscribe (BehaviorSubject.js:22)     at BehaviorSubject.push../node_modules/rxjs/_esm5/internal/Observable.js.Observable._trySubscribe (Observable.js:43)

The issue here is this line. It passes the route params as an onPaginationChange event, but that's no longer valid. The structure of those events has changed. That change is the reason for this PR: it fixes the logic inside onPaginationChange.
If you create an interface for onPaginationChange events (they have a pagination: PaginationComponentOptions and a sort: SortOptions property), and add that as a type to the event param for onPaginationChange the compiler will point out these kinds of errors.
For now, that call using the route params can just be removed. The pagination component itself will parse the route for now. The ticket Tim mentioned above will ensure it moves to a more suitable location later.

The issue here is this line. It passes the route params as an onPaginationChange event, but that's no longer valid. The structure of those events has changed. That change is the reason for this PR: it fixes the logic inside onPaginationChange.
If you create an interface for onPaginationChange events (they have a pagination: PaginationComponentOptions and a sort: SortOptions property), and add that as a type to the event param for onPaginationChange the compiler will point out these kinds of errors.
For now, that call using the route params can just be removed. The pagination component itself will parse the route for now. The ticket Tim mentioned above will ensure it moves to a more suitable location later.

@tdonohue Updated code to reflect on @artlowel 's input. Error is no longer presents and I have tested functionality in my local environment.

@tdonohue Updated code to reflect on @artlowel 's input. Error is no longer presents and I have tested functionality in my local environment.

@AndrewZWood : It looks like you need to rebase on the latest main code as there are merge conflicts now.  Keep in mind that we recently merged an update to Angular 10, which also changed some of the lint settings...so you may need to make minor formatting changes too after rebasing (if yarn lint throws errors).

@AndrewZWood : It looks like you need to rebase on the latest main code as there are merge conflicts now.  Keep in mind that we recently merged an update to Angular 10, which also changed some of the lint settings...so you may need to make minor formatting changes too after rebasing (if yarn lint throws errors).

@tdonohue Sorry about that....rebase and checked against the newer lint settings.

@tdonohue Sorry about that....rebase and checked against the newer lint settings.

Thanks @AndrewZWood ! Looks good now.  Merging

Thanks @AndrewZWood ! Looks good now.  Merging


internal links dont work in chrome app

first of all, love this tool. It works great. especially love the much needed side-by-side and synced scrolling.
the big thing that doesnt work for me is that internal links dont work in the preview.
For example, in one section I can put:
then in a different place in my doc i can put a link to it using: [my section](#mySection)
this works fine in GitHub or NPM but not in the preview pane.
thanks,
Yoav

Hey, thanks for bringing this to my attention.
The technical explanation for why it didn't work is that the preview panel is placed in a sandboxed iframe, and links are handled differently within those.
So I've made sure links to both external URLs and internal URL fragments work.
You can now link to a specific part of your Markdown document using such fragments, e.g. clicking [Chapter 2](#chapter-2) will jump to
Chapter 2
.
However, you can only use the id attribute for that. I haven't bothered implementing the same behavior with name on anchors, since that attribute is obsolete in HTML5. If your use-case really depends on , and you can't use the id attribute instead, please tell me, and I'll take some time to add that.
As usual with Chrome applications updates, it may take some time for you to get the latest version (usually a matter of hours). Once you do, feel free to share any feedback here.
Cheers!

works like a charm! thanks :)


Choose whether circle area or circle diameter should be proportional to the number of individuals

Add a button allowing users to choose whether the diameter or the area of the haplotype circles should be proportional to the number of individuals harbouring this haplotype.

Actually, maybe we only need to option using the circle area (as it makes the graph looks much better, more balanced than we using the circle diameter).


Added support for dotnet nuget push inline with Tooling v1.0

Added DotNetCoreNugetPush Alias for dotnet nuget push

Added unit tests

For more information see #1533

@JonCubed,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@JonCubed I've rebased this PR so it's inline with latest branch and will review for merge as soonish

@devlead thanks
On Thu., 27 Apr. 2017, 01:09 Mattias Karlsson<EMAIL_ADDRESS>wrote:

@JonCubed https://github.com/JonCubed I've rebased this PR so it's
inline with latest branch and will review for merge as soonish
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cake-build/cake/pull/1581#issuecomment-297439963, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACbHvBRfutXHNBEJBg_pz2XbCKbNaZkHks5rz14ogaJpZM4NIH01
.

@JonCubed  your changes have been merged, thanks for your contribution 👍


[Feature Request]: Add @pushElseIf and @pushElse blade directives

Feature Description
Feature Description
Add @pushElseIf and @pushElse blade directives in v10.32.1
laravel/framework#48990

fixed in 1.24.2


docs(readme): Simplify readme

Add notes specific to rustup as it is soon to be the preferred Rust
toolchain install method.

Thanks!


⚠ Text Filter API Endpoint has degraded performance

In 3c6167d, Text Filter API Endpoint (http://textfilter.roblox.com/) experienced degraded performance:

HTTP code: 200
Response time: 1281 ms

Resolved: Text Filter API Endpoint performance has improved in df0b3ef.


invite link preview on non-mobile and mobile devices

Describe the bug
Invite link should have a notice to open on mobile phone when opened on desktop
If should either redirect to a simple page that says to open the link on moile
Or have some other way
Currently it leads to the joinseeds website and people get stuck there and don't know what to do
We've had a few people open this link on deskrop and getting confused.
The link preview also goes to joinseeds.com, it should probably go to the app store?!
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Current behavior
A clear and concise description of what you are seeing.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Android, iOS or Both
App Version [e.g. 22]

Additional context
Add any other context about the problem here.

Looks like a website issue/enhancement, not a bug with the app. Likely to come up in the Passport for web / LW for mobile transition. Closing.


Rebase main new logic

@apoorvsingal I have tried to merge the new additions in main branch to the staging branch and created a new branch for the changes.
Please test this and if it is working fine we can first merge it to staging and than merge staging to main.


enhancement(terraform): Configurable path prefix to lookup code

Terraform will now by default look at the default path. This also allows this module to be referenced as follows:
module "cai-export" {
  source = "github.com/GoogleCloudPlatform/migrate-from-service-account-keys//terraform

  ...
}

I need to test a bit more before I can verify everything works, so I'll add this to the README.md in a separate PR.

I'm taking a look at this today, will get back to you shortly


chore(master): release 0.19.0

:robot: I have created a release beep boop
0.19.0 (2024-03-18)
Features

subscription pods improvements (#297) (ba89596)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/fairDataSociety/fdp-storage/releases/tag/v0.19.0 :sunflower:


added a DATE type field with MAXDATE and MINDATE options

parses a date to verify it's correct.
maxdate and mindate can be dates or keyword 'today'
to use:
<input type="date"> or <input type="date" maxdate="Jan 5, 2015" mindate="1980-01-01>

How does this align to native browser date field validation?

Closing PRs for old code.


[33] Produce mean gender differences with subject specific terminology removed

Closes #33.
BIT has defined two groups of subject specific words in the GCSE descriptions, 'crucial' and 'optional'.
This PR adds functionality to produce mean gender difference charts with the above words excluded:

Adds subject specific word lists to inputs (inputs/data/subject_specific_terminology/)
Adds getter for subject specific words lists (getters/subject_terminology.py)
Updates pipeline/glove_differences/make_mean_differences.py to produce mean gender difference calculations with subject specific words removed
Updates getters/mean_gender_differences.py to be able to load mean gender difference csv files in the new format
Updates analysis/save_charts_data.py to produce charts with subject specific words removed
Replace old charts with new charts

Checklist:

[x] I have refactored my code out from notebooks/
[x] I have checked the code runs
[x] I have tested the code
[x] I have run pre-commit and addressed any issues not automatically fixed
[x] I have merged any new changes from dev
[x] I have documented the code

[x] Major functions have docstrings
[x] Appropriate information has been added to READMEs

[x] I have explained the feature in this PR or (better) in output/reports/
[x] I have requested a code review

Looks good. It might be good to add/update a readme explaining the difference between crucial, optional and no word removal.

Thanks for the review. I've made your suggested changes and added to the readme.


does it use magnet links?

Hi!
So far there is no support for magnet links, although - it can easily be implemented.
Meanwhile, you can convert you magnet links to "physic" torrent files using sites like this:
https://magnet2torrent.com/
Good luck!


TPC-H Query 17

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-11530
Subquery in (WHERE) expression support is missing.
{{Error: NotImplemented("Unsupported ast node Subquery(Query { with: None, body: Select(Select { distinct: false, top: None, projection: [UnnamedExpr(BinaryOp { left: Value(Number("0.2")), op: Multiply, right: Function(Function { name: ObjectName([Ident { value: "avg", quote_style: None }]), args: [Unnamed(Identifier(Ident { value: "l_quantity", quote_style: None }))], over: None, distinct: false }) })], from: [TableWithJoins { relation: Table { name: ObjectName([Ident { value: "lineitem", quote_style: None }]), alias: None, args: [], with_hints: [] }, joins: [] }], selection: Some(BinaryOp { left: Identifier(Ident { value: "l_partkey", quote_style: None }), op: Eq, right: Identifier(Ident { value: "p_partkey", quote_style: None }) }), group_by: [], having: None }), order_by: [], limit: None, offset: None, fetch: None }) in sqltorel")}}

Latest failure:
Error: NotImplemented("Physical plan does not support logical expression (Subquery: Projection: Float64(0.2) * #AVG(lineitem.l_quantity)\n  Aggregate: groupBy=[[]], aggr=[[AVG(#lineitem.l_quantity)]]\n    Filter: #lineitem.l_partkey = #part.p_partkey\n      TableScan: lineitem projection=None)")
t

Resolved in this branch which I am getting ready for PR.
+-------------------+
| avg_yearly        |
+-------------------+
|<PHONE_NUMBER>857141 |
+-------------------+
Query 17 iteration 2 took 91715.6 ms and returned 1 rows
Query 17 avg time: 92059.84 ms


Global Cases Improvement suggestion

I'm submitting a ...

[ ] bug report
[x] feature request
[ ] support request => Please do not submit support request here, see note at the top of this template.

Do you want to request a feature or report a bug?

As a user, I want to go to the corresponding source/ consulate page for further information.

As a user, I also want the information from the airline companies of the special pandemic arrangement, so that I can find travel-related information easily.

What is the expected behaviour?

Each chip has a clickable link to the corresponding page.
New tab displaying information about airline arrangement

What is the motivation/use case for changing the behaviour?
Small change to chip component with no library change.
A new tab in Global Case tab list
I can work on it if you guys think these are good to have feature. :)

Thanks for the suggestions!
Our website is expected to support (1), it would include the data source/consulate link, just pending some little code work and data input.
https://docs.google.com/spreadsheets/u/1/d/e/2PACX-1vQOnfZtGysW5qVe9FferSvhSODKa9ASH7SeqCGAGJSz8ZV7POm3kzFqfkbVAgryHKdj9WwLKXJai332/pub?gid=0
For (2), in my opinion, I think a user would go to the airline website directly if he/she has already got the ticket, so it may be a little bit lower priority comparing to others 🙏

The newly merged pr ( #161 ) covered my suggestion. I will close this issue.


adapt definition of GO:0007342 so it fits not only mammals

Fusion of sperm to egg plasma membranes occurs in many taxons, in plants, plasmodium (see e.g. PubMed=21209845), mammalia, etc, and it would be good to have an appropriate GO term for this.
Would it be possible to simplify the definition of the term "GO:0007342 fusion of sperm to egg plasma membrane" so it can be used for a wide range of organisms?
The new definition might simply read "The binding and fusion of a sperm with the plasma membrane of the oocyte. "
The present version applies only to mammals - a pity!
Many thanks in advance, Ursula

Please note, the simplified definition should then be directly linked to  "GO:0009566 fertilization", since plants have "GO:0009567 double fertilization forming a zygote and endosperm" vs " GO:0007338 single fertilization" for mammals.

Please note, the simplified definition should then be directly linked to  "GO:0009566 fertilization", since plants have "GO:0009567 double fertilization forming a zygote and endosperm" vs " GO:0007338 single fertilization" for mammals.

In plants, is the pollen considered sperm? @tberardini @lreiser ?
However, the definition does need to be changed since it doesn't account for ameboid sperm in nematodes.

yes, pollen is considered sperm (see https://www.ncbi.nlm.nih.gov/pubmed/?term=arabidopsis+sperm)
Generally speaking, when a sexual species has one small, motile gamete, and a large, non-motile gamete, people use the terms sperm and egg/ovule.

"GO:0007342 fusion of sperm to egg plasma membrane"  is a child of 'single fertilization'.
http://amigo.geneontology.org/amigo/term/GO:0007342
I think if a term/s that is similar to this one that is desired for plants with double fertilization (either forming two zygotes or forming a zygote and endosperm), specific terms that describe those processes should be created instead of modifying the existing term definition and term relationships which are already quite clear.
The existing definition of GO:0007342 fusion of sperm to egg plasma membrane"  could be modified to include the phrase, "...in the process of single fertilization" to make that more explicit.

Getting the hierarchy right is definitely an issue.

I'd be perfectly fine with a new term that fits plants (fusion of sperm to egg plasma membrane during double fertilization),
plus a change of the current definition of "fusion of sperm to egg plasma membrane during single fertilization", so that it fits also non-mammalian species.
please note, there is an orphan (unused) GO term (http://www.ebi.ac.uk/QuickGO-Old/GTerm?id=GO:0009677#term=info) that maybe should be obsoleted - I found double fertilization only in the context of plants, but that may simply be due to my ignorance

It looks to me like GO:0009677 is a legitimate term:
PMID:25667083
If you would like the additional term for double-fertilization, could one of you supply an appropriate definition and parentage?

Thanks for PMID:25667083, I retract my suggestion to obsolete http://www.ebi.ac.uk/QuickGO-Old/GTerm?id=GO:0009677#term=info

I'd be glad about a new term equivalent to "GO:0007342 fusion of sperm to egg plasma membrane", but unlike GO:0007342 = a child of 'single fertilization', the new term should be a child of GO:0009567 'double fertilization forming a zygote and endosperm'.

Proposal for the definition: "The binding and fusion of a sperm with the plasma membrane of the oocyte in the process of double fertilization. "

Revised definition proposal:  "The binding and fusion of a sperm with the plasma membrane of the egg cell in the process of double fertilization. "
Rabbit hole:  There are several cell fusion events in double fertilization forming a zygote and endosperm: the fusion of one sperm with the egg cell and the fusion of another sperm with the central cell.   "...the central cell likely promotes its own fertilization by a yet unknown signaling mechanism."  There's a mutant where the second fertilization event  (central cell) doesn't occur.
Also: "Recently, even a third cell fusion event was reported in Arabidopsis[88], occurring between the fertilized central cell and the persisting synergid cell, thereby preventing the attraction of multiple pollen tubes"
!!!
http://www.sciencedirect.com/science/article/pii/S0960982215015584
PMID:26859271

Coming in a little late...
Regarding pollen. Pollen is synonymous with male gametophyte. In higher plants this represents the very reduce haploid stage. Pollen grains are more than sperm cells, the contain vegetative nuclei that are important during pollen tube germination and growth. Pollen are multicellular. Therefore pollen!=sperm.

So do we want an additional term, and if so what should it be? I will modify the current term to be restricted to single fertilization and will tweak the def to include sperm without a flagellum. But you are far more qualified to come up with the terms for plants.

Hello,
Not that I know anything about this but it seems like in this case the same term may me used to represent analogous structures rather than homologous structures. To avoid TPV two terms seem more appropriate.
Pascale

thanks, so could you please create a separate term for "The binding and fusion of a sperm with the plasma membrane of the egg cell in the process of double fertilization." ?
Target of this annotation: the fusogen HAP2/GCS1  (see e.g. https://www.ncbi.nlm.nih.gov/pubmed/28137780 and other recent papers about this protein: https://www.ncbi.nlm.nih.gov/pubmed/?term=hap2+gcs1).
.

We currently have two terms to describe double fertilization. Do we need terms for both?
I have modified the name and definition of the existing term.

@ukemi weren't there two instances. One double fertilization that produces a 2n embryo and endosperm (3n, GO:0009567) and one that produces two 2n structures (embryo and rudimentary embryo, GO:0009677). So not the same.

There are two classes. So do I need to make both:
'fusion of sperm to egg plasma membrane involved in double fertilization forming a zygote and endosperm'
and
'fusion of sperm to egg plasma membrane involved in double fertilization forming two zygotes'
?

At the moment I think one term could suffice and be true for both types of double fertilization as they both refer to the fusion of a sperm cell with an 'egg cell' membrane.
In other words- this term would be  a part of both types of double fertilization.
But not all types of double fertilization would have  sperm- central cell fusion or sperm-synergid fusion. should those terms need to be added.

We can't have the one term be part of both of the types because making the part_of relationship between two terms means that in every instance of the fusion, it would be part of an instance of the process, in this case every fusion would be part of both processes.

OK so then we need to have the two new terms in order to avoid violating the rules....;)

OK. Then I will add both terms and sort out existing terms to fit the new structure. Let me know if you spot anything amiss.


General feedback

Copypasta'd from FCC forms.  Please note that the comments are very stream of consciousness and were typed in as I was working through the problems, any frustrations expressed are not expressed at any individual/person.  I went through to do some rough proofreading and editing as needed, but if something doesn't make sense here feel free to reach out.

Hey Quincy, @bonham000, and @no-stack-dub-sack!  Thanks a TON for putting these together.
WARNING: LONG POST INCOMING!!!
Some background:
I started learning React last Friday (the 16th), after I got through most of the Intermediate dev projects, and wanted to get a head start on the Data Viz section.  Most of the online tutorial out there are pretty newbie non-friendly.  The best ones I found were
The New Boston, and Stack Overflow posts.  Even the Facebook Tic Tac Toe tutorial, and explanations were not the best in my experience because most of them left me with too many questions unanswered.
On Monday someone from our local FCC group posted that these were up and I've been working on them on and off through the week, and I can say with certainty that these are the most newbie friendly tutorials/walkthroughs of React that I've found.
I figured I would chime in an provide a set of users stories for each problem letting you know where pitfalls/pain points were in understanding for a relative newbie to React.
I'll likely also do the Redux tutorials here at some point, and provide feedback on those too.
I'm assuming this is qualified under 'general feedback', but will open up issues if need be.
Thanks again for all your hard work! :slight_smile:
TL;DR(AKA Top 3 issues that frustrated me as a Newbie):

Lessons 25, 26, and 27 covering 'this' are REALLY confusing/frustrating.
How to render components and pass properties via custom HTML tags and attributes respectively could be explained way better.
Parent/Child components were confusing for the longest time.

Trying and reviewing React Alpha Tutorials
##Lessons

Lesson 1: Create a simple JSX element
    // No major issues with Lesson 1

Lesson 2: Create a simple JSX element
// Issues with Lesson 2:

The word component is used here at the end of
the Instructions section, but I don't really have a good context for what 'component' means, nor are any questions resolved with a "we will cover components in future lessons

Lesson 3:  Add Comments in JSX
// No issues with Lesson 3

Lesson 4: Render HTML Elements to the DOM
// Issues with lesson 4

There is still no understanding of what a component is or could be, I understand not want to overwhelm students, but bringing up terminology that someone is uncertain with multiple times stops me and leaves me asking questions before I press on

The sentence: "select the target DOM node with the getElementById() method on the document object" is confusing.  Just write document.getElementById()

Do this because:
A.  I'm thinking that I'm already passing things to the document object with ReactDOM() (Voice in my head as a student: It stands for Document Object Model therefore I must be doing something on the document object)
and
B: Syntax is easier to repeat correct the first time, when it is seen correctly ( e.g. Do as I do ).

Lesson 5: Define an HTML Class in JSX
// No issues with lesson 5

Lesson 6: Self closing JSX tags
// No issues with lesson 6

Lesson 7: Create a stateless functional component
// No issues with lesson 7

Lesson 8: Create a React component
// Issues with Lesson 8

As a student questions immediately come to mind:
A.  Why are there 2 ways to create components? Is one better than the other?
B.  What is ES6? Why does it matter?
C.  Why is there a render() here? Can't I just use return ( /* code here */)

Lesson 9: Create a component with Composition
// Questions about Lesson 9:

The following sentence seems imprecise:
"You can use one or more components in the render() method of another one."
the 'another one' seems ambiguous in that 'another one' in this instance could refer to another component, or another render method.

Ok, COMPONENT COMPOSITION WAS CONFUSING FOR THE LONGEST TIME.  It was confusing because no one really STRONGLY made the distinction between a Component, and calling a component.  This is why in JS there is a distinction between a function, and a function call, because both refer to VERY specific operations/uses.  There is a small 2 sentence paragraph about this in the intro, but it needs to be bolded that REACT ALLOWS YOU TO CREATE CUSTOM HTML TAGS AND IT'S HOW YOU UTILIZE/CALL COMPONENTS.

I really got confused here because in future lessons tags like < MyComponent  > are called components, but to me these are just HTML tags, how can they be components?  There needs to be a STRONG reinforcement that JSX/React basically allows you to create custom HTML tags.

I'm also REALLY confused why arrow functions are being used here. I've never seen the arrow function before this lesson, and it confuses me/makes me wonder if there is something else going on that i'm missing.  It is refred to as a 'functional component' in the Instructions, as a student I'm wondering if is meant i 'functional stateless component'

After sitting through a bunch of React tutorials I'm still wondering about ParentComponents and Child components, and how they interact.  No tutorial I've found, really seems to drive this point home, or how to distinguish between them.  It seems strange to introduce the concept of parents/children here without FULLY breaking it down/explaining it, ESPECIALLY if you're going to use the concept in future lessons.

Lesson 10: use React to Render nested Components
// Issues with lesson 10

It would seem easier to introduce the analogy/concept of nesting components in lesson 9, to make it easier for the student to conceptualize/understand what composition/composing is.

Yeah I'm still really confused on Parent/Child components, because all of these seem like separate classes/functions, HOW are they child/parent components and explain WHY child component is that way.  After going through lesson 11 I now understand (or seem to understand) that child components, are components that are rendered inside of another component, but that's not really highlighted in this lesson.

There needs to be MUCH more direct verbage drawing attention to what a child component is with something in an Intro similar to:
" When we render one component within another, this is known as making it a child component, and we do so by creating a custom HTML tag (for example  inside the parent component's render function"

Lesson 11: Compose React Componets
// No issues with lesson 11

Lesson 12: Render a class Component to the DOM.
// Issues with lesson 12

The sentence/syntax:

Here's an example of the syntax: ReactDOM.render(componentToRender, targetNode)

Is a bit strange because I can understand 'componentToRender', but because of my general ignorance with React I originally assumed that targetNode was something I could render to.

Lesson 13: Write a React Component from Scratch
// No issues with lesson 13

Lesson 14: Pass a string to a stateless functional component
// Issues with lesson 14

This section in the Intro:
The code editor shows a functional component
called ReturnUsername that accepts an argument
called props. You can access props from within
the component using dot notation. For example, if
you passed in a prop called birthday, you would
access its value by writing props.birthday. In
JSX, that value is JavaScript, so you write it as
{props.birthday}.

In order to define a props name and value, React
uses custom HTML attributes. The attribute name
is the prop name, and the attribute value is the
prop's value. For example, to pass a child
component a prop called birthday, when you
compose the child component within the parent, it
could look like this: <Child birthday="Jul 6th,
1986" />. ""

NEEDS to be hammered harder.  Here's why:

As a someone coming from vanilla JS I'm SUPER confused why what were previously called arguments, are now being universally refered to as props.
The usage of custome HTML attributes is also REALLY foreign, especially since we're using custom HTML tags to call/utilize/render components.
The last sentence is confusing because previously examples have used  as an example piece/block of code, what could make this more clear is

A.  When referring to 'child component' in the last sentence refer to it as: 'the component Child', or make it even more clear with: 'ChildComponent' to drive the distinction home.
or
B: just refer to it as MyComponent.

Because this is so integral to everything else I would STRONGLY recommend at least to changes here:

1.  Cut down the example that is being used here
to allow students to focus more on how this
works.  E.G. Simplify the code more
2.  Make this multiple lessons to reinforce it.

Something like this as an introductory lesson:
class MyComponent extends React.Component {

 render() {

return ( <div>
    <h1> Hello there {this.props.name} {this.props.newName}
    </h1>

    <h2> You are number {this.props.number}!</h2>
    </div>

)

}
}
ReactDOM.render(<MyComponent name="awesome"
newName="Quincy" number={1}/>,document.getElementById('myDiv'));

Makes it MUCH easier to understand, because I can draw a 1 to 1 parallel between what is named, and what is being utilized.  I understand that it possibly introduces 'this' before it should be explained, but I think that's a small price to pay.

Lesson 15: Pass an array as props
// No issues with lesson 15

// Issues with son 16

This was a little confusing because I thought that the only thing I could put below a component is ReactDom.render()

Lesson 17: Override default props
// No issues with lesson 17

Lesson 18: Use PropTypes to Define the Props you Expect
// Issues with lesson 18

Ok, this is confusing because it should be made more clear that what is being checked is not neccessarily the quantity prop, but the value associated with the quantity key, because this is what I initially entered:
Items.propTypes = {React.PropTypes.number.isRequired
};

Lesson 19: Access Props using this.prop
// Issues with Lesson 19:

Thank you for providing a solid explanation of WHY we use the this keyword...SOOOOOO many tutorials don't cover it at all

The following set of sentences are unclear:
"Render an instance of the ReturnTempPassword component in the parent component ResetPassword. Give this component a prop of tempPassword and assign it a value of a string that is at least 8 characters long."
The word 'this' in the second sentence seems like it could refer to either the ResetPassword component OR the ReturnTempPassword component.

Lesson 20: Review Using Props with Stateless functional components
// Issues with Lesson 20

YES!!! The Terminology Review is ABSOLUTELY ON POINT, and should be leveraged more heavily/often/earlier in the lessons to make things more clear/explicit for students.

Lesson 21: Create a Stateful Component
// Issues with lesson 21:

The only thing I might recommend is to add more detail to the example object, in case people don't remember/recall the format of JS objects

Lesson 22: Render State in the UI
// Issues with Lesson 22:

This is a near perfect intro block, it answers the questions of WHAT has to be done, HOW it has to be done, and WHY it has to be done

Lesson 23: Render State in the UI another way
// Issues with Lesson 23

This is a perfect lesson, short, simple, descriptive, to the point, and explains everything the correct amount.

Lesson 24: Set Stat with this.setState
// Issues with lesson 24

The instructionsuse 'this' 3 times in one sentence here:

"
You call this method within your component class like this: this.setState(), passing in an object with key-value pairs.".

One of those times is as a keyword, using 'this' so many times is confusing.  A better re-write would be:

"You call the setState method with your component class like so: this.setState()..."

If the instructions tell me that I should not modify state directly, please provide a concise reason why.  Will it break the app? Will it display incorrectly? Is it a security issue I should be aware of?

The first  2 sentences of the instructions here feel like unnecessary information.

An example of what this.setState looks like would work REALLY well here, because as a student I see this.state = { / code here / }, and assume that this.setState() is similar, to the point where I could see many students falling into the trap of typing: this.setState() = { / code here / }

Lesson 25: Bind 'this' to a class method
// Issues with lesson 25 (IHaveNoIdeaWhatsGoingOn.jpg)

Ok, this lesson intro is terribly confusing.  I've read the intro half a dozen times now and I still can't really make sesne of it, the my main problems are:

A.  The first paragraph is unclear.  What is meant by define methods 'on' my component class?  Do the instructions mean define methods 'within' my component class?
B.  Next it's written that:

"A class method needs to use the this keyword so it can access properties on the class (such as state and props), inside the scope of the method".

The second sentence is unclear because of the word 'properties' in this context getting conflated with props/state.  It may be better to refer to 'properties' as data or information.
Also in this sentence saying 'on the class' is confusing, does the sentence mean 'we can define methods that are part of the class'.  This is only partially resolved by the language following the parenthesis of 'inside the scope of the method', but also feels like a lot of jargon/buzzwords to throw out in 2 sentences that are not direct/clearly explicated.

The whole second paragraph feels messy.

A.  The first sentence makes no sense, what does it mean to bind 'this' to a class method? What does that do, and why does that matter?  It seems like the instructions try to explain that in the last sentence, but even that sentence makes things less clear.
B.  In the last sentence when things try to get cleared up, I get lost again with:

'this refers to the class and will not be undefined'.

??? Please unpack that sentence more for me.  I don't understand why the 'this' keyword is so important, other than I need to use it when I call props or state in class based components.
C.  Ok, I stepped away for an hour, grabbed lunch, and came back, and re-read all of the instructions/intro...I'm still lost.

Lesson 26: Bind this with an arrow function
// Issues with lesson 26

I'm sure that if the previous lesson were broken down into further pieces, but I still don't know what 'this' really is or why it matters.

I'm also confused by what is meant by 'context' in this instance, an example would REALLY help here.

Another example of an arrow function would also go a long way here.

Lesson  27: Use State to toggle an element
// Issues with lesson 27

Ok, I built an arrow function...but I don't know why I'm building an arrow function, or why I need to bind this...I have no doubt my lack of insight is because of the 2 previous lessons.

Lesson 28: Write a Simple Counter

Ok, after writing methods from before, and seeing how they were implemented in the solutions prior, this challenge makes sense

Lesson 29: Create a controlled input
// Issues with lesson 29

Ok, this was a lot to handle, but manageable, I just had to break everything down into pieces, which was possible because while there was a fair amount of jargon, it was all relateable, and clearly built on things that came before.  I'm REALLY thankful that the tests are there
The first sentence of the second paragraph is confusing, is it a 'parameter' or is it a 'prop/property'?

Lesson 30: Create a Controlled Form
// Issues with Lesson 30

Ok, this one pushed me just past my limit of where I felt that I was doing too much, and took me about a half hour or so to work through completely.

Lesson 31: Pass state as Props to child components

Ok, I'm confused on how Unidirectonal data flow works... Where is props/the argument pulling it's data from???

Ok, I spent about 20 minutes playing around with this in order to figure it out.  I added a second key/value pair in the state object in order to make more sense of it, here's how it makes sense in my mind:

A.  We declare Navbar with a custom HTML tag in the React component MyApp render section.
B.  In this custom HTML tag we add the custom attribute of name.
C.  The custom name attribute, holds the value of the object of MyApp known as this.state, specifically it holds the value of key name.  the custom name attribute  holds this value through what we have covered in previous lessons by utilizing this.state.name.
D.  Here's where the trick comes in.  Notice that the Navbar component does not have a name attribute, ONLY the Navbar custom HTML tag has the name attribute.
E.  In the Navbar component  we are able to access the custom attributes, but we access them because they were passed in via props (via background magic I assume).  Sooooo, we use {this.props.ATTRIBUTENAME}
3.Nowhere in previous lessons or even in this one, does it feel like the link between attributes and props gets fully articulated which leads to confusion.

Lesson 32: Pass a callback as props
// Issues with Lesson 32:

Ok, I was able to figure this one out, but only after some guesswork.  The way the following sentences are constructed are confusing to me:
"Add GetInput to the render method in MyApp, then create a prop called input and pass the inputValue from state to it. Also create a prop called handleInput and pass the input handler handleChange to it"

A.  What do is meant by 'create a prop'??? I had to guess that what was meant by this was: "create a custom attribute".
B.  It is really easy for me at this point to conflate prop and state, so when the instructions say 'create a prop and pass inputValue from state', I'm confused as to whether I should be typing {this.props.inputValue} or {this.state.inputValue} because both would seem to be valid given how the preceding sentence is constructed.

Lesson 33: Use the lifecycle Method ComponentWillMount
// No issues with lesson 33

Lesson 34:
// No issues with lesson 34

Lesson 35: Event listeners
// No issues with lesson 35

Lesson 36: Manage updates with lifecycle methods
// No issues with lesson 36

Lesson 37: Optimize Re-renders with shouldComponentUpdate
// Issues with lesson 37

hrmmmm why is it not this.nextProps.value?  Ohhhhh, is it becuase nextProps is already in the shouldComponentUpdate function?  Hrmmmm, so I guess the question still is: when is 'this' used, and when is it not/what is the purpose/function of 'this'?

Why can I not use an if statement here?  I know from other tutorials that React is picky about using if/else statements, but it's the first thing that comes into my mind from JS

Ok, I'm curious as to how the shouldComponentUpdate method stops the render from happening unless a condition is met, but for now I'll take it as React Magic(tm)

###38: Introducing Inline Styles
// No issues with lesson 38:

Lesson 39: Add Inline Styles in React
// Issues with lesson 39

It just seems strange that the entirety of the border property/selector/value has to be a string inside the JS object

Lesson 40: Use advanced JS in React Render Method
// Issues with Lesson 40

Hrrmmm, ok.  On the handleChange method what is 'e' and where does it come from.

Lesson 41: Render with an if/else condition
// Issues with lesson 41

Lol, I had hard time keeping track of closing brackets/parens with this one.

Lesson 42: use && for a more concise conditional
// Issues with Lesson 42

I think it would be useful to juxtapose what a traditional if statement looks like against the && operator, because the way that the && operator is presented seems completely foreign to me.

A.  The line of code: {condition && markup}, makes me think that I need to write { if (this.state.display) &&  Display  }.

Lesson 43: Return null to prevent rendering
// Issues with Lesson 43:

This one makes sense now that I understand how properties work, and can remember that vanilla JS goes BEFORE the return statement

Lesson 44: Ternary operator
// Issues with Lesson 44:

There REALLY needs to be a refresher on ternary operators and what they look like here, especially if/when chaining them together.

I peeked at the solution code, reloaded the seed, and then spent a good 20 minutes trying to figure out how to duplicate a chained ternary operator, which I was able to do based off of this stackoverflow post

Lesson 45: Render Condtionally from props
// Issues with lesson 45:

Why is there, after the lesson with ternary, a line of code showing what ternary is???? That seems REALLY out of place/late:
(condition ? expr1 : expr2)

This is the first lesson in a while where I felt like I had a tenuous, but OK grasp on things and was able to piece everything together to make it work, because the lessons seem to either fall in the category of IHaveNoIdeaWhatImDoing.jpg or Ok, I get what this is saying.

This lesson is a nice balance between those that made me struggle for a bit and feel accomplished when I saw that all the tests passed.

Lesson 46: Use Array.map to dynamically render elements
// Issues with lesson 46

The first sentence of the second paragraph in the intro seems strangely constructed:
"Let's let our example, in this case, be a simple..."

An example/reminder of what array.map looks like would be helpful.

It took me about 10 minutes and this page to get to the solution, after wrestling around a bit on what needed to be mapped etc...

Lesson 47: Use Array.filter to Dynamically filter an array
// Issues with Lesson 47

An example of a filter function in action would go a long way here to cutting down the time to work on something like this

Lesson 48: Render React on the Server with renderToString
// Issues with lesson 48:

This one is quick and makes sense, the only thing I hesitated on was being used to using ReactDOM.render( , document.getElementById('element')), because I though i would have to provide something to render to

My notes:

Challenge 4: Revised document.getElementById().
Challenge 8: I didn't make any changes, we can revisit this if needed
Challenge 9/10: I made a lot of revisions on this! Please take a look and see what you think.
Challenge 12: I revised the language here a little.
Challenge 14: I've re-written this. Please review!
Challenge 18: Added slight changes.
Challenge 19: Fixed it.
Challenge 24: Added example of this.setState().
Challenge 25/26/27: I made a note that the this keyword is a very confusing aspect of JS. That is why we tried to wait so long to introduce this even though it is encountered very commonly in React because it's difficult to understand. The React challenges are not the place for a thorough review of how this works, however, so I'm just going to say please refer to other lessons on that point for now.
Challenge 31: Hopefully this is clearer with the revisions in 14?
Challenge 32: I changed the language here a little.
Challenge 37: You can totally use an if/else statement here or anything else you want, as long as the method returns a boolean which React will use to determine if it should update or not, as the intro states.
Challenge 40: I've updated the e to be event — it is the same as from the controlled input form challenges.
Challenge 44/45: Good point! I've moved this overview of what a ternary expression is from 45 to 44. Otherwise, regarding ternary expressions again these challenges are not the best place to review them.
Challenge 46: Changed wording.
Challenge 47: Added an example use of filter

Thanks a lot for your feedback @ryan-jr!!! This is really helpful. Mainly, I will comment that these challenges are already quite verbose in terms how much text they have, especially in comparison to current FCC challenges. This is because a lot has to be explained with React, which we are trying to do as best we can. However, that's also why on certain topics, e.g. this, ternary operator, array methods like map and filter, we're a little limited on detailed explanation because these are all core JavaScript topics that can be learned elsewhere.
@HKuz you may want to briefly review the wording on challenges 9 and 14 now because I just more or less re-wrote these two.

Also, @ryan-jr if you continue with the Redux and React-Redux challenges, which I hope you do, please feel free to open individual issues here as they arise so we can handle them one by one!

@bonham000, will do 👍


GHC 9.2 Compat

Hello, this library has an outdated upper bound on bytestring, which prevents it from building with ghc 9.2. I noticed this when trying to use country and ghc 9.2.
It appears your direct usage of bytestring is limited to ShortByteString, BS.length, and BS.unsafeUseAsCStringLen. The changelog does mention these, but not in a conflicting way, as far as I can tell.
For what it's worth, the project compiled and tests passed for me when I merely bumped the bounds. I am unable to judge compatibility beyond that, however.
I also tested with the newest version of transformers:
diff --git a/bytehash.cabal b/bytehash.cabal
index 597e4e4..34c4629 100644
--- a/bytehash.cabal
+++ b/bytehash.cabal
@@ -34,8 +34,8 @@ library
     , primitive-unlifted >=0.1.2 && <0.2
     , byteslice >=0.2.1 && <0.3
     , entropy >=<IP_ADDRESS> && <0.5
-    , bytestring >=0.10.8 && <0.11
-    , transformers >=0.5.6 && <0.6
+    , bytestring >=0.10.8 && <0.12
+    , transformers >=0.5.6 && <0.7
   hs-source-dirs: src
   ghc-options: -O2 -Wall
   default-language: Haskell2010

Thanks for the great library!

fixed in 62b6d78e818ddca9cf0ea20c58df134aa7a1d661 and in 7ff99c4357a42eb5bd0fa55561c8f9742406edd6

I've also make these changes on hackage as a metadata revision.


Escaping special characters with XML::Builder broken broken in document fragment

When using XML::Builder, the #text method is supposed to insert text content and make sure it's properly escaped to not allow injecting content that could be interpreted as tags.
This generally works as expected, but there's a weird special case when text is added at the top scope of a document fragment, i.e. not wrapped in an element.
# This is ok:
XML.build_fragment {|b| b.element("p") { b.text("<foo>") } } # => "
<foo>
\n"
# This is NOT ok:
XML.build_fragment {|b| b.text("<foo>") } # => "<foo>\n"

The reason for this is in libxml2's xmlTextWriterWriteString method which for some reason seems to not escape the string if there's no entry on the writer stack:
https://github.com/GNOME/libxml2/blob/bfc0f674ccf5c3929ce22e29307a6ffae17428ad/xmlwriter.c#L1491-L1524
I have no idea what's the reason for this and I can't fidn any further documentation nor bug reports for this. But it's really hard to find such things for libxml2. Maybe I should open an issue at https://gitlab.gnome.org/GNOME/libxml2/-/issues but I can't imagine this hasn't come up before, so there must be some information, I just can't find it. Maybe someone here has an idea?
The behaviour of our exposed API is certainly unexpected and a potential security issue because text should be expected to always escape, no matter the builder state.
We don't even expose a #raw method yet which could be used for explicitly escaped content (for example using HTML.escape).

IMO Crystal API XML::Builder shouldn't be exposing text, attribute, attributes etc as Document level, as these are element level things and should only be made available to element (first part of your example above).
So this isn't a problem with the underlying library, but how we have encapsulated that into API.

The XML::Builder interface is agnostic to this. There's no way to statically restrict the methods you can call on it. That depends on the current context, which is a runtime property.
What you describe is actually a different problem and not really related to this issue. This is about an entirely valid represenation of a DOM (a document fragment containing a text node) being improperly created. This is not a failure of the API (which is completely fine as per my example above) but the implementation is flawed.


Update code to compile with AKV v1.0.0

for issue #389
after updating to azure-keyvault v1.0.0, the project breaks. The change fixes it. However, it will also break user's existing programs that use AKV. We will need to document this breaking change.

Codecov Report

Merging #397 into dev will increase coverage by 0.04%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##                dev     #397      +/-   ##
============================================
+ Coverage     40.12%   40.16%   +0.04%
+ Complexity     1890     1886       -4
============================================
  Files           107      107
  Lines         24482    24472      -10
  Branches       4038     4039       +1
============================================
+ Hits           9823     9829       +6
+ Misses        12820    12800      -20
- Partials       1839     1843       +4

Flag
Coverage Δ
Complexity Δ

#JDBC41
39.97% <0%> (-0.03%)
1878 <0> (-4)

#JDBC42
40% <0%> (ø)
1877 <0> (-5)
:arrow_down:

Impacted Files
Coverage Δ
Complexity Δ

...om/microsoft/sqlserver/jdbc/SQLServerResource.java
100% <ø> (ø)
4 <0> (ø)
:arrow_down:

...QLServerColumnEncryptionAzureKeyVaultProvider.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...m/microsoft/sqlserver/jdbc/KeyVaultCredential.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...om/microsoft/sqlserver/jdbc/ReaderInputStream.java
44.94% <0%> (-1.13%)
16% <0%> (-1%)

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
27.23% <0%> (-0.42%)
187% <0%> (-4%)

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
39.59% <0%> (-0.07%)
0% <0%> (ø)

...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
49.43% <0%> (+0.14%)
210% <0%> (ø)
:arrow_down:

...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java
42.42% <0%> (+0.21%)
46% <0%> (ø)
:arrow_down:

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
45.31% <0%> (+0.44%)
0% <0%> (ø)
:arrow_down:

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
30.11% <0%> (+0.44%)
58% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fe6ccc...b9c6cf1. Read the comment docs.


[ID Tool] When creating a user after switching views, the dropdown menu for adding the user to an agency doesn't update until manually refreshing

@mhuang-usdr : Do you have two browser tabs open, one showing the Users tab and the other showing the Agencies tab?

@chrisxkeith I just reinvestigated this and can't repro it. I'll close it for now, thanks for taking a look!


auto ban outside bots???

i have seen other games with an anti bot that when someone tries spawning bots it will automatically ban the proxies used to spawn the bots, can anyone tell me how i could do that on my server???

Get a list of every single proxy in the world and ban them, no it's not possible.


[Feat]: Implement Return Policy Page

Description
The current shopping project lacks a dedicated page for the Return Policy, which is crucial for informing users about the terms and conditions related to returns and exchanges. To enhance user trust and satisfaction, I propose adding a comprehensive Return Policy page.
Proposed Features:
Detailed Return Policy: Clearly outline the terms for returning products, including the time frame within which returns are accepted, condition requirements, and any exceptions.
Exchange Process: Explain the process for exchanging items, including how users can initiate exchanges and any associated costs or conditions.
Refund Information: Provide details on how refunds are processed, including time frames for refunds and the methods used for returning funds.
Screenshots
https://github.com/user-attachments/assets/66766dd1-ef4c-4490-9550-e5664f4a6805
I wanna add like this
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@RachitSahu26 As of now, we do not need it. We will let you know in the future if there is a need. Please search for another issue and raise it, which I'm happy to assign to you.


Using NavigationController in storyboard

Hi I really fascinated with this library. I just asked a question previously and it solved me perfectly.
Now i am coming up with another issue is that, when i created a viewController and then i embed it with navigationController which Editor -> Embed In -> Navigation Controller and then i inherited with AppNavigationController class in order to get NavigationController as material design view.
But unfortunately for me i don't think that it works for me.
This is how my storyboard looks like
This is when i run the app and then i don't think that is working for me ;( Output
This is my AppNavigationController custom class
`class AppNavigationController: NavigationController {
open override func prepare() {
    super.prepare()
    isMotionEnabled = true
    motionNavigationTransitionType = .fade
    guard let v = navigationBar as? NavigationBar else {
        return
    }

    v.backgroundColor = .darkGray
    v.depthPreset = .depth5
    v.dividerColor = Color.grey.lighten2
}

}`
Sorry if i ask much questions because i am not yet professional and i want to be a professional in one day.
Thank for your valuable help.

@SamboVisal Hey! Why did you close this? Did you solve your problem?


[CBR-377] Separate Plugins into 'Plugins' and 'LegacyPlugins'

Description
Not quite done, but this is the foundation. Still have to re-implement the update notifier plugin. I'll have a look at that ASAP, but in the meantime, this can go in if you feel like it.
Linked issue
[CBR-377]
Type of change

[ ] 🐞 Bug fix (non-breaking change which fixes an issue)
[x] 🛠 New feature (non-breaking change which adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)
[x] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
[ ] 🔨 New or improved tests for existing code
[ ] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

[x] I have read the style guide document, and my code follows the code style of this project.
[x] If my code deals with exceptions, it follows the guidelines.
[x] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

QA Steps

Screenshots (if available)

Superseded by https://github.com/input-output-hk/cardano-sl/pull/3514.