Show capture length in the load capture widget

With this change, we add the capture length information to the load capture widget.
Now, when the user take a new capture file or touch a previous capture file, the capture length information will be added to corresponding CaptureFileInfo and saved.
When the user rename a capture file (from the main window menu), the capture length information will also be added to the renamed file.
After the change: http://screenshot/47AFnYyrkQQgFVo
Tooltips when the capture length is missing: http://screenshot/5qVQXAcjGGsREen
Bug: http://b/198562119
Test:

Unit test;
Take a new capture and return to the connection window, see the correct capture length value in the load capture widget;
Load a previous capture file and return to the connection window, see the the capture length value changed from "--" to the same value we can see in the capture main window timer label;
Rename a capture file from the capture main window and return to the connection window, see the renamed file also has the correct capture length value.

I want to discuss a general thing first before reviewing this: CaptureFileInfo used to only store information about Orbit's usage of the capture but it was not duplicating any information from the capture file itself. This is changing with this PR. That means CaptureFileInfo could get out of sync from the capture file - for example when someone changes the capture file from a different machine. (Could easily be the case when having a network drive for the MyDocuments folder.)
What is usually done in these situation is to store some additional information which allows to verify whether the CaptureFileInfo is still up-to-date (i.e. the length is still the correct length). So what about doing something similar and also storing filesize and modification date in CaptureFileInfo which allows to validate whether the file hasn't been altered?

Good point!
For the capture length, we set it every time when the user touch it. So it might be fine. But I think it is a good idea to store information for verifying whether the CaptureFileInfo syncs correctly with the actual file.
@antonrohr WDYT?

@beckerhe, @antonrohr As we discussed offline, I changed to also save the file size and last modified date.
The capture length will be reset to std::nullopt if we find the file size or last modified date does not match.


[WIP][ ZF3 ] duplicate EVM in Zephir

So first of i want to say dam you @bakura10 for creating so many awesome PR i feel i need to do something...
So the idea grew a bit in the #zfalk.dev channel today about the performance of various components e.g ServiceManger, EventManager and Stdlib. And how we could increase the performance of these components. Something we realised is that many of the components are rather stable/mature. So maintaining the code shouldn't be too much of a hasel to maintain either (Famous last words).
So my idea is to start writing the EventManager in Zephir first to see how much of a performance boost we get and see what issues are with using it.

EVM v3 is merged on component branch. If you want open a discussion about apply Zephir please reopen on the component issue tracker.


3D surface drawing in graphical calculator

As addition to the graphical mode
https://github.com/microsoft/calculator/issues/338
https://blogs.windows.com/windowsexperience/2020/01/16/announcing-windows-10-insider-preview-build-19546/
it would be nice, to have a 3D surface mode,
An example is NuCalc, which was part of Mac OS 7
https://en.wikipedia.org/wiki/NuCalc
http://www.pacifict.com/

Closing as a dupe of #944


Build & Run are failing on CI(private)

This is from the build.log:
Error-[SVA-COBMMI] Can only bind to modules or instances.
../src/lowrisc_dv_aes_sva_0.1/[aes_bind.sv](https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Faes_bind.sv%2F&data=05%7C01%7Cjacob.levy%40nuvoton.com%7C1a7f7c99749d4110d53a08da32a47637%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C637877979210638123%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tWo14PXqQEEZ594rP2esdOgjZx2zNCeI3ofWNu3Dc%2BU%3D&reserved=0), 54
aes_bind
  Can only bind to modules or module instances.
  bind aes_prng_masking aes_masking_reseed_if u_aes_masking_reseed_if( .clk_i
  (clk_i),  .rst_ni (rst_ni),  .entropy_i (entropy_i),  .prng_seed_en
  (prng_seed_en),  .prng_seed (prng_seed),  .lfsr_q_0
  (gen_lfsrs[0].u_lfsr_chunk.lfsr_q),  .lfsr_q_1
  (gen_lfsrs[1].u_lfsr_chunk.lfsr_q),  .lfsr_q_2
  (gen_lfsrs[2].u_lfsr_chunk.lfsr_q),  .lfsr_q_3
  (gen_lfsrs[3].u_lfsr_chunk.lfsr_q),  .lfsr_q_4
  (gen_lfsrs[4].u_lfsr_chunk.lfsr_q));

@tjaychen @msfschaffner @rswarbrick

@Jacob-Levy, can you point us to the PR where this is currently failing?

It is not a PR yet... I run the CI(private) using dvsim on a PR candidate.

Ah sorry about that - I just saw the email.
@weicaiyang @rasmus-madsen
Is this error maybe due to the VCS version?
@Jacob-Levy is using R-2020.12-1 if I am not mistaken...

We just switched to S-2021.09-SP2-1. Greg sent an announcement last night.
https://github.com/lowRISC/opentitan-private-ci/commit/181fa4149f13c96739909182b943b4792b1ed08d
perhaps push it to a PR so that we can take a look.

Will update VCS version and rerun CI(private)

Hi Jacob,
Looks like the build failed for that block. Probably worth having a look
at the build log to see what happened.
Rupert
On Wed, 11 May 2022 at 07:34, Jacob @.***> wrote:

II just updated VCS&VERDI versions to  S-2021.09-SP2 while waiting to our CAD to pull S-2021.09-SP2-1.
I also pulled the opentitan latest master and run the following from opentitan (no AST PR files!):
% util/dvsim/dvsim.py hw/top_earlgrey/dv/top_earlgrey_sim_cfgs.hjson --purge -w -i smoke --max-parallel 3 --tool=vcs --fixed-seed=1
The result:
INFO: [FlowCfg] [scratch_path]: [chip]
[/tanap1/proj_cd14/opentitan/jlevy/ot_PR/opentitan/scratch/master/chip_earlgrey_asic-sim-vcs]
## TOP_EARLGREY_BATCH_SIM Simulation Results (Summary)
### Wednesday May 11 2022 11:39:37 UTC
### GitHub Revision:
[`6195eefb3`](https://github.com/lowrisc/opentitan/tree/6195eefb387fb0876c57c9db30333fb2fd9c1704)
### Branch: master

|       Name       |  Passing  |  Total  |  Pass Rate  |
|:----------------:|:---------:|:-------:|:-----------:|
|     TL_AGENT     |     1     |    1    |  100.00 %   |
|     ADC_CTRL     |     3     |    3    |  100.00 %   |
|       AES        |     0     |    3    |   0.00 %    |
|       AES        |     3     |    3    |  100.00 %   |
|    AON_TIMER     |     3     |    3    |  100.00 %   |
|      CLKMGR      |     3     |    3    |  100.00 %   |
|      CSRNG       |     3     |    3    |  100.00 %   |
|       EDN        |     3     |    3    |  100.00 %   |
|   ENTROPY_SRC    |     3     |    3    |  100.00 %   |
|    FLASH_CTRL    |     3     |    3    |  100.00 %   |
|       GPIO       |     3     |    3    |  100.00 %   |
|       HMAC       |     4     |    4    |  100.00 %   |
|       I2C        |     2     |    3    |   66.67 %   |
|      KEYMGR      |     3     |    3    |  100.00 %   |
|       KMAC       |     3     |    3    |  100.00 %   |
|       KMAC       |     3     |    3    |  100.00 %   |
|     LC_CTRL      |     4     |    4    |  100.00 %   |
|       OTBN       |     3     |    3    |  100.00 %   |
|     OTP_CTRL     |     3     |    3    |  100.00 %   |
|     PATTGEN      |     3     |    3    |  100.00 %   |
|    PRIM_ALERT    |     1     |    1    |  100.00 %   |
|     PRIM_ESC     |     1     |    1    |  100.00 %   |
|    PRIM_LFSR     |     1     |    1    |  100.00 %   |
|   PRIM_PRESENT   |     1     |    1    |  100.00 %   |
|   PRIM_PRINCE    |     1     |    1    |  100.00 %   |
|       PWM        |     3     |    3    |  100.00 %   |
|      PWRMGR      |     3     |    3    |  100.00 %   |
|     ROM_CTRL     |     3     |    3    |  100.00 %   |
| RSTMGR_CNSTY_CHK |     1     |    1    |  100.00 %   |
|      RSTMGR      |     3     |    3    |  100.00 %   |
|      RV_DM       |     7     |    7    |  100.00 %   |
|     RV_TIMER     |     3     |    3    |  100.00 %   |
|     SPI_HOST     |     3     |    3    |  100.00 %   |
|    SPI_DEVICE    |     3     |    3    |  100.00 %   |
|    SRAM_CTRL     |     3     |    3    |  100.00 %   |
|    SRAM_CTRL     |     3     |    3    |  100.00 %   |
|   SYSRST_CTRL    |     3     |    3    |  100.00 %   |
|       UART       |     3     |    3    |  100.00 %   |
|      USBDEV      |     2     |    2    |  100.00 %   |
|  ALERT_HANDLER   |     3     |    3    |  100.00 %   |
|       MAIN       |     1     |    1    |  100.00 %   |
|       PERI       |     1     |    1    |  100.00 %   |
|       CHIP       |     6     |    6    |  100.00 %   |

INFO: [FlowCfg] [results:email]: [/tanap1/proj_cd14/opentitan/jlevy/ot_PR/opentitan/scratch/email.html]
ERROR: [dvsim] Errors were encountered in this run.

          [ legend ]: [Q: queued, D: dispatched, P: passed, F: failed,
K: killed, T: total]
00:18:51 [ build ]: [Q: 000, D: 000, P: 043, F: 001, K: 000, T: 044]
100%
00:46:00  [     run     ]: [Q: 000, D: 000, P: 115, F: 001, K: 003, T: 119] 100%

Also the run.log for the I2C errors attached
run.log
.

II just updated VCS&VERDI versions to S-2021.09-SP2 while waiting to our CAD to pull S-2021.09-SP2-1. I also pulled the opentitan latest master and run the following from opentitan (no AST PR files!):
% util/dvsim/dvsim.py hw/top_earlgrey/dv/top_earlgrey_sim_cfgs.hjson --purge -w -i smoke --max-parallel 3 --tool=vcs --fixed-seed=1
The result:
INFO: [FlowCfg] [scratch_path]: [chip] [/tanap1/proj_cd14/opentitan/jlevy/ot_PR/opentitan/scratch/master/chip_earlgrey_asic-sim-vcs]
## TOP_EARLGREY_BATCH_SIM Simulation Results (Summary)
### Wednesday May 11 2022 11:39:37 UTC
### GitHub Revision: [`6195eefb3`](https://github.com/lowrisc/opentitan/tree/6195eefb387fb0876c57c9db30333fb2fd9c1704)
### Branch: master

|       Name       |  Passing  |  Total  |  Pass Rate  |
|:----------------:|:---------:|:-------:|:-----------:|
|     TL_AGENT     |     1     |    1    |  100.00 %   |
|     ADC_CTRL     |     3     |    3    |  100.00 %   |
|       AES        |     0     |    3    |   0.00 %    |  <<<<<<<<
|       AES        |     3     |    3    |  100.00 %   |
|    AON_TIMER     |     3     |    3    |  100.00 %   |
|      CLKMGR      |     3     |    3    |  100.00 %   |
|      CSRNG       |     3     |    3    |  100.00 %   |
|       EDN        |     3     |    3    |  100.00 %   |
|   ENTROPY_SRC    |     3     |    3    |  100.00 %   |
|    FLASH_CTRL    |     3     |    3    |  100.00 %   |
|       GPIO       |     3     |    3    |  100.00 %   |
|       HMAC       |     4     |    4    |  100.00 %   |
|       I2C        |     2     |    3    |   66.67 %   |  <<<<<<<<
|      KEYMGR      |     3     |    3    |  100.00 %   |
|       KMAC       |     3     |    3    |  100.00 %   |
|       KMAC       |     3     |    3    |  100.00 %   |
|     LC_CTRL      |     4     |    4    |  100.00 %   |
|       OTBN       |     3     |    3    |  100.00 %   |
|     OTP_CTRL     |     3     |    3    |  100.00 %   |
|     PATTGEN      |     3     |    3    |  100.00 %   |
|    PRIM_ALERT    |     1     |    1    |  100.00 %   |
|     PRIM_ESC     |     1     |    1    |  100.00 %   |
|    PRIM_LFSR     |     1     |    1    |  100.00 %   |
|   PRIM_PRESENT   |     1     |    1    |  100.00 %   |
|   PRIM_PRINCE    |     1     |    1    |  100.00 %   |
|       PWM        |     3     |    3    |  100.00 %   |
|      PWRMGR      |     3     |    3    |  100.00 %   |
|     ROM_CTRL     |     3     |    3    |  100.00 %   |
| RSTMGR_CNSTY_CHK |     1     |    1    |  100.00 %   |
|      RSTMGR      |     3     |    3    |  100.00 %   |
|      RV_DM       |     7     |    7    |  100.00 %   |
|     RV_TIMER     |     3     |    3    |  100.00 %   |
|     SPI_HOST     |     3     |    3    |  100.00 %   |
|    SPI_DEVICE    |     3     |    3    |  100.00 %   |
|    SRAM_CTRL     |     3     |    3    |  100.00 %   |
|    SRAM_CTRL     |     3     |    3    |  100.00 %   |
|   SYSRST_CTRL    |     3     |    3    |  100.00 %   |
|       UART       |     3     |    3    |  100.00 %   |
|      USBDEV      |     2     |    2    |  100.00 %   |
|  ALERT_HANDLER   |     3     |    3    |  100.00 %   |
|       MAIN       |     1     |    1    |  100.00 %   |
|       PERI       |     1     |    1    |  100.00 %   |
|       CHIP       |     6     |    6    |  100.00 %   |

INFO: [FlowCfg] [results:email]: [/tanap1/proj_cd14/opentitan/jlevy/ot_PR/opentitan/scratch/email.html]
ERROR: [dvsim] Errors were encountered in this run.

          [   legend    ]: [Q: queued, D: dispatched, P: passed, F: failed, K: killed, T: total]
00:18:51  [    build    ]: [Q: 000, D: 000, P: 043, F: 001, K: 000, T: 044] 100%
00:46:00  [     run     ]: [Q: 000, D: 000, P: 115, F: 001, K: 003, T: 119] 100%

i'll have a loook and push a fix. just reproduced the aes error in my environment.
Not really sure why this wasn't seen before..or breaking CI.

Not really sure why this wasn't seen before..or breaking CI.

CI is running with the signed-off tool now. Hence, i2c and aes are running with Xcelium.

@Jacob-Levy after talking to folks here, we think you should just push the PR first.
The thing right now is for those two blocks (aes and i2c), the signoff tool is xcelium, and our guess is that xcelium doesn't flag these.
So we'll address them for vcs in the background, but you should be able to push a PR without issues (we hope).

@tjaychen I can add a draft and you can add it to your draft PR #12570 and push them together as one PR. Is it OK with you?

@tjaychen  AES issue gone we now left with I2C run fail...
ERROR: [Scheduler] [00:24:14]: [run]: [status] [i2c:0.i2c_smoke.1: F]
ERROR: [dvsim] Errors were encountered in this run.

          [   legend    ]: [Q: queued, D: dispatched, P: passed, F: failed, K: killed, T: total]
00:19:08  [    build    ]: [Q: 000, D: 000, P: 044, F: 000, K: 000, T: 044] 100%
00:45:56  [     run     ]: [Q: 000, D: 000, P: 118, F: 001, K: 000, T: 119] 100%

INFO: [FlowCfg] [results]: [i2c]:
## I2C Simulation Results
### Thursday May 12 2022 20:24:37 UTC
### GitHub Revision: [`1fbd3356e`](https://github.com/lowrisc/opentitan/tree/1fbd3356e57c5053ecdd0221d87c163741d3901f)
### Branch: master
### [Testplan](https://docs.opentitan.org/hw/ip/i2c/doc/dv/#testplan)
### Simulator: VCS

### Test Results
|  Milestone  |                   Name                    | Tests            |  Passing  |  Total  |  Pass Rate  |
|:-----------:|:-----------------------------------------:|:-----------------|:---------:|:-------:|:-----------:|
|     V1      |                host_smoke                 | i2c_smoke        |     0     |    1    |   0.00 %    |
|     V1      |               target_smoke                | i2c_smoke        |     0     |    1    |   0.00 %    |
|     V1      |               csr_hw_reset                | i2c_csr_hw_reset |     1     |    1    |  100.00 %   |
|     V1      |                  csr_rw                   | i2c_csr_rw       |     1     |    1    |  100.00 %   |
|     V1      | regwen_csr_and_corresponding_lockable_csr | i2c_csr_rw       |     1     |    1    |  100.00 %   |
|     V1      |                                           | **TOTAL**        |     2     |    3    |   66.67 %   |
|     V2      |          tl_d_outstanding_access          | i2c_csr_hw_reset |     1     |    1    |  100.00 %   |
|             |                                           | i2c_csr_rw       |     1     |    1    |  100.00 %   |
|     V2      |            tl_d_partial_access            | i2c_csr_hw_reset |     1     |    1    |  100.00 %   |
|             |                                           | i2c_csr_rw       |     1     |    1    |  100.00 %   |
|             |                                           | **TOTAL**        |     2     |    3    |   66.67 %   |

## Failure Buckets

* `UVM_ERROR (cip_base_scoreboard.sv:586) [scoreboard] tl_a_chan_fifos[i] item uncompared:` has 1 failures:
    * Test i2c_smoke has 1 failures.
        * 0.i2c_smoke.1\
          Line 49, in log /tanap1/proj_cd14/opentitan/jlevy/ot_PR/opentitan/scratch/master/i2c-sim-vcs/0.i2c_smoke/out/run.log

                UVM_ERROR @<PHONE_NUMBER> ps: (cip_base_scoreboard.sv:586) [uvm_test_top.env.scoreboard] tl_a_chan_fifos[i] item uncompared:
                -------------------------------------------------------------------
                Name                           Type             Size  Value
                -------------------------------------------------------------------
                req                            cip_tl_seq_item  -     @528403

INFO: [FlowCfg] [scratch_path]: [i2c] [/tanap1/proj_cd14/opentitan/jlevy/ot_PR/opentitan/scratch/master/i2c-sim-vcs]

do you see this issue with xcelium @Jacob-Levy ?
i think right now i2c CI is run with xcelium, so it doesn't show up for whatever reason (i do reproduce this under vcs).

I run my CI(private)  (using dvsim) locally so it uses only VCS. I did not have an issue with this run few weeks ago...

closing this for now since the issue is not observed in CI.


Fix(CX-3151): fix duplication of MyCollection after submission

The type of this PR is: Fix

This PR solves CX-3151
Description

Fixes the duplication of MyCollection Artwork after submission.
Fixes submission_id not being updated on MyCollection Artwork submission because the source is forced to web_inbound instead of my_collection

Let's merge this once the tests are fixed. I will try to rerun them again


[BUG] Group slices are defined in a dynamically grouped view

Dynamic groups have a group media type, but should not inherit group dataset attributes as it seems they do not apply to dynamic groups. This discrepancy breaks page state assumptions made by the App.
import fiftyone.zoo as foz

dataset = foz.load_zoo_dataset("quickstart")
assert dataset.group_by("filepath").group_slice is None

dataset = foz.load_zoo_dataset("quickstart-groups")
assert dataset.select_group_slices("left").group_by("filepath").group_slice is None # left is defined
assert dataset.select_group_slices("left").group_by("filepath").group_slices is None # slices are defined

This conflict causes issues with dynamically grouped views created from a converted group dataset (i.e. with dataset.select_group_slices("slice"). Using quickstart-groups, the App incorrectly inherits a defined group_slice:
import fiftyone as fo
import fiftyone.zoo as foz

dataset = foz.load_zoo_dataset("quickstart-groups")
session = fo.launch_app(dataset.select_group_slices("left").group_by("filepath"))

The grid loads successfully, but incorrectly presents the slice selector. Expanding the modal presents a hard error.

Resolved by #3333


Use Polly to perform retries on failed event processing

Currently, when an event incurs an error the entire batch is retried forever. This PR utilizes Polly to perform the retry logic. Only a specific set of exceptions will be allowed to retry.

Yeah I changed the exception to that of the new SDK per your suggestion.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Will @.>
Sent: Monday, July 12, 2021 8:08:35 PM
To: microsoft/iomt-fhir @.>
Cc: Rob Gordon @.>; Author @.>
Subject: Re: [microsoft/iomt-fhir] Use Polly to perform retries on failed event processing (#123)
@wi-y commented on this pull request.

In src/console/Normalize/Processor.cshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fiomt-fhir%2Fpull%2F123%23discussion_r668393748&data=04|01|Rob.Gordon%40microsoft.com|1bcc65c67e654d49855a08d945ab8146|72f988bf86f141af91ab2d7cd011db47|1|0|637617425190418517|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=QtUixuzWE2qgjZQ4CtBxrlP33vz34IR55x16ezO0tTM%3D&reserved=0:

@@ -90,5 +109,49 @@ public async Task ConsumeAsync(IEnumerable events)
eventStats.TotalEventsProcessedBytes);
}
}

   private static AsyncPolicy CreateRetryPolicy(ITelemetryLogger logger)

   {

       bool ExceptionRetryableFilter(Exception ee)

       {

           switch (ee)

           {

               case AggregateException ae when ae.InnerExceptions.Any(ExceptionRetryableFilter):

               case OperationCanceledException _:

               case HttpRequestException _:

               case EventHubsException _:

               case AuthenticationFailedException _:

               case RequestFailedException _:

Nevermind - it works fine when pulling in the latest changes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fiomt-fhir%2Fpull%2F123%23discussion_r668393748&data=04|01|Rob.Gordon%40microsoft.com|1bcc65c67e654d49855a08d945ab8146|72f988bf86f141af91ab2d7cd011db47|1|0|637617425190428512|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=wRYB7aC9imfA0qBKQlb2RaaC6i%2Fi6j9PNeMGIuKP9Zs%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARAAJ2XABSMYW5ENGMOO6C3TXOU3HANCNFSM5ADRAEZA&data=04|01|Rob.Gordon%40microsoft.com|1bcc65c67e654d49855a08d945ab8146|72f988bf86f141af91ab2d7cd011db47|1|0|637617425190428512|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=5SxwZUWrt1V1H1%2BxYwBxqovy5Abt6RrcxWYkiL0ecg0%3D&reserved=0.


zh-CN: Regular up-to-date.

[x] I understand that contributing to this repository will require me to agree with the CLA

Description
Translation documents update.

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[x] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[x] 📜 README.md
[ ] 📓 tech-docs
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@any contributor @Gitbreast docs


PandaDoc on Startup Pack

Added PandaDoc to Startup pack. Src on imgur.

Sure, I'll allow it. Not a ton of startups in this pack anyway.


Rename references to account_id/accountId to account_number

In CRC org_id is used to refer to a number that organization admins have access to really. And account_number is the shared number over an organization.
So let's rename account_id/accountId references to account_number (but keep org_id as is). To keep it consistent and avoid future confusion. Migrate the db as well, since we currently have a single table without any references to account_id, we can just rename it to account_number.

As a note: the personal/individual number is identity["user_id"]; this should be unique across an organization. When we want to track composes of individual numbers as well we might need to use org_id + user_id combo.


Reactify not working in latest Chrome version

@treshugart
Reactified component is rendering in Firefox, but not in latest Chrome (55.0.2883.95).
Component gets inserted inserted into DOM but is never upgraded and never renders itself.
See codepen below...
http://codepen.io/kentendo/pen/BQMEbe?editors=1010

I only see this happening in Chrome version 55.*
Works in 56.

@kentendo do you have a reproduction of this? If you can write a failing test for this, that would be awesome :). Currently tests pass in 55.

I started on a test, but looked at the other tests in here and noticed they are still using the v0 API and polyfill. The issue I'm seeing is more v1 specific, where the lifecycle hooks ( onConnectedCallback, etc )  are never getting called.  I'm afraid if I switch to a v1 polyfill, I'm going to have to rewrite all these old tests. Any ideas?

You're right. We should update the tests, for sure. I raised #59 for this. I don't have much time to do this for the next week or so. Would you have time to submit a PR for it? I understand if not.

I'll give it a shot...

I've made some good progress on this, but I'm having issues with the event tests in chrome...
https://github.com/kentendo/react-integration


Creating database, or a public API for adapter storage_up/storage_down?

Environment

Elixir version (elixir -v): 1.9
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.): 10.5
Ecto version (mix deps): 3.1.7
Database adapter and version (mix deps): postgrex 0.15 and ecto_sql 3.1.6
Operating system: MacOS Mojave

Current behavior
I've been digging into the dynamic repo functionality for project.  This issue is about the dirtiest part of the solution. Creating the database.
Part of my requirements is to be able to create a repo at runtime. Ecto.Migrator provides some of this, specifically it allows us to run migrations. It does not allow us to mimic mix ecto.create in code without using what I assume is internals:
repo_module.__adapter__.storage_up(options)
Similarly (during tests in my case) I end up using storage_down
Expected behavior
I'd like the Migrator or some part of Ecto to provide this possibility. It feels like an oversight.
I guess if you can rely on someone else creating the databases for you the dynamic repo is quite useful without this. But I imagine there are plenty of use cases beyond mine where the application might want to be able to create the database.
Let me know if I'm overlooking something or if something is unclear. Maybe I should be dropping down into Postgrex or something but that seems counter-intuitive when dynamic repos is there and an actual feature.

repo_module.adapter.storage_up(options)

This is the public API. :) Both __adapter__ and storage_up are publicly documented. Since they are not frequently used, we don't feel there is a need to wrap them in a module.

Oh sweet. Thanks for that I'll use it without shame then :)


”Cerna” is listed in the drop-down menu

Description:
"Cerna" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Cerna" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Cerna, TULCEA".


Changing OpenVPN server port as well as changing to TCP from UDP if my new port doesn't bypass firewall

Hi,
I'm a newb Raspberry user and I was able to successfully install OpenVPN on my Raspberry pi by using a walk-through I found on pivpn.
I have it set up on typical port 1194 udp.  Everything is currently working and I have been able to edit my ip address (I'm dynamic) when it changes (maybe once a year).   I have been editing my ip address with this command I found online on a forum.
"sudo nano /etc/openvpn/easy-rsa/pki/Default.txt"
I edit the ip address and control + x to exit and save changes
restart with
"sudo reboot"
A new firewall at work has been installed and I can no longer access my VPN at my house (to check my security cameras etc on my local network only).  I'm trying to change to different ports because what I have read indicated that maybe ports 443 and 80 might work for me.  If not, then it was suggested to change to TCP rather than UDP.
So far I tried to edit my Default.txt and change the port the same way that I changed the ip address that I listed above.  I changed the port and saved the default.txt file and used the "pivpn add" command and created a new user/pass and tried the new .ovpn file generated in /home/pi/ovpns but this did not work.  In fact when I tried my older .ovpn file that was on port 1194 it was still working so this leads me to believe that the default.txt file located in /etc/openvpn/easy-rsa/pki/Default.txt is for the remote (login) part of the ovpn file and not actually changing the OpenVPN server port to be listening on port 443.  I did port forward in my router all UDP traffice to port 443 to my internal ip of my Raspberry pi.  I would appreciate any help on:

how can I edit the server port on my OpenVPN configuration?
If my UDP ports are all blocked (I'll try port 443, 80, 22, 587) one at a time I would like to also try the same ports using TCP.

Can you please elaborate how I can go about doing this rather than re-installing my OpenVPN configuration every time?
Thank you in advance for the help.  It is highly appreciated.

Okay I think I was able to change the port properly as well as change from UDP to TCP.  This may be completely incorrect but my understanding is that:
okay to change the port you basically have to change both the server.conf file and the default.txt file to match - the server.conf file is for my pi to know what port to listen in on and the default.txt is what makes the .ovpn file know what port to use.  Yes I'm sure my ability to interpret and explain and not even close to the "real" part and if someone would like to chime in I would welcome it.  Here's what I just did:
type "sudo nano /etc/openvpn/server.conf"
change port and control + x to exit and save changes
restart with "sudo reboot"
then
type "sudo nano /etc/openvpn/easy-rsa/pki/Default.txt"
edit the ip address and control + x to exit and save changes
restart with "sudo reboot"
Once I complete each of these steps I was able to use:
"pivpn add" and create a new .ovpn file that worked on my new port -
Also want to chime in that to change from UDP to TCP I was able to edit line 3 of both the server.conf and default.txt file along the way.

You are correct. The Default.txt file is used for generating new CLIENT .ovpn files while the server.conf actually controls how the server responds.
When you change in the server.conf you will need to restart OpenVPN. If you only change the Default.txt no restart is required as this file is read each time. If you do not want to recreate the client .ovpn file you can edit it directly on the client and restart the OpenVPN service or reboot and it will take effect.
When editing the server.conf file make sure to change your port forwarding on your router.


Change class name from Settings to Setting

To follow rails conventions, the model should be singular.

Moving to a different branch. I'll reopen the PR


CLOUDSTACK-9859: Retirement of midonet plugin (final removal)

Following the component retirement process defined in [1], a vote thread was started in [2]. The community decided to retire the Midonet plugin. This task represents the final step of the retirement, which is the removal of the plugin from CloudStacks code base.
[1] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=68720798
[2] http://markmail.org/message/qigrtfirwnmct4hr

LGTM.


[Win] Remove TAP adapters on uninstall

Need to remove all TAP adapters when uninstalling Subutai

On some systems Environment,GetPath(Environment.SpecialPath.ProgramFiles) can return path to "Program Files x86"


TestModuleFor{App,Acceptance} proposal

WRT https://github.com/rwjblue/ember-qunit/pull/71
@rwjblue @stefanpenner I'm looking into baking this into switchfly/ember-test-helpers:
// tests/helpers/module-for-acceptance.js

import Ember from 'ember';
import { module } from 'qunit';
import startApp from './start-app'; // This file is the unchanged, `ember new` version

export default function(name, options = {}) {
  let application;

  module(`Acceptance | ${name}`, {
    beforeEach: function() {
      application = startApp();
      if (options.beforeEach) {
        options.beforeEach.call(this, arguments);
      }
    },

    afterEach: function() {
      Ember.run(application, 'destroy');
      if (options.afterEach) {
        options.afterEach.call(this, arguments);
      }
    }
  });
}

So that it's integration with ember-qunit would be as minimal as the rest.
I'm having trouble figuring out how, though.
Any ideas?
Will this work at all, or is it best left as a hand-rolled helper?

I guess I don't understand what you mean.

Since we don't really need any special shenanigans to deal with bizarreness in Ember, this sort of thing likely lives in ember-qunit itself.

Sorry if this is too cryptic.
https://github.com/rwjblue/ember-qunit/pull/71 introduces a moduleForApp to wrap
https://github.com/ember-cli/ember-cli/blob/8d9c3a4579abb65416f40ec0dd46008b3c159a49/blueprints/acceptance-test/files/tests/acceptance/__name__-test.js#L3-L13
I'd like to push that forward, but it looks like that PR predates the ember-test-helpers / ember-qunit split, so I tried to work it into this repo instead but I hit a wall.

We've been toying around with implementing something like this for use in one of our addons. Thus far, we've been writing all the code inside the addon, but with an eye for potentially extracting it out for inclusion into ember-test-helpers
https://gist.github.com/Robdel12/c8470434a5e0ded666db
It's been working really well thus far, but my primary concern is with these lines here https://gist.github.com/Robdel12/c8470434a5e0ded666db#file-test-helper-js-L2-L3
Since this class is embedded into our addon, it has access to the (dummy) application's class and config, but is that going to pose a problem if this code were to live in ember-test-helpers?
Also, the startApp() test helper that gets generated by ember-mocha and ember-qunit acceptance-test blueprints allows passing one-off options to Application.create() per test. Changing settings suite-wide in environment.js for 'test' has always been sufficient for us, so we wouldn't miss that, but it might be a problem for others.

Unless anybody sees anything obviously flawed with this approach, we'll go ahead and submit the PR.

@cowboyd I say go ahead, I have an outstanding PR to ember-cli/ember-cli, but I'm having some trouble with it.
If we could get something working in this repo instead, I think we'd be better off.

Added to ember-cli directly in https://github.com/ember-cli/ember-cli/pull/4692


Deleting : file

Looks like this change was already made. Feel free to open a new pull request to add something else.


Error With Custom Token Types

Hello,
I noticed that since version 1.11.0 our pipeline throws an error when running the co build command.
From my investigation, the problem is with the new logic introduced in packages/core/src/lint-core/rules/duplicate-values.ts.
Coming to line 55 with a type that has not been defined in the initial values object throws Cannot read properties of undefined. In reality, any token whose type returns an empty or undefined set is automatically not a duplicate.

Good investigation! That’s a quick fix; will patch that right up


Add aqua test

This PR adds some aqua tests

For unbound type parameters, see https://github.com/JuliaLang/julia/issues/29393
For method ambiguities, see https://github.com/SciML/OrdinaryDiffEq.jl/issues/1750

Oof, TC is a major offender. I may have an idea of how to fix this

I'll merge this for now and we can chip away at driving this down.

bors r+


Please include "--generate-bash-completion" for the "help" command and subcommands

The help command/subcommands are some of the most useful to have autocomplete as I usually.  Require read the docs of command I am less familiar with.
Thanks in advance!

In release 2.30.0, the CLI introduced the assist command that bridges between the CLI and docs using watsonx. Wondering if this will prove even more useful to you?


fix free calls in L and wrap

allow for JS values ( number literals in custom encodings ) as abstraction bodies and expressions
fixes #99 ; the same problem happened in L bodies ( thanks to @monadius for pointing that out )

free determines the free variables in a term. If that term is in JS, it doesn't have free variables, but it also doesn't have a method free, so it should return an empty Set instead of calling undefined.


[Search for facet values] Refinement list - InstantSearch.js

This is a preview PR and I would love your input on the implementation, as well as the configuration options. The commits will be squashed to have a proper history.
Summary
This PR provides an implementation of options to be able to search into facet values in the refinementList widget. When activated it adds a search input on top of the list, the results are replacing the values in the list. Pressing return when there are search results, selects the first item.
The API tries to stay consistent with the current implementation with a configuration object that  defaults and with the following structure (using the structure enables the feature):

placeholder: string (plain text)
templates: object
templates.noResults: string (html  template)

Result

Question about the behavior: if we sort the refinementList by isRefined first, shouldn't we sort the search for facet values results list the same way?

@mthuret this is a very valid question indeed. I failed to find a way to do that without extracting and moving the code sorting the values. I think this question is broader, because in instantsearch.js we let developers use custom sort, should we apply this one?
After testing it seems that the order is fine when returned from Algolia because we are searching. I will put an online version to let you test.

I managed to break it (Don't get me wrong, this is awesome, I just like to break stuff), steps:

load http://bouncy-clam.surge.sh/
search for digipower in facet search
select digipower
search for faeta in searchbox
search for digipower in facet search
remove characters in facet search one by one
wait 700ms
it breaks

/o
😢 😿 😭

One last comment, about design, the icons are not the same style. They seems to come from two different icon sets. The magnifier icon is good, the clear one is a bit too bold/big from my POV

One last comment, about design, the icons are not the same style. They seems to come from two different icon sets. The magnifier icon is good, the clear one is a bit too bold/big from my POV

I used @Shipow generator and I think I can tweak that pretty easily. Thanks!

:+1:


[stable/nginx-ingress] Update img to 0.23.0

Signed-off-by: Naseem Ullah<EMAIL_ADDRESS>
What this PR does / why we need it:
Update image to 0.23.0 for more info please see https://github.com/kubernetes/ingress-nginx/releases/tag/nginx-0.23.0
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #11983

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

Bump

/lgtm


tooltip: true

In this branch, I’m trying to figure out how we could provide shorthand syntax for tooltips. So, rather than needing to repeat the channel definitions when declaring a tooltip, we could derive a tooltip from an existing mark (and possibly allow some overrides, say to suppress certain channels from appearing in the tooltip, or altering how the values are formatted).
As a first cut, I recycled the concept of channel aliases from the earlier PR #798. However, I don’t think this will be sufficient for initializers such as hexbin, because initializers can populate channels that are not declared in mark.channels, and thus we can’t create static aliases. That suggests that either we’d need to run the initializer on the tooltip mark (which is a bummer because it is duplicate effort and wouldn’t work with a nondeterministic initializer), or the tooltip should instead have a reference to the mark whose channel values we want to show in the tooltip. I think the latter is the way to go, but it’ll require some more plumbing to figure out how that would work… and also we should retain the ability to render an independent tooltip (attached to itself, in effect).
Getting this working is probably a blocker for #1304 because we shouldn’t land the proposed tooltip mark if we’ll have to redesign it substantially to support shorthand. But I think we’re pretty close to figuring this out.

Superseded by #1527 which, while the syntax is not final, demonstrates how the underlying mechanism will work.


feat: Drop the hostname requirement when handling PV topology for release-v0.32.x (#1018)

Fixes #N/A
Description
Cherry-picks over #1018 into the v0.32.x release branch
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm

/approve


Flood Fill

Description
Code added for Flood Fill in C++.
Fixes #2080
Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

@ravikr126 Kindly review my PR under LGMSOC'21


Rebuilding text into .sb2 (not an issue)

Please add some way of converting the text back into an .sb2 or .sprite2 format

Whatever for?

I want to be able to use scratch as a text-based programming language is well, and it would make it easier to make custom blocks.

scratchblocks is not a good syntax for that. I have a separate project for that, see http://tjvr.org


ntp: 4.2.8p12 -> 4.2.8p13

Motivation for this change
From http://www.ntp.org/index.html:

ntp-4.2.8p13 was released on 07 March 2019.
It addresses 1 medium-severity security issue in ntpd, and provides 17
other non-security fixes and 1 improvements over 4.2.8p12.

backport candidate
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Warrants a back-port to 19.03?

Yes, security fix!
slackware-security@ links to this CVE (no details yet) in their update:
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-8936
(and ntp.org makes it pretty clear as well :))
Thanks for asking!
On Fri, 08 Mar 2019 01:24:08 -0800, markuskowa<EMAIL_ADDRESS>wrote:

Warrants a back-port to 19.03?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/57059#issuecomment-470862101Non-text part: text/html

backported to 19.03: 5919bf3b40d

backported to 18.09: 2be82fd06ea


Use collectd-metrics with network cryptography

Hi, we want to use collectd-metrics in our project, but looks like there is no support for network cryptography.
For example, as described in collectd wiki: https://collectd.org/wiki/index.php/Networking_introduction
In order to send metrics to our collectd server, we need to provide credentials and SecurityLevel "Encrypt". Do you have plans on this?
Thanks!

Thanks for your interest in metrics! You're right, the library doesn't support encryption for Collectd, but I took a look at the encryption part the binary protocol https://collectd.org/wiki/index.php/Binary_protocol, and it seems not terribly complicated to implement. I will take a swing on it next week.

Hi, thank you for taking this up. The required client side config which works for us is something like this:
LoadPlugin network
<Plugin network>
    <Server "<IP_ADDRESS>" "25826">
        SecurityLevel Encrypt
        Username "user"
        Password "pass"
    </Server>
</Plugin>

Thanks!


"Then we’ll order Node.js to listen to the server configured". Confused

I'm currently trying to follow along with this article https://medium.com/@stfalconcom/chat-app-creation-using-vue-js-nuxt-js-node-js-socket-io-vue-socket-io-vuetify-js-technologies-5f15f0781476
and am a little confused. I'm lost as to which js file im adding new code to for this step "Then we’ll order Node.js to listen to the server configured". Am I editing those lines of code into the index.js file in the servers folder? or is this a different js file.
Appreicate any help

From the artical in your comment, I think the repo is https://github.com/psborul/nuxt-chat-app , so the server file is https://github.com/psborul/nuxt-chat-app/blob/master/server/index.js


NVS Partition Generator KeyError: 'value'

Environment

IDF version:  v3.2-beta1-182-g4c881708d
Build System: Make
Compiler version: xtensa-esp32-elf-gcc (crosstool-NG crosstool-ng-1.22.0-80-g6c4433a) 5.2.0
Operating System: Linux

Problem Description
I'm following the recommendation here to use NVS storage to store AWS certificates in flash.
The NVS partition generator returns an error when checking the value of the file to be encoded.
I think my certificate file does not contain a valid String. How can I make the utility accept the certificate file format?
Expected Behavior
The utility should generate a bin file with the AWS certificate which can be flashed to an esp32 partition.
Actual Behavior
AN empty bin file is generated and a stack trace with the error message:
KeyError: 'value'
Steps to reproduce

Generate AWS certificate.
Null terminate the content of the certificate with '\0'

-----BEGIN CERTIFICATE-----
NOTARealCertIfICAtEAMPD7uM9E2FC7WcXkVQvjJ818Nr+MA0GCSqGSIb3DQEB
CwUAME0xSzBJBgNVBAsMQkFtYXpvbiBXZWIgU2VydmljZXMgTz1BbWF6b24uY29t
IEluYy4gTD1TZWF0dGxlIFNUPVdhc2hpbmd0b24gQz1VUzAeFw0xOTAyMTgxMTEx
NTFaFw00OTEyMzEyMzU5NTlaMB4xHDAaBgNVBAMME0FXUyBJb1QgQ2VydGlmaWNh
dGUwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDFhVNrOPnq3TKNA7X7
LCeQGjD6ec0QxuHs+eRFGJtIgv5G0mM/KYOEw4n0D5JjRlbu22aSi9NAf5BejRDo
1HtcrNUvhmvNDSli4NX+yqA34PgQNUXs1d5GOxO9K/uXlhjBuBO7O54zTtfhN1ZP
8Gd20XC/X6TOZZ0ltx7pmvPH64ZKNW461k7MTGZZEqWlYndsjizNODePlc5rAUuE
09A2YEourhkKRiOAHQk3DLtuyfR/wQlLmcnhOlDDKA8IzeYE+/v4eFkQtc5lzLu4
Q+5z3ozsnPOJ3lnMiQ2NXUUBuMJY+v6Bb98GyOgY7ay4Uzl2lw8ScwyHhawiq2TF
od6VAgMBAAGjYDBeMB8GA1UdIwQYMBaAFPE649b3WKoPCg9tIjnyZnYpxA4AMB0G
A1UdDgQWBBSbBSBvOks3f4oaWDqEpWTGLXpjUjAMBgNVHRMBAf8EAjAAMA4GA1Ud
DwEB/wQEAwIHgDANBgkqhkiG9w0BAQsFAAOCAQEAYMb71nZbaz7VAlpWkZDJju5r
ckyb4CPpH9KQykVnXuYN1sDGdNPFnF8wnpowRRiuQn5cpZHwc0HNchFZ4caIyksF
favEXD/GPpNnkCK+03YDTsTG69cXFbrWDKwyqj6hKR6dkQxBkic5feq2rQ+bav3H
Rju8UbuvrtE6aJTz3IjPqVvbbzTcMeZLY4iEpA2W6Tky8u0Kttz6mIb9GAW5dcx8
s+6ONomRML/FzJQYIqrIjSPIhGwyN6TVzBr9AAmm+d+9mfsv9xIf9H1z1AkyJv9O
CLaxqeNOEtxriSV49bf1e1ccNu8qRsnHH973U/KheqOZ5ch1D9+4c+0RlI3eNg==
-----END CERTIFICATE-----\0

Create the NVS input file certs.csv

key,type,encoding,value
certs,namespace,,
certificate_pem_crt,file,string,~/esp/esp-idf/examples/protocols/aws_iot/certs/certificate_pem_crt
private_pem_key,file,string,~/esp/esp-idf/examples/protocols/aws_iot/certs/private_pem_key

Run the NVS Partition Generator command below.

Code to reproduce this issue
python ~/esp/esp-idf/components/nvs_flash/nvs_partition_generator/nvs_partition_gen.py ~/esp/esp-idf/examples/protocols/aws_iot/certs.csv certs.bin 8192
Debug Logs
  File "/home/andrew/esp/esp-idf/components/nvs_flash/nvs_partition_generator/nvs_partition_gen.py", line 775, in <module>
    main()
  File "/home/andrew/esp/esp-idf/components/nvs_flash/nvs_partition_generator/nvs_partition_gen.py", line 770, in main
    nvs_part_gen(input_filename, output_filename, input_size, key_gen, is_encrypt_data, key_file, version_no)
  File "/home/andrew/esp/esp-idf/components/nvs_flash/nvs_partition_generator/nvs_partition_gen.py", line 692, in nvs_part_gen
    write_entry(nvs_obj, row["key"], row["type"], row["encoding"], row["value"])
KeyError: 'value'

@mahavirj Any thoughts on this?

@asweeney99 Hi, we have started to look into this issue, @shivani-tipnis please help share if any updates, thanks.

@asweeney99 Hi,

Could you try this on master branch, there have been a couple of fixes on it.
Could you provide the absolute path in the certs.csv for the certs value instead of the tilde sign (~).

Superb. Thank you. Removing the space worked.

Maybe the documentation could be updated? Thanks again.

@asweeney99 Interim, please note that you may not null terminate certificate file (as you had mentioned in step 2), it will be taken care of being string type in NVS configuration.


American Samoa - Validate CSV files

Problem statement
The CSV structure needs to be tested with American Samoa. They will need messages sent through the test feed first as fake data. When that passes validation, then LIVE messages should be sent
Acceptance criteria

[x] Fake messages sent
[ ] STLT accepts CSV structure of fake messages
[ ] Live messages sent
[ ] STLT accepts CSV structure of live messages

To do

[x] Create CSV files from CLI with fake data
[ ] received feedback on fake messages
[ ] implement settings changes as needed
[ ] Send live CSV files from CLI
[ ] received feedback receive feedback on fake data

Email sent to<EMAIL_ADDRESS>with test CSV data

@sarahnw to reach out to Megan Light for re-engagmemnt strategy

Closing for now  until we get reengagement from Receiver.


Update href checker

Add vlinker to vendor so we can use the new home for the tools.
fixed some vet issues, not sure why other PRs didn't see this
updated vendor in a separate commit

oh I also added a new target in the Makefile so that we can rebuild glide.lock when glide.yaml is changed. Not sure how this was done before.

Why not try and get this into repo-infra?

that might be an option but for later...

The glide stuff was taken out of the makefile because we're checking in our vendored stuff now and it shouldn't be run in any normal flow. We do probably need to document what that flow is somewhere. Similarly to the upstream "if you change a godeps, run these steps...".

ok rebase and conflicts fixed

ok redone w/o glide this time - see what ya'll think


feat: LSDV-5296: Scroll container max height

PR fulfills these requirements

[X] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[ ] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[X] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[X] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[X] Frontend

Describe the reason for change
Add maxheight as a config attribute with a default of 500px and style scrolling window
What does this fix?
N/A
What is the new behavior?
The config attribute defines the maximum height of the scrolling window
What is the current behavior?
it takes up as much space as it's contents will allow
What libraries were added/updated?
none
Does this change affect performance?
no
Does this change affect security?
no
What alternative approaches were there?
we could have used flex box or javascript to calc the available space
What feature flags were used to cover this change?
fflag_feat_front_lsdv_e_278_contextual_scrolling_short
Does this PR introduce a breaking change?
(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[X] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[ ] integration
[ ] unit

Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Codecov Report
Patch coverage: 42.85% and project coverage change: -2.88 :warning:

Comparison is base (8c63614) 67.94% compared to head (d1a7468) 65.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1469      +/-   ##
==========================================
- Coverage   67.94%   65.07%   -2.88%
==========================================
  Files         397      436      +39
  Lines       26123    27408    +1285
  Branches     6984     7177     +193
==========================================
+ Hits        17749    17835      +86
- Misses       7007     9573    +2566
+ Partials     1367        0    -1367

Impacted Files
Coverage Δ

src/tags/object/Paragraphs/model.js
53.62% <ø> (+0.57%)
:arrow_up:

src/tags/object/Paragraphs/HtxParagraphs.js
75.55% <40.00%> (-3.47%)
:arrow_down:

src/utils/feature-flags.ts
100.00% <100.00%> (ø)

... and 258 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

/git merge master


Add ProgressEvent on NetworkingEngine. Allows for tracking progress of network transactions.

Hey
We thought it would be useful for users to see a percentage indication of re-buffering progress in certain cases. It creates a better awareness for available network bandwidth and overall a more transparent user experience. But also for analytics and internal player metrics reasons, it may be useful to be able to track the actual network buffers throughput (as much as browsers will allow it).
Hope this doesn't disrupt any architectural grand lines. Here is a summary of changes:

Makes NetworkingEngine an EventTarget
Introduces new event: ProgressEvent, with similar interface as the standard DOM ProgressEvent, see: https://developer.mozilla.org/en-US/docs/Web/API/ProgressEvent
Listenening to the networking engines' events should allow for measuring download progress of segments (or any other item downloaded)
Event data allows to track various transactions by their inner target, which my be an underlying XHR object (several transactions may happen concurrently, listeners can differentiate between their progress events)
Extension on the SchemePlugin interface
Updated testst

TODO:

[ ] Write tests

Before I write tests I'd like to make sure this is a viable approach with the other parties here on the project.
Cheers

I signed it!

Hey @joeyparrish
Concerning Fetch API, afaiu there will be a progress event too: https://developer.mozilla.org/en-US/docs/Web/API/FetchObserver, see onresponseprogress, and we may adapt our API our synthesize the ProgressEvent interface as known from XHRs. By the way it seems that the interfaces of the XHR and Fetch API progress events is compatible if not equal.
Thanks for you feedback! Very good point in fact about the current usability. Well to fully solve that we'd have to map segments requests' progress events to the actual SourceBuffer state I guess. That means for each request you have to know what part of the audio/video buffers it should cover. We currently lack that info in the network engine. But as we have these events from there now, and the info connecting segment URLs and buffer metadata, as well as re-buffering goal parameter, exists in other places, this event might bubble up to a more high-level one giving us actual buffer filling progress. Maybe this PR can be a first step in that direction.
On a more hackie way to approach it with what we'd have now, you might be able to just say: OK my segments are 5 seconds long, it is reasonable to set my re-buffering goal to 5 seconds. And then I'll just assume that the audio makes up a rather small part of the whole progress i.e the video being the main thing (it's all application dependent of course), and then you can indicate a re-buffering progress as the aggregate progress events on the first audio and video segments respectively, and weight them by 90% vs 10% for video vs audio respectively. That would give you a good indication of the progress anyhow. You may go even further and us the streamBandwidth from statistics and calculate that in against the audio bitrate (which may be 128k anyhow) to achieve a more precise audio vs video bitrate ratio estimation.

@joeyparrish Clear for the test, will write them now as you seem to say it is OK to make this contribution. I'll come up with some usage examples, I believe it is possible to provide some usable (event if fuzzy) presentation even when re-buffering goal is larger than a segment.

@joeyparrish added tests to networking-engine and http plugin. couldn't find any offline scheme implementation in the current version. where is it? for the data-uri plugin, i don't see how it makes any sense to add anything there, since we wouldn't have any async progress or so. compiler doesn't complain, at least on my local environment. could you confirm that? best regards

What I mean is that you changed the API for SchemePlugin, but you did not update the signatures of all SchemePlugin implementations.  Can you please update the parameters for the data URI scheme (lib/net/data_uri_plugins.js), the offline scheme (lib/offline/offline_scheme.js), and the test scheme (test/test/util/test_scheme.js)?
It would also be really helpful if you could demonstrate the usefulness of this extra progress info.  You mentioned using it to provide a progress bar in the buffering state.  Can you modify the demo app (demo/*) to do that?

@joeyparrish sure, will do that

With the event data and player state we currently can combine we can actually get a meaningful display of what is going on network-wise. I have been testing it with 3G network conditioning for example, and I think it proves to be quite useful. It looks a bit hectic when used with really short segments. We could avoid that by looking at the video element's buffered TimeRanges and the stream bandwidth to rather have an estimation of progress until rebuffering completes. Otherwise, what would be really useful would be if Schemes' would have, in the case of SEGMENT type requests, metadata of the segment, essentially the duration, which would allow mapping it to the rebufferingGoal and/or TimeRange objects.

I really like the idea of showing the user a meaningful progress bar while buffering.  When I test your implementation, though, I find that the progress bar jumps backward noticeably when I limit my network speed.  I worry that a progress bar that moves backward would be confusing.
If the goal is a progress bar, perhaps there is another way we can accomplish this.
Instead of the NetworkingEngine dispatching progress to the application, what if it dispatched progress for segments to StreamingEngine?  StreamingEngine has the context of segment references, buffering goals, etc., and could produce a more meaningful progress indicator (content fetched, sub-segment resolution) to the application.

@joeyparrish yes totally agree on your feedback, i noticed that too. that's pretty much the direction i'd go as well. proper progress indicator needs the context of segments and buffering goal. the application should get a more high-level event type that will allow to easily build a progress-bar that will work against the actual buffering goal in the time domain.
the current "moving backwards" is caused by the fact that the current display i built aggregates the loaded bytes across all pending requests. so when a request is added while one is already pending (like when fetching audio/video as seperate segments) then the total bytes amount increases, and the bar "moves backwards" because the ratio of loaded vs total bytes goes down. so it is really because we are showing progress against pending bytes vs actually using time-domain progress, which we would do with the approach to dispatch events via streaming engine as you proposed.

OK, so what I did is that we are now tracking each request (now ref is passed via net-engine progress event), and thus we are tracking per content-type a the bytes loaded during the buffering state of the player. When we are not in buffering state we dont dispatch the events and dont keep long track of the requests progress. We these trackers we can then make an estimation of the media-time loaded until now (assuming constant bitrate basically, will be more precise with shorter segments, but is precise over the segment length of course).
Using the media-time downloaded estimation vs the buffering goal works really well to display progress I find.
One could also display progress for audio and video seperately where appropriate.
So, I think we have something really going into direction of useful now. I have tested it with 3G emulated network and it was looking pretty good.
It certainly can be improved in certain cases. For some reason at startup sometime the bar doesn't go until completion, i.e we start before it expects to finish :)
This is kind off in a prototypical state, I haven't added tests or proper docs yet.
I just wanted to check wether we should keep going in this direction before adding these.
Best,

@joeyparrish was wondering if you had any feedback on this? :)

I'm sorry, but we are not keeping up with pull requests very well at the moment.  I promise to come back to this as soon as I can make the time.  Please accept my apologies for keeping you waiting so long.

Sorry for this getting lost, but a lot has changed with the networking API since this was made.  Plus we are going to be adding progress events as part of #1051.  I'm going to close this for now.  Once #1051 is done we can discuss exposing the progress events themselves so the app can display something like you have here.  Again, sorry that we weren't looking at this.

@TheModMaker Well, you shouldn't be sorry in fact 😆  I am rather sorry for you that you haven't been able to leverage my effort somehow.
Hopefully we can improve our efficiency in collaboration somehow in the future? 👍 What do you suggest?
It seems my initial idea wasn't bad in the first place, since now you are actually needing it for several other purposes. Why wouldn't you help me work on this and getting it into Shaka in the first place? :)

With #1051, the progress infrastructure supports an important feature within the library, as opposed to serving progress events up to the application.  Again, our apologies for losing track of this PR.

Serving progress events to the application is an important features as well, while I intuitively believe that any networking engine should in fact expose progress of ongoing transactions, as it allows for more fine-grain decision points, specifically like for aborting requests or switching qualities as with #1051. I am happy you have realized this as well.
In the end this isn't much different. A user who can see the progress events in the application as a visual feedback, can understand better that his bandwidth isn't sufficient and enforce a lower quality manually.
I don't quite understand what the apologies are about. Either we want to work together or not :) I am still not sure if there is actually a real interest for community contribution here, as there are several PRs I have done about a year ago that have somehow not really been given any feedback, although other people than me have adressed interest in these features.
Do you feel like there are more PRs done against this project than you can handle at reviewing, as a somewhat "dedicated" maintainer?
From my point of view, until now, even though I wanted too, it felt really hard to be able to contribute to this project.
Other community-driven projects might be able to overlap with the features Shaka offers, but be more community-accessible. Or Shaka might as well be forked and become more community driven.
I would like to point out I feel that currently there is a lack of community discussion and drive around this project, and seems to all happen very much behind the scenes.
For example, where is the roadmap for Shaka being discussed?


Multiple watchers

I want to run multiple watchers, i have 2 separate webpack entries with both other configurations + my regular gulp watch tasks. When i run the webpack tasks with watch: true, it hangs on the first task.
If i disable the watch argument, everything runs fine, but then i loose the awesome caching (quick rebuild) feature of webpack.

It's likely you don't need to run multiple watchers. Otherwise, since watching is a process gobbling event you would probably need to run them in separate processes.

@jtangelder How did you solved it?

It seems If gulp.watch task is declared first, then it works.
gulp.task 'default', ['watch', 'client', 'server']

Closing per my comment above.

Please can you explain "It's likely you don't need to run multiple watchers."? What If I need two separate scripts?

idk, I've always just used gulp's watch and never needed webpack's watch. I don't understand why anyone would need to run both simultaneously.

If you program consists of many files, the incremental build is must. Sorry, rebuild everything without incremental build is no-go for regular projects.

Incremental builds seem to work ok for me with webpack using gulp's watch.

@shama Are you sure incremental builds works for you with gulp's watch?
Can you explain how to verify it?
Thanks,
NaorYe

@naorye I pushed an example: https://github.com/shama/webpack-stream/tree/master/examples/incremental-builds

@shama Thanks!


Fix task timeout logic

Task timeout is not working well with JRuby. This PR will fix it.

Coverage increased (+0.9%) to 96.12% when pulling d2e480345db0425dea0332daadf4afa943955ede on better-timeout into 3e597d4fe895ec3534d44df0fb61b045d43411bf on master.


Add deadability matcher

Add deadability test.

@nelantone please add proper test for happy failure path ... (not test huh?) then please propose this change as well to official repository https://github.com/philostler/rspec-sidekiq to do your own contribution!! 💯

@pavel-jurasek-bcgdv-com .
Sorry for the delay, I was figuring out how to refactor and fix/understand some parts.
I will be happy to receive feedback.
Once you give me the thumbs up/merge it I will clean up/remove the code from the API.
díky!

@robert.koch Please take a look. In case it's all fine, please give  some 👍 & 🚢-it !
Thanks!


Uncaught TypeError: this.player.fastForward is not a function

I get this error Uncaught TypeError: this.player.fastForward is not a function on plyr 3.0.6 when using Right Arrow button.

Pushed v3.0.7 which has a fix for this...


Modify Format of Results Template

Center the Bill Summary Text under the Bill Title and reduce the text size and weight.

Limit the number of Sponsors to 10 (as to not clog the output)

Bold or heavier weight the first sponsor name (as he or she is the primary sponsor on a bill)

Did you really mean centered or indented?  I made it indented previously, and have now added bold, smaller text, sponsor limit, and bottom margin.  Take a look.

For the sponsors, it looks like the output of the function isn't actually a list but a string: str(list(output)) Regex up to "]," ?
Also, can we give the indented text a lighter weight still?

Doh on the sponsors.  By lighter do you mean the color or the weight of the text?  The color is easy to change, the weight may not be depending on the font, I'll have to investigate tomorrow.

Ok, ignore the weight, a lighter color is fine. If possible, a slightly smaller font than 'sponsors' would be ideal as well to show more contrast (nice to have, not must have).

Another issue.  If the list of sponsors is actually a text string instead of a proper list, it will be hard to reliably make the first one bold.  Guess we could chop on the bracket characters, are they guaranteed to be there?

Hi, take a look at my updates when ya have a chance.


Please, remove the "Delete" button if the node has no dgraph type.

Users can be confused and frustrated when trying to delete a node via the UI. Because when a node does not have the predicate "dgraph.type", it is not possible to delete it. It is necessary to add a well-defined Type to be able to do this. And Dgraph can't do it automatically.
See this user experience here https://discuss.dgraph.io/t/ratel-delete-node-function-query-seems-wrong/6071/4
If this is already implemented, please just close this.

Thanks Michel.


iOS - Browse catalog should have one more tab 'Programs'

Description
LEARNER-2363
Notes
Update COURSE_ENROLLMENT Configurations and add PROGRAM_ENROLLMENT configurations.
COURSE_ENROLLMENT:
    TYPE: 'webview'
    WEBVIEW:
        SUBJECT_DISCOVERY_ENABLED: true
        SEARCH_URL: 'https://webview.edx.org/course'
        DETAIL_TEMPLATE: 'https://webview.edx.org/course/{path_id}'
        SEARCH_BAR_ENABLED: true

PROGRAM_ENROLLMENT:
    TYPE: 'webview'
    WEBVIEW:
        SEARCH_URL: 'https://webview.edx.org/course?program=all&mobile_only=true'
        DETAIL_TEMPLATE: 'https://webview.edx.org/{path_id}?mobile_only=true'
        SEARCH_BAR_ENABLED: true

@salman2013
PR is ready for another pass.

@salman2013 PR is ready for another pass.

@zeshanarifios once you fixed the conversation please try to comment and mark it as resolve conversation.

@saeedbashir I have reviewed this PR, Please take another look into it and approve for merge when you are done.

@zeshanarifios Can you please rebase your branch with origin/master and resolve conflicts.

@saeedbashir I have rebased my branch with origin/master, please review it again.

@saeedbashir
PR is ready for another pass.

@zeshanarifios Please add Find Programs and Program Info screen events for program discovery screen and program details page respectively.


Excel Labs fails to load in excel 2019

Is there a fix to load Excel Labs in Excel 2019? Please let me know. Thank you.

I have windows 10 home edition with MS office 365 installed. I tried adding Excel labs (Advanced formula environment) and it fails to load.


chinaeast2 server for Android LUIS SDK fails because of malformed URL connection

Describe the bug

chinaeast2 server supports LUIS Azure intent recognition and operates on a separate portal than the Western Azure.
When using the chinaeast2 LanguageUnderstandingSubscriptionKey, LanguageUnderstandingServiceRegion, and LanguageUnderstandingAppId, the Intent Recognition fails with a Canceled error because the URL in the Java Android SDK is incorrect when trying to access the LUIS server.

Using a packet sniffer on the Android Device,

The Android cognitive-services-speech-sdk for LUIS specifically tries to access

chinaeast2.sr.speech.microsoft.com.mshome.net

And it fails repeatedly because that URL does not exist.
While trying the chinaeast2 servers for Speech-To-Text, it works,

We can see that the format of the Speech-To-Text Java SDK URL is:

chinaeast2.stt.speech.azure.cn

That Speech-To-Text URL above is valid.
So I think that the internal URL that the Java Android cognitive-services-speech-sdk is accessing for chinaeast2 LUIS is invalid.
To Reproduce
Steps to reproduce the behavior:

I used both https://github.com/Azure-Samples/cognitive-services-speech-sdk/tree/master/quickstart/java/android/intent-recognition and https://github.com/Azure-Samples/cognitive-services-speech-sdk/tree/master/samples/java/android/sdkdemo
I changed LanguageUnderstandingSubscriptionKey, LanguageUnderstandingServiceRegion, and LanguageUnderstandingAppId to use the chinaeast2 key, appID, and region.
LUIS for chinaeast2 can be found at: https://luis.azure.cn
You can create a LUIS app just like on the Western servers. The chinaeast2 servers are also using a valid up-to-date 3.0 API that be validated through POSTMAN or testing any POST request.
I built the Android APKs and deployed them to my phone. Testing the chinaeast2 servers for Speech-To-Text and other cognitive servers worked, but LUIS would fail with: ErrorCode = ConnectionFailure. ErrorDetails=Connection failed (no connection to the remote host).

Using a packet sniffer, you can see that
"chinaeast2.sr.speech.microsoft.com.mshome.net" is probably a malformed URL.
And
it's probably supposed to end with azure.cn instead of microsoft.com.mshome.net

Expected behavior
When the Java SDK is working for the western servers, after pressing Recognize Intent, I can say a few words and get an Intent response back:

Version of the Cognitive Services Speech SDK
I have tried both 1.14.0 and 1.15.0 and 1.17.0

com.microsoft.cognitiveservices.speech:client-sdk:1.14.0
com.microsoft.cognitiveservices.speech:client-sdk:1.15.0
com.microsoft.cognitiveservices.speech:client-sdk:1.17.0

Platform, Operating System, and Programming Language

OS: Android
Hardware - ARM64
Programming language: Java

Thanks for pointing this out. There's a couple of different problems.
First, the SDK is incorrectly building the URL's for the IntentRecognizer for China* regions. I've got a bug tracking this in our internal database.
Second, even if the URL was built correctly, not all the components for the Speech->LUIS integration are deployed in China East2. So you'd get back recognized speech, but not recognized intents.

Thanks Ryan!
I could be talking about something completely different for the 2nd thing you mentioned, but for the Speech->LUIS Integration Intent Recognition,
the China East 2 REST API seems to recognize speech and intents like for example:
Saying Open Main Menu returns a few predicted intents:

The Speech SDK doesn't use the REST API, but talks to a different stream based endpoint.
That stream based endpoint doesn't have the LUIS integration deployed.
You can try overriding the SDK's host generation by using code like:
var host = "wss://chinaeast2.sr.speech.azure.cn";
var speechConfig = SpeechConfig.FromHost(new Uri(host), "key"); // ChinaEast2 LUIS Key

(My test app is in C#, not Java...)
(Or I mis-configured my LUIS test app in azure.cn)

I see what you mean, Ryan. I have tried your suggestion in Java, and the WebSocket failed with the following:
06-29 21:22:10.811 15100 15202 D CANCELED: Reason=Error
06-29 21:22:10.811 15100 15202 D CANCELED: ErrorCode=Authenticati
onFailure
06-29 21:22:10.811 15100 15202 D CANCELED: ErrorDetails=WebSocket
upgrade failed: Authentication error (401). Please check subscription informati
on and region name.
06-29 21:22:10.811 15100 15202 D CANCELED: Did you update the sub
scription info?

That error means you have the wrong key.
I'd have expected RecognizedSpeech for the reason instead of RecognizedIntent. Make sure to use the prediction resource's endpoint key and not the LUIS app's authoring key.

You are right. ResultReason was ResultReason.RecognizedSpeech and not ResultReason.RecongizedIntent. I was using a US LUIS Prediction Key instead of the China East 2.

Hi @huy-ffd, I understand from the thread that you were able to solve your issue. Will close this item but please feel free to create a new one if you need further assistance.

I did not solve the issue, @glecaros

The Cognitive Services SDK is still incorrectly building its URL for the IntentRecognizer for China* regions.
Speech->LUIS integration are deployed in China East2 does not have all the components like a websocket on the Cognitive Services End.

Ryan was just showing me how he knew that all the components on the Cognitive Service was not setup on the China East2, and I was following his method of testing the China East 2 LUIS Intent Recognizer.
So the issue that China East2 LUIS server fails because of malformed URL connection still exists.

Got it, reopened the issue. Sorry for the confusion.

Internal work item ref. 3622485.

There are no plans to support LUIS based IntentRecognzier in China regions. There is a way to make IntentRecognizer with simple pattern matching work in China regions. Please open a new issue if you would like to use simple pattern machine in China region and we can assist you with that. Closing this issue.


Explore solutions for enhancing OOP in high-level resources

Although JAX promotes a functional programming pattern, it's often useful offering to downstream users also OOP resources that usually simplify the learning curve.
Jaxsim follows a similar approach:

All resources inside jaxsim.physics are functional.
All resources inside jaxsim.high_level are object-oriented.

We are currently trying to simplify the application of jit/vmap transformations (see #44 and #48), but there are some use-cases related to r/w classes like high_level.link.Link and high_level.joint.Joint that are still a bit rough (see 48#issuecomment-1746635121).
It would be interesting exploring solutions like those discussed in https://github.com/google/jax/issues/7919 and https://github.com/google/jax/discussions/17341, with some extra detail provided in https://github.com/ami-iit/jaxsim/pull/48#issuecomment-1753204287.

We eventually decided to migrate towards functional APIs. The OOP resources have been removed and merged into main in #108.

For those reading this issue in mid 2024, there's an experimental attempt of using PyDags for OOP in Flax:
https://flax.readthedocs.io/en/v0.8.3/experimental/nnx/nnx_basics.html
In their case, the new classes hold both the NN structure and the state (parameters). A caveat -at first look- is that they had to create a new decorator (rings a bell with our previous OOP pattern) for JIT compilation to handle stateful arguments.


[Doc] Add authenticateMetricsEndpoint option in administration-prox…

Hi!
I found a missing parameter on the documentation of the Pulsar-Proxy.
Motivation
The parameter authenticateMetricsEndpoint was explained in the Pulsar Configuration guide but not on the Pulsar-Proxy dedicated page.
Modifications
I added the missing parameter in the dedicated page, as it was the only missing parameter based on the main Pulsar Configuration guide.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Have a nice day :sun_with_face:

run java8 tests
run integration tests

Thanks :smile:


GitHub workflows: Use Java version in matrix, cache functionality of actions/setup-java@v2

Currently, GitHub workflow does define the matrix of Java versions, but not use them at all. So I've fixed it along with a simplicity improvement.
References:

https://github.com/actions/setup-java#testing-against-different-java-versions
https://github.com/actions/setup-java#caching-maven-dependencies

You can see the difference of duration.

Making cache(5m 38s): https://github.com/spring-cloud/spring-cloud-openfeign/actions/runs/1336977215
Using cache(2m 5s): https://github.com/spring-cloud/spring-cloud-openfeign/actions/runs/1337010590

@OlgaMaciaszek I want to re-ask: can you add the hacktoberfest-accepted label to this PR?


running error

Hi, wentao
Here is an error when I run the inbreast.py :
Traceback (most recent call last):
File "inbreast.py", line 292, in
traindata, trainlabel, testdata, testlabel = loaddata(0, 5)
File "inbreast.py", line 200, in loaddata
ims = loadim(mydictkey[trainindex[i]]+'.pickle', aug=aug)
TypeError: loadim() got an unexpected keyword argument 'aug'
It will be grateful if you can help me to solve the problem.
Danyang Li

Hi Danyang,
You can try to comment the aug parameter.
Thanks,
Wentao

Hi wentao
I have solved it. Thanks very much!
Danyang Li


New Version : H3poteto.whalebird desktop v6.0.0 beta.0 3 c6 aaa49

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @itsAdee,

This PR's version number aaa49 has 1 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 5.0.6, which has 3 parameters.

Is this intentional?
(Automated response - build 677)

Hi @itsAdee,

This PR's version number aaa49 has 1 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 5.0.6, which has 3 parameters.

Is this intentional?
(Automated response - build 677)
Edit: Since you're the usual uploader of this package, I'll assume so. If not, please let me know.

yes it is intentional :)

Hi @itsAdee,

This PR's version number aaa49 has 1 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 5.1.1, which has 3 parameters.

Is this intentional?
(Automated response - build 680)


Migrating the docs to Docsify

For aesthetic and ease of use we're migrating the docs to Docsify because it relies on simple Markdown and allows the source files to be easily edited.

Successfully moved typedoc to docsify for customization reasons.


Unexpected end of input (not same as one before)

As the title says, my issue is an "unexpected end of input" error.  I have a HTTP web server I'm writing using an example from the Boost.Beast library, and in it I want to send a request to a currency API that gives back its response as JSON data.  I'm trying to use this library for that.
I don't know what exactly caused the problem, but I can provide a link to a Gist with all of my code here at least: https://gist.github.com/DragonOsman/9a7d4ee116efc575dece7d6de46bd31d . The HTML and JavaScript files provided are also part of the project and may be needed to reproduce the issue.
The expected behavior for the JSON part is that I should get back a conversion rate as JSON data that would be stored in my cache storage.
The actual behavior is that I have a message that says there's an unexpected input error, and it seems like the response body I was expecting isn't there.  There are other problems in the program itself, but I don't think I should talk about them here since this is about the JSON library.
The compiler I'm using is MSVC, latest version.  Visual Studio 2017 IDE.  OS is Windows 10.
This is not a bug report, just an issue I'm having that I thought I should ask about.  Any help would be appreciated.  Thanks in advance.
Edit to add: I forgot to say this earlier; I used ParcelJS to build my front-end code to make the country-currency-map stuff work.  It runs its own server, though, so I had to close that and then run the application which has its own server.

I'm making this post to add something I'd forgotten earlier:
I used ParcelJS to build my front-end code to make the country-currency-mapstuff work. It runs its own server, though, so I had to close that and then run the application which has its own server.

The error message means that the text you passed to the parser is invalid JSON. If you use the latest version of the library, the error message will be more detailed (e.g. parse error at 2: unexpected end of input; expected string literal) and also contains the byte position of the error (in the example above: 2).
In your linked example, I assume the error stems from
			found = m_cache.insert_or_assign(found, query_data, std::make_pair(std::chrono::steady_clock::now(), json::parse(res.body())));

Could you provide the content of res.body()? I assume it is empty or any other non-valid JSON text.

I believe that res.body() is an empty string.  As you can see in the program output I gave above, the space in front of the message body received is:  part has nothing in it.  I tried to print res.body() there.
This code:
                       std::string host{ "openexchangerates.org" }, api_endpoint{ "/api/latest.json" }, base{ "USD" },
				app_id{ "8974a3dc97e3409392c97825a8978eb4" }, symbol{ query_data }, prettyprint{ "true" }, show_alternative{ "false" },
				target = api_endpoint + "?app_id=" + app_id + "&base=" + base +
				"&symbols=" + symbol + "&prettyprint=" + prettyprint + "&show_alternative=" + show_alternative,
				port{ "443" };
			int version = 11;

			// This object and the TCP socket perform our IO
			tcp::resolver resolver{ m_ioc };

			// Look up the domain name
			const auto results = resolver.resolve(host, port);

			// Make the connection on the IP address we get from a lookup
			boost::asio::connect(m_socket, results.begin(), results.end());

			// Set up an HTTP GET request message
			http::request<http::string_body> req{ http::verb::get, target, version };
			req.set(http::field::host, host);
			req.set(http::field::user_agent, BOOST_BEAST_VERSION_STRING);

			// Send the HTTP request to the remote host
			http::write(m_socket, req);

is where I'm trying to construct the host and port strings, get the IP address, and send the request to the remote host.  I wonder if the API I'm sending the request to expects a JSON request.  If it doesn't, then I don't understand what's wrong since I'm sure I gave it the correct URL.

Well then we know why there is an error message. I guess there is nothing wrong with the library at this point.


Backport "Only evaluate transparent inline unapply once" to LTS

Backports #19380 to the LTS branch.
PR submitted by the release tooling.
[skip ci]

No regressions detected in the community build up to lts-20227.
Reference


Fix SDK version reports as node:unknown

This code was out of date after #224, leading to the package.json being not found

Do you want to release it in 0.20.1 or 0.21? Please assign a milestone.

Let's do 0.20.1. This is worth including in a point release if we make one. If we end up not having one, I'll move to 0.21


Fix race with CTS disposing

Fixes https://github.com/aspnet/AspNetCore-Internal/issues/2293
DisposeAsync will dispose the CTS and then set it to null, however we could still try to cancel it between the dispose and the null resulting in ODE.
Couldn't think of a great way to do this without locking, but it shouldn't be a contested lock so it's fine.

Ping, I modified this a little since when it was approved.
Had to do some ugly test hackery to try to make the test do what it claimed to be doing.

/azp run all

@BrennanConroy do you want to try and get this in today for preview 2? Assuming not (because of the milestone) I've labeled this "NO MERGE" so we hold off on merging until the branch is open for preview 3 changes.

I don't want to rush it, but it would be nice to fix in 3.1. Fixes most LongPolling tests from being flaky

Cool. I believe we stay in M2 approval for Preview 3 so let's bring it up then. Especially if it reduces test flakiness :).

Branches are open again for preview 3 work, but this PR does still need @Pilchie approval before merging.

Approved for 3.1 Preview 3.  Thanks @BrennanConroy.


Feature/typescript

This PR replaces microbundle by Typescript to build the library in order to provide a better usage with VS Code and moder IDE's (autocompletion, live documentation, etc.).
The changes introduces the following changes:

Files in the src/ folder must have a  .ts extension
Files in the src/ folder can use the awesome features of Typescript (but vanilla JS will still work)

Closing this PR as it is too soon for Typescript.


Update README.md improve code example

As #246 this is an fixed version, to also get JS modules, and Theme Styles.
Further than that, we output to the console a full working document.

I wasn't happy, because I believe DX could be improved.
Now we get the output, and generate an index.html file.
I'm sure people will know what to do with this 😄
// Output HTML to the console
console.log(htmlDocument)

// Run `node generate-html.js` to generate the HTML file
// and open it in the browser
fs.writeFileSync('index.html', htmlDocument)

Let me know your thoughts! ❤

Thank you so much for taking the necessary README update into your hands and creating this PR!

Thank you for creating such an awesome library!!

I love your idea of outputting an actual HTML file in the example, this feels so much more complete. Especially given the fact that this is a low-level package where you need to do more work yourself, I think this is great to show how the API works.
I tested your code and made a few minor adaptions and remarks, please have a look. :)

Thanks! I'm glad you enjoyed it. The most convenient starting point, at the lowest energy spent. :)
All adaptions made sense. Also, learned there were "batches", so I didn't have to commit one by one lol.
I pulled again, tried it on my end, everything's great!

Also, for consistency sake, shouldn't the examples on both readme's be the same, or link to a single one??

Good point regarding the core readme example!
They cannot be completely identical as the core example must import from @expressive-code/core and can only use the ExpressiveCodeEngine class.
The rendered result will also be different as the core package does not have any plugins bundled, so there will be no highlighting (which is done by plugin-shiki), no frames or copy buttons (plugin-frames), and no text markers (which is the only plugin that doesn't affect this example as it doesn't use markers).
Still, the core example would definitely benefit from everything you added to the expressive-code readme, so a version of it adapted to use only core functionality would be the optimum I think.
How would you like to proceed? Merge this PR as is and tackle the core readme update separately, or add it to this PR? I'm open to both approaches!

Yeah, both are valid! 😄
Maybe merge this right away, it might help someone, while I don't do the other one.
I'll come back on the next few days and do the README of core package 👍

Perfect, let's do it like that!
The new readme will be visible on GitHub right away and on NPM with the next version update, which is going to be in a few days.
Thanks again for your work!


KAFKA-1901: follow-up on KAFKA-1901; Added error handling.

@guozhangwang  added .git/refs/heads/ file existence check.

@omkreddy If there is no file exist in .git/refs/heads, could we search in .git/packed-refs?

@guozhangwang  Yes, we can implement. But there may be other git scenarios, we may get similar exception. Current patch captures git commitID, if we are building on trunk/branch/tag (these common ways of building, for other scenarios it will just returns "unknown" commitID.  I feel current functionality is sufficient for  general build scenarios.  Let me know your thoughts.

@ijuma thank for the review. I just removed unnecessary else block.

@guozhangwang Do you want to check this PR again?

LGTM. Merging to trunk.


Icon upload enhancements

[x] UI when changing the icon to be uploaded (currently displays both filenames)
[x] Delete the old icon if you change path of an uploaded icon
[x] Delete the old icon if the icon's row is deleted on galleries#add_new
[x] Allow uploaded icons to be changed (currently doable by uploading a new icon and then using the 'replace icon' tool)
[x] Handle errors properly with multi-upload ('Can't display the filename when rendering the error page in galleries#icon')
[ ] Sort the list as icons upload, especially with multi-upload
[x] Show a preview of the image once it's uploaded

Some progress made in #409

Icon sorting may not be necessary tbh?

I think you are right that icon sorting was probably as an alternative to icon previews; going to close for now, can revisit if requested.


Clickable background issue

Is it possible to make the buttons in the background still clickable while displaying a dialog or overlay in the foreground?

@sabreys this issue is related to issue #18 and it's fixed with this PR
please verify that you are using the latest version of the package


Start opening a gitter Channel

Hi ArangoDB Team,
i think it would be great to start a arangodb gitter Channel (Room/Community) here https://gitter.im/
I think there are a lot of people they have quick/short questions and need quick/short answers.
Greetings mok

Hi @mok-liee, we're already using slack - https://slack.arangodb.com/ feel free to join ;-)


Count error rate very high after merge (hll++)

every time I merge 2 hll++ with precision = 18. I find that the count result is totally wrong

func HashFnv1(str string) hash.Hash64 {
    hashed := fnv.New64a()
    hashed.Write([]byte(str))
    return hashed
}

func BenchmarkHLLPP(b *testing.B) {
    hll1,_ := hyperloglog.NewPlus(18)
    hll2,_ := hyperloglog.NewPlus(18)

    for i := 0; i < 1000; i++ {
        hll1.Add(HashFnv1("entry_1_"+strconv.Itoa(i)))
        hll2.Add(HashFnv1("entry_2_"+strconv.Itoa(i)))
    }

    b.Log("count hll1 = ", hll1.Count())
    b.Log("count hll2 = ", hll2.Count())

    for i := 0; i < b.N; i++ {
        hll1.Merge(hll2)
    }
    b.Log("count hll1 | hll2 =", hll1.Count())
}

gives me this
BenchmarkHLLPP-4 	   50000	     36267 ns/op
--- BENCH: BenchmarkHLLPP-4
	operation_test.go:160: count hll1 =  1000
	operation_test.go:161: count hll2 =  1000
	operation_test.go:166: count hll1 | hll2 = 244
	operation_test.go:160: count hll1 =  1000
	operation_test.go:161: count hll2 =  1000
	operation_test.go:166: count hll1 | hll2 = 244
	operation_test.go:160: count hll1 =  1000
	operation_test.go:161: count hll2 =  1000
	operation_test.go:166: count hll1 | hll2 = 244
	operation_test.go:160: count hll1 =  1000

It looks like fnv hasher might not be giving very uniform hash values. Have you tried using a different hash function like MD5 or Murmur3?  If I print out the hashes generated from fnv they look like this:
...
0xc2081194a0
0xc2081194f0
0xc208119540
0xc208119590
0xc2081195e0
0xc208119630
...

And if I edit your example to append a random string to each Add call, the numbers look much better:
BenchmarkHLLPPBug	   50000	     36573 ns/op
--- BENCH: BenchmarkHLLPPBug
	bench_test.go:87: count hll1 =  1000
	bench_test.go:88: count hll2 =  1000
	bench_test.go:93: count hll1 | hll2 = 1999
	bench_test.go:87: count hll1 =  1000
	bench_test.go:88: count hll2 =  1000
	bench_test.go:93: count hll1 | hll2 = 1998
	bench_test.go:87: count hll1 =  1000
	bench_test.go:88: count hll2 =  1000
	bench_test.go:93: count hll1 | hll2 = 1998
	bench_test.go:87: count hll1 =  1000

Interesting, I am using fvn hash for other purpose and just add each of them into an HLL object. I might consider using Murmur3.
Thanks a lot.


Remember already opened preview in embedded browser

Similar to #92 but for the embedded browser:
Current behaviour is that any pre-existing editor group html preview tab is replaced by the new preview tab.
It would be useful to have more than one preview tab open at a time so I can see the results of running VSCode tasks that modify more than one file at a time.

We currently don't have plans to support multiple embedded windows, see rationale in #84.


Added writing time and speed to the logfile

More information about writng history files is sent to the log file
Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist:

[x] I have tested this change with a run of GEOSgcm (if non-trivial)
[x] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[x] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

This PR replace the PR #2087

@mathomp4 @tclune , Maybe we can add information like DONE_FIFLENAME to the logfile so Bill would know a file is completed.

This is what it looks like
Writing time:     0.078 s, speed:     1.156 MB/s, size:     0.090 MB, at server node: 0, of rank: 3, file: test_writing_prof.geosgcm_budi.20000415_0000z.nc4
Writing time:     0.023 s, speed:   369.882 MB/s, size:     8.667 MB, at server node: 0, of rank: 1, file: test_writing_prof.geosgcm_prog.20000415_0000z.nc4
Writing time:     0.093 s, speed:    29.392 MB/s, size:     2.728 MB, at server node: 0, of rank: 2, file: test_writing_prof.geosgcm_surf.20000414_2230z.nc4


[BUG] Google Fonts Muli is now named Mulish, but it isn't reflected in the package

Describe the bug
Google Fonts' Muli has been renamed to Mulish, but is still available in google_fonts as Muli
To reproduce
Steps to reproduce the behavior:

Open lib/google_fonts.dart
Look for Muli references - the static member named muli links to the https://fonts.google.com/specimen/Muli, which produces a 404

Expected behavior
Muli references should be replaced with Mulish ones
Additional context
https://fonts.google.com/specimen/Mulish
https://www.reddit.com/r/fonts/comments/i1b44r/did_google_remove_muli_font_from_its_collection/fzw7cd1/?utm_source=reddit&utm_medium=web2x&context=3

Mulish is now available but you're right that Muli is still present. I'll repurpose this issue to remove unavailable fonts


Bulk delete

Added bulk delete endpoint and bulk delete support.

This is why I did not do it like that,
warn This endpoint has a rate limit of 1 request per second per guild, and is limited to
100 messages per request.
The request will fail if less than two snowflakes are provided.
Only bot accounts can use this endpoint.

Great job @VagantemNumen and thanks a lot for the help! I really appreciate it!


Testing

To do

[ ] code-server now maintains all user data in ~/.local/share/code-server, we need to move them here in the upgrade script

!testme

This upgrade need to be manually tested.
The upgrade should not delete extensions etc...


Arbitrary value with brackets within arbitrary attribute doesn't work

Example
_="(.FancySelect__control:hover) border-c-(var(--brand-color)) shadow-(0_0_0_1px_var(--brand-color))"
How the above rule border color generated

Checking on dev tools

Hi
This problem is now fixed in RC version. Please test that with npm i mojocss@next.
Thank you