Question on PTM_RX_DELAY parameter

Hey Michael,
Earlier today (Thursday) you confirmed that the intent for the pl_ptm_rx_delay[7:0] signal is to be the PTM_RX_DELAY parameter expressed in nanoseconds, where the clock to ns can be gleaned from the LPIF_CLOCK_RATE parameter.
In Gen2 Full rate, this can be in increments of 0.5ns. How do you want us to express that? Round up / down? Or can we assume PTM_RX_DELAY will always be even if we are in Gen2 Full rate?
Related, since pl_ptm_rx_delay[7:0] is 8 bits, that limits the value of PTM_RX_DELAY to 127, 255, or 511 or smaller for Quarter, Half, or Full in Gen2 (and 127, 255 for Half, Full in Gen1). Am I understanding that correctly?
Thanks,
John

Rounding should be fine. Please round down as that is simpler and this is not intended to be perfectly representative signal. The limits are not making sense to me though. Eight bits is sufficient for representing an integer value between 0 and 255. But in any case the expected values for this link are well under 127. The LogPHY adds a single cycle of latency and the PHY layer will only add a dozen or so more cycles in the worst cases. At 500MHz this still put the reported value at ~30ns worst case.

Had good conversation with Michael earlier and we generally agreed on the above understandings, but Michael did want to think on the pipeline vs PTM ramifications a bit.
I'm marking this as fixed, but I'll leave to Michael to close when he is ready.

We are aligned. PTM_RX_DELAY should be used for pl_ptm_rx_delay[7:0] and remain independent from LPIF_PIPELINE_DELAY. Closing this issue.


Translation ?

Hi,
Thank you for this very well done GUI.
Is this possible to submit translation (French), and if so, how to proceed? Same question for mupen64plus-qt.

Yes, very possible. You would use Qt Linguist to work with a TS file.
See this for more information:
https://doc.qt.io/qt-5.5/linguist-translators.html
This page might also interest you as well:
https://doc.qt.io/qt-5.5/linguist-manager.html
I'll get this setup for you when I have some time.

I have began to read these pages.
Qt Linguist is now installed.
With command line :
lupdate -pro  mupen64plus-qt.pro  -ts mupen64plus-qt.ts
I have obtained a file to translate in QT Linguist.
Correct me if I'm wrong. Then I must give you the ts file to compile.

Yes, that's the general idea. If you want to wait a few days though, I'm going to go through the source code and see what text I've missed marking as translatable since I was lazy at points with that while coding this.

Of course.  I just wanted to be sure that I could do this translation, because I am not a developer. But no need to rush (by the way, English is not my native language, so if what I say seems sometimes strange, that is normal...).

Your English seems fine to me.
I've added the .ts file you can work with at resources/locale/cen64-qt_fr.ts. If you want, you can fork the repository and then edit that file and submit the changes as a pull request. Let me know if you have any questions or issues.
There could also be text left that doesn't appear within the .ts file for you to translate. If you spot some, let me know.
I've also added the ability to change the language under Settings->Configure->Other->Language. Currently changing the language to French will do nothing since nothing has been translated yet, but if you want to test out your translations, run lrelease cen64-qt.pro to generate the .qm file and then recompile the application.
I've also added these changes to Mupen64Plus-Qt if you want to translate that as well.
Thanks for translating this!

ok, I have tried and it works fine. I begin the translation, it wil take me probably several days, or 1 week if I have less time than I thought.

Almost done. I can't finish the translation in the next day, but there is no problem to finish what remains (5-10%) very soon.

Alright, thanks! No rush.

Did you finish the translation?

ok, this is not perfect. I would have probably  to make some changes later,  but I think it is good for now.

Awesome thanks!
I've updated the .qm file so the development version now compiles with the translation and also fixed a few minor issues with spacing in the settings dialog.
Also added one more translation I missed before: "Game Cover" under QObject if you want to translate that. "No Cart" under MainWindow is untranslated as well.
Thanks so much for doing this!

I've also merged as much of this translation into the Mupen64Plus-Qt translation to aid you if you want to work on that one as well.


Manager not picking up some required mods

Hey guys,
Thanks so much for the manager! I've noticed some required mods not being flagged. This screen shot shows the required karank mod not being flagged as missing mod, even although it is on the steam workshop. I feel like I had this issue with another mod the other week as well.
Regards,
Jack

Hey guys! I was just curious if there's any more info you need about this?


doc: missing npm run build step

I copied the snippet provided to create a GitHub action and used it to publish to npm.
As npm run build is missing in the action, I ended publishing an empty package to npmjs.

That step isn't needed in every project though.

Typically, if the build step is required for publishing, you'd put npm run build in a prepublishOnly script, so you don't have to remember to do it.

There's also a chance your package has no files in it in the first place - copy-pasted snippets can't work for every possible situation, but if you're following best practices (like including your build process in a prepublish step) then it should work fine.

Let's close it then.


Limit diagnostics by range in getCodeActions

Fixes #90

Thanks, this PR looks great. I'm seeing this build error locally too, wondering whats changed. Taking a look into it now

Hope you dont mind but I've rebased this which should fix the tests


bug(extension): storage onChange not polyfiled

https://github.com/AceLikesGhosts/ytm-rpc/commit/b7f95ac4eb4931ad2b6488ca7d9615e7bec55fc6

fixed


fixing lmdb.cc when compiled on Windows (mkdir -> _mkdir)

Should fix #462 .

Ah, I should check not only _WIN32, but that the target is Windows - any suggestions how to do it?

Actually, seems like Travis and Appveyor fail not because of my changes...

Thanks for the fix - the continuous build might be just having an out of time error.


Stepper value changed from 1

I hace setup GMStepper in my UITableViewCell. In cellForRowAt indexPath method I am setting its textlable value like this:
cell.stepper.label.text = String(receive_Cart[indexPath.row].quantity)
value is displaying correctly.
But when I changed its value by + or - it is not changing relative to value which I set in cellForRowAt indexPath.
Example: The stepper label is set to 3. I have press + it should display 4 but it is displaying 2
I have made a delegate of cell and function for stepper:
func stepperValueChanged(cell: CartCell) {

    }

Can we know which button pressed plus button or minus button?

@ibhavin how did you solve the issue of knowing which button pressed plus button or minus button?


chore: Use PAT for semantic release to push on protected branches

This PR is included in version 0.2.1 :tada:


RocksDB: Fix SST ingestion

What is changed and how it works?

Issue Number: Close #17691

What's Changed:
Update RocksDB to include fixes for ingestion

* https://github.com/tikv/rocksdb/commit/31eb76b1bc82740c9b85a2462804130857df0577
* https://github.com/tikv/rocksdb/commit/cf9cd5b89217fe49d22194af8ae67aaecf0ba231

Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[x] Need to cherry-pick to the release branch

Check List
Tests

[ ] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

Fixing SST ingestion slowness after RocksDB upgrading

/retest


Ignore IntelliJ '.iml' project file

Thanks for the patch. Do you have an Apache CLA on file?

Obviously my first commit to an Apache project :) I just submitted my signed ACL to Apache...

Thanks for the first contribution!

thanks for the contrib 🌮


Temporary disable a p2p test (sporadic failures)

I'd rather keep the test failing in CI and rerunning when it fails. It should stay as a reminder that there's an issue until we have the time to fix it. We will have time soon enough.

I'd rather keep the test failing in CI and rerunning when it fails. It should stay as a reminder that there's an issue until we have the time to fix it. We will have time soon enough.

OK, sure, no problem.


add animation in podcast description button

Hopefully close #47
I have used StreamController to trigger animation instead of SetState() because the parent widget was rebuilding the whole description Text widget instead of animating.
I am open to suggestions if there is a better way to achieve this. Though I think this one isn't bad either.

Hi @GouravShDev, your solution seems to work fine.
Therefore, I see a few possible improvements.
Ergonomics
text 'jumps' on animation start
This can be fixed with the property alignment: Alignment.topCenter, on the AnimatedSize widget.
Bottom ShaderMask should be disabled when description is expanded
Technical solution
As you mentioned, using setState triggers a widget rebuild, which is perfectly normal.
You can get a working animation with that solution (see solution proposal ⬇).
Here is a working implementation with the few improvements mentioned.  (I didn't know how to share that improvement proposal, so I created a temporary PR)
https://github.com/amugofjava/anytime_podcast_player/pull/85/files

I'll push another commit with proposed changes.

This is great, but I wonder if it is possible for the text to be part of the closing animation rather than jumping. If you look at the animation below, which is slowed down, you can see when the description is collapsed the text disappears and then the animation starts. Compare that with the list tile and you can see the text is part of the animation.
device-2023-02-25-110256.webm
This is a definite improvement so I am happy to accept this and the animation could always be improved at a later date.

@amugofjava, Ok I understand what you trying to say. For now, if you want you can accept this merge. I'll work on the improvement in text animation after some time and add another PR.

Thank you for your input on this issue.


switch to HFS+ for release dmg

It would be nice to switch release dmgs to HFS+.
The release dmg seems to contain an APFS partition. This prevents MachOExplorer from being installed on older versions of MacOS. The app itself does not seem limited to newer versions of MacOS.

Thanks, I will fix it in two weeks along with some other bugs.

I can confirm that https://github.com/everettjf/MachOExplorer/releases/download/v1.0/MachOExplorer.dmg is now HFS+ format.
Note however that the minimum OS version to run the app is 10.11 (which I assume is due at least in part to use of Qt 5.10).

@follower Thanks for your confirmation.
Yes, it is based on Qt5.10.


Implement HTML reporting as part of fetch-raw sub-command

This adds the --html flag to the fetch-raw subcommand, which will
generate a report for all the raw results it gets.

Pull-request updated, HEAD is now aa94cfc56be7bdb84ed1ac46f3b96061208470a9

Pull-request updated, HEAD is now dc929ef8d18a7f59d1a7188b3b8c24105614bf57


error in as.array.MXNDArray in R

When converting form array to MXNDArray I get the following error:
cc <- array(c(1,2,3,4))
cc_mxnet <- mxnet:::as.array.MXNDArray(cc)
Error in eval(substitute(expr), envir, enclos) :
  expecting an external pointer

Any idea? @thirdwing

I think what you want is
> library(mxnet)
> cc <- array(c(1,2,3,4))
> cc_mxnet <- mx.nd.array(cc)
> str(cc_mxnet)
Class 'MXNDArray' <externalptr>

Just one more thing. The as.array.MXNDArray() will be called when we apply as.array over a MXNDArray. It is for converting MXNDArray to array.

Awesome @thirdwing!! I already have the custom iterator example. Tomorrow I'll do a PR. I was thinking to add the example here, what do you think?

You can do what you like.
Personally I might prefer also adding a separate doc on "How to write your iter". We already have "How to write your own callback function" and "How to use your own loss function".
https://github.com/dmlc/mxnet/blob/master/docs/tutorials/r/CallbackFunctionTutorial.md

Ok, it make sense


Backend controller infinite loop Magento 2.3

When creating entities and linking them from the admin menu, if you select one in 2.3.x you get sent in a loop of;
[url]/[adminpath]/[module_name]/[enttiy_name]/index/key/48484848484/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/adminhtml/dashboard

same issue.

any good news for this issue?

This appears to be caused by secret keys being added to the URLs.
https://github.com/magento/magento2/issues/21454
However, the issue is that the module creating is coming up with a 404, so there is a problem that still needs resolving :)

On closer inspection, changing the route ID seems to fix the 404 for me. So i'm guessing there's an issue with the way it's being generated. My module vendor contained many capitals I.E "ThisIsMyVendor".
Which seem to output the route to "this_is_my_vendor", altering the route file has resolved this.

i have to fix it manually. for  "ThisIsMyVendor" issue or "ThisIsMyModule" issue
How to auto fix this issue? what about to replace "ThisIsMyVendor" to "vendor" and  "ThisIsMyModule" to "module"?
or How about to add a field for naming by pre-defined?

@Azaciux @sidealice can you please send me a faulty module configuration file so I can reproduce it and fix it? You can find the file in var/umc and should have the same name as the module itself. Send it at<EMAIL_ADDRESS>

This should be fixed in 4.0.0


koord-descheduler: fixes namespace object limiter

Ⅰ. Describe what this PR does
Currently, if user uses evictAllBarePods to evict a bare pod, the namespace object limiter cannot get its ownerRef to add a limiterKey for this pod's namespace. This lead to the namespace limiter for bare pods does not work.
This PR fixes namespace object limiter for koord-descheduler's MigrationController.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/lgtm
/approve


Minor improvements

I think ViewGroup.show()/ViewGroup.hide() extension methods are redundant. ViewGroup is a View.
View.toggleVisibility() would be a useful addition:

View.toggleVisibility() {
  visibility = if (visibility == View.VISIBLE) View.GONE else VIew.VISIBLE
}

Sorry, too lazy to make a PR currently.

You are totally right. Thanks! 👍


Setting react

Add  "Setting up a React App"

@bsg-bob I think a couple of these have lang: set to kr instead of ko.

Sorry, Fixed it

Hey @bsg-bob Isn't the right code ko? I think they all need to be ko not kr 😝

Of course, kr is right, but confusingly I changed it because you asked me to do ko here.
eu-US
ko-KR

So, can I change the language to all the ko values?

Looks good! Thank you again!

Merged. Have a look and let me know if something looks off.


Functions mapped in an ajax call gets GC'ed prematurely

Details: http://groups.google.com/group/liftweb/browse_frm/thread/059442615ab2d77f#

The code for the fix to this issue is in master


Added a warning if a document has over 100 attributes

fix #120

Current coverage is 86.65% (diff: 81.81%)

Merging #138 into develop will increase coverage by 0.12%

@@            develop       #138   diff @@
==========================================
  Files           116        116
  Lines          1960       2038    +78
  Methods          58         63     +5
  Messages          0          0
  Branches        149        165    +16
==========================================
+ Hits           1696       1766    +70
- Misses          206        211     +5
- Partials         58         61     +3

Powered by Codecov. Last update d76a861...5cf8848


What the heck Microsoft!

, we cannot just simply click setup anymore? Are you going out of your way to make your software more difficult to install and use after all these years of making the best software? http://www.openoffice.org

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 626ac155-c2df-20a5-a23f-14921c0c72ae
Version Independent ID: 63a9307c-d246-bd15-9a2b-178b8a49580b
Content: Deploy Office 2019 (for IT Pros)
Content Source: DeployOffice/office2019/deploy.md
Product: office-perpetual-itpro
GitHub Login: @DHB-MSFT
Microsoft Alias: danbrown

...plus no status feedback while the software is installing, geez.

You're saying Microsoft should build both of you custom installers? Along with every customer? Not everyone has the same needs and requirements, this tool is actually very useful if you can do more than double-click an exe.


Improve Documentation

We wish to improve the documentation. Any help is welcome!

I can help for this.

Thanks :)

Do you still want help? I'm willing.

Yes Thanks. The idea is to create a proper docs with https://docusaurus.io/ .

Do you still want help? I'm willing.

Would you mind telling me a little bit more? I'm completely new to this, sorry.

Taking inspiration by the contents in the actual readme.md, you can create a static website using https://docusaurus.io/docs/en/installation .  The examples one their website should guide you to get started with it.

I'd like to work on this, please.

Hey, I'd like to help if the issue is still open.


Zoom feature similar to the browser one

You could make a zoom feature even though the window is maxed out, similar to that of browsers (Firefox Ctrl +) for example.
It's perfect if you are connected to a TV and you are sitting further away. Currently the text changes the size a little bit when you maximize the window.

Yes this feature as been requested many time and will be implemented in a future beta.
Meanwhile please try our new beta. See https://github.com/Aluxian/Facebook-Messenger-Desktop/issues/458
I will close this issue since we have many duplicates.


How to Fix this library with Android 33?

Any native solution to fix this library when Target Android 33?

Hello, google added a selinux policy for netlink send for getneigh message.
So it's not possible to do that with netlink at least.


Generate experiments during sanitization

This ensures the code always stays in sync with the configuration. Also adds gen_experiments to sanity checks.

This is a good thing to do, probably even necessary. It needs clang-format to run with it though, or it's going to be wrong (and writing a code generator to emit clang-format identical code is beyond the scope of what I'd be willing to do)

We probably need to get a clang-format docker image setup that can clang-format a set of passed in files.


Production server for best performance

Which gives the best performance in production?
For deploying in production we use docker.
And what better use gunicorn -w or uvicorn --workers?
In uvicorn docs recommends use gunicorn (https://www.uvicorn.org/#running-with-gunicorn):
This allows you to increase or decrease the number of worker processes on the fly, restart worker processes gracefully, or perform server upgrades without downtime.

But i think it not actual when using docker.

tiangolo/uvicorn-gunicorn-fastapi-docker

tiangolo/uvicorn-gunicorn-fastapi-docker

We use custom Dockerfile. And balance worker manualy (on uvicorn ). Wondering if the upgrade to Gunicorn is worth it?

it is recommended to use Gunicorn in production ( with Uvicorn workers).
I've used Gunicorn in all of my productions environment.
you can create a Custom Dockerfile . just check the tiangolo/uvicorn-gunicorn-fastapi-docker repo to find out how to configure the gunicorn depending on your requirement.

It's recommended by uvicorn itself: https://www.uvicorn.org/deployment/#using-a-process-manager
But talking about numbers (performance), I didn't find any comparison between those...

For production deployments we recommend using gunicorn with the uvicorn worker class.

I will add something that is a bit different from the above comments, to give you something else to think about. Gunicorn appears to have lots of good stuff and is probably sufficient for a lot of people, but for a project that I have worked on Gunicorn did not appear to be suitable/necessary.
After some trial and erroring along with lots of researching, I discovered the reasons for this had to do with our architecture. We are running our application on Kubernetes, which had a few implications on this decision:

Kubernetes can scale our app, and should be in charge of that imo. It is also in charge of the number of resources that a pod will have access to. I think it would be confusing to have Gunicorn also attempting to do scaling inside of a pod instead of adding a replica. I don't know how much overhead and what not Gunicorn has over Uvicorn (I'm sure it's nothing much), but there was no reason to find that out.

We let our pods die if there is a server error, and Kubernetes will restart it and we will get our alerts, be able to see a pod restarted N times etc. I struggled to kill a pod with Gunicorn, I think because of the way it is modeled. In Gunicorn, a main process spawns worker processes. But if a server error had occured - it would not crash the pod. I can't remember all of the details why, but I recall trying to figure it out for some time (trying different signals and stuff too) with no luck. I think possibly it was that the worker process would die but not the main one because of the way it runs.

If by using Docker, you mean using Docker Swarm, then you may be in a similar situation to what I was in, and really you could do things either way. If you scale with Swarm, you will be consistent in your scaling with Swarm at least, and if you do something like we do by killing/restarting containers, you will achieve that with Uvicorn easily. But this is where you need to decide what is best for you.
Disclaimer: I have never run an app in Gunicorn so I have no production experience with it over a significant period of time, only with trying to use it. Maybe the 2nd point is solvable, but the first point still stands, for me anyway.

Thank you, @Kennpow this is useful information. I think we will eventually come to using Kuber.

@Kennpow have you tried Knative? If not definitely check it out. You can do a lot more than Gunicorn able to do.
Some pros:

Per request load balancing.
Traffic splitting using revisions of a service.
Request based auto scaling.
It's easier to make new deployments, you don't need to write 100s LOC yaml.
[optional] automatic monitoring support for HTTP metrics (latency, requests, etc.)
[optional] automatic TLS certs and termination for external endpoints

Haven't tried it @ycd, looks like an interesting project though

Thanks for the discussion here everyone. 🍰
There's a lot of new info in the docs about deployments including how and when to combine Uvicorn with Gunicorn (or not): https://fastapi.tiangolo.com/deployment/

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.


Theme / Colorscheme

Every color on the UI should have a proper name
The theme creator should

utilize a 4-bit(16 colors) color palette for easier color scheme creation
utilize primary, secondary, and tertiary colors for easier color scheme creation
be fully configurable for advanced theme creation

What about gradients on theming?


got picture from different users query

i had one time occuring that i got the results from a friends query to my user and vice versa

This looks like an issue with comfyui-api reusing client id's. I hadn't tested this with multiple concurrent users before, but I implemented a fix in 97fa2f35cd52f64ecf7c2d5053d7516ce85c6af1 and it seems to fix things for me.

I'm assuming this is fixed with the above fix, please re-open if you still see it in the latest version.


1.2 backports 18 09 17

Backported PRs:

#5552
#5556 - required a few conflicts to be resolved. Required pulling in of 7b542736ab79964e89263705deb31f451f071953 . @tgraf please confirm validity of changes.
#5579
#5551
#5575

Not-backported PRs:

#5550 - already being taken care of by #5583
#5445 - requires pulling in a lot of changes into CI. Discussion is ongoing.

Signed-off by: Ian Vernon<EMAIL_ADDRESS>

This change is

test-me-please

Unit tests got broken in this PR:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/6527
Will triage and fix.

Got unit tests passing locally, trying tests again.

test-me-please

Please also pull in https://github.com/cilium/cilium/pull/5551

@tgraf done

test-me-please

Had some bpf.sha fun, trying again...

test-me-please

Kafka tests failed: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/6535/

test-me-please

When triaging
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/6535 , I noticed that we are still testing with K8s 1.7 in this branch?

Merging, will cut release tomorrow morning PST.


unpublish version 0.0.0-semantically-released

for some reason, the 0.0.0-semantically-released was published, ooops. Problem is here: https://travis-ci.org/hoodiehq/pouchdb-hoodie-sync/jobs/67043781#L387
@zoepage can you please add me to the npm package?
We need to run this
npm unpublish<EMAIL_ADDRESS>And then, we have to double check the npm API key here: https://github.com/hoodiehq/pouchdb-hoodie-sync/blob/master/.travis.yml#L50. I'm quite sure it's not correct, and that's what causing the trouble

okay, the version is set to 1.0.0.
I've added you to the pkg.
I'll check the key.

@boennemann we checked together that the API key is correct, that cannot be the cause, must be something else. For some reason, it doesn't know that 1.0.0 is already out, and tries to re-publish it. There were only chore commits after 1.0.0 anyway, it shouldn't publish at all

Can you pin<EMAIL_ADDRESS>for now? There seems to be a bug somewhere in the pulling info from the registry part :/ I'm sorry. https://github.com/boennemann/semantic-release/issues/46

Will do. Thanks!

tried. failed.
https://travis-ci.org/hoodiehq/pouchdb-hoodie-sync/jobs/68371806#L389
added you @boennemann to the pkg.

I'm on my way home to Munich till tomorrow 5pm, so I probably won't be able to look into it till then. Maybe @christophwitzko can help? :)
On Thu, Jun 25, 2015 at 12:50 PM, Ola Gasidlo<EMAIL_ADDRESS>wrote:

tried. failed.
https://travis-ci.org/hoodiehq/pouchdb-hoodie-sync/jobs/68371806#L389
added you @boennemann to the pkg.
Reply to this email directly or view it on GitHub:
https://github.com/hoodiehq/pouchdb-hoodie-sync/issues/38#issuecomment-115375553

Alright, got some time for trying some quick fixes in the meantime. Let's see how it goes.

I had to pin 3.3.2 and now we're back to normal: https://travis-ci.org/hoodiehq/pouchdb-hoodie-sync/jobs/68404030#L383
Meanwhile I've moved the latest tag on semantic-release back to 3.3.2, so the problematic version won't get installed until we've got this figured out.
Sorry.


Missing EnhancedEcommerceProductContext

Describe the bug
We migrated from js-tracker v2.14 to v2.16.1, by just replacing the tracking library. And noticed that the EnhancedEcommerceProductContext is missing completely on add/remove/detail actions.
To Reproduce
Watch the tracking call payloads.

Thanks for raising the defect. I'll take a look at this.

https://github.com/snowplow/snowplow-javascript-tracker/releases/tag/2.16.2 is now available


Add planner/execution support for DROP COLUMN

For now added  only some basic tests.
Will follow up with more tests

[ ] try to simulate concurrency (e.g drop a column while it has been used in a new column with a generated expression in between)
[ ] dropping parent drops subcols
[ ] information_schema,pg_catalog
[ ] check all places that the dropped columns are not "seen" (views, show create table, select _raw, etc)
[ ] re-add column with same name

Also added select _raw to the "dropped column not seen" TODO entry.


Failed to load module "canberra-gtk-module"

Steps To reproduce

Download version 0.1.9 for linux on ubuntu.
Extract the folder and mark Trello as executable
./Trello in the home Directory shows this error

`Gtk-Message: 00:35:10.136: Failed to load module "canberra-gtk-module"

(Trello:122799): Pango-ERROR **: 00:35:10.298: Harfbuzz version too old (1.4.2)

Trace/breakpoint trap (core dumped)`

Technical Information

Ubuntu 20.04
Trello-Desktop version 0.1.9

canberra-gtk-module Error Fix
just Type this in console sudo apt install libcanberra-gtk-module libcanberra-gtk3-module


Support a .flatignore file

It would be handy to extend this:
https://github.com/githubocto/flat-viewer/blob/19477a0d975ea69ecad16140b3bc733aaab348c4/src/api/index.ts#L48-L49

.flatignore could be a good solution for #27 and allow github repository maintainers to filter out some json files that flat viewer can't display.

I love Flat Viewer and came here to check if there was a way to ignore certain files, since I'd love to give collaborators a flat link to my repos and not have them land by default on a devcontainer or other json file that can't be displayed. Just chiming in that I would also greatly appreciate this feature!


loss functions should infer dtype from predictions

Please make sure that this is a Bug or a Feature Request and provide all applicable information asked by the template.
If your issue is an implementation question, please ask your question on StackOverflow or on the Keras Slack channel instead of opening a GitHub issue.
System information

Have I written custom code (as opposed to using example directory):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
TensorFlow backend (yes / no):
TensorFlow version:
Keras version:
Python version:
CUDA/cuDNN version:
GPU model and memory:

You can obtain the TensorFlow version with:
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
You can obtain the Keras version with:
python -c 'import keras as k; print(k.version)'
Describe the current behavior
def mean_squared_error(y_true, y_pred):
if not K.is_tensor(y_pred):
y_pred = K.constant(y_pred)
y_true = K.cast(y_true, y_pred.dtype)
return K.mean(K.square(y_pred - y_true), axis=-1)
y_pred is always converted to float32 because of K.constant call.
Describe the expected behavior
pass dtype to the K.constant call
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

@pavithrasv Could you please refer to this link and let us know if it helps ?
In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here. Thanks!

Closing this issue due to lack of recent activity & assuming this issue as resolved .Please feel free to reopen if you still have concern .Thanks!


esp_sntp: Fix c++ compile issue in esp_sntp.h (IDFGH-9212) (IDFGH-9239)

Added a cast to esp_sntp_operatingmode_t in sntp_setoperatingmode()'s call to esp_sntp_setoperatingmode(operating_mode).  Althouogh C doesn't require the cast, C++ does.  Otherwise you get...
error: invalid conversion from 'u8_t' {aka 'unsigned char'}
to 'esp_sntp_operatingmode_t'

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks again for the contribution. Merged as https://github.com/espressif/esp-idf/commit/c8f0ec7fa4f9555db2e085977dc502689cad71fd


placemarkFromCoordinates in isolate

Hello,
I  got  error when calling placemarkFromCoordinates in Isolate.
Here's the error
E/flutter (20127): [ERROR:flutter/runtime/dart_isolate.cc(1137)] Unhandled exception:
E/flutter (20127): Null check operator used on a null value
E/flutter (20127):     MethodChannel.binaryMessenger (package:flutter/src/services/platform_channel.dart:142:86)
E/flutter (20127):       MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:148:36)
E/flutter (20127):       MethodChannel.invokeMethod (package:flutter/src/services/platform_channel.dart:331:12)
E/flutter (20127):       MethodChannelGeocoding.placemarkFromCoordinates (package:geocoding_platform_interface/src/implementations/method_channel_geocoding.dart:56:44)
E/flutter (20127):       placemarkFromCoordinates (package:geocoding/geocoding.dart:44:32)
Can you give me a solution ?

did you solve it? I have the same problem

Unfortunately this will not work as method channels are not setup to work in isolates. This is a limitation on Flutter, not on the part of the geocoding plugin.

Hello,
I got error when calling placemarkFromCoordinates in Isolate.
Here's the error
E/flutter (20127): [ERROR:flutter/runtime/dart_isolate.cc(1137)] Unhandled exception: E/flutter (20127): Null check operator used on a null value E/flutter (20127): MethodChannel.binaryMessenger (package:flutter/src/services/platform_channel.dart:142:86) E/flutter (20127): MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:148:36) E/flutter (20127): MethodChannel.invokeMethod (package:flutter/src/services/platform_channel.dart:331:12) E/flutter (20127): MethodChannelGeocoding.placemarkFromCoordinates (package:geocoding_platform_interface/src/implementations/method_channel_geocoding.dart:56:44) E/flutter (20127): placemarkFromCoordinates (package:geocoding/geocoding.dart:44:32)
Can you give me a solution ?

I think you tried to run it on isolate because it's freezer the main thread
but here is a great solution
https://github.com/Baseflow/flutter-geocoding/issues/58#issuecomment-891315068


I just updated from 4.0 to 5.8 and my update broke the site

I have the full install from 4.0 saved
but now i tried to enter the new install in another folder and then import the old database then i get a failure in return:
"Cannot read property 'uuid' of undefined", and red box en lower left corner says "import failed"
What can i do about this, is there a json converter which convert this old db into the new version of the database?

@sp90 how did you resolve this? I'm having the same issue.

@marcusway can't really remember, but im pretty sure i took the DB file, converted it into json and installed a new instance of ghost, fx 0.6.2 and then used the import json file on that :)


Q Overestimation

I'm rerunning velocity baselines in the POMDP directory and I'm observing exploding Q values fairly often. I was wondering if this is something you experienced during training. TD3 seems to avoid overestimation bias but the returns seem low. Any tips to get more stable returns across trials without massive batch sizes?

Yes, I found overestimation and also gradient explosion when training LSTM TD3 in some hard environments like Walker-V. A simple remedy may be add gradient clipping to avoid explosion, although I don't expect this can fix the issue.


The built-in library 'dart:utf' is not available on the stand-alone VM.

Using the lib in a standalone VM ends in the following error message which makes it impossible to use it.
The built-in library 'dart:utf' is not available on the stand-alone VM.
'package:mqtt/mqtt_shared.dart': error: line 4 pos 1: library handler failed
import 'dart:utf';

Sorry, my fault. Had local cache issues.


Add OPLS-AA LigParGen PEO to the library

Here's PEO with OPLS-AA using parameters obtained from the LigParGen server. Works good. Can generated a OH terminated PEO like this:
polyply gen_itp -lib oplsaa_LigParGen_polymers -name PEO -seq OHter:1 PEO:50 OHter:1 -o PEO_n50_opls.itp

To run, you need the following in the top:
; Include forcefield parameters
#include "/usr/local/gromacs-XXXX/share/gromacs/top/oplsaa.ff/forcefield.itp"
#include "atom_types_LigParGen.itp"
...
etc.

where atom_types_LigParGen.itp looks like this:
; GENERATED BY LigParGen Server
; Jorgensen Lab @ Yale University
;
[ atomtypes ]
  opls_800  C800   12.0110     0.000    A    3.50000E-01   2.76144E-01 ; C
  opls_801  O801   15.9990     0.000    A    2.90000E-01   5.85760E-01 ; O
  opls_802  H802    1.0080     0.000    A    2.50000E-01   1.25520E-01 ; H
  opls_803  O803   15.9990     0.000    A    3.12000E-01   7.11280E-01 ; O (ALCOHOL, TERMINI)

I left the atom type definitions as a comment on the header of PEO.oplsaa.LigParGen.ff - probably not the best idea on the long run...
Man, we really should figure out how to automagically take an itp generated from servers such as LigParGen server and by entering which atoms belong to the block and which belong to a termini, generate automatically all the necessary blocks and links.! I would be up for taking on such a task at some point but I'd need some guidance from you code masters on how to do this in the smartest way possible :)

@ricalessandri did you try building a system? If yes then we can merge this or not?

I did not to build a PEO OPLS melt but I'm trying a PS OPLS melt and having some difficulties. But it's my first AA melts so.. they are more delicate. I'll try more tomorrow.

@ricalessandri I tried building this PEO OPLS system and it seems fine to me. I could energy minimize and run a Berendsen at 1fs for some nano seconds.

Yes, OPLS PEO looks good. I run the melt for a while. It needs flexible bonds for the energy minimization and some 10s of ns of equilibration but we knew that's needed for AA systems.
I added the test following the instructions at https://github.com/marrink-lab/polyply_1.0/pull/112#issuecomment-826108758. So I'd say this PR is good to go.


Any plans to upgrade to typescript?

Hey there,
since the client is already written in TypeScript I wonder if there are plans to upgrade the backend too?
For example LoopBack 4 is also fully TypeScript compatible.

Not all the loopback3 plugins have been upgraded to loopback4 e.g. passport/LDAP, so that is blocking upgrade.

But in general if all plugins or substitutions would be available for loopback 4, you would upgrade?
I am just curious in regards of the maintainability of the project, and since TypeScript is somewhat type safe in his nature, I see this as an logical next step.

Yes

My Opinion: this is very likely to happen, but not on an immediate timescale. We looked into loopback4 several times and it was not ready yet. In any case it will be a major effort to do the upgrade, but most likely worthwile in the longterm. It would be a good opportunity for some refactoring as well. As usual any help from volunteers is appreciated ;-)

Thanks for clarification :)


fix: 31101 Eye icon to show password on password protected PDF file is not working

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/31101
PROPOSAL: https://github.com/Expensify/App/issues/31101#issuecomment-1803554514
Tests

Tap on the password protected PDF preview on the chat.
Tap on "enter the password".
Type some characters.
Tap on the eye icon to reveal the password.
The password should be revealed and visible to the user.

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Tap on the password protected PDF preview on the chat.
Tap on "enter the password".
Type some characters.
Tap on the eye icon to reveal the password.
The password should be revealed and visible to the user.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/113963320/bcd3186a-bd69-418d-9c87-3973e0e8d068

MacOS: Desktop

@tienifr The patch isn't getting installed for me.  This the error I get when I did a fresh npm i

**ERROR** Failed to apply patch for package react-native-web

  This happened because the patch file patches/react-native-web+0.19.9+003+fix-pointer-events.patch could not be parsed.

and then when I tried to run this specific patch using     patch -p1 -i patches/react-native-web+0.19.9+003+fix-pointer-events.patch.
patching file 'node_modules/react-native-web/src/exports/StyleSheet/compiler/index.js'
patch: **** malformed patch at line 21:

Can you confirm if it works fine at your end?

This is the patch that I generated and works fine on my local.
diff --git a/node_modules/react-native-web/src/exports/StyleSheet/compiler/index.js b/node_modules/react-native-web/src/exports/StyleSheet/compiler/index.js
index 639f532..7445b76 100644
--- a/node_modules/react-native-web/src/exports/StyleSheet/compiler/index.js
+++ b/node_modules/react-native-web/src/exports/StyleSheet/compiler/index.js
@@ -385,13 +385,13 @@ function createAtomicRules(identifier: string, property, value): Rules {
         finalValue = 'auto!important';
         if (value === 'box-only') {
           const block = createDeclarationBlock({ pointerEvents: 'none' });
-          rules.push(`${selector}>*${block}`);
+          rules.push(`${selector} *${block}`);
         }
       } else if (value === 'none' || value === 'box-none') {
         finalValue = 'none!important';
         if (value === 'box-none') {
           const block = createDeclarationBlock({ pointerEvents: 'auto' });
-          rules.push(`${selector}>*${block}`);
+          rules.push(`${selector} *${block}`);
         }
       }
       const block = createDeclarationBlock({ pointerEvents: finalValue });

and even after applying the patch it isn't working for me.
https://github.com/Expensify/App/assets/3069065/591fd6fc-cf67-4e38-8126-cd49d4de61ed

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/3069065/6a7510a0-a437-4579-94ad-725dffa96d45

Android: mWeb Chrome
https://github.com/Expensify/App/assets/3069065/7c92ad7a-090f-435c-bf44-81ae73d7fabb

iOS: Native
https://github.com/Expensify/App/assets/3069065/5b6b4259-36c6-43bc-a52d-5759b6086938

iOS: mWeb Safari
https://github.com/Expensify/App/assets/3069065/deca9e5e-f9a6-4a14-9ef2-4ddef0e644e4

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/3069065/b897cf8f-e3d5-474b-bde7-a47871f811b6

MacOS: Desktop
https://github.com/Expensify/App/assets/3069065/30d8e6ba-9d69-4068-a717-8e0eb1dcc1b2

@situchan can you please re-do the author checklist? It's failing the check for some reason, so please copy it from a blank PR and refill it to guarantee we're checking all the items and none were deleted by mistake

@situchan can you please re-do the author checklist? It's failing the check for some reason, so please copy it from a blank PR and refill it to guarantee we're checking all the items and none were deleted by mistake

you meant to tag @tienifr? 😄

yes, sorry about that hah

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.0-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

We had to rollback the patch because it caused this issue.


[Jest] ReferenceError with inlineRequire: true

Possibly related to #3999 @cpojer comments.
After upgrading from 0.14.2 to 0.17 and using react-native preprocessor.js - with default value set to true:
ReferenceError: /src/auth/newPasswordForm.js: _immutable is not defined
        at Object.<anonymous> (src/auth/newPasswordForm.js:3:30)

that:
import {Map} from 'immutable'

is simply striped out from transformed code (the first line in the file). Setting it to false makes tests green again.
Funny fact is that it's only affected by the jest. When running normally with packager - all goes smoothly.

I'm having a similar issue, replacing import ... from ... with require() works around the error. Perhaps somehow Babel is not setup correctly while testing?

Same, for jest 0.9.0-fb2 and react-native 0.19.
Probably, using require or setting inlineRequires: false gets work done, but any update on this issue?

Setting inlineRequires: false on 0.22 makes it work again

btw. I'll be recommending to use babel-jest together with babel-preset-react-native but I haven't had enough time to rewrite the documentation for this yet, unfortunately.

This is still a super breaking thing for us internally @cpojer, so I'd be more than happy to submit few patches & try out undocumented solutions to get it working

Thank you for your patience. We launched Jest 14.0 with experimental react-native support:

Blog Post
React-Native Tutorial

Please feel free to create new issues after trying out the new integration if any issues remain.


Add assets field

depends on https://github.com/openprocurement/openprocurement.api/pull/371 https://github.com/openprocurement/openregistry.lots.core/pull/64

Coverage increased (+0.005%) to 97.959% when pulling 91e970248f055afb36c46e41ce60d60717ad5d27 on oleksiyVeretiuk:add_assets_field into 72ba97c599ae3238ab86c599eebe3ea61222af2a on openprocurement:master.


[cmake] transition to cmake

use cmake for building otbr-agent
use cmake for all tests.
use cmake for OpenWrt.
move dbus test into check
remove raspbian jessie test for it very hard to upgrade cmake
remove autotools

All tests passed


Staff Pets Index: Remove unnecessary columns from the table

UI change: we do not need these columns in the staff Pet index table. Please remove them.

Hi @kasugaijin , I would love to work on this. I have raised PR for the earlier issue. Since we are removing sex, breed and weight columns from UI should we remove sex filter as well?

@atbalaji sounds good! You raise a very good point! I think more about this and we should keep the sex column and filter but get rid of the others.


Updated currency cookie after context is created

1. Why is this change necessary?
The ContextFactory finds the currency based on the currency uuid in the given currency cookie. If there is none, a fallback will be used. This fallback is never persisted to the cookies.
2. What does this change do, exactly?
This change writes the currency uuid to the request attributes where it will later be read from and sent back to the browser as a cookie.
3. Describe each step to reproduce the issue or behaviour.
Open the Storefront without a currency cookie.
4. Please link to the relevant issues (if any).
None.
5. Which documentation changes (if any) need to be made because of this PR?
None.
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hi,
thanks for the pull request. The fallback shouldn't be written back to the request cookie.
The currency cookie should only be set if the customer switch the currency. We only set the shop cookie for faster routing.


[Bug] TC-IDM-10.1 The feature-map value for both the ElectricalPowerMeasurement cluster and ElectricalEnergyMeasurement cluster has failed validation

Describe the bug
Hi!
We have some doubts about the test case TC-IDM-10.1.
When running the test case TC-IDM-10.1， it shows that Value ValueDecodeFailure,
But it's successful to read the feature-map value of both the ElectricalPowerMeasurement cluster and the ElectricalEnergyMeasurement cluster by using the chip-tool.
Problem: ProblemSeverity.ERROR
    test_name: test_TC_IDM_10_1
    location:
        Endpoint: 1,
        Cluster:  144 (0x90) ElectricalPowerMeasurement,
        Attribute:65532 (0xfffc)
    problem: Failed validation of value on Endpoint 1, Cluster ElectricalPowerMeasurement (144, 0x0090), Attribute FeatureMap 65532, 0xFFFC: Value ValueDecodeFailure(TLVValue=None, Reason=InteractionModelError(<Status.Failure: 1>)) is not an integer or uint (decoded type: <class 'chip.clusters.Attribute.ValueDecodeFailure'>)
    spec_location: Global Elements

[MatterTest] 03-07 11:15:23.263 INFO
Problem: ProblemSeverity.ERROR
    test_name: test_TC_IDM_10_1
    location:
        Endpoint: 1,
        Cluster:  145 (0x91) ElectricalEnergyMeasurement,
        Attribute:65532 (0xfffc)
    problem: Failed validation of value on Endpoint 1, Cluster ElectricalEnergyMeasurement (145, 0x0091), Attribute FeatureMap 65532, 0xFFFC: Value ValueDecodeFailure(TLVValue=None, Reason=InteractionModelError(<Status.Failure: 1>)) is not an integer or uint (decoded type: <class 'chip.clusters.Attribute.ValueDecodeFailure'>)
    spec_location: Global Elements

We are not sure which side makes this error, our code or the test tool.
In advance， thanks for all the replies!
Steps to reproduce the behavior
No response
Expected behavior
No response
Log files
TC-IDM-10.1-fail-2.txt
Problem: ProblemSeverity.ERROR
    test_name: test_TC_IDM_10_1
    location:
        Endpoint: 1,
        Cluster:  144 (0x90) ElectricalPowerMeasurement,
        Attribute:65532 (0xfffc)
    problem: Failed validation of value on Endpoint 1, Cluster ElectricalPowerMeasurement (144, 0x0090), Attribute FeatureMap 65532, 0xFFFC: Value ValueDecodeFailure(TLVValue=None, Reason=InteractionModelError(<Status.Failure: 1>)) is not an integer or uint (decoded type: <class 'chip.clusters.Attribute.ValueDecodeFailure'>)
    spec_location: Global Elements

[MatterTest] 03-07 11:15:23.263 INFO
Problem: ProblemSeverity.ERROR
    test_name: test_TC_IDM_10_1
    location:
        Endpoint: 1,
        Cluster:  145 (0x91) ElectricalEnergyMeasurement,
        Attribute:65532 (0xfffc)
    problem: Failed validation of value on Endpoint 1, Cluster ElectricalEnergyMeasurement (145, 0x0091), Attribute FeatureMap 65532, 0xFFFC: Value ValueDecodeFailure(TLVValue=None, Reason=InteractionModelError(<Status.Failure: 1>)) is not an integer or uint (decoded type: <class 'chip.clusters.Attribute.ValueDecodeFailure'>)
    spec_location: Global Elements

PICS file
Here is all the PICS of us.
PICS.zip
Screenshots
No response
Environment
TH Version: [2.10-beta3+spring2024]
Matter SDK Commit：9f6d627e0262e1d023986291948bb4e845be803e
Additional Information
No response

@Survensa Can you check if this issue is seen by the QA team as well ?

Try reading the feature map on that cluster with chip-tool. f it comes back as an error, it's a problem with your device because feature map is a required global attribute.

@Semi-Bin-Blain can you try out what Cecille has suggested pleas e?

@cecille @raju-apple
After the test case failed, I tried that and was able to read the feature map on both the EEM cluster and the EPM cluster using chip-tool.
./chip-tool electricalenergymeasurement read feature-map 1 1

[1709805249.099078][9420:9422] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0091 Attribute 0x0000_FFFC DataVersion:<PHONE_NUMBER>
[1709805249.099252][9420:9422] CHIP:TOO:   FeatureMap: 7
[1709805249.099774][9420:9422] CHIP:EM: <<< [E:36736i S:38883 M:138781990 (Ack:60809736)] (S) Msg TX to 1:0000000000000001 [FE0B] [UDP:[fd7b:94b:40c6:1:c5b6:ecc7:e869:9f64%wpan0]:5540] --- Type 0000:10 (SecureChannel:StandaloneAck)
[1709805249.100047][9420:9422] CHIP:EM: Flushed pending ack for MessageCounter:60809736 on exchange 36736i

./chip-tool electricalpowermeasurement read feature-map 1 1

[1709862941.751647][4200:4202] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0090 Attribute 0x0000_FFFC DataVersion: 951985864
[1709862941.751797][4200:4202] CHIP:TOO:   FeatureMap: 2
[1709862941.752275][4200:4202] CHIP:EM: <<< [E:44752i S:33163 M:170189480 (Ack:211495321)] (S) Msg TX to 1:0000000000000001 [7F2C] [UDP:[fd2d:2141:4633:1:5068:d647:92f:285f%wpan0]:5540] --- Type 0000:10 (SecureChannel:StandaloneAck)
[1709862941.752538][4200:4202] CHIP:EM: Flushed pending ack for MessageCounter:211495321 on exchange 44752i

That's interesting because it's definitely coming back as a value decode failure, and we know this is not a general test failure. Is there maybe something strange with the wildcard vs. individual attribute read? Can you try this again using a wildcard for the cluster or endpoint?

Of course! How do I do that? Which command should I use for the chip-tool?

You can use read-by-id for wildcard. 0xFFFFFFFF is the key for "everything". So
chip-tool any read-by-id 0x0091 0xFFFFFFFF 0x12344321 1
chip-tool any read-by-id 0x0090 0xFFFFFFFF 0x12344321 1
where 0x0091 / 0x0090 are the cluster IDs, 0xFFFFFFFF is the key for "all the attributes", and 0x1234321 is the node id (change as appropriate) and 1 is the endpoint

You can use read-by-id for wildcard. 0xFFFFFFFF is the key for "everything". So
chip-tool any read-by-id 0x0091 0xFFFFFFFF 0x12344321 1 chip-tool any read-by-id 0x0090 0xFFFFFFFF 0x12344321 1
where 0x0091 / 0x0090 are the cluster IDs, 0xFFFFFFFF is the key for "all the attributes", and 0x1234321 is the node id (change as appropriate) and 1 is the endpoint

I have tried this and it was successful. Below is the log file.
[1710818316.889845][85260:85262] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0090 Attribute 0x0000_FFFC DataVersion:<PHONE_NUMBER>
[1710818316.889867][85260:85262] CHIP:TOO:   FeatureMap: 2

[1710818303.167114][85257:85259] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0091 Attribute 0x0000_FFFC DataVersion:<PHONE_NUMBER>
[1710818303.167149][85257:85259] CHIP:TOO:   FeatureMap: 15

wildcard_attribute_read_20240319_112256.log

I'm fairly stumped - the read from the test is reporting that the attribute isn't readable, but it seems like it is. I'm fairly confident that the decoding code in python is robust - it's been in use for quite some time. It feels like there's something more fundamental going on here.
Would you mind trying one more thing - can you re-run the test with dump_device_composition_path enabled? If you're running this from the command line, just pass that as a flag, and give it a filename to dump to. It will output a json and a txt file with a direct dump of the wildcard. If you want to anonymize the dump, you can use the tool here: https://github.com/cecille/connectedhomeip/commit/dabbb14277a15cd46f2d505a5338916d263e8ac3 (or just erase the basic information cluster information). You can also send it over to me to take a look if you don't wish to attach it to this issue.

I'm fairly stumped - the read from the test is reporting that the attribute isn't readable, but it seems like it is. I'm fairly confident that the decoding code in python is robust - it's been in use for quite some time. It feels like there's something more fundamental going on here.
Would you mind trying one more thing - can you re-run the test with dump_device_composition_path enabled? If you're running this from the command line, just pass that as a flag, and give it a filename to dump to. It will output a json and a txt file with a direct dump of the wildcard. If you want to anonymize the dump, you can use the tool here: cecille/connectedhomeip@dabbb14 (or just erase the basic information cluster information). You can also send it over to me to take a look if you don't wish to attach it to this issue.

Sorry, I'm a little confused.
Should I re-run the IDM-10.1 test case and add the flag dump_device_composition_path? Where can I get the output file?

Yes. The argument to that flag is the path to output the files.

Yes. The argument to that flag is the path to output the files.

Sorry to bother you, I tried to run the test in the docker command line, but I can not get the dump file.  Should I bind a new directory to the docker container?  If I'm running it in the wrong way? If so, could you please show me the right way?
Below is the command:
rm -f admin_storage.json && python3 temp_python_testing/scripts/sdk/TC_DeviceBasicComposition.py --discriminator 3996  --passcode 34732441 --commissioning-method ble-thread --paa-trust-store-path  /credentials/development/paa-root-certs/  --storage-path admin_storage.json --int-arg use_pase_only:0 --tests test_TC_IDM_10_1 --thread-dataset-hex 0e080000000000010000000300000b35060004001fffe00208f3e7c92ab739b79f0708fd24c99c0091f31d05101e9ebf38f9503215ab0218abc646b9d4030f4f70656e5468726561642d35363333010256330410acd351f85bdfacb4858456eb8565e0840c0402a0f7f8 --ble-interface-id 0 --dump_device_composition_path tc_idm_10_1

I'm sorry about that - I've completely botched the flag. It should be --string-arg dump_device_composition_path:path_and_filename
where path_and_filename is the path and filename for your file.

Got it, it's worked, thanks. Below is the files:
tc_idm_10_1.json
tc_idm_10_1.txt
Besides that, one thing I think needs to mentioned, the feature map value of these two clusters, can not be edited by the Zap tool, we need to config it in the code, like the following:
Is there anything wrong?
BitMask<Clusters::ElectricalPowerMeasurement::Feature> epm_feature = BitMask<Clusters::ElectricalPowerMeasurement::Feature>(2);

There's definitely something bad going on here - you have value decode failures for almost every attribute on the cluster.
     <class 'chip.clusters.Objects.ElectricalPowerMeasurement'>: {<class 'chip.clusters.Attribute.DataVersion'>:<PHONE_NUMBER>,
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.ApparentCurrent'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.ActivePower'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.ReactivePower'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.AttributeList'>: [0, 1, 2, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,
                                                                                17, 65528, 65529, 65531, 65532, 65533],
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.FeatureMap'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.RMSVoltage'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.PowerMode'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.NumberOfMeasurementTypes'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.Accuracy'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.Voltage'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.ActiveCurrent'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.ApparentPower'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.RMSCurrent'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.RMSPower'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.Frequency'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.ReactiveCurrent'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.PowerFactor'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.GeneratedCommandList'>: [],
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.AcceptedCommandList'>: [],
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.ClusterRevision'>: 1},

There's definitely something bad going on here - you have value decode failures for almost every attribute on the cluster.
     <class 'chip.clusters.Objects.ElectricalPowerMeasurement'>: {<class 'chip.clusters.Attribute.DataVersion'>:<PHONE_NUMBER>,
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.ApparentCurrent'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.ActivePower'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.ReactivePower'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.AttributeList'>: [0, 1, 2, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,
                                                                                17, 65528, 65529, 65531, 65532, 65533],
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.FeatureMap'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.RMSVoltage'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.PowerMode'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.NumberOfMeasurementTypes'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.Accuracy'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.Voltage'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.ActiveCurrent'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.ApparentPower'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.RMSCurrent'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.RMSPower'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.Frequency'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.ReactiveCurrent'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.PowerFactor'>: ValueDecodeFailure(TLVValue=None,
                                                                                Reason=InteractionModelError(<Status.Failure: 1>)),
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.GeneratedCommandList'>: [],
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.AcceptedCommandList'>: [],
                                                                  <class 'chip.clusters.Objects.ElectricalPowerMeasurement.Attributes.ClusterRevision'>: 1},

As you say, it seems there is some wrong with our usage, is there any suggestions that can help us to fix it? Thanks!

@cecille @raju-apple Is there anything that we can do to fix this issue?

Given that this test is passing on the example apps, i don't believe this is a test issue - the device is returning bad data on the wildcard. So you'll have to fix it on the device side.

Given that this test is passing on the example apps, i don't believe this is a test issue - the device is returning bad data on the wildcard. So you'll have to fix it on the device side.

Got it, thanks

@cecille @raju-apple Hi, I resolved this issue, after checking, I noticed that the Test case was finished before my device initiated the value of both clusters, so maybe the command got NULL or Unkonw status value of both clusters, I initiated the value more early, now the case can pass.
But during the test running, my device still got some error logs, which show retrieving data error, I think the error code means No memory, it seems not to have any bad effect on my device, and the test case is passed, is that okay to ignore these error logs?
E: 25620 [DMG]Error retrieving data from clusterId: 0x0000_0030, err = b
I: 25632 [EM]<<< [E:45483r S:13657 M:44666486 (Ack:251262658)] (S) Msg TX to 1:000000000001B669 [6576] [UDP:[fd11:53::31ef:ebd3:f329:7f51]:52214] --- Type 0001:05 (IM:ReportData)
I: 25849 [EM]>>> [E:45483r S:13657 M:251262659 (Ack:44666486)] (S) Msg RX from 1:000000000001B669 [6576] --- Type 0001:01 (IM:StatusResponse)
I: 25863 [IM]Received status response, status is 0x00
E: 25924 [DMG]Error retrieving data from clusterId: 0x0000_0035, err = b
I: 25936 [EM]<<< [E:45483r S:13657 M:44666487 (Ack:251262659)] (S) Msg TX to 1:000000000001B669 [6576] [UDP:[fd11:53::31ef:ebd3:f329:7f51]:52214] --- Type 0001:05 (IM:ReportData)
I: 26150 [EM]>>> [E:45483r S:13657 M:251262660 (Ack:44666487)] (S) Msg RX from 1:000000000001B669 [6576] --- Type 0001:01 (IM:StatusResponse)
I: 26164 [IM]Received status response, status is 0x00
E: 26244 [DMG]Error retrieving data from clusterId: 0x0000_003E, err = b
I: 26255 [EM]<<< [E:45483r S:13657 M:44666488 (Ack:251262660)] (S) Msg TX to 1:000000000001B669 [6576] [UDP:[fd11:53::31ef:ebd3:f329:7f51]:52214] --- Type 0001:05 (IM:ReportData)
I: 26434 [EM]>>> [E:45483r S:13657 M:251262661 (Ack:44666488)] (S) Msg RX from 1:000000000001B669 [6576] --- Type 0001:01 (IM:StatusResponse)
I: 26447 [IM]Received status response, status is 0x00
E: 26462 [DMG]Error retrieving data from clusterId: 0x0000_003F, err = b
I: 26475 [EM]<<< [E:45483r S:13657 M:44666489 (Ack:251262661)] (S) Msg TX to 1:000000000001B669 [6576] [UDP:[fd11:53::31ef:ebd3:f329:7f51]:52214] --- Type 0001:05 (IM:ReportData)
I: 26649 [EM]>>> [E:45483r S:13657 M:251262662 (Ack:44666489)] (S) Msg RX from 1:000000000001B669 [6576] --- Type 0001:01 (IM:StatusResponse)
I: 26663 [IM]Received status response, status is 0x00
E: 26691 [DMG]Error retrieving data from clusterId: 0x0000_001D, err = b
I: 26703 [EM]<<< [E:45483r S:13657 M:44666490 (Ack:251262662)] (S) Msg TX to 1:000000000001B669 [6576] [UDP:[fd11:53::31ef:ebd3:f329:7f51]:52214] --- Type 0001:05 (IM:ReportData)
I: 26928 [EM]>>> [E:45483r S:13657 M:251262663 (Ack:44666490)] (S) Msg RX from 1:000000000001B669 [6576] --- Type 0001:01 (IM:StatusResponse)
I: 26942 [IM]Received status response, status is 0x00
I: 26950 [DL]Get the fixed label with index:0 at endpoint:1
I: 26956 [DL]Get the fixed label with index:1 at endpoint:1
I: 26961 [DL]Get the fixed label with index:2 at endpoint:1
I: 26967 [DL]Get the fixed label with index:3 at endpoint:1
E: 26987 [DMG]Error retrieving data from clusterId: 0x0000_0090, err = b
I: 27000 [EM]<<< [E:45483r S:13657 M:44666491 (Ack:251262663)] (S) Msg TX to 1:000000000001B669 [6576] [UDP:[fd11:53::31ef:ebd3:f329:7f51]:52214] --- Type 0001:05 (IM:ReportData)
I: 27211 [EM]>>> [E:45483r S:13657 M:251262664 (Ack:44666491)] (S) Msg RX from 1:000000000001B669 [6576] --- Type 0001:01 (IM:StatusResponse)
I: 27225 [IM]Received status response, status is 0x00
I: 27243 [EM]<<< [E:45483r S:13657 M:44666492 (Ack:251262664)] (S) Msg TX to 1:000000000001B669 [6576] [UDP:[fd11:53::31ef:ebd3:f329:7f51]:52214] --- Type 0001:05 (IM:ReportData)


Fixes for double-freeing native tensor handles.

This PR fixes three instances of native tensor handles being freed more than once, causing access violations.
It includes the fix surfaced in PR #316.

@lostmsu, I tried to add you as a reviewer, but your name didn't pop up on the list.

Do your tests for the custom module without the fix? I wonder why you had to replace the original one.

Yeah, I copied your test to debug it and understand exactly how it went wrong, then I copied your fix, etc.


How to modify the drawing board size of PSD

Hey, I assume this is a duplicate of the last ticket which ive translated from chinese? In which case I would delete the other one since it is not in english.
As for your question, if by drawing board you mean the canvas itself theres multiple options, you can either modify it on initialization using the appropriate constructor or directly modify the properties after construction if you wish to resize it after adding all the layers
Here is the relevant cpp reference
https://photoshopapi.readthedocs.io/en/latest/code/layeredfile.html
The attributes for cpp are m_Width and m_Height
Here is the relevant python reference
https://photoshopapi.readthedocs.io/en/latest/python/layeredfile.html
The attributes for python are width and height
Hope this helps!

this is my code `import psapi
layered_file = psapi.LayeredFile.read("LR8224.psd")
print(layered_file.width)
layered_file.width = 500
layered_file.height = 500
layered_file.write("123.psd")`

this  is  my  code
`
import psapi
layered_file = psapi.LayeredFile.read("LR8224.psd")
print(layered_file.width)
layered_file.width = 500
layered_file.height = 500
layered_file.write("123.psd")
`

layered_file = psapi.LayeredFile.read("LR8224.psd")
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd5 in position 24: invalid continuation byte

Let me have a look once im home! Is there any way you could provide me with the file in question if it is not confidential.
That being said I recently pushed a change that fixed a bug relating to filepaths where reading a file without a path would fail.
You could try instead
psapi.LayeredFile.read("./LR8224.psd")
I think this should fix your error but let me know if it doesnt. This bugfix will be part of the 0.5.0 release once I get the time to implement some other features :)

thank you very much . can you  give me you email?

Yes sure, its<EMAIL_ADDRESS>:). Ill try and have a look tonight or tomorrow morning my time!

Hey @kkgg0521 I gave a look at the file and was able to read it just fine using the latest pip installable photoshopapi version of 0.4.0 without any errors. Even when omitting the "./" prefix from the path I only got a create_directories error and not a UnicodeDecodeError.
Mind letting me know what python version and PhotoshopAPI version you are running? That way I can see if I can recreate your setup.
Additionally if you could let me know what OS you are running on that could help :)

python 3.7 PhotoshopAPI 0.4.0

windows

我切换了电脑 发现正常读取了。

这个问题解决了 希望可以早日用上0.5.0版本的软件 感谢

Glad it worked out, in general something that is TODO is the parsing of unicode layer names as I hadnt implemented that yet whicv is why your layer names might come out funny.
Ill open an issue for it

这个项目我很感兴趣,他十分强大。


Actions broken

You should be able to fix it like this https://github.com/vijayvarma392/surfinBH/commit/fbff946117cc42d7dc55126b94ce710da174095b

any luck with this?

Failing due to some issue while building spinsfast package

maybe of changes made in spinsfast last week?

can we temporarily remove sxs from dependency? The tests do not use sxs. spinsfast is required by sxs, so removing sxs may be a temporary fix. @vijayvarma392

The real error might be something else:

Is sxs an actual dependency for the package? If so, we shouldn't just remove it.
Looks like only the macos test was run though: https://github.com/vijayvarma392/gw_eccentricity/actions/runs/8890734138/job/25533440833?pr=214. Can you try disabling macos test so that the ubuntu test is forced to run?

Also, maybe worth trying newer python versions: https://github.com/moble/spinsfast/blob/main/.github/workflows/build.yml#L18

Should this be closed now @vijayvarma392?

Yes, and feel free to take executive decisions about which issues can be closed :)


[7.x.x] Bump Dependencies #5230682984

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/5230682984

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


kss/sass error: "error reading values after ..."

I'm trying to compile a folder of .scss files in to a kss styleguide and getting the following error:
Error during generation

src/scss/bs-constants.scss:17: error: error reading values after "0"

After a fair bit of Googling and combing through various blogs and forums. Could it be the sass compiler that grunt-styleguide uses?
As best I can discern the error can be traced back to my usage of sass maps
Here's a snippet of the sass map that seems to be hanging up the system.
$layers: (
    "0" : -200,
    "1" :    0,
    "2" :  200,
    "3" :  400,
    "4" :  600,
    "5" :  800,
    "6" : 1000
);

Additionally here's a snippet of my gruntfile.js
        styleguide: {
                options: {
                    template: {
                        src: './styleguide/template/'
                    },
                    framework: {
                        name: 'kss'
                    }
                },
                all: {
                    files: [{
                        './documentation/': './src/scss/lib.scss'
                    }]
                }
        }

Any help would be much appreciated.
Ken

@frederickk node-kss has removed all pre-compilation of Sass in future versions from 2.0. It's my intention to upgrade styleguide to use this new version which will mean you will have to use a separate grunt task for the sass compilation. Then in the options you would just specify the generated CSS to include.

That sounds great, as I'm already compiling my SASS with a separate task already. Looking forward to the next release.

@frederickk if you are using kss exclusively I recommend you use https://www.npmjs.com/package/grunt-kss


[3pt] Warning Cleanup: Burn in Bridges, Mask Levee-protected and D8 Slopes from DEM

Now that we have a warning log file, it will uncover (and has) some warnings that maybe be addressed some day.
These ones came from a quick test against 05030104.
I selected just these three for now as they were very prevenent.
================
Burn in bridges 05030104<PHONE_NUMBER>
/usr/local/lib/python3.10/dist-packages/rasterstats/io.py:335: NodataWarning: Setting nodata to -999; specify nodata explicitly
  warnings.warn(

Note: Some but not branches also threw a second part to the warning:  ie)
Burn in bridges 05030104<PHONE_NUMBER>
/usr/local/lib/python3.10/dist-packages/rasterstats/io.py:335: NodataWarning: Setting nodata to -999; specify nodata explicitly
  warnings.warn(
/usr/local/lib/python3.10/dist-packages/geopandas/io/file.py:633: UserWarning: You are attempting to write an empty DataFrame to file. For some drivers, this operation may fail.
  _to_file_fiona(df, filename, driver, schema, crs, mode, **kwargs)

In: delineate_hydros_and_produce_HAND.sh
echo -e $startDiv"Burn in bridges $hucNumber $current_branch_id"
python3 $srcDir/heal_bridges_osm.py \
================
Mask levee-protected areas from DEM (*Overwrite dem_meters.tif output) 05030104<PHONE_NUMBER>
/usr/local/lib/python3.10/dist-packages/rasterio/mask.py:88: UserWarning: shapes are outside bounds of raster. Are they in different coordinate reference systems?
  warnings.warn('shapes are outside bounds of raster. '

in: delineate_hydros_and_produce_HAND.sh
================
D8 Slopes from DEM 05030104<PHONE_NUMBER>
D8FlowDir version 5.3.5
WARNING: no output p file specified

In: delineate_hydros_and_produce_HAND.sh
Yes. this is a Taudem call, but worth taking a peek at.
================

I ran fim_pipeline.sh on HUC 05030104 using dev-python-upgrades (#1253) and the first warnings have disappeared. The other two are still there.
-----------------------------------------------------------------
Burn in bridges 05030104<PHONE_NUMBER>

-----------------------------------------------------------------

The UserWarning about an empty DataFrame was addressed by #1225.
-----------------------------------------------------------------
Burn in bridges 05030104<PHONE_NUMBER>
The geoDataFrame is empty. File not saved.

-----------------------------------------------------------------


Release Text Analytics Track 2

This tracks the work to release the Text Analytics Track 2 library.

@AlexGhiondea  which version? should we close this issue as we already released GA for TA?

I believe this has been concluded last year so I will close it. Please feel free to re-open it if there're any pending items still.


ObservableObjectPublisher requires implementation.

It seems that we need runtime support to implement this.
🤔, I am considering the feasibility of introducing runtime as a dependency.

Done with #28. Since it's unstable and requires Runtime as dependency, you need env variable COMBINEX_EXPERIMENTAL_OBSERVABLE_OBJECT to enable this feature.
Once we strip Runtime dependency, the env flag can be removed.


Menu sub-items should be visible whenever the menu is in active state

Click on the File menu, the contents of that menu will be visible.
Hover over the Notebook menu and "Notebook" is set to active state but the menu items are not visible.
The menu should behave in the same manner as a browser menu, moving your cursor over the various menu items after having clicked on one should open and highlight whichever item your cursor is hovering on. A second click will close the menu and hovering over an items will not show the list of sub-items or show the item in an active state.
In the attached screenshot "Notebook" should have its menu items displayed.

agreed this is better behavior.


Implement a foundry based testing framework

There is a shared feeling that the current hardhat testing framework is hard to use, unstable, and generally a mess.
While we want to keep it because having the TypeScript-based framework is important for compatibility and e2e testing purposes, a new Foundry-based testing framework is needed for iterative, quick feedback smart-contract side development.
I will implement test contracts mocking everything that is happening outside of the host chain in Inco using Foundry cheat codes, and provide a base to write Solidity tests for the cERC20 implementation and future confidential smart contracts.
Please use this issue to give feedback while I start working on it.

can you assign this to me! @npasquie


Need to error out if instance creation fails

If the instance creation fails (e.g. due to not having a backing volume) the failure from is not reported back to ciao-cli and to the user it looks like the creation has succeeded. It looks like it has succeeded because an instance uuid has been returned.
e.g "Created new instance: a4224629-88ea-45e0-8eb2-8dce411af3e1"
But that instance creation failed.

the instance creation can fail aychronously. we should change the wording of the message from ciao-cli to indicate that the instance is pending creation.

Easy to do quickly s/Created/Asynchronously creating/


How to prevent the pickler from using fully qualified names?

I have an error where un-pickling data triggers this error:
it expects:
'Microsoft.FSharp.Collections.FSharpMap`2[IExchange.Instrument,Testing+TrendAnalysis[]]'
but got:
'Microsoft.FSharp.Collections.FSharpMap`2[IExchange.Instrument,Program+TrendAnalysis[]]'
The object to deserialize to is the same, I just relocated it in the project. How can I prevent it from using the full name of the object so that the definitions can be moved around?

Per documentation in http://mbraceproject.github.io/FsPickler/ the serializer is not designed with version tolerance in mind. That being said, it should be possible to work around that issue by providing a custom implementation of the ITypeNameConverter interface.