[CHA-RL7] Room lifecycle operation precendence

This is an important part of room lifecycle management.
Spec states that
(CHA-RL7a) [Testable] Room lifecycle operations have a precedence. If multiple operations are scheduled to run, they run in the following order:
(CHA-RL7a1) The RETRY operation – an internal process.
(CHA-RL7a2) The RELEASE operation.
(CHA-RL7a3) The ATTACH and DETACH operations have equal precedence
We have currently specified two solutions for this

RoomLifecycle: Sequential Coroutinescope using select
RoomLifecycle: Atomic Coroutinescope

I have listed few concerns with option 1, since it needs extra implementation to handle edge cases and can cause memory leaks even after room release.
So, currently going with option 2, I have raised channel attach PR on top of it -> https://github.com/ably-labs/ably-chat-kotlin/pull/33. We can refactor it a bit more, but I strongly believe the current impl. is well-tested and can be used as a part of the room lifecycle

┆Issue is synchronized with this Jira Task by Unito

Fixed via https://github.com/ably-labs/ably-chat-kotlin/pull/32


Feature: pair @cond and @endcond commands together as collapsible regions

Firstly, great work! Colourizing the @attention and @warning commands alone is enough for me to make this a regular part of my workflow, let alone all the other great stuff.
Anyways, my feature suggestion: In the past when I've wanted a collapsible region around large amount of code at file scope I've used things like #if 1 / #endif (or #pragma region, but other compilers complain about that). Since I often use doxygen's condition regions in public API's, it'd be nice if those could also be used as the basis for collapsible regions in the VS editor.

I think that is a great idea. I will look into it. Not sure whether it is possible to add additional regions to an existing language. I do hope so, but I learned to expect things to be more difficult than expected when it comes to the VS extension API. Also, no promises on the time frame 😉

Thanks for considering it!

This is such an extraordinary extension that deserve more stars and attention. Thanks a lot for your work @Sedeniono
Regarding to this issue, it seems to be do-able by looking at this doc

@HO-COOH thank you for the kind words 😊
I have not forgotten about the collapse regions/outlines, but private life and other projects kept me busy. (I also wanted to update the extension to support the latest Doxygen commands for months now...)


A couple of questions and suggestions

First of all I would like to say that so far, Vox look so promising!!!! Your design choices are on point. A d-like language without a GC, a bloated runtime with even faster compilation times? I must be dreaming! First of all I would like to ask some questions and then proceed on giving some suggestions. Of course you should read this with caution  cause maybe some of them may not be good ideas. So first of all I would like to give a little bit of background about me. You can of course skip it but you may be interested and it will help you understand with I'm so Hyped with Vox. Also keep in mind that I disited to write that here rather than getting in contact in private because there will be suggestions here (I hope you would consider some of them, lol) so it will be fine to stay here and also have other people saying their opinion.
My background
I started coding in about early 2020 (I kinda had some experience with Python but I don't count that). I feel really bad for saying that, but I don't think that I have made anything significant thorough this time. Which is really disappointing if you think that we are talking about a span of 1.5 years. Well I learnt TONS of stuff but didn't do a lot in practice. Were I wasted my time? Easy! 85-90% I was searching for my ideal programming language. I've come across tons of different languages but explain each one and saying why I didn't finally used them, would literally take paragraphs and paragraphs... From what you understand, I don't like the "Choose the right language for the right job" phrase. I want to learn only 1 language that will be able to do anything (even if it's not better in everything) and be a professional about it. Anyway let's see my ideal language.
My ideal language
I will go straight to the point. My ideal language compiles fast! Really fast!!! It should be able to have compilation times close to C (or even better). The performance should also be important. It should be at worse 2-3 times slower than C (again at worse). The syntax should not be bloated (not unnecessary and hard to read code) but still clear and not Python-like. And finally It should not limit me in anything or in general make my life harder (Yes Rust I'm talking about you).
Vox has the potential to be this language
Vox is not there yet (not in everything at leas) but it has an amazing potential. If we see that we have common goals, I would like to help and make the new TRUE replacement of C (C++ and D failed to do that)
Questions

How does Vox compiles so fast (faster than GCC, Clang) and still produces code that is 80-100% slower than optimized (-Os) gcc? Well tbh I don't know if that's the case, I just tried one example with fib numbers. Also only 35k loc? Man wtf!!!
Does Vox has an optimization flag or it does it out of the box (like Go)? You say that one of the goals is: "Maximize application performance" so I suppose you care about optimization right?
What's the current state o Vox? What has been implemented so far?
Is the memory only manual managed?
How the structs are implemented? Are they similar to C? Are they lighter and faster than C++/D classes/structs or?
Are there any feature that Vox has (or is planned to have) that C++/D doesn't?

Suggestions
Before I type the suggestions out, I just want to be very clear that I don't think like a spoiled user who demands what he has or else "I won't use your language". You have the final word and you will decide. Also like I said before, If we have the same views on some topics, I would also learn and join the development. Let's see:

DOCUMENTATION!!! Pretty much the most important thing imo. I'm talking about both user documentation and about developer documentation. The first one will come in time but I think that in this point the second one is more important as people should learn and how Vox is structured and how it works so we can contribute and improve the language. This will be really useful for people like me that want to help
Please allow people to make suggestion/feature requests just like I do now and not make it necessary to write a whole HUGE proposal like D does. This is really annoying and it takes a lot of time to write, review and finally get approved. YOU should be the only one to decide the direction of Vox and choose who will get implemented and what not. D is where it is now pretty much because of this (well not only because of that but the language doesn't have a direction).
Create a standard library that will be linked automatically (while having a flag to not link it). Let's make the library something between C++ and D in size with performance in mind so build directly on system calls rather than build on other functions like C++ (and D if I'm not wrong) does. I know this will take a lot of years to reach to this point but we gotta start right?
Package/Project manager. I mean we all know the C/C++ dependency hell...
Make a automatic memory management system (optional)  based on some rules for when the memory is freed just like how Rust does it (but not having Ownership). If you are interested on this one, I could tell you my ideas.
Optional semicolon maybe? I think we can have the end of a statement to be the end of the line just like a lot of other languages. The semicolon can be used when someone want to have a lot of statements in the same line.
This a little bit of a detail thing but I think that you should also add words for types rather than just have things like "i32" because I think having numbers is a little bit distrusting. If not then maybe implement D-like alias where people can alias the type with the name they want (which would also be a great feature in general to beginning with). Also I think the the brackets look better after the name of the variable and it will also allow us to create multiple arrays of the same type with different sizes.
For the end, I would say that I would like to see a strong template system like Rust's macro rules which is SUPER flexible and powerful. However you have pointed out in the "README" that you care about strong meta-programming and the you plan to implement macros (WIP) so you probably already thinking about that.

Anyway that was all. I know it was huge and I hope you don't mind but I'm so so so excited! The fast compilation times where really what I was looking for. Any language with fast compilation time would either by 4-6 times slower than C or it would be C (which is fine but really annoying when you hit the limitations). So if everything goes as planned, I'll look up the code and I hope I can help as soon as possible! Thanks for your work and I hope Vox gets big (fingers crossed!)!

Questions:

Language is simpler. Compiler is written from scratch, and with minimal dependencies, which means less stuff to worry about, and code does the minimum work. Data layout and memory management is optimized for speed. Less unneeded abstractions. Maybe less modularity. Of course there are even faster compilers like tcc (which is ~5x faster than Vox). Compiler runs in single thread atm, so there are some gains there + I could make an even simpler back-end for faster builds too.
There are a couple of internal settings to toggle some optimizations, but all optimizations are on by default atm. Very low number of optimizations are actually implemented rn: front-end does constant folding + IR generation with minimal control flow, back-end has inlining, primitive dead code elimination and medium complexity register allocation. The plan is to have a couple more common optimizations + intrinsics. So should be in 1x-2x from LLVM/GCC perf.
I would say that Vox is on C level + some extras atm. By extra I mean basic templates, some CTFE.
For now only manual management, but with templates one can write and use containers that will manage memory for you.
structs are basically the same as in D. POD + methods. No constructors though.
I think it is mainly meta-programming + CTFE. (Also compilation speed 😄)

Suggestions:

See internals.md for details on how Vox compiler is implemented. Of course it is not exhaustive, but I try to fill in the gaps from time to time. Please ask me if you want me to go in detail on something specific. Some bits of user documentation are in /spec/index.md, but that is mostly on stuff that is new to D users, not going in detail on basics.
Worth mentioning that compiler itself compiles fast (4s) and test suite runs fast (70ms), which is important for working on the compiler itself.
Unnecessary bureaucracy is indeed harmful for the contributions, but this doesn't mean that not doing necessary research and analysis is a good idea. The steady progression zone is somewhere between those extremes.
On one hand I want to cover the need for exploratory programming, where you want to go fast with less quality (battery included mode). On the other hand the main use-case for me is game development, where you need 99% of control on everything. Another point is that I prefer conservative choices at the start and I don't trust myself to write a good general-purpose std lib. So, atm I write utility code for myself.
There is also a point that without std lib the language is easier to embed.
One option that I see is to have std lib be a regular package in package manager. This way it is both opt in and readily available. The most important goal for std lib is not to have common implementation, but common interfaces that many other packages can agree on.
Yeah, this is one of those problems where all solutions are kind of meh (you can include memory management and error handling in here). However I like the way Zig and Jai do this. Note, that it is actually 2 problems: package management + build system.
As I already mentioned, this is one of the generally unsolved problems for me. The path that I can envision in the future include allocator system a la Zig/Jai/Odin, automatic ownership like in Lobster and wholly inclusive system like in Cone
I'm 95% nope on that one.
This was a bit of uneasy decision for me to choose between D-style basic type names and more modern one. In the end I decided to use the one with bit sizes as more consistent option. Vox supports alias declarations like in D (syntax can potentially change).
On the topic of brackets after variable name. If I understood correctly then you mean stuff like:i32 var1, var2[40];

Which is referred to as spiral rule in C (see here). Modern languages moved away from this very big flaw of the C language. This is one of those decisions that I'm very confident about.
Another thing that is currently unimplemented in Vox is ability to define multiple variables on the same line. I'm not a fan of doing opinionated things in the language, but I a) don't personally use those b) find it surprising when I encounter multiple definitions on one line, often missing the rest of the line. c) find it more readable when every definition is on its own line.
So, I prefer this:i32 var1;
i32[40] var2;

Some kind of code generation is definitely on the list. But the goal is to have in a more procedural way, so that it is both more like regular code and more performant to run.

Atm priorities are like that:

Compiler stability and bug fixes. There are a couple of places that are inexhaustible source of bugs, which need systematic solution. That includes node evaluation order problems and IR generation when dealing with aggregates.
Improving existing features
Adding new language features

Thanks for your feedback! Make sure to read internals/spec files, those contain most of the documentation I have so far. I hope for productive collaboration.
P.S. I will move this in Discussions tab if you don't mind.


Update sensor (swiss_public_transport) for new UI

This sensor was not working nice with the new frontend. This update moves some information away and misuses the unit field to display the remaining time till the next departure.

The problem with misusing the unit field is that the history tab will go nuts, trying to create a line chart for each unique unit it detects in the states.

I think that we shouldn't spend a lot of time on this because it seems that I'm the only one who is using this sensor. For this kind of sensor it would be nice to be able to disable the logging (aka don't use the data in the history). But that's a topic for the future, I guess.

Closed because idea was wrong.

Hey @fabaff
First I'd like to thank you (very much!) for this awsome work, you're definitely not the only one using it. I had to increase the scan_interval and now get reliable notifications every 5 minutes (30min after I wake up and with sliders for when I think I'll leave work).
The only thing that bugs me is the many errors I get in the log, either about buffering or timeouts...
File "/usr/local/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 385, in _make_request stderr 20:48:31     httplib_response = conn.getresponse(buffering=True) stderr 20:48:31 TypeError: getresponse() got an unexpected keyword argument 'buffering'
requests.packages.urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host='transport.opendata.ch', port=80): Read timed out. (read timeout=30)
PS: I tried changing the logger options for requests.packages.urllib3.connectionpool (that didn't work) and will try now to change the sensor options to critical only...


List jumps to the top of the List when onStartReached is called

I'm fetching data from an API which will either be appended at the end of the List (onEndReached) or the beginning of the list (onStartReached).
However when onStartReached is triggered, the list will jump to the very top, which will then again call onStartReached. It should not jump to the top of the list. Even with enableAutoscrollToTop set to false, which I know is the default value, it still jumps to the top.
When I reach the end (onEndReached) everything works as expected.

For future reference: keyExtractor is the most crucial thing. If set correctly, this list works perfectly fine, so mistake on my end.


Update links for generic types

Basically, apps can specify only the module name (not the full type) to allow some flexibility in matching any subtype in the module so I needed to tweak the links to work. I also did some tidying and DRYing while I was at it.

I can see that this works fine for the links in sections for the "organize by input/output types" views.
There are also type viewer links in the app view kbaseCatalogAppViewer.js which are subject to this issue as well. There are other instances type links which I haven't inspected closely -- I suppose anywhere a #spec link is created from a type identifier should be similarly modified.
Interestingly, the type catalog takes a different approach to type links -- the module component links to the module spec, the type name to the type spec. Not necessarily in scope for this PR, but there might be something to having the links work the same.

@eapearson I did a second look over and I pretty sure the app view is the only other place that needed fixing. I could change all the links to work the way that the type page links do but I'm not sure that would be super helpful to the average user. When an average user is presented with a type, I'm pretty sure they want the actual type 99% of the time so the module might be more confusing than helpful to a user that doesn't really know our type system


Respect Retry-After header in Torznab queries

ToDo

[x] cleanup initial chatgpt code 😅
[ ] Test
[ ] verbose logging?

Git Ref

Fixes #375

I think the workflow needs to be updated to pull_request_target instead of pull_request so the tokens carry over.
https://github.com/cross-seed/cross-seed/blob/master/.github/workflows/ci.yml#L9

LGTM, lmk when you're ready for a merge.

changes look good.  Probably should be tested, but also seems simple/logical enough to just Yeeet in 😅

Logic seems sound, unfortunate that we cannot test a container build of this PR. We should be able to make PRs build though without much a hassle.

yolo


Signing in on Github Enterprise errors out

Extension version: 0.3.2
VSCode Version: 1.30.2 (1.30.2)
OS: macOS Mojave

Steps to Reproduce:
When trying to login on my Enterprise GitHub, every time I click sign in it leads me to a page on https://vscode-auth.github.com which errors out:

Same here, my guess is this is happening because our enterprise GitHub server is on premise and can't be accessed from internet. It looks like VS Code is trying OAuth from a Heroku app.

@pcastellazzi I did follow those steps and while the token did get copied to my keychain, I'm still finding it requesting me to login when I launch VSCode and integration not working.
(As a side note it should prob. highlight that after relaunch the token gets moved to keychain. I kept on checking my settings.json and after seeing it missing assuming that was the broken part. Maybe I'll PR to docs with slightly clearer language)

I have the same issue using Extension Version 0.4.0 and Visual Studio Code 1.31.1 on macOS 10.14.3
The workaround also doesn't work. I can see the token in the keychain but it keeps me asking for login credentials.
I can also see in GHE that the token has never been used.
The GHE instance is not reachable from the internet.

Same issue.

Can we have the server instead of timing out and showing a 404 redirect to the alternative instructions and/or maybe add a link to the instructions that combines the attempted enterprise host combined with /settings/tokens/new?scopes=repo,read:user,user:email,write:discussion&description=VSCode%20Github%20Extension which will autofill the entire token form for you. People would just hit 'generate' and then copy-paste the token.
It's a little annoying that alt-tabbing away from VSCode after you enter the token cancels the flow (I have to type in the enterprise host without letting VSCode lose focus).

@ProLoser while working to debug some of these GitHub Enterprise issues, I ran into this scenario. I'm looking to fix it for the next release. Hopefully fixing this is a start to better understanding some of these authentication issues.
@mkonikov I'm working to figure out the issue you have been having, but as mentioned earlier, the error might be a consequence of the setup. In the meantime things have changed in the plugin as far as authentication goes, would you mind updating to the latest version and starting again from scratch?
@stinnux did you try the workaround that was mentioned in the wiki. https://github.com/Microsoft/vscode-pull-request-github/wiki#personal-access-token-authentication
@akbyrd can you be a bit more specific, same issue as whom?
Also, what version of GitHub Enterprise are you all using?

@StanleyGoldman Seems to work for me now.

Hey @mkonikov I'm glad it's working for you, but so I can be sure of what I'm debugging, can you be a bit more specific.

What steps did you go through that worked for you?
What version of the extension are you running?
What version of GitHub Enterprise do you have?

Honestly nothing. Just tried again with the latest version.

I'm still seeing this issue.
GitHub Pull Requests 0.11.2, GitHub Enterprise 2.15.18.

Still broken with version 0.15.0 & GitHub Enterprise ???.

We have discontinued support for GitHub Enterprise. https://github.com/microsoft/vscode-pull-request-github/wiki#2-is-github-enterprise-supported


feat: Add Uno Platform Sandbox and Quickstart links

Add Uno Platform Sandbox and Quickstart links
Related PR: feat: Add ScottPlot Uno Platform QuickStart

Hi @agneszitte, thanks so much for this PR! I look forward to merging it soon, but I'm travelling for the next several days so it may take me until next week before I can get started.
One thing I notice is that there are a few "dot files" in this commit. Specifically .vscode and .run folders and .vsconfig and .editorconfig files. I wanted to double-check with you whether this was intentional before this gets merged into the main branch. Thanks for your input!

Regarding the common weakness identified by CodeQL, more information is on https://codeql.github.com/codeql-query-help/csharp/cs-web-missing-global-error-handler/ which provides recommendations for how to edit web.config to be a little more secure.
I recognize that having this code in the sandbox app is low risk in itself, but it would be great if we could implement a fix to make this a little more secure by default in case it gets copy/pasted into a production environment.

Regarding the common weakness identified by CodeQL, more information is on codeql.github.com/codeql-query-help/csharp/cs-web-missing-global-error-handler which provides recommendations for how to edit web.config to be a little more secure.
I recognize that having this code in the sandbox app is low risk in itself, but it would be great if we could implement a fix to make this a little more secure by default in case it gets copy/pasted into a production environment.

@swharden  I have removed the web.config default file in the sandbox app. It’s unnecessary for local tests for WebAssembly and primarily used for deployments on IIS. When creating a new Uno Platform project, this file is added by default but can be adjusted as needed to enhance security.

Hi @agneszitte, thanks so much for this PR! I look forward to merging it soon, but I'm travelling for the next several days so it may take me until next week before I can get started.
One thing I notice is that there are a few "dot files" in this commit. Specifically .vscode and .run folders and .vsconfig and .editorconfig files. I wanted to double-check with you whether this was intentional before this gets merged into the main branch. Thanks for your input!

@swharden I removed them as well. They are added by default with a new Uno Platform project but not necessary in this case.

Hi @swharden, let me know if you need anything else for this PR please

Hi @agneszitte, thanks again for this PR! It took me longer than expected to get to it, but I look forward to merging this today, publishing a NuGet package, and updated the docs on the website.

I am currently unable to launch Desktop WSL2 with the Sandbox with Visual Studio for this solution due to a space in the path.

https://platform.uno/docs/articles/common-issues-vs2022.html#my-application-does-not-start-under-wsl

Because a proper fix would involve renaming a lot of important folders, I'm satisfied leaving it as it in the sandbox app. The important thing is that users can create new Uno Platform projects that use ScottPlot by following the QuickStart guide on the website. As long as the docs are in a good place, I think most people will not encounter this issue.

Thanks a lot, @swharden for merging the changes here <3


Getting some errors

Hi,
thanks for this great work!
I tried to read some files, and I got:
---------------------------------------------------------------------------
UnboundLocalError                         Traceback (most recent call last)
Cell In[64], [line 1](vscode-notebook-cell:?execution_count=64&line=1)
----> [1](vscode-notebook-cell:?execution_count=64&line=1) pad = signal_to_pad(np.tile(binarized_mean_signal,8))
      [3](vscode-notebook-cell:?execution_count=64&line=3) # How long is the signal 1
      [4](vscode-notebook-cell:?execution_count=64&line=4) one_times = pad[:,0]

File [/usr/local/lib/python3.11/site-packages/flipper_raw_rfid/utils.py:66](https://file+.vscode-resource.vscode-cdn.net/usr/local/lib/python3.11/site-packages/flipper_raw_rfid/utils.py:66), in signal_to_pad(signal)
     [63](https://file+.vscode-resource.vscode-cdn.net/usr/local/lib/python3.11/site-packages/flipper_raw_rfid/utils.py:63)     if len(p) == 1:
     [64](https://file+.vscode-resource.vscode-cdn.net/usr/local/lib/python3.11/site-packages/flipper_raw_rfid/utils.py:64)         yield p[0] - position, len(s) - position - 1
---> [66](https://file+.vscode-resource.vscode-cdn.net/usr/local/lib/python3.11/site-packages/flipper_raw_rfid/utils.py:66) return numpy.array(list(it(signal)))

File [/usr/local/lib/python3.11/site-packages/flipper_raw_rfid/utils.py:63](https://file+.vscode-resource.vscode-cdn.net/usr/local/lib/python3.11/site-packages/flipper_raw_rfid/utils.py:63), in signal_to_pad.<locals>.it(s)
     [60](https://file+.vscode-resource.vscode-cdn.net/usr/local/lib/python3.11/site-packages/flipper_raw_rfid/utils.py:60)         yield p[0] - position, p[1] - position
     [61](https://file+.vscode-resource.vscode-cdn.net/usr/local/lib/python3.11/site-packages/flipper_raw_rfid/utils.py:61)         position = p[1]
---> [63](https://file+.vscode-resource.vscode-cdn.net/usr/local/lib/python3.11/site-packages/flipper_raw_rfid/utils.py:63) if len(p) == 1:
     [64](https://file+.vscode-resource.vscode-cdn.net/usr/local/lib/python3.11/site-packages/flipper_raw_rfid/utils.py:64)     yield p[0] - position, len(s) - position - 1

UnboundLocalError: cannot access local variable 'p' where it is not associated with a value

any ideas why?

I got this issue too running the code on raw data of a pet microchip that my F0 can't scan but when I ran the code on the raw dump of a card I can scan natively the code runs fine. Not sure the reason but I think the raw dumps I have either haven't scanned properly or can't be by the Z0 :(.


pdal: 2.8.0 → 2.8.1

https://github.com/PDAL/PDAL/releases/tag/2.8.1
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 354986 run on x86_64-linux 1

6 packages built:

entwine
grass
pdal
qgis
qgis-ltr
saga


Fix metadata template issue when using Adetailer

This PR fixes a bug with how the prompt template is saved when using Adetailer: https://github.com/adieyal/sd-dynamic-prompts/issues/703
I'm not sure why Adetailer does this, but after it processes an image, it calls the process() function of dynamic-prompts a second time and, during this second execution, dynamic-prompts overwrites its template metadata with a prompt value that no longer contains template information.
So this PR just makes sure not to overwrite the template metadata after it's written correctly the first time.

https://github.com/adieyal/sd-dynamic-prompts/pull/790


[Dubbo-config]fix the bug of the delay configuration in dubbo.properties is invalid team2

What is the purpose of the change
fix the bug of the delay configuration in dubbo.properties is invalid, close #1728
Brief changelog
change ServiceConfig.java, get properties before judge delay
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

issue3

bug复现
搜索export服务发布接口，设置断点进行问题复现 ------dubbo.properties中的delay配置不生效

Debug
doExport()中参数校验、反射默认初始化
appendProperties(this)中

可以看到这里对延时进行了读取，所以问题找到了。就是在 if (delay != null && delay > 0)判断时 还没有读取properties中的参数设置。 解决就是在判断前进行读取appendProperties(this);

Codecov Report

Merging #2271 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2271      +/-   ##
============================================
- Coverage     54.57%   54.54%   -0.04%
+ Complexity     5156     5153       -3
============================================
  Files           568      568
  Lines         25019    25020       +1
  Branches       4456     4456
============================================
- Hits          13655    13648       -7
- Misses         9323     9328       +5
- Partials       2041     2044       +3

Impacted Files
Coverage Δ
Complexity Δ

...in/java/org/apache/dubbo/config/ServiceConfig.java
47.56% <100%> (+0.12%)
62 <0> (ø)
:arrow_down:

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
37.5% <0%> (-12.5%)
3% <0%> (ø)

...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java
51.89% <0%> (-3.8%)
10% <0%> (-3%)

...bo/remoting/transport/netty/NettyCodecAdapter.java
53.12% <0%> (-1.57%)
3% <0%> (ø)

...ache/dubbo/remoting/transport/mina/MinaClient.java
56.92% <0%> (-1.54%)
8% <0%> (-1%)

...pache/dubbo/registry/support/AbstractRegistry.java
50.93% <0%> (-1.13%)
43% <0%> (ø)

.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java
57.89% <0%> (-1.06%)
18% <0%> (ø)

...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java
59.16% <0%> (+0.83%)
31% <0%> (+1%)
:arrow_up:

...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java
64.51% <0%> (+6.45%)
3% <0%> (ø)
:arrow_down:

...onfig/spring/extension/SpringExtensionFactory.java
85.71% <0%> (+10.71%)
10% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c16f78...d97bdaf. Read the comment docs.


Possible to show devTools only?

Is it possible to show devTools only and hide the entire webpage view?

I guess you can detach the dev tools and hide the browser window?

Yeah hiding the browser window would do the trick.


Improve BlockColourGen by using block.getBlockState().getValidStates()

Currently the code tries to get a block state for each of the possible meta combinations. This leads to more lookups than necessary and is a big contributor to the exceptions you have to catch. You can use block.getBlockState().getValidStates() to get an immutable list of all valid states. In the tests I ran, this lead to an increase in load times. This increase was slight in vanilla, but more noticeable in heavily modded environments.

i will look into this. thanks for the information

You could further optimize this code by replacing the code used to check for duplicate sprites. You currently compare all four UV coordinates, however you only need to compare U1 and V2 to get the same results.
If you wanted to further improve this code, you could map TextureAtlasSprite objects to their colour, and then use this result instead. In my basic tests the speed is roughly the same, but results in more sprites being skipped. This would likely have the biggest impact with higher res textures.


Convert Imported Libraries While Transpiling

Google has achieved this with Grumpy and Go, would it be a possibility to have transcrypt actually go in the folders of the imported modules and do the conversion and include those as well ? Not talking about things tied to the operating system of course.

Transcrypt takes into account modules in subdirectories and includes the resulting JavaScript, as described in:
http://www.transcrypt.org/docs/html/special_facilities.html#transcrypt-s-module-mechanism
It will also take into account modules in the CPython installation, as long as they are Python only and don't use facilities that Transcrypt doesn't support, like e.g. exec. This means that Transcrypt e.g. has its own implementations of math, random, re, time, etc.


adds-alt-text

Added support for including the image description (alt text) in the pptelement interface to be used in  the ppt-service

Looks fine, let me know once deployed and tested. Then i will be merging it. Since in order to use it in our service we just need to update the npm package and merge is not mandatory.


Adding translations for other languages for countries used in the bottom sheet

Found translations here and created a script to merge them in to one file for this repo.
Ready 👍

Awesome stuff 🔥🔥🔥... Thanks ^_^

Hi, just tested this out locally again and I'm seeing that failure to load the countries error again. It cannot seem to load that json file, but it works during testing 🤔....
Please revert and I will fix 🦖


Uninterpreted extension 'import'

Hello,
type%import longident = Longident.t [@@deriving show]

produces an error:
File "lib/lib.ml", line 3, characters 5-11:
3 | type%import longident = Longident.t [@@deriving show]
         ^^^^^^
Error: Uninterpreted extension 'import'.

Confirmed with dune 3.7.1.
It uses staged_pps in dune file. The complete code base is here:  https://github.com/keigoi/test_ppx_import/blob/main/lib/lib.ml

Hi @keigoi , the new syntax is only available if you are using the master branch of ppx_import, likely you are using 1.10 which needs this syntax:
type longident = [%import: Longident.t] [@@deriving show]

Hi, it worked like a charm. Thank you very much and sorry for the late reply!


Some times number keys are not working while power toys works in background.

While working on my pc and laptop I've enocourged a problem that keys from 1 to 0 on my keyboard are not working. It happened to me on two different machines. While pressing any number I saw that power toys fancy zones are blinking. Turning off power toys or restarting pc solves the problem.

Hi @mshadem
which version of PowerToys are you running?
The bug is supposed to be fixed in the current release https://github.com/microsoft/PowerToys/releases/tag/v0.14.1
Can you give it a try?
Thanks.

I have <IP_ADDRESS>. Will try with 14.1. Thanks

I'm going to close this issue since this was fixed in the new release. @mshadem if you still have this problem with the new release feel free to reopen this.


Automatic SSL/TLS

I saw the docs about pointing to an existing SSL/TLS certificate: https://github.com/axllent/mailpit/wiki/HTTPS
Another Go project, PocketBase, automatically issues Let's Encrypt certs if you pass the --https flag: ./pocketbase serve --http="mysite.com:80" --https="mysite.com:443"
It looks like they use https://pkg.go.dev/golang.org/x/crypto/acme/autocert
Here's how it is implemented in their server code: https://github.com/pocketbase/pocketbase/blob/master/cmd/serve.go#L61
Would something like that align with the roadmap for Mailpit? It's an awesome project by the way, thanks for all your hard work!

Thanks for the kind words @jimafisk.
Early on in development I had briefly considered something like this, however I very quickly came to the conclusion that it would cause far more problems than it would solve. Firstly Mailpit is designed to run as a separate stand-alone service, mostly alongside whatever other services there would be. In most cases this means that a webserver is already running on ports 80 & potentially 443, and that Mailpit is running on some alternate port (eg 8025). In order for Let's Encrypt to register or renew, the certificate requesting service must be running unencrypted on port 80 (even if it's a redirect to another secure port), and must be accessible to the internet on those ports. This is by design of Let's Encrypt.
This would mean that Mailpit would need to run an unencrypted HTTP server on port 80, and redirect to whatever other port one has chosen. So to get back to my point - users who would try make use of such a feature would end up with all sorts of conflicts because of the requirement for port 80 (conflicting with existing services) or they wouldn't realize that it has to be externally accessible, and I would endlessly have to explain that this functionality would be for edge cases whereby Mailpit would be running as the only service on an externally-accessible port 80 etc etc.
It's just not worth the effort to be honest. If the hosting server doesn't already run anything on port 80 (but is accessibly from the internet), then Certbot has ways to spin up a temporary HTTP server to handle the certificate request. So basically there are already existing official tools to handle this, rather than try and cater for everyone's unique situations using software that is "is a work in progress and makes no API stability promises".
I hope that makes sense, but this is not a viable option for Mailpit.

Totally understand, thanks for the explanation!


Implement RFC 6531 (SMTP Extension for Internationalized Email)

Is it possible to implement Proposed Standard RFC 6531?
Right now we're experincing a problems with German users, which has umplauts in their usernames. Like, " Address in mailbox given<EMAIL_ADDRESS>does not comply with RFC 2822, 3.6.2.done "
We can't force them to change emails, because they are already using them and experience no problems at other services.

+1

+1

:+1:

I've found a way to hack SwiftMailer to be able to work with i18ed email addresses.
Check this gist: https://gist.github.com/e1himself/58c53aeef31a45345172
We use this hack in our project, so it's verified it's working on SwiftMailer v5.2.2.

What also seems to work, but requires PHP7, is to switch all PCRE-calls to UTF-8 mode and then use the new Unicode codepoint escape syntax to augment to atext block in SwiftMailer's Grammar class:
Grammar.php:84
self::$_grammar['atext'] = '[a-zA-Z0-9\u{0080}-\u{07ff}\u{0800}-\u{ffff}\u{10000}-\u{10ffff}!#\$%&\'\*\+\-\/=\?\^_`\{\}\|~]';

MailboxHeader.php:346
if (!preg_match('/^'.$this->getGrammar()->getDefinition('addr-spec').'$/Du',

This is basically what RFC 6531 is all about, but absolutely not the best way to do it. You'd have to rewrite SwiftMailer completely and make it more abstract for it to allow RFC 5321-based email messages (RFC 5321 = the current SMTP version from 2008; SwiftMailer is still based on RFC 2822 from 2001).

No need for PHP7, the Unicode codepoint escape syntax is about strings not about regex.
The PCRE engine already supports unicode without any problems.

@sstok: Yup, but those aren't included in [a-z], obviously. The regular expressions used by SwiftMailer do not support Unicode (UTF-8) character sequences, so you have to augment them. One of the easier ways to do this, is to use unicode codepoints in PHP7 to specify the desired Unicode character ranges.

Any news regarding the plan to implement this / allow unicode in pre-@ part? Just bitten by this. Symfony Email validator allows users to enter umlauts etc, but later sending with SwiftMailer will fail...

+1

fixed in master

@cerlestes Your diff works perfectly for legacy code that is hard to update!
Thank you very much!


Documents:  Change restriction to warning when entering file location URLs

When creating or editing a document, the URL field will not accept values that don't start with "http" or
"https".  The field should be changed to accept any kind of input but issue warnings if it doesn't match a pattern that is likely to be on a hard drive.

[ ] Remove restriction on input
[ ] Change "URL (Link to document or document repository)" to just "Link to document or document repository"
[ ] Give a warning if the path name seems like it may be on the local users hard drive or if it doesn't match certain criteria.  "Warning:  The file you are linking to should be on external storage.  The file path you provided looks like it might be on your local hard drive."  The following patterns should be ok:

[ ] Anything with an http or https
[ ] Anything with a drive letter > C:
[ ] Any path that might match a Unix file path (starts with a "/")
[ ] Path beginning with smb://

Updated the logic how the error messages appear

If the text starts with a http, https, smb, or ftp:

If it matches a normal web resource format, there is no error message.  If it doesn't, there is a warning of a potentially badly formatted web resource.

If the text doesn't start with one of those protocols:

The text is checked for forward and backward slashes.  If one is not found, a warning about using a file path is deplayed.  If a slash is found, a warning to use a networked path is displayed.


Add support for wake-on-motion

Add support for the chip's wake from a low-power state function.

added in 1f58aafdc8346d539c503259a8a15498b2f1c210


Annotation family ignore-taint.cluster-autoscaler.kubernetes.io/* not registered / documented

This is a Bug Report

Problem:
The cluster autoscaler uses annotations matching ignore-taint.cluster-autoscaler.kubernetes.io/*, but these are not registered in https://kubernetes.io/docs/reference/labels-annotations-taints/
Proposed Solution:
Register the annotations (not taints, annotations), by documenting them.
Page to Update:
https://kubernetes.io/docs/reference/labels-annotations-taints/
/language en
/sig autoscaling
/kind bug
/priority backlog

To learn more about these, you might need to look at the source code for the cluster autoscaler, or read its documentation, or search the web.

Also see https://github.com/kubernetes/autoscaler/issues/5251

/triage accepted

/retitle Taint family ignore-taint.cluster-autoscaler.kubernetes.io/* not registered / documented

D'oh
/retitle Annotation family ignore-taint.cluster-autoscaler.kubernetes.io/* not registered / documented
It was right the first time.


Component Governance Fixes (0.75)

This PR fixes various CG issues:

Updates ws to 7.5.10.
Updates @grpc/grpc-js to 1.9.15 by updating firebase to 11.0.1.
Updates serve-static to 1.16.2.
Updates send to 0.19.0.
Updates rexml to 3.3.9.
Updates es5-ext to 0.10.64.
Configures CG to ignore helloword.

https://github.com/microsoft/react-native-macos/pull/2253 needs to land (along with fixes to 0.75's PR pipeline) so that we don't accidentally publish 0.75.x as latest over a 0.76.x release


ConsulTxnStore: handle failure in read/get transaction

Related issue: https://github.com/openark/orchestrator/issues/1300
Description
This PR resolves a panic when the ConsulTxnStore returns a nil transaction response due to an error in the transaction
Following this PR errors in the read transaction (to check existing values) will be logged and will cause the store to perform an update of the keys in the read transaction, as we can't be sure they're consistent if there is a read transaction error
Lastly, this PR adds better unit testing for this issue. Fixes https://github.com/openark/orchestrator/issues/1300

With the exception of https://github.com/openark/orchestrator/issues/1302 (separate PR to come!) I've confirmed this fixes the majority of the issues found when testing the consulTxnStore on real-world environment
Ready for @shlomi-noach to review 🙇


Console cursor disappears

VSCode Version: 1.3.1
OS Version: Linux Fedora 22, bash shell

Steps to Reproduce:

Press Ctrl+' to open a new Terminal.
Press up arrow to show the previous command from bash history.
Observe that the flashing cursor disappears.
Start typing to append to the command line, still no cursor.

@max0x7ba I can't seem to reproduce, would you be able to use dev tools (Help > Toggle Developer Tools) to inspect the element where the cursor is and take a screenshot? There is supposed to be a span with the terminal-cursor class.

There is a span initially:

Then I press arrow-up key to bring up the latest command and the cursor disappears:

And then I click arrow-left key and the cursor reappears:

@max0x7ba does un-maximizing, horizontally resizing and then trying to reproduce again make the cursor show up?

@Tyriar Resizing the window to a smaller size and then back truncates the command prompt.

Closing as there's still no repro (and there's an intuitive work around if it does happen, ctrl+c).


Mini-issue: Make program runnable on Azure

As a TA, I want to have the program be accessible on Azure, so that I know that the group understands how to properly deploy their programs
Acceptance Criteria

Make the Azure page for the Razor website not crash

Definition of Success

Program is accessible through Razor

All the diagnostics tools are only allowed for paying users

it worked once we changed to temp


Poissible Guava depencendy conflict

Hi Jens,
i have a dependency issue and am not sure how to solve it.
Your bundle requires com.google.common.base, version >= 19 / < 20 which i have as part of Guava. Now we merged with some web console stuff that requires cxf, which requires version 18. When i have both installed, your bundle does not come up with this error:

Error starting bundle 159: Unable to resolve de.dentrassi.camel.milo.camel-milo [159](R 159.0): missing requirement [de.dentrassi.camel.milo.camel-milo [159](R 159.0)] osgi.wiring.package; (&(osgi.wiring.package=com.google.common.base)(version>=19.0.0)(!(version>=20.0.0))) Unresolved requirements: [[de.dentrassi.camel.milo.camel-milo [159](R 159.0)] osgi.wiring.package; (&(osgi.wiring.package=com.google.common.base)(version>=19.0.0)(!(version>=20.0.0)))]

I did some research and it might be guava that 18 and 19 do not get along with each other. When i uninstall guava 18, cxf does not work any longer, but this error goes away. Do you have a setup where those bundles get along with each other?
Update: I just saw camel 2.18 also comes with the guava 18 dependency in apache-camel-2.18.0-features.xml. Strange.
Karaf 4.0.5/Camel 2.18
Thanks
Gerd

Yes .. I think the issue is that guava doesn't do semantic versioning. So 18.0.0 would be incompatible from 19.0.0. OSGi follows this principle pretty strongly and so the bnd plugin probably generated imports for [19,20).
As long as there are now overlaps, it would also be possible for OSGi to run both in parallel. But this not always the case. So it can come to the issue your reported.
I guess for guava we could simply ditch the upper bound.

Do you mean the upper or lower bound? Could you run with guava 18?

I published a new version to Maven Central a few minutes ago (version 0.1.1). This should fix this issue.
It would be great if you could give it another try and let me know if this helps. Thanks!

Hi,
when adding that to the pom.xml of our project, i get this when trying to build:
[ERROR] Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.0.5:assembly (default-assembly) on project offline-karaf: Unable to build assembly: Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=de.dentrassi.camel.milo.camel-milo; type=osgi.bundle; version="[0.1.1,0.1.1]"; resolution:=mandatory [caused by: Unable to resolve de.dentrassi.camel.milo.camel-milo/0.1.1: missing requirement [de.dentrassi.camel.milo.camel-milo/0.1.1] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.apache.camel)(version>=2.17.0)(!(version>=3.0.0)))"] -> [Help 1]
This version >=2.17, !>=3.0.0 might cause problems.

It looks like you are missing camel altogether.

And that is pretty strange. We have camel, we successfully used your .kar. But when i introduce your dependency into our pom.xml like so:
        <dependency>
            <groupId>de.dentrassi.camel.milo</groupId>
            <artifactId>camel-milo</artifactId>
            <version>0.1.1</version>
        </dependency>

it breaks...

Yes, that only adds the features to the project. But you also need to add the feature camel-core. Depending in your setup it differs how to do this.
If you are running feature:install from the shell it will pull in this dependency automatically. If you are using the maven-karaf-plugin you will probably need to add this either as a dependency or in the plugin's configuration.


cell tracking dataset as the custom dataset

This project is very helpful for me I guess!!! When I clone it to my own directory and try to train my own model, I find something wrong...
I have a cell tracking dataset and convert it into coco-format, then how could I use the trackformer to train my tracking model?
When I use :
python src/train.py with
deformable
tracking
mot17
full_res
resume=models/mot17_train_deformable_private/checkpoint.pth
output_dir=models/custom_dataset_train_deformable
mot_path=data/custom_dataset
train_split=train
val_split=val
epochs=20 \
I got the FileNotFoundError: [Errno 2] No such file or directory: 'models/mot17_train_deformable_private/checkpoint.pth' error...

Did you download the pretrained model files and unpack them in the correct directory?

sorry, I forget it...
BTW, if I don't want to use these pretrained model, what should I set the parameters?

You can set the resume=False and it will not load any pretrained model files. Only the backbone will load an ImageNet petraining.


Fix missing shape color field on ODLC review.

Testing our integration with the new proto-based api, I was afraid we did something wrong when I checked the ODLC review screen and saw no shape color:

Turns out the issue was actually with the interop server.

LGTM, thanks!


stack ghci fails

Thanks for the article
Unfortunately stack ghci fails:
 $ stack ghci
has-type-class-pattern-<IP_ADDRESS>: initial-build-steps (lib)
Configuring GHCi with the following packages: has-type-class-pattern
GHCi, version 8.0.2: http://www.haskell.org/ghc/  :? for help
Loaded GHCi configuration from /home/palik/.ghc/ghci.conf
Loaded GHCi configuration from /home/palik/.ghci
[1 of 4] Compiling Uniplate         ( /opt/haskell/devel/has-type-class-pattern/src/Uniplate.hs, interpreted )
[2 of 4] Compiling Types            ( /opt/haskell/devel/has-type-class-pattern/src/Types.hs, interpreted )
[3 of 4] Compiling TraverseImages   ( /opt/haskell/devel/has-type-class-pattern/src/TraverseImages.hs, interpreted )

/opt/haskell/devel/has-type-class-pattern/src/TraverseImages.hs:37:12: warning: [-Wname-shadowing]
    This binding for ‘head’ shadows the existing binding
      imported from ‘Prelude’ at /opt/haskell/devel/has-type-class-pattern/src/TraverseImages.hs:2:8-21
      (and originally defined in ‘GHC.List’)

<no location info>: error:
Failing due to -Werror.
Failed, modules loaded: Types, Uniplate.

<no location info>: error:
    Could not find module ‘CollectImages’
    It is not a module in the current program, or in any known package.
Loaded GHCi configuration from /tmp/ghci14916/ghci-script

fixed
---
 src/CollectImages.hs  | 1 +
 src/TraverseImages.hs | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/CollectImages.hs b/src/CollectImages.hs
index 3382bd8..6c5c970 100644
--- a/src/CollectImages.hs
+++ b/src/CollectImages.hs
@@ -4,6 +4,7 @@ import Types
 import Data.Set (Set, fromList, singleton)
 import Data.Text (Text)
 import Data.Monoid
+import Prelude hiding (head)

 collectImages :: Scene -> Set Text
 collectImages Scene {..}
diff --git a/src/TraverseImages.hs b/src/TraverseImages.hs
index 3e34bd8..99e6c5d 100644
--- a/src/TraverseImages.hs
+++ b/src/TraverseImages.hs
@@ -10,6 +10,7 @@ import Data.Data
 import Data.Text (Text)
 import qualified Data.Text as T
 import Data.Set
+import Prelude hiding (head)

 class HasImages a where
   images :: Traversal' a Text
--


Cleanup unneeded files

Spotted these while I was looking at how the crushinator works.

Hmm, build failure on bundle install: "Could not find rb-fsevent-0.10.1 in any of the sources"


Bindable attributes may lose values set during bind()

@jdanyow this commit has caused an intermittent behavior.
Given this custom element:
export class MyElement{
    @bindable attribute1;
    @bindable attribute2;
    bind(){
        if(!this.attribute1){
            this.attribute1 = this.attribute2;
        }
    }
}

Used like this:
<my-element attribute2="foo"> <!-- leave attribute1 unset -->

If there are more than 100 bindings in the page (minimumImmediate) then the binding connection is differed. When it is later connected, it overwrites the value assigned to attribute1 during bind() with undefined.

I patched my aurelia.js this way in the mean time:
Binding.prototype.bind = function bind(source) {
  ...
  if (mode === bindingMode.oneWay) {

    // PATCH
    // enqueueBindingConnect(this);
    sourceExpression.connect(this, source);
  } else if (mode === bindingMode.twoWay) {
    sourceExpression.connect(this, source);
    this.targetObserver.subscribe(targetContext, this);
  }
  ...

@sylvain-hamel why is there a binding instance being connected to the attribute1 property?

@jdanyow I'm sorry I made a mistake when I wrote the markup in my original post. In my real case, attribute1 is always set but does not always have a value. The markup would be closer to this:
<my-element attribute2="ob1.foo" attribute1="obj1.bar"> <!-- bar's value is undefined -->

If you can't reproduce it from this, I can write a test case. I wanted to submit this issue  with a  Plunkr but I could not find an up-to-date plunkr to fork.

attribute1 is bound to the obj.bar expression.  This means the binding system is responsible for keeping them attribute1 in sync with obj.bar.  By manually assigning attribute1 you are interfering with this logic. Use a one-time or two-way binding and things will work as you expect.  You could also set the default binding mode for this attribute1 to make this a little easier.


wget2: init at 1.99.2

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 113079 run on x86_64-linux 1

19 packages built:

gnu-pw-mgr
gnulib
grub2 (grub2_light)
grub2_efi
grub2_pvgrub_image
grub2_xen
lbzip2
libhsts
lua51Packages.lrexlib-gnu
lua52Packages.lrexlib-gnu
lua53Packages.lrexlib-gnu
luajitPackages.lrexlib-gnu
os-prober
safeeyes
super-productivity
surf-display
wget2
winusb (woeusb)
xprintidle-ng

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

gnulib:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/tools/gnulib/default.nix:29:3:
   |
29 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/tools/gnulib/default.nix:19:3:
   |
19 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

grub2_efi:

A likely typo in grubTarget argument was found, did you mean distTarget?
Near pkgs/tools/misc/grub/2.0x.nix:99:3:
   |
99 |   grubTarget = if efiSupport
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/tools/misc/grub/2.0x.nix:113:3:
    |
113 |   meta = with lib; {
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
libtool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/tools/misc/grub/2.0x.nix:57:3:
   |
57 |   buildInputs = [ ncurses libusb-compat-0_1 freetype gettext lvm2 fuse libtool ]
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/misc/grub/2.0x.nix:53:5:
   |
53 |     ./fix-bash-completion.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

grub2:

A likely typo in grubTarget argument was found, did you mean distTarget?
Near pkgs/tools/misc/grub/2.0x.nix:99:3:
   |
99 |   grubTarget = if efiSupport
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/tools/misc/grub/2.0x.nix:113:3:
    |
113 |   meta = with lib; {
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
libtool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/tools/misc/grub/2.0x.nix:57:3:
   |
57 |   buildInputs = [ ncurses libusb-compat-0_1 freetype gettext lvm2 fuse libtool ]
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/misc/grub/2.0x.nix:53:5:
   |
53 |     ./fix-bash-completion.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

grub2_pvgrub_image:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/tools/misc/grub/pvgrub_image/default.nix:32:3:
   |
32 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/tools/misc/grub/pvgrub_image/default.nix:32:3:
   |
32 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

grub2_xen:

A likely typo in grubTarget argument was found, did you mean distTarget?
Near pkgs/tools/misc/grub/2.0x.nix:99:3:
   |
99 |   grubTarget = if efiSupport
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/tools/misc/grub/2.0x.nix:113:3:
    |
113 |   meta = with lib; {
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
libtool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/tools/misc/grub/2.0x.nix:57:3:
   |
57 |   buildInputs = [ ncurses libusb-compat-0_1 freetype gettext lvm2 fuse libtool ]
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/misc/grub/2.0x.nix:53:5:
   |
53 |     ./fix-bash-completion.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

lbzip2:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/tools/compression/lbzip2/default.nix:24:5:
   |
24 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
perl is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/tools/compression/lbzip2/default.nix:14:3:
   |
14 |   buildInputs = [ gnulib perl ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

lua51Packages.lrexlib-gnu:

URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:699:14:
    |
699 |     url    = mirror://luarocks/lua-resty-http-0.15-0.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:716:14:
    |
716 |     url    = mirror://luarocks/lua-resty-jwt-0.2.2-0.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:733:14:
    |
733 |     url    = mirror://luarocks/lua-resty-openidc-1.7.2-1.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:750:14:
    |
750 |     url    = mirror://luarocks/lua-resty-session-3.6-1.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:1484:14:
     |
1484 |     url    = mirror://luarocks/readline-2.6-0.src.rock;
     |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
Unused argument: pkgs.
Near pkgs/development/lua-modules/generated-packages.nix:8:34:
  |
8 | { self, lib, fetchurl, fetchgit, pkgs, ... } @ args:
  |                                  ^

lua52Packages.lrexlib-gnu:

URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:699:14:
    |
699 |     url    = mirror://luarocks/lua-resty-http-0.15-0.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:716:14:
    |
716 |     url    = mirror://luarocks/lua-resty-jwt-0.2.2-0.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:733:14:
    |
733 |     url    = mirror://luarocks/lua-resty-openidc-1.7.2-1.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:750:14:
    |
750 |     url    = mirror://luarocks/lua-resty-session-3.6-1.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:1484:14:
     |
1484 |     url    = mirror://luarocks/readline-2.6-0.src.rock;
     |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
Unused argument: pkgs.
Near pkgs/development/lua-modules/generated-packages.nix:8:34:
  |
8 | { self, lib, fetchurl, fetchgit, pkgs, ... } @ args:
  |                                  ^

lua53Packages.lrexlib-gnu:

URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:699:14:
    |
699 |     url    = mirror://luarocks/lua-resty-http-0.15-0.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:716:14:
    |
716 |     url    = mirror://luarocks/lua-resty-jwt-0.2.2-0.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:733:14:
    |
733 |     url    = mirror://luarocks/lua-resty-openidc-1.7.2-1.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:750:14:
    |
750 |     url    = mirror://luarocks/lua-resty-session-3.6-1.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:1484:14:
     |
1484 |     url    = mirror://luarocks/readline-2.6-0.src.rock;
     |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
Unused argument: pkgs.
Near pkgs/development/lua-modules/generated-packages.nix:8:34:
  |
8 | { self, lib, fetchurl, fetchgit, pkgs, ... } @ args:
  |                                  ^

luajitPackages.lrexlib-gnu:

URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:699:14:
    |
699 |     url    = mirror://luarocks/lua-resty-http-0.15-0.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:716:14:
    |
716 |     url    = mirror://luarocks/lua-resty-jwt-0.2.2-0.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:733:14:
    |
733 |     url    = mirror://luarocks/lua-resty-openidc-1.7.2-1.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:750:14:
    |
750 |     url    = mirror://luarocks/lua-resty-session-3.6-1.src.rock;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
URI literals are deprecated.
Near pkgs/development/lua-modules/generated-packages.nix:1484:14:
     |
1484 |     url    = mirror://luarocks/readline-2.6-0.src.rock;
     |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md
Unused argument: pkgs.
Near pkgs/development/lua-modules/generated-packages.nix:8:34:
  |
8 | { self, lib, fetchurl, fetchgit, pkgs, ... } @ args:
  |                                  ^

os-prober:

Please consider this feature to be alpha.

Near pkgs/tools/misc/os-prober/default.nix:24:3:
   |
24 |   buildInputs = [ makeWrapper ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/misc/os-prober/default.nix:25:3:
   |
25 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

surf-display:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/surf-display/default.nix:54:5:
   |
54 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/surf-display/default.nix:29:15:
   |
29 |   patches = [ ./pdf-makefile.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

wget2:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/networking/wget2/default.nix:41:5:
   |
41 |     (fetchpatch {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/networking/wget2/default.nix:46:5:
   |
46 |     (fetchpatch {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

winusb:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/tools/misc/woeusb/default.nix:56:5:
   |
56 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/misc/woeusb/default.nix:16:15:
   |
16 |   patches = [ ./remove-workaround.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

xprintidle-ng:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/tools/X11/xprintidle-ng/default.nix:40:5:
   |
40 |     license = lib.licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
configurePhase should probably contain runHook preConfigure and runHook postConfigure.
Near pkgs/tools/X11/xprintidle-ng/default.nix:27:3:
   |
27 |   configurePhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

@ofborg eval


Feature request:  Determine platform and architecture from the github runner.

This is a Github Action.  Even if there actually is an application, in which a release is preferred for a platform or architecture different to the one the code itself is running on, that should not be the default.

I should've read the docs sorry.  The code tries to do this already.
It's even case insensitive
https://github.com/jaxxstorm/action-install-gh-release/blob/2fba7e5bd9dcf38d6ab500fa0f8c0b0e46884336/src/main.ts#L179
It looks like a fantastic actions - well done guys.  Unfortunately I've no idea why I can't get it to find the binary I'm after.


Docker Health Check Support

I'd like to be able to implement an automated Docker health check on Izzy's container for automated restarts should a fault state ever occur, such as encountering a gateway disconnect and not attempting to reconnect, like has occurred once before.
Docker needs a command that it can run against the container that will return a status code of 0 if the container's service is healthy.
The example they give in the dockerfile reference is
CMD curl -f http://localhost/ || exit 1
Basically, see if application is responding, else exit with status 1, telling Docker the service is dead and the container needs restarted.
The command used for the health check can be anything that can be executed in the container and return the correct exits codes (0 for success and 1 for unhealthy).
ASP.NET has a health check capability that exposes an http endpoint that Docker can curl inside the container to see if the application is alive or not.
Relevant microsoft docs:
https://learn.microsoft.com/en-us/aspnet/core/host-and-deploy/health-checks?view=aspnetcore-7.0
https://learn.microsoft.com/en-us/dotnet/architecture/microservices/implement-resilient-applications/monitor-app-health
From Discord messages:

https://learn.microsoft.com/en-us/aspnet/core/host-and-deploy/health-checks?view=aspnetcore-7.0#create-health-checks
Izzy's connection disconnected, and never reconnected, but the app was still running.

Health checks are created by implementing the IHealthCheck interface. The CheckHealthAsync method returns a HealthCheckResult that indicates the health as Healthy, Degraded, or Unhealthy. The result is written as a plaintext response with a configurable status code.
The health check's logic is placed in the CheckHealthAsync method. The preceding example sets a dummy variable, isHealthy, to true. If the value of isHealthy is set to false, the HealthCheckRegistration.FailureStatus status is returned.

izzy is already monitoring connection status to write connected / disconnected console messages
write that status to a variable and have the health check logic aync method monitor it?
if connected, return Healthy on the endpoint, if disconnected, return Degraded or Unhealthy on the endpoint
Docker can check the endpoint once every say, 5 minutes (since a normal gateway reconnect event usually only takes a few seconds), and if it sees anything other than Healthy, it knows to kill and restart Izzy.

After trying and failing to follow the above instructions, my current impression is that none of this is available to us because we are not an ASP.NET app. If there's a way around that it's beyond me.


Small typo in README.

Type of changes

[ ] Bug fix
[ ] New feature
[x] Documentation / docstrings
[ ] Tests
[ ] Other

Checklist

[ ] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[ ] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
Typo fix in README.

Thanks.


Better control over visibility of prelude elements

This is a feature request.
Currently, if I understand correctly, the code in prelude.ml is visible to the student, whereas the code in prepare.ml is not. Furthermore, prepare.ml can refer to (unqualified) names defined in prelude.ml, but not the other way around. This is too inflexible; for instance, I have an example where I need a type definition to be in prelude.ml (because the rest of the prelude depends on it) yet I would like it to be invisible (because I want the student to view this type as abstract).
Could we have finer-grained control over visibility? E.g., elements in prelude.ml could optionally be marked [@invisible]. (Perhaps, for the sake of symmetry, elements in prepare.ml could be marked<EMAIL_ADDRESS>

My current solution is to move everything into prepare.ml (so prelude.ml is empty) and explicitly copy the definitions that the student must know about into the exercise description in descr.md.

I think the issue fixed by #254 was #168, not this one.

@yurug I think @adhameer is right, could you reopen this ?


Re-structure submodules for vector, raster

The submodule names are inconsistent with the common geospatial scheme of "raster" and "vector" (which are unfortunately inconsistent with the common ML/CV nomenclature of "image" and "label"). Going to re-name them to rasterimage and vectorlabel, and create sub-modules beneath them for a lot of the functionality. The current "label" module is getting unwieldy and I still haven't added in road network/graph support.

Resolved with #9


Texture transparency is broken

So, in my game engine I heavily rely on JavaFX and I consider your OpenGLFX library as the only solution for the Windows 10 bug that makes JavaFX completely unsusable. I'm commited to reach production quality of your library hopefully with your help :) Here is another bug report - you can reproduce it by trying my pull request (specifically this commit)
Basically what's intended to be transparent is not.

not a bug because https://github.com/dmitrykolesnikovich/openglfx/commit/bc6e4a951e7cc9978e8c1c95fe35d0f79c0977f5


Settle import of categories

Either automatically detect categories with the same label, or provide a button to delete all categories at once.

Fixed by https://github.com/bnjbvr/kresus/commit/40bcfbbac15864ceb012f6f2166ede8fa9c502b6


Update shell extension

Description

Breaking down monolithic index.tsx file to dedicated components, helpers and custom hooks.
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

If I enter a command as the argument, it doesn't run anymore; it only shows the history - can you look into that?


[AST] Implement HLL_COUNT Function in AST

Description
Add HLL_COUNT function in AST
select count(i), hll_count(i) from sequence;

hll_count function is approximate aggregate function. Approximate aggregation typically requires less memory than exact aggregation functions, but also introduces statistical error.
Using HyperLogLog++ , Get Cardinality.
https://research.google/pubs/pub40671/
Test
test_case!(hll_count, async move {

    test!(
        r#"select hll_count([0, 1, 1, 2, 3, 5]) as hll from Approx;"#,
        Ok(select!(
            column1
            I64;
            5
        ))
    );

});

Refrence
https://cloud.google.com/bigquery/docs/reference/standard-sql/hll_functions
https://redis.io/commands/pfcount/
http://antirez.com/news/75
https://research.google/pubs/pub40671/
http://www.dmtcs.org/dmtcs-ojs/index.php/proceedings/article/view/dmAH0110
http://highscalability.com/blog/2012/4/5/big-data-counting-how-to-count-a-billion-distinct-objects-us.html
http://highlyscalable.wordpress.com/2012/05/01/probabilistic-structures-web-analytics-data-mining/
https://github.com/addthis/stream-lib/
http://en.wikipedia.org/wiki/Iterated_logarithm

Hyperloglog is used for count distinct (which we've proposed to include in #970).
I suggest that COUNT(DISTINCT col) becomes then UNIQUE(col, hll, P) with P as the precision of hll. This API would also be more welcoming to other count distinct algorithms in the future, such as probability counting or theta sketch.
There should be a default to "exact" though, so UNIQUE(col) should be translated to COUNT(DISTINCT col)) as hyperloglog and others are only used by people with very large, high cardinality datasets, which is probably not the case for most users of GlueSQL.
Is it ok if we merge this with #970 and include HLL as another count distinct algorithm?

I think the way you said it would be better for usability than this Issue. Thank you for the comments


do you support googles objectrons data format?

hey
i went through this repo https://github.com/google-research-datasets/Objectron looks interesting, do you support 3d object detection in 2d image?

There are currently no plans to support the dataset.

hey
i went through this repo https://github.com/google-research-datasets/Objectron looks interesting, do you support 3d object detection in 2d image?

Please refer to mmdetection3d


v1.0: Push GA by 2 days

… in order to reflect the holidays in some countries

@rthallisey @aburdenthehand wdyt?

I am ambivalent. I would prefer not to move the release date if we can help it. But if we need people for the release who would otherwise be on holiday then this makes perfect sense.

Let's discuss more on Wednesday

I believe the Czech Republic also has public holidays on 5th and 6th, and it seems some of our US folks will be out for much of that week. In light of this, I think pushing it a week (July 11th) is better than two days.

5th or 6th is fine, i'll be available then to cut the release at least.


Adjust interviwer note text

What is the context of this PR?
Adjusting the case on Interviewer Note: to be Interviewer note:
How to review
Check that interviewer notes are being displayed with Interviewer note:
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 (I) CCS- Mop up changes 2 (XS)


Fix RandomSchemaGenerator.new always returning equivalent generators

RandomSchemaGenerator.new relies on Kernel#rand to generate a seed if
none is given. However, the values returned are in the range 0...1,
which get rounded to 0 by Random.new, effectively becoming a fixed
constant.
Replace Kernel#rand with Random.new_seed.

@thomasleese you mean like this? Feels a bit weird to have the version added there before the bump.
https://github.com/alphagov/govuk_schemas/pull/60/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1e

In this case it doesn't really matter because we're going to release immediately afterwards, but usually what we would do is include the entry in the changelog under a ## Unreleased heading, and then in the version bump PR we change that to the version. (It means other people can raise PRs and we don't need to decide on the version until the release).


Wip dom0 xt gen3 gen4

Thank you for the PR. I really love the approach, but there are some kinks that need to be ironed out.
I understand that you are assigned to another project, so maybe you can handover this PR to someone else?

I still have a 20% allocation for the appropriate project, so fixing issues in this PR is possible for me.

One more thing I fill confused about - binaries added, but no information where they are taken from? where is the sources? May be good time to start filling README.rst here

Additional 5c : may be good to follow https://xenbits.xen.org/docs/unstable/designs/launch/hyperlaunch-devicetree.html as max as possible?

Additional 5c : may be good to follow https://xenbits.xen.org/docs/unstable/designs/launch/hyperlaunch-devicetree.html as max as possible?

Some configuration names can be aligned with Hyperlaunch (actually, only a few of them); the rest I leave as is.

One more thing I fill confused about - binaries added, but no information where they are taken from? where is the sources? May be good time to start filling README.rst here

I'll add information to commit message but my task always was "run prod-devel domU(s) on Zephyr Dom0", so from that it is easy to understand where I got binaries

One more thing I fill confused about - binaries added, but no information where they are taken from? where is the sources? May be good time to start filling README.rst here

I'll add information to commit message but my task always was "run prod-devel domU(s) on Zephyr Dom0", so from that it is easy to understand where I got binaries

This project is public, right? Assume I'm not from xen-troops team - what is "prod-devel domU(s)"? ;)
Also in my opinion, having binaries in repo is usually not exactly a good idea,  better to just provide link to pre-built binaries (if exist) or source repo (meta).

One more thing I fill confused about - binaries added, but no information where they are taken from? where is the sources? May be good time to start filling README.rst here

I'll add information to commit message but my task always was "run prod-devel domU(s) on Zephyr Dom0", so from that it is easy to understand where I got binaries

This project is public, right? Assume I'm not from xen-troops team - what is "prod-devel domU(s)"? ;)
Also in my opinion, having binaries in repo is usually not exactly a good idea, better to just provide link to pre-built binaries (if exist) or source repo (meta).

I've just used that approach as we used by our before (you can traverse through history not only in this repository but also in the Zephyr AOS repository, and it will be easy to find out that this is a common approach) for quicker testing and checking changes, consolidating everything in one repository. However, in the future, we'll need to use CONFIG_DOM[UD]... to obtain the correct device tree blobs and binaries.
Note: This isn't a release version yet, so I think it's normal to include prebuilt binaries here. Therefore, it's understandable that for now, people outside our team might not understand where these binaries came from.
We have a lot to accomplish in this repository, and my pull request represents only the initial steps that our team has taken to run DomUs on real hardware.


IndexError: RangeError (index): Index out of range: no indices are valid: 0

Steps to Reproduce

...After installing flutter by git clone while flutter doctor is typed in flutter_console.bat then it shows error and says flutter has exited unexpectedly.
...
...

Logs

Flutter crash report; please file at https://github.com/flutter/flutter/issues.
command
flutter doctor
exception
IndexError: RangeError (index): Index out of range: no indices are valid: 0
#0      _Uint8ArrayView.[] (dart:typed_data-patch/typed_data_patch.dart:3932:7)
#1      InputStream.readUint16 (package:archive/src/util/input_stream.dart:206:22)
#2      GZipDecoder._readHeader (package:archive/src/gzip_decoder.dart:89:29)
#3      GZipDecoder.decodeBuffer (package:archive/src/gzip_decoder.dart:26:5)
#4      GZipDecoder.decodeBytes (package:archive/src/gzip_decoder.dart:17:12)
#5      _WindowsUtils.verifyGzip (package:flutter_tools/src/base/os.dart:352:21)
#6      CachedArtifact._downloadArchive.<anonymous closure> (package:flutter_tools/src/cache.dart:605:20)
#7      CachedArtifact._withDownloadFile (package:flutter_tools/src/cache.dart:638:26)
#8      CachedArtifact._downloadArchive (package:flutter_tools/src/cache.dart:604:12)
#9      CachedArtifact._downloadZippedTarball (package:flutter_tools/src/cache.dart:630:12)
#10     GradleWrapper.updateInner (package:flutter_tools/src/cache.dart:1070:12)
#11     CachedArtifact.update (package:flutter_tools/src/cache.dart:560:11)
#12     Cache.updateAll (package:flutter_tools/src/cache.dart:432:24)
#13     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:698:27)
#14     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:620:33)
<asynchronous suspension>
#15     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart)
#16     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#17     _rootRun (dart:async/zone.dart:1184:13)
#18     _CustomZone.run (dart:async/zone.dart:1077:19)
#19     _runZoned (dart:async/zone.dart:1619:10)
#20     runZoned (dart:async/zone.dart:1539:10)
#21     AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#22     FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:610:20)
#23     CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#24     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:339:21)
<asynchronous suspension>
#25     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart)
#26     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#27     _rootRun (dart:async/zone.dart:1184:13)
#28     _CustomZone.run (dart:async/zone.dart:1077:19)
#29     _runZoned (dart:async/zone.dart:1619:10)
#30     runZoned (dart:async/zone.dart:1539:10)
#31     AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#32     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:288:19)
#33     CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:112:25)
#34     new Future.sync (dart:async/future.dart:224:31)
#35     CommandRunner.run (package:args/command_runner.dart:112:14)
#36     FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:231:18)
#37     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:63:22)
#38     _rootRun (dart:async/zone.dart:1184:13)
#39     _CustomZone.run (dart:async/zone.dart:1077:19)
#40     _runZoned (dart:async/zone.dart:1619:10)
#41     runZonedGuarded (dart:async/zone.dart:1608:12)
#42     runZoned (dart:async/zone.dart:1536:12)
#43     run.<anonymous closure> (package:flutter_tools/runner.dart:61:18)
<asynchronous suspension>
#44     run.<anonymous closure> (package:flutter_tools/runner.dart)
#45     runInContext.runnerWrapper (package:flutter_tools/src/context_runner.dart:64:18)
<asynchronous suspension>
#46     runInContext.runnerWrapper (package:flutter_tools/src/context_runner.dart)
#47     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#48     _rootRun (dart:async/zone.dart:1184:13)
#49     _CustomZone.run (dart:async/zone.dart:1077:19)
#50     _runZoned (dart:async/zone.dart:1619:10)
#51     runZoned (dart:async/zone.dart:1539:10)
#52     AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#53     runInContext (package:flutter_tools/src/context_runner.dart:67:24)
#54     run (package:flutter_tools/runner.dart:48:10)
#55     main (package:flutter_tools/executable.dart:69:9)
#56     main (file:///C:/src/flutter/packages/flutter_tools/bin/flutter_tools.dart:8:3)
#57     _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:299:32)
#58     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)

flutter doctor
[✓] Flutter (Channel stable, v1.17.3, on Microsoft Windows [Version 10.0.17134.1], locale en-US)
    • Flutter version 1.17.3 at C:\src\flutter
    • Framework revision b041144f83 (5 days ago), 2020-06-04 09:26:11 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\syeed.shovon\AppData\Local\Android\sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    ✗ Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[!] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[!] Connected device
    ! No devices available

! Doctor found issues in 3 categories.

flutter_01.log

Oops; flutter has exited unexpectedly: "RangeError (index): Index out of range: no indices are valid: 0".
A crash report has been written to C:\Users\syeed.shovon\flutter_03.log.
This crash may already be reported. Check GitHub for similar crashes.
https://git.io/JeyYe
To report your crash to the Flutter team, first read the guide to filing a bug.
https://flutter.dev/docs/resources/bug-reports
Create a new GitHub issue by pasting this link into your browser and completing the issue template. Thank you!
https://git.io/JfyRZ

duplicate of https://github.com/flutter/flutter/issues/48014

Thanks for checking this out. But what is the solution?? plz help


Security policy document for NSM repos.

Signed-off-by: Szilard Vincze<EMAIL_ADDRESS>

@edwarnicke, @denis-tingaikin: The security email seems to be working fine, so I send this PR to have the security policy in place.

@szvincze Can we also add it to the site?
https://github.com/networkservicemesh/site
I suspect we can open a quick PR and give it to @edwarnicke on review


Add create array task

Added

Added CreateArrayTask.
Added BaseServiceTaskKind.

Changed

Updated TaskKindType with createArray.
Updated CreateInstanceTaskKind and GetServiceDependenciesTaskKind to extend BaseServiceTaskKind.

Codecov Report

Merging #103 (e0af7b1) into master (831e26e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   95.54%   95.56%   +0.02%
==========================================
  Files          89       90       +1
  Lines        1413     1421       +8
  Branches      164      166       +2
==========================================
+ Hits         1350     1358       +8
  Misses         60       60
  Partials        3        3

Flag
Coverage Δ

cuaktask
92.72% <ø> (ø)

iocuak
94.41% <100.00%> (+0.05%)
:arrow_up:

porygon
98.58% <ø> (ø)

porygon-typeorm
98.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...iocuak/src/task/models/cuaktask/CreateArrayTask.ts
100.00% <100.00%> (ø)

...ages/iocuak/src/task/models/domain/TaskKindType.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f30132...e0af7b1. Read the comment docs.


LocationSync: Syncup with Metro plugin changes

IGeography implementation restructuring
Warning removed and alignment against coding standard
Check add for location/internet before usage to avoid crash

Closing this, since added new one agains latest sprint: https://github.com/rdkcentral/rdkservices/pull/2229


Extension causes high cpu load

Issue Type: Performance
Extension Name: python
Extension Version: 2019.10.41019
OS Version: Darwin x64 18.7.0
VSCode version: 1.38.1

:warning: Make sure to attach this file from your home-directory:
:warning:/Users/lning/ms-python.python-unresponsive.cpuprofile.txt
Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

Unfortunately you didn't seem to include /Users/lning/ms-python.python-unresponsive.cpuprofile.txt as required for us to look at the issue. Please attach the file and then we can reopen this issue.


Fix #96 by enabling table name aliasing

This is a really major refactoring of RelationBase/Relation class to enable using table name alias. At the same time the current API is not changed.
This is just an initial PR for reviewing.
Enables defining tableAlias model property.
var Shop = Model.extend({
  tableName: 'organization_units',
  tableAlias: 'shops',
  initialize: function() {
    Model.constructor.apply(this, arguments);
    this.attributes.type_id = this.attributes.type_id || 123
  }
});

Shop.fetch();

This would execute following SQL
select `shops`.* from `organization_units` `shops` where `shops`.`type_id` = 123

instead of
select `organization_units`.* from `organization_units` where `organization_units`.`type_id` = 123

:exclamation: Tests need to be written :exclamation:
Solves #96

@vellotis Are you interested in adding tests to this PR?

Closing this since there were many changes to Bookshelf and Knex since this PR was written and the conflicts are hard to fix properly. Also, I tried as much as possible to adapt the code into the current codebase but the original issue this was supposed to fix wasn't fixed.
However I know have a new test case that can be used to check for the last remaining issue mentioned in one of the comments of #96.


How to force a network to stop moving after some times

Hi
For most networks the physics works and they stabilize (stop moving) quickly.
Nevertheless some networks never stop moving.
E.g. https://www.metanetx.org/chem_info/MNXM729615
How to force a network to stop moving?
I use vis-network version 8.2.1

Hi @smoretti
Unfortunately the physics sometimes gets stuck in chaotic movement and never stops. You can interrupt it with network.stopSimulation(), which technically speaking would be exactly the answer you asked for, however it will most likely restart chaotic movement as soon as you do anything with the network, which is unlikely to be what you want.
If you don't need physics enabled, you can disable it and use network.stabilize(number) where number is the number of iterations it will do and then it will stop regardless of the state of the network.
If you want to keep physics enabled, you can try playing with Force Atlas 2, it is less likely to end up moving forever than the default Barnes Hut in my experience.

I tried the forceAtlas2Based solver but for me on large networks the colors I put on nodes, as well as the text, disappear. The network stops moving very quickly.
So I tried with network.stabilize(10) and/or physics: { stabilization: { iterations: 10 } } with the barnesHut solver but the network does not stop moving.

Hi @smoretti,
I suggested to disable physics (physics: { enabled: false }) and run network.stabilize(10) manually as a possible solution, running with the physics enabled has little chance of stopping the movement.
Regarding the colors and text disappearing, could you open a new issue for this, elaborate a bit more and provide an MWE (edit JSFiddle or so), please?
Thanks.

Thanks it works with physics: { enabled: false }
I have opened another issue for the colors and text disappearing #1111