Insufficient logging

Downloaded 1.7.1 from Github for Windows 7 - it's a single .exe
When I downloading something, for a fraction of a second at the bottom of the screen it says "Downloading CLI" or something to that effect.
But really it doesn't download anything (I guess my firewall, but that's a me problem). So I end up with a youtube-dl.exe file that has 0 bytes. I can fix this myself.
The bug is that none of this downloading or failing to download is in the log file at all. It should be. Similar to the other bug I reported, you should always log errors!

why are you on Windows 7? Anyways I tested this on a VM with Windows 7 and I didn't have any issues with firewall turned off. I don't recommend using Windows 7 and especially without a firewall since its obsolete but you didn't mention if you were using a third party firewall of windows built in. have you tried downloading it manually to try running it again?


Remove deployStrategy kustomization

/test install-yamls-deploy
error: timed out waiting for the condition on openstackcontrolplanes/openstack-galera

Seeing this error in the Data Plane operator logs:
{"level":"error","ts":"2023-09-22T07:15:46Z","msg":"Reconciler error","controller":"openstackdataplanenodeset","controllerGroup":"dataplane.openstack.org","controllerKind":"OpenStackDataPlaneNodeSet","OpenStackDataPlaneNodeSet":{"name":"openstack-edpm-ipam","namespace":"openstack"},"namespace":"openstack","name":"openstack-edpm-ipam","reconcileID":"45f84eac-2fd3-40c1-9c53-eb590cc4022c","error":"openstackdataplanenodesets.dataplane.openstack.org \"openstack-edpm-ipam\" is forbidden: User \"system:serviceaccount:openstack-operators:dataplane-operator-controller-manager\" cannot patch resource \"openstackdataplanenodesets/status\" in API group \"dataplane.openstack.org\" in the namespace \"openstack\""

https://review.rdoproject.org/zuul/build/6d7728d7adbe4e85b2324e67b5f286a7/log/ci-framework-data/artifacts/must-gather.local.2359472218303190313/quay-io-openstack-k8s-operators-openstack-must-gather-sha256-070a98749455b097c66a1a25ff827a3c0ee7385f1f0c8bf54f5b15438501f2bd/namespaces/openstack-operators/pods/dataplane-operator-controller-manager-7579b4dd5d-fp8zp/logs/dataplane-operator-controller-manager-7579b4dd5d-fp8zp.log#589

Seeing this error in the Data Plane operator logs:

There are are tons for errors.. But mostly to me it's down to resource constraints. Not related to the PR though. I suspect there is too much overcommit of resources with vex and that's resulting in all these weird failures.
https://logserver.rdoproject.org/46/546/4e9446484708261aa42a1b90a05ef05639e6e36b/github-check/install-yamls-crc-podified-edpm-baremetal/6d7728d/ci-framework-data/logs/crc/pods/openstack-operators_dataplane-operator-controller-manager-7579b4dd5d-fp8zp_ba70cf2d-604a-40f2-bb67-d193e6da657d/manager/1.log
Controller","controller":"openstackdataplanedeployment","controllerGroup":"dataplane.openstack.org","controllerKind":"OpenStackDataPlaneDeployment"}
2023-09-22T06:59:00.031191060+00:00 stderr F {"level":"info","ts":"2023-09-22T06:59:00Z","logger":"controllers.OpenStackDataPlaneNodeSet","msg":"Reconcile request for: [openstack/openstack-edpm-ipam]"}
2023-09-22T06:59:01.339764194+00:00 stderr F 2023/09/22 06:59:01 http: TLS handshake error from <IP_ADDRESS>:53154: EOF
2023-09-22T06:59:02.047450768+00:00 stderr F I0922 06:59:02.043065       1 trace.go:236] Trace[2014863386]: "DeltaFIFO Pop Process" ID:openshift-marketplace/certified-operators-dockercfg-hz7fl,Depth:169,Reason:slow event handlers blocking the queue (22-Sep-2023 06:59:01.941) (total time: 101ms):
2023-09-22T06:59:02.047450768+00:00 stderr F Trace[2014863386]: [101.885136ms] [101.885136ms] END

/test install-yamls-deploy

Same install-yamls-deploy problem here as in #545:
Warning  Failed          23m (x3 over 24m)     kubelet            Failed to pull image "quay.io/infrawatch/sg-core@sha256:f277dbed6ec445a3b4707b8d3dd71d871feebb8e92ec9995d49e003c6069931d": rpc error: code = Unknown desc = reading manifest sha256:f277dbed6ec445a3b4707b8d3dd71d871feebb8e92ec9995d49e003c6069931d in quay.io/infrawatch/sg-core: manifest unknown: manifest unknown

/test install-yamls-deploy

recheck

recheck

recheck


make TTAudioObject.cpp more DRY

there are a lot of unit conversion methods within TTAudioObject.cpp.
Since we have our dataspace code for unit conversions, we should not repeat ourselves here and make this file more DRY.
see more on the original redmine issue http://redmine.jamoma.org/issues/786

This is invalid.  The versions in TTAudioObject are there for high performance inlining.  The versions in the dataspace for maximum flexibility and configurability, thus serving an entirely different purpose -- and requiring that the two be written differently.


Wrongly Deleting Sites

On the Goolge Authenticator iPhone app, I tried to delete my login for one site (let's say Facebook) and it initially didn't disappear. So I tried to delete it again, after which not only had that login disappeared but also another login for another site (let's say Amazon) was gone too. This got me locked out of Amazon.
I know there's no way to prove this but I promise I didn't accidentally delete the Amazon login the second time. The fact that it then disappeared makes me think that somehow the id's of the different logins are getting reassigned after a login is deleted, which (in a case like this where for some reason there was a delay in the first login being removed from my screen) made it possible for me to delete a login named "Facebook" and cause my Amazon login to disappear instead.
It goes without saying but given the nature of GA this seems like a critical bug -- it could (and did) get me completely locked out of a service I was using (Amazon) because I was suddenly left without the 2FA code I needed to log in.

This is for the current app store version of Authenticator, right? Do you know of any way to reliably reproduce this bug? Unfortunately, there's not much anybody can do to investigate or fix this unless the bug is reproducible.

Does this work?
Steps to reproduce:

Use GA on iPhone
Have multiple logins listed (let's say Google, Amazon, Facebook)
Delete the last login (Facebook)
Before the app has fully refreshed/updated and removed the Facebook login from your screen, delete the same login again
After app has processed this, instead of just deleting the Facebook login (and throwing an error the second time around), it will have deleted both the Facebook and Amazon logins (i.e. the last and second-last login in your list of logins).

I believe @cbjartli had the same issue, perhaps he has more details?


feat: vercelKV checkpointer (WIP)

This PR adds VercelKV checkpointer support.
Working OK tested against vercelKV. It needs proper mockup for the vercelKV service before merging. @nfcampos

Ooh very cool!

Could you open this/put this in @langchain/community instead here though?
https://github.com/langchain-ai/langchainjs

@jacoblee93 Sure I can.
I think it be good  to export SerializerProtocol and CheckpointTuple from this pkg to allow these contributions there. Is it OK?

Yeah makes sense. We'll also need to add an optional dep on LangGraph to community, let me know if I can help with that.


Media upload

After upload image, input value is not set. Please take look on following code the input value is empty.

<input type="text" class="form-control" data-action="arkounay--ux-media--media#updatePathValue" data-arkounay--ux-media--media-target="inputPath" id="zone_Media" name="zone[Media]" value="" placeholder="ux_media.path.placeholder">

If the image uploads successfully and the field updates correctly, it's normal if the input's value is not set in the value attribute right after the file upload, it's like when you manually edit a text <input>, its value isn't set directly in the html
However:

The data-arkounay--ux-media--media-path-value attribute on the controller should be updated immediately after the image upload.
The value attribute of the input element should not remain empty if the original form value wasn't empty.

If the field isn't properly updated or the file isn't uploaded, it's the js that isn't executed for some reasons - do other ux bundles work for you ? do you use asset mapper or webpack encore ?

do other ux bundles work for you
Yes it's work

do you use asset mapper or webpack encore
webpack encore

Seems UX media doesn't work correctrly with
Embedded CollectionType
When the other values in the form are changed, the ux media content is not properly updated.


Error on upload files via kong proxy

kong throwing error "An unexpected error occurred" with server 500 when we try to upload a file via kong proxy with post. We identitf that this error occurs when kong try to merge the request in
kong/plugins/oauth2.lua
in line 94
return utils.table_merge(ngx.req.get_uri_args(), ngx.req.get_post_args())
this error dont happen if we change this line for this another line
return ngx.req.get_uri_args()
In my error log i have this
coroutine 0:
[C]: in function 'get_post_args'
/usr/local/share/lua/5.1/kong/plugins/oauth2/access.lua:97: in function 'retrieve_parameters'
/usr/local/share/lua/5.1/kong/plugins/oauth2/access.lua:344: in function 'parse_access_token'
/usr/local/share/lua/5.1/kong/plugins/oauth2/access.lua:397: in function 'execute'
/usr/local/share/lua/5.1/kong/plugins/oauth2/handler.lua:12: in function 'access'
/usr/local/share/lua/5.1/kong.lua:173: in function 'access'
access_by_lua(nginx.conf:98):2: in function <access_by_lua(nginx.conf:98):1>, client: <IP_ADDRESS>, server: _, request: "POST /rebate/debit-notes HTTP/1.1", host: "localhost:8000"

@jl91 I believe my PR fixes your problem. Is the error message you pasted the full log?

no, this is a tail off log. tomorrow i update this ticket.

Okay - I think my PR fixes it but seeing the full log would still help.

now i have another problem. Everytime i reboot my pc and when i try to start kong have this messa.
[ERR] nginx: [error] [lua] kong.lua:144: init(): Startup error: /usr/local/share/lua/5.1/kong/tools/utils.lua:221: /usr/local/share/lua/5.1/kong/plugins/runscope/handler.lua:3: module 'kong.plugins.runscope.log' not found:	no field package.preload['kong.plugins.runscope.log']	no file '/usr/local/openresty/lualib/kong/plugins/runscope/log.lua'	no file '/usr/local/openresty/lualib/kong/plugins/runscope/log/init.lua'	no file './kong/plugins/runscope/log.lua'	no file '/usr/local/openresty/luajit/share/luajit-2.1.0-beta1/kong/plugins/runscope/log.lua'	no file '/usr/local/share/lua/5.1/kong/plugins/runscope/log.lua'	no file '/usr/local/share/lua/5.1/kong/plugins/runscope/log/init.lua'no file '/usr/local/openresty/luajit/share/lua/5.1/kong/plugins/runscope/log.lua'	no file '/usr/local/openresty/luajit/share/lua/5.1/kong/plugins/runscope/log/init.lua'	no file '/usr/local/openresty/lualib/kong/plugins/runscope/log.so'	no file './kong/plugins/runscope/log.so'	no file '/usr/local/lib/lua/5.1/kong/plugins/runscope/log.so'	no file '/usr/local/openresty/luajit/lib/lua/5.1/kong/plugins/runscope/log.so'	no file '/usr/local/lib/lua/5.1/loadall.so'	no file '/usr/local/openresty/lualib/kong.so'	no file './kong.so'	no file '/usr/local/lib/lua/5.1/kong.so'	no file '/usr/local/openresty/luajit/lib/lua/5.1/kong.so'	no file '/usr/local/lib/lua/5.1/loadall.so'
[ERR] Could not start Kong
To fix that always i have to "Make install again kong"

see #1079

@jl91 that's fixed in the next release.

thanks man, really thanks i love this project haha <3

@jl91 btw you can give it a try, RC1 is out: https://github.com/Mashape/kong/releases/tag/0.8.0rc1


Oro/Bundle/ImportExportBundle/Reader/AbstractReader::initializeFromContext() Should be an abstract

Looks like the Oro/Bundle/ImportExportBundle/Reader/AbstractReader::initializeFromContext() method is required to be overridden and implement some initialization.
/**
 * Should be overridden in descendant classes
 *
 * @param ContextInterface $context
 */
protected function initializeFromContext(ContextInterface $context)
{
}

If you have not implemented the method it throws the exception: "Reader must be configured with source" which makes you to dig out the source code of the ORO Platfom to figure out what is a real cause. Obviously the method should be declared as an abstract if it's really required.

I see now, the source iterator can be provided in a different way.


Some modules are not sorting

Batting
Pitching
Appearances
Fielding
People
FieldingOF
FieldingOFSplit
Salaries
Search

Research which ones work and which ones do not

Batting
Sort works for both

Pitching

Appearances

Fielding

People

FieldingOF

FieldingOFSplit

Salaries

Search


[Bug]: shopify theme dev CORS and HMR errors

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Theme
Expected behavior

No CORS errors
HMR works normally
Can access Cart API (eg: /cart/update.js) in the localhost preview (eg: at https://<IP_ADDRESS>:9292)

Actual behavior
HMR is not working properly, possibly due to CORS errors (that I didn't have before version <3.38 roughly). There are lots of errors are showing in console – note the bottom two lines, it's returning a 401 error when I just try to add a product to cart:

No idea how to fix this. I didn't change any theme code, and this was working fine in previous versions... so it makes me think there's something wrong with CLI authentication or CORS or CLI Ruby?
Not sure, but might be related to #1343
Stack trace
kenji % SHOPIFY_CLI_STACKTRACE=1 shopify theme dev --path=src --store=<REDACTED> --theme=122631749741 --password=<REDACTED> --verbose
2023-02-12T05:03:22.717Z: Running command theme dev
  shopify:theme:dev init version<EMAIL_ADDRESS>argv: [ '--path=src', '--store=<REDACTED>', '--theme=122631749741', '--password=<REDACTED>', '--verbose' ] +0ms
2023-02-12T05:03:22.729Z: Ensuring that the user is authenticated with the Theme API with the following scopes:
[]

2023-02-12T05:03:22.734Z: Obtaining the dependency manager in directory /Users/kenji/Dev/<REDACTED>...
2023-02-12T05:03:22.736Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/ruby -v
  · Working directory: /Users/kenji/Dev/<REDACTED>

2023-02-12T05:03:23.089Z: Analytics event sent: {
  "command": "theme dev",
  "time_start":<PHONE_NUMBER>718,
  "time_end":<PHONE_NUMBER>732,
  "total_time": 14,
  "success": true,
  "cli_version": "3.43.0",
  "ruby_version": "3.2.1",
  "node_version": "19.6.0",
  "is_employee": false,
  "uname": "darwin arm64",
  "env_ci": false,
  "env_plugin_installed_any_custom": false,
  "env_plugin_installed_shopify": "[\"@shopify/cli\",\"@shopify/theme\"]",
  "env_shell": "zsh",
  "env_device_id": "2872e235535e04836bff70a7b12c8a364c8bee7c",
  "env_cloud": "localhost",
  "env_package_manager": "yarn",
  "cmd_all_launcher": "unknown",
  "cmd_all_topic": "theme",
  "cmd_all_plugin": "@shopify/theme",
  "args": "--path=src --store=<REDACTED> --theme=122631749741 --password=<REDACTED> --verbose",
  "env_plugin_installed_all": "[\"@shopify/cli\",\"@shopify/theme\"]",
  "metadata": "{\"extraPublic\":{},\"extraSensitive\":{}}"
}
2023-02-12T05:03:23.089Z: Completed command theme dev
2023-02-12T05:03:25.740Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/ruby -v
  · Working directory: /Users/kenji/Dev/<REDACTED>

2023-02-12T05:03:25.760Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/bundle -v
  · Working directory: /Users/kenji/Dev/<REDACTED>

2023-02-12T05:03:25.871Z: Creating directory at /Users/kenji/Library/Caches/shopify-cli-nodejs/vendor/ruby-cli/2.34.0...
2023-02-12T05:03:25.871Z: Writing some content to file at /Users/kenji/Library/Caches/shopify-cli-nodejs/vendor/ruby-cli/2.34.0/Gemfile...
2023-02-12T05:03:25.872Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/bundle config set --local path /Users/kenji/Library/Caches/shopify-cli-nodejs/vendor/ruby-cli/2.34.0
  · Working directory: /Users/kenji/Library/Caches/shopify-cli-nodejs/vendor/ruby-cli/2.34.0

2023-02-12T05:03:25.952Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/bundle install
  · Working directory: /Users/kenji/Library/Caches/shopify-cli-nodejs/vendor/ruby-cli/2.34.0

2023-02-12T05:03:26.104Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/bundle exec shopify theme serve /Users/kenji/Dev/<REDACTED>/src --theme<PHONE_NUMBER>41 --live-reload hot-reload
  · Working directory: /Users/kenji/Dev/<REDACTED>

┏━━ Viewing theme… ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
┃ DEBUG GET https://theme-kit-access.shopifyapps.com/cli/admin/api/unstable/themes.json with X-Request-Id: ab8c3a26-fe28-4f5a-b29b-36a224b28420
┃ * Syncing theme #122631749741 on <REDACTED>.myshopify.com
┃ DEBUG GET https://theme-kit-access.shopifyapps.com/cli/admin/api/unstable/themes/122631749741/assets.json with X-Request-Id: 3be1ea5a-3026-4f7e-ba19-1d4d76b5870e
┃                                                                                100%
┃
┃ Serving /Users/kenji/Dev/<REDACTED>/src
┃
┃ Please open this URL in your browser:
┃ http://<IP_ADDRESS>:9292
┃
┃ Customize this theme in the Theme Editor, and use 'theme pull' to get the changes:
┃ https://<REDACTED>.myshopify.com/admin/themes/122631749741/editor
┃
┃ Share this theme preview:
┃ https://<REDACTED>.myshopify.com/?preview_theme_id=122631749741
┃
┃ (Use Ctrl-C to stop)
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ (2.08s) ━━
[2023-02-12 15:03:28] INFO  WEBrick 1.7.0
[2023-02-12 15:03:28] INFO  ruby 3.2.1 (2023-02-08) [arm64-darwin22]
[2023-02-12 15:03:28] INFO  WEBrick::HTTPServer#start: pid=10361 port=9292
DEBUG Refreshing preview _secure_session_id cookie
DEBUG Proxying HEAD https://theme-kit-access.shopifyapps.com/cli/sfr/?preview_theme_id=122631749741&_fd=0&pb=0
DEBUG `-> 302 request_id: 44fc8e55-d1bd-42dc-b451-d77f651d2009
DEBUG Proxying GET https://theme-kit-access.shopifyapps.com/cli/sfr/?_fd=0&pb=0
DEBUG `-> 200 request_id: e92524c4-1bbf-404a-bb66-d94c0daa1d0a
DEBUG [HotReload] Connected to SSE stream
DEBUG Proxying POST https://theme-kit-access.shopifyapps.com/cli/sfr/.well-known/shopify/monorail/unstable/produce_batch?_fd=0&pb=0
DEBUG Proxying GET https://theme-kit-access.shopifyapps.com/cli/sfr/web-pixels-manager@0.0.216/sandbox/?_fd=0&pb=0
DEBUG Proxying GET https://theme-kit-access.shopifyapps.com/cli/sfr/web-pixels-manager@0.0.216/sandbox/worker.modern.js?_fd=0&pb=0
DEBUG Proxying POST https://theme-kit-access.shopifyapps.com/cli/sfr/.well-known/shopify/monorail/unstable/produce_batch?_fd=0&pb=0
DEBUG Proxying POST https://theme-kit-access.shopifyapps.com/cli/sfr/.well-known/shopify/monorail/unstable/produce_batch?_fd=0&pb=0
DEBUG `-> 400 request_id: 766f6f21-bfea-43b0-a1e4-9e3512d30270
DEBUG `-> 400 request_id: 584af6f7-6442-42c8-b80f-c022d80a4640
DEBUG `-> 400 request_id: c9a71544-0f99-4181-b10b-ac034f376daa
DEBUG Proxying POST https://theme-kit-access.shopifyapps.com/cli/sfr/.well-known/shopify/monorail/unstable/produce_batch?_fd=0&pb=0
DEBUG Proxying POST https://theme-kit-access.shopifyapps.com/cli/sfr/.well-known/shopify/monorail/unstable/produce_batch?_fd=0&pb=0
DEBUG `-> 200 request_id: ccf7442f-8cbd-4a86-9e2f-0570ac24e729
DEBUG `-> 200 request_id: 554b65b2-97e6-4476-99ab-81d8f872910c
DEBUG `-> 400 request_id: 11323032-97be-480b-a450-2f96e2b2841a
DEBUG `-> 400 request_id: 6ff30724-fa2a-427f-abe9-25b2e28c364b
DEBUG Proxying POST https://theme-kit-access.shopifyapps.com/cli/sfr/.well-known/shopify/monorail/v1/produce?_fd=0&pb=0
DEBUG `-> 400 request_id: 1f444d4d-3445-479f-8f9f-11180ea3c7f6
DEBUG Proxying GET https://theme-kit-access.shopifyapps.com/cli/sfr/cart?_fd=0&pb=0
DEBUG `-> 200 request_id: aceb4fd6-90fc-4b8d-915f-b36ffc793a7f
DEBUG Proxying POST https://theme-kit-access.shopifyapps.com/cli/sfr/cart/update.js?_fd=0&pb=0
DEBUG `-> 401 request_id: 3012e3b1-0f4a-4fde-9868-2e1b91077ec3
^CDEBUG Stop signal: "SIGINT"
Stopping…
DEBUG Stop signal: "SIGTERM"
Stopping…

kenji % [2023-02-12 15:04:31] INFO  going to shutdown ...
[2023-02-12 15:04:31] INFO  WEBrick::HTTPServer#start done.

Reproduction steps

Run shopify theme dev with --store and --password
Open the local preview in your browser
Check if HMR works and if there are any CORS errors in the console, and possibly trying to access shopify APIs (eg: Cart API).

Operating System
MacOS Ventura 13.1
Shopify CLI version (check your project's package.json if you're not sure)
3.43.0
Shell
zsh
Node version (run node -v if you're not sure)
v16.19.0
What language and version are you using in your application?
No response

👋 hi @kenji-twp, thanks for reporting this issue! i'm able to reproduce the issue so thank you for all the helpful information.
the 400s you're seeing in your console are noisy but don't appear to be related to the reason the cart isn't previewing.
this issue seems to be related to the theme access app so i was able to successfully hot reload the cart related templates/ add to cart by excluding the --password param. if possible, id authenticate via the browser in the meantime instead of using your theme access token. however, let me know if this temporary workaround doesn't work 🙏

Im getting the same issue without using Theme Access app or the --password flag, I even tried to logout and relogin but still get the same issues mentionned above, here is my console screen.
When I disable HOT RELOAD, these issues disappear however. I hope this could help.

Same issue here. Using Apple Silicon + Homebrew Shopify CLI 3.0, latest version (3.43.0)

Also getting CORS errors and hot-reloading failing. Also noticing that shopify theme dev --live-reload full-page seems to try hot-reloading still but fails and does a full round trip anyway.
Apple Silicon + Homebrew install
Current Shopify CLI version: 3.43.0

just an update -- the CORS error was fixed via this PR (see original issue here), however this fix isn't live yet in the CLI.
however the issue i linked didn't stop HMR from working, so ill continue to investigate.

Ok, it should work now (it doesn't require a CLI upgrade). Please, let us know if you find any other issue.

Hot reload was working great for me until suddenly it stopped a week ago. Any fresh theme extensions created (I am using a theme extension) also show the same CORS issue. I can see from your PR linked that one of the things to test is the hot-reload URL shouldn't be called twice, and unfortunately it is.

@Poitrin thanks for the follow-up. Appreciate it. Good to know that it's been working without CORS. Tried your shopify-nightly fix but unfortunately it doesn't run shopify-nightly app dev so unusable for me. Weirdly, something has stopped HMR working in my code, so I may open another issue in that case


Reuse configuration + clean up resources upon provision failure

When a developer creates an environment and runs azd provision/azd up, they can run into blocking problems that are out of their control (e.g. if the region they selected during environment creation is busy/at capacity).
In this case, if the region is busy, we require the user to effectively start over, delete/create a new environment/run azd down and try again. This is slow and pretty cumbersome.
Instead, it'd be ideal if we could reuse pieces of information that the developer is likely to want to keep the same and make it easy for them to retry their desired action.
For example, this could look like:

Developer runs azd up
Developer configures their environment by passing in the environment name, region and subscription
Developer sees error that the region is busy and that the provision has failed as a result of a capacity related issue
Developer is prompted to select another region (we keep the environment name and subscription selected)
After picking a suitable region, provision and deploy finish as intended

Under the hood, we'd:

Adjust the region in the azure.yaml
Either deprovision anything that can't be modified to reflect the new region, or change the region in place (optimizing for the quickest operation)
Maybe other things???

There also might be other cases where this type of retry experience would be helpful.

cc: @puicchan

We do have azd env set command that can be used to switch an environment to a different location (azd env set AZURE_LOCATION someNewRegion). This, together with azd down should get you pretty close to what you want, although one can argue the env set command is not super discoverable, or very well documented.
azd down could also really benefit from introducing a --no-wait option.

I think figuring out what to do here is going to require a bunch of deep thinking, there are a lot of things we need to take into account.  In general, every resource could end up in a different region (for example, today we take a location parameter to our templates and use that single parameter for everything, but there's no reason we couldn't take multiple parameters and use one value for some resources and the other value for the other resources, or hard code resources, etc).
I don't think it's possible to move already provisioned resources (or if you can it will be service specific) non-destructively, which will make moving from one location to another behind the scenes difficult.
A related problem is that we need to make sure when you change the value of the location parameter, what the behavior of the next azd provision should be.  In a system like Pulumi or Terraform, we'd actually see the region change as a difference and see a delete and creation scheduled to get the resource into the new location.  I'm not sure what ARM would do, it might give an error saying the resource already exists in a different region (as it does for deployments).

Good points @ellismg , but what you are saying makes me inclined to not touch this ball of complexity with 10-foot pole. Instead, we could just say

location is an environment setting, like any other. It just happens to be a required one for many of our templates, so we ask about it up-front.
How the system reacts to changing location, depends on how the deployment is structured/defined, as well as whether you are using Bicep, Terraform, or something else.

And then we just need to figure out if we can established some conventions for our templates that make @savannahostrowski  happy.


[Event Request] Codeunit 427 ICInboxOutboxMgt - procedure CreatePurchDocument - OnCreatePurchDocumentOnAfterValidateBuyFromVendorNo

Please add an Event OnCreatePurchDocumentOnAfterValidateBuyFromVendorNo in procedure CreatePurchDocument in Codeunit 427 ICInboxOutboxMgt
[Event Request] Codeunit 427 - ICInboxOutboxMgt - procedure CreatePurchDocument
var
    ICInboxPurchLine: Record "IC Inbox Purchase Line";
    PurchHeader: Record "Purchase Header";
    ICDocDim: Record "IC Document Dimension";
    ICDocDim2: Record "IC Document Dimension";
    HandledICInboxPurchHeader: Record "Handled IC Inbox Purch. Header";
    HandledICInboxPurchLine: Record "Handled IC Inbox Purch. Line";
    DimensionSetIDArr: array[10] of Integer;
    IsHandled: Boolean;
begin
    IsHandled := false;
    OnBeforeCreatePurchDocument(ICInboxPurchHeader, ReplacePostingDate, PostingDate, IsHandled, PurchHeader, HandledICInboxPurchHeader);
    if IsHandled then
        exit;

    with ICInboxPurchHeader do begin
        PurchHeader.Init();
        PurchHeader."No." := '';
        PurchHeader."Document Type" := "Document Type";
        OnCreatePurchDocumentOnBeforePurchHeaderInsert(PurchHeader, ICInboxPurchHeader);
        PurchHeader.Insert(true);
        PurchHeader.Validate("IC Direction", PurchHeader."IC Direction"::Incoming);
        PurchHeader.Validate("Buy-from Vendor No.", "Buy-from Vendor No.");

        OnCreatePurchDocumentOnAfterValidateBuyFromVendorNo(ICInboxPurchHeader, PurchHeader); // <-- NEW EVENT

        if "Pay-to Vendor No." <> PurchHeader."Pay-to Vendor No." then
            PurchHeader.Validate("Pay-to Vendor No.", "Pay-to Vendor No.");
    ...

[IntegrationEvent(false, false)]
local procedure OnCreatePurchDocumentOnAfterValidateBuyFromVendorNo(ICInboxPurchHeader: Record "IC Inbox Purchase Header"; var PurchHeader: Record "Purchase Header")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Gift card floating point values

Description
Fixes #955
The gift card API returns string values for balance and initial_value (e.g. "25.00"). However, the ShopifyAPI::GiftCard class specifies returns(T.nilable(Float)). When an instance of ShopifyAPI::GiftCard is created using the response from the API, calling gift_card.balance or gift_card.initial_value results in an error like so:
TypeError: Return value: Expected type T.nilable(Float), got type String with value "120.00"
How has this been tested?
Enhanced test suite to assert that balance and initial_value methods can returns the expected values.

[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have added a changelog line.

Closing for same reason as discussed in: https://github.com/Shopify/shopify_api/pull/956#issuecomment-1128054054


Remove no longer needed resource service

What type of PR is this?
/area simulator
/kind cleanup

What this PR does / why we need it:
We no longer need each resource service.
Which issue(s) this PR fixes:

closes #139 #233
Special notes for your reviewer:
/label tide/merge-method-squash

@196Ikuchil Sorry about the delay, FYI https://github.com/kubernetes-sigs/kube-scheduler-simulator/pull/304 is merged

/unhold

Thanks!
Please review this? 🙏
/assign @sanposhiho


user inactive can not log in

Seems to work good. Deals with the reset password loophole as well.

Yeah seems to work well, thanks for helping on this everyone!

checked in without i18n :(

Submit a PR :)  Its an important bug fix that has been waiting for a long time or I wouldn't have.


Proposal to restructure repo

@tucotuco @pzermoglio. I discussed this morning with @baskaufs if the Quick Reference Guide should be part of the standard. If it is, it needs to comply with how human documentation, section "3.2.3 Layout and style". We think it should be the first brick of a community-maintained Darwin Core website (where we have more freedom) and not part of the standard.
So, we here propose a new structure for the repo:

All content considered part the standard is in directory standard. Generic enough if you used for other vocabs
The standard contains (as by the guide) vocabularies and documents
Vocabularies contains only one: term_versions.csv
Documents contains the 4 guides: this will have to comply with how human readable documentation should look like, but that is something that we can do (and almost the case)
The quick reference guide is part of a /www directory, in the directory guides. The www directory can be seen as the start of the community-maintained Darwin Core website, which in the future might not even be part of this repo.

That sounds good to me. More freedom!


Fix the 1.0.5 release

Looks like this didn't actually get out because of some weird 401 on the deploy step. Need to investigate and get this into Maven Central which still shows the latest as 1.0.4.

Deployed it locally. Somehow my password no longer worked but I was able to deploy after resetting it.


topolvm-controller restart failure

Describe the bug
After a very disruptive (intentional) CNI restart, I found that topolvm-node instances and controllers were in CrashLoopBackoff. Exploring more deeply, the replicaset for the controller had this warning in the events:
  Warning  FailedCreate  18s (x6 over 2m48s)  replicaset-controller  Error creating: Internal error occurred: failed calling webhook "pod-hook.topolvm.cybozu.com": Post "https://topolvm-controller.topolvm-system.svc:443/pod/mutate?timeout=30s": context deadline exceeded

While the nodes were likely waiting for the controller, it was suboptimal that the controller could not start when it was also supplying the webhook.
The solution was to save the MutatingWebhookConfiguration object, delete it, then restart the pods and finally re-introduce the webhook configuration.
I apologize that I am reporting on an older version, will be updating soon, but wanted to make sure the report was not lost.
Environments

Version: 0.7.0
OS: Ubuntu 20.04, kernel 5.11.0-22-generic # 23~20.04.1-Ubuntu SMP

It is needed to set a label to the topolvm namespace to ignore itself from the webhook.
see this document. https://github.com/topolvm/topolvm/blob/main/deploy/README.md#install-helm-chart
I think this should be also described in charts/topolvm/README.md. I will fix it later.

I assume this is resolved by adding the label to the namespace. If you have any more problems, please report it.

Hi sorry for the delay to respond, thanks for your response and closing this out!!


[DPE-2658] - Integration tests stabilization

Issue
Some integration tests such as the client integration seem to consistently fail, this PR implements DPE-2658, namely this PR implements:

Tests side:

alternative wait for idle on all tests with more granularity
breakdown of ha-tests into 2 files including ha-multi-clusters-integration

charms side:

cluster health handling of erroneous response payload
upgrade of charm libs - with regards to snaps
removal of snapd refresh that causes the install to hang sometimes
Handling of plugin operation error on_config_changed
Introduction custom event for forcing re-trigger of a deferral:

removal of deferral strategy using _status_update
replace it with DeferTriggerEvent.emit()

Avoiding setting the status of a unit or an application UNLESS the current status is not equal to it, to avoid updating the idle flag of the model
Retry of lock acquiring in scale-down
Upgrade of urllib to version 2

Hi @Mehdi-Bendriss, the client-integration ran for a long time, but it seems it faced a timeout error in one of its tests: https://pastebin.ubuntu.com/p/QWSzFcgqPS/
Right before, there was also two other lines in the same unit:
2023-10-16 18:22:24 INFO unit.opensearch/1.juju-log server.go:316 opensearch-client:5: Health: {'error': {'root_cause': [{'type': 'security_exception', 'reason': 'OpenSearch Security not initialized for cluster:monitor/health'}], 'type': 'security_exception', 'reason': 'OpenSearch Security not initialized for cluster:monitor/health'}, 'status': 503}
2023-10-16 18:22:24 ERROR unit.opensearch/1.juju-log server.go:316 opensearch-client:5: 'int' object has no attribute 'lower'

Full juju status of that failure: https://pastebin.ubuntu.com/p/kyv7mCv8TQ/
Now, it should not be a problem the amount of workloads you have there. So, the erroring unit is the reason for the test to fail.
I had a proposal in this PR: https://github.com/canonical/opensearch-operator/pull/130#issuecomment-1744451875

Thanks @phvalguima ! the health case you described should be handled here


Comment counter testing

In this milestone, the following tasks have been achieved:

Designed tests to check the comments counter function.
Create multiple tests checking for different scenarios.

Status: ✔ Project Approved ✔
Hi @Sajeelzafar ,
Everything is looking great! Please, merge this branch :shipit:
Congratulations! 🎉


v2plugin: add checks for delete network/epg

In swarm-mode, add check for mapped docker network
when deleting netctl network or epg.
Fixes https://github.com/contiv/netplugin/issues/962

2recheck

build PR

build PR

build PR

build PR


Hide deprecated and duplicate attributes

Hide deprecated and duplicate attributes
Some virtual_attributes are not needed in reporting nor the api.
Some deprecated attributes should not be advertised for customers to start using.
Now, the attributes are still accessible. So nothing will break. But
these attributes are no longer advertised on the public apis (i.e.: report builder and rest api).
This allows us to control which parts of our models are exposed.
So it will fix #18130 and also allows us to introduce attributes in PRs like #20532 because we will not need to expose the newly introduced attribute.
This does modify the report builder, but minimal changes over in the api repo are necessary to plug up this hole over there.

I think the preferred way to do this is to use private instead of adding yet more metadata - but I felt like turning all these fields private has some unknown consequences

I like this idea...  seems like a decent compromise over straight private.  In that sense, can we name it private_attribute or perhaps even better private_virtual_attribute (since I assume we'll never want to hide regular attributes - though password does come to mind 😉 )

yea so models that inherit from the ActsAsArModel aren't going to work with this as it is now

Just pushed whitespace fix.

Added tests around children and deprecated attributes. Don't know how to hide from children to parents.
If you want to remove privatization of deprecated attributes, give the word?

Just pushed whitespace fix...

This doesn't sound like a whitespace fix...

maybe hidden_attribute would be better?
-- @bdunne

<3 I agree and that is the original name.
But I just want the thing merged and am good with any name that people pick.
(the branch name also suggests my agreement with your statement)

I had this in deprecated attribute mixin. But the original intent was to hide new virtual attributes

@miq-bot cross-repo-tests #20664

for this pr, lets test across many repos (trying to get a handle on this)
@miq-bot cross-repo-tests manageiq-ui-classic, manageiq-api, ManageIQ/manageiq-providers-amazon, ManageIQ/manageiq-providers-azure, ManageIQ/manageiq-providers-ibm_cloud, ManageIQ/manageiq-providers-kubernetes, ManageIQ/manageiq-providers-openstack, ManageIQ/manageiq-providers-vmware

status: cross repo failure was because this PR is against an older version of the code base
Just pushed a rebase and those should be fixed

@miq-bot cross-repo-tests manageiq-ui-classic, manageiq-api, ManageIQ/manageiq-providers-amazon, ManageIQ/manageiq-providers-azure, ManageIQ/manageiq-providers-ibm_cloud, ManageIQ/manageiq-providers-kubernetes, ManageIQ/manageiq-providers-openstack, ManageIQ/manageiq-providers-vmware

I had this in deprecated attribute mixin. But the original intent was to hide new virtual attributes

Ahhhh...my original intent was for it to act more like private (ref & ref).  This is probably why was confused here.
However, I'm good if your intent is to act more like hidden.  If that's the case, then I agree that hidden_attribute makes more sense as a name.

right about now is when I wish my git-fu were not as good and I had an earlier commit with the hidden word in it (rather than rebasing and the changes I made)
coming right up

@bdunne and @Fryguy is this closer to what we want?

cc @agrare ... wonder if we can start using this to hide the support features stuff.


Running SLAM in online mode

Thanks for sharing the code!
I've read through the documentation, but couldn't find instructions on running this SLAM in online mode (as it is supposed to). Could you please direct me to the appropriate resource? Thanks.

Hi, we mostly evaluate on datasets, if you want to run online with your device attached to the computer, maybe you could try SplaTAM, they provided a demo on their GitHub.


Cleanup Vim and NeoVim instructions. Fix #2579

I took some freedom to remove additional tips that I simply considered unnecessary as I view it as responsibility of plugin's own docs.

LGTM!
bors delegate+

bors r+


[REVM-5] Create a single runSQL endpoint that can handle multiple writes and creates

Discussed in https://github.com/orgs/tablelandnetwork/discussions/231

Originally posted by sanderpick August 19, 2022
Tension: https://github.com/orgs/tablelandnetwork/discussions/230
We want to let a single txn touch multiple tables. Here's a proposal for altering TablelandTables to enable this.

Create an overloaded version of runSQL that takes an array of structs containing a table ID and an array of SQL statements. Pseudo-ish code:
struct Runnable {
    uint256 tableId;
    string[] statements;
}

function runSQL(
    address caller,
    Runnable[] memory runs,
) external payable;

For many statements against the same table, the table ID doesn’t need to be repeated (but you could still have multiple structs against the same table, if this ordering was important to you)
ACL check could be performed once per struct instance (vs. grouping in the contract which has some computational cost)

I also like the idea of including table creation in a single endpoint like this. We could say that if the table ID is not defined (has its default value of 0), then interpret it as “create table”.
With a SQL parser available to clients, SDKs could map a plain list of SQL statements to an array of Runnable (or similarly named object). That is to say, using the API would be abstracted from users in some UX friendly way.
From SyncLinear.com | REVM-5

@sanderpick Sounds great!

@joe I imported this issue and added you as assignee because you've already done most of the hard work. Sound okay?


Package not found

Hi, it seems you forgot to upload “simcse” package

You can check out https://github.com/princeton-nlp/SimCSE for package installation.


Missing outputFocus context variable

I'm trying to set things up so that I can always close whatever pane I'm in with a cmd+w, I can do this for:
Problems:
{ "key": "cmd+w", "command": "workbench.action.togglePanel", "when": "problemFocus" }
Debug console:
{ "key": "cmd+w", "command": "workbench.debug.action.toggleRepl", "when": "inDebugRepl" }
Terminal:
{ "key": "cmd+w", "command": "workbench.action.terminal.kill", "when": "terminalFocus" }
But I can't do this for the Output pane, since there's no outputFocus context variable I can use.
Can you add this please?

Please use the inOutput context key
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/output/common/output.ts#L62


add inference test for mosaicml-mpt-7b-chat

Type of Change
CI for mpt-7b-chat
Description
CI test based on docker
Expected Behavior & Potential Risk
CI tests run successfully on all supported models so far
How has this PR been tested?
CI tests triggered and run in self hosted runner
Dependency Change?
no

@XuehaoSun @chensuyue please help review.
It doesn't work when try to read env variables from runner .env. So I added some logic to load env variables from the .env.


Users still registered with name when disconnecting

Hello,
Trade System still register users with their username instead of UUID while disconnecting.
Suggested:

Register an user in the userlist only when he try to use /trade or /tblacklist for the first time.
Register the UUID & the name (but the name should be updated if the user change his name on mojang)
When using /tblacklist on a player who doesn't exist in the user list, add a message "this user never user /trade before. You can't block him."

Features/Fixes will be in the next update!


vimPlugins.nvim-scissors: init at 2024-10-30

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@GaetanLepage

README says that it depends on telescope.
Could you start by adding an nvimRequireCheck in overrides.nix ?
If telescope-nvim is really needed, then add it to the dependencies.

README says that it depends on telescope. Could you start by adding an nvimRequireCheck in overrides.nix ? If telescope-nvim is really needed, then add it to the dependencies.

I have added the check. Can you please run nixpkgs-review

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 352245

x86_64-linux

:white_check_mark: 2 packages built:

vimPlugins.nvim-scissors
vimPluginsUpdater

aarch64-linux

:white_check_mark: 2 packages built:

vimPlugins.nvim-scissors
vimPluginsUpdater

x86_64-darwin

:white_check_mark: 2 packages built:

vimPlugins.nvim-scissors
vimPluginsUpdater

aarch64-darwin

:white_check_mark: 2 packages built:

vimPlugins.nvim-scissors
vimPluginsUpdater


test: setup and write tests for a11y

fixes #106

Pull Request Test Coverage Report for Build 633

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 79.522%

Totals

Change from base Build 625:
0.3%

Covered Lines:
425

Relevant Lines:
517

💛  - Coveralls


Update DG

Summary
Resolves #196
Resolves #205
Detail

Update Logic puml and developer guide
Add implementation details for viewing patients
Add some use cases

Checks

[X] Link PR to issue
[X] Add Reviewer
[X] Pass CI

Codecov Report

Merging #311 (e67738b) into master (b8fa536) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

:exclamation: Current head e67738b differs from pull request most recent head f6a78d3. Consider uploading reports for the commit f6a78d3 to get more accurate results

@@             Coverage Diff              @@
##             master     #311      +/-   ##
============================================
- Coverage     74.34%   74.32%   -0.02%
- Complexity     1036     1037       +1
============================================
  Files           141      141
  Lines          3375     3373       -2
  Branches        384      384
============================================
- Hits           2509     2507       -2
  Misses          723      723
  Partials        143      143

Impacted Files
Coverage Δ

...logic/commands/viewcommand/ViewPatientCommand.java
88.88% <100.00%> (-1.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8fa536...f6a78d3. Read the comment docs.


Firefox: tooltip doesn't show up when attached to a child of Button

I have a component that renders a button and within that button I would like to have an img with react-tooltip attached:
    return (
        <button>

            <ReactTooltip id="iconTooltip" className="test-icon">
                foo
            </ReactTooltip>
        </button>
    );

The tooltip shows up in Chrome (58.0.3029.96 64-bit), but doesn't with Firefox (v53.0 32-bit). If the data-tip is specified at the button level directly (rather than on the image), it shows up:
    return (
        <button data-tip data-for="iconTooltip">

            <ReactTooltip id="iconTooltip" className="test-icon">
                foo
            </ReactTooltip>
        </button>
    );

@msarilar i have the same issue as i am tooltip inside the button. The only fix i have is to change the button into a  or anything. Did you get the actual fix?

I'm seeing this as well, appears to be a browser level bug, nothing library specific: https://bugzilla.mozilla.org/show_bug.cgi?id=1084196


Mac Notification Centre Bug

The app doesn't respect the alert style
eg. If I select 'Alerts' instead of 'Banners' the notification still clears itself without user interaction.
thanks

This seems to have fixed itself. Closing the issue.


Updated partitions to match working partitions from simulation

Update partitions to match the working partitions from the simulation (original coordinates were eyeballed to match plot of sample sites-- updated coordinates match real points in the corresponding real dataset):

Trained on real data with default variational inference (updated defaults in additional PR):
Val loss: 1.397790789604187
Train loss: 0.9393936395645142
Test loss: 0.9468271732330322
dO18 RMSE: 0.9135236042418461
Here's a comparison with the current repo partitions to characterize the regression: https://docs.google.com/document/d/1WU_gJgCfi2zQqL5pvLfQKwHO_mj0Vr13HLyMOFqQxNY/edit?resourcekey=0--P8qZrbtdcQhUMIIfCqLIQ#heading=h.vobge5f8t1op

Re comparison doc: When we compared Gabriella's model to the VI model, we discarded RMSEs and instead focused on the PR curves. Why can't we do that here?

Update: Marked DO NOT MERGE since the experiments this is based on now fail to run. We will have to debug post-freeze. All models now appear to produce the same exact (bad) result, regardless of partitioning. Perhaps something with the Drive paths.


TS-4684 Leaked references to HostDBInfos from HttpTransact

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/345/ for details.


Add necessary functionalities.

Here I have added all the functionalities required by the project. I have built all the required JS functionalities of the project. Dear Reviewer, please check my project. Thanks for your time. I haven't styled it very well but Im still trying to style it. The issue is that I have another project ahead and this is the last day. So I was in a bit of rush. Thank you.

Dear Mr. @EricMbouwe
I appreciate your kind review. I will surely work on the optional reviews made by the previous reviewer and would love to have additional reviews to make my code better. Thank you so much.


volume.tier.upload (rclone) doesn't find volumes, unless explicitly specified

Describe the bug
When using rclone on a custom storage.backend config, the volume.tier.upload command doesn't find the volumes to transfer.
When executing the following command:
lock
volume.tier.upload -dest rclone -fullPercent=1 -quietFor=1s
unlock

The shell returns:
collect volumes quiet for: 1 seconds and 1.0% full
tier upload volumes: []

System Setup

OS version: Ubuntu 22.04
weed version: "chrislusf/seaweedfs:3.71_full" (rclone requires full version)

In master.toml, add custom backend:
[storage.backend]
        [storage.backend.rclone.default]
        enabled = true
        remote_name = "hetzner_storage"

In /root/.config/rclone/rclone.conf add:
[hetzner_storage]
type = sftp
host = user.your-storagebox.de
user = user
pass = pw # needs to be obfuscated by rclone
port = 23
shell_type = unix

Hetzner Storage Boxes can be obtained here. Make sure to enable SSH support.
Expected behavior
When explicitly specifying the other arguments, such as, keepLocalDatFile, volumeId, and collection, it works:
lock
volume.tier.upload -dest rclone -fullPercent=1 -quietFor=1s -keepLocalDatFile=false -volumeId=2 -collection=default
unlock

However, this solution is cumbersome, as it requires having a separate script to find all volumes via the master API, and issuing commands to the shell outside of the master service itself. Ideally, the following script should work:
lock
volume.tier.upload -dest rclone -fullPercent=1 -quietFor=1s
unlock

Ah, it also ignores the -fullPercent=95 arg.

The volume.tier.upload is calling this function https://github.com/seaweedfs/seaweedfs/blob/master/weed/shell/command_volume_tier_upload.go#L84
defined in
https://github.com/seaweedfs/seaweedfs/blob/master/weed/shell/command_ec_encode.go#L290
Could not eyeball to find the bug. Could you do some println debugging to see what went wrong?

It seems one of the issues is in this part of the code:
	// volumeId is provided
	if vid != 0 {
		return doVolumeTierUpload(commandEnv, writer, *collection, vid, *dest, *keepLocalDatFile)
	}

If a volumeId is specified, there are no checks to see if the fullPercent, quietFor, or collection conditions are met, and doVolumeTierUpload is called directly. I.e. fullPercent, quietFor, or collection are ignored.
But, if the volumeId is not provided (i.e. default value is 0), the code calls collectVolumeIdsForEcEncode, which checks the fullPercent, quietFor, or collection conditions.
Since I don't know how to code go, I've manually checked in python, and using the master API, that the fullPercent, quietFor, and collection  conditions are indeed met.
However, the collectVolumeIdsForEcEncode doesn't return anything:
	for vid := range vidMap {
		vids = append(vids, needle.VolumeId(vid))
	}

	return // here's the 2nd bug

So, to fix both bugs, collectVolumeIdsForEcEncode should always be used to check the fullPercent, quietFor, and collection conditions, and actually return the volumes that meet the criteria.

I don't know if this is valid (not familiar with coding in go), but Claude suggests the following code to fix both bugs:

func (c *commandVolumeTierUpload) Do(args []string, commandEnv *CommandEnv, writer io.Writer) (err error) {
	tierCommand := flag.NewFlagSet(c.Name(), flag.ContinueOnError)
	volumeId := tierCommand.Int("volumeId", 0, "the volume id")
	collection := tierCommand.String("collection", "", "the collection name")
	fullPercentage := tierCommand.Float64("fullPercent", 95, "the volume reaches the percentage of max volume size")
	quietPeriod := tierCommand.Duration("quietFor", 24*time.Hour, "select volumes without no writes for this period")
	dest := tierCommand.String("dest", "", "the target tier name")
	keepLocalDatFile := tierCommand.Bool("keepLocalDatFile", false, "whether keep local dat file")
	if err = tierCommand.Parse(args); err != nil {
		return nil
	}

	if err = commandEnv.confirmIsLocked(args); err != nil {
		return
	}

	// Always use collectVolumeIdsForEcEncode to check conditions
	volumeIds, err := collectVolumeIdsForEcEncode(commandEnv, *collection, *fullPercentage, *quietPeriod)
	if err != nil {
		return err
	}

	// If a specific volumeId was provided, filter the list
	if *volumeId != 0 {
		found := false
		for _, vid := range volumeIds {
			if vid == needle.VolumeId(*volumeId) {
				volumeIds = []needle.VolumeId{vid}
				found = true
				break
			}
		}
		if !found {
			return fmt.Errorf("volume %d does not meet the criteria for tier upload", *volumeId)
		}
	}

	fmt.Printf("tier upload volumes: %v\n", volumeIds)
	for _, vid := range volumeIds {
		if err = doVolumeTierUpload(commandEnv, writer, *collection, vid, *dest, *keepLocalDatFile); err != nil {
			return err
		}
	}

	return nil
}

func collectVolumeIdsForEcEncode(commandEnv *CommandEnv, selectedCollection string, fullPercentage float64, quietPeriod time.Duration) (vids []needle.VolumeId, err error) {
	// collect topology information
	topologyInfo, volumeSizeLimitMb, err := collectTopologyInfo(commandEnv, 0)
	if err != nil {
		return nil, err
	}

	quietSeconds := int64(quietPeriod / time.Second)
	nowUnixSeconds := time.Now().Unix()

	fmt.Printf("collect volumes quiet for: %d seconds and %.1f%% full\n", quietSeconds, fullPercentage)

	vidMap := make(map[uint32]bool)
	eachDataNode(topologyInfo, func(dc string, rack RackId, dn *master_pb.DataNodeInfo) {
		for _, diskInfo := range dn.DiskInfos {
			for _, v := range diskInfo.VolumeInfos {
				// ignore remote volumes
				if v.RemoteStorageName != "" && v.RemoteStorageKey != "" {
					continue
				}
				if v.Collection == selectedCollection && v.ModifiedAtSecond+quietSeconds < nowUnixSeconds {
					if float64(v.Size) > fullPercentage/100*float64(volumeSizeLimitMb)*1024*1024 {
						vidMap[v.Id] = true
					}
				}
			}
		}
	})

	for vid := range vidMap {
		vids = append(vids, needle.VolumeId(vid))
	}

	return vids, nil  // Corrected return statement
}


Prevent spurious failures for presence ping test

This should prevent the spurious failures caused in case an state is being executed when performing the presence ping test.
On such cases we don't expect to get the actual response from state.show_highstate but a response from the minion like:
- The function "state.apply" is running as PID 8710 and was started at 2017, Jul 05 12:11:54.266463 with jid<PHONE_NUMBER>1154266463

Getting either any of both responses is a valid scenario as the minion is actually responding.

@meaksh  backport the fix to 3'0 and 31 direcly

Merged on master and manager-3.1.
I noticed that the presence ping test is not present on manager30 branch. I also backported the test to manager30.


Partially revert ulimit change - leave jmxtrans crippled

This partially reverts #791 , leaving only the hbase fix. Based on past experience, jmxtrans should be intentionally hobbled.

Rather than reverting the jmxtrans ulimit resource, we'll intentionally set it low here, just in case the system defaults give it more freedom than we want it to have.

Line length?


[feature request] mention ereg in preprocessing tutorial

see above :)

I saw the TODO in issue #72 first and opened #50 for the new branch
Sry, I will do it within the open issue next time

Was fixed in issue #50 but needs review (@neuronflow )


ChunksWriter

Thanks for splitting this out into a separate PR! It is still very big though, I am having a bit of trouble to see the bigger picture just from looking at the diff. Could you maybe write a short summary of the changes in the pull request description? That would be very helpful for me.

Sure. I went for consistency with the read module, so we now have a ChunksWriter that basically inherits all the code that was in WavWriter. The WavWriter is now as a facade for ChunksWriter, maintaining the current interface and preventing the ChunksWriter to reach invalid states.
An EmbeddedWriter struct is added allowing to write an arbitrary chunk. It can be obtained by calling start_chunk on the ChunksWriter. Similarly with the reader case, I could not use the EmbeddedWriter for writing the data chunk (it would have been made WavWriter self-borrowing) so the data chunk is opened by calling start_data_chunk.
The chunk header maintenance routines for both the datachunk managed by ChunksWriter itself and EmbeddedWriters are shared in an the ChunkWritingState struct, mimicking again the "read" case.

@ruuda I'll have a look next week, I'm off right now.

Hey @ruuda, I think this is in a shape... it would be nice to get it merged and released :)

Could you resolve the conflict and fix the commit message?

Thanks, and apologies for the delay. I will make one more pass over the metadata reading before making a release to make sure that the APIs are aligned between Claxon and Hound. I hope to get around to that soon.


onSelect returns previous end date when start date is selected

The callback function onSelect returns previous selected endDate when a new startDate is selected. However, default behaviour puts a .... How to validate if end date selection is pending?

Hi Sachin.
This looks like useful.
I'll merge as soon as possible.
Thanks for the PR.


Webdriver io isExisting method doesnt return anything if element does not exist

I'm trying to check if element exists on the page or not with isExisting() webdriverio method, but it doesnt return anything when element is not exists and works properly and returns true if it does with the following code:
@log
protected async isExisting(element: string, name?: string): Promise<boolean> {
    await this.app.client.isExisting(element)
        .then(data => {
            const isExisting = data;
            console.log(CONSOLE_COLORS.YELLOW, "IS EXISTING???", isExisting);
            return isExisting;
        })
        .catch(e => {
            console.log(CONSOLE_COLORS.RED, "no existing elem")
            return false;
        });
}

How can I write it properly? Webdriverio docs says that isExisting() method is sync and returning a promise. Sorry for creating an issue but I cannot find any answers or workarounds for this.

Nvm, was my bad. Can be closed.


Add JSON response to gcapc/pull and gcapc/push

Add a JSON response to the pages yourpage.com/gcapc/pull and yourpage.com/gcapc/push

closed by #14


--extra-vars not working anymore

In tower-cli 3.1.0 and 3.2.0, creating job_templates with --extra-vars is not working any more:
tower-cli job_template create --name was85-nets_cote_nightly-dev-netsc-startcluster --job-type run --inventory was85-dev-netsc --project Plattformen-SBB --playbook was85_default_start.yml --machine-credential was85-dev --ask-variables-on-launch False --extra-vars project=nets_cote_nightly --force-on-exists
results in a Job Template where the extra-vars is empty. I tried with --extra-vars {project:nets_cote_nightly}  which was not working either.

Fallout from #216, and collision between the create overwrite for the job_type parameter with the overwrite of write for the extra_vars parameter. Although, the exact mechanism by which this collision happened is still unclear to me, it has always been difficult to predict the behavior when using patterns like that.

planning to ship fix in 3.1.3 relatively soon.


Fix isolation checks when using device_map

This PR:

Fixes the isolation checks when device_map is used for the pytorch backend
avoids a call to torch.cuda.current_device() which may trigger an error RuntimeError: Cannot re-initialize CUDA in forked subprocess. To use CUDA with multiprocessing, you must use the 'spawn' start method as it requires to initialize CUDA in a subprocess, which is sensitive to the start method.
adds a yaml example with device_map

isolation checks should be disabled because the tests fail when someone is using the DGX at the same time.

@IlyasMoutawwakil Should be good now!

@IlyasMoutawwakil Do you think the failing test is related to this PR? Is the workflow running on the merge commit or on the branch commit? I can't reproduce the failing workflow on neither of them.

I believe the workflow runs on branch commit. there's a lot of inefficiency in it. I'm trying to avoid the image building each time in another PR. I'm also setting them to not be launched automatically, it gets very messy with the queue.

it seems the error is coming from llm_int8_threshold=0. transformers must have removed it in source, I will check.

Aah I see why this is happening. since we're not using quantization in the config you added, the llm_int8_threshold=0 is not being filtered from kwargs by the BnBQuantizationConfig. in these cases I generally use:
**(
    {"llm_int8_threshold": 0}
    if config.load_in_4bit or config.load_in_8bit
    else {}
),

but the best way should be passing a quantization_config, we could do that when adding GPTQ support.

@IlyasMoutawwakil It should be fixed with https://github.com/huggingface/optimum-benchmark/pull/21/commits/805839210682c38fbce9f2472d82c79e1ebf51c4! Feel free to merge if it looks good to you!


Regarding train_epochs

(TimesNet)
some models have very small train_epochs settings, what is the reason? To prevent the training time from getting too long, or to prevent overfitting. But why do you use such small train_epochs when you have already set up an early stop mechanism?

Hi, thanks for pointing out this issue. these are typos, you can just remove them and adopt the default setting.


Bufferingprogress

Description
Related to #2453. Added bufferingprogress() to time_range_utils.js which returns the buffered amount as a number. The function could be called while designing the UI.
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change may require a documentation update

Checklist:

[x] I have signed the Google CLA https://cla.developers.google.com
[x] My code follows the style guidelines of this project
[x] I have verified my change on multiple browsers on different platforms
[x] I have run ./build/all.py and the build passes
[x] I have run ./build/test.py and all tests pass

This doesn't make sense to me as it is currently written.
It looks like it provides a percentage of the video duration, but this is not really useful as a progress indicator.  We don't care about how much of the total video duration is buffered, because that is not how buffering states work.
When the video starts buffering, there is a buffering goal after which is leaves the buffering state.  This is what we would measure to augment the buffering UI: how close are we to leaving the buffering state?

Okay, "How close are we to leave the buffering state?"
I'll make the changes.

We recently merged a PR adding getBufferFullness() to the Player class.  Thanks!


pax-logging-logback: Allow to skip reset of JUL

We configure logback with
  <contextListener class="ch.qos.logback.classic.jul.LevelChangePropagator">
    <resetJUL>true</resetJUL>
  </contextListener>

as recommended for performant logging with JUL+SLF4J.
LevelChangePropagator however only works in one direction, pushing logback configuration into JUL, it does not account for JUL configuration being changed behind its back. But this is what happens currently due to that unconditional manager.reset() call:

when the bundle activator creates PaxLoggingServiceImpl on line 126 and thereby boots/configures logback, log levels for logback are set and synchronized to JUL
when manager.reset() runs next, the JUL log levels are reset, i.e. default to INFO level, causing a disconnect between JUL and logback such that (logback) loggers that have enabled DEBUG level never receive messages because the originating JUL logger drops anything below INFO before the JdkHandler is reached

hmm ... sorry for being PITA, but usually we prefer to have a corresponding Jira issue with a PR. That way it's easier to track what has been included in the next release.
could you at least open an issue for this and link this commit to it?
Thanks


Adding earthaccess catalog in Intake 2

I have written a little code which enables calling the earthaccess functions from within intake. The point of this, is that certain queries and dataset results could then be persisted in catalogs without having to keep code snippets around. The users still need to register and understand what the query parameters mean.
Do people here think this is a useful thing to do, and does the implementation look OK? Am I right in assuming that the DOI is the best unique identifier of a data product?

Nice! I haven't used Intake before, but excited to see more integrations :) What would using this look like?

Am I right in assuming that the DOI is the best unique identifier of a data product?

I think collection_concept_id is going to be the "best" unique identifier (as intended by the CMR API, not necessarily easiest-to-use). Under the hood, earthaccess is translating the doi query to a concept_id query by doing a collection search to get the concept_id.
https://github.com/nsidc/earthaccess/blob/7db2e59fb76d9eea87a343bbf2af505a57c43e10/earthaccess/search.py#L699-L702

collection_concept_id is going to be the "best" unique identifier

Thanks, I'll use that.
The use pattern would be like
import intake.readers.catalogs
spec = cat = intake.readers.catalogs.EarthdataCatalogReader(temporal=("2002-01-01", "2002-01-02"), ....)
cat = spec.read()
list(cat) # shows available identifiers, which all have metadata
reader = cat[<identifier>]
ds = reader.read() # outputs an xr.DataSet

Of course, the flow is nearly exactly the same as you have anyway, but the point is that spec and reader with their parameters can be saved in catalogs.

I am working with provisional ATL07/10 data, and would like to set up some access to our local repositories.  These are pre-decisional data, and cannot be added for general access.  I have been looking for instructions and/or tutorials on how to set up intake/earthaccess to access local files/repositories, but have not figured it out yet, so I thought I would ask here .
As a note, it has been 5+ years since I worked on setting up any intake catalogs, so pointers to instructions on setting this out would be helpful.  I will be glad to post tutorials and instructions once I get this worked out, but I will first have to get permission for the public release.

Thanks!  This gives me a place to start.  Ill post something here if I find a workable solution.


Carousel Items width is defective

I have the following code
<ngx-carousel [inputs]="carouselOne">
                    <ngx-tile NgxCarouselItem>

                                <input type="checkbox" class="toggle">All

                    </ngx-tile>
                    <ngx-tile NgxCarouselItem>

                                <input type="checkbox" class="toggle">Electronics

                    </ngx-tile>
                    <ngx-tile NgxCarouselItem>

                                <input type="checkbox" class="toggle">Toys

                    </ngx-tile>
                    <ngx-tile NgxCarouselItem>

                                <input type="checkbox" class="toggle">Books

                    </ngx-tile>
                    <ngx-tile NgxCarouselItem>

                                <input type="checkbox" class="toggle">Clothing

                    </ngx-tile>
                    <ngx-tile NgxCarouselItem>

                                <input type="checkbox" class="toggle">Jewellery

                    </ngx-tile>
                    <ngx-tile NgxCarouselItem>

                                <input type="checkbox" class="toggle">Watches

                    </ngx-tile>
                    <ngx-tile NgxCarouselItem>

                                <input type="checkbox" class="toggle">Bicycles

                    </ngx-tile>
                    <button NgxCarouselPrev class='leftRs'><</button>
                    <button NgxCarouselNext class='rightRs'>></button>
                </ngx-carousel>

and in TS
public carouselOne: NgxCarousel;

    ngOnInit(): void {
        this.carouselOne = {
            grid: { xs: 0, sm: 0, md: 0, lg: 0, all: 200 },
            slide: 2,
            speed: 400,
            animation: 'lazy',
            point: {
                visible: true
            },
            load: 2,
            touch: true,
            easing: 'ease'
        }
}

and the output is the following:

There is white space on the right of each item.

The 'ngx-tile' component has 10px as padding by default.
Try to override the css or use 'ngx-item' which has no styling if it's possible for you.

I dont think padding is the problem here but width. I changed as you suggested to ngx-item but again there is too much space between the items.
Control's design is not ideal as the items should use all available space and you should not have to specify how many items must be visible in every size (s,m,lg etc..) . This is totally wrong.

@pantonis It looks like your are trying to have variable width tiles, i'm not sure this is supported.
Remember that is is a free component that cost you no time to implement, if you feel like contributing an improvement or modifying the functionality go ahead and make a fork.

there are two types of spaces in your image.
one is carousel tile padding
another one is inside the tile
currently, carousel does not support variable spaces. try to solve with the current implementation of the carousel
<ngx-tile NgxCarouselItem>

                     <input type="checkbox" class="toggle">Bicycles

</ngx-tile>

.myclass {
     width: 100%;
     text-align: center;
}

@iamlothian No I am not trying to have variable width with tiles. what I am saying is you shouldnt specify any size or how many number of items should be shown. This should be done handled by the control. Setting this number means might lead to problems like the screenshot I posted above.

@sheikalthaf Thanks for the control. You have done a great work.
I managed to solve it by setting width to auto on the ngx-tile directly. In this case depending on the text length of the item width is set. No empty spaces.
<ngx-tile NgxCarouselItem style="width:auto!important;padding:5px!important;">

                     <input type="checkbox" class="toggle">Bicycles

</ngx-tile>


Review (and if necessary, fix) JSON/YAML ser/de for custom TransformProcess

Idea: ensure that custom Transforms can be properly serialized/deserialized to/from JSON and YAML.

https://github.com/deeplearning4j/DataVec/pull/164


need help spawn packets instant disconnect

all timeout http://i.imgur.com/SbCTIoG.png

is the packets updated

and how did you mange too  connect to server

@Wartoz Agar.io has recently made many updates, stopping all unofficial clients. Agario-client is officially dead, you may try to use Agario-client2 if t still works.


Remove Petition.states_by_count

The method Petition.states_by_count was used for the counts in tabs and is no longer used anywhere so remove it.

cool

Yay, deletes!


Webconfig should indicate if keys have been loaded

If you load keys onto a device in the addons section, then reboot and go back to webconfig, there's no indication that keys have been loaded, just the ability to load new ones, like there aren't any to begin with. It would be ideal to have a way to confirm that keys exist before potentially overwriting them.

Hey @sgfdevices  - Good callout.  We will look into this.

I'm closing https://github.com/OpenStickCommunity/GP2040-CE/issues/245 as it seems to be dupe of this issue right here.

We could add an end-point that validates of PS4 keys are set to null or not. Or even /api/ps4AuthEnabled true/false?
That would probably do it, I might add this.

We are going to close this as not-planned.
We believe most people are using passthrough now and in order to have this shown in web-config we would need access to the keys which introduces complexities we are not comfortable with.


perfhistograms

add prometheus.perfhistograms=true (https://github.com/lightningnetwork/lnd/blob/master/sample-lnd.conf#L428) (and update lndmon chart?)

@nicolasburtey Is this still relevant? Here's the docs about the flag.

I dont really remember the context. closing it down.
one useful topic for prometheus is actually to prune the charts and remove all the one that honeycomb is fullfilling.


Host/Container IDs are reversed (I think)

I'm trying to map id 1001 in a container to 1000 on my host.
The web tool generates:
# Generated with Proxmox LXC idmap helper created by Stanisław Nieradko
lxc.idmap: u 0<PHONE_NUMBER>
lxc.idmap: g 0<PHONE_NUMBER>
lxc.idmap: u 1000 1001 1
lxc.idmap: g 1000 1001 1
lxc.idmap: u 1001<PHONE_NUMBER>5
lxc.idmap: g 1001<PHONE_NUMBER>5

However, this does not work. It's worth noting my host does not have a user with id 1001.
looking around, it seems like the ordering of the arguments to at least the second pair of idmap values are backwards. (lxc.idmap: u 1000 1001 1). https://www.reddit.com/r/Proxmox/comments/jz5ugx/lxc_user_mapping_help/ seems to indicate that the first value is the id for the container, and the second is is the id for the host. I also tried https://github.com/ddimick/proxmox-lxc-idmapper, and it seems to reflect this behaviour. Also, it's output works!
So it seems like if you are mapping one id to a different in the host, you need to swap the host/container ids to get a correct result.
root@proxmox:~# ./idmapper 1001=1000

# Add to /etc/pve/lxc/<container_id>.conf:
lxc.idmap: u 0<PHONE_NUMBER>
lxc.idmap: g 0<PHONE_NUMBER>
lxc.idmap: u 1001 1000 1
lxc.idmap: g 1001 1000 1
lxc.idmap: u 1002<PHONE_NUMBER>4
lxc.idmap: g 1002<PHONE_NUMBER>4

# Add to /etc/subuid:
root:1000:1

# Add to /etc/subgid:
root:1000:1

This is also the behaviour I get from this tool if I put the container ID in as the host ID, and vice versa, so it can generate the correct output, it's just the inputs are backwards.

Second this..  It seems to be generating them backwards to the examples in projects i am setting up.. not superhelpful when trying to understand the weirdness of subgids!

I created a PR for this. Feel free to use https://jo-me.github.io/proxmox-idmap-helper in the meantime.


docs: clarify reboot step

Minor clarification how to proceed when no reboot required. Context on this in chat with @jcrtp https://discord.com/channels/405159462932971535/1059705474540388402/1110657868488769657

:+1:


AMQP-630: Move dependency from Log4j to Log4j2

JIRA: https://jira.spring.io/browse/AMQP-630

Artem, I merged this too soon - we need to remove log4j.properties from the test resources and configure log4j2.xml.

Doh. Thank you for pointing that out. I will raise a new PR. Will hope the simple renaming will work: https://logging.apache.org/log4j/2.x/manual/configuration.html

Bear in mind, though that there is already a log4j2.xml in spring-rabbit (for the appender tests).

See #442 for configs migration.


Use new auth properties app and web

Is your feature request related to a problem? Please describe.
BankID now allows additional data about the device (app or web) to be sent to BankID as part of the auth and sign request. Actice Login should detect and send this information to BankID.

@elinohlsson The params app/web in the Auth- and SignRequests are optional, but are the properties inside these objects mandatory or optional? The API-specs does not say "required" for these properties, so i made an assumption that they are mandatory for now. BankId API Docs


Joseph Wagner - DS3 U3S1

Base goals

[ X]  Clear and descriptive commit messages
[ X]   Code is written by the student
[ X]   Code is organized and easy to read
[ X]   Code demonstrates understanding of underlying data/statistics concepts
[ X]   MVP Complete

Stretch goals

[ ] Exceeds accuracy and efficiency expectations of the assignment
[ ]   At least 1 stretch completed

Notes:
Good Job, following PEP8. Try to push yourself to create more functions in your code.


picking issue for non-fullscreen widget

https://github.com/uber/react-vis/pull/304
picking for scatterplot layer does not work in the above PR.
https://github.com/uber/deck.gl/blob/master/src/react/deckgl.js#L133
here x and y should be relative positions to the canvas, not screen coordinates.
will fix for v4.0.

Related to #248?


[WIP] Initial work

Please do not merge this pull request. It's still WIP
Alert! Use only on testnet4. Do not use on mainnet. Mainnet parameters are not adjusted except genesis block hash and Merkle Root hash.
What is done:

Changed chainparams.cpp testnet part according to SAPP mainnet consensus parameters. Some parameters in the SAPP code does not exist in KYAN code so omitted them.

Changed messaging pchMessageStart numbers

Changed ports for mainnet, testnet and regtest

Checkpoints copied from SAPP code

pszTimestamp and genesisOutputScript changed to match SAPP values

seed server addresses temporarily set. Will be changed when more nodes on testnet are set up on VPS servers

How to run
Always run the wallet with -testnet parameter. testnet=1 can be added to testnet4/pivx.conf file as well
After compilation, run the wallet once and then close the wallet.
After first run, testnet4 directory will be created under .pivx data directory.
Close wallet and extract the SAPP bootstrap into testnet4 directory.
Copy SAPP wallet.dat into testnet4 directory.
Run the wallet again with -testnet and -reindex parameters. Reindex will take a long time and may even not result (bug).
Todo

Replace pivx names with kyan from the code but not from the License notices.
Replace filenames pivx with kyan.

Closing because of complications.


Hotfix develop - Fix typo with space-before-bang docs

Develop hotfix for #355
DCO 1.1 Signed-off-by: Ben Griffith<EMAIL_ADDRESS>

Fantastic work!


Errors in order complete after review

Expected behavior:
Show ratings and  description in the review page
Actual behavior:
Rating is not showing in review and after submit he give me some error plz see in the screenshot
Version:
V3.0

Related: https://github.com/tastyigniter/ti-ext-user/commit/1423552df3ae9f2daa36110e776941afeb8a36ef

plz check issue after changing

Related: tastyigniter/ti-ext-user@1423552
plz check issue after changing


Fix migrate to bigautofield

Fix #410

Thanks @mom1 two questions:

Does this create a new migrations file?
If you were to first create a new migrations file right now without this PR (like many people may have already done in their virtualenv), then using this PR, would a new migrations still be needed?

Thanks for this!

For example if this pr include to 4.8.0

Fresh install 4.8.0 - No new file will be created.
4.6.0 -> 4.8.0 - No new file will be created.
4.7.0 -> 4.8.0 - If was created file 0009... and was applied to db befor update 4.8.0 then

need run python manage.py migrate 0008.
need delete file 0009... or reinstall djangorestframework-simplejwt
Else creating a new migration will be broken.

Thanks for the diagnosis @mom1 ! I think what this PR has is good, but we need to make sure the release doesn't break any production builds, too.
What we could do is create a new migrations file that is titled with a datetime (e.g. 0007_auto_20171017_2214.py; stupid of me not to double check these migration file names before argggg sorry), so something like 0009_auto_20210526_0101asdfh2jkfdu892.py since these prod databases have a migrations table that logs which migrations files were migrated and checks which files haven't. So even if these people create a migrations file titled 0009_auto_20210525_0101.py, we can add a migrations file for the next release that guarantees no conflicting file name by appending random letters (example from above 0009 example).
The remaining question is: we know for a fact that the user generated migrations file and the new file we're adding is the same, but will that break Django because they are the exact same? My intuition is saying "no," but obviously we'd need to test this.
Thoughts?

@Andrew-Chen-Wang  I understand your concerns.
But It seems to me that this problem cannot be solved now.
If the user created the file 0009_auto_20210525_0101.py, and we created the file0009_auto_20210526_0101asdfh2jkfdu892.py, then these files will have the same
dependencies = [
        ('token_blacklist', '0008_migrate_to_bigautofield'),
    ]

and the next time the migration is created, django will offer to create a third file with
dependencies = [
        ('token_blacklist', '0009_auto_20210525_0101'),
        ('token_blacklist', '0009_auto_20210526_0101asdfh2jkfdu892'),
    ]

@mom1 I'm assuming you're talking about the merge conflict and thus a new file that tries to linearize the migration history, right? Something like X_merge_X_auto_etc.py? Here's a different strategy:
We create a new migration file 0010_auto_*.py based on the deleted models.BigAutoField. This creates the conflict since both depend on 0008_auto_etc.py. So in addition we create a migration file 0011 that has no operations but linearizes the history. This file has to balance those who didn't migrate and those who did using their virtual environment, so 0011 looks like:
import os, fnmatch
from pathlib import Path

from django.db import migrations

parent_dir = Path(__file__).resolve(strict=True).parent

class Migration(migrations.Migration):

    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)
        self.dependencies = [
            ('token_blacklist', '0010_auto_20210527_1746')
        ]
        _m = sorted(fnmatch.filter(os.listdir(parent_dir), "000*.py"))
        if len(_m) == 9:
            self.dependencies.insert(0, ('token_blacklist', os.path.splitext(_m[8])[0]))

    operations = [
    ]

It looks quite unstable since we're using files to check, but I couldn't find a way to hack with SQL to the django_migrations table to grab which migrations had already been migrated. However, because of what was user-generated by 0009 migrations, we also have to do a bit of work in 0010:
# Generated by Django 3.2.3 on 2021-05-27 17:46

import os, fnmatch
from pathlib import Path

from django.db import migrations, models

parent_dir = Path(__file__).resolve(strict=True).parent

class Migration(migrations.Migration):

    dependencies = [
        ('token_blacklist', '0008_migrate_to_bigautofield'),
    ]

    operations = [
         migrations.AlterField(
             model_name='blacklistedtoken',
             name='id',
             field=models.BigAutoField(primary_key=True, serialize=False),
          ),
          migrations.AlterField(
              model_name='outstandingtoken',
              name='id',
              field=models.BigAutoField(primary_key=True, serialize=False),
          ),
    ]

Finally, we add those id fields directly back in otherwise another new file will be generated (token_blacklist.models):
id = models.BigAutoField(primary_key=True, serialize=False)
# This goes into both OutstandingToken and BlacklistedToken

So those three changes (two new files, and one changed file i.e. models.py) makes sure no new migrations file is needed. Sorry for not trying this out earlier; was just swamped by work. Let me know if you find anything errneous!
Note: I wrote all this code down here since I'd like for you to create a PR for it. I can't approve my own PRs, so your help is really appreciated!

Sounds great!
But, maybe can we still do without adding id fields in models?

@mom1 Unfortunately I tried it without adding and those migrating from 4.6.0 to 4.8.0 or who didn't migrate would need to create a new migrations file like those who did migrate on 4.7.0, so it's necessary.


_run_until_done is incompatible with Python 3.6

In commit 9f312ac3bbc9560ddeb9706e2754713af8ac01a2 the _run_until_done function was introduced.
This function calls asyncio.current_task() but that was only added to asyncio in Python 3.7 (see https://docs.python.org/3/library/asyncio-task.html#asyncio.current_task)
As a result, fsspec crashes if used with Python 3.6:
File "/usr/lib/python3.6/site-packages/fsspec/asyn.py", line 21, in _run_until_done
  task = asyncio.current_task()
AttributeError: module 'asyncio' has no attribute 'current_task'

Please could you change setup.py to reflect the new dependency on 3.7? e.g. something like this:
    python_requires=">3.7",

At the moment, pip install fsspec will install the latest version on a Python 3.6 system, which will then crash.

Can I ask which backend you were using? As it stands, only http uses this, of the builtin backends in fsspec.
Updating the python_requires wouldn't help, because the old versions would still be there (and I think you have the inequality incorrect). But we can fix it probably, using Task.current_task . Would you like to try that?

Updating the python_requires wouldn't help, because the old versions would still be there

Good point.

I think you have the inequality incorrect

Also true!

Can I ask which backend you were using?

I'm actually using s3fs, which has fsspec as a dependency.

But we can fix it probably, using Task.current_task. Would you like to try that?

Sure - if compatibility with 3.6 can be maintained, that would be even better. I'm happy to help test that.

I'm actually using s3fs

OK, makes sense. 'll get back to you with the change.

After a little trying, I cannot get this to work on py36. Please have a go, if you have any knowledge of this code!
In the meantime, we can explicitly say that async implementations don't work with py36 (but everything else does), and perhaps add an instantiation-time check into the async class, so that people installing in the future will know to downgrade fsspec or upgrade python.

I'm afraid I'm not familiar with this code. From the docs, it looks like you should be able to do asyncio.Task.current_task() until Python 3.7, and asyncio.current_task() from 3.7 onwards. I guess from your comment that it isn't that easy though!
An instantiation-time check sounds good though: at least then it would be clear what's going wrong, and that the solution is to downgrade fsspec or upgrade Python, without having spend time debugging.

Yes, but there are other lines following that also don't work.

An instantiation-time check sounds good though

Would you like to submit this?

I took a quick look at this code but it seems to require tox and conda, neither of which I have installed or used before. Conda looks like it's a whole new package management system, which isn't something I really want to install. Is there a simple way to run tests for this package without it?

Certainly - just call pytest in the source directory. tox and conda are used for the CI, but you don't need to worry about it for local development, you can use pip install -e ., or whatever you normally do.
(as an aside, I generally do recommend conda, but that's a whole other conversation)

Thanks, I got that working. However, I see that in fact you've already added appropriate version checks in #426. So I guess this issue can be closed now.

Of course, if you can solve it, that's even better! :)
Feel free to close, though.

If I ever have free time again, maybe I'll take a look at solving this properly :)


how was the add screenshots to the costume extension added?

We tried to look into how the scratch custom extensions and images blocks were added. But were not able to find the the structure on how the images block were added to the scratch?

I've described this in more detail at https://dalelane.co.uk/blog/?p=4846


monacoeditorwork is missing on prod build

After production build, there are no monacoeditorwork being created.

+1

+1  层主如何解决的？


upgrade to working nyc

nyc now has a signal-exit that should actually work.

Changes Unknown when pulling b5234d9d0547e05f9883f3af17978ddb783186b6 on nyc-upgrade into ** on master**.

Changes Unknown when pulling 9654072a730dfd827ea39ed35d9466ed8726bcc9 on nyc-upgrade into ** on master**.

Changes Unknown when pulling 9654072a730dfd827ea39ed35d9466ed8726bcc9 on nyc-upgrade into ** on master**.

Changes Unknown when pulling 33805eac0ba9219784db0b8f28a7663d7ee7f411 on nyc-upgrade into ** on master**.

Changes Unknown when pulling b07411fead3bebcab442d366f0663310836bd0ff on nyc-upgrade into ** on master**.

Changes Unknown when pulling e8eb0b45545c69a04b90ccd8c8e6c8eb3873bb72 on nyc-upgrade into ** on master**.

Changes Unknown when pulling e8eb0b45545c69a04b90ccd8c8e6c8eb3873bb72 on nyc-upgrade into ** on master**.


What to do?

Hi,
I'm new to this. So I tried running it, only under "https://some-rickroll-bro.com".
Is the generator supposed to make a new website ("https://some-rickroll-bro.com/") or something else?

I'm closing this issue as a result of a lack of activity.


How to use reveal modal efficiently in loop case ?

currently i have a page which loop data, and i use reveal modal to show confirm dialog of each row, as i do so far is loop the Delete and
modal content here

here is my loop data looks like
Delete

Are you sure ?

Wanna to delete id 31 category. This action can't be undone.

Confirm
×

Delete

Are you sure ?

Wanna to delete id 32 category. This action can't be undone.

Confirm
×

and so on

i think thus code is bloated and not efficient for me, so i am start thinking with jQuery.
maybe the code like this :
// put this code in  tag
$("a[data-reveal-id*='myModal']").click(function(){
var id = $(this).attr('data-reveal-id');
// generate reveal modal content here
// show reveal modal
});

i think with the above code, my script will less code and looks more efficient, since i only loop Delete because reveal modal content and show reveal modal already defined with javascript in the  tag.
But how i can generate reveal modal content and show reveal modal tottally with jquery. ?

lets say i have this
Delete
Delete
and so on

as i do so far
        $("[data-method]").click(function(e){
            e.preventDefault();
            var target_url = $(this).attr('href'); // Use this to get the URL to use on form
            var method = $(this).data('method');
            var modal_id = $(this).data('data-reveal-id');

            var modal = document.createElement('div');
            modal.setAttribute("id", modal_id);
            modal.setAttribute("class", "reveal-modal");
            modal.setAttribute("data-reveal", "");

            var modal_title = document.createElement('h2');
            var modal_title_value = document.createTextNode('Are you sure wanna to delete ' + modal_id + ' category ?');
            modal_title.appendChild(modal_title_value);

            var modal_close = document.createElement('a');
            modal_close.setAttribute("class", "close-reveal-modal");
            var modal_close_value = document.createTextNode('×');
            modal_close.appendChild(modal_close_value);

            modal.appendChild(modal_title);
            modal.appendChild(modal_close);

            $('#' + modal_id).foundation('reveal', 'open');
            alert('tes cok');
        });

if i click the link its show alert, but reveal modal not showing.
let me know whats wrong with my code ?

@gakimball
sorry tagging you. maybe you know whats wrong with my above code ?

What you're missing is a call to reflow. The Foundation JavaScript sweeps the page for plugins to initialize once, when the page loads. That means any new elements added to the DOM after the fact won't be recognized as plugins. You can tell the JS to find new plugins by calling the reflow method. Do this after your element has been added to the DOM:
$(document).foundation('reveal', 'reflow');


trigger('click') does not fire the click

I'm testing a new custom component which I created.
When clicking on arrow-img, the class active-menu should be moved from the first li to the second li.
My tests after trigger('click') suggest that nothing has changed as if the arrow-img hasn't been clicked.
expect(firstLi[0].element.className).to.equal('active-menu');
expect(secondLi[0].element.className).to.equal('');

arrowImg[0].trigger('click');

// These tests do not pass
expect(firstLi[0].element.className).to.equal('');
expect(secondLi[0].element.className).to.equal('active-menu');

And here is my component js
import jQuery from 'jquery';
window.$ = window.jQuery = jQuery;

// This contains jquery DOM manipulation
import {runjQuery} from './js/home';

require('nmodules/bootstrap-sass/assets/javascripts/bootstrap/collapse.js');

export default {
    created() {
        runjQuery(jQuery);
    },
};

As you can see, my component DOM is fully manipulated by jQuery.
Is this the reason trigger('click') has no effect on my component?
How do I fix it?

Hi, the component needs to have a render function that renders something for avoriaz to test the DOM. Alternatively, you can simply call mount with the option attatchToDocument: true and use a DOM testing library for your assertions.
Something like this:
mount(Component, {
  attachToDocument: true
})

$('.arrow').click()
expect($('li:first-of-type').hasClass('')).to.equal(true)


Validate synthetic Q&A pairs.

Description
Synthetic data needs to be validated and washed prior to sending it through the training pipeline

Added validation for Replicate datasets. Need to do the same for OpenaI

Fixed in #32


Refactor Hero Component

Describe the desired behavior
The Hero component currently takes in a handful of props that we just pass through for the ChannelValue child including fontSize, value, units, valueIcon, and valueColor. This becomes an issue when updating the ChannelValue props as the Hero component props would need updated as well;

Refactor the Hero component to take in a ChannelValueProps prop that passes all ChannelValue props through to the ChannelValue child element
Update Hero storybook stories to work with the new syntax
Add deprecation warnings.

Is this request related to a current issue?
No.
Additional Context

https://github.com/brightlayer-ui/react-component-library/pull/386 is merged. Closing this issue.