Don't want to have unit tests named testFail

Problem
There are a few unit tests names testFail* which means it passes even though it fails. we need to remove Fail from those functions

So we need to check every testFail function and rename those that are problematic or rename all of the functions?

So we need to check every testFail function and rename those that are problematic or rename all of the functions?

right

may I take this one?

@rndquu I see that PR was linked and unlinked.
@pavlovcik @0xcodercrane Whether this issue is actual?

@rndquu I see that PR was linked and unlinked.
@pavlovcik @0xcodercrane Whether this issue is actual?

Perhaps there was a deleted comment because I don't see what you're quoting.

@rndquu please share your wallet address here

@rndquu please share your wallet address here

0x336C033842FA316d470e820c81b742e62A0765DC

@rndquu please share your wallet address here

0x336C033842FA316d470e820c81b742e62A0765DC

https://etherscan.io/tx/0xddbf6b4244ba2330780e5d3179fcbcf815421c57ed511ba7440922e91c94312f


Create separate [ S * O ] index class for case where there is only one predicate

This would save the overhead of storing a full reference for the one integer.

Thanks a lot to @kolarm for the suggestion.

If adding/removing a vertex should create issues, then always having the Int on the class would still be more efficient than paying for the boxing, given the huge number of instances that have only 1 predicate.


Emoji didnt change

Hey Guys, i'm new in GitHub. My issue ist that the Emoji didnt change after  installing and rebooting. For example in Snapchat they didn't change:/
So I'm currently on a Custom ROM on the 8 Pro. Any guesses why it didn't work🤔
Thanks in advance

It didn't change only for Snapchat or overall? I don't use Snapchat, does it use custom emojis?

In Gboard it did change, but typing it in Snapchat it still shows the android stock emojis.
I'm on the Corvus ROM for the OnePlus 8 Pro.
Where can I see if Snapchat uses custom emojis🤔

@Umberto1973 By any chance, do you have Snapchat on your Denylist?

Yeah I got it on m deny list and cleared the cache, but it didn't work, maybe ist an A12 thing...

@Umberto1973 for Emoji's to work on Snapchat, Snapchat needs to be removed from the DenyList

Oh I thought it has to be in the deny list. Wait, what deny list are we talking about? The one from magisk right🤔

Yep the one in Magisk


Retry timed-out tasks locally

The naively-looking approach works surprisingly well.
Credits: @nvartolomei
Closes: #62

Seems fair enough!


Append to existing tree in array2root

Hi,
while working on a pandas wrapper for root_numpy (https://github.com/ibab/root_pandas) I noticed that array2root doesn't properly append to existing TTrees: the file just gets larger and larger, but only the last saved version of the tree is accessible.
import numpy as np
from root_numpy import root2array, array2root

arr = np.array(np.array([1,2,3]), dtype=[('test', '<i8')])
array2root(arr, 'test.root', 'default')
array2root(arr, 'test.root', 'default')

x = root2array('test.root', 'default')
print(x)
# prints [1,2,3] instead of [1,2,3,1,2,3]

As far as I can tell, this can be fixed by looking for an existing tree and passing it to array2tree.
What do you think?

Coverage remained the same when pulling ec92275f5db3b11366ab95e64eaeb74a4706c0bc on ibab:master into ecdda0cc45a438a388349ed70a452db0696c104d on rootpy:master.

I believe array2root is a single output file, when you run it twice, it
creates two outputs, the second overwriting the first. I've never used it
for streaming purposes.
On Sun, Jan 18, 2015 at 17:08 Coveralls<EMAIL_ADDRESS>wrote:

[image: Coverage Status] https://coveralls.io/builds/1764223
Coverage remained the same when pulling ec92275
https://github.com/rootpy/root_numpy/commit/ec92275f5db3b11366ab95e64eaeb74a4706c0bc
on ibab:master into ecdda0c
https://github.com/rootpy/root_numpy/commit/ecdda0cc45a438a388349ed70a452db0696c104d
on rootpy:master.
—
Reply to this email directly or view it on GitHub
https://github.com/rootpy/root_numpy/pull/166#issuecomment-70431197.

It depends on the mode you pass to array2root.
The default is 'update', which allows you to append to the file.
The file is overwritten when passing mode='recreate'.

A wrapper for pandas! Nice!
Yes, array2root just writes out a file and will overwrite an existing file (the mode keyword argument can be used to update an existing file, but a tree with the same name would just be "overwritten").
Use array2tree instead of array2root. array2tree will extend an existing tree:
315 def array2tree(arr, name='tree', tree=None):
316     """Convert a numpy structured array into a ROOT TTree.
317
318     .. warning::
319        This function is experimental. Please report problems.
320        Not all data types are supported (``np.object`` and ``np.float16``).
321
322     Parameters
323     ----------
324     arr : array
325         A numpy structured array
326     name : str (optional, default='tree')
327         Name of the created ROOT TTree if ``tree`` is None.
328     tree : existing ROOT TTree (optional, default=None)
329         Any branch with the same name as a field in the
330         numpy array will be extended as long as the types are compatible,
331         otherwise a TypeError is raised. New branches will be created
332         and filled for all new fields.

Although, this would be a nice feature to add. I think we should enable growing an existing TTree with array2root also. But for now, array2tree should do the job.

Checking the diff and will merge.

@ibab what version of Cython did you run? 0.21.2?

(Sorry, originally thought this was an issue report, but then realised it is a pull request!)

I think I ran 0.21, but I could rerun with 0.21.2.

Great, yes better to use the latest. Then I will merge.

Coverage remained the same when pulling 3ac793629edbcfe4f2c6ad54054c4f51297f6d40 on ibab:master into ecdda0cc45a438a388349ed70a452db0696c104d on rootpy:master.

Ok, I ran 0.21.2 and amended the commit.

thanks!

Thanks! That will make stream processing of ROOT files very convenient.
And I can use array2tree in my wrapper until the next version of root_numpy is released.

3.4.0 is released: https://pypi.python.org/pypi/root_numpy


[engsys] Release Pipeline check for prerelease package dependencies

Today it's easy to accidentally GA an SDK that still has a runtime dependency on a pre-release package. It would be great if part of our release pipeline checks verified that direct dependencies of GA packages are also GA.
Example: For a package "@azure/foo" that depends on "@azure/bar": "1.0.0-beta.1", the release will be blocked unless "@azure/foo" is also using a pre-release version number.

@xirzec: Would you extend this to transitive dependencies?  I would, with an exception mechanism when needed.

@xirzec: Would you extend this to transitive dependencies? I would, with an exception mechanism when needed.

Yeah, if it didn't generate too much noise. Maybe start with direct deps and then experiment with going deeper?


Items @DClick works even with bankbox closed

If you link an assistant like razor to an item's serial inside your bankbox, that item can be used (DClick) even if the bankbox is closed and your position is different from the MOREP of the bankbox layer. The item cannot be moved nor you can add items to the container, but they can be dclicked.
Fast way to replicate:

Use ClassicUO client
Open your bankbox
Open a bag inside the bankbox with some bandages or potions inside
Move away. The bankbox will close but the bag will remain open.
Interact with objects inside the bag, like drinking a potion or bandageself anywhere in the world. ^^

Don't know if could be of any help... but CANSEE always returns 1 with objects inside bankbox.

I have temporarly fixed the issue this way:
//put this inside your main event for players
ON=@ItemDClick
	IF ( <ACT.CONT.UID> != 0)
		IF (!( <I.P.X> == <I.FINDLAYER(29).MOREX> ) || !( <I.P.Y> == <I.FINDLAYER(29).MOREY> ) || !( <I.P.Z> == <I.FINDLAYER(29).MOREZ> ))
			IF ( <I.FINDLAYER.29.f_find_inside_bankbox <ACT.UID>> )
				I.SYSMESSAGE You can't reach that.
				RETURN 1
			ENDIF
		ENDIF
	ENDIF

[FUNCTION f_find_inside_bankbox]
REF1=<ARGN1>
FORCONTID <REF1.BASEID> 10
	IF ( <UID> == <REF1.UID> )
		RETURN 1
	ENDIF
ENDFOR
RETURN 0

I know it's a bit rough, but it just need to work until the issue will be fixed server-side. ^^'

Are you sure you tried with player character? Because I tried it player character and I can't dclick items on bankbox.

mmm, that way you are going to check only items directly inside the layer bankbox... not items inside nested containers

@pentanorl  here you are again more enhanced for @xwerswoodx and less complex than yours.
On=@ItemDClick
ref1=<act.topcont>
IF (<ref1.TYPE> == t_eq_bank_box) && !(STRMATCH('<P>', '<ref1.MOREP>'))
	SYSMESSAGE You can't reach that.
ENDIF

[FUNCTION topcont]
if (<cont.isitem>)
	return <cont.topcont>
else
	return <uid>
endif

Oh okay, I got you now;
Here is a solution without causing any crash;
REF1=<ACT.TOPCONT>
IF (<REF1.TYPE> == t_eq_bank_box) && !(STRMATCH('<P>', '<REF1.MOREP>'))
	SYSMESSAGE You can't reach that.
ENDIF

[FUNCTION topCont]
REF1 = <UID>
WHILE (<REF1.CONT.isCont>) && !(<REF1.CONT.isChar>)
  REF1=<REF1.CONT>
ENDIF
RETURN <REF1>

Just improved @GitMadKing's solution with WHILE loop.

I just tested it and i tell a little example:

I put 300 potion in a bag inside bank
I save serial of this item in any assistant script tools
Go to farming mob
Play script from assistant do a Useitem on serial of potion in bankbox
Tadannn.. i can use from bankbox totally safe and no need have it in backpack.

This can do for all item have Use function (potion, bandage, scrolls, ecc ecc)

Same here. It's a script fix or a core fix?

@pentanorl here you are again more enhanced for @xwerswoodx and less complex than yours.
On=@ItemDClick
ref1=<act.topcont>
IF (<ref1.TYPE> == t_eq_bank_box) && !(STRMATCH('<P>', '<ref1.MOREP>'))
	SYSMESSAGE You can't reach that.
ENDIF

[FUNCTION topcont]
if (<cont.isitem>)
	return <cont.topcont>
else
	return <uid>
endif

hope no one dclick an item nested in 351 containers #418 -.-'

sadly there are people who find entertaining do everything imaginable to cause problems... and I don’t know if you noticed, but you can nest even containers of the same type. I haven’t checked how many levels, but I got tired trying after a few dozen of bags inside bags, so I had to put a check to prevent nesting containers with same baseid.
Anyway thanks for the Topcont tip, I haven’t scripted anything in the last 5 years and I forgot a lot of stuff. Still recovering memories and removing rust. ^^’

just use @xwerswoodx with while and no problem

Anyway i think can use item from bankbox (away from bank) is a core issue.

far from my intentions to look pedant, but as anticipated, the fix with STRMATCH won't work. Tried right now and it prevents you to use anything in your bank even if it's properly open. And in the itemdclick trigger there's a RETURN 1 missing.
So, here there's a mix of what came out from this topic, I've tested it right now and works as supposed to:
ON=@ItemDClick
	REF1=<ACT.f_topcont>
	IF (<REF1.TYPE> == t_eq_bank_box) && (!( <I.P.X> == <REF1.MOREX> ) || !( <I.P.Y> == <REF1.MOREY> ) || !( <I.P.Z> == <REF1.MOREZ> ))
	  SYSMESSAGE You can't reach that.
	  RETURN 1
	ENDIF

[FUNCTION f_topcont]
REF1=<UID>
WHILE (<REF1.CONT.ISCONT>) && !(<REF1.CONT.ISCHAR>)
  REF1=<REF1.CONT>
ENDIF
RETURN <REF1>

Yeah we forgot to set RETURN 1 value :)) Also STRMATCH not working because we need to use double quotes for the words including commas.
ON=@ItemDClick
	REF1=<ACT.f_topcont>
	IF (<REF1.TYPE> == t_eq_bank_box) && !(STRMATCH("<P>", "<REF1.MOREP>"))
	  SYSMESSAGE You can't reach that.
	  RETURN 1
	ENDIF

[FUNCTION f_topcont]
REF1=<UID>
WHILE (<REF1.CONT.ISCONT>) && !(<REF1.CONT.ISCHAR>)
  REF1=<REF1.CONT>
ENDIF
RETURN <REF1>

should work fine, anyway you can check one by one but I don't suppose to use 3 more check.

I'll try with the double quotes ;)

[FUNCTION bt]
if (STRMATCH("<FINDLAYER.LAYER_BANKBOX.MOREP>", "<P>"))
  RETURN 1
ENDIF
RETURN 0

I tried it with that function and works fine for me.

yep, I confirm, with double quotes, works as supposed to.

Hi,
Try enabling EF_FixCanSeeInClosedConts.

@JulianUO make test whit EF_FixCanSeeInClosedConts flags, but nothing change if send a useitem keep use if item is in bank and i'm away and bank close.

Work a+ for me

I confirm too, Fix work very good :) thx

I add some details but half fixed:

Targer is Bandage.

If bandage outside container in main bank box problem fixed:
This situation OK:

If move bandage inside a subcontainer:

Still bugged, CAN use item away from bank whit bank closed.

items contained by containers inside the bank are still dclickable.

https://www.dropbox.com/h?preview=UO+-+Bruteforce+--++0+0+0+0+0+0+0+0+497+2020-04-27+23-20-26_Trim.mp4

https://www.dropbox.com/s/r7vx6mn33wijwip/UO - Bruteforce --  0 0 0 0 0 0 0 0 497 2020-04-27 23-20-26_Trim.mp4?dl=0

https://www.mediafire.com/file/null/SphereSvrX64_nightly.rar/file
Could you test it with that version? I did some changes but I need to make sure before pull request.

I try to download but:

Something appears to be missing…
The key you provided for file access was invalid. This is usually caused because the file is no longer stored on MediaFire. This occurs when the file is removed by the originating user or MediaFire. Still have questions, or think we've made a mistake? Please contact support for further assistance.

Yeah sorry the copy link works bad on website, here is the correct link;
https://www.mediafire.com/file/1uls29llqyri55b/SphereSvrX64_nightly.rar/file

Hey! I tested to send packet useitem for subcontaier item also, and is fixed! Good Work

Thank you for information, I will pull the request after I finished to work on other issues.


Update LlllbinParseInfo.cs

Data length error for LLLLBIN.

Closing this PR since there is no unit test. You can reopen it whenever you properly add a unit test


Added grid

Grid is activated with age style

Split off the latex activation from the mplstyle "age", so that it can be used without latex installed.
Latex can now be used with the "tex" mplstyle.


simply JUPYTERHUB_HTTP_REFERER=https://openscapes.2i2c.cloud/

Hi @betolink ,
This should be what we need on the quarto side!

Thank you!


Create data pipeline for v4 variants

Create a data pipeline for gnomAD v4 variants.
Much of the v3 pipeline can probably be reused, but exome data will need to be added and joined to genome data.

Close by #1178


Add Red Hat Enterprise Linux images

From the 01/Feb/2020, RHEL will be for free for 16 devices for "small production workloads". Link
So it would be nice to have RHEL 8 template for using.

It certainly would not be nice. RHEL is not free software and what they have just showed us is a perfect example of "embrace-extend-extinguish", which should not be tolerated by anybody, much less by open community, such as vpsFree.cz.


Merge in changes to upstream manylinux project

@vitaly-krugl - Please review when you are back to make sure I handled the changes correctly. I needed to do this because the openssl link that was being relied on had changed and no longer worked.

I can't get this to work, too many things seem broken now so would take more time then I have at the moment.


System auth cache

Addresses: https://nanopay.atlassian.net/browse/NP-4696
Added to improve performance on the system auth service decorator.
Previous comments - https://github.com/kgrgreer/foam3/pull/434

@zahnno also we need access to this check from other auths and outside the auth - LoginAttemptServiceAuth for example sets the clustering flag based on this check.   Perhaps an isAdmin can do the group test, then check can call that, then isAdmin is available elsewhere.   Open to other ideas.

@jlhughes Checking another user's admin privilege would be the equivalent of auth.checkUser.(context, user, ””); and for the current context user - auth.check(x, "");
The reason group implies is called and cached here is to avoid having to go through all the decorated auth check logic for every request from an admin "*" user - It's a shortcut.

Where you going to add the default super group setup with 'admin' and 'system'?

Where you going to add the default super group setup with 'admin' and 'system'?

there's a condition checking system_user_id within the system auth


Type imports

The following PR is designed to allow for splitting bolt rule definitions into multiple files. This should enable a few extra features in the bolt ecosystem including:

Allow for re-usable types such as simple validation through publicly available bolt modules.
Code which is easier to read.

This has been requested by the community for some time (https://github.com/firebase/bolt/issues/63) and this is a second re-write of the original gulp-firebase-bolt plugin with a more ES6 spec. It is a complete end-to-end integration covering the parse & compiler.
I have explicitly left functions and paths out of this release as I'm running out of time to implement all of that. Not withstanding this there is value in the PR as is.
Example usages include:
import * from './module' // import everything from sub module.
import * as types from './module' // import everything under the 'types' namespace
import {Foo} from './module' // only import specific types
import * from 'module' // global imports
type Bar is Foo {
}
Example usages include:
import * from './module' // import everything from sub module.
import * as types from './module' // import everything under the 'types' namespace
import {Foo} from './module' // only import specific types
import * from 'module' // global imports
type Bar is Foo {
}
Documentation has been updated to include the new spec, tests should be parsing and a sample has been added. An additional fix to the master branch has been cherry picked from https://github.com/firebase/bolt/pull/209
Comments are welcome:
Cheers,
Jason
Brew Software.

Please guys merge this. My current workflow concatenates files :/

I could really use this feature as well


⚠ Bofrost.lu has degraded performance

In 721dd0d, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1564 ms

Resolved: Bofrost.lu performance has improved in 7c40316 after 46 minutes.


Added Partial to setParams

You might not want to update all params?
I'm open to discussing this as I don't know if this was intentional or not :)

Hi @Titozzz
The NavigationParams interface seems already flexible enough to me, and not sure what you expect adding Partial will provide (
To me this won't change anything, do you see any case that might differ before/after? I've made a playground here: http://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=18&pc=36#code/JYOwLgpgTgZghgYwgAgHJwG7AOZzMAexAAU4o4BbAZ2QG8AoZZAbQGsIBPALmSrClDYAujzggOAbnoBfevQRE+vCGFLlqARmQBeZAAoADmUpUA-D3RZc+ImpMBKHQD46yWQpBKqKu9QBMOvpG6mY8avhwADYAPJY4eIQkxtROjtoutG5y3qrJVBp69lI5vlR+hVL0JXkFtNJFVT555XUNjbkhtVQEFBC+PBr1xU0hLd29-ciDbdWderTjfck8AK4gACYQMKAQ60PtpWM9S+qrG1s7e0VAA

Maybe the fix is wrong.
http://www.typescriptlang.org/play/#code/JYOwLgpgTgZghgYwgAgHJwG7AOZzMAexAAU4o4BbAZ2QG8AoZZABzMoEEAuZKsKUbABpGLNhQBC3EAFcKAI2j0AvvXoIivHhDCly1AIzIAvMgAUrPVQD83dFlz4iuylQCUxgHx1kK9SE1U2s7UAEzGZhYuNsi6+HAANgA8djh4hCRiVB7uRl60PqqBOpn6pq4A3PRFwVQhZZVVQSWmtJEUXMgA5AAWEPHxBJ1KFY3FlnWtYh09fQNDI6M1pZN60739g4KiepLIIQDMw5XVmRNta7Ob25S7B0dAA
Is the issue I was facing.
TLDR: I want to update only one of the defined params

But I didn't check where the generic is used so I'll have another look

The file I'd need to be updated is @react-navigation/core/lib/typescript/types.d.ts
I'd need setParams to be setParams(params: Partial<ParamList[RouteName]>): void;
export declare type NavigationProp<ParamList extends ParamListBase, RouteName extends keyof ParamList = string, State extends NavigationState = NavigationState, ScreenOptions extends object = {}, EventMap extends Record<string, any> = {}> = NavigationHelpersCommon<ParamList, State> & {
    /**
     * Update the param object for the route.
     * The new params will be shallow merged with the old one.
     *
     * @param params Params object for the current route.
     */
    setParams(params: ParamList[RouteName]): void;
    /**
     * Update the options for the route.
     * The options object will be shallow merged with default options object.
     *
     * @param options Options object for the route.
     */
    setOptions(options: Partial<ScreenOptions>): void;
    /**
     * Returns the parent navigator, if any. Reason why the function is called
     * dangerouslyGetParent is to warn developers against overusing it to eg. get parent
     * of parent and other hard-to-follow patterns.
     */
    dangerouslyGetParent<T = NavigationProp<ParamListBase> | undefined>(): T;
    /**
     * Returns the navigator's state. Reason why the function is called
     * dangerouslyGetState is to discourage developers to use internal navigation's state.
     * Note that this method doesn't re-render screen when the result changes. So don't use it in `render`.
     */
    dangerouslyGetState(): State;
} & EventConsumer<EventMap & EventMapBase> & PrivateValueStore<ParamList, RouteName, EventMap>;

setParams(params: Partial<ParamList[RouteName]>): void; seems better to me yes, as it's shallow merged we could only ask the user to pass partial params

Hey @Titozzz! Seems like you're using v5. This is not the correct repo. The code is here https://github.com/react-navigation/navigation-ex

🤦♂


bugfix: specify both cmd and its args when create a container

Signed-off-by: YaoZengzeng<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1027 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
- Coverage   14.21%   14.21%   -0.01%
==========================================
  Files         127      127
  Lines        8474     8475       +1
==========================================
  Hits         1205     1205
- Misses       7169     7170       +1
  Partials      100      100

Impacted Files
Coverage Δ

daemon/mgr/cri.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec48e96...9982898. Read the comment docs.

Please provide more details about this pull request in pull request description. @YaoZengzeng
Thanks a lot.

@allencloud PTAL

With this PR, the node-e2e test result will be:
Ran 186 of 258 Specs in 1501.814 seconds
FAIL! -- 146 Passed | 40 Failed | 0 Pending | 72 Skipped
exciting 😄

LGTM


make FA5 brand icons work on Android

Use Brands for Android and Regular for rest.
Closes #983.

While it is working it is a little breaking for the PostScript name on Android, it works now but might break so I changed it to work the same on both platforms 🙂


Add Smile Hall by agent26105

Song Name
Smile Hall
Artist Name
agent26105
Source
Youtube
Youtube Link
aGTxyxnUeSJytXBb
Direct File Link
No response
Song ID
1266014
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 108780575

reject
invalid YouTube link


Powertoys run does not find certain programs

Environment
Windows build number: 10.0.18362.836
PowerToys version: 0.8.1
PowerToy module for which you are reporting the bug (if applicable): run
Steps to reproduce
Install Evernote. Search for Evernote.
Expected behavior
Evernote app should be in the list.
Actual behavior
Searching for Evernote shows only the EvernoteClipper in the list.
Screenshots

Search bar/box shows the app in results:

Similarly “File Explorer” cannot be fount.

I have the same problem. I have µTorrent and if I write torrent (or Torrent, doesn't matter) - it doesn't find the app.

We are aware of this issue and currently being tracked in #3223. Closing this as a duplicate.


Loop

Initial Check

If the issue is a request please specify that it is a request in the title (Example: [REQUEST] more features). If this is a question regarding 'twint' please specify that it's a question in the title (Example: [QUESTION] What is x?). Please only submit issues related to 'twint'. Thanks.

Make sure you've checked the following:

[] Python version is 3.6; done
[] Updated Twint with pip3 install --upgrade -e git+https://github.com/twintproject/twint.git@origin/master#egg=twint; done
[] I have searched the issues and there are no duplicates of this issue/question/request. done

Command Ran
from __future__ import print_function
import os
import sys
import subprocess
import datetime
import twint
import pandas as pd
usernames = ["chrislhayes"]
colrn     ={0:"id",1:"date",2:"time",3:"username",4:"tweet",5:"replies",6:"retweets",7:"likes",8:"user_rt",9:"hashtags"}

for u in usernames:
    c = twint.Config()
    c.Username = u
    c.Store_csv = True
    c.Timedelta = 1
    c.Since = "2016-01-01"
    c.Store_csv = True
    c.Custom = ["id","date","time","username","tweet","replies","retweets","likes","user_rt","hashtags"]
    c.Output = u+".csv"

    # Run
    twint.run.Search(c)
    df = pd.read_csv(u+".csv")
    df["accountName"] = u
    df.to_csv(u+".csv",index=False)
    print(out)

Description of Issue

I get stuck in an endless loop (I posted a video in the Slack, wasn't sure if I was supposed to).

Environment Details

ubuntu 16.04

Hi @SeanMcElwee ,
I do not find your video on Slack, may you provide me a link to it?

Yes. Apologies for the delay. @pielco11 Does this work? https://drive.google.com/file/d/1j6NSqu_S591Ks5Qxn0mw7CPpUmIjNz_X/view?usp=sharing

The video did not load for me, either, but I was able to download and view it locally by clicking the download button.  The video seems to show terminal output of a series of eight or so tweets being downloaded endlessly.  Not much else is discernible.

I tried the query and Twint does not replicate the issue. I suppose that's not related to Twint, so I'm closing this


qemu: Invalid parameter 'obsolete'

I'm running into the following issue with a lxc start on a virtual-machine:
$> lxc start LF3eb234f5-66ff-4592-9436-4ff0c772c250
Error: Failed to run: /usr/bin/lxd forklimits limit=memlock:unlimited:unlimited -- /usr/bin/qemu-system-x86_64 -S -name LF3eb234f5-66ff-4592-9436-4ff0c772c250 -uuid 9cb93712-2808-41f3-8687-8d62caef7b77 -daemonize -cpu host -nographic -serial chardev:console -nodefaults -no-reboot -no-user-config -sandbox on,obsolete=deny,elevateprivileges=allow,spawn=deny,resourcecontrol=deny -readconfig /var/log/lxd/LF3eb234f5-66ff-4592-9436-4ff0c772c250/qemu.conf -pidfile /var/log/lxd/LF3eb234f5-66ff-4592-9436-4ff0c772c250/qemu.pid -D /var/log/lxd/LF3eb234f5-66ff-4592-9436-4ff0c772c250/qemu.log -chroot /var/lib/lxd/virtual-machines/LF3eb234f5-66ff-4592-9436-4ff0c772c250 -runas nobody: qemu-system-x86_64: -sandbox on,obsolete=deny,elevateprivileges=allow,spawn=deny,resourcecontrol=deny: Invalid parameter 'obsolete': exit status 1
Try `lxc info --show-log LF3eb234f5-66ff-4592-9436-4ff0c772c250` for more info

(lxd/instance/drivers/driver_qemu.go)
The server is on debian 9 (so debian oldstable), and the distro-packaged qemu with the following version:
$> qemu-system-x86_64 --version
QEMU emulator version 2.8.1(Debian 1:2.8+dfsg-6+deb9u9)
Copyright (c) 2003-2016 Fabrice Bellard and the QEMU Project developers

I can't find in which version the parameters to sandbox where introduced in QEMU, but in the packaged version, it only accepts on or off.
There's no real solution for this, besides:

Make a more intelligent code that works with the qemu version (Might be useful in the future too)
Removing the sandbox arguments in order to comply with older systems
Not supporting virtual-machines without at least a XX.XX qemu version.

Any of these will work for me.

We should put out a statement in documentation about the version of qemu we support and test on.
The version we actively develop/test on and ship with the snap is Qemu 4.2 but we also have systems running on 2.11 so we're unlikely to completely break 2.11. Versions prior to that should be considered unsupported.
I don't think we'd reject a pull request to do version detection to handle older versions, but we're realistically not going to be testing on old versions to make sure we don't break things again later.


Roll back release of validation library on staging

Metadata validation library has broken the entering of metadata

Not needed


Switch on key paths.

@swift-ci Please smoke test

Is there value in keeping the flag?

@slavapestov If something goes horribly wrong and we have to turn it off, perhaps, but from a churn-minimization standpoint it also seems better to turn the switch on first then pull it out.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test


Other Project Planning prerequisites

Requesting other members of the team to add any additional Project Planning steps you can think of to complete before the milestone can be considered reached. I know captus was possibly thinking about some others in particular. Thanks guys!

The only other thing I can think of is researching the hex grid implementation itself.
It turns out if you model a 3D grid projected onto a 2D surface you can create a hex grid where each tile has a unique (x, y, z) address (1-to-1 mapping).

http://www.redblobgames.com/grids/hexagons/ is a really useful resource I've been looking at.
Right now I'm thinking that using the axial coordinate system about a quarter of the way down the page looks like a great option, but I'll continue checking it out.

The advantage of the axial system is you can manage a cube-like coordinate system with only two coordinates (axes) as the third coordinate is implied. For instance, if x==1 and y==2, z==-3 as the three must add up to zero.


Increase user clock measurement delay

Increase delay before measuring user clock after changing frequency. The previous delay was a bit short, leading to measurement errors.
Correct naming of DELAY time macro units from ms to us.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
15 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.06%) to 73.652%

Files with Coverage Reduction
New Missed Lines
%

libraries/plugins/xfpga/open.c
1
74.68%

libraries/plugins/uio/opae_uio.c
4
90.18%

libraries/plugins/vfio/opae_vfio.c
4
85.13%

libraries/plugins/xfpga/mmio.c
6
82.87%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
15741

Relevant Lines:
21372

💛  - Coveralls


fix: table Creator - Web design #24 #375

Created a table according to the given image in the issue section

Please review my changes @NtemKenyor

Please take a look at my pr @NtemKenyor

Please take a look at my pr @NtemKenyor

Please sorry for the delay, Trying to cope with work man..

thanks for merging @NtemKenyor


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/25214

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.


[Coverage] Add counters for performance evaluation

This should help investigate performance issues (like r://39332957).

@swift-ci Please smoke test

@slavapestov Counters are less of a mess than timers. You can use either counter subsystem (the LLVM one or the UnifiedStatsReporter one). In an assert build the USR one merges-in all the LLVM counters and reports them to the stats-dir file. In a release/no-assert build the USR ones are the only ones that exist: LLVM ones are compiled-out. Pick whichever one you want based on whether you want field reports from shipping compilers to be able to include them.

Thanks for the feedback -- it does seem worthwhile to have these counters in release builds.

@vedantk Are you still interested in this after #15909 and Graydon's driver improvements?

This needs to be reworked to use the USR. I'll set it aside for now.


where is the script/config.js

Hi ckken, which config.js file are you referring to?
if you're referring to config.xml, cordova.js or cordova_plugins.js then it's to be placed on the root of your project...
Hope this helps.
Jose
ex.
/
/img
/css
/js
/plugins
/com.dooble.phonertc
/src
/browser
PhoneRTCProxy.js
/www
phonertc.js
config.xml
cordova.js
cordova_plugins.js
index.html
...

You need to install Grunt CLI and perform the Grunt build action to build many files, including the config.js.


Allow using videos as screenshots

Both a bug fix and an enhancement.

Bug fix: the readme parser doesn't include jpg in the screenshot regex, resulting in many screenshots being unavailable in the options window.
Enhancement: .mp4 and .mov videos are now supported in the options window. In fact, select-notifications already uses a video as the screenshot.

$ rg --only-matching --replace '$1' 'user-images.+\.(\w+)\)$' readme.md | sort -u
gif
jpg
mp4
png

Test URLs
chrome://extensions/?options=balgliakcbamepammkbcjdepogihccmj
Screenshot

@kidonng the two image links (1, 2) in which you changed the file extensions to lowercase (.PNG --> .png)
have become broken. I believe they should remain in uppercase.

I believe they should remain in uppercase, as they were.

Or we could just re-upload the screenshots, for consistency and ease of parsing.

Yes, that would be the best.

Adding a note here: .mp4 videos are preferred because their URLs can opened and played directly in the browser. .mov's URL only downloads it.


More missing bindings to File, add util

This is also probably going to need a sprinkling of #include <nanobind/stl/optional.h> I'm guessing

This is also probably going to need a sprinkling of #include <nanobind/stl/optional.h> I'm guessing

I did so in bindings.h :-D


Router->register() / $additionalAttributes correct?

I'm having the following situation, a route I'd like to map:
Route::register('/ccm/my_package/dialogs/my_dialog/{optional_parameter}', '\Concrete\Package\MyPackage\Controller\Dialog\MyDialog::view'));

However, I'd like to allow both of these requests to the controller:
/ccm/my_package/dialogs/my_dialog/custom_parameter (with parameter)
AND
/ccm/my_package/dialogs/my_dialog (without parameter)
This is not currently possible with a single route definition because of how the default attributes are set in core currently:
https://github.com/concrete5/concrete5-5.7.0/blob/e89ef659be2cc7de811aa4b95a61bbfd0329db36/web/concrete/src/Routing/Router.php#L45
Just asking whether the $additionalAttributes is passed correctly to the new Route object.
Asking because the variable named $additionalAttributes is currently passed as the third argument to the Symfony\Component\Routing\Route object which is equal to $requirements there.
Naming of the variable seems to be a bit off if this is intentional. Should that rather be merged with the $attributes array, so that developers could pass in custom attributes there?
And additionally, should we also allow passing the other parameters ($requirements, etc.) to the Symphony's route object? As per the constructor definition:
https://github.com/symfony/Routing/blob/master/Route.php#L87

@ahukkanen @KorvinSzanto Wanted to weigh in on this after having played around w/ the routing stuff for a long time today. Changing the method signature to have parity with Symfony's is not going to solve the problem. Specifically, the issue isn't necessarily w/ the register() call not passing all arguments to the Route instance, its with the $callback parsing. Which obviously Concrete5 has to use to hook into the routing system and customize it, so its not as easy as just passing additional arguments.
The lines above where the new Route gets instantiated, there are three conditionals to detect if its either a) a closure, b) the dispatcher, or c) a controller route callback. Then the callback is passed into the getRouteAttributes method of ClosureRouteCallback, DispatcherRouteCallback, or ControllerRouteCallback, respectively. Those methods set and return the $attributes. And the way parsing is done w/in those methods (not merging, but by setting pre-defined values) like array('callback' => $callback) doesn't allow any additional attributes (that should be part of the $attributes value) to go through.
Again, its understandable why C5 wouldn't support it initially, cause you easily set conflicting routes. But for using C5 as a more advanced framework, I'm seconding ahukkanen that we should continue to look for a fix.

Actually, after looking at this more - its a much bigger issue. Even if the issue above does get fixed and you can pass in all the route parameters properly, the execute method of the Router class works on callbacks that all have to be instances of the RouteCallback abstract class, each of which implement the execute method.
Not being sure what @ahukkanen is looking for with routing, but I can say that trying to build out an API for a package with a proper restful implementation (ie: mapping GET and POST calls to their respective handlers, even if its the same route) is something thats valuable but impossible given the current setup.

What I was trying to do was explained in the initial message. It was a really simple case and I would just have wanted to avoid doing duplicate code and doing it on a single line whereas now I need two lines for it.
You're better off bypassing the flawed C5's own API and using the Symphony classes, as @KorvinSzanto suggest. Strange to hear such suggestion from a core team member, though. Encouraging not to use their API because it's not flexible enough to do what you want to do...

@ahukkanen The wrapper is meant to simplify functionality, not to completely wrap functionality. Using symfony's route object instead of our own is an example of better design and better interoperability, not flawed api design.

@KorvinSzanto I have to agree w/ @ahukkanen, given the way C5 currently wraps symfony's router, its easier to go around it. Not ideal.

I had similar problems as @jhartman86 when building an API with different http methods. In my experience the Resolver returned one 'matched' route and then quit with a "Method not Allowed".

@a3020 when concrete5 creates a MethodNotAllowedException instance, it should always be paired with detailed information about why it was blocked. It sounds to me like your webserver might be disallowing the method.
@jhartman86 I don't disagree. @ahukkanen is correct, I say that in this reply right here. I just don't understand why being able to pass any instance of Route is an issue, to me this is a prime example of LSP working well. Our wrapper serves to simplify and support legacy functionality, it is not there to make symfony more powerful.
I agree that if there are opportunities to make this wrapper better that it's worth exploring but up until now you two are just saying "this is bad" without any actual reasoning as to why it is bad, to me passing my own Route object instead of concrete5's is fine.  Perhaps if you explain why it is not ideal and give an example it'd be easier to actually talk about this?

@KorvinSzanto I was using get and post. Like this:
Route::register('path/to', ..... 'get', 'SomeController')
Route::register('path/to', ..... 'post', 'SomeController')

The Resolver only matches with the first one and if you then send a post request, it gives a MethodNotAllowedException. But maybe I did something wrong. Ended up using one controller b/c I thought it wasn't supported by C5.

@KorvinSzanto I tried to explain this previously but communication error I guess. But see my comments from February 26th last year (above).
There are two things:

Even if the Router::register() method did match Symfony's router signature (which maybe it does now?), the problem isn't there...
In https://github.com/concrete5/concrete5/blob/develop/web/concrete/src/Routing/Router.php#L117, attributes are derived from hardcoded static functions of either ClosureRouteCallback, DispatcherRouteCallback, or ControllerRouteCallback. Because of this, the attributes passed onto a Symfony Route instance aren't customizable, thus - you can not set defaults in route parameters (eg. mypath/{id}).

@a3020 - with regards to matching routes against different HTTP methods, I haven't been able to figure out how to do it without going around C5's router entirely (although I haven't tried since 1503 got merged, but if its not working for you, this ticket is relevant). That said, you can actually fire up a Symfony router and use it normally, although you have to go around C5's entirely, and then punt back up to C5 to let it do its thang if you want. Its a lot to look at, but if it helps you here's where to start:
https://github.com/jhartman86/schedulizer-package-57/blob/master/controller.php#L141, and the ApiOnStart class used by the method in the controller: https://github.com/jhartman86/schedulizer-package-57/blob/master/src/Api/ApiOnStart.php

@jhartman86 we are on the same page with that, my point is that it we should not have to go around the router. $router->getList()->add('custom_handle', $route) is not going around the router, in testing it looks like this is broken.
Perhaps we should eliminate this router wrapper in v8.0.0 and instead opt for a proper implementation of either \Symfony\Component\HttpFoundation\RequestMatcherInterface or \Symfony\Component\HttpFoundation\UrlMatcherInterface.
@a3020 It looks like you're right about this one, this is a bit puzzling. So the way this should work, you should be able to do this:
$route = \Router::register('/some/path');
$route->setMethods('POST');

for some reason this fails today, likely because the router wrapper isn't wrapping symfony properly.

@jhartman86 I'd recommend opening a new proposal issue with examples of what you'd like to be able to do in version 8.0.0. We can discuss ways that we can improve this stack in there since this issue is rather specific.


Provide hands-on examples

Current example is based on some fake registry, which does not make sence when users are trying to run and see how it works. It would be much better to demo against docker hub (the default registry) and provide hands-on examples that users can learn from easily by doing.

Check out the galley-template repo! I think this has exactly what you're looking for.


feat: fix missing loop break label

Likely related to flakiness reported in #6502, although I don't know how this ever worked the way it was :exploding_head:

@elsirion Given a random nature of the problem, my bet would be on something non-deterministic, like timestamp or ID comparison.

@elsirion Would probably be good to have a test that generates like 100 random events, then paginates them 3 by 3, then compares that it got all the same events in same order. Just something heavy duty like that.

Hmm... this test passes deterministically 100% of the time(?) locally?!

So how did this pass https://github.com/fedimint/fedimint/actions/runs/12116242638/job/33776213978 . It says it ran the unit tests ...

I have re-run it and it failed. O_O
https://github.com/fedimint/fedimint/actions/runs/12116242638/job/33937424126

It's going to be hard to tell now why did that one particular run lie to us and pass. Since everything seems to be correctly failing now, such a one-time event does not scare me, but making a mental note that it happened.


Add missing javadocs

Completely describe the Fenzo API in javadoc comments, including classes, interfaces, methods, attributes, and enums.
Use the active voice in order to make the documentation unambiguous -- see http://go/pv

Java docs were added to all public classes and methods.


godot4-mono: init at 4.2.1

Description of changes
Add the mono version of godot4.2.1
For now this is technically not a derivation of the base package godot4, but for now it does work.
Recreation of my previous PR (#264287 ) after I tried uprading the godot version and commiting my make-deps.nix file it got very very broken and broke even more when I tried to fix it
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

closes #255986

It looks like this wasn't exported anywhere. Using this I can't import pkgs.godot4-mono or similar.

It looks like this wasn't exported anywhere. Using this I can't import pkgs.godot4-mono or similar.

It still needs to be accepted. I think it's a lot harder because it's technically a new package.

It looks like this wasn't exported anywhere. Using this I can't import pkgs.godot4-mono or similar.

Yeah, I also would like to try it out. If you found out how to get it, would love to know.

Yeah, I also would like to try it out. If you found out how to get it, would love to know.

if you download the files you can add this into your config
let
godot4-mono = pkgs.callPackage /path/to/godot4-mono/default.nix {};
in
then it can go in your environment.systemPackages like normal

Yeah, I also would like to try it out. If you found out how to get it, would love to know.

if you download the files you can add this into your config
let godot4-mono = pkgs.callPackage /path/to/godot4-mono/default.nix {}; in
then it can go in your environment.systemPackages like normal (You will have to compile it yourself tho, cannot fetch from the cache)

you dont need the /default.nix part btw

you dont need the /default.nix part btw

oh ok

Is there anything holding this PR up? I have been using this package for a bit now and can confirm it works great.
Since this PR was created, godot has moved to 4.2.2.

Works fine for me, any chance of this getting this merged? It would be nice if it could be bumped to 4.2.2 too, should be a relatively smooth process.

I updated the version on my computer to 4.2.2 yeaterday so I can create a branch with it while we wait for this to be merged

I think it should be fine to just update this branch, especially if it's just a minor bump. At least, I've seen other PRs do it in the past.

Alright, I will take a look at these asap

How would you modify the code to compile Godot 4.3 instead? I have some Issues with Xwayland and want to try the new native wayland support.
I tried changing the version and commit hash to:
version = "4.3-dev"; #"4.2.2-stable";
commitHash = "89f70e9";
However it still compiles 4.22 :/

You also need to modify the hash in fetchFromGithub (the way I do it, correct me if im wrong, is delete the hash, start a build then paste in whatever it finds but there is a chance that is a terrible way to do it lol)

You also need to modify the hash in fetchFromGithub (the way I do it, correct me if im wrong, is delete the hash, start a build then paste in whatever it finds but there is a chance that is a terrible way to do it lol)

Thank you so much for the quick response! That actually worked and it starts compiling. Sadly I get the following error message:

/build/source/modules/mono/editor/GodotTools/GodotTools.OpenVisualStudio/GodotTools.OpenVisualStudio.csproj : error NU1101: Unable to find package Microsoft.NETCore.App.Host.win-x86. No packages exist with this id in source(s): godot4-mono-deps [/build/source/modules/mono/editor/GodotTools/GodotTools.sln]
Restored /build/source/modules/mono/editor/GodotTools/GodotTools.Shared/GodotTools.Shared.csproj (in 179 ms).
Restored /build/source/modules/mono/editor/GodotTools/GodotTools.Core/GodotTools.Core.csproj (in 179 ms).
Failed to restore /build/source/modules/mono/editor/GodotTools/GodotTools.OpenVisualStudio/GodotTools.OpenVisualStudio.csproj (in 126 ms).
Failed to restore /build/source/modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/Godot.SourceGenerators.csproj (in 389 ms).
Restored /build/source/modules/mono/editor/GodotTools/GodotTools.IdeMessaging/GodotTools.IdeMessaging.csproj (in 474 ms).
Restored /build/source/modules/mono/editor/GodotTools/GodotTools.BuildLogger/GodotTools.BuildLogger.csproj (in 1.06 sec).
Restored /build/source/modules/mono/editor/GodotTools/GodotTools.ProjectEditor/GodotTools.ProjectEditor.csproj (in 1.86 sec).
Restored /build/source/modules/mono/editor/GodotTools/GodotTools/GodotTools.csproj (in 1.87 sec).

I had no luck debugging, but I will try again later today.

Oh right, my bad. You also need to run the fetchDeps.sh file (sorry I forgot about that, I always do everytime I update it)

First thanks for the great work on this. I was using this to use godot just fine until recently. I updated (and changed other things on my system) and now godot crashes on startup. Could you verify that if this still works after updating to the latest version so I can try and figure out of this is a nix problem or an issue with my system?
free(): invalid pointer
Aborted (core dumped)

I will give it a try later today (Im busy rn)

I will give it a try later today (Im busy rn)

I'm sorry if you are still busy, but do you have any updates on this?

Sorry, I have been very busy with some school stuff recently but now thats sorted i will be able to test in a minute

I'm having some issues with the dependency generation, I just get an empty file for some reason.
Running nuget-to-nix manually on the directory that contains the packages from the restore also returns empty, not sure what I am doing wrong.

I'm having some issues with the dependency generation, I just get an empty file for some reason. Running nuget-to-nix manually on the directory that contains the packages from the restore also returns empty, not sure what I am doing wrong.

Sorry, I do not know what you are doing wrong, does it return any errors (also you are running make-deps.nix right?)
In other news, I have been working on 4.3 and am just figuring out what deps i need for the wayland support

I'm having some issues with the dependency generation, I just get an empty file for some reason. Running nuget-to-nix manually on the directory that contains the packages from the restore also returns empty, not sure what I am doing wrong.

Sorry, I do not know what you are doing wrong, does it return any errors (also you are running make-deps.nix right?)
In other news, I have been working on how to get 4.3 working with nix and am just figuring out what deps i need for the wayland support

I am running the shell script make-deps.sh, which from what I can tell invokes the make-deps.nix via the passthru in default.nix.
I do get the deps.nix file and the output from dotnet restore, so it's definitely running, the deps.nix file is just empty at the end.
Like I said running it manually on a folder that contains packages also returns nothing. I tried using the nuget2nix package, which does give me the nuget lockfile correctly, so I have no idea why the nixpkgs included nuget-to-nix is not working with the same folder structure.
Someone on discord ran into a similar issue and recommended I use nuget2nix instead, but I'd rather use the nixpkgs version if possible.

I'm wondering why this pkg requires the dotnetsdk pkg to exist separately on the system considering godot3_mono did not need this (at least to open a project without crashing). I'm thinking this pkg result makes more sense as I could theoretically have different dotnet version in different directories courtesy flakes and this pkg may be more strict about the dependency checking, just curious.
Also I needed to change the final icon names in the install phase from godot.fileExt to godot_icon.fileExt in order to have both this and godot_4 (non mono godot4 build) coexist on my system without a collision.

I heard from the devs that they're planning to merge mono with the main project as a single Godot release. So if this breaks now, it'll probably mean the Godot build will eventually break in the future.

Someone on discord ran into a similar issue and recommended I use nuget2nix instead, but I'd rather use the nixpkgs version if possible.

Sorry, I have not been having this issue and cant really help you there

I could theoretically have different dotnet version in different directories

On 4.3 (at least) anything less then dotnet sdk 8 will not work

I heard from the devs that they're planning to merge mono with the main project as a single Godot release. So if this breaks now, it'll probably mean the Godot build will eventually break in the future.

Hmm I see, Ive been trying to get wayland support to work but it really does not want to (and also it makes it fail to run through xwayland at the same time) even though im 99% sure Ive added all the required dependencies

Could you share the error you are hitting on wayland? It wont launch for me on wayland (or maybe it's my gpu) in 4.2 and I'm wondering if it is a similar issue.

Godot Engine v4.2.2.stable.mono.nixpkgs.15073afe3 - https://godotengine.org
DRM kernel driver 'nvidia-drm' in use. NVK requires nouveau.
Vulkan API 1.3.277 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce GTX 1060 6GB
WARNING: Invalid pipelines cache header.
     at: _load_pipeline_cache (drivers/vulkan/rendering_device_vulkan.cpp:9229)

free(): invalid pointer
Aborted (core dumped)

Could you share the error you are hitting on wayland? It wont launch for me on wayland (or maybe it's my gpu) in 4.2 and I'm wondering if it is a similar issue.

Godot Engine v4.2.2.stable.mono.nixpkgs.15073afe3 - https://godotengine.org
DRM kernel driver 'nvidia-drm' in use. NVK requires nouveau.
Vulkan API 1.3.277 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce GTX 1060 6GB
WARNING: Invalid pipelines cache header.
     at: _load_pipeline_cache (drivers/vulkan/rendering_device_vulkan.cpp:9229)

free(): invalid pointer
Aborted (core dumped)

I've actually been using a modified version of your flake.nix from Thrive to mess with Godot + RL Agents.
I've really just added a few dependencies under # Runtime Deps but it's working on my NV 3070 + Vulkan under Wayland. Hopefully it can help or I can provide further environment information.
One possible thing is my nix-ld is absolutely polluted as I copied in everything from nixos appimage into the .libraries pkg list.
Here is the flake and I've also just recreated it to ensure that it's still currently working, was able to load the editor and kick off an rl-agent run with a viewer.
https://gist.github.com/postcert/e38bef0431bf813abcf79e9ae8129bdb

Using that flake godot works for me just fine. I wonder what the issue with the other flake is. Thanks for the help.

What is the issue preventing this from being merged? Is there anything one can do? I'd really like using this package

https://github.com/NixOS/nixpkgs/pull/285941#pullrequestreview-2035907508

Could withDebugSymbols be added as an option? I would like to be able to more easily build it that way for profiling.

I can do that, Ill dedicate a day this weekend to just get it done including fixing the stuff in the review

@ilikefrogs101 Not sure which issues you ran into specifically, but adding dotnet-sdk_8, dotnet-runtime_8,  wayland-scanner, libdecor, and speechd to both nativeBuildInputs and runtimeDependencies, as well as wayland to runtimeDependencies, and it builds and runs fine for me under wayland on godot on commit 9aa9f3d54402893d0c3c6fff89966e4f7f62d2b2 (4.3).
Hyprland also reports as much.
Window 3008df30 -> node_2d.tscn - New Game Project - Godot Engine:
        class: org.godotengine.Editor
        title: node_2d.tscn - New Game Project - Godot Engine
        initialClass: org.godotengine.Editor
        initialTitle: Godot
        xwayland: 0

Window 300ceb90 -> New Game Project (DEBUG):
        class: New Game Project
        title: New Game Project (DEBUG)
        initialClass: New Game Project
        initialTitle: Godot
        xwayland: 0

Please use nixfmt (rfc) to format package.

Please enable strictDeps.

Version 4.3 is out:
https://github.com/godotengine/godot-builds/releases/tag/4.3-stable

I've been trying to get this to work for 4.2.2-stable, it compiles fine but once I run it I get an error saying "Unable to load .NET runtime, specifically hostfxr". I've run make-deps and checked the runtime dependencies, but it won't find it.

I'm currently trying to package this in my flake, with a 4.3-stable tag as the source. It all works well until the .NET assemblies are generated.
I ran make-deps.sh to have an up-to-date version of the deps.nix lockfile and the source is seemingly generated successfully.
godot4-mono> Running phase: createNugetDirs
godot4-mono> The template "NuGet Config" was created successfully.
godot4-mono> Processing post-creation actions...
godot4-mono> Package source with Name: nuget disabled successfully.
godot4-mono> Package source with Name: _nix added successfully.
godot4-mono> Running phase: unpackPhase
godot4-mono> unpacking source archive /nix/store/gafq6151pc62pdymx8aw5i4d977phsf6-source
godot4-mono> source root is source
godot4-mono> Running phase: patchPhase
godot4-mono> Running phase: configureNuget
godot4-mono> Running phase: updateAutotoolsGnuConfigScriptsPhase
godot4-mono> Running phase: configurePhase
godot4-mono> no configure script, doing nothing
godot4-mono> Setting up buildhome.
godot4-mono> Configuring NuGet.
godot4-mono> Running phase: buildPhase
godot4-mono> Starting Build
godot4-mono> scons: Reading SConscript files ...
godot4-mono> Auto-detected 32 CPU cores available for build parallelism. Using 31 cores by default. You can override it with the -j argument.
godot4-mono> Building for platform "linuxbsd", architecture "x86_64", target "editor".
godot4-mono> Using custom build name: 'nixpkgs'.
[1/0/1 built] building godot4-mono-4.3-stable (buildPhase)
godot4-mono> Checking for C header file mntent.h... yes
godot4-mono> scons: done reading SConscript files.
godot4-mono> scons: Building targets ...

Then it fails at this stage:
godot4-mono> Building C#/.NET Assemblies
godot4-mono> Using custom build name: 'nixpkgs'.
godot4-mono> Running MSBuild:  /nix/store/1nmjsx4wkr7braiz5spq84b1ibvvz2jb-dotnet-sdk-8.0.303/bin/dotnet msbuild /build/source/modules/mono/glue/GodotSharp/GodotSharp.sln /restore /t:Build /p:Configuration=Debug /p:NoWarn=
1591
godot4-mono> MSBuild version 17.10.4+10fbfbf2e for .NET
godot4-mono>   Determining projects to restore...
godot4-mono> /build/source/modules/mono/glue/GodotSharp/GodotSharp/GodotSharp.csproj : error NU1101: Unable to find package ReflectionAnalyzers. No packages exist with this id in source(s): _nix [/build/source/modules/mono
/glue/GodotSharp/GodotSharp.sln]
godot4-mono> /build/source/modules/mono/glue/GodotSharp/GodotPlugins/GodotPlugins.csproj : error NU1101: Unable to find package Microsoft.NETCore.App.Ref. No packages exist with this id in source(s): _nix [/build/source/mo
dules/mono/glue/GodotSharp/GodotSharp.sln]
godot4-mono> /build/source/modules/mono/glue/GodotSharp/Godot.SourceGenerators.Internal/Godot.SourceGenerators.Internal.csproj : error NU1101: Unable to find package NETStandard.Library. No packages exist with this id in s
ource(s): _nix [/build/source/modules/mono/glue/GodotSharp/GodotSharp.sln]
godot4-mono> /build/source/modules/mono/glue/GodotSharp/GodotSharpEditor/GodotSharpEditor.csproj : error NU1101: Unable to find package Microsoft.NETCore.App.Ref. No packages exist with this id in source(s): _nix [/build/s
ource/modules/mono/glue/GodotSharp/GodotSharp.sln]
godot4-mono> /build/source/modules/mono/glue/GodotSharp/GodotPlugins/GodotPlugins.csproj : error NU1101: Unable to find package Microsoft.AspNetCore.App.Ref. No packages exist with this id in source(s): _nix [/build/source
/modules/mono/glue/GodotSharp/GodotSharp.sln]
godot4-mono> /build/source/modules/mono/glue/GodotSharp/Godot.SourceGenerators.Internal/Godot.SourceGenerators.Internal.csproj : error NU1101: Unable to find package Microsoft.CodeAnalysis.CSharp. No packages exist with th
is id in source(s): _nix [/build/source/modules/mono/glue/GodotSharp/GodotSharp.sln]
godot4-mono> /build/source/modules/mono/glue/GodotSharp/GodotSharpEditor/GodotSharpEditor.csproj : error NU1101: Unable to find package Microsoft.AspNetCore.App.Ref. No packages exist with this id in source(s): _nix [/buil
d/source/modules/mono/glue/GodotSharp/GodotSharp.sln]
godot4-mono> /build/source/modules/mono/glue/GodotSharp/Godot.SourceGenerators.Internal/Godot.SourceGenerators.Internal.csproj : error NU1101: Unable to find package Microsoft.CodeAnalysis.Analyzers. No packages exist with
 this id in source(s): _nix [/build/source/modules/mono/glue/GodotSharp/GodotSharp.sln]
godot4-mono> /build/source/modules/mono/glue/GodotSharp/GodotSharp/GodotSharp.csproj : error NU1101: Unable to find package Microsoft.NETCore.App.Ref. No packages exist with this id in source(s): _nix [/build/source/module
s/mono/glue/GodotSharp/GodotSharp.sln]
godot4-mono> /build/source/modules/mono/glue/GodotSharp/GodotSharp/GodotSharp.csproj : error NU1101: Unable to find package Microsoft.AspNetCore.App.Ref. No packages exist with this id in source(s): _nix [/build/source/mod
ules/mono/glue/GodotSharp/GodotSharp.sln]
godot4-mono>   Failed to restore /build/source/modules/mono/glue/GodotSharp/GodotSharp/GodotSharp.csproj (in 57 ms).
godot4-mono>   Failed to restore /build/source/modules/mono/glue/GodotSharp/GodotSharpEditor/GodotSharpEditor.csproj (in 58 ms).
godot4-mono>   Failed to restore /build/source/modules/mono/glue/GodotSharp/Godot.SourceGenerators.Internal/Godot.SourceGenerators.Internal.csproj (in 57 ms).
godot4-mono>   Failed to restore /build/source/modules/mono/glue/GodotSharp/GodotPlugins/GodotPlugins.csproj (in 58 ms).
error: builder for '/nix/store/hbndj1l8pjag52h30ig6k3lxhswg4688-godot4-mono-4.3-stable.drv' failed with exit code 1;
       last 10 log lines:
       > /build/source/modules/mono/glue/GodotSharp/GodotPlugins/GodotPlugins.csproj : error NU1101: Unable to find package Microsoft.AspNetCore.App.Ref. No packages exist with this id in source(s): _nix [/build/source/mod
ules/mono/glue/GodotSharp/GodotSharp.sln]
       > /build/source/modules/mono/glue/GodotSharp/Godot.SourceGenerators.Internal/Godot.SourceGenerators.Internal.csproj : error NU1101: Unable to find package Microsoft.CodeAnalysis.CSharp. No packages exist with this i
d in source(s): _nix [/build/source/modules/mono/glue/GodotSharp/GodotSharp.sln]
       > /build/source/modules/mono/glue/GodotSharp/GodotSharpEditor/GodotSharpEditor.csproj : error NU1101: Unable to find package Microsoft.AspNetCore.App.Ref. No packages exist with this id in source(s): _nix [/build/so
urce/modules/mono/glue/GodotSharp/GodotSharp.sln]
       > /build/source/modules/mono/glue/GodotSharp/Godot.SourceGenerators.Internal/Godot.SourceGenerators.Internal.csproj : error NU1101: Unable to find package Microsoft.CodeAnalysis.Analyzers. No packages exist with thi
s id in source(s): _nix [/build/source/modules/mono/glue/GodotSharp/GodotSharp.sln]
       > /build/source/modules/mono/glue/GodotSharp/GodotSharp/GodotSharp.csproj : error NU1101: Unable to find package Microsoft.NETCore.App.Ref. No packages exist with this id in source(s): _nix [/build/source/modules/mo
no/glue/GodotSharp/GodotSharp.sln]
       > /build/source/modules/mono/glue/GodotSharp/GodotSharp/GodotSharp.csproj : error NU1101: Unable to find package Microsoft.AspNetCore.App.Ref. No packages exist with this id in source(s): _nix [/build/source/modules
/mono/glue/GodotSharp/GodotSharp.sln]
       >   Failed to restore /build/source/modules/mono/glue/GodotSharp/GodotSharp/GodotSharp.csproj (in 57 ms).
       >   Failed to restore /build/source/modules/mono/glue/GodotSharp/GodotSharpEditor/GodotSharpEditor.csproj (in 58 ms).
       >   Failed to restore /build/source/modules/mono/glue/GodotSharp/Godot.SourceGenerators.Internal/Godot.SourceGenerators.Internal.csproj (in 57 ms).
       >   Failed to restore /build/source/modules/mono/glue/GodotSharp/GodotPlugins/GodotPlugins.csproj (in 58 ms).
       For full logs, run 'nix log /nix/store/hbndj1l8pjag52h30ig6k3lxhswg4688-godot4-mono-4.3-stable.drv'.

Any idea what might be going on here? All the relevant files can be found in my flake for reference.

Don't think you are doing anything wrong. I have the exact same issue :/

godot4-mono> /build/source/modules/mono/glue/GodotSharp/GodotPlugins/GodotPlugins.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Ref with version (= 6.0.31) [/build/source/modules/mono/glue/GodotSharp/
GodotSharp.sln]
godot4-mono> /build/source/modules/mono/glue/GodotSharp/GodotPlugins/GodotPlugins.csproj : error NU1102:   - Found 1 version(s) in godot4-mono-deps [ Nearest version: 6.0.32 ] [/build/source/modules/mono/glue/GodotSharp/Go
dotSharp.sln]

This is sort of expected when building net6.0 from SDK 7/8, because SDK 7/8 might have 6.0.31 hardcoded, but SDK 6 in nupkgs supplies 6.0.32.
Still, when you run fetch-deps on this package, it should put 6.0.31 in the lock file, so I'm not sure what's up there.

@ilikefrogs101 take a look at https://github.com/corngood/nixpkgs/commit/4469d5a1ec965c132b75fdf4680732bab549d595
This is on top of your commit, rebased on recent master.
The dotnet-sdk hooks take care of most of the nuget configuration now.  I plan on making it even easier to add nuget deps to an existing derivation (i.e. replace most of what make-deps.sh and make-deps.nix are doing), but for now this should work.

The dotnet-sdk hooks take care of most of the nuget configuration now. I plan on making it even easier to add nuget deps to an existing derivation (i.e. replace most of what make-deps.sh and make-deps.nix are doing), but for now this should work.

This seems to fix the issues I had while building 4.3 as well. Thanks for the update!

@ilikefrogs101 I'd love to get this in.  Are you still interested in maintaining this?  If not, maybe someone else here can do it?

@corngood I would like to be able to maintain it but I really just dont have the time at the moment so if you or anyone else want to take over feel free

I can open a PR with the version I have up on Nyx, upstreaming is a goal anyways. So that would be a good way to get going? 👀

@dr460nf1r3 Sounds good to me.  I don't mind helping to maintain it, but I don't use it day-to-day, so I probably won't be proactive about it.  If we have a solid updateScript in place that would help.

Can I use godot-mono on nixos now? Or does godot 4.3 support it?

@solitudealma I think we're still waiting for someone to make a PR.  I might do it eventually if nobody else does.  In the meantime there might be another way, like flatpak or something?  I'm not sure what upstream provides.

Well, thank you for your enthusiasm for godot. The software I built using the code of this pr prompts that the runtime dependency of dotnet6 is missing. I don't know if it will affect the use. I think if you want to package it, you can start preparing it directly. Although the initiator has not given up, he doesn't have much time, and he doesn't seem to use this software mainly.

You are likely missing DOTNET_ROOT env var.
I sadly didn't get to make the PR yet, real life happens. I already started though, using the existing godot_4-mono as base / overrides.
If you want a working app right now, either use the Nyx overlay linked above or copy it's code to build your own version. It has all the necessary stuff like env vars and paths set.

Should I go to Godot or Hyprland to file an issue?

I'd probably look for existing issues on both projects first, but IMO godot shouldn't be able to deadlock the compositor.  If that's what's happening I'd start by filing it on Hyprland.  It's also possible that it's a nixpkgs specific issue.

Any progress on this? Nyx doesn't build anymore and I couldn't get binary version of godot running either(It refuses to recognise opengl drivers).

Any progress on this? Nyx doesn't build anymore and I couldn't get binary version of godot running either(It refuses to recognise opengl drivers).

Maybe you shouldn't package it yourself, you should try his nixpkgs

Any progress on this? Nyx doesn't build anymore and I couldn't get binary version of godot running either(It refuses to recognise opengl drivers).

Maybe you shouldn't package it yourself, you should try his nixpkgs

I tried, I just didn't use their binary cache as I couldn't get it to work without using their module (which is not something I want to do).
Anyway, I managed to get official binary version working, here's the flake if it helps anyone:
https://github.com/Damianu/godot4-bin'
I tested only if simple Console.WriteLine works from script - didn't test launching with wayland flag yet either.

Any progress on this? Nyx doesn't build anymore and I couldn't get binary version of godot running either(It refuses to recognise opengl drivers).

Maybe you shouldn't package it yourself, you should try his nixpkgs

I tried, I just didn't use their binary cache as I couldn't get it to work without using their module (which is not something I want to do).我尝试过，我只是没有使用他们的二进制缓存，因为如果不使用他们的模块我就无法让它工作（这不是我想做的事情）。
Anyway, I managed to get official binary version working, here's the flake if it helps anyone: https://github.com/Damianu/godot4-bin
I tested only if simple Console.WriteLine works from C# - didn't test launching with wayland flag yet either.

This is a long process. I think you can use gdscript for the time being. Most tutorials are based on this. Of course, you may be an experienced game developer, but this does not affect you.

The problem with Gdscript is that there are a lot of libraries missing especially for niche hardware. I could of course use c++ but that's a pain compared to C#

I think saying "Just use GDScript" to someone asking about packaging mono version is kinda funny...
As I said previosuly, I really hope that at some point we'll get godot4-mono in nixpkgs as C# is a popular language in game development, and not including variant of package seems weird(Especially when previous version of the engine has mono version packaged).
To me arguing if it should be included or if its needed is kinda like saying "Just use python" when someone asks for nodeJS.
However for now I am fine using my flake based on official binary - it does the job for me.

I spend a good chunk of my free time helping develop an open source video-game that uses godot c#. I have no control over what language the project uses as I am just one member of a larger community. Saying "Just use GDScript" is frankly just insane.
Oh, and thanks again Damianu, that flake works great for the time being, but I also would very much like to see this mainlined.

I don't understand this part:

Of course, you may be an experienced game developer, but this does not affect you.

Is it implying that there's no overlap between experienced game developers and Nix users? That's evidently not the case as I'm one of those, but even if it were, wouldn't it be in the project's best interest to package Godot4-Mono anyway to make Nix more attractive to that portion of the population?

I don't understand this part:

Of course, you may be an experienced game developer, but this does not affect you.

Is it implying that there's no overlap between experienced game developers and Nix users? That's evidently not the case as I'm one of those, but even if it were, wouldn't it be in the project's best interest to package Godot4-Mono anyway to make Nix more attractive to that portion of the population?

Most game developers start learning C#, so if you have experience, C# is indeed the best choice. If not, gdscript is also a good choice. It's just a suggestion, don't worry about it.

Most game developers start learning C#, so if you have experience, C# is indeed the best choice. If not, gdscript is also a good choice. It's just a suggestion, don't worry about it.

Gotcha. I didn't get that impression from the original comment. Thanks for clarifying :heart:

FYI Nyx build has been fixed: https://github.com/chaotic-cx/nyx/pull/911
If anyone wants to bring this to Nixpkgs please feel free to. I sadly lack the time to focus on this lately.

FYI Nyx build has been fixed: https://github.com/chaotic-cx/nyx/pull/911
If anyone wants to bring this to Nixpkgs please feel free to. I sadly lack the time to focus on this lately.

thx, bro

If anyone wants to bring this to Nixpkgs please feel free to. I sadly lack the time to focus on this lately.

I'll have a go at this

PR at #353242 if anyone here wants to take a look.


Include periods in acceptable punctuation in units

Add . to acceptable punctuation in units.

People use periods in their units?

a.u.
mol.%
Formally they shouldn't, but in practice they do.


Hotifx: clean up validation for Year-type fields.

Context
There were some leftover unused classes to validate the Year fields for CourseParticipationEntity objects which can be safely removed.
Changes in this PR

removed extraneous YearFloor and YearFloorValidator files as we're not using custom annotations.
cleaned up a controller test which checked the validity of the yearStarted and yearCompleted fields in CourseParticipationEntity.

Release checklist
Release process documentation
As part of our continuous deployment strategy we must ensure that this work is
ready to be released once merged.
Pre-merge

[ ] There are changes required to the Accredited Programmes UI for this change to work...

[ ] ... and they been released to production already

Post-merge

[ ] Manually approve release to preprod
[ ] Manually approve release to prod

Closed as changes have been pulled into #158 .


add support for basic blocks

See #55 for progress.

Hello @mike-hunhoff ,
Do let me know if and how I can be of help with this issue?

@akhilguruprasad22 I'd love your help here! I've got a draft PR open that you can continue to develop. It's almost at the finish line but there is some unaddressed feedback that needs to be investigated. I'd recommend you start by reviewing the draft PR  + unaddressed feedback. Please let me know if you have any questions!

I've assigned this issue to you for now. No pressure, if you decide not to move forward please let me know and I'll remove you 😄

Got it @mike-hunhoff , thank you. I shall look into this right away.

Hello @mike-hunhoff ,
Apologies for the unavoidable delay in resolving this. I won't be able to raise a PR with the changes (95% completed) until the next weekend. I really hope this won't be an issue.
I do have a few questions for you:

Should blocks which have no predecessors i.e. instructions following unconditional branches be considered block leaders? Every blog, including the url provided as a comment, I've come across state that they should be. @williballenthin mentions this on the capa PR review. In our tests, the exception handler block falls into this category. Hence using this as an example, we can argue that they are valid block leaders. Wanted to get this cleared up since a suggested comment makes a mention of this.
There is a suggestion to include your logic regarding connecting blocks as comments:
_https://github.com/mandiant/capa/pull/1326#discussion_r1120866293_
I was wondering whether it'd be acceptable to rephrase your comment or if it'd be prefered to have them in the code verbatim.

There were also some assumptions needing verification:

does .NET support non-returning functions:

The 6th point in the following snippet from the ECMA CLI spec file answers this:

.NET doesn't support tail calls, i.e. jmp to other routine:

While the CLR does support tail calls, the C# compiler doesn't.
https://blog.objektkultur.de/about-tail-recursion-in-.net/

.NET doesn't support shared function chunks, i.e. two different entry points to the same function body:

I'm yet to document sources which prove this.

Hello @mike-hunhoff ,
Thank you for resolving my queries.
I have raised a PR here, awaiting further review.


Woodpecker 2.7.2 broke login auth redirects, always returns blank page.

Component
server
Describe the bug
With the 2.7.1 -> 2.7.2 upgrade, woodpecker always returns a blank page. It seems to be trying to redirect to the /login?url=/repos page, but returns a blank page
Steps to reproduce

Have a working 2.7.1 install
Upgrade to 2.7.2
All pages are blank, and the loging redirect fails.

Expected behavior
It should correctly handle login redirects
System Info
`"source":"https://github.com/woodpecker-ci/woodpecker","version":"2.7.2"}`

Luckily there were no migrations as far as I can tell, so switching back to the v2.7.1 docker tag seems to be working fine.
Additional context
NA
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]

Perhaps, related #4194

same here

it look like https://woodpecker.foo/api/stream/events  api error
strict-origin-when-cross-origin

Browser console error

index-KaW5c5Z3.js:14 SyntaxError (at index-KaW5c5Z3.js:30:2267)
    at Ja (index-KaW5c5Z3.js:30:2267)
    at bt (index-KaW5c5Z3.js:40:798)
    at ue (index-KaW5c5Z3.js:40:4679)
    at Object.pe [as t] (index-KaW5c5Z3.js:40:4736)
    at setup (Login-RBNwZx3k.js:1:1138)
    at ca (index-KaW5c5Z3.js:14:38)
    at _p (index-KaW5c5Z3.js:14:38755)
    at pp (index-KaW5c5Z3.js:14:38538)
    at K (index-KaW5c5Z3.js:14:22424)
    at B (index-KaW5c5Z3.js:14:22316)

Got the same issue using Caddy as reverse proxy

Same using Traefik as reverse proxy

As @zc-devs stated, it likely due to #4194, which required a dep update (#4197) to get fixed. This wasn't backported to 2.7.2, so this release is broken and unusable.

Did you try the new release, 2.7.3? Because the linked PR was included in that.

We updated the Cloudron woodpecker package. Can confirm the issue is fixed with 2.7.3


Starts Broker and Server in parallel when using ServiceManager

Description
This starts Broker and Server in parallel when using ServiceManager
Fixes #5876
Upgrade Notes
Does this PR prevent a zero down-time upgrade? No
Does this PR fix a zero-downtime upgrade introduced earlier? No
Does this PR otherwise need attention when creating release notes? Yes
Release Notes
Broker and Server will now start in parallel when using ServiceManager
Documentation
N/A

ok here is what it looks like now:
$ docker logs pinot 2>&1|grep 'INFO.*since launch'
07:12:45,859 INFO  [main] command.StartServiceManagerCommand (StartServiceManagerCommand.java:254) - Starting a Pinot [CONTROLLER] at 5.448s since launch
07:12:51,703 INFO  [main] command.StartServiceManagerCommand (StartServiceManagerCommand.java:256) - Started Pinot [CONTROLLER] instance [Controller_f322d4ca725c_9000] at 11.293s since launch
07:12:51,706 INFO  [Starting BROKER] command.StartServiceManagerCommand (StartServiceManagerCommand.java:254) - Starting a Pinot [BROKER] at 11.296s since launch
07:12:51,706 INFO  [Starting SERVER] command.StartServiceManagerCommand (StartServiceManagerCommand.java:254) - Starting a Pinot [SERVER] at 11.296s since launch
07:12:55,523 INFO  [Starting SERVER] command.StartServiceManagerCommand (StartServiceManagerCommand.java:256) - Started Pinot [SERVER] instance [Server_f322d4ca725c_8098] at 15.113s since launch
07:12:55,593 INFO  [Starting BROKER] command.StartServiceManagerCommand (StartServiceManagerCommand.java:256) - Started Pinot [BROKER] instance [Broker_f322d4ca725c_8099] at 15.183s since launch

I'm pretty satisfied with this now
$ docker logs pinot 2>&1|grep 'INFO.*since launch'
08:51:48,903 INFO  [main] command.StartServiceManagerCommand (StartServiceManagerCommand.java:260) - Starting a Pinot [ServiceManager] at 0.02s since launch
08:51:54,182 INFO  [main] command.StartServiceManagerCommand (StartServiceManagerCommand.java:262) - Started Pinot [ServiceManager] instance [ServiceManager_55e6f54e58a8_7098] at 5.299s since launch
08:51:54,368 INFO  [main] command.StartServiceManagerCommand (StartServiceManagerCommand.java:260) - Starting a Pinot [CONTROLLER] at 5.485s since launch
08:52:00,930 INFO  [main] command.StartServiceManagerCommand (StartServiceManagerCommand.java:262) - Started Pinot [CONTROLLER] instance [Controller_55e6f54e58a8_9000] at 12.047s since launch
08:52:00,933 INFO  [Starting SERVER] command.StartServiceManagerCommand (StartServiceManagerCommand.java:260) - Starting a Pinot [SERVER] at 12.05s since launch
08:52:00,933 INFO  [Starting BROKER] command.StartServiceManagerCommand (StartServiceManagerCommand.java:260) - Starting a Pinot [BROKER] at 12.05s since launch
08:52:04,767 INFO  [Starting BROKER] command.StartServiceManagerCommand (StartServiceManagerCommand.java:262) - Started Pinot [BROKER] instance [Broker_55e6f54e58a8_8099] at 15.885s since launch
08:52:04,834 INFO  [Starting SERVER] command.StartServiceManagerCommand (StartServiceManagerCommand.java:262) - Started Pinot [SERVER] instance [Server_55e6f54e58a8_8098] at 15.952s since launch

one problem is the logging of org.apache.helix.manager.zk.ZKHelixManager. Trying the cluster clutters the log like this even when we catch exception:
fail to createClient.
org.apache.helix.HelixException: Cluster structure is not set up for cluster: QuickStartCluster
	at org.apache.helix.manager.zk.ZKHelixManager.handleNewSession(ZKHelixManager.java:1124) ~[pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.helix.manager.zk.ZKHelixManager.createClient(ZKHelixManager.java:701) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.helix.manager.zk.ZKHelixManager.connect(ZKHelixManager.java:738) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.admin.command.StartServiceManagerCommand.clusterExists(StartServiceManagerCommand.java:260) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.admin.command.StartServiceManagerCommand.startBootstrapServices(StartServiceManagerCommand.java:228) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.admin.command.StartServiceManagerCommand.execute(StartServiceManagerCommand.java:181) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.admin.command.StartControllerCommand.execute(StartControllerCommand.java:130) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.admin.command.QuickstartRunner.startControllers(QuickstartRunner.java:105) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.admin.command.QuickstartRunner.startAll(QuickstartRunner.java:140) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.HybridQuickstart.execute(HybridQuickstart.java:132) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.HybridQuickstart.main(HybridQuickstart.java:57) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
fail to connect ServiceManager_localhost_-1
org.apache.helix.HelixException: Cluster structure is not set up for cluster: QuickStartCluster
	at org.apache.helix.manager.zk.ZKHelixManager.handleNewSession(ZKHelixManager.java:1124) ~[pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.helix.manager.zk.ZKHelixManager.createClient(ZKHelixManager.java:701) ~[pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.helix.manager.zk.ZKHelixManager.connect(ZKHelixManager.java:738) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.admin.command.StartServiceManagerCommand.clusterExists(StartServiceManagerCommand.java:260) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.admin.command.StartServiceManagerCommand.startBootstrapServices(StartServiceManagerCommand.java:228) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.admin.command.StartServiceManagerCommand.execute(StartServiceManagerCommand.java:181) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.admin.command.StartControllerCommand.execute(StartControllerCommand.java:130) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.admin.command.QuickstartRunner.startControllers(QuickstartRunner.java:105) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.admin.command.QuickstartRunner.startAll(QuickstartRunner.java:140) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.HybridQuickstart.execute(HybridQuickstart.java:132) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]
	at org.apache.pinot.tools.HybridQuickstart.main(HybridQuickstart.java:57) [pinot-all-0.5.0-SNAPSHOT-jar-with-dependencies.jar:0.5.0-SNAPSHOT-3508311f31a79d45a279d3a2fe1437bdfd2358be]

I'm changing to always synchronously start CONTROLLER as it is better than scary logs

Codecov Report

Merging #5917 into master will decrease coverage by 22.91%.
The diff coverage is 48.81%.

@@             Coverage Diff             @@
##           master    #5917       +/-   ##
===========================================
- Coverage   66.44%   43.53%   -22.92%
===========================================
  Files        1075     1184      +109
  Lines       54773    62044     +7271
  Branches     8168     9479     +1311
===========================================
- Hits        36396    27013     -9383
- Misses      15700    32596    +16896
+ Partials     2677     2435      -242

Flag
Coverage Δ

#integration
43.53% <48.81%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ot/broker/broker/AllowAllAccessControlFactory.java
100.00% <ø> (ø)

.../helix/BrokerUserDefinedMessageHandlerFactory.java
52.83% <0.00%> (-13.84%)
:arrow_down:

...ava/org/apache/pinot/client/AbstractResultSet.java
26.66% <0.00%> (-30.48%)
:arrow_down:

.../main/java/org/apache/pinot/client/Connection.java
22.22% <0.00%> (-26.62%)
:arrow_down:

.../org/apache/pinot/client/ResultTableResultSet.java
24.00% <0.00%> (-10.29%)
:arrow_down:

.../org/apache/pinot/common/lineage/LineageEntry.java
0.00% <0.00%> (ø)

...apache/pinot/common/lineage/LineageEntryState.java
0.00% <0.00%> (ø)

...rg/apache/pinot/common/lineage/SegmentLineage.java
0.00% <0.00%> (ø)

...ache/pinot/common/lineage/SegmentLineageUtils.java
0.00% <0.00%> (ø)

...ot/common/messages/RoutingTableRebuildMessage.java
0.00% <ø> (ø)

... and 1104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8974c7...33ce463. Read the comment docs.

Looking at the below, I'm wondering if ServiceManager itself can be deferred to start? It takes 8s
docker logs pinot 2>&1|grep 'INFO.*since launch'
11:33:12,151 INFO  [main] command.StartServiceManagerCommand (StartServiceManagerCommand.java:260) - Starting a Pinot [SERVICE_MANAGER] at 0.04s since launch
11:33:20,299 INFO  [main] command.StartServiceManagerCommand (StartServiceManagerCommand.java:262) - Started Pinot [SERVICE_MANAGER] instance [ServiceManager_f0292d096fa4_7098] at 8.189s since launch
11:33:20,344 INFO  [main] command.StartServiceManagerCommand (StartServiceManagerCommand.java:260) - Starting a Pinot [CONTROLLER] at 8.235s since launch
11:33:27,010 INFO  [main] command.StartServiceManagerCommand (StartServiceManagerCommand.java:262) - Started Pinot [CONTROLLER] instance [Controller_f0292d096fa4_9000] at 14.9s since launch
11:33:27,012 INFO  [pool-13-thread-1] command.StartServiceManagerCommand (StartServiceManagerCommand.java:260) - Starting a Pinot [BROKER] at 14.902s since launch
11:33:27,023 INFO  [pool-13-thread-2] command.StartServiceManagerCommand (StartServiceManagerCommand.java:260) - Starting a Pinot [SERVER] at 14.914s since launch
11:33:30,771 INFO  [pool-13-thread-1] command.StartServiceManagerCommand (StartServiceManagerCommand.java:262) - Started Pinot [BROKER] instance [Broker_f0292d096fa4_8099] at 18.696s since launch
11:33:30,821 INFO  [pool-13-thread-2] command.StartServiceManagerCommand (StartServiceManagerCommand.java:262) - Started Pinot [SERVER] instance [Server_f0292d096fa4_8098] at 18.747s since launch

nah chicken, egg as servicemanager starts the roles. I think this is good as it gets.

I think this is good for now.
I will take a look how to let service manager to connect to helix and decide if it's required to start controller first or it can start everything at once.

Thanks @fx19880617 and @kishoreg I will make one last sweep here to make sure if a role crashes the process does. then ask to merge (and ideally cut a snapshot)

ok PTAL I finished polishing the exit status work and updated Javadoc

PS this seems it didn't make it to 0.5.0. Can it be added to the next release after that? It will help to not be perpetually on snapshots

Right, this PR will be included in next release(0.6.0)


can't install @datadog/mobile-react-native

Describe what happened
When I try to install the Datadog Real User Monitoring (RUM) on my react-native project, with the command: npm install @datadog/mobile-react-native . I get the following error:
77 error code 1
78 error path myprojectFolder\node_modules\@datadog\mobile-react-native
79 error command failed
80 error command C:\WINDOWS\system32\cmd.exe /d /s /c scripts/replace-react-require.js

this error occurs only when I try to install the datadog libraries, other libraries work fine.
I´m Using react-native 0.68.0, gradle version: 6.7.1 and gradle plugin version: 4.2.0
Steps to reproduce the issue:
try to install the library with the command: npm install @datadog/mobile-react-native
Describe what you expected:
I expect to be able to install  the Datadog RUM in my project
Additional context

Version of the SDK: "@datadog/mobile-react-native@latest"
package.json:
...
"dependencies": {
"@ant-design/icons": "^4.2.1",
"@react-native-community/geolocation": "^2.0.2",
"@react-native-community/masked-view": "^0.1.10",
"@react-native-community/netinfo": "^5.9.4",
"@react-native-community/slider": "^3.0.3",
"@react-native-community/toolbar-android": "^0.2.1",
"@react-native-mapbox-gl/maps": "^8.4.0",
"@react-native-picker/picker": "^1.12.0",
"@react-navigation/bottom-tabs": "^5.7.2",
"@react-navigation/drawer": "^5.8.4",
"@react-navigation/material-bottom-tabs": "^5.2.14",
"@react-navigation/native": "^5.8.9",
"@react-navigation/stack": "^5.14.9",
"@reduxjs/toolkit": "^1.8.4",
"@sentry/react-native": "^3.4.1",
"@supersami/rn-foreground-service": "^1.1.1",
"@turf/circle": "^6.3.0",
"@turf/helpers": "^6.3.0",
"@turf/turf": "^6.3.0",
"adb": "^0.2.0",
"axios": "^0.21.1",
"color-convert": "^2.0.1",
"jdk": "^0.0.0",
"link": "^1.4.0",
"moment": "^2.29.1",
"npm-check-updates": "^12.5.11",
"react": "17.0.2",
"react-devtools": "^4.24.7",
"react-moment": "^1.1.1",
"react-native": "0.68.0",
"react-native-action-button": "^2.8.5",
"react-native-android-location-enabler": "^1.2.2",
"react-native-cli": "^2.0.1",
"react-native-color-picker": "^0.6.0",
"react-native-compass-heading": "^1.3.0",
"react-native-date-ranges": "^2.5.0",
"react-native-datepicker": "^1.7.2",
"react-native-document-picker": "^4.2.0",
"react-native-dropdown-picker": "^4.0.9",
"react-native-elements": "^2.3.2",
"react-native-exception-handler": "^2.10.9",
"react-native-exit-app": "^1.1.0",
"react-native-flatlist-slider": "^1.0.5",
"react-native-fs": "^2.16.6",
"react-native-geolocation-service": "^5.2.0",
"react-native-gesture-handler": "^1.8.0",
"react-native-linear-gradient": "^2.5.6",
"react-native-location": "^2.5.0",
"react-native-mail": "^6.1.1",
"react-native-masked-text": "^1.13.0",
"react-native-material-menu": "^1.2.0",
"react-native-modal": "^11.5.6",
"react-native-offline": "^5.7.0",
"react-native-option-select": "^1.0.4",
"react-native-paper": "^4.7.2",
"react-native-picker-select": "^7.0.0",
"react-native-popup-menu": "^0.15.10",
"react-native-pull-to-refresh": "^2.1.3",
"react-native-raw-bottom-sheet": "^2.2.0",
"react-native-reanimated": "^1.13.4",
"react-native-responsive-screen": "^1.4.1",
"react-native-restart": "0.0.17",
"react-native-safe-area-context": "^3.0.6",
"react-native-screens": "^2.15.0",
"react-native-select-input-ios": "^2.0.5",
"react-native-sensors": "^7.3.5",
"react-native-share": "^7.3.2",
"react-native-slider-color-picker": "^2.2.0",
"react-native-sliding-up-down-panels": "^1.0.0",
"react-native-smtp-mailer": "^1.2.5",
"react-native-svg": "^12.1.1",
"react-native-svg-uri": "^1.2.3",
"react-native-swipe-up-down": "^1.0.7",
"react-native-vector-icons": "^6.7.0",
"react-native-wheel-color-picker": "^1.0.2",
"react-navigation": "^4.4.3",
"react-navigation-hooks": "^1.1.0",
"react-navigation-material-bottom-tabs": "^2.3.0",
"react-redux": "^7.2.0",
"reactotron": "^0.9.0",
"reactotron-react-native": "^5.0.0",
"reactotron-redux": "^3.1.3",
"realm": "^6.1.8",
"reanimated-bottom-sheet": "^1.0.0-alpha.22",
"redux": "^4.0.5",
"redux-offline-queue": "^1.0.8",
"redux-saga": "^1.1.3",
"rn-fetch-blob": "^0.12.0",
"rn-sliding-up-panel": "^2.4.5",
"seamless-immutable": "^7.1.4",
"stacktrace-parser": "^0.1.10",
"symbol-observable": "^4.0.0",
"tinycolor2": "^1.4.1",
"tokml": "^0.4.0"
},
"devDependencies": {
"@babel/core": "^7.18.10",
"@babel/preset-env": "^7.18.10",
"@babel/preset-flow": "^7.18.6",
"@babel/preset-react": "^7.18.6",
"@babel/runtime": "^7.12.5",
"@react-native-community/eslint-config": "^2.0.0",
"@testing-library/jest-native": "^4.0.5",
"@testing-library/react-native": "^11.0.0",
"axios-mock-adapter": "^1.21.2",
"babel-jest": "^26.6.3",
"eslint": "7.14.0",
"jest": "^26.6.3",
"metro-react-native-babel-preset": "^0.66.2",
"react-test-renderer": "17.0.2"
},
"jest": {
"preset": "react-native"
},
"rnpm": {
"assets": [
"./assets/fonts/"
]
}

Thank you so much, the  version 1.1.3  worked fine for me !
I also had  tried the 1.0.0-rc5 version but it didn't work, it returns the same error.

I'm still having this issue on my Mac

Hi @elmcapp,
The issue was automatically closed when the PR was merged, it will be released in the very next version :)


Index Out Of Bounds Exception

Getting this after fresh install and moving around in a python file:
Error executing vim.schedule lua callback: ...e/nvim/lazy/supermaven-nvim/lua/supermaven-nvim/util.lua:100: Index out of bounds
stack traceback:
        [C]: in function 'nvim_buf_get_text'
        ...e/nvim/lazy/supermaven-nvim/lua/supermaven-nvim/util.lua:100: in function 'get_cursor_prefix'
        ...maven-nvim/lua/supermaven-nvim/binary/binary_handler.lua:288: in function 'poll_once'
        ...maven-nvim/lua/supermaven-nvim/binary/binary_handler.lua:24: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

so far it seems to only show when editing at the end of a file I believe

I'm having difficulty reproducing this, does it only occur after a fresh install?