perf: stop early if the sync iter is done

We sometimes defer the done flag by wrapping it inside a promise, and letting the outer sync iter run indefinitely. This usually is not a problem, as both flags need to be checked anyway, but it can improve perf and save a few ops to stop early.

Done.


webcomponents-lite.js -> webcomponents-lite.min.js

This change is

https://github.com/vaadin/vaadin-date-picker/blob/de5a45717512780606c92ca3e81d468f7164b79e/test/index.html#L14
Can you change that also? #fasterTests

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

nvm,

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


⚠ RPC server - Astar has degraded performance

In 58c19dc, RPC server - Astar ($ASTAR_RPC_URL) experienced degraded performance:

HTTP code: 0
Response time: 0 ms

Resolved: RPC server - Astar performance has improved in 7efaccb after 14 minutes.


[MB-15973] Upgrade Storybook (and associated dependencies) to v7

Summary
This pull request upgrades storybook to the next major version (currently 7.0.12) by running the automatic upgrade script listed in storybook's official v7 migration guide. This script made the following changes:

Upgraded the version of any associated storybook dependencies (any dependabot pull request that upgraded any package to the v7 ecosystem was doing this anyway)
Reconfigured some settings in the storybook/main.js configuration file to comport with updated expectations
Removed, and added, some associated dependencies to reflect the updated build patterns.
Updated the storybook and build-storybook commands in package.json.

The expectation is that there are no changes to any of the developer workflow, the build pipeline output, the rendering of Happo diffs, or the functionality of storybook on https://storybook.dp3.us/. As an added quality-of-life bonus, this pull request also seems to resolve the longstanding issue where, when starting Storybook locally in developer mode, the first displayed page would often contain an error that needed to be manually dismissed.
Other than some formatting edits that prettier insisted on making during our standard pre-commit hooks, this pull request currently contains no original work besides what the automatic script made. Fingers crossed that everything works!
There is no Jira ticket for this specific work, as it is part of A-Team's dependencies chore this slice.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code

Instructions for starting storybook

How to test

Run Storybook locally. Does it seem to work correctly? Cool, that's it. (Enjoy the new sidebar font.)

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.

Messages

:book:
:link: MB-15973

  Generated by :no_entry_sign: dangerJS against 78f2633e86febc332d9ba7d16c36bda4d42c915c


Please tell me how use this Control with only one thumb? Thank you.

I need custom slider where value-text will  move with thumb. Please help me.

Documentation can be found here https://github.com/halkar/xamarin-range-slider#supported-properties


Vim crashes with sigsev when setting encoding

I have a file containing some ill-encoded text (see attachment). I tried to set the encoding using :set encoding=8bit-cp1252, at which point vim crashes.
vim: v.8.0
Included patches: 1-628
I'm running arch linux and all packages are up-to-date.
example.txt

I'm very sorry for opening this ticket too soon, turns out that the problem was somehow related to the nerd-fonts package, not with vim. This can be deleted, but I can't figure out how.

I don't think the ticket can be deleted but it can be closed — something you did yourself, a little less than half an hour ago.

For whatever Reason, Vim shouldn't crash. So a gdb backtrace is still appreciated in order to handle this error gracefully (if possible)

The &encoding option is not supposed to be set ever after starting Vim: it immediately invalidates all non-ASCII strings present in Vim memory. I am not surprised this finally resulted in a crash (and would not be surprised to know that there are many more such crashes in the archives, but can’t remember anything now). Neovim which before deciding to force &encoding to be utf-8 always had been restricting setting this option after startup looks like using a better approach. It still allows maintaining some related features Neovim is not interested in (specifically dropping multibyte support with some other FEAT_… for decreased size of binary). (Patch was made in neovim/neovim#2929.)

What makes you think, that this is caused by making &encoding changeable?

It's hard to know whether this specific issue is caused by &encoding changing after startup without more details.  However, it's a known issue that doing so can cause crashes.  I brought this up0 over 8 years ago when I floated the idea of always using UTF-8 for &encoding.

I remember that discussion and would be very much in favor of such a change, especially since this would clean up all those nasty ifdefs, that often cause problems when changing only one or the other part of the ifdef.


Transitive dependency support for Maven pom.xml

Issue https://github.com/google/osv-scanner/issues/35
In this PR, the new Maven extractor invokes Maven resolver to compute the transitive dependencies of a Maven pom.xml.
Since managed dependencies are not actually being depended on, they are not in the resolved dependency graph, and thus they are not included in the scan results.

Codecov Report
Attention: Patch coverage is 97.61905% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 65.58%. Comparing base (804589a) to head (dc901f4).
Report is 3 commits behind head on main.

Files
Patch %
Lines

internal/manifest/maven.go
97.61%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
+ Coverage   64.47%   65.58%   +1.11%
==========================================
  Files         148      149       +1
  Lines       12088     9511    -2577
==========================================
- Hits         7794     6238    -1556
+ Misses       3843     2824    -1019
+ Partials      451      449       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Bugfix] Workaround tied tensors bug

Purpose

Fix failing tests related to shared tensors by working around https://github.com/huggingface/transformers/issues/33689

Prerequisites

#172

Changes

Added patch_tied_tensors_bug which detects shared tensors when there should be none and unties them
Added newly passing cases to test_model_reload
Added test_model_shared_tensors tests

Testing

test_model_reload tests pass
test_model_shared_tensors tests pass
Previously failing finetune, oneshot, sparsification, and obcq tests now pass

https://github.com/vllm-project/llm-compressor/actions/runs/11024922805


Fix v4.9.0 upgrade filename

Questions
Answers

Branch?
develop

Description?
v4.9.0 upgrade filename was wrong, so it was probably ignored 🤔

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?

How to test?
Please check that, following an upgrade from a version < 4.9.0 to a version > 4.9.0 autoupgrade module is correctly registered on hook dashboardZoneOne and set to top

@matks
Could you rebase this pr please?
Thanks :)

@sarahdib Rebased

@matks Your PR can't be merged because Travis is in :red_circle:

@matks Your PR can't be merged because Travis is in 🔴

But QA said yes 😁
I checked the error:
$ composer install
install.2
$ docker-compose up -d
$ bash -c 'while [[ "$(curl -s -o /dev/null -w %{http_code} http://localhost:8001/index.php)" != "200" ]]; do sleep 5; done'
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
The build has been terminated

Faulty build => I restart

I have ever restarted

... what a good way to start the day 😭 ...

Restarting Travis

@matks Always :red_circle: :(

Maybe if I retry again ? 😁

I just tried.

An idea @Quetzacoalt91  ?

Yes, I found out the 1.6 tag of the docker image prestashop/prestashop does not properly, there is an issue with a missing PHP library (I haven't copied the message, sorry).

Related to https://github.com/PrestaShop/docker/issues/211

Thanks @Quetzacoalt91 ;)

Thanks @matks & @Quetzacoalt91 (for fixing Docker)


W-17328863 - Support for other SF subdomains

There are certain internal services relying on different subdomains than my.salesforce.com. This include, but is not limited to, OrgFarm, TOFU and Trailhead.
Example:

The idea behind this simple change is to allow users to pass the full host as the Salesforce org parameter in the connector provider. This way, the provider validates the connection to other domains, as follows:

Thanks for the change. This has already been fixed with several other changes in the develop branch.
We will soon raise a merge request to sync develop and master branch.

@ayush-salesforce I think we recently added it to develop.
@panizzag thanks for your contribution, the team has probably added this the connector. @ayush-salesforce  can you confirm?

@ayush-salesforce @amirkhan-ak-sf
Nice job team, looks great! When will this change be released? I have a development waiting on this fix and I'd like to make the necessary changes to my pom to get the right version (I saw that a few structural changes were added to the new version, like groupId in the pom).
One more thing completely unrelated to this PR (I'm open to log a new WI if you want me to). I'd suggest that the [SF API base URL] (https://github.com/MuleSoft-AI-Chain-Project/mule-einstein1-connector/blob/master/src/main/java/com/mule/einstein/internal/helpers/ConstantUtil.java#L5) should be dinamically populated based on the /services/oauth2/token endpoint response, by extracting the value contained in the payload.api_instance_url. The main reason of this is that we may have different subdomains that are validated against other subdomains of the api url as well, for example test.api.salesforce.com.
Thanks


fix(footer): Set dds-footer role to contentinfo

Related Ticket(s)
Fixes #6890
Description
This PR sets the dds-footer element's role to contentinfo overriding any pre-existing roles that may have been set on the element.
Changelog
Changed

dds-footer has contentinfo landmark role

One issue I noticed that remains (at least in the dotcom shell story): The dds-footer element now having the contentinfo role ought to be a top-level landmark on the page. Currently it is a child of an element with role="main"

Additionally, we're using an HTML5 <main> element which carries an implicit role="main". A page should not have more than one element with a role of main.

Thank you @andy-blum !
Can you run yarn test:unit:updateSnapshot in the web components package folder to update the snapshot files?

Yes! I knew what test failed but not how to fix it!

@jeffchew @Praveen-sr Any thought about what @andy-blum mentioned here - https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/6964#issuecomment-904959569?

@proeung @andy-blum looks like the configuration is on the container level in Storybook, so might be something we will need to globally set:

Ideally we would not be setting the role="main" if there is already a dds-dotcom-shell on the page, if that isn't happening we will need to look into that.
@Praveen-sr any thoughts?

Looking more into this, the attribute hasMainTag: true will probably need to be added to the default dotcom-shell story parameters (dotcom-shell.stories.ts)


Suggest to run dashmate setup

Expected Behavior

When you run any commands except setup with a fresh setup, dashmate should recommend to run setup command first.
Current Behavior

Since new configs are created with base config as default we can see many different errors depend on a command you run.
Possible Solution

Initialize dashmate configuration with default config as null
Recommend to to run the setup command in error message when default group or default config is not set:

Error: Default config is not set. Please use '--config' option or set default config

Related https://github.com/dashpay/platform/issues/487

Fixed in v0.24


Missing GroupID in Unit Default QA test

@ntknguyen Is it possible to migrate those images and ticket to GitHub?

@ntknguyen I believe the typo was fixed in easey-content:c194686. Could you confirm this, or otherwise point out the existing typo?

@ntknguyen I believe the typo was fixed in easey-content:c194686. Could you confirm this, or otherwise point out the existing typo?

@maxdiebold-erg - It looks like it's fixed in dev not in test.  I guess it will reflect the changes in test later on, correct?

You are right, that change was not promoted to test or beta. I will do that.

Confirmed on dev. Emissions is spelled correctly in Submit screen banner. Comment with Group ID testing results on ticket #5984.

Tested as part of #5984


Timeout for preview observations for Energypespektiven 2050 or LFI dataset

Can we adapt the size of the card to the content?
With the following dataset, the dataset is not really visible as it has a lot of text information.
No rows are available in the preview table.
https://test.visualize.admin.ch/en/browse/dataset/https%3A%2F%2Fenergy.ld.admin.ch%2Fsfoe%2Fbfe_ogd56_energieperspektiven2050%2F4?previous={"includeDrafts"%3Afalse}.

Ah no, there seems to be a bug @ptbrowne

For large datasets the query to get the preview rows can take a long time. When it timeouts, no data is available, so no rows are shown. I have edited the title of the issue for clarity.

It seems to work now, I am closing, please re-open if you experience the issue.


Support for material v3?

I noticed this is dependent on material v2, it'd be nice to have a v3 version.

I use it together with Material 3.


[Doc] Update websocket docs to suggest passing the token as headers rather than query parameters

Search before asking

[X] I searched in the issues and found nothing similar.

What issue do you find in Pulsar docs?
https://pulsar.apache.org/docs/4.0.x/client-libraries-websocket/#authentication
What is your suggestion?
suggest passing the token as headers rather than query parameters
Any reference?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

I want to do it if no one want. could you assign it to me? @lhotari

I want to do it if no one want. could you assign it to me? @lhotari

sure, please go ahead. Just a tip: using generative AI such as ChatGPT is good for fixing grammar issues.

@walkinggo You should first update the documentation files in the docs directory and then in the versioned_docs ONLY for supported versions (version-4.0.x and version-3.0.x). More details in https://github.com/apache/pulsar-site?tab=readme-ov-file#updating-versioned-docs and https://pulsar.apache.org/contribute/document-contribution/#update-versioned-docs .

Thank you ! I will try my best to finish it.

I would like to resolve this issue, but could you please explain the reason? You suggested passing the token as a header rather than as a query parameter, but why is that the case? @lhotari


Holder Metrics endpoint

Add support for new tokens holder_metrics endpoint
Additional context
Token API

Is just starting..

Also adding given endpoint from Token API
https://bloxy.info/api_method_calls/token?method=token_correlated_addresses

Released in 1.2.0


Bugfix: map widget doesn't work when in list field

Summary
Working with netlify-cms to create a list of Points of Interest, each with a Map field, I found that when a map widget is instantiated into a folded list field child (ie. an extant POI in a list of POIs), the OpenLayers Map does not render correctly. The map works as expected when a new list field child is created and the map widget is visible on screen when the OpenLayers Map object is instantiated.
I believe there are actually two issues, one I understand, and one I don't.
When a Map field is rendered into a folded list child:

OpenLayers is not able to determine a height with which to instantiate the map. To solve this, we can tell the OpenLayers Map to .updateSize() when the map becomes visible. This I understand fairly well, and the bulk of this PR is to address this.
The Map container has height 0. Not sure why this is happening, but to mitigate this, I set a style on the container defining a height of 500px. A bit brittle, but workable. Note that this change, alone, does not address the initial observed issue.

Looking forward to any feedback or questions!
I am not sure if a bug report exists for this issue.
Test plan
Let me know if you'd like more comprehensive testing.
Pre:

Post:

And here is a picture of a map with many animals:

Thanks for this! We'll want to avoid hardcoding the concept of an expanding/collapsing parent into our core, or into any individual widget - this fix should be localized within the map widget itself. Maybe it can store its own dom container height in local state and run updateSize() when its height changes?


Initial Support for Checkpoint && Restore

This adds the initial work for implementing checkpoint and restore.  We are still missing the RW layer in this but ctr currently supports binds along with the criu checkpoint data being placed in the content store.
You can play with this PR by running a container, checkpointing it, and then restoring.  I have tested with criu 2.2.
# run an initial container
sudo ctr run --net-host --id test docker.io/library/redis:alpine

# checkpoint it
sudo ctr checkpoint --id test --exit
sha256:44b628f0af2afbca9b15df24cfb9d0d1649f980cc014b34ed57a4b950f22072d

# restore the container
sudo ctr restore --id test sha256:44b628f0af2afbca9b15df24cfb9d0d1649f980cc014b34ed57a4b950f22072d

# ctrl-c to exit and you will see the redis shutdown

When you checkpoint a container, its checkpoint gets placed inside the content store and the client is returned a digest that allows you to build an Index that can be pushed to a registry and pulled later.  You can give the index in the content store using the dist command.
sudo dist content get sha256:44b628f0af2afbca9b15df24cfb9d0d1649f980cc014b34ed57a4b950f22072d

{
   "schemaVersion" : 0,
   "manifests" : [
      {
         "mediaType" : "application/vnd.containerd.container.checkpoint.tar",
         "digest" : "sha256:fc21c179fe1e43316f04a6378725c36616bcb811df0a54e9b982e4069ab5147f",
         "size" : 700416,
         "platform" : {
            "os" : "linux",
            "architecture" : "amd64"
         }
      },
      {
         "mediaType" : "application/vnd.containerd.container.checkpoint.config.v1+json",
         "digest" : "sha256:9037d23dff618df5ae54553eddbfb41b658fe2c0564ad4fccc6c0a36582a6938",
         "size" : 2939,
         "platform" : {
            "os" : "linux",
            "architecture" : "amd64"
         }
      }
   ]
}

When we get the snapshot and rootfs PRs in we will need to add RW checkpointing so that the container's rw layer is included in the index for pushing and migration.
Closes #787

Codecov Report

Merging #862 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #862   +/-   ##
=======================================
  Coverage   59.55%   59.55%
=======================================
  Files           5        5
  Lines         759      759
=======================================
  Hits          452      452
  Misses        199      199
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26a6222...a100aff. Read the comment docs.

ping @boucher

Will try to get this running tomorrow.

Is it possible to get the criu dump/restore logs? It doesn't seem to be stored in the data put into the content store (and the restore process doesn't write anything to the content store anyway). Perhaps we need a flag for passing the work directory?

Confirmed working with CRIU 3.0 on my system.

@boucher what do you think a good solution for the logs should be?  Do you only care about them on failure or all the time?

I only care about them on failure, but its possible some people might care more broadly? I think if there was an easy way to get them on failure that would at least cover 80% of the use though.

@boucher ok I added it to the error message

@dmcgowan @stevvooe this is ready for a first pass on review

@avagin so that is already in master?

@avagin what version of criu do i need to support the freezer change?

@avagin ok, I found the commits.  You had me super confused because you gave me a link on github that made it look like that commits where merged into master but they were still in your PR.  I was so confused...

@crosbymichael not that it matters much, but your runc vendoring change doesn't actually change anything that would affect containerd (it's a README and runc's vendor.conf change). Of course I totally understand that the build of runc matters, and it doesn't hurt to keep the vendored sha in line with the one required to build/run underneath containerd.

@estesp ya, just trying to keep the hashes in sync.  Maybe we should have some type of RUNC_COMMIT file so that people know which runc to build until we hit a 1.0 where we can depend on version numbers instead of commits.

This is ready for another pass of review.

ping @dmcgowan @stevvooe for review :)

A few nits, don't mind them getting addressed in follow up though.
LGTM

@dmcgowan updated

@stevvooe updated with the descriptor change

LGTM


SASS files

What about that 2-year-old topic?
https://github.com/elegantthemes/divi-child-theme-init/issues/2
The idea to provide SASS files for Divi is abandoned?

QA Checklist
Reporter

[ ] Helpful title used

Helpful title format: Scope(s) :: One Sentence To Describe The Issue
Example: VB :: Floating Toolbar :: Jumps To Top Of Page

[ ] Detailed description

Description should usually be 150+ characters.

[ ] Steps to reproduce included
[ ] Support Ticket URL included
[ ] Image and/or gif

Developer

[ ] Steps to reproduce proven solved
[ ] Test included and coverage acceptable and all Tests passing?
[ ] PR description has layman's description of problem and solution and "Areas Affected" listed/explained?
[ ] PR branch includes latest commits from master branch (at the time of checking)?
[ ] Estimated points on issue
[ ] Proper code documentation and conventions?
[ ] Proper RTL appearance
[ ] i18n used if applicable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?

Peer Review

[ ] PR branch includes latest commits from master branch (at the time of checking)?
[ ] Steps to reproduce proven solved
[ ] Affected areas are tested and ok
[ ] Proper code documentation and conventions
[ ] Proper RTL appearance
[ ] i18n used if applicable
[ ] Test(s) included and coverage acceptable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?

Quality Assurance

[ ] All tests passed on CircleCI.
[ ] Steps to reproduce passed, the fix works.
[ ] No errors in console or output
[ ] Affected areas are tested and ok
[ ] The fix does not change a customer's website in any surprising or unintended way

[ ] If Divi's design is adjusted, settings are migrated gracefully and invisibly

Design Review

[ ] UI is to spec
[ ] UX is to spec
[ ] Design is to spec
[ ] No surprising visual changes to a customer's website will be experienced after updating

[ ] Any/all visual changes are migrated gracefully

Dev Review

[ ] Test(s) included and coverage acceptable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?
[ ] i18n used if applicable
[ ] Implementation acceptable, DRY, Scaleable, future safe
[ ] Best practices used, cleverness and grokage, ES6 use, etc.

@web2033 there's a PR for it: https://github.com/elegantthemes/create-divi-extension/pull/255
But seems like not only ideas are abandoned, the whole repo is. No activity for a long time and no responses to comments/questions. Did you manage to add SASS yourself?

Hi @luisnomad
No, I didn't. The whole setup is too complicated for me.
I'd rather build from what Divi offers out of the box or build a project from scratch without Divi.


implement libc::sched_setaffinity on linux

fixes https://github.com/rust-lang/miri/issues/2749
the implementation, like libc::sched_getaffinity, just always returns EINVAL, which kind of simulates a device with zero cpus. I believe the idea is that callers of this function always do it to optimize, so they are likely to gracefully recover from this function returning an error.
based on the libc crate, these functions are also available on android and freebsd (but not on macos or windows). So should the implementation of the sched_* functions just be copied to the android and freebsd shims?

The original motivation stated in the issue was a call site in nix-0.23.2/src/sched.rs:175. What does that code do when EINVAL is returned? Does this help Miri do anything useful in that code?

Allright, I dug into glommi's usage os these functions. for instance they have
#[test]
fn blocking_function_placement_independent_of_executor_placement() {
    let affinity = nix::sched::sched_getaffinity(nix::unistd::Pid::from_raw(0)).unwrap();

this test will just fail on miri because sched_getaffinity always returns EINVAL. The only benefit that you get from miri supporting this function at all is that the arguments to libc::sched_getaffinity are checked (e.g. if you pass in a NULL pointer miri would yell at you about that). The executor_pool_builder_placements test would also hit an unwrap on the result of sched_getaffinity, but it errors earlier on an unsupported syscall:
error: unsupported operation: can't execute syscall with ID 324
    --> glommio/src/sys/membarrier.rs:67:18
     |
67   |         unsafe { libc::syscall(libc::SYS_membarrier, cmd as libc::c_int, 0 as libc::c_int) }
     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't execute syscall with ID 324

That's a separate issue though (no idea how miri should handle that).

Then sched_setaffinity. In glommio it is wrapped in this function
pub(crate) fn bind_to_cpu_set(cpus: impl IntoIterator<Item = usize>) -> Result<()> {
    let mut cpuset = nix::sched::CpuSet::new();
    for cpu in cpus {
        cpuset.set(cpu).map_err(|e| to_io_error!(e))?;
    }
    let pid = nix::unistd::Pid::from_raw(0);
    nix::sched::sched_setaffinity(pid, &cpuset).map_err(|e| Into::into(to_io_error!(e)))
}

which is tested here
#[test]
fn bind_to_cpu_set_range() {
    // libc supports cpu ids up to 1023 and will use the intersection of values
    // specified by the cpu mask and those present on the system
    // https://man7.org/linux/man-pages/man2/sched_setaffinity.2.html#NOTES
    assert!(bind_to_cpu_set(vec![0, 1, 2, 3]).is_ok());
    assert!(bind_to_cpu_set(0..1024).is_ok());
    assert!(bind_to_cpu_set(0..1025).is_err());
}

So this will just fail with miri. Based on the man page this will also fail in general (i.e. even without miri) when

The affinity bit mask mask contains no processors that are currently physically on the system and permitted to the thread according to any restrictions that may be imposed by cpuset cgroups or the "cpuset" mechanism described in cpuset(7).

but this test seems to just assume that that did not happen, and up to 1024 cpus can be configured for the current thread.

I think in general that means that the implementations of {g, s}et_affinity are not that useful for glommio at least, besided checking some safety properties on the arguments.
I'm not sure how miri could do better though. It would have to keep track of the affinity (1024 bits per thread id, with pid 0 mapping to the current thread) in some piece of global state?

We can have a simple-but-wrong implementation that happily says "ok" on setaffinity but just ignores this and returns the full mask on getaffinity. Or we track the per-thread mask in some per-thread state, so that getaffinity can return the right result. Either way it would not have any other effect. I don't have a strong preference either way, but maybe some apps get confused when their setaffinity is not reflected in getaffinity.

based on the libc crate, these functions are also available on android and freebsd (but not on macos or windows). So should the implementation of the sched_* functions just be copied to the android and freebsd shims?

No copy-paste please. You can do it like reallocarray -- have the impl in the generic unix file and guard it on what the concrete OS is.

are there examples of such per-thread state?
I don't think the simple-but-wrong approach is really more useful than the status quo.

I'd suggest you add a new FxHashMap<ThreadId, ...> to MiriMachine.

@rustbot ready
allright, the implementation now simulates the logic in that setting and then getting the mask returns the updated value. the initial value of the mask is based on -Zmiri-num-cpus.

apparently for this target no CPUs are configured? specifically the s390x-unknown-linux-gnu target fails when executed on macos?!
  Error:
     0: ui tests in tests/pass-dep for s390x-unknown-linux-gnu failed
     1: tests failed

  full stderr:
  thread 'main' panicked at tests/pass-dep/libc/libc-misc.rs:80:5:
  assertion failed: unsafe { libc::CPU_ISSET(0, &cpuset) }
  stack backtrace:
     0: std::panicking::begin_panic_handler
               at /Users/runner/.rustup/toolchains/miri/lib/rustlib/src/rust/library/std/src/panicking.rs:661:5
     1: core::panicking::panic_fmt
               at /Users/runner/.rustup/toolchains/miri/lib/rustlib/src/rust/library/core/src/panicking.rs:74:14
     2: core::panicking::panic
               at /Users/runner/.rustup/toolchains/miri/lib/rustlib/src/rust/library/core/src/panicking.rs:148:5
     3: test_affinity
               at tests/pass-dep/libc/libc-misc.rs:80:5
     4: main
               at tests/pass-dep/libc/libc-misc.rs:141:9
     5: <fn() as std::ops::FnOnce<()>>::call_once - shim(fn())
               at /Users/runner/.rustup/toolchains/miri/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5
  note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

https://github.com/rust-lang/miri/actions/runs/9627551162/job/26554759066?pr=3698
we can just skip the test on this platform but it is weird.

s390x is a big-endian architecture, so likely your code is simply not correct for big-endian systems.

Instead of repeating the same cfg over and over, please move these "use" inside the function.

does
//@ignore-target-windows: only very limited libc on Windows
//@ignore-target-apple: `sched_setaffinity` is not supported on macOS
//@ignore-target-wasm32

let through the same targets as
    #[cfg(any(target_os = "linux", target_os = "freebsd", target_os = "android"))]

it's close but there's probably something I'm missing

You don't need the wasm line, we only run very few tests on wasm as it is not fully supported by Miri.

@rustbot author

@rustbot author

That was the last of my comments, thanks and congrats. :)
Please squash it all into one or a few commits (ideally with a force-push that has no diff)

@rustbot ready
yeah lol this "good first issue" escalated quickly

That force-push has quite a big diff unfortunately... you rebased over the latest master instead of keeping the same base commit, didn't you? That makes reviewing a lot harder. :/

ah you meant no diff versus the branch (and not versus the master branch). I can probably revert it back to 467f5e1eb7db71667589ff1f2eedf63163d3a19d again if that is easier

Well there's always a diff to the master branch, it's all your changes. :)
I guess I wasn't clear enough.

I made it lookup the c_ulong type from core to avoid having to hard-code that.
However, in doing that I noticed something odd -- sched_setaffinity still allows sizes that are not a multiple of the chunk size. That can't be right, can it?

For sched_setaffinity an arbitrary size does work, except that the current implementation does not handle the cpusetsize == 0 case
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=b861ccd6ea9d75a3b1146c38f2ff2926
this runs  succesfully
use libc::{cpu_set_t, sched_setaffinity};

const PID: i32 = 0;

fn main() {
    let mut cpuset: cpu_set_t = unsafe { core::mem::MaybeUninit::zeroed().assume_init() };

    unsafe { libc::CPU_SET(1, &mut cpuset) };

    let err = unsafe { sched_setaffinity(PID, 0, &cpuset) };
    assert_eq!(err, -1, "fail for {}", 0);
    assert_eq!(
        std::io::Error::last_os_error().kind(),
        std::io::ErrorKind::InvalidInput
    );

    for i in 1..1024 {
        let err = unsafe { sched_setaffinity(PID, i, &cpuset) };
        assert_eq!(err, 0, "fail for {i}");
    }
}

I'll fix that

Interesting. And the semantics is that it works just as if all the remaining bytes are zero?

that is what I assume but I can't really test that because I only have 8 physical cores on my system. the man pages say this
       sched_setaffinity()  sets the CPU affinity mask of the thread whose ID is pid to the value specified by mask.  If pid is zero, then the
       calling thread is used.  The argument cpusetsize is the length (in bytes) of the data pointed to by mask.  Normally this argument would
       be specified as sizeof(cpu_set_t).

so the bytes thing is documented. What happens to any unspecified bytes isn't but assuming zeros seems like the logical choice.

Makes sense. Maybe leave a comment in the source saying that this part is guesswork.

yeah lol this "good first issue" escalated quickly

It did.^^ It's not always easy to predict how much research will be required to implement some API...
Thanks for seeing this through!
@bors r+

:pushpin: Commit a2a280bc1ea3d84674ab26c0108a12516d0f3714 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit a2a280bc1ea3d84674ab26c0108a12516d0f3714 with merge 22dae19452ca604130f59610bc67e3467778a341...

:broken_heart: Test failed - checks-actions

that test failure is legit, in that on a big-endian system like s390x-unknown-linux-gnu giving it one byte of the cpu mask codes for CPUs 56..64 which are not available on the system... so in practice you'd likely want to work in multiples of the chunk size anyway, at least on BE systems.
So if we make the loop bound here start at 8 on BE systems things work as expected again
    // any other number of bytes (at least up to `size_of<cpu_set_t>()` will work
    for i in 1..24 {
        let err = unsafe { sched_setaffinity(PID, i, &cpuset) };
        assert_eq!(err, 0, "fail for {i}");
    }

So if we make the loop bound here start at 8 on BE systems things work as expected again

Yeah, something like that.

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 8f40dd256384883b78700bc348e7f5f272f131ca to master...


pure - df, pure_arrayperformance and pure_arraydetails

Would that be possible to include those stats in the plugin please?

i just noticed i got the values after upgrading to 2.1.0p28


Daijisho crashing everytime I show details after 1 sec

Hi,
On my Odin 2, last version of Daijishō, new user (enjoy).
Everytime i want to show detail of a game (no matter on what platform) the app crash. I can brievely see the page like under a second.
I've clear caache/data of the playstore, issue remain.
Thank you !
I can post video, or log if it help

After a reboot few minutes in idle, i've retried and it's now OK, i think the scrapping wasn't finished

After few try it seems random. when i restart my odin 2, the crash when i open details came back again

Please find below a video ↓
https://github.com/TapiocaFox/Daijishou/assets/16538756/f353ccaa-ea72-412e-891b-4a971806b491

I have the same issue, happens across platforms and a reboot/waiting has not resolved for me


Wip: add fs-version arsg for pack subcommand

fix #528
Signed-off-by: zyfjeff<EMAIL_ADDRESS>

@zyfjeff , a new test job has been submitted. Please wait in patience.

@zyfjeff , The CI test is completed, please check result:

Test CaseTest Result

merge-target-branch:white_check_mark:SUCCESS

build-docker-image:white_check_mark:SUCCESS

compile-nydus:white_check_mark:SUCCESS

compile-ctr-remote:white_check_mark:SUCCESS

compile-nydus-snapshotter:white_check_mark:SUCCESS

start-nydus-snapshotter-config-containerd:white_check_mark:SUCCESS

run-container-with-nydus-image:white_check_mark:SUCCESS

Congratulations, your test job passed!


Deferred Status

Summary
Adds a context.deferred property that tracks if an application command in the given context is currently deferred.
Checklist

[X] I have run nox and all the pipelines have passed.
[ ] I have made unittests according to the code I have added/modified/deleted.

I will implement this myself


add new column for even screen split system

I've decided it would be better if we have opportunity to use grid system when we have to split screen in 10 parts , 5 parts , 2 parts and 3 parts,1 part and 4 parts , So I've several case when it was needed to split screen like this and I've made solution to extend bootstrap grid  , so it can help others to save time who has that kind of cases which I had , I've called it column even so there are col-even-(xs, sm, md,lg )-(1,2,4,6,8,10)

Hi @theMarkupist!
Thanks for wanting to contribute to Bootstrap by sending this pull request!
Unfortunately, your pull request seems to have some problems:

Changes must be made to the original Sass or Less source code file(s), not just the compiled CSS file(s).

You'll need to fix these mistakes and revise your pull request before we can proceed further.
Once you've fixed these problems, you can either ask the maintainers to re-open this pull request, or you can create a new pull request.
Thanks!
(Please note that this is a fully automated comment.)

Successor: #20125


rp2040: Add missing comma in rp2040_i2c_slave.c

This patch fixes missing comma, found by cppcheck.
rp2040_i2c_slave.c:259:0: error: failed to expand 'modbits_reg32',
Wrong number of parameters for macro 'modbits_reg32'.
Signed-off-by: Masanari Iida<EMAIL_ADDRESS>

@standby24x7 is it possible to integrate cppcheck(or even https://github.com/Ericsson/codechecker) to CI system so we can catch the problem before merging?


We should be able to group by age groups.

Examples:
No Grouping
Group by 2
Group by 5
Sweden Group by 5


I am getting an error with IDA9 -

On line 659:
start_addr = idaapi.cvar.inf.min_ea
end_addr = idaapi.cvar.inf.max_ea
I don't think IDA 9 had this object:
idaapi.cvar.inf.min_ea or  idaapi.cvar.inf.max_ea
need o replace it with:
import ida-ida
...
        start_addr = ida_ida.inf_get_max_ea()
        end_addr = ida_ida.inf_get_min_ea()

Thank you for the information and for providing the correction code.
Please continue to contact me if you have any errors or requests.


Out of Memory, process killed by enumerate(tr_loader)

Hi, I got such an error when I wanna run the train.py in a docker container following the README, could you please tell me why it is happening? My RAM is 64GB. Thank you very much!
[275167.571578] oom-kill:constraint=CONSTRAINT_NONE,nodemask=(null),cpuset=containerd.service,mems_allowed=0,global_oom,task_memcg=/system.slice/docker-20655d2ab3f63b26ba1035325333ea4aeb4c7443f7a9ada285a5b190441acfba.scope,task=python,pid=140359,uid=1001 [275167.571636] Out of memory: Killed process 140359 (python) total-vm:73883040kB, anon-rss:59102060kB, file-rss:67584kB, shmem-rss:8192kB, UID:1001 pgtables:117500kB oom_score_adj:0
`
===== RUN NAME: JCBM3  (runs/JCBM3) =====
{'augmentations': [],
'backbone': 'pointnet2',
'batch_size': 32,
'config': None,
'dataset': 'cuboids-v1',
'debug': False,
'discr_lambdaGP': 10,
'discr_train_iter': 1,
'epochs': 1250,
'eval_ckpt': 'best',
'eval_freq': 100,
'eval_metrics': ['pcd'],
'extra_data': ['orientnorm'],
'group': None,
'knn_gcn': 20,
'knn_repulsion': 1,
'lambda_points': 4,
'loss': ['chamfer', 'rich_attraction_chamfer'],
'lr': 0.001,
'min_centroids': False,
'name': None,
'no_save': False,
'normalization': 'per-dataset',
'notes': None,
'output_dir': 'runs',
'overfitting': False,
'overlapping': 0,
'pc_points': 5120,
'pretrained': True,
'rep_target': None,
'seed': 42,
'soft_attraction': False,
'steplr': 100,
'traj_points': 2000,
'weight_align': 1.0,
'weight_attraction_chamfer': 1.0,
'weight_chamfer': 1.0,
'weight_discr_training': 1.0,
'weight_discriminator': 1.0,
'weight_intra_align': 1.0,
'weight_mse': 1.0,
'weight_orient': 0.25,
'weight_repulsion': 1.0,
'weight_rich_attraction_chamfer': 0.5,
'weight_velcosine': 1.0,
'weight_wdiscriminator': 1.0,
'workers': 0}
Number of output vectors (mini-sequences or single poses): 500
epoch 0
Killed
`

Dear @Yucheng-Tang,
unfortunately I never tried docker with this project and I'm unsure why you're getting such error. A RAM of 64gb seems to be more than enough.
Have you ever tried launching the training script without a docker container?

Dear @gabrieletiboni ,
thanks for the reply, I solve the problem yesterday! :)
The problem is probably that the latest version of point-cloud-utils package has changed the definition of sample_mesh_poisson_disk() which is used by the PaintNetDataloader.getitem().
https://github.com/fwilliams/point-cloud-utils/blob/387b84f658efc10464e7c3cf5bed5f54c1c711e3/docs/docs/sections/mesh_sampling.md?plain=1#L51
 This can be achieved with Poisson Disk Sampling. Point cloud utils supports sampling a mesh such that there are either … fid, bc = pcu.sample_mesh_poisson_disk(v, f, num_samples=target_num_pts) fid, bc = pcu.sample_mesh_poisson_disk(v, f, num_samples=-1, radius=target_radius)
I removed radius=0.5 from the function and it works now. But still thanks for the reply, I'm very excited that I can now try paintnet!

Oh sweet! Thank you for noticing that. Could you please tell me which versions of point-cloud-utils you tried (which one did not work and which one did work)?
For my experiments I'm currently using point-cloud-utils==0.27.0, and it works just fine.
Happy to know you're excited to play around with PaintNet! I'm currently working on minor improvements to the training pipeline which is able to get slightly better results w.r.t. the conference paper (i.e. tiny changes to the loss functions and more stable hyperparameters). For example, simply training for longer epochs is helpful by itself. Either way, I'll push new public changes once we have our Journal extension officially ready, ~1/2 months from now :+1:

Hi, I am using the latest version of point-cloud-utils===0.30.4.
After playing around with the PaintNet a little bit, I have some more questions:

how the scan paths in the dataset were generated, in the paper it was only briefly described that they were manually drawn by an expert. Is there any specialized software or pipeline available that allows one to manually generate such trajectories? I would like to generate some datasets with other objects.

I also observed that it seems like the IDs of the trajectory points generated from the PaintNet are messed up, e.g. for cuboid the trajectory points on the same surface are not the same, is this normal?

Thanks a lot in advance! I'd appreciate it if you could take the time to answer those;)

Oh sweet! Thank you for noticing that. Could you please tell me which versions of point-cloud-utils you tried (which one did not work and which one did work)?
For my experiments I'm currently using point-cloud-utils==0.27.0, and it works just fine.
Happy to know you're excited to play around with PaintNet! I'm currently working on minor improvements to the training pipeline which is able to get slightly better results w.r.t. the conference paper (i.e. tiny changes to the loss functions and more stable hyperparameters). For example, simply training for longer epochs is helpful by itself. Either way, I'll push new public changes once we have our Journal extension officially ready, ~1/2 months from now 👍

I have same problem, could you kindly add package versions in the requirements.txt?


bug: When adding Windows as a platform, android icons are added

Type: bug
Platform: desktop browser
When I start a fresh app and add Windows as a platform, android icons are downloaded:
S:\Dev\Ionic\WindowsSample1>ionic platform add windows
Updated the hooks directory to have execute permissions
Downloading Default Ionic Resources
Downloading: https://github.com/driftyco/ionic-default-resources/archive/master.zip
[=============================]  100%  0.0s
Done adding default Ionic resources
Adding icons for platform: android
Adding windows project...
Running command: cmd "/s /c "C:\Users\marka.cordova\lib\npm_cache\cordova-windows\4.1.0\package\bin\create.bat S:\Dev\Ionic\WindowsSample1\platforms\windows com.ionicframework.windowssample1986598 WindowsSample1""
Creating Cordova Windows Project:
App Name  : WindowsSample1
Namespace : com.ionicframework.windowssample1986598
Path      : S:\Dev\Ionic\WindowsSample1\platforms\windows
Copying template to S:\Dev\Ionic\WindowsSample1\platforms\windows
Running command: "C:\Program Files\nodejs\node.exe" S:\Dev\Ionic\WindowsSample1\hooks\after_prepare\010_add_platform_class.js S:\Dev\Ionic\WindowsSample1
add to body class: platform-windows
Installing "cordova-plugin-console" for windows
Installing "cordova-plugin-device" for windows
Installing "cordova-plugin-splashscreen" for windows
Installing "cordova-plugin-statusbar" for windows
Installing "cordova-plugin-whitelist" for windows
This plugin is only applicable for versions of cordova-android greater than 4.0. If you have a previous platform version, you do not need this plugin since the whitelist will be built in.
Installing "ionic-plugin-keyboard" for windows
Saving platform to package.json file
S:\Dev\Ionic\WindowsSample1>

Greetings @mavenius!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

I chose desktop somewhat arbitrarily, because Windows isn't available as a platform in the custom issue form.

Thanks for submitting this issue! As this issue is more related to the ionic cli i will be moving this issue there. Please feel free to continue the conversation there!

This issue was moved to driftyco/ionic-cli#843


lots per village in superflat

https://imgur.com/NqXv8zc
this is a thing

What is the world seed? It works fine on my end.

What is the world seed? It works fine on my end.

just about any superflat does from what i've tried, have tried a load... some villages span with none, some spawn with a whole bunch...  for example the seed "seed" has 3 waystones at 10000 10 -10000
fabric-api-0.29.0+1.16
wraith-waystones-1.1.0

just about any superflat does from what i've tried, have tried a load... some villages span with none, some spawn with a whole bunch...  for example the seed "seed" has 3 waystones at 10000 10 -10000
fabric-api-0.29.0+1.16
wraith-waystones-1.1.0

This should be fixed in the latest commit.
Releasing on CurseForge later today or tomorrow.


Large model (762M) keeps repeating the same utterance

I tried running the large model (in a colab notebook) using the approach described in the model card from the huggingface library:
from transformers import AutoModelWithLMHead, AutoTokenizer
import torch

tokenizer = AutoTokenizer.from_pretrained("microsoft/DialoGPT-large")
model = AutoModelWithLMHead.from_pretrained("microsoft/DialoGPT-large")

# Let's chat for 5 lines
for step in range(5):
    # encode the new user input, add the eos_token and return a tensor in Pytorch
    new_user_input_ids = tokenizer.encode(input(">> User:") + tokenizer.eos_token, return_tensors='pt')

    # append the new user input tokens to the chat history
    bot_input_ids = torch.cat([chat_history_ids, new_user_input_ids], dim=-1) if step > 0 else new_user_input_ids

    # generated a response while limiting the total chat history to 1000 tokens,
    chat_history_ids = model.generate(bot_input_ids, max_length=1000, pad_token_id=tokenizer.eos_token_id)

    # pretty print last ouput tokens from bot
    print("DialoGPT: {}".format(tokenizer.decode(chat_history_ids[:, bot_input_ids.shape[-1]:][0], skip_special_tokens=True)))

Unfortunately, the output seems to quickly repeat the same sentence over and over again. In example 1 and 2, it repeats the same sentence from the beginning. In the 3rd case, the model starts fine, but as the conversation progresses, it starts repeating the same thing (or parts of it).
Is that an intended behavior?
Example 1
>> User:Today, I bought some ice cream.
DialoGPT: I'm so sorry.
>> User:Why are you sorry?
DialoGPT: I'm sorry for your loss.
>> User:What loss? I didn't lose anything.
DialoGPT: I'm sorry for your loss.
>> User:I'm very confused by what you are saying.
DialoGPT: I'm sorry for your loss.
>> User:Ok, nevermind.
DialoGPT: I'm sorry for your loss.

Example 2
>> User:Can't wait to upvote this 17 different times later this week.
DialoGPT: I'm going to upvote it every time.
>> User:What are you going to upvote every time?
DialoGPT: I'm going to upvote it every time.
>> User:Uh sure, if that's what you want.
DialoGPT: I'm going to upvote it every time.
>> User:I'm very confused by what you are saying.
DialoGPT: I'm going to upvote it every time.
>> User:What's your name?
DialoGPT: I'm going to upvote it every time.

Example 3
>> User:I like to walk my dog in the park.
DialoGPT: I like to walk my dog in the park.
>> User:That's great. What's your dog breed?
DialoGPT: He's a mix of some sort.
>> User:That's funny, you don't even know what mix it is.
DialoGPT: I know what mix it is.
>> User:What is it, then?
DialoGPT: A mix of some sort.
>> User:What sort? "Sort" is not a type of dog.
DialoGPT: I know what mix it is.
>> User:That's not the issue. I'm talking about your dog's breed.
DialoGPT: I know what mix it is.
>> User:Then tell me!
DialoGPT: I know what mix it is.
>> User:What are you waiting for?
DialoGPT: I know what mix?
>> User:Are you serious?
DialoGPT: I know what?
>> User:What?
DialoGPT: I know what?

Hi @xhlulu. This is a known issue that transformers tend to copy things. My suggestion would be that you can try either do random generation with higher temperate, or add a repetition penalty to the generation to explicitly penalize repeating the context.

Thank you! Is that possible with huggingface's transformers, or would I need to use the original model (in this repo)?

They are the same model, so either is fine. You can use huggingface's decoding script for GPT-2 and change it a bit to adapt to DialoGPT. There you should be able to tweak the temperature or add repetition penalty.

Awesome, thanks for the advice! I'll try out this decoding script and close this issue if no problems arise.

@xhlulu could workaround the problem? I'm experiencing exactly the same issue

I tinkered a bit w the temperature and top-p parameters and got decents results, this is my code:
`
Let's chat for 50 lines
for step in range(50):
# encode the new user input, add the eos_token and return a tensor in Pytorch
new_user_input_ids = tokenizer.encode(input(">> User:") + tokenizer.eos_token, return_tensors='pt')
# append the new user input tokens to the chat history
bot_input_ids = torch.cat([chat_history_ids, new_user_input_ids], dim=-1) if step > 0 else new_user_input_ids

# generated a response while limiting the total chat history to 1000 tokens,
chat_history_ids = model.generate(bot_input_ids, max_length=1000, pad_token_id=tokenizer.eos_token_id, temperature=0.6, repetition_penalty=1.3)

# pretty print last ouput tokens from bot
print("DialoGPT: {}".format(tokenizer.decode(chat_history_ids[:, bot_input_ids.shape[-1]:][0], skip_special_tokens=True)))

`

Thanks for sharing! I'll try this with my own bot

I just tried your method, as well as the top-p/top-k method from the huggingface tutorial. Here are the results.
Greedy
# Let's chat for 5 lines
for step in range(5):
    # encode the new user input, add the eos_token and return a tensor in Pytorch
    new_user_input_ids = tokenizer.encode(input(">> User:") + tokenizer.eos_token, return_tensors='pt').to('cuda')

    # append the new user input tokens to the chat history
    bot_input_ids = torch.cat([chat_history_ids, new_user_input_ids], dim=-1) if step > 0 else new_user_input_ids

    # generated a response while limiting the total chat history to 1000 tokens,
    chat_history_ids = model.generate(bot_input_ids, max_length=1000, pad_token_id=tokenizer.eos_token_id)

    # pretty print last ouput tokens from bot
    print("DialoGPT: {}".format(tokenizer.decode(chat_history_ids[:, bot_input_ids.shape[-1]:][0], skip_special_tokens=True)))

Result:
>> User:Today, I bought some ice cream.
DialoGPT: I'm going to buy some ice cream.
>> User:Ok, but hwy?
DialoGPT: I'm going to buy some ice cream.
>> User:Fine.
DialoGPT: I'm going to buy some ice cream.
>> User:Stop
DialoGPT: I'm going to buy some ice cream.

Temperature + repetition penalty (from @pablonm3)
for step in range(5):
    # encode the new user input, add the eos_token and return a tensor in Pytorch
    new_user_input_ids = tokenizer.encode(input(">> User:") + tokenizer.eos_token, return_tensors='pt').to('cuda')

    # append the new user input tokens to the chat history
    bot_input_ids = torch.cat([chat_history_ids, new_user_input_ids], dim=-1) if step > 0 else new_user_input_ids

    # generated a response while limiting the total chat history to 1000 tokens,
    chat_history_ids = model.generate(bot_input_ids, max_length=1000, pad_token_id=tokenizer.eos_token_id, temperature=0.6, repetition_penalty=1.3)

    # pretty print last ouput tokens from bot
    print("DialoGPT: {}".format(tokenizer.decode(chat_history_ids[:, bot_input_ids.shape[-1]:][0], skip_special_tokens=True)))

Result:
>> User:Today, I bought some ice cream.
DialoGPT: I'm going to buy a boat.
>> User:Wow that was random! but happy for you
DialoGPT: It's not like he has anything else to do!
>> User:What has what?
DialoGPT: A boat?
>> User:You said he?
DialoGPT: No, I didn't say him. He is the one who said it.
>> User:Ok fine. Whatever you say
DialoGPT: He's just saying that because of his name.

Top-p + top-k (from the tutorial)
# Let's chat for 5 lines
for step in range(5):
    # encode the new user input, add the eos_token and return a tensor in Pytorch
    new_user_input_ids = tokenizer.encode(input(">> User:") + tokenizer.eos_token, return_tensors='pt').to('cuda')

    # append the new user input tokens to the chat history
    bot_input_ids = torch.cat([chat_history_ids, new_user_input_ids], dim=-1) if step > 0 else new_user_input_ids

    # generated a response while limiting the total chat history to 1000 tokens,
    chat_history_ids = model.generate(
        bot_input_ids,
        do_sample=True,
        max_length=1000,
        top_k=50,
        top_p=0.95,
        pad_token_id=tokenizer.eos_token_id
    )

    # pretty print last ouput tokens from bot
    print("DialoGPT: {}".format(tokenizer.decode(chat_history_ids[:, bot_input_ids.shape[-1]:][0], skip_special_tokens=True)))

Result:
>> User:Today, I bought some ice cream.
DialoGPT: Me too! :D
>> User:Nice! What brand did you buy?
DialoGPT: Strawberry and Vanilla
>> User:That's not a brand!
DialoGPT: Yup :P
>> User:Ok fine, anyway. What else did you do?
DialoGPT: I ate candy bars
>> User:cool! Were they good?
DialoGPT: They were. It was kinda like a snickerdoodle from my younger years.

Hy @xhlulu
I am also encountering the same issue of repeated utterance and tired the above mentioned solution (with different combinations of parameters), but utterances generated are still same. I am using a self-generated data to train the model.
I have attached few screenshots for your reference

I am trying to train a transformer-based model, but my model always generates the same word as follows

and my code is here

How can I fix it?

im also trying to use DialoGPT model, I fine-tuned it with a dataset related to my task. here is an example of what I went through.
User: im happy
Psychobot: im happy�'m feeling really down and hopeless. What can I do to feel better? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do? What can I do???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m?'m????'m?????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????'m not?'m not?'m not?'m not?'m?'m?'m?'m?'m?'m'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm'm
how can I solve this issue? should I repeat the fine-tune process? or use another dataset?
this is the link of the dataset I used to fine-tune DialoGPT. https://huggingface.co/datasets/jkhedri/psychology-dataset
although I dropped the last column because it generates bad answers.


WIP: check file headers

Makefile: Add CI for porch controllers
Check headers in CI

Thanks - I think we did this via the fix-all approach, so I'm going to close.


Bring all windows in a node in front of other nodes

Given the following tree:
       R
     /    \
    a    N
        /     \
       b     c

When switching from window a to window b or c, a should appear behind all leaf windows in node N (b and c). For example, if ais behindb, and you focus cthenawill currently stay in-front ofbeven thoughbis a sibling to the currently focused windowc. Changing this such that aappears behindbeven thoughc` was the focused window will help as a visual cue to orientation when navigating nodes in the tree.

Duplicate of #24 ?

Duplicate of #24 ?

Not necessarily a duplicate, but perhaps related in that this is asking for improvement on z-index ordering of windows for accordion nodes. Though, it's not strictly an accordion problem. Sometimes even when there are tile windows that contain windows overlapping outside of their tile container (which happens due to minimum window size constraints for some apps), then the z ordering improvements suggested here will impact those cases as well.

Absolutely not a duplicate. If I have an accordion of tile layouts, when I move in the direction of the accordion I would expect the next tile layout would load entirely, not load a single split window and then I need to focus in the other axis to bring the rest of the tile container's windows forward. This is not a visualization improvement, it's a behavior change that matches the expectation, the expectation being you can navigate between containers and not just leaf nodes. Triggering a leaf node should bring along by default or by configuration the other leaf nodes in the closest parent container. Otherwise stacking containers on containers is not really feasible, even if the docs say you can do it.

I think this should be the expected behavior. Right now, changing accordion tab would only show 1 sub-child of that tab.

This make it really hard to tell what the other sub child is.


Backport some production fixes

Follows #24
Tests should pass now, duno how to run Travis on a PR :/

Thank you so much for your work!
I added some (free) credits to my Travis account yesterday. Now PRs seem to get tested.


Added utilities and tests for text media matching

Added text media matching utilities
Added tests for text media matching

This looks good! Is there anything apart from tests left to do in this PR?

I've added tests along with descriptions as well. Please do take a look at that as well.
Since the similarity between sentences cannot be measured accurately the tests are approximate .
Let me know if this requires any changes!

This looks good! Is there anything apart from tests left to do in this PR?
@tmadhuri
IMO, we should add a test for any major processing that we do on the data eg. in this case, we should add a test to verify if the preference matrices are constructed properly and to check that the similarity score works as intended. WDYT?

This looks good! Is there anything apart from tests left to do in this PR?
@tmadhuri
IMO, we should add a test for any major processing that we do on the data eg. in this case, we should add a test to verify if the preference matrices are constructed properly and to check that the similarity score works as intended. WDYT?

@tmadhuri
That sounds like a great idea . Will update accordingly !

Added Tests for the following :

Formation of preference matrix
Stable matching algorithm
Text media matching for the following cases:

Text and Media with same indices ( matching based only on content similarity )
Text and Media with different indices ( matches based on both content and distance)
Matching with Bad media attributes ( checks if it takes maximum of similarities )
Related Text and Media are spread out ( do not occur nearby but content is related)
Matching with all contents very similar but still distinguishable


fix bincode deserialization

Currently, the current bincode de/serialization has a bug:

When serializing, a byte array is used from the PublicKey::serialize method.
Then when deserializing, the attempt is made by default to deserialize directly into a PublicKey instead of calling the corresponding PublicKey::parse_slice function.

Additionally, bincode serialization isn't covered in the tests.
Therefore, this PR does the following:

Implement and use a new PublicKeyBytesVisitor for deserializing bytes to a PublicKey (Closes #97).
Add a test to cover bincode serialization / deserialization.
Return the base64 decoding error instead of unwrapping (Closes #105).

Hey @sorpaas,
when will we see this deployed to crates?


Playfab integration

Hello, I am using shooter IO pun with the playfab integration the google play login and facebook login do not work anymore as the code is out of date and GPGS does not use the same methods.
The serious problem is when you purchase an item using currency that Item does not get updated and does not appear Unless you purchase another item. Also if you log out or leave game everything you have purchased will disappear but will show back up when you buy something. Can you please look into these issues.

I will check it.

Thank you for looking into it its really giving me problems

Updated, now it logins should work

Thank you but what about the problems with pulling the items from server was that also fixed.

Try add these codes

        var uis = FindObjectsOfType<UIProductList>(true);
        foreach (var ui in uis)
        {
            ui.onPurchaseSuccess.RemoveListener(UpdateAvailableItems);
            ui.onPurchaseSuccess.AddListener(UpdateAvailableItems);
        }

to Start function in UIMainMenu class

I added that code to the Start function and Items bought are still not being pulled from playfab server if I buy something else everything updates but again when I log out or close game everything still disappears. and I checked playfab inventory and all purchased items are there like characters and weapons just not showing up on players end.

https://youtu.be/eveakjLsERQ

Also please note google play login just says login cancelled when trying to use it. download directly from google play store using internal testing FB login just crashes the app

May I try by using AnyDesk?

AnyDesk the remote desktop client?

Yes, you can send your info to my email<EMAIL_ADDRESS>

should be sent to your email my email is<EMAIL_ADDRESS>

Didn't receive yet.

Sent again using second email<EMAIL_ADDRESS>

Also Is it possible to have more the 1 match making scene seems like matching making only works with scene and gameplay rule set in GameNetworkManager unless I’m mistaking. And thank you for all the help.

Not sure how are you going to use it?

Basically what I was trying to achieve was have different matching making for deathmatch teamdeath match and the BR so just how the gamenetwork instance works just be able to choose which scene and gameplay rule instead of it just being one

So I figured out you can change gameplay rule so but is How can a make it so it choose a random Map instead of same scene for example

Instead of just having the one map maybe set it as an array where it can choose a random map from the list

Hey message me I know how to fix that and what you're looking for brother

If you have the same name on discord I sent you a message


IF chat prompt does't get the image

I load a image to IF chat prompt image input, and ask for describing the picture, but the response is not correct,, it seems that the node does't get the image.

Yes for images you need a multi-modal model LlaMA3 is just for text here is a link for a LLaVa1.6 ollama run llava:7b-v1.6-mistral-q5_0 you can also see all the available models here on this list the bigger they are the better quality you get but also take more resources like vram etc.. https://ollama.com/library/llava if you click on the latest dropdown you can check them up

It works after I get the llava switch the model in the IF-AI node, thank you very much!

Thank you, I will close the issue then

After running the command "ollama run llava" the model is automatically downloaded to the C drive, do I need to move the model to a certain folder, my node does not recognize the model! thanks

no if ollama is running it should see the model if you open your terminal and type ollama list and llava is listed it should be also in comfy is the same command. so if llama service is running comfy should see it

no if ollama is running it should see the model if you open your terminal and type ollama list and llava is listed it should be also in comfy is the same command. so if llama service is running comfy should see it

thanks,I'm going to reinstall 0.1.25, I had the latest version installed previously

No the very last version works fine I have been using it they fix that issue

No the very last version works fine I have been using it they fix that issue

Sorry to interrupt again, I reinstalled 0.1.25 and still can't load ollama's model, and the reply given by claude3 doesn't seem to help!

if you are in the same computer try writing <IP_ADDRESS> as base ip instead of localhost could you give it a try please

in your username in your computer locate that file open it see any message with source=routes to check if that is your base_ip

if you are in the same computer try writing <IP_ADDRESS> as base ip instead of localhost could you give it a try please

这对我有效，太感谢了，这个文件我找到了，和您说的一样

if you are in the same computer try writing <IP_ADDRESS> as base ip instead of localhost could you give it a try please

This worked for me, thanks so much, I found this file and it's exactly what you said

nice thanks, glad it works now


Experiments: Add a Gradle task for updating workflows-kt

@aSemy we now have just a single workflow, and it's easy to regenerate the YAML by just executing the script either via the command line or the IDE. Let me close this PR as it looks stale, and we can always get back to it.

sure thing, this was just an experiment/demo :)


Nested annotation regions

Often my users want to annotate regions within region.  Right now the behavior to draw a new region within an existing first selects the larger parent region which interferes with the drawing.  Is it possible to allow for drawing of nested regions?  At the moment we have to draw the child annotation outside of the parent and drag it in.
Thanks again!

This works, in fact, fine in "standard" Annotorious. But it's a known issue in the OpenSeadragon version... (I'm moving the issue to the AnnotoriousOSD repo.) I actually need this fixed myself in one of my day-job projects, i.e. should hopefully be able to resolve this soon.


ioutil.TempFile return something which looks like a valid file when base dir does not exists.

I might be doing something wrong, as this looks like very basic behaviour, still I could not find the error on my side.
What version of Go are you using (go version)?
$ go version
go version go1.9 linux/amd64

but I have also found it on 1.8
Does this issue reproduce with the latest release?
Yes.
I can also reproduce it on https://play.golang.org/p/IDMHXJFdMA
What operating system and processor architecture are you using (go env)?
Linux on amd64
I can also reproduce it on Travis-CI
https://travis-ci.org/adiroiban/vbox-ec2-md/jobs/269533011#L430
What did you do?
https://play.golang.org/p/IDMHXJFdMA
What did you expect to see?
I was expecting to see a failure to open / create the file.
If the parent path exists, all is good and it fails to open it https://play.golang.org/p/ly0_Q1oUXl
What did you see instead?
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0xffffffff addr=0x0 pc=0xd9f86]

This is not a bug. The testify suite method Nil does not terminate the test in the presence of an error. Because processing is not terminated, execution proceeds to this line
https://github.com/adiroiban/vbox-ec2-md/commit/67ee8f8dc1a4326b79e0c58b9e46b233ee45bfaa#diff-53618cae32e23ae47e1c35f10da92654R53
Which panics because the contents of the other values returned from ioutil.TempFile are not defined and cannot be used in the presence of an error.
i am going to close this as it does not look like this is a bug in Go. Please reopen if you disagree.

True. My bad. Much appreciated! Sorry for the noise.

It might be worth raising a bug on the testify project to use FailNow,
rather than Fail inside assert.Nil
On Tue, 29 Aug 2017, 22:12 Adi Roiban<EMAIL_ADDRESS>wrote:

True. My bad. Much appreciated! Sorry for the noise.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/21680#issuecomment-325644470, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAcA8XOjxWvohtHpY1QfgATc64r1Iuuks5sdAAugaJpZM4PFwSp
.


The response time of "Login", "CreateUser" function is much higher than other functions like "GetSatellites", "GetPlanets"

The response time of "Login", "CreateUser" function is much higher than other functions like "GetSatellites", "GetPlanets"

When I execute the command GraphQL: mutation CreateUser: Ping 515ms

mutation CreateUser($user: UserInput!) {
  createUser(user: $user) {
    firstName
    lastName
    username
    role
  }
}

When I execute the command GraphQL: mutation CreateUser: Ping 46ms

query GetSatellites {
  getSatellites{
    id
    name
    lifeExists
    firstSpacecraftLandingDate
  }
}

I have a feeling but the function that needs to validate the Token has a much higher response time than the function that doesn't need to authenticate, please help me.

In general, this is because of the operations performed under the hood on the server: SQL insert in case of CreateUser and JWT generation in case of Login.

The response time of "Login", "CreateUser" function is much higher than other functions like "GetSatellites", "GetPlanets"

First, let's compare GetSatellites and GetPlanets vs CreateUser. In general, SQL writing operations are slower than reading (because the writing do multiple things under the hood that are not performed in reading queries).
Also, could you try to execute CreateUser 3-4 times consequently? It may turn out that its first execution has the biggest time.
Login probably doesn't do any SQL writing operations but JWT generation is not the cheapest operation as well.

I have a feeling but the function that needs to validate the Token has a much higher response time than the function that doesn't need to authenticate, please help me.

 Also, it is interesting how much time takes password hashing.
It would be more informative to compare times of GraphQL operations of one type: 2 queries or 2 mutations. To evaluate authentication time you can try to execute the same operation with and without a roleGuard.


Cant click accept on the first popup

I have just installed cianemu, and basically I get a popup saying that there are some diferences between cyanemu and a true vrc instance, and click accept to make the window go away.
The problem is that no many times do I click it or how much I try to restart cyanemu or unity, the window does not go away.
Help me plz :(

also, the console is constantly spitting this error:
NullReferenceException: Object reference not set to an instance of an object
VRCPrefabs.CyanEmu.CyanEmuPlayerController.OnGUI () (at Assets/CyanEmu/Scripts/CyanEmuPlayerController.cs:1025)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)

CyanEmu does not have a popup mentioning differences between VRC client. The popup was added in ClientSim. Do you happen to have both ClientSim and CyanEmu imported? I recommend removing CyanEmu and looking at the ClientSim known bugs instead.
https://github.com/vrchat-community/ClientSim
The second error mentioned implies you are missing or renamed files and would require deleting and reimporting. Again, you should look into using ClientSim instead of CyanEmu.


Add drone-plugin GitHub tags

It might help with visibility & search to add some tags to this repo? :)
For example: https://github.com/songsterr/drone-kubernetes-job.

Done!
Thanks for the suggestion 😄


Tracker issue for 4.15 readiness

[x] https://github.com/crc-org/snc/issues/830
[x] #838
[ ] #850

4.15.0-rc4 qe pass

Bundle is generated and in testing phase.


accessibility issue in web site (dimensions set in pixels)

web site uses pixels to define max-width of the #content element. This is an accessibility issue for people with large font needs, because it doesn't expand with the fonts that are being used.
recomended quickie-fix: just delete the max-width attribute. the site works fine without it.
long term fix: scan the css for any use of pixels to specify with and replace with sizing directives that are to font size, like rem em and so on.

(ignore the color scheme in the screenshot. that's just DarkReader kicking in to compensate for bright pages)

I have only a modicum of expertise at HTML/CSS design but I am inclined to agree with @masukomi that pixel based sizing should not be used; with the possible exception of some esoteric situations that do not seem applicable to the Elvish website. Note that this applies not just to the max-width property but also min-width:
website/style.css:@media (min-width: 600px) and (max-width: 899px) {

Also, several other properties, such as those related to margins and borders, currently use pixel based sizes that might be better expressed in other units. Even without considering support for "accessibility" the reality is that viewers of the Elvish website may span a wide range of pixel density. Which means that something like 3px may render radically differently depending on the platform being used.
If there are any Elvish users with a modicum of web UI expertise it would be great if you expressed an opinion.


Fix memory leak in ASN.1

Affects 1.1.0 dev branch only; introduced around commit
f93ad22f6adb00e722c130e792799467f3927b56

+1

Updated - needs re-review.

+1

Pushed with minor tweaks - had to correct a few mistakes in d2i_test now that --strict-warnings is working again.


Incorrect variable used

https://github.com/GoogleCloudPlatform/data-analytics-golden-demo/blob/bfc1acca898f27cf16984bd3ecb73aa3e106e3b8/deploy.sh#L70
This looks like it should be org_id instead of billing_account

Thanks.  The code has been updated.


New Open Vault can be redeployed by non-developers

The new Open Vault can be redeployed by non-developers, like the new Stock Sales website allows.

@afred: ETA on the EC2 instance building machinery?

After working through the ansible stuff, i'm rethinking the idea of triggering a full rebuild and ELB swap for every deploy.
Full rebuild and swap is a process that needs to be solid, but it's time consuming and introduces a lot of moving parts that really aren't necessary for just getting the latest code in place. Particularly, there is a lot of yum install and gem install going on, which introduce external dependencies.
I think a user-facing script that wraps a Capistrano deployment would be much faster, and have a lower probability of failure.

@caseyedavis12 ok to take this out of the "launch" milestone?

@afred: Yes, understanding that this is a still a goal to accomplish beyond the end of March launch date.

Tested and working from following README.

the README instructions fall quite a ways short of a single button that you can click from a UI, like the Stock Sales site has.
But I'm fine with closing this if others are.

I'm ok with this.


Changing the maximum size of an element name to 64

So this PR is exactly the same thing of my PR #212 except I make the maximum size twice as actual.
Why change again ? Is 32 not long enough ? Well yes and no for me...
In my project I need to create some custom element who represent an administration task form controller.
For this the name should be <admin-create-reservation-controller> since it's represent what the custom element do.
Except this example is 35 longs...
So this is why I remade the same PR as #212.
But now I was wondering ? Why is Templ limit the maximum length of an element ? Web Component don't have any restriction on their name so why ?

It's really just there as a backstop to identify when the parser has probably done something I wasn't expecting. I figured it would be unexpected to have such a long element name. Maybe bounce it to 128 instead, I came up with the limit based simply on the list of HTML name.

It's really just there as a backstop to let users know that the document has been parsed, but has a value that they probably weren't expecting.
I figured it would be unexpected to have such a long element name, and it would likely mean a bug.
Setting it to 128 would be fine, I came up with the limit based simply on the list of HTML names.

Hum that a nice touch to prevent some big bug.
I setup the limit up to 128 characters so this problem should never occur again for anyone.
If I made a third PR about complaining I can't write a custom element with 129 characters.
I think you can mock me before rejecting this third PR xD


Add files via upload

Add Caraga State University

Add Kangnam University

@AlienWolfX First stage of verification passed, official domain is carsu.edu.ph as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@AlienWolfX Thank you for your patience while waiting for a review and processing your request. Pull request merged.


required integration order for full numerical precision is much higher than expected

Example: for a 1um bead, the scattering order is 12, but integration need order 20. Should revise the automatic order scheme

Addressed with https://github.com/lumicks/py-optics/commit/e1ddfc3d721eb08b49d44f734b2a519b724ce3ec


100kb larger size due to unicode tables

I'm not sure whether to consider this just unfortunate, anyways...
Currently the go-pdk depends on github.com/valyala/fastjson and also strings, which end up bringing in all of the unicode tables. However, ideally for the minimal use, you wouldn't want the unicode tables to be included.
Although, I agree, it might be difficult to achieve in practice.

One option here would be to move the http things to a separate package, e.g. github.com/extism/go-pdk/pdkhttp

This appears to be covered in #23. but feel free to re-open if not. Or we can file a new issue.

Ping @nilslice to be sure

yea I'm good to close this -- if it becomes critical to save the bytes, we can move the http stuff into another package.


Upgrade to font awesome  5.x

https://fontawesome.com/how-to-use/upgrading-from-4

Aborting this issue.  Needs more work, issue's as follows:
Source Target Graph and Flow diagram doesn't show icons


feat: move to typescript code generation

ok waiting for @JustinBeckwith  or @bcoe approval, then I will merge it, thanks!


syscall: TestSetuidEtc failure

--- FAIL: TestSetuidEtc (0.01s)
    syscall_linux_test.go:565: [6] "Setgroups([]int{0,1,2,3})" comparison: "/proc/85360/status" got:"Groups:\t0 1 2 3 4 6 10 11 20 26 27" want:"Groups:\t0 1 2 3" (bad) [pid=85360 file:'Name:	syscall.test
        Umask:	0022
        State:	S (sleeping)
        Tgid:	85360
        Ngid:	0
        Pid:	85360
        PPid:	84199
        TracerPid:	0
        Uid:	0	0	0	0
        Gid:	0	0	0	0
        FDSize:	64
        Groups:	0 1 2 3 4 6 10 11 20 26 27
[...]
runtime.goexit()
	/workdir/go/src/runtime/asm_amd64.s:1571 +0x1 fp=0xc0000527e8 sp=0xc0000527e0 pc=0x4683c1
created by runtime.ensureSigM
	/workdir/go/src/runtime/signal_unix.go:956 +0xbd
FAIL	syscall	0.060s

2022-08-03T17:12:14-fcdd099/linux-amd64-alpine

Duplicate of #19938.


Node.js buildpack should include Paketo Datadog buildpack

Paketo recently released a Paketo Datadog buildpack that was integrated with the Java buildpack.
We should integrate this buildpack into the Node.js buildpack as well.

@dmikusa-pivotal said he has a rough implementation for Node.js compatibility in the Datadog buildpack but would be good to get a second set of eyes on there.


Running into issues on example execution

Get this error when I run the first example python3 -m baselines.deepq.experiments.train_cartpole:
/usr/bin/python3: Error while finding spec for 'baselines.deepq.experiments.train_cartpole' (<class 'ImportError'>: cannot import name 'deepq')

I have both Python 2 and 3 installed. Thus I installed baselines with pip3.
Any suggestions?

I had the same issue as above. Any help will be appreciated !

I cannot reproduce it neither on linux nor on max. Can you provide more details?

i did my setup within virtualenv

i installed tensorflow with pip3
i installed baselines with pip3
i installed gym with pip3 (minimal install)

i tried running one of the example command line: python3 -m baselines.deepq.experiments.train_cartpole
and i got the following error:
/usr/bin/python3: Error while finding spec for 'baselines.deepq.experiments.train_cartpole' (<class 'ImportError'>: cannot import name 'deepq')
When i tested it in python3:

import baselines
This is ok
from baselines import deepq
i got the following error:
Python 3.4.3 (default, Nov 17 2016, 01:08:31)
[GCC 4.8.4] on linux
Type "help", "copyright", "credits" or "license" for more information.

import baselines
from baselines import deepq

i got the following error:
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.4/dist-packages/baselines/deepq/init.py", line 4, in
from baselines.deepq.simple import learn, load  # noqa
File "/usr/local/lib/python3.4/dist-packages/baselines/deepq/simple.py", line 12, in
from baselines import deepq
ImportError: cannot import name 'deepq'

I managed to solve the issue by installing Anaconda 3 and creating a Conda environment conda create -n tensorflow and then running the installation in this environment. More instructions are provided in the following:
conda create -n tensorflow

It seems like there's a workaround so I will close this issue.
If the issue persists, since it is difficult to reproduce, please specify a Dockerfile needed to reproduce it before reopening.

Do not install testflow seperately, install gym and baselines with pip3 and run with python3, everything should be ok.

But the program needs tensorflow as the backend, right? You must have installed it somewhere.

the issue seemed to be stemming from a recursive import error (i don't have know what i'm talking about) of deepq from baselines.deepq.simple.py
I changed some some code in simple.py  to more explicitly point at the desired modules and it worked
modifications include:
edited line 12 to "from baselines.deepq.build_graph import build_act, build_train"
edited line 172 to "    act, train, update_target, debug = baselines.deepq.build_graph.build_train("
added "import baselines" to file

@chenmin1107 , "pip3 baselines" will install testflow, if you look at lastest test flow installation,  it can installed by pip3, do not have to install in virtualenv, I guess the virtualenv cause the issue.

I think it is a recursive import error and @Dangerpuss offers a practical solution. But it's still weird because in my case one machine with python 3.5 does not report this error while the other machine with python3.4 reports this error.

@Zhang-Yong thanks for the suggestion, but I want to set it up in a virtualenv so it won't mess my other things.
@yuke93 Same thing here, @Dangerpuss 's way works on my side as well. But I have not tried python3.5. Maybe it is just a python version issue.

Thanks @Dangerpuss I'm also confident that it's a python 3 versioning issue as @yuke93 indicates.
from baselines import deepq
Python 3.4: recursive import error, dangerpuss's edits fixed problem
Python 3.6: no issue

in simple.py
Also edit line 25 to:         act = baselines.deepq.build_graph.build_act(**act_params)

You can replace,
from baselines import deepq by
from baselines.deepq.build_graph import build_act, build_train
it will work. This problem I faced while working with python 2.7


Title is not removed when null

Describe the bug
When page title is not defined, it is not remove from page title.
Eg using the reproduction URL:

Check page title (everything is ok, juste sitename)
Navigate to a page using the header
Return to home using le logo in the header

If you check page title, <previous page> - Le Classement des Associations but i expected that <previous page> was removed (as the first time you load /)
Here the repo: https://github.com/Barbapapazes/le-classement.fr/pull/155
Reproduction
https://le-classement-fr-git-fix-seo-barbapapazes.vercel.app/
System Info
System:
    OS: Windows 10 10.0.19044
    CPU: (4) x64 Intel(R) Core(TM) i5-7300U CPU @ 2.60GHz
    Memory: 2.09 GB / 15.88 GB
  Binaries:
    Node: 18.12.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 3.3.1 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.19.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (108.0.1462.54), ChromiumDev (110.0.1556.0)
    Internet Explorer: 11.0.19041.1566

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Hey, thanks for the code/reproduction. Very helpful.
I think the issue is actually an upstream issue with nuxt/content. If you change it to this it should work:
head.title: null

Yes, it seems that title is not update because of this code.
https://github.com/nuxt/content/blob/main/src/runtime/composables/head.ts#L22
When title is null, it is not pass to head.

It works with title and head.title to null. Thanks for your answer.

The property og:title is not updated (same reproduction).

Maybe there is something to do here: https://github.com/unjs/unhead/blob/main/packages/addons/src/plugins/inferSeoMetaPlugin.ts#L52

not a massive problem as og:image is only for robots on initial load, I'll investigate though

Thanks man for the information!
The solution could be to give a default value to this in case of undefined value?


groups prefixes and per world things

Hi,
I'm frustrated, tired and I cant possibly figure it out myself anymore and i do not know what is the problem or what am i doing wrong.
ok so i have server that has multiple worlds, i need to set different groups per world say, when a player is in survival world he would be default group called "member" but when he is in the world mines he would be in group called A and i needed those two groups to be default (automatically joins the member upon joining server)
i read in forums that you cannot set groups per world, so i said maybe set  different preffixes per world
but nothing is working i have deleted the whole file started from 0 and nothing my member can do things they have all the permissions but not me the owner i have tried multiple times /pex user MYUSERNAME group set Owner and nothing,
i need you guys help i have 2 survival worlds 1 creative and 1 prison mine and i need to have different "ranks" preffixes or what ever they are called per world this is what i got so far
http://pastebin.com/2rjfhvLy
i need groups from A-Z each group to have the ability to rank up to the next letter, i have a rank up pluging that does that i just need to give the permission.node to the default group. help please

First and foremost, follow this example to get the correct basic formatting for your file.
Next, take a look at these 2 example groups to see how you would format their multiworld permissions.
There is one command to assign permissions to a groups:
pex group <group> add <permission.node> [world]
If you were to type pex group Guest add modifyworld.* into the server console, you would give the "Guest" group access to everything the "Modifyworld" plugin can do, on all worlds the server has.
If you were to type pex group Guest add modifyworld.* Survival into the server console, you would give the "Guest" group access to everything the "Modifyworld" plugin can do, but only on the world named "Survival".
Unfortunately, PEX 1.x does not support per-world default groups or per-world prefixes.  The per-world default groups may be possible in PEX 2.x versions, which are still in development.  All prefixes/suffixes are handled by your choice of chat management plugins; PEX does not do any chat management and only gives you a place to store prefixes/suffixes so your choice of chat management plugin can pulls from that location to display the prefixes/suffixes in-game.  (Note: Chat Manager and ChatEx plugins may not be fully compatible with PEX.)

Issue must be resolved.  OP hasn't responded in more than 7 days.


Add launch argument to optionally omit the controller_stopper node

Adds an argument to ur_control.launch.py to optionally launch the controller_stopper node.
In our hardware setup we have multiple types of robots (URs, rails, lifts, AMRs, etc), and have implemented some custom software e-stops for halting everything in the system, then restarting controllers as needed. While we normally rely on the controller_stopper, we've found that it steps on the toes of our custom e-stopper. It would be handy to optionally not include the node in a way that lets us continue to use the driver's launch files as is.
I don't imagine this change will be something that most UR users will need. That said, it may be a nice to have if anyone runs into a similar situation as we are.
Testable with variations of:
ros2 launch ur_robot_driver ur5e.launch.py robot_ip:=<IP_ADDRESS> use_mock_hardware:=false use_controller_stopper:=false

I would actually rather not have this. The controller_stopper is an essential piece in a) avoiding sudden motions of the robot in case the user has sent a target while the robot program was not running and b) help making clear that the robot currently cannot accept new targets since the controller is not running.
What is your reasoning why you would not to have it running? Anyway, users can still build their own launchfiles without the controller stopper if they really want to. That obviously requires a bit more understanding than just running a launch file, but disabling the controller stopper also requires understanding what its purpose is and what I as a user have to take care of myself.

Thanks for the quick feedback, @urfeex! That makes complete sense to me, we'll stick with building our own launch files.
We run into issues when using applications that don't necessary reset their controller commands after something is paused. For example, MoveIt Servo may continue sending commands to a JTC even after the JTC is stopped by the controller stopper. When the UR is reset and the controller reactivated there will be a resulting joint jump.
We have similar situations with other types of hardware where the application or controller needs to be reset before a controller is re-activated, so to handle that we've rolled everything into a software e-stop. What we want on top of that is a snapshot of the controller manager's state prior to triggering a stop, which we might not be able to get if the UR's controller stopper triggers before our node's does.
In any case, thanks for the information. If this option were there I think it would be more trivial for a novice user to do something dangerous, whereas it's a much more deliberate choice on our end.
Closing this.


Menu

@runongirlrunon navigate bar is completely fixed. login & log out will display properly.

Seeing this error when I run the server on your branch, can you fix please?

Better screenshot:

i fixed deprecation error, and when user log in the register button will disappear.
also I took out $cakeDescription

This closes https://github.com/summer17-csc648-team1/warehausmedia/issues/14.


[Feature Request] Remove the Nd*TensorSpec classes

Motivation
The usage of the non-Nd TensorSpec classes is limited, as they are essentially special cases of the Nd specs.
To simplify things and for better maintenance we should get rid of the non Nd specs and rename the Nd to their counterpart names, ie
Remove
BoundedTensorSpec, UnboundedContinuousTensorSpec, UnboundedDiscreteTensorSpec

And rename
NdBoundedTensorSpec, NdUnboundedContinuousTensorSpec, NdUnboundedDiscreteTensorSpec

With these names

I'm on it 😄


add support for image override for argocd-extension

What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This PR adds downstream support of argocd-extension in gitops-operator using env var
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes GITOPS-5661
How to test changes / Special notes to the reviewer:

Looks like the new unit test is failing
--- FAIL: Test_getRolloutInitContainer (0.00s)
    --- FAIL: Test_getRolloutInitContainer/when_running_in_gitops#01 (0.00s)
        deployment_test.go:2448:
            	Error Trace:	/home/runner/work/argocd-operator/argocd-operator/controllers/argocd/deployment_test.go:2448
            	Error:      	Not equal:
            	            	expected: "quay.io/argoprojlabs/argocd-extension-installer:v0.0.8"
            	            	actual  : "updated_container"

            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1 +1 @@
            	            	-quay.io/argoprojlabs/argocd-extension-installer:v0.0.8
            	            	+updated_container
            	Test:       	Test_getRolloutInitContainer/when_running_in_gitops#01
            	Messages:   	Image check
        deployment_test.go:2449:
            	Error Trace:	/home/runner/work/argocd-operator/argocd-operator/controllers/argocd/deployment_test.go:2449
            	Error:      	Not equal:
            	            	expected: []v1.EnvVar{v1.EnvVar{Name:"EXTENSION_URL", Value:"https://github.com/argoproj-labs/rollout-extension/releases/download/v0.3.6/extension.tar", ValueFrom:(*v1.EnvVarSource)(nil)}}
            	            	actual  : []v1.EnvVar(nil)

            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1,8 +1,2 @@
            	            	-([]v1.EnvVar) (len=1) {
            	            	- (v1.EnvVar) {
            	            	-  Name: (string) (len=13) "EXTENSION_URL",
            	            	-  Value: (string) (len=89) "https://github.com/argoproj-labs/rollout-extension/releases/download/v0.3.6/extension.tar",
            	            	-  ValueFrom: (*v1.EnvVarSource)(<nil>)
            	            	- }
            	            	-}
            	            	+([]v1.EnvVar) <nil>

            	Test:       	Test_getRolloutInitContainer/when_running_in_gitops#01
            	Messages:   	Env check

Please fix the unit test. Rest all looks good.