HADOOP-19105. Improve resilience in vector reads.

Add a new releaser method, which then is invoked to release buffers on failure.
It is a bit contrived how we try not break external implementations when adding a new default implementation to PositionedReadable: the releaser will be lost unless they do so.
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 57s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 41s

trunk passed

+1 :green_heart:
compile
17m 46s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
16m 26s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
4m 21s

trunk passed

+1 :green_heart:
mvnsite
2m 42s

trunk passed

+1 :green_heart:
javadoc
2m 14s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
1m 42s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
3m 56s

trunk passed

+1 :green_heart:
shadedclient
35m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 30s

the patch passed

+1 :green_heart:
compile
17m  4s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
17m  4s

the patch passed

+1 :green_heart:
compile
16m 12s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
16m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 13s
/results-checkstyle-root.txt
root: The patch generated 2 new + 57 unchanged - 0 fixed = 59 total (was 57)

+1 :green_heart:
mvnsite
2m 41s

the patch passed

-1 :x:
javadoc
1m 15s
/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-common-project_hadoop-common-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
javadoc
1m 46s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
4m 18s

the patch passed

+1 :green_heart:
shadedclient
36m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 48s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 56s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m  5s

The patch does not generate ASF License warnings.

258m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7105/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7105

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c313793e4f5e 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 311c2e09995c8a82440024d082d87719333e3171

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7105/1/testReport/

Max. process+thread count
3152 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7105/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 48s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
32m 41s

trunk passed

+1 :green_heart:
compile
18m  1s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
16m 55s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
4m 24s

trunk passed

+1 :green_heart:
mvnsite
2m 45s

trunk passed

+1 :green_heart:
javadoc
2m 10s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
4m  0s

trunk passed

+1 :green_heart:
shadedclient
35m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 30s

the patch passed

+1 :green_heart:
compile
17m  4s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
17m  4s

the patch passed

+1 :green_heart:
compile
16m 23s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
16m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 22s
/results-checkstyle-root.txt
root: The patch generated 2 new + 57 unchanged - 0 fixed = 59 total (was 57)

+1 :green_heart:
mvnsite
2m 39s

the patch passed

-1 :x:
javadoc
1m 14s
/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-common-project_hadoop-common-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
javadoc
1m 48s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
4m 21s

the patch passed

+1 :green_heart:
shadedclient
36m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m  2s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  5s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m  7s

The patch does not generate ASF License warnings.

249m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7105/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7105

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux bd03228d87db 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 29e20495659a61ab84db2aed1d0553151818f87a

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7105/2/testReport/

Max. process+thread count
1251 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7105/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 49s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 36s

trunk passed

+1 :green_heart:
compile
17m 45s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
16m 42s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
4m 23s

trunk passed

+1 :green_heart:
mvnsite
2m 41s

trunk passed

+1 :green_heart:
javadoc
2m 12s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
3m 57s

trunk passed

+1 :green_heart:
shadedclient
35m 40s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
36m  6s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 27s

the patch passed

+1 :green_heart:
compile
17m 28s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
17m 28s

the patch passed

+1 :green_heart:
compile
16m 44s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
16m 44s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 12s
/results-checkstyle-root.txt
root: The patch generated 2 new + 57 unchanged - 0 fixed = 59 total (was 57)

+1 :green_heart:
mvnsite
2m 38s

the patch passed

-1 :x:
javadoc
1m 12s
/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-common-project_hadoop-common-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
javadoc
1m 46s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
4m 20s

the patch passed

+1 :green_heart:
shadedclient
35m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 34s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  0s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m  6s

The patch does not generate ASF License warnings.

247m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7105/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7105

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 1c492766ce40 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fef176208ad4dbe6153a1944ddb545204c7a6537

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7105/3/testReport/

Max. process+thread count
3152 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7105/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
7m 23s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 22s

trunk passed

+1 :green_heart:
compile
16m 26s

trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
15m 20s

trunk passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
checkstyle
4m 13s

trunk passed

+1 :green_heart:
mvnsite
2m 34s

trunk passed

+1 :green_heart:
javadoc
2m  9s

trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
spotbugs
3m 49s

trunk passed

+1 :green_heart:
shadedclient
33m 42s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
34m  8s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 24s

the patch passed

+1 :green_heart:
compile
15m 43s

the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
15m 43s

the patch passed

+1 :green_heart:
compile
15m  4s

the patch passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
javac
15m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 13s
/results-checkstyle-root.txt
root: The patch generated 2 new + 57 unchanged - 0 fixed = 59 total (was 57)

+1 :green_heart:
mvnsite
2m 34s

the patch passed

-1 :x:
javadoc
1m 12s
/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.txt
hadoop-common-project_hadoop-common-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
javadoc
1m 45s

the patch passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
spotbugs
4m  5s

the patch passed

+1 :green_heart:
shadedclient
33m 41s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 57s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  7s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m  4s

The patch does not generate ASF License warnings.

227m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7105/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7105

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 613e1b441543 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2e8b7dcedf1f9a9dc576911841c1bd8893529736

Default Java
Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7105/4/testReport/

Max. process+thread count
2353 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7105/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Add -q parameter to fourmolu

For removing lines like Loaded config from: /home/user/.config/fourmolu.yaml when formatting.

I appreciate the PR. I can merge this if you could make a change to handle situations where someone overrides the executable with a different formatter.
Rather than hard-coding the value, in plugin/vim_fourmolu.vim can you add a check for g:fourmolu_executable, and if it's fourmolu set a variable called g:fourmolu_quiet = " -q "?

Yeah you are right, I will add it now.

Looks good, thanks for making the change


Update V2 host to v2.0.13862

https://github.com/Azure/azure-functions-host/releases/tag/v2.0.13862

/azp run


When will Chinese version release?

Currently Chinese result is not very good.

We are working on bilingual version.


Fix checking validity of tmate-server-xxx parameters

Don't throw an exception if they match the expected form but rather if
they do not match it.
Also add colon to the list of allowed characters as it must be used in
the fingerprints (which have the form of "SHA256:xxxxxx").

Sorry if I'm missing something obvious here, but it seems that the check can't work as currently written: as soon as I add
        with:
          tmate-server-host: shell.example.com

to my work workflow, I get
Error: Invalid value for 'tmate-server-host': 'shell.example.com'

and looking at the code it seems impossible to avoid this.
I believe that the intention was to negate this check, but even then it's still not quite right because we also need to allow colons here. But, again, perhaps I'm misunderstanding something here because I just don't see how could this have ever worked as written.

Now that I look at the code again, I cannot fail to notice how little sense it makes to validate all four inputs against the same regex. The port number, for example, should only contain digits, and start with a non-zero one.

I agree with this, but I wanted to keep my changes as small as possible, so I decided to not change this.

So I would like to suggest moving the regex to a parameter that is passed to the getValidatedInput() function. And the different inputs should then have their own, different regexes.

This looks like a good idea, but as long as we're discussing this anyhow, let me ask another question: what is the purpose of this validation in the first place? The parameters come from the workflow file and the action code itself also comes (albeit indirectly) from the same workflow file, so there doesn't seem to be any security concerns here (you would be just attacking yourself, basically, by using malicious parameters). What's the worst that is going to happen if you pass an invalid value for any of those? Wouldn't we just get an error from tmate anyhow?
I.e. do we really need the validation at all? And if we do, maybe we should just do core.warning(...) instead of throwing an error if it fails?

Also, we will want to prevent an equally face-palm-triggering bug as a missing ! in the future. The way to do that is of course to add a regression test.
[...]
Would you mind making those changes?

I'm not a JS/TS developer at all, so I might have some trouble with/it might take me some time to do this, but I'll try to do it, I agree that having tests would be good. But I'd like to see what do you think about the questions above first. TIA!

Now that I look at the code again, I cannot fail to notice how little sense it makes to validate all four inputs against the same regex. The port number, for example, should only contain digits, and start with a non-zero one.

I agree with this, but I wanted to keep my changes as small as possible, so I decided to not change this.

Please do change it.

So I would like to suggest moving the regex to a parameter that is passed to the getValidatedInput() function. And the different inputs should then have their own, different regexes.

This looks like a good idea, but as long as we're discussing this anyhow, let me ask another question: what is the purpose of this validation in the first place?

Usage mistakes are very easy to make. These validations help identify and rectify the mistakes. There is not really any security concern, but there is the concern that unhelpful error messages are such a pain.

I'm not a JS/TS developer at all

Hah, neither am I. But the existing code is easy enough to imitate, no?
FWIW if you have trouble figuring out how to run the tests, simply call npm install followed by npm run test.

This looks like a good idea, but as long as we're discussing this anyhow, let me ask another question: what is the purpose of this validation in the first place?

Usage mistakes are very easy to make. These validations help identify and rectify the mistakes. There is not really any security concern, but there is the concern that unhelpful error messages are such a pain.

Right, but AFAICS core.warning() would work nicely in this case, as it should create an  annotation with the problem. OTOH it would still allow the action to work if the validating regex is too strict for whatever reason.
Are you sure you prefer to keep the exception (I promise not to ask again)?

Right, but AFAICS core.warning() would work nicely in this case, as it should create an annotation with the problem.

I would go for a core.error(), actually.

Are you sure you prefer to keep the exception (I promise not to ask again)?

That's the easiest way to exit with error, even easier than core.error() and then ensuring that we return without proceeding. So actually, yes, I would keep the exception: I prefer simpler solutions to complicated ones.

I've finally implemented this (it took much longer than I thought due to my inexperience with JS and Jest) and it seems to work as expected. Please have a look at the new version.

@mxschmitt I can't release this right now, as I am typing this on a phone... if you have some time, would you mind? Otherwise I will do it as soon as I can.

Okay, I'm on it.

Done: https://github.com/mxschmitt/action-tmate/releases/tag/v3.10

Hi, this seems to break the action when no tmate-server-host is specified (and it should thus fall back to the default).
What I'm getting instead is Error: Invalid value for 'tmate-server-host': ''.

Hi, this seems to break the action when no tmate-server-host is specified (and it should thus fall back to the default).
What I'm getting instead is Error: Invalid value for 'tmate-server-host': ''.

Sorry for the breakage! Next version incoming...

@mxschmitt fixed it in #109


Missing link in Readme file

Missing a guide link:

The guide is what follows that intro header, not a separate document.

@davidlago it might be better to re-word that to avoid future confusion.

Updated :)

Haha yeah I figured so. Thanks for updating. While I was following the instructions, I also added some missing info to the README.md that helped me to successfully deploy the app. I just created a pull request. Please take a look. Hope it helps.


OpenCV 3.0: Python Stitcher hangs OSX

I installed opencv 3.0.0 with homebrew on Macbook Pro (intel) OSX 10.10.4 Yosemite. When I run the following code:
imgs = []

for i in range(1,6):
	file = 'stitching_img/S%d.jpg'%i
	print file
	im = cv2.imread(file)
	imgs.append(im)

st=cv2.createStitcher()
ret,pano = st.stitch(imgs)

print 'ret',ret

if ret: cv2.imwrite('pano.png',pano)

My entire computer locks up after the 6 images are loaded. I originally did a cv2.imshow(im) to ensure the images were loaded correctly and they were. I took it out thinking showing an image was what locked up my system and forcing a reboot, however, that didn't help and I sill had to reboot.

locked up my system and forcing a reboot

Try to disable OpenCL support in OpenCV (for example, via environment variables OPENCV_OPENCL_DEVICE=disabled or OPENCV_OPENCL_RUNTIME=invalid)


Fix for issue #93 "After running code action, no cursor is present"

Removed the call to clear selection after the code action. It causes the
issue and removing it doesn't seem to have any side effects.

Thanks! Welcome to git and OSS :+1:


Failing to get the context in Program.cs

As part of introducing an interface for the context you changed Startup.cs to:
services.AddDbContext<INorthwindDbContext, NorthwindDbContext>(options =>

The problem is that in Program.cs:
var context = scope.ServiceProvider.GetService<NorthwindDbContext>();

returns a null for me.  I cloned your solution and just pressed the build solution button.  Pretty sure I did not change anything.  Verified I'm using 2.2 etc.  Ran into the same thing when I tried to duplicate your solutions structure.
I poked around a bit and really could not find an example of passing both an interface as well as an implementation to AdDbContext.  The signature is documented but there is no more details on it.  And my source code reading skills are sadly limited.
Any thoughts on what I am doing wrong?

Thanks I missed this! What I've done is to request INorthwindDbContext and cast to NorthwindDbContext for the purposes of seeding.


Add paragraph element

A paragraphs is just a collection of text elements without any specific features or attributes.

+1

+1

+1

+1


Expert Necromancy, Master Necromancy, Legendary Necromancy not working

The class features for Expert Necromancy, Master Necromancy, Legendary Necromancy only raise the proficiency level of the spell casting DC. They are not targeting the Necromancer class DC, and the Necromancer isn't listed as a class DC that can be targeted when trying to edit the effect.

Those features don't increase your class DC. Casters are stuck at trained the entire time


Does the java wrapper have a similar rdkit.Chem.QED module in the python API

I need rdkit.Chem.QED.QEDproperties (MW, ALOGP, HBA, HBD, PSA, ROTB, AROM, ALERTS) in python. Then there is no quantitative estimate of drug similarity in the java wrapper. Where is it located?
Thank you very much！

I'm closing this because it is a question, not a bug report or enhancement request.
Please ask questions using the "Discussions" tab.


AnalyzeMedia content-type

I have been failing to successfully communicate with AnalyzeMedia using any other way than content-type "formdata" (as working here). The environments I use (Cables.gl and Touchdesigner) don't support formdata.
AnalyzeText works with content-type "application/json" but AnalyzeMedia doesn't acknowledge the file ever and tells me "nothing to do without any signal. which is fine". I have tried encoding the image file in the json in base64, numpy array, url, uri... without success.
Been stuck on this for DAYS and would be immeasurably grateful for any tip on this.
Thank youuuu

Here is a progress on this:
HTTP GET with request body
It seems uncommon to have a GET request with a body but not impossible. Although It may be the reason why the media is not recognized by the request.

A payload within a GET request message has no defined semantics;
sending a payload body on a GET request might cause some existing
implementations to reject the request.


DOC: Fix a variable name in params example.

Coverage remained the same at 58.265% when pulling 41b68238fcfee796061cc23035e1ea5b217e07bf on wrwrwr:patch-1 into 011815d287456efee0a24a9efe5a2c0c49b720f2 on spacetelescope:master.

Thanks!


Duplicating a file with multiple extensions misses the full extension

Issue Type: Bug
Steps to reproduce:
Create a file and Save it as foo.schema.json.
Attempt to duplicate the file.
File name will prefill as foo1.schema rather than foo1.schema.json
VS Code version: Code 1.65.1 (Universal) (8908a9ca0f221f36507231afb39d2d8d1e182702, 2022-03-08T02:20:11.670Z)
OS version: Darwin x64 21.2.0
Restricted Mode: No

I couldn't find any similar report.

/gifPlease


Cannot connect to any server

I've seen there is already 2 issues closed 11 days ago. I try connecting for days without success. I try with and without Tor proxy. Is there another issue? Can there be put more servers into the Network screen?
Some excerpts from my log:
20211116T164620.692812Z |     INFO | interface.[electrum.ravencoin.foundation:50002] | disconnecting due to: ErrorGettingSSLCertFromServer(SOCKSFailure('connection refused',),)
20211116T164649.448367Z |     INFO | interface.[electrum2.rvn.rocks:50002] | disconnecting due to: ConnectError(SSLError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:852)'),)
20211116T164741.165123Z |     INFO | interface.[electrum.ravencoin.foundation:50002] | disconnecting due to: ErrorGettingSSLCertFromServer(ConnectError(ConnectionRefusedError(10061, "Connect call failed ('<IP_ADDRESS>', 50002)"),),)
20211116T164910.218487Z |     INFO | interface.[rvn4lyfe.com:50002] | disconnecting due to: ConnectError(SSLError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:852)'),)
20211116T164931.104607Z |     INFO | interface.[electrum3.rvn.rocks:50002] | disconnecting due to: ConnectError(TimeoutError(10060, "Connect call failed ('<IP_ADDRESS>', 50002)"),)
20211116T165213.170114Z |     INFO | network | connecting to electrum-rvn.dnsalias.net:50002:s as new interface
20211116T165214.556051Z |     INFO | interface.[electrum-rvn.dnsalias.net:50002] | succeeded in getting cert
20211116T165215.296228Z |     INFO | interface.[electrum-rvn.dnsalias.net:50002] | disconnecting due to GracefulDisconnect(RPCError(1, 'unsupported protocol version: 1.9'),)

It looks like you are using an old version correct?

Version I use is freshly installed latest release Electrum Ravencoin 0.4.4

Go into you electrum directory and delete your certs in the certs folder

That did the trick for electrum1.rvn.rocks, electrum2.rvn.rocks and rvn4lyfe.com, thanks!


0.6.2 package, tag?

Would like to update the ebuild on Gentoo, thanks.

Sorry I'm not master of gentoo. Do you want static URL to download each versions?

Yep, the same github downloadable zip packages work just fine like you have 0.6.0 and older.


Fix bug with existing dates

What problem does the pull request solve?
Visiting a question page with an existing date field (i.e. one without an answer settings field) will result in an error, since the date question type expects the input type to be present.
This PR adds a check for this. This should be a temporary solution - the proper solution is to migrate the existing date (and address) fields. There is a ticket for this in the backlog which should be done in the next sprint.
Checklist

[x] I've used the pull request template
[n/a] I've linked this PR to the relevant issue (if mission work)
[x] I've written unit tests for these changes (if code change)
[n/a] I've updated the documentation in (If any documentation requires updating)

[n/a] README.md
[n/a] Elsewhere (please link)

@aliuk2012 Thanks, have added tests now


long bars between each update

When I try to run it there's 1/4-1 sec between each time it analyzes any sound producing long bars on the spectrograph. I'm running the 1.5.7 linux release. I'm not seeing any limitations in memory or in cpu usage.

What audio backend are you using on your Linux installation?

The new version solved the problem. I'm using Ubuntu with pulse audio drivers. Thank you.


Feature Request: Implement chunk_ids feature to Identify chunks.

Currently there is no way to differentiate between chunks from the same document as all chunks get the same document_ids.
One use case where this would be useful is when breaking down a query into related sub queries and retrieving relevant chunks for all sub queries and then do de-duplication of the chunks based on chunk_ids.

Good suggestion, thanks! Tagging as Help Wanted/Good First Issue, other I or @anirudhdharmarajan will get on this eventually!


Enhancement Request: Pin aemsync and less-tree to versioned packages

Aemfed has 2 dependencies (aemsync, and less-tree) that point to github urls of tarball files for a specific commit. Since these are compiled commits and not a specific version, our corporate NPM registry intake has no way of scanning the dependency for vulnerabilities and therefore cannot know for certain if they are safe to use.

In our project we are facing similar issue, hence the deployment is failing, as the deployment agency has addd a check to allow "All dependencies from NPM Registry only".
They also asked us to remove the package and use some other alternative which doesn't have Github dependencies.
@abmaonline - could you please suggest as to what can be done?
Thanks,

@abmaonline this is actually a concerning issue. Any reason for the use of github URLs as opposed to published NPM modules?
@skbhardwaj aemfed is a development tool only, this means you can remove it from your package.json and install it globally on your local machine: npm install -g aemfed and then use it only locally on your developer machine without it ever making it to your CI/CD build.

@ahmed-musallam Problems with global install:

doesn't solve the core issue - our internal repo prevents me from depositing it without a published build.
doesn't scale easily for teams where we'd prefer configuration as code.

Yes. I suggested it as a work-around :)

These tarballs start to create a lot of issues. Let me check if I can merge the changes back into the original projects or otherwise publish them as custom npm packages.

Just published a release candidate with scoped npm packages instead of tarballs for the customized modules. Maybe you could give it a try and let me know if it solves the issue?
Please use npm install aemfed@next to install the latest release candidate (or npm install<EMAIL_ADDRESS>when you want to be explicit).


Master

merge

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 7 committers have signed the CLA.:x: Nick Kew:x: bryancall:x: jpeach:x: zwoop:x: yunkai:x: igalic:x: scottharrisNick Kew seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Adding playlists resource: Make a Chat App With Ktor

Hi, the new resource is a YouTube playlist. I hope you like it. Thanks!

Awesome! Thanks for your contribution.


Burst id and absolute orbit number

This PR updates the two things:

Burst ID: three digits for the track number. e.g. t051_, t123_
Absolute orbit number: For populating the RTC metadata, Sentinel1BurstSlc will keep the absolute orbit number as one of its attributes.

Before approving, may I ask what are the use cases for these changes?

Before approving, may I ask what are the use cases for these changes?

Yes. The new format of burst_id will make the lengths of the string to be the same.
RTC metadata parses some information from burst id. We can already extract what we need from the current format, but the new one will make it easier.
Regarding the absolute orbit number, we need this information to make the RTC metadata as similar as the  NISAR-equivalent product (GCOV)

@LiangJYu Thanks for pointing me to the unit test. I've updated test_bursts.py in accordance with your suggestion.
Currently circieCI keeps on failing due to the error message below:
CondaHTTPError: HTTP 404 NOT FOUND for url <https://repo.anaconda.com/pkgs/main/linux-64/zlib-1.2.12-h7f8727e_1.conda>
Elapsed: 00:00.093111
CF-RAY: 740068947daf5b28-IAD

An HTTP error occurred when trying to retrieve this URL.
HTTP errors are often intermittent, and a simple retry will get you on your way.

Exited with code exit status 1
CircleCI received exit code 1

Hope this failure is not related to this PR.

@LiangJYu Thanks for pointing me to the unit test. I've updated test_bursts.py in accordance with your suggestion. Currently circieCI keeps on failing due to the error message below:
CondaHTTPError: HTTP 404 NOT FOUND for url <https://repo.anaconda.com/pkgs/main/linux-64/zlib-1.2.12-h7f8727e_1.conda>
Elapsed: 00:00.093111
CF-RAY: 740068947daf5b28-IAD

An HTTP error occurred when trying to retrieve this URL.
HTTP errors are often intermittent, and a simple retry will get you on your way.

Exited with code exit status 1
CircleCI received exit code 1

Hope this failure is not related to this PR.

I don't think it's related. @rtburns-jpl to my untrained eye and shallow investigation, it looks like our CircleCI specfile needs to be updated to account for changes here? What do you think? Whatever the case, I'll open a new issue to continue discussion there.


Add MUSA support

Needs https://github.com/RWKV/ggml/pull/3

official implement is introduced in https://github.com/ggerganov/llama.cpp/pull/8383


Generating directly executable parsers

The old LR parsing and finite automata literature used to distinguish between two basic ways of implementing DFA: table-based and "directly executable".
Directly executable (or hardcoded) is when the tables are actually encoded in the generated C++ code, usually there would be a label and a block of generated code for each state, and goto would be used for jumping from one state to the other.
If I understood correctly, your approach was to start from table-based and then augment it with some "recursive-descent" stuff (I only skimmed your paper as of yet).
Is the directly executable/hardcoded apprach compatible with your work? Have you considered letting langcc generate such parsers?

While one could theoretically expand the generated LR parsing tables into executable code, such code would not be significantly more intuitive; it would still look like hard-coded tables, as the table indices (and resulting jump indices) do not provide significant intuition. For this reason, it does not appear worthwhile to enable this in langcc.

Usually the motivation is performance. Hardcoding the tables into executable code should enable the C++ compiler to do a lot more optimization than it otherwise could, and I guess that less data cache pressure is also a good thing.

There might be a slight performance advantage (or maybe not -- considering also the instruction cache), but in either case I don't think it would be nearly significant enough to justify that amount of complicated codegen.


Hostname does not resolve to a loopback address

Environment

Elixir & Erlang/OTP versions (elixir --version): Elixir 1.14.5 (compiled with Erlang/OTP 25)
Operating system: MacOS Sonoma 14.0
How have you started Livebook (mix phx.server, livebook CLI, Docker, etc): open /Applications/Livebook.app
Include what is logged to the server console:

ERROR!!! [Livebook] Your hostname "defiant" does not resolve to a loopback address (<IP_ADDRESS>/8), which indicates something wrong in your OS configuration, or EPMD is not running.

Current behavior
Livebook fails to start. This is seems to be the same issue as https://github.com/livebook-dev/livebook/issues/1927.
What I've tried

Setting hostname via sudo scutil --set HostName defiant and running Livebook doesn't fix the issue.
I've created a config file, with no success either.

❯ cat /Users/erasmas/.livebookdesktop.sh
export LIVEBOOK_DISTRIBUTION=name
export<EMAIL_ADDRESS>
Expected behavior
I'm able to start Livebook.

Can you make it so the nodename is only export<EMAIL_ADDRESS>I am not sure Erlang supports slashes in the host.

Can you make it so the nodename is only export<EMAIL_ADDRESS>I am not sure Erlang supports slashes in the host.

Hi and thank you for a quick response! I changed to<EMAIL_ADDRESS>❯ cat /Users/erasmas/.livebookdesktop.sh
export LIVEBOOK_DISTRIBUTION=name
export<EMAIL_ADDRESS>
The issue remains, what else can I try?

If you run iex --sname foo and iex --name foo, what does it print in both cases?

❯ iex --sname foo
Erlang/OTP 25 [erts-<IP_ADDRESS>] [source] [64-bit] [smp:10:10] [ds:10:10:10] [async-threads:1]

Interactive Elixir (1.14.5) - press Ctrl+C to exit (type h() ENTER for help)
iex(foo@defiant)1>

❯ iex --name foo
=INFO REPORT==== 16-Oct-2023::18:57:43.558018 ===
Can't set long node name!
Please check your configuration

=SUPERVISOR REPORT==== 16-Oct-2023::18:57:43.558049 ===
    supervisor: {local,net_sup}
    errorContext: start_error
    reason: {'EXIT',nodistribution}
    offender: [{pid,undefined},
               {id,net_kernel},
               {mfargs,{net_kernel,start_link,
                                   [#{clean_halt => true,name => foo,
                                      name_domain => longnames,
                                      supervisor => net_sup}]}},
               {restart_type,permanent},
               {significant,false},
               {shutdown,2000},
               {child_type,worker}]

{"Kernel pid terminated",application_controller,"{application_start_failure,kernel,{{shutdown,{failed_to_start_child,net_sup,{shutdown,{failed_to_start_child,net_kernel,{'EXIT',nodistribution}}}}},{kernel,start,[normal,[]]}}}"}
Kernel pid terminated (application_controller) ({application_start_failure,kernel,{{shutdown,{failed_to_start_child,net_sup,{shutdown,{failed_to_start_child,net_kernel,{'EXIT',nodistribution}}}}},{kernel,start,[normal,[]]}}})

Crash dump is being written to: erl_crash.dump...done

❯ epmd -names
fish: Unknown command: epmd

❯ rm /Users/erasmas/.livebookdesktop.sh

❯ iex --sname foo
Erlang/OTP 25 [erts-<IP_ADDRESS>] [source] [64-bit] [smp:10:10] [ds:10:10:10] [async-threads:1]

Interactive Elixir (1.14.5) - press Ctrl+C to exit (type h() ENTER for help)
iex(foo@defiant)1> :inet.gethostbyname(~c"defiant", :inet, :infinity)
{:ok, {:hostent, 'defiant.tail7c5e.ts.net', [], :inet, 4, [{100, 88, 111, 48}]}}
iex(foo@defiant)2> :inet.gethostbyname(~c"defiant", :inet6, :infinity)
{:ok, {:hostent, 'defiant', [], :inet6, 16, [{0, 0, 0, 0, 0, 0, 0, 1}]}}
iex(foo@defiant)3>

Hostname resolves in iex. As for the epmd, I don't have it in $PATH, let me see how to install it.

I think that's the issue, epmd does not seem to be running. It should be installed with Erlang. Do you have any process named epmd running?

You can also try running :erl_epmd.names({100, 88, 111, 48}) in IEx. It that does not return node names, it explains the reason (and confirms that EPMD is not running).

iex(1)> :erl_epmd.names({100, 88, 111, 48})
{:error, :address}

You're right, I guess epmd is the issue. I have installed Elixir using Nix, and I never explicitly installed Erlang. Trying to figure out now how to get epmd running.


Dafang hack configuration

Hi!
I have a hacked dafang camera that was working on the v2, and now in the v3 get stuck in "loading 2"
I see in the documentation that this camera sould work, but it indicates a configuration:
"Video: H264, size: 1920x1080, bitrate: 1000, format: VBR, frame rate: 10
Audio: PCMU, rate in: 8000, rate out: 44100"
That I dont really understand where I should set it up.
My camera configuration is:
camera:
  - platform: ffmpeg
    name: Living Room Camera
    input: -rtsp_transport tcp -i rtsp://<IP_ADDRESS>/unicast

and my card
          - type: "custom:webrtc-camera"
            entity: camera.living_room_camera
            title: 'Salón'
            ui: true

The camera streams works fine in home assistant, but the webRTC card is stuck. I have another camera of other platform (generic) that works fine. Can someone point me what can be the problem, and how/where should I set those configurations to check if this is the issue?
Thanks!

Try to use RTSP URL in WebRTC card

Hi!
I have a hacked dafang camera that was working on the v2, and now in the v3 get stuck in "loading 2"
I see in the documentation that this camera sould work, but it indicates a configuration:
"Video: H264, size: 1920x1080, bitrate: 1000, format: VBR, frame rate: 10 Audio: PCMU, rate in: 8000, rate out: 44100"
That I dont really understand where I should set it up.
My camera configuration is:
camera:
  - platform: ffmpeg
    name: Living Room Camera
    input: -rtsp_transport tcp -i rtsp://<IP_ADDRESS>/unicast

and my card
          - type: "custom:webrtc-camera"
            entity: camera.living_room_camera
            title: 'Salón'
            ui: true

The camera streams works fine in home assistant, but the webRTC card is stuck. I have another camera of other platform (generic) that works fine. Can someone point me what can be the problem, and how/where should I set those configurations to check if this is the issue?
Thanks!

I'm facing the same issue, did you manage to solve it?

Nope, still not working using the RTSP url directly

I have already did for Xiaofang in latest go2rtc master version. I think it will also helps for Dafang

I have already fix for Xiaofang in latest go2rtc master version. I think it will also helps for Dafang. Will be with new releases

Great! Thanks!

@AlexxIT What was the fix? I have these : https://www.amazon.co.uk/gp/product/B00NPT0YZO/ref=ppx_yo_dt_b_search_asin_title?ie=UTF8&psc=1 (SANSCO) cameras and this sounds a lot like my problem.


The location of executor stdout

Hello, when I run example, I could not find the stdout of executor in log. Where are them output?
For example, I use
fmt.Println("Start ExampleExecutor")
fmt.Fprintf(os.Stderr, "Hello\n")

And I could not found them in /tmp/mesos/0/slaves/20150309-212927-16777343-5050-18580-S0/frameworks/20150309-212927-16777343-5050-18580-0008/executors/default/runs/latest/stderr and /tmp/mesos/0/slaves/20150309-212927-16777343-5050-18580-S0/frameworks/20150309-212927-16777343-5050-18580-0008/executors/default/runs/latest/stdout.

I see them on the terminal where I started mesos from (I use the bin/mesos-local.sh script) I haven't looked into the setting that would send them to the places you are listing.

Thank you for your great help! :+1:

Is it possible I redirect the output of executor to the "stdout" file? @fmpwizard Thank you in advance.

Oh, got it. Run it with mesos-master and mesos-slave.


the localization confidence  isn't object detection’s object confidence?

hello, I want to know the localization confidence in your paper isn't object detection’s object confidence?

Hello, thanks for your attention！
The localization confidence is obtained from detectors, but it is not the object confidence. The 2D Detector in the third part of our paper (3.Proposed Method), we introduced how to get he localization confidence (https://arxiv.org/abs/2309.09765). And you can learn more details about the localization confidence from IoU-Net.

I'm sorry, I didn't look carefully enough. Thank you for your patient response!


fix(readme): add notes

remove namespace from postgres-DB
add more checks to deploy/config/is_*
remove deps to Taskfile to make startup/teardown easier

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


feat: update arch for fetching binary

Following @timostamm 's feedback in #510 to support osx updated
Address issue #515 for win32
Support linux arm64 version

This was released in v2.9.0


arp:

Is this a bug report or a feature request?:
bug
What happened:
Updating a deployment with set image seems to kill the LB to pod redirection:
%  dig @<IP_ADDRESS> mx miek.nl
; <<>> DiG 9.10.3-P4-Debian <<>> @<IP_ADDRESS> mx miek.nl
; (1 server found)
;; global options: +cmd
;; connection timed out; no servers could be reached

What you expected to happen:
should just work.

Seems coredns is dead.

ah, set the wrong image: zsh. Now again:
 kubectl set image deployment/coredns-deployment coredns=miek/coredns:0.6

works.


remove obsolete test excludes

well, we'll see what's obsolete and what isn't...

queued: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/4664/

all were still green except scribe

we'll see if some of these exclusions need to come back, but commented as "intermittent" this time


KYC-Match-ParameterDesriptionRefine

What type of PR is this?

correction

What this PR does / why we need it:

To refine parameters/attributes description of the KYC-Match yaml v0.1.0.
Need this to finalise v0.1.0.

Which issue(s) this PR fixes:
Special notes for reviewers:
Changelog input
Additional documentation

Hi all,
As agreed at yesterday's meeting.
For Country, country code alpha-3 is proposed, as I think it is easier to understand than alpha-2, and OIDF eKYC-IDA adopts alpha-3.
Best regards,
Toshi

@ToshiWakayama-KDDI Thanks for the PR

@ToshiWakayama-KDDI , @fernandopradocabrillo, you'are right in DeviceStatus API alpha-2 is required for countryName (added to a countryCode attribute) and not country. I haven't found in Camara API any country attribute name valued in alpha-2. I wonder if we should really normalize the country attribute. What do you think about ?
Gilles

For gender I agree with @fernandopradocabrillo, an enum could be an interesting proposal.
Thanks
BE
Gilles

Hi @ToshiWakayama-KDDI ! can we apply those little changes and merge this PR?
Thanks!! 😄

Hi @fernandopradocabrillo , Hi @GillesInnov35
Sorry for the delay.  Gender enum is fine.  But I am not sure of 'country' - country id, alpha-2/alpha-3 etc.  Could we revert to 'Country of customer's address' for v0.1.0?
Best regards,
Toshi

Hi @fernandopradocabrillo , Hi @GillesInnov35
Sorry for the delay. Gender enum is fine. But I am not sure of 'country' - country id, alpha-2/alpha-3 etc. Could we revert to 'Country of customer's address' for v0.1.0?
Best regards, Toshi

Hi @ToshiWakayama-KDDI , fine from my side!
We can move the discussion to commonalities and decide there. My position is to maintain what is already been used in Device Status, but if you (or anybody) has a different approach I think it is best to discuss it in a common forum to reach a global agreement.

Hi @fernandopradocabrillo ,
Thank you, Fernando, for your comment.
Hi @fernandopradocabrillo , Hi @GillesInnov35 ,
Could you review and approve this PR again please.  Gender enum has been added, and Country has reverted.
Many thanks,
Toshi

Hi @ToshiWakayama-KDDI , @fernandopradocabrillo , I'm in line with you that we can let commonalities make the decision and publish recommendations. I agree also with @fernandopradocabrillo that we should be in line with the other API's specifications such as DeviceStatus.
I've asked my colleagues who are TMF contributors their opinion and they told me that they proposed for another API a schema for a StandardIdentifier ( format, value)    "format examples": ["ISO 3166-1","ISO 3166-1 Alpha 2","ISO 3166-1 Alpha 3","ISO 3166-1 Numeric"].
I mean that even if it is a simple attribute it might be defined by Commonalities' decisions.
Thanks a lot for your work
BR   Gilles

Hi @ToshiWakayama-KDDI @GillesInnov35 , we can merge this PR already right?

hi @fernandopradocabrillo

we can merge this PR already right?

Yes we can merge it

Thank you, @fernandopradocabrillo , @GillesInnov35 .  I will merge this PR shortly.


Aix ppc64 xlc builder

Python on AIX is available in a version built with IBM XLC and a version built with GCC, so builders for each configuration would be beneficial.
This patch updates the Python Buildbot configuration to add a factory to use the IBM XLC compiler and a builder on the edelsohn-aix-ppc64 worker to use the new factory.

Thanks @edelsohn !


Rearranging devdeps, improving package.json readability

There are a few deps in the dependencies section of package.json that could be pulled out to devDependencies, and I also moved some cookiecutter conditionals around to make the dependencies easier to read.
Saw there's a big refactor of mo static coming, looks really cool. Hope y'all are doing good :v:

Hey @elifitch thanks for the PR!
I agree there are many npm deps that would technically be devDependencies, however we include them in the dependencies list instead so these get installed on Heroku by default since they are required in order to build the static assets. This does make our slug sizes a lot bigger, but if we're only using node during the app build step, we can use https://github.com/istrategylabs/heroku-buildpack-node-cleanup to clean these modules up.
We did focus on reducing the overall dependencies in the new refactor you mentioned, so keep an eye out for that! https://github.com/istrategylabs/mo-static/pull/77

@akrawchyk Oh! Well neyvermind then 👌


Post constructor initialization

Here's a proposal for doing post-constructor initialisation.
[AutoConstruct(nameof(Initialize))]
public partial class MyClass
{
    private readonly IService _service;

    private void Initialize()
    {
        // Do some post constructor setup here.
    }
}

The generated code.
partial class MyClass
{
    public MyClass(IService service)
    {
        _service = service;
        Initialize();
    }
}

Does nameof work like that in an attribute?
Does it matter if it's only after the fields are set? The benefit of that is the fields are available in the initialize method.
Should there be a way of setting the "Initialize" name at a global level, so it doesn't need to be repeated in each attribute?

This is risky. It may end up calling a method when you don't want it to.
Might do this after the first version.

For a first implementation the initialize method must have no parameters and return void.

cc @Thundarr1974

Nice!

Yes, nameof will work fine. I think you could leave the Init method name optional (defaulted to Initialize) and just have that if the user wanted to use a diff name for some reason.
I would assume it fires after the fields are set, but maybe name it "Initialized" for clarity. Potentially could have an "Initialize()" call before the fields are set, but I don't see much of a use case for it.
Most other CodeGen libraries I'm using have a built-in name that it will look for by default, but allow customization through the decoration attribute parameters.

Yes, nameof will work fine. I think you could leave the Init method name optional (defaulted to Initialize) and just have that if the user wanted to use a diff name for some reason.

Lol it's actually easier to have it so if a method name is provided, the generator just adds the code, and if the method is missing the compiler does the work of returning that error. Having AutoCtor detect if the method is there or not and then add the call is more work. I chose the lazy version.

Most other CodeGen libraries I'm using have a built-in name that it will look for by default, but allow customization through the decoration attribute parameters.

Can you share some of those libraries? I'm curious to see what others solutions are out there.

The main ones used on our current project are Injectio, Mapperly, Vogen and this one.

Ok, next idea. I keep hitting the following when converting a project.
The constructor has some legacy code.
public MyClass(IService service, Func<Something> somethingFunc, AnotherObject anotherObject)
{
    _service = service; // Standard

    // How to handle these?
    _something = somethingFunc();
   anotherObject.DoSomething();
}

The idea is to include any arguments that Initialise() takes as part of the constructor. For example.
public void Initialise(Func<Something> somethingFunc, AnotherObject anotherObject)
{
    _something = somethingFunc();
   anotherObject.DoSomething();
}

Would generate
public MyClass(IService service, Func<Something> somethingFunc, AnotherObject anotherObject)
{
    _service = service;
    Initialise(somethingFunc, anotherObject);
}

Is the use case to allow a constructor parameter without having to have a backing field? That would be a nice feature.
If the user puts parameters on Initialize() it does imply they have to be on the constructor (where else could the value(s) come from?).
The cleanest solution IMO would be to define a new [AutoInitialize] decorator attribute so the user can opt-in by putting it on a method. That way you know exactly which method should be called.

Updated proposal

[assembly: AutoConstruct(string methodName)]
This attribute sets the default method to be called as a post constructor method.
Example
[assembly: AutoConstruct("Initialise")]

[AutoConstruct]
public partial class MyClass
{
    private readonly IService _service;

    private void Initialise()
    {
    }
}

Generated
partial class MyClass
{
    public MyClass(IService service)
    {
        _service = service;
        Initialise();
    }
}

If there is multiple methods with the same name a compiler error will be thrown saying the specific method to be used must be marked with [AutoPostConstruct].

[AutoPostConstruct]
This attribute is to mark a method directly as the post-constructor method. This will override the default if that is set.
Example
[assembly: AutoConstruct("Initialise")]

[AutoConstruct]
public partial class MyClass
{
    private readonly IService _service;

    [AutoPostConstruct]
    private void CustomPostConstruct()
    {
    }
}

Generated
partial class MyClass
{
    public MyClass(IService service)
    {
        _service = service;
        CustomPostConstruct();
    }
}

Pass parameters through to post-construct method
If there are parameters on the post-construct method they will be passed through the constructor as it's created.
Example
[AutoConstruct]
public partial class MyClass
{
    private readonly IService _service;

    [AutoPostConstruct]
    private void PostConstruct(ISomethingElse somethingElse)
    {
        somethingElse.DoThing();
    }
}

Generated
partial class MyClass
{
    public MyClass(IService service, ISomethingElse somethingElse)
    {
        _service = service;
        PostConstruct(somethingElse);
    }
}

Nice - Can't wait for this to be available!
Q: Is the AutoConstruct assembly directive required for the behavior to be enabled?

Q: Is the AutoConstruct assembly directive required for the behavior to be enabled?

No. You can use any of the 3 ways to specify a post-constructor method.

[assembly:AutoConstruct("Method")] will set a default if not overridden by another option
[AutoConstruct("Method")] will call Method for the type it's on, so long as method is there.
[AutoPostConstruct] on a method will always use this method.

2.0.0-alpha.1 should now be available with all the new features. Give it a spin.

Fantastic! Updated to the new pkg and incorporated on the perfect use case for it - configuring a private field without need of backing fields... !
[AutoConstruct]
public partial class CompensationService : DisposableBase, ICompensationService
{
    private ActionBlock<ScopeContext> SaveContextBlock = default!;

    [AutoPostConstruct]
    protected void Init(IHostApplicationLifetime hostLifetime, CompensationSettings settings)
    {
        SaveContextBlock = new ActionBlock<ScopeContext>(..., new ExecutionDataflowBlockOptions
        {
            BoundedCapacity = settings.IssueQueueCapacityMax,
            MaxDegreeOfParallelism = Environment.ProcessorCount,
            CancellationToken = hostLifetime.ApplicationStopping
        });
    }

This is our new favorite generator :)

Ok, now that I've started using the new version, there's a couple more todo items for this feature.

Defining the post constructor method as a string is not needed and bad syntax. Anything can be put into a string and that can lead to injection style hacks.
There's no way to opt-out of the assembly level definition.
Some of the current warnings should become errors. Ultimately if the generator cannot call the post construct method for any reason, it should be an error if the [AutoPostConstruct] attribute is included as the author is expecting the method to be called when it cannot.

Version 2.0.0 has been released with this new feature.


Activity Group Support

fixes #850

Summary of changes

Implement group load, display, and filtering support in Dive.
Implement KPF group parser in TS (cli only for now)
Implement new schema, Dive Json V2, in desktop and web, with migrations on both platforms.
Primary key of annotation objects (trackId) is migrated to id for consistency between track and group.

Summary of Approach
The general goal in this PR is to refactor a significant chunk of the core data and logic that dealt exclusively with tracks to make generic, abstract base classes that could be extended as Track and Group variants

track.ts becomes BaseAnnotation.
useTrackStore becomes BaseAnnotationStore.
useFilterControls becomes BaseFilterControls.
useStyleManager becomes StyleManager.
useTrackSelectionControls generally has moved into useModeManager where it seems to belong.
TypeList becomes FilterList and takes generics.
Lots of stuff that used to operate on Track now operates on BaseAnnotation
FrameDataTrack, the interface to an on-screen annotation, gets expanded to include references to groups.  I also back out the unnecessary "performance enhancement" of destructuring properties like confidencePairs into that interface and just pass the track reference wholesale.  This performance enhancement was useless and based on an incomplete understanding of computed properties, which are always shallow refs.  (They could still be watched deeply, which would be very bad for performance, but deep:true is such a red flag to me at this point that I don't see much risk in making this change -- it would be caught in review)

Instead of taking the return values of each composition function and breaking them down into reactive state and handlers, the provide interface is simplified by taking instances of the classes above (2 each, for tracks and groups).
In general, this change moves away from abusing composition functions and toward more standard OOP.  Here's an example.
// Before -- Inject state directly
const allTypesRef = useAllTypes();
// After -- Inject the TrackFilter class and access its property.
const allTypesRef = useTrackFilters().allTypes;

// Before -- Inject trackMap and then fetch using helper.
const trackMap = useTrackMap();
const track = getTrack(trackMap, trackId);
// After -- call instance method on trackStore class
const track = useTrackStore().get(trackId);

This does have one glaring disadvantage: the ability to wrap functions (like removeTrack, for example) in contextual behavior (like showing a dialog) is now less obvious when and where it should be done.  handler still exists, and its functions should still be used to trigger mutations.   It would be great to have some way to register a chain of side-effects on certain kinds of state mutations or come up with a more sane theory of how useModeManager wraps or does not wrap mutations in other modules.  Resolving this design difficulty will make a huge improvement on the quality of the code.
For now, the rule I've tried to follow is if it can be called directly (in an AnnotationStore, FilterControls, etc) do that.  Otherwise, make a wrapper function in useModeManager.  This is partly why I moved useTrackSelectionControls to that file.
Web notes
This change adds a new mongo collection and a migration script in docker/server_setup.py to move the old annotationItem to trackItem, change the id, regenerate indexes, etc.
Test data
I probably forgot to do some stuff IDK.

To try the feature out, use this video https://viame.kitware.com/#/viewer/616984a677e2fb3216074bc3
Here's a folder with annotation data: https://drive.google.com/drive/folders/1yazuOc5mwP_q98EpckEotSiHFrnz8CrO

I think I've fixed the things that need fixing on client and server.   Integration tests are now passing.  Client unit tests are passing except for that one test.


Support for whisper.cpp?

Are there any plans for supporting ggerganov's whisper.cpp implementation of WhisperAI?
transcribe-anything's ease of use and API + whisper.cpp's performance would be fantastic.

This is a fantastic idea.
I've wanted to do this but right now I'm busy with another (paid) project.
I'll accept a PR though to get this working.

Might be a good idea to have a python package called whisper.ai.cpp with builders for mac/linux/windows to prove it works on all platforms.
Then adding it would be a snap.

There are faster whisper implementations for cpu. Also I recommend that --device insane is used which works for Mac M1 using the mps device.


added a ready list in kitchen

Changes made

added a ready list in the kitchen client
a text replaces the buttons when something is preparing
changed prepping time to 5s
ready orders can now be popped in the kitchen
preparations list now list the items in the current order at the top
preparations list now shows the number of item in an order
removed repeating order in orders column in preparations list
fixed the bug where if user does not click an item in prep list, when any of the prep button list pressed, it creates the previous prepped item
Discard checking is now done every 2s
Orders are now highlighted when an item is selected in the prep list is included in that order

Bug bug bug!!


Design: more space before text that follows code blocks

Disclaimer: I am not a web designer
I find that the looks of text following code blocks is a bit awkward and misleading:

For me the "For example" comes too close to the preceding code block. I would prefer to have the same space before and after the block.

Yep I think this is probably a bug, thanks for noticing 👍 I agree we should have at least the same amount of space before/after by default


"Read more" link is broken on >= 1 page

Not sure what makes this specific page different:
http://gitxiv.com/posts/pvuSi2QwFBFCb5pDC/paragraph-vector-distributed-representations-of-sentences

tnx! fixed now, was a "http" missing in front of the arxiv url


Timeout not working?

While this seems to be the best code around to send plain ICMP pings efficiently on iOS, I have a problem with the timeout.
I tried to set the timeout to 1s:
let once = SwiftyPing(host: "<IP_ADDRESS>", configuration: PingConfiguration(interval: 1,with: 1), queue: DispatchQueue.global())
        once?.observer = { (_, response) in
            let duration = response.duration
            print(duration)
            once?.stop()
            print("stopped")
        }
        once?.start()

However, I don't get a timeout. If there is e.g. a 2s latency, the observer just normally gets called after 2s printing the latency.
How can I get a real timeout, i.e. that my function above or another one gets called on timeout?
Note: I used the fix in #7 to have just a single ping.

Same issue for me: timeout doesn't seem to have an effect ... I tried testing it with a local IP address I know doesn't exist & it never enters the .observer closure, or into .errorClosure. Perhaps there is another way I'm able to detect a timeout error (specific throw, error?).

It turned out that the socket timeout error previously implemented was actually just about sending the request, not about receiving it. I have now added a timeout watchdog, so it should now work properly. My testing was limited, so feel free to open a new issue if it still doesn't work.

It now works perfectly.
This library is the best low level ping library for swift - thank you very much @samiyr for your great work!


Sidebar: use release blog post URL for release notes

Changes the behavior of getReleaseNotesURLByIDE to always return the release blog post URL for VS Code.
Adds a new getReleaseBlogPostURL function to construct the release blog post URL based on the version number.
Updates the unit tests to reflect the new behavior.

Test plan

Verify clicking on the following options will redirect you to the release blog post instead of github release notes:

"Release Notes" option in the sidebar
Upgraded notification in Chat pop-up

https://github.com/sourcegraph/cody/assets/68532117/b4e8537f-87b6-4598-ae2c-eb4fc877f00b

Did not run locally, so I'm not the best to review, but I left a comment on the test.

Did not run locally, so I'm not the best to review, but I left a comment on the test.

@rrhyne Thanks! You might need to submit the review for the comment to show


automatically_mark_as_processed false causes infinite loop #441

This PR aims to solve the problem of lack of offset management for topics without automatic marking. It introduces an in memory offset cache per each partition and topic. Also it supports the failure and will reconsume the whole match for each_batch and the last message for each_message.

Thanks! I'll look at this tomorrow. 👍

Thanks!


Consider having glibc print warnings when LD_LIBRARY_PATH contains empty segments

We had a bad security bug in #67234 caused by the chromium derivation modifying LD_LIBRARY_PATH and unintentionally adding an empty segment (typically caused by a leading or trailing :). Empty segments cause glibc to look for shared libraries in the current working directory. This is particularly dangerous with programs that may frequently be started from a directory with untrusted files.
Because the empty-segment->"load .so from cwd" behavior is very dangerous and almost always unintended, I propose patching our glibc to emit a scary warning when an empty segment is present in LD_LIBRARY_PATH. This would help shake out additional security bugs in both nixpkgs and the software within it. The loading behavior would not be changed, it would just emit a warning to stderr so that we know what to fix, and to detect new regressions early.
To mitigate problems with the rare software that relies on this behavior and where warnings in stderr are unacceptable, a new environmental variable could be used to control the warning.

Why do you propose this being patched in nixpkgs and not upstream glibc?

Probably because we particularly suck at this…
pkgs/applications/graphics/paraview/default.nix:33:    export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$PWD/lib:$PWD/VTK/ThirdParty/vtkm/vtk-m/lib
pkgs/applications/misc/audio/soxr/default.nix:16:    export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:"`pwd`/build/src
pkgs/applications/networking/mailreaders/claws-mail/default.nix:46:    export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:${python}/lib
pkgs/applications/office/gnucash/default.nix:82:    export LD_LIBRARY_PATH=$PWD/lib:$PWD/lib/gnucash:$PWD/lib/gnucash/test:$LD_LIBRARY_PATH
pkgs/applications/video/avidemux/default.nix:69:    export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:${libXext}/lib"
pkgs/build-support/build-fhs-userenv/env.nix:55:    export LD_LIBRARY_PATH="/run/opengl-driver/lib:/run/opengl-driver-32/lib:/usr/lib:/usr/lib32:$LD_LIBRARY_PATH"
pkgs/desktops/deepin/dde-file-manager/default.nix:232:    export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:${zlib}/lib";
pkgs/desktops/deepin/dde-file-manager/default.nix:233:    export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:${libX11}/lib";
pkgs/desktops/enlightenment/efl.nix:126:    export LD_LIBRARY_PATH="${curl.out}/lib:$LD_LIBRARY_PATH"
pkgs/development/compilers/halide/default.nix:32:    export LD_LIBRARY_PATH="$(pwd)/lib:$LD_LIBRARY_PATH"
pkgs/development/compilers/llvm/4/llvm.nix:139:    export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$PWD/lib
pkgs/development/compilers/llvm/5/llvm.nix:115:    export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$PWD/lib
pkgs/development/compilers/llvm/6/llvm.nix:123:    export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$PWD/lib
pkgs/development/compilers/llvm/7/llvm.nix:144:    export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$PWD/lib
pkgs/development/compilers/llvm/8/llvm.nix:120:    export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$PWD/lib
pkgs/development/compilers/llvm/9/llvm.nix:137:    export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$PWD/lib
pkgs/development/compilers/mlton/20130715.nix:80:    export LD_LIBRARY_PATH=${gmp.out}/lib:$LD_LIBRARY_PATH
pkgs/development/compilers/solc/default.nix:57:      LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$(pwd)/$dir
pkgs/development/guile-modules/guile-lib/default.nix:24:    "$(dirname $(echo ${stdenv.cc.cc.lib}/lib*/libgcc_s.so)):$LD_LIBRARY_PATH"
pkgs/development/haskell-modules/hackage-packages.nix:93356:       preBuild = ''export LD_LIBRARY_PATH=`pwd`/dist/build:$LD_LIBRARY_PATH'';
pkgs/development/interpreters/pure/default.nix:27:    LD_LIBRARY_PATH=$LD_LIBRARY_PATH:${llvm}/lib make check
pkgs/development/libraries/boxfort/default.nix:32:    export LD_LIBRARY_PATH=`pwd`:$LD_LIBRARY_PATH
pkgs/development/libraries/caf/default.nix:25:    export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$PWD/lib
pkgs/development/libraries/criterion/default.nix:33:    export LD_LIBRARY_PATH=`pwd`:$LD_LIBRARY_PATH
pkgs/development/libraries/cutelyst/default.nix:27:    export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:`pwd`/Cutelyst:`pwd`/EventLoopEPoll"
pkgs/development/libraries/glib/default.nix:166:    export LD_LIBRARY_PATH="$NIX_BUILD_TOP/${pname}-${version}/glib/.libs:$LD_LIBRARY_PATH"
pkgs/development/libraries/grpc/default.nix:41:    export LD_LIBRARY_PATH=$(pwd):$LD_LIBRARY_PATH
pkgs/development/libraries/jsoncpp/default.nix:28:    export LD_LIBRARY_PATH="`pwd`/src/lib_json:$LD_LIBRARY_PATH"
pkgs/development/libraries/libtins/default.nix:35:    export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$PWD${placeholder "out"}/lib
pkgs/development/libraries/orcania/default.nix:22:    export LD_LIBRARY_PATH="$(pwd):$LD_LIBRARY_PATH"
pkgs/development/libraries/qt-4.x/4.8/default.nix:122:    export LD_LIBRARY_PATH="`pwd`/lib:$LD_LIBRARY_PATH"
pkgs/development/libraries/qt-5/modules/qtbase.nix:167:    export LD_LIBRARY_PATH="$PWD/lib:$PWD/plugins/platforms:$LD_LIBRARY_PATH"
pkgs/development/libraries/science/math/arpack/default.nix:35:    export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:`pwd`/lib
pkgs/development/libraries/science/math/scalapack/default.nix:43:    export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:`pwd`/lib
pkgs/development/libraries/yder/default.nix:35:    export LD_LIBRARY_PATH="$(pwd):$LD_LIBRARY_PATH"
pkgs/development/pharo/vm/build-vm.nix:120:    LD_LIBRARY_PATH="\$LD_LIBRARY_PATH:$libs" exec $out/pharo "\$@"
pkgs/games/dwarf-fortress/dfhack/default.nix:112:      export LD_LIBRARY_PATH="$PWD/depends/protobuf:$LD_LIBRARY_PATH"
pkgs/games/dwarf-fortress/wrapper/dfhack.in:10:LD_LIBRARY_PATH="$env_dir/hack/libs:$env_dir/hack:$LD_LIBRARY_PATH" \
pkgs/games/steam/chrootenv.nix:56:    export LD_LIBRARY_PATH="$runtime_paths:$LD_LIBRARY_PATH"
pkgs/games/steam/chrootenv.nix:263:      ${lib.optionalString (!nativeOnly) "export LD_LIBRARY_PATH=/lib32:/lib64:${lib.concatStringsSep ":" ldPath}:$LD_LIBRARY_PATH"}
pkgs/os-specific/linux/ati-drivers/builder.sh:288:      wrapProgram $out/bin/$(basename $prog) --prefix LD_LIBRARY_PATH : $out/lib/:$gcc/lib/:$out/share/ati/:$libXinerama/lib/:$libXrandr/lib/:$libfontconfig/lib/:$libfreetype/lib/:$LD_LIBRARY_PATH
pkgs/os-specific/linux/tiscamera/default.nix:87:    export LD_LIBRARY_PATH=$PWD/src:$LD_LIBRARY_PATH
pkgs/servers/plex/default.nix:100:    LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$root exec "$root/Plex Media Server"
pkgs/tools/X11/libstrangle/nixos.patch:29:+FPS="${FPS}" LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:@out@/lib/libstrangle/lib64:@out@/lib/libstrangle/lib32" LD_PRELOAD="${LD_PRELOAD}:libstrangle.so" exec "$@"
pkgs/tools/X11/primus/default.nix:30:  export LD_LIBRARY_PATH=${ldPath}:$LD_LIBRARY_PATH
pkgs/tools/filesystems/ceph/default.nix:135:      export LD_LIBRARY_PATH="$PWD/build/lib:$LD_LIBRARY_PATH"
pkgs/tools/misc/staruml/default.nix:45:        --prefix LD_LIBRARY_PATH : $out/lib:${LD_LIBRARY_PATH}
pkgs/tools/security/neopg/default.nix:34:    export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$(pwd)/3rdparty/googletest/googletest:$(pwd)/neopg
pkgs/tools/text/opencc/default.nix:14:    "LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$(CURDIR)/src"

I made an attempt to fix these existing issues at #76804.


update sdk ts for diagram generation

Many thanks for submitting your Pull Request :heart:!
What this PR does / why we need it:
update sdk-ts to this commit https://github.com/serverlessworkflow/sdk-typescript/commit/b3357710dbff278aeaff681724694f81dcf29066
Special notes for reviewers:
Additional information (if needed):

@antmendoza PERFECT! thank you very much!


lack of code about the University-1652 dataset

aquire the University-1652 code and model config

Do you solve this problem?


read row_order_position => nil

when i use an_object.row_order_position, i have nil but an_object.row_order return 4194304.
row_order_position isn't an accesor to have the position of the object ? how can I get it with ranked-model ?
actually, I use this :
AllObject.all.find_index(an_object)

Good hints there :) Closing due to age.


Mount volumes on driver pod?

I am doing this because I want to store the output back to my local file system since in the cluster mode, the output is written back the driver pod. Is this supported?

I'm pretty sure we will support volume mounts but only on Spark 2.4. You can also take the tip of the master branch of Spark to get volume support.
Also, please note that we are no longer improving this fork at all and all further development is being done towards apache/master.

Actually volume support is in the works - https://github.com/apache/spark/pull/21260


format fixed for loader_impl_mock_function declaration

Description
The declaration of pointers to struct followed the following format in the loader module.
typedef struct loader_impl_function_type
{
	loader_impl_function_create create;
	loader_impl_function_interface interface;
	loader_impl_function_destroy destroy;

} * loader_impl_function;

This was different in mock loader so, changed it to make it uniform everywhere :)

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Documentation Update

Checklist:

[x] My code follows the style guidelines (Clean Code) of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
[ ] I have tested my code with OPTION_BUILD_SANITIZER and OPTION_TEST_MEMORYCHECK.
[ ] I have tested with Helgrind in case my code works with threading.

If you are unclear about any of the above checks, have a look at our documentation here

Have you tested the changes?

All tests are passing with ctest after building cmake  -DOPTION_BUILD_SANITIZER ..
I get No rule to make target 'memcheck'.  Stop. when I run make memcheck after building with cmake -DOPTION_TEST_MEMORYCHECK

All tests are passing with make test
Running tests...
Test project /home/siv2r/Projects/core/build
      Start  1: preprocessor-test
 1/32 Test  #1: preprocessor-test ...........................   Passed    0.01 sec
      Start  2: environment-test
 2/32 Test  #2: environment-test ............................   Passed    0.01 sec
      Start  3: log-test
 3/32 Test  #3: log-test ....................................   Passed    0.01 sec
      Start  4: log-custom-test
 4/32 Test  #4: log-custom-test .............................   Passed    0.01 sec
      Start  5: adt-set-test
 5/32 Test  #5: adt-set-test ................................   Passed    0.01 sec
      Start  6: adt-trie-test
 6/32 Test  #6: adt-trie-test ...............................   Passed    0.01 sec
      Start  7: adt-vector-test
 7/32 Test  #7: adt-vector-test .............................   Passed    0.01 sec
      Start  8: reflect-value-cast-test
 8/32 Test  #8: reflect-value-cast-test .....................   Passed    0.01 sec
      Start  9: reflect-function-test
 9/32 Test  #9: reflect-function-test .......................   Passed    0.01 sec
      Start 10: reflect-object-class-test
10/32 Test #10: reflect-object-class-test ...................   Passed    0.01 sec
      Start 11: reflect-scope-test
11/32 Test #11: reflect-scope-test ..........................   Passed    0.01 sec
      Start 12: reflect-metadata-test
12/32 Test #12: reflect-metadata-test .......................   Passed    0.01 sec
      Start 13: dynlink-test
13/32 Test #13: dynlink-test ................................   Passed    0.01 sec
      Start 14: detour-test
14/32 Test #14: detour-test .................................   Passed    0.01 sec
      Start 15: serial-test
15/32 Test #15: serial-test .................................   Passed    0.01 sec
      Start 16: configuration-test
16/32 Test #16: configuration-test ..........................   Passed    0.01 sec
      Start 17: loader-path-test
17/32 Test #17: loader-path-test ............................   Passed    0.01 sec
      Start 18: metacall-logs-test
18/32 Test #18: metacall-logs-test ..........................   Passed    0.01 sec
      Start 19: metacall-load-memory-test
19/32 Test #19: metacall-load-memory-test ...................   Passed    0.01 sec
      Start 20: metacall-load-configuration-test
20/32 Test #20: metacall-load-configuration-test ............   Passed    0.01 sec
      Start 21: metacall-test
21/32 Test #21: metacall-test ...............................   Passed    0.01 sec
      Start 22: metacall-distributable-test
22/32 Test #22: metacall-distributable-test .................   Passed    0.01 sec
      Start 23: metacall-ducktype-test
23/32 Test #23: metacall-ducktype-test ......................   Passed    0.01 sec
      Start 24: metacall-inspect-test
24/32 Test #24: metacall-inspect-test .......................   Passed    0.01 sec
      Start 25: metacall-initialize-test
25/32 Test #25: metacall-initialize-test ....................   Passed    0.01 sec
      Start 26: metacall-initialize-ex-test
26/32 Test #26: metacall-initialize-ex-test .................   Passed    0.01 sec
      Start 27: metacall-reinitialize-test
27/32 Test #27: metacall-reinitialize-test ..................   Passed    0.01 sec
      Start 28: metacall-initialize-destroy-multiple-test
28/32 Test #28: metacall-initialize-destroy-multiple-test ...   Passed    0.01 sec
      Start 29: metacall-invalid-loader-test
29/32 Test #29: metacall-invalid-loader-test ................   Passed    0.01 sec
      Start 30: metacall-fork-test
30/32 Test #30: metacall-fork-test ..........................   Passed    0.01 sec
      Start 31: metacallcli
31/32 Test #31: metacallcli .................................   Passed    0.01 sec
      Start 32: metacalllog
32/32 Test #32: metacalllog .................................   Passed    0.01 sec

100% tests passed, 0 tests failed out of 32

Label Time Summary:
MEMCHECK_IGNORE                              =   0.02 sec*proc (3 tests)
adt-set-test                                 =   0.01 sec*proc (1 test)
adt-trie-test                                =   0.01 sec*proc (1 test)
adt-vector-test                              =   0.01 sec*proc (1 test)
configuration-test                           =   0.01 sec*proc (1 test)
detour-test                                  =   0.01 sec*proc (1 test)
dynlink-test                                 =   0.01 sec*proc (1 test)
environment-test                             =   0.01 sec*proc (1 test)
loader-path-test                             =   0.01 sec*proc (1 test)
log-custom-test                              =   0.01 sec*proc (1 test)
log-test                                     =   0.01 sec*proc (1 test)
metacall-distributable-test                  =   0.01 sec*proc (1 test)
metacall-ducktype-test                       =   0.01 sec*proc (1 test)
metacall-fork-test                           =   0.01 sec*proc (1 test)
metacall-initialize-destroy-multiple-test    =   0.01 sec*proc (1 test)
metacall-initialize-ex-test                  =   0.01 sec*proc (1 test)
metacall-initialize-test                     =   0.01 sec*proc (1 test)
metacall-inspect-test                        =   0.01 sec*proc (1 test)
metacall-invalid-loader-test                 =   0.01 sec*proc (1 test)
metacall-load-configuration-test             =   0.01 sec*proc (1 test)
metacall-load-memory-test                    =   0.01 sec*proc (1 test)
metacall-logs-test                           =   0.01 sec*proc (1 test)
metacall-reinitialize-test                   =   0.01 sec*proc (1 test)
metacall-test                                =   0.01 sec*proc (1 test)
metacallcli                                  =   0.01 sec*proc (1 test)
metacalllog                                  =   0.01 sec*proc (1 test)
preprocessor-test                            =   0.01 sec*proc (1 test)
reflect-function-test                        =   0.01 sec*proc (1 test)
reflect-metadata-test                        =   0.01 sec*proc (1 test)
reflect-object-class-test                    =   0.01 sec*proc (1 test)
reflect-scope-test                           =   0.01 sec*proc (1 test)
reflect-value-cast-test                      =   0.01 sec*proc (1 test)
serial-test                                  =   0.01 sec*proc (1 test)

Total Test time (real) =   0.24 sec

All tests are passing with ctest after building cmake  -DOPTION_BUILD_SANITIZER ..
I get No rule to make target 'memcheck'.  Stop. when I run make memcheck after building with cmake -DOPTION_TEST_MEMORYCHECK

That's maybe because they are mutually exclusive, you have to disable sanitizer before enabling memory check.


Unable to install extension in wsl

Type: Bug
Click Install in wsl, it prompts that it has been installed, but it still shows that it needs to be installed in wsl. or Always installing
VS Code version: Code 1.82.2 (abd2f3db4bdb28f9e95536dfa84d8479f1eb312d, 2023-09-14T05:55:25.390Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1498)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.60GB (5.97GB free)

Process Argv
--crash-reporter-id e95c51ef-3414-4d33-a0f3-242a496db92b

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: dev

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1497)

Memory (System)
7.56GB (5.15GB free)

VM
0%

Extensions (5)

Extension
Author (truncated)
Version

jupyter-keymap
ms-
1.1.2

remote-wsl
ms-
0.81.3

copilot
Git
1.111.404

vscode-language-pack-zh-hans
MS-
1.82.2023091309

korofileheader
OBK
4.9.3

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
vsccc:30803844
282f8724:30602487
f6dab269:30613381
showlangstatbar:30737416
0bi6i642:30835152
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxpt:30805730
pythonnoceb:30805159
dsvsc013:30795093
dsvsc014:30804076
diffeditorv1:30821571
dsvsc015:30829745

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Add "Show despawn timer" option to NPC Indicators

Would be useful when pickpocketing trapped npcs to know when you need to let them move to prevent them from despawning

there is now an external plugin for this


fix(integrations-service): Return errors for failed integration executions

[!IMPORTANT]
Integration executions now return ExecutionError for failures, enhancing error handling across multiple integration utilities.

Behavior:

execute_integration in execute_integration.py now raises an exception if integration_service_response contains an error.
Integration functions in brave.py, browserbase.py, email.py, llama_parse.py, remote_browser.py, spider.py, weather.py, and wikipedia.py return ExecutionError on exceptions.

Models:

Adds ExecutionError model to execution.py to encapsulate error messages.

Functions:

Updates return types of integration functions to include ExecutionError in brave.py, browserbase.py, email.py, llama_parse.py, remote_browser.py, spider.py, weather.py, and wikipedia.py.

This description was created by  for fb41003100344cfb450aedcfa2a8259771634e20. It will automatically update as commits are pushed.

Lgtm. I’d add a TODO comment to refactor the try except into a decorator in the future. Merge if tested locally

@creatorrr Will do, thanks!


Suggestion: preload Interstitial

Admob team contact me about policy from interstital implementation. They suggest to preload the ad first (ex: when app starts), then show on needed.
This is useful to "Rewarded mediation": https://support.google.com/admob/answer/3063564?hl=en
I have did some modification. It is not the final implementation, but It is a start.
admob.preloadInterstitial = function(arg) {
  return new Promise(function (resolve, reject) {
    try {
      var settings = admob.merge(arg, admob.defaults);
      var activity = application.android.foregroundActivity;
      admob.interstitialView = new com.google.android.gms.ads.InterstitialAd(activity);
      admob.interstitialView.setAdUnitId(settings.androidInterstitialId);

      // Interstitial ads must be loaded before they can be shown, so adding a listener
      var InterstitialAdListener = com.google.android.gms.ads.AdListener.extend({
        onAdLoaded: function () {
          var a = admob.interstitialView.isLoaded();
          resolve(a);
        },
        onAdFailedToLoad: function (errorCode) {
          reject(errorCode);
        }
      });
      admob.interstitialView.setAdListener(new InterstitialAdListener());

      var ad = admob._buildAdRequest(settings);
      admob.interstitialView.loadAd(ad);

    } catch (ex) {
      console.log("Error in admob.createBanner: " + ex);
      reject(ex);
    }
  });
};

This should be more than a suggestion, because using the plugin this way is a violation of Admob's policies and as the OP says they will contact you. It is within Admob's rights to withhold your ad money and terminate your account. The issue is that they specifically say you cannot show an interstitial an indeterminate amount of time after the action that triggered it. It will almost never be the case that the interstitial is loaded immediately after it is requested. The way this plugin works at the moment, it will nearly always present the interstitial a few seconds after you call it, and that is exactly what Admob does not allow.

That's clear. Anyone wanting to contribute a solution?

Any update on this?

Any update about it?

In the README, it says: "Note that Interstitial banners need to be loaded before they can be shown, but don't worry: this plugin will manage that transparently for you", which seems in contradiction to this (open) issue.  Can you please clarify if preloading has been added for both platforms and this issue should be closed, or if the above statement is incomplete or inaccurate?

It’s accurate AND preloading hasn’t been added but it’s still up for grabs.
What the readme says is you don’t have to call 2 functions (load, then show when loaded) as it’s all integrated into 1 function.

It’s accurate AND preloading hasn’t been added but it’s still up for grabs.
What the readme says is you don’t have to call 2 functions (load, then show when loaded) as it’s all integrated into 1 function.

Can you please provide an example. All I can see is when I use your example on the main readme, it shows the ad as soon as it is loaded. How do I preload the ad and show when needed?

You are using a test ad, so that displays very quickly. But a normal ad will take at least a few seconds to load, and maybe longer depending on the ad content and the device connection. The way to test this properly is to log to the console when the ad is successfully loaded (or not), and then trigger the ad to display based on some action by the user. And this cannot be done with the plugin as it currently is.

So any other alternatives? maybe another plugin? How do you guys solve this problem in your own apps?

Exactly as @SteveOliverC states.
Btw, it's not too hard to add to this plugin, it's just a matter of priority/time.

Thanks for the plugin, really appreciate it.  But as it stands we shouldn't use the plugin for interstitial ads without first hacking the plugin code?
"Note that Interstitial banners need to be loaded before they can be shown, but don't worry: this plugin will manage that transparently for you." gives an entirely different impression!
SteveOliverC says he couldn't figure it out, so fat chance for those of us with lesser skills.

Okay, I see.  We can't preload and show when needed, but it effectively preloads.  Hacking only needed if we want to show the ad at a later point from when it's loaded.

Yep, that’s what that quote tries to say.

Let me try to be clear:

Yes, there's an issue (we need to add a function to explicitly load interstitials). At the moment they are preloaded automatically and shown when loaded (which allegedly is frowned upon by Google), instead of preloaded and shown on demand.
No, nothing was changed / fixed yet.
Happy to merge a PR because this issue needs to fight for my time with literally hundreds of other issues.

FYI I'm spending my weekend fixing this. iOS is already done. Android tomorrow. There will be 2 new methods: preloadInterstitial (with the same parameters as the current createInterstitial), and showInterstitial which should not be called before the promise of preloadInterstitial resolves, but can be called a long time after it has been preloaded.

Is it fixed in nativescript-plugin-firebase as well?

2.0.0 released, see the updated docs.

@umair-ameen Check https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/934 - now available from npm in nativescript-plugin-firebase version 7.1.1.

@EddyVerbruggen Thank you so much Eddy. You are awesome.

@EddyVerbruggen NICE work!!!

Brilliant, thanks!


Add source.removeUnused action to codeActionsOnSave

VS Code has a few useful codeActionsOnSave actions for code cleanup and organization, but it is missing a crucial option to only remove unused imports.
In Flutter, it is often common to separate "platform imports" (Flutter libraries, external packages, etc.) from local imports (app-specific classes and assets) with an empty line; sometimes even with 3 separate sections of imports, like so:
import 'dart:convert';
import 'dart:typed_data';

import 'package:app/core/utilities/image_tools.dart';
import 'package:app/users/user_model.dart';

import 'package:flutter/material.dart';

** The second section above contains the app-specific imports.
Currently, running the Organize Imports command removes the unused imports, but also sorts the remaining ones, AND removes any empty lines in between. However, using the Quick Fix menu to remove unused imports from the file does exactly what you'd expect; removing the unused imports without touching the order or spacing of the remaining imports.
Ideally, I would expect the source.organizeImports action to: 1) retain the spacing (while removing duplicate empty lines), 2) sort each import-block separately, and 3) remove unused imports within each import-block.
Alternatively, as the title says, having asource.removeUnused action that only removes unused imports - without sorting or organizing - will also work, as it will at least allow users to maintain the existing formatting.

Additional source actions can be contributed by extensions. JS/TS for example already implements this as source.removeUnused (it removed all unused code in the current file)
Please file an issue against Flutter if you want to see a source.removeUnused supported there as well


AWS again: reinstate database

Recreate the database on AWS. This uses smaller default instance and disk size than we used to have, and is in-line with what we were using on Render (which seemed to work just fine). Should save a little on costs.

Note to self: need to update the SNS subscription that powers our Slack integration once this deploys!

need to update the SNS subscription that powers our Slack integration once this deploys!

Enjoyably, the ARN for the alarm’s topic is based on its name, meaning this created a topic with the same ARN as the old one (we didn’t change the name), so the subscription that sends it to Slack just automatically picked it up! Didn’t actually have to do anything.