All privilege tests must define rvtest_mtrap_routine

Any tests that can possibly trap (and not immediately hang) must install a trap handler.
This is done by defining the variable  rvtest_mtrap_routine (and, if it traps into smode, also
rvtest_strap_routine, and if it traps into a guest OS,  rvtest_vtrap_routine).
None of the priv tests currently define this variable, so the trap handler code defaults to defining it.
There might b a better way than explicitly defining it in every test, but I don't see any obvious way to do that.

All privilege indeed define the rvtest_mtrap_routine macro here : https://github.com/riscv-non-isa/riscv-arch-test/blob/5932678c2edac2606f366144a1ed7ce5cc3cd611/riscv-test-suite/rv32i_m/privilege/Makefile#L3

Ah,that's where it is. Then we have a different problem. Thanks.


Add local chart support in airgapped environment for upgrade.

resolve: https://github.com/istio/istio/issues/28995
[ ] Configuration Infrastructure
[ ] Docs
[ X ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

This is still an issue, is there a reason it was closed without merging?

@morvencao curious why was this closed without merging. Did you find a workaround for this?

@Nino-K We haven't figured out how to get the old installed IOP without referring to the old chart, it is not good practice to specify the old chart location, user may use customized chart for the old IOP.

@morvencao "user may use customized chart for the old IOP." so this is the workaround?

@brendarearden When I say "user may use customized chart for the old IOP.", I mean that specifying the old chart location for upgrade may not be a general solution. Image that the istio was installed with customized chart, then upgrade with build-in old chart may get unexpected result.


Do not use a separate URI for reconnection

Right now, Palindrom uses a separate URI for reconnection: https://github.com/Palindrom/Palindrom/blob/d1fc4d358d6295baa73963a9bfeb15b70fbf70b1/src/palindrom.js#L291
It was added as a solution to https://github.com/Palindrom/Palindrom/issues/71. I am not sure why a new URI was introduced for that.
I think that reconnection can be achieved by calling the full transfer URI ("remote URL") with a proper set of headers.
Before implementing, make sure this is addressed in https://github.com/Palindrom/Palindrom/issues/61

To be addressed at https://github.com/Palindrom/Palindrom/issues/280#issuecomment-564160594


Build error of symengine.py when SymEngine's LLVMDoubleVisitor is enabled.

I experienced this error first locally, and I have now reproduced it in our CI:

Relevant part of log https://github.com/bjodah/symengine.py/actions/runs/9315200175/job/25640872589
running build
running build_ext
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

-- The C compiler identification is GNU 11.4.0
-- The CXX compiler identification is GNU 11.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Deprecation Warning at /home/runner/our_usr/lib/cmake/symengine/SymEngineConfig.cmake:34 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
Call Stack (most recent call first):
  CMakeLists.txt:16 (find_package)

-- Performing Test HAVE_FFI_CALL
-- Performing Test HAVE_FFI_CALL - Success
-- Found FFI: /home/runner/our_usr/lib/libffi.so
-- Performing Test Terminfo_LINKABLE
-- Performing Test Terminfo_LINKABLE - Success
                 from /home/runner/our_usr/include/boost/multiprecision/number.hpp:12,
                 from /home/runner/our_usr/include/boost/multiprecision/cpp_int.hpp:19,
                 from /home/runner/our_usr/include/symengine/mp_class.h:12,
                 from /home/runner/work/symengine.py/symengine.py/dist-extract/symengine-0.11.0/symengine/lib/symengine_wrapper.cpp:1275:
/home/runner/our_usr/include/boost/math/tools/config.hpp:23:6: warning: #warning "The minimum language standard to use Boost.Math will be C++14 starting in July 2023 (Boost 1.82 release)" [-Wcpp]
   23 | #    warning "The minimum language standard to use Boost.Math will be C++14 starting in July 2023 (Boost 1.82 release)"
      |      ^~~~~~~
In file included from /usr/include/c++/11/vector:66,
                 from /home/runner/work/symengine.py/symengine.py/dist-extract/symengine-0.11.0/symengine/lib/symengine_wrapper.cpp:1271:
/usr/include/c++/11/bits/stl_uninitialized.h: In instantiation of ‘_ForwardIterator std::uninitialized_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = std::move_iterator<SymEngine::LLVMDoubleVisitor*>; _ForwardIterator = SymEngine::LLVMDoubleVisitor*]’:
/usr/include/c++/11/bits/stl_uninitialized.h:333:37:   required from ‘_ForwardIterator std::__uninitialized_copy_a(_InputIterator, _InputIterator, _ForwardIterator, std::allocator<_Tp>&) [with _InputIterator = std::move_iterator<SymEngine::LLVMDoubleVisitor*>; _ForwardIterator = SymEngine::LLVMDoubleVisitor*; _Tp = SymEngine::LLVMDoubleVisitor]’
/usr/include/c++/11/bits/stl_uninitialized.h:355:2:   required from ‘_ForwardIterator std::__uninitialized_move_if_noexcept_a(_InputIterator, _InputIterator, _ForwardIterator, _Allocator&) [with _InputIterator = SymEngine::LLVMDoubleVisitor*; _ForwardIterator = SymEngine::LLVMDoubleVisitor*; _Allocator = std::allocator<SymEngine::LLVMDoubleVisitor>]’
/usr/include/c++/11/bits/vector.tcc:659:48:   required from ‘void std::vector<_Tp, _Alloc>::_M_default_append(std::vector<_Tp, _Alloc>::size_type) [with _Tp = SymEngine::LLVMDoubleVisitor; _Alloc = std::allocator<SymEngine::LLVMDoubleVisitor>; std::vector<_Tp, _Alloc>::size_type = long unsigned int]’
/usr/include/c++/11/bits/stl_vector.h:940:4:   required from ‘void std::vector<_Tp, _Alloc>::resize(std::vector<_Tp, _Alloc>::size_type) [with _Tp = SymEngine::LLVMDoubleVisitor; _Alloc = std::allocator<SymEngine::LLVMDoubleVisitor>; std::vector<_Tp, _Alloc>::size_type = long unsigned int]’
/home/runner/work/symengine.py/symengine.py/dist-extract/symengine-0.11.0/symengine/lib/symengine_wrapper.cpp:185448:39:   required from here
/usr/include/c++/11/bits/stl_uninitialized.h:138:72: error: static assertion failed: result type must be constructible from value type of input range
  138 |       static_assert(is_constructible<_ValueType2, decltype(*__first)>::value,
      |                                                                        ^~~~~
/usr/include/c++/11/bits/stl_uninitialized.h:138:72: note: ‘std::integral_constant<bool, false>::value’ evaluates to false
/usr/include/c++/11/bits/stl_uninitialized.h: In instantiation of ‘_ForwardIterator std::uninitialized_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = std::move_iterator<SymEngine::LLVMFloatVisitor*>; _ForwardIterator = SymEngine::LLVMFloatVisitor*]’:
/usr/include/c++/11/bits/stl_uninitialized.h:333:37:   required from ‘_ForwardIterator std::__uninitialized_copy_a(_InputIterator, _InputIterator, _ForwardIterator, std::allocator<_Tp>&) [with _InputIterator = std::move_iterator<SymEngine::LLVMFloatVisitor*>; _ForwardIterator = SymEngine::LLVMFloatVisitor*; _Tp = SymEngine::LLVMFloatVisitor]’
/usr/include/c++/11/bits/stl_uninitialized.h:355:2:   required from ‘_ForwardIterator std::__uninitialized_move_if_noexcept_a(_InputIterator, _InputIterator, _ForwardIterator, _Allocator&) [with _InputIterator = SymEngine::LLVMFloatVisitor*; _ForwardIterator = SymEngine::LLVMFloatVisitor*; _Allocator = std::allocator<SymEngine::LLVMFloatVisitor>]’
/usr/include/c++/11/bits/vector.tcc:659:48:   required from ‘void std::vector<_Tp, _Alloc>::_M_default_append(std::vector<_Tp, _Alloc>::size_type) [with _Tp = SymEngine::LLVMFloatVisitor; _Alloc = std::allocator<SymEngine::LLVMFloatVisitor>; std::vector<_Tp, _Alloc>::size_type = long unsigned int]’
/usr/include/c++/11/bits/stl_vector.h:940:4:   required from ‘void std::vector<_Tp, _Alloc>::resize(std::vector<_Tp, _Alloc>::size_type) [with _Tp = SymEngine::LLVMFloatVisitor; _Alloc = std::allocator<SymEngine::LLVMFloatVisitor>; std::vector<_Tp, _Alloc>::size_type = long unsigned int]’
/home/runner/work/symengine.py/symengine.py/dist-extract/symengine-0.11.0/symengine/lib/symengine_wrapper.cpp:187586:39:   required from here
/usr/include/c++/11/bits/stl_uninitialized.h:138:72: error: static assertion failed: result type must be constructible from value type of input range
/usr/include/c++/11/bits/stl_uninitialized.h:138:72: note: ‘std::integral_constant<bool, false>::value’ evaluates to false
/usr/include/c++/11/bits/stl_uninitialized.h: In instantiation of ‘_ForwardIterator std::uninitialized_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = std::move_iterator<SymEngine::LLVMLongDoubleVisitor*>; _ForwardIterator = SymEngine::LLVMLongDoubleVisitor*]’:
/usr/include/c++/11/bits/stl_uninitialized.h:333:37:   required from ‘_ForwardIterator std::__uninitialized_copy_a(_InputIterator, _InputIterator, _ForwardIterator, std::allocator<_Tp>&) [with _InputIterator = std::move_iterator<SymEngine::LLVMLongDoubleVisitor*>; _ForwardIterator = SymEngine::LLVMLongDoubleVisitor*; _Tp = SymEngine::LLVMLongDoubleVisitor]’
/usr/include/c++/11/bits/stl_uninitialized.h:355:2:   required from ‘_ForwardIterator std::__uninitialized_move_if_noexcept_a(_InputIterator, _InputIterator, _ForwardIterator, _Allocator&) [with _InputIterator = SymEngine::LLVMLongDoubleVisitor*; _ForwardIterator = SymEngine::LLVMLongDoubleVisitor*; _Allocator = std::allocator<SymEngine::LLVMLongDoubleVisitor>]’
/usr/include/c++/11/bits/vector.tcc:659:48:   required from ‘void std::vector<_Tp, _Alloc>::_M_default_append(std::vector<_Tp, _Alloc>::size_type) [with _Tp = SymEngine::LLVMLongDoubleVisitor; _Alloc = std::allocator<SymEngine::LLVMLongDoubleVisitor>; std::vector<_Tp, _Alloc>::size_type = long unsigned int]’
/usr/include/c++/11/bits/stl_vector.h:940:4:   required from ‘void std::vector<_Tp, _Alloc>::resize(std::vector<_Tp, _Alloc>::size_type) [with _Tp = SymEngine::LLVMLongDoubleVisitor; _Alloc = std::allocator<SymEngine::LLVMLongDoubleVisitor>; std::vector<_Tp, _Alloc>::size_type = long unsigned int]’
/home/runner/work/symengine.py/symengine.py/dist-extract/symengine-0.11.0/symengine/lib/symengine_wrapper.cpp:188783:39:   required from here
/usr/include/c++/11/bits/stl_uninitialized.h:138:72: error: static assertion failed: result type must be constructible from value type of input range
/usr/include/c++/11/bits/stl_uninitialized.h:138:72: note: ‘std::integral_constant<bool, false>::value’ evaluates to false
gmake[2]: *** [symengine/lib/CMakeFiles/symengine_wrapper.dir/build.make:94: symengine/lib/CMakeFiles/symengine_wrapper.dir/symengine_wrapper.cpp.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[1]: *** [CMakeFiles/Makefile2:194: symengine/lib/CMakeFiles/symengine_wrapper.dir/all] Error 2
gmake: *** [Makefile:136: all] Error 2
error: error building project

I'm trying to narrow down what might have changed, I'm leaning towards cython generating a bad symengine_wrapper.cpp (the above attached full log shows that it uses cython-3.0.10):
log.txt
I'll report back when I've tried different versions of cython.

I'm leaning towards that we need to adapt symengine_wrapper.pyx to work with this fix in the c++ lib:
https://github.com/symengine/symengine/pull/1995


Add upgrade entries for quicksilver-rc2 and quicksilver

Description
Add upgrade entries for quicksilver-rc2 and quicksilver.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

I ran the quicksilver upgrade locally from a v1.14.1 node without problems.
I also ran the quicksilver-rc2 upgrade locally from a v1.15.0-rc2 node without problems.
I'm trying to get a mainnet node running locally in order to force-test a quicksilver upgrade on it, but am running into persistent peers issues.

I'm trying to get a mainnet node running locally in order to force-test a quicksilver upgrade on it, but am running into persistent peers issues.

Finally got it running. I had to provenanced config set p2p.persistent_peers '' since the value I had there wasn't working anymore. Once I did that, my mainnet node started up just fine.
Using the injectUpgrade function, I was then able to test the quicksilver upgrade against mainnet. It worked as expected and happened so fast I originally thought it didn't trigger. I used the HighStakes quicksync download for this.


⚠ Bofrost.at has degraded performance

In bd4440b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2498 ms

Resolved: Bofrost.at performance has improved in 52a1652.


Made homepageURL required

While testing, I noticed the homepageURL field from the software form was missing required

homepageURL is not mandatory for Code only for Software


Error running plugin on android

E/flutter (): [ERROR:flutter/lib/ui/ui_dart_state.cc(198)] Unhandled Exception: MissingPluginException(No implementation found for method play_note on channel midi_player)
E/flutter (): #0      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:165:7)
E/flutter ():
I got this error on android.

@nathanblanchard12 Are you sure you restarted the app after adding the plugin? I cannot reproduce the bug, but it looks like you need to restart the app (not hot reload).
If you did restart and the bug still exists please provide

output flutter doctor -v
minimum code for reproduction if needed

This is the error messages I am getting:
D/EGL_emulation( 7639): app_time_stats: avg=1286.08ms min=15.87ms max=4269.66ms count=4
D/EGL_emulation( 7639): app_time_stats: avg=9663.89ms min=9663.89ms max=9663.89ms count=1
I/flutter ( 7639): dev message
I/flutter ( 7639): MissingPluginException(No implementation found for method getAll on channel plugins.flutter.io/shared_preferences_android)
I/flutter ( 7639): platform android
I/flutter ( 7639): 5
D/EGL_emulation( 7639): app_time_stats: avg=288.38ms min=8.21ms max=860.37ms count=5
D/EGL_emulation( 7639): app_time_stats: avg=2852.70ms min=24.34ms max=8507.15ms count=3
I/flutter ( 7639): dev message
I/flutter ( 7639): MissingPluginException(No implementation found for method getTemporaryDirectory on channel plugins.flutter.io/path_provider_android)
D/EGL_emulation( 7639): app_time_stats: avg=810.57ms min=22.53ms max=1908.62ms count=3
I/flutter ( 7639): difference 0.3127   newPrice 125.08  noteToPlay 6 percentage 0.0 range : 0.0025 , percentage 0.0
I/flutter ( 7639): FormatException: Invalid double
I/flutter ( 7639): dev message
I/flutter ( 7639): MissingPluginException(No implementation found for method getTemporaryDirectory on channel plugins.flutter.io/path_provider_android)
I/flutter ( 7639): difference 0.3127   newPrice 124.28  noteToPlay 6 percentage 0.0 range : 0.0025 , percentage 0.0
I/flutter ( 7639): FormatException: Invalid double
I/flutter ( 7639): dev message
I/flutter ( 7639): MissingPluginException(No implementation found for method getTemporaryDirectory on channel plugins.flutter.io/path_provider_android)
I/flutter ( 7639): difference 0.3127   newPrice 124.68  noteToPlay 6 percentage 0.0 range : 0.0025 , percentage 0.0
I/flutter ( 7639): FormatException: Invalid double
I/flutter ( 7639): dev message
I/flutter ( 7639): MissingPluginException(No implementation found for method getTemporaryDirectory on channel plugins.flutter.io/path_provider_android)
D/EGL_emulation( 7639): app_time_stats: avg=4094.53ms min=4094.53ms max=4094.53ms count=1

Looks like you have a lot of problems with plugins. Check your flutter version and flutter pub get output. It's not [midi_player](https://github.com/tplkn/midi_player) problem.


Ensure navigation buttons are visible when BottomSheetDialog is displayed

Description:
When the fire button is clicked on the light theme, the navigation buttons, as well as the icons in the action bar, are hard, if not impossible, to see on Android 8+.  This PR brings the UI focus loss in line with what one may expect from a normal Dialog etc.  Attempts to fix #754
Steps to test this PR:

Ensure that the navigation buttons and actionbar icons are clearly visible on light and dark theme with intended contrast.

Below are two screenshots from a Pixel 3XL API 29: the first is a picture of what the navbar and actionbar will look like after this PR, and the second is of an alternative UI candidate that does not dim the navbar since I thought it looked decent and could be another acceptable way of handling this since BottomSheetDialogs are not floating dialogs hence the navbar doesn't necessarily need to be dimmed here in my opinion.  I would be happy to submit a PR implementing the second approach if desired.

Internal references:
Software Engineering Expectations
Technical Design Template

Thank you for the review, and for brainstorming with me, @cmonfortep!

I would prefer to rely on themes / styles if possible.

This was my initial thought as well.  I will elaborate on why I made changes in FireDialog.kt below.

About making the navBar white...

The second approach would not always have a white navbar; the navbar would stay the color that it normally is for that particular theme.

I think modifying our BottomSheetDialog style and adding the following should work:

I did try this, but this seems to make the navbar black.  I'm not sure if my logic is correct here, but I will try to outline the logic behind my decision to modify FireDialog.kt:

I was thinking that Theme.Design.BottomSheetDialog, which BottomSheetDialog inherits from in styles.xml, possibly applies its own static theming here, similar to how a custom keyboard might.  When I add those two lines you mentioned, the navbar becomes black.  I also thought that it was possible that there could be a certain attribute in themes.xml that BottomSheetDialog pulls from that we were not expecting it to use, so I changed every color to cornflowerBlue, but the navbar still turned black when the fire button was clicked, again, much like a keyboard may ignore themes and apply its own.
I tried changing what BottomSheetDialog inherits from to many different parents for testing, which include ThemeOverlay.*.BottomSheetDialog, Theme.*.Dialog etc.  These didn't change much as far as the proper focus loss of the navbar, but eliminated the black navbar that Theme.Design.BottomSheetDialog had when putting those two lines in styles.xml.
As another test, I changed FireDialog.kt to inherit from Dialog instead of BottomSheetDialog.  After I did this, the focus loss looked correct.  Since making BottomSheetDialog inherit from Dialog in styles.xml didn't change the focus loss, but making FireDialog.kt inherit from Dialog did, I figured maybe the best place for these changes would be in FireDialog.kt.
Again, I am not sure if this logic is sound, but this is my thought process here.  It honestly sounds to me like something that Google may need to fix in their libraries (I also tested this issue against the "Update app dependencies" PR that Craig recently submitted to test if anything changed, but the bug still persists).  I believe the only way to fix this may be to manually override some colors in styles.xml (or maybe adding missing attributes in themes.xml?), but I think that may be much messier than modifying FireDialog.kt and letting Android take care of it for us.  We can also keep the navbar in its normal, undimmed, state and preserve the color by changing the parent of BottomSheetDialog in styles.xml to one that does not apply its own theming if that is preferable.

Even in that article you linked, written pre Android 10, it seems as though the navigation buttons and actionbar icons did not dynamically change color when focus was lost, and the contrast looks similar, if not identical, to how the DDG app currently looks on Android 9 and below.  Happy to take a closer look at this issue if you think there is something I could be missing here, and that a more optimal solution exists.
Sorry for the long reply!

Thanks @JeffAment, it could be true that changing focus triggers a different theme to be applied, I didn't think about that. Still, I think it worths to explore setting this through themes, just for consistency with how we are used to work with other view components, it will be the first place any dev will try to look at when trying to understand this.
We did some work trying to change the nav bar color and decided to give support only to api27 and above, you can see it inside the description of this PR https://github.com/duckduckgo/Android/pull/726
About theme proposed solution, I want to remark that android:statusBarColor doesn't set the nav bar color but the one from the top, I don't know if you were trying to set the color to cornFlowerBlue using that attribute.
if navbar is black with that solution, I think is okish. Maybe we can investigate a bit more using android:navigationBarColor for API>27 like we did in the PR I was talking about, and see if it works.

@JeffAment We got a fix for this issue and we can close this PR. I wanted to thank you for the work you did here (and in many other contributions). Looking forward to future contributions from you, they are always very welcome here. 🖖

@cmonfortep,
Happy to hear that a fix has been merged :tada:.  I am sorry I couldn't have been more prompt here; life circumstances and a hectic work schedule sort of got in the way.
All the best and stay well :rocket: :v:


Reduce creation of new C variables via some use analysis

I have idiomatic code like this, where 'p' is being used as the offset to append to inside a buffer of bytes.
  let p = append8 packet 0ul 0x63uy in
  let p = append64 packet p csm.connectionID in
  let p =  append32 packet p (Cast.uint64_to_uint32 csm.packetNumber) in
The C extraction declares p, p1, and p2, matching precisely the F* variable scoping.
I would like to see Kremlin recognize that the first p is used exclusively before the second p is defined, and has the same type.  In that case, the declaration of p1 can be omitted, by assigning back into the original variable p.
  uint32_t p = Utils_append8(packet, (uint32_t)0U, (uint8_t)0x63U);
  uint32_t p1 = Utils_append64(packet, p, csm.connectionID);
  uint32_t p2 = Utils_append32(packet, p1, (uint32_t)csm.packetNumber);
would become
  uint32_t p = Utils_append8(packet, (uint32_t)0U, (uint8_t)0x63U);
  p = Utils_append64(packet, p, csm.connectionID);
  p = Utils_append32(packet, p, (uint32_t)csm.packetNumber);

I forgot to comment on this one but it's not trivial to do, because by the time KreMLin receives the program, the names have already been numbered by F*, so I'd have to change F* to either have a proper notion of scope, or transmit DeBruijn directly to KreMLin.


Document the #![windows_subsystem] attribute

(part of https://github.com/rust-lang/rust/issues/37499)

Looks great, thank you!


[camera] Restore compatibility with older Flutter

https://github.com/flutter/plugins/pull/4808 accidentally broke
compatibility with pre-2.10 version of Flutter (without a corresponding
min version change). This restores compatibility, since doing so is
trivial.
Fixes https://github.com/flutter/flutter/issues/98660
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

test-exempt: code refactor with no semantic change


Refactor: remove keyExtractor option

Refactor: remove keyExtractor option

Pull Request Test Coverage Report for Build 892470427

0 of 9 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.1%) to 2.103%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/useVirtual.ts
0
9
0.0%

Totals

Change from base Build 892432411:
2.1%

Covered Lines:
7

Relevant Lines:
259

💛  - Coveralls


How to customize the Chinese dataset in raw_dataset, can you provide a code example?

@nieallen Please provide more description of what you mean by "customize the Chinese dataset", otherwise it's hard for us to understand what help you need. If you mean to add and use your own Chinese dataset, we have documentation at https://github.com/microsoft/DeepSpeedExamples/tree/master/applications/DeepSpeed-Chat#-adding-and-using-your-own-datasets-in-deepspeed-chat

Closing due to lack of activities, feel free to reopen if my answer above did not resolve your issue.


Generic PF-Button function

Could you add a generic function like send_PF(self, nr) so that all the PF-Keys (1 to 24) are available?
That would be awesome.

pull request #5 created


[Improvement]Need a way to avoid reorder some of the xaml part

I want a panel(x:Name=p) to cover the page when Grid(x:Name=root) is the root control of the page, so I must to put it to the bottom of the root. But in this case, if I save the page the XamlStyler will help me to reorder the Grid.Row/Grid.Column and I don't think disable the reorder is a good solution. Could I create some attribute to disable the p for reorder?

that's an option that reorders grid and canvas children according to their relative positions. it's on by default but can be disabled


What is postmessage, and what do I need it for?

When using either the parent or child version of seamless.js I get the following message in the console: You must install the postmessage.js module to use seamless.js. I did not find a mention of postmessage in the install instructions.
I tried using seamless.child.nopm.js because I assumed that "nopm" would mean "no postmessage", but the result is the same.
I am using Seamless 1.2.0.

There is a weird bug where seamless initialises postmessage under the 'pm' property of the window object. But in some cases where seamless is called directly by another script, the window object is not passed in. In kind of expects seamless to be called by the html document so that the script runs under the window context i.e. this = window
if you are using webpack try
const seamless = require('!raw-loader!seamless/build/seamless.parent.min.js'
eval.call(null, seamless.default);

or via a promise
import('!raw-loader!../../../node_modules/seamless/build/seamless.parent.min.js').then(rawModule => {
eval.call(null, rawModule.default);


📂Other: Implement Environment Variables for API URLs to Replace Hardcoded References

What would you like to share?
The issue involves the presence of hardcoded API URL's (host) within the client side code, replace them with the help of environment variables.
🥦 Browser
Google Chrome
Checklist ✅

[X] I checked and didn't find similar issue
[X] I have read the Contributing Guidelines
[ ] I am participating in JWOC
[ ] I am participating in IWOC
[X] I am willing to work on this issue (blank for no)

@jayant-vashisth I guess its unnecessary as we see the credentials are not exposed publically


about/me/history does not match other pages that require login to view

about/me/history (not logged in):

~whit537/history (not logged in)

The latter is a 401 code, the former is not.

Thanks for ticketing, I noticed this the other day, too.


fix: Configuration loader is throwing error

Describe the bug
The version 0.2.5 can read multiple configuration files. But if
Expected behavior
The configuration files can have either data_sources or metrics. Both are not optional. data_sources can be present in any of the file in a directory.
To Reproduce
Add multiple configuration files and add only metrics in one file without data_sources key.
Screenshots

Logs and additional context
{"@timestamp": "2024-01-15T10:09:32.785Z", "level": "ERROR", "projectName": "ecommerce-search-dqm", "message": "failed to run datachecks: 'data_sources'", "thread": "MainThread", "logger_name": "__main__", "pro │
│ Traceback (most recent call last):                                                                                │
│   File "/src/jobs.py", line 23, in wrapper                                                                                │
│     return job_func(*args, **kwargs)                                                                                │
│   File "/src/jobs.py", line 36, in job                                                                                │
│     run_datachecks_with_config(tenant=tenant_name)                                                                                │
│   File "/src/app/run.py", line 26, in run_datachecks_with_config                                                                                │
│     inspector = Inspect(configuration=load_configuration(config_path))                                                                                │
│   File "/usr/local/lib/python3.10/site-packages/datachecks/core/configuration/configuration_parser.py", line 370, in load_configuration                                                                            │
│     final_config_dict["data_sources"].extend(config_dict["data_sources"])                                                                                │
│ KeyError: 'data_sources'

fixed with #181


Immer fails to build with parcel

🐛 Bug Report
This issue is just a FYI, for others running into this, the actual issue can be tracked here: https://github.com/parcel-bundler/parcel/issues/2820
When using immer with parcel, the following error occurs:
🚨  /home/michel/Dropbox/presentaties/parcel-bug/node_modules/immer/dist/immer.module.js:1065:113: Export 'original' is not defined (1065:113)
  1063 |
  1064 | export default produce;
> 1065 | export { produce, setAutoFreeze, setUseProxies, applyPatches$1 as applyPatches, createDraft, finishDraft, Immer, original, isDraft, isDraftable, NOTHING as nothing, DRAFTABLE as immerable };
       |                                                                                ^
  1066 |
  1067 |

To Reproduce
Run yarn build on the repo linked below
Expected behavior
Link to repro (highly encouraged)
https://github.com/mweststrate/parcel-bug

Closing, fixed by latest parcel version


Not working at all

Hi,
so far I've tried all possibilities to install magisk with the steps given here.
However, none of them work. It doesnt matter if I run patch.sh normally, with canary or with anything else.
It does seem to patch the ramdisk.img correctly since the patched one is 1.8MB instead of 1.5MB (original ramdisk.img).
I then replace the original ramdisk.img with the patched one (and yes, I replaced the correct one), but yet magisk manager shows that its not installed.
Im running the Pixel 3a XL one with android 11.
Any suggestions?

same

same . I use magisk 21.4 and then I found it work!

So it works with 21.4, but not with the latest?

same . I use magisk 21.4 and then I found it work!

So it works with 21.4, but not with the latest?

https://github.com/topjohnwu/Magisk/releases/download/v21.4/Magisk-v21.4.zip
Use this one,I think it will work!

https://github.com/topjohnwu/Magisk/releases/download/v21.4/Magisk-v21.4.zip
Use this one,I think it will work!
For me, it doesn't work either :/

$ patch.sh
ramdisk.img: 1 file pushed, 0 skipped. 612.3 MB/s (1821425 bytes in 0.003s)
magisk.zip: 1 file pushed, 0 skipped. 452.1 MB/s (6173806 bytes in 0.013s)
busybox: 1 file pushed, 0 skipped. 165.7 MB/s (2074240 bytes in 0.012s)
process.sh: 1 file pushed, 0 skipped. 134.4 MB/s (11525 bytes in 0.000s)
[*] Checking Android version
[*] Unzipping Magisk ..
[-] API level greater then 30
[*] Check if we need to repack ramdisk before patching ..
[*] Checking ramdisk status ..
[-] Magisk patched boot image detected
[*] Patching ramdisk ..

Loading cpio: [/data/local/tmp/ramdisk.img]
Add entry [init] (0750)
Patch with flag KEEPVERITY=[false] KEEPFORCEENCRYPT=[true]
Found fstab file [first_stage_ramdisk/fstab.ranchu]
Remove pattern [,avb=vbmeta]
Found fstab file [fstab.ranchu]
Remove pattern [,avb=vbmeta]
Loading cpio: [/data/local/tmp/ramdisk.img.orig]
Backup mismatch entry: [first_stage_ramdisk/fstab.ranchu] -> [.backup/first_stage_ramdisk/fstab.ranchu]
Backup mismatch entry: [fstab.ranchu] -> [.backup/fstab.ranchu]
Backup mismatch entry: [init] -> [.backup/init]
Create directory [.backup] (0000)
Add entry [.backup/.magisk] (0000)
Dump cpio: [/data/local/tmp/ramdisk.img]
[*] Done patching, compressing ramdisk ..
[*] Installing MagiskManager ..
su: invalid uid/gid '-c'
[*] Installing su binaries ..
mkdir: '/data/user_de/0/com.topjohnwu.magisk/install/': File exists
total 3452
-rwxr-xr-x 1 root root    3507 2021-08-15 11:29 addon.d.sh
-rwxr-xr-x 1 root root    4703 2021-08-15 11:29 boot_patch.sh
-rwxr-xr-x 1 root root 2074240 2021-08-15 11:29 busybox
drwxr-xr-x 2 root root    4096 2021-08-15 11:20 chromeos
-rwxr-xr-x 1 root root<PHONE_NUMBER>-08-15 11:29 magisk
-rwxr-xr-x 1 root root<PHONE_NUMBER>-08-15 11:29 magiskboot
-rwxr-xr-x 1 root root<PHONE_NUMBER>-08-15 11:29 magiskinit
-rwxr-xr-x 1 root root   22136 2021-08-15 11:29 util_functions.sh
[*] Clean up
/data/local/tmp/ramdisk.img: 1 file pulle...ped. 153.4 MB/s (1821425 bytes in 0.011s

I see this error line:

su: invalid uid/gid '-c'
And yeah I get that -c flag is used to execute a particular command as a sudo user, but then... process.sh prepares busybox, so there shouldn't be any differences when executing su -c

I tried it again and it works ：）
not error line with su: invalid uid/gid '-c'
no idea where you went wrong :(

Okay.. Re-tried, and now it worked! :+1:  ;-;. I think that's because the second attempt of patching ramdisk was on already patched ramdisk.iso (with newer version)
Thank you @Discover999 :)

When I run the patch.bat command, I get an error
"adb" is not an internal or external
command, executable program, or batch file.
What should I do?
When I run the patch.sh command, it says
Adb not found
The .bat is referring to Adb, but what do I do with it to activate it?

When I run the patch.bat command, I get an error
"adb" is not an internal or external
command, executable program, or batch file.
What should I do?
When I run the patch.sh command, it says
Adb not found
The .bat is referring to Adb, but what do I do with it to activate it?

I assume you don't have $PATH Environment Variable set, to point to your adb executable @Niktakolesn
What is $PATH Environment Variable? - It's a system variable that keeps track of the binaries, executables, commands location.
When you execute adb, your system searches for an executable file, and it looks at the $PATH Variable, because directories listed there are meant to have commands that you can execute anywhere in the File System
See this blog-post -> https://www.addictivetips.com/windows-tips/system-wide-access-to-fastboot-and-adb-tools/
There's a chapter on setting Environment Variable with Android Platform Tools directory.
If the adb is not there, and you need to find adb location by yourself and add this directory to $PATH

@89z I tried on Android 10 - it didn't work, then I tried with fresh Android 11 AVD - and it worked after some retries.
It's an emulator, I signed in to google account and they're sending me some spam :)


[BUG] sar_movielens.ipynb - top_k = model.recommend_k_items(test, top_k=TOP_K, remove_seen=True) error

Description

I got error when running sar_movielens.ipynb notebooks from azure machine learning compute instance

2023-10-09 20:08:29,498 INFO     Calculating recommendation scores
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In[8], line 2
      1 with Timer() as test_time:
----> 2     top_k = model.recommend_k_items(test, top_k=TOP_K, remove_seen=True)
      4 print("Took {} seconds for prediction.".format(test_time.interval))

File /anaconda/envs/msftrecsys2/lib/python3.9/site-packages/recommenders/models/sar/sar_singlenode.py:533, in SARSingleNode.recommend_k_items(self, test, top_k, sort_top_k, remove_seen)
    520 def recommend_k_items(self, test, top_k=10, sort_top_k=True, remove_seen=False):
    521     """Recommend top K items for all users which are in the test set
    522
    523     Args:
   (...)
    530         pandas.DataFrame: top k recommendation items for each user
    531     """
--> 533     test_scores = self.score(test, remove_seen=remove_seen)
    535     top_items, top_scores = get_top_k_scored_items(
    536         scores=test_scores, top_k=top_k, sort_top_k=sort_top_k
    537     )
    539     df = pd.DataFrame(
    540         {
    541             self.col_user: np.repeat(
   (...)
    546         }
    547     )

File /anaconda/envs/msftrecsys2/lib/python3.9/site-packages/recommenders/models/sar/sar_singlenode.py:346, in SARSingleNode.score(self, test, remove_seen)
    344 # calculate raw scores with a matrix multiplication
    345 logger.info("Calculating recommendation scores")
--> 346 test_scores = self.user_affinity[user_ids, :].dot(self.item_similarity)
    348 # ensure we're working with a dense ndarray
    349 if isinstance(test_scores, sparse.spmatrix):

File /anaconda/envs/msftrecsys2/lib/python3.9/site-packages/scipy/sparse/_base.py:411, in _spbase.dot(self, other)
    409     return self * other
    410 else:
--> 411     return self @ other

File /anaconda/envs/msftrecsys2/lib/python3.9/site-packages/scipy/sparse/_base.py:622, in _spbase.__matmul__(self, other)
    620 def __matmul__(self, other):
    621     if isscalarlike(other):
--> 622         raise ValueError("Scalar operands are not allowed, "
    623                          "use '*' instead")
    624     return self._mul_dispatch(other)

ValueError: Scalar operands are not allowed, use '*' instead

In which platform does it happen?

It happen on Azure ML compute instance
How do we replicate the issue?

This is setup script I use in AzureML :
# 1. Install gcc if it is not installed already. On Ubuntu, this could done by using the command
# sudo apt install gcc

# 2. Create and activate a new conda environment
conda create -n msftrecsys2 python=3.9.16
conda activate msftrecsys2

# 3. Install the core recommenders package. It can run all the CPU notebooks.
pip install recommenders
pip install recommenders[gpu]
# 4. create a Jupyter kernel
python -m ipykernel install --user --name msftrecsys2 --display-name msftrecsys2

# 5. Clone this repo within VSCode or using command line:
git clone https://github.com/recommenders-team/recommenders.git

this is my compute instance setting:

Expected behavior (i.e. solution)

Cell below should run without throwing error
with Timer() as test_time:
    top_k = model.recommend_k_items(test, top_k=TOP_K, remove_seen=True)

print("Took {} seconds for prediction.".format(test_time.interval))

Other Comments

I think that return np.array(result) lines at the end of similarity functions in recommenders/utils/python_utils.py should be changed to return result.toarray().
So the new version of jaccard should read as
def jaccard(cooccurrence):
    """<docstring>"""

    diag_rows, diag_cols = _get_row_and_column_matrix(cooccurrence.diagonal())

    with np.errstate(invalid="ignore", divide="ignore"):
        result = cooccurrence / (diag_rows + diag_cols - cooccurrence)

    # return np.array(result) # not this
    return result.toarray()

See https://github.com/scipy/scipy/issues/18796

Resolved in PR #2083


Busy indicator finding folders

Something like | -> / -> - -> \ -> | -> / -> - -> \ -> |

Closed in #16


statik --watch: OSError: [Errno 99] Cannot assign requested address

On  a Debian 9.1 host, when I try to run the examples/blog project or a custom statik project via statik --watch, I got the following error:
(venv) breitner@breitner-vm-debian-x:~/projects/statik/examples/blog$ statik --watch
Project path configured as: /home/breitner/projects/statik/examples/blog
Using encoding: utf-8
Writing output file: /home/breitner/projects/statik/examples/blog/public/rand-example/index.html
Writing output file: /home/breitner/projects/statik/examples/blog/public/2016/06/01/first-post/index.html
Writing output file: /home/breitner/projects/statik/examples/blog/public/2016/06/04/second-post/index.html
Writing output file: /home/breitner/projects/statik/examples/blog/public/2016/06/30/html-content-test/index.html
Writing output file: /home/breitner/projects/statik/examples/blog/public/index.html
Writing output file: /home/breitner/projects/statik/examples/blog/public/slugify-example/index.html
Wrote 6 output file(s) to folder: /home/breitner/projects/statik/examples/blog/public
Copying assets from /home/breitner/projects/statik/examples/blog/assets to /home/breitner/projects/statik/examples/blog/public/assets...
Copied 1 asset(s)
--- Logging error ---
Traceback (most recent call last):
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/statik/cmdline.py", line 102, in main
    safe_mode=args.safe_mode)
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/statik/watcher.py", line 75, in watch
    open_browser=open_browser
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/httpwatcher/cmdline.py", line 49, in watch
    server.listen()
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/httpwatcher/server.py", line 98, in listen
    super(HttpWatcherServer, self).listen(self.port, address=self.host, **kwargs)
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/tornado/web.py", line 1943, in listen
    server.listen(port, address)
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/tornado/tcpserver.py", line 142, in listen
    sockets = bind_sockets(port, address=address)
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/tornado/netutil.py", line 197, in bind_sockets
    sock.bind(sockaddr)
OSError: [Errno 99] Cannot assign requested address

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.5/logging/__init__.py", line 981, in emit
    msg = self.format(record)
  File "/usr/lib/python3.5/logging/__init__.py", line 831, in format
    return fmt.format(record)
  File "/usr/lib/python3.5/logging/__init__.py", line 568, in format
    record.message = record.getMessage()
  File "/usr/lib/python3.5/logging/__init__.py", line 331, in getMessage
    msg = msg % self.args
TypeError: not all arguments converted during string formatting
Call stack:
  File "/home/breitner/projects/statik/examples/blog/venv/bin/statik", line 11, in <module>
    sys.exit(main())
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/statik/cmdline.py", line 113, in main
    logger.exception("Exception caught while attempting to generate project", e)
Message: 'Exception caught while attempting to generate project'
Arguments: (OSError(99, 'Cannot assign requested address'),)
(venv) breitner@breitner-vm-debian-x:~/projects/statik/examples/blog$

I followed your setup/installation procedure from your documentation, using python 3.5.3 and a virtual environment. Generating the site via statik finished without any error (see above).
The same projects run just fine on another Debian Stretch host. Unfortunately, I have no idea how I can fix this error...

What else have you got running on that Debian 9.1 host? By default Statik binds to localhost port 8000. Check if anything else is bound to localhost (or <IP_ADDRESS>) port 8000:
> lsof -Pni4 | grep LISTEN

Looks to me like you've got an IP address/port conflict. Also, try binding Statik to a different host/port:
> statik --watch --host <IP_ADDRESS> --port 8001

That' weird - nothing is listening on <IP_ADDRESS> on port 8000. And I could bind Statik to all kind of IP/port combination - but not on localhost:
OK:
> statik --watch --host <IP_ADDRESS> --port 8000
...
/statik/examples/blog/public/assets...
Copied 1 asset(s)
Started HTTP watcher server at http://<IP_ADDRESS>:8000/

Not OK:
> statik --watch --host localhost --port 8000
...
/statik/examples/blog/public/assets...
Copied 1 asset(s)
--- Logging error ---
Traceback (most recent call last):
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/statik/cmdline.py", line 102, in main
    safe_mode=args.safe_mode)
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/statik/watcher.py", line 75, in watch
    open_browser=open_browser
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/httpwatcher/cmdline.py", line 49, in watch
    server.listen()
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/httpwatcher/server.py", line 98, in listen
    super(HttpWatcherServer, self).listen(self.port, address=self.host, **kwargs)
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/tornado/web.py", line 1943, in listen
    server.listen(port, address)
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/tornado/tcpserver.py", line 142, in listen
    sockets = bind_sockets(port, address=address)
  File "/home/breitner/projects/statik/examples/blog/venv/lib/python3.5/site-packages/tornado/netutil.py", line 197, in bind_sockets
    sock.bind(sockaddr)
OSError: [Errno 99] Cannot assign requested address
...

So it seems my localhost name resolution is confused and that has nothing to do with Statik.  Thanks a lot for your hints.

Cool, closing for now then 😀 👍

Strange, django runserver runs happily on localhost on port 8000:
(_venv) $ python manage.py runserver localhost:8000
Performing system checks...

System check identified no issues (0 silenced).
August 07, 2017 - 13:41:04
Django version 1.10.7, using settings 'project.settings'
Starting development server at http://localhost:8000/
Quit the server with CONTROL-C.

Perhaps it's not an issue with my name resolution but in httpwatcher?


Template  has Additional DIV wrapped, why?

Each inserted  populated template is wrapped by two layers of div
for example, I have template like this:

after I inserted it into the DOM, they look like as below,
`

`
Who can tell me the reason?

Can you provide a jsfiddle showing the issue, then I can have a look at it?

I'm having the same issue...
I made a jsfiddle, however I couldn't exactly reproduce the same bug...
On my jsfiddle there is only one
 wrapping the template (even thought there is a wrapper div in my template).
I hope this helps a wee bit.

I finally managed to reproduce the bug: https://jsfiddle.net/ftxxtfqt/
To each item in the array an HTML like this is generated:

The nested
s come from the recursive invocation of loadTemplate().
My pull request #102, which is about suppressing a wrapper element altogether, implicitly also fixes this bug, but only if you turn option noDivWrapper on.

I just amended the PR to fix a bug where the enclosing element of a template wasn't itself processed with setting noDivWrapper on.

@mklement0 Thank you very much!!! I will start testing your code right now!

@mklement0 it works perfectly!!! :+1:

@mklement0 : you said "The nested
s come from the recursive invocation of loadTemplate() when array input data is passed."
I need to recursive invocate loadTemplate() but I am a bit lost, could you please give me an example of how to do it?
In my case I want to bind to customer data and loop trough notes in a json like this:
{
    "customer_data": {
        "id": "1",
        "name": "John Doe",
        "phone": "123456789",
        "notes": [
            {
                "title": "Lorem 1",
                "content": "Lorem ipsum ..."
            },
            {
                "title": "Lorem 2",
                "content": "Lorem ipsum ..."
            },
            {
                "title": "Lorem 3",
                "content": "Lorem ipsum ..."
            }
        ]
    }
}

Thank you :-)

@jor77: Assuming you use the code from my PR, and assuming your (jQuery-wrapped) target DOM element is $target, your template is in DOM element with id tmpl, your data object is in variable data, and you want to pass only the notes array to the template:
   $target.loadTemplate(
        $("#tmpl")
        , data.customer_data.notes
        , { noDivWrapper: true }
    )

Thank you! I will try it in the next hours :-)

@mklement0
I found your code bring about a new bug, when I use your option
noDivWrapper: true
Then the prepend option will be no longer has any effect
prepend: true
All elements are just appended to the containter.
When I remove
noDivWrapper: true
The prepend option comes back again.

@itimryan: Thanks for pointing that out. I'm not planning on working on this PR any further, but I've added your comment as a caveat to the PR page (#102 ).

Regarding the 2 additional divs it happens to my only in vers 1.5.7, switching back to 1.5.6 the problem is gone... Maybe you guys already know but I didn't see this specified anywhere so I just wanted to highlight that fact.

I'd assumed it came from the change in 1.5.7 based off the changes in that version and the timing but hadn't tested specifically so thanks for confirming.
Should be fairly easy to fix when I get the time

Tnx PB.
I hope you didn't mind... I just inserted a page in the wiki about templateFormatters examples, only one example at the moment, I would like to add more in the future.

That is great, thanks

Confirmed that 1.5.6 doesn't add the extra wrapping divs. Two pens:
1.5.6: http://codepen.io/anon/pen/VjWBpJ
1.5.7: http://codepen.io/anon/pen/bZRKvG

Thank you very much @codepb!
Verified: 1.5.9: http://codepen.io/anon/pen/jAwjJk


replace insecure-key support with authorized-key support

I think this fills all the use cases of the insecure-key, plus some, and is overall more secure.

@bukzor this PR is fine, but I don't know if @FooBarWidget would like to make insecure_key and authorized_keys optional, or keep one of them.
I suggest removing all changes that are not related with the authorized_keys feature, and if it's the case, open a new PR for each os these other changes.
That's my 2cents, HTH.

@bukzor Is there an existing issue that this PR is in reference to? If not, please open a new issue which explains what you are trying to accomplish with these changes. Thank you!
This PR also has merge conflicts, please kindly resolve those conflicts. :)


Add PHP 7.2 support, drop HHVM

Update Travis configuration
Check Travis results

@froschdesign It can be closed now, version 2.8.0 with PHP 7.2 support and HHVM removed has been released yday.


TS2304: Cannot find name 'JSON'

Potential bug when upgrading to Angular 7 and Typescript 3.2.0. Using IntelliJ.
TS2304: Cannot find name 'JSON'

Deleting node_modules and npm install seems to have fixed it.

Even after deleting node modules and then doing npm install, the error persists.

Same for me. Reinstall with npm doesn't work.

I just hit this too for a new project.  I have another project that works, but I am running code-server with typescript 3.4.4 building with webpack for node 8.  So there are a lot of moving parts.  I am going to try to break it down and see if there is rhyme or reason.  I see this reported on other projects, and usually, the solution for some people involves a mixture of tsconfig.json tweaks to the library target and installing specific @type/ packages.  There doesn't seem to be consistency though, so I think it is a tooling configuration problem.

I'm hitting the same issue as @geiseri
I also see Cannot find name 'document'. Do you need to change your target library? Try changing the lib compiler option to include 'dom'.ts(2584) even when my lib entry in tsconfig.json includes dom

Cannot find name 'getJSON'.ts(2304)

Cannot find name 'document'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
/* To learn more about this file see: https://angular.io/config/tsconfig. */
{
"compileOnSave": false,
"compilerOptions": {
"baseUrl": "./",
"outDir": "./dist/out-tsc",
"forceConsistentCasingInFileNames": true,
"strict": false,
"noImplicitOverride": true,
"noImplicitAny":false,
"noPropertyAccessFromIndexSignature": false,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"strictPropertyInitialization": false,
"sourceMap": true,
"declaration": false,
"downlevelIteration": true,
"experimentalDecorators": true,
"moduleResolution": "node",
"importHelpers": true,
"lib": [
"DOM",
"es2020"
],
"target": "es2020",
"module": "es2020",
},
"angularCompilerOptions": {
"enableI18nLegacyMessageIdFormat": false,
"strictInjectionParameters": true,
"strictInputAccessModifiers": true,
"strictTemplates": true
}
}


Layouts - Trying to add layout after saving preset causes crash

Was able to reproduce 2 / 2 times attempted.
http://screencast.com/t/NPSs49wX5E
http://screencast.com/t/WfkP0rc17
This may be the related PHP Error:
Allowed memory size of 134217728 bytes exhausted (tried to allocate 32 bytes) in /home/c5sandbox/public_html/concrete/vendor/doctrine/dbal/lib/Doctrine/DBAL/SQLParserUtils.php on line 95

Creating layout preset causes infinite loop while getting available presets from DB. So any page with layout cannot be rendered. Removing layout preset from DB fixes the problem, but any new preset will lead to this infinite loop.
Currently Running <IP_ADDRESS>

This issue is still valid on 8.5.2.

Found this while looking through issues – this has been fixed as of 8.5.5. (https://documentation.concretecms.org/developers/introduction/version-history/855-release-notes)


pull request for e2e test at 01/04/2017 00:26:13

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


After failing to arm alarm, send event ALARMO_RETRY_ARM result in unknown alarmo state

Alarmo Version
v1.8.3
HA Version
2021.2.5
Bug description
After failing to arm alarm, retry (event ALARMO_RETRY_ARM) results in unknown alarmo state (if there's still pending sensors).
Steps to reproduce

Leave some sensor blocking arm activation;
Execute arm alarm (will fail due to open sensor);
While keeping an open sensor, send ALARMO_RETRY_ARM;
Alarmo will report unknown state to home assistant.

Relevant log output
No response

Thanks for reporting this. I am seeing the same problem here.
I will investigate and get back to you.

Thank you for helping all of us and for this great project! Just recently, few days ago, discovered this, before I was trying to do all by myself with "thousands" of Home Assistant automations... :-)
Let me know if I can help.

This is fixed by updating to v1.8.6.


Broken links for massbank and metabolights download

While downloading massbank and metabolights there is Server Error (500)
http://curatr.mcf.embl.de/MS2/export/
For massbank the error is often random and may not appear every time.
Thanks
Prasad

Axis for the graph of Molecules on stat page should be reversed http://curatr.mcf.embl.de/stats/
X axis: number of spectra
Y axis: number of molecules


Add qr code for landing and iframe

:tada: This PR is included in version 1.34.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix: reload default page on discard

Description
After discard is successful, reload the default page.
Fixes #13736
Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=8f6a1586ddba46100c04067311bf5929842c094f

Loading default page after discard.
bug
https://user-images.githubusercontent.com/1573771/177031576-e934b48f-7988-42c6-a475-8042a7fa479f.mov
fix
https://user-images.githubusercontent.com/1573771/177031585-6700327a-9002-4d9e-9889-e4fd3625c662.mov

Failing tests. This needs update in discard tests.

Failing tests; these might be genuine failures due to code change:

/ok-to-test sha=efb036c

Only one test fails after fixing another one. Who knew that fixing failing tests works?

/ok-to-test sha=64131af

Failing build

Failing tests

/ok-to-test sha=5d89967

Failing test, cannot run it locally.

/ok-to-test sha=0a609fa

Failing tests

/ok-to-test sha=c57f9d9

/ok-to-test sha=eef9f35

Failing test.

Tests are passing.

@IAmAnubhavSaini  this looks gud


Configure ursula when we need deploy environment from package with la…

…test build

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

@ivy275  Just saw in file "roles/apt-repos/defaults/main.yml" line 46, seems username and password left in file content, is it ok ?

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

@jianzj Sorry, I already deleted the credentials from this branch and PR, and will close this PR.

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist


null_resource

Hi,
I am wondering how I can find a part that install the label studio on the cluster, like null_resource or similar?

Hi,
There is a separate module that you can use https://github.com/heartexlabs/label-studio-terraform/tree/master/terraform/common/modules/label-studio


QSVEncC Intel - Checking Limit performance - Error

Enabling - Limit performance to lower resource usage - creates an error indicating a value is required.
Error: Unknown value "--cqp" for "--max-procfps"
"--max-procfps" requires value.
Start:    14:32:30
End:      14:32:30
Duration: 00:00:00

Which encoder is it?

Many moons ago - must have been Intel H.265. Only thing I would have used QSVEncC Intel for.


added option to specify port range for client ports

Fixes #105.

I want this PR!

@defunctzombie - mind reviewing all the localtunnel server PRs? A lot of them are trivial and would bring a lot of useful functionality to the system. Thanks!


key type?

What kind of key is required for this to work properly/safely? I see that it takes a [u8;32], but what should be used to generate this?
x25519, ed25519, curve25519, or?

After digging through the libsodium gitbook I see that it's an X25519 key. Will the keypair generated from the ed25519_compact/x25519 module be safe to use with this package?

This crate has KeyPair::create() function that creates a key pair.
So, just use that :)

The README file also includes a usage example, that generates a new key pair.


Pydantic validation revised

Includes revised pydantic validation and dataset validation, as well as additional helper validation functions

@harmatt can you please have a look at the merge conflicts and see if you can sort them out?

@afrubin , I resolved the merge conflicts and added @EstelleDa  as a reviewer

I think all look good. Except one validation function, validate_external_identifier, in mavecore/validation/identifier.py need to change or we can leave this one in the future. For the rest, we can try to use them in MaveDB.

Thanks @EstelleDa ! I agree, the validation in validate_external_identifier is ugly and deviates from the methods used in the other validation. Pydantic has a way, using root_validator, to do this more elegantly, but I cannot seem to get it to work. You can see (commented out) how it should be implemented in mavecore/models/identifier.py . @afrubin , with your approval I can merge and close this pull request.


isIdentifierText in scanner.ts doesn't match Identifier parsing anymore

TypeScript Version:  3.6.0-dev.20190804

Search Terms:
Expected behavior:
isIdentifierText should match what scan does.
Actual behavior:
The implementation was not updated to allow for astral symbols and escaped characters. This might cause some inconsistencies, for example when using an astral character in compilerOptions.reactNamespace.
Related Issues:
#32096, #32701, cc @weswigham

It's already up to date (and had to be to parse the example in the PR)? isIdentifierText uses isIdentifierStart and isIdentifierPart which in turn use isUnicodeIdentifierStart and isUnicodeIdentifierPart which in turn use unicodeESNextIdentifierStart and unicodeESNextIdentifierPart which were added in that PR expressly to support the higher unicode codepoints that are now allows as identifier bits.

But it still uses charCodeAt instead of codePointAt and advances the index by 1 instead of charSize(ch)

Oh, fair. As-is, I suppose it's just relying on the later half of an extended code point maybe being a valid part on its own. Anyone know of a unicode character which is a valid identifier part but whose lower 8 bits, interpreted as a character, are not?

Found one with some guesswork - \u1061.

Found one~


Change scapedMetricsNameCache method to support /

[ ] If this is non-trivial feature, paste the links/URLs to the design doc.

[ ] Update the documentation to include this new feature.

[ ] Tests(including UT, IT, E2E) are added to verify the new feature.

[ ] If it's UI related, attach the screenshots below.

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.

[x] Update the CHANGES log.

Initially I wanted to convert / to - but mal doesn't support - either.
I also tried to write unit tests, but creating PrometheusMetricConverter object was complicated. So I have tested it locally.


font size problem

Hi again,
When I am retrieving paragraph from database, the font size is not working.
For example in the table, in one column the data is saved into two paragraphs, If I define the font size 18 for that column, the font size is default for the first paragraph, for the second paragraph the font size is correct.
docx.p user.biography, size: 18
Here the biography has two paragraphs. While retrieving in the document, the first font size is default (10) and for the second paragraph the font size in 9.
Thanks

What does user.biography contain?  Text and line feeds?  Is there any markup in the field value?

Only text.

Assuming the value is a text string with \ns to create separate paragraphs, there's nothing in the Caracal programming—to my knowledge—that would cause this to happen.  Caracal never evaluates the content passed to its commands—it simply parrots everything back out in the OOXML.  Word, of course, might have an issue with the content, but that's not really a Caracal concern per se.
Have you inspected the OOXML in the output file?  Does the markup in the document.xml file match what the document renderer produces?
If that's not illuminating, another strategy might be to use ruby to .split the biography into an array of paragraph texts and call docx.p for each item in the resulting array.  That might circumvent whatever formatting issue Word has with the text in the biography.

Hi @jdugan
Thanks for the answer.

Hi @jdugan
Just asking-
When is the next update?
Thanks


pick_ik: 1.1.0-1 in 'humble/distribution.yaml' [bloom]

Increasing version of package(s) in repository pick_ik to 1.1.0-1:

upstream repository: https://github.com/PickNikRobotics/pick_ik.git
release repository: https://github.com/ros2-gbp/pick_ik-release.git
distro file: humble/distribution.yaml
bloom version: 0.11.2
previous version for package: 1.0.1-1

pick_ik
* Support continuous (unbounded) joints properly (#59 <https://github.com/PickNikRobotics/pick_ik/pull/59>)
* Run elite gradient descent in separate threads (#61 <https://github.com/PickNikRobotics/pick_ik/pull/61>)
* Contributors: Sebastian Castro

I had some issues running bloom-release locally, hence why I manually switched the -3 to -1.


Fix external links in navigation bar

It fixes #53 while this PR is released.

Do we want pydata-sphinx-theme<0.10.1 or pydata-sphinx-theme<=0.10.1?

0.10.1 is failing with an error in the gallery.

Ok.  So then I guess 0.10 is good!


TraceLogging events are sometimes not decoded by PerfView/TraceEvent properly

More information in my one note under 'Fixing Tracelogging in TraceEvent'
The issue is that the 'Event ID' field of an event is not guaranteed to be an accurate identity for the schema of an event.   In the limit, some Tracelogging providers use 0 for the Event ID for all events, which make all schema's collide.
There are a number of solutions, but the most reasonable is likely to be to have a table that maps a TraceLogging event's meta-data to a schema ID.   (it is annoyingly inefficient, but arguably there just are not that many Tracelogging events, so it is OK).
It is straightforward work (a day or two).

Turns out I have already fixed this on 9/7/2016.   See history of TraceLoggingEventId.cs


Added new features to dialogue

.setColor .setFontSize

"j+=8 j+=7"..... refactor this getting command/value lengths instead of using magic numbers pls


Remove Google+ dependency

Based on this: https://github.com/mstade/passport-google-oauth2/issues/13#issuecomment-459733198
I updated profile to add the new field and put them in the old ones to maximise compatibility

I tested on my server, work just fine.
I did not launch your tests tho since it needs to be modified as well and I do not know how

Sounds great!
Could be ESlinted for a last check and cleanup before commit/push.
Thanks guys

Many thanks for this @Guisch – appreciate the assist! I checked and verified these changes as best I could locally, added some changes necessary to get the example working and then bumped to v0.2.0 before releasing to npm.
Hope this helps!


Cannot edit PR review: resource not accessible by integration

When attempting to edit an existing but not yet submitted PR review comment, GitHub Codespaces emits the following error:
GraphQL error: Resource not accessible by integration

This was observed both with the release version and the pre-release (v0.75.2023100909) versions.
GitHub Codespace version information:
Version: 1.83.0
Commit: e7e037083ff4455cf320e344325dacb480062c3c
Date: 2023-10-03T16:11:43.025Z
Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36

Thanks for looking into it.

Just to complement: removing commments doesn't seem to work either. Is the extension supposed to be working or is it still an early alpha?
Thanks again.

I've just tried and the same issue is still there, with the same error.

Are you making a PR from a fork of the upstream repo?

I'm creating the codespace from inside the PR itself.

Do you have the PR branch checked out, or is this a PR from the "Pull Requests" view?

This is the PR that was already checked out given (1).

Do you have push permission on the upstream repo?

Yes, full access.

Just to completement: I can actually create review comments correctly, so this shouldn't be a permission issue. Just can't edit them.

Thanks for all the details! One more question: Is this PR from a fork to an upstream repo (i.e., are the base and compare branches in the same repo, or is the compare branch from a fork)?

The branch proposed for merging is on a personal fork. The PR and code review are on the main branch on the upstream repository.

Awesome. Thank you for all the details. I can repro.

It looks like this is an issue with GitHub Codespaces and the auth token they provide. I'm getting help from them.
@TylerLeonhardt FYI

@TylerLeonhardt, I though I could work around this Codespaces issue by doing forceNewSession when I hit this error, but that doesn't seem to work. Do you know if there's anything I can to do to work around this? It makes the extension very broken.

Yeah unfortunately, forceNewSession does not work here because Codespaces owns the lower level token provider... and they're probably just sending the same bad token.

I have, I'm sad to say, learned that in a GitHub Codespace which was created from a PR from a fork, the auth token that GitHub provides is flawed. This flaw is intentional to prevent a malicious PR from having too much access. There is no way for this extension to get a real auth token at this point and somethings will just fail with "resource not accessible by integration".
I'm trying to come up with a less-bad UX for this.
@niemeyer, the easiest work around for you would be to create the Codespace from the main branch of the base repo, then check out the PR from the Pull Requests view in the Codespace. Improvements, if not fixes, are coming soon.

Still working with GitHub folks to see how this can be improved. It may be an unknown issue after all.

GitHub Codespaces folks are looking into it. 🤞we have a fix soon.

Codespaces folks are working on testing the fix.


qgis: 3.26.2 -> 3.28.2

Description of changes
This PR updates QGIS to the latest stable version. Replaces #205339.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

PR manually tested tested by:

building by export NIXPKGS_ALLOW_INSECURE=1; nix-build -A qgis

running built binary with test project from QGIS source code ./result/bin/qgis ../../../osgeo/qgis/code/tests/testdata/quickapp_project.qgs


p2os: 2.1.0-0 in 'jade/distribution.yaml' [bloom]

Increasing version of package(s) in repository p2os to 2.1.0-0:

upstream repository: https://github.com/allenh1/p2os
release repository: https://github.com/allenh1/p2os-release.git
distro file: jade/distribution.yaml
bloom version: 0.5.26
previous version for package: 2.0.5-0

p2os_doc
* Switch to format 2 (#48 <https://github.com/allenh1/p2os/issues/48>)
  * Update p2os_launch to package.xml format 2.
  * Update p2os_driver to package.xml format 2.
  * Update p2os_urdf to package.xml format 2.
  * Update p2os_teleop package.xml to format 2.
  * Update p2os_msgs to package.xml format 2.
  * Update p2os_doc to package.xml format 2.
* Contributors: Hunter Allen

p2os_driver
* Switch to format 2 (#48 <https://github.com/allenh1/p2os/issues/48>)
  * Update p2os_launch to package.xml format 2.
  * Update p2os_driver to package.xml format 2.
  * Update p2os_urdf to package.xml format 2.
  * Update p2os_teleop package.xml to format 2.
  * Update p2os_msgs to package.xml format 2.
  * Update p2os_doc to package.xml format 2.
* Contributors: Hunter Allen

p2os_launch
* Switch to format 2 (#48 <https://github.com/allenh1/p2os/issues/48>)
  * Update p2os_launch to package.xml format 2.
  * Update p2os_driver to package.xml format 2.
  * Update p2os_urdf to package.xml format 2.
  * Update p2os_teleop package.xml to format 2.
  * Update p2os_msgs to package.xml format 2.
  * Update p2os_doc to package.xml format 2.
* Contributors: Hunter Allen

p2os_msgs
* Switch to format 2 (#48 <https://github.com/allenh1/p2os/issues/48>)
  * Update p2os_launch to package.xml format 2.
  * Update p2os_driver to package.xml format 2.
  * Update p2os_urdf to package.xml format 2.
  * Update p2os_teleop package.xml to format 2.
  * Update p2os_msgs to package.xml format 2.
  * Update p2os_doc to package.xml format 2.
* Contributors: Hunter Allen

p2os_teleop
* Switch to format 2 (#48 <https://github.com/allenh1/p2os/issues/48>)
  * Update p2os_launch to package.xml format 2.
  * Update p2os_driver to package.xml format 2.
  * Update p2os_urdf to package.xml format 2.
  * Update p2os_teleop package.xml to format 2.
  * Update p2os_msgs to package.xml format 2.
  * Update p2os_doc to package.xml format 2.
* Contributors: Hunter Allen

p2os_urdf
* Small xacro fix.
* Switch to format 2 (#48 <https://github.com/allenh1/p2os/issues/48>)
  * Update p2os_launch to package.xml format 2.
  * Update p2os_driver to package.xml format 2.
  * Update p2os_urdf to package.xml format 2.
  * Update p2os_teleop package.xml to format 2.
  * Update p2os_msgs to package.xml format 2.
  * Update p2os_doc to package.xml format 2.
* Contributors: Hunter Allen, Hunter L. Allen

@allenh1 Just checking: this will likely be the last release of this repo in Jade. Is it still ok to release this as the final version ?

Yes, this was the idea. I updated all the packages to format 2, and used that as an excuse for one final Jade release.
#RipJade


Fix split cell icon disabled after converting from text to code

This PR fixes https://github.com/microsoft/azuredatastudio/issues/17405

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 41.481%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/notebook/browser/cellToolbarActions.ts
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
26817

Relevant Lines:
58646

💛  - Coveralls


Create Python plugin API

SeleniumLibrary has nice plugin API to extend the library. Use the same idea to create similar plugin API also the Browser library

Partially done in #2515 but needs some document updates.


proso_flashcards practice options broken

proso_flashcards practice returns questions with options with only single option (the asked flashcard).

You have to be more specific. What is your config? What is your dataset?


Fix fast_acvnet_plus_onnx_no_gridsample link

Fix fast_acvnet_plus_onnx_no_gridsample link
The old link was referencing the fast_acvnet_onnx_gridsample file instead of the fast_acvnet_plus_onnx_no_gridsample file.

Thanks!

Your contribution is very impressive. I invite you to become a collaborator because I want you to commit more and more without waiting for my approval.

Thank you for your kind words. I will try to be careful to not break anything!


Update emp.js script to include data sharing

USER STORY
As a website visitor, when I have an Ethyca cookie on my browser which reflects that I have opted out of data sharing, then the Ethyca script exposes that choice on the DOM for GTM, Segment, Facebook etc to consume.
DETAILS
In Pro's Control Panel today an admin can create Data Use Cases. These use cases show under Consent Management in the Privacy Center for a user to opt in or out. We will add Data Sharing as a new type when creating data use cases to comply with CPRA/VCPA in https://github.com/ethyca/fides/issues/1397 and https://github.com/ethyca/fides/issues/1398.
With https://github.com/ethyca/fides/issues/1399 we will add Data Sharing to the eth_cmp cookie.
In Pro, we have an existing script that places the consent data on the DOM for other scripts. We need to add Data Sharing to this script.
Pro Docs - Implement Consent in Browser
EPIC DOC
AC

Given that I have the Ethyca cookie on my browser from a site and the site has the Ethyca emp.js script in the <head>, when the page loads, then the Ethyca emp.js script places the contents of the cookie on the window for other scripts to consume.

Minor comment here - the emp.js script sets this object on the window regardless of the presence of the cookie. When the cookie is set, it updates the values on the ethyca object reflect the cookie values.


Caching problem with --runTestsByPath and 'import' in globalSetup

🐛 Bug Report
I see caching problem when I use --runTestsByPath flag with custom babelizer and import statements in globalSetup file
To Reproduce
Steps to reproduce the behavior:

Take the repo
npm i
Run a single test using jest --runTestsByPath src/Components/SomeComponent.test.js
Modify that test slightly: change false to true here https://github.com/pahan35/jest-custom-babelizer-cache-problem/blob/37251c10162dccfc78f8d8f1cbf02b8c6c576c8e/src/Components/SomeComponent.test.js#L9
Try to run a command, mentioned in step 3 again

Expected behavior
I expect to see a correct test run like it was before.
What happens instead?
jest fails with error

TypeError: /Users/p35/PycharmProjects/jest-custom-babelizer-cache-problem/src/Components/SomeComponent.test.js: Cannot read property 'from' of undefined
at Converter.toBase64 (node_modules/convert-source-map/index.js:61:28)
at run.next ()
at transform.next ()

Potentially it caused by not transformed imports in globalSetup
https://github.com/pahan35/jest-custom-babelizer-cache-problem/blob/37251c10162dccfc78f8d8f1cbf02b8c6c576c8e/testing/globalSetup.js#L1
Also, maybe this line https://github.com/pahan35/jest-custom-babelizer-cache-problem/blob/37251c10162dccfc78f8d8f1cbf02b8c6c576c8e/testing/babelizer.js#L23 has some effect. Without it, tests are not transformed correctly.
Link to repl or repo (highly encouraged)
https://github.com/pahan35/jest-custom-babelizer-cache-problem/
envinfo
 System:
    OS: macOS 10.15.4
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Binaries:
    Node: 13.7.0 - /usr/local/bin/node
    Yarn: 1.21.1 - /usr/local/bin/yarn
    npm: 6.13.6 - /usr/local/bin/npm
  npmPackages:
    jest: ^26.0.1 => 26.0.1

Notice
If you noticed that it stops failing, please run jest --clearCache and rerun 3-5 steps to recheck it.
P.S: originally discovered here https://youtrack.jetbrains.com/issue/WEB-45575

This is super weird. I've tracked the issue down to this line:
https://github.com/thlorenz/convert-source-map/blob/9e9a7a9b652c30878c9c9aa591d861a9fdf61a7e/index.js#L21
During the first run, SafeBuffer.Buffer is a thing, but during the second run SafeBuffer is an empty object.
Not really sure what's going on... Seeing as removing the globalSetup file works
Full stack trace doesn't really help

@SimenB thanks for investigating it!
There was a problem with getCacheKey in our babelizer.js. My teammate just helped me to figure it out. I'll post our solution in the branch babelizer-fix in the provided repo.

Actually, the solution is just in
transformIgnorePatterns: [
    '.*/signal-exit/.*',
    '.*/is-typedarray/.*' ,
    '.*/safe-buffer/.*',
  ],


Added tool bar (#223)

As part of this, I also replaced the "boilerplate" menu with temporary (hard-coded) hamburger menu on tool bar.

This change is

src/renderer/components/platform-bible-menu.tsx line 1 at r1 (raw file):
Previously, katherinejensen00 wrote…
Should we wrap Grid and Menu Item like we have been wrapping other MUI components?

Probably. I wasn't at all sure about whether this was likely to be the final approach we would take (especially the grid), so I wasn't sure if I should take the time to try to do this. I guess for the menu items, it might be beneficial to wrap them, so that even if we end up doing something totally different, the wrapper might still serve us. I see that Jolie is now working on this (#250). Since the task was really to add a toolbar, my main intent in adding the menu stuff was as a learning exercise for me and to kind of replace the boilerplate menu with something a little bit closer to what we might ultimately want.

src/renderer/components/platform-bible-toolbar.tsx line 4 at r1 (raw file):
Previously, katherinejensen00 wrote…
This is definitely a MUI component we will want to wrap. That wasn't part of this case though. Would you mind creating cases for the  MUI components you used as part of this task?

I can do that. Do you think we'll want/need both AppBar and Toolbar wrapped as separate components, or would we perhaps be better served by a single wrapper component that encapsulates the two? Similarly, should our toolbar maybe just have a boolean that says whether or not to include the menu button (or an optional object that defines the menu structure)? For now, I'm using Typography only to display some place-holder text. Will we want to use Typography in Paratext? If so, will we want to wrap it? (I'm guessing we would, but not sure.)

src/renderer/components/platform-bible-toolbar.tsx line 16 at r1 (raw file):
Previously, rolfheij-sil wrote…
What's the use of returning undefined? Also, can't these small function just be inlined in the JSX?

Nothing, I think, unless maybe it made Typescript happy. I grabbed this code from somewhere online. Inlining it is fine. The only potential benefits of making a function is readability (though toggleMenu and closeMenu would be better names) and keeping the JSX lean. I don't know if we have standards that dictate/suggest what we prefer as a team.

src/renderer/components/platform-bible-toolbar.tsx line 50 at r1 (raw file):
Previously, rolfheij-sil wrote…
Do we want to inline CSS stuff like this?

This is almost certainly temporary code. I don't know the correct way to dynamically resize the Drawer based on the number and lengths of the menus. I spent some time fiddling with it, but I didn't want to kill myself trying to figure it out since I'm not even sure if this is how we intend to lay out the menus in Platform.Bible.


Confusion matrix reporter

This would likely require bringing in sklearn as a dependency, which feels unnecessary, especially given how easy it is to just use their functions to get a matplotlib figure and then use a normal FigureReporter: https://scikit-learn.org/stable/modules/generated/sklearn.metrics.ConfusionMatrixDisplay.html


[Plugin Request]

Plugin Name: EXP Leaderboards
Plugin Info:
Create economy like plugin, but in EXP, dependent on economy api, player receives exp the amount of money they get from selling. (If player sells a diamond for $100, player receives 100 exp. /expleaderboard to set location for the leaderboard for top 10 exp holder. /myexp to show how many exp you have. If a player kills someone, receives exp, if killing the same player again, gets half of the exp before this kill. if the player dies, they lose 1% of their exp. (for kill/death exp, make them customization in config.yml). I'd appreciate if the players gets over 1000, it writes as 1k, (1573->1.57k | 248944->248.94k), 1m and 1b same way.
Thank for reading this request, I'd appreciate it if you make this into reality! If you have any questions, feel free to reply and I'll be happy to answer :D

You can do plugin requests on my Discord Server.


Correct duplicate test name

There were two tests in this file named test_get_host_ips_exclude_docker, which meant that the first test would never run.
The quick-and-easy fix is to rename one of the tests, which is what I've done. Somebody who knows the tests better than me should probably check:

Whether we actually want both tests (they're similar but not identical)
If so, whether I've chosen an appropriate name

Looks fine.


Simplify the usage of RpnExpressionBuilder

Signed-off-by: Breezewish<EMAIL_ADDRESS>
What have you changed? (mandatory)
This PR adds some utility function for RpnExpressionBuilder so that the usage can be even more simpler, for example, push_constant don't need to always supply 2nd parameter.
What are the type of the changes? (mandatory)

Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)
No.

/rebuild

/rebuild


SDL readme section may not always be necessary

On my fresh Manjaro XFCE install, monpad "just works" with all the Steam games I've tried, without setting the environment variable. This is surprising, but excellent, news.
We should investigate what the determining factor might be, and which distributions are affected. Previous tests were on a 3/4 year old Mint LTS.

On Overcooked 2, I do need the environment variable...


How to make the autocomplete suggestions appear at particular classes, eg Geometry.*

Context/problem
Within DR, you can access many of the methods in the API from the class level, eg:
Geometry.find_intersect_rect()

The classes we've defined/documented here are in the GTK module, copying the actual classes in the contrib repo.
How do we "fool" Solargraph to expose all these doco hooks at the base level classes, like the example above?
Does this only work within DR because the tick method and therefore our code in a running game are also in the GTK module?
Places where we'd need this:

Geometry
Kernel
???

cc @leviongit for your ruby module/namespace knowledge.  Hopefully this description is clear.

Fixed by https://github.com/owenbutler/dragonruby-yard-doc/pull/5


No consistent order when saving large toml files

Is there a way to either have the items within a table sorted or to preserve their order when parsing and saving files?
I have found the issues #133 and #111 that also ask the question but it seems the answer in 133 does not apply anymore to the newest version of the library. I need a cosnsitent way of saving large files since having the order change every time is a nightmare when dealing with versioning large files unfortunately.
Thank you for your help.

You can use toml::ordered_type_config and toml::ordered_value.
#include <toml.hpp>
#include <iostream>

int main(int argc, char** argv)
{
    if(argc != 2) {return 1;}

    const auto input = toml::parse<toml::ordered_type_config>(argv[1]);
    std::cout << toml::format(input) << std::endl;

    return 0;
}

cf. https://toruniina.github.io/toml11/docs/features/configure_types/#preserving-order-of-values-in-tables
I will add more description about it to README and the docs.

Perfect, thank you so much! I must've missed the section in the docs, sorry about that.


cmd/vet: rangeloop: inspect all go/defer statements prior to a loop back edge

Running go vet on this file:
package main

import "fmt"

func main() {
	done := make(chan bool)

	values := []string{"a", "b", "c"}
	for _, v := range values {
		go func() {
			fmt.Println(v)
			done <- true
		}()
	}

	for _ = range values {
		<-done
	}
}

prints
golang_goroutines_and_closures.go:11: loop variable v captured by func literal

If I change loop body to this:
ok := true
for _, v := range values {
	if ok {
		go func() {
			fmt.Println(v)
			done <- true
		}()
	}
}

then go vet prints nothing.
Looking at the vet source code, checkRangeLoop can just judge a go or defer statement for body  to see whether a variable is capture, which means vet will be failed if it exists condition sentence before a go or defer statement

/cc @mvdan @alandonovan

Making vet more precise for loop-variable capture is #16520. Marking as duplicate.

Making vet more precise for loop-variable capture is #16520. Marking as duplicate.

can the question be sovled?

This is an interesting special case that we could easily extend the check to handle without the full generality of #16520, which is much harder to solve. Specifically: the go/defer statement is still the last statement within the loop body, if we use a slightly more generalized definition of "last" that traverses down into control constructs (such as if-statements in this example).

Hi @luhexcp, FYI, I tried implementing an older idea from @alandonovan and sent https://go.dev/cl/452155. With that CL, go vet now complains about your second example that was not flagged before:

func main() {
        done := make(chan bool)

        values := []string{"a", "b", "c"}

        ok := true
        for _, v := range values {
                if ok {
                        go func() {
                                fmt.Println(v) // vet now warns loop variable v captured by func literal
                                done <- true
                        }()
                }
        }

        for _ = range values {
                <-done
        }
}


Minor errors, typos, and grammar.

A few typos and mistakes made some of this content a little difficult to follow, so I've had a go at improving it.
Category

[x] Content fix
[ ] New article

What's in this Pull Request?
Minor fixes, some typos fixed, some rewrites to make a bit clearer.

Good submissions... the doc needs a few more edits to fix automated warnings that I'll take care of..

Thanks, AC :-)


Upgrade to hanami-model 0.6.1 / hanami-utils 0.7

Coverage remained the same at 75.0% when pulling 36bd43efb06980ca31459e00683b9736498f2d67 on darkslategrey:feature/hanami into 3804ed16fa040471e300c40c8d45ffff60f20673 on angeloashmore:master.

Coverage remained the same at 75.0% when pulling 77d7edb5e55d243a5045671b1a166d028e055977 on darkslategrey:feature/hanami into 3804ed16fa040471e300c40c8d45ffff60f20673 on angeloashmore:master.

Coverage remained the same at 75.0% when pulling c865b914d1a02caaeb56ba81fddfd9b2a4c28459 on darkslategrey:feature/hanami into 3804ed16fa040471e300c40c8d45ffff60f20673 on angeloashmore:master.

Thank you for this! I should have some time to check it out in a day or two.

Not a lot of work to upgrade:

renaming s/Lotus/Hanami/g
change the constructor as it require options params
I also add a Now type to coerce collection. Not sure if it's useful

I had to break the RethinkDB naming convention because the way hanami-model computes the adapter name with classify.
The rethinkdb_adapter become Rethinkdb  and not RethinkDB.
I'm not sure about the pertinence to maintain such adapter in the future.
Mainly because it exists other mature solutions. As nobrainer or rom combined with the rom RethinkDB driver.
By now others solutions, means some work to adapt to Hanami.

Sorry this took me a while to merge.
I personally like ROM. Although a bit hard to setup, I feel it is more flexible. This gem was created when Lotus was still somewhat new and I had not heard of ROM yet. Still, there may be users wanting to stick to Hanami components.
Thanks for the update!


Syncronization of Electrum Win64

I tried first private key with only one transaction before fork, and got BCH very quickly.
Then I added second private key with 80k+ transactions and used long time. More then five days app. syncronizing and still not done. I don't understand which block sycronizing now or how many hours left. Just see slow software network activity on control panel.

Where I can see progress? or how can I understand when sync finish?
Why first wallet synced very fast? This one transaction was in lasts block.

Thanks

i dont know


Got netlink permission deny on Fedora 39

fge@fed:~$ nmstatectl show
[2024-03-04T02:26:28Z INFO  nmstatectl] Nmstate version: 2.2.26
NmstateError: Bug: NetlinkError: Received a netlink error message Operation not permitted (os error 1)
fge@fed:~$ uname -a
Linux fed 6.7.5-200.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Sat Feb 17 17:20:08 UTC 2024 x86_64 GNU/Linux

This will be fixed by https://github.com/nispor/nispor/pull/276 .


Tokens pass through walls while mounted

Tokens pass through walls when mounted on a token with piloting option enabled.
Only Ridable and routinglib are enabled
FoundryVTT version 12
System DnD 5th Edition

I have added a collision check with v3.0.1

It is still possible to enter a wall from the side if it is lined up with the center of the token.

That should now be fixed with v3.0.2

You can still enter a wall but now you get stuck inside and can only exit from one of the end points.

Entering the wall is also possible in core foundry, i don't think there is much more i can do about that. I will try to see what i can do about getting stuck though

In core foundry it is possible to enter a wall in a similar way but the token is still on one side and is unable to see or pass through to the other side.
Honestly, how it was in v3.0.1 was pretty good already in my opinion. It was a minor issue and also easy to work around. And if it still happens, it will usually only be in a situation where the riding player already had access to both sides of the wall anyways.

I tried another version with v3.0.3. It should now be almost impossible to enter a wall with piloting. I have also added a per tile/token setting to enable/disable the collision (default off for tokens), since i realised, that the collision check might cause problems for token attacher tokens with attached walls

Glad to hear that


For information, these little . are intentional marks.
It typically means there is something I have to pay attention to ....

Ahh, i assumed it was different comment styles between you and @inikep


Guide user when selecting storage container

Discussed in https://github.com/Azure/data-product-batch/discussions/75

Originally posted by renepajta August  2, 2021
Hi all ,
I am deploying Batch data product. At Synapse config I am struggling to choose which container of Enriched/Curated data lake I  should choose. Shall I create a new container per data product or point to main data lake container?

We will look into how we can provide more guidance in the Deploy to Azure experience as well as when using the GHA or ADO deployment process.


Gregturn master

@k2iga Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


the Redis Cluster client cannot support auth

fix the Redis Cluster client to support auth in the Func of NewWithOpts #32
#32

Hi.
The DialFunc idea is that you create your own and then use that. In it you can do everything you would like to do before the making the connection(some complicated knock mechanism to open a port ...) and before that connection can be used(sending AUTH and/or SELECT ...).
The cluster package docs don't have example, but there is one in the pool.

@MStoykov is correct, the purpose of the DialFunc is to allow for things like AUTH within it. The pool's example works just as well for cluster. I'm going to close your PR and this issue, but thanks for contributing and please don't be discouraged in the future!


Multiple ticks in multiple select with data-max-options defined as "1"

I have the same issue as has been reported here: https://github.com/snapappointments/bootstrap-select/issues/2289
Select with attribute "multiple" and "data-max-options='1'" is buggy, it allows to select more than 1 item.
It was fixed in v1.13.11, but in v1.14.0-beta2 it is again here. :(

Try this out. It works.
$(document).ready(             function() {                 $('#offering').selectpicker({                     maxOptions:2                 });             }         );

Yes, more than 1 works normally (it does not matter if it is set via javascript or in html attributes).
But in previous versions, data-max-options="1" with multiple attribute was working perfect.
Benefit from this usage that user can see a placeholder "Choose an option..." instead of first value of selectbox.

I made this change and works.

Thank you @FurbyX92, I have tried your fix and it looks good so I commited the proposed change on the dev branch.


Fix dependabot alerts

Codecov Report

Merging #43 (6e887a3) into develop (91dcb45) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #43   +/-   ##
========================================
  Coverage    50.39%   50.39%
========================================
  Files           29       29
  Lines         2562     2562
========================================
  Hits          1291     1291
  Misses        1081     1081
  Partials       190      190

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91dcb45...6e887a3. Read the comment docs.