Discussion: commandline arguments in v0.9 are not user-friendly or readable?

Make arguments user-friendly and type friendly
With ver 0.9 arguments to launch WT has been introduced. This is really a good feature addition.
However I find that the arguments are very linux like and unfriendly to new users:
please refer Ned Pyle:
https://twitter.com/NerdPyle/status/1227757778732601344
and Cinnamon examples:
wt -p "Windows PowerShell" -d . ; split-pane -V wsl.exe
wt -d C:\Users\cinnamon\GitHub\WindowsTerminal ; split-pane -p "Command Prompt" ; split-pane -p "Ubuntu" -d \wsl$\Ubuntu\home\cinnak -H
I do not feel this is userfriendly. Not everyone that want to replace cmd and powershell with a modern terminal is a dev
implement arguments that allow both written and readable and shortened args example, which exlcude using ambigous args
examples
-r or -run
-l or -list

I have not tested it but I think that should work:
wt --profile "Windows PowerShell" --startingDirectory . ; split-pane -V wsl.exe
wt --startingDirectory C:\Users\cinnamon\GitHub\WindowsTerminal ; split-pane --profile "Command Prompt" ; split-pane --profile "Ubuntu" --startingDirectory \wsl$\Ubuntu\home\cinnak -H
You can read the doc here: https://github.com/microsoft/terminal/blob/master/doc/user-docs/UsingCommandlineArguments.md

Yes partly this is ok
as here https://github.com/microsoft/terminal/blob/master/doc/user-docs/UsingCommandlineArguments.md#Reference
for some reason it uses --  instead of  - which is uncommon to Windows
at a glance -V and -H are missing readable -- args

another addition about consistency help feature allows familiar commands as /? -help and also --help
so if we want to keep -- args for linux friendlyness please also also allow them but add args with just one -
so we might please all usergroups.

Well, I don't think Windows-native command-line apps have ever had a consistent (or readable) parameter experience, outside of PowerShell 😉
But why are we using linux syntax --longWords and Case Sensitive -Hp initials-stuck-together syntax on a Windows app? This syntax is not at all native or intuitive on this platform.
Before PowerShell, Windows apps did not use dashes at all, never mind double-dashes. We used /profile or /p and we didn't allow combining short forms.
In PowerShell, parameters are not case sensitive, and we still don't support the concept of combining short-form parameters.
The syntax split-pane -Hp "Windows PowerShell" just isn't normal in Windows.

But why are we using linux syntax --longWords and Case Sensitive -Hp initials-stuck-together syntax on a Windows app? This syntax is not at all native or intuitive on this platform.

Perhaps it could be made better but you are forgetting the primary users of Terminal are also using WSL. It is extremely likely that compatibility will be broken if that syntax isn't used.

I'm marking this as the discussion area for commandline arguments.

the primary users of Terminal are also using WSL

I don't know what makes those of us using WSL the "primary" users. Every user of Terminal is also using Windows. WSL is a Windows app (which is why it has awful pop-up help behavior).

likely that compatibility will be broken if that syntax isn't used.

I'm sorry, but that's hogwash. Show me how using -parameter instead of --parameter "breaks" anything other than the expectations of posix users.
The idea that we should support posix-normal parameter syntax in a Windows app that pops up dialogs to show help is really just guaranteeing confusion. WSL users will use a lot of windows apps, both CLI and Windowed. None of those apps will use this syntax.

@DHowett-MSFT the original intention is a feature request. I am unsure if "discussions" will change anything in the product. Can you outline how this discussion will be handled by PM and designers?

Okay so that's on me for not adding the long form of those args. I kinda threw the whole split-pane command into that PR, I definitely should have had long forms for those 😅
In general, we'll be having both long and short forms for the args we add to commands. Everything else in that spec has them, but sometimes when writing/reviewing a 700 line spec, you miss some of the details 😜
Just now, I actually discovered that CLI11 (which we're using for parsing the args) actually also implicitly supports the /d, /startingDirectory format for args as well. So as it turns out, wt supports both --unixStyleArgs and /windowsStyleArgs. Not only that, but the short windows forms actually doesn't support combining either (eg wt split-pane /Hp "Windows Powershell" doesn't work) . How neat!

I am looking forward how this will turn out in the future.

Hey so this discussion seems to have run it's course. Since we're getting imminently close to 1.0 at this point, and it doesn't seem like we're about to dramatically change the surface of the commandline args, I'm going to close this discussion. I think we've addressed most of the complaints in the OP about not having --longForm versions of most parameters at this point, and the documentation is updated to reflect that.
Thanks for the feedback everyone!


style(ci): lint and standardize the actions structure

Motivation
When making changes that affected multiple actions, not having an standardized file made global replacements difficult, and sometimes it left unwanted code unchanged.
Designs

Make all the actions standard in structure and indentation

Solution

Refactor and lint the files to comply with https://json.schemastore.org/github-workflow.json

Review
@dconnolly can also review this

I used https://marketplace.visualstudio.com/items?itemName=cschleiden.vscode-github-actions to ensure the conditions were kept as we expected, and https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml to lint based on GitHub Action's json schema https://json.schemastore.org/github-workflow.json (mostly automatic)
The changes requested to comply were (aside from linting):

Using macos-latest as macOS-latest does not exists in the schema
Remove  ${{  }} from if conditions
Use required and missing keys from the inputs in workflow_dispatch

Changes after revision:

Revert to single quotes (fewer diff)
Lint Mergify and Dependabot conf

@teor2345 @dconnolly I'd like to prioritize this PR, as it will help me identify common errors, including parsing errors that won't be correctly parsed by GH (I added an action to lint other actions and verify shell errors)

@teor2345 @dconnolly I'd like to prioritize this PR, as it will help me identify common errors in other PRs, including parsing errors that won't be correctly parsed by GH (I added an action to lint other actions and verify shell errors)

That makes sense. Did you need it to go in before we tag the NU5 testnet rollback version?
(We're currently waiting for the zcashd team to release 4.7.0 and pick an activation height. Hopefully that will happen some time in the next few days.)
Here's what I think this PR does:
No behaviour change:

use standard formatting

Behaviour change:

change when some workflows run
add a job that lints workflows

Unsure:

remove some job conditions - only a behaviour change if the conditions were skipping the job

Do any of these changes need to merge sooner? Did I miss anything?
If we need some changes sooner, we could reduce the risk by splitting it into multiple PRs. Or by testing a Rust PR immediately after it merges, and reverting if it causes problems.

@teor2345 answering you here:

Here's what I think this PR does:
No behaviour change:
use standard formatting
Behaviour change:
change when some workflows run
add a job that lints workflows
Unsure:
remove some job conditions - only a behaviour change if the conditions were skipping the job

Change when some workflow run:

This was the changed condition https://github.com/ZcashFoundation/zebra/pull/3940/files#diff-107e910e9f2ebfb9a741fa10b2aa7100cc1fc4f5f3aca2dfe78b905cbd73c0d2 which I recently explained here: https://github.com/ZcashFoundation/zebra/pull/3940#discussion_r841316337 and it should be "safe" as it's just running the same linting but just on PR instead of push, and adding the workflow linters. This won't consume much time on each PR until we have a better solution.

Add a job that lints workflows:

As this jobs just raises warnings and it doesn't try to lint the files automatically, it should be safe enough.

Remove some job conditions

This conditions were wrongly added to a patch file which didn't have inputs https://github.com/ZcashFoundation/zebra/pull/3940/files#diff-74d6f532ff664f2d9c2ee8b539caf7545179c52ae354f21a6b6bdbb6b2a0d084

I reduced some diffs so we're basically just adding the formatting and the linting behavior change.

@teor2345 this is ready. The shellcheck can be seen later, those have been like that for a while, I don't think those are completely valid.
I fixed the checkpoint_sync issue as that one was needed.

@teor2345 this is ready. The shellcheck can be validated later, those shell commands have been like that for a while, I don't think those recommendations are completely valid for the specific use case.

I checked each shellcheck warning.
Some could be fixed, but none of them seem to be causing problems right now. They will be ok as long as the names don't contain special characters. (And we control those names.)
Some of them might need to be ignored.

Merge queue: sync past mandatory checkpoint:

Error: No such container: klt-sync-checkpoint-4078-merge-97382fe-qxsz

https://github.com/ZcashFoundation/zebra/runs/5963991145?check_suite_focus=true#step:9:115

@mergifyio update

Yeah, I have that warning pending. I don't want to do checkout if it's not needed, but this is working without using checkout, but I'm not sure it will still work if I remove the create_credentials_file. I'll test that in the documentation PR

This is, once again, the error caused by partitions in GCP

This happened before in other PRs, I'll follow up with the ticket. But it's not related to the name of the container.
I'll also create a PR to show this kind of issues when the container does not start, so it's easier for the team identifying the root cause without having to get into GCP and search for the logs


Generate RSpec subjects/lets using Rantly

Is there a way to parametrize subjects/lets using Rantly?

You can return rantly data from rspec's let and subject methods for use in your tests.
let example
require 'rantly'

describe 'Rspec let with rantly' do
  let(:random_string) do
    Rantly { string }
  end

  it 'is a String' do
    expect(random_string).to be_a String
  end
end

subject example
require 'rantly'

describe 'Rspec subject with rantly' do
  subject do
    Rantly { integer }
  end

  it 'is a Number' do
    expect(subject).to be_an Integer
  end
end

I know I can, but I want to be able to run the tests multiple times. I managed to do it without the RSpec integration.

@thedrow Could you provide an example of what you have done outside of the rspec integration?
You can also run each property test based on the RANTLY_COUNT environment variable. See here.

I no longer have access to the code. I just copy/pasted the blocks around.
As far as I understand from the documentation Rantly { integer } will only generate one example.
In order to utilize the rspec integration you have to use:
property_of {
  integer
}.check { |i|
  assert(i.is_a?(Integer), "integer property did not return Integer type")
}


Failed to fetch chunk

Hi,
I know this has been answered in issues 123
I have posted 6 transactions today trying to resolve the issue using both
transaction.post(transaction) and uploader in the example, but non of the two works

This is the error message with uploader function.
txn hash: TZTrMhF5-zpSyQJp3ZeyVSrT079PMzS1WVq2bB6HKCY
All the transaction went through and the uploader did return in the console but when calling getData I still get chunk error.
Thanks
After hours of testing and trying, I believe it is the issue with vite. With React or Next.js, the function is running perfectly fine.

Arweave.js works badly in vite enviroment (#167)

Actually the issue was data was not boardcasted to the network. Rare cases. All further transactions are in good state

issue resolved as i understand it, closing


Update grabbingOneCommit.js

There are no branch master, it is called main. SO in russian language it should be not 'in master' but 'in main branch'

Ah yes, we went through and renamed all master instances to main but it wouldnt catch the translated version (like мастер)


Password-protected Tokens

Readiness checklist

[X] I added/updated tests.
[X] I ensured that the PR title is good enough for the changelog.
[X] I labeled the PR.

Some TODOs not in this PR are:

Allowing querying for password-protection in the runtime (I forgot it with the templates, so I thought to do them separately for both templates and tokens)
Completing the refactoring where validations for expiresAt and passwordProtection are moved into the SchemaValidator by renaming the SchemaValidator

It seems like you have committet some things during my review - please make sure to read all comments, also if they are marked as outdated as this can be a false positive.

Also this PR conflicts.

@Milena-Czierlinski typically we don't test error messages, only codes.

@Magnus-Kuhn anything that blocks this from merging?


I get this error when trying Cohere Example API

Documentation for Intent classification: https://docs.cohere.com/reference/intent-recognition
Input Import:
import cohere
from cohere.responses.classify import Example

Error:
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[12], line 2
      1 import cohere
----> 2 from cohere.responses.classify import Example

ModuleNotFoundError: No module named 'cohere.responses'

Cohere API Responses is not  coming correctly. I am using the cohere verison: 5.2.2

Hey @kurianbenoy sorry that doc is out of date. I will get it updated. Please see the api docs for up to date snippets! classify should look like:
import cohere
from cohere import ClassifyExample
co = cohere.Client('<<apiKey>>')
examples=[
  ClassifyExample(text="Dermatologists don't like her!", label="Spam"),
  ClassifyExample(text="'Hello, open to this?'", label="Spam"),
  ClassifyExample(text="I need help please wire me $1000 right now", label="Spam"),
  ClassifyExample(text="Nice to know you ;)", label="Spam"),
  ClassifyExample(text="Please help me?", label="Spam"),
  ClassifyExample(text="Your parcel will be delivered today", label="Not spam"),
  ClassifyExample(text="Review changes to our Terms and Conditions", label="Not spam"),
  ClassifyExample(text="Weekly sync notes", label="Not spam"),
  ClassifyExample(text="'Re: Follow up from today's meeting'", label="Not spam"),
  ClassifyExample(text="Pre-read for tomorrow", label="Not spam"),
]
inputs=[
  "Confirm your email address",
  "hey i need u to send some $",
]
response = co.classify(
  inputs=inputs,
  examples=examples,
)
print(response)

Thanks, this helped!


[FLINK-19086] Revert "[FLINK-19052] [serialization] add constructor c…

What is the purpose of the change
This reverts commit 162e3ead63e5766cf2116af09922a88537889e53 ( PR https://github.com/apache/flink/pull/13250 )
which caused performance regression 2020-08-28 in globalWindow benchmark (FLINK-19086).
Verifying this change
http://codespeed.dak8s.net:8080/job/flink-benchmark-request/221/

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: yes
The runtime per-record code paths (performance sensitive): yes
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? no

CC @shuttie @aljoscha

No, the failure is unrelated:
Errors:
   Elasticsearch6DynamicSinkITCase.testWritingDocumentsNoPrimaryKey:225 » Execution

Caused by: org.elasticsearch.client.ResponseException: method [HEAD], host [http://<IP_ADDRESS>:9200], URI [/], status line [HTTP/1.1 503 Service Unavailable]

@flinkbot run azure


Feature Request

When go into dashboard, if I'm the creator of the dashboard want a fast edit button (current I have to go to my space and click option to edit)
Add click to update filter in dashboard
Extend session, so I need sign in once in 7 days or 30 days
Able to click a column in chart to filter
Able to change visualization on dataset screen

for 1  , design change isrequired.    won't support it in short time.

for 3 , it's api access token grant issues,  by default configuration as 7 days.    not a  big deal for builders, even can sign in per day.
for viewers , it does not require for signin.

for  2,4 , support


handle z coordinate

should this flip [x, y, z] to [z, y, x], or just maintain the z coord?

Done in 6f833bb7909071246f1222ef874d4a4208f486a7


add_tsm

Signed-off-by: gexy5<EMAIL_ADDRESS>

Codecov Report

Merging #1148 (b793bf7) into main (376b134) will decrease coverage by 4.05%.
The diff coverage is 17.55%.

@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
- Coverage   65.93%   61.88%   -4.06%
==========================================
  Files         226      232       +6
  Lines       10321    11260     +939
  Branches     1736     1829      +93
==========================================
+ Hits         6805     6968     +163
- Misses       3066     3819     +753
- Partials      450      473      +23

Impacted Files
Coverage Δ

towhee/models/tsm/bn_inception.py
6.23% <6.23%> (ø)

towhee/models/layers/non_local.py
20.73% <20.73%> (ø)

towhee/models/tsm/temporal_shift.py
20.79% <20.79%> (ø)

towhee/models/tsm/mobilenet_v2.py
20.83% <20.83%> (ø)

towhee/models/tsm/tsm.py
34.63% <34.63%> (ø)

towhee/models/tsm/basic_ops.py
80.00% <80.00%> (ø)

towhee/models/utils/video_transforms.py
85.00% <0.00%> (-1.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376b134...b793bf7. Read the comment docs.

@gexy185 Add test cases to cover all base models for TSM.

Todo:

refactor (split): base models as individual towhee.models
ut: add more test cases to increase coverage

Merge for now. Please open a new pr to optimize @gexy185.
/lgtm
/approve

/lgtm
/approve


Aux window split view sash uses the main window mouse move events

Repro:

Open a text editor
Split editor in group
Move the active editor into a new window
Resize the split view if you can 🐛

Thanks, maybe this is fixed by https://github.com/microsoft/vscode/pull/195778.
You seem to be running out of sources, could you check from that branch. If it still reproduces do you have more detailed steps how you do the dragging in the last step?

I've tested #195778, and I can confirm that it's fixed.


Links unfurl twice

Description
I am using the chat.unfurl method to create custom unfurls, however it seems to unfurl twice when I post the message. One through my implementation and another through the classic link unfurling. In the documentation it says
Be sure and respond with a friendly HTTP 200 OK to the event as quickly as possible. Do not wait to wrestle an unfurl with [chat.unfurl](https://api.slack.com/methods/chat.unfurl) before telling Slack you received the event. You'll probably want to enqueue behavior like this.
Looking at the Bolt Python Repo issues one person mentions this: https://github.com/slackapi/bolt-python/issues/283#issuecomment-815354541 as well.
I think the double unfurling may be happening because we don't acknowledge the request, however the ack() function is not in the slack event middleware arguments.

What type of issue is this? (place an x in one of the [ ])

[x] bug
[ ] enhancement (feature request)
[x] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Reproducible in:
package version: "@slack/bolt": "3.11.1",
node version: 14.9
OS version(s): macOS Monterey 12.4
Steps to reproduce:
Probably will need to download our Guru QA app if that is possible
paste link in message box https://qaapp.getguru.com/card/cMEMgbbi/Public-Card-Test
Expected result:
only one unfurl

Actual result:
two unfurls

Attachments:
This is the flow our code for listening to chat unfurls.
in our index we listen to the "link_shared" event
app.event("link_shared", handleLinkUnfurls);
handleLinkUnfurls handles the event
export async function handleLinkUnfurls(
  props: LinkUnfurlParams
): Promise<void> {
  const { client, event, context } = props; //no ack function available

  const ts = event.message_ts;
  const channel = event.channel;
  const url = event.links[0].url;

  //business logic code

  const unfurls = {
    [url]: {
      blocks: createLinkUnfurlView(cardData, url),
      preview: {
        title: {
          type: "plain_text",
          text: "card title"
        }
      }
    }
  };

  await client.chat.unfurl({ ts, channel, unfurls });

Hey @EddyYeung1! Thanks for writing this up and providing helpful attachments and steps to reproduce. I've run out of time today to take a look at this issue, but it's on my radar to look at first thing tomorrow PST.

@seratch ok in that case, what might be causing the links to unfurl twice? I was hoping that if we have the domain registered in the slack dev portal slack would recognize not to fallback to classic link unfurling?

@EddyYeung1

I was hoping that if we have the domain registered in the slack dev portal slack would recognize not to fallback to classic link unfurling?

Sorry, we don't have such an option at this moment.
If your app receives link_shared events multiple times and it's not due to retries, I'd suggest checking if the user_id / bot_user_id in the event payload is the one of your app to skip repeating the chat.unfurl API requests.

@seratch interesting I found this part of the documentation as well, but I am not sure where to put this to turn off classic link unfurling?

@EddyYeung1 Ah, I see the point. These flags can be passed when you post a message using chat.postMessage / chat.postEphemeral / chat.scheduleMessage API methods.

@seratch so if we use chat.unfurl we can't turn it off at all and just have to manually close out the slack classic unfurl?

@EddyYeung1 I do understand that the lack of those options is an obstacle for your use case, but your understanding is correct.

In this case, it seems that your unfurling content itself also has the target URL in the blocks. So, my understanding of your situation is that the default unfurling for the URL in your blocks happens while your custom unfurling works.

we actually thought the same thing and tested it without the context block having our link in it. As you can see in this screenshot the behavior still persists.

@EddyYeung1 Thanks for your reply. I confirmed that I could see the same behavior on my end. Even when the blocks are in a chat.unfurl API request do not contain any URLs, the classic unfurling occurs.
We will escalate this feedback to the product / engineering teams. However, as for the short-term solution, AFAIK, there is no workaround at this moment. Also, since I had misunderstood the latest behavior of unfurling in this scenario, I couldn't provide a quick answer to this inquiry. I am sorry for that.
As the SDK maintainers, we don't have any further actions that we can take for you in this issue tracker. So please let us close this issue now. Please contact our partnership counterparts and customer support agents if you have any follow-ups on the unfurling behavior.

@seratch Hey thanks for looking into this for me. I actually just discovered that the link in our Action Button was the reason it was unfurling twice. I removed it and it no longer classically unfurled. However, this is still an issue because we have to include that URL in the button for it to work. So still seems like a slack issue, but at least we know where it's coming from now. It is odd however, on your end you were getting the same behavior for having no links present.

@EddyYeung1 - I think it should be a bug if Slack tries to unfurl links inside of existing unfurl content supplied as part of chat.unfurl. I'll keep this issue closed as I agree with @seratch  that there's not much we can do as SDK maintainers to help resolve this on our end.
However, I have filed an issue with the interactivity team on our end. As I get responses, I will update!

@EddyYeung1

that the link in our Action Button was the reason it was unfurling twice.

I noticed there are two buttons in the blocks. Does that Action Button link you mentioned contain the same URL as the URL which triggers the link_shared event in the first place (aka the one in the message)? Or is it a different URL?

@srajiang its the same URL, oddly enough however, we are no longer having the issue anymore. We haven't made any changes

Ok. First, I'm glad you're not having the issue anymore - but how frustrating that we weren't able to get to the bottom of why. I'm sorry about that! It's definitely a Slack server-side behavior, I am just not sure if a fix is likely to materialize soon, since it's seen inconsistently and those are difficult to get fixes for.
Here's what I've been able to find out, if it helps:
A known behavior we've seen: The original link shared unfurls twice – once by Guru (via chat.unfurl) and once by the default Slack unfurler. The server-side does it's best to block the in-built unfurl, but if the app takes a little while to respond, timing issues can happen. This sounds a bit like what Kaz described repro-ing since he saw classic unfurl behavior with no additional links shared. This is unfortunately something that isn't going to be fixed any time soon.
Still doesn't fully explain why removing the second link would temporarily fix the unfurling issue, so I'll poke around a bit more. Let us know whether the issue comes back @EddyYeung1!

@EddyYeung1 - There's one last thing I want to check. Can you provide your App ID and the Team ID of the workspace you're developing in?

@srajiang App ID: A0321PHS5BJ Team ID: T031941HY69

I found this thread after having the same issue myself. In my case what fixed it was adding the links:read scope to the oauth configuration page: https://api.slack.com/apps/{YOUR_APP_ID}/oauth
It's confusing because you can still generate a valid token through OAuth with the required scopes as query params without having the scopes added to the config on that page. Hopefully this will save someone a bit of time in the future.


Error when loading weights without top layer

Hi,
first of all, thanks for your work providing this Keras implementation of DenseNets.
I am trying to create a DenseNet model without the last layer using the instruction:
model = densenet.DenseNet((32, 32,3), depth=40, growth_rate=12, nb_filter=16,include_top=False)
but it produces the following error:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "densenet.py", line 169, in DenseNet
    model.load_weights(weights_path)
  File "/home/joheras/.virtualenvs/keras/local/lib/python2.7/site-packages/keras/engine/topology.py", line 2572, in load_weights
    load_weights_from_hdf5_group(f, self.layers)
  File "/home/joheras/.virtualenvs/keras/local/lib/python2.7/site-packages/keras/engine/topology.py", line 3012, in load_weights_from_hdf5_group
    g = f[name]
  File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper (/tmp/pip-build-YjgiH2/h5py/h5py/_objects.c:2687)
  File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper (/tmp/pip-build-YjgiH2/h5py/h5py/_objects.c:2645)
  File "/home/joheras/.virtualenvs/keras/local/lib/python2.7/site-packages/h5py/_hl/group.py", line 166, in __getitem__
    oid = h5o.open(self.id, self._e(name), lapl=self._lapl)
  File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper (/tmp/pip-build-YjgiH2/h5py/h5py/_objects.c:2687)
  File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper (/tmp/pip-build-YjgiH2/h5py/h5py/_objects.c:2645)
  File "h5py/h5o.pyx", line 190, in h5py.h5o.open (/tmp/pip-build-YjgiH2/h5py/h5py/h5o.c:3440)
KeyError: "Unable to open object (Object 'dense_2' doesn't exist)"

It does not matter whether I use theano or tensorflow as backend.
Do you know how to solve this?
Thanks in advance.
Jónathan

I will have to look at the weights file. Sadly, I'm travelling right now so I can't do that for the next 11 days or so.

Thanks, whenever you have time to do it will be fine for me.
Since loading the weights including the top layer works properly, and I am planning to try this network for transfer learning, I wonder if it makes sense to load the weights including the top layer, and then remove the last layer of the network. Will it produce the same results as loading the weights without the last layer?

DenseNet doesn't have Fully Connected Layers. It feeds directly into a Softmax class layer after the global average pooling.
If you load up all the laters, then pop the last layer (it would be the same as using the no top model). To make sure how many layers to pop, look at the last section of the DenseNet code.
Sorry for the hassle and I'll look into it asap

Yes, that was what I meant.
Thank you so much, and congratulations for this nice work.


[feat] Links in the app help menu on Mac

Links to go in this empty help menu

Website (https://onlook.dev/?utm_source=onlook_studio&utm_medium=app&utm_campaign=in-app help menu)
Support<EMAIL_ADDRESS>Report Issue (https://github.com/onlook-dev/onlook/issues/new/choose)

Could you assign it to me?

there ya go 👌

@drfarrell, the top bar is changed now, its no longer the default windows top bar. So I think this issue could be closed.

This still exists on the mac version so I'll update the issue to specify

@drfarrell @Kitenite I can't test this on a Mac, so I won't be able to work on this issue

No worries, I'll unassign you @abhiroopc84


Revert boolean flag to make sure JNI structures are always released

What does this PR do?:
Fixes erroneous logic for releasing JNI structures
Motivation:
Avoiding slow memory leak
For Datadog employees:

[ ] If this PR touches code that signs or publishes builds or packages, or handles
credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
[x] This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Will be dealt with in another PR


RBD: implement volume resizing with go-ceph

The resizeRBDimage() function (to be renamed to rbdVolume.resize()) still calls out to the rbd command. go-ceph supports image resizing, so that should be used instead.

@nixpanic I can pick it up

This can be worked on once #1262 has been merged (contains the rename of resizeRBDimage() to rbdVolume.resize()).

#1262 has been merged. The rbdVolume.resize() function can now be implemented with go-ceph.
While doing so, it is probably a good idea  to pass the new size as a parameter to the resize(newSize) function, instead of updating the member of the rbdVolume object and hoping that resize does not return an error. After successful resize the  resize() method should update the member of the object, of course.


Wrong target for link "DTU resource limits - Azure SQL Database."

The first link of the page "DTU resource limits - Azure SQL Database." target a vCore documentation page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83ac6bf5-b77e-2eeb-20ad-f850fbbf06c6
Version Independent ID: fa64f1b9-62f1-3abc-523c-419682d911c0
Content: DTU resource limits elastic pools - Azure SQL Database
Content Source: articles/azure-sql/database/resource-limits-dtu-elastic-pools.md
Service: sql-database
Sub-service: elastic-pools
GitHub Login: @sachinpMSFT
Microsoft Alias: sachinp

@BzSpi Thank you for the feedback. This is being assigned to the content author to evaluate and update as appropriate.


Tcp socket implementation

Recently In a research project for work we were looking into integrating SIP phone functionality into our existing client flutter app. The main constraint was that it had to work with a 3cx server.
Unfortunately 3cx doesn't accept web socket connections and seeing as this was the only viable dart sip ua package on pub dev I had to go about adding the ability to connect to 3cx over tcp with this package.
I have successfully registered with a 3cx server and made calls between two clients.
I then went back and made sure that I could still register fine with an Asterisk server on FreePBX using the existing websockets.
In a nutshell what i did was abstract out the websocket class into a socket_interface. Then have  web_socket and tcp_socket  classes extend this abstracted interface.
In the example app when you register the connection, a type is chosen with a radio check box.
When what ever type is chosen, the sip_ua_helper creates the appropriate socket types and adds them to the array of sockets.
The rest of the package carries on as usual not caring about what type of socket is used. It just calls .send() on the socket interface and the sockets deal with how they connect.
At the risk of sounding lame, im hoping this will eventually be accepted as it will be my first contribution as a developer to public open source code :)

Thanks @mikaelwills, this is great work.
Before merging, we may need to do some checks

Make sure this patch does not affect Flutter Web because the browser does not support TCP
Since TCP is already supported, I think TLS can also be supported (using SecureSocket). Of course, it is not necessary. I am very interested to see if it can be supported.

Great news.
I'll start looking into those two points. WIth the second point possibly making a third secure_socket.class the extends the abstract class and getting that to work.

This is really good news as it would make this library so much more versatile.


help,could you install the detectron2 with cuda 11.3?

hello ,i have met a fault below when i use this comand 'python -m pip install -e detectron2' to install detectron2
The detected CUDA version (11.3) mismatches the version that was used to compile PyTorch (10.2). Please make sure to use the same CUDA versions.

my cuda version is 11.3 which is recommended

pytorch version is 1.12

It seems you should update your pytorch version, you should install the version complied with cuda11.3 in pytorch official website

i have fixed it ,the reason is that when install torch with pip should down the torch which is pre-builded with the same cuda version


Why setting the same controller in both route config and template?

I see that the controller for a template is defined in both the route config as the actual template. One of them is not needed I suppose, as there will be two of them created? Which would you keep and which would you remove? Removing it from the template messes up the IDE (IntelliJ IDEA), so I would say in the route config?

i have a style for that https://github.com/johnpapa/angularjs-styleguide#style-y038


Feature Request - Date Formats

Is your feature request related to a problem? Please describe.
Right now the date format is DD-MM-YYYY, where a lot of users probably use MM-DD-YYYY, or my preference, YYYY-MM-DD
Describe the solution you'd like
A setting either in the settings file or in webUI (preferred all settings are avaialble in web UI actually! Would make knowing what we can change much easier at a glance)
Thanks in advance, finding this quite easy and pleasing to use so far! :)

@CorneliousJD, thank you for well described and to the point feature request.
This issue will be solved in sync with #133


Space padding and scroll setup

How can I set space padding between tabs to zero? I'd like tabs to fill the bar and avoid gaps, without scrolling. And to have the same width if possible.
I'm using the 3.0 (objective c) version from pods.

You can do buttonBarView .shouldCellsFillAvailableWidth = YES
Cheers


Scrolling to top when option changed

Imagine the buttons at the bottom of a ScrollView.
When option clicked, it re-render the scene (normally) and scrolls to top. Is there any workaround for this?

I have no idea but that's a react-native issue to preserve scroll positions between render cycles, it's not specific to this component.


SubQuestionQueryEngine: Equivalent of RetrievalQAWithSourcesChain and printing intermediate results in streamlit

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I am using SubQuestionQueryEngine for chat with pdf functionality. I need help with a couple of things:

Is there an equivalent of RetrievalQAWithSourcesChain from Langchain in Llamaindex? What I want is that the response should also return sources that were used to draft the response with specific page number, so that users can scroll to that part and get additional info as needed. Something similar to what they have implemeneted here: https://chat.langchain.com/

When I run the subquestion query, it does show me the intermediate results in python notebook. But when I try the same code in a streamlit app, the intermediate steps don't appear. Is there a way to stream the intermediate steps in realtime and output it on streamlit ?

You need to use a callback to achieve both of these. We did the same in our SEC-Insights demo app
https://github.com/run-llama/sec-insights/blob/e7f20213c60984dec2d25106ae4c3501e19c88c0/backend/app/chat/messaging.py#L33
I can make a PR to add the source nodes to the response object though. But the callback will give you the most direct results.
The sub-steps are only printed to console, which is why you don't see it in your streamlit app.

Thank you @logan-markewich , this is helpful


Fix another bug in the Quota method.

Given the current config, the quota method can be invoked from the mixc command
with:
bazel-bin/cmd/client/mixc quota --amount 1 -name RequestCount

This change is

Jenkins job mixer/presubmit passed

Jenkins job manager/mixer-pr passed

Do I still need to provide --globalConfigFile and --serviceConfigFile flag in addition to these quota flags?

Jenkins job mixer/presubmit passed

Jenkins job manager/mixer-pr passed


Don't attempt to regenerate keys if they appear to have already been generated.

You need to do a couple of things with this commit:

Add a sign-off.  This is as easy as running git commit --amend -s
Follow the community contributing guide around commit messages (specifically, we link to this post by Chris Beam).  You can also make this modifications with the above git commit --amend -s
You'll need to go through the DCO steps if you haven't already, which are under the Checks.

Thanks again for the fix @MattSGS .  Looks like there were a few fixups required including the sign-off. If we don't hear back soon I'll assume you've moved on to help other projects and I will close this for you.

Closing due to lack of DCO sign-off. If fixed, please re-open.


Implement Borrow for QueuedWaker

This allows using self.queue.remove(&id) directly, which then allows other simplifications.

The "other simplifications" are

No need to implement  PartialEq, Ord, and PartialOrd for QueuedWaker
Avoid a call to unwrap in Waitlist::pop


Configure and enforce ktlint

Applies and enforces uniform Kotlin coding style via ktlint. Adds a pre-comit hook.
Removes all .idea config as these depends on the developers os and hard pathes.
Adds gradle initIdea to easily generate a local userspecific .idea configuration.
Resolves #2

@Sebkasanzew line endings are fixed. Anything else todo?

@reicheltp Ready to merge from my side


package_data does not copy files

I have a simple setup file that compiles cython code. However, I want to package my *.pxd files for other cython packages to use. The package_data option does not copy the pxd files to the installed directory regardless of what options I use.
MANIFEST.in
glob-include *.pxd
global-exclude __pycache__

[...]
setup(
...
package_dir = {"", "plexsim"},
package_data ={"", ["*pxd"]},
include_package_data = True
)

My sources file lists the to be packaged  files
[/...egg/SOURCES.TXT]
plexsim/models.cpp
plexsim/models.pxd
plexsim/models.pyx

However the installed directory remains empty
[python3.8/site-packages]
models.cpython-38-x86_64-linux-gnu.so
models.py
__pycache__

The only work-around I have found is to use the data_files option, however this seems a bit odd as even in the docs it's stated as a 'else' option for packing data.
Am I missing something with my setup file? Why is the added option not used?
Setuptools: 50.3.0.post20201006
python: 3.8.6

Hi @cvanelteren, have you tried this thing again with version 58.5.3?
Maybe the problem was solved with https://github.com/pypa/setuptools/pull/2844.

For the time being, I will close this issue since I believe it was solved by #2844.
But please feel free to re-open it (by adding a comment with more information regarding a more recent version of setuptools).


cmake: DTS post-processing of ELF file depends on CONFIG_HAS_DTS

Only run gen_handles.py if CONFIG_HAS_DTS is set. This enables vendors
without device tree implementations to compile without the generated
dependencies.
Fixes #34416.
Signed-off-by: Morten Priess<EMAIL_ADDRESS>

Closed/reopened to rerun CI

Can anybody help with the CI errors? Is it because some configurations are using DTS, but somehow set CONFIG_HAS_DTS=n?

Can anybody help with the CI errors? Is it because some configurations are using DTS, but somehow set CONFIG_HAS_DTS=n?

@pabigot can you assist ?

Can anybody help with the CI errors? Is it because some configurations are using DTS, but somehow set CONFIG_HAS_DTS=n?

@pabigot can you assist ?

In arch/Kconfig the SPARC architecture doesn't have select HAS_DTS.  Adding a commit that "fixes" that would probably make it work.  Not sure why it isn't there @martin-aberg
I suspect platforms that don't have devicetree aren't going to make it very far in the Zephyr of the future.  @galak @mbolivar-nordic FYI in case this is something to consider from an architectural level.

In arch/Kconfig the SPARC architecture doesn't have select HAS_DTS. Adding a commit that "fixes" that would probably make it work. Not sure why it isn't there @martin-aberg

Thanks! I will add a commit with that selected.

I suspect platforms that don't have devicetree aren't going to make it very far in the Zephyr of the future

I can understand that from a Zephyr architectural perspective. I will inform my colleagues of the deprecation, and hopefully we can go the DTS-way in the next generation.

I suspect platforms that don't have devicetree aren't going to make it very far in the Zephyr of the future. @galak @mbolivar-nordic FYI in case this is something to consider from an architectural level.

That is my general impression as well, as documented in https://docs.zephyrproject.org/latest/guides/dts/design.html#single-source-for-all-hardware-information though this is ongoing work.
Basic things like "be able to create a struct device that isn't from devicetree" will continue to work "forever", though, as far as I know. I never use platforms without DTS though, not sure if we've got project level decisions made on the future of CONFIG_HAS_DTS=n.

@pabigot Thank you for the heads-up regarding the missing HAS_DTS.
@mtpr-ot Thank you for the fix.

@pabigot, so is this acceptable for the time being?


fix: Wrap each use of filesystem library in #ifndef __wasm__

Description
Workaround that fixes #180
As noted in the issue, the <filesystem> library can't be used in code that compiles to Wasm, even if we are targeting WASI. I just quickly wrapped all the usages in #ifndef __wasm__ to verify this workaround solves the problem in Nix. I think the "more correct" way to solve this would be to use mkdir (on unix) and _mkdir (on Windows), but that seemed to receive pushback on the internal PR.
Checklist:

[x] I have reviewed my diff in github, line by line.
[x] Every change is related to the PR description.
[x] I have linked this pull request to the issue(s) that it resolves.
[x] There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
[x] There are no circuit changes, OR specifications in /markdown/specs have been updated.
[x] There are no circuit changes, OR a cryptographer has been assigned for review.
[x] I've updated any terraform that needs updating (e.g. environment variables) for deployment.
[x] The branch has been rebased against the head of its merge target.
[x] I'm happy for the PR to be merged at the reviewer's next convenience.
[x] New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
[x] If existing code has been modified, such documentation has been added or updated.

Since the wasm tests don't run in CI. @dbanks12 recommended I run them locally, so I ran the following commands:
cd build_wasm
for test in ./bin/join_split_example_*tests; do
  wasmtime --dir .. $test;
done

and all succeed 🎉


TypeScript errors when layer and app have different dependency versions

Environment
app
- Operating System: `Darwin`
- Node Version:     `v18.16.0`
- Nuxt Version:     `3.6.5`
- Nitro Version:    `2.5.2`
- Package Manager<EMAIL_ADDRESS>- Builder:          `vite`
- User Config:      `extends`, `typescript`, `devtools`
- Runtime Modules:  `-`
- Build Modules:    `-`

layer
- Operating System: `Darwin`
- Node Version:     `v18.16.0`
- Nuxt Version:     `3.6.5`
- Nitro Version:    `2.5.2`
- Package Manager<EMAIL_ADDRESS>- Builder:          `vite`
- User Config:      `typescript`
- Runtime Modules:  `-`
- Build Modules:    `-`

Reproduction

clone repo https://github.com/DawidKopys/nuxt-h3-event-ts-error-repro
run npm i in nuxt-layer directory
run npm i in app directory
run npx nuxi typecheck / npm run dev / npx vue-tsc --noEmit inside app directory. You should get below error:

Nuxi 3.6.5                                                                                3:57:55 PM
../nuxt-layer/server/api/foo.ts:7:13 - error TS2345: Argument of type 'H3Event' is not assignable to parameter of type 'H3Event<EventHandlerRequest>'.

7   setCookie(event, 'someCookieName', 'someCookieValue')
              ~~~~~

../nuxt-layer/server/utils/someUtil.ts:6:13 - error TS2345: Argument of type 'H3Event' is not assignable to parameter of type 'H3Event<EventHandlerRequest>'.
  Type 'H3Event' is missing the following properties from type 'H3Event<EventHandlerRequest>': method, headers, toJSON, fetch, $fetch

6   setCookie(event, 'someCookieName', 'someCookieValue')
              ~~~~~

Found 2 errors in 2 files.

Errors  Files
     1  ../nuxt-layer/server/api/foo.ts:7
     1  ../nuxt-layer/server/utils/someUtil.ts:6

Describe the bug

app has dependency h3 installed with version 1.8.0
nuxt-layer has dependency h3 installed with version 1.7.1 (forced with overrides field in layer's package.json - for simplicity - the effect would be exactly the same if layer had 1.7.1 version locked with its package-lock.json)

As a result, I am getting typescript errors if some utils are imported manually from h3 and others are auto-imported. Layer file server/api/foo.ts shows simple example of this scenario. In this file, defineEventHandler is imported manually, while function setCookie is auto imported - we get ts error because of that.
There is a simple solution for this exact situation - don't import defineEventHandler manually. If done so, there are no ts errors for this file.
However, sometimes we might need to import something manually from our dependency. File server/utils/someUtil.ts serves as an example of such case.
Here, we have some utility function, which accepts event as its argument. In order to type the parameter we need to import H3Event from h3. This function also uses setCookie function which is auto imported.
Again, we get ts error as a result.
Workaround
Importing everything manually from our h3 dependency fixes the problem - we no longer get ts errors.
We no longer get the benefit of auto imports though.
Additional context
No response
Logs
No response

Does it make a difference if you import from #imports?

I can't make it work importing from #imports. My code with the changes is here:

I have added /nuxt-layer/server/tsconfig.json file, similarily to how it was done in app
in both app and nuxt-layer - I am getting ts errors:

layer:
server/api/foo.ts:5:10 - error TS2305: Module '"#imports"' has no exported member 'defineEventHandler'.

5 import { defineEventHandler } from '#imports'
           ~~~~~~~~~~~~~~~~~~

server/api/foo.ts:7:36 - error TS7006: Parameter 'event' implicitly has an 'any' type.

7 export default defineEventHandler((event) => {
                                     ~~~~~

Found 2 errors in the same file, starting at: server/api/foo.ts:5

the app (I have added file /app/server/api/bar.ts to verify if it works in the app:
server/api/bar.ts:1:10 - error TS2305: Module '"#imports"' has no exported member 'defineEventHandler'.

1 import { defineEventHandler } from '#imports'
           ~~~~~~~~~~~~~~~~~~

server/api/bar.ts:3:36 - error TS7006: Parameter 'event' implicitly has an 'any' type.

3 export default defineEventHandler((event) => {
                                     ~~~~~

../nuxt-layer/server/api/foo.ts:5:10 - error TS2305: Module '"#imports"' has no exported member 'defineEventHandler'.

5 import { defineEventHandler } from '#imports'
           ~~~~~~~~~~~~~~~~~~

../nuxt-layer/server/api/foo.ts:7:36 - error TS7006: Parameter 'event' implicitly has an 'any' type.

7 export default defineEventHandler((event) => {
                                     ~~~~~

../nuxt-layer/server/utils/someUtil.ts:4:10 - error TS2724: '"#imports"' has no exported member named 'setCookie'. Did you mean 'useCookie'?

4 import { setCookie } from '#imports'
           ~~~~~~~~~

Found 5 errors in 3 files.

also, H3Event is not exported from #imports - I can only import it directly from h3

might help:

https://github.com/nuxt/cli/pull/264

at least I hope so :pray:

This is no longer reproducible for me with latest package versions in that repo (though I kept the override)...


/deep/ combinator is deprecated: refactor styles

needs research

I don't see anywhere we are using this directly? Seems like it will be solved by getting rid of Polymer? #222


Create index.md for Java Solution of Binary Search

Added Java Program and document for implementing Binary Search in java language
Thanks for helping us build up our knowledge base!
What kind of pull request hav you brought us today?
Pull Request Type

[x] Sample Program Documentation
[x] Language Documentation
[x] Project Documentation
[ ] Other (explain below)

Notes
Feel free to share any details you feel are relevant.

Updated PR https://github.com/TheRenegadeCoder/sample-programs-website/pull/481


Scaling Error when training using different ratio size of image in batch_size > 1

Error in Trainer.train()
RuntimeError: stack expects each tensor to be equal size, but got [3, 200, 257] at entry 0 and [3, 200, 341] at entry 2
When using set of image that contain different kind of ratio (for example 4:3 with 16:9).
Running in batch_size = 1 is fine. But larger than that, make this error.
Sorry for troubling you haha.
It's not really a bug I guess, I can solve it by resizing the train image myself, just letting you know if you want to fix it.

Oh... I guess the rescale function is not working perfectly... I will fix it.
Thank you for letting me know.
Anyway, you used image size(200, 200) using PSPnet. I don't know your dataset, but PSPnet needs a bigger size than other networks because the network has a pyramid structure. There is some chance to vanish features. If you don't know about that, test it :)

By the way, you used image size(200, 200) using PSPnet. I don't know your dataset, but PSPnet needs a bigger size than other networks because the network has a pyramid structure.

Ah thank you! I guess that's why it's not working well in some of my cases with small pixel label (ie. detecting crack), but doing well in some case with large label area (road, house, etc).
I was just using the default param (scale width to 200). How about the FCN and UNET? Got another tips?

Well, FCN is a simple network and requires lower GPU resources than other networks. You can use this network when you have not good enough hardware like a mobile phone.
UNet is focused on finding a small feature so, this model often uses in the medical image like a cells image.
So.. here are my advice.

If you want to label large and small areas, consider using PSPnet.(recommend having upper (500x500) size)
If you want to label small and detail, consider using UNet.
If you want light results, consider using FCN. But it has not high accuracy.
The input size is important. You should think about what you want to label the smallest area. And then, change sizes and test training.

I hope it will help you.
Thanks.


Configure with local LLM?

Is it possible to configure with local llm - i.e.: Ollama or LlamaCpp servers?
Some code cannot be sent to open apis.
Thanks

yes it is.  Please check out our wiki


.sass files not supported

Hi,
I'm using nativescript-dev-sass in a project using Angular and Nativescript but i'm using .sass files and not .scss files, could it be supported?
Thanks

Definitely could be.
There are a handful of places in the converter.js and after-prepare.js files where this pattern is used to find files that will be parsed: app/**/*.scss
To extend support for *.sass, this pattern just needs to be updated. Don't have time directly to test, but if you want to test a patch and submit a PR, I'll happily merge!

This will be supported in the next release (1.0.0). Available today as an RC release on NPM.
Support added with PR from @PeterStaev (#22)


Backport: HBASE-24256 When fixOverlap hits the max region limit, it is possible…

… to include the same region in multiple merge request (#1584)
Signed-off-by: stack<EMAIL_ADDRESS>

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 45s
branch-2 passed

+1 :green_heart:
checkstyle
1m  7s
branch-2 passed

+1 :green_heart:
spotbugs
2m  1s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 17s
the patch passed

+1 :green_heart:
checkstyle
1m  5s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 17s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

37m  0s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1694/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1694

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux d2458d0de1b8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / cf786a2dfb

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1694/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 45s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 16s
branch-2 passed

+1 :green_heart:
compile
1m  5s
branch-2 passed

+1 :green_heart:
shadedjars
5m 38s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 43s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  2s
the patch passed

+1 :green_heart:
compile
1m  3s
the patch passed

+1 :green_heart:
javac
1m  3s
the patch passed

+1 :green_heart:
shadedjars
5m 29s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
121m 30s
hbase-server in the patch passed.

147m 28s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1694/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1694

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8d980bee6dac 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / cf786a2dfb

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1694/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1694/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1694/1/testReport/

Max. process+thread count
4527 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1694/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 45s
branch-2 passed

+1 :green_heart:
compile
0m 56s
branch-2 passed

+1 :green_heart:
shadedjars
4m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 18s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
4m 30s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
130m 19s
hbase-server in the patch passed.

152m 30s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1694/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1694

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5b21d051b805 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / cf786a2dfb

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1694/1/testReport/

Max. process+thread count
4421 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1694/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Add Bkool.com as hard

Added another service with hard to delete account.

Thanks for your contribution!


Types aren't generated for +page.server.ts unless there is a corresponding +page.svelte

Describe the bug
I have a route that I don't need any component rendered for. I just need to do some work in the load function of a +page.server.ts file and then return a redirect (or throw error for +error.svelte to catch). This currently works but I ran into a small bug. If I don't have an empty +page.svelte file in addition to my +page.server.ts file, no types are generated in .svelte-kit/types/src/routes folder. I therefore can't import type { PageServerLoad } from './$types';
I tried using a +server.ts file for this but the functionality recently changed to not allow +error.svelte to catch thrown errors from a +server.ts files. See issue https://github.com/sveltejs/kit/issues/5993 and PR https://github.com/sveltejs/kit/pull/6028
+page.server.ts
import { error, redirect } from '@sveltejs/kit';
import type { PageServerLoad } from './$types';

const shortcodes: { [index: string]: string } = {
	microsoft: 'https://www.microsoft.com',
	google: 'https://www.google.com'
};

export const load: PageServerLoad = ({ params }) => {
	if (!params.shortcode || !shortcodes[params.shortcode]) {
		throw error(404, 'Shortcode not found');
	}

	return redirect(301, shortcodes[params.shortcode]);
};

Reproduction
Create a +page.server.ts file without a +page.svelte file. Check if any types were generated by npm run dev in .svelte-kit/types/src/routes
Logs
No response
System Info
System:
    OS: macOS 12.5
    CPU: (10) arm64 Apple M1 Max
    Memory: 5.49 GB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.7.0 - /opt/homebrew/bin/node
    npm: 8.16.0 - /opt/homebrew/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 104.0.5112.79
    Firefox Developer Edition: 104.0
    Safari: 15.6
    Safari Technology Preview: 16.0
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.64
    @sveltejs/kit: next => 1.0.0-next.417
    svelte: ^3.44.0 => 3.49.0
    vite: ^3.0.0 => 3.0.8

Severity
annoyance
Additional Information
No response

Could you be using a +layout.svelte page instead?


fix travis builds

Thanks for the PR, but the real issue is that the version of mocha is wrong. Will you update this to just change the version of mocha to 3.5.3, change the engine back to 0.10.0 and add node 0.10 and 0.12 back to the build matrix?
Newer versions of mocha use dependencies that require higher versions of node, so we can't use those to test code that's compatible with older versions of node.
Thanks!

add node 0.10 and 0.12 back to the build matrix?

Not build matrix, just the node_js property.


fitToBounds

hi, I get an array of some LAT and LNG from my API to show on the map. but can't show all of the markers. in reactjs I use fitToBounds  to show all markers in the first look. how to this in react native and with this library?

There are some fitTo* methods you could try, please check the docs


Allow clearing history + Use type name when object name doesn't exist

Couple features I added to my local copy that I figured I'd contribute back to you!

Clear History on right-click menu

Show type name when object name doesn't exist, in the form of "Unnamed [Type]"

Thanks! I'll merge this in.


Add support for Path and Method based Rate Limiting when using an OpenShift route

When wiring up RateLimiting for a route, by default if we generate the VirtualService the rate limiting service would be called for all request to that host and so per path and method RL would have to be done in Limitador directly.

Duplicated of #107 ?


Fix - bank account user goes to connect manually flow after start over offline

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/18518
PROPOSAL: https://github.com/Expensify/App/issues/18518#issuecomment-1550178895
Tests

Open App, create/open workspace and start to add bank account in workspace
Exit in the middle of the flow (after page 'Company Information' or 'Personal Information')
Return to the flow again > Settings > Workspaces > Connect bank account
Go offline
Select Start Over on the page 'Almost done!'
User gets page 'You appear to be offline'
Go Online
Verify that the screen remains on Connect online with Plaid and Connect manually options screen and doesn't go to connect manually screen

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as "Tests" Section above.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/39636266/bae45a41-a04a-4370-954a-8cdba1962a9f

Mobile Web - Chrome
https://github.com/Expensify/App/assets/39636266/78e75cd8-148c-4752-8fa4-da7168f499c0

Mobile Web - Safari
Screencast-mweb-safari.webm

Desktop
https://github.com/Expensify/App/assets/39636266/a147192e-1fad-4694-9b45-0aba7490c04a

iOS
https://github.com/Expensify/App/assets/39636266/80b45d2a-9265-4830-84b4-c6c022c62ff2

Android
https://github.com/Expensify/App/assets/39636266/a1f4c540-5a53-4809-bc3c-3a47b0b5ec2d

@mananjadhav can you fill out the checklist please? Just wanna make sure 😁

@flodnv Just working on the testing.

@HezekielT I see that you've posted Android screencasts for Mobile Web Safari and iOS. Can you please correct them?

@HezekielT I see that you've posted Android screencasts for Mobile Web Safari and iOS. Can you please correct them?

@HezekielT Quick bump on the previous comment.

Okay thanks for the clarification @HezekielT. I think we can use my screencasts as reference to go forward. Two things:

Please remove the non-relevant screencasts, to avoid confusion. You can probably write a comment Asked C+ to upload or just keep it blank.
Please read through out guidelines for testing on all platforms.

@flodnv Can we please approve and merge this PR taking my screencasts for QA?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.20-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.20-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Request: Add npm support

Providing an npm package would be nice :)

We use a package we created called promulgate to release new versions of the CLI: https://github.com/manifoldco/promulgate
I think it would make sense to add NPM distribution support there, when this gets picked up.


1.3 release - porting 1.x to 1.3

Description
Porting changes from 1.x to 1.3.
Issues Resolved
https://github.com/opensearch-project/alerting-dashboards-plugin/issues/179
Check List

[x] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #193 (cf19c7d) into 1.3 (b25d322) will decrease coverage by 0.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              1.3     #193      +/-   ##
==========================================
- Coverage   57.52%   56.79%   -0.74%
==========================================
  Files         195      198       +3
  Lines        4490     4756     +266
  Branches      599      651      +52
==========================================
+ Hits         2583     2701     +118
- Misses       1905     2053     +148
  Partials        2        2

Impacted Files
Coverage Δ

...eMonitor/containers/DefineMonitor/DefineMonitor.js
70.61% <0.00%> (-16.72%)
:arrow_down:

...omponents/TriggerEmptyPrompt/TriggerEmptyPrompt.js
50.00% <0.00%> (-16.67%)
:arrow_down:

...mponents/MonitorOverview/utils/getOverviewStats.js
60.00% <0.00%> (-15.00%)
:arrow_down:

...lic/pages/Monitors/containers/Monitors/Monitors.js
89.59% <0.00%> (-4.78%)
:arrow_down:

...reateMonitor/components/MonitorType/MonitorType.js
35.00% <0.00%> (-2.50%)
:arrow_down:

...onitor/containers/MonitorDetails/MonitorDetails.js
18.18% <0.00%> (-1.82%)
:arrow_down:

...eTrigger/containers/DefineTrigger/DefineTrigger.js
14.92% <0.00%> (-1.75%)
:arrow_down:

...erting-dashboards-plugin/public/utils/constants.js
100.00% <0.00%> (ø)

...ateTrigger/components/TriggerQuery/TriggerQuery.js
72.00% <0.00%> (ø)

...eMonitor/containers/CreateMonitor/CreateMonitor.js
58.33% <0.00%> (ø)

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25d322...cf19c7d. Read the comment docs.


Working on supporting low prices

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 28.972%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
888

Relevant Lines:
3065

💛  - Coveralls


pnp/sp PeoplePicker

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!
Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.
Category
[ ] Enhancement
[ ] Bug
[x ] Question
2.4.0 Version
Please specify what version of the library you are using: [   2.4.0      ]
If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.
Hello!
I have question about pnp/sp PeoplePicker.
PeoplePicker has property "required", but wen i use it in my form it is ignored.
This is my PeoplePicker code:
<PeoplePicker
required={true}
context={this.props.spContext}
personSelectionLimit={1}
onChange={this.hcRequestorPP}
showHiddenInUI={false}
principalTypes={[PrincipalType.User]}
ensureUser={true}
resolveDelay={1000}
defaultSelectedUsers={this.props.pRequestor}
disabled={false}
                                    />

What am i doing wrong?
Thank you, Matjaz Reberc
Thanks!

Hello @matjazreberc,
The required flag, similarly to Fluent UI components, just specifies if the control renders with * in the label. It doesn't activate any validation or "blocking" of external form.
You should handle onChange event and implement the logic to disable the "Submit" button of your form if needed.
You can additionally use errorMessage or onGetErrorMessage props to provide error message for the situation when the picker is empty.

Hello AJIXuMuK , thank you for you anwser. I find this "required" little confusing. Thank you, Matjaz


AmplitudeEstimator/Amplifier minor refactoring and docs.

Summary
qiskit.algorithms.amplitude_estimators.AmplitudeEstimator now inherits from ABC.
qiskit.algorithms.amplitude_amplifiers.AmplitudeAmplifier is now included in qiskit/algorithms/__init__.py file.
Closes: #7751

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 83.453%

Totals

Change from base Build<PHONE_NUMBER>:
0.005%

Covered Lines:
52354

Relevant Lines:
62735

💛  - Coveralls


feat: update security part

更新安全相关部分，添加Misc入门材料，以及修正一些错别字、语序错误和文章序号。

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


WP hooks callback issues

The check for type declarations has an handy exceptions that don't require type declaration when the callback is used for a WordPress hook.
It works when a closure is directly added to an hook, e.g.:
add_action('init', function () { /* ... */ });

or when the @wp-hook annotation is used:
/**
 * @wp-hook init
 */
function fooBar() { /* ... */ }

However, there are two issues currently:

Closures are not recognized when they are static
Class methods are not recognized if not public

Regarding second point, it is true that only public methods can be used directly in a hook, but it is quite common to have a closure that acts as a proxy to a private method, something like:
add_action('init', function ($args) { $this->doSomething($args) });

This allows to use separate methods, without exposing them as public. However, in the example above the closure will not be required to have type, but the doSomething method will be required, even if the  @wp-hook annotation is used, so only chance is to either make it public (at that point having the closure does not make sense anymore) or manually excluding the type declaration check.

Fixed in 52edc0b


Provide an option to use { require: true } as default in model.fetch

In my current usage, I find myself adding { require: true } to most (if not all) fetch calls. I would like to have the option to specify this as a default, and optionally disable it by passing { require: false }.
I can submit a pull request if you are interested in this and we agree on an API.

So I'm considering making this the default, but I'm also looking at creating an API which will allow for partial application of things like options for cases like this.
Will let you know what I come up with.

Great, thanks! Let me know if you need any feedback or help.

Any updates on this?

I'm planning to follow through with Tim's decision and making this the default, but for all types of fetch calls.


add upgrade pandas warning

Unfortunately I don't know what this means anymore.  I will re-open if it comes back up.


refactor: separate rust API from wasm API

I find it much cleaner to use a cargo workspace, then keep all the Wasm code in a separate local crate that only gets used for publishing to deno.land/x.
Closes #33

How can I help get this marshalled through review? 😄

@ProofOfKeags thanks! I opened #37
By the way, it's best to open issues since this is an already resolved/closed PR and comments could be more easily unnoticed.


Failed to activate the atom-alignment package

[Enter steps to reproduce below:]

...
...

Atom Version: 1.2.0
System: Mac OS X 10.10.5
Thrown From: Atom Core
Stack Trace
Failed to activate the atom-alignment package
At Cannot read property 'command' of undefined

TypeError: Cannot read property 'command' of undefined
    at Object.module.exports.activate (<anonymous>:10:27)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:170:19)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:150:32
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:92:15)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:143:26
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:140:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:512:21)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:495:29
    at Config.module.exports.Config.transact (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:311:16)
    at PackageManager.module.exports.PackageManager.activatePackages (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:490:19)

Commands

Config
{
  "core": {
    "themes": [
      "atom-dark-ui",
      "seti-syntax"
    ]
  },
  "editor": {
    "invisibles": {},
    "fontSize": 13
  }
}

Installed Packages
# User
angularjs, v0.0.5
atom-alignment, v0.9.3
autocomplete, v0.29.0
language-javascript, v0.39.0
linter-jshint, v0.0.18
seti-syntax, v0.1.7

# Dev
No dev packages

Please update all your packages - they are extremely out of date.
In addition, please uninstall language-javascript as that comes bundled with Atom (and in fact, you're more than 61 versions behind on that one).


Update resource-limits-vcore-elastic-pools.md

Added information about general purpose multi-az public preview

@emlisa : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@emlisa: I'm sorry - only the author of this article, @oslake, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

Hi @emlisa - This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. Would you make this content update in the private repo instead? Thank you! We'll close this PR.


Use Deleter for cleaning up leftover files from failed unpack

We are cleaning up the output directories of a task after a failed attempt to load from the cache. Currently, we are using FileUtils to do the cleanup. It may be better to use Deleter, so the error messages when failing to delete the unpacked files would be better.
See https://github.com/gradle/gradle/pull/8783#discussion_r266046836

We should not try to recover from a failed unpack at all. We'll change this in 6.0.


[PORT] move base interface schema files to declarative assembly

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/3808

Changed projects

Microsoft.Bot.Builder.Dialogs.Declarative

We don't have schema files in JS, closing this issue.


feature: Added support for oracle batch insert, update and delete

feature:  Added support for oracle batch insert, update and delete .(The field type cannot grow automatically)

增加oracle 支持:
------------批量更新-----------
//orale 必须加begin    end;
1.begin   UPDATE DRUG_LOGS SET type = ?, CONTENT = ? where id = ? ;   UPDATE DRUG_LOGS SET type = ?, CONTENT = ? where id = ?; end;
----------批量插入 ----------
//批量插入 （主键不能是自动增长类型，主键值由业务自己设置.  因为INSERT INTO SELECT语句不支持RETURNING语句）
1.INSERT into DRUG_LOGS(id,type,CONTENT) select ？,2,3 from dual UNION select 43,24,34 from dual
//批量插入 （主键不能是自动增长类型，主键值由业务自己设置.  因为INSERT INTO SELECT语句不支持RETURNING语句）
2.INSERT into DRUG_LOGS(id,type,CONTENT)
select * from (
select ? a,4 b,3 c from dual
UNION select 13 a,8 b,9 c from dual
)
//批量插入 （主键不能是自动增长类型，主键值由业务自己设置.  因为INSERT ALL INTO 语句不支持RETURNING语句）
//这种sql是mybatis 批量插入的实现方式
3.INSERT ALL
INTO mytable (column1, column2, column_n) VALUES (expr1, expr2, expr_n)
INTO mytable (column1, column2, column_n) VALUES (expr1, expr2, expr_n)
INTO mytable (column1, column2, column_n) VALUES (expr1, expr2, expr_n)
SELECT * FROM dual;
----------批量删除--------
1.批量删除
begin   delete from DRUG_LOGS  where id = ? ;  delete from DRUG_LOGS  where id = ?; end;
二。不支持sql（oracle）
1.MERGE  into

基于1.3.0版本。包含自定的功能，比如数据变化的前后镜像保存等，这些和sql支持的没关系。

基于1.3.0版本。包含自定的功能，比如数据变化的前后镜像保存等，这些和sql支持的没关系。

感谢你的pr贡献,请基于develop分支进行开发,并解决冲突

基于1.3.0版本。包含自定的功能，比如数据变化的前后镜像保存等，这些和sql支持的没关系。

感谢你的pr贡献,请基于develop分支进行开发,并解决冲突,并在标题前加上feature: 开头,标题以pr实现简单介绍

@15168326318 Can you handle code conflicts?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.ccg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.ccg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Due to code conflicts and age, if you are still interested in participating in the community, please resubmit this pr to the 2.x branch after resolving the conflict.
由于代码冲突以及年代久远，如果你还有兴趣参与到社区，请解决完冲突后重新请提交这份pr至2.x分支中


Runepouch plugin

Runepouch plugin with rune images/amounts. I feel like my implementation of the cache is redundant; let me know. The old method was the same as what is still used by the fishing plugin. Please review and critique anything! I'm looking for feedback. Thanks!

Thanks


Clean up CSS

Organize SCSS
Use a tool like PurgeCSS

Watched Using PurgeCSS with Hugo - Christian Oliff // HugoConf 2022. The config example is outdated but was a nice intro.
Follow PurgeCSS Hugo guide and check the config docs.

Tried methods described in this forum post and this blog post but no luck. 😵💫 Giving up on that for now.
Anyways...
I was wondering why there were duplicate font-face rules! Just needed to change the structure of my sass files -> d737ec8


Swapping Items Deletes them

in the current release version 1.5.0 if I swap an item from the inventory to my hotbar, any item that was in that hotbar slot disappears.
Setup:
Minecraft 1.18.1, Fabric 0.12.2, Fabric API 0.44.0, Carpet Mod 1.4.56, Carpet fixes 1.5.0+v211215
Edit: Same with a fresh Instance. Newly created world, survival mode

No rules enabled? Alright, ill look into it. Thanks

You are right, seems the reIntroduceItemShadowing rule was redirecting without adding back the vanilla behavior. I am changing its implementation and should be releasing a v1.5.1 later today. Thanks

Sorry for the bad news XD, thanks for the great mod!

Alright, it's now in v1.5.1!


./gradlew refreshVersions --cleanup

Remove the comments from versions.properties

Don't you think that a refreshVersionsCleanup dedicated task would make more sense?
First the refreshVersions task would not do something completely different because of an option.
Second, it'd better surface in the IDE.
Third, no risk of the option being added and not being removed in the run configuration, leading to user confusion when you they actually want to refresh the versions.

I created a group "refreshVersions" for our tasks, we already have 6 of them and there are more coming


Styles not being applied correctly

Brand new to React and React-toolbox.  I am trying to get the simplest version of the demo of the dropdown to work, but the styles aren't being loaded.  A "class" attribute is being applied, but it has no value.  I'm guessing it's something I'm missing in my webpack setup which I've supplied at the bottom.

Result:

Try enabling modules for the css loader and see if that helps:
{ test: /\.scss?$/, loaders: [ 'style', 'css?modules', 'sass' ] },

https://github.com/webpack/css-loader#css-modules

Thanks for the reply.  Unfortunately it didn't change anything.

Hey @aubford ! The problem is that your styles are not being loaded probably because of your webpack configuration. The weird thing is that you are not getting require errors but of course it is not getting any styles since the class attribute is empty. Please give a try to the react-toolbox-example repository. It has a working configuration for webpack.


[WIP - discussion] - Alternate Method of Seq.map chaining

@forki
Hey, this is an example of the method I suggested for Seq.map chaining in #1525. I believe it could be safer than an expression optimizer. That said, I don't think this method has a very wide range of applicable situations. And although this method makes chaining Seq.map a decent amount faster for 64-bit (40% when just chaining the id function 4 times), it comes at the cost of more allocations; it also appears to do very little for 32-bit.
Chained with Cast = Map int->double->int->string->double->int
Chained = Map id 4 times
Double = Map id twice
Single = Map id once
           Method | Platform |       Jit | count |        Median |      StdDev |    Gen 0 | Gen 1 | Gen 2 | Bytes Allocated/Op |

--------------------- |--------- |---------- |------ |-------------- |------------ |--------- |------ |------ |------------------- |
newMapChainedWithCast |      X64 |    RyuJit |    10 | 2,681.3056 ns |  54.0795 ns | 1,689.20 |     - |     - |             860.49 |
oldMapChainedWithCast |      X64 |    RyuJit |    10 | 3,162.8985 ns |  99.1808 ns | 1,460.50 |     - |     - |             759.68 |
newMapChained |      X64 |    RyuJit |    10 |   999.2051 ns |  21.7923 ns |   950.20 |     - |     - |             480.46 |
oldMapChained |      X64 |    RyuJit |    10 | 1,602.6801 ns |  62.1952 ns |   876.30 |     - |     - |             444.90 |
newMapDouble |      X64 |    RyuJit |    10 |   672.5340 ns |  11.1336 ns |   591.66 |     - |     - |             303.59 |
oldMapDouble |      X64 |    RyuJit |    10 |   829.7948 ns |  25.4848 ns |   573.53 |     - |     - |             291.14 |
newMapSingle |      X64 |    RyuJit |    10 |   512.7723 ns |  18.6634 ns |   434.50 |     - |     - |             224.26 |
oldMapSingle |      X64 |    RyuJit |    10 |   517.8100 ns |  17.3567 ns |   434.09 |     - |     - |             224.05 |
newMapChainedAndCast |      X86 | LegacyJit |    10 | 4,556.4599 ns |  98.8518 ns |   896.00 |     - |     - |             464.44 |
oldMapChainedAndCast |      X86 | LegacyJit |    10 | 4,590.3545 ns | 132.2131 ns |   796.46 |     - |     - |             413.15 |
newMapChained |      X86 | LegacyJit |    10 | 1,800.9681 ns |  55.1074 ns |   516.93 |     - |     - |             270.98 |
oldMapChained |      X86 | LegacyJit |    10 | 1,988.7315 ns |  54.5289 ns |   496.59 |     - |     - |             253.48 |
newMapDouble |      X86 | LegacyJit |    10 | 1,133.6465 ns |  29.1723 ns |   364.62 |     - |     - |             190.35 |
oldMapDouble |      X86 | LegacyJit |    10 | 1,135.3443 ns |  40.1621 ns |   365.74 |     - |     - |             191.04 |
newMapSingle |      X86 | LegacyJit |    10 |   714.6264 ns |  19.5114 ns |   299.75 |     - |     - |             151.89 |
oldMapSingle |      X86 | LegacyJit |    10 |   720.0241 ns | 154.7598 ns |   302.13 |     - |     - |             153.09 |

I approve of your detailed measurements.... used any tool for that?

@mrange I used BenchmarkDotNet. Here is an example of a script that uses it: https://gist.github.com/liboz/c9e529d0292f25135243721157b93fae

@liboz should probably just close this given #1570?


[UI] [Advanced] Karaf console authentication is different and preserved across SS authentications.

For replay this bug you need:
Test case

Go to SS and login under any account.
Go to "System Settings"->"Advanced"->"Console" page.

Result: When landing for the first time there the user is presented with a HTTP domain based authentication window:

This authentication method needs to go away. The user authenticating into SS and having the permissions to access this console should be enough. The authentication not be integrated with SS security is creating issues for us like:

usability with a second log in when not required
when you log back out and log back in as another user it still seems to be available (security issue here)

related issue: https://github.com/subutai-io/base/issues/187

Fixed


Document PDM support

Why is the change needed?
Creosote supports PDM now, but this isn't documented.
What was done in this PR?
Documented PDM support.
Are there any concerns, side-effects, additional notes?
No.
Checklist, when applicable

~[ ] Added test(s)~
[x] Updated README.md
~[ ] Is this a backwards-compatibility breaking change?~
~[ ] Resolves: #issue-number-here~

Someplace else you commented that your wanted to keep PEP-621 support as the first row of the table. That would break alphabetical sorting though. Moreover, the PEP-621 support still stands out at first glance, since it is still quite at the top and the table and whole README is pretty brief. And to be honest, I expect your target audience to be more familiar with their favorite tools than with Python standards.

@fredrikaverpil
The test failures are related to your source code. Can you make Ruff only run on changed files?

I'm sorry about the failure as it is, like you say, unrelated to your PR. The problem has been fixed in #158 but there is an underlying problem I'll think about where I haven't pinned any of the static type checkers and I haven't limited the set of rules to check for.

you commented that your wanted to keep PEP-621 support as the first row of the table. That would break alphabetical sorting though.

There's another PEP in that list so this alphabetical order is already broken. I might revise this order later.
By the way, did you know PEP-582 was rejected?
Thanks for your contribution! 🎉

By the way, did you know PEP-582 was rejected?

Yes, but in case you think so, PDM doesn't depend on that. 🙂

Yeah, it's optional with pdm, right?
I haven't used pdm really. Just tried it out some time ago.


10.14 MacOS Mojave Home folders on NAS - broken but Sierra works fine

High, bit of an odd one here.
I have relocated the Mac users home folders to an NFS share which has been working for ages. Have upgraded to Mojave (forced by app updates) and the Sierra clients, configured in the same way, work fine and create homes etc.
The Mojave clients when logging in get the attached message. Really cannot see why this could be. Any ideas anyone please.
thanks Duncan

We are currently investigating.

Thanks, this is using PBIS as the authentication source as per my previous post.

Mojava - and now Catalina - is making changes that break this functionality. We are aware of these issues but they are low on the backlog. If we address this, it will be noted in the changelog. For know I'll be making as won't fix.


Change arrow functions into purecomponents

Arrow functions are not Pure and were updating at every form change. See #1967.
At this point, there are still some unwanted updates, but i think these are from formsy-react-components, so there is not much we can do about it unless getting rid of Formsy.

Don't merge this until i have added the commits that remove formsy from input components

Edit: @SachaG I'm sorry but i don't have time currently to do the whole switch and rewrite all the components from scratch.
Also it seems that 94fc8fffe9ea848c5d3099da93ba0da2172a445e broke error handling at the field level. The field does not pass in error mode, the error text is not displayed and instead the whole form is disabled

Should I still merge this or not then?

you can, it saves the updates on the components in ui-bootstrap/Form, but they have to be rewritten from scratch to get rid of Formsy.
i made the default input like this:
import React from 'react';
import { registerComponent } from 'meteor/vulcan:core';

class Default extends React.PureComponent {
  handleChange(event) {
    this.props.inputProperties.onChange(
      this.props.inputProperties.name,
      event.target.value
    );
  }

  render() {
    const { refFunction, inputProperties, ...properties } = this.props;
    return (

          {inputProperties.label}

          <input
            name={inputProperties.name}
            id={this.props.path}
            className="form-control"
            value={inputProperties.value}
            onChange={this.handleChange.bind(this)}
          />

    );
  }
}

it's pure bootstrap html, i did not use react bootstrap because i couldn't reproduce easily the actual horizontal layout. This code works on regular fields but not in nested fields. FormNested must change the scope or something and the value is not updated.

Maybe I'll wait a bit to merge to devel then. I would like to get the UI stuff out first before taking on the performance issues.