feat: add support for eslint overrides

This PR adds support to override eslint config with a .eslintrc.* file or an eslintConfig field in a package.json file.
Basically using configFile with useEslintrc: true doesn't work because configFile takes precedence over anything coming from the current repo.
/cc @PedroMiguelSS, @diasdavid

Hm, the point of having linting in aegir and all projects using aegir is that we get linting that is consistent across all repositories. What's the use case of being able to override the rules?

https://github.com/ipfs/js.ipfs.io needs stuff like this :
{
    "parser": "babel-eslint",
    "plugins": ["import", "react"],
    "parserOptions": {
        "ecmaVersion": 8,
        "sourceType": "module",
        "ecmaFeatures": {
            "jsx": true,
             "experimentalObjectRestSpread": true
        }
    },
    "extends": [
        "eslint-config-aegir"
    ],
    "rules": {
        "import/first": "error",
        "import/no-amd": "error",
        "import/no-webpack-loader-syntax": "error",

        "react/forbid-foreign-prop-types": ["warn", { "allowInPropTypes": true }],
        "react/jsx-no-comment-textnodes": "warn",
        "react/jsx-no-duplicate-props": ["warn", { "ignoreCase": true }],
        "react/jsx-no-target-blank": "warn",
        "react/jsx-no-undef": "error",
        "react/jsx-pascal-case": [
          "warn",
          {
            "allowAllCaps": true,
            "ignore": []
          }
        ],
        "react/jsx-uses-react": "warn",
        "react/jsx-uses-vars": "warn",
        "react/no-danger-with-children": "warn",
        "react/no-deprecated": "warn",
        "react/no-direct-mutation-state": "warn",
        "react/no-is-mounted": "warn",
        "react/react-in-jsx-scope": "error",
        "react/require-render-return": "error",
        "react/style-prop-object": "warn"
    }
}

Basically modules, jsx, react stuff etc.

Would it make sense to have pre-defined configs for react, modules etc. which could then be added to aegir with extends or something similar? This would prevent having real custom rules on repositories. But you would get a common set of rules for all similar projects.

yes i agree but we still need a way to extend in the repo

@vmx yeah, we could probably have a --eslintrc=react flag to configure other configs, but I think those configs would have to live here in aegir rather than in the individual repos. Then they should be shared across all react repos.

@VictorBjelkholm Yes, they should surely be in the AEgir repo.

Can we merge this ?


feat: implement ERC721Mintable and ERC721Burnable

Fixes #1273
🚀 Description
I had to refactor the accounts management for the erc721 tests because they weren't consistent enough to test mintable behavior.

[x] 📘 I've reviewed the OpenZeppelin Contributor Guidelines
[x] ✅ I've added tests where applicable to test my new functionality.
[x] 📖 I've made sure that my contracts are well-documented.
[x] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

need to add more mintable tests, whoops

@nventuro my editor had prettier installed and it wrecked havok on the formatting 😢I'm not sure if there's an easy way for me to revert those changes, since they pass the eslint rules.

@shrugs I'm going to move a few things around to try simplify this PR. (Sorry for jumping in, I'd like to merge this today.)

Hi, I try the new ERC721Mintable contract.
ERC721Mintable is a ERC721Full. ERC721Full has this constructor args : string name, string symbol. To set name and symbol when you extend the ERC721Mintable, constructor(string name, string symbol) must be added? Is missing in the ERC721Mintable contract, what do you think?

@branciard check out the mocks for an example of how to use it. In solidity you can initialize a contract via multiple constructors (this is how the Crowdsales are architected, for instance).
https://github.com/OpenZeppelin/openzeppelin-solidity/blob/master/contracts/mocks/ERC721MintableBurnableImpl.sol
also, check out our slack channel https://slack.openzeppelin.org/ for debugging help


Disable utilization of resource_types cache when cache_classes is false

Though this forces recreation of resources on each call to resource_for, this fixes Rails autoloading to actually reload Resource code while in development (previously @@resource_types held on to the stale version of the class from before the autoload).
A more efficient solution would only reinstantiate the resources after the Rails set_clear_dependencies_hook clears ActiveSupport::Dependencies, but would likely require more complex callback/finalizer code.

Fixed by the original retainer by a complete rewrite of the resource_for method.


Update networking.md

add the AWS NAT gateway corresponding service on Azure

@kobile70 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/MicrosoftDocs/azure-docs
Private repo URL: https://github.com/MicrosoftDocs/azure-docs-pr
We have closed this pull request. Please resubmit the updates through the private repo. For more information, [see the contributor guide].(https://docs.microsoft.com/en-us/contribute/)

#Sign-Off

@EdPrice-MSFT: I'm sorry - only the author of this article, @kobile70, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

Hi @EdPrice-MSFT - Metadata and article ownership should be changed only in the private repo, per the internal contributor guide. Could you go ahead and create a pull request in the private repo to make all the metadata changes you'd like to see in AAC articles?
We're not intended to merge PRs in the public repo in which contributors change article ownership. We'll merge this one because we can confirm the identity and Microsoft affiliation for the contributor.
Before we merge, could you verify that you want to change the metadata author attribute to kobile70? Thanks.
If article ownership is changed in this repo in other PRs, we'll back out those changes so you can make them in the private repo (to keep MicrosoftDocs owners content). Thanks much!

Sorry for all the overhead I’ve created, I can resubmit the changes using the private repo if that help
Best Regards, Kobi
Get Outlookhttps://aka.ms/qtex0l for iOS

From: Kristine Toliver @.>
Sent: Tuesday, July 27, 2021 7:41:23 PM
To: MicrosoftDocs/architecture-center @.>
Cc: Kobi Levi @.>; Mention @.>
Subject: Re: [MicrosoftDocs/architecture-center] Update networking.md (#2964)
Hi @EdPrice-MSFThttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FEdPrice-MSFT&data=04|01|kobilevi%40microsoft.com|903078789a734abe411808d9511d6ab7|72f988bf86f141af91ab2d7cd011db47|1|0|637630009279808162|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=nbsMECm67pwRivpfhQFFoEDJUoZ842zFP7yZ28NBjtM%3D&reserved=0 - Metadata and article ownership should be changed only in the private repo, per the internal contributor guide. Could you go ahead and create a pull request in the private repo to make all the metadata changes you'd like to see in AAC articles?
We're not intended to merge PRs in the public repo in which contributors change article ownership. We'll merge this one because we can confirm the identity and Microsoft affiliation for the contributor.
Before we merge, could you verify that you want to change the metadata author attribute to kobile70? Thanks.
If article ownership is changed in this repo in other PRs, we'll back out those changes so you can make them in the private repo (to keep MicrosoftDocs owners content). Thanks much!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Farchitecture-center%2Fpull%2F2964%23issuecomment-887665286&data=04|01|kobilevi%40microsoft.com|903078789a734abe411808d9511d6ab7|72f988bf86f141af91ab2d7cd011db47|1|0|637630009279818119|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=5nYZlKnu8jNUGOzmtgVTm6Dbftl02w5h3nIVv4RePIA%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOFXY6NZCAW7N7SOOGN75XTTZ3OTHANCNFSM5BAIGPBA&data=04|01|kobilevi%40microsoft.com|903078789a734abe411808d9511d6ab7|72f988bf86f141af91ab2d7cd011db47|1|0|637630009279818119|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=qngQUtn0QqP1HMrTWZklV%2FcprjCxAqZcjnkP%2B%2Fa%2FpmI%3D&reserved=0.

Hi @kobile70 I didn't notice that a commit was added to change article ownership. That type of metadata change should be done in the private repo, and not in the public repo. I'm checking with the lead PR reviewer and will come back to this PR shortly. Thanks :)

We'll sort it out; no worries.

@EdPrice-MSFT Hi - To update the article owner, the commit should be moved to the private repo and merged there. Let me know if you'd like the PR review team to help with this. Thanks.


Evaluation Error for 3DMatch

Dear  Chris,
When I finished training and tried to evaluate the result following your instruction. It gives an error on mean of empty slice.
Full Error Message:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
02/24 20:37:01 0.100000 0.050000
/disk_1/FCGF/scripts/benchmark_3dmatch.py:182: RuntimeWarning: Mean of empty slice.
logging.info("average : %.4f +- %.4f" % (scene_r.mean(), scene_r.std()))
/disk_1/anaconda3/envs/fcgf/lib/python3.7/site-packages/numpy/core/_methods.py:161: RuntimeWarning: invalid value encountered in double_scalars
ret = ret.dtype.type(ret / rcount)
/disk_1/anaconda3/envs/fcgf/lib/python3.7/site-packages/numpy/core/_methods.py:217: RuntimeWarning: Degrees of freedom <= 0 for slice
keepdims=keepdims)
/disk_1/anaconda3/envs/fcgf/lib/python3.7/site-packages/numpy/core/_methods.py:186: RuntimeWarning: invalid value encountered in true_divide
arrmean, rcount, out=arrmean, casting='unsafe', subok=False)
/disk_1/anaconda3/envs/fcgf/lib/python3.7/site-packages/numpy/core/_methods.py:209: RuntimeWarning: invalid value encountered in double_scalars
ret = ret.dtype.type(ret / rcount)
02/24 20:37:01 average : nan +- nan
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Command input for running:
python -m scripts.benchmark_3dmatch --source /disk_1/FCGF/3DMatch/threedmatch/ --target ./feature_tmp/ --voxel_size 0.025 --model /disk_1/FCGF/outputs/checkpoint.pth --do_generate --do_exp_feature --with_cuda
Do  you have any idea  on this error? Dataset  is downloaded through command:
./scripts/download_datasets.sh /path/to/dataset/download/dir
And training is perfectly fine.

It seems that the test failed due to 0 / 0 error which means, it did not find any dataset and the result was 0; thus 0 / 0 --> NaN error.
I pushed a new commit with more assertions. Please make sure that you don't get any assertion errors during the evaluation.

Dear Chris,
If I understand it correctly, I need to download test data from this link
https://github.com/andyzeng/3dmatch-toolbox#multi-frame-depth-tsdf-fusion
and follow the instruction in Geometric Registration Benchmark section. And then, run your script.benchmark_3dmatch.py.
Is this correct?

The evaluation files are located at http://3dmatch.cs.princeton.edu/#keypoint-matching-benchmark

Yes, it was my mistake. Thanks for reminding. However, in line 174 of  benchmark_3dmatch.py:
traj = read_trajectory()
I think its input should be xxxx_gt.log instead of empty, right?

Ah thanks for pointing this out. I made this commit in a hurry and just fixed it after reading your comment on https://github.com/chrischoy/FCGF/commit/9d909cdfcb1556a919901e5bdb76b10f5b35375b

Thank you very much Chris. Everything works now. So I am gonna close this issue


Video Tutorial Error with handleCellSelected() - [See updated code here]

In the video tutorial CellState.isSelected is properly used until code is refactored into helper functions. At that point Cell.isSelected is used. This worked for most months until I hit a month where it didn't.

can you let me know by joining me here -> https://gitter.im/patchthecode/JTAppleCalendar

There is an error in the handleCellTextColor function. Please replace it with the following code:
func handleCellTextColor(view: JTAppleCell?, cellState: CellState) {
}

@dmholmes hey, i am trying to remember for which month you were experiencing cell.isSelected failure at? In version 7.0.3 i made isSelected unavailable for the cell, but some users were using it it seems. So i want to look into the issue a bit deeper.

IIRC it wasn’t related to a specific month in particular.

On Jun 4, 2017, at 9:03 AM, JTAppleCalendar<EMAIL_ADDRESS>wrote:
@dmholmes https://github.com/dmholmes hey, i am trying to remember for which month you were experiencing cell.isSelected failure at? In version 7.0.3 i made isSelected unavailable for the cell, but some users were using it it seems. So i want to look into the issue a bit deeper.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/patchthecode/JTAppleCalendar/issues/409#issuecomment-306041957, or mute the thread https://github.com/notifications/unsubscribe-auth/AAATByb1QVhG_LkLEfPxDJ-4_ZGd54uEks5sArk3gaJpZM4NTNHf.

ok thanks. i'll look more into the problem on my end.

Same issue here sir.

after I update my code base on your given code. I still have the same exp

I think it happens when I select a date that is in the current view and the view when I scroll to left or right
Example:
I selected dec 1
and when i Scroll to the left
the cell I selected is still in that view
then if u select another cell. thats the error happens

what error happens?


Retinanet using C2 in Feature Pyramid

Can I use C2 output from backbone in feature pyramid model?
I'm trying to implement myself based on Fizyr implementation
backbone outputs from ResNet
["conv2_block3_out", "conv3_block4_out", "conv4_block6_out", "conv5_block3_out"]

c2_output, c3_output, c4_output, c5_output = self.backbone(images, training=training)
p2_output = self.conv_c2_1x1(c2_output)
p3_output = self.conv_c3_1x1(c3_output)
p4_output = self.conv_c4_1x1(c4_output)
p5_output = self.conv_c5_1x1(c5_output)
p2_output = p2_output + self.upsample_layer(p3_output)
p4_output = p4_output + self.upsample_layer(p5_output)
p3_output = p3_output + self.upsample_layer(p4_output)
p2_output = self.conv_c2_3x3(p2_output)
p3_output = self.conv_c3_3x3(p3_output)
p4_output = self.conv_c4_3x3(p4_output)
p5_output = self.conv_c5_3x3(p5_output)
p6_output = self.conv_c6_3x3(c5_output)
p7_output = self.conv_c7_3x3(tf.nn.relu(p6_output))
return p2_output, p3_output, p4_output, p5_output, p6_output, p7_output

But I get the Incompatible error when subtracting box regression: difference = y_true - y_pred
I think using more output of feature pyramid leads to more values of the output since these outputs are concatenated
        features = self.fpn(image, training=True)
        N = tf.shape(image)[0]
        cls_outputs = []
        box_outputs = []
        for feature in features:
            box_outputs.append(tf.reshape(self.box_head(feature), [N, -1, 4]))
            cls_outputs.append(
                tf.reshape(self.cls_head(feature), [N, -1, self.num_classes])
            )
        cls_outputs = tf.concat(cls_outputs, axis=1)
        box_outputs = tf.concat(box_outputs, axis=1)
        return tf.concat([box_outputs, cls_outputs], axis=-1)

You can use C2 features but you would have to add anchors for it as well, probably here https://github.com/keras-team/keras-io/blob/master/examples/vision/retinanet.py#L222-L223

You can use C2 features but you would have to add anchors for it as well, probably here https://github.com/keras-team/keras-io/blob/master/examples/vision/retinanet.py#L222-L223

Thank you for your fast reply. I will try it

Thank you for your fast reply. I will try it

@ptran1203 Hello, I am facing the same challenge and I did an implementation similar to the one you showed, same error. Were you able to use C2 in the FPN?

Looks like this is resolved. Closing.


reconsider form data specific RestClient:Post overload

The addition of this overload was driven by lack of a url encoding function other than curl_easy_escape. curl_easy_escape requires an easy handle which would break our encapsulation of libcurl in order to provide access to it prior to the Post method being called.
Rolling our own url encode/decode functions could obviate the need for this form specific overload.

Closing for now, if it becomes a problem we can reopen.


Using the 0.32 strimzi, using latest 3.3.1 apache kafka (#2822)

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>

/retest

OCF Webhook is merging this PR


migrate to 17.1 profiles

Current situation
On every emerge operation the following message is printed:
!!! Your current profile is deprecated and not supported anymore.
!!! Use eselect profile to update your profile.
!!! Please upgrade to the following profile if possible:

        default/linux/amd64/17.1/no-multilib/hardened

To upgrade do the following steps:

The amd64 17.1 profiles switch to a more standard 'no SYMLINK_LIB'
multilib layout, and require an explicit migration.
The migration is performed using the app-portage/unsymlink-lib tool.
The following steps can be used to upgrade your system:

Impact
Annoying and unsupported upstream.
Ideal future situation
flatcar profile upgraded to 17.1.
Additional information
The only real difference between 17.0 and 17.1 profiles is defaulting to "SYMLINK_LIB=no" (instead of "yes"), which affects whether lib is a symlink to lib64 or a proper directory. The arm64 profiles already use SYMLINK_LIB=no. There might be a couple spots in ebuilds and SDK thataccidentally rely on the symlink, but we can weed them out.

Problematic with stage1/stage2 bootstrap. If stage1 uses old ebuilds, then its built with old profile, and stage2 switches profile (fail); if stage1 uses new ebuilds it fails because old seed.
Also requires updating a bunch of docs that reference /usr/lib64 paths that might not be correct after profile update (/usr/lib/systemd as an example).

@krnowak can we close this, as we have migrated to 17.1?
ref: https://github.com/flatcar/coreos-overlay/pull/2502

Yes, it's done. I forgot that we had an issue about it filed.


fix issue 15940 - ImplicitConversionTargets and class alias in struct

LGTM

Are there any reasons, why this has never been merged?


[W6.4h][T09-B3] Koh Yee Ru

Implement a getPrintableString interface for Name, Phone, Email, and Address classes.

@iNekox3
Some comments added. Please close the PR after reading comments.


Valid NAME records rejected

Reported via SourceForge: https://sourceforge.net/p/lifelines/bugs/268/
1 NAME Elijah /Hamblin/ and nine others are claimed "Bad NAME syntax" (out of thousands of others in the same format). Since the NAME lines can be edited, "Bad NAME syntax" should not be a fatal error but a warning. Load the file and if there is an actual error (these are not), the user can then correct them.

Thanks for migrating this.  Maybe if someone is able, the other site should be "locked" from any more submissions.  I'm sure there are many sites with sourceforge links beside the one that sent me there.

Unfortunately the people with access to the project pages have been unreachable so I haven't been able to close things off as nice as I'd have liked.


val_loss can not decrease

I faced some problem when I trained. At the beginning, both the loss and val_loss decreased step by step, but then only loss decreased val_loss frozen between 24 and 25. My trained data is 1922 and my tested data for evaluate is 213, their ratio is 9(9:1), I have no idea if it is enough for training, and I have no idea if it is the reason cause the problem.

Does anyone have the same problem?


Rename commands in Run/Debug button

Closes #17019

Seems like this has already been taken care of: https://github.com/microsoft/vscode-python/pull/17592. Closing this.

@karrtikr sorry, I instructed her to send this PR because we in the previous PR the python.command.python.execInTerminal.title was updated when we wanted to only update the one used in the Icon 😅 I can create a separate issue if that would be better

Oh I see.
@analiabs Can you please rebase this PR off OSD branch? As that has already accepted a similar contribution, there're some merge conflicts.


Not sure if Cloud Run uses Let's Encrypt to provision a certificate

https://github.com/ahmetb/cloud-run-faq#user-content-does-cloud-run-offer-ssltls-certificates-https:~:text=If you’re using your own custom,get a certificate for your domains.
My last Cloud Run project seems to have had its certificate issued by Google Trust Services and not out of the Let's Encrypt infrastructure:
https://github-wiki-see.mindflakes.com/

ack that changed at some point.


Update ocis-reva 2020-09-10

ocis-reva v0.13.1-0.20200910085648-26465bbdcf46
fixes file operations for received shares by changing OC storage default config
adds ability to overwrite storage registry rules

Closes https://github.com/owncloud/product/issues/193
Closes https://github.com/owncloud/product/issues/205

adjusted test expectations


GH36: Add page for getting started with cake recipe.

Possibly related to https://github.com/cake-contrib/Cake.Recipe/issues/36
Written as a quickstart with a few hints for customising Cake.Recipe.

@wozzo thank you for taking the time to add this!  I still need to add some more information for #36, but this will certainly help!


Improve party details view

The Chore
Now we have removed the json and are able to present party details as ui elements we want to improve the layout and look and feel  of this view
Acceptance Criteria

[ ]  I can see party id as the maine (e.g. H1)  title of the page
[ ]  I can easily copy the Party ID into my clipboard
[ ]  Party IDs are presented without the preceding 0x (see note below)
[ ]  I can see a list of Assets the Party owns with the asset balance
[ ]  I can easily copy the asset ID from the list into my clipboard
[ ]  I can view the page and understand the content effectively in dark and light modes
[ ]  The page and it's content are accessible and easy to navigate using a keyboard

Tasks

[ ] TBC
[ ] and then what?
[ ] Etc.

Additional details / background info
Consider tackling this ticket if/when adding more data to the party details view as more valuable / time efficient [LINK TO TICKET]
Notes on party IDs Originally from @campbellssource
The convention on Vega is that even though public keys are hexadecimal, they do not appear with the leading 0x.
This has perhaps become a convention from the fact that the Vega API returns parties without the 0x.
however, it appears that the Tendermint API (or whatever block explorer is using) does return parties with a preceding 0x.
This ticket is to remove the 0x from anything that is a party in Block explorer.

find all instances of a party that does start with a 0x
remove the 0x

This will help users copy paste between different apps

Link to designs in Figma: https://www.figma.com/file/CRNfp3wtC29lIr3ctcWVe9/Block-Explorer?node-id=1324%3A1766

Discussed this and agreed to move the transaction details to the bottom as it will have infinite scroll, don't believe Elmar needs anything more from design on this


update name DunogeonVF to FR

Closing as duplicate of https://github.com/arduino/library-registry/pull/2271


Filtering out RestApiOperation before registering them in RegisterOpenApiSkillAsync

I would like to be able to filter RestApiOperation from a OpenApiDocument before registering them.
The current method RegisterOpenApiSkillAsync does not let me filter out skills before registering.
My use case is that I would like to add GET skills only to a kernel but NOT POTS/PUT/DELETE.
I can do a PR where I add another argument to the method to let the user filter, but that probably means to add it to all the methods from KernelOpenApiExtensions, and break the api.

This would be really helpful. Had an incident the other day when AI delete some work items from our ADO instance because the openapi.json file gave it information about the delete APIs as well.

@Poltuu  - thanks for this request, we will take look into this.

Super. I'm more than happy to help if needed

All .Net issues prior to 1-Dec-2023 are being closed. Please re-open, if this issue is still relevant to the .Net Semantic Kernel 1.x release. In the future all issues that are inactive for more than 90 days will be labelled as 'stale' and closed 14 days later.


Add Cupertino Slider

What would you like to be added:
Add Cupertino theme for Slider
https://developer.apple.com/design/human-interface-guidelines/ios/controls/sliders/
https://api.flutter.dev/flutter/cupertino/CupertinoSlider-class.html
https://github.com/dotnet/GraphicsControls/blob/master/src/GraphicsControls/Controls/Slider/Slider.cupertino.shared.cs
SliderTrackBackgroundColor = "#8E8E93";
SliderTrackProgressColor = "#007AFF";
SliderThumbColor = "#161313";
For which Platform:

[x] UWP
[x] iOS
[x] Android
[x] WebAssembly
[x] macOS

Verified on build  1.0.0 (716)


az network nsg rule create FAILS with weird 'str' object has no attribute 'is_default' error

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az network nsg rule create
Errors:
The command failed with an unexpected error. Here is the traceback:
'str' object has no attribute 'is_default'
Traceback (most recent call last):
  File "/usr/lib64/az/lib/python3.6/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 658, in execute
    raise ex
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 721, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 692, in _run_job
    result = cmd_copy(params)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 328, in __call__
    return self.handler(*args, **kwargs)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/network/custom.py", line 5016, in create_nsg_rule_2017_06_01
    _handle_asg_property(kwargs, 'source_application_security_groups', source_asgs)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/network/custom.py", line 4985, in _handle_asg_property
    if kwargs[prefix + 'address_prefix'].is_default:
AttributeError: 'str' object has no attribute 'is_default'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az network nsg rule create --v --subscription {} --resource-group {} --nsg-name {} --name {} --priority {} --source-port-ranges {} {} {} {} {} {} {} {} {} {} {} {} {} {} {} {} {} --source-address-prefixes {} --source-asgs {} --access {} --protocol {} --direction {} --destination-port-ranges {}

Expected Behavior
Environment Summary
Linux-3.10.0-862.el7.x86_64-x86_64-with-centos-7.9.2009-Core, CentOS Linux 7 (Core)
Python 3.6.8
Installer: RPM

azure-cli 2.35.0

Additional Context

network

It's duplicated one as: https://github.com/Azure/azure-cli/issues/22023


release CentOS 8 artifact

CentOS 8 will be released on 9/24: https://wiki.centos.org/About/Building_8
The linux-glibc build should just work but we need to update the yum repository. @taiki45 can you take this as well?

@lizan Sure, let me handle this.


translated properties can't be symmetric

Document this/determine any workaround or what least bad behavior should be.

One possible solution might be to coerce all Django utils Promise objects to strings in the Choices meta class. This would disable symmetric behavior for all but the originally specified string.


timeout?

I encountered cases where blastn did not complete for long time. We may introduce 'timeout' function?

shuji's personal note:

mapp2g_out_j939t4/240.fasta

1277hr

mapp2g_out_j976t41/308.fasta
mapp2g_out_j980t45/239.fasta

1237　or  408 hr


Add two unittests for realloc()

Simple tests for realloc, verifying that old memory is not affected by the reallocation.

Did the clang-format myself this time, I hope :).

LGTM. Test failure on the CI server is in another test, for something I thought I fixed. I'll look into that and double check these tests with that fix in.

Did you manage to have a look into the CI failure? I'm quite sure "it worked on my machine".

Thanks for the ping - had surgery and then totally forgot.

Thank you for another contribution!


Add test option

This adds another top-level option method. In this case, inView.test, which takes a function to be used to determine element visibility. (instead of the default inViewport). That function should return true for visible and false otherwise.
inView.test((element, options) => {
    // ...
});

Looks fine to me but if you’re heading towards v1 I have  a reservation :). Right now inView acts as a singleton. If you replace the test method there’s no way to get it back and there’s no way you can use it both ways. So I guess it’s key that you add some kind of factory function as well. You could still keep the default singleton, but allow users to create a new inView instance from it.

@kmohrf Agreed, not ideal. I think the way to handle it going forward is to allow per-registry settings that fall back to static global defaults. This will work as a stopgap.


mmap input files rather than reading

[Consolidating some comments from #107 and #108]
Currently we read input files into a local buffer.  I had thought this was better than mmap because:

we need a trailing nul bye on the file for parser reasons
performance -- I can't remember where I had read it, but I recall the argument that mmap can be costlier than reading when it's a large file you're reading sequentially, due to some kernel overhead related to setting up all the memory mapping data structures(?)

However, it turns out that you can just mmap a private page at the end of the file to write the nul, and @Colecf says "Judging based on n2's tracing output, just reading the file into memory takes over twice as long as the android fork's entire ninja invocation".

Relevant code in Android's Ninja fork.  (Not sure how to get a permalink to that commit but the file is unlikely to change much in the future, but it's the function MapFile.)

I wrote a mini benchmark here.
On this Mac Air M2 for a random 1.4gb file:
without madvise:
  ./target/release/read-file mmap $F ran
    1.25 ± 0.01 times faster than ./target/release/read-file read $F

with madvise:
  ./target/release/read-file mmap $F ran
    1.36 ± 0.02 times faster than ./target/release/read-file read $F

So I conclude at least for this hw/OS that mmap is faster, and madvise helps too.

Relevant code in Android's Ninja fork. (Not sure how to get a permalink to that commit but the file is unlikely to change much in the future, but it's the function MapFile.)

Sorry, this link should be permanent.

can this invalidate the memory mapping?

The Linux man pages says it's undefined behavior.  The Mac ones don't say either way.  It is true that we wouldn't want to preserve the mapping beyond the point where the file might be rewritten though.


Create tests for get_types

"The unit test function should test 3 to 5 edge cases to ensure that the function returns what is expected. When writing your tests, build them around the function specifications and requirements."

https://github.com/UBC-MDS/pokehelpyer/pull/36


ARXIVNG-1008 incremented version number in feedback collector to 0.4

Per ARXIVNG-1009 I also updated the link to the release notes, and updated the version number displayed with that link.

Coverage remained the same at 81.911% when pulling c25346e53e21a27144c923be9bb31114077d01f3 on task/ARXIVNG-1008 into 9450de05b0875901ccb138d0339f25118e96179c on develop.


Request:  Array of fields to return

Thank you for making and publishing this hook.  Saved me a ton of time and head scratching trying to other hooks and code to fetch associated data.
Have a request if you think worthy.  How about an array on the target include that allows us to specify which fields to return?  My postgres is a quite complex multi-tenant with a lot of relationships and useless associations and other fields that in these associations that is not relevant to the the response I need to return to the app.
I can discard the unnecessary data  in an after hook but in my case would need to update and maintain 80+ tables - this option would save a ton of time and makes sense re: efficiency and compressing the response....
Whaddyathink?
const options = {
  include: {
    service: 'phones',
    nameAs: 'phone',
    keyHere: 'default_phone_id',
    keyThere: 'id'
    fields: ['name', 'number', 'extension', 'e164']     <-------- this
  }
}

Oh...@marshall I see you are one of the maintainers.  Was going to mention I am using feathers-vuex on client with setupInstance, so assume that the service id should be returned be default...si?

Yeah, I'm the primary maintainer on this, now. The id would definitely require to be returned.

@marshallswain great!  appreciate your efforts in community.
So what do you think about the request to provide an array of fields to return?

Since FeathersJS already has a query operator for $select, maybe it would make sense to update feathers-shallow-populate to allow you customize the params object.  We could make it so the params attribute in each include could be a function that receives the params object AFTER feathers-shallow-populate has already built the query.`
{
  params: (params) => {
    params.query.$select = ['name', 'number', 'extension', 'e164']
  }
}

@corepay you can now customize the params, based on the work by @fratzinger in #16.  Check out the updated docs in the readme.  You'll need to install<EMAIL_ADDRESS>

Works great!  This helps a lot, makes a few related hacks less hacky.
Thank you @fratzinger and @marshallswain !


Upload error

Laravel Version: 5.5.4
Voyager Version: dev-master
PHP Version: 7.0.10
Database Driver & Version: MySQL

Description:
on a fresh install when trying to upload a file there's an exception:
ErrorException in VoyagerMediaController.php line 186:
Undefined variable: path
Steps To Reproduce:
try to upload file...

I have try:
dd($request->upload_path , $this->filesystem)
Result:
null
"public"
=> The null value for upload_path is normal??

Labels: invalid
Close (dev-master is not stable)

Please update to latest version, if this still happens please provide steps on how to reproduce.

After updates, it still happens again.
Step to reproduce:

go to media menu
click on download button
choose a file
wait the ajax finish

Response of the ajax call:
{"success":false,"message":"The file \"\" does not exist","path":""}

I have update my files again... same issue as #1822

Closing as this issue is for a much older Voyager version.


Update this_en.md detailed Explanation

Thanks for the PR, please preview your md to make sure it is readable.


[Flaky multikueue e2e] MultiKueue when Creating a multikueue admission check Should run a job on worker if admitted

What happened:
End To End MultiKueue Suite: kindest/node:v1.30.0: [It] MultiKueue when Creating a multikueue admission check Should run a job on worker if admitted
{Timed out after 5.001s.
The function passed to Eventually failed at /home/prow/go/src/sigs.k8s.io/kueue/test/e2e/multikueue/e2e_test.go:231 with:
Expected
    <bool>: true
to be false failed [FAILED] Timed out after 5.001s.
The function passed to Eventually failed at /home/prow/go/src/sigs.k8s.io/kueue/test/e2e/multikueue/e2e_test.go:231 with:
Expected
    <bool>: true
to be false
In [It] at: /home/prow/go/src/sigs.k8s.io/kueue/test/e2e/multikueue/e2e_test.go:232 @ 11/18/24 14:17:15.278
}

What you expected to happen:
No random failures
How to reproduce it (as minimally and precisely as possible):
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/3580/pull-kueue-test-multikueue-e2e-release-0-9/1858512622475808768
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version):
Kueue version (use git describe --tags --dirty --always):
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/3708/pull-kueue-test-multikueue-e2e-main/1863892287004610560

/kind flake


Thumbnail not generated with exact size

I came across what I think is a bug on the concrete5 thumbnail generation on which I need your opinion.
I use a thumbnail type with the following options :

Width : 1900px
Height : 500px
Sizing mode : Resize and Crop to the Exact Size

When I upload an image with the same dimensions as the thumbnail type, the thumbnail is not generated. After a little search in the code, I found two conditions that exclude this case in the file concrete/src/Entity/File/Version.php on lines 1118 and 1124 :
If the image width is smaller or the same as the thumbnail type the thumbnail is not generated, and if the image height is smaller or the same as the thumbnail type the thumbnail is not generated.
Is it the wanted behaviour ?
I would have replaced :
$imageheight <= $type->getHeight() to $imageheight < $type->getHeight()
and
$imagewidth <= $type->getWidth() to $imagewidth < $type->getWidth()

There are few problems in thumbnail generation. I'm (quite tired of) waiting for #6275 to be reviewed in order to address them.

@mlocati I saw that #6275 has been merged, I checked this issue and I confirm that I still have it.
But as I said, I'm not sure if it is an actual issue, maybe it is the expected behaviour.

I inspected this, and IMHO it's the indented behaviour.
First of all, it's useless to generate a thumbnail that has the same size as the original image itself: it takes time and memory to generate a thumbnail, and it's a waste of disk space. In this case, simply use the original image.
The same argument can be applied in the case when the thumbnail would be wider or taller that the original image. In this case we would also have the problem to determine how to fill the "exta" space of the thumbnail... If we'd use transparent, that would work only for PNG images (but someone may have set to use the JPEG format for thumbnails); if we'd use a solid color, someone may want black, someone else white, someone else the mean color of the image...

@mlocati Thanks for your explanation. Now I understand why concrete5 wouldn't generate the thumbnail but as I mentioned in #6292, concrete5 shows the image in the thumbnails list of the file and there is the "Edit Thumbnail" button even if the thumbnail hasn't been generated.
When I click on the edit button, I have the following error :

Unable to find requested thumbnail
The thumbnail you requested was not included in the available thumbnails, is your source image smaller than the thumbnail?

Should this have been closed? There is still a bug that needs to be fixed, just not the bug initially suspected.

@JohntheFish which bug are you referring to?

"When I click on the edit button, I have the following error :"

Should there be an edit button for a non-existent thumbnail?

@JohntheFish @mlocati answered here #6292

OK, thanks.

@mlocati I understand why concrete5 isn't generating the thumbnails if the original image is smaller. But in my opinion it would still be nice to have an option like "allow upscaling" on thumbnails to define this behaviour. There are some cases where you want to have a cropped image, no matter what the original size is. Is this something that's planned in the future or which would be welcome? I'd be happy to work on it. Or did I simply not find the option and is it already available?

@jneijt I'd open a new issue to talk about it

@mlocati I'll do, thanks 👍


[Task]: Hide transactions that do not relate to the address

Task description
A transaction can contain outputs that none are spent by the address, the explorer in this case will show an entry in the tx history with value 0, instead of that, we should directly not push this transaction as belonging to the address

https://github.com/iotaledger/inx-chronicle/pull/1314
from a chronicle dev:

we update the associated address when the output is spent, so at that point the output X is associated with address A since it spent it

This issue does not longer shows up in the explorer, case closed 💃


Rainy clouds animation

Rainy clouds animation

Close #4734

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have created a helpful and easy to understand README.md

@MohitGupta121 @TusharKesarwani Kindly review this PR.


Use g_free for xfs/g_xfs in xfs_delete_xfs_fs

It's possible for xfs (g_xfs) to be null due to fuse mounts failing.
If g_xfs is null chansrv will crash with sig. fault.

We need to make a release  for this fix.

Agreed, as it seems to be affecting other users. I can only apologise for not picking it up in my unit testing.

ref. #1449


Pass by reference not allowed to error

Slightly wierd quirk of the system but I had (incorrectly) set my variable with a reference in one of my controllers as such:
$this->table1_downloads(&$start,$excel,$kitID,$dates);
I fully appreciate that this is wrong because pass by reference to a function is now deprecated however for some reason CI completely crashed. No error reporting/logging (on level 4) and browser just redirected. No PHP/error/output.
Not a major issue but took quite a while of debugging to find it because I wasn't being told what was wrong.

This is not even related to CI.


Update the license to Apache 2

Fixed by https://github.com/vaadin-component-factory/explorer-tree-grid-flow/pull/3


Py37

And update-cb3

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

Whenever possible python packages should use pip. See https://conda-forge.org/docs/meta.html#use-pip

Failing on Windows and PY37 with:
running build_ext
building 'gmpy2' extension
creating build
creating build\temp.win-amd64-3.7
creating build\temp.win-amd64-3.7\Release
creating build\temp.win-amd64-3.7\Release\src
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -DMPIR -DWITHMPFR -DWITHMPC -DMSC_USE_DLL=1=1 -I\bld\gmpy2_1538879494742\_h_env\Library\include -IC:\bld\gmpy2_1538879494742\_h_env\include -IC:\bld\gmpy2_1538879494742\_h_env\include "-IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE" "-IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\shared" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\winrt" -IC:\bld\gmpy2_1538879494742\_h_env\Library\include /Tcsrc\gmpy2.c /Fobuild\temp.win-amd64-3.7\Release\src\gmpy2.obj
gmpy2.c
c:\bld\gmpy2_1538879494742\work\src\gmpy.h(116): warning C4005: 'isnan': macro redefinition
C:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\ucrt\math.h(275): note: see previous definition of 'isnan'
c:\bld\gmpy2_1538879494742\work\src\gmpy.h(117): warning C4005: 'isinf': macro redefinition
C:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\ucrt\math.h(274): note: see previous definition of 'isinf'
c:\bld\gmpy2_1538879494742\work\src\gmpy_random.c(251): warning C4996: 'mpfr_grandom': was declared deprecated
c:\bld\gmpy2_1538879494742\_h_env\library\include\mpfr.h(502): note: see declaration of 'mpfr_grandom'
c:\bld\gmpy2_1538879494742\work\src\gmpy_mpz.c(2136): fatal error C1057: unexpected end of file in macro expansion
error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\BIN\\amd64\\cl.exe' failed with exit status 2


Multiple dex files define Landroid/support/v7/appcompat/R$anim;

Hey, thanks for making this library great!
I'm having a few issues on Android:

React Native 0.27
Android 5X 6.0.1

I went through the process manually, I did not use rnpm link
Unknown source file : UNEXPECTED TOP-LEVEL EXCEPTION:
Unknown source file : com.android.dex.DexException: Multiple dex files define Landroid/support/v7/appcompat/R$anim;
Unknown source file : 	at com.android.dx.merge.DexMerger.readSortableTypes(DexMerger.java:596)
Unknown source file : 	at com.android.dx.merge.DexMerger.getSortedTypes(DexMerger.java:554)
Unknown source file : 	at com.android.dx.merge.DexMerger.mergeClassDefs(DexMerger.java:535)
Unknown source file : 	at com.android.dx.merge.DexMerger.mergeDexes(DexMerger.java:171)
Unknown source file : 	at com.android.dx.merge.DexMerger.merge(DexMerger.java:189)
Unknown source file : 	at com.android.dx.command.dexer.Main.mergeLibraryDexBuffers(Main.java:502)
Unknown source file : 	at com.android.dx.command.dexer.Main.runMonoDex(Main.java:334)
Unknown source file : 	at com.android.dx.command.dexer.Main.run(Main.java:277)
Unknown source file : 	at com.android.dx.command.dexer.Main.main(Main.java:245)
Unknown source file : 	at com.android.dx.command.Main.main(Main.java:106)

:app:dexDebug FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:dexDebug'.
> com.android.ide.common.process.ProcessException: org.gradle.process.internal.ExecException: Process 'command '/Library/Java/JavaVirtualMachines/jdk1.8.0_92.jdk/Contents/Home/bin/java'' finished with non-zero exit value 2

Try this command at the root of your project:
cd android && ./gradlew clean

It worked when I got this error.

@peterpme Did the gradlew clean command worked for you?

Hey, what ended up happening is the multiple versions of GCM so I forced a particular version! Thanks!

Thanks @jmitch0901, saved me a lot of heartache.

@jmitch0901 THANK YOU! I've been searching FOR HOURS for a resolution, and it was as simple as cleaning the project 😄

@jmitch0901 wish I could upvote your answer 1000 times.

@jmitch0901 OMG!!!! THX!!


Refactor the yaml package a bit

Using strslice.StrSlice and simplify the structs based on slices and map are simplified 🐸.
/cc @joshwget @dnephin @ibuildthecloud
🐸
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

I like this change. It should make dealing with the YAML types easier :+1:


feat: implemented the backend for demand and capacity notifications 2.0

Description

implemented the CRUD endpoints for demand and capacity notications

resolves #316
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

Please see new comment. Regarding bpnl sanitizing: not sure if you missed the comment, please check. If you propose to not go with sanitizing the controllers parameter, please elaborate why.

I'm unsure what you mean regarding the BPNL sanitizing. Is the pattern check I added to the parameter not enough?

Please see new comment. Regarding bpnl sanitizing: not sure if you missed the comment, please check. If you propose to not go with sanitizing the controllers parameter, please elaborate why.

I'm unsure what you mean regarding the BPNL sanitizing. Is the pattern check I added to the parameter not enough?

Ah sorry, you're right. Got confused due to the outdated conversation.


Runtime translation support

Hello,
As far as I know, translation workflow with c-3po uses *.po files on compile time (e.g. via webpack), so translations are built in JS bundles.
But does c-3po supports any kind of providing translations in runtime, after bundle is built? For example via additional request.
Thanks in advance!

Hi, c-3po also works without transpile. Here is a short demo on js-fiddle - https://jsfiddle.net/AlexMost/9wuafbL5/30/. In general, you need to parse po file and after that call addLocale.
You can check the quick-start - https://c-3po.js.org/quick-start.html, it uses runtime translations loading (without babel plugin).

you can also build your workflow with po-loader and webpack and load translations via dynamic imports - https://c-3po.js.org/localization-with-webpack-and-c-3po.html#4-localization-with-dev-setup


Adding option to rename games without extra info

Hey! I was playing with the idea to make a option to rename games without all the extra information after the game name itself. I don't know if you're interested in it, so thought to make this PR.
EDIT: Just noticed that sometimes the games may have more than one parenthesis with extra info. I'll look what can be done about this.

Done! It's now a lot better :D

Hi!
I think it's a cool feature!
Thanks for contributing :)

It will be available in the next version


Annotate structured control flow with merge addrs

The merge address of a structured control flow node (loop/switch/if) is the address of the first basic block "after" the statement's body. It is generally distinct from the address of the next (high level AST) statement in the containing block.

Thank you for the comprehensive change, for covering all dependencies!


Updated new commercial marketplace openapi files

Updated openapi files with the versions currently found in https://github.com/microsoft/commercial-marketplace-openapi

Test broke... You may want to make sure it passes all tests.  Probably CI needs update.

Resolved issue with secrets that was causing the Github Action to fail.


fixed main_split_image.dart's error

Fixed this error on build:" error: The function expression type 'Future Function(Uint8List, {int cacheHeight, int cacheWidth})' isn't of type 'Future Function(Uint8List, {bool allowUpscaling, int cacheHeight, int cacheWidth})'. This means its parameter or return type doesn't match what is expected. Consider changing parameter type(s) or the returned type(s). (invalid_cast_function_expr at [flutter_samples] lib/split_image/main_split_image.dart:20)"
It was missing the bool allowupscaling  parameter. I have added that, and now its working just fine.

What's your flutter version?
On Fri, Oct 2, 2020, 3:36 AM rushikesh127001<EMAIL_ADDRESS>wrote:

Fixed this error on build:" error: The function expression type 'Future
Function(Uint8List, {int cacheHeight, int cacheWidth})' isn't of type
'Future Function(Uint8List, {bool allowUpscaling, int cacheHeight, int
cacheWidth})'. This means its parameter or return type doesn't match what
is expected. Consider changing parameter type(s) or the returned type(s).
(invalid_cast_function_expr at [flutter_samples]
lib/split_image/main_split_image.dart:20)"
It was missing the bool allowupscaling parameter. I have added that, and
now its working just fine.
[image: Screenshot from 2020-10-02 14-02-04]
https://user-images.githubusercontent.com/50454029/94904067-5adf2880-04b8-11eb-81f7-05456ba4769f.png
You can view, comment on, or merge this pull request online at:
https://github.com/diegoveloper/flutter-samples/pull/24
Commit Summary

fixed main_split_image.dart's error

File Changes

M lib/split_image/main_split_image.dart
https://github.com/diegoveloper/flutter-samples/pull/24/files#diff-3aeb596394b2ec091a38b4d61bc994ce
(2)

Patch Links:

https://github.com/diegoveloper/flutter-samples/pull/24.patch
https://github.com/diegoveloper/flutter-samples/pull/24.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/diegoveloper/flutter-samples/pull/24, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABFL3UFJCBVNNCG4XPGRVTTSIWGI5ANCNFSM4SBNRZYQ
.

What's your flutter version?
…
On Fri, Oct 2, 2020, 3:36 AM rushikesh127001 @.***> wrote: Fixed this error on build:" error: The function expression type 'Future Function(Uint8List, {int cacheHeight, int cacheWidth})' isn't of type 'Future Function(Uint8List, {bool allowUpscaling, int cacheHeight, int cacheWidth})'. This means its parameter or return type doesn't match what is expected. Consider changing parameter type(s) or the returned type(s). (invalid_cast_function_expr at [flutter_samples] lib/split_image/main_split_image.dart:20)" It was missing the bool allowupscaling parameter. I have added that, and now its working just fine. [image: Screenshot from 2020-10-02 14-02-04] https://user-images.githubusercontent.com/50454029/94904067-5adf2880-04b8-11eb-81f7-05456ba4769f.png ------------------------------ You can view, comment on, or merge this pull request online at: #24 Commit Summary - fixed main_split_image.dart's error File Changes - M lib/split_image/main_split_image.dart https://github.com/diegoveloper/flutter-samples/pull/24/files#diff-3aeb596394b2ec091a38b4d61bc994ce (2) Patch Links: - https://github.com/diegoveloper/flutter-samples/pull/24.patch - https://github.com/diegoveloper/flutter-samples/pull/24.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#24>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFL3UFJCBVNNCG4XPGRVTTSIWGI5ANCNFSM4SBNRZYQ .

my flutter version is "Flutter (Channel stable, 1.20.3, on Linux, locale en_IN.UTF-8)"
this is the latest stable version i guess

great, thanks for the contribution!


Fill type info assist

I was looking into #1965,
I got the simplest of tests passing:
"fn f() { let a<|>: _ = 1; }" == "fn f() { let a<|>: i32 = 1; }",

This basically scans the text range after the colon for the placeholder type, and calls analyzer.type_of like the previous implementation, plus it doesn't bail immediatly after seeing a colon.
I'd like some help with is understanding why I'm getting the Unknown type when trying to retrieve type information for vec![1,2,3].
It clearly works when on the IDE, so RA can infer this correctly:

What am I missing?
This is probably a pretty messy implementation - we could move followed_by_placeholder_ty outside and so on, and perhaps the traversal is not optimal - so comment/nits on the implementation details are more than welcome!

'd like some help with is understanding why I'm getting the Unknown type when trying to retrieve type information for vec![1,2,3].

It is because when lowering, we do not store the expr_id of the actual macro_cal ast node, we only store all expanded exprs inside BodySourceMap such that the following line will return None:
https://github.com/rust-analyzer/rust-analyzer/blob/d6223253b628b279f9ddae8f83f7173d01f6b32c/crates/ra_hir/src/source_binder.rs#L216
Maybe we could try to expand the Ast::MacroCall before/inside calling SourceAnalyzer::type_of ?

@edwin0cheng I'm not sure thats a macro problem - I've also tried "fn f() { let a<|>: Vec<_> = Vec::<i32>::new()" - and it still returns Unknown. Also - the call to analyzer.type_of does return a ty - it simply is unknown.
puttind a dbg!(&expr, &ty); after line 91 at add_explicit_type.rs yields:
[crates\ra_assists\src\assists\add_explicit_type.rs:93] &expr = CallExpr(
    CallExpr {
        syntax: CALL_EXPR@[25; 42)
          PATH_EXPR@[25; 40)
            PATH@[25; 40)
              PATH@[25; 35)
                PATH_SEGMENT@[25; 35)
                  NAME_REF@[25; 28)
                    IDENT@[25; 28) "Vec"
                  TYPE_ARG_LIST@[28; 35)
                    COLONCOLON@[28; 30) "::"
                    L_ANGLE@[30; 31) "<"
                    TYPE_ARG@[31; 34)
                      PATH_TYPE@[31; 34)
                        PATH@[31; 34)
                          PATH_SEGMENT@[31; 34)
                            NAME_REF@[31; 34)
                              IDENT@[31; 34) "i32"
                    R_ANGLE@[34; 35) ">"
              COLONCOLON@[35; 37) "::"
              PATH_SEGMENT@[37; 40)
                NAME_REF@[37; 40)
                  IDENT@[37; 40) "new"
          ARG_LIST@[40; 42)
            L_PAREN@[40; 41) "("
            R_PAREN@[41; 42) ")"
        ,
    },
)
[crates\ra_assists\src\assists\add_explicit_type.rs:93] &ty = Type {
    krate: CrateId(
        0,
    ),
    ty: InEnvironment {
        environment: TraitEnvironment {
            predicates: [],
        },
        value: Unknown,
    },
}

It is because our test fixture do not import anything (include std),  so it will not works in such case.
However, I try to build and install your PR as actual VS Code Extension, it works:

@edwin0cheng I was silly not to actually try this! I've added an example that doesn't need std and it passes. Thanks for the help :)

@edwin0cheng I've checked it now - and it seems to fail with the macro vec!, but work with Vec.
So this probably related to the issue that you've previously mentioned.

@edwin0cheng I've tried doing something like this before calling analyzer.type_of:
    if let Some(macro_call) = ast::MacroCall::cast(expr.syntax().clone()) {
        let token = hir::InFile::new(ctx.frange.file_id.into(), macro_call);
        let expansion = analyzer.expand(db, token.as_ref())?;
        dbg!(expansion);
    };

It does seem to hit and print:
[crates\ra_assists\src\assists\add_explicit_type.rs:101] expansion = Expansion {
    macro_call_id: MacroCallId(
        0,
    ),
}

But it won't be inferred if I simply check expr after it.
Do I need to somehow ask it to infer the macro?
Also - I'm using a lot of the code found in the hover action as reference, it seems to  handle all of those cases, and - evidently it gets it right a lot of the times, I wonder if theres any way we can share some of the code with ra_ide?

@edwin0cheng I've tried doing something like this before calling analyzer.type_of:

IMHO, maybe just leave it as is and solve it in another PR ? Fixing it seem like out of scope of this PR and it involve some design decision in type_of and lowering which I am not familiar to.

@edwin0cheng I'm fine with fixing it later - it's somewhat beyond my current comprehension of the code base aswell.
I'll wait for @matklad to look over this and see how to proceed from here :)

Yeah, it's a good point that type_of currently doesn't work with macros, but this needs to be fixed on the deeper level. For the time being, let's ignore macros altogether.

Closing due to inactivity!


build: update python_rules to support Python 3.12

Before, when trying to use to build the project using Bazel, this would result in multiple occurrence of this error:
AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?
This error is due to rules_python being too old. While building with Python3.12 still result in an error, the new one clearly indicate is mismatch of the TensorFlow version.
Very similar/related: https://github.com/googleapis/gapic-generator-python/pull/1825
BUG=https://github.com/tensorflow/tensorflow/issues/73174

I used the link in the documentation to open an issue, no sure if it was correct to open it in the main tensorflow repository. Let me know if I should create a new one in tflite-micro.

Thanks for the approval!
Seems that there is a mergify issue though and I'm not sure what am I suppose to do.
Should I just update my branch by merging tensorflow:main into my branch? Or is it because I inattentively used the main branch of my fork to create the PR? (In this case I think I will need to create another PR)
Anyway, I'm waiting on your input to avoid doing something wrong.

Thanks for the approval! Seems that there is a mergify issue though and I'm not sure what am I suppose to do. Should I just update my branch by merging tensorflow:main into my branch? Or is it because I inattentively used the main branch of my fork to create the PR? (In this case I think I will need to create another PR) Anyway, I'm waiting on your input to avoid doing something wrong.

Sometimes this happens when we try to merge a bunch of PRs at once. I've updated the branch and that should kick off a fresh attempt.

@rascani
Hmm, do you have to approve it again or something?

Thanks!


Getting this error when trying to use this module.

[Unhandled promise rejection: TypeError: null is not an object (evaluating 'RNSwisseph.swe_julday')]

node_modules/react-native-swisseph/index.js:9:28 in swe_julday$
node_modules/regenerator-runtime/runtime.js:45:44 in tryCatch
node_modules/regenerator-runtime/runtime.js:271:30 in invoke
node_modules/regenerator-runtime/runtime.js:45:44 in tryCatch
node_modules/regenerator-runtime/runtime.js:135:28 in invoke
node_modules/regenerator-runtime/runtime.js:170:17 in
node_modules/promise/setimmediate/core.js:45:7 in tryCallTwo
node_modules/promise/setimmediate/core.js:200:23 in doResolve
node_modules/promise/setimmediate/core.js:66:12 in Promise
node_modules/regenerator-runtime/runtime.js:169:27 in callInvokeWithMethodAndArg
node_modules/regenerator-runtime/runtime.js:192:38 in enqueue
node_modules/regenerator-runtime/runtime.js:216:8 in
node_modules/react-native-swisseph/index.js:8:0 in swe_julday

screens/home.js:36:64 in render

node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:11581:21 in finishClassComponent
node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:11509:4 in updateClassComponent
... 18 more stack frames from framework internals

hi, I'm getting the same error with android, any clues?


Can we add a rust & run (which builds and runs) similar to go run in Golang?

This would make learning rust much faster.
At the moment every change i make i need to run cmd + B - Rust, then cmd + B - Run
could we have one which runs the 2 so i can just run 1 build in sublime which does both?
So we have functionality similar to go run?
Thanks

My top tip to you is use Cargo :) doc.crates.io/guide.html

@dten for projects sure!
I'm talking more about having a playground to dump code in and see if it works without having to set up any project or file structure. I do this quite a lot with other languages when i want to try some syntax out
Similar to https://play.rust-lang.org/ except in Sublime

An easy way to do this would be to use cargo-script. Just install it and then set up a build command that passes the name of the file to cargo script.

Thanks @lloydac playing with that now, would be nice if there's some way of integrating that

Cargo Script has now been added. So i'm going to close this


Data classification: Training would be failed when choosing the third validation data strategy for SQL Server data.

System Information (please complete the following information):
Windows OS: Windows-11-Enterprise-22H2
ML.Net Model Builder 2022: <IP_ADDRESS>7701 (Main Build)
Microsoft Visual Studio Enterprise: 2022(17.5.2)
.Net: 6.0
Describe the bug

On which step of the process did you run into an issue:
Training would be failed when choosing the third validation data strategy for SQL Server data.

TestMatrix
https://testpass.blob.core.windows.net/test-pass-data/wikipedia-detox-250-line-data.tsv
To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio start window.
Choose the C# Console App (.NET Core) project template.
Add model builder by right click on the project.
Select "Data classification scenario.
On Data page, choose the "Microsoft SQL Server" data source.
Click the "Advanced data options..." link, go to the "Validation data" tab, choose the third option and browse the file like below.

Click "Start training" button to training, you will see that training failed with error "Splitter/consolidator worker encountered exception while consuming source data".

Expected behavior
Training successful.
Screenshot

Additional context

The bug is also repro on "Text classification" when choosing the third validation data strategy for both of Microsoft SQL Server and Microsoft SQL Server Database File data.

@zewditu No, I didn't open my file in excel.

@v-Hailishi  thanks for confirming, better error message is a good fix for it.

The bug has been fixed on the latest main build <IP_ADDRESS>8101


The request was aborted: Could not create SSL/TLS secure channel

After trying to open the injector this message appears and nothing happens. With last version it was the same but after the message skin changer just opened and everything was fine, now nothing happens

The following commit fixes the issue: https://github.com/R3nzTheCodeGOD/R3nzSkin/commit/70fd37c8882c6f92013be2609f24dd46445888c3


Proxy support in HTTP default parameters

Contains changes to idl.xml and a rerun of idl.rb to regenerate the dsl file.

Thank you


Show image size and frame count on image edit view

I think the frame count of animated images is of similar importance to the width/height, so this adds a frame_count field to the Image model. and adds an "Image size" section in the sidebar which displays the total image size in pixels along with the frame count.
This depends on https://github.com/wagtail/Willow/pull/74

Might remove total number of pixels, and add total length in seconds. Total length/frame count will only be shown on animated gifs so this PR would have no changes for still images.


Docs.MS Release Updates for azure-resourcemanager

Update docs metadata and targeting for release of azure-resourcemanager

Docs Build status updates of commit e00d514:
:clock10: Full build: the average full build time is 279 min(s) 9 sec(s), this is based on the last 923 build(s) for this repository.

Docs Build status updates of commit e00d514:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/resourcemanager-readme-pre.md
:white_check_mark:Succeeded
View (azure-java-stable) View (azure-java-preview) View (azure-java-legacy)

package.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Saving the color-coded log of the snakemake run

Is there a way for for saving a log of a run in a color-coded manner as it is visible in the shell?
For now I am just just directing the log to the log file, but I must admit that the color coding supports the visual examination greatly.
I couldn't fine any useful flag or parameter.

See if this helps https://stackoverflow.com/questions/27397865/how-to-write-stdout-to-file-with-colors
You will need something like less -R my.log to see the colors or a text editor that interprets ansii color codes. Otherwise, the log file will look like a mess.


rust should support an extract-method refactoring

I've discussed this partially elsewhere (e.g. here and here, but I think it's probably an important enough consideration that it deserves to be elevated to an independent issue, for independent discussion. @bill-myers originally raised an argument here that I interpret as showing that current rust's dynamic drop semantics are technically incompatible with an automated extract-method refactoring. (I'd love to be proven wrong on this point.) I want to raise this as an explicit issue so that the following can be discussed:

Can dynamic drop be made compatible with an automated extract-method refactoring?
If dynamic drop is indeed incompatible with this refactoring, is it possible to modify rust post 1.0, in a backwards-compatible way, so that this refactoring would becomes possible?
If, as I fear, the answers to the above questions are "no" and "no", is eventual support for this refactoring something that rust considers important?
If support for this refactoring is important, how can it be achieved?

From the way I've framed this, my position is probably clear: I think supporting advanced tooling for editing rust source code will be highly important to mainstream acceptance of the language down the road, and we might be running out of time to address issues like this, before 1.0's guarantee of backwards compatibility makes solving this issue much more technically challenging. In any event, I hope these concerns can be discussed...

I don't think dynamic drop is inherently incompatible with such a refactoring. Yes it needs additional information from the compiler, but thats true for a lot of possible refactorings. C++ would have the same problem, and afaik IDEs exist that can deal with this.
If such a case is encountered, the IDE could then either ask the user, give an error or warning, or attempt to rewrite the code into something using the Option dance that preserves the drop behavior.
And its not like dynamic drops are the only thing that prevents turning an arbitrary block of code into a function - if that block uses control structures like break or return, then it wouldn't work as intended too, unless some additional code gets rewritten.

Thanks for commenting. I'm sure the 1.0 work has everyone very busy, and that's part of why I feel the need to scream so loudly about this. I wish I had gotten involved earlier so I could have noticed these issues closer to when they were first raised.
That said, my concern would be alleviated if someone could show how an extract method could possibly work against the code I alluded to earlier:
fn f() {
  let x = S { ... };
  // extract from here:
  if a() {
    b();
    consume(x);
  }
  // ...to here.
  c();
}

What would the transformed code look like? As far as I can tell, an automatic refactoring would require that no variables be "maybe" consumed in the body of the code being extracted (they must either be fully consumed, or not consumed at all). And I'd think dynamic drop is incompatible with that requirement. To allow extract method, the meaning of the code would need to be changed so that x would have to be consumed:
fn f() {
  let x = S { ... };
  // extract from here:
  {
    // capture `x` in scope
    let x = x;
    if a() {
      b();
      consume(x);
    }
  }
  // ...to here.
  c();
}

...and changing meaning means you're no longer refactoring.

I don't know if this is the best way, but one possible translation I could imagine is this:

Make the dynamic drop first class by using an Option as an explicit drop flag.

fn f() {
    let x = S { ... };
    let mut __dyn_drop_x = Some(x);
    // extract from here:
    if a() {
      let x = __dyn_drop_x.take().unwrap();
      b();
      consume(x);
    }
    // ...to here.
    c();
}

This turns the dynamic drop of x into a static drop of __dyn_drop_x which however still allows a dynamic move by turning Some(x) into None with take().

Extract the method by taking a &mut Option<T>, which explicitly passes the mutation of the "drop flag" into the extracted function.

fn f() {
    let x = S { ... };
    let mut __dyn_drop_x = Some(x);
    // extract from here:
    g(&mut __dyn_drop_x);
    // ...to here.
    c();
}

fn g(__dyn_drop_x: Option<T>) {
    if a() {
      let x = __dyn_drop_x.take().unwrap();
      b();
      consume(x);
    }
}

This does not necessarily look nice, but preserves the semantic of what drops when.

I see that now... I have to admit I still find the resulting code significantly uglier to read than the original, and it's tightly coupled to details of resource management, but on the other hand it's much more explicit about what's going on when using dynamic drop, so that the code actually does, in a sense, become clearer and easier to work with (since some magic was eliminated). On the other hand, having an automated refactoring result in significantly more code noise seems likely to turn off people who are used to refactoring making their code look prettier. :-(
Is there maybe a positive answer to the second question I posted: If, someday, it is determined that dynamic drop is not the way the community thinks the language should work, would it be possible to change the language to use static drop in a backwards-compatible way?

Note that in most cases where such a refactoring changes drop semantic, it doesn't actually matter for the user. In practice, I'd expect a refactoring tool to ask the user "Do you want to preserve the exact drop locations the local binding foo of type Bar?", and I'm guessing that in most cases, this will be something like Box<T> or String, and be answerable with "no", probably to the point of there being a whitelist of types for which this does not matter.
The ugly form of the code would then only appear for cases where the user does absolutely not want to change any of the drop semantic, which will usually only be in highly specialized environments where every instruction has to be at its right place, or around problematic places like unsafe code.

I know this will sound dogmatic, but the user absolutely not wanting to change behavior is a big part of what refactoring is about. That refactorings don't ask for decisions that affect behavior is a big part of what makes them so useful.
We may be years away from tools that support automatic refactoring, so that means developers will be doing manual refactoring. With dynamic drop, I expect manual refactorings will be more bug-prone. (It's non-obvious to a developer that the naive refactoring of the original code, shown below, would change behavior. First, they need to understand the drop semantics at a deep level, and even if they do, with a more complex version of the code, it would be very easy to miss that x was not fully consumed in the body of the function being extracted).
fn f() {
  let x = S { ... };
  // extract from here:
  g(x);
  // ...to here.
  c();
}
fn g(x: S) {
  if a() {
    b();
    consume(x);
  }
}

That said, since I first posted this I've become a bit more optimistic that the drop semantics could possibly change in the future. It would be pretty painful, but I can imagine a #![lang=static_drop] attribute being defined, at some point (with the negative impacts that the compiler would need to support multiple drop semantics at once, that users would not be able to predict the behavior of some rust code without knowing the value of that attribute, and with unpredictable interactions with macro expansion - so this would be a very expensive option). With such a lang attribute, it's conceivable that that eventually becomes the preferred way to write rust code (like perl's use strict), until the point that dynamic drop can be deprecated or removed. So my position has changed a bit, at this point:

It's possible to perform the refactoring, but only in a way that would either change behavior or make the code uglier. (And, incidentally, manual refactoring is more bug-prone than initially noted. :-( )
It will be possible to change drop semantics in the future, but only at a significant cost over an extended period of time.

The current direction still feels like a mistake, to me. :-( :-(

Well, once the new dynamic drop semantic is implemented there will most likely be a lint you can enable that will error in case a program actually makes use of it.
So there isn't really anything that needs to change for that, and the only thing that could change in a backwards compatible way would be to forbid it completely, which would be equivalent to just making that lint always active.

If I read this correctly, the lint would trigger if the code includes any "maybe"-dropped variables? Becoming even more strict than any drop semantics so-far discussed, to what might be called "explicit consume under branch"? So that the code block we keep mentioning would trigger the lint?
If so, I think that's a very good step. But wouldn't that lint also trigger for the cases you describe (String, or Box<T>), where a user is not likely to care? A lint that generates too many false positives isn't likely to get widespread use. I will say, if such a lint generates a large number of false positives, but also generates some true positives (i.e. cases where the author intended that each branch path consume a variable), that would, to my mind, be another argument in favor of a static drop semantic: It would mean that the lint would be useful, but unusable.

Yes, the lint would be more restrictive that the originally proposed static drop semantic, but adopting that is not really a feasible point any more. The problem with the original proposal is that it neither dropped values as late as possible, nor as soon as possible, and "somewhere in between" cases are horrible to reason about without stepping through every line of code.

I think the original author is absolutely correct that this danger exists, but it's probably just a fact of life. There are many things that are affected by scope in Rust (as in C++) that seem like they shouldn't be (for example, introducing a let is not a no-op).
I think this is just Yet Another argument that one ought to have the RAII object guard access to the data or unsafe actions that it affects, and hence this refactoring, if it doesn't provide a compilation failure, will have no effect. However, as was argued on the original thread, there will always be cases (unsafe code, some cases of side effects) where this rule cannot be enforced, and in those cases this refactoring tool would have to be used with caution (or else be conservative, as @Kimundi suggests).
That said, all refactoring tools have edge cases where they introduce breakage. In Java, for example, reflective code can break. In smalltalk, which introduced the idea of automatic refactoring, all of this was based on simple heuristics (same method name), and it worked pretty darn well. So I'm not so worried about this being a big issue in practice.

Also, I've definitely had tools like Eclipse give me warnings or ask for feedback when doing a refactoring. For example, to select what local variables will get frozen and so forth, or to warn me that this transformation is not 100% semantics preserving. So that is always an option.

For the record, I'm not arguing for a specific form of "static drop semantics", but rather for any form of static drop semantics (and against dynamic drop). I've seen two discussed ("static drop", and "eager drop"), and I appreciate that "eager drop" is preferred by the community. It's also my technical preference, though I also think linear types of some form will be necessary to make eager drop usable. (My attempt to address this problem was here. I don't particularly care if my proposal in this domain or someone else's gets adopted, there seems to be a lot of interest in this domain so something will likely happen, and linear types could almost certainly be added in a backwards-compatible way, meaning there is more time to get them right.)
Still, yes, things can always break, and bug-free code remains a pipe-dream. The "it's a fact of life" objection has been made about every legacy system. But rust is not yet a legacy system. There is still, barely, an opportunity to reduce the likelihood of error, or the scenarios in which problem cases will become evident.

I think this is just Yet Another argument that one ought to have the RAII object guard access to the data or unsafe actions that it affects, and hence this refactoring, if it doesn't provide a compilation failure, will have no effect.

Can you unpack this, a little? Maybe a link to previous discussion? I don't quite follow.

@Kimundi:

The problem with the original proposal is that it neither dropped values as late as possible, nor as soon as possible, and "somewhere in between" cases are horrible to reason about without stepping through every line of code.

I'm sorry, but I disagree with this sentiment. Things are hard to reason about when there are unclear rules, or non-obvious corner cases. In that sense, "static drop" was actually the easiest to reason about of the mechanisms I've seen: Dynamic drop is not, for reasons I've tried to express in this thread, but these issues ultimately derive from dynamic drop's requirement that the compiler insert run-time code for managing state that is invisible and inaccessible to users. Eager drop is not, because (in my read) it does not provide an explicit promise about when a drop will occur, but rather just allows the drop to occur at any point after last use. Static drop allows a user to say "drop will occur here", which is clear. (Eager drop is still my preference, because a "drop" routine allows a user to force when a drop should occur for the cases when it's important, and specifying things more loosely allows the compiler to optimize more heavily. BTW, this is also a benefit of eager drop over dynamic drop.)
And this is probably obvious, but to tie the conversation back together, I think the extract method case I'm using has significantly more obscure rules to understand and preserve in a dynamic drop scenario than it does in a static drop (or eager drop) scenario. It is harder to reason about.

How about introducing a new take keyword to anoune that ownership should not return?
fn consume(take x: S){
}
fn f() {
  let x = S { ... };
  // extract from here:
  if a() {
    b();
    consume(take x);
  }
  // ...to here.
  c();
}

And the compiler will make sure that take/untake matches at argument in consumer function and the caller.

@bombless Unless I misunderstand your point, the x: S in fn consume(x: S) already says that ownership should not return.
I believe I had an oversight in how I looked at this issue: since eager drop doesn't specify when a value needs to be dropped (it sets a lower bound, not an upper bound - in which case, even the drop routine (as currently defined) wouldn't necessarily cause a variable to be dropped immediately), could it be said that both static drop (as described in RFC #210) and dynamic drop (as in current rust) would be compatible with eager drop (as described in RFC #239)? So that, if RFC #239 were adopted, the naive refactoring would still preserve rust's defined behavior, and this issue could be closed. On the other hand, any destructors with timing-relevant semantic meaning (such as MutexGuard) would have to be called buggy, since they'd be relying on undefined details about the implementation...


Merge pull request #2 from DavinderJolly/main

Co-authored-by: Davinder Jolly<EMAIL_ADDRESS>

Co-authored-by: Davinder Jolly<EMAIL_ADDRESS>


feat: general implement

ref to:
https://github.com/casbin/casbin-oa/blob/master/web/src/auth/Auth.js
@hsluoyz @Kininaru plz review
Signed-off-by: Zxilly<EMAIL_ADDRESS>

@Kininaru @sh1luo plz review

@Zxilly we have updated some API names, see: https://github.com/casbin/casbin-oa/commit/d67a3f5263d9c78441675e59da8c5e0a00b3af71
Plz update this PR.

@hsluoyz updated


Audio attribute will reload even if you add data-turbo-permanent

Hi, im trying to add a data-turbo-permanent to an audio element.
But when i click on any  attribute the audio restarts and the old one stays on the page and because off this you will hear the audio multiple times. Also tried data-turbo="false"
Somebody any idea how to fix this? (Searched for a discord for support but couldn't find it)

The data-turbo-permanent requires an id field (so Turbo knows which field to keep between the re-renders). Have you provided that attribute? Something like this:
<audio data-turbo-permanent id="audio-player"></audio>

Here's the documentation about it.
I'm closing this issue because it doesn't look like an issue with the package itself. If you disagree, please, feel free to reopen it and, please, provide more information about the problem you're having. Cheers.


ACL bug，Why does retrying a message require the send permission of the original topic

PlainAccessValidator  77

MQClientAPIImpl  1101

In my opinion, it seems like a tradeoff. If not so, any clients with subscription permission to one topic, but without publish permission, can also publish messages to that topic through SEND_MSG_BACK request.

After reviewing current resource policy, I think the following would be more reasonable:

CONSUMER_SEND_MSG_BACK: ONLY check group+SUB
SEND_MESSAGE, SEND_MESSAGE_V2:

For retry topic, check group+SUB, OR
topic+PUB

SEND_MESSAGE, SEND_MESSAGE_V2: use topic+PUB.

SEND_MESSAGE, SEND_MESSAGE_V2: use topic+PUB.

Under normal circumstances, no one will SEND_MESSAGE send retry topic, if he is blocked, it is reasonable. It should configure retry topic=PUB

SEND_MESSAGE, SEND_MESSAGE_V2: use topic+PUB.

Under normal circumstances, no one will SEND_MESSAGE send retry topic, if he is blocked, it is reasonable. It should configure retry topic=PUB

@Cczzzz Sending to retry topic through SEND_MESSAGE request exits, e.g.:
https://github.com/apache/rocketmq/blob/aacaf91539a90b18de21a988a204b5e842497352/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java#L377-L391
https://github.com/apache/rocketmq/blob/aacaf91539a90b18de21a988a204b5e842497352/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java#L586-L600

how about this. @caigy

 how about this. @caigy

if topic is Retry or DLQ checkout group SUB

@Cczzzz Some suggestions:

If publishing to a retry topic, get group name from it and check subscription permission to that group. Furthermore, checking DLQ topic is unnecessary, because no clients would publish to a DLQ topic directly.
For CONSUMER_SEND_MSG_BACK, check SUB permission of group, not retry topic.

Would you like to submit a PR? Let's fix it.

@Cczzzz Some suggestions:

If publishing to a retry topic, get group name from it and check subscription permission to that group. Furthermore, checking DLQ topic is unnecessary, because no clients would publish to a DLQ topic directly.
For CONSUMER_SEND_MSG_BACK, check SUB permission of group, not retry topic.

Would you like to submit a PR? Let's fix it.

Of course willing


Use swift/main for development

Now, main is used for development and automatically forwards to apple/swift/main

Please update update-checkout json file in the swiftlang/swift repo.


Manual Gripper Control is Broken

The gripper only responds to manual controls sporadically.

Fixed in release v1.3.24.


Use Atom's grammars instead of TextMate's when possible

This PR drops a number of TextMate grammars in favour of Atom's:

textmate/c.tmbundle       -> atom/language-c
textmate/css.tmbundle   -> atom/language-css
textmate/html.tmbundle -> atom/language-html
textmate/java.tmbundle -> atom/language-java
textmate/json.tmbundle -> atom/language-json
textmate/make.tmbundle -> atom/language-make
textmate/objective-c.tmbundle -> atom/language-objective-c
textmate/perl.tmbundle -> atom/language-perl
textmate/php.tmbundle   -> atom/language-php
textmate/sql.tmbundle   -> atom/language-sql
textmate/toml.tmbundle -> atom/language-toml
textmate/xml.tmbundle   -> atom/language-xml

Atom's grammars are updated far more frequently than TextMate's, and it doesn't take much snooping around their commit logs to notice this. This is especially important for fast-paced languages like CSS, where new properties are being introduced very often.

I think we should still check for each grammar that it improves highlighting. While I agree that Atom grammar seem to be evolving faster, TextMate grammars may still be better at highlighting in some cases.
@arfon What do you think?

Well, it'd surprise me if they did, considering Atom's grammars were originally derived from TextMate's...

Grammars for these fast-paced languages tend to grow rapidly. Despite the large number of automated tests in Atom grammars (that's certainly a plus), they are often subject to regressions.
For example, take the issue atom/language-javascript#366. The original TextMate grammar doesn't have the same issue (I think, thanks to @infininight's more conservative approach when it comes to merging pull requests), while the Atom grammar still does.
I'm not saying we should necessarily stick with TextMate's grammars. I even agree that in the long run we should probably move to Atom's grammars. But I think we should be careful and assess each grammar before switching.

Aye, I'm in no rush to get this merged.

I'm not saying we should necessarily stick with TextMate's grammars. I even agree that in the long run we should probably move to Atom's grammars. But I think we should be careful and assess each grammar before switching.

That sounds about right to me. In principal I think we should be moving away from un-maintained older grammars as long as there's an improvement in the user experience (syntax-highlighting).

Well, here's the first definite improvement. =)
I've been meaning to compile a full list, but tonnes of endeavours have my attention locked elsewhere.
(... in other words, I'm more than capable of flaggin' my own PR as stale, thaaank ye very much <3)

Okay, there's no way I'm picking through all these conflicts. Easiest thing to do would be to simply have another crack at it later. With evidence of improvement, to boot.


is this project dead?

The code still works, but it's been over 3 years since the latest commit (or for that matter, any word at all from @andredumas). There are a few minor bugs in various corners that you may or may not come across depending on your needs. But if you do encounter any, you'll probably need to fix them yourself. That, and the code is ES5 and integrating it with "modern" build tools and/or JS frameworks is not always super straight forward.
If you're using React, https://github.com/rrag/react-stockcharts is an alternative

While the code base is sound, and in a working state. There has been no progress, or response for a while.
I'm using this for some basic graphing, but without low level documentation, it's kinda hard to evolve.
I would wish for someone smarter than me to pick up this project, and carry it forward.

thanks for the info @trasherdk  and @briancappello. This is a cool lib but difficult to reason about without docs. The https://d3fc.io/ project is pretty cool, not as featured tho.


Fix #146 HTTPS links don't work when adding new torrent

Issue #147

Could you please add test for this?
Example can be found here, and you can add test in that class: https://github.com/werwolfby/monitorrent/blob/develop/tests/plugins/trackers/tests_lostfilm/test_lostfilmtracker.py#L75-L79
Just add one test with https example, and don't forget to push generated cassette

And could you please update commit message to:
fix(plugins/lostfilm): fix #146 https links don't work when adding new torrent

Changes Unknown when pulling 9be7f710e21af7294d010a74592765b30d8d2944 on XBeg9:fix/issue-146 into ** on werwolfby:develop**.

Current coverage is 99.94% (diff: 100%)

Merging #147 into develop will decrease coverage by 0.05%

@@           develop       #147   diff @@
=========================================
  Files           47         47
  Lines         3455       3455
  Methods          0          0
  Messages         0          0
  Branches         0          0
=========================================
- Hits          3455       3453     -2
- Misses           0          2     +2
  Partials         0          0

Powered by Codecov. Last update 3d2a528...9be7f71

Changes Unknown when pulling 660055d38850a536dadfe7e0c2a6872d9f1011b2 on XBeg9:fix/issue-146 into ** on werwolfby:develop**.

I have a bit different dev stack, could you please help me with this push generated cassette ? As I understand, it's here.. https://github.com/kevin1024/vcrpy but how to generate it? Don't to waste time digging into documentation. Thanks @werwolfby

Just run this test
You can do it by run run_test.cmd on windows

Update:
coverage run -m unittest discover -s tests
On all platforms

I don't know why AppVeyor is failing, any reasons? @werwolfby cassette has been added.

thank you @XBeg9 looks good.
I'll wait for checks and will merge the changes.

@XBeg9  AppVeyor on fault state for last two month :(
We are working on fixes, but now without any luck, so don't worry.

Changes Unknown when pulling c89e765b307475ff80301bc441eb3f3cb206bd1a on XBeg9:fix/issue-146 into ** on werwolfby:develop**.


Rearrange test/recipes/95-test_*.t to use skip_all

The conditions to skip these recipes entirely don't show in a
non-verbose test harness output.  We prefer to know, so use skip_all,
as it is a little bit more verbose.
[extended tests]

Checklist

[x] tests are added or updated

Merged. b83ace316282f05d8507561cc8129ec8491caade


compress/flate: Allow private dict/history buffer to be retrieved from flate.Reader

Original Discussion
This issue was submitted as a result of this thread:
https://groups.google.com/forum/#!topic/golang-dev/UND0JhtsV9s
Summary
The compress\flate package allows you to initialize a compressed reader using an existing dictionary by calling flate.NewReaderDict(r io.Reader, dict []byte). This is nice.  What would also be nice is a method to return the state of this []byte after some decompression has taken place.
The issue is that the history buffer can not be retrieved. Hopefully this can serve as a discussion as to whether the dictionary / history buffer should be exposed in stdlib. There's at least one use case for this that I know of, but I'd like to enumerate and discuss other potential uses.
Use Case
I'm using Go to implement a cabinet (cab) file extractor. The compression format used in many cab file is mszip. Mszip slightly modifies the block semantics of the flate algorithm by preserving the "history buffer" across block boundaries. This means each decompressed block is the result of an entire inflate operation requiring a new or reset reader for each block with one difference: every block (except the first) needs the history buffer carried over from previous blocks.
By adding this function to the flate package in the standard library (for testing purposes only; i don't suggest this as the solution to access the history)
func Dict(r io.ReadCloser) []byte {
    return r.(*decompressor).dict.hist
}

I am able to implement mszip without any other changes. Although I'm skeptical that this is a good stdlib feature and compression internals are not in my domain of expertise I am also not looking forward to maintaining a fork of compress/flate just for this function. Is there a reason that dict.hist is private other than the usual "nobody has needed it public"?
// example usage of flate.Dict

var (
    dict []byte
    zbuf = new(bytes.Buffer)
)

// zbuf filled with blocks

for zbuf.Len() > 0{
 zr := flate.NewReaderDict(zbuf, dict)
 _, err := plaintext.ReadFrom(zr)
 if err != nil{
     log.Fatalln(err)
 }
 dict = flate.Dict(zr)
}

What version of Go are you using (go version)?
go1.8rc3.windows-amd64

As mentioned in the linked discussion, there is a workaround which is to wrap the io.ReadCloser with a memoryReader:
// memoryReader wraps an io.Reader remembers up to 32KiB
// of the last bytes read.
type memoryReader struct {
	io.Reader
	Dict []byte
}

func (mr *memoryReader) Read(b []byte) (int, error) {
	const maxWindow = 1 << 15 // Maximum size of a DEFLATE window
	n, err := mr.Reader.Read(b)
	mr.Dict = append(mr.Dict, b[:n]...)
	if len(mr.Dict) > maxWindow {
		mr.Dict = mr.Dict[len(mr.Dict)-maxWindow:]
	}
	return n, err
}

The dictionary is literally the last (up to 32KiB) few bytes decompressed up until that point, so recording what those bytes were is all that is needed.
Any API additions to the Reader will inevitably lead to nasty package-level functions or interfaces that are not obvious to user how to use (e.g., I find the flate.Resetter interface really ugly).
If we want to add this functionality, I vote that we revisit this in Go2, when the API can be made cleaner.

The workaround works as expected and is documented on the issue tracker. I think we should consider this for Go2.


anagram: sync

Sync the anagram exercise with the latest data, as defined in https://github.com/exercism/problem-specifications/tree/main/exercises/anagram.

Feel free to close this PR if there is another PR that also syncs this exercise.
When approved, feel free to merge this PR yourselves (you don't have to wait for me).

As this PR only updates docs and/or metadata, it won't trigger a re-run of existing solutions (see the docs).

This is included in the housekeeping PR #189


profile get renders a alert: on status instead of the correct one

Noticed a difference between what's rendered for a profile that has alerts disabled.

profile

profile list gets the correct setting

profile get -i  gets the value as "on" instead of "off"

Forgot to close the issue 👍


Dead JS link

Propose changing to //translate.google.com.
https://github.com/i7eo/v-google-translate/blob/b987bdff3be6f56251ea96798b75f9b40cadbd3c/src/packages/src/index.vue#L452

Alright, i will check it in this weekend

You can change translate.google.cn to translate.google.com


Git Tools - Submodules - example repo does not exist

In describing Submodules (http://git-scm.com/book/en/v2/Git-Tools-Submodules), DbConnector repo was used. However, on attached link (https://github.com/chaconinc/DbConnector), which is used for explanation and examples, mentioned repo does not exist.

honor6-channe

Hey, so this is actually about the Pro Git book - I think you want to reopen this issue over at that repository.