question about source code

rw.invalid is true. Are there any conditions under which it becomes false?

https://github.com/thorvg/thorvg/blob/568846491da025b57823adc63ae4920c6e7c7eef/src/renderer/sw_engine/tvgSwRle.cpp#L924
2 I'm not very knowledgeable about this, so I don't understand the purpose of bandSize and Cell.
https://github.com/thorvg/thorvg/blob/568846491da025b57823adc63ae4920c6e7c7eef/src/renderer/sw_engine/tvgSwRle.cpp#L931
https://github.com/thorvg/thorvg/blob/568846491da025b57823adc63ae4920c6e7c7eef/src/renderer/sw_engine/tvgSwRle.cpp#L913

@rinechran Hello.

The maintainers here are all busy with plenty of tasks. If you have any issue on that, please come up with the context.
It can be quite challenging and frustrating to explain the difficult parts to someone who is unfamiliar with the basic code. In my experience, understanding complex logic directly from the code can be more intuitive and easier than following verbal instructions. If you consider yourself an experienced programmer, please review the code carefully.


[BUG]RuntimeError: cuda rng state model-parallel-rng is not added

Describe the bug
Running an error
Log output
Traceback (most recent call last):
File "/xxxxx/deepspeed_chat/training/step2_reward_model_finetuning/main.py", line 472, in
main()
File "/xxxxx/deepspeed_chat/training/step2_reward_model_finetuning/main.py", line 393, in main
outputs = rm_model(**batch, use_cache=False)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn
ret_val = func(*args, **kwargs)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 1731, in forward
loss = self.module(*inputs, **kwargs)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/xxxxx/deepspeed_chat/training/utils/model/reward_model.py", line 53, in forward
transformer_outputs = self.rwtranrsformer(
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/root/.cache/huggingface/modules/transformers_modules/THUDM/visualglm-6b/533d4ae86f232b1d7d04417398f572f71751c77d/modeling_chatglm.py", line 1462, in forward
image_embeds = self.image_encoder(images)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/root/.cache/huggingface/modules/transformers_modules/THUDM/visualglm-6b/533d4ae86f232b1d7d04417398f572f71751c77d/visual.py", line 69, in forward
enc = self.vit(image)[0]
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/root/.cache/huggingface/modules/transformers_modules/THUDM/visualglm-6b/533d4ae86f232b1d7d04417398f572f71751c77d/visual.py", line 28, in forward
return super().forward(input_ids=input_ids, position_ids=None, attention_mask=attention_mask, image=image)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/sat/model/base_model.py", line 144, in forward
return self.transformer(*args, **kwargs)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/sat/model/transformer.py", line 569, in forward
layer_ret = layer(*args, layer_id=torch.tensor(i), **kw_args, **output_cross_layer,
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/sat/model/transformer.py", line 330, in forward
return HOOKS_DEFAULT['layer_forward'](self, hidden_states, mask, *args, **kw_args)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/sat/transformer_defaults.py", line 127, in layer_forward_default
attention_output = self.attention(attention_input, mask, **kw_args)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/sat/model/transformer.py", line 103, in forward
return HOOKS_DEFAULT['attention_forward'](self, hidden_states, mask, **kw_args)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/sat/transformer_defaults.py", line 63, in attention_forward_default
context_layer = attention_fn(query_layer, key_layer, value_layer, mask, dropout_fn, **kw_args)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/sat/transformer_defaults.py", line 38, in standard_attention
with mpu.get_cuda_rng_tracker().fork():
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/contextlib.py", line 113, in enter
return next(self.gen)
File "/opt/conda/envs/rlhf_tw_test/lib/python3.8/site-packages/deepspeed/runtime/activation_checkpointing/checkpointing.py", line 174, in fork
raise Exception('cuda rng state {} is not added'.format(name))
Exception: cuda rng state model-parallel-rng is not added
Execute script:
deepspeed --include localhost:7 /xxxxx/deepspeed_chat/training/step2_reward_model_finetuning/main.py --data_output_path /xxxxx/deepspeed_chat/training/step2_reward_model_finetuning/data_output_zh_multi_model --model_name_or_path THUDM/visualglm-6b --num_padding_at_beginning 0 --per_device_train_batch_size 1 --per_device_eval_batch_size 1 --learning_rate 5e-4 --num_train_epochs 1 --gradient_accumulation_steps 1 --num_warmup_steps 0 --zero_stage 2 --deepspeed --output_dir /xxxxx/deepspeed_chat/training/step2_reward_model_finetuning/output_zh_multi_modal --lora_dim 2 --lora_module_name q_proj,k_proj --only_optimize_lora
pytorch:2.0.1
CUDA: 11
System info:
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 18.04.5 LTS
Release: 18.04
Codename: bionic

See here
from deepspeed.runtime.activation_checkpointing.checkpointing import _CUDA_RNG_STATE_TRACKER, _MODEL_PARALLEL_RNG_TRACKER_NAME
 _CUDA_RNG_STATE_TRACKER.add(_MODEL_PARALLEL_RNG_TRACKER_NAME, 1)

@XaviLv  Thank you very much ! It works !


Incorporate constraint package to WebSub/WebSubHub

Description:

$subject

@ayeshLK Shall we list down the possible usecase where the constraint facility can be engaged? For example, in HTTP package, this was engaged to Inbound payload data binding.


python_stubs/-378786325

I wanna ask what is ***/python_stubs/-378786325, because my python_stubs folder has many children folder like -320340808. Do I need to copy this torch folder to each of these children folder? Thanks a lot!

did you solve the problem?


Unable to rebuild library using get command

I want "rebuild" the course-presentation using the h5p-cli, but it seems that there're some libraries missing. To rebuild the package, I run the following commands:
/h5p # h5p get --https h5p-course-presentation
Looking up dependencies... DONE
cloning https://github.com/h5p/h5p-course-presentation.git
Cloning into 'h5p-course-presentation'... OK
cloning https://github.com/h5p/font-awesome.git
Cloning into 'font-awesome'... OK
cloning https://github.com/h5p/h5p-font-icons.git
Cloning into 'h5p-font-icons'... OK
cloning https://github.com/h5p/h5p-joubel-ui.git
Cloning into 'h5p-joubel-ui'... OK
cloning https://github.com/h5p/drop.git
Cloning into 'drop'... OK
cloning https://github.com/h5p/tether.git
Cloning into 'tether'... OK
cloning https://github.com/h5p/h5p-transition.git
Cloning into 'h5p-transition'... OK
cloning https://github.com/h5p/h5p-editor-course-presentation.git
Cloning into 'h5p-editor-course-presentation'... OK
cloning https://github.com/h5p/h5p-advanced-text.git
Cloning into 'h5p-advanced-text'... OK
cloning https://github.com/h5p/h5p-audio.git
Cloning into 'h5p-audio'... OK
cloning https://github.com/h5p/h5p-blanks.git
Cloning into 'h5p-blanks'... OK
cloning https://github.com/h5p/h5p-question.git
Cloning into 'h5p-question'... OK
cloning https://github.com/h5p/h5p-continuous-text.git
Cloning into 'h5p-continuous-text'... OK
cloning https://github.com/h5p/h5p-dialogcards.git
Cloning into 'h5p-dialogcards'... OK
cloning https://github.com/h5p/h5p-editor-vertical-tabs.git
Cloning into 'h5p-editor-vertical-tabs'... OK
cloning https://github.com/h5p/h5p-drag-n-bar.git
Cloning into 'h5p-drag-n-bar'... OK
cloning https://github.com/h5p/h5p-drag-n-drop.git
Cloning into 'h5p-drag-n-drop'... OK
cloning https://github.com/h5p/h5p-drag-n-resize.git
Cloning into 'h5p-drag-n-resize'... OK
cloning https://github.com/h5p/h5p-drag-question.git
Cloning into 'h5p-drag-question'... OK
cloning https://github.com/h5p/h5p-editor-drag-question.git
Cloning into 'h5p-editor-drag-question'... OK
cloning https://github.com/h5p/h5p-image.git
Cloning into 'h5p-image'... OK
cloning https://github.com/h5p/h5p-editor-wizard.git
Cloning into 'h5p-editor-wizard'... OK
cloning https://github.com/h5p/jquery-ui.git
Cloning into 'jquery-ui'... OK
cloning https://github.com/h5p/h5p-drag-text.git
Cloning into 'h5p-drag-text'... OK
cloning https://github.com/h5p/h5p-exportable-text-area.git
Cloning into 'h5p-exportable-text-area'... OK
cloning https://github.com/h5p/downloadify.git
Cloning into 'downloadify'... OK
cloning https://github.com/h5p/swfobject.git
Cloning into 'swfobject'... OK
cloning https://github.com/h5p/filesaver.git
Cloning into 'filesaver'... OK
cloning https://github.com/h5p/blob.git
Cloning into 'blob'... OK
cloning https://github.com/h5p/h5p-interactive-video.git
Cloning into 'h5p-interactive-video'... OK
cloning https://github.com/h5p/h5p-video.git
Cloning into 'h5p-video'... OK
cloning https://github.com/h5p/h5p-editor-interactive-video.git
Cloning into 'h5p-editor-interactive-video'... OK
cloning https://github.com/h5p/h5p-go-to-question.git
Cloning into 'h5p-go-to-question'... OK
cloning https://github.com/h5p/h5p-editor-timecode.git
Cloning into 'h5p-editor-timecode'... OK
cloning https://github.com/h5p/h5p-guided-tour.git
Cloning into 'h5p-guided-tour'... OK
cloning https://github.com/h5p/shepherd.git
Cloning into 'shepherd'... OK
cloning https://github.com/h5p/h5p-link.git
Cloning into 'h5p-link'... OK
cloning https://github.com/h5p/h5p-editor-url-field.git
Cloning into 'h5p-editor-url-field'... OK
cloning https://github.com/h5p/h5p-mark-the-words.git
Cloning into 'h5p-mark-the-words'... OK
cloning https://github.com/h5p/h5p-multi-choice.git
Cloning into 'h5p-multi-choice'... OK
cloning https://github.com/h5p/embeddedjs.git
Cloning into 'embeddedjs'... OK
cloning https://github.com/h5p/h5p-nil.git
Cloning into 'h5p-nil'... OK
cloning https://github.com/h5p/h5p-questionnaire.git
Cloning into 'h5p-questionnaire'... OK
cloning https://github.com/h5p/h5p-open-ended-question.git
Cloning into 'h5p-open-ended-question'... OK
cloning https://github.com/h5p/h5p-simple-multiple-choice.git
Cloning into 'h5p-simple-multiple-choice'... OK
cloning https://github.com/h5p/h5p-single-choice-set.git
Cloning into 'h5p-single-choice-set'... OK
cloning https://github.com/h5p/h5p-soundjs.git
Cloning into 'h5p-soundjs'... OK
cloning https://github.com/h5p/h5p-summary.git
Cloning into 'h5p-summary'... OK
cloning https://github.com/h5p/h5p-editor-summary-textual-editor.git
Cloning into 'h5p-editor-summary-textual-editor'... OK
cloning https://github.com/h5p/h5p-table.git
Cloning into 'h5p-table'... OK
cloning https://github.com/h5p/h5p-text.git
Cloning into 'h5p-text'... OK
cloning https://github.com/h5p/h5p-true-false.git
Cloning into 'h5p-true-false'... OK
cloning https://github.com/h5p/h5p-editor-radio-group.git
Cloning into 'h5p-editor-radio-group'... OK
cloning https://github.com/h5p/h5p-editor-color-selector.git
Cloning into 'h5p-editor-color-selector'... OK
cloning https://github.com/h5p/h5p-editor-duration.git
Cloning into 'h5p-editor-duration'... OK
cloning https://github.com/GriffWith/h5p-twitter-user-feed.git
Cloning into 'h5p-twitter-user-feed'... OK
cloning https://github.com/h5p/h5p-editor-radio-selector.git
Cloning into 'h5p-editor-radio-selector'... OK
/tmp # h5p pack -r h5p-course-presentation/
Packing 1 library to file...
Adding 56 dependencies to file...
h5p-course-presentation OK 1.24.1
font-awesome OK 4.5.4
h5p-joubel-ui OK 1.3.12
tether OK 1.0.2
h5p-font-icons OK 1.0.6
drop OK 1.0.2
h5p-transition OK 1.0.4
h5p-editor-course-presentation OK 1.24.2
h5p-drag-n-bar OK 1.5.15
h5p-drag-n-drop OK 1.1.5
h5p-drag-n-resize OK 1.2.6
h5p-image OK 1.1.13
h5p-advanced-text OK 1.1.12
h5p-editor-url-field OK 1.2.2
h5p-continuous-text OK 1.2.14
h5p-link OK 1.3.15
h5p-table OK 1.1.16
h5p-audio OK 1.5.0
h5p-blanks OK 1.14.0
h5p-video OK 1.6.5
h5p-single-choice-set OK 1.11.18
h5p-question OK 1.5.1
h5p-soundjs OK 1.0.2
h5p-editor-vertical-tabs OK 1.3.9
h5p-multi-choice OK 1.16.2
h5p-true-false OK 1.8.0
embeddedjs OK 1.0.4
h5p-drag-question OK 1.14.5
h5p-editor-radio-group OK 1.1.4
jquery-ui OK 1.10.22
h5p-editor-drag-question OK 1.10.19
h5p-summary OK 1.10.13
h5p-editor-wizard OK 1.2.15
h5p-editor-summary-textual-editor OK 1.1.10
filesaver OK 1.0.6
h5p-exportable-text-area OK 1.3.11
blob OK 1.0.6
downloadify OK 1.0.3
swfobject OK 1.0.2
h5p-interactive-video OK 1.24.1
h5p-editor-interactive-video OK 1.24.0
h5p-text OK 1.1.15
h5p-editor-duration OK 1.1.12
h5p-editor-color-selector OK 1.3.1
h5p-drag-text OK 1.10.1
h5p-mark-the-words OK 1.11.0
h5p-guided-tour OK 1.0.6
h5p-editor-timecode OK 1.2.12
shepherd OK 1.0.3
h5p-questionnaire OK 1.3.5
h5p-go-to-question OK 1.3.13
h5p-open-ended-question OK 1.0.21
h5p-simple-multiple-choice OK 1.1.16
h5p-dialogcards OK 1.9.2
h5p-editor-radio-selector OK 1.2.2
h5p-twitter-user-feed OK 1.0.1
h5p-nil OK 1.0.14

This gives me a "libraries.h5p" which includes 57 directories and 1 file. When I try to install the package (in my case in Moodle), it tells me that the package is invalid. Now, I compared the "original" H5P course presentation from https://api.h5p.org/v1/content-types/H5P.CoursePresentation which contains 70 directories and when I try to install it, everything is fine.
I compared both h5p files and the following folders/files are missing:

content: Not sure how to "generate" this folder?!
H5P.AudioRecorder-1.0
H5P.CKEditor-1.0
H5P.FreeTextQuestion-1.0
H5P.IVHotspot-1.2
H5P.Shape-1.0
H5P.TextUtilities-1.3
H5PEditor.RangeList-1.0
H5PEditor.SelectToggleFields-1.1
H5PEditor.Shape-1.0
H5PEditor.ShowWhen-1.0
H5PEditor.SingleChoiceSetTextualEditor-1.0
H5PEditor.TableList-1.0
h5p.json: Not sure how to "generate" this file?!

Any idea why these files/folder are missing and also not fetched by h5p get command?

Ok, it seems that I'm missing the build-command. But I wonder if there's a "mass"-build command because I don't want to build all libraries by going into the directory, call npm install and npm run build...

@timvol I assume repositories that are missing are not listed where they should be listed, but you can clone them from git of course - even though that's manual labor.
I don't think the H5P CLI tool doesn't have an inbuilt build command yet, but a simple bash script should be able to do the job.

h5p-cli core functionality has been rewritten. Try using new setup flow.


Switch to using Godot's High-Level Multiplayer API via the NakamaMultiplayerBridge

@dsnopek looks good to me, though should the addons folder be in source control?

should the addons folder be in source control?

There isn't really a better way to do it. We can't use a Git submodule because the paths would be wrong. Godot doesn't have a package manager to automatically pull dependencies in. I suppose we could write a script to download the version of the addon we want? That's not a standard practice or anything, though, folks generally expect to be able to checkout a game's source and have everything there they need to run the game.

@dsnopek no worries -- didn't realize Godot didn't have a package manager. Agreed it's the best solution until then 👍


xfreerdp fails to connect when one host out of several is down

Hi,
We rebooted our three xrdp servers today. They are load balancing behind haproxy. DNS returns three IP addresses in response to an A query against (details anonymised) xrdp.domain:
:) bduncan@fry:~$ host xrdp
xrdp.domain has address <IP_ADDRESS>
xrdp.domain has address <IP_ADDRESS>
xrdp.domain has address <IP_ADDRESS>
:) bduncan@fry:~$

Today, one of the servers got bricked and we had to rebuild it. My DNS cached the above result for a long time.
When I run xfreerdp /v:xrdp.domain I expect to get a connection to one of the remaining working hosts, even though one of them gives ECONNREFUSED on 3389.
Instead, I get this error:
[16:16:41:077] [12220:12221] [INFO][com.freerdp.client.common.cmdline] - loading channelEx cliprdr
[16:16:41:078] [12220:12221] [INFO][com.freerdp.client.x11] - No user name set. - Using login name: bduncan
[16:16:41:084] [12220:12221] [ERROR][com.freerdp.core.transport] - BIO_should_retry returned a system error 32: Broken pipe
[16:16:41:084] [12220:12221] [ERROR][com.freerdp.core.nego] - Protocol Security Negotiation Failure
[16:16:41:084] [12220:12221] [ERROR][com.freerdp.core] - freerdp_set_last_error ERRCONNECT_SECURITY_NEGO_CONNECT_FAILED [0x0002000C]
[16:16:41:084] [12220:12221] [ERROR][com.freerdp.core.connection] - Error: protocol security negotiation or connection failure

(lots of messages about security negotiation despite the server returning a clear Connection Refused!)
I can connect to any of the remaining servers directly, but not using this DNS name.
It looks to me like xfreerdp is trying to connect to each IP address simultaneously and acts on the first response it receives. Since the failure is much easier, it arrives first, so the whole connection fails:
:) bduncan@fry:~$ strace -ffs 9999 -e connect xfreerdp /v:xrdp.domain +glyph-cache
connect(10, {sa_family=AF_UNIX<EMAIL_ADDRESS>20) = 0
strace: Process 12259 attached
[16:17:05:462] [12258:12259] [INFO][com.freerdp.client.common.cmdline] - loading channelEx cliprdr
[pid 12259] connect(12, {sa_family=AF_UNIX, sun_path="/var/run/nscd/socket"}, 110) = -1 ENOENT (No such file or directory)
[pid 12259] connect(12, {sa_family=AF_UNIX, sun_path="/var/run/nscd/socket"}, 110) = -1 ENOENT (No such file or directory)
[16:17:05:464] [12258:12259] [INFO][com.freerdp.client.x11] - No user name set. - Using login name: bduncan
[pid 12259] connect(12, {sa_family=AF_UNIX<EMAIL_ADDRESS>20) = 0
strace: Process 12260 attached
strace: Process 12261 attached
strace: Process 12262 attached
strace: Process 12263 attached
[pid 12259] connect(19, {sa_family=AF_UNIX, sun_path="/var/run/nscd/socket"}, 110) = -1 ENOENT (No such file or directory)
[pid 12259] connect(19, {sa_family=AF_UNIX, sun_path="/var/run/nscd/socket"}, 110) = -1 ENOENT (No such file or directory)
[pid 12259] connect(19, {sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr("<IP_ADDRESS>")}, 16) = 0
[pid 12259] connect(19, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("<IP_ADDRESS>")}, 16) = 0
[pid 12259] connect(19, {sa_family=AF_UNSPEC, sa_data="\0\0\0\0\0\0\0\0\0\0\0\0\0\0"}, 16) = 0
[pid 12259] connect(19, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("<IP_ADDRESS>")}, 16) = 0
[pid 12259] connect(19, {sa_family=AF_UNSPEC, sa_data="\0\0\0\0\0\0\0\0\0\0\0\0\0\0"}, 16) = 0
[pid 12259] connect(19, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("<IP_ADDRESS>")}, 16) = 0
[pid 12259] connect(19, {sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr("<IP_ADDRESS>")}, 16) = 0
[pid 12259] connect(19, {sa_family=AF_INET, sin_port=htons(3389), sin_addr=inet_addr("<IP_ADDRESS>")}, 16) = 0
[pid 12259] connect(19, {sa_family=AF_UNSPEC, sa_data="\0\0\0\0\0\0\0\0\0\0\0\0\0\0"}, 16) = 0
[pid 12259] connect(19, {sa_family=AF_INET, sin_port=htons(3389), sin_addr=inet_addr("<IP_ADDRESS>")}, 16) = 0
[pid 12259] connect(19, {sa_family=AF_UNSPEC, sa_data="\0\0\0\0\0\0\0\0\0\0\0\0\0\0"}, 16) = 0
[pid 12259] connect(19, {sa_family=AF_INET, sin_port=htons(3389), sin_addr=inet_addr("<IP_ADDRESS>")}, 16) = 0
[pid 12259] connect(19, {sa_family=AF_INET, sin_port=htons(3389), sin_addr=inet_addr("<IP_ADDRESS>")}, 16) = -1 EINPROGRESS (Operation now in progress)
[16:17:05:477] [12258:12259] [ERROR][com.freerdp.core.transport] - BIO_should_retry returned a system error 32: Broken pipe
[16:17:05:477] [12258:12259] [ERROR][com.freerdp.core.nego] - Protocol Security Negotiation Failure
[16:17:05:477] [12258:12259] [ERROR][com.freerdp.core] - freerdp_set_last_error ERRCONNECT_SECURITY_NEGO_CONNECT_FAILED [0x0002000C]
[16:17:05:477] [12258:12259] [ERROR][com.freerdp.core.connection] - Error: protocol security negotiation or connection failure
[pid 12260] +++ exited with 0 +++
[pid 12263] +++ exited with 0 +++
[pid 12262] +++ exited with 0 +++
[pid 12261] +++ exited with 0 +++
[pid 12259] +++ exited with 0 +++
+++ exited with 133 +++
:) bduncan@fry:~$ xfreerdp +version
This is FreeRDP version 2.0.0-dev5 (2693389a+debian)
:) bduncan@fry:~$ xfreerdp /buildconfig
This is FreeRDP version 2.0.0-dev5 (2693389a+debian)
Build configuration: BUILD_TESTING=OFF BUILTIN_CHANNELS=ON HAVE_AIO_H=1 HAVE_EXECINFO_H=1 HAVE_FCNTL_H=1 HAVE_INTTYPES_H=1 HAVE_JOURNALD_H=TRUE HAVE_MATH_C99_LONG_DOUBLE=1 HAVE_POLL_H=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK=ON HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL= HAVE_SYSLOG_H=1 HAVE_SYS_EVENTFD_H=1 HAVE_SYS_FILIO_H= HAVE_SYS_MODEM_H= HAVE_SYS_SELECT_H=1 HAVE_SYS_SOCKIO_H= HAVE_SYS_STRTIO_H= HAVE_SYS_TIMERFD_H=1 HAVE_TM_GMTOFF=1 HAVE_UNISTD_H=1 HAVE_XI_TOUCH_CLASS=1 WITH_ALSA=ON WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CUPS=ON WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_CLIPRDR=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DSP_EXPERIMENTAL=OFF WITH_EVENTFD_READ_WRITE=1 WITH_FAAC=OFF WITH_FAAD2=OFF WITH_FFMPEG=OFF WITH_GFX_H264=OFF WITH_GPROF=OFF WITH_GSM=OFF WITH_GSSAPI=OFF WITH_GSTREAMER_0_10=OFF WITH_GSTREAMER_1_0=ON WITH_ICU=ON WITH_IPP=OFF WITH_JPEG=ON WITH_LAME=OFF WITH_LIBRARY_VERSIONING=ON WITH_LIBSYSTEMD=ON WITH_MACAUDIO=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_OPENH264=OFF WITH_OPENSLES=OFF WITH_OPENSSL=ON WITH_OSS=ON WITH_PAM=ON WITH_PCSC=ON WITH_PROFILER=OFF WITH_PULSE=ON WITH_SAMPLE=OFF WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_MEMORY=OFF WITH_SANITIZE_MEMORY_AVAILABLE=1 WITH_SANITIZE_THREAD=OFF WITH_SANITIZE_THREAD_AVAILABLE=1 WITH_SERVER=ON WITH_SERVER_CHANNELS=ON WITH_SERVER_INTERFACE=ON WITH_SMARTCARD_INSPECT=OFF WITH_SOXR=OFF WITH_SSE2=ON WITH_THIRD_PARTY=OFF WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_WAYLAND=ON WITH_X11=ON WITH_X264=OFF WITH_XCURSOR=ON WITH_XDAMAGE=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=ON WITH_XKBFILE=ON WITH_XRANDR=ON WITH_XRENDER=ON WITH_XSHM=ON WITH_XTEST=ON WITH_XV=ON WITH_ZLIB=ON
Build type:          RELWITHDEBINFO
CFLAGS:              -g -O2 -fdebug-prefix-map=/build/freerdp2-yLCxhl/freerdp2-2.0.0~git20190204.1.2693389a+dfsg1=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -Wall -Wno-unused-result -Wno-unused-but-set-variable -Wno-deprecated-declarations -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -g -DWINPR_DLL
Compiler:            GNU, 8.2.0
Target architecture: x64
:) bduncan@fry:~$ grep ^PRETTY_NAME= /etc/os-release
PRETTY_NAME="Ubuntu Disco Dingo (development branch)"
:) bduncan@fry:~$ dpkg -l \*freerdp\*
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                       Version                              Architecture Description
+++-==========================-====================================-============-=====================================================
un  freerdp                    <none>                               <none>       (no description available)
un  freerdp-x11                <none>                               <none>       (no description available)
ii  freerdp2-x11               2.0.0~git20190204.1.2693389a+dfsg1-1 amd64        RDP client for Windows Terminal Services (X11 client)
un  libfreerdp-client2         <none>                               <none>       (no description available)
ii  libfreerdp-client2-2:amd64 2.0.0~git20190204.1.2693389a+dfsg1-1 amd64        Free Remote Desktop Protocol library (client library)
un  libfreerdp2                <none>                               <none>       (no description available)
ii  libfreerdp2-2:amd64        2.0.0~git20190204.1.2693389a+dfsg1-1 amd64        Free Remote Desktop Protocol library (core library)
:) bduncan@fry:~$

Happy to reproduce with more debugging if necessary.
Hope that's enough detail. Thanks for all your hard work :)

Currently freerdp only connects to the first address returned by the resolver (see freerdp_tcp_connect)
Changing that to try each returned address and use the first successful tcp connection should be possible.

Hi @akallabeth

Currently freerdp only connects to the first address returned by the resolver (see freerdp_tcp_connect)

From the strace above it looks like freerdp is connecting to all of the addresses returned from the resolver.

Changing that to try each returned address and use the first successful tcp connection should be possible.

That would be great! From my naive reading I would have said that freerdp_tcp_connect_multi should do exactly that.

It tries some different types of connection first.
freerdp_tcp_connect_multi is indeed such a function, but for a specialized case.
Most likely needs some adjustments to correctly work.


Us33922 new

Description:

Related issue(s):
Fixes #
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

closing this PR as latest one merged


Need a clearer component in the storybook.

I think the advantage of storybooks is to intuitively show what changes occur in various ways, such as changing props of components.
However, I don't think the current components are enough to show this behavior.
Of course, if users are already familiar with the storybook, they will use it without difficulty. However, I think the user base who is looking for boilerplate is mostly next(or.. react) beginners.
I think putting components such as very simple buttons with props in a storybook for them would also help react beginners accessing this project.

Our opinion are different but agree about the example is maybe not intuitively. So, I'm totally open to pull request.
The goal of a boilerplate is not to teach people. There are already a lot of resources online to learn (in this case, learn storybook): tutorial, official documentation, etc... The goal of the boilerplate is to provide configuration, so developers don't lose the time to configure from scratch. So, the user base can be beginner but also intermediate or advanced users.
Of course, they can add their own configuration or remove some configuration we don't want. The boilerplate is a just a starting point. At least this is how I use the boilerplate myself.

It was definitely my guess to use it for beginners😞
Nevertheless, I think a few more examples are needed for the storybook. If there was a component in it that had a prop, I thought it would save me some time to look for documentation while developing, saying, 'How did I add a prop to this...?'
If you don't think the boilerplate fits this, you can close the issue. That's okay.
This is just my idea, and I respect your opinion :)

Actually, I'm not proficient in Storybook and implemented the storybook based on: : https://github.com/ixartz/Next-js-Boilerplate/issues/103. It's the first time I'm using Storybook, definitively we can make it more easier to use.
So, totally open to PR to improve it if you are thinking about a few more examples we can add.


Question (not an issue):

Sorry for listing a question here, but I saw no other way of contacting you, Paul.  I am successfully using the WEPopover, but I would like to know how to make a slight alteration.
I am showing an image full screen.  I have the popover showing the image's metadata when a navigation button is tapped.  I can show the data but it is on the popup as-is (white font, dark popup background).  I've played with the settings for alpha, clearColor backgrounds, etc, but I cannot get the popup to be transparent (or nearly...somewhere around apha .3) with non-transparent white font.
How to alter code to have a nearly transparent background on the popover, rather than a dark background..  I'm using iOS 5 and storyboard.
Thanks in advance!

I should mention:  I can make the popup transparent now, by setting alpha to .5 in  presentpopoverFromRect:inView:permittedArrowDirections:animated: under the if (animated) section where animation typically goes from 0.0 to 1.0  (great!).  but how to get the labels from being transparent.  I've tried setting their individual alphas to 1.0 and their individual opaque to NO.

Hi Rodney,
Sorry for the lack of contact information. I've updated my email on
github.com<EMAIL_ADDRESS>Have you changed the background graphic? It's not transparent, so you'll
need to add transparency.
-Paul Solt
On Thu, Jan 5, 2012 at 2:55 PM, RodneyJ725 <
<EMAIL_ADDRESS>
wrote:

Sorry for listing a question here, but I saw no other way of contacting
you, Paul.  I am successfully using the WEPopover, but I would like to know
how to make a slight alteration.
I am showing an image full screen.  I have the popover showing the image's
metadata when a navigation button i tapped.  I can show the data but it is
on the popup as-is (white font, dark popup background).  I've played with
the settings for alpha, clearColor backgrounds, etc, but I cannot get the
popup to be transparent (or nearly...somewhere around apha .3) with
non-transparent white font.
How to alter code to have a nearly transparent background on the popover,
rather than a dark background..  I'm using iOS 5 and storyboard.
Thanks in advance!

Reply to this email directly or view it on GitHub:
https://github.com/PaulSolt/WEPopover/issues/7

--
Paul Solt
<EMAIL_ADDRESS>215-341-0407 (Cell)
http://www.PaulSolt.com/
Creative apps for iPhone and iPad: http://www.ArtworkEvolution.com/

Hi Paul,
Thanks for the reply.  Ive not changed the background image for the popover (i did not know one was being used).  Upon first look, I see a bgImangeName but I do not see where the image view is set, so I can try to play with its alpha.  Or am I looking in the wrong place?

Change the bgImage.png resource that should be in the project. You'll need
to use a photo editing app (PhotoShop, etc) to change transparency on the
.png file.
I added drop shadow (semi-transparent) when I forked the WEPopover project.
However, you'll need to make the main part of the image transparent.
-Paul Solt
On Thu, Jan 5, 2012 at 6:31 PM, RodneyJ725 <
<EMAIL_ADDRESS>
wrote:

Hi Paul,
Thanks for the reply.  Ive not changed the background image for the
popover (i did not know one was being used).  Upon first look, I see a
bgImangeName but I do not see where the image view is set, so I can try to
play with its alpha.  Or am I looking in the wrong place?

Reply to this email directly or view it on GitHub:
https://github.com/PaulSolt/WEPopover/issues/7#issuecomment-3378396

--
Paul Solt
<EMAIL_ADDRESS>215-341-0407 (Cell)
http://www.PaulSolt.com/
Creative apps for iPhone and iPad: http://www.ArtworkEvolution.com/

I see.  OK, thanks for your help and guidance, Paul!

Did that work? Can you post how it looks with transparency?


Can't delete objects via REPL: InternalServerError: relation "..." does not exists

EdgeDB Version: EdgeDB CLI 2.0.4+a7fc49b, server is 1.4 Docker image on GCP
OS Version: masOS Monterey 12.4

I added an endpoint to my new FastAPI application - one which connects to an EdgeDB instance previously accessed from my JavaScript app. It simply collects form data and creates a new Merchant, but as you can see by the below I'm unable to delete the created Merchants from the REPL after.
dev> select Merchant { name, merchant_id, logo_url, emails, wallets, locations, website, business_types, main_contact_index } filter .name = "Michael";
{
  default::Merchant {
    name: 'Michael',
    merchant_id: '34550715062af006ac4fab288de67ecb44793c3a05c475227241535f6ef7a81b',
    logo_url: '',
    emails<EMAIL_ADDRESS>    wallets: ['2umBR0hVvii7XbwL6RYmwJfmvj9dpv5LNE3hDYHqQ7LMjVxJZi0bkJ7CqXkuDKeiKWz2K7flpBLi01ln'],
    locations: ['Here, TH'],
    website: {},
    business_types: ['{business_type}'],
    main_contact_index: 0,
  },
}
dev> delete Merchant filter .name = "Michael";
edgedb error: InternalServerError: relation "edgedbpub.e63d2cdc-1e65-11ed-8843-43d0592a625a_t" does not exist
  Hint: This is most likely a bug in EdgeDB. Please consider opening an issue ticket at https://github.com/edgedb/edgedb/issues/new?template=bug_report.md
  Server traceback:
      edb.errors.InternalServerError: relation "edgedbpub.e63d2cdc-1e65-11ed-8843-43d0592a625a_t" does not exist
dev> delete Merchant filter .merchant_id = "34550715062af006ac4fab288de67ecb44793c3a05c475227241535f6ef7a81b";
edgedb error: InternalServerError: relation "edgedbpub.e63d2cdc-1e65-11ed-8843-43d0592a625a_t" does not exist
  Hint: This is most likely a bug in EdgeDB. Please consider opening an issue ticket at https://github.com/edgedb/edgedb/issues/new?template=bug_report.md
  Server traceback:
      edb.errors.InternalServerError: relation "edgedbpub.e63d2cdc-1e65-11ed-8843-43d0592a625a_t" does not exist

Steps to Reproduce:

I simply added a new endpoint to my application to create a Merchant object, e.g. insert Merchant { name := "Michael", merchant_id := "...", ... }
Attempt to delete the merchant based on either the name or merchant_id fields (secondary, primary key analogs respectively).

Schema:
dbschema.zip

This bug can be reproduced with the schema:
module default {
    type M;
    abstract type Base { link l -> M };
    type A extending Base;
    type B extending Base;
    type L { link l -> A | B };
}

and doing insert M; delete M;
The problem is that we are including the type A | B in the triggers!

There's another nasty issue here which is that the migration scripts won't apply on 2.x, because of the insert in a default. See https://github.com/edgedb/edgedb/issues/3592#issuecomment-1239797739.
I discuss some of the issues involved there in https://github.com/edgedb/edgedb/issues/4330

Ouch.... that one might hurt come upgrade time. I'll hold off on upgrading, then - is #4329 (above) only available in 2.x?


assingRequest signature is incorrectly depicted in docs.

The signature of assignRequest function example is incorrectly depicted in the documentation.
The signature should be appsmith.workflows.assignRequest() and not assignRequest
Docs link : https://docs.appsmith.com/workflows/reference/workflow-functions

@parth-appsmith - Raised a PR to fix this. For all doc-related issues or changes, please raise them on the appsmith-docs repo.


pydeck: Enforce pydeck notebook deck.gl semver on sdist

For #4103

Background

Change List

Coverage remained the same at 80.852% when pulling 41627ed4bd07ff1f3beff96154ce75a4d79b0ad1 on ajd/locking into 4626d36bba6d622aee607163b3f61f2c567dfa3d on master.

If I understand this correctly, it will block the ability to publish beta versions of pydeck that depends on a beta version of deck.gl.

If I understand this correctly, it will block the ability to publish beta versions of pydeck that depends on a beta version of deck.gl.

There's nothing currently enforcing that a particular prerelease of pydeck depends on a prerelease of deck.gl, thought I can add that check. This just simply makes sure that a maintainer is intentional about the deck.gl release paired with pydeck.


Composer create-project syntax

We should add this to packagist so we can install via composer create-project command.
https://getcomposer.org/doc/03-cli.md#create-project

This is built into the main project repo in https://github.com/quickenloans-mcp/mcp-panthor as of version 3.3.0. We use composer script events (post create-project) .


code error is this.include

https://github.com/serebrov/emoji-mart-vue/blob/2d6ec8aeaf0cc29efd936fa68da45521bfd76383/src/components/StaticPicker.vue#L179
Sorry, I didn't find where the include came from

should is props?

and this.exclude
https://github.com/serebrov/emoji-mart-vue/blob/2d6ec8aeaf0cc29efd936fa68da45521bfd76383/src/components/StaticPicker.vue#L183

https://github.com/serebrov/emoji-mart-vue/blob/master/src/utils/shared-props.js
not found

@yoonasy actually the include and exclude are properties of the EmojiIndex class, not of the component.
So having them used in the StaticPicker is definitely a bug, also it should be harmless as this.include and this.exclude are used in the condition and should always return false.
Are you hitting some issue because of it?
If you just want to actually filter the data, you can use code like this:
 <template>
  <StaticPicker :data="indexInclude" />
 </template>

<script>
  const indexInclude = new EmojiIndex(data, {
    include: ['nature', 'smileys', 'recent'],
  })

  export default {
    data() {
      return {
        indexInclude: indexInclude
      }
    },
    components: {
      StaticPicker,
    },
}

</script>

See the complete example in the demo app.
Note for me: these properties were originally the in the picker component, should be safe to remove.

thank u, resolved


Functionality Split: Completing vs Deleting

Hello,
Would be nice to have a differentiation between completing a ticket and deleting it.  I would like to have two different nodes, so that my mods can complete but not delete and my admins can delete them.
This might lead to either having two lists, one for 'active' and 'completed' tickets, or having another column in /ticket list that says whether it has been completed or not.
Thanks.

Completed for v1.1.0.

Would it be possible to just split the delete / complete stuff so it's two commands?


[Feature request] Translate a pdf from one language to another and return the already translated pdf

The truth is that there are fewer and fewer things left to improve in your project! It's amazing and very good!. So maybe you're suggesting this improvement and you already have it planned or it's been requested.
Or maybe it's something too complex, but I think it would be an incredible tool, to be able to upload a pdf in one language and have your platform return it in another language with the same structure as the pdf, or maybe in a docx it could also be valid if it's easier to develop.
I edit, I forgot another topic: I don't know if a platform like the one you have developed could do something that I have been looking for a long time in docker or selfhosted, it would be to monitor a folder and be able to print on the default printer that is configured, so that all the PDFs that arrive in that folder are printed instantly. There are really tedious workloads when receiving hundreds of PDFs in multiple emails.
In any case, I appreciate the assessment of this improvement. Best regards.

Hey good to see you, I know you been here since Stirling-PDF first started!
As it is sadly translations are not yet possible.
Once we find a good way to provide realtime text editting within the PDF we can approach this but since we are not currently able to edit the text we can no provide translations etc.
One of the main reasons is the "maintain formatting" part
a 4 letter word could be replaced with a 10 letter translation, with formatting in mind thats a huge mess for PDFs
So no plans to support currently sorry

@NexusEFR could you create a new issue for the second feature request? Thanks!


No video formats found error for youtube link 'https://www.youtube.com/watch?v=_CMBCfxN1lU'

Checklist

[ ] I'm reporting a broken site support issue
[ ] I've verified that I'm running youtube-dl version 2021.06.06
[ ] I've checked that all provided URLs are alive and playable in a browser
[ ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ ] I've searched the bugtracker for similar bug reports including closed ones
[ ] I've read bugs section in FAQ

Verbose log

youtube_dl.utils.DownloadError: ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.```

## Description

<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->

WRITE DESCRIPTION HERE

Be sure to call youtube-dl with the --verbose flag and include its complete output.

Do not ignore this very important part.

Works for me:
youtube-dl -v -F 'https://www.youtube.com/watch?v=_CMBCfxN1lU'[debug] System config: ['--prefer-ffmpeg']
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-F', 'https://www.youtube.com/watch?v=_CMBCfxN1lU']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.5.2 (CPython) - Linux-4.4.0-210-generic-i686-with-Ubuntu-16.04-xenial
[debug] exe versions: avconv 4.3, avprobe 4.3, ffmpeg 4.3, ffprobe 4.3
[debug] Proxy map: {}
[youtube] _CMBCfxN1lU: Downloading webpage
[youtube] _CMBCfxN1lU: Downloading player 408a20d8
[info] Available formats for _CMBCfxN1lU:
format code  extension  resolution note
249          webm       audio only tiny   44k , webm_dash container, opus @ 44k (48000Hz), 1.30MiB
250          webm       audio only tiny   56k , webm_dash container, opus @ 56k (48000Hz), 1.64MiB
251          webm       audio only tiny  102k , webm_dash container, opus @102k (48000Hz), 2.98MiB
140          m4a        audio only tiny  129k , m4a_dash container, mp4a.40.2@129k (44100Hz), 3.76MiB
394          mp4        256x144    144p   65k , mp4_dash container, av01.0.00M.08@  65k, 25fps, video only, 1.91MiB
160          mp4        256x144    144p   67k , mp4_dash container, avc1.4d400c@  67k, 25fps, video only, 1.97MiB
278          webm       256x144    144p   87k , webm_dash container, vp9@  87k, 25fps, video only, 2.53MiB
395          mp4        426x240    240p  104k , mp4_dash container, av01.0.00M.08@ 104k, 25fps, video only, 3.03MiB
133          mp4        426x240    240p  129k , mp4_dash container, avc1.4d4015@ 129k, 25fps, video only, 3.74MiB
242          webm       426x240    240p  143k , webm_dash container, vp9@ 143k, 25fps, video only, 4.17MiB
396          mp4        640x360    360p  198k , mp4_dash container, av01.0.01M.08@ 198k, 25fps, video only, 5.74MiB
243          webm       640x360    360p  259k , webm_dash container, vp9@ 259k, 25fps, video only, 7.52MiB
134          mp4        640x360    360p  326k , mp4_dash container, avc1.4d401e@ 326k, 25fps, video only, 9.46MiB
397          mp4        854x480    480p  337k , mp4_dash container, av01.0.04M.08@ 337k, 25fps, video only, 9.78MiB
244          webm       854x480    480p  438k , webm_dash container, vp9@ 438k, 25fps, video only, 12.70MiB
135          mp4        854x480    480p  649k , mp4_dash container, avc1.4d401e@ 649k, 25fps, video only, 18.83MiB
398          mp4        1280x720   720p  622k , mp4_dash container, av01.0.05M.08@ 622k, 25fps, video only, 18.05MiB
247          webm       1280x720   720p  815k , webm_dash container, vp9@ 815k, 25fps, video only, 23.63MiB
136          mp4        1280x720   720p 1172k , mp4_dash container, avc1.4d401f@1172k, 25fps, video only, 33.99MiB
399          mp4        1920x1080  1080p 1050k , mp4_dash container, av01.0.08M.08@1050k, 25fps, video only, 30.45MiB
248          webm       1920x1080  1080p 1371k , webm_dash container, vp9@1371k, 25fps, video only, 39.77MiB
137          mp4        1920x1080  1080p 2033k , mp4_dash container, avc1.640028@2033k, 25fps, video only, 58.95MiB
18           mp4        640x360    360p  536k , avc1.42001E, 25fps, mp4a.40.2 (44100Hz), 15.55MiB (best)
$

Let me try again with --verbose flag.
Thank you.
-Arpit
On Mon, Jul 26, 2021, 7:13 PM dirkf @.***> wrote:

Works for me:
youtube-dl -v -F 'https://www.youtube.com/watch?v=_CMBCfxN1lU'[debug] System config: ['--prefer-ffmpeg']
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-F', 'https://www.youtube.com/watch?v=_CMBCfxN1lU']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.5.2 (CPython) - Linux-4.4.0-210-generic-i686-with-Ubuntu-16.04-xenial
[debug] exe versions: avconv 4.3, avprobe 4.3, ffmpeg 4.3, ffprobe 4.3
[debug] Proxy map: {}
[youtube] _CMBCfxN1lU: Downloading webpage
[youtube] _CMBCfxN1lU: Downloading player 408a20d8
[info] Available formats for _CMBCfxN1lU:
format code  extension  resolution note
249          webm       audio only tiny   44k , webm_dash container, opus @ 44k (48000Hz), 1.30MiB
250          webm       audio only tiny   56k , webm_dash container, opus @ 56k (48000Hz), 1.64MiB
251          webm       audio only tiny  102k , webm_dash container, opus @102k (48000Hz), 2.98MiB
140          m4a        audio only tiny  129k , m4a_dash container, @.*** (44100Hz), 3.76MiB
394          mp4        256x144    144p   65k , mp4_dash container, av01.0.00M.08@  65k, 25fps, video only, 1.91MiB
160          mp4        256x144    144p   67k , mp4_dash container, avc1.4d400c@  67k, 25fps, video only, 1.97MiB
278          webm       256x144    144p   87k , webm_dash container, vp9@  87k, 25fps, video only, 2.53MiB
395          mp4        426x240    240p  104k , mp4_dash container, av01.0.00M.08@ 104k, 25fps, video only, 3.03MiB
133          mp4        426x240    240p  129k , mp4_dash container, avc1.4d4015@ 129k, 25fps, video only, 3.74MiB
242          webm       426x240    240p  143k , webm_dash container, vp9@ 143k, 25fps, video only, 4.17MiB
396          mp4        640x360    360p  198k , mp4_dash container, av01.0.01M.08@ 198k, 25fps, video only, 5.74MiB
243          webm       640x360    360p  259k , webm_dash container, vp9@ 259k, 25fps, video only, 7.52MiB
134          mp4        640x360    360p  326k , mp4_dash container, avc1.4d401e@ 326k, 25fps, video only, 9.46MiB
397          mp4        854x480    480p  337k , mp4_dash container, av01.0.04M.08@ 337k, 25fps, video only, 9.78MiB
244          webm       854x480    480p  438k , webm_dash container, vp9@ 438k, 25fps, video only, 12.70MiB
135          mp4        854x480    480p  649k , mp4_dash container, avc1.4d401e@ 649k, 25fps, video only, 18.83MiB
398          mp4        1280x720   720p  622k , mp4_dash container, av01.0.05M.08@ 622k, 25fps, video only, 18.05MiB
247          webm       1280x720   720p  815k , webm_dash container, vp9@ 815k, 25fps, video only, 23.63MiB
136          mp4        1280x720   720p 1172k , mp4_dash container, @., 25fps, video only, 33.99MiB
399          mp4        1920x1080  1080p 1050k , mp4_dash container, @., 25fps, video only, 30.45MiB
248          webm       1920x1080  1080p 1371k , webm_dash container, @., 25fps, video only, 39.77MiB
137          mp4        1920x1080  1080p 2033k , mp4_dash container, @., 25fps, video only, 58.95MiB
18           mp4        640x360    360p  536k , avc1.42001E, 25fps, mp4a.40.2 (44100Hz), 15.55MiB (best)
$
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ytdl-org/youtube-dl/issues/29654#issuecomment-886715566,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFLSP34LNXV6CYZEO3LKUQTTZVRBLANCNFSM5A73STLA
.

For me, this is not working :( and I don't have idea why some video works correctly and some not
$ youtube-dl -v -F 'https://www.youtube.com/watch?v=_CMBCfxN1lU'
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-F', 'https://www.youtube.com/watch?v=_CMBCfxN1lU']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.8.10 (CPython) - Linux-5.8.0-63-generic-x86_64-with-glibc2.29
[debug] exe versions: ffmpeg 4.2.4, ffprobe 4.2.4, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] _CMBCfxN1lU: Downloading webpage
WARNING: Unable to download webpage: HTTP Error 429: Too Many Requests
[youtube] _CMBCfxN1lU: Downloading API JSON
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/home/tom/.local/lib/python3.8/site-packages/youtube_dl/YoutubeDL.py", line 815, in wrapper
    return func(self, *args, **kwargs)
  File "/home/tom/.local/lib/python3.8/site-packages/youtube_dl/YoutubeDL.py", line 836, in __extract_info
    ie_result = ie.extract(url)
  File "/home/tom/.local/lib/python3.8/site-packages/youtube_dl/extractor/common.py", line 534, in extract
    ie_result = self._real_extract(url)
  File "/home/tom/.local/lib/python3.8/site-packages/youtube_dl/extractor/youtube.py", line 1715, in _real_extract
    self._sort_formats(formats)
  File "/home/tom/.local/lib/python3.8/site-packages/youtube_dl/extractor/common.py", line 1374, in _sort_formats
    raise ExtractorError('No video formats found')
youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

See #23638.

You are right, sorry for this, with generated cookies it's works, thanks :pray:


Missing link to sample scripts for respective output formats

A different page describes the output formats available as:

The platform parameter specifies the platform to export to: allowed values are CoreML, TensorFlow, DockerFile, ONNX, VAIDK, and OpenVino.

But some platforms are missing reference materials on how to use the exported model (notably VAIDK/OpenVino).
May you add pointers that would guide users to example usages or sample code, so that all platforms are covered with fairness? I see the repository below, for example.
https://github.com/Azure-Samples/customvision-export-samples

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 916de6f5-ef41-c82b-5918-0c6149326aab
Version Independent ID: c7a4bb67-957d-f0a3-4a9f-e71035923f58
Content: Export your model to mobile - Custom Vision Service - Azure AI services
Content Source: articles/ai-services/custom-vision-service/export-your-model.md
Service: azure-ai-custom-vision
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

@jesweare
Thanks for your feedback! We will investigate and update as appropriate.

@jesweare
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Create GitHub Actions workflow to run post-submit test

Spec - https://github.com/dapr/dapr/issues/335#issuecomment-548217582
This is to create github actions workflow to run e2e test:

[ ] : run e2e test by PR
[ ] : run e2e test by schedule

The workflow should be:

Contributors runs pre submit tests
Submits PR
A do-not-merge label is added automatically
A reviewer is assigned
Once the reviewer believes it's ok to test, they add an ok-to-test label
e2e tests run
When e2e tests pass, a reviewer can approve the PR by adding the lgtm label.
The PR can then be merged by the bot or manually


docs(a11y): Add a11y docs for table, expansion panel, dialog, chips, autocomplete…

…, and select

Comments addressed. Please take another look. Thanks!

Comments addressed. Please take another look. Thanks!

LGTM for input

Comments addressed. Please take another look. Thanks!


Infinite recursion until bug

def method
  until method == 0
  end

  method
end

method

BUG: `!(method)` at eval:2:9 has no type (Exception)
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from main
  from __libc_start_main
  from _start
  from ???
Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues

It's a bug related to until. It does not happen with while.

It does happen with while:
def method
  while !(method == 0)
  end

  method
end

method

(that's what until expands to)


⚠ Samsung has degraded performance

In 4e52fee, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2659 ms

Resolved: Samsung performance has improved in cc667a2.


Indent option MemberExpression does not support "off"

ESLint now defaults the MemberExpression option of the indent rule to 1.
It also gives the option to set it to "off" to ignore this option (https://eslint.org/docs/rules/indent).
Unfortunately, this is viewed as an invalid type and gives the error:
Configuration for rule "indent" is invalid: 	Value "off" is the wrong type.
The configuration I am using looks like this:
"indent": [
    "error",
    2,
    {
        "SwitchCase": 1,
        "MemberExpression": "off"
    }
],

The ESLint extension doesn't do any interpretation of the configuration. It is passed to the ESLint npm module. What happens if you run ESLint from a terminal on that project give the same configuration?

Yeah you're right, nothing to do with this extension.
Looks like this was confusion between versions 3 and 4. Gave an error with 3, but not with 4.
Thanks


Use CultureInfo.InvariantCulture when writing with GeoWKTWriter

Relates: https://stackoverflow.com/questions/56594358/parse-exception-when-adding-wkt-multipolygon-to-elasticsearch
When writing latitude, longitude and z values of coordinates to StringBuilder, values should be written culture invariantly, such that decimal points are used as the separator for fractional values, irrespective of culture.

Opened https://github.com/elastic/elasticsearch-net/pull/3820

Closing this as #3820 is merged and will be in the next 6.x and 7.x releases


Generalising code between Pool and Transaction

Hi,
This looks great and solves a key problem for me.
I have various models and some handlers need to call functions on multiple models. I have been wondering how to make this work for transactions. At the moment I can switch everything to use Transactions instead of the Pool.
However, I wonder if there is a way to write functions so that they use Executors rather then Pools or Transactions. Then they can work with either depending on the calling method.
Mind you at the same time it would be wonderful if we could move towards a point where we use the generic Executor rather than the db specific ones so that it would be easier to provide both sqlite and postgres support. I'm not sure that sqlx is ready for that though.

It is possible to write a function that is generic for any sqlx::Executor and sqlx::Database, e.g.
// "model" function
async fn save<'c, E>(executor: E)
where
    E: sqlx::Executor<'c>,
{
    executor.execute("INSERT INTO ...").await.unwrap();
}

async fn save_with_pool<DB>(pool: sqlx::Pool<DB>)
where
    DB: sqlx::Database,
    for<'c> &'c mut DB::Connection: sqlx::Executor<'c, Database = DB>,
{
    // `save` can be called with a pool
    save(&pool).await;
}

async fn save_with_tx<DB>(mut tx: axum_sqlx_tx::Tx<DB>)
where
    DB: sqlx::Database,
    for<'c> &'c mut DB::Connection: sqlx::Executor<'c, Database = DB>,
{
    // `save` can be called with a transaction
    save(&mut tx).await;
}

Being generic on DB requires most of the bounds, and when the DB generic is known it gets a lot simpler (using sqlite as an example):
async fn save<'c, E>(executor: E)
where
    E: sqlx::Executor<'c>,
{
    executor.execute("INSERT INTO ...").await.unwrap();
}

async fn save_with_pool(pool: sqlx::Pool<sqlx::Sqlite>) {
    save(&pool).await;
}

async fn save_with_tx(mut tx: axum_sqlx_tx::Tx<sqlx::Sqlite>) {
    save(&mut tx).await;
}

Is this the kind of thing you're trying to do?

Hi,
Thanks. This is exactly the sort of thing I was looking for.
If I understand correctly then Marker https://docs.rs/axum-sqlx-tx/latest/axum_sqlx_tx/trait.Marker.html is a way to allow me to pass a transaction to a handler that is not type specific to a particular database driver.
So if I combine using Marker to pass generic transactions to my models I could create a Trait Model that would give implementations for save_with_tx and and save_with_pool so each Model would only need to implement save?
I'm still a rust noob. So this has been very helpful.
Thanks

I think what you're describing should work – though it can get pretty hairy combining generics with traits and async. Good luck!


unknown action: toggle-wrap

First of all, thank you for developing this, like it very much. Very clean.
I'm facing this particular issue only when using --preview with --fzf.
To reproduce: fastanime --icons --preview --fzf anilist

Extra Context:

Using Windows 11
Terminal -> Terminal Preview app from windows store
Installed using pip

Welcome. This looks like a fzf version issue, check if its 0.56.0

Welcome. This looks like a fzf version issue, check if its 0.56.0

That was the problem. Upgrading fzf, resolve it.
Seeing a different issue, but will open another thread for that. Thanks.

Join the discord


Fails on import

Seems there are some syntax errors in innit.py
Traceback (most recent call last):
  File "scrape.py", line 7, in <module>
    from rightmove_webscraper import rightmove_data
  File "/home/pi/notebooks/HouseData/HouseFinderENV/lib/python3.5/site-packages/rightmove_webscraper/__init__.py", line 65
    raise ValueError(f"Invalid rightmove search URL:\n\n\t{self.url}")

then on fixing that
Traceback (most recent call last):
  File "scrape.py", line 7, in <module>
    import rightmove_webscraper
  File "/home/pi/notebooks/HouseData/HouseFinderENV/lib/python3.5/site-packages/rightmove_webscraper/__init__.py", line 99
    assert by in self.get_results.columns, f"Column not found in `get_results`: {by}"
                                                                                ^
SyntaxError: invalid syntax

Which version of Python are you using? The latest version requires Python 3.6 or above as it uses f-strings

Have added specification to setup.py that it requires python 3.6 or above.


[posix-app] asserts when running toranj test-010 with posix-app/rcp model

I have been trying to get toranj test to run with posix-app and RCP (NCP with radio only) model.
Many tests are passing ok but test-010-on-mesh-prefix-config-gateway.py fails consistently:
  File "test-010-on-mesh-prefix-config-gateway.py", line 131, in <module>
    verify_prefix(all_nodes, prefix1, stable=True, on_mesh=True, slaac=True)
  File "test-010-on-mesh-prefix-config-gateway.py", line 65, in verify_prefix
    prefixes = wpan.parse_on_mesh_prefix_result(node.get(wpan.WPAN_THREAD_ON_MESH_PREFIXES))
  File "/usr/local/google/home/abtink/sw/openthread/tests/toranj/wpan.py", line 325, in get
    return self.wpanctl('get ' + ('-v ' if value_only else '') + prop_name)
  File "/usr/local/google/home/abtink/sw/openthread/tests/toranj/wpan.py", line 306, in wpanctl
    result = subprocess.check_output(self._wpanctl_cmd + cmd, shell=True, stderr=subprocess.STDOUT)
  File "/usr/lib/python2.7/subprocess.py", line 219, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '/usr/local/bin/wpanctl -I wpan1 get -v Thread:OnMeshPrefixes' returned non-zero exit status 11

From wpantund/OT logs I get this assert
wpantund[4735]: Inbound DBus message for INTERFACE "PropGet" from ":1.132943"
wpantund[4735]: property_get_value: key: "IPv6:AllAddresses"
ot-ncp: radio_spinel.cpp:1259: otError ot::RadioSpinel::RequestV(bool, uint32_t, spinel_prop_key_t, const char*, __va_list_tag*): Assertion `mTxRadioTid == 0' failed.
wpantund[4735]: [-NCP-]: Socket error on read: Input/output error 5

Created this issue to investigate this further.

This is fixed.


rocmPackages: extend ISA compatibility

rocmPackages: extend rocm-runtime ISA compatibility
rocmPackages: extend clr ISA compatibility
rocmPackages: extend tensile ISA compatibility
rocmPackages: extend rocblas ISA compatibility
rocmPackages: extend miopen ISA compatibility

Description of changes
This will eliminate the need for users to use HSA_OVERRIDE_GFX_VERSION to emulate their GPUs as a supported GPU model.
For more info, see this mailing thread.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I think having that artificial barrier removed is a great change.
I just want to give you a heads up after quickly looking over that linked email:
It seems those patches are originally provided as git commits. Unless they need to be adapted somehow form the original commits, it would be better to integrate them by using fetchpatch instead of checking them in, like you can see for example in this change : https://github.com/NixOS/nixpkgs/commit/9a4f48bb251a2275293a85611a503b46bbdcf9cb

@mschwaig Updated. Thank you for your comment!

I will leave nixpkgs-review running through the night, and if nothing fails I'll mark squash the commits and mark this as ready for review tomorrow.

Well I guess that had to be 2 nights because it ran out of space building rocblas... Going to finish the rest tonight and hopefully I can update the PR tomorrow.

Going by the output of nixpkgs-review it seems like rocblas is still not building yet.
Result of nixpkgs-review pr 298388 run on x86_64-linux 1

14 packages marked as broken and skipped:

rocmPackages.llvm.flang
rocmPackages.llvm.flang.doc
rocmPackages.llvm.flang.info
rocmPackages.llvm.flang.man
rocmPackages.migraphx
rocmPackages.rdc
rocmPackages.rdc.doc
rocmPackages_6.llvm.flang
rocmPackages_6.llvm.flang.doc
rocmPackages_6.llvm.flang.info
rocmPackages_6.llvm.flang.man
rocmPackages_6.migraphx
rocmPackages_6.rdc
rocmPackages_6.rdc.doc

6 packages failed to build:

rocmPackages.hipblas (rocmPackages_6.hipblas)
rocmPackages.hipsolver (rocmPackages_6.hipsolver)
rocmPackages.miopen (rocmPackages.miopen-hip ,rocmPackages_6.miopen ,rocmPackages_6.miopen-hip)
rocmPackages.rocalution (rocmPackages_6.rocalution)
rocmPackages.rocblas (rocmPackages_6.rocblas)
rocmPackages.rocsolver (rocmPackages_6.rocsolver)

34 packages built:

blender-hip
rocmPackages.clr (rocmPackages_6.clr)
rocmPackages.clr.icd (rocmPackages_6.clr.icd)
rocmPackages.composable_kernel (rocmPackages_6.composable_kernel)
rocmPackages.hipcub (rocmPackages_6.hipcub)
rocmPackages.hipfft (rocmPackages_6.hipfft)
rocmPackages.hiprand (rocmPackages.rocrand ,rocmPackages_6.hiprand ,rocmPackages_6.rocrand)
rocmPackages.hipsparse (rocmPackages_6.hipsparse)
rocmPackages.llvm.mlir (rocmPackages_6.llvm.mlir)
rocmPackages.llvm.openmp (rocmPackages_6.llvm.openmp)
rocmPackages.llvm.openmp.doc (rocmPackages_6.llvm.openmp.doc)
rocmPackages.llvm.openmp.info (rocmPackages_6.llvm.openmp.info)
rocmPackages.llvm.openmp.man (rocmPackages_6.llvm.openmp.man)
rocmPackages.rccl (rocmPackages_6.rccl)
rocmPackages.rocdbgapi (rocmPackages_6.rocdbgapi)
rocmPackages.rocdbgapi.doc (rocmPackages_6.rocdbgapi.doc)
rocmPackages.rocfft (rocmPackages_6.rocfft)
rocmPackages.rocm-runtime (rocmPackages_6.rocm-runtime)
rocmPackages.rocminfo (rocmPackages_6.rocminfo)
rocmPackages.rocmlir (rocmPackages_6.rocmlir)
rocmPackages.rocmlir-rock (rocmPackages_6.rocmlir-rock)
rocmPackages.rocmlir.external (rocmPackages_6.rocmlir.external)
rocmPackages.rocprim (rocmPackages_6.rocprim)
rocmPackages.rocprofiler (rocmPackages_6.rocprofiler)
rocmPackages.rocr-debug-agent (rocmPackages_6.rocr-debug-agent)
rocmPackages.rocsparse (rocmPackages_6.rocsparse)
rocmPackages.rocthrust (rocmPackages_6.rocthrust)
rocmPackages.roctracer (rocmPackages_6.roctracer)
rocmPackages.rocwmma (rocmPackages_6.rocwmma)
rocmPackages.rpp (rocmPackages.rpp-hip ,rocmPackages_6.rpp ,rocmPackages_6.rpp-hip)
rocmPackages.rpp-cpu (rocmPackages_6.rpp-cpu)
rocmPackages.rpp-opencl (rocmPackages_6.rpp-opencl)
rocmPackages.tensile (rocmPackages_6.tensile)
rocmPackages.tensile.dist (rocmPackages_6.tensile.dist)

Here is the build log:
@nix { "action": "setPhase", "phase": "unpackPhase" }
Running phase: unpackPhase
unpacking source archive /nix/store/ihrai11dd7zmmvj6j9g1kyj4337f85hh-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: patchPhase
applying patch /nix/store/04x9sfq554jgzhafdkpyznpk0azglwp0-Extend-rocBLAS-HIP-ISA-compatibility.patch
patching file library/src/handle.cpp
patching file library/src/rocblas_auxiliary.cpp
patching file library/src/tensile_host.cpp
ln: failed to create symbolic link 'build/Tensile/library/TensileLibrary.dat': File exists
/nix/store/hylcibqj87y8flsj51d2dpc7fiy6g1gx-stdenv-linux/setup: line 131: pop_var_context: head of shell_variables not a function context

Did you manage to run nixpkgs-review or are you having trouble with it?
My own experience is that ROCm is quite a pain to build with its huge hardware requirements.

@mschwaig Thank you for the run! I'm still fixing rocblas. I realized I could set gpuTargets to only my GPU and I had been doing that to reduce the build time/memory requirement.
I had a fix for rocBLAS but it was really messy. I think I figured out a clean solution that requires just one short patch and no more postPatch. Currently building locally to verify.

Quick question: I want to test rocBLAS through llama.cpp. How do I build a llama-cpp that has rocmSupport set to true?

Quick question: I want to test rocBLAS through llama.cpp. How do I build a llama-cpp that has rocmSupport set to true?

Should be llama-cpp.override { rocmSupport = true; }

Hi @mschwaig would you mind running nixpkgs-review on your end? rocblas now compiles fine, but for some reason even 64GB of RAM is not enough to run nixpkgs-review and I still frequently get out-of-disk-space errors :(

Hi @mschwaig would you mind running nixpkgs-review on your end? rocblas now compiles fine, but for some reason even 64GB of RAM is not enough to run nixpkgs-review and I still frequently get out-of-disk-space errors :(

Great to hear that it compiles.
I'm running nixpkgs-review now and I will post the results when it completes.

I was reading the llvm documentation for the upcoming generic targets and it doesn't look like that this patch will always work, for example:

It looks like that some targets do not support some instructions, so they are not really compatible. So for example for rocblas with this patch if you are using a gfx1012 by default you will be using gfx1010 code, that includes some instructions that are not supported by gfx1012. It looks like this might cause some problems.

Result of nixpkgs-review pr 298388 run on x86_64-linux 1

14 packages marked as broken and skipped:

rocmPackages.llvm.flang
rocmPackages.llvm.flang.doc
rocmPackages.llvm.flang.info
rocmPackages.llvm.flang.man
rocmPackages.migraphx
rocmPackages.rdc
rocmPackages.rdc.doc
rocmPackages_6.llvm.flang
rocmPackages_6.llvm.flang.doc
rocmPackages_6.llvm.flang.info
rocmPackages_6.llvm.flang.man
rocmPackages_6.migraphx
rocmPackages_6.rdc
rocmPackages_6.rdc.doc

5 packages failed to build:

rocmPackages.hipblas (rocmPackages_6.hipblas)
rocmPackages.hipsolver (rocmPackages_6.hipsolver)
rocmPackages.miopen (rocmPackages.miopen-hip ,rocmPackages_6.miopen ,rocmPackages_6.miopen-hip)
rocmPackages.rocalution (rocmPackages_6.rocalution)
rocmPackages.rocsolver (rocmPackages_6.rocsolver)

35 packages built:

blender-hip
rocmPackages.clr (rocmPackages_6.clr)
rocmPackages.clr.icd (rocmPackages_6.clr.icd)
rocmPackages.composable_kernel (rocmPackages_6.composable_kernel)
rocmPackages.hipcub (rocmPackages_6.hipcub)
rocmPackages.hipfft (rocmPackages_6.hipfft)
rocmPackages.hiprand (rocmPackages.rocrand ,rocmPackages_6.hiprand ,rocmPackages_6.rocrand)
rocmPackages.hipsparse (rocmPackages_6.hipsparse)
rocmPackages.llvm.mlir (rocmPackages_6.llvm.mlir)
rocmPackages.llvm.openmp (rocmPackages_6.llvm.openmp)
rocmPackages.llvm.openmp.doc (rocmPackages_6.llvm.openmp.doc)
rocmPackages.llvm.openmp.info (rocmPackages_6.llvm.openmp.info)
rocmPackages.llvm.openmp.man (rocmPackages_6.llvm.openmp.man)
rocmPackages.rccl (rocmPackages_6.rccl)
rocmPackages.rocblas (rocmPackages_6.rocblas)
rocmPackages.rocdbgapi (rocmPackages_6.rocdbgapi)
rocmPackages.rocdbgapi.doc (rocmPackages_6.rocdbgapi.doc)
rocmPackages.rocfft (rocmPackages_6.rocfft)
rocmPackages.rocm-runtime (rocmPackages_6.rocm-runtime)
rocmPackages.rocminfo (rocmPackages_6.rocminfo)
rocmPackages.rocmlir (rocmPackages_6.rocmlir)
rocmPackages.rocmlir-rock (rocmPackages_6.rocmlir-rock)
rocmPackages.rocmlir.external (rocmPackages_6.rocmlir.external)
rocmPackages.rocprim (rocmPackages_6.rocprim)
rocmPackages.rocprofiler (rocmPackages_6.rocprofiler)
rocmPackages.rocr-debug-agent (rocmPackages_6.rocr-debug-agent)
rocmPackages.rocsparse (rocmPackages_6.rocsparse)
rocmPackages.rocthrust (rocmPackages_6.rocthrust)
rocmPackages.roctracer (rocmPackages_6.roctracer)
rocmPackages.rocwmma (rocmPackages_6.rocwmma)
rocmPackages.rpp (rocmPackages.rpp-hip ,rocmPackages_6.rpp ,rocmPackages_6.rpp-hip)
rocmPackages.rpp-cpu (rocmPackages_6.rpp-cpu)
rocmPackages.rpp-opencl (rocmPackages_6.rpp-opencl)
rocmPackages.tensile (rocmPackages_6.tensile)
rocmPackages.tensile.dist (rocmPackages_6.tensile.dist)

These are the logs of the failing packages:
rocmPackages.rocsolver.log
rocmPackages.rocalution.log
rocmPackages.miopen.log
The logs for hipblas and hipsolver were empty since their dependencies failed to build.

Hi @Tungsten842, I believe it's actually the reverse. The document is saying that because we're compiling against gfx1010, when you're running an executable compiled against gfx1010 on gfx1012 hardware, the instruction v_dot4_i32_i8 would not be available for you to use (it's there, but your executable would never use this instruction) since the compiler has to assume you may be running on gfx1010. For example, you can see from the gfx1010 instruction docs that v_dot4_i32_i8 is not present, but this instruction is present in the gfx1011/gfx1012 instruction docs.

@mschwaig I believe I have fixed the issue (the header file rocblas.h is now being installed properly). Would you mind running nixpkgs-review when you get a chance? Thanks!

Hi @Tungsten842, I believe it's actually the reverse. The document is saying that because we're compiling against gfx1010, when you're running an executable compiled against gfx1010 on gfx1012 hardware, the instruction v_dot4_i32_i8 would not be available for you to use (the instruction would work properly if you try to call it, but your executable would never use this instruction) since the compiler has to assume you may be running on gfx1010. For example, you can see from the gfx1010 instruction docs that v_dot4_i32_i8 is not present, but this instruction is present in the gfx1011/gfx1012 instruction docs.
Therefore, gfx1010 is indeed the greatest common denominator for RDNA1 GPUs and all RDNA1 GPUs can use gfx1010 instructions as the basis ;)

Makes sense. But there is still one problem, it looks like that gfx900 supports some v_mad_mix instructions. But (gfx906, gfx904...) do not.
https://llvm.org/docs/AMDGPU/AMDGPUAsmGFX900.html
https://llvm.org/docs/AMDGPU/AMDGPUAsmGFX904.html
https://llvm.org/docs/AMDGPU/AMDGPUAsmGFX906.html
Also gfx1100 seems to have more VGPRs than other targets, not sure about the impact of this: https://reviews.llvm.org/D134522.

Finally, llama-cpp has been built. I am able to run Gemma 2B on gfx1032 without setup or environment variables. It just works™

@mschwaig I believe I have fixed the issue (the header file rocblas.h is now being installed properly). Would you mind running nixpkgs-review when you get a chance? Thanks!

Sure, no problem. I am running it now.
Congrats on getting llama.cpp to work. I think my suggestion of using nix eval was not that good, because you only get very minimal output that way.
I read a comment on an article recently where someone from AMD left a comment about supporting a wider range of hardware: https://www.phoronix.com/forums/forum/linux-graphics-x-org-drivers/open-source-amd-linux/1446020-amd-preparing-rocm-6-1-for-release-with-new-features?p=1446093#post1446093
That comment makes me think that if we have questions about what ISAs to target, we could also consider contacting someone at AMD and asking.

Result of nixpkgs-review pr 298388 run on x86_64-linux 1

14 packages marked as broken and skipped:

rocmPackages.llvm.flang
rocmPackages.llvm.flang.doc
rocmPackages.llvm.flang.info
rocmPackages.llvm.flang.man
rocmPackages.migraphx
rocmPackages.rdc
rocmPackages.rdc.doc
rocmPackages_6.llvm.flang
rocmPackages_6.llvm.flang.doc
rocmPackages_6.llvm.flang.info
rocmPackages_6.llvm.flang.man
rocmPackages_6.migraphx
rocmPackages_6.rdc
rocmPackages_6.rdc.doc

40 packages built:

blender-hip
rocmPackages.clr (rocmPackages_6.clr)
rocmPackages.clr.icd (rocmPackages_6.clr.icd)
rocmPackages.composable_kernel (rocmPackages_6.composable_kernel)
rocmPackages.hipblas (rocmPackages_6.hipblas)
rocmPackages.hipcub (rocmPackages_6.hipcub)
rocmPackages.hipfft (rocmPackages_6.hipfft)
rocmPackages.hiprand (rocmPackages.rocrand ,rocmPackages_6.hiprand ,rocmPackages_6.rocrand)
rocmPackages.hipsolver (rocmPackages_6.hipsolver)
rocmPackages.hipsparse (rocmPackages_6.hipsparse)
rocmPackages.llvm.mlir (rocmPackages_6.llvm.mlir)
rocmPackages.llvm.openmp (rocmPackages_6.llvm.openmp)
rocmPackages.llvm.openmp.doc (rocmPackages_6.llvm.openmp.doc)
rocmPackages.llvm.openmp.info (rocmPackages_6.llvm.openmp.info)
rocmPackages.llvm.openmp.man (rocmPackages_6.llvm.openmp.man)
rocmPackages.miopen (rocmPackages.miopen-hip ,rocmPackages_6.miopen ,rocmPackages_6.miopen-hip)
rocmPackages.rccl (rocmPackages_6.rccl)
rocmPackages.rocalution (rocmPackages_6.rocalution)
rocmPackages.rocblas (rocmPackages_6.rocblas)
rocmPackages.rocdbgapi (rocmPackages_6.rocdbgapi)
rocmPackages.rocdbgapi.doc (rocmPackages_6.rocdbgapi.doc)
rocmPackages.rocfft (rocmPackages_6.rocfft)
rocmPackages.rocm-runtime (rocmPackages_6.rocm-runtime)
rocmPackages.rocminfo (rocmPackages_6.rocminfo)
rocmPackages.rocmlir (rocmPackages_6.rocmlir)
rocmPackages.rocmlir-rock (rocmPackages_6.rocmlir-rock)
rocmPackages.rocmlir.external (rocmPackages_6.rocmlir.external)
rocmPackages.rocprim (rocmPackages_6.rocprim)
rocmPackages.rocprofiler (rocmPackages_6.rocprofiler)
rocmPackages.rocr-debug-agent (rocmPackages_6.rocr-debug-agent)
rocmPackages.rocsolver (rocmPackages_6.rocsolver)
rocmPackages.rocsparse (rocmPackages_6.rocsparse)
rocmPackages.rocthrust (rocmPackages_6.rocthrust)
rocmPackages.roctracer (rocmPackages_6.roctracer)
rocmPackages.rocwmma (rocmPackages_6.rocwmma)
rocmPackages.rpp (rocmPackages.rpp-hip ,rocmPackages_6.rpp ,rocmPackages_6.rpp-hip)
rocmPackages.rpp-cpu (rocmPackages_6.rpp-cpu)
rocmPackages.rpp-opencl (rocmPackages_6.rpp-opencl)
rocmPackages.tensile (rocmPackages_6.tensile)
rocmPackages.tensile.dist (rocmPackages_6.tensile.dist)

Thank you @mschwaig. I think we're good to go!

@mschwaig Thank you for your review! I'll respond to the review comments either tomorrow or Monday. I'll respond to your questions at the end of your comment first since I'm asking another person to join this conversation.

Do you want to upstream this?
Is something like this is likely to land upstream?

I'll answer these two questions together: No to both. To my knowledge, AMD has already presented and upstreamed (to LLVM) Generic Architectures as the once-and-for-all and robust solution to GPU compatibility issues. Therefore, they will not be accepting workaround patches like the ones presented in this PR.
Hi @cgmb. Sorry to ping you. If you could verify the info above, that would be appreciated. Thank you!

Who else is carrying or planning to carry these patches? Solus?

Solus definitely yes, as long as I'm the ROCm maintainer for Solus. Probably Debian as well depending on @cgmb. Ideally I would like to convince Arch and Fedora to also get on to the same boat. :smiling_imp:

Do these changes cover all of ROCm?

To the best of my knowledge, yes. The changes in clr and rocm-runtime is enough to cover 90% of the use cases, because it directly targets the HIP runtime. The only cases where we still need to patch manually (rocBLAS, Tensile, and MIOpen) is caused by these libraries querying the GPU arch on their own to choose what GPU code to execute, instead of relying on the HIP runtime to decide.
llama.cpp, stable diffusion, and any application/library that relies on ROCm that I have run, can run with these set of patches without issues. My hardware is gfx1032 (masked as gfx1030) and gfx90c (masked as gfx900).

Is composable_kernel affected by these changes (since that project also seems to build a lot of things per ISA)? How?

No. As explained in the response in 1. and 2., the changes in the HIP runtime covers most cases, which includes composable_kernel. I have read through the codebase of composable_kernel and concluded that composable_kernel relies solely on the HIP runtime to decide what GPU code to execute, so patches to the HIP runtime is enough. I have verified this by passing the composable_kernel test suite on my GPU with this set of patches.

Do you want to upstream this?
Is something like this is likely to land upstream?

I'll answer these two questions together: No to both. To my knowledge, AMD has already presented and upstreamed (to LLVM) Generic Targets as the once-and-for-all and robust solution to GPU compatibility issues. Therefore, they will not be accepting workaround patches like the ones presented in this PR.
Hi @cgmb. Sorry to ping you. If you could verify the info above, that would be appreciated. Thank you!

That is correct. I proposed these patches upstream and they were explicitly rejected in favour of pushing the compatibility logic into the compiler. I was consulted during the development of the LLVM generic targets and I agree that they are the better solution. However, it will be some time before generic targets are supported by the HIP runtime and the ROCm libraries.
I neither endorse nor condemn using these patches on NixOS. I supported merging them into Debian Unstable because the upstream solution would not be available in time for Ubuntu 24.04. I will drop them from Debian the next time the libamdhip64 soname is changed, if the upstream solution is available at that time.
Note that I have updated the patches slightly after reviewing the LLVM generic ISAs. The gfx1012 ISA is a superset of gfx1010, not equivalent to gfx1010.

7. Do these changes cover all of ROCm?

To the best of my knowledge, yes.

There are some dynamic checks in rocprim (at least in 5.5 and later). I added a patch to allow users to opt-in at compile time to treating gfx1031 through gfx1036 as gfx1030; and gfx902, gfx909, and gfx90c as gfx900.

ROCm only runs on GPUs they do verification on, and personally I think it makes sense for nixpkgs to merge something like this and distribute a version of ROCm which supports a wider range of devices.

FWIW, I've acquired a wide range of test hardware for Debian. It's not all available on our CI yet, but we run quite a lot of tests on GPUs that are not officially supported upstream. Debian ROCm CI: https://ci.rocm.debian.net/ Test CI (for upcoming systems): https://ci-test.rocm.debian.net/

No, composable_kernel doesn't need additional changes to get the same compatibility improvement. As explained in the response in 4., the changes in the HIP runtime covers most cases, which includes composable_kernel. I have read through the codebase of composable_kernel and concluded that composable_kernel relies solely on the HIP runtime to decide what GPU code to execute, so patches to the HIP runtime is enough. I have verified this by passing the composable_kernel test suite on my GPU with this set of patches.

Could we drop some of the default GPU targets from composable_kernel and just have a small performance loss on the dropped targets?
A build for all default targets  is really large right now (large enough to cause issues https://github.com/NixOS/nixpkgs/pull/299589), because of
${composable_kernel}/lib/libdevice_operations.a, weighing in at 3.7 GB with DEFAULT_GPU_TARGETS=gfx908;gfx90a;gfx940;gfx941;gfx942;gfx1030;gfx1100;gfx1101;gfx1102.
When I, for example, just compile for gpuTargets = ["gfx908" "gfx1030" "gfx1100"] that goes down to 1.9 GB. The build times are also much lower of course.

Could we drop some of the default GPU targets from composable_kernel and just have a small performance loss on the dropped targets?
A build for all default targets is really large right now (large enough to cause issues #299589), because of ${composable_kernel}/lib/libdevice_operations.a, weighing in at 3.7 GB with DEFAULT_GPU_TARGETS=gfx908;gfx90a;gfx940;gfx941;gfx942;gfx1030;gfx1100;gfx1101;gfx1102.

No, those ISAs all have meaningful differences between them. It might be possible to replace gfx1100, gfx1101 and gfx1102 with gfx11-generic in the future.
If you need to cut down on size, you could consider dropping gfx940 and gfx941. Those ISAs were used for early engineering samples, but all final MI300 hardware uses the gfx942 ISA.

There are some dynamic checks in rocprim (at least in 5.5 and later). I added a patch to allow users to opt-in at compile time to treating gfx1031 through gfx1036 as gfx1030; and gfx902, gfx909, and gfx90c as gfx900.

Patch has been included. Thanks for the catch!

Result of nixpkgs-review pr 298388 run on x86_64-linux 1

20 packages marked as broken and skipped:

rocmPackages.llvm.flang
rocmPackages.llvm.flang.doc
rocmPackages.llvm.flang.info
rocmPackages.llvm.flang.man
rocmPackages.migraphx
rocmPackages.mivisionx
rocmPackages.mivisionx-cpu
rocmPackages.mivisionx-hip
rocmPackages.rdc
rocmPackages.rdc.doc
rocmPackages_6.llvm.flang
rocmPackages_6.llvm.flang.doc
rocmPackages_6.llvm.flang.info
rocmPackages_6.llvm.flang.man
rocmPackages_6.migraphx
rocmPackages_6.mivisionx
rocmPackages_6.mivisionx-cpu
rocmPackages_6.mivisionx-hip
rocmPackages_6.rdc
rocmPackages_6.rdc.doc

1 package failed to build:

rocmPackages.rocprofiler (rocmPackages_6.rocprofiler)

39 packages built:

blender-hip
rocmPackages.clr (rocmPackages_6.clr)
rocmPackages.clr.icd (rocmPackages_6.clr.icd)
rocmPackages.composable_kernel (rocmPackages_6.composable_kernel)
rocmPackages.hipblas (rocmPackages_6.hipblas)
rocmPackages.hipcub (rocmPackages_6.hipcub)
rocmPackages.hipfft (rocmPackages_6.hipfft)
rocmPackages.hiprand (rocmPackages.rocrand ,rocmPackages_6.hiprand ,rocmPackages_6.rocrand)
rocmPackages.hipsolver (rocmPackages_6.hipsolver)
rocmPackages.hipsparse (rocmPackages_6.hipsparse)
rocmPackages.llvm.mlir (rocmPackages_6.llvm.mlir)
rocmPackages.llvm.openmp (rocmPackages_6.llvm.openmp)
rocmPackages.llvm.openmp.doc (rocmPackages_6.llvm.openmp.doc)
rocmPackages.llvm.openmp.info (rocmPackages_6.llvm.openmp.info)
rocmPackages.llvm.openmp.man (rocmPackages_6.llvm.openmp.man)
rocmPackages.miopen (rocmPackages.miopen-hip ,rocmPackages_6.miopen ,rocmPackages_6.miopen-hip)
rocmPackages.rccl (rocmPackages_6.rccl)
rocmPackages.rocalution (rocmPackages_6.rocalution)
rocmPackages.rocblas (rocmPackages_6.rocblas)
rocmPackages.rocdbgapi (rocmPackages_6.rocdbgapi)
rocmPackages.rocdbgapi.doc (rocmPackages_6.rocdbgapi.doc)
rocmPackages.rocfft (rocmPackages_6.rocfft)
rocmPackages.rocm-runtime (rocmPackages_6.rocm-runtime)
rocmPackages.rocminfo (rocmPackages_6.rocminfo)
rocmPackages.rocmlir (rocmPackages_6.rocmlir)
rocmPackages.rocmlir-rock (rocmPackages_6.rocmlir-rock)
rocmPackages.rocmlir.external (rocmPackages_6.rocmlir.external)
rocmPackages.rocprim (rocmPackages_6.rocprim)
rocmPackages.rocr-debug-agent (rocmPackages_6.rocr-debug-agent)
rocmPackages.rocsolver (rocmPackages_6.rocsolver)
rocmPackages.rocsparse (rocmPackages_6.rocsparse)
rocmPackages.rocthrust (rocmPackages_6.rocthrust)
rocmPackages.roctracer (rocmPackages_6.roctracer)
rocmPackages.rocwmma (rocmPackages_6.rocwmma)
rocmPackages.rpp (rocmPackages.rpp-hip ,rocmPackages_6.rpp ,rocmPackages_6.rpp-hip)
rocmPackages.rpp-cpu (rocmPackages_6.rpp-cpu)
rocmPackages.rpp-opencl (rocmPackages_6.rpp-opencl)
rocmPackages.tensile (rocmPackages_6.tensile)
rocmPackages.tensile.dist (rocmPackages_6.tensile.dist)

I think rocprofiler just fails on my machine, so the nixpkgs-review this is looking good now.
Due to https://github.com/NixOS/nixpkgs/pull/298979#issuecomment-2067629025  building this PR against master fails right now.
I will finish my review of this in the next few days, I wish I would have gotten to it sooner.
Last time i started reviewing this I realized that I had broken ROCm with that patch to add compression. 🤦
I already successfully tested this by with my old RX 6600. 😊

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3826

@mschwaig Updated according to https://github.com/NixOS/nixpkgs/commit/89ab15f76cbafe1c1166b05bf4e49298879db998

@mschwaig Updated according to 89ab15f

You've already patched rocBLAS to run gfx1010 kernels on gfx1012 hardware, so you can further reduce the size by dropping gfx1012 from that list.

@mschwaig Updated according to 89ab15f

Great! I already ran nixpkgs-review again with that change.
Result of nixpkgs-review run on x86_64-linux 1

10 packages marked as broken and skipped:

rocmPackages.llvm.flang
rocmPackages.llvm.flang.doc
rocmPackages.llvm.flang.info
rocmPackages.llvm.flang.man
rocmPackages.migraphx
rocmPackages.mivisionx
rocmPackages.mivisionx-cpu
rocmPackages.mivisionx-hip
rocmPackages.rdc
rocmPackages.rdc.doc

42 packages built:

blender-hip
rocmPackages.clr
rocmPackages.clr.icd
rocmPackages.composable_kernel
rocmPackages.hipblas
rocmPackages.hipcub
rocmPackages.hipfft
rocmPackages.hiprand
rocmPackages.hipsolver
rocmPackages.hipsparse
rocmPackages.llvm.mlir
rocmPackages.llvm.openmp
rocmPackages.llvm.openmp.doc
rocmPackages.llvm.openmp.info
rocmPackages.llvm.openmp.man
rocmPackages.miopen
rocmPackages.rccl
rocmPackages.rocalution
rocmPackages.rocblas
rocmPackages.rocdbgapi
rocmPackages.rocdbgapi.doc
rocmPackages.rocfft
rocmPackages.rocm-runtime
rocmPackages.rocminfo
rocmPackages.rocmlir
rocmPackages.rocmlir-rock
rocmPackages.rocmlir.external
rocmPackages.rocprim
rocmPackages.rocprofiler
rocmPackages.rocr-debug-agent
rocmPackages.rocrand
rocmPackages.rocsolver
rocmPackages.rocsparse
rocmPackages.rocthrust
rocmPackages.roctracer
rocmPackages.rocwmma
rocmPackages.rpp (rocmPackages.rpp-hip)
rocmPackages.rpp-cpu
rocmPackages.rpp-opencl
rocmPackages.tensile
rocmPackages.tensile.dist
zluda

The sizes are looking good as well:
du -h --apparent-size --max-depth 0 */ | grep G
3.7G	rocmPackages.composable_kernel/
1.6G	rocmPackages.miopen/
2.7G	rocmPackages.rocblas/
2.1G	rocmPackages.rocfft/
1.5G	rocmPackages.rocsolver/
1.2G	rocmPackages.rocsparse/

You've already patched rocBLAS to run gfx1010 kernels on gfx1012 hardware, so you can further reduce the size by dropping gfx1012 from that list.

@cgmb Good call, thanks for pointing that out! I added gfx1012 to enable some optimization/instructions unavailable in gfx1010, but forgot my patch causes gfx101* GPUs to run as gfx1010, so building for gfx1012 is indeed useless for now :sweat_smile:
@mschwaig I've removed gfx1012 just to save a bit more space. I don't think this requires another nixpkgs-review, so I think this is good for merge.

@mschwaig Comments added. Ideally I think we should be using clr.gpuTargets in all places, though that would be for another PR. Solus uses gfx803;gfx900;gfx906;gfx908;gfx90a;gfx1010;gfx1030;gfx1100;gfx1101;gfx1102, and the only package we had to patch was composable_kernel.

I will take a closer look at this tomorrow and see if we can land this. Thanks a lot for working on this!


Feat - OAuth on Development Mode (Hot Reload ON)

Fixing the #761 .
This fix adds one env var on the UI to apply a redirection only on Development mode.
This fix makes by default the next_url to be the PUBLIC_URL informed for proper redirection after callback execution.

Thanks for adding oauth for local dev, this troubled me for a long time 😄


Allow terrible method hack to decompile

Pull Request Test Coverage Report for Build 966471929

0 of 4 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 69.335%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

decompiler/IR2/AtomicOpTypeAnalysis.cpp
0
4
0.0%

Totals

Change from base Build 966443143:
-0.001%

Covered Lines:
36661

Relevant Lines:
52875

💛  - Coveralls


fix(deps): update dependency pyvmomi to v7.0.3

This PR contains the following updates:

Package
Type
Update
Change

pyvmomi
packages
patch
==7.0.2 -> ==7.0.3

Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: Pipfile.lock
Command failed: pipenv lock
Warning: Python 3.9 was not found on your system...
Neither 'pyenv' nor 'asdf' could be found to install Python.
You can specify specific versions of Python with:
$ pipenv --python path/to/python


add support for setting pixel cache limits

This is meant to supersede #71, since it seems to have been abandoned, and fixes #108.

Thank you!


Make sure display modes are explicitly set everywhere

Description
Some display modes are inferred by the KPN Style portals' choices of HTML element. For example, the current documentation offers this example for a notification:
<div class="notification notification--informative">
However, users of KPN Style might choose to make this a <span>-element, or even something else entirely. That could change the default display mode (which would be block for the div, but inline for the span), which could in turn lead to unexpected results. That could be detrimental to the delivery of consistent experiences by KPN Style.
Therefore, we should explicitly set display modes for at least all parent classes (such as notification, button, or card).
Acceptance criteria

[ ] All parent classes have their display mode set explicitly

We are not sure yet and should investigate further. If you do the parent tag, you also should do it for all child elements to be useful.
Maybe it can also be fixed with a short documentation piece about symantic HTML


Package description

Could someone please change the package description and remove the 2 from "Sublime Text 2". The versioned releases are now live on Package Control and I think the description should communicate it works with ST2 and ST3.

Sure, that's changed now.


Fix C# nuget package build.

Currently broken on master: https://source.cloud.google.com/results/invocations/5fc1cac6-9090-44a8-8a4f-00dd7afd0fbe/targets
The breakage was caused by upgrading the SDK in https://github.com/grpc/grpc/pull/27966 (sorry about that!)
(the packageIconUrl was deprecated and a fix in SDK caused a regression in dotnet pack --output behavior).

EasyCLA, wake up!


Uncaught Error: ENOENT, open '/home/v3ss/workspace/ANATR/models/schemas.py'

This randomly popped up. so reporting
Atom Version: 0.188.0-609a661
System: linux 3.17.0-sabayon
Thrown From: Atom Core
Stack Trace
Uncaught Error: ENOENT, open '/home/v3ss/workspace/ANATR/models/schemas.py'
At events.js:94

Error: ENOENT, open '/home/v3ss/workspace/ANATR/models/schemas.py'
  at Error (native)

Commands

Config
{
  "core": {
    "disabledPackages": [
      "language-ruby-on-rails",
      "mobile-preview",
      "atom-html-preview",
      "color-picker",
      "run-command",
      "runcoderun",
      "script",
      "wrap-guide",
      "whitespace",
      "svg-preview",
      "autosave",
      "vim-mode",
      "autocomplete-jedi",
      "autocomplete-plus-async",
      "autocomplete-plus",
      "cute-cursor",
      "pulsing-cursor",
      "ease-blink",
      "neon-selection",
      "pdf-view",
      "tree-view-breadcrumb",
      "atom-lint",
      "term2",
      "highlight-line",
      "animation-showcase"
    ],
    "audioBeep": false,
    "ignoredNames": [
      "*.pyc",
      "/home/v3ss/workspace/phwa.be/condaenv",
      "/home/v3ss/workspace/phwa.be/pypyenv",
      "*.zip",
      "*.tar",
      ".hg"
    ],
    "themes": [
      "one-dark-ui",
      "one-darker-syntax"
    ],
    "autoHideMenuBar": true
  },
  "editor": {
    "preferredLineLength": 120,
    "showIndentGuide": true,
    "tabLength": 4,
    "lineHeight": 1.35,
    "fontSize": 12,
    "fontFamily": "Univspace",
    "confirmCheckoutHeadRevision": false,
    "showInvisibles": true,
    "scrollPastEnd": true,
    "autoIndentOnPaste": false,
    "scrollSensitivity": 80,
    "invisibles": {}
  }
}

Installed Packages
# User
atom-beautify, v0.23.0
atom-color-highlight, v3.0.8
build, v0.26.0
editorconfig, v0.3.3
highlight-column, v0.4.0
highlight-selected, v0.9.1
linter, v0.12.0
linter-coffeelint, v0.2.0
linter-csslint, v0.0.11
linter-flake8, v1.3.0
linter-jshint, v0.1.0
linter-tidy, v1.0.0
linter-xmllint, v0.0.5
one-darker-syntax, v0.3.1
script-runner, v1.7.1
terminal-panel, v1.10.0

# Dev
No dev packages

I get similar stuff on os x. Steps to reproduce:

open a git branch which has files only specific to branch
open these files
close atom window
switch branches
re-open window
atom should now try to reopen the last window session
all files that were previously opened in the old branch will now give ENOENT

Closing in favor of #6210.