Last version Crashes on Windows

Windows 10 Pro 64 bit,
Last lovr version crashes, the nightly version only try to open window and closes immediately. (at try to start lovr.exe)

There isn't enough information here to know what's going on.  Recently one other person experienced a crash on Intel GPU due to the shader cache.  You can disable that by setting t.graphics.shadercache = false in conf.lua to see if it helps.  What GPU are you using?

But there is no conf.lua. In archive are only 7 files:
glfw3.dll, lovr.exe, lovrc.bat, luajit.dll, msdfgen.dll, ode.dll and openxr_loader.dll.
I try to start the lovr.exe, and Windows opens message that the Lovr stopped work and I close it (in the nightly  version, only blinks on screen and nothing).
In the old version, the VR window was opened (but I can't remember the old version number, because I directly replace it with the new release archive).

To change some of the config settings to see if it helps, you can make a project by putting these 2 files in a folder:
-- main.lua
function lovr.load()
  print(lovr.graphics.getDevice().name) -- print the GPU you have
end

function lovr.draw(pass)
  pass:text('Hi!!!', 0, 1.7, -3)
end

-- conf.lua
function lovr.conf(t)
  t.graphics.shadercache = false -- maybe this will fix something?
end

You can run it from cmd.exe like this: lovr --console C:\path\to\folder.
Are you using a VR headset?  The WMR runtime doesn't support Vulkan yet

I not use VR, just see that lovr was copied on my system and before start to learn it, decided to update... I want to play with making desktop "games" in lua.
I try, add this project with this 2 lua files in lovr folder and the result is the same with or without conf.lua:
C:\lovr-v0.16.0-win64>lovr --console .
C:\lovr-v0.16.0-win64>Error:
GPU error: Failed to load vulkan library
Stack:
boot.lua:90: in function boot.lua:4
[C]: in function 'xpcall'
My video card is not for game, but I like to play with some small physics 3d demonstrations, just look for most simple way to make them (before use vpython). My card is:
Intel HD Graphics 4400
It have last drivers, but may be Vulkan can't work with it?

Ok, unfortunately your GPU doesn't support Vulkan, so v0.16.0 won't work.  Sorry about that, there might be ways LÖVR can improve this in the future.  Thanks for the issue.


[event-hubs] Fixing bug in load balancing algorithm with even numbers of processors.

This "fixes" the problem we're seeing in #6439.
Our code was always assuming that we were allowed an "extra" partition, even
when the partitions would be evenly divisible by the number of processors.
This PR changes that to take into account whether or not we really do want to
have an extra partition.
NOTE: there is still a possibility of deadlock if a new processor comes online and
can't claim it's first partition. This is logged in issue #6945.

/azp run js - eventhubs-client - tests

Looking at one more spot with the min partitions check (this._isLoadBalanced)

/azp run js - eventhubs-client - tests


Ability to apply unspecified-nullness to an individual type usage (e.g. a type-use annotation like @UnspecifiedNullness)

It's not time to make a decision on this yet, but I wanted to start collecting links to past discussions on the subject.

#32 is about the name of such an annotation, assuming that we have one in the first place.
https://github.com/jspecify/jspecify/issues/128#issuecomment-700214870 points out that developers may write something like @NullnessUnspecified List<String> when they mean for the String part to have unspecified nullness, too.
I had been thinking that Android had asked us for @NullnessUnspecified V get(@Nullable Object o) for Map. But I appear to be wrong. Possibly they'd still use @NullnessUnspecified for findViewById, but (a) I'd have to confirm that, and (b) a defaulting annotation (if available!) seems sufficient there.
https://github.com/jspecify/jspecify/issues/32#issuecomment-697920608 (leading into #129) discusses the impact that having such an annotation could have on error messages. Typically, one less annotation is one less annotation for us to name and for users to understand, but here, we may still need to pick a name, and users will still need to understand the concept.
very minor: If we were to omit both @NullnessUnspecified and @NonNull (#4), that would make conflicting type annotations (like @Nullable @NonNull String) impossible (discussed somewhat in #100 and #101). (But it might still end up being possible for defaulting annotations, depending on what happens with #127 and and #109.)
I don't think that omitting such an annotation will end up simplifying our rules much: Given a type with an explicit @NullnessUnspecified annotation on it, we can generally construct a similar API in which the type has unspecified nullness only implicitly and the rest of the API's types likewise have similar nullness to the original API.

Writing that up in an appropriate level of detail was one of our objectives for these past few months. Real Life has interfered, but we're going to give it another shot in the coming months.
The too-short explanation of what it means: We haven't yet considered how to annotate this type for nullness. Either it should have @Nullable on it, or it shouldn't. Tools may wish to assume the worst (roughly: don't let code put null into the type, but also don't let code dereference it), or they may wish to assume the best (roughly: behave like a stock Java compiler, letting you put null into the type and dereference it). (Naturally, this all assumes that we've previously defined @Nullable.)
My hope has been that the too-long explanation can be based on https://jspecify.dev/tsttcpw.html. (Hopefully it will also be visible within in the next few weeks in our prototype CF checker.) But it's not yet clear whether tool authors will find those rules to provide the appropriate level of detail, nor whether tool authors and end users will approve of the results of those rules on real code.

Thanks.  I can see defaulting an entire class or package with such an annotation (is that what "in the club" or "not in the club" means?  I'm not sure), but what is an example where it is good style for a user to write this annotation explicitly?

I can see defaulting an entire class or package with such an annotation (is that what "in the club" or "not in the club" means? I'm not sure)

(Yes. Settling on a term for that concept is partially covered by #87 and #109.)

but what is an example where it is good style for a user to write this annotation explicitly?

The nicest thing that I personally have to say about it is that it's made it simpler to cover some unusual cases in the sample inputs :)
The other two potential uses I know of are:

I have time to annotate only part of a class right now. (We may provide other ways to do that besides this specific annotation.)
I know how to annotate this type, but I'm worried that my users will get mad at me when tools start enforcing it. This is "the findViewById use case" (among other examples from #71), and it again ties back to questions about what @Nullable means.

Thanks.  That's very helpful.

The nicest thing that I personally have to say about it is that it's made it simpler to cover some unusual cases in the sample inputs :)
The other two potential uses I know of are:

I have time to annotate only part of a class right now. (We may provide other ways to do that besides this specific annotation.)

This use case doesn't seem very likely to me.  I expect it is more trouble to go through a class and write @NullnessUnspecified on every type in an API, than to write @Nullable in those cases where it is needed.  Maybe someone else has evidence that this is a common need, however.

I know how to annotate this type, but I'm worried that my users will get mad at me when tools start enforcing it. This is "the findViewById use case" (among other examples from #71), and it again ties back to questions about what @Nullable means.

I don't think this is good style.  I think we should strongly encourage users to write accurate, honest specifications rather than inaccurate ones that pander to the limitations of some particular tool.  This opinion is independent of the meaning of @Nullable.  Tools can always have special-case behavior for known APIs, or they can extend Jspecify with extra annotations of their own.

We discussed this more in today's meeting. Here are the notes.
The primary takeaway is probably:

General undercurrent of support for a defaulting annotation over a type annotation to start.

The fact that an annotation like this is handy in our extremely artificial conformance tests doesn't make a case for its merit in the real world.
If we deem it important that you can ever mix all three kinds of nullness in a single signature, then either this or #4 would accomplish that.
However, I will claim that that argument works much better as a case for #4 than it does for this, though. If it's not strong enough to justify #4 then I'm skeptical that it would justify this. (Note that #43 and #127 are leaning yes.)
IF we're yes on #4, then the advantages of this feature are ergonomic only. And as we currently expect "yes" on #43 and #127, it's a small-scale difference.

But atm this seems like the biggest factor to me:

If we have this, we may find it is rampantly used for #71 whether we have a better solution for that or not.

Agreed on basically all of that, particularly that this is "really about" #71 but also even that I would add @NonNull before adding @UnspecifiedNullness -- and you know how much I personally want to avoid adding @NonNull until we're absolutely sure we need it :)
Still, to be clear: I think that @UnspecifiedNullness provides us with the ability to fully mix all three kinds of nullness in a single signature but that @NonNull only almost does. The difficulty is (as usual) type variables: If we want to say "Just this particular usage of this particular type variable has specified nullness," then there's no way to do that with @NonNull if the type variable allows nullable types.
Again, I think the best solution to that is to give up on guaranteeing that every possible mix of nullness in a single signature declaration is possible, not to add annotations to make sure it's possible.

I just learned from Victor that Kotlin APIs can include platform types. (Thanks, Victor.) It happens if a Kotlin method doesn't declare an explicit return type and the method returns the value of an unannotated Java method. For example:
==> j/p/J.java <==
package p;

public interface J {
  Object o();
}

==> k/p/K.kt <==
package p;

fun go(j : J) = j.o() // `go` has a return type that is a platform type.

So, if we want Kotlin to use pure JSpecify annotations to annotate its generated bytecode someday, then Kotlin needs support for the "mixing" case discussed above. So either we need to offer @NullnessUnspecified, or Kotlin will need to take one of a few alternative approaches, all of them at least somewhat ugly:

Avoid annotating the whole class with @NullMarked. (It could still annotate some types with @Nullable (and with @NonNull if we provide that -- though that may require additional logic to emit @NonNull, which wouldn't be necessary in most normal cases). And it might be able to individually annotate other APIs in the class with @NullMarked -- but only if we allow that annotation on smaller scopes.)
Annotate the whole method with @NotNullMarked (if we provide that). (Again, it's possible to then annotate some of the other types in the method.)
Annotate the return type with @Nullable (which is arguably sort of "never wrong" for the case of return types -- certainly safer than "non-null") and some other annotation that tells consumers not to strongly enforce that annotation on callers. (We don't know if we'll provide an annotation like that or not.)

(Or Kotlin could define its own annotation, which could "imply" @Nullable but explain that it "really means" something more like "unspecified.")
Would it make sense for us to file an explicit issue about "mixing all kinds of nullness in one signature" and/or "having Kotlin emit JSpecify annotations" -- the latter of which would also help with our goal of filing bugs to track which tasks block other tasks?

If we do this (have an annotation I abbreviate as @Unspec), there is an awkwardness.
(I currently think) we would have to make ImmutableList<@Unspec Foo> an error even in null-unmarked code, even though it would appear to just be redundant. (This because the type named doesn't actually exist, since the type parameter extends non-nullable Object.)

I think you're advocating for making ImmutableList<@Unspec Foo> an error in null-unmarked code but ImmutableList<Foo> not an error in null-unmarked code? I see the logic in that, but I wouldn't go so far as to say that we'd "have to" even encourage it:

It seems unlikely to come up often enough to be much trouble.
It seems strange to treat code differently for naming the same type in two different ways (aside from merely warning about redundancy, which I think you're arguing is different from this): I'd say that "the type named doesn't actually exist" in both cases. We could still encourage tools to treat it differently, but would this be the only such rule that would be stronger than the redundancy one?
It seems like a way to trigger somewhat unhelpful errors in generated code that writes @Unspec automatically and happens to sometimes be generated in a null-unmarked package. (Maybe that's not too likely, though, if we assume that the code generator would write @NullMarked on its own class? But maybe it would come up when, e.g., someone moves a method from one class to another?)

If a tool wants to tell users about this kind of declaration, I would personally discourage it, but I wouldn't fight them on it. I think that going the other direction and encouraging it is unlikely to be worth the effort, but if it's just "encouragement," I don't object to having some page somewhere that summarizes this discussion and explains why it could be a useful feature.

I'm making the call that this annotation is the perfect example of the kind of annotation we should only add if dragged kicking and screaming into it. And sure, something like #71 could do it, but until then I'm closing. That will encourage a cogent argument to be put forth by someone wanting to reopen it.

This issue is going to get replaced with a new issue soon enough, but I'll drop two more notes for us to potentially pick up later.
The first note ties together two conversations that came up in meetings I was in today:
As we roll out nullness annotations inside Google, one of the things that we're doing is looking at tables of the APIs that have the most users but that lack nullness information. It's a little sad to imagine that, in order to find the APIs we actually want to annotate, we'd have to filter through a bunch of APIs that are technically unspecified, not because we don't know their nullnesses but rather because annotating them would just be too painful:
// Spot the one method we actually want to go annotate now!
android.view.View#findViewById(int)
android.support.v7.app.AppCompatActivity#findViewById(int)
java.util.Map#get(Object)
com.google.common.collect.ImmutableMap#get(Object)
com.google.common.collect.ImmutableBiMap#get(Object)
com.google.some.foo.generateddatastore.Foo#lookup(Object)
java.util.HashMap#get(Object)
java.util.TreeMap#get(Object)
android.app.Activity#findViewById(int)
android.app.Dialog#findViewById(int)
java.util.regex.Matcher#group(int)
javax.inject.Provider#get()
com.google.some.bar.generateddatastore.Bar#lookup(Object)
java.lang.reflect.Method#invoke(Object, Object[])
android.view.Window#findViewById(int)
com.google.some.baz.generateddatastore.Baz#lookup(Object)
...

The hope would be that features like #26 or #27 could offer a way to say "nullable, but don't create a bunch of pain for callers." Even if nullness checkers ultimately treated that much like "unspecified," it would be nice for the code to contain the "honest" @Nullable annotation so that our stats can distinguish between "We don't know the nullness" and "We know the nullness but don't want to annoy callers" (or "haven't gotten around to updating all the callers yet").

The other note was specifically about generic methods, like Map.get:
The nice thing about saying that Map.get has an @UnspecifiedNullness return type (not that we're likely to decide to say that!) is that you can call get(foo) on a Map!<Foo!, Bar!> and get a Bar* out, at which point you see behavior basically like what you'd see with a Bar!. That makes sense if our goal is for checkers to behave like foo is a key that is present in the map: In that case, every call will return a Bar!.
But now consider a Map!<Foo!, Bar?>. We really want you to get a Bar? out of that: Even if foo is a key that is present in the map, get(foo) can return null because the value associated with that key can be... null.
So that brings us back to https://github.com/jspecify/jspecify/issues/248: What happens if we have the following:
@NullMarked
interface Map<K extends @Nullable Object, V extends @Nullable Object> {
  @UnspecifiedNullness V get(@Nullable Object k);
}

@NullMarked
void x(Map<Foo, @Nullable Bar> map) {
  map.get(foo).something();
}

Does map.get(foo) return Bar? (current behavior, good from the narrow perspective of an unspec Map.get) or Bar* (possible future behavior)?
My guess is that this won't turn out to be a key point in either this issue or #248, but it feels notable as another way that withholding nullness information could have concrete negative effects.


improve scroll bar and preloader

Related Issue
Issue Fixed: #174
Description
Styling has been applied to the preloader and scroll bar. The preloader and Scroll bar is present on all pages of the website with styling. The scroll bar behaviour has been improved and the thumb and track have been redesigned, resulting in improved scroll behaviour.
Improvements:

Optimized Preloader: Enhanced the preloader animation on the landing page to improve user experience.

Revamped Preloader Design: Redesigned the preloader with modern CSS styling to enhance visual appeal.

Dedicated Preloader Script and StyleSheet: Created a separate JavaScript file named "preloader.js" to manage the preloader functionality and CSS file named " preloaderStyle.css" to enhance the styling and functionality, ensuring better code organization and maintainability.

How Has This Been Tested?
The program was tested locally on a machine using the Chrome browser. To verify the changes, the website was loaded after the modifications were made. This involved manually inspecting the visual elements and functionally testing various user interactions to ensure the changes were implemented correctly.
Screenshots 📷

Before changes
https://github.com/user-attachments/assets/59aac5fb-6f00-498e-8c8b-b0b2bc9e7c94
After adding preloader
https://github.com/user-attachments/assets/45f3ae4f-a598-4b3d-96a4-c0e2f57e10f5
After improving scroll bar
https://github.com/user-attachments/assets/bc20a5b9-d026-41c1-b31f-d880ec58822f

@JayShukla8 Could you please review this pull request?

Yes i did. There are several things not right here. Firstly there are conflicts in the pr, secondly the loading page is not displayed properly. I ran your code on my local machine and saw that the website looks better without the loading screen. Also the orientation and padding for the quotes is not proper and looks haphazard. Sorry but i will not be able to merge this request. If you want to contribute, you can add your fav quote and update the data.json. Thanks for your time.

Apologies for any inconvenience caused. May I kindly inquire if it would be possible to include quotes from the Bhagavad Gita?

Sure, there's no problem with that.
.
Also i am attaching below a video for reference of how the loading screen is not proper + the quotes padding is gone. You can compare it with current website to see the difference.
https://github.com/user-attachments/assets/7d54692b-4e23-4510-9fca-dac6257076b8


Parameter logging now logs the value of byte arrays

Fixes issue #3670

@ErikEJ Sorry if I was unclear. We want the parameter values in DbCommandLogData to be the original typed values, not strings. The custom parameter formatting should only happen when we are rendering a string via the formatter delegate.

@anpete Ah. so you mean do the Parameter Formatting here?
       state.Parameters
                         .Select(kv => $"{kv.Key}='**{kv.Value}**'")
                         .Join(),

@ErikEJ Yep, we want the original objects to flow through as a structure logging payload.

@ErikEJ Are you planning to update this?

@anpete Yes, I just got stuck in the dotnet chaos - planning to submit a new PR

Closing and will attempt a new PR


feat: cds.Vector support for the HANAService

Hi @BobdenOs ,
Did you also do it for the old HANA driver? I think that's what people are waiting for most.

Hi @BobdenOs ,
Can we merge this for our colleagues to test?


Add support for Partial Constructor application

Composing identity∘f converts the Constructor f::DataType to a function, then calls ($) again to be handled properly.

Ooh nice change! I didn't know anyone was using this but me! Thanks!


Menu icon needs improvement

Hi @SonamMalik17 !
I would love to work on this. Let me know precisely what sort of ideas do you have about the required changes.
Kindly assign me this issue under the GSSOC '23

@SonamMalik17 , please follow the issue template and reopen


Does agent-protocol have a version 0.2.3?

I've been working at this for hours and I think I'm going crazy. In pyproject.toml has the agent-protocol = "^0.2.3" but that's not listed as a version on PyPI?!
I think it's supposed to be agent-protocol = "^1.0.0"?
What am I missing here?

You're correct, sorry about that!
The PR #358 aims to fix this. The agent protocol versions 0.3.0 and earlier were lost from pypi in a transition.


💡 [REQUEST] -

[x] I am from GSSoC'23.
[x] I would like to be assigned this task.

@abhijeet141 Respected Sir,
I want to add a Tkinter GUI for the project with the ML model for all the predictions and giving the output.
I will make it for to take the manual features input and the backend ML model will compute the results and display it on the GUI.
Plz kindly assign this request to me. It will be a big opportunity for me.
Thank You
Dhruv Saxena
Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct.

[x] I follow the Contributing Guidelines of this project.
[x] I have checked the current issues for duplicate problems.
[x] I have read the readme of this repository.

Hi @dhruvsaxena11
This project is already using ReactJs for frontend so I think it does not need a tkinter gui for the prediction. If you have any other issues or suggestions related to the project, I would be more than happy to consider them and collaborate on those.


Release version 0.10

Kongserver Release  version0.10.0, including what features?
Is there a monitoring (health)  check function that I see supporting load balancing and SRV
What other features(RC1)?
This version will join the keepalive health check function?
Does kong support getting the state of the back-end container from the consul's DNS interface and automatically updating the kong API record?

https://github.com/Mashape/kong/releases/tag/0.10.0rc1
https://github.com/mashape/kong/compare/0.9.7...0.10.0rc1
https://github.com/Mashape/kong/pull/1587
https://github.com/Mashape/kong/pull/1735
A better and much more complete changelog for 0.10 will follow soon.
As much as we appreciate your interest in Kong, please slow down on the number of issues you are opening in this repository. Many of the questions you asked can be answered by yourself should you do your homework and spend some time documenting yourself and watching the activity in this repository. @Tieske has recently dedicated a lot of his time patiently answering your questions but really you are taking a lot of his time that would be better spent actually working on this project or answering other users...
Thank you.

You have opened almost 20 issues in the last month: https://github.com/Mashape/kong/issues?q=is%3Aissue+author%3Ahuyifanstar

ok , thanks!


s3_redudant raises a RuntimeErorr: 502 Server Error: Bad Gateway

while installing the s3 redundant it raises the following error.

grid website is down and 0-template has nothing to do with it


Reorganized and cleaned up FastAPI components

Changed: Reorganized layout of FastAPI elements to match MVC layout and allow for future expansion if desired
Added: WTFPL License
Added: setup.py to make the project installable via pip
Added: Python, Coding, Copyright, and filename to each file
Added: __main__.py so the API can be started as a Python module
Added: cli.py to allow for Python CLI hooks
Added: log.py to centralize logging outputs
Added: .dockerignore so only necessary files are copied into the Docker image
Updated: Production server now uses gunicorn
Updated: osgeo/gdal image to the newest locked tag
Updated: .gitignore to include common ignore rules
Removed: Redundant AZGPXRequest and AZGPXResponse models
Fixed: version.py was misspelled
Fixed: GPX downloads were using multiple temp directories and returning the file as an in-memory string. This has been fixed to provide a file download

LGTM! Thanks for all the amazing work!


Using the incorrect URI even when the spring.cloud.config.uri is specified

I have a cloud config server running on localhost:8888 and a test app that uses properties from the config server, this uses the default uri localhost:8888. Now when I change the port to 8889 in both config server and client application using http://localhost:8889 as the spring.cloud.config.uri value the client app does not start up and I get errors like.
Could not resolve placeholder 'some.property' in value "${some.property}"
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessPropertyValues(AutowiredAnnotationBeanPostProcessor.java:372) ~[spring-beans-4.3.13.RELEASE.jar:4.3.13.RELEASE]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1264) ~[spring-beans-4.3.13.RELEASE.jar:4.3.13.RELEASE]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:553) ~[spring-beans-4.3.13.RELEASE.jar:4.3.13.RELEASE]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:483) ~[spring-beans-4.3.13.RELEASE.jar:4.3.13.RELEASE]

Here is an extract of the build.gradle
buildscript {
	ext {
		springBootVersion = '1.5.9.RELEASE'
	}
	repositories {
		mavenCentral()
	}
	dependencies {
		classpath("org.springframework.boot:spring-boot-gradle-plugin:${springBootVersion}")
		classpath('io.spring.gradle:dependency-management-plugin:0.5.4.RELEASE')
	}
}

dependencies {
	compile('org.springframework.cloud:spring-cloud-starter-config')
	compile('org.springframework.boot:spring-boot-starter-actuator')
	compile('org.springframework.boot:spring-boot-starter-web')
}

dependencyManagement {
	imports {
		mavenBom "org.springframework.cloud:spring-cloud-dependencies:Edgware.RELEASE"
	}
}

Also if I keep the config server uri as 8889 on the client but still start the config server at localhost:8888 everything works then even though it shouldn't really.
Have recorded a small vid of some debugging that might be useful

The gif starts from the yml file which shows that the port is 8889, afterwards the debug points placed get hit. As shown initially the first url value is having port 8888 (this is due to the default value assigned to the class variable). Next we show the console log which says
[           main] c.c.c.ConfigServicePropertySourceLocator : Fetching config from server at: http://localhost:8888

This seems to highlight that the default localhost:8888 url is used instead of 8889, then afterwards the setUri method gets hit with the correct port value 8889 however it seems too late as the exception above gets thrown later (not shown in the vid to keep it short and under 10MB though)

The value needs to go in bootstrap.yml.

Thanks a lot, that works! Will close out the issue as well.

HI Spencer,
I have the property defined in bootstrap.yml for client dummy-service and config server is started at 8890 port
`spring:
application:
name: dummy-service
profiles: zone1
cloud:
config:
uri: http://localhost:8890
fail-fast: true
profile: sit
eureka:
instance:
instanceId: ${spring.cloud.client.hostname}:${spring.application.name}:${server.port}
prefer-ip-address: true
metadataMap:
zone: zone1
client:
serviceUrl:
defaultZone: http://localhost:8761/eureka/
server:
port: ${PORT:1100${SEQUENCE_NO}}
spring:
application:
name: dummy-service
profiles: zone2
cloud:
config:
uri: http://localhost:8890
fail-fast: true
profile: sit
eureka:
instance:
instanceId: ${spring.cloud.client.hostname}:${spring.application.name}:${server.port}
prefer-ip-address: true
metadataMap:
zone: zone1
client:
serviceUrl:
defaultZone: http://localhost:8761/eureka/
server:
port: ${PORT:1100${SEQUENCE_NO}}
`
And I run it
mvn spring-boot:run -Dspring-boot.run.arguments=--SEQUENCE_NO=1,--spring.profiles.active=zone1
Still I see :
2020-02-10 16:21:37.428  INFO 84203 --- [           main] c.c.c.ConfigServicePropertySourceLocator : Fetching config from server at : http://localhost:8888 2020-02-10 16:21:37.543  INFO 84203 --- [           main] c.c.c.ConfigServicePropertySourceLocator : Connect Timeout Exception on Url - http://localhost:8888. Will be trying the next url if available 2020-02-10 16:21:37.544  WARN 84203 --- [           main] c.c.c.ConfigServicePropertySourceLocator : Could not locate PropertySource: I/O error on GET request for "http://localhost:8888/application/default": Connection refused (Connection refused); nested exception is java.net.ConnectException: Connection refused (Connection refused)
And  next in controller I am trying to get profiled value I am getting error org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'scopedTarget.dummyServiceController': Injection of autowired dependencies failed; nested exception is java.lang.IllegalArgumentException: Could not resolve placeholder 'spring.profiles' in value "${spring.profiles}"

Without a project that reproduces the problem, I won't be able to help

Hi Spencer,
This looks like springboot 2.2.4.RELEASE issue when we pass multiple arguments. Apparently they have changed the way to pass arguments
https://github.com/spring-projects/spring-boot/issues/20115


Evaluate CRI-O as containter runtime for RHEL8

Machine-controller recently introduced support for RHEL8.
We are currently installing Docker using Centos7 docker repository, but there are some limitations with this approach:

Some containerd dependencies are excluded (i.e. runc) and this prevents from installing recent docker versions without hacks (by courtesy of @kron4eg
https://bugzilla.redhat.com/show_bug.cgi?id=1756473)
RHEL users probably wants to have full support from RH and packages installed from centos7 docker repo are definitely out of policy.

The goal of this task is to evaluate the possibility of using CRI-O as container runtime for RHEL.
Note that CRI-O is part of OpenShift and probably not available through RHEL official repositories without OCP subscription (to be checked). It's not guaranteed that second point I mentioned can be addressed by this solution.
Find some pointers below:
https://access.redhat.com/documentation/en-us/openshift_container_platform/3.11/html/cri-o_runtime/use-crio-engine
https://github.com/openshift/openshift-ansible/blob/23eb7004a8b5dc928ea467ecc495f4fdb0ef8109/roles/openshift_node/defaults/main.yml#L13
https://kubernetes.io/docs/setup/production-environment/container-runtimes/#cri-o

xref #393

CRI-O cannot be installed through RHEL repositories without openshift subscription thus is not suitable to be used as CRI for plain Kubernetes.


Monitor information do not getting correctly in docker container

I have run your module inside docker container, the collected information, such as CPU, Memory, is measurement data of real computer which the docker container is running on.
How can I get real CPU usage, Memory state as mentioned at the following link?
https://docs.docker.com/engine/reference/commandline/stats/

You would write a probe that execs the stats command from within nodejs, and gets the value from stdout.


Feature/updates typo and order

Addresses:
#4332
#4253
#4335

@Raheel1258 Please resolve SonarQube's issues.


FIX: sklearn .18 n_splits

attempt to close #3578 & #3579

Current coverage is 87.28% (diff: 0.00%)

Merging #3580 into master will not change coverage

@@             master      #3580   diff @@
==========================================
  Files           341        341
  Lines         60142      60142
  Methods           0          0
  Messages          0          0
  Branches       9187       9187
==========================================
  Hits          52496      52496
  Misses         4899       4899
  Partials       2747       2747

Powered by Codecov. Last update f5e56a9...b713f59

@agramfort @Eric89GXL ready for review.

is that it? I fixed more in
https://github.com/mne-tools/mne-python/pull/3579

Well but yours didn't pass did it? :]

Yes I think that's it, we're currently relying on sklearn.cross_validation, which is backward compatible until sklearn .20; we'll have to make hard choices then: i.e. ask the user to get sklearn > .18 or hard copy old cross_validation objects in mne.

Can't we inspect the arguments and triage?

Can't we inspect the arguments and triage?

To me it's a sklearn bleeding edge issue; they decided to change their API, we shouldn't put too much into supporting it.

they decided to change their API, we shouldn't put too much into supporting it.

But they have clear deprecation messages, right? This means we should use the new API if possible (by inspecting args) and fall back to the old way if necessary. This avoids warnings in the meantime. See e.g. #3582. I can take care of it if necessary

That's what we do in the script. The bug came from a change of API in their
dev version.
For the examples I don't think we should create an if condition to handle
sklearn version. Just push until .20 and then update the examples with the
new API.
Le 8 sept. 2016 9:21 PM, "Eric Larson"<EMAIL_ADDRESS>a écrit :

they decided to change their API, we shouldn't put too much into
supporting it.
But they have clear deprecation messages, right? This means we should use
the new API if possible (by inspecting args) and fall back to the old way
if necessary. This avoids warnings in the meantime. See e.g. #3582
https://github.com/mne-tools/mne-python/issues/3582. I can take care of
it if necessary
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/pull/3580#issuecomment-245791591,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEp7DLppDAJCEMdAzhY7Fnwjl_TikUkcks5qoLR_gaJpZM4J4ZDi
.

Sure for the examples. But I'm talking about our internal code -- the warnings (and error) in #3582 appear when running tests. We'll need to support 0.20+ and 0.18- eventually, so might as well do it now.

For the warning in #3582 it works but emits a warning. I think we need to do the same thing, i.e. triage based on sklearn version what arguments/calls to make.

@Eric89GXL ok, I'll take a look. Ok to merge this one?

Yeah thanks @kingjr


error in LM pretraining

What I did?

Checked out the pretrain-lm branch because it has clear instructions how to pretrain LM (#57).
Installed required packages.
Executed bash prepare_wiki.sh de
Executed python -W ignore -m multifit new multifit_paper_version replace_ --name my_lm - train_ --pretrain-dataset data/wiki/de-100
Received the following traceback:
python -W ignore -m multifit new multifit_paper_version replace_ --name my_lm - train_ --pretrain-dataset data/wiki/de-100
 Setting LM weights seed seed to 0
Running tokenization: 'lm-notst' ...
Wiki text was split to 1 articles
Wiki text was split to 1 articles
Wiki text was split to 1 articles
Traceback (most recent call last):
File "/home/ubuntu/anaconda3/lib/python3.6/runpy.py", line 193, in _run_module_as_main
 "__main__", mod_spec)
File "/home/ubuntu/anaconda3/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/ubuntu/multifit/multifit/__main__.py", line 16, in <module>
fire.Fire(Experiment())
File "/home/ubuntu/anaconda3/lib/python3.6/site-packages/fire/core.py", line 138, in Fire
component_trace = _Fire(component, args, parsed_flag_args, context, name)
File "/home/ubuntu/anaconda3/lib/python3.6/site-packages/fire/core.py", line 468, in _Fire
target=component.__name__)
File "/home/ubuntu/anaconda3/lib/python3.6/site-packages/fire/core.py", line 672, in _CallAndUpdateTrace
component = fn(*varargs, **kwargs)
File "/home/ubuntu/multifit/multifit/training.py", line 587, in train_
self.pretrain_lm.train_(pretrain_dataset)
File "/home/ubuntu/multifit/multifit/training.py", line 275, in train_
learn = self.get_learner(data_lm=dataset.load_lm_databunch(bs=self.bs, bptt=self.bptt, limit=self.limit))
File "/home/ubuntu/multifit/multifit/datasets/dataset.py", line 208, in load_lm_databunch
limit=limit)
File "/home/ubuntu/multifit/multifit/datasets/dataset.py", line 258, in load_n_cache_databunch
databunch = self.databunch_from_df(bunch_class, train_df, valid_df, **args)
File "/home/ubuntu/multifit/multifit/datasets/dataset.py", line 271, in databunch_from_df
**args)
File "/home/ubuntu/multifit/fastai_contrib/text_data.py", line 147, in make_data_bunch_from_df
TextList.from_df(valid_df, path, cols=text_cols, processor=processor))
File "/home/ubuntu/anaconda3/lib/python3.6/site-packages/fastai/data_block.py", line 434, in __init__
if not self.train.ignore_empty and len(self.train.items) == 0:
TypeError: len() of unsized object

From initial debugging, train.items is an ndarray with shape () . When I print it, it returns articles in German. I suppose this part suggests a problem ``Wiki text was split to 1 articles- I reckon the wiki text should be split in more than 1 article. So maybe something goes wrong in read_wiki_articles()indataset.py`... This is my educated guess, but I don't know where to go from here.

My package versions differ slightly from those in requirements.txt, maybe sacremoses is related:
fire                               0.3.0
sacremoses                         0.0.38
sentencepiece                      0.1.85
fastai                             1.0.47


Add thermal system class

Add class System_thermal as a combinatory class of System.

Hello Tom, I updated the head files. But i am a little confused about how to write the API code for a sub-class. It takes me time to try:-(

Hello Tom, I updated the head files. But i am a little confused about how to write the API code for a sub-class. It takes me time to try:-(

I'll help you on the way in the morning!

@ctu-3u I have taken your start and have a suggestion for a fully completed API here https://github.com/tdegeus/FrictionQPotSpringBlock/pull/45 . Maybe you can give your feedback in https://github.com/tdegeus/FrictionQPotSpringBlock/pull/45 ?

Hi! It would be good to rebase this against "main" (and not "random")


Initial opened folder

Is there a way to start the docker image with a folder already opened instead of having to click "Open Folder" each time the docker container is ran?
Thanks

Pass the path of the folder as the first argument.
e.g. docker run <flags and image> <my directory>


Could you please add pod 2.7.7

There was a release for version 2.7.7 but cocoapod is in v2.7.6. Could you please release it too on the Cocoapod?

++

The pod is currently at 2.7.7 (https://github.com/CocoaPods/Specs/blob/master/Specs/7/d/3/XCDYouTubeKit/2.7.7/XCDYouTubeKit.podspec.json)
Can I see your pod file?

Thank You. Now it works.


How to change the Redux state when the user clicks on an Electron menu?

I'm trying to load the Redux state from a file.
In the main.js file I can implement the behavior for the Electron menu items:
 submenu: [{
    label: '&Open',
    accelerator: 'Ctrl+O',
    click: function() {
        // I want to change the Redux state here
    }
  }

... However I don't know how to change the Redux state from the click function.
Any idea?
When I find a solution I'm willing to make a PR for documenting this since I think the majority of use cases for this project will involve changing the Redux state based on opening a file.
Thank you.

I ended up posting this question on Stackoverflow as well.

Vadim Macagon has answered my question on Stackoverflow. I'm going to document that on the readme file and submit a pull-request. I hope you accept that.

duplicated of #118. PR Welcome.


feature: Documentation on how to debug with Meltano

Feature scope
Other
Description
I'm trying to figure out why Meltano isn't passing the state into my ELT pipeline. I've followed the documentation on how to debug a custom extractor but since it's running the tap.py directly I'm unable debug Meltano's state management.
The ask:
It would be great to have a guide or video on how to debug an ELT pipeline in VS Code so I can see all the parts working together.
My current troubleshooting steps:
I can see that the state is correct via: meltano --environment prod state get daily-ga-lcp-load
But when I run the ELT and log self.state from the tap I get an empty object. This is the command I'm running: meltano --environment prod elt --state-id daily-ga-lcp-load tap-ga--report-lcp target-postgres --transform run

Here's how I do it, maybe some have better ways.
How to debug a tap with state that you've been running with Meltano.

First find the state value you want to use, meltano state list
Send the state to a file meltano state get {state_name} > state.json state_name is from the list comand above
Open the state.json file and remove the "singer_state" object that wraps everything. ie you'll get something like

{"singer_state": {"bookmarks": {"conversation": {}, "message": {}}}}

We want it to be
{"bookmarks": {"conversation": {}, "message": {}}}

Save the state.json file.
4. Generate the config  the tap. meltano invoke --dump=config tap-name > config.json
5. Generate the catalog the tap. meltano invoke --dump=catalog tap-name > catalog.json 6. Pass the state.json file into the tap directly, tap-name --config config.json --state state.json --catalog catalog.json`
Because this only takes me a minute or so and I do it infrequently I don't mind the steps 🤷

Thank you @visch that was helpful! This thread can serve as documentation for anyone stuck like I was :)
I managed to debug it with the state that I exported using your steps and everything works fine. What's strange is that when running it using the ELT pipeline the state doesn't seem to make it into the extractor. Any ideas on this?

Thank you @visch that was helpful! This thread can serve as documentation for anyone stuck like I was :)
I managed to debug it with the state that I exported using your steps and everything works fine. What's strange is that when running it using the ELT pipeline the state doesn't seem to make it into the extractor. Any ideas on this?

If you could share your meltani.yml, my guess is that the tap doesn't have state added as a capability. Hard to know this one, I'm not sure of a good solution to make users aware that this is the case.

If you could share your meltani.yml, my guess is that the tap doesn't have state added as a capability.

What's strange is that it saves to the state just fine. I see Incremental state has been updated at 2023-01-21 23:01:06.418219. in the logs and using meltano state get returns:
{"singer_state": {"bookmarks": {"LCP_1500_2000_66350024": {"testing": "20230120", "replication_key": "ga_date", "replication_key_value": "20230120"}}}}

Would this mean the state capability is detected fine? It just seems to have trouble fetching the state and giving it to my tap.

Hi @visch - I'm curious if you have any other insights on this. I'm still running into the issue where the state passed into the tap/streams is empty.
I can see that the tap's capabilities include "state" if I log out the self.capabilities (I'm using the Meltano SDK). I also see that the stream/tap is writing to the state table in Postgres so it appears to have the correct db settings and is able to access the database.
When I run the tap directly and pass in the --state state.json I can see that it works fine so I don't believe it is an issue with my tap code.
It only appears to be when running via meltano with meltano invoke my-tap --state-id my-id, or meltano elt my-tap --state-id my-id, or even when running via airflow

Closing as this was my own confusion with which meltano.yml file to add the capabilities to. I was under the assumption that it would pull the capabilities from the tap but it looks like you need to define it yourself in your project file's meltano.yml file as pointed out by @aaronsteers here.
Thanks for the help guys!


VEText Migration - Update Twilio provider logic to use sms sender.

#747
POST requests to /v2/notifications/sms are used to send text messages to veterans.  In addition to the recipient's phone number or recipient_id, which can be used to look up the phone number, sending a request requires the sender's phone number.
These changes implement the ability to create text notifications using the value of message_service_sid in place of the sender's phone number when using Twilio as the SMS backend.  message_service_sid, if available, will be read from the sms_sender_specifics JSON field of a ServiceSmsSender instance associated with the authenticated service (user) and given template id, which is the other required field when making a request to this sms endpoint.
I found the existing code very difficult to follow.  Many of the edits in this PR are comments I made about types and purposes to facilitate not having to refer to different files frequently.  I also made formatting changes to appease the code scan test.
Rough flow path for the endpoint

app/v2/notifications/post_notifications.py::post_notification
The above calls either process_sms_or_email_notification or process_notification_with_recipient_identifier.  The outcome is the creation of a new Notification instance from the JSON attributes contained in the POST request.
Eventually, the Notification instance gets converted to a Celery task and enqueued.
The Celery worker processes each task by passing it to the "provider" (i.e. Twilio, etc.).  That is implemented in app/delivery/send_to_providers.py::send_sms_to_provider.

I have not updated the Postman collection.  It says that sms_sender_id is part of the POST body, but that value is not used.

This branch has been successfully deployed.

I thoroughly appreciate you cleaning up the code. It's important to take a few minutes to clean things up when we find them and I love seeing it. This kind of thing saves us and future maintainers a lot of headache!
That said, I think send_to_providers.py needs a little more work. send_sms_to_provider was intended as a provider-agnostic method using polymorphism to call the relevant provider's send_sms method. What you have here breaks that, and allowing it to be commit to master is just asking for tech debt. I know how much work you put into this but I'm going to have to ask for a rework to include the provider-specific logic in the provider's class/method.
I would advise changing the existing send_sms methods to take **kwargs as their final parameter, then I'd include
notification.service_id and notification.reply_to_text to the provider's send_sms method. Specifying **kwargs allows future changes to not require refactoring. Providers that have specifics (such as Twilio) would then call dao_get_service_sms_sender_by_service_id_and_number with the passed information. Calling it in the provider's send_sms method accomplishes the same goal you had before of only calling the dao method it if it was relevant.
That last paragraph I leave at your discretion; it was a suggestion for how it could be handled. However you adjust it, please just ensure the whole method remains provider-agnostic.

Briefly reviewed. This fails to meet the goal of the rework. message_service_sid is Twilio-specific and should not be in the send_sms_to_provider method. send_sms_to_provider should only pass additional information to the provider's send_sms method. If all goes well the only thing to change in send_sms_to_provider would be to add notification.service_id in the list of arguments being sent to provider.send_sms().
Inside the twilio client you can call dao_get_service_sms_sender_by_service_id_and_number and then set messaging_service_sid.
This is more a style thing, but if you wish to ditch the duplicated lines between 59 and 75 you could specify the values as a dictionary (twilio_data for instance), then pass self._client.messages.create(**twilio_data), only adding the messaging_service_sid if necessary. 100% up to you.

Converting to draft. Will open new PR when code changes are in new branch since I merged master into this one.


Fixed 'canvas.clipPath' crashes on Android P for Circular Image Cropping

Hi,
I've made changes in com.theartofdev.edmodo.cropper.CropOverlayView file to fix the cashing issue device with Android P. Please accept the pull request.
Thanks
Nauman

well, I defenitly not as engaged as I should be but this is the nature of open-source, I havn't touched Android for more than 2 years now...
but I can't accept this PR, it changes almost 2K lines by breaking all the formating of the file so I don't know what is the actual change...
my guess it's #618

Thanks a lot!
There were multiple PR's open addressing this issue. I don't expect you to always keep this library update.
But after a major android update like P, really critical issues that need to be addressed asap arise.
Maybe put a warning on the readme, that this is currently unmaintained?


chore: Map environment variables using 'env' context instead of inline bash script

Details
https://github.com/actions/runner/issues/665 mentions that input arguments are not implicitly mapped to environment variables in composite action steps. This action.yml file contained an inline script to map the environment variables. This PR replaces the inline script with the env context.
Motivation
This is simpler and helps protect the action from runtime injection in the bash script.
Pull request checklist

[ ] Addresses an existing issue: Fixes #0000
[ ] Added relevant unit test for your changes. (yarn test)
[ ] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
[ ] Ran precheckin (yarn precheckin)
[ ] (after PR created) The Accessibility Checks (pull_request) check should fail. All other checks should pass.

Codecov Report

Merging #704 (b4b9913) into main (d8cd84f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #704   +/-   ##
=======================================
  Coverage   94.81%   94.81%
=======================================
  Files          25       25
  Lines         559      559
  Branches       49       49
=======================================
  Hits          530      530
  Misses         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8cd84f...b4b9913. Read the comment docs.


Add missing blas dependency

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin please rerender

While you're there, license: GPL-3.0-only?

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@cbrueffer Certainly!

Tack!

@conda-forge-admin please rerender

Weird, I'll rerender locally


Link to config on Getting Started page 404s

Hi! I'm new to tsoa and started looking through the docs, but I noticed that a link on the Getting Started page is 404ing, specifically at https://github.com/tsoa-community/docs/blame/master/getting-started.md#L66.
I'd open a PR to fix but I'm not actually sure what the correct thing to link to is 😅

Fixed, should be up in a sec, thanks for reporting.


[FEAT] there is no any contributors page

i will make a contributors page where you and other users can see all the contributos of these project like these : https://ticket-booking-blue.vercel.app/contributor.html
so assign this to me i will do it under level2

Hey @SumitSahu44 , I wont be able to give this level 2 since its a single page. Please let me know if you can do it under level 1.

I would like to solve this issue

@BhavikaPachauri, You can get started now

okk


[Feature Request] Logging in after 900 seconds might be a bot detection vector

Short Description
Logging in into Pokemon go has been failing a lot lately (every time I open the app, I'm forced to tap "Try again" almost every time). This might be some tactic from Niantic to detect bots like this that will try to login again after exactly 900 seconds.
Possible solution
This retry attempt should be more human, like:

Try again a few more times as soon as the server throws a bad response (wait 2 or 3 seconds between the first and the second request)
Try again at the speed of an app relauch
Wait a random amount of time (few minutes) and try again.

How it would help others
It would avoid bot detection.

This could be done by using a .bat file or script file to restart the bot at a random amount of time between two intervals. Currently, it takes my iPhone 6 6-10 seconds to relaunch the app and get past the Niantic screen. We could make the .bat or script file restart between 6-15 seconds (for the actual loading after the Niantic screen to get done). Currently on my mac this is my code.
cd PokemonGo-Bot source bin/activate until (python pokecli.py); do     echo "Process crashed with exit code $?.  Respawning.." >&2     sleep 5 done
Sleep could be a random number.

You can configure this delay yourself in your config.json file.
    "reconnecting_timeout": 15,
15 = 15 minutes = 900 seconds
It doesn't achieve the randomness but at least it doesn't ALWAYS have to be 900.

You really think Niantic takes this specific bot's 900 seconds reconnect time as trigger to  flag and ban?
I'm using the bot in a different way (each of my account runs for 60/90/120 seconds), and there's always about 10% getting the 'try again in 900 seconds' message, but it shuts down after the amount of seconds that i specify, so it never reaches the reconnect time. Still having accounts banned and even the vps ip is banned.


Bittrex Ticker Api using Error

Hello, I'm developer in korea.
Thanks for creating an easy to use API.
I want to report and report a bug when using the Bittrex API.
Bittrex's Ticker API usage seems to be wrong.
I think, API call "getticker" instead of "getmarketsummary".
/public/getmarketsummary
=> Used to get the last 24 hour summary of all active exchanges
/public/getticker
=> Used to get the current tick values for a market.
reference page:
https://bittrex.com/Home/Api
Overview Description
Steps to Reproduce

Call Bitrex ticker API using bitex

Actual Results
Call getmarketsummary
Expected Results
Call gettickerAPI
Reproducibility
Always
Additional Information:

Hey @paragonjh,
thanks for contributing! I'm glad you've found the project useful.
Regarding your issue, this was intentional. The getticker endpoint offers little data, while getmarketsummary returns not only the top level of the market's book, but also candle data (ohlc), the market volume, order count for each side of the book, as well as an actual server-created timestamp of the data.
We found this to be better in every sense, which is why we're using this resource, instead of getticker.
Hope that clears things up!


Exporting Abaqus mesh with subdomain information

Hi Nico,
Again, in a way related to what I am trying to achieve in pygmsh: 320. I have an Abaqus mesh that I want to convert to xdmf format so as to import in dolfin . The mesh comprises of two element sets (essentially two subdomains, denoted by the keyword ELSET in Abaqus).  Is there a way to do that using meshio such that I can store the subdomain data to be called in dolfin? What I have so far:
import meshio
import numpy as np
msh = meshio.read("geom_cp_0_05.inp")
#  msh.cells[0] is a `CellBlock` containing the cells for the first domain and msh.cells[1] the second
entireCells = np.vstack(( msh.cells[0].data, msh.cells[1].data))
particles = msh.cells[1].data
entireMesh = meshio.Mesh(msh.points, cells = {"tetra": entireCells})
particlesMesh = meshio.Mesh(msh.points, cells = {"tetra" : particles})
meshio.write("entireMesh.xdmf", entireMesh)
meshio.write("particles.xdmf", particlesMesh)

I want to be able to do something like
subdomainMesh = meshio.Mesh(msh.points, cells = ....)
meshio.write("subdomains.xdmf", subdomainMesh)
from dolfin import *
mesh = Mesh()
with XDMFFile("entireMesh.xdmf") as sdf:
    sdf.read(mesh)
sub_domains= MeshFunction("size_t", mesh, subdomains.xdmf")
dx = Measure("dx")(subdomain_data=sub_domains)

Also, how are element-sets imported in meshio. I see that there was some work in #493 but not sure if I can access each ELSET in meshio as of now. If I try to
print(msh.cell_data_dict)

I get an empty dictionary

Is there anything in msh.cell_sets rather than msh.cell_data_dict? See
https://github.com/nschloe/meshio/blob/44a91dc9ca9655dd1297ebffcf5d5eefd511527e/meshio/abaqus/_abaqus.py#L137-L147
The cell_sets attribute is a newish feature of meshio.Mesh; it is so far ignored when writing XDMF.  Reading XMDF Modal and Format does suggest a few possibilities for how such information might be recorded in that format (multiple Grids #568, Subset, Set).  I don't know how dolfin reads XDMF.

Is there anything in msh.cell_sets rather than msh.cell_data_dict? See

No it too returns an empty dictionary.

Hmm. Could you share an MWE?

Sure. I am attaching the Abaqus-generated mesh.
geom_cp_0_05.zip
import meshio, os
msh = meshio.read("geom_cp_0_05.inp")
#  msh.cell_sets --> "{}"

Although, I have partly been able to do what I want but would anyway like to have an insight on this.

Thanks.  I don't know what the Abaqus .inp format is supposed to look like myself, but if lines like 123972
*Element, type=C3D4, ELSET=PART1

or 716709
*Element, type=C3D4, ELSET=PART2

are valid then the 'ELSET' is not going to be detected by the current implementation of meshio.abaqus._abaqus.read_buffer which only looks for "ELSET" in keyword where
https://github.com/nschloe/meshio/blob/3ca5b8f19de63a7ea18dbaf737196453da687170/meshio/abaqus/_abaqus.py#L123
This is only going to give keyword == "ELEMENT" and never reach the clause quoted above.  The lines are reread in ._read_cells into sline but only to extract the type (here "C3D4"), not the "ELSET".

I see. Thanks for pointing it out. If this is it and there are no major changes elsewhere then maybe I can take a stab at editing
https://github.com/nschloe/meshio/blob/3ca5b8f19de63a7ea18dbaf737196453da687170/meshio/abaqus/_abaqus.py#L137 to make sure that cell_data can recognize ELSET's.

At first glance, it doesn't seem too complicated to fix (I don't have time right now).
You'd simply have to parse ELSET in function _read_cells and make the latter returns an element set dict (empty if no ELSET), and then update the dict cells_set in function read_buffer.
However, I wonder what would happen if you invert the order of ELSET and type i.e. whether *Element, ELSET=PART1, type=C3D4 is valid for Abaqus. In case it is, parsing the line starting with *ELEMENT into a dict would make things easier and less error-prone for the future.

However, I wonder what would happen if you invert the order of ELSET and type i.e. whether *Element, ELSET=PART1, type=C3D4 is valid for Abaqus. In case it is,

Good catch, I think it might be.  The ‘Input deck format’ *ELEMENT documentation for Calculix (which reads the same format as Abaqus) gives the example
*ELEMENT,ELSET=Eall,TYPE=C3D20R

I PRed the line conversion into a dict (PR #752). I don't have time right now to make the fix for element sets but you should be able to do something like:
if "ELSET" in values.keys():
    # Append cell ID to local cell_sets dict
    # Probably need to remap cell ID too

"Thanks" to COVID19, I found some spare time to look into a fix. It wasn't as straightforward as I thought, though.
In PR #760, Abaqus reader is able to parse ELSET defined in ELEMENT, and mesh.cell_sets_dict should return
{
    'PART1': {'tetra': array([0, 1, 2, ..., 592733, 592734, 592735])},
    'PART2': {'tetra': array([592736, 592737, 592738, ..., 658221, 658222, 658223])}
}

Thanks for taking it up @keurfonluu ! I believe this should be it then. Thanks everyone


[FEATURE REQ] Add property to disable Kafka related auto-configuration

Is your feature request related to a problem? Please describe.
When developing an application that supports multiple Spring Cloud Stream binders:

spring-cloud-azure-stream-binder-servicebus
spring-cloud-stream-binder-kafka
spring-cloud-stream-binder-rabbit

an application fails to connect to on-premise Kafka (which is not deployed in Azure). The root cause - AzureEventHubsKafkaOAuth2AutoConfiguration changes user-agent for kafka-client (see class constructor) from apache-kafka-java to apache-kafka-java/az-sp-kafka. And then when client tries to connect to Kafka I get errors:
Received error INVALID_REQUEST from node -1 when making an ApiVersionsRequest with correlation id 9. Disconnecting.

Describe the solution you'd like
Add @ConditionalOnProperty annotation on AzureEventHubsKafkaOAuth2AutoConfiguration, so it can be disabled using configuration properties. For example: spring.cloud.azure.kafka.enabled.

Hi @ahrytsiuk thanks for reaching us, the pr #30605 will meet your request, and we are going to use the property of spring.cloud.azure.eventhubs.kafka.enabled to control the auto-configuraion.

I will close this issue since it has been resolved in #30605, and you could reopen it for any other questions.


How do I uninstall pivpn on my rasberry pi 3?

I want to uninstall pivpn on my rasberry pi for acouple weeks but i don't know how.

I know I can't do -u for uninstalling it but is it just that or is there other stuff to uninstall?

Correction I meant to say I can do -u to uninstall but what I'm asking is there anything else I have to uninstall or does that do everything for me

Yup, pivpn -u should uninstall everything (it probably will still leave a trace somewhere, but that shouldn't really matter)


Contribution guide is contradictory

Under the section "Files, folders and naming conventions" there's a statement that a Azure policy needs to include 4 different files.

azurepolicy.json
azurepolicy.rules.json
azurepolicy.parameters.json
README.md

There's a description stating

Include a README.md file that explains how the Azure Policy works, and how to assign it at scope.
Guidelines on the README.md file below.

Same under "Pull requests"
PR must:

Contain a single Policy (with 4 files)
Requests for changes must be answered within 30 days

PR will be deleted after this time

However, there's also a section stating that the README.md is optional
https://github.com/Azure/Community-Policy/blob/master/CONTRIBUTING.md#readmemd-optional
Is the guideline that the README.md must be included or is it optional?

Optional. We are having a discusion around this topic and will refine the guidance soon.


Add version or app info in settings

If possible it would be nice to see the app information along the version info in settings or a new info menu below the settings.

added


[Bug]: PDF not renderable due to CSP not allowing WASM since PDFJS4 - CompileError: WebAssembly.Module(): Refused to compile or instantiate WebAssembly module

Attach (recommended) or Link to PDF file
PDFJS-JPEG2000-WebAssembly-Problem.pdf
Web browser and its version
FireFox 128.0, Edge 126.0.2592.102, Chrome 126.0.6478.183
Operating system and its version
Windows 11 Enterprise 22H2 22621.3880
PDF.js version
4.4.168
Is the bug present in the latest PDF.js version?
Yes
Is a browser extension
No
Steps to reproduce the problem

Have a Content-Security-Policy that does not allow usage of WebAssembly
Try to render the PDF file which has JPXDecode inside
The canvas stays blank and receive a warning on the console

What is the expected behavior?
The canvas should get painted and no console warnings should happen.
The problematic PDF file was renderable with PDFJS version 3.
What went wrong?

The canvas stays blank.
The browser console logs Warning: Unable to decode image "img_p0_1": "CompileError: WebAssembly.Module(): Refused to compile or instantiate WebAssembly module because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src 'self' *.company.tld"".

Link to a viewer
No response
Additional context
The PDF was renderable without problems with the same CSP with PDFJS version 3.11.174.
I am not allowed to adjust or weaken the CSP.
This is the CSP: default-src 'none'; script-src 'self' *.company.tld; connect-src 'self' *.company.tld; img-src 'self' blob: data: *.company.tld; frame-src 'self' *.company.tld; style-src 'self' 'unsafe-inline' *.company.tld; font-src 'self' *.company.tld; frame-ancestors 'self' *.company.tld; upgrade-insecure-requests;

Have a Content-Security-Policy that does not allow usage of WebAssembly

Most unfortunately, such a CSP is incompatible with the latest PDF.js versions.

Try to render the PDF file which has JPXDecode inside

Please note that there were a number of reasons for replacing our old JS-based JPEG 2000 decoder (with a compiled one based on the OpenJPEG decoder):

It was significantly slower, and used more memory.
It contained various (often old) bugs.
It lacked support for a lot of JPEG 2000 features.
None of the PDF.js contributors knew enough about the image format to support/improve the decoder.

I am not allowed to adjust or weaken the CSP.

That's very unfortunate, but we cannot really help in that case since we won't revert to the old JS-based decoder for the reasons listed above.


Test correct court finder text is shown

Different for in-state and out-of-state.

Closed by #201


[WIP] Better support for ?include_attributes and ?exclude_attributes API query param filters

This pull request improves handling of the ?include_attributes and ?exclude_attributes API query param filters.
With those query parameters user can specify which attributes it wants to receive in the API response. Among other things, it also controls which fields we retrieve from the database.
Because of the way our API models and responses work, we convert database document to the API model before serializing that to JSON and returning it as a response. API model performs object validation and sets the default values for the fields which are not provided.
That means, for example, if user only requests name field it may get many other fields back, depending on the default values specified on the API model jsonschema (and those fields will use default values from the API model schema which is confusing and invalid).
The problem is related to the issue (deficiency in our API model handling) I've already mentioned a long time ago. We are abusing API model for two purposes - input and output. We really should have two models (one for input and one for output) and this way we would avoid issues like that.
Sadly that would require a lot more work so I'm going with the middle of the ground approach to begin with.
As per discussion with @enykeev, I decided to perform this filtering inside the router. This way it happens very last, just before serializing the response to JSON and returning it back to the user.
In the first attempt, I tried to do it inside the API model, but it really doesn't belong there.  API model represents data which has been validated and it's complete and valid (based on the model jsonschema). API model with some fields missing could potentially be invalid, hence that data shouldn't be represented by the API model.
Current approach is not the most efficient, because we still convert each database document to the API model before filtering / processing the response, but it should be a start. Future optimization would involve skipping the API model layer all together when either ?exclude_attributes or ?include_attributes query param filter is provided.
That involves a lot more work and refactoring though (we would potentially need to touch and change each API controller because a lot of them override parent controller "_get_all" method and handle API model instantiation themselves).
TODO

[ ] Tests

[ ] Test for various edge cases (invalid field specified, field contains non-whitelisted characters, make sure user can't fish out secret parameters, etc.)

[x] Add support for those filters to all "get_all" / list resource API endpoints

Another thing to keep in mind - due to how we handle our resource models (actions, sensors, rules, triggers, etc.), fields which form a ref attribute (aka resource primary key / unique identifier) need to be always present in the response.
For resource models those fields are name and pack and for other models, that field is id. I personally think that's not an issue and is desirable since "get_all" / list response which doesn't contain item's primary key is of no use / makes no sense.

@enykeev I'm still working on adding support for those query param filters to all the resource API endpoints and improved tests, but the core functionality is ready for review.
Main changes are pretty straight forward and include:

New _process_response method which handles attribute exclusion before sending response back to the client - https://github.com/StackStorm/st2/pull/4300/files#diff-364c1d17f394113df1634d1423d1a3c4R578
Skip response validation if response schema is available and those filters are provided - https://github.com/StackStorm/st2/pull/4300/files#diff-364c1d17f394113df1634d1423d1a3c4R540. It makes no sense to perform response validation when those filters are provided because response will be partial and will likely fail validation (this should also speed things up a bit).
Removal of old "include_reference" related code which we don't need anymore (we haven't need it for a long time now) - https://github.com/StackStorm/st2/pull/4300/files#diff-364c1d17f394113df1634d1423d1a3c4R540

On a related note - it's actually a good idea that we do this parameter filtering at the very and don't skip the DB model and API model layer.
Secrets masking happens inside the DB and API layer which means skipping it would be a bad idea. Right now the function which handles filtering (including, exclusion) gets passed in an object which has already been masked so there is no way to "fish out" secret parameter.
I also plan to spend a good amount of time next week writing test cases for all the various edge cases to make sure this functionality doesn't negatively affect the security (notable secret parameters and related stuff).

I'm working on the test cases as discussed before.
The following get all / list endpoints now support those filters:

/v1/actions
/v1/actions/views/overview
/v1/rules
/v1/rules/views
/v1/runnertypes
/v1/sensortypes
/v1/ruleenforcements
/v1/ruleenforcements/views
/v1/traces
/v1/triggertypes
/v1/triggerinstances
/v1/actionalias
/v1/executions
/v1/inquiries
/v1/packs
/v1/policytypes
/v1/policies

So pretty much all of the content pack resource API endpoints.
As far as the tests go - I added a base test class which exercises various exclude and include attributes scenarios based on the some meta attributes on the API controller test class (get_all_path, controller_cls, include_attribute_field_name, exclude_attribute_field_name).
This allows us to avoid a lot of copy and paste and duplicate code and still exercise the various scenarios.
In addition to those common scenarios, controller specific scenarios are exercised directly on that controller test class (e.g. making sure that secrets are still correctly masked when using those filters for the executions controller, etc).
Sadly we still have a lot of "legacy" test cases which insert and delete test data inside the test case method instead of utilizing the fixtures and inserting data inside setUp / setUpClass methods. This means that the base test class is not as nice as I would want it to be.
I hope to address this in the future, but definitely not in the PR since it's already turning into a big change (sadly no way around that, we need good test coverage).
Another thing which I already pointed out and discussed with @enykeev, but I want to point out again is that some of the model have mandatory attributes which are always included in the response. Those are usually primary keys which means that for most content pack resources that is pack and name (which form a ref) and for non content pack resources that is id.
In addition to that, we have some models which have additional mandatory attributes which can't be excluded (e.g. trigger for rules and action.parameters, and runner.runner_parameters` for execution objects, etc.). Those are either needed because they form a compound primary key or because of some other functionality (e.g. to be able to mask secrets correctly).
/cc @enykeev

On a related note - this pull request also exposed a lot of issues with the current handling of exclude_attribute and lack of good tests for some other API endpoints.


Config section is not clear

Spent couple of hours trying to get this tool running but no luck, there are many cookies once you login to chatgpt (browser->dev tools->storage->cookies), it is not clear what values should I pick and in what format as the tools makes http request..

Hi there, did you try to follow the latest README and update cookie field? For now, that is the only parameter required to run the tool, though you need to update time by time.


Return dual objective function

Find an easdy way to return a dual objective function value without having to compute the inverse of P. This is related to the discussion in https://github.com/oxfordcontrol/OSQP.jl/pull/55
Suggestions are welcome!

This is also relevant for COSMO


Chore: Installed Angular framework

Description
Please include a summary of the change and relevant motivation and context.
List any dependencies that are required for this change.
"dependencies": {
"@angular/animations": "~8.2.14",
"@angular/common": "~8.2.14",
"@angular/compiler": "~8.2.14",
"@angular/core": "~8.2.14",
"@angular/forms": "~8.2.14",
"@angular/platform-browser": "~8.2.14",
"@angular/platform-browser-dynamic": "~8.2.14",
"@angular/router": "~8.2.14",
"rxjs": "~6.4.0",
"tslib": "^1.10.0",
"zone.js": "~0.9.1"
},
"devDependencies": {
"@angular-devkit/build-angular": "~0.803.23",
"@angular/cli": "~8.3.23",
"@angular/compiler-cli": "~8.2.14",
"@angular/language-service": "~8.2.14",
"@types/jasmine": "~3.3.8",
"@types/jasminewd2": "~2.0.3",
"@types/node": "~8.9.4",
"codelyzer": "^5.0.0",
"jasmine-core": "^3.5.0",
"jasmine-spec-reporter": "~4.2.1",
"karma": "~4.1.0",
"karma-chrome-launcher": "~2.2.0",
"karma-coverage-istanbul-reporter": "~2.0.1",
"karma-jasmine": "~2.0.1",
"karma-jasmine-html-reporter": "^1.4.0",
"prettier": "^2.0.5",
"protractor": "~5.4.0",
"ts-node": "~7.0.0",
"tslint": "~5.15.0",
"tslint-config-prettier": "^1.18.0",
"tslint-plugin-prettier": "^2.3.0",
"typescript": "~3.5.3"
}
Fixes #8
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code etc.
Screenshots (if applicable, else remove this line / section)
Checklist:

[x ] My code follows the style guidelines of this project
[x ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added necessary inline code documentation
[ ] I have added tests that prove my fix is effective and that this feature works
[ ] New and existing unit tests pass locally with my changes

@ArinzeOkorji With the linting and everything else, bravo!

Hi @ifeLight, have we been able to undo what was done in codacy? So that we can confirm that all the checks are fine. Great job team.

@ArinzeOkorji  let's take a look at this doc from https://docs.google.com/presentation/d/1hvnwv76gX98nAAgTxJp47CremzwPkfzDkXgejQGz2l0/edit#slide=id.g8005fdbe5f_0_98 on how a branch should be named. Also, the PR description you are seeing right now is meant to be a template/sample for you to use in telling us what you have done. Feel free to reach out for clarity.


Angular 6

Hi,
Is it possible to have an Angular 6 based build?
Thanks in advance,

I would like that too because i am upgrading my projects and currently ng2-bs3-modal is breaking my builds because it doesn't play nicely with rxjs 6.0.0.

add rxjs polyfill in your angular6 project could fix related build problem:
yarn add rxjs-compat
# npm install rxjs-compat

thats only a temporary solution because this package will be deprecated in Angular 7

@SergejSa and this information can be found where, please? Or from what information you assume?

Hi how it look. I want to remove rxjs-compat as soon as possible but bs3-modal is still incompatible.
Do you want help with update?

Chech my pull request, its two month old
https://github.com/dougludlow/ng2-bs3-modal/pull/241

After update is there issue, when i try run though ng serve compiler cannot find ng2-bs3-modal, it try to find it in whole project but unsuccess.
Log looks like:

Module not found: Error: Can't resolve 'ng2-bs3-modal/ng2-bs3-modal' in 'D:\Analityca Design\Zoomfab\zoomfabMain\webApp\src\app\assets-manager\asset-layout'
resolve 'ng2-bs3-modal/ng2-bs3-modal' in 'D:\Analityca Design\Zoomfab\zoomfabMain\webApp\src\app\assets-manager\asset-layout'
Parsed request is a module
using description file: D:\Analityca Design\Zoomfab\zoomfabMain\webApp\package.json (relative path: ./src/app/assets-manager/asset-layout)
Field 'browser' doesn't contain a valid alias configuration
resolve as module
looking for modules in D:/Analityca Design/Zoomfab/zoomfabMain/webApp/src
using description file: D:\Analityca Design\Zoomfab\zoomfabMain\webApp\package.json (relative path: ./src)
Field 'browser' doesn't contain a valid alias configuration
using description file: D:\Analityca Design\Zoomfab\zoomfabMain\webApp\package.json (relative path: ./src/ng2-bs3-modal/ng2-bs3-modal)
no extension
Field 'browser' doesn't contain a valid alias configuration
D:\Analityca Design\Zoomfab\zoomfabMain\webApp\src\ng2-bs3-modal\ng2-bs3-modal doesn't exist
.ts
Field 'browser' doesn't contain a valid alias configuration
D:\Analityca Design\Zoomfab\zoomfabMain\webApp\src\ng2-bs3-modal\ng2-bs3-modal.ts doesn't exist
.mjs
Field 'browser' doesn't contain a valid alias configuration
D:\Analityca Design\Zoomfab\zoomfabMain\webApp\src\ng2-bs3-modal\ng2-bs3-modal.mjs doesn't exist
.js
Field 'browser' doesn't contain a valid alias configuration
D:\Analityca Design\Zoomfab\zoomfabMain\webApp\src\ng2-bs3-modal\ng2-bs3-modal.js doesn't exist
as directory

@JBeater try importing from just ng2-bs3-modal instead of ng2-bs3-modal/ng2-bs3-modal.
The build changed a little bit...

@dougludlow thanks, it work fine 👍


Changing theme of runner window

Is there an easy way to change the runner window colors from dark grey on slightly-less-dark grey?

atom-runner should be using your window theme settings. see #84. If you want to make some tweaks that work a little more consistently across different theme settings, I'd welcome a pull request!

Closing. If you are interested in tweaking this, please submit a PR.


Implement Best Practices in style.css

Description:
While the current code in the style.css file is functional, it's essential to ensure that it follows best practices for maintainability and future development. We need to make sure that the CSS code is organized, well-documented, and follows industry standards.
Tasks:

Review the existing CSS code in the style.css file.
Organize the CSS rules and selectors for improved readability.
Add comments to explain complex or non-obvious code sections.
Ensure proper indentation and consistent naming conventions.
Remove any unused or redundant CSS rules.

Acceptance Criteria:

The CSS code in the style.css file should be well-organized and easy to understand.
Comments should be added where necessary to explain the purpose of specific code sections.
Indentation and naming conventions should follow best practices.
Unused or redundant CSS rules should be removed.

Additional Information:
Feel free to discuss any additional recommendations or best practices that you believe should be applied to the project's CSS. Your contributions to enhance the maintainability and readability of the code are highly appreciated.
If you have any questions or need assistance, please don't hesitate to ask. Thank you for helping us ensure that our project's CSS code adheres to best practices!

Hello! I'll be working at the following:

Improving the CSS readability,
Adapting to best practices/standards.
Removing redundant code.

Hello, good day!
Since this issue is still open, i will like to be assigned to it

Welcome @Victorthedev , I appreciate your willingness to contribute.

Hey @ktriggsdev, feel free to make changes and create a PR.

hey @MrAshwin2142 I have raised a new issue regarding possible redundant code, could you please get back to me regarding that so I can make any necessary changes?

I would like to work on this issue. Can you Please assign me this issue?'

is this still open, i want to contribute on this issue

Yes sir!


NoUnused.Parameters: don't flag named patterns

Unit patterns are ignored
testUnit : () -> Bool
testUnit =
    \() -> True

but named patterns are flagged and replaced with _
type Tag
    = Tag

testTag : Tag -> Bool
testTag =
    \Tag -> True

or
type Tagged a
    = Tagged a

testTagged : Tagged a -> Bool
testTagged =
    \(Tagged _) -> True

Named patterns are flagged if all inner patterns are _.
This seems to be a deliberate choice. However,

named patterns like these are no different from unit patterns.
often, spelling out a Tag can help to understand the code better:

Result.mapError
    (\NoGoatFound ->
        ...
    )

Providing the option to ignore named patterns in this rule could be one solution.

Hey :wave:
This is interesting. I agree that it is not necessary to remove these. I know there are some rules that only check whether a pattern is equal to _ to know whether it can be simplified/ignored, but I can't remember which ones, and therefore have trouble figuring out what the side-effects of this would be (not that we couldn't fix it in those rules later, but we might have trouble detecting them).
@sparksp any opinions on this?

Do we agree that named patterns should likely still be reported for named functions?
I get the feeling that it's more likely for a lambda to have an extra parameter because the function that uses it requires a certain shape. But for named functions, the shape of the function is a bit less important, and therefore having a (Tagged _) remain there for no reason is likely something that should be simplified.

Hmm, it becomes a bit tricky when encountering things like the following in named functions.
foo (Singular _, Pair _ _) thing =
    thing

Should we report Singular _ and Pair _ _, or should we keep them as is? Maybe stylistically it is fine to keep them, but I believe that in this case we should let the user know the argument is not used.
I think we have 2 choices:

A. Report named patterns anyway (contrary to the original request)

B. Keep the named pattern but only in some cases, such as keeping it if it's the one at the root of the argument (parentheses not included)

foo (A _) = x - Don't report
foo (A _, B _) = x - Report and suggest (not autofix) to turn both patterns by _, which will turn them into ( _, _ ) and in a later fix into _
foo (A (B _)) = x - :man_shrugging:

C. Don't report named patterns, but if the entire parameter does not introduce any variables AND is not _ (or (_)) AND does not have any otherwise simplifiable patterns, then report it.

foo (A _, B (C _) (D x) ) = x - Don't report because there's a variable introduced in there somewhere
foo (A _, B (C _) (D _) ) = x - Report because no variables were introduced, meaning the parameter is entirely unused, and the signature of the function should probably be simplified.

@sparksp @lue-bird What do you think?

I don't really see a difference between A, A _, A B, ( A, B ) or A ( B, C ).
At least they are all useful in certain contexts:
Result.mapError
    (\AnimalMissing Goat ->
        ...
    )

Maybe we do what I suggested

Providing the option to ignore named patterns in this rule
but like this:

|> keepNamedPatterns [ "AnimalMissing", "Goat" ]

?

I don't believe that's the right way to go about it, because I don't think it especially makes sense to ignore this by virtue of what type is destructured, ignoring by location or context would make a lot more sense. What I mean is that if you like this style of writing code, then you'll likely add all your types in that configuration, and if you don't, you'll put an empty list.

In the particular case of AnimalMissing Goat as a function argument, this
must mean that Goat and AnimalMissing a are the only variants of their
types; with the proposed change to ignore single variant types both would
be allowed.
Do you have any other concrete examples to consider?
On Thu, 12 Aug 2021 at 09:05, lue @.***> wrote:

I don't really see a difference between A, A _, A B, ( A, B ) or A ( B, C
).
At least they are all useful in certain contexts:
Result.mapError
(\AnimalMissing Goat ->
...
)
Maybe we do what I suggested
Providing the option to ignore named patterns in this rule
but like this:
|> keepNamedPatterns [ "AnimalMissing", "Goat" ]
?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jfmengels/elm-review-unused/issues/45#issuecomment-897432960,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB3RNOEF6DJYIPXZ6ALP23T4N6DXANCNFSM5BGERUUQ
.

--
Phill Sparks
www.phills.me.uk https://phills.me.uk/

My exact usecase is this:
An elm-review rule fix configuration hierarchy:
type FixByDestructuringIn
    = FixByDestructuringInExistingLets ...
    | FixByDestructuringTheArgument ...

if we have an error:
...
onlyCreatingSeparateLetLeftFixOr
    (\(DestructureTheArgument { argumentAlsoUsedElsewhere }) ->
        argumentAlsoUsedElsewhere
            |> onlyCreatingSeparateLetLeftFixOr
                (\DestructureUsingAs ->
                    destructureAsFix varInCaseOf
                )
    )

I'm sorry @lue-bird, but I don't follow the use-case or what you want to do with it.
Can you explain what kind of code you have before the rule, the code you have after and why it bothers you that the named pattern disappears?

I think that allowing/ignoring single variant types will fix this for @lue-bird. That will stop DestructureUsingAs and DestructureInExistingLets from getting reported.

So is the suggestion to have an option to the rule to allow or not allow this:
foo =
    \(Singular _) ->
        x

and to, regardless of the chosen option, to always report the following?
foo =
    \(Singular _, Pair _ _) ->
        x

which would then be simplified to \_ -> x.

I'm still having trouble understanding the rationale for the request. I don't understand the examples you give @lue-bird (is it implementation of your rule, or related to what the rule will look at?), and I'm having a really hard time understanding the PR you linked to, which could b
So if you don't mind, let's go back to the drawing board.
The reason people use () as an argument is usually for indicating the lack of any data or for having computations be lazy. The reason we don't report () (and I encourage it) is so that people reading the code don't have to wonder what the _ could potentially stand for.
About things like type Tag = Tag. If it's used as a phantom type, we won't have a value to destructure. If it's used as a real value, then I have to admit I'm having trouble seeing the use of such a type. If the type is meant to grow later (type Tag = Tag | Tag2), then I do some see the value of not reporting it, because foo = \Tag -> x will then cause a compiler error whereas foo = \_ -> x, and I do see value in having that reminder. But if the the type is supposed to stay as it is, then to me the API design is lacking and should be improved.
For type Tag = Tag Value, the type really holds a value. if we see foo = \(Tag _) -> x. then to me this is a sign that foo should be simplified and the argument removed. If the argument is there to fit an API (view : { takeFoo : a -> Int } -> Html msg ; view { takeFoo = foo }, then I'd say it's fair to ignore the argument by changing it to _. If again, the purpose is to let the type grow, then maybe is should stay in a case expression? (Though I know at least Simplify will remove the case expression).
So the only reasonable case I see for not removing a named pattern is for keeping compiler reminders. And that is a fine reason.
Alright, let's say we agreed that we don't want to report named patterns for that reason. Then when we see
foo =
    \(Singular _, Pair _ _) ->
        x

then we shouldn't report this, because any simplification to this will remove compiler reminders.
Similarly, this shouldn't be reported
foo =
    \(Foo Bar) ->
        x

because if we simplify it, then we lose some of the reminders.
And actually, for that reason we also shouldn't change named functions and the following should not be reported.
foo Foo =
  x

The downside of not reporting the above is that it will require more attention from the user to notice that they should remove the entire parameter when the last variable from the pattern is removed and the entire parameter lost its purpose.
I'll have to mull it over, but I am willing to go towards this solution. Let me know if you disagree with something I said, but then I could really use some detailed explanation of your rationale or needs :pray:

I have disabled reporting named patterns entirely in 1.1.16. I'll close this issue, but if you have any comments, feel free to continue the discussion or open a new issue.


Add Tailwind styling support

Add support for Tailwind styling through className, example:
const t = () => toast.success('Success!', {
     className: 'bg-indigo-500'
   })

Reason: Makes it easier for those who use the lib in Next 13!

This is already added.

And how do I style toast with tailwind? I'm using it with Next 13.

https://sonner.emilkowal.ski/toast#headless
or just className like here https://sonner.emilkowal.ski/toast#rendering-the-toast


[packagers] Docker packager loses name property

This typo:
https://github.com/jreleaser/jreleaser/blob/a0247785e5e1399be82415e2187ef14e3d7a04be/plugins/jreleaser-gradle-plugin/src/main/groovy/org/jreleaser/gradle/plugin/internal/dsl/packagers/DockerPackagerImpl.groovy#L185
    packagers {
        docker {
            active.set(Active.ALWAYS)

            repository {
                repoOwner.set("clusterless") // also this translates to {{owner}}, not {{repoOwner}}
                name.set("tessellate") // becomes null if username is not set, otherwise username if set
            }

Expected Behaviour
The repository.username, when set, should not be used as the repository.name.
Actual Behaviour
Cannot publish docker image because the repository name is incorrect.
Environment Information
trace.log
            repository:
                enabled: true
                active: RELEASE
                owner: clusterless
                name: tessellate-main-docker

console log
[INFO]  Packaging distributions
[INFO]    - Packaging tessellate distribution
[INFO]      [docker] packaging tessellate distribution
[INFO]      [docker]  - docker.io/clusterless/tessellate:1.0-wip-dev
[INFO]      [docker]  - docker.io/clusterless/tessellate:latest-wip
[INFO]  Publishing distributionss]
[INFO]    - Publishing tessellate distribution
[INFO]      [docker] publishing tessellate distribution
[INFO]      [docker] setting up repository clusterless/tessellate-main-docker

🎉 This issue has been resolved in v1.8.0 (Release Notes)


daemon: Eliminate dry-mode option

Remove option.Config.DryMode to improve code readability and future development.
Fixes: #18489

Lots of tests (at least tests in daemon/cmd and test/controlplane) depend on the DryMode option, so unfortunately it cannot be removed yet.

I see. I understand why that issue hasn't resolved yet.
OK, now I'm not sure I can take enough time to do, so I close this PR.


Provide mechanism to disable CPU Fallback

Numba njit GPU function silently executes on the CPU whenever Numba is not able to successfully compile the function for the GPU. This can be sometimes frustrating to the user who has assumes the code works correctly on the GPU, while in fact it has been executing on the CPU. While providing feedback will help slightly, we really need to provide some mechanism using which the user can disable CPU fallback and force program failure when GPU compilation fails. One way would be through an environment variable.

@1e-to can we close this once your #40 is merged?

Implemented.


Mp4Composer Throw and Exception in Samsung A30 Device

This devicel cannot codec with that setting. Check width, height, bitrate and video format. i m trying to record video with filter but  am getting this error

There was an issue with Height, the width of the Video. which was 405:720 so here width is not divisible by 2, so Mp4Composer throw an exception.