Error when selecting to use OAuth2

d make whoami config
?     No
  Yes, with HTTP Basic Authentication
> Yes, with Oauth2
  Yes, with Mutual TLS (mTLS)
Set WHOAMI_OAUTH2=true

Error: choices variable is missing.
Exiting.
make[1]: *** [Makefile:13: config-hook] Error 1
make: *** [../_scripts/Makefile.lifecycle:5: config] Error 2

it happens when no existing authorization groups exist.


Reduce maximum topic size to 50MB

1GB per topic seems way too large. Instead make it 50MB. Topic data will
never be deleted until at least 1 data node has replicated the data, regardless of size.

Discussed this with @toddboom -- purely a default setting change, so merging on green.

This value's definition isn't quite right yet, as tropic truncation still needs some work, but this should reduce current space requirements on brokers significantly.


engo.Point{}.Within

@otraore thought it'd be nice to be able to say
point := engo.Point{1, 2}
spaceComponent := common.SpaceComponent{
    Position: engo.Point{3, 4},
    Width: 5,
    Height: 6,
}

// Specifically this line:
point.Within(spaceComponent)

// This you can already do, and should result in exactly the same:
spaceComponent.Within(point)

How do we make Point not depend on the common package? Through an interface?
If we define a method Within on point, it would make sense to rename the SpaceComponent.Within method to Contains. Perhaps that's just a personal preference. What do you think?

How do we make Point not depend on the common package? Through an interface?

You're right, we can't. (interface doesn't really make it any better, at least not for a "convenience" method, imho)
Contains SGTM. Awaiting response from others :smile:

https://github.com/EngoEngine/engo/issues/313#issuecomment-220161908
That’s the rename we were looking for. @mewmew
Contains does make a lot more sence for a space component
And Within more sense for a Point
@otraore in the gitter chat

Harrison Shoebridge @paked 23:27
Yep!
That's what I was trying to say

Up for grabs.

Closes by #333

I disagree @paked because https://github.com/EngoEngine/engo/pull/333 only fixes one of the things mentioned in this issue. The other one Poing.Within is still up for grabs. It's a tough issue.

How do we make Point not depend on the common package? Through an interface?

You're right, we can't. (interface doesn't really make it any better, at least not for a "convenience" method, IMHO)

The other one Poing.Within is still up for grabs. It's a tough issue.

@otraore, could you elaborate? I thought we were not going to add a Within method to Point, as that would require it to have knowledge about common. Or are we aiming to introduce some form of interface to encapsulate the notion of an entity in which another entity may be contained within?
One option may be.
package engo

// A Container is a 2-dimensional closed shape which may contain a set of points.
type Container interface {
   // Contains reports whether the container contains the given point.
   Contains(p Point) bool
}

// A Point is an X, Y coordinate pair. The axes increase right and down.
type Point struct {
   // X- and y-coordinates.
   X, Y int
}

// Within reports whether the point is contained within the given container.
func (p Point) Within(c Container) bool {
   return c.Contains(p)
}

package common

// A Rectangle contains the points with Min.X <= X < Max.X, Min.Y <= Y < Max.Y.
type Rectangle struct {
   // Top-left and bottom-right corner of the rectangle.
   Min, Max engo.Point
}

// Contains reports whether the container contains the given point.
func (r Rectangle) Contains(p engo.Point) bool {
   return r.Min.X <= p.X && p.X < r.Max.X && r.Min.Y <= p.Y && p.Y < r.Max.Y
}

// A Circle represents
type Circle struct {
   // Centerpoint of the circle.
   Origin engo.Point
   // Radius.
   Radius int
}

// Contains reports whether the container contains the given point.
func (c Circle) Contains(p engo.Point) bool {
   // sqrt(dx^2 + dy^2)
   dx := math.Abs(c.Origin.X - p.X)
   dy := math.Abs(c.Origin.Y - p.Y)
   // NOTE: Should it be `hypo < c.Radius` or `hypo <= c.Radius`?
   return math.Sqrt(math.Pow(dx, 2), math.Pow(dy, 2)) < c.Radius
}

Looking at the image package of the Go standard library, I believe we should change the name from Within to In:
// In reports whether p is in r.
func (p Point) In(r Rectangle) bool

(The above code has not been tested or compiled, just included to spark a discussion)

On a side node, may I ask why we are not reusing (and potentially extending through embedding) the already defined image.Rectangle and image.Point?

@mewmew In response to your first suggestion, that seems like a really nice solution. I'm going to implement it and send in a PR to spark up a discussion.


Remove .git from project URL.

Strictly the .git extension points at the git repo bundle, which is useful only for cloning the git repository. GitHub very kindly redirects browser requests for this URL to the HTML home page, but we should save GitHub the effort and point to the correct site.

Coverage decreased (-0.03%) to 96.857% when pulling efcec22efe9d3530a8cc1204c0d8466071dcfc86 on Lukasa:patch-1 into 88240d3152d6c13c15caf89d668d71a755c80f38 on peterbrittain:master.

Coveralls, continuing to be weirdly inaccurate.

Hey, Cory.  Nice to hear from you again.  How did you spot this?

I spotted it in passing, weirdly. I ended up on the PyPI page for asciimatics somehow, following a chain of links, and noted the strange URL in the Home Page section of the metadata. I figured it was easily enough fixed. And then it was just a matter of being a good OSS citizen and pitching in to help out. ;)


Force to enable systemd services after installation ha success

We found the zuul node won't startup automatically after reboot.
So we need to enable the all services into sytermd autostartup process
after installation ha.
Related-Bug: theopenlab/openlab#218

recheck

recheck


ENH: Savitsky-Golay filter for non uniformly spaced data

Is your feature request related to a problem? Please describe.
I've been using scipy's Savitzky-Golay filter multiple times in the past. Now I have a task where I would like to apply the filter to non-uniformly spaced independent data.
In my application, the independent data are not entirely randomly spaced, but originate from lab data where the measurement interval is successively increased, e.g. 0,1 s interval for 1 hour, followed by 1 s interval for the rest of the day, followed by 10 s interval for some days, etc.
Describe the solution you'd like.
I am by far not a signal nor mathematics expert, but I am still wondering whether it would be possible (or desired) to extent the scipy.signal.savgol_filter for the derivatives of non-uniformly spaced data. This could be triggered by setting the delta parameter not to a single value, but to an array of deltas, having the same size as the data.
I found a implementation on stackexchange and a github repo based on the very same proposal.
As far as I understand, the current implementation is limited to uniformly spaced independent data (using delta and deriv parameters) because this reduces to a single set of coefficients and very efficient folding operation. There's also concerns that a significant increase in runtime by changing a single parameter (delta) could be at least surprising for users with large datasets. Yet it thought it might still be worth discussing, whether any form of semi-fast implementation might be worth looking into.
So here are some ideas to speed things up:
At least for my desired application, the independent variable is not entirely random. Hence, a sort-of piece-wise savgol filter could be employed. Considering my example from above, for example. It would not be necessary to recalculate the savgol_coeffs for each window, as the delta varies only occasionally. This would result in a reduced set of deltas for which the coefficients would have to be calculated, e.g. for a window length of 5:
[0.1, 0.1, 0.1, 0.1, 0.1],
[0.1, 0.1, 0.1, 0.1, 1.0],
[0.1, 0.1, 0.1, 1.0, 1.0],
[0.1, 0.1, 1.0, 1.0, 1.0],
[0.1, 1.0, 1.0, 1.0, 1.0],
[1.0, 1.0, 1.0, 1.0, 1.0],
...

Obviously it is strongly dependent on the level of non-uniformity of delta, how many sets of coefficients are needed.
I also found a reference  to a paper pointing towards polynomial something called "similarity transformations" in the same context. Unfortunately, I neither have access to the paper, nor do I fully understand the implications of this method.
Any thoughts on this?
Describe alternatives you've considered.
No response
Additional context (e.g. screenshots, GIFs)
No response

This is the kind of thing that I'd like to see developed in a separate package first, then adopted into scipy once completed (if it still makes sense to do so with the data gathered from real use) rather than developed inside of scipy.

Doing some research, I found a paper which I can access:
Gorry, P. A. (2002). "General least-squares smoothing and differentiation of nonuniformly spaced data by the convolution method." Analytical Chemistry 63(5): 534-536. [1]
I am in the process of implementing it. Preliminary results are promising.  Not sure how to fix that yet.
A quick outlook (just an abritrary timeit comparison):
scipy: 0.03243189997738227 # original savgol_filter
polyfit: 6.405896900017979 # fitting all polynomials individually
gorry: 0.1077934000059031 # based on linked paper

I will publish the code, as soon as I find the time to clean it up a little.
[1] https://pubs.acs.org/doi/abs/10.1021/ac00005a031

It looks good if gorry  is only 3 times slower.
AFAICS, Gorry article is for unequal spaced points.
An alternative for piecewise constant spacing would be to stitch together SG on subsamples. The main work is then to smooth the connecting points which will require separate filters for the window length observations.

A question:
Is there any recommended way to test the performance? Maybe even some standardized test signals available to use?

It looks good if gorry is only 3 times slower.

Turns out this is not always the case. This was for a fairly small signal (1k points and polyorder=2). For larger signals it doesn't scale as good. Increasing the polyorder also reduces performance, as the Gorry approach recursively generates the coefficients in a loop over polyorder.
For now, I have focused on getting it to work. And after dealing with multiple edge-cases (even window, edge points), it now gives me identical results to scipy's savgol_filter. While I am not a professional programmer, even I still see some room for improvements in my prototype. That's why I haven't uploaded it yet.

AFAICS, Gorry article is for unequal spaced points.
An alternative for piecewise constant spacing would be to stitch together SG on subsamples. The main work is then to smooth the connecting points which will require separate filters for the window length observations.

That's what I was thinking initially, but my application is not that performance hungry. Hence, I'd rather develop are more universal filter rather than dealing with my niche case and regret it the next time I have a truly nonuniform signal.
In the long run, however, a combination using piece-wise classic savgol on equally-spaced sections and Gorry for the stitching sections might be the way to go.

So here is finally a draft of what I was able to come up with. I am not entirely convinced, but at least I did learn a lot during the process.
Some remarks regarding this implementation:

The Gorry algorithm relies on recursive calculation of weight factors, which I did not now how to do other than using a loop over np.arange(0, polyorder+1).
Regarding the individual windows, I was able to do this with matrix formula, avoiding an outer loop. This might be memory intensive, but is faster than an outer loop.
I separated the start values for all recursively calculated parameters in separate conditions. This could be done in a more compressed manner in less conditions. For the sake of clarity, I kept it separated for now.
With the initial problem of partially uniform $x$ values in mind, I calculated $\Delta x_{window} - x_{window, center}$ and ran np.unique on it, so that I only have to calculate parameters for uniquely spaced windows.
In an intermediate version, I did not use np.unique windows and did not center them to 0, but calculated every window regardless of possible repetition. There, I encountered weird spikes in the results when setting large polyorder. I am not entirely sure where they were coming from. The algorithm requires the calculation of powered values of x for each window in the form

\left( \begin{matrix} x_0^0 & ... & x_{windowsize}^0\\ ... & ... & ... \\ x_0^{2*polyorder+1} & ... & x_{windowsize}^{2*polyorder+1}\end{matrix} \right)

So I can only suspect, that I ran in some kind of float precision loss during calculation of $x_i^{2*polyorder+1}$. If it is in fact related to precision loss, this should also occur when have signals with very large $\Delta x$. Unfortunately I was not able to reproduce this.
Performance
Regarding performance, I did only some very basic tests. The basis was a sine signal with added artificial noise. Based on this, I created three different signals:

with uniformly spaced $x$ -> x-uniform, solid lines
with three uniformly spaced segments of $x$ -> x-partial, dashed lines
with random noise added to all $x$ -> x-nonuniform, dotted lines

These I filtered with three savgol versions:

scipy.signal.savgol_filter (blue)
A reference implementation, which basically loops np.polynomial.polynomial.polyfit over all windows -> polyfit (green)
The linked implementation of Gorry algorithm -> nonunfirm (red)

Signal length

Regarding signal length, the performance lies inbetween scipy version and referency polyfit. It does not scale as well as scipy-version. Calculating only uniquely spaced windows kicks in, for larger signal lengths as the uniformly spaced segments remain the same, whereas the ratio of unique transition windows relative to the total signal length decreases.
Window length
To be fully transparent, for a signal with $N_{points} = 10^5$, my implementation scales poorly, even exceeding the reference polyfit. Not sure whether this is my implementation or the algorithm itself...

Conclusion

Scaling seems to be an issue with my implementation. For small signals its better than just fitting polynomials per window, but this seems to change for larger signals and window length.
Poor scaling with polyorder is intrinsic to the Gorry algorithm, as it requires recursive calculation of weight factors.
I will keep investigating, where the mentioned spikes came from, if I ever encounter them again.
For partially uniform signals, using uniquely spaced windows helps, but that strongly depends on the data.

After seeing the performance tests, I think it is not yet suited for scipy. At least in it's current form. If you have any recommendations regarding my hobbyist-style implementation, I am open for suggestions.


Init 22.10.0-SNAPSHOT

Signed-off-by: Peixin Li<EMAIL_ADDRESS>as title. Verified 22.10 build in internal pipeline

Please help review but let me merge it since we need to merge corresponding internal CI MR at the same time, thanks!


Uninitialized variables work around strictNullChecks

TypeScript Version:  2.2.0
--strictNullChecks must be used.
Code
interface Foo {
    name: () => string;
}

let foo: Foo;
setTimeout((() => foo.name()), 0);

Expected behavior:
Error at let foo: Foo line since the compiler is implicitly doing let foo: Foo = undefined;.
If I were to write the = undefined initializer myself, the compiler properly errors with:
Type 'undefined' is not assignable to type 'Foo'.

Actual behavior:
The code compiles and errors at runtime:
TypeError: foo is undefined

Possible duplicate of https://github.com/Microsoft/TypeScript/issues/11463.

Ping! This still feels broken to me.

I've been bitten by this too, this seems broken that let foo: Foo; can be an allowed statement with --strictNullChecks.
It's not even that TS is unaware that it's potentially undefined as the below snippet does error.
interface Foo {
    name: () => string;
}

let foo: Foo;
foo.name(); // foo.ts(6,1): error TS2454: Variable 'foo' is used before being assigned.

Have you tried const?

Using const errors with foo.ts(5,7): error TS1155: 'const' declarations must be initialized which is nice, but in a case where a variable may or may not be set later (necessitating let), I would like the type checker to prevent me from assuming it's certainly defined later.

You can add | undefined to such variables. I agree that it's a shortcomming of the compiler that it's unable to track whether a variable is initialized inside closures, but that's because you can't know whether the closure is immediately invoked or stored for later use.

Ah, my example was a bit unclear. I'm fine with TS being unable to know when a variable has been initialized in a closure. I'm advocating for the same expected behavior as the OP, no error at line 6 but an error at line 5 Type 'undefined' is not assignable to type 'Foo' which does not require tracking of initialization beyond the variables declaration statement.

Well, that's kind of unpractical for deferred initializations such as in if\else.

Sure, but I'm not enabling --strictNullChecks and using TypeScript for the practicality and free-wheeling spirit of initializing variables however I please 😉  . When I've declared a variable to be of a particular type, I've explicitly expressed the desire for undefined to not be considered a member of that type, and I assign undefined to that variable somewhere in my program (regardless of if I potentially re-assign to a valid type elsewhere, such as in your if/else example), I expect a reasonable compiler to provide me with an error.
I'm sure there are cases where this necessitates additional ! operators throughout the code, but that's to be expected if indeed a particular Object "is possibly 'undefined'".

@gcnew

Well, that's kind of unpractical for deferred initializations such as in if/else.

Coming from a CoffeeScript background, this seems like a non-sequitur to me. I consider deferred initialization to be a bit of a code smell and tend to rely on immediately invoked function expressions for complicated initialization:
var x = (function() {
    // can even use complicated control flow
    switch (y) {
        case 1: return 'foo';
        case 2: return 'bar';
        default: return 'unknown';
    }
})();

CoffeeScript has syntax sugar for IIFE's with do notation that makes this even more idiomatic.
The point is, instead of forcing the compiler to reason about variable initialization (which isn't complete because it can't deal with closures), just do complicated initialization via IIFE's. Syntax sugar is nice but it's workable without.

@rraval But then, how do you express self referential initializations?
let self = {
    x: 4,
    doSomething: () => self.x + self.x
}

It can be made  a special case, however I think the current situation strikes a good compromise:

const variables are always initialized. As a bonus they are assigned just once, which is a good thing
you can have a convention to always initialize let variables and enforce it by a lint rule
you can add | undefined to the lazily inited variables

@gcnew I'm not sure I follow. The following code seems perfectly reasonable to me:
let self = {
    x: 4,
    doSomething: () => self.x + self.x
};

self would have type {x: Number, doSomething: () => Number}, which the () => self.x + self.x expression captures and everything should typecheck cleanly.
Here's a thornier example that currently breaks even with const:
function indirection(func: () => Number): Number {
    return func();
}

const foo: {a: Number, b: Number} = {
    a: 1,
    b: indirection(() => foo.a),
};

This results in a runtime TypeError because foo is undefined when the callback for b is invoked.
Here's how I would expect things to work. I might've gotten things horribly wrong so please correct me if so:

In strictNullChecks, given a declaration let x: T or const x: T where undefined ∉ T, x must be immediately initialized.
In the initializer for x, function definitions that capture x are split into 2 types:

Simple definitions where the function cannot be passed to anything else will have x: T in their body. This means that the doSomething: () => self.x + self.x from your example has self: {x: Number, doSomething: () => Number}.
If the function //can// be passed to something else, the compiler can no longer reason about when the function gets called. Thus, for the body of the function, x: T | undefined. For my example, b: indirection(() => foo.a), inside the function foo: {a: Number, b: Number} | undefined, at which point the compiler can complain about foo.a because it no longer typechecks.

Point 1 can be made palatable with sugar for IIFE's for complicated initialization.
Point 2.1 should capture the bulk of self referencing function definitions and things just work. This is because the compiler knows that those functions cannot be invoked until after the variable has been initialized.
Point 2.2 is necessary to ensure correctness. The current version of the compiler breaks with a runtime TypeError, which seems to fly in the face of TypeScript's primary goal.

Ping!
We might as well close this issue if it's just going to languish like this.

@gcnew 's comments already addressed why this is the intended behavior. See #10641, #9382, #10815

let num_or_undefined:number
function runtimeerror() { num_or_undefined.toString() }
runtimeerror()

How is this not a compile error in strict mode? How can i make it error?
let x:number|undefined works as intended, but i have to remember to put |undefined everywhere.
I feel like maybe line 1 should be an error?
Something like Type 'undefined' is not assignable to type 'number'.

@bterlson we discussed this at Edge summit way back in September, any chance you followed up? :)

@RyanCavanaugh Why was this closed? Those fixes don't cover this particular issue.
I think it's especially important to revisit this issue now that --strictPropertyInitialization is available. With --strictPropertyInitialization, this code correctly emits a compile error:
Link
class Foo {
  private x: number; // Compile-time error!
  foo() {
    // `x` isn't initialized!
    // But it's OK, compile-time error above.
    return this.x.toString();
  }
}

But this code compiles successfully:
Link
function fooFactory() {
  let x: number;
  return {
    foo() {
      // `x` isn't initialized!
      // Run-time error!
      return x.toString();
    }
  };
}

Shouldn't there be a --strictLocalInitialization mode to catch errors like this? I imagine it would work similarly to --strictPropertyInitialization: if a local variable is not synchronously initialized before it's used, a compile error would be emitted. To resolve it, one would need to:
A) Initialize the variable in a way that the TypeScript compiler understands (e.g. immediately, or before referencing it in a function somewhere).
-OR-
B) Use a definite assignment assertion. (It seems that this issue would come up naturally when discussing definition assignment assertions for local variables.)
-OR-
C) Explicitly mark the variable as potentially undefined.

Expanding upon option (B), this code was given as an example in the linked-to blog:
let x!: number[];
initialize();
x.push(4);

function initialize() {
    x = [0, 1, 2, 3];
}

I think that this is a misleading example. This code - in an ideal world where the compiler performs flow analysis - should not need the definite assignment assertion. However, this code should (and currently does not):
let x: number[]; // Doesn't require definite assignment assertion.
function foo() {
    x.toString();
}
foo(); // No compile-time error, but throws an exception.

Thoughts?

@agopshi you can log a new suggestion for that


Feature/podcast creation

Endpoints Done :

Create and Get podcast
Add, Delete and Edit Episodes

TBD :

Unit Tests

Closes: #18


I'd like to use yaml instead of json on swaggerUI

I'd like to load static yaml file (not generated)  via SwaggerUI, is it possible?

I think this could work:
app.UseSwaggerUi(settings =>
{
     settings.SwaggerRoute = "/my/path/to/swagger.yaml";
     settings.SwaggerUiRoute = "/swagger";
});

This was the 1st thing I actually tried, but it does not work, it says - file not found, file is located in the same folder as json which works

This works only when the swagger file is generated from the assembly but I need to just load a static file instead

Seems to work for me?

It probably only works if the file is hosted on the same server...

Just don't add the assembly as first parameter then only the UI is served and no spec is generated...

Yes that works, I was trying with UseSwaggerUi3, and that does not work, it says:
Failed to load API definition. Fetch errorNot Found /swagger/v1/swagger.yaml

Can you try to directly load the yaml file which is shown in the UI? Is this working? (also check what URL is loaded by the UI with F12 and check if this is accessible)

not sure whether this helps:

Yes, so now you just have to ensure that the yaml file is served from http://localhost:3001/swagger/v1/swagger.yaml - you need to do this manually...

Not sure what you mean, the file is located in that folder, if I use UseSwaggerUi it works, if I use UseSwaggerUi3 it does not.

sorry for confusion, so it does not work in both cases when you want to display static yaml file, I was cached version from browser when I used generated yaml from assembly before

I think you cannot just put a file in a directory and access it with ASP.NET Core, you need to register a middleware for that: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/static-files?tabs=aspnetcore2x

I have it there, see my previous comment

The problem may be that the UI and static file are both served from /swagger and only one of the middlewares are being process and the other is ignored... maybe try to register the static file middleware before nswag m.?

the StaticFiles middleware was registered before, but I got back to the static json, not yaml an it says something different:
Can't read from server. It may not have the appropriate access-control-origin settings.

Ok, then you're probably almost there
https://docs.microsoft.com/en-us/aspnet/core/security/cors

So, my findings:
json issues:
the message about cors is wrong, I had all the stuff allowed, but the problem is that I had non valid json, then it is evaluated in js file as else if (response.status === 0) {           return self.fail('Can\'t read from server.  It may not have the appropriate access-control-origin settings.');
if I want to expose yaml file via staticfiles lib I have to register the extensions like var provider = new FileExtensionContentTypeProvider();             // Add new mappings             provider.Mappings[".yaml"] = "application/x-yaml"; then use it in staticfiles settings

Good findings. It would be great if you could update the wiki with that: https://github.com/RSuter/NSwag/wiki/Middlewares#customization


Can you make the eyes friendly?


fix resize on rtl page

Fixes: #6057
Demo

Can you test an rtl language in the demo when switching to rtl mode? E.g. change the legend from "# of votes" to "عدد الاصوات"

Can you test an rtl language in the demo when switching to rtl mode? E.g. change the legend from "# of votes" to "عدد الاصوات"

Don't see a difference, do you think there should be?

@kurkle can you add a regression test by duplicating one of these tests.

@kurkle can you add a regression test by duplicating one of these tests.

Done 🚀

Can you test an rtl language in the demo when switching to rtl mode? E.g. change the legend from "# of votes" to "عدد الاصوات"

Don't see a difference, do you think there should be?

No, after looking into rtl a bit more it seems there should not be a difference.
I was worried that setting ltr might not do the right thing for users in Arabic or Hewbrew. But as far as I can tell this doesn't change anything. The tooltips look like they might not be aligned properly when the user is using an rtl language, but that's the case on master as well. At least this fixes the resize issue

But as far as I can tell this doesn't change anything

direction: rtl is enforced only on the internal div (.chartjs-size-monitor-*) that are used to detect a resize, thus it doesn't impact the canvas or any parent of the canvas or any user DOM elements.

Thanks @kurkle


Add Docker run command

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@lilien1010 please aign the CLA, thx


New release tag

It's been a long time since the more recent release tag.  We should probably make a new one.
(And probably, come up with a process for regular releases.)

Hi - sorry to hijack this issue - could the Python version also get a new release tag by the way? There's been an issue for this for a couple of months: meshcat-dev/meshcat-python#142

I think we can make a tag, but I'm not sure if anyone I know has access to publish on PyPI.  I'll ask around.

I think we can make a tag, but I'm not sure if anyone I know has access to publish on PyPI. I'll ask around.

Shouldn't @rdeits have access ?

Ah, sorry, happy to provide PyPI access so you can update that. I'll do
that next time I'm at my home computer.
On Thu, Jan 25, 2024, 16:21 Wilson @.***> wrote:

I think we can make a tag, but I'm not sure if anyone I know has access to
publish on PyPI. I'll ask around.
Shouldn't @rdeits https://github.com/rdeits have access ?
—
Reply to this email directly, view it on GitHub
https://github.com/meshcat-dev/meshcat/issues/164#issuecomment-1911016785,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEQQDVG3QJVDBWUKO36A4LYQLEDXAVCNFSM6AAAAABCF3AIA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJRGAYTMNZYGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

That's great, thank you!  My PyPI username is the same: jwnimmer-tri (https://pypi.org/user/jwnimmer-tri/).

Done!
On Fri, Jan 26, 2024 at 1:27 PM Jeremy Nimmer @.***>
wrote:

That's great, thank you! My PyPI username is the same: jwnimmer-tri (
https://pypi.org/user/jwnimmer-tri/).
—
Reply to this email directly, view it on GitHub
https://github.com/meshcat-dev/meshcat/issues/164#issuecomment-1912501415,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEQQDSMLJ6P4EBVZ66F2LLYQPYPPAVCNFSM6AAAAABCF3AIA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGUYDCNBRGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Once there is a new release, updating the artifact URL in MeshCat.jl to something more bit stable and without symlinks should fix the installation issue in https://github.com/rdeits/MeshCat.jl/pull/248

Hello, is there any progress towards a new release?

No, there isn't any progress.  To be notified when a release happens, you can go to https://github.com/meshcat-dev/meshcat and use the "Watch" widget option for "Custom" to select "Releases", and then GitHub will email you as soon as a release happens.


[HOLD for payment 2024-05-08] [$500] Public room - Login page shows momentarily before showing public room

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.51-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4421788
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
precondition: user created a public room and copied the link

Log out of ND if logged in
Navigate to a public room via deeplink, e.g. https://staging.new.expensify.com/r/1275927936266854

Expected Result:
The user is navigated to a public room, and the chat history is displayed
Actual Result:
The user is navigated to the sign-in page. Only after login, the public room is opened
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/57d887c1-fb40-449b-8919-76a418ae4887

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0177518535cd3da4f9
Upwork Job ID:<PHONE_NUMBER>502310912
Last Price Increase: 2024-03-27
Automatic offers:

tienifr | Contributor | 0

Issue OwnerCurrent Issue Owner: @puneetlath

@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

This is a BE issue where some onyx data is in array.

PR #38272 of issue #37999 is awaiting fixing of this issue.

Hmm, so when I try it shows the login page momentarily but then does show the public room after a second.
https://github.com/Expensify/App/assets/1371996/a98481b2-0496-488e-85f0-72079c1303e5
So @bernhardoj I feel like maybe something changed and this is indeed a client-side issue. What do you think?

Proposal
Please re-state the problem that we are trying to solve in this issue.
Public room - Login page shows momentarily before showing public room
What is the root cause of that problem?
Onyx network.isOffline is temporarily set to true, causing the splash screen to be hidden too early.
What changes do you think we should make in order to solve the problem?
Prevent setOfflineStatus from being called when state.isInternetReachable equals null, in code below.
https://github.com/Expensify/App/blob/729d4758be1ca005113148f1dc0dd3f9694ffa5b/src/libs/NetworkConnection.ts#L109

@kmbcook tested your solution and i am still able to reproduce the issue.

@getusha if the link above is used, then the issue can be reproduced because the link is to staging instead of to development in which code changes have been made. I don't know if that is something you have done, but I have mistakenly done that a few times!
Without any code changes I can reliably reproduce the issue by opening a new incognito window each time I want to reproduce. After code changes I have never been able to reproduce.

I just realized that there are two places where this same change should be made, so I updated my proposal.

Taking over!

Asked for another c+ here, @puneetlath please assign @allroundexperts

Reviewing proposals Melv.

@tienifr Can you please provide a link to support the following?

The "assuming we're offline when network status is not determined" was on purpose to prevent performance issues

Thanks @tienifr. I agree with @tienifr's proposal and the proposed solution. @kmbcook With your proposal, we'll re-introduce the the redundant ReconnectApps calls as mentioned above.
🎀 👀 🎀 C+ reviewed

I think the proposal sounds good, but I'd like to get a little wider visibility on it. Can you post it in #expensify-open-source please @tienifr?

Alright, let's do it. When can you have a PR ready @tienifr?

@tienifr can you raise a fix for the regression above?

@tienifr has been paid.
@allroundexperts bump on the checklist for you.

Checklist

I was not able to find the exact PR which caused this. It seems like several PRs introduced this issue with time.
N/A
N/A
A regression test would be helpful.

Regression Test

Log out of ND if logged in
Navigate to a public room via deeplink, e.g. https://staging.new.expensify.com/r/1275927936266854

Verify that the user is navigated to a public room, and the chat history is displayed
Do we 👍 or 👎 ?

Issue for regression test is here: https://github.com/Expensify/Expensify/issues/394854
Payment summary:

C - $500 - @tienifr - paid via Upwork
C+ - $500 - @allroundexperts - to be paid via NewDot

@allroundexperts please request on NewDot. Thanks everyone!

$500 approved for @allroundexperts


Update Install-Dtc.md

Issue - "fill in the blank" assignments - Description has been updated now.

Docs Build status updates of commit f46773c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2012r2-ps/msdtc/Install-Dtc.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@get-itips @tseward
Peer review needed for this PR. Thanks.


Requiring unknown module react-native-tab-navigator

Hi all,
I have an issue that can not find requireing module as attaches. I have clear cache npm  and npm install again, reinstall app by react-native run-android but still not working. Please help me.

Thank you for all, I don't know why, but after restarting my computer. It is ok now.


How class_embedding is obtained？

Hi, can you tell me how class_embedding is obtained? Is there a code for that?

Hi,
Thank you for the interest in our work.
Given the binary mask of a class in an image and the SAM image embedding of the image, we compute the class embedding by taking the average of all foreground features, in three steps.
Step 1 - Since the original binary mask has a spatial resolution of 1024x1280 and the SAM image feature has a spatial resolution of 64x64, we first process the mask to 64x64, using the code here.
Step 2 - Sometimes the foreground region can be small, so it is possible that the mask after processing has no foreground at all. In this case, we do not compute the class embedding, as shown here.
Step 3 - If the mask after processing does contain some foreground regions, we multiply the processed mask with the SAM image embedding and take the mean, using the code here. The final class embedding is represented by a vector.


Make sure a test case covers test services out of control plane NS

Investigate why the fix of #6349 wasn't covered by any tests when testing #6133.
If there is no test to cover it, add/modify one.

Not stale

@ymesika Do you have an update on this test-failure status?

@ymesika any update?

No update. Sorry didn't notice I was assigned to this preventing from others to pick it up.


Move top-level export name conflict check to analyzer

Depends on #2527.

This does not depend on #2527 anymore, since Infos are computed at link-time and can be adapted at any time.


Machine mac-29 lost connection from external iPhone device.

Machine mac-29 lost connection from external iPhone device.

Hey @kentnguyen99 , just F.Y.I. we just created a new column in ticket queue Device Lab for visibility and moved all devicelab related bugs there. Please help open new bugs in that column. Thanks.

The external connection has been restored by rebooting machine mac-29.


Layout file should be optional

Building a project without a layout file gives this error:
Copy public, assets
Cannot resolve caller slurp(IO::Path: ); none of these signatures match:
    (IO::Path:D $: :$enc, :$bin, *%_)
  in sub build at /Users/emiller/Code/rakudo/install/share/perl6/site/sources/B64B70030D8DC8D24494E45C38BA972A87CF0732 (Uzu::Render) line 541
  in sub MAIN at /Users/emiller/Code/rakudo/install/share/perl6/site/sources/A6A04D2AC064A3AC3AC0CFA1813B60BA00E99C28 (Uzu::CLI) line 63
  in block <unit> at /Users/emiller/Code/rakudo/install/share/perl6/site/resources/2FA4F1086B130C49B85739217FDF9182FFBCD515 line 5
  in sub MAIN at /Users/emiller/Code/rakudo/install/share/perl6/site/bin/uzu line 2
  in block <unit> at /Users/emiller/Code/rakudo/install/share/perl6/site/bin/uzu line 2

This should be fixed now. If the layout file is missing then the pages will render without error.

👍


Create new version of magic 8 Ball

I created a new and extended version of magic 8 ball. It contains code for the extra optional challenge.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


make CRD cluster-scoped

Summary
Makes Pomerium CRD cluster-scoped, as Pomerium Ingress Controller is naturally watching resources in multiple namespaces.
Related issues
https://github.com/pomerium/internal/issues/906
Checklist

[x] reference any related issues
[ ] updated docs
[x] updated unit tests
[ ] updated UPGRADING.md
[x] add appropriate tag (improvement / bug / etc)
[ ] ready for review

pending rebase after https://github.com/pomerium/ingress-controller/pull/273 is merged.


KAFKA-16566: Fix consumer static membership system test with new protocol

Updating consumer system test that was failing with the new protocol, related to static membership behaviour. The behaviour regarding static consumers that join with conflicting group instance id is slightly different between the classic and new consumer protocol, so the expectations in the tests needed to be updated.
If static members join with same instance id:

Classic protocol: all members join the group with the same group instance id, and then the first one will eventually fail (receives a HB error with FencedInstanceIdException)

Consumer protocol: new member with an instance Id already in use is not able to join, and first member remains active (new member with same instance Id receives an UnreleasedInstanceIdException in the response to the HB to join the group)

This PR is keeping the single parametrized test that existed before, given that what's being tested and part of the test itself apply to all protocols. This is just updating the expectations that are different, based on the protocol parameter.

Hey @lucasbru, could you take a look at this test fix? Thanks!

FYI, I've been getting successful runs with this change:
running:
TC_PATHS="tests/kafkatest/tests/client/consumer_test.py::OffsetValidationTest.test_fencing_static_consumer" bash tests/docker/run_tests.sh
results:

================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.11.4
session_id:       2024-04-16--016
run time:         27 minutes 15.117 seconds
tests run:        16
passed:           16
flaky:            0
failed:           0
ignored:          0

But I still got less frequent failures after trying it several times, so I'm afraid there may be something else (maybe related to sessions remaining open between test executions happening too close to each other?). If that's the case, I'll probably be adding another change here.
I'll dig into it and update here.

@lianetm did you mean to closet the PR?

Hey @lucasbru, yes, I had closed it just to investigate a bit more about some failures that I noticed, but ended up getting only to flaky behaviour not related to the changes in this PR, so reopening now for review.
This PR is fixing a known change in the static membership behaviour between the protocols (it was failing consistently, as expected). I still see flakiness in the test, but not in the path that this PR is fixing, and happening with the legacy and new protocol, so I would say I track that separately, since this fix is already a good improvement to the current test situation.

LGTM, thanks!
Merging this, however:

Have we discussed the behavioral difference with broker team / David?
Have we documented the behavioral difference anywhere?

Hey @lucasbru , answering your questions : the new behaviour of the static membership regarding a member that joins with dup group instance Id is documented in this section of the KIP. We've also discussed it with @dajac and other client teams (librd), seeing the improvement the new protocol bring in this area (mainly in cases of conflicting members, that continuously kick each other out with the classic protocol)
Your question does makes me notice that, even though the KIP describes how conflicting static members behave in the new protocol, it would probably be helpful extend that explanation to point out the fundamental difference it has with the legacy protocol and how it is an improved approach. (I can't find that explained in the KIP. If I'm not missing it, it would probably be a good update to the KIP static membership section @dajac ?)
Thanks @lucasbru !


Iteration plan (Week 35-36)

TODO.
Stian will work on ui.
Vegard will work on parsing.
Robin will work on rendering of particles and brain mesh.
Milestone
https://github.com/stisol/particles/milestone/3
Endgame

[ ] Add deferred issues
[ ] Setup milestone and iteration plan for next iteration
[ ] Create link to iteration plan in wiki
[ ] Create iteration tag in branch

Outdated


api generator: Generate correctly typed id argument for integer ids

Previously, the id parameter for retrieving a single item was assumed to be of type string. However, the id of an entity can also be of an integer type, which requires the id parameter of the generated method to be of type number.

Question is, if we want to support this. Our standard is usually uuid, why don't you use that in your entities? (crud generator is very opinionated, which I consider a good thing)
(we added support for int relations, that's a different story where you might have existing entities etc)

Question is, if we want to support this.

I can think of a use case: When we're synching data from external systems (e.g., for performance reasons). The external entities could have integer IDs. We could use these "original" IDs as our entity IDs as well, or we could define an additional internal ID (which is then a UUID) and keep the "original" ID as additional field (e.g., sourceId).
What's your recommended approach for this use case?

Question is, if we want to support this.

I can think of a use case: When we're synching data from external systems ...

That's exactly my use case, pretty much in every project that I work on. However, the amount of data with integer ids is fairly small compared to the amount of data with string ids (maybe 10%), but it would still be nice if I could use the api generator for all entities and not only those with string ids.

@nsams @johnnyomair have you already decided if the api-generator should support integer ids? Can we merge or close this?

we will discuss today

we will discuss today

@nsams what's the status here? Were you able to discuss this?

@lllHuber sorry, I forgot to tell you about our solution. We decided to support Integer IDs. However, we recommend using UUID IDs whenever possible, because they can be used more flexibly (e.g., creating the ID in the admin), and have no obvious downsides.
Please review if the CRUD Generator works for all CRUD operations with Integer IDs (and that they're really integers at runtime). There may be some missing transforms, for instance, while updating an entity.

@johnnyomair I've added integer support to the update- and delete-method, as well as filter- and sort-DTOs. I have also verified that the id is an integer at runtime.


fix renderIcon logic to be optional and not trigger stylesheet warnings

renderIcon is a weird mix of optional (TabNavigatorIcon has a default value, TabNavigator constantly checks item.props.renderIcon) and non-optional (marked as func.isRequired). On top of that, the default value of renderIcon returns a , which does not accept the defaultSelectedIcon stylesheet's tintColor (which is only allowed on  elements.)
This correctly makes renderIcon optional again in all senses of the word, and ensures the code works without warnings in such cases. (I see some references on the issue tracker about this problem.)
This isn't important in shipping code (where you'll most likely have icons), but is important when first setting it up without icons and seeing scary looking warnings.
The renderIcon is optional in many ways (has a default value that returns a

Published in 0.3.2, thanks :)


Migrate to Java 11

updated dependencies to work with java 11
updated travis file to include openjdk/oraclejdk 11

Signed-off-by: Martin Mihálek<EMAIL_ADDRESS>

Coverage increased (+0.09%) to 84.468% when pulling 47833ff6075281c4e067a084e4d2e7cf88aa96a6 on jdk-11 into b248ec14670ae5166ba69df0dbd7109a4e30c578 on master.


spotifywm no longer needed?

The docs suggest installing spotifywm as a workaround for spotify's behaviour not being friendly to windowrules
however, I'm currently running these rules successfully, without having to install it:
windowrulev2 = float, title:Spotify
windowrulev2 = size 1800 1000, title:Spotify
windowrulev2 = center, title:Spotify

are the docs outdated?

Just remembered I'm also using spicetify, though I'm not sure that could have any effect on the window's initial state?

Huh yeah spotify was also working on my hyprland on arch install with window rules until recently but I had to reinstall arch/hyprland yesterday and spotify won't launch at all now, with or without spotifywm.

I just tested and window rules indeed seem to work without spotifywm now. Tested with this rule:
windowrulev2 = opacity 0.90 override 0.90 override, title:^(Spotify)$


Not sorting check box column . Want to sort checkbox which are checked

I created a table in which first column is of check boxes . Now i want to this column with check boxes which are checked . I also updating data-value from 0 to 1 when some one check check box , but this is not working

is this issue stil valid?

Problem is solved for me now.. Thanks for checking with me ...

no problem


[Andriod Agent] Unable to enroll a device with Android 4.4.2

When attempting to enrol a device with Android 4.4.2., once the user enters credentials it prompts back to enter the server URL.  This happens continuously as a loop. But enrolment works fine for Android 5.0.2 devices
Tested in Samsung tab (4.4.2)

@chamaraanu  , @geethkokila , @madhawap : Labels: 3.1.0-beta2, High

This might be a regression issue introduced due to: #1121

This fix with https://github.com/wso2/cdmf-agent-android/pull/64

Verified.


Error with bourbon include

I'm getting the following error when I try to add bourbon include to main.scss like shown in the README.
@import "bourbon/app/assets/stylesheets/bourbon";

Running "sass:debug" (sass) task
Syntax error: Invalid CSS after "    eot": expected ")", was ":   "#{$file-pa..."
        on line 22 of /home/kopszak/WYDAWNICTWO/OKLEPL2/2v/oklepl/bower_components/bourbon/app/assets/stylesheets/helpers/_font-source-declaration.scss
        from line 28 of /home/kopszak/WYDAWNICTWO/OKLEPL2/2v/oklepl/bower_components/bourbon/app/assets/stylesheets/_bourbon.scss
        from line 2 of tmp/half-pipe/prepare/assets/styles/main.scss
  Use --trace for backtrace.
Warning: Exited with error code 1 Use --force to continue.

Aborted due to warnings.

OK it seems it is just a bourbon and sass problem. https://github.com/thoughtbot/bourbon/issues/419


Wireguard/OpenVPN parity issue with unmentioned reply_to bug

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[ O ] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[ O ] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
https://github.com/opnsense/core/issues/4389
Unlike OpenVPN, port forwarding through Wireguard is bugged- the wireguard ingress PASS rules must have a reply_to setting pointed to the Wireguard gateway, not the WAN Gateway- otherwise packets will be dropped without mention.
This is at best a parity issue, at worst an undocumented, critical bug that's been hidden away by closed issues.
To Reproduce
Steps to reproduce the behavior:
Follow the Wireguard selective routing guide at https://docs.opnsense.org/manual/how-tos/wireguard-selective-routing.html to the T.
Open ports on external endpoint and notice incoming packets to Wireguard interface at the selected ports being denied.
Setup a pass rule for those ports in the Wireguard interface firewall
Setup a port forward for those ports to the correct internal hosts.
Notice that ports remain closed and traffic is blocked.
Repeat steps for OpenVPN and notice it is working.
Expected behavior
Equal parity for OpenVPN or Wireguard/document the need for reply_to Gateways
Describe alternatives you considered
In advanced section of the pass rule, make sure packets are marked as to reply to the WG Gateway- but don't set the gateway lmao
Screenshots

Relevant log files
N/A
Additional context
N/A
Environment
OPNsense 23.7.8 (amd64).

This is not a support request. I've already gotten the port forwarding working
This is a parity issue. Wireguard requires the reply_to option to be set to the wireguard gateway while OpenVPN does not.
And none of this is mentioned in any document anywhere.

@Monviech I'm now having trouble with port forwards again. Even with reply_to selected, it's not working.
In short- incoming packets are logged correctly and I see all of them.
Packets incoming -> hits VPN tunnel address -> port forwarded to single host with reply_to rule -> port marked as open
So that seems to be working. And it does work- qBittorrent for example will work perfectly both downloading and seeding through the VPN.
However, anytime I try a more advanced service things fail. Specifically web uis- any web UI that I've tried to port forward has completely failed. while nmap claims the port is open, I am unable to actually access the web ui- it even redirects to the correct path such as "ip:port/web/ui/" but won't actually display anything.
Please, if you have any ideas what's going on have mercy on my pitiful soul.

If it happens for HTTPS and SSH for example, or most TCP traffic, its an MTU/MSS problem.
Its described here (applies to any vpn), look at the normalization rule that accounts for the VPN overhead in paket size.
https://docs.opnsense.org/manual/how-tos/wireguard-s2s.html#step-4a-setup-firewall-site-a

Unfortunately I cannot test SSH and HTTPS, both ports are below the size limit. I can only test any port over 2048.
I'm not sure if it's TCP, but it's possible. I'll give it a go.

Holy FUCK!
Setting the normalization to 1340mss worked.
THANK YOU!!@@!J!@KJKJK OML

Great, good job :)

@Monviech Two last questions. You're my savior in terms of everything. My sanity has been restored all thanks to you.

To resolve DNS leaks I setup a port forward rule for all DNS ports (53) from WGHosts to a specific DNS server.
This breaks local DNS resolution. The other options on the guide didn't work. Any ideas on a better method?
I cannot access my web services through their domain locally. Should I just setup some unbound DNS redirects locally, or is there a way to resolve this in a smarter way?

Sorry these kinda things are more for the forum now.
https://forum.opnsense.org/

With all due respect, I have made the post on the forum and the opnsense reddit and neither had any reception for a long time.
Both the OPNSense forums and reddit seem like they're slowly dying out.
https://forum.opnsense.org/index.php?topic=41282.0
I have made a new forum post about the NAT reflection issue if you could help.

If you think they're dying out feel free to help instead of being passive aggressive. 🤷♂

If you think they're dying out feel free to help instead of being passive aggressive. 🤷♂

Sorry, it was not my intention to come across like that, haha.
I just meant that generally people seems to stop contributing on OPNSense/PFSense related forums.
I've requested help with various problems over the past year and received barely any help overall. This github has been the most useful.


List people who've agreed to be on the OTIAB

(there are a few other invites outstanding, but this is good for now)

(per discussion at the call last Friday)

oh: once we've established this list, we can add them here: https://github.com/orgs/opentracing/teams/otiab

Glad to have this.

Usernames added... I will merge this in the next day or two if there are no objections.


support deleteWebhook and getWebhookInfo

deleteWebhook
getWebhookInfo

@zhyu Could we merge pr in here ?

@konstantinzolotarev Sorry to keep you waiting. I merged p-r 🙇


[Feature Request]: SVAMP for ReAct

Feature Description
Familiarize yourself with the repository and take a look at the ReAct repo, paper, and SVAMP.
Currently, the ReAct implementation only has prompts for HotpotQA and FEVER.
Add relevant prompts and logic to the current ReAct implementation. You'll see that an agent's current structure is divided into cog/agent, cog/modules, and cog/functional/. This task will require you to make modifications in cog/prompts, but will also require you to test your code in all the other relevant modules cog/functional and cog/agent.
What to submit:

[ ] Set up your environment via the CONTRIBUTING.md
[ ] Make a Pull Request (PR)
[ ] Add the prompts for the specified benchmark
[ ] Write a short notebook tmp.ipynb in cog/agent showcasing the agent ran on a sample question from the benchmark

[ ] Add print statements for all calls to the LLM for easier debugging + I can easily verify the outputs

[ ] Include a thorough description of your changes within the PR
[ ] Request a review from @alckasoc

ReAct may not have been tested on this benchmark. If this is true, refer to other methods that have been tested on this benchmark. Check the project lifecycle document.
If there is any additional logic for testing ReAct on this benchmark, include these specifications in the PR description.
Feel free to ask me questions on Slack if you're confused! Good luck!

hello


Upgrade dependencies to their latest versions.

@jonahkagan, these changes upgrade coffee-jshint's normal dependencies to their latest versions, as per your request in #20.
The coffee-script version in devDepencies has not been touched to stay in line with the peerDependencies version range.
Note that more recent versions of coffee-script specify "preferGlobal": true in their package.json, resulting in an npm warning if you do try to upgrade it:
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g

So ideally it should be removed altogether, but doing so will break your Makefile.

I agree that we should leave the coffee-script version in devDependencies as is, since there's no explicit need to update it. It shouldn't affect which coffee-script version users of the tool install, it should only matter when developing in coffee-jshint. So we should be able to update the peerDependencies for #17 without running into the preferGlobal issue.
This looks good. Thanks @cueedee!

Makes sense. Thank you @jonahkagan for merging this in.
One final note on finding that some previous merge requests also appeared to include a package version bump; I deliberately left the version unaltered reasoning that release management and therefore versioning decisions are best left to package maintainers.

Yep - I'm planning on releasing a new version after fixing #17


Update copyright headers

Xcode added the following header by default:
//  Copyright © 2017 omaralbeik. All rights reserved.

SwifterSwift is a community effort, lets update copyright headers to
//  Copyright © 2017 SwifterSwift

Closed in #308


Building Fixes

By making it so that the sunfire test is optional, building the project works.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Validation firing on load

I am validating using
 <Form model="mymodel" validators={validators} validateOn="change">

I am finding the validation is firing before any change as soon as the page loads.

I've adapted this fiddle as an example https://jsfiddle.net/wbd86ewj/

Also to reset, I am finding I need to reset each field individually, so I am needing

dispatch(actions.resetValidity("mymodel.field1"))
dispatch(actions.resetValidity("mymodel.field2"))
dispatch(actions.resetValidity("mymodel.field3"))

instead of
dispatch(actions.resetValidity("mymodel"))
Which I saw mentioned

The resetValidity issue is a bug, thanks for finding that.
As far as validation firing on load, this is standard behavior - the initial validity state of the form should be calculated, e.g. an empty sign up form that hasn't been touched yet is invalid.
What is your use case for not having validation on load?

I don't want to display error messages until the person has either attempted to progress to the next section, or has blurred or changed the fields.

Ah, that's why there's the .touched property on the field. ;-)
// in render()
let { userForm: { fields } } = this.props;

// displaying the error
{ fields.email.touched && !fields.email.valid &&

Please check your email address.

}

Let me know if that makes sense. This is the same way that validation works in Angular. If RRF didn't validate on load, the user would technically be able to submit an empty, untouched form because it's "valid", which is definitely not something we want.

Ok , so if I want to display validation messages if someone attempts to go to the next section without touching what would you recommend?

Good question. Would you expect the form to be "touched" if it were submitted (or at least attempted)? If so, I can add that functionality in.

I don't actually use the submit functionality of the form at present. Would that touched be then passed down to all the fields? If updating the field.touched property is the way to go then any way of doing this from an action.

Right now, no, touched is only passed to the model that is touched.
You can set any of these properties by dispatching actions: https://davidkpiano.gitbooks.io/react-redux-form/content/field_actions.html

Would it make sense if setting touched on the model that this would propagate to the fields?
actions.setTouched(model)

Yes, it would. I'll add that in.

So for validateOn="blur" I use:
// in render()
let { userForm } = this.props;

// displaying the error
{
  !fields.email.valid &&
  (userForm.submitted || userForm.fields.email.touched) &&

Please check your email address.

}

// validateOn="change" while-typing validation
{
  !fields.email.valid &&
  (
    userForm.submitted ||
    userForm.fields.email.touched ||
    (userForm.fields.email.dirty && userForm.fields.email.focus)
  ) &&

Please check your email address.

}

It would just be as david originally posted I think . .
let { userForm: { fields } } = this.props;

// displaying the error
{ fields.email.touched && !fields.email.valid &&

Please check your email address.

}

The form's submitted state should be true if the form has been submitted. Shouldn't have to add any additional code / actions for this to work properly.
You should check userForm.submitted as well as userForm.fields.email.touched

@sattaman Version 0.8.4 includes two changes:

Submitting a form now sets its touched state to true.
Changing/dirtying a field now sets its touched state to true as well.

Validation on load is the expected behavior, as explained. I'm thinking of an alternate solution of resetting validity that doesn't force you to call multiple actions, stay tuned!

Ok, so the plan is to know whether a field needs to display an error message you will need to check the form too? I currently have all my field validation handled by a wrapper around the bootstrap Input which I was just passing the field like so:
<ValidatedInput field={getField(myForm, "myField")}>
I guess I'll need to change to

Just thought I'd double check..

Right, because it's possible that a field could never be touched, but the form could be attempted to be submitted (which would cause it to be touched).
If you were just checking that the field were touched, then you'd just need to pass the field.

https://github.com/davidkpiano/react-redux-form/issues/56 would cut down on some code here

Submitting a form now sets its touched state to true.

In that case, submitting a form should set it's fields state to touched=true ?
When I do this:

I think submitting an untouched form should either:

set the state of the fields to touched=true or
set the state of the field to submitted=true
So that we can display an error message if the user clicks on submit before having tried to fill in the form

This works as expected in recent versions: https://github.com/davidkpiano/react-redux-form/blob/master/test/form-reducer-spec.js#L263-L285
That is, when the formReducer receives actionTypes.SUBMIT_FAILED, it will:

Set the .submitFailed and .touched properties to true on the form, and
Set the .submitFailed and .touched properties to true on all of the form's fields

Which version are you on? This was fixed in 0.12.7

I'm working on "react-redux-form": "^0.12.6", which was the latest available on npm yesterday...

I just tried again and npm install keeps fetching 0.12.6, any idea why ?

Should be 0.13.1: https://www.npmjs.com/package/react-redux-form
Try npm install react-redux-form@latest --save

Oh, it's OK now, I forgot the --save when rm and install... I have the 0.13.1 now.

I also confirm the problem I've initially reported is fixed in latest version :)!


Event loop gets stuck awaiting the request after last change or requests-async/http3

I've discovered an interesting behaviour recently.
The matter is that the code below starts getting stuck at awaiting the request since the bump of request-async to 0.5.0 (0.4.1 works well), but the only meaningful change in https://github.com/encode/requests-async/pull/48 is bumping of httpcore/http3 to 0.3.0 (if I'm not mistaken). That's why I decided to open an issue here.
I'm wondering if it could be possible to clarify if I'm missing something.
Happy to provide any assistance with investigation/debugging/fixing.
The code example:
import asyncio
import uvloop
import requests_async

myurls = [
    "https://google.com",
    "https://google.com",
]

async def async_get(url):
    resp = await requests_async.get(url)
    return resp.status_code

async def gather_run():
    tasks = [async_get(x) for x in myurls]
    # Await a coroutine
    result_1 = await tasks[0]
    # Or gather them all
    results = await asyncio.gather(*tasks, return_exceptions=True)
    print(f'Results: {results}')
    return results

uvloop.install()
asyncio.run(gather_run())

Note: it behaves same without uvloop.

Gotcha - that was an HTTP/2 issue in an older version.
I've updated requests-async to depend on the http3 now, which appears to resolve the issue.
Sometime soon I'll start recommending just to use http3.AsyncClient() rather than the requests-async wrapper.

Awesome! Thanks a lot for fast update and it's good to know.


Database is Locked, DML-Statements Possible

Description
All tables get the lock-symbol in the top left corner of the grid, reconnecting or restarting DBeaver doesn't help. The cells are obviously read-only.
In the script-editor I can still execute DML-statements normally and commit them. Reloading the grid then shows the changes.
DBeaver Version
Community Edition <IP_ADDRESS>306041918
Operating System
Windows 11
Database and driver
Oracle Database 11g Release <IP_ADDRESS>.0 - Production
PL/SQL Release <IP_ADDRESS>.0 - Production
CORE <IP_ADDRESS>.0 Production
TNS for Linux: Version <IP_ADDRESS>.0 - Production
NLSRTL Version <IP_ADDRESS>.0 - Production
Steps to reproduce
Don't know what's causing it.
Additional context
When I log in as SYSDBA and check the locks with DBeaver, that view is empty.
Similar to #15229

Hello @vermgit
Please check this toolbar element. Does it unlock?

That showed the same unlocked state. I clicked it twice, it reconnected twice, but no change. However, I got this instead:
ALTER SESSION SET OPTIMIZER_FEATURES_ENABLE='<IP_ADDRESS>'

[96] ORA-00096: invalid value <IP_ADDRESS> for parameter optimizer_features_enable, must be from among <IP_ADDRESS>.1, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, 10.1.0, 9.2.0, 9.0.1, 9.0.0, 8.1.7, 8.1.6, 8.1.5, 8.1.4, 8.1.3, 8.1.0, 8.0.7, 8.0.6, 8.0.5, 8.0.4, 8.0.3, 8.0.0

Could you please disable this setting in your connection settings and try to reconnect?

I disabled it, but nothing changed. I also clicked on the lock icon just to see if it helps, but sadly not.
I see a new error now:
SELECT
    c.TABLE_NAME,
    c.CONSTRAINT_NAME,
    c.CONSTRAINT_TYPE,
    c.STATUS,
    c.SEARCH_CONDITION,
    (
      SELECT LISTAGG(COLUMN_NAME || ':' || POSITION,',') WITHIN GROUP (ORDER BY "POSITION")
      FROM ALL_CONS_COLUMNS col
      WHERE col.OWNER ='owner' AND col.TABLE_NAME = 'table_name' AND col.CONSTRAINT_NAME = c.CONSTRAINT_NAME GROUP BY CONSTRAINT_NAME
    ) COLUMN_NAMES_NUMS
FROM
    ALL_CONSTRAINTS c
WHERE
    c.CONSTRAINT_TYPE <> 'R'
    AND c.OWNER = 'owner'
    AND c.TABLE_NAME = 'table_name'

[923] ORA-00923: FROM keyword not found where expected

Could you please check this query in your SQL Editor? Does it produce the same error?

Yes, the same error occurs in the SQL Editor in line 8 where "GROUP" of "WITHIN GROUP" is underlined.
Server: Oracle Oracle Database 11g Release <IP_ADDRESS>.0 - Production
Driver: Oracle JDBC driver <IP_ADDRESS>.0

Could you please enable this setting and try again?

Oh nice. Now the lock symbol is gone and also no failing internal queries. Things are looking normal now.
Thanks!


Thorchain lending slippage levels

ticket replacing this one https://github.com/shapeshift/web/issues/6577

Implement slippage color / warning scheme in thorchain lending. Follow the same pattern used in the swapper and same heuristics.
double check on LP to see if we can extend there as well
pull health tag should reflect Active or Halted state rather than Healthy

What I did on LP:

If it's something else than Available, it will display Halted with a red tag
I also added the fact that we display every pools we support even if the status is halted, here is a monkey patched example:

It actually doesn't change anything and will almost never be shown as loan_collateral will mostly be 0, we actually end up with BTC and ETH pool for now but it works!
Pools:
We already handle the status:

BorrowInput: we already handle the slippage Acknowledge warning
RepayInput: Missing the slippage acknowledge warning, I'll add it in the same PR
Do I miss anything regarding heuristics? Is that enough?

Sounds right. It's that tag, e.g., if a lending pool is at capacity it shouldn't show as healthy.
It should say active probably.

We have acknowledgement almost everywhere except in RepayInput
Status are reflecting the real status of Lendings

If someone has a loan to repay or can deposit in the LP at one time because it's a bit emptier, feel free to finish this but it's pretty hard to test on my side for now

potentially closing based on upcoming TC vote


Firefox Browser Prompts for State Changes

Describe the bug in current situation
In the Firefox browser on the Request Details page, when a state change is made to the request, a modal pops up from the browser asking if the user wants to Leave page or Stay on page. Selecting Leave page takes the user back to the Queue page. Selecting Stay on page keeps the user on the Request Details page, or on the Save Changes modal, but only part of the saved changes will be updated.
Link bug to the User Story
This bug relates to User Stories #508  #509, #510 and #511.
This bug is also related to Bug Report #419.
Impact of this bug
Impact is high. Bug occurs across all requests.
Chance of Occurring (high/medium/low/very low)
Does not occur when changing state from Intake in Progress to Open. Occurs when changing all other states from Open onwards, including from Call for Records back to Open.
Pre Conditions: which Env, any pre-requisites or assumptions to execute steps?
Occurs in Test environment
Steps to Reproduce
Steps to reproduce the behavior when choosing to Save Change for state change:

Go to the Request Details page of a request in Call for Records state (or Review, Consult, or Ministry Sign Off)
Click on 'Review' in the state dropdown, then click on Save Change in the modal
See browser popup:
Click 'Stay on page'
See green toast in background indicating change has been saved successfully
See left navigation panel has updated to say 'Review' and colour has changed
Click on state dropdown menu and see dropdown options have NOT been updated

Click on FOI homescreen to return to queue
Click into Request Details page of same request, then click on state dropdown menu and see dropdown options have now been updated

Steps to reproduce the behaviour when choosing to Cancel the state change:

Go to the Request Details page of a request in Call for Records state (or Review, Consult, or Ministry Sign Off)
Click on 'Review' in the state dropdown, then click on Cancel in the modal
See browser popup:
Click 'Stay on page'
See user is returned to 'Changing the state' modal
Click Cancel in the modal, then click Leave page in the browser popup
See user is returned to the request queue

Actual/ observed behaviour/ results
The same behaviour exists when changing other states.
Expected behaviour
A clear and concise description of what you expected to happen. Use the gherking language.
Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

QA completed, bug issue is resolved.


Wizard v2 updates

A draft for updating the Wizard for V2.
Changes are

Removed description under title for create wizard
Changed step titles to match mockup
Fixed registration bug where on create wizard registration step wasn't on by default
Change tar text to update
Added helper text to create wizard and update wizard
Fixed bug for package input search where enter went to next step instead of search

Need review on

updated patternfly from 4.128.2 -> 4.135.0 to include helper text and color class support
on useEffect on package step add event listener for enter bug fix

@boaz0 Need your expert opinion! :smiley:

Codecov Report

Merging #122 (4ec66c3) into master (f0b5c9e) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   27.76%   27.36%   -0.41%
==========================================
  Files          70       70
  Lines        1228     1246      +18
  Branches      321      328       +7
==========================================
  Hits          341      341
- Misses        819      836      +17
- Partials       68       69       +1

Impacted Files
Coverage Δ

src/Routes/ImageManager/CreateImageWizard.js
0.00% <ø> (ø)

src/Routes/ImageManager/steps/imageOutput.js
0.00% <0.00%> (ø)

src/Routes/ImageManagerDetail/constants.js
0.00% <ø> (ø)

src/components/ReviewSection.js
0.00% <ø> (ø)

src/components/form/ImageOutputCheckbox.js
0.00% <0.00%> (ø)

src/components/form/Packages.js
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b5c9e...4ec66c3. Read the comment docs.


[JA] Remove announcement and deprecationwarning shortcodes

Umbrella issue: #21609
Remove the following from /content/ja/_index.html L6-8:
{{< announcement >}}

{{< deprecationwarning >}}

/assign inductor

/kind cleanup

On it!

/closed

/close


External dependencies are configured with invalid paths

After adding an external dependency to WORKSPACE file and hitting the "Sync Project with BUILD Files", the library is detected and visible in Project Settings -> Modules -> Dependencies tab. However, the path to a library JAR file is not correct.
To reproduce:

Add the maven_jar rule to the WORKSPACE file:

maven_jar(
    name = "com_google_guava_guava",
    artifact = "com.google.guava:guava:18.0",
    sha1 = "cce0823396aa693798f8882e64213b1772032b09",
)

Hit Bazel -> Sync -> Sync Project with BUILD Files.
Inspect the project dependencies:

You can also read the IntelliJ XMLs directly:
username@hostname:~/SomeProject$ cat .idea/libraries/guava_18_0_ijar_dc6ac314.xml
<component name="libraryTable">
  <library name="guava-18.0-ijar_dc6ac314">
    <CLASSES>
      <root url="jar:///private/var/tmp/_bazel_username/c0bcf34a998a89d27827c3237447ba16/execroot/WorkspaceName/bazel-out/local-fastbuild/com_google_guava_guava/jar/_ijar/jar/external/com_google_guava_guava/jar/guava-18.0-ijar.jar!/" />
    </CLASSES>
    <JAVADOC />
    <SOURCES />
  </library>
</component>

Inspect the filesystem:

# Go to the local-fastbuild directory.
username@hostname:~$ cd /private/var/tmp/_bazel_username/c0bcf34a998a89d27827c3237447ba16/execroot/WorkspaceName/bazel-out/local-fastbuild/

# Check that the declared library path is incorrect.
username@hostname:local-fastbuild$ stat com_google_guava_guava/jar/_ijar/jar/external/com_google_guava_guava/jar/guava-18.0-ijar.jar
stat: com_google_guava_guava/jar/_ijar/jar/external/com_google_guava_guava/jar/guava-18.0-ijar.jar: stat: No such file or directory

# Check that by adding **genfiles/external** we obtain a correct path.
username@hostname:local-fastbuild$ stat genfiles/external/com_google_guava_guava/jar/_ijar/jar/external/com_google_guava_guava/jar/guava-18.0-ijar.jar
16777221 78950315 -r-xr-xr-x 1 username wheel 0 1621418 "May  3 22:48:39 2017" "May  3 19:43:13 2017" "May  3 19:43:14 2017" "May  3 19:43:13 2017" 4096 3168 0 genfiles/external/com_google_guava_guava/jar/_ijar/jar/external/com_google_guava_guava/jar/guava-18.0-ijar.jar

It looks like adding genfiles/external between local-fastbuild and the dependency name in the library path (in this examplecom_google_guava_guava) would solve the problem. Manually fixing the path works perfectly until the Sync button is pressed again.
I did not check if the problem occurs for external dependencies in other languages.
IDE version: IntelliJ IDEA 2017.1.2, Build #IC-171.4249.39
Plugin version: IntelliJ with Bazel, Version: 2<IP_ADDRESS>

Hi @Eipifi, sorry for the delay in replying.
I haven't been able to reproduce this -- which version of Bazel are you using?

After updating to bazel 0.4.5 the issue is gone. I'm not sure which version I had before updating.


Is it possible to add 1 new mqqt command.

I use multiple touch screens and PCs (multiple rooms) connected via mqqt but if the esp32 radio is already playing I would like to send a command so that all information is sent again just like when the esp is started (Stream name, Track information, Volume , Preset and possibly IP address).
Now it is the case that when the screen is switched on later, only Track information appears and it is actually not my intention to reset the ESP when a new screen is registered.
I have been trying to understand the software for quite some time now, but I cannot find where I can possibly add a new command.
with kind regards
SijDij

Does anyone else know how to add an extra mqtt command for the above problem?

I added the command "mqttrefresh".  This will trigger all MQTT items to refresh.
No time to test it, so please check it out.

It took a while because the USB connector came loose from the ESP32, but it has now been repaired.
I tried "mqttrefresh" and it works exactly as I wanted it to.
Thank you very much.


fix package name missing

Summary by CodeRabbit

Documentation

Updated the reference to DBConfig in the documentation to reflect the latest package changes.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.358%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
716

Relevant Lines:
1079

💛  - Coveralls


Performance test for integrated span collection

In the old repository, we mentioned we needed some work to facilitate integration benchmarking. For example, we need to be able to invoke reporters on-demand, regardless of whether that code lives here or in brave.
While many things need benchmarking, one can reasonably argue that span collection is the more critical. For example, there are far more applications reporting data then end-users of zipkin's UI or api. By benchmarking collection, we can help identify bugs, or limitations that impact zipkin's ability to perform its most basic function: storing spans.
It is important that this benchmark be something that others can run, as often laptops aren't representative. For example, in higher loads, there are likely multiple collector shards, and each may have different timeouts, thread pools, and heap size configuration than defaults.
We could have a test that produces spans against http, kafka or scribe and somehow knows how to analyze stats or otherwise to see how many actually arrived. For example, it could read the collector metrics until all messages are accepted, then look at the traces query until all spans are processed or timeout. On timeout, it could verify in a storage-specific way how many spans landed. This all is needed because storage operations are async.
Using such a tool, admins can sample or throttling writes to meet the performance characteristics of their integrated zipkin system. For example, they can set the collector sample rate accordingly or use something like zipkin-zookeeper to ensure writes don't exceed the capacity of the system.
The minimum scenarios should be tested:
Reusing the same assets we do for benchmarks, vary on span count,  spans/message and messages/second. It is important that these spans have unique timestamps and ids, and that the timestamps vary on days. By using the same assets as our benchmarks, we can more consistently test improvements that may be library-specific.
See #1142 #961 #444

thinking about jbender for this http://blog.paralleluniverse.co/2016/03/30/http-server-benchmark/ https://github.com/pinterest/jbender

Not sure if the view that span collection is the most performance critical still applies. A laggy and slow UI makes users turn away from zipkin and not want to use it ...
The idea was insightful at the time though, observability was novel territory back then. I doubt though that we can easily provide something that will work for all sites. Most low traffic sites won't need this, and the high traffic sites are most likely well enough staffed that they can take care of this themselves. We would just end up in a whole range of support issues we don't want to get involved with.
Closing this one, if you still feel there's merit pursuing this feel free to reopen.

@anuraaga did the bulk of this with testcontainers. I think the general process could be lifted by another into multi-node somehow https://github.com/openzipkin/zipkin/blob/master/benchmarks/src/test/java/zipkin2/server/ServerIntegratedBenchmark.java


Session service bus message handler not getting triggered immediately even though messages are there in service bus.

Query/Question
Session service bus message handler not getting triggered immediately even though messages are there in service bus.
We have a session-based service bus handler with lock time 5min. Sometimes we saw that even though session messages are there in service bus the handler, it is not triggering our handler up to 5min. From application log, we can confirm that we are completing the previous msgs successfully, we should have got the next msg immediately, but we received after 5min. this issue happened sometimes, but not always.
SessionId: ebc08df5-b90c-4b0c-b8da-3f41842d2c98_37ca181b-54ce-4556-829c-3bf9aa63aa44
We saw these pauses of 5 min happening 2 times in 1hr. for example:
Pause 1: 2021-03-29 12:31:39.4845970 to 2021-03-29 12:36:42.5334268
Previous Message Id: 17fbbd0a-fd1f-44b5-a5f2-3058c779c27d completed around 2021-03-29 12:31:39.4845970
Next Message Id: 2aa7a5a5-3b81-45ff-8757-6b8c45ae1d41processing started at 2021-03-29 12:36:42.5334268
Environment:

Name and version of the Library package used: Microsoft.Azure.ServiceBus 5.1.2
Namespaces: oc-test-ocscale2-nam-eus-mbus
Entity name: urassignmentqueue
Code: We can provide you on Teams.

Reproduce steps:
Happened sometimes, not always happened.
Investigation done:
We checked the Etw log and find out below message id.
Previous Message Id: 17fbbd0a-fd1f-44b5-a5f2-3058c779c27d completed around 2021-03-29 12:31:39.4845970
Next Message Id: 2aa7a5a5-3b81-45ff-8757-6b8c45ae1d41 processing started at 2021-03-29 12:36:42.5334268
First message:
We analyzed the Etw log. The first message “17fbbd0a-fd1f-44b5-a5f2-3058c779c27d” been send to queue at 3/29/2021 12:31:39.473050 PM UTC.
It been completed at 3/29/2021 12:31:39.688528 PM UTC. We can see below Etw log contains the session id and sequence number.
Second message:
The second message “2aa7a5a5-3b81-45ff-8757-6b8c45ae1d41” been send to queue at 3/29/2021 12:31:42.497669 PM UTC.
This message been peeked at 3/29/2021 12:36:42.509548 PM UTC. We can see it has same session id with first message. Its sequence number show it is next message of first message in session(264342 - 264343).
This message been completed at 3/29/2021 12:36:50.428807 PM UTC
Frontend Etw:
We can see that the second message been peeked after about 5 minute of enqueue time. The peek request hit the FE.13 instance. Then I checked the FE.13 Etw log. But I didn’t find the log by tracking id
“00cdacc20000024301a6b8276061c9da_G13_B57”. But I see lots of time out on this FE instance.
More Information:
a.	How many sessions we have?
There were messages with only one session (session id - ebc08df5-b90c-4b0c-b8da-3f41842d2c98_37ca181b-54ce-4556-829c-3bf9aa63aa44) in 1 hr interval when this issue occurred ( 2021-03-29T12:01:07.2270000 UTC to 2021-03-29T13:21:53.9730000 UTC)
b.	Have tried to set the MaxConcurrentSessions = 10 x ‘session number’ to see whether it can mitigate the issue.
Max concurrent session is set to 16, which looks good for 1 session. We have 15 nodes hosting this receiver code, so the actual number is 16 * 15.
c.	Additional observation:
We observed these 2 pauses consistently in 1 hour experiments (did 3-4 runs) - 20 messages pumped per min for 60min and received paused 5 min for 2 times during the run. We also found some correlation with this pause time with lock time, as when we did same run with lock time 1 min, there were 6 pauses of 1 min each.
Conclusion:
a.	It is not session order caused issue since the first message and second one’s sequence number are one next the other.
b.	The question is why receiver try to peek the message after 5 minutes.
c.	The message lock is on single message. So it should not be message lock caused issue.
d.	We are thinking whether the issue has relation with session lock. The session lock may be set as same with message lock duration. For some reason, the callback receiver been block and hold the session till lock expire. Since other receiver didn’t get the released session and have to wait for session lock release, it cause the delay.
e.	We tried to upgrade SDK to latest 5.1.2, but issue still occurs.
Ask:
Whether it is session lock competition caused issue? How to fix this issue?

Thank you for your feedback.  Tagging and routing to the team best able to assist.

//fyi:  @JoshLove-msft

Hi @JoshLove-msft , could you please advise? thank you

/cc @axisc

@weilingchang2021 how often do you see this behavior? It's possible that this is caused due to connection disruption or idle timeouts which translates to the additional time needed to reconnect to Service Bus and repoll the message.

@weilingchang2021 following up to check if you have more details on this.

Closing this due to inactivity. Please feel free to open another issue if you still face the problem.
#please-close


Rename config.json.demo to config.demo.json

Rename config.json.demo to config.demo.json for syntax highlighting.

This is reasonable, but you should never be using config.json.demo, and should always rename it to config.json.  This helps avoid accidental commits of your environment information, and is the default config file that gets read.  For these reasons, I want to leave it as is.


As a JavaFX user, I want merge and split functionalities, so that the user can either add or split the pdf

The two tasks (#Issue 29, #Issue 30) under this user story are implemented successfully.
Closing this user story


Add warning when workspace is not open

Need to add a warning when a workspace is not opened and VS Code is opened in “file-only” mode. Addons cannot be enabled in “file-only” mode, and it can lead to confusion.
Can use the workspaceOpen property.

Fixed by https://github.com/LuaLS/vscode-lua-webvue/commit/65e5f9055f2f69fd87194febad2752ad85ad2980


ui: polishing and minor enhancements

Most of changes were done based on wireframes:

General

Added missing Roboto Medium (used on panel titles for example)
Slightly larger line-height on .panel-heading to fit .btn-sm
Buttons on .panel-heading moved from .btn-xs to .btn-sm

Configuration

Added missing .panel-title (except for proxy settings to avoid conflict)

Overview page

Centered status icon to column name
Status text in the same column as icon
Aligned table data text in the middle
Wrong use of th instead of td on nodes table
Master checkbox aligned before role text
Changed update all nodes from button to link

Overview and Discovery

Added text when Pending Nodes panel is empty

Overview (before)

Overview (after)

Discovery page (before)

Discovery page (after)

if the differences are really visible, could you add some screenshots once you're done with the coding?

if the differences are really visible, could you add some screenshots once you're done with the coding?

Sure. Didn't do yet because there still one change left. Will do as soon as I'm done with it. Don't worry!

i think the current attached screenshot is pretty wicked tho. good job.

i think the current attached screenshot is pretty wicked tho. good job.

The wireframes are from Cierra not from myself. Hehe.

Good to be reviewed!

I fixed the conflicts against master using the web UI. If everything passes I would merge the code

I merged it manually into master.


React-with-Redux project template with ASP.NET Core fails to launch after publish

After setting up a new React-with-Redux template, I can successfully run the application in debug mode, but running the application after publishing fails:
Steps to reproduce:

dotnet new reactredux
dotnet publish -c Release -r win10-x64
Navigate to destination folder ([appDirectory]\bin\Release\netcoreapp2.1\win10-x64\publish\)
dotnet [appName].dll

Result:
      User profile is available. Using 'C:\Users\[snip]\AppData\Local\ASP.NET\DataProtection-Keys' as key repository and Windows DPAPI to encrypt keys at rest.
info: Microsoft.AspNetCore.SpaServices[0]
      Starting create-react-app server on port 50445...
Hosting environment: Development
Content root path: [appDirectory]\bin\Release\netcoreapp2.1\win10-x64\publish
Now listening on: http://localhost:5000
Now listening on: https://localhost:5001
Application started. Press Ctrl+C to shut down.
npmfail: Microsoft.AspNetCore.SpaServices[0]
      npm ERR! path [appDirectory]\bin\Release\netcoreapp2.1\win10-x64\publish\ClientApp\package.json

fail: Microsoft.AspNetCore.SpaServices[0]
      npm ERR! code ENOENT
npm ERR! errno -4058
npm ERR! syscall open
npm ERR! enoent ENOENT: no such file or directory, open '[appDirectory]\bin\Release\netcoreapp2.1\win10-x64\publish\ClientApp\package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

---
#### Document Details

⚠ *Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.*

* ID: 7264db1b-55ec-e419-d2c4-bd4fe64922a2
* Version Independent ID: 720995d2-006a-3573-4868-d253c8a2acc7
* Content: [Use the React-with-Redux project template with ASP.NET Core](https://docs.microsoft.com/en-us/aspnet/core/client-side/spa/react-with-redux?view=aspnetcore-2.1)
* Content Source: [aspnetcore/client-side/spa/react-with-redux.md](https://github.com/aspnet/Docs/blob/master/aspnetcore/client-side/spa/react-with-redux.md)
* Product: **aspnet-core**
* GitHub Login: @SteveSandersonMS
* Microsoft Alias: **scaddie**

This seems to be an issue with my system as my colleague was not able to reproduce the issue.


primitives: add missing cargo metadata to sp-arithmetic-fuzzer

After #5401 I noticed that CI failed on master (https://gitlab.parity.io/parity/substrate/-/jobs/432668), this PR adds the missing metadata.
Also, do we really want to get this particular crate published on crates.io?

Also, do we really want to get this particular crate published on crates.io?

well, an alternative is to put into the --skip-list for cargo-unleash.

I am not familiar with this crate so I am not totally sure if it makes sense to publish the fuzzer or not, seems like it is just part of the testing infrastructure of sp-arithmetic. @expenses @kianenigma WDYT?

No, it doesn't make sense because they're just binaries to be run. Nobody other than us has a real reason to run them.

Added sp-arithmetic-fuzzer to cargo unleash skip list.


Possible major privacy issue with static device MAC addresses

What is missing
I'd like to see documentation for the low-level BLE frame contents, i.e. what exactly is sent over the air, including any packet headers. In particular, I'd like to know what device address is transmitted.
Best information I could find on this topic:

https://microchipdeveloper.com/wireless:ble-link-layer-packet-types
https://microchipdeveloper.com/wireless:ble-link-layer-address

Why should it be included
Quote from above link:

Since all BLE packets include a Device Address, it's possible to track the BLE device as it's moving and communicating, unless it changes its address periodically. BLE adds the ability to periodically change the address.

So I'm wondering if the address is periodically changed. If it is, please document it.
If it's not, there's a major privacy issue:
The scenario I'm thinking about are players who have the means to deploy lots of cheap bluetooth sniffer devices at public locations where many people pass by. It would be trivial to collect device addresses together with a timestamp and location of the sniffer and correleate those on a central server to generate movement profiles for each smartphone (and their owners) that got the app installed.
Examples for those players could be owners of franchises (e.g. station kiosks) or operators of public transport or anyone else willing to spend a few thousand € on this.

Dear @joernheissler , this functionality of the app is handled through the Google/Apple Exposure Notification Framework. Google and Apple respectively published their Bluetooth specification and one design goal is that "The advertiser address type shall be Random Non-resolvable.".
Best regards,
TK
Corona-Warn-App Open Source Team


Convert to Torchscript

How can I convert the saved models into torchscript so that I can make them compatible with C++ version.

Sorry, I have not worked with Torchscript before.

Can you suggest some other way to use the model in C++?

I'm not familiar with any way. Did you try that?

Yes, I did try that. But it the complete conversion including Post Processing in C++ is still in progress. I'll update here if I get things running.

Hi @dkhanna511,
Have you done converting LaneATT to TorchScript?!

Hi @hthoai, I exported the model in Torchscript format. I loaded it in c++ and tried to run the forward function by passing an image from CULane dataset. Firstly, I'm just saving reg_proposals to the model and not the proposals_list as returned by nms function in laneatt.py.
Therefore, the output that I'm returning is of the shape [1000, 77]. In that, I'm getting some values for column 3 and 4, and all the other columns are coming out be "nan".

Hi @dkhanna511,
Thanks for your response. Did you have any trouble when exporting the model in TorchScript format?! I got some errors when scripting the model. Could I ask you some questions about the process?!

Hi, I exported the model using tracing and didn't get any error there. But it turns out that the exported model might be wrong, because of the "nan" problem I mentioned earlier.
I'm also trying to export the model using torch.jit.script so that I can have the complete control flow defined in the model but for that, I'm facing multiple errors.
Please, let me know if you find something useful and are able to export the model correctly.


[JobRouter] Regenerate from specs

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Communication.JobRouter


Fix climbing and bonking simultaneously

About the PR

Due to an oversight, it was possible for clumsy characters to trigger the doAfters for both successfully climbing and bonking at the same time. This made it easy to pass through windoors on tables. This fixes that.
Why / Balance

Bug fix.
Fixes #27245.
Technical details

Modified the DoAfterArgs for climbing and bonking so they now consider any DoAfter with the same user, "tool" (dragged person), and target to be a duplicate DoAfter, even if the DoAfterEvent is a different type. This prevents them running simultaneously.
Also fixed BonkSystem's subscription to AttemptClimbEvent to be by-ref, so cancellation actually works. Previously this was causing the climb DoAfter to always start, when when a bonk happened.
As a bonus, ClumsyComponent is now networked, so adding it via VV on the server duplicates it on the client for proper prediction (which was annoying while I was testing this fix). I also went ahead and cleaned up the rest of ClumsyComponent to use modern standards.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

gah, my clown magic tricks patched!


Addition: Candy Bar of Doom

https://blog.adafruit.com/2022/10/21/parents-please-carefully-inspect-your-kids-halloween-candy/
https://youtu.be/6V_ofcX9cic
great site!

Haha!
Thanks for reporting this one! I'll add it to the db as soon as I'll have a moment.
Cheers!

Added Candy Bar of Doom to the database (along with a few other cool items):
https://github.com/zvolchak/can-it-run-doom/pull/39