fix(ASSETS-6851): Project Wide - The selected state of the reorder button does not have a sufficient contrast ratio

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.

Hi @TudorSMR ,
Please change the title based on coral commit convention for automatic release process to trigger.
Thank you

@Pareesh Done.
Thanks!

Hi @TudorSMR ,
This rgb(158, 158, 158) seems to be quite a used value, Please create a var in var.css and then use it. Also change this https://github.com/adobe/coral-spectrum/commit/093fb74d5c9354c6ca72afcea6e0adc0705a97e8 to var.
Create two different variable name fro border and background color.
Thank you

Hi @TudorSMR ,
For css changes, try to attach a screenshot of before and after, it would be easier to review.
Thank you

Hi @Pareesh ,
I've updated the css to use vars. Here are the before and after screenshots.
Before:

After:


[FEATURES] support create AlluxioRuntime in namespace with quota

support create AlluxioRuntime in namespace with quota
Our project must have create a namespace with quota, but  when i create alluxioRuntime ,it says 'is forbidden: failed quota: init: must specify limits.cpu,limits.memory' when statefulset create pod

I think it's ok to use the similar logic on resource to handle worker and master.


Basic theory discussion

The difference in angle  BETA  between the two rays and the distance difference DELTA Depth  are actually the same thing. So what is the difference between the two? In addition, calculating the angle difference is actually more complicated than calculating the distance difference. Why choose a more complicated way?
And why is your calculation method faster? Because the horizontal resolution is compressed to 870?

Answered in #44


Cleanup settings

The default fdCacheDuration for warp is 0 as of 3.0.0: https://hackage.haskell.org/package/warp-3.2.12/docs/src/Network-Wai-Handler-Warp.html#setFdCacheDuration
No reason to re-set it; just noticed the redundancy.

Coverage remained the same at 57.273% when pulling ac716b853c0b67b4dec8ce3285601bcbba0847f0 on 5outh:feature/5outh/clean-settings into ad88120e9772a65cfbcd0feba135a504244d58ad on scotty-web:master.

Coverage remained the same at 57.273% when pulling ac716b853c0b67b4dec8ce3285601bcbba0847f0 on 5outh:feature/5outh/clean-settings into ad88120e9772a65cfbcd0feba135a504244d58ad on scotty-web:master.

@potomak Oh shoot, good call. I'll close it!

Eh, 3.0.13 was a long time ago... I'd accept this patch if you bumped the bound to that.

Coverage remained the same at 57.273% when pulling ac716b853c0b67b4dec8ce3285601bcbba0847f0 on 5outh:feature/5outh/clean-settings into ad88120e9772a65cfbcd0feba135a504244d58ad on scotty-web:master.

Coverage remained the same at 57.273% when pulling ac716b853c0b67b4dec8ce3285601bcbba0847f0 on 5outh:feature/5outh/clean-settings into ad88120e9772a65cfbcd0feba135a504244d58ad on scotty-web:master.

Coverage remained the same at 57.273% when pulling ac716b853c0b67b4dec8ce3285601bcbba0847f0 on 5outh:feature/5outh/clean-settings into ad88120e9772a65cfbcd0feba135a504244d58ad on scotty-web:master.

@xich Done!

Coverage remained the same at 57.273% when pulling a36171fb7dd126d6581567cc32a931e2d71d59fb on 5outh:feature/5outh/clean-settings into ad88120e9772a65cfbcd0feba135a504244d58ad on scotty-web:master.

Coverage remained the same at 57.273% when pulling a36171fb7dd126d6581567cc32a931e2d71d59fb on 5outh:feature/5outh/clean-settings into ad88120e9772a65cfbcd0feba135a504244d58ad on scotty-web:master.


Support for existsBy projection

Fixes #93

Codecov Report

Merging #94 into master will decrease coverage by 0.02%.
The diff coverage is 44.44%.

@@             Coverage Diff              @@
##             master      #94      +/-   ##
============================================
- Coverage     40.58%   40.55%   -0.03%
- Complexity      336      337       +1
============================================
  Files            64       64
  Lines          1752     1758       +6
  Branches        341      345       +4
============================================
+ Hits            711      713       +2
- Misses          936      939       +3
- Partials        105      106       +1

Impacted Files
Coverage Δ
Complexity Δ

...namodb/repository/query/PartTreeDynamoDBQuery.java
80.95% <100%> (+0.95%)
9 <2> (+1)
:arrow_up:

...namodb/repository/query/AbstractDynamoDBQuery.java
20% <28.57%> (ø)
7 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deef49a...a6cec8d. Read the comment docs.

Thank you - especially the addition of the unit tests!


Possible enhancements to MCMC.

Some possible enhancements/improvements, in no particular order and of varying scope:
-Change SliceSampler to be able to handle multimodal univariate distributions. Should just be a matter of implementing the pseudocode in Neal 2003 http://projecteuclid.org/download/pdf_1/euclid.aos/1056562461
-Add Metropolis-Hastings univariate sampler as alternative to SliceSampler.
-Add Metropolis-Hastings/nested/etc. multivariate samplers as alternatives to GibbsSampler.  This should only be tackled if a model/dataset necessitates it.
-Implement hierarchical/multilevel models in an OOP way.  Currently, the samplers operate on lists of global parameters and lists of lists of "local" parameters (i.e., segment-level or site-level parameters), which is a bit clunky.
-Add convergence diagnostics (e.g., autocorrelation time).
-Add ability to make trace plots and corner plots.
-Implement more flexible discarding of burn-in.  Currently, samples from all iterations are aggregated in memory.  Depending on the maximum number of iterations we want to allow, it might be better to write samples to disk, only store samples in memory after burn-in, etc. so we don't run into memory issues.
-Parallelization (again, only if a model/dataset necessitates it).

@samuelklee Do we need this for the beta release?

I'd say no to pretty much all of the points, except for whatever @davidbenjamin ends up needing to implement for the allele-fraction model (David, last time I looked at your branch there was some MH sampling going on?).  Some of them will probably be relatively easy to address before beta (e.g., the first point about fixing up the SliceSampler), but I think they are low priority.
The only thing that we'll definitely have to decide on for beta release is how to store/plot the MCMC chains (i.e., the posterior samples).  If all people want to see is posterior point estimates + credible intervals, we can just discard the chains, but this seems somewhat wasteful to me.

Issue moved to broadinstitute/gatk #2824 via ZenHub


NIFI-5973 Adds ShellUserGroupProvider.

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Supersedes #3495.
The code in this change-set provides the functionality discussed in NIFI-5973, specifically:

adds a new UserGroupProvider implementation called ShellUserGroupProvider
shell users + groups support on OSX, Alpine Linux, CentOS, Debian, and Ubuntu
adds remote shell support (via ssh) for testing the above
adds test for all the above, some via Testcontainers

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Reviewing...

Hi Troy. Reviewing this leads me to the same scenario I encountered on PR #3495 -- the authentication with LDAP works successfully, but the user with identity alopresto doesn't have any groups populated and despite being set as the Initial Admin Identity, it does not have the expected (or any) permissions. There are permissions defined in authorizations.xml but for a user with ID 502, and I don't see them being correctly associated.
2019-06-18 19:06:21,025 INFO [main] org.eclipse.jetty.server.Server Started @28024ms
2019-06-18 19:06:21,043 INFO [main] org.apache.nifi.nar.NarAutoLoader Starting NAR Auto-Loader for directory ./extensions ...
2019-06-18 19:06:21,044 INFO [main] org.apache.nifi.nar.NarAutoLoader NAR Auto-Loader started
2019-06-18 19:06:21,044 INFO [main] org.apache.nifi.web.server.JettyServer NiFi has started. The UI is available at the following URLs:
2019-06-18 19:06:21,044 INFO [main] org.apache.nifi.web.server.JettyServer https://andy.nifi:9443/nifi
2019-06-18 19:06:21,045 INFO [main] org.apache.nifi.BootstrapListener Successfully initiated communication with Bootstrap
2019-06-18 19:06:21,045 INFO [main] org.apache.nifi.NiFi Controller initialization took<PHONE_NUMBER>7 nanoseconds (19 seconds).
^C...1.10.0-SNAPSHOT-bin/nifi-1.10.0-SNAPSHOT (pr3537) 😉
🔓 0s @ 19:07:09 $ bca
───────┬───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: conf/authorizations.xml
───────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
   2   │ <authorizations>
   3   │     <policies>
   4   │         <policy identifier="f99bccd1-a30e-3e4a-98a2-dbc708edc67f" resource="/flow" action="R">
   5   │             <user identifier="502"/>
   6   │         </policy>
   7   │         <policy identifier="b8775bd4-704a-34c6-987b-84f2daf7a515" resource="/restricted-components" action="W">
   8   │             <user identifier="502"/>
   9   │         </policy>
  10   │         <policy identifier="627410be-1717-35b4-a06f-e9362b89e0b7" resource="/tenants" action="R">
  11   │             <user identifier="502"/>
  12   │         </policy>
  13   │         <policy identifier="15e4e0bd-cb28-34fd-8587-f8d15162cba5" resource="/tenants" action="W">
  14   │             <user identifier="502"/>
  15   │         </policy>
  16   │         <policy identifier="ff96062a-fa99-36dc-9942-0f6442ae7212" resource="/policies" action="R">
  17   │             <user identifier="502"/>
  18   │         </policy>
  19   │         <policy identifier="ad99ea98-3af6-3561-ae27-5bf09e1d969d" resource="/policies" action="W">
  20   │             <user identifier="502"/>
  21   │         </policy>
  22   │         <policy identifier="2e1015cb-0fed-3005-8e0d-722311f21a03" resource="/controller" action="R">
  23   │             <user identifier="502"/>
  24   │         </policy>
  25   │         <policy identifier="c6322e6c-4cc1-3bcc-91b3-2ed2111674cf" resource="/controller" action="W">
  26   │             <user identifier="502"/>
  27   │         </policy>
  28   │     </policies>
  29   │ </authorizations>
───────┴───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
...1.10.0-SNAPSHOT-bin/nifi-1.10.0-SNAPSHOT (pr3537) 😉
🔓 4s @ 19:07:39 $ grc tail -f logs/nifi-user.log
2019-06-18 19:06:16,744 DEBUG [main] o.a.n.a.util.IdentityMappingUtil Identity Mapping property nifi.security.identity.mapping.pattern.dn was found, but no transform was present. Using NONE.
2019-06-18 19:06:16,744 DEBUG [main] o.a.n.a.util.IdentityMappingUtil Found Identity Mapping with key = dn, pattern = (?i)^CN=([^,]*),.*$, value = $1, transform = NONE
2019-06-18 19:06:16,790 DEBUG [main] o.a.n.a.util.IdentityMappingUtil Identity Mapping property nifi.security.identity.mapping.pattern.dn was found, but no transform was present. Using NONE.
2019-06-18 19:06:16,790 DEBUG [main] o.a.n.a.util.IdentityMappingUtil Found Identity Mapping with key = dn, pattern = (?i)^CN=([^,]*),.*$, value = $1, transform = NONE
2019-06-18 19:06:58,710 DEBUG [NiFi Web Server-32] o.a.nifi.authorization.util.ShellRunner Run Command 'Get Single User by Id': [sh, -c, id -P alopresto | cut -f 1,3,4 -d ':']
2019-06-18 19:06:59,353 INFO [NiFi Web Server-27] o.a.n.w.s.NiFiAuthenticationFilter Attempting request for (<JWT token>) GET https://andy.nifi:9443/nifi-api/flow/current-user (source ip: <IP_ADDRESS>)
2019-06-18 19:06:59,354 DEBUG [NiFi Web Server-27] o.a.nifi.authorization.util.ShellRunner Run Command 'Get Single User by Id': [sh, -c, id -P alopresto | cut -f 1,3,4 -d ':']
2019-06-18 19:06:59,376 INFO [NiFi Web Server-27] o.a.n.w.s.NiFiAuthenticationFilter Authentication success for alopresto
2019-06-18 19:06:59,450 DEBUG [NiFi Web Server-27] o.a.nifi.authorization.util.ShellRunner Run Command 'Get Single User by Id': [sh, -c, id -P alopresto | cut -f 1,3,4 -d ':']
2019-06-18 19:06:59,477 INFO [NiFi Web Server-27] o.a.n.w.a.c.AccessDeniedExceptionMapper identity[alopresto], groups[] does not have permission to access the requested resource. Unknown user with identity 'alopresto'. Returning Forbidden response.

@alopresto
Thanks again for testing again.
Can you review/post you ldap mapping, e.g., nifi.security.identity.mapping. and friends?  I've been testing with the defaults on Mac and Linux both.

I'm hoping I just missed a configuration value (either failed to populate or copied a stale value from an old config).

authorizers.xml
login-identity-providers.xml
nifi.properties
authorizations.xml

Prerequisites:

LDAP server at specified host with alopresto and tmelhase users.
valid keystore and truststore with specified passwords

Generic comment before I forget, I think there are more locations in the code when the shell runner runs a command without a description of what's happening and we can clean that up. Grep the DEBUG nifi-user.log for <unknown>.

Was able to fix a bug where the user and groups object query was expecting the identifier (i.e. "502"), but was being provided the identity (i.e. "alopresto"). Everything now works as expected.
When using LDAP authentication and Shell UGP, if NiFi is started without an existing flow.xml.gz, the initial admin identity permissions do not include read/write for the root process group, but I verified this behavior is the same using LDAP UGP.
Ran contrib-check and all tests pass. +1, merging.


BUG: Internal and external indices on axis 1 do not match.

Modin version checks

[X] I have checked that this issue has not already been reported.

[X] I have confirmed this bug exists on the latest released version of Modin.

[ ] I have confirmed this bug exists on the main branch of Modin. (In order to do this you can follow this guide.)

Reproducible Example
import modin.pandas as mpd
import numpy as np

import string

# Function to generate a random string of given length
def generate_random_string(length):
    return ''.join(np.random.choice(list(string.ascii_letters)) for _ in range(length))

# Generate a list of 1500 strings
list_of_strings = []
for _ in range(1500):
    string_length = np.random.randint(5, 63)
    random_string = generate_random_string(string_length)
    list_of_strings.append(random_string)

# Generate a small amount of data to be queried
for _ in range(5):
    string_length = np.random.randint(64, 100)
    random_string = generate_random_string(string_length)
    list_of_strings.append(random_string)

def split(df, split_size):
    df_ = mpd.DataFrame(columns=['uid', 'seq', 'len'])
    df_['seq'] = [
        df['seq'][x:x+split_size]
        for x in range(0, df['len'], split_size)]
    df_['uid'] = df['uid']
    df_['len'] = df_['seq'].apply(len)
    return df_

df = mpd.DataFrame(columns=['uid', 'seq', 'len'])
df['seq'] = list_of_strings
df['uid'] = 'test'
df['len'] = df['seq'].apply(len)

print(df)

splitted_df = df[df['len'] > 64].apply(split, axis=1, split_size=64).reset_index(drop=True)

print(splitted_df)

Issue Description
when doing apply() on a queried dataframe, there's a chance to get internal error when queired dataframe is small. It does sometimes work when queries dataframe have many rows.
Expected Behavior
get the expected result without any error.
Error Logs

Replace this line with the error backtrace (if applicable).

 I would like to clarify whether the resultant series (splitted_df) containing multiple DataFrames is the expected result to you? I see the following output with pandas.
print(splitted_df)
[1505 rows x 3 columns]
0        uid                                       ...
1        uid                                       ...
2        uid                                       ...
3        uid                                       ...
4        uid                                       ...
dtype: object

print(splitted_df[0])
    uid                                                seq  len
0  test  fuMmtQebxFZBfeCANHayKnbKmkNeKdEjczKsLyQrfSsuaR...   64
1  test                                            QYCMNtm    7

@YarShev Yes it is expected. My goal is to split each row into multiple rows with smaller data, currently I have an apply() and then followed with something like pd.concat(splitted_df.tolist(), ignore_index=True), perhaps there's a better way to code it?

There might be other way to do what you want to achieve but I am afraid of we will get into a similar issue with indices mismatch. We will take a look at this issue.

@YarShev What I have done to workaround this issue is to not query the dataframe. Instead, I apply the function on every row, check for the length, if is not greater than the size, return np.nan, then I will have to do a dropna() before the concat.

Good to hear that you have been able to workaround the issue. But we should definitely figure out the root cause of the issue. Hope to schedule this task on a future release.

The issue kind of relates to empty partitions that are left after df[df['len'] > 64]. After doing apply we have partitions (empty and non-empty) that have different columns (correct columns are in non-empty partitions, outdated/wrong columns are in empty partitions). Then, when we compute columns at the end of apply for a Modin DataFrame, we retrieve them from empty partitions, which is wrong. This is a known issue for us and we already planned to properly handle this case but not in the upcoming months, unfortunately. I hope, the workaround you have done is sufficient to you for now.

yes, I can live with it for now.


Signal the start of a YAML document

I added two common best practices for YAML files:

Document separator --- to signal the start of the document
A new line add the end of the document

Thanks!


🚨(frontend) enable rule to sort imports

Purpose
In order to improve code structure we would like to sort imports as follows "builtin", "external", "internal", "parent", "sibling", "index". The eslint import plugin allow to do that. We also have to install a plugin to resolve webpack alias as internal imports.
Proposal

[x] Enable eslint import/order rule

So far so good 😊
NB: The lint-front job seems to fail 😕

Yup, there was something to reformat within .eslintrc.json.


bump ember-auto-import to 1.5.3 and babel to 7.0.0

I'm running into build errors on another project that pulls in an addon which uses ember-burger-menu, and @babel/core is blaming different versions of ember-auto-import. Also bumped ember-cli-babel to 7.0.0 while I was in there, and tests pass.

This is now completed.


Add Template workflows for X-Wing

To add GitHub Actions workflows to your repository:

create this issue
add a new comment with the content below
replace [repo name] with your repository name in the format owner/repo, e.g. BSData/test.

/template-workflows-pr [repo name]

/template-workflows-pr BSData\swxwing

/template-workflows-pr BSData/swxwing


[ITensors] test sample MPO

Description
Added a missing test for sample-ing an MPO, which wasn't covered.
How Has This Been Tested?
Tests passed locally
Checklist:

[x] My code follows the style guidelines of this project. Please run using JuliaFormatter; format(".") in the base directory of the repository (~/.julia/dev/ITensors) to format your code according to our style guidelines.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have added tests that verify the behavior of the changes I made.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] Any dependent changes have been merged and published in downstream modules.

Thanks!

Codecov Report

Merging #1093 (ad06c16) into main (aab9933) will decrease coverage by 31.08%.
The diff coverage is n/a.

:exclamation: Current head ad06c16 differs from pull request most recent head e614ea6. Consider uploading reports for the commit e614ea6 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #1093       +/-   ##
===========================================
- Coverage   84.51%   53.43%   -31.08%
===========================================
  Files          86       85        -1
  Lines        8277     7740      -537
===========================================
- Hits         6995     4136     -2859
- Misses       1282     3604     +2322

see 66 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[mps]

It's running here: https://github.com/ITensor/ITensors.jl/actions/runs/4388790545

MPS tests passed 😎

Thanks! Also glad to see the comment triggered testing put to good use and working (though I need to figure out how to get it to report the results in a comment to the PR, maybe with an ITensorBot...).


CASSANDRA-18232: CEP-26 Rewrite compaction information, updating LCS, STSC, TWCS, and adding …

Resubmitting

Committed as https://github.com/apache/cassandra/commit/93a4fcd32c2b58a116498ac9eb31752bf07bae71


Microsoft.TypeScript.MSBuild doesn't output compilation errors in VSTS XAML build log

TypeScript Version:  2.6.2
Visual Studio Version: Enterprise 14.0.25431.01 (2015 Update 3)
Visual Studio Team Foundation Server Version: 14.102.25423.0 (2015 Update 3)
VSTS Team Project Process Template: Agile
VSTS Team Project Version Control: Team Foundation Version Control
XAML Build process template: Default Template (TfvcTemplate.12.xaml)
Code

Create a new Visual Studio solution with two projects:
a. ASP.NET Web Application
b. Unit Test Project

In the Web Application:
a. Install-Package Microsoft.TypeScript.MSBuild -Version 2.6.2
b. npm install<EMAIL_ADDRESS>c. Add TypeScript JSON configuration file
d. Add TypeScript file

/// <reference types="jsnlog" />

import "jsnlog"
declare var JL;

JL().debug("WebApplication1");

In the Unit Test Project:
a. Install-Package Microsoft.TypeScript.MSBuild -Version 2.6.2
b. npm install<EMAIL_ADDRESS>c. Add TypeScript JSON configuration file
d. Add TypeScript file

/// <reference types="jsnlog" />

import "jsnlog"
declare var JL;

JL().debug("UnitTestProject1");

Build the solution in Visual Studio and verify it succeeds.

Check-in code (including package-lock.json files and node_modules directories)

Create a new XAML build definition that builds the sln file and verify the XAML build succeeds.

Add the following lines to the TypeScript file in the Unit Test project:

import "../WebApplication1/file1";

JL().debug("imported");

Build the solution in Visual Studio and verify that the build fails as expected with the error message:
MSB6006: "tsc.exe" exited with code 1.

If "Visual Studio > Tools > Options... > Projects and Solutions > Build and Run > MSBuild project build output verbosity" is set to Detailed then you will also see the following error message as expected:
message TS4090:Build:Conflicting definitions for 'jsnlog' found at './WebApplication1/node_modules/jsnlog/Definitions/jl.d.ts' and './UnitTestProject1/node_modules/jsnlog/Definitions/jl.d.ts'. Consider installing a specific version of this library to resolve the conflict.

Check in code and verify the XAML build fails as expected with the error message:
MSB6006: "tsc.exe" exited with code 1.

However, even when adding /p:verbosity=diagnostic to the XAML build's "MSBuild arguments" field, the error message TS4090 is never displayed in the detailed build log.
I also tried launching Visual Studio on the build agent and setting "Visual Studio > Tools > Options... > Projects and Solutions > Build and Run > MSBuild project build output verbosity" and "MSBuild project build log file verbosity" to Diagnostic using the same account as the "Visual Studio Team Foundation Build Service Host 2015" Windows service.
Expected behavior:
I expected error message TS4090 to at least be displayed in the build log file.
Actual behavior:
The error message TS4090 is never displayed in the build log file and so there's no indication as to the underlying issue as to why the TypeScript compilation failed.
A work-around to find out what the actual TypeScript compilation error was is to manually run the tsc.exe command line as indicated in the build log file on the build agent; the errors will be displayed on the console.
I've attached the sample Visual Studio solution here.
Additional Note:
If the NuGet package "Microsoft.TypeScript.Compiler" v2.6.2 is installed on both projects, then a build in Visual Studio succeeds which is interesting.
However, even if checked in, the XAML build still fails with the same behavior.
Thank you!

Sorry, please try with this version; I've included the contents of the node_modules folder:
TypeScriptBug.zip
Thank you.

@uniqueiniquity u know more about the targets than i do, can you take a look.

@icnocop, sorry for the delay on this.
Seems like we are mislabeling this failure as a "message", not an "error".
This is causing it to be reported by VS incorrectly (well, correctly with regards to our mislabeling).
I will have a fix for this soon.


How can I generate key pair using this?

I'm trying to find documentation to create key pair, but there's no information regarding that.
I would like to generate key pair and store that in some database and use them later to encrypt, decrypt files.
Please guide me.

Looking at the lib/gpg.js source there are no methods currently dedicated to generating new key pairs, however, the Usage portion of the ReadMe.md file states that the call method may be used for calling the command line utility that this project wraps...
  // ... Other stuff

  /**
   * Raw call to gpg.
   *
   * @param  {String}   stdin  String to send to stdin.
   * @param  {Array}    [args] Array of arguments.
   * @param  {Function} [fn]   Callback.
   * @api public
   */
  call: function(stdin, args, fn) {
    spawnGPG(stdin, args, fn);
  },

... checking with GitHub's GPG docs states that either --full-generate-key or --default-new-key-algo rsa4096 --gen-key, however, this would be ill-advised if you're after non-interactive key pair generation, which if that's your aim then glancing at one of my older projects source files (S0AndS0/Perinoid_Pipes - Script_Helpers/GnuPG_Gen_Key.sh), shows that the following command line options may be of use...
#!/usr/bin/env bash

## ... other stuff

Func_gen_gnupg_keys(){
	_pass_phrase=( "$@" )
	if [ "${#Var_gnupg_comment}" != "0" ]; then
		gpg --batch --gen-key <<EOF
Key-Type: ${Var_gnupg_key_type}
Key-Length: ${Var_gnupg_key_length}
Subkey-Type: ${Var_gnupg_sub_key_type}
Subkey-Length: ${Var_gnupg_sub_key_length}
Name-Real: ${Var_gnupg_name}
Name-Comment: ${Var_gnupg_comment}
name-Email: ${Var_gnupg_email}
Expire-Date: ${Var_gnupg_expire_date}
Passphrase: ${_pass_phrase[*]}
## Uncomment the next line to not generate keys
#%dry-run
%commit
%echo finished
EOF
	else
		gpg --batch --gen-key <<EOF
Key-Type: ${Var_gnupg_key_type}
Key-Length: ${Var_gnupg_key_length}
Subkey-Type: ${Var_gnupg_sub_key_type}
Subkey-Length: ${Var_gnupg_sub_key_length}
Name-Real: ${Var_gnupg_name}
name-Email: ${Var_gnupg_email}
Expire-Date: ${Var_gnupg_expire_date}
Passphrase: ${_pass_phrase[*]}
%commit
%echo finished
EOF
	fi

	unset _pass_phrase
}

## ... more _pruning_ of non-essential code for this answer

Note, I do not know if this project can handle EOF (End Of File) redirection of arguments and it's likely not to work so well on non-Unix inspired OSs, but if memory serves from the last time I did a info --node='Unattended Usage of GPG' gpg, some of the above where required at the time.

Doing a search for call( within this project shows test/index.js demonstrates the use of the call method...
// ... Other tests trimmed

    it('should decrypt files', function(done){
      gpg.call('', [ '--skip-verify', '--passphrase-fd', '0', '--decrypt', './test/hello.gpg' ], function(err, decrypted){
        assert.ifError(err);
        assert.ok(decrypted.length);
        assert.equal(decrypted.toString('utf8'), 'Hello World\n');
        done();
      });
    });

// ... and a bit more pruning to keep things relatively concise

Putting some of this together one might be able to...
function keyGen({key_type, length, sub_type, name, email, pass, expires}) {
  let gpg_configs = '--batch --gen-key';
  // ... Do stuff that checks and defaults things like `type`
  // if (key_type) {
  //   gpg_configs += `\nKey-Type: ${key_type}`
  // } else {
  //   gpg_configs += `\nKey-Type: DSA`
  // }
  // ... Then _feed_ the `call` method
  GPG.call(gpg_configs, [], (err, results) => {
    if (err) throw err;
    // ... do stuff with results?
    console.log(results);
  });
}

... though this last bit is untested an incomplete, hopefully as a whole this has prepared ya to code something better.


Adding refresh limit capability.

Setting a refreshLimit will cause refresh to stop after x refreshes.
  // The following ad will refresh 10 times every 30 seconds, and then stop.
  {{google-publisher-tag
    tracing=1
    adId="/6355419/Travel/Europe/France/Paris"
    width=300
    height=250
    refresh=30
    refreshLimit=10
  }}

also this project has some transient Travis CI issues, so don't worry if not all builds succeed.

Close enough, going to merge and then do a few cleanup tasks, and then tag and release.


Proper scales

Currently, the scales that are present are just holders for settings passed onto the ggplot object at __radd__ time. The scales need to be more complete with knowledge of the data domain and the functions to map the domain onto the aesthetic range, i.e. the current assign_* functions need to be refactored into the scales.
The scales should be added to the ggplot object and should remain separate objects until plot time e.g under ggplot.scales. Also, only the ggplot scales should know about the transformations, the matplotlib scales available through ax should know nothing.
All this is key for among other things, a straight forward facetting implementation and statistic computations. Scale trainning will also be easy this way, since it needs to be done to avoid a bunch of edge cases. e.g. geom_text and geom_bar

Possibly #248

I think the problem(s) may be coming from more than one source. In the plot building pipeline there isn't a clear distinction of what should be handled by ggplot and what is handled by matplotlib. The best solution is to fix the underlying architecture to adhere to the same process as ggplot2. This is what I am trying to do in #360, it is big (almost a complete rewrite) and I haven't made any commits lately.

@has2k1 no worries, not trying to pressure you, just trying to tie bugs together and investigate further so if/when you tackle this you'll have less hunting to do.
One thing I'd appreciate is where I'd start looking if I wanted to fix the outputs manually - like, after the matplotlib elements are generated, where / how would I intercept them before they get repr()'d so I can, say, manually fix the viewport or investigate what's going on?

@makmanalp, that would have to be in the ggplot/ggplot.py draw method. There is a lot going on in there and it is a very unsightly. Maybe try poking around after the log scales are [applied] (https://github.com/yhat/ggplot/blob/0f3774e6a645796b843d3ce77fb388958773338e/ggplot/ggplot.py#L135).

@has2k1 Perfect, thank you so much.


fix: Upgrade rtsp-simple-server to fix vulnerability

Upgrade rtsp-simple-server to v0.21.6 to fix vulnerability
Fix #178

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?) not impact
[ ] I have fully tested (add details below) this the new feature or bug fix (if not, why?) not impact
[ ] I have opened a PR for the related docs change (if not, why?) not impact

Testing Instructions

Run core service and device-usb-camera to test video stream
New Dependency Instructions (If applicable)

Codecov Report

Merging #179 (3d9796f) into main (4e47f77) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@          Coverage Diff          @@
##            main    #179   +/-   ##
=====================================
  Coverage   3.05%   3.05%
=====================================
  Files          6       6
  Lines        687     687
=====================================
  Hits          21      21
  Misses       666     666

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ajcasagrande , we need to also do this for the upcoming Levski patch release.


Update README.md

Sometimes it not good to publish all resources from vendors

@al0mie yes that's right


An error occurred while provisioning resources on windows-2022

Description
I'm trying to set up WSL with Rust toolchain via Setup WSL action on Windows Server 2022, but my builds hang and crash with an error (see below).
Virtual environments affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
Build: https://github.com/intellij-rust/intellij-rust/runs/4332945286
Is it regression?
No
Expected behavior
The build doesn't hang.
Actual behavior
The build hangs and then fails with error:

Repro steps
Repush last commits in https://github.com/intellij-rust/intellij-rust/pull/7285.

Hi @mchernyavsky. Thank you for your report. We will take a look. Could you please provide minimal workflow or slightly more detailed repro steps to help us with the investigation process.

@shilovmaksim

Create a fork of https://github.com/intellij-rust/intellij-rust repo
Enable check workflow
Create a PR from wsl-tests into your main branch

PR in my fork fails with the same result - https://github.com/mchernyavsky/intellij-rust/pull/3

Hello @mchernyavsky. I've investigated the issue and looks like the root cause was temporary connection issues. I wasn't able to reproduce the issue anymore and as I can see your builds are passing now. Could you please confirm that the issue is not appearing anymore.

@dibir-magomedsaygitov

Could you please confirm that the issue is not appearing anymore.

I still have this issue:

In intellij-rust repo - https://github.com/intellij-rust/intellij-rust/actions/runs/1546646297
In my fork - https://github.com/mchernyavsky/intellij-rust/actions/runs/1546766549

Hello @mchernyavsky. I was able to reproduce the issue on Windows-2022 with your latest changes, but without them - the issue is not appearing. Also, the build doesn't hang if you will use bash instead of wsl-bash {0} as a shell in Check environment step.
Looks like your latest changes are causing the issue or there is an issue in setup-wsl action. Unfortunately, we are not experts in Kotlin or setup-wsl action. Could you please check your project or contact maintainers of the setup-wsl action for possible breaking changes?

I have created an issue in setup-wsl repo - https://github.com/Vampire/setup-wsl/issues/15

Hello @mchernyavsky. Looks like this issue is related to rust. I'm going to close this one, but feel free to contact us if you have any questions or concerns. Thank you!


Running Inference without GT

Your work looks amazing! I want to try to run this on a dataset of my own to improve the quality of a video. As this video is blurry of it’s own I do not have a non-blurry ground truth available. Is there any way to run the model without?

You can copy the burry video and take it as the placeholder of GT. Then you can run the inference code.
In addition, if you want to get the whole deblurred video, you can copy the border frames to make this code consider border frames.
For example:
burry frames [1, 2, 3, 4, 5] -> deblurred frames [3]
copy the border frames:
burry frames [1, 1, 1, 2, 3, 4, 5, 5, 5] -> deblurred frames [1, 2, 3, 4, 5]

This is the same as issue #12, which I fixed in my fork.
As for the example. I usually do it a bit different to keep motion in the frames even if it is in the reverse direction.
blurry frames [3, 2, 1, 2, 3, 4, 5, 4, 3] -> deblurred frames [1, 2, 3, 4, 5]
I'm going to try to figure out how to do this automatically in inference.py but I haven't gotten around to it yet.


Person first language - Accessibility

Describe your problem and - if possible - how to reproduce it
This isn't really a coding issue.  This has to do with using "person-first language" for the Applied Accessibility modules.  First, I want to say that I LOVELOVELOVE that you are teaching Applied Accessibility!  Thank you so much! I thought I was going to need to scour the web for good resources on building accessible sites.  Again, Thank You Thank You Thank You!!!
It's possible that you know all about this and just let it slip, but I noticed the "Improve Accessibility of Audio Content with the audio Element" module has the sentence "Audio content also needs a text alternative to be accessible to the deaf or hard of hearing."  The only issue w/ this sentence is the use of "the deaf..." as opposed to "people who are deaf or hard of hearing."
This may seem inconsequential, but it's important to many people w/ disabilities b/c it puts an emphasis on the person being... well... a person.  Saying "the deaf, the blind, or a paraplegic" is avoided because it reduces a person to their disability, whereas "a person who is deaf, a person with visual impairments, or a person with paraplegia" puts an emphasis on humanity first and the disability second.
If you want any other tips on p.c. wording for accessibility, etc., that's my area!  Again, thanks so much for including this section!!
Add a Link to the page with the problem
Tell us about your browser and operating system

Browser Name:
Browser Version:
Operating System:

If possible, add a screenshot here

Thanks for pointing this out @rhuss623, let us know if you find anything else - the issue can be fixed here - https://github.com/freeCodeCamp/freeCodeCamp/blob/staging/seed/challenges/01-responsive-web-design/applied-accessibility.json#L476

Got it. Will fix tonight.


Add --mode option to transaction transfer

Can you add a --mode option to transaction transfer?
If you add this I could spam the network with this method. At the moment I have to press enter for every transaction.

@meyns good catch, it should be solved in the next release 👍


Won't Initialize in Strict Mode

Hi, I'm running into an issue with this package when it's being built into a javascript file which is declared in strict mode. The file it's included in must remain in strict mode, so when I build it this package into the  JS file, or declare "use strict"; for that matter in the function itself, it gives this error:
Uncaught TypeError: Cannot set property 'humanizeDuration' of undefined
humanize-duration.js:412 Uncaught TypeError: Cannot set property
The issue is relating to this line on 412:
this.humanizeDuration = humanizeDuration;

How could this package be made to work within strict mode? Thanks.

By changing this to window fixes it. @EvanHahn What do you think about using window rather than this? Are there any known drawbacks?
window.humanizeDuration = humanizeDuration;

@phongmedia I believe I fixed this. Could you try the latest version and make sure the issue is fixed?

@EvanHahn Great thanks, I see the one you linked there uses global., I'll give that a try, so you can assume it works fine in strict mode unless I message you again. Thanks!

@phongmedia Have you tested it? If so, I'll push a new patch version.

It works..

Is this all solved?


Adds easy to use, modern looking theming

Adds easy to use, customizable theming to hvPlot. Should work for HoloViews as well and integrate well with Panel.
For example like
hvplot.extension(theme=THEME, color=COLOR, cmap=CMAP, font=FONT)

This PR was requested by @philippjfr . I should initiate and @philippjfr would look at finding solutions for the Bokeh related technical issues.

How to style tooltips and toolbar. This requires css and I cannot see any Bokeh/ hvPlot way to inject this.

I think the Bokeh Theme should provide a css argument that can be used?

How to implement working autohide toolbar as there is some bug currently according to Philipp.

Maybe @matpap has suggestions for solving these issues?
This PR is about getting the basics right

Theme api that extends to all plotting backends and multiple themes
Theme that works well for default the Bokeh backend

I think we should not wait for Bokeh 3.0 to solve some of these issues. But one day it would be nice to get the improvements ported back to Bokeh.
Closes #841, Closes #834
Related #537
Examples
panel serve examples/user_guide/theming_bokeh.py --auto
fast theme

fast-dark theme

I will wait for Philipps feedback/ solutions for the .css and hooks issues.

Is that a screenshot from a full-screen plot on a large monitor?  The tick labels seem much too small, but maybe if it were on a laptop screen they would be ok?

Big screen

I remember using the theme like:
hv.renderer("bokeh").theme = "dark_minimal"
Does .opts(theme="dark_minimal") work, or is this separate?
Also, should the theme be integrated on panel rather than hvplot?
I personally like streamlit's widget theme/style; feels very "modern/minimal"

Thanks @MarcSkovMadsen for this effort. I agree it'd be nice to have an easy way to customize the theme. However I wouldn't know where to start reviewing this, it seems like you're creating a new hvplot_extension function while there's already an existing one. There's also a lot of TODOs in the code. If this is still work in progress could you please mark it as WIP?

I asked @MarcSkovMadsen to push something I could work from, so blame me 🙂


[QUESTION] Different pause durations

I need to understand if this package can be used for voice activity detection in my project, where I want to trigger different actions based on varying pause lengths. Is it possible to achieve this functionality with this package, and if so, how can I set up different actions for different pause durations?

You can listen to onSpeechEnd and use audioData.length directly to calculate the speech duration
_vadHandler.onSpeechEnd.listen((audioData) {
  final duration = audioData.length / 16000; // Duration in seconds

  if (duration < 3) triggerShortSpeechAction();
  else if (duration < 6) triggerMediumSpeechAction();
  else triggerLongSpeechAction();
});

This calculates duration from audioData and triggers actions as defined by you.

@keyur2maru Your example involves determining the length of the received audio stream, and I need to determine the length of the pause.
My goal is to use the VAD to identify small pauses and based on them to cut the audio stream into pieces and thus start transcribing it before the speech is finished

@keyur2maru Your example involves determining the length of the received audio stream, and I need to determine the length of the pause.
My goal is to use the VAD to identify small pauses and based on them to cut the audio stream into pieces and thus start transcribing it before the speech is finished


Godot version:
3.2 stable
EDIT: tested with 3.2.1 RC1 and the problem is present too
OS/device including version:
Windows 10 1903
Issue description:
Material with opaque prepass enabled, even little alpha, appears invisible if no other object is behind. Tested on 3.1, the issue is not present.
I tried to create leaves for trees and, if no other object is behind I see them invisible.

in 3.1 the issue is not present (same project)

Steps to reproduce:
create a quad with material with alpha texture, enable opaque prepass, enable alpha scissor (additionaly decrease the alpha channel of albedo color to 255 -> 252) and see the object become completely transparent.

Minimal reproduction project:
IssueOpaquePrepass.zip

Note: The rationale behind the opaque prepass is that only the opaque parts of your object will be rendered. Because you have effectively made your entire object transparent, the whole thing is discarded.
https://github.com/godotengine/godot/blob/f4e3701893bdf6b304ee114745def2f8ac4aa822/drivers/gles3/rasterizer_scene_gles3.cpp#L4131
I am not sure why the cutoff is 0.99, it seems the cutoff could and should just be the alpha scissor threshold. But it is what it is.
That being said, this is easy to work around. There is no benefit to making your material 98% opaque and alpha scissored. You should either treat it like an opaque material, or treat it like a transparent material.

@clayjohn
maybe I understand what you mean, but even with 100% opacity the object looks weird.
Also the opaque prepass was the only way (that I know) to make a transparent object cast a shadow.

@unSkind You example scene works fine if you just don't reduce the transparency of the albedo color. The reason it is disappearing is because you are making the entire object transparent. Opaque pre-pass only captures the opaque part of the object.

@clayjohn
You are right, I have tested it with opacity 100% and actually I can see the object. But I said that it looks weird because, if you zoom out, the object disappear again. If I want to use this material for foliage it's not good, because I want to see the leaves of the tree also from long distance.

I have created a small test project that illustrates several of the conditions required for this bug. It seems to confirm that when a part of the material has an ALPHA value of less then .99, when using ALPHA_SCISSOR set to any value, and the shader is using depth_draw_alpha_prepass then the range between ALPHA_SCISSOR and 0.99 values will only be rendered if there is another solid object behind it.

AlphaScissors.zip
Given that 4.0 will have rewritten this entirely it seems unlikely that this particular issue will be fixed before the 4.0 release. In the meantime there is a slightly hacky workaround using the shader language. You can click on any SpacialMaterial and click Convert To ShaderMaterial. Then modify or add the following lines.
# Replace This
ALPHA = albedo.a * albedo_tex.a;
ALPHA_SCISSOR = alpha_scissor_threshold;

# With This
if (alpha_scissor_threshold < albedo.a * albedo_tex.a) {
    ALPHA = 1.0;
} else {
    ALPHA = 0.0;
}

Maybe someone should open a pull request on the 3.2 branch to modify the shader code.

OK so, this isn't what I normally do, so excuse my noobiness or if this is wasting anyone's time, I don't normally do C++ coding and I've never contributed to Godot before..
I think I found a way of implementing @AsherGlick 's hack like @Calinou suggested.
I just did a tiny test right now and it appears to work.
In the file /scene/resources/material.cpp @ line 883, I added a little bit of code that tweaks the shader code that's generated.
This is what that section of the code looks like normally:
	} else if (features[FEATURE_TRANSPARENT] || flags[FLAG_USE_ALPHA_SCISSOR] || flags[FLAG_USE_SHADOW_TO_OPACITY] || (distance_fade == DISTANCE_FADE_PIXEL_ALPHA) || proximity_fade_enabled) {
		code += "\tALPHA = albedo.a * albedo_tex.a;\n";
	}

And this is what I tweaked it to:
	} else if (features[FEATURE_TRANSPARENT] || flags[FLAG_USE_ALPHA_SCISSOR] || flags[FLAG_USE_SHADOW_TO_OPACITY] || (distance_fade == DISTANCE_FADE_PIXEL_ALPHA) || proximity_fade_enabled) {
		code += "\tALPHA = albedo.a * albedo_tex.a;\n";
		if (ddm == DEPTH_DRAW_ALPHA_OPAQUE_PREPASS) {
			code += "\tALPHA = float(alpha_scissor_threshold < ALPHA);\n";
		}
	}

The extra line achieves what Asher's hack does. Instead of an if/then I just compacted it to cast the if condition result into a float.
I don't know if that's messy or not but.. hopefully that helps.
It however doesn't fix the REAL issue which is that if the 'depth_draw_alpha_prepass' render mode is enabled, then nothing is drawn that has an alpha value less than 0.99. I tried looking for that in Godot's code but I couldn't find it.
But it would fix at least my use case issue with Godot, of spatial materials with depth prepass and alpha scissor enabled together not working when there's a sky background behind them.
What do you think?

I have a glitches that seems to come from the same issue but I'm not sure:

depth_draw_alpha_prepass seems really tricky to use...

I think I've figured out why this issue is particularly problematic for trees.
For trees, you often have lots of quads overlapping each other, so you need some kind of alpha clipping/alpha scissor to render them, and you need opaque pre-pass to render shadows of the leaves. There's no other way around it, you would have triangle sorting issues otherwise.
Because the threshold is so high, when you zoom out from a surface with an alpha transparent texture of leaves on it, the effects of mipmapping kicks in. The lower mipmaps are averaging pixel values, including alpha, so the lower mipmaps are blurry and hence there's no alpha values that are greater than 0.99 anymore, even though there are plenty of values which are greater than 0.5 and which should be rendered. The threshold really needs to be controllable with the alpha scissor threshold to fix this.
Here's a video example of this issue

@RonanZe @mindinsomnia Does this still occur if using my workaround and setting the threshold lower? I feel like I ran into something very similar to this as well in my own work but it was also fixed with that little hack without realizing that mipmaps were the cause.

@AsherGlick With your workaround the problem is fixed. Your workaround effectively produces the behaviour that Godot should be doing anyway with the scissor value so it fixes the problem easily and branch textures look fine from a distance.

See also https://github.com/godotengine/godot/pull/40364 which may resolve this issue.

I have been fighting with this issue as well and I'm just wondering if any workaround shouldn't discard the fragments? I assume that's what's happening in the background when you are using ALPHA_SCISSOR? At least that's what it sounds like in the manual.
I get visually the same result doing this, but a big performance improvement.
if (alpha_scissor_threshold > albedo.a * albedo_tex.a) {
    discard;
}

Will this still be fixed for the 3.2.4 release? Because in some situations, you can't just convert the material and fix the shader, like with materials in imported models. Event import scripts can't do that, because there seems to be no way of converting a Spatialmaterial into a shader in code.

Will this still be fixed for the 3.2.4 release? Because in some situations, you can't just convert the material and fix the shader, like with materials in imported models. Event import scripts can't do that, because there seems to be no way of converting a Spatialmaterial into a shader in code.

@Avogine Feel free to open a pull request for this (against the 3.2 branch, not master) :slightly_smiling_face:
Make sure to include a minimal reproduction project so we can confirm this effectively fixes the issue.

@Avogine Feel free to open a pull request for this (against the 3.2 branch, not master) :slightly_smiling_face:
Make sure to include a minimal reproduction project so we can confirm this effectively fixes the issue.

@Calinou Thanks, I will do that.😄

@Calinou Thanks, I will do that.😄

I found the commit that caused this bug:
#32763
I don't know if this is just a bug, or just a side-effect of the fix from @clayjohn in this pr.
Anyways, I think it would be nice to have this fixed for 3.2.6, as a lot of scenes break with this bug.

I found the commit that caused this bug:
#32763
I don't know if this is just a bug, or just a side-effect of the fix from @clayjohn in this pr.
Anyways, I think it would be nice to have this fixed for 3.2.6, as a lot of scenes break with this bug.

@Avogine Thanks for tracking that down. I'd like to explain what the root of the bug here is so that someone can take a stab at fixing it.
By default, transparent materials do not write anything to the depth buffer when drawn. However, if "opaque_prepass" is enabled they will be drawn during the depth prepass using any portion of the object with an alpha of 1.0 (fully opaque).
For some reason, right now, transparent materials with depth prepass are not being drawn in areas where the depth is not written to (i.e. there is no solid object behind). This behaviour is inconsistent and changes depending on whether a gizmo in the scene is selected. My guess is there is a some OpenGL state not being set correctly (perhaps a glDepthMask or glDepthFunc call) resulting in this inconsistent behaviour (to me it almost looks like the transparent materials are accidentally using GL_GREATER for the glDepthFunc, running the test scene through RenderDoc could confirm).
Regardless of whether the prepass is used, transparent materials should draw normally. The opaque prepass should just be necessary for inclusion in screen space effects that rely on depth.
#45372 would help alleviate this issue as it allows transparent materials to write to depth even if their alpha is less than 1.0, but it doesn't fully resolve this issue.

Thanks for the explanation.😄

This may be fixed by #50721 or may be moot, as you no longer have to use alpha scissoring for foliage anymore. You can use real alpha.
As of this PR, my trees use depth_draw_alpha_prepass and cull_disabled and I no longer have occlusion or ordering issues in (99% of the cases) whether I use alpha scissoring or true alpha.


Bug Report: assumePayable does not work for 0x08

According to https://www.evm.codes/precompiled?fork=shanghai, 0x08 will always returns success even when transfer fails. So we need modify the assumePayable function to check payable.

See discussion in https://github.com/foundry-rs/forge-std/pull/387, but this address is payable, so closing


[sample_hevc_fei] Fix MVP block size setting for PREENC

Confusing commit title. sample_hevc_fei doesn't support MV predictors for PreENC


Not working with typescript

What is the current behavior?
Throw error when working with webpack and awesome-typescript-loader
Uncaught TypeError: Cannot read property 'createContext' of undefined

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to a CodeSandbox (https://codesandbox.io/s/new) or RN Snack (https://snack.expo.io/) example below:
I have created a repo to repro this bug: https://github.com/xcatliu/react-redux-bug
Run npm i && npm start && open public/index.html to see the error
Also, the current work around is to use react-redux/lib rather than react-redux
What is the expected behavior?
Not throw error
Which versions of React, ReactDOM/React Native, Redux, and React Redux are you using?  Which browser and OS are affected by this issue? Did this work in previous versions of React Redux?
react 16.8.6
react-dom 16.8.6
react-redux 7.0.1
redux 4.0.1
redux-devtools-extension 2.13.8
redux-thunk 2.3.0
awesome-typescript-loader 5.2.1
typescript 3.4.3
webpack 4.29.6
webpack-cli 3.3.0

This isn't a react-redux bug.


refactor: Update parameters

Updates buf gen properties

You can merge it to main. We don't use releases/v0.21 anymore

Need releases/v0.21.x to generate all proto's (perp/spot) otherwise it causes a huge downstream issue in the web-app/ts-sdk

A lot of this was prettier


hash_tree giving wrong output

Ok this is a very tricky bug so bear with me.
I tried to create a simplified test case to illustrate it but the bug seems to depend on a very particular order of things happening that I haven't been able to reproduce inside the gem source.
Here is how to reproduce:
git clone https://github.com/sassafrastech/madeline_system.git
cd madeline_system
git checkout closure_tree_hash_tree_bug
# Ensure ruby 2.2.3 or greater
bundle install
cp config/database.yml.example config/database.yml
cp config/secrets.yml.example config/secrets.yml
rspec ./spec/models/loan_response_progress_spec.rb:29

Note the output from hash_tree that gets printed to stdout. There are three top level nodes!
Note that if you run the spec individually with rspec ./spec/models/loan_response_progress_spec.rb:53, everything looks correct. The issue seems to be created by the fixtures from earlier tests being rolled back in the database, but I'm not sure how.
I was able to trace this to an issue with the ordering of the fetched nodes. In build_hash_tree, if you echo out the fetched nodes, they are not sorted by depth, and that throws the whole thing off.
For now I was able to fix this with this commit:
https://github.com/sassafrastech/closure_tree/commit/02689da3f186b7412adf648d298afc0614123631
But I don't think that should really be necessary since self_and_descendants is supposed to return nodes in depth order but isn't.
Curious if someone can fix this properly. I think this could be a serious bug as it's not clear when the ordering of self_and_descendants is incorrect and it could affect other parts of the code.
Thanks!

Any thoughts on this?


[Experimental][TS] - "Alternate_ear_graphics" mod not affecting visuals

Tags
[Experimental] - normal tags
[TS] - Tile Set
Name the mod
Put the name(s) of affected mod(s) here.
Alternate_ear_graphics
Describe the bug
The graphics which the mod should change does not - the original feline ear graphic, for example, is present, rather than the mod's version. Using the latest version of UndeadPeople tileset.
How to reproduce
Include the steps you took to get the bug here.
Have the Feline Ears, Canine Ears, Lupine Ears etc. mutation with the alternate_ear_graphics mod installed using UndeadPeople tileset.
Solution
How you think the bug should be resolved.
Additional context
Add any other context about the problem here.

is this still persistent?

is this still persistent?

needs tested think i fixed it
Alternate_ear_graphics.zip

needs tested think i fixed it
Alternate_ear_graphics.zip

fixed it

fixed it

closing this as its fixed with https://github.com/TheGoatGod/Goats-Mod-Compilation/pull/212

closing this as its fixed with https://github.com/TheGoatGod/Goats-Mod-Compilation/pull/212


Fixed markup

Hi @iamjessklein, this is a very small PR. I hope you get to merge it soon.
Regards from a fellow Mozillian,
Henrik


jpg_loader: fix compiler warnings

@Issue: https://github.com/thorvg/thorvg/issues/2639

https://github.com/thorvg/thorvg/pull/2763


allow badge maxAge to be set by category; affects [discord]

This PR adds the ability for us to override BADGE_MAX_AGE_SECONDS with a different value for a category or a specific badge. This will allow us to set a long cache on badges that change infrequently (like license) and a shorter cache on badges that change more frequently (like build status). I've set some values in this PR:
license: 1 hour
version: 5 minutes
build: 30 seconds
as a starting point, but I'm not wedded to them. I'm more interested in feedback on the approach for now.
This only applies to the services we've already refactored, but as we refactor more of the codebase, this becomes an increasingly helpful feature :)
I've also shown an example in fe3552a of how we can use this feature to override the default in a specific badge. 2 mins cache is fine for most of the 'chat' badges, but the discord "how many users are online now" badge shows something more immediate so we might want to set a lower cache time on it.
One downside of this is that it becomes tricky to clearly explain the behaviour of the maxAge param:
https://github.com/badges/shields/blob/9df1da137c19d93e0d4e0a0a2526e807cddfbed4/frontend/components/usage.js#L267-L275
as potentially every badge could define its own default (lets not actually do that). That said, as we become better at caching on our side, I wonder if exposing that for users is still a valuable feature? :thinking:

Warnings

:warning:

This PR modified service code for discord but not its test code. That's okay so long as it's refactoring existing code.

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @chris48s!

  Generated by :no_entry_sign: dangerJS

Looks good to me! 👍
I think @PyvesB suggestion will definitely help future proof it though.

Cheers - good suggestions, both.
I reckon with the maxAge param, lets leave it there for now with @PyvesB 's suggested wording, but once we've refactored a larger chunk of the codebase we can probably just quietly remove that param. It is primarily there to allow users to manually work around a problem which we're now taking a more sophisticated approach to solving internally.


add LinkModal for outgoing link (floating) search in file

I added commands for "outgoing link search in a file."
I also added a "floating search" version like "header floating search in a file."
These commands solve this issue: #45
I'm new to typescript, and this PR is for learning purposes.
The added code may be redundant.
Thanks for your helpful plugins!

Thank you for your PR, @masa1290 :)
However, could I let me leave the PR? Because

I want to consider the specification a little more
I have been implementing some updates for the next major release, v7.0. And it may change some code bases

Best regards.

However, could I let me leave the PR?
Got it!
I'm looking forward to the next major release, v7.0.


Emits from servers arent allways received

Hello!
I tryed to use node.js with latest socket.io version to connect to your socket.io client implementation, the connection works well, but sometimes, when i put a bit of debug or a bit of hard execution works, the emits from the server arent received.
Emits from client are received by the server, but emits from the server sometimes not received, the server then timeout (60 sec), and no errors or debug messages are shown then even with the using directive you provided. (even disconnection)
(connection and other messages before the issue are sent well).
Do you know what can be the problem?
Do your debug directive catches errors yet, or do i got to implement error catch?
Could it come from websockets?
How could i catch timeout on client side? (so i could maybe reconnect manually)
Is it linked to the fact i use unity free? The issue doesnt happens most of the time, so i though it was just a something i did bad, but can i be perplex about unity free? (i dont want to buy license just to see the problem still occur).

This is not an answer, but more like a comment. Have you checked that the emit packages are sent at all? By using an application like WireShark, you can see which packets are being sent and received on your network. I was just wondering if the process you are doing are taking up too much work, making your server incapable of sending any packages?

If you want to, you could try to use an older version of socket.io?

this api isnt compatible with latest version?
i dont think the problem comes from the server, when i talked about process that take too much work, i meant that unity debugging things made things dont work sometimes only, not server side, but yes i ll try to see, thank you for advice.
here what happend:
1 : i create a new GameObject, add a socket.io component on it.
2 : i start a coroutine telling it to send an event after some seconds
3: the server receive the event, then emit another event back to the socket, telling it another port so it can connect to it. (a threaded room) (the server thread itself just after emitting back the event).
4: sometimes unity receive it, sometimes not. :s
what version of socket.io does this api support?

if actually it is the work that is too big on server side, what can i do to fix that? the work needed is mandatory :s it instantiates informations of prefabs from some files, and do non avoidable initializations,
if i remove the threading (that is by the way weirdly after the emit, things works more often), if i put it back yes it looks like it produce random things again. anyway to be sure socket.io wont die if i do too much work on server side?

  Node.js and Socket.IO are not
meant to be multithreaded, are they ?
Are you running multiple servers on different ports ? and disconnecting
from one to connect to another ?
I'm kind of suprised by your messages, since I didn't experience the
problems you are describing, even when doing kinda heay-load operations on
the server.
2016-02-12 11:07 GMT+01:00 gdefraiteur<EMAIL_ADDRESS>
if actually it is the work that is too big on server side, what can i do
to fix that? the work needed is mandatory :s it instantiates informations
of prefabs from some files, and do non avoidable initializations,
if i remove the threading (that is by the way weirdly after the emit,
things works more often), if i put it back yes it looks like it produce
random things again. anyway to be sure socket.io wont die if i do too
much work on server side?
—
Reply to this email directly or view it on GitHub
https://github.com/fpanettieri/unity-socket.io/issues/31#issuecomment-183259477
.

You can try lowering the pingInterval configuration of the SocketComponent to 5,10 or 20 seconds. You might be experiencing a disconnection for inactivity, and after a client is disconnected due a timeout, it won't reconnect until it sends another message.
I haven't used this package in the last 14/16 months, I can't provide an accurate solution to your case.
For future issues, try running the server in debug mode, you will see any error or disconnection that might cause other bugs.


[QST] Triton complains about extra columns in the workflow output

Hi,
I'm trying to reproduce some of the notebooks but the tritonserver is complaining about extra columns in the workflow's output. I'm confused about the error, as those as the columns outputted by the nvtabular workflow which I'm then using to train the sequential recommendation engine.
+-------------+-------------------------------------------------------------------------+--------+
| Backend     | Path                                                                    | Config |
+-------------+-------------------------------------------------------------------------+--------+
| pytorch     | /opt/tritonserver/backends/pytorch/libtriton_pytorch.so                 | {}     |
| onnxruntime | /opt/tritonserver/backends/onnxruntime/libtriton_onnxruntime.so         | {}     |
| openvino    | /opt/tritonserver/backends/openvino_2021_2/libtriton_openvino_2021_2.so | {}     |
| tensorflow  | /opt/tritonserver/backends/tensorflow1/libtriton_tensorflow1.so         | {}     |
| python      | /opt/tritonserver/backends/python/libtriton_python.so                   | {}     |
+-------------+-------------------------------------------------------------------------+--------+

I0309 02:34:41.725660 115 server.cc:589]
+-----------------+---------+-------------------------------------------------------------------------------------------------------------------------------------------------+
| Model           | Version | Status                                                                                |
+-----------------+---------+-------------------------------------------------------------------------------------------------------------------------------------------------+
| t4r_pytorch_nvt | 1       | UNAVAILABLE: Internal: ValueError: The following extra columns were found in the workflow's output: {'week_index', 'et_dayofweek_cos-list_seq', |
|                 |         |  'item_id-count', 'session_id', 'product_recency_days_log_norm-list_seq', 'et_dayofweek_sin-list_seq', 'item_id-list_seq'}                      |
|                 |         |                                                                                |
|                 |         | At:                                                                                |
|                 |         |   /usr/local/lib/python3.8/dist-packages/nvtabular/inference/workflow/base.py(71): __init__                                                     |
|                 |         |   /usr/local/lib/python3.8/dist-packages/nvtabular/inference/workflow/tensorflow.py(33): __init__                                               |
|                 |         |   /models/t4r_pytorch_nvt/1/model.py(85): initialize                                                                                |
| t4r_pytorch_pt  | 1       | READY                                                                                |
+-----------------+---------+-------------------------------------------------------------------------------------------------------------------------------------------------+

I0309 02:34:41.725789 115 tritonserver.cc:1865]
+----------------------------------+------------------------------------------------------------------------------------------------------------------------------------[0/1772]
| Option                           | Value                                                                                |
+----------------------------------+------------------------------------------------------------------------------------------------------------------------------------------+
| server_id                        | triton                                                                                |
| server_version                   | 2.18.0                                                                                |
| server_extensions                | classification sequence model_repository model_repository(unload_dependents) schedule_policy model_configuration system_shared_memory cu |
|                                  | da_shared_memory binary_tensor_data statistics                                                                                |
| model_repository_path[0]         | /models                                                                                |
| model_control_mode               | MODE_NONE                                                                                |
| strict_model_config              | 1                                                                                |
| rate_limit                       | OFF                                                                                |
| pinned_memory_pool_byte_size     | 268435456                                                                                |
| cuda_memory_pool_byte_size{0}    | 67108864                                                                                |
| response_cache_byte_size         | 0                                                                                |
| min_supported_compute_capability | 6.0                                                                                |
| strict_readiness                 | 1                                                                                |
| exit_timeout                     | 30                                                                                |
+----------------------------------+------------------------------------------------------------------------------------------------------------------------------------------+

I0309 02:34:41.725820 115 server.cc:249] Waiting for in-flight requests to complete.
I0309 02:34:41.725828 115 model_repository_manager.cc:1026] unloading: t4r_pytorch_pt:1
I0309 02:34:41.725873 115 server.cc:264] Timeout 30: Found 1 live models and 0 in-flight non-inference requests
I0309 02:34:42.726033 115 server.cc:264] Timeout 29: Found 1 live models and 0 in-flight non-inference requests
I0309 02:34:43.318535 115 model_repository_manager.cc:1132] successfully unloaded 't4r_pytorch_pt' version 1
I0309 02:34:43.726237 115 server.cc:264] Timeout 28: Found 0 live models and 0 in-flight non-inference requests
error: creating server: Internal - failed to load all models

Do you have any idea what might be causing the issue?
I'm using triton from the Docker image nvcr.io/nvidia/merlin/merlin-inference:22.02.

@IamGianluca can you give a bit more info? which nb are you running? the end-to-end example nb?

@rnyak yes, I'm trying to replicate the end-to-end-session-based example. I'm using nvcr.io/nvidia/merlin/merlin-pytorch-training:22.03 for training and nvcr.io/nvidia/merlin/merlin-inference:22.02 for inference. I would use nvcr.io/nvidia/merlin/merlin-inference:22.03 for inference, but tritonserver doesn't seem to be installed in that Docker image.

@IamGianluca thanks. you can use nvcr.io/nvidia/merlin/merlin-pytorch-inference:22.03  image and install torch and torchmetrics if required. I am looking into the following extra columns were found in the workflow's output issue.

@IamGianluca sorry for my late response. this issue does not occur anymore if you use the nvcr.io/nvidia/merlin/merlin-pytorch-inference:22.03 container and install torch and torchmetrics and be sure that you are pulling the latest transformers4ec, nvtabular and core main branches. I also ran pip install transformers==4.17.0  in the inference container to have the transformers version same in training and inference containers.  However, I am getting another error, which I will create a bug ticket for shortly.  sorry for the inconvenience.

@IamGianluca this issue should be solved now. You can test that if you pull nvcr.io/nvidia/merlin/merlin-pytorch:22.06 container and then pull the latest transformers4ec, nvtabular and core main branches.  Please run pip install . after each pull in each repo directory.  You do not need a separate inference container, since merlin-pytorch:22.06 has all in it.

@karlhigley somehow tutorial triton example nb 04-Inference-with-Triton.ipynb  are giving extra column error as above. fyi.

closing since the issue is solved and we do not get error from TIS when serving ensemble model.


Fully automated creation of new certs

Hi
I'm trying to get an automated process where my program creates a site in IIS and applies a new certificate to it too. I'm doing this at present with my asp program calling a shell script to run command line.
It's hanging when I run the command line because it is waiting for a response.
I see others have requested this/similar. Any update on whether this can/will be implemented?
Essentially I want to be able to run this and the prompts automatically answered:
letsencrypt.exe  --manualhost "www.mynewwebsite.com" --webroot "c:\inetpub\wwwroot\mynewwebsite.com\"
Thanks.

Just FYI: I have a PR open to make that a feature: https://github.com/Lone-Coder/letsencrypt-win-simple/pull/275

Seems to be merged already, so this can be closed. Please open a new issue if it doesn't work for you @webbysteve


Use upstream defined kafka broker jmx_exporter configs

Q
A

Bug fix?
no

New feature?
yes

API breaks?
no

Deprecations?
no

Related tickets
fixes #318

License
Apache 2.0

What's in this PR?

Use upstream defined kafka broker jmx_exporter configs
Checklist

[x] Implementation tested
[x] Error handling code meets the guideline
[x] Logging code meets the guideline
[x] User guide and development docs updated (if needed)

awesome, thanks guys!


having a choice to bypass 'exit;' in route->end() ?

I am tring to send a file generated by php to client, and I used "before" to create an html template. And 'before' runs before get so I have no clue what my contents will be.
then I tried using ob to catch all template and also my content.
here's an example code:
app()->nowrap =false;
$route->before('/',function(){
  ob_start();
  ...
  app()->heading = ob_get_clean();
}
$route->get('/file',function(){
  echo file_get_contents(...);
}
$route->after('/',function(){
  header('Content-Type: text/plain');
  app()->nowrap = true;
  ob_start();
  ...
  app()->footing = ob_get_clean();
}
ob_start();
$route->end();
$content = ob_get_clean();
if (!app()->nowrap) echo app()->heading;
echo $content;
if (!app()->nowrap) echo app()->footing;

function end(bool $exit = true){
...
if ($exit){
exit;
}

before and after, and use is designed such middleware, Not for output content
You need to use view template instead
see this https://github.com/nezamy/view

got it! will check it out! thanks!!


Mouselook Toggle

Mouselook is already improved. A full mouselook toggle would be cool. I am already very far, but it still has some annoying edge cases that ruin the experience.
Cherry on top: "Inverse Toggle"
When in full mouselook mode, holding Rotate should display the cursor while held.
Is a complete own task though.

Some notes I had lying around:

think about all kinds of race conditions
currently, there is an issue if you toggle while the context menu is open

if you press contextmenu, toggle mouselook, rightclick, then rightclick does not work anymore
maybe request toggle, instead of setting it directly?

toggle off mouselook when opening panels

i think in an old IDA database, i found something about cancel menu events
maybe hook the tab in event? there was some sdl stuff


Display correct names for rooms

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/12883
Tests

If you need to, create a new worskspace and a room in said workspace. Give a name to the room.
Using the LHN, navigate in and out of the room a few times. The name should not change and should always display correctly

[x] Verify that no errors appear in the JS console

Offline tests
Test step 2 above while offline. The behavior should be the same.
QA Steps
Same as tests

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above

[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms

[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers

[x] I followed the guidelines as stated in the Review Guidelines

[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)

[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)

[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such

[x] I verified that if a function's arguments changed that all usages have also been updated correctly

[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for expected offline behavior are in the Offline steps section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

Desktop

iOS

Android

Looking good.

I don't know what is wrong with the checklist. It is the same as what we have on the latest template.

I don't know what is wrong with the checklist. It is the same as what we have on the latest template.

I think it is because it is not starting with "## Reviewer Checklist" (this check here)
I'm guessing that the text you add before #### Reviewer Checklist and that #### Reviewer Checklist is not ## Reviewer Checklist is messing with it

No emergency, the reviewer checklist was done, but the automated check was not detecting it correctly.

I think there is room for improvement in the code finding the reviewer checklist to make it more robust and find it anyway in cases like this

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @aldo-expensify in version: 1.2.30-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Gonals @parasharrajat @aldo-expensify,
While executing this PR, we noticed messages duplicated in Staging (NOT in PROD) with HT account for one user only. Not sure if its related and other team members were not able to reproduce, but want to check if you can try since it may be a potential blocker
https://user-images.githubusercontent.com/43995119/203592962-ff6ebae9-4383-46d9-8c11-90b7b7527070.mp4
immediately after you create a room and send a message navigate back and forth between other chats and this room

@Gonals @parasharrajat @aldo-expensify,
While executing this PR, we noticed messages duplicated in Staging (NOT in PROD) with HT account for one user only. Not sure if its related and other team members were not able to reproduce, but want to check if you can try since it may be a potential blocker
Desktop.-.12886.mp4
immediately after you create a room and send a message navigate back and forth between other chats and this room

This issue should not be related to this PR! I think we'll need a new GH issue for it

Yep, I have seen that for a while, I would say is not related at all. I happens to me in chats that are not rooms too. IIRC it is going to get fix once we get rid of the sequence numbers or client ids, don't remember :P

🚀 Deployed to production by @luacmartins in version: 1.2.30-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Agreed, this is related to sequence numbers, which is an internal project that we're already working through.


InAppBrowser Compatibility

The plugin does not work correctly when using the InAppBrowser. If an InAppBrowser windows is open, it tries to present itself to the Main window, which is not the top most window.
This fix searches for the topmost window and presents the PassBook plugin to that, so it appears on top of the InAppBrowser.

Looks good, thanks for contributing


Error has bad English spelling

Error English is incorrect when trying to apply a node with the same account as the coinbase: Your account address cannot same with coinbase address

Suggest a good one @etienne-napoleone

I was creating the PR ;)


elastic-tube-3d plot-all-displacements.sh does not produce results

In the elastic-tube-3d tutorial, after running a few time windows of both fluid-openfoam + solid-calculix and fluid-openfoam + solid-fenics, the plot-all-displacements.s exits successfully (exit code 0, no messages), but nothing appears on screen.
gnuplot is installed and I am running in the GUI. @fsimonis observed the same behavior in https://github.com/precice/vm/pull/50#issuecomment-1321945158. This already affected v2202 and maybe earlier versions.
The gnuplot script plot-displacement.sh for the perpendicular-flap seems to work.
I am not sure if this is originating from the tutorials or from the vm, but it is not new. Nothing relevant has changed, neither in the respective tutorial, nor in the vm since v2202.

False alarm, this is just an inconsistent behavior issue.
The perpendicular-flap tutorial plots the result to the screen. The script of this tutorial plots the result to a file.


Add section about Python::check_signals to the FAQ

I think Python::check_signals should be mentioned somewhere in the user guide, as it can be difficult to figure out why Ctrl-C doesn't work while running Rust code and the function is somewhat buried in the documentation.

👍 thank you!


Fix converter regression

Description

Unit tests in separate PR: https://github.com/pulumi/pulumi-java/pull/782 on top of this one
Fixes #774
Checklist

[ ] I have added tests that prove my fix is effective or that my feature works

[x] I have updated the CHANGELOG-PENDING file with my change

[ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

merged with https://github.com/pulumi/pulumi-java/pull/782/


Fixes day2 worker playbook for disconnected installs

Currently the day2 worker playbook is broken for disconnected installs
as the patching logic for mirrored registries does not exist. This
commit fixes this although its mostly a copy of the templates from
the main create cluster role so probably can be done a lot nicer.
Also, the CSR approval mechanism is still broken.

I agree I think we could refactor disconnected manifests into its own role and re-use it for the day2 process.


[ko]Change the way removing reviewer section when localizing docs in Korean

This is a Feature Request

What would you like to be added

As discussed in previous SIG-Docs Korean L10n Team Meeting, I would like to change ### 리뷰어 삭제 part from leaving blank space to commenting the whole block in content/ko/contribute/localizattion_ko.md.

Why is this needed

Reference: https://github.com/kubernetes/website/pull/35423#issuecomment-1196555307

Comments

/language ko

/assign

@jinnypark9393 감사합니다!
/triage accepted

This issue is resolved by https://github.com/kubernetes/website/pull/36802


Replace all \newcommand by their standard command in the doc to fix t…

…he bug in read the doc

:x: Build SMT 0.1.179 failed (commit https://github.com/SMTorg/SMT/commit/54966a9f5d by @bouhlelma)

:x: Build SMT 0.1.180 failed (commit https://github.com/SMTorg/SMT/commit/aba5780728 by @bouhlelma)

:white_check_mark: Build SMT 0.1.181 completed (commit https://github.com/SMTorg/SMT/commit/a2f8a280f7 by @bouhlelma)


Remove run script's coreutils dependency (Closes #4809)

Description

Removed dependency on realpath, notably absent from macOS and some debian distros. Replaced with an equivalent bash function.
Cleaned up prompt response handling, replaced var tests with param expressions.
Removed potentially uneeded calls to sudo (again absent on some systems and most users are part of the docker group anyway). Instead, test if it's needed and get preauth with sudo -v.
Poll for running and stopped Lean containers, and prompt before replacing them. Would fail prior.
Uppercase variables. Sorry.
Incidentally fixed some state-related bug with config file location. Sounds like #4592

Related Issue
#4809

Motivation and Context

Requires Documentation Change
None

How Has This Been Tested?
Tested on macOS and Ubuntu 20. Needs to be run with CSHARP_DLL set for full coverage.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Hey C,
I will have another look at the path resolution, I may have mistranslated the ../../../ used in the container as relative to the Lean directory instead.
I swapped --mount for -v because mount was using the default mount options, which -v is an alias of.

Sounds good!
Ah yes that makes sense, maybe we can change the CSharp DLL and PDB to use them as well!

@kazazes thanks for the PR.
A note for posterity, from our tests you need to use --mount with mounting files. -v is fine for directories.

PR Replaced by #4922

Thanks @kazazes! I'm closing this PR since @C-SELLERS addressed reviews on top of this PR at https://github.com/QuantConnect/Lean/pull/4922