Windows: don't check for MSVC for supporting Unicode filenames

The corresponding wchar_t functionality is also supported by MinGW (at least somewhat recent versions thereof), so the check for _MSC_VER causes the MinGW build to only support the local codepage, and thus differ from the MSVC build, and also have the issue of not being able to access some files on the filesystem if they are not representable in the local codepage.
This drops the defined(_MSC_VER) and only keeps the _WIN32 check, because this is not a compiler feature, but rather a platform feature, so that check is the correct one.
This patch has been used in production successfully for quite a while with MinGW builds.

I've updated the patch to use just 1.11.6, and once that's merged I'll create a new pull request with the 1.11.6 -> 1.10.6 (this will conflict, so I won't do that immediately)
Thanks!

Note that HDF5 itself doesn't check for a specific compiler for the availability of those functions, it just assumes that on Windows that the Win32 API functions are available:
https://github.com/HDFGroup/hdf5/blob/49cce9173f6e43ffda2924648d863dcb4d636993/config/cmake/ConfigureChecks.cmake#L71
From a quick internet search using the compilers you mentioned, without having tested it, all appear to support _wfopen() at least in the current version (which is the only non-standard C runtime function used in this code) -- and I assume that compilers on Windows do support invoking the Windows API for MultiByteToWideChar(). LCC appeared to have missed _wfopen() in very old versions, but that was fixed in 2017.
Windows NT 4 (mid-1990's) was the first Windows version that supported Unicode filenames and the wchar_t APIs, and Windows XP (end of 2001, more than 22 years ago) was the first Windows version also targeted at consumers that supported these APIs. (I'll ignore 2000 here because it was never accepted by enough consumers to count.) I think that anybody developing a compiler that works on even somewhat modern Windows would provide access to these.
I personally therefore think the best option would be to simply guard by defined(_WIN32) and if someone then comes back and says "btw, my compiler XYZ doesn't work anymore", this could be updated to defined(_WIN32) && !defined( ... define for broken compiler ...) - instead of explicitly opting in to compilers that work, because the expectation should be that on modern Windows these APIs are simply available.
If you disagree here I can change the patch to explicitly add a whitelist for MSVC, MinGW, and clang for Windows, where I know for sure this is supported.


Fix performance of dropping large number of keys

Two simple performance fixes that allows large number of series to be actually be deleted.  The first is deleting keys in bulk.  Doing it key at a time fell over with 100k keys because it was constantly reading in the tombstone file and writing it back out one at a time.  The other issue was the WAL delete buffer growing logic was inefficient.  It was growing the dst buffer to slowly causing many small allocations.  It now doubles it each time when needed.
This could be made more efficient, but this change address the biggest perf issues currently.

+1

+1

Cherry-picked to 0.9.6


chrom : fix cargo clippy error in runtime

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

re #812

2. What is the scope of this PR (e.g. component or file name):

/kclvm/runtime
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

runtime code clean:
1. remove dead code
2. move rust code of system module to mod.rs in order to avoid use statements like base64:: base64
3. change the access permission of the unsafe function from pub to pub(crate)
4. fix other cargo clippy warnings

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[x] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.82%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2300

Relevant Lines:
2619

💛  - Coveralls


tests: Load just built engine from the output directory

Define ENGINE_DIR for all binary tests. Instead of auto-loading engine
using `example.conf' load it directly from the OUTPUT_DIRECTORY for
curves tests.

Результат hub pull-request.


Rename SimpleChannelInboundHandler.channelRead0() to messageReceived()

Motivation
Per javadoc in 4.1.x SimpleChannelInboundHandler:

Please keep in mind that channelRead0(ChannelHandlerContext, I) will be renamed to messageReceived(ChannelHandlerContext, I) in 5.0.

Modifications
Rename aforementioned method and all references/overrides.
Result
Method is renamed.

@njhill can you rebase ? I will merge it after it then

@netty-bot test this please

@njhill please fix the compile errors:
13:27:37 [INFO] Netty/Testsuite/Shading ............................ SUCCESS [  9.555 s]
13:27:37 [INFO] Netty/Testsuite/NativeImage ........................ FAILURE [  1.170 s]
13:27:37 [INFO] Netty/Transport/BlockHound/Tests ................... SKIPPED
13:27:37 [INFO] Netty/Microbench ................................... SKIPPED
13:27:37 [INFO] Netty/BOM .......................................... SKIPPED
13:27:37 [INFO] ------------------------------------------------------------------------
13:27:37 [INFO] BUILD FAILURE
13:27:37 [INFO] ------------------------------------------------------------------------
13:27:37 [INFO] Total time: 21:38 min
13:27:37 [INFO] Finished at: 2019-10-31T12:27:37Z
13:27:38 [INFO] Final Memory: 186M/2882M
13:27:38 [INFO] ------------------------------------------------------------------------
13:27:38 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project netty-testsuite-native-image: Compilation failure: Compilation failure:
13:27:38 [ERROR] /code/testsuite-native-image/src/main/java/io/netty/testsuite/svm/HttpNativeServerHandler.java:[33,7] error: HttpNativeServerHandler is not abstract and does not override abstract method messageReceived(ChannelHandlerContext,HttpObject) in SimpleChannelInboundHandler
13:27:38 [ERROR] /code/testsuite-native-image/src/main/java/io/netty/testsuite/svm/HttpNativeServerHandler.java:[43,4] error: method does not override or implement a method from a supertype
13:27:38 [ERROR] -> [Help 1]
13:27:38 [ERROR]
13:27:38 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
13:27:38 [ERROR] Re-run Maven using the -X switch to enable full debug logging.

@normanmaurer oops my bad, sorry :( Now fixed

@netty-bot test this please

@njhill thanks a lot!


[bug] Gather window moves when toggling "Show only available items"

To replicate:

have some items in the gather window that are not currently available
check "Anchor gather window to bottom left"
toggle "Show only available items" multiple times

Expected result:
the window should expand upwards and show the unavailable items, then retract and stay in its original position
Actual result:
the window expands downwards and shows the unavailable items, then retracts but its position shifts downwards

"multiple times"?
It repositions on the next frame, if you somehow toggle it multiple times in one frame (is that even possible?) you're bound to break it.

Multiple times but not in the same frame. just keep toggling it, doesn't need to be fast

Just tried this, doesn't seem to happen on my system, at least not how it's described. I've attempted with anchor to bottom left on and off and spammed show only available with both. window stays where it's at. I can see a slight flickering as though the window were trying to expand down when adding new items but it corrects itself and expands in the expected direction.

My bad. All of the items in the list must not be available, then you'll happen


fix litellm FunctionMessage

<!-- Thank you for contributing to LangChain!

Replace this entire comment with:
  - **Description:** fix litellm FunctionMessage to use langchain.schema.messages.FunctionMessage,  currently if I use funciton call with litellm, it will be raise an error that "raise ValueError(f"Got unknown type {message}")" which the message is a FunctionMessage.

Please make sure your PR is passing linting and testing before submitting. Run `make format`, `make lint` and `make test` to check this locally.

Thank you for making this PR @DumoeDss -- do you have a twitter/linkedin? Would love to give this work a shoutout in our daily changelog

Thank you for making this PR @DumoeDss -- do you have a twitter/linkedin? Would love to give this work a shoutout in our daily changelog

Yeah, I'd like to do it.
Here is my twitter: https://twitter.com/MajoSayo

believe this was already fixed in #11063


metainfo: Fix release date in the future

This was released on August, not September 2023 :)

CC @dbnicholson

It would be useful to have an extra release with this patch, but I can import it on Flathub separatedly if necessary


[FIX] Handle case where open is called before refs initialize

Hi @rayandrews,
This fix is working for me locally. I wasn't able to figure out why the ref callbacks / componentDidMount didn't fire in the order as expected.
Fixes #5

Sorry for holding it so long, there are some other stuffs that I must look into. :sweat_smile:
I will check it first, thank you :smiley:

I have already checked it and it works perfectly.
Ready to merged.
Thank you for your contribution! @awinograd

Glad the PR was useful. Thanks for checking it out and merging :)


IdP initiated logout not working

I'm using Rails 5.2 with Devise and Azure AD for SSO, Sign in process and SP initiated logout is working fine.
For IdP initiated logout, the user is not logged out of the session. The session["saml_uid"] is returning as nil and validate_signature is returning as false.
While accessing the session during LogoutRequest, facing the below issue
#<ActionDispatch::Request::Session:0x7fb410fbc388 not yet loaded>
I have the provided the below credentials for integrating Rails with Azure using omniauh-saml,
assertion_customer_service_url, idp_sso_target_url, idp_slo_target_url, idp_cert_fingerprint, issuer, slo_default_relay_state
Can you please help in getting the Rails session logged out while logging out in Azure?

Could you please provide a sample app that reproduces this issue?


Download nightly builds

Just an ability do download and install latest nightly builds. Based on #3 pr.

Works on my end! cargo clippy is complaining about a few things. Could you fix those? Once that is complete, I'll merge.

That`s was my frist try to do something in Rust Xd

Aha, really? Your first try is much better than mine. Thanks so much!!! Merged!


syntax error

I keep getting the below response when i try to run the program: Please check and let me know what i am not doing right.
root@vps:~/warp1# ./run.sh
./warpwallet_cracker.go: line 1: package: command not found
./warpwallet_cracker.go: line 3: syntax error near unexpected token newline' ./warpwallet_cracker.go: line 3: import ('

Did you build warpwallet_cracker using go build first?

When i build this is the response i get: go build warpwallet_cracker.go
warpwallet_cracker.go:5:2: cannot find package "code.google.com/p/go.crypto/pbkdf2" in any of:
/usr/lib/go/src/pkg/code.google.com/p/go.crypto/pbkdf2 (from $GOROOT)
/root/.go/src/code.google.com/p/go.crypto/pbkdf2 (from $GOPATH)
warpwallet_cracker.go:4:9: cannot find package "code.google.com/p/go.crypto/scrypt" in any of:
/usr/lib/go/src/pkg/code.google.com/p/go.crypto/scrypt (from $GOROOT)
/root/.go/src/code.google.com/p/go.crypto/scrypt (from $GOPATH)
root@vps:~/warp1# go build warpwallet_cracker.go
warpwallet_cracker.go:4:3: cannot find package "github.com/ctz/go-fastpbkdf2" in any of:
/usr/lib/go/src/pkg/github.com/ctz/go-fastpbkdf2 (from $GOROOT)
/root/.go/src/github.com/ctz/go-fastpbkdf2 (from $GOPATH)
and below is the response i get when i run:
./warpwallet_cracker 1MkupVKiCik9iyfnLrJoZLx9RH4rkF3hnA<EMAIL_ADDRESS>bash: ./warpwallet_cracker: No such file or directory

I have resolved the issue. I run: go get github.com/ctz/go-fastpbkdf2 and it was fixed. Its working now.
Thanks


Handle undefined fields on revisions in streamfield migrations

Fixes #12408

Any update on this? It's blocking out migrations. Thanks

@apokaikun in the interim, an acceptable workaround may be to set your migrations to exclude revisions that don't include the offending field, using the revisions_from parameter, which accepts a datetime object.


Make sure findOne throws if no elements are found

If you have the following code:
// in this case, `findOne` couldn't find any elements with `displayName: 'some name'`
PAGE.elements.findOne({ displayName: 'some name' }).anotherElement.click()

it throws with not very helpful message: Cannot read property 'anotherElement' of undefined.
This change adds a more helpful error: Expected at most one result from 'findOne' query in 'elements' collection.
cc @NicholasMohr

@pzuraq easy review, I've already approved but I don't have write access, so either giving me write access or reviewing the PR are easy steps to make this PR go away 😄

@pzuraq bump, only you can save us!

@pzuraq easy review, I've already approved but I don't have write access, so either giving me write access or reviewing the PR are easy steps to make this PR go away 😄

Added you as a collaborator, @twokul should already be one. Feel free to merge/release as you guys need, I'm not able to help out with this lib unfortunately at the moment, happy to transfer it if you want it to be on the Addepar github org too

ok thanks very much, wasn't aware @twokul was one, will let you know if we decide to transfer it!


TLS / SSL certificates not working for docker?

Hi,
I have difficulties using the API for a google server which is running litd in a docker in intergrated mode
here is the configured lit.conf:
# Application Options
httpslisten=<IP_ADDRESS>:8443
uipassword=***
tlscertpath=~/.lit/tls.cert
tlskeypath=~/.lit/tls.key
lnd-mode=integrated
network=mainnet

# Lnd
lnd.lnddir=~/.lnd
lnd.alias=BitNet
lnd.rpclisten=<IP_ADDRESS>:10009
lnd.listen=<IP_ADDRESS>:9735
lnd.debuglevel=info

# Lnd - bitcoin
lnd.bitcoin.node=neutrino
lnd.feeurl = https://nodes.lightning.computer/fees/v1/btc-fee-estimates.json

# Lnd - Unlock Wallet once created
lnd.wallet-unlock-allow-create=true
lnd.wallet-unlock-password-file=~/.lit/wallet_password

# Lnd - bitcoind
#lnd.bitcoind.rpchost=localhost
#lnd.bitcoind.rpcuser=testnetuser
#lnd.bitcoind.rpcpass=testnetpw
lnd.bitcoind.zmqpubrawblock=localhost:28332
lnd.bitcoind.zmqpubrawtx=localhost:28333

...

When trying to call the api with
response = requests.get(url, headers=headers, verify=TLS_PATH)

I always get this error:
ubuntu@ubuntu:~/Desktop/authentication$ /bin/python3 /home/ubuntu/Desktop/authentication/pythonfunctions/taproot_assets/listassets.py
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 699, in urlopen
    httplib_response = self._make_request(
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 382, in _make_request
    self._validate_conn(conn)
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 1012, in _validate_conn
    conn.connect()
  File "/usr/lib/python3/dist-packages/urllib3/connection.py", line 411, in connect
    self.sock = ssl_wrap_socket(
  File "/usr/lib/python3/dist-packages/urllib3/util/ssl_.py", line 449, in ssl_wrap_socket
    ssl_sock = _ssl_wrap_socket_impl(
  File "/usr/lib/python3/dist-packages/urllib3/util/ssl_.py", line 493, in _ssl_wrap_socket_impl
    return ssl_context.wrap_socket(sock, server_hostname=server_hostname)
  File "/usr/lib/python3.10/ssl.py", line 513, in wrap_socket
    return self.sslsocket_class._create(
  File "/usr/lib/python3.10/ssl.py", line 1100, in _create
    self.do_handshake()
  File "/usr/lib/python3.10/ssl.py", line 1371, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get issuer certificate (_ssl.c:1007)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/requests/adapters.py", line 439, in send
    resp = conn.urlopen(
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 755, in urlopen
    retries = retries.increment(
  File "/usr/lib/python3/dist-packages/urllib3/util/retry.py", line 574, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='mybitnet.com', port=8443): Max retries exceeded with url: /v1/taproot-assets/assets (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get issuer certificate (_ssl.c:1007)')))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ubuntu/Desktop/authentication/pythonfunctions/taproot_assets/listassets.py", line 19, in <module>
    response = requests.get(url, headers=headers, verify=TLS_PATH)
  File "/usr/lib/python3/dist-packages/requests/api.py", line 76, in get
    return request('get', url, params=params, **kwargs)
  File "/usr/lib/python3/dist-packages/requests/api.py", line 61, in request
    return session.request(method=method, url=url, **kwargs)
  File "/usr/lib/python3/dist-packages/requests/sessions.py", line 544, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/lib/python3/dist-packages/requests/sessions.py", line 657, in send
    r = adapter.send(request, **kwargs)
  File "/usr/lib/python3/dist-packages/requests/adapters.py", line 514, in send
    raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='mybitnet.com', port=8443): Max retries exceeded with url: /v1/taproot-assets/assets (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get issuer certificate (_ssl.c:1007)')))

However I checked multiple times the TLS_PATH seems to be correct and the the fullchain.pem file generated by certbot also is correct.
I'm pretty sure I've set up ssl correctly on the dockermaschine (certbot standalone setup in which I created the certificates on the server and then copied them into the litd docker while creating it)
Here is the command I've used creating my docker:
sudo docker run -d \
  -v ~/Desktop/wallet_password:/root/.lit/wallet_password \
  -v ~/Desktop/lit.conf:/root/.lit/lit.conf \
  -v /etc/letsencrypt/live/mybitnet.com/fullchain.pem:/root/.lit/tls.cert \
  -v /etc/letsencrypt/live/mybitnet.com/privkey.pem:/root/.lit/tls.key \
  -p 8443:8443/tcp \
  -p 9735:9735/tcp \
  -p 10009:10009/tcp \
  lightninglabs/lightning-terminal:v0.12.2-alpha --enablerest

Just in case the issue would be on my client side I tried this command and it seems to work fine. I've even manually installed the X1 certificate for my client mutltiple times.
ubuntu@ubuntu:~$ openssl s_client -connect mybitnet.com:8443 -showcerts
CONNECTED(00000003)
depth=2 C = US, O = Internet Security Research Group, CN = ISRG Root X1
verify return:1
depth=1 C = US, O = Let's Encrypt, CN = R3
verify return:1
depth=0 CN = mybitnet.com
verify return:1
---
Certificate chain
 0 s:CN = mybitnet.com
   i:C = US, O = Let's Encrypt, CN = R3
   a:PKEY: rsaEncryption, 2048 (bit); sigalg: RSA-SHA256
   v:NotBefore: Jan 24 17:15:42 2024 GMT; NotAfter: Apr 23 17:15:41 2024 GMT
-----BEGIN CERTIFICATE-----
...
-----END CERTIFICATE-----
 1 s:C = US, O = Let's Encrypt, CN = R3
   i:C = US, O = Internet Security Research Group, CN = ISRG Root X1
   a:PKEY: rsaEncryption, 2048 (bit); sigalg: RSA-SHA256
   v:NotBefore: Sep  4 00:00:00 2020 GMT; NotAfter: Sep 15 16:00:00 2025 GMT
-----BEGIN CERTIFICATE-----
...
-----END CERTIFICATE-----
 2 s:C = US, O = Internet Security Research Group, CN = ISRG Root X1
   i:O = Digital Signature Trust Co., CN = DST Root CA X3
   a:PKEY: rsaEncryption, 4096 (bit); sigalg: RSA-SHA256
   v:NotBefore: Jan 20 19:14:03 2021 GMT; NotAfter: Sep 30 18:14:03 2024 GMT
-----BEGIN CERTIFICATE-----
...
-----END CERTIFICATE-----
---
Server certificate
subject=CN = mybitnet.com
issuer=C = US, O = Let's Encrypt, CN = R3
---
No client certificate CA names sent
Peer signing digest: SHA256
Peer signature type: RSA-PSS
Server Temp Key: X25519, 253 bits
---
SSL handshake has read 4491 bytes and written 378 bytes
Verification: OK
---

Please, I would be happy about any form or sort of help since I really dont know how to proceed
ps: this is supposed to go production so simply putting verify=False when calling the API is no option for me
Do I need to configure anything additional in my docker?

It looks like on the lightning terminal side everything works fine. I'm able to open the page in my browser. So I think our python code might be wrong? Are you supplying the system's CA certificates that include the ISRG Root X1 root certificate?

It looks like on the lightning terminal side everything works fine. I'm able to open the page in my browser. So I think our python code might be wrong? Are you supplying the system's CA certificates that include the ISRG Root X1 root certificate?

I did supply it I still wonder if theres something wrong with my system I tried using certifi package from python and now and it works. I guess it seems to be a local issue on my maschine then.
I guess we can close the ticket I'll reopen if I find a bigger issue.

import certifi
....
r = requests.post(url, headers=headers, stream=True, data=json.dumps(data), verify=certifi.where())


Use dialog to warn users about lack of upload permissions

Feature Description
This is a follow up to #1372, specifically https://github.com/google/web-stories-wp/issues/1372#issuecomment-642446562
As per the design at https://www.figma.com/file/Cd9iacVknHK62RO4pRwb68/Stories-Editor?node-id=9631%3A10:
If as user does not have capabilities to upload media, display a dialog saying "You don't have access to upload media. Check with your administrator to request access."
Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

If as user does not have capabilities to upload media, display a dialog saying "You don't have access to upload media. Check with your administrator to request access."

Implementation Brief

I will take a look and pick up this issue.

Verified in QA


How to release editor correctly?

Describe the bug
Editor does not clean its memory and some data structures are blocked repeatable open in the same window:
Open editor in div:

Then close div, destroy all release all data structures with link the div content and open again:

Exactly the same open - but editor does not load itself. It is necessary to release window object to work it again.
In a summary: editor cannot open twice in the same window if placed to the box that has style 100% width, height. But when placed without mac size. it works repeatedly:
Opened in the tab field with max height:

Works repeatedly.
To Reproduce
Steps to reproduce the behavior:

Open editor by java script in div with 100% size
Close div
Open again

BTW, when placed within a table, it behaves better - but it has relation with the former report.
Desktop (please complete the following information):
any windows browser, mobile not tested

After hours of testing we have found that editor does not work on page that change size of the fields behind the editor. It works in case that size is changed automatically (flexibox) so we have redesign page to have only fix-size boxes in flexibox and fix max size of the field in which editor is placed. With such settings it looks working good.
Nevertheless, it would be better, if editor withstands size changes.


Get Changes from "Manual" Logging

Its possible to implement the function to get the changes in a Model, using manual logging?
Making the default "manual" logging:
activity()
->performedOn($anEloquentModel)
->causedBy($user)
->log('Look, I logged something');
And then getting with:
$myactivity->changes()
To make something (example) like this:

User DEFAULT user changes in the model. Changes:
From:
Title:  OLD | Status: 0
To:
Title: NEW | Status: 1

Can't you do something like
$anEloquentModel = Model::find(1);

$anEloquentModelBeforeChanges = $anEloquentModel->toArray(); // <<< make a toArray to have to old model unchanged on this variable

$anEloquentModel->property = true; // <<< change whatever you want
$anEloquentModel->save()

$anEloquentModelAfterChanges = $anEloquentModel->toArray();

This was you have two arrays with before and after properties of the model.

Well, maybe it can. But its more a "hacky" way, what i propose its a package functionality to make things better.
For example:
In my blade template:
@foreach ($activities->changes() as activity)
OLD: {!! $activity->old_value !!}
NEW: {!! $activity->new_value !!}
@endforeach
Or something like that. The Package handles the comparations of the two arrays.

That would not work, because changes() returns a collection of before and after of any given model.
You could easily do something like this in your Blade
array_diff( json_decode($activity->changes(), true)['old'] , json_decode($activity->changes(), true)['attributes'] )
That will get you an array of changes, since changes has a before and after.


markdownlint

Description and Motivation
We have a spate of linter issues for markdownlint and this will resolve them.
Related Issues

Checklist:

[ ] I have read Migaloo's contribution guidelines.
[ ] My pull request has a sound title and description (not something vague like Update index.md)
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation.
[ ] The code is formatted properly golangci-lint run ./... --fix.

note: 930 flags as of this


Item Refactor

Changes to Item
Use separate tables, not STI

[ ] Create a CanonicalItem type that will be replicated into Item on Org creation
[ ] Create a method that automates the replication (no overwrites, but no direct duplicates)
[ ] If possible, integrate existing Item records to work with CanonicalItem
[ ] Add a universal "key" to CanonicalItem that can be used to universally identify a diaper type. The key should be programmatically generated and idempotent.
[ ] Administrative users can manage CanonicalItems, normal users cannot, but they can see them
[ ] Regular users can maintain their own Items, adding, modifying, deleting, etc, but any Item they add must root in a CanonicalItem (N.B. care should be taken when deleting an item that has previously been used by Donation, Distribution, etc)
[ ] Add a way to "hide" an Item when it's requested to be deleted but has prior history
[ ] Refactor "size" into a field, instead of just being in the name (so it can be filtered, etc)

Changes to BarcodeItem

[ ] Global BarcodeItems are rooted with CanonicalItem
[ ] Local BarcodeItems are rooted with Item
[ ] BarcodeItem link to Item is polymorphic

Workflow for new organization signup

New org signs up
Canonical items are replicated into regular items for the org
Org then does whatever kind of modifications they want to those items (full CRUD), adds more, deletes any that have never held inventory, etc.

TODO: Add scopes to display CanonicalItem types that have been created in last 30 days and are not currently among the item types of the current user. Display those as a notification to the signed-in user so they can opt-in if they want.


Feature: Swipe to next unread notifications

Would be super slick if you could swipe through issues to go through all the unread ones?
 or similar.

Super cool idea. Going to backlog this for now tho, might get pretty complicated 😅


The config to reproduce the latest results with improvement from Magic3D.

Hi, ashawkey, thanks for the impressive work!
In the latest readme (8d7899ae758e0f683a1cef51b876f2a37cba0c55), you show that the improvement from Magic3D can greatly boost the quality.
However, it seems that the default setting cannot generate objects with on-par quality (e.g., "a DSLR photo of a squirrel").
Would you like to show any example config or scripts that can to reproduce these results?

@ybbbbt Hi, they are run with the default config, but only using prompts like "a squirrel" (Adding "a DLSR photo of" leads to worse shape in my case). But you do need some luck to get a good result, here are my reproduction with the latest commit:
https://user-images.githubusercontent.com/25863658/216313871-9d816302-2a16-4b61-aba3-0509eee08b9e.mp4


Incompatibility between Valkyrie's precise depth buffer option and Weather mod

Describe the bug
Weather mod changes how Valkyrie's depth buffer works, and can make your hand able to go through blocks.
Weather mod:
https://www.curseforge.com/minecraft/mc-mods/weather-storms-tornadoes
Requires CoroUtil as dependency:
https://www.curseforge.com/minecraft/mc-mods/coroutil
By default settings, Weather mod just kinda disables Valkyrie's depth buffer. You can get Valkyrie's depth buffer working again by disabling Weather mod's "useEntityRenderHookForShaders" option (in config/CoroUtil/General.cfg), however this will then make your hand able to clip through blocks.
Currently you cant have both precise depth buffer from Valkyrie AND correct hand rendering at the same time, if you are using Weather mod as well.
This is all kind of a mess, but if there is a way to fix this issue from Valkyrie's side somehow, that would be very nice. Maybe if its possible to mixin to Weather mod's code and override the part where it essentially duplicates and forces usage of whatever Minecraft rendering code was lacking a depth buffer? I don't have a good understanding of how this would work, I just really think Weather mod would require depth buffer to look good, the way raindrops immediately become dark blue when over (not under) water breaks immersion a bit :[
Reproducibility

[x] I reproduced this issue with as few other mods as possible installed.
[ ] I am unable to reproduce this issue consistently.

To Reproduce
Steps to reproduce the behavior:

Install Valkyrie
Turn on depth buffer option in Valkyrie's config
Notice that depth buffer is nice TM
Install Weather mod
Notice that your hand clips through blocks now
Turn off "useEntityRenderHookForShaders" in config/CoroUtil/General.cfg
Notice that your hand no longer clips through blocks, but now Valkyrie's depth buffer option is non-functional and is doing nothing

Expected behavior
Functional depth buffer from Valkyrie, without hand clipping. And with Weather mod still installed.
Screenshots or/and videos
Clipping hand:

Not clipping hand:

(these images are taken from the exact same position and rotation)
Versions

Valkyrie: 0.2 Dev 8
Red Core: 0.4
Localized Weather & Storms: 1.12.1-2.6.12

Update: this bug actually isn't because of Valkyrie at all and "useEntityRenderHookForShaders" from Weather mod is broken whether Valkyrie is installed or not.
I reported the bug to the Weather mod GitHub a while ago but forgot to close this report until now.


SV-Create Required Resolvers

Create required resolvers for Apollo back end.

Created query resolvers and createUser and loginUser mutations. Created typedefs for all models and initial queries and mutations. New scalar for date still to be set up properly.


Enable backup tasks by default for all executors that support them

The policy for launching backup tasks for stragglers is fairly conservative, and I haven't seen any problems while using it. In fact it has occasionally kicked in to help a slow-running computation, so I think it would be good to enable it by default.

I agree, when I ran those quadratic means cases a while ago it seemed to only ever improve things.


Create an Admin for the Data Loading Management Command

Problem
We need an front end for for the data loading management command
Proposed Solution
We can use django admin or a fronted form that need some inputs:

A json concept mapping document
A csv delimited file with health sites data
The name of the origin organisation
A checkbox to indicate whether previous records should be replaced or update

Suggestion from @timlinux for point 4 : to use a combination of the location (with some fuzzy match) and the origin organisation to determine whether records are the same.
Sample data:
https://github.com/konektaz/healthsites/wiki/Rwanda-data
Expected Result
The admin page allow Mark (and eventually registered users) to easily upload new data into the database.

I made a simple mock up for the data loader UI

Link to moqups: https://moqups.com/tim@kartoza.com/S6i82SXi/p:a148562f1
Which one is better? Put it as in side panel or as a modal?

I think the modal works well. However, I think it's useful to be able to share the URL of the 'functionality'. So maybe the modal window could pop-up out of the dedicated /healthsites-dataloader/ page..?

That looks spot on thanks @ismailsunni Lets go with the modal option for now. @markherringer I think this should be for admins only so we should not mainstream it to end users.

As an administrator I need a way to find the Rwanda data easily. How do we identify the locations in the database that fall within Rwanda? Do we query the Rwanda shapefile?


"Finalize" button shows warning if NO participants where marked as present in the meeting

[ ] If no participants selected on finalize show a new(!) warning message:
"No invited user is checked as participant of this meeting.
Are you sure, you want to finalize the meeting?" [No/Yes]

[ ] Use existing confirmation dialog box infrastructure for this
client/helpers/confirmationDialogFactory.js

[ ] 3 E2E test (3 scenarios)

Team Estimation: 1d


[Public Catalog] Crazy egg running multiple userscripts

We are seeing an error when loading the crazy egg script on production. We should look into this and resolve it.
Uncaught Error: CE: multiple userscripts installed
    <anonymous> https://script.crazyegg.com/pages/scripts/0045/9836.js:1

Additional context

This script is set in the DevSetSEO.js component.

This issue was originally a part of this ticket.

According to the Crazygg docs, they suppress multiple scripts from running, so it will not interfere with our data collection.

Acceptance Criteria

[ ] Determine the cause and remove the error.

smells like sustaining to me. so I added it our upcoming sustainment epic. 🧀


yo neptun:react does not create the expected gitignore

It only contains two lines:
node_modules
coverage

it comes from the generator-node: https://github.com/yeoman/generator-node/blob/master/generators/git/templates/gitignore


Support cabal-fmt for Haskell-Cabal mode

Depends on https://github.com/lassik/emacs-language-id/pull/3

Perfect. Thank you!


[Feature] Controller shortcut to open the System Menu (a.k.a. "Three Dots" Menu)

I'm using:

Device: Shield TV
OS: Android TV
Browser: Kiwi Browser

I want to suggest this feature:
If you might add more controller shortcuts in the future, I would be very happy about a shortcut that will show/hide that menu behind the three dots. This would be very useful especially on Android TV, so you don't have to use a mouse to open it.
With a shortcut I would be able to have a quick look at the streaming badges. And would also be able to use the Quit button there to exit games. So in my opinion this would really improve the usability for Android TV users.

With that upcoming UI change ...
https://github.com/redphx/better-xcloud/issues/98#issuecomment-1868288677
... it will become less relevant to have a shortcut for the "three dot menu".
Instead it would be more useful now to be able to hide/show the HUD bar and interact with it with the controller and/or remote. Like this you would also be able to get to the "three dot menu", so there would be no need for an extra shortcut.
On the GFN app on Android TV it's possible to show/hide their HUD bar by holding the Start button. And when it's visible, you can interact with it using your controller. It would be great if this would also be possible when using "Better xCloud".

To my surprise this already works with the WebView based Android app.
When I press the up key on my remote, the hud bar indicator gets a visual highlight (also works if it was hidden before):

And when I press OK, the hud bar will open. And then I can use my remote to move from right to left and e.g. enable the stream stats or go to the three dot menu. Yeah. =)

But I hoped that I would be able to use the refresh stream option by long pressing the red exit button. But unfortunately I can’t long press the button with the remote. It’s always recognized as a short press and shows the prompt if I want to exit the game.
So maybe you could add a separate refresh button in the three dot menu? This way I could also use the option on Android TV. And the feature would also be more visible in general for all users.
But as interacting with the HUD bar now works with the Android app, I will close that feature request.


icons disappear after update to v.1.1.13

After update to v.1.1.13 all my icons disappear. Buttons are there but icons are not visible

I figure it out. There is issue to load "ion" icons, please to fix this

Oh I'm sorry to hear that! @ericcornelissen can you look into this?

#265 is one fix for this. It just adds md- to any ion icon that isn't prefixed with ios- or md-

also
[not a tool-bar bug]
if md- does not do the trick
ion has changed some iconnames

true. The best solution might just be telling people to make sure they are using the new icon names.

Oh I'm sorry to hear that! ericcornelissen can you look into this?

Ah yes, my apologies, I was unaware of the notable differences between the old and new version (should have checked :sweat_smile: again, my apologies). @UziTech's solution is definitely a good starter, though, as @petKitsune points out, it might not work for all icons as some names have changed. The only solution to that, I can think of at least, is to indeed tell people they may have to change some of the names (I don't think it is feasible to provide backwards compatibility in this package).
Alternatively you may consider reverting the change in v1.1.14 and releasing the new icons with v2.0.0 or v1.2.0 to signal breaking changes.

There is issue to load "ion" icons

Not sure what this means, Atom should have no problem finding the font as there is a test for that.

You're right, we can't have backward compatibility here. Ionicons now offer iOS and Material style icons and the users should be able to select which one they prefer.
I unpublished 1.1.13 and published those changes as 1.2.0 with a warning.
We'll just have to inform any affected users about this change (I don't think there's a way to do it in an automated fashion).
Thank you all for quickly jumping on this!

I'm getting this on 1.20

@AriMKatz check #268 for more details on how to resolve this issue. If you still have questions you can ask it there 😉

Where in the code do I add md- for getting the icons back?

The code might be part of another package.

Thanks, @ericcornelissen, It was a late night and I misread the thread, sorry for the noise.

Thanks, @ericcornelissen, It was a late night and I misread the thread, sorry for the noise.

Not a problem :wink: I'm happy to help.

Where in the code do I add md- for getting the icons back?

@PernilleF, As @UziTech said it might be another package, are you using any other packages with tool-bar (for example one of the ones listed here)? It might be possible to edit the configuration file for the toolbar yourself, in that case open the command pallete (Ctrl+Shift+P by default) and type something along the lines of "toolbar config file" and see if there is an option to edit it. Otherwise you will need to open an issue in the respective toolbar plugins (if there isn't already).

Adding ios- or md- doesn't help. My toolbar doesn't load at all. What should I do?
This is my package:
https://github.com/aminya/juno-toolbar-plus

My toolbar doesn't load at all. What should I do?

If the toolbar doesn't load at all there is probably a different issue 🤔 Do you see any errors in the developer tools of Atom (Ctrl+Shift+i or View -> Developer -> Toggle Developer Tools)?
If it is just a few icons that is missing, then I advice you to look at the Ionicons documentation and see if the icon still exists under the same name.
Hope that helps @aminya 🙂

@ericcornelissen I fixed the problem in the last version. The name of the icons was the issue causing the toolbar not to appear.


modules/rpm: trivial style fixes

Signed-off-by: Igor Gnatenko<EMAIL_ADDRESS>

@jpakkane merge this, because it's trivial (style fixes) and need no tests


Calculate score per word

This version determines a score per word based on the relative frequency of the suggested letters in a word.
The score is then used to rank the output.

Marc, this is so cool! I like the SCORE-feature! Thank you for adding it!
Unfortunately I'm on a 7.31 system which doesn't support the VALUE statement :-(
I'll merge your pull request later today.
I also have to install the free ABAP version now so I can run your enhanced version. That will take a weekend. With a little bit of luck this weekend. My first repo on Github and even a pull request! I like this ABAPGit thing :-)

no worry, i will change the syntax so 7.0x so everyone can use it :-)

a little note: putting the "last changed" date into the code doesn't work well. you can remove it since you can always check on GH who changed what when.


feat(datahub-upgrade): adding concurrency policy for the cronjobs

Context
By default, the concurrency policy for the cronjobs is Allow. In a few deployment strategies, concurrencyPolicy is defaulted to Forbid. In those scenarios, the upstream chart should have the option for it to be set.
This PR will help in accomplishing that.
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

I though you might have missed it here but it was taken care already.

Good if you can update corresponding README files and chart versions.

@upendra-vedullapalli I can update. Let me take a look.

@upendra-vedullapalli I see that there is no dependency chart in datahub/datahub/Chart.yaml for the datahub upgrade job where I can bump the version. So I presume, it is not required. Please let me know if its not the case.

LGTM. Probably you need a maintainers approval for merge 🤞

How do I get that privilege?

Thanks for the contribution! 😄


Ability to run isar on background Isolates/Web Workers

Is your feature request related to a problem? Please describe.
isar throws exceptions when run on a background thread due to the use of dart:ui
Describe the solution you'd like
I'm creating a parser to process very large files.  The parser needs to be multi-threaded (multi-isolate on native platforms, multi-web worker on web.  I'd like to be able to add objects to the ISAR DB in a background isolate/web worker.  I'm using the Squadron package (version 3.3) to do the common interface to isolate/web worker.  Any calls to isar when on the background web worker causes an exception to be thrown.  It appears isar is using dart:ui and you can't do ui stuff when not on the primary thread.
Describe alternatives you've considered
The only available alternative is to pass data from the background web worker to the main isolate and then add the data to isar from the main isolate.  The issue with this is that I'm dealing with 100's of MB files/objects and there's a large overhead to do the transfer of objects from web worker to the main thread.
Version

Platform: all
Flutter version: 2.10.4
Isar version: 2.2.1

It should work in isolates. Isn't dart:ui available in isolates?
Web workers are unsupported in Flutter unfortunately :(

Correct, it works in isolates.  Web worker is what I'm looking for.  I'm using a package called Squadron 3.3 which does support web workers and it's working great.  I am able to run true multi-platform with isolates on native platforms and web workers on web (with a common interface) and it works great.  The part of the code that is the threaded code, I just have to dart compile js ..., and load that js.  I just have to be cautious about data types crossing boundaries; but it works great.
Now, I did do a test of isar on web (without any web workers), and a .where().findAll() of 100,000 entries took 31 minutes.  So, I can't use isar for now, since I need support for 10 million+ entries.
But, support for web workers is definitely an option and works great.  Take a look at Squadron

Unfortunately, IndexedDB is quite slow for huge amounts of data. Especially on Chrome. Not much we can do to improve it unfortunately. IndexedDB is the only real cross platform database backend on web...

squadron looks really cool! I need to check it out in detail

Hello there,  yes, Squadron is awesome.
For reference, In the repository of Hive package they are discussing a solution about how to run Hive on web workers https://github.com/hivedb/hive/issues/939

Unfortunately I don't expect big performance improvements because Isar is not the bottleneck.
IndexedDB is really slow for > 10-50k entries and web workers don't help much.

Hello,
I believe Isar can be made to run in Web Workers, with little effort. Main problem is in web/open.dart where access to the DOM is assumed, as well as in the isar-web library where it's using window instead of self. I have tried with this (+ the attached fixed library that I have placed in the test folder). But then it crashed in isar_impl.dart because of the reference to DomException (it comes from dart:ui). I haven't looked further. I shall create a fork and post my changes but there aren't enough hours in one day!
Future<void> initializeIsarWebFromWindow() async {
  ScriptElement script = ScriptElement();
  script.type = 'text/javascript';
  script.src =<EMAIL_ADDRESS>  script.async = true;
  assert(document.head != null);
  document.head!.append(script);
  await script.onLoad.first.timeout(Duration(seconds: 30), onTimeout: () {
    throw IsarError('Failed to load Isar');
  });
}

Future initializeIsarWebFromWorker() async {
  try {
    // >>> testing
    DedicatedWorkerGlobalScope.instance.postMessage('Loading Isar-Web...');
    final script = await HttpRequest.getString('isar-web-fixed.js');
    DedicatedWorkerGlobalScope.instance.postMessage('Isar-Web found, length = ${script.length}');
    WorkerGlobalScope.instance.importScripts('isar-web-fixed.js');
    DedicatedWorkerGlobalScope.instance.postMessage('Isar-Web is ready!');
    // <<< testing
    // >>> intended final version:
    // WorkerGlobalScope.instance.importScripts('https://unpkg.com/isar@$isarWebVersion/dist/index.js');
  } catch (ex) {
    DedicatedWorkerGlobalScope.instance.postMessage('failed to load Isar-Web');
    throw IsarError('Failed to load Isar-Web');
  }
}

var _loaded = false;
Future<void> initializeIsarWeb() async {
  if (_loaded) return;
  _loaded = true;

  try {
    await initializeIsarWebFromWindow();
  } catch (ex) {
    await initializeIsarWebFromWorker();
  }
}

isar-web-fixed.zip

Correct, it works in isolates. Web worker is what I'm looking for. I'm using a package called Squadron 3.3 which does support web workers and it's working great. I am able to run true multi-platform with isolates on native platforms and web workers on web (with a common interface) and it works great. The part of the code that is the threaded code, I just have to dart compile js ..., and load that js. I just have to be cautious about data types crossing boundaries; but it works great.
Now, I did do a test of isar on web (without any web workers), and a .where().findAll() of 100,000 entries took 31 minutes. So, I can't use isar for now, since I need support for 10 million+ entries.
But, support for web workers is definitely an option and works great. Take a look at Squadron

Hello, Did you also test with that amount of data in native isolation? How long did it take? I use hive with a lot of data in native isolation and wanted to know that Isar is faster than Hive.
I also have memory leak issues with Hive as I have to leave the box open in the isolate to improve response speed.
Thank you.

How long did it take? I use hive with a lot of data in native isolation and wanted to know that Isar is faster than Hive.
I also have memory leak issues with Hive as I have to leave the box open in the isolate to improve response speed.

Native Isar is MUCH faster than IndexedDB and Hive. Querying 100k entries should be well below a second (using an index probably around 50ms)
Hive does not have memory leaks it just can't share memory across isolates. Isar does not have this limitation.

Unfortunately I don't expect big performance improvements because Isar is not the bottleneck.
IndexedDB is really slow for > 10-50k entries and web workers don't help much.

The main goal of running Isar in Isolate/webworker for me isn't performance, but release main thread from getting stuck loading heavy tasks. I don't mind if it takes more seconds to process If I achieve a stable fps rate.

The main goal of running Isar in Isolate/webworker for me isn't performance, but release main thread from getting stuck loading heavy tasks.

Did you experience that using Isar? Indexeddb runs in a background thread and Isar itself is extremely lightweight. I'd have to see an example where that actually happens

Did you experience that using Isar? Indexeddb runs in a background thread and Isar itself is extremely lightweight. I'd have to see an example where that actually happens.
I haven't tested it yet, but @martin-robert-fink did, <<Now, I did do a test of isar on web (without any web workers), and a .where().findAll() of 100,000 entries took 31 minutes. So, I can't use isar for now, since I need support for 10 million+ entries.>>

I known fetching 100k items and retrieving is a lot maybe, but my use case is to retrieve those 100k items in webworker and only give the main thread some of those items, already processed.

And Isar already supports background Isolates
But not in webworkers, maybe @d-markey gave some ideas in his previous comment.

I known fetching 100k items and retrieving is a lot maybe, but my use case is to retrieve those 100k items in webworker and only give the main thread some of those items, already processed.

Like I said, Isar is not the bottleneck here, IndexedDB is. And to my knowledge it doesn't get any faster if you access it from a web worker. If you have different information or maybe even a benchmark, I'll work on web worker support. But until then I just see no point in implementing it 🤷🏼♂

Hello,
actually it's a tad more complicated. Dart libraries also reference the "window" object eg. in https://github.com/dart-lang/sdk/blob/main/sdk/lib/html/html_common/device.dart and that's not available in Web workers. It seems the scope of changes goes beyond just isar and isar-web!

I'm going to close this for now since it won't benefit the performance. We might be able to revisit this when Dart supports WASM.


Error in pinterest handler

If the pinistrify function, handlePinterestEmbed makes this check:
https://github.com/shobhitsharma/embedo/blob/46c7821397088d3e0c6e956ed3e0e562223938eb/embedo.js#L1593
pinterest_embed_timer is an interval ID, so you'll always get an error, even if the embed is successful, if the ID pool is over 100 (pretty common, especially in SPA).
I'm not sure what this is supposed to be checking, but even if you use a counter here instead, 100 * 250ms (25 seconds) seems too long. Something like 20, or 5s total, would be more reasonable.
Also, I'm reasonably certain that the setInterval call here:
https://github.com/shobhitsharma/embedo/blob/46c7821397088d3e0c6e956ed3e0e562223938eb/embedo.js#L1578
should be inside the setTimeout after the if block containing the PinUtils.build call:
https://github.com/shobhitsharma/embedo/blob/46c7821397088d3e0c6e956ed3e0e562223938eb/embedo.js#L1580-L1584
(after line 1583)
My changes here https://github.com/nborko/embedo/blob/865fcbe1da62467a333d31838541c39861294c48/embedo.js#L1578-L1598 work for me, please let me know if you'd like a PR.
thanks,
Nick

@nborko Hi Nick, thanks for the issue and PR mate. I checked and merged it. Looks fine now.


Sapphires

User Story
#US5_Project Creation
Project List API

[N/A ] Bug fix (non-breaking change which fixes an issue)
[Yes ] New feature (non-breaking change which adds functionality)
[N/A ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[N/A ] This change requires a documentation update

Now the project will be created and displayed and  on both taiga and scrum board project

Merging the pull request after approval


typed descriptors and setup.py only includes pandera

Fixes #738 and #737

thanks @cristianmatache! would you mind fixing the lint errors?


Remove service env vars

Small question: How will these env vars be set when the app is deployed?

@gastaldi you'll need a Catapult pod installed in the same project as well. Then they will just be available automatically.

ok cool


Compilation against .NET5

I cannot use this because my company prohibits me from using .NET 5 assemblies because of the the security related issues with that version of the framework.
Any plans to produce an updated version ?
Also, it's an unsupported version of the .NET framework.
// Microsoft.Azure.Functions.Worker.dll
// Microsoft.Azure.Functions.Worker, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=551316b6919f366c

[assembly: TargetFramework(".NETCoreApp,Version=v5.0", FrameworkDisplayName = ".NET 5.0")]
[assembly: AssemblyCompany("Microsoft")]
[assembly: AssemblyConfiguration("Release")]
[assembly: AssemblyCopyright("© Microsoft Corporation. All rights reserved.")]
[assembly: AssemblyDescription("This library enables you to create an Azure Functions .NET Worker, adding support for the isolated, out-of-process execution model.")]
[assembly: AssemblyFileVersion("<IP_ADDRESS>")]

@rangers-bnc .NET 6 and 7 are supported, you ultimately control the TFM in your .csproj file. Just set <TargetFramework>net6.0</TargetFramework>.
When you target .net6.0 yourself, all base class libraries loaded will also be .net6.0, so even if our projects say <TargetFramework>net5.0</TargetFramework> they will ultimately be binding to .net6.0 at runtime, and thus all the security fixes are brought in.

Many project support .net5, .net6, net7.0; there is a good reason for that.

The reasoning for this is either they want access to new features from the later releases, or they do it for consistency and their own benefit. In the dotnet repo cases, I would say they do this for consistency and to dogfood their own changes. There is no requirement for a library to support later runtimes unless they need features from that runtime. In fact, it is recommended for libraries to reference the lowest possible runtime possible that meets your feature needs - this lets you reach the broadest set of customers possible. In our case, the function app you write - your .csproj - is what controls the runtime. Our libraries being built against net5.0 will not bring in net5,0 runtime unless you also target net5.0.

Plus the compiler issueing OWASP warnings that the project references and uses .NET 5.0 assemblies.

Which project does that warn about?
Take a look at the net7 worker sample: https://github.com/Azure/azure-functions-dotnet-worker/blob/main/samples/Net7Worker/Net7Worker.csproj - this project targets .net7 - so at runtime .net7 will be used, regardless of what the dependencies are declare.

Then how to explain this?
9>
9>C:\Users\Robert\.nuget\packages\system.diagnostics.diagnosticsource\7.0.0\buildTransitive\netcoreapp2.0\System.Diagnostics.DiagnosticSource.targets(4,5): warning : System.Diagnostics.DiagnosticSource 7.0.0 doesn't support net5.0 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
9>    1 Warning(s)
9>    0 Error(s)
9>

    <TargetFrameworks>netstandard2.0;net5.0;net6.0;net7.0</TargetFrameworks>

  <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
    <PackageReference Include="Microsoft.Extensions.Hosting" Version="5.0.0" />
  </ItemGroup>
  <ItemGroup Condition="'$(TargetFramework)' == 'net5.0'">
    <PackageReference Include="Microsoft.Extensions.Hosting" Version="5.0.0" />
  </ItemGroup>
  <ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
    <PackageReference Include="Microsoft.Extensions.Hosting" Version="6.0.0" />
  </ItemGroup>

  <ItemGroup Condition="'$(TargetFramework)' == 'net7.0'">
    <PackageReference Include="Microsoft.Extensions.Hosting" Version="7.0.0" />
  </ItemGroup>

@bobbyangers Microsoft.Extensions.Hosting/5.0.0 is not equal to .net5.0 - it just happens the dotnet team versions them together. You can have Microsoft.Extensions.Hosting/5.0.0 in .net7, and you can also have Microsoft.Extensions.Hosting/7.0.0 on .net5. They are not bound together.
You are free to pin to a higher version of that package yourself in your csproj by adding:
<PackageReference Include="Microsoft.Extensions.Hosting" Version="7.0.0" />

This happens simply compiling this project.
1>    Target NETStandardCompatError_System_Diagnostics_DiagnosticSource_net6_0:
1>        C:\Users\Robert\.nuget\packages\system.diagnostics.diagnosticsource\7.0.0\buildTransitive\netcoreapp2.0\System.Diagnostics.DiagnosticSource.targets(4,5): warning : System.Diagnostics.DiagnosticSource 7.0.0 doesn't support net5.0 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
1>    Done building target "NETStandardCompatError_System_Diagnostics_DiagnosticSource_net6_0" in project "DotNetWorker.Core.csproj".
2>Build started 2023-05-03 4:17:17 PM.

This discussion is about end users' dependency on .net5.0, which is not the same as what our own project builds with. Yes, we have dependencies on .net5.0 that raise warnings on build of our own project. But this is not transitive to customers (potentially unless they also target net5.0).
As for what Checkmarx flags, I don't know - I do not use it. It is odd for it to flag a transitive dependency to that platform, as the platform is determined by the final projects TFM - not what package references were built against. Also remember that Microsoft.Extensions.* is not the platform or runtime. These are NuGet packages shipped separately from the .net runtime.

This happens simply compiling this project.

1>    Target NETStandardCompatError_System_Diagnostics_DiagnosticSource_net6_0:

1>        C:\Users\Robert.nuget\packages\system.diagnostics.diagnosticsource\7.0.0\buildTransitive\netcoreapp2.0\System.Diagnostics.DiagnosticSource.targets(4,5): warning : System.Diagnostics.DiagnosticSource 7.0.0 doesn't support net5.0 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set true in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.

1>    Done building target "NETStandardCompatError_System_Diagnostics_DiagnosticSource_net6_0" in project "DotNetWorker.Core.csproj".

2>Build started 2023-05-03 4:17:17 PM.

This discussion is about end users' dependency on .net5.0, which is not the same as what our own project builds with. Yes, we have dependencies on .net5.0 that raise warnings on build of our own project. But this is not transitive to customers (potentially unless they also target net5.0).
As for what Checkmarx flags, I don't know - I do not use it. It is odd for it to flag a transitive dependency to that platform, as the platform is determined by the final projects TFM - not what package references were built against. Also remember that Microsoft.Extensions.* is not the platform or runtime. These are NuGet packages shipped separately from the .net runtime.

@jviau At the end of the day, I do understand that the runtime itself doesn'nt end up at calling project.  The problem is referencing dll that are old, compiled against older runtime, doean't garanty compatibility.
To ensure that your package is compatible with more recent version you need compile against them and test them.  I mean, newer version are not only "api" compatible, you also need to exercise the new functionalieties those more recent packages.

Closing this. The original question / concern has been addressed. We will eventually be moving off of .NET5 as it is out of support, but that will be tracked separately.


Restrict openWindow() to http(s) schemes?

We currently reject on about:blank (due to #696), but is there any benefit in allowing schemes other than http and https?
What would it mean to openWindow('mailto:hello@example.com')? etc
I propose we reject on schemes other than http/https. Any objections?

What happens if you hit a redirect to a custom scheme? Or execute some JavaScript to navigate to one?

Hey, I just noticed the about:blank spec change.
Chrome currently treats all about:* URLs as "about:blank" in openWindow(). Apparently this mimics the behavior of window.open().  cc @mounirlamouri who implemented this in https://codereview.chromium.org/980383004
By the logic of issue #696, it would seem we should instead reject all about:* instead of opening about:blank. Should the spec codify that?

Apologies for flip-flopping, but I'm no longer convinced the changes in #696 were a good idea.
Sure, clients.openWindow('about:blank') creates a window that cannot be used by the SW, and is arguably useless, but as @annevk points out, a developer would open a page on their origin that navigates to about:blank with JS, or a redirect. Or, they could do clients.openWindow('/whatever').then(c => c.navigate('about:blank')) once #681 lands.
Making openWindow accept a different set of URLs to window.open seems needlessly complicated.

It seems better if they follow the same code path as much as possible, agreed. This requires some special casing though for about:blank as bz pointed out in that bug. You want it to inherit the origin of the service worker (and likely the CSP policy, and maybe some other stuff, we should have something for that).

F2F: Allowing about:blank means figuring out what origin it is, and if it's service-worker controlled. It's more complicated than it seems, and it's a real edge case. Moving to v2, since we can add it later.


Feat: Make Artifacts support in-structure commenting

Background
In most decompilers, like IDA Pro, you can have types that have comments in them, like:
struct Elf64_Vernaux // sizeof=0x10
{                                       // XREF: LOAD:0000000000400410/r
     unsigned __int32 vna_hash;         // this is some comment on this first member
     unsigned __int16 vna_flags;
     unsigned __int16 vna_other;
     unsigned __int32 vna_name __offset(OFF64,0x400390);
     unsigned __int32 vna_next;
};

Which libbs does not currently support. An ideal solution would look like this:
my_struct = deci.structs["Elf64_Bernaux"]
print(my_struct.comments[0]) // this is some comment on this first member
print(my_struct.members[0].comment) // // this is some comment on this first member

Implementation
To support this type of commenting, we'll need to do a few things:

[ ] Update member-like Artifacts to have the comment attribute
[ ] Support setting/getting these in each decompiler (as much as possible)
[ ] Refactor Function to support comments
[ ] Remove the old comments system that simply stored all comments globally

if you don't want to have to use the edm_t.cmt and udm_t.cmt attributes to enumerate or serialize complex field comments, you can also unpack/save them from tinfo_t.serialize() (which was the pre-8.4 method anyways)
decoding the bytes returned by tinfo_t.serialize into a list of comments is basically lexing for "\1" to find each 8-bit or 16-bit length, decoding said length, using the length to extract the comment, then utf-8 decoding those bytes. (field names are similar)
    def decode_bytes(bytes):
        '''Decode the given `bytes` into a list containing the length and the bytes for each encoded string.'''
        ok, results, iterable = True, [], (ord for ord in bytearray(bytes))

        integer = next(iterable, None)
        length_plus_one, ok = integer or 0, False if integer is None else True
        while ok:
            one = 1 if length_plus_one < 0x7f else next(iterable, None)
            assert((one == 1) and length_plus_one > 0)
            encoded = bytearray(ord for index, ord in zip(builtins.range(length_plus_one - 1), iterable))
            results.append((length_plus_one - 1, encoded)) if ok else None

            integer = next(iterable, None)
            length_plus_one, ok = integer or 0, False if integer is None else True
        return results

encoding the string passed to tinfo_t.deserialize(til, type, fields, cmts=None) requires encoding the length for each utf-8 encoded comment, and concatenating back into a stream of bytes.
apologies for the unreadability of the following.. "encode_length" is all that is relevant
    def encode_bytes(cls, strings):
        '''Encode the list of `strings` with their lengths and return them as bytes.'''
        encode_length = lambda integer: bytearray([integer + 1] if integer + 1 < 0x80 else [integer + 1, 1])
        iterable = (bytes(string) if isinstance(string, (bytes, bytearray)) else string.encode('utf-8') for string in strings)
        pairs = ((len(chunk), chunk) for chunk in iterable)
        return bytes(bytearray().join(itertools.chain(*((encode_length(length), bytearray(chunk)) for length, chunk in pairs))))

however, it's worth confirming the performance with regards to serializing/deserializing them at scale is actually relevant in binsync. minsc creates an index for all commentable "things" so that they can be tagged for searching and (mis-)used to store nearly-arbitrary data, so being able to check if a tinfo_t even has comments or distinguishing what exactly was updated (name/comment/other) in response to events (w/o having to iterate through all the fields one-by-one) made a difference.
...i'm literally praying that they don't try to retrofit repeatable/non-repeatable comments into this btw.


Prefetch

Obviously not expecting this to be merged right in. But I've played around with the prefetching and added a ton of comments. If you've got a more representative test, then I'd be interested to see what performance metric you get.

Thanks for the PR. I have a local benchmark which is using the OpenSSL example from libFuzzer: https://google.github.io/clusterfuzz/setting-up-fuzzing/heartbleed-example/#building-a-libfuzzer-target-for-openssl. It seems to be a really good benchmark, and we get to find Heartbleed using hotwax!
I'll take a look at this PR's performance in isolation and then in conjunction with Ole's new logging offset calculation code.

Cool thanks. I think before the prefetching was being done in the child, so each for would fetch every block (including those which might not be reached) and then discarding them. Hence the slow down.
Assuming the number of persistent loops isn't huge, then I can't logically see why using prefetch shouldn't have a positive effect, even if the block compilation overhead is low, but maybe I've missed something?!

I've merged this into prefetch-ng where I'll work on it further there & provide my benchmark suite. Thanks again for this.


Allow control of vehicles other than the 'active one'

Currently, only the vehicle in which the player 'sits' can be controlled.
We should allow all vehicles in the game to be controlled.
It should probably work like how AI vehicles are controlled by .lua scripts right now.

@tckarenchiang: did you mean to close this issue?
I don't believe #44 implemented this, does it?

@tckarenchiang: did you mean to close this issue?
I don't believe #44 implemented this, does it?

I thought commit  https://github.com/tud-cor/FS19_modROS/commit/e82eae8352ae573c63b9f315bf35b665b3dbae40 did it?

Can users now control multiple vehicles other than the one the player is in by publishing Twist messages to specific topics?
How would they address specific vehicles?
IIUC, e82eae8 applies the same Twist to all vehicles. That would be something else.

Can users now control multiple vehicles other than the one the player is in by publishing Twist messages to specific topics?
How would they address specific vehicles?
IIUC, e82eae8 applies the same Twist to all vehicles. That would be something else.

Not yet in the previous PR, yes, you are right. I got confused.
This will be fixed in the later PR.
Thanks for reopening the issue!


Make mock structs for testify.go public

Why do you need those to be public? You can construct new instances with the generated NewX method and should probably never want to use the real type of the mock structs but rather use the interface type they implement. 🤔

Jo, the issue is, that we have some huge test which depend on these mocks.
For each subtest we have to create a new mocks, which cause a lot of boiler code.
It would be nice to store an instance of the mock to reuse it for the subtest.
This is not possible atm.
I'm open for suggestions

Jo, the issue is, that we have some huge test which depend on these mocks. For each subtest we have to create new mocks, which cause a lot of boiler code. It would be nice to store an instance of the mock to reuse it for the subtest. This is not possible atm. I'm open for suggestions

Couldn't you just define a variable like mock := NewFoo() and then reuse this variable in multiple subtests? 🤔 Maybe a short code example would help me to understand the issue here.
But either way, this instance should probably be defined with the interface type and not with the concrete type of the mock struct.
I'm also not against these changes, I'm just trying to understand why they are necessary, since the struct type has been made private for the reason that it should never be needed.

e.g. a testify suite
https://pkg.go.dev/github.com/stretchr/testify/suite
type ExampleTestSuite struct {
    suite.Suite
    mock *mockFooClient // Not possible because the mock is private
    mock  FooClient // Possible, but now I can't use suite.mock.OnSayHello() later
}

func (suite *ExampleTestSuite) SetupTest() {
    suite.mock = NewMockFooClient()
}

func (suite *ExampleTestSuite) TestExample() {
    suite.mock.OnSayHello()...
}

The default client interface only has the SayHello func but not the OnSayHello func.
Also some linters don't like this:
https://www.reddit.com/r/golang/comments/xurmnl/return_unexported_type/

e.g. a testify suite https://pkg.go.dev/github.com/stretchr/testify/suite
type ExampleTestSuite struct {
    suite.Suite
    mock *mockFooClient // Not possible because the mock is private
    mock  FooClient // Possible, but now I can't use suite.mock.OnSayHello() later
}

func (suite *ExampleTestSuite) SetupTest() {
    suite.mock = NewMockFooClient()
}

func (suite *ExampleTestSuite) TestExample() {
    suite.mock.OnSayHello()...
}

The default client interface only has the SayHello func but not the OnSayHello func.
Also some linters don't like this: https://www.reddit.com/r/golang/comments/xurmnl/return_unexported_type/
I could also run this in every test, but we try to avoid this.
mock := NewMockFooClient()

Also , this PR is no urgent, just something I would like to discuss 😀

Okay, I see why having an exported type would be needed in that example. I think in general, it's not always a good practice to introduce such abstractions for testing, since test code should be kept simply and easy to follow (see e.g. this blog post). So in that sense I'd say constructing new instances in each test (with NewMockFooClient) should be preferred even despite of the repetition.
That being said, I'm also fine with exporting the struct type since that basically matches what other projects like https://github.com/uber-go/mock do and what is generated for pegomock: https://github.com/lovoo/protoc-gen-go-grpcmock/blob/e44c38fe7354d1284e685a9d2218b2612cd02548/examples/helloworld/pegomock/helloworld_grpc_mock.pb.go#L22
So feel free go go ahead with this PR. 😄


bare condor_submit should return help, not a traceback

$ condor_submit
Traceback (most recent call last):
  File "/opt/jobsub_lite/bin/condor_submit", line 83, in <module>
    main()
  File "/opt/jobsub_lite/bin/condor_submit", line 71, in main
    proxy, token = get_creds(args)
NameError: name 'args' is not defined

Sorry for the duplicate I'll just close this then.


[CARBONDATA-3835] Fix global sort issues

Why is this PR needed?

For global sort without partition, string comes as byte[], if we use string comparator (StringSerializableComparator) it will convert byte[] to toString which gives address and comparison goes wrong.

For global sort with partition, when sort column is partition column.
it was sorting on first column instead of partition columns.

What changes were proposed in this PR?

change data type to byte before choosing a comparator.
get the sorted column based on index, don't just take from first

Does this PR introduce any user interface change?

No

Is any new testcase added?

Yes

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3093/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1371/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3096/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1374/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3098/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1376/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1378/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3101/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1379/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1380/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3103/

LGTM

LGTM


Maven report generation fails on Java 9

Although with the latest plugin versions report generation fails. It seams that findbugs is not updated to Java 9 (and maybe never will....). Upstream bug: https://github.com/gleclaire/findbugs-maven-plugin/issues/60
Problem:
     [java] Warning: Unknown version of Java
     [java] edu.umd.cs.findbugs.JavaVersionException: Could not parse Java version string: 9

I suggest we just document the problem in the readme and postpone the resolution to 1.2 or 2.0.

@cruftex consider moving to Spotbugs as Findbugs is dead

Looks like SpotBugs is still stabilising. This is only used by the mvn site goal which we don't use and only occurs on Java 9. Lets move this to 2.0 as it is not blocking anything.


How to use "onEnterFullscreen"?

I've Tried this onEnterFullscreen: AutoOrientation.landscapeAutoMode(), when the page load, the phone automatic landscape, and i received this error.

what i want is, when the user click the fullscreen, the video automatic landscape

onEnterFullscreen is a function of type void Function(InAppWebViewController controller), so your code should be:
onEnterFullscreen: (controller) async {
  AutoOrientation.landscapeAutoMode();
},

// or

onEnterFullscreen: (controller) => AutoOrientation.landscapeAutoMode(),


Return 204 No Content when response is empty

Similar return 201 Created when a new instance is created.

We now return 204 when the body is empty. Since it is a bit hard for the framework to detect if an entity has been created the implementor of a method can instead override the status code with 201 if that's the code (via the InvocationContext).


Refines functionality of miro_inventory lambda

What is this PR trying to achieve?
Modify miro_inventory lambda to record decisions and not images in order that we can record data on the decisions themselves.
Who is this change for?
💻
Have the following been considered/are they needed?

[ ] Deployed new versions
[ ] Run terraform apply.

@alicefuzier if you're adding a copy asset from the none topic, we'll need to coordinate ensuring that is recorded in the inventory.


DropDown does not work in a standard Android 4.2.2 browser

On tap menu opens and immediately closes.

Android 4.4.2 and when I tap the menu dropdown, it animates and as soon as animation is over it begins the hide/close event.  However, when I long-press on the menu dropdown, it will stay open but I must long press to close otherwise it will close then re-open again.
Android Browser is the only problem, works in latest chrome and ff fine on the same device.

This is still happening, any chance for a fix?

Are you experiencing this in the beta docs? http://beta.semantic-ui.com

Yes, unfortunately the behavior is the same.
It may be worth noting that I am using a Samsung Galaxy Note 2, recently factory reset and only some basic apps installed.  I tested this on my wife's Samsung Galaxy S5 and I did not have any issues with the dropdown.  Additionally, I am unable to reproduce the issue on the android emulator.
Side Note: This may belong in another thread, but on beta i wasn't able to navigate easily using the sidebar:

Same problem at android 4.4.1, it closed the dropdown menu/select rapidly. And if you use drag to open the dropdown ui, still can't select the item to select input.

@inergy Beta is not being used now. I should probably take down that repo to avoid confusion.

@jlukic yeah, that screenshot was taken before beta launched.
The problem still exists, and i'm getting all kinds of other odd issues now (with 2.0 release), but I think I've given up for now.  Unless we start to see a ton of users using the samsung galaxy note 2 default browser, I'm going to ignore the issue.  It seems the default android browser on most other phones works without these symptoms, hard to tell if it's a samsung issue or something.

I see, it seems like some android issues are a bit difficult to pin down using emulation tools only. Wish I had more of a solution

Any news on this? The dropdown on the semantic ui demo pages is not working on android browser in marshmallow.

I have some problems with dropdown not displaying on android too (when there is no default value selected and just a "prompt")

Come on now guys, this should be a critical bug.That SU is broken in one of the bigger mobile browsers makes it hard to motivate a dependency on this at all.

+1

I'm not able to dive into this and offer a patch myself, but is there anything else one can do to help this move forward?

If anyone can send me an old android phone that I can use to test this, email me at<EMAIL_ADDRESS>

I'm not sure if it is the same issue, but we experienced something similar with iOS devices. Dropdowns show and hide immediately. I think it might be related to fastclick (causing two clicks in a row).
It is possible to reproduce using an emulator. For instance semantic examples show that issue in the "Restoring Defaults" example. Maybe someone could verify using an iPad 3 and that example?
I attached a video showing the problem.
ScreenFlow.mp4.zip

Has there been any update on this?

@jlukic Could you please open some pay-pal or gofundme or whatever it's called so that we can send you money to go buy some old android phone?

Potential temporary fix: https://github.com/Semantic-Org/Semantic-UI/issues/3304#issuecomment-241954237

I ended up disabling the show and hide functionality, implementing my own whilst still retaining onChange event:
$('.dropdown').click(function(){         $('.dropdown').toggleClass('active visible');         $('.dropdown .menu').toggleClass('hidden visible').toggle(); }); $('.dropdown').dropdown({         onChange: function(value, text, $selectedItem) {                 // custom code         },         onShow: function() {                 return false;         },         onHide: function() {                 return false;         } });

Ongoing issues may be related to https://github.com/Semantic-Org/Semantic-UI/issues/2718?

Has this issue ever been resolved?


How to flushall / flushdb?

Checking https://github.com/Netflix/dynomite/blob/dev/notes/redis.md, it appears the flushall and flushdb commands are not supported. Given this limitation, how can one flush Dynomite?

The way we do it is write a script that connects to redis parallelly on all instances and runs the flushall command


[3.0] viewport screen capture doesn't work

Operating system or device - Godot version: Linux, Godot 3.0 (master)
Issue description:
Getting a screen capture from any viewport results in empty data.
Steps to reproduce:
get_viewport().queue_screen_capture()
yield(get_tree(),"idle_frame")
yield(get_tree(),"idle_frame")
var i = get_viewport().get_screen_capture()
i.save_png("user://cap.png")

Now queue_screen_capture() and get_screen_capture() don't even exist.

Haven't tryed from gdscript, but you should be able to call 'viewport.get_texture().get_data()' to get a reference to Image wich you can save. Also calling 'image.lock()' and image.unlock()' should let you get (and maybe set?) pixels.
This is how it works for color picker when picking a color from the screen:
https://github.com/godotengine/godot/blob/master/scene/gui/color_picker.cpp#L428

@MarianoGnu you are correct, the issue is only that ViewportTexture::get_data() is not bound to GDScript, but that should be easy to solve.


Parameter Instant requires input

I tried to use the parameter instant and have noticed that an additional input is required.
So calling the .\totp-cli.exe instant Z4L6NI0Q3M2PDUBCXZSYN3UBJK first shows a blank line, i can type or just hit enter and then the totp is shown.

That's intentional. From the help:
   instant          Generate an OTP from TOTP_TOKEN or stdin without the Storage backend.

So yes, it waits for an input from stdin and it does not work with additional arguments. The token should never be pasted as an argument, either saved in an env var (for example CD/CI), pipe it from other program (or even like echo), or paste it after you started. If you put it into the command line with the command, it may show up in your shell history and usually that's something we want to avoid.

or just hit enter and then the totp is shown.

that totp shouldn't be correlated with the provided token. That was generated from an "empty string token".

OK. Got it running.
But when I write
Write-Host $env:token | .\totp-cli.exe instant the token is printed to the console and this will also appear in the logs. I have tried to redirect the different streams, but without success.
How can I savely suppress printing the token?

Usually stdin and stdout are not in the log, only commands as written for shell history. What is the environment (I can see it's windows, but that's the only thing I can see), what logs?
Another note: I'm not a PowerShell mage, it's rare I use it, but looking up what Write-Host does, it send a message to the host. I think you want to use Write-Output. The following example shows Write-Host output doesn't go to stdout, while Write-Output does.
PS C:\Users\efert\Downloads> Write-Host "should fail with 'illegal' input" | .\totp-cli.exe instant
should fail with 'illegal' input
974991

PS C:\Users\efert\Downloads> Write-Output "should fail with 'illegal' input" | .\totp-cli.exe instant
 !!! otp error: illegal base32 data at input byte 14

Thank you for your feedback. It looks good now and gives me the only output i expect.
$totp = "3SLSWZPQQBB7WBRYDAQZ5J77W5D7I6GU" Write-Output $totp | .\totp-cli.exe instant
It was indeed the small difference between Write-Output and Write-Host.
Thank you for your assistance  ;-)


HDDS-10199. Node.js 16 actions are deprecated

What changes were proposed in this pull request?
Upgrade GitHub actions to v4 to get Node.js 20.
https://issues.apache.org/jira/browse/HDDS-10199
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone-docker-runner/actions/runs/7644627140

Thanks @dombizita for the review.


Fix github action workflows' bugs

Signed-off-by: pixiake<EMAIL_ADDRESS>What this PR does / why we need it:
Fix github action workflows' bugs.

Fix the parameters' problem of login dockerhub task.
Fix format problem of release-drafter.yml

/lgtm


Fixing Size Issues of AI Chatbot in OpenTek

Related Issues
#479
This pull request addresses the size issues of the AI chatbot in OpenTek by making changes to the Alan AI settings and adjusting the position of the chatbot to improve its appearance and usability.
Proposed Changes

Modified Alan AI Settings: Adjusted the configuration of Alan AI to better handle the chatbot's size and appearance on different screen resolutions and devices. This ensures that the chatbot is displayed correctly and consistently across various platforms.

Position Adjustment: Changed the bottom and left position of the chatbot to align it properly within the OpenTek web application. This eliminates any overlapping issues and improves the chatbot's overall visibility.

Additional Information

Any additional information or context

Checklist

[ ] Tests
[ ] Translations
[ ] Documentations

Screenshots

@AnirudhPanda ,please review and merge my pull request


Support password in Redis

VR does not support passwords in Redis.
Here is where a Redis url is parsed and password ignored:
https://github.com/yougov/vr.common/blob/b53f0a3841f2503507152033427a31e951338e68/vr/common/utils.py#L138-L148
This function seems useless, as "redis" Python module already provides a way to parse a URL and return a Redis instance: https://github.com/andymccurdy/redis-py/blob/master/redis/utils.py#L11

@jaraco I've deprecated that function in vr.common and replaced it with redis.StrictRedis.from_url in vr.server and vr.agent: more patches will follow in those projects.
If you agree with the approach, I'll cut a new vr.common release and bump it in the other modules.


Moving network interfaces that are connected to virtual machines.

It appears that you can move a network interface to another resource group without moving associated resources. I was able to move a network interface that is connected to a virtual machine without moving the virtual machine or virtual network. Is it possible to review/clarify this?

If you move the network interface, you must move all resources related to the network interface with it. If the network interface is attached to a virtual machine, for example, you must also move the virtual machine, and other virtual machine-related resources.
<

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c377fa1e-2274-704a-dcfa-4ac02659bf87
Version Independent ID: 1ba8a48b-a99e-096b-4822-63d62379e605
Content: Create, change, or delete an Azure network interface
Content Source: articles/virtual-network/virtual-network-network-interface.md
Service: virtual-network
GitHub Login: @KumudD
Microsoft Alias: kumud

@atamu , thank you for the feedback, we will investigate this and update the thread accordingly.

@atamu , I replicated your scenario and I was able to move the Network interface of a VM to another resource group without moving any related resources. We have engaged the backend team to provide their insights on same. We will get back to you once we have an update from them.

@atamu This only qualifies when moving to a different Subscription & resource group, not just a resource group. I have updated the docs to state that, and the docs should reflect the change within 24 hours.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


[ISSUE #3009]test(benchmark): support delay message test

Make sure set the target branch to develop
What is the purpose of the change
issue #3009
Brief changelog
add delay message option
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.05%) to 54.105% when pulling 79228a6278a95133d8974155c4b5f308770f25bd on maixiaohai:add_delay_message_parameters_to_benchmark into a92996accf560d6c63d8ef23670023be60498cd9 on apache:develop.

Coverage increased (+0.05%) to 54.105% when pulling 79228a6278a95133d8974155c4b5f308770f25bd on maixiaohai:add_delay_message_parameters_to_benchmark into a92996accf560d6c63d8ef23670023be60498cd9 on apache:develop.


[Server] Add documentation and example service

Add some good operational documentation to the server README referring to an example service we need to write.

Here is a Amazon maintained not SDK Smithy model:
https://github.com/aws/aws-parallelcluster/tree/develop/api

Oh nice, thanks for pointing this out!

Hi @crisidev
Is there any example of a server code that uses the codegen-server output? I couldn't find one in the repo.
I also wonder what should be the process of building the codegen-server crate for a given service (S3 in my case) - should I create a build.gradle like in codegen-server-test and use it to generate the code, and then store the generated code in my project?
Thanks!

Hi @crisidev
Is there any example of a server code that uses the codegen-server output? I couldn't find one in the repo.

Unfortunately there isn't yet. We have in plans to write an example service with README showcasing all the features, but it has not been done yet. This issue is to keep track of this.

I also wonder what should be the process of building the codegen-server crate for a given service (S3 in my case) - should I create a build.gradle like in codegen-server-test and use it to generate the code, and then store the generated code in my project?

Yes, you will need a whole gradle setup like in codegen-server-test. Also this will be covered by the example sooner or later. If you are in a worry, the repo posted by @tschuett has a model setup. Most of the things you will need are already there, you will have to add the rust-codegen specific that you can find in codegen-server-test.

Thanks!

I am sorry we don't have an example yet, we are at a very early stage of development.

Sure @crisidev I totally understand the stage and trying to contribute to the gaps I can.
Would you consider it relevant to reference to a "living example" to the s3d project I am building at red hat emerging tech?

It looks like the s3d project is dormant now, and we don't have any real good open source example to link to. Since we already have the examples folder in this repo we are closing this issue.


make all scenario-level CLI options indirect through the scripting API

When managing advanced scenarios via scripting, it is problematic to also have to rely on a specific command-line setup. It should be possible to access the services which are configured or initialized via command line options through the scripting environment as well.
detailed design: TBD
originally filed as https://github.com/engineblock/engineblock/issues/81

superseded with 5.21+ command API


feat(KViewSwitcher) Adds table/grid view switcher

Summary
Adds view switch button originally used in Konnect.
PR Checklist

[x] Does not introduce dependencies
[x] Functional: all changes do not break existing APIs and if so, bump major version.
[x] Tests pass: check the output of yarn test packages/
[x] Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
[x] Framework style: abides by the essential rules in Vue's style guide
[x] Cleanliness: does not have formatting issues, unused code (e.g., console.logs), or leftover comments
[x] Docs: includes a technically accurate README, uses JSDOC where appropriate

How come I'm not seeing the icons?

@xitongzou refresh the page. I used steal but the  docs now use steel

@xitongzou refresh the page. I used steal but the docs now use steel

hmm still shows blank for me, tried other browsers and clearing cache too. Also, should we change KTable too to use steel? noticed thats still using steal


All application setting value and name properties must be of type string

It seems that I can only set the applications setting to a string value ?
Below config is not allowed:

Is this By Design or will this change in the future?

This is by design, all app settings keys are strings as are the values.


RxJS patch is not closure safe

Assignment into imported constructor is not allowed: https://github.com/angular/zone.js/blob/master/lib/rxjs/rxjs.ts#L75
We can’t use string literals here: https://github.com/angular/zone.js/blob/master/lib/rxjs/rxjs.ts#L230 since they don’t minify in closure

The fix for #1 is https://github.com/trxcllnt/rxjs/blob/53eddb1cca1228fe6d81aa6bec0ee0a57c8f4664/src/add/zone.ts#L60-L74 The trick is to intercept the setter to have side-effects. This way we don’t need to replace the constructor.

@mhevery , I have modified this one in #848, please review.


refactor(egen): Refactored the Custom tabular bq managed dataset code as per template guidelines

Refactored all the cells according to the template notebook

List of updates:

Steps are re-organized based on the new template.
Renamed REGION as LOCATION
Removed import os - unused
Included --quite argument in the pip install dependencies.
Removed IS_TESTING env variable
Included colab enterprise link and generalized code for "colab only" cells

REQUIRED: Fill out the below checklists or remove if irrelevant

If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:

[x] Use the notebook template as a starting point.
[x] Follow the style and grammar rules outlined in the above notebook template.
[x] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
[x] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
[ ] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
[ ] This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
[x] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

/gcbrun

/gcbrun

/gcbrun