MODEXPW-269 - mod-data-export-worker: memory settings

MODEXPW-269 - mod-data-export-worker: memory settings
Purpose
Increasing of mod-data-export-worker settings to achieve stable working of module on the hosted reference env and Vagrant box
Approach
ModuleDescriptor updating
TODOS and Open Questions

Learning

Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.

Does this PR meet or exceed the expected quality standards?

[ ] Code coverage on new code is 80% or greater
[ ] Duplications on new code is 3% or less
[ ] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] Were any API paths or methods changed, added or removed?
[ ] Were there any schema changes?
[ ] Did any of the interface versions change?
[ ] Were permissions changed, added, or removed?
[ ] Are there new interface dependencies?
[ ] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all they appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment.  Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

I did Jenkins re-run of that unrelated failed branch build. Success. Dunno what that was about.


Nested lists don’t line up properly

Algorithmic Number Theory

Efficient computations

Integer addition/subtraction/multipllication/division with remainder

Modular addition/subtraction/multiplication/reduction

Modular Exponentiation?

Same issues as #32


sFld argument in FIND_RHO_2D

The CHECK_SALINITY_FOR_NEGATIVE_VALUES flag can modify sFld
Shall we switch the description of argument from "I" to "U", i.e.,
SUBROUTINE FIND_RHO_2D(
I                iMin, iMax, jMin, jMax, kRef,
I                tFld,
U               sFld,
...

This makes sense to me.

@menemenlis As far as I remember, this flag was introduced as a hack to make sure that we never have negative salinities that would bomb sqrt(sFld). Maybe it would make more sense to remove this call here and add once in beginning the timestep, before find_rho is called for the first time, e.g. at the beginning of S/R do_oceanic_physics

The location of this call to LOOK_FOR_NEG_SALINITY is not ideal:
a) if we really want to reset negative salinity to zero, I agree with Martin (@mjlosch)
it would be better outside FIND_RHO_2D (like FREEZE_SURFACE, which, BTW, is not a great name).
b) if the only reason of this CHECK_SALINITY_FOR_NEGATIVE_VALUES
is to prevent problems in density computation, then we could change the behavior
to just compute density from MAX(0, sFld) (when CHECK_SALINITY_FOR_NEGATIVE_VALUES is
defined). Would not be difficult to change since it's a CPP option.
Otherwise, if we just follow Dimitris' (@menemenlis) recommendation with no other code
change than continuation line switch from "I" to "U", I would suggest to put it within
#ifdef CHECK_SALINITY_FOR_NEGATIVE_VALUES, like this:
  SUBROUTINE FIND_RHO_2D(
 I                iMin, iMax, jMin, jMax, kRef,

#ifdef CHECK_SALINITY_FOR_NEGATIVE_VALUES
I                tFld,
U                sFld,
#else
I                tFld, sFld,
#endif
O                rhoLoc,
I                k, bi, bj, myThid )
On Sun, Nov 10, 2019 at 10:25:18PM -0800, Martin Losch wrote:

@menemenlis As far as I remember, this flag was introduced as a hack to make sure that we never have negative salinities that would bomb sqrt(sFld). Maybe it would make more sense to remove this call here and add once in beginning the timestep, before find_rho is called for the first time, e.g. at the beginning of S/R do_oceanic_physics
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/MITgcm/MITgcm/issues/241#issuecomment-552310563


Overcommit swallows non-error output from pronto

Hello guys! 👋
First of all, thanks for the amazing project! It has helped me a lot through the last few years 😄
I am now trying to use Overcommit along with PrePush Pronto checks - which is working great for when there's actual errors flagged by pronto. However when there's no error and only info messages, Overcommit does not display them. This is less than ideal as I would love to be able to display some suggestions (which don't fail the action) when the git-hooks are triggered.
I expected that the "quiet" option would be responsible for it, but I couldn't get it to work as desired.
⋊> ~/w/o/sts on test-branch ⨯ tail -n15 .overcommit.yml
PrePush:
  Pronto:
    enabled: true
    quiet: false
    description: Analyzing with Pronto (brakeman, fasterer, flay, reek and rubocop)
    flags:
      - run
      - --exit-code
      - --commit=qa
      - --runner
      - brakeman
      - fasterer
      - flay
      - reek
      - rubocop

⋊> ~/w/o/sts on test-branch ⨯ overcommit --install
Installing hooks into /Users/OH-RGIBIN/workspace/org/sts
Successfully installed hooks into /Users/OH-RGIBIN/workspace/org/sts

⋊> ~/w/o/sts on test-branch ⨯ be pronto run --exit-code --commit=qa --runner brakeman rubocop reek flay fasterer
Running Pronto::Brakeman
Running Pronto::Rubocop
Running Pronto::Reek
Running Pronto::Flay
Running Pronto::Fasterer
app/models/shipment.rb:163 I: Calls 'loc.type' 3 times - [DuplicateMethodCall](https://github.com/troessner/reek/blob/v6.0.4/docs/Duplicate-Method-Call.md)
app/models/shipment.rb:163 I: Refers to 'loc' more than self (maybe move it to another class?) - [FeatureEnvy](https://github.com/troessner/reek/blob/v6.0.4/docs/Feature-Envy.md)

⋊> ~/w/o/sts on test-branch ⨯ git push --dry-run origin HEAD
Running pre-push hooks
Analyzing with Pronto (brakeman, fasterer, flay, reek and rubocop)[Pronto] OK

✓ All pre-push hooks passed

To github.com:Org/sts
 * [new branch]        HEAD -> test-branch

Is there any workaround for this?

If you look at how the Pronto hook is implemented, it treats anything that isn't prefixed with E: as a warning:
https://github.com/sds/overcommit/blob/7d94fa55a74ceea705645d565a34ecefaca08ea5/lib/overcommit/hook/shared/pronto.rb#L7
Therefore these messages should be getting shown. I'm personally not familiar with pronto, so it might be worth reaching out to the author of #488 if you'd like some more insight. Perhaps there is something wrong with the regex in:
https://github.com/sds/overcommit/blob/7d94fa55a74ceea705645d565a34ecefaca08ea5/lib/overcommit/hook/shared/pronto.rb#L16
Appreciate you digging in to investigate. I won't personally be digging further unless there's a clear issue we can point to within Overcommit itself.

Thank you for the quick answer @sds! Those leads are very helpful already; I'll try to dig a bit further when I have the time.


docs: Add alternative WindiCSS config

As a follow up to https://github.com/brillout/vite-plugin-ssr/pull/37

I think we can show the vite.plugin.js example only and add a comment that it's also possible to define in windi.config.js.

🙏


refactor: replaced AnthorpicBedrock SDK with aws-sdk BedrockRuntimeClient

This change reduces non-AWS dependencies and allows more flexibility for changing models within Bedrock.
Two lambda functions were leveraging this SDK for calls to Bedrock (Claude). Functionality hasn't changed though
Resolves deprecation warning for aws-sdk/signature-v4.
fix #71
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This also fixes #70 as well


IMPORT FAILED

ComfyUI: v0.3.7-3-g8af9a91
(2024-12-06)
Manager: V2.55.4
Up to date, tried to uninstall reinstall and still got an import failed, could be related to a recent Comfy update that break things since this issue is more recent than your last commit,

yes im experiencing the same issue it seems to be related to opencv-python-headless the package is automatically uninstalled at comfyUI launch to be replaced with the opencv-python package

I just reinstalled comfuyUI, seems that it fixed the issue for me, even if it's the same version and packages as before. so I can't really say what caused this failed import error

May have been order of installation. While I have tried to unpin specific
versions so it's more compatible, other packages may pin lesser versions
themselves
On Sat, Dec 7, 2024, 11:17 AM PGCRT @.***> wrote:

I just reinstalled comfuyUI, seems that it fixed the issue for me, even if
it's the same version and packages as before. so I can't really say what
caused this failed import error
—
Reply to this email directly, view it on GitHub
https://github.com/WASasquatch/was-node-suite-comfyui/issues/519#issuecomment-2525283700,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIZEZMSIHIARIPWI3IEFXL2ENCUHAVCNFSM6AAAAABTFWSAZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRVGI4DGNZQGA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Ingress labels copied to certificate, causing issues with applysets

Describe the bug:
I have an ingress for which I am provisioning certificates, with these annotations:
    annotations:
      cert-manager.io/cluster-issuer: staging
      cert-manager.io/private-key-algorithm: ECDSA

The problem is that my certificate ends up with these labels applied to it, which seem to be copied from the ingress resource:
    labels:
      app: keycloak
      applyset.kubernetes.io/part-of: applyset-hKKbb7RbYuU0FpW0aj6J1V02xlxKvG_l7wjuo6REa0U-v1

These copied labels are causing problems because kubectl --prune wants to delete my certificate due to the applyset.kubernetes.io/part-of label. This behaviour doesn't seem to be documented anywhere, and from a Slack discussion seems to be a bug.
Expected behaviour:
I expect the certificate to be created without any labels. If this is not possible for backwards-compatibility reasons, I would like to be able to deny-list certain labels (specifically applyset.kubernetes.io/part-of in my case).
Steps to reproduce the bug:

Install cert-manager with the default static manifests
Create the following ingress resource:

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: keycloak
  namespace: keycloak
  labels:
    app: keycloak
  annotations:
    cert-manager.io/cluster-issuer: staging
    cert-manager.io/private-key-algorithm: ECDSA
spec:
  ingressClassName: external
  tls:
    - hosts: ["example.com"]
      secretName: keycloak-tls
  rules:
    - http:
       host: "example.com"
       paths:
        - path: /
          pathType: Prefix
          backend: { service: { name: keycloak, port: { name: http } } }

Observe that the created Certificate has the same labels as the ingress.

Anything else we need to know?:
From the Slack thread:

Code here: https://github.com/cert-manager/cert-manager/blob/d2f6bbe579fd9d5f88b82f9a4bfe9241709e9eb8/pkg/controller/certificate-shim/sync.go#L378
PR introducing this behaviour: https://github.com/cert-manager/cert-manager/pull/1450/files#diff-76233e2bc68eec8223c36383b6d5c0672e1ca809e3e7e280e6f3716fabdd6bb6R160

Environment details::

Kubernetes version: 1.28.2
cert-manager version: 1.13.2
Install method: static manifests

/kind bug

/remove-lifecycle stale

/remove-lifecycle rotten

@ThatsMrTalbot - For the public record, I discussed with the devs (I think in the bi-weekly video call, maybe on Slack) that it would be good to specify an excluded set of labels, and that it would make sense to exclude the applyset.kubernetes.io/* labels by default, since copying them is almost certainly the wrong behaviour (since it'll result in the certs getting deleted whenever the applyset is used).
This was the approach taken in #6576, but it went stale and I don't have the time to pick that up again now. I might get back to it in a few weeks/months.


18 different 16 Bit transactions,

Hi,
I'm trying to transfer 18 different transactions with 16 bit each from slave to master, the Clock is set to 125kHz.
Therefor I put the CC on another free GPIO pin and attached an interrupt on this additional "CS Line". In the ISR I check for the rising edge and then write the data from an array to spi_slave_tx_buf[0]. Because I want 18 different data to be transmitted (for testing purposes, 0xAAAA and 0xFFFF should be transmitted alternately) I use a counter:

if (enableLOW == false && DirectionSignal == LOW){
spi_slave_tx_buf[0] = TMData[counter];
++counter;
if(counter > 18) {
counter = 0;
}
}

The DirectionSignal is just a Signal with the value 0/1, on this Signal depends if the slave shall send or receive data.
If the ISR is done and I went back to my code there is just this code to transmit the data:

if (DirectionSignal == LOW) {
if (slave.remained() == 0) {
slave.queue(spi_slave_rx_buf, spi_slave_tx_buf, BUFFER_SIZE);
}
}
while (slave.available()) {
slave.pop();
}

When I check the transmitted data i receive the following bit patterns:

I've already tried it with 8Bit and it was working as expected.
Since my board version is incompatible with the latest version of your library, I use the previous version 0.1.2. There I changed the parameters(rx_buf, tx_buf) of the functions from uint8_t to uint16_t. But since it still does not work, I have the impression that I overlook something at one point that still needs to be changed.
I hope you can help me with this!
Vani456

I have same issue, and using newest lib version...  Trying to recv/send 32 Bits

Could you try it with the latest arduino-esp32 core (not the library)?

If you still need help with the latest arduino-esp32 core and the latest ESP32SPISlave, please feel free to reopen.
In that case, please attach a minimal code that can reproduce the example.


Export SWRConfigContext

About
Added export of SWRConfigContext to allow for

consuming context in class components (such as error boundaries)
mocking SWRConfigContext in fixtures/tests

It seems like retrying errors isn't currently possible with suspense (#1907). This change allows clearing/manipulating the cache before resuming from an error boundary.
Example usage
export class ErrorGuard extends Component<any, { error: Error | undefined }> {
  constructor(props: any) {
    super(props);
    this.state = { error: undefined };
  }

  public componentDidCatch(error: any, errorInfo: any) {
    this.setState({ error });
  }

  public render() {
    if (this.state.error === undefined) {
      return <Fragment {...this.props} />;
    }

    return (
      <SWRConfigContext.Consumer>
        {value =>

Error

            <button onClick={() => { value.cache.delete("somekey"); this.setState({ error: undefined }) }}>Retry</button>

        }
      </SWRConfigContext.Consumer>
    );
  }
}

Additional functionality to automatically refetch errors on mount when using suspense would be a more useful option (can be done in a separate PR)

I think the use case of class components makes sense! Wdyt @huozhi?

I would recommend to write a helper component for that case with useSWRConfig like
function SWRConfigConsumer({ children }) {
  const config = useSWRConfig();
  return children(config);
}

return (
  <SWRConfigConsumer>
     {value => ...}
  </SWRConfigConsumer>
)

This is doable with current APIs without exposing extra things but can achieve the same goal.


tests: add test for bug 5379

Should fail on master and 6.0.x for now.
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/5379

Interesting. Was expecting it to fail on 6..


Necessary changes that were left behind due to recent updates

Codecov Report
Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.23%. Comparing base (79725c8) to head (5e90c25).
Report is 14 commits behind head on develop.

Files with missing lines
Patch %
Lines

src/phelel/file_IO.py
0.00%
1 Missing :warning:

src/phelel/velph/cli/phono3py/init.py
66.66%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #22      +/-   ##
===========================================
- Coverage    73.42%   73.23%   -0.19%
===========================================
  Files           74       74
  Lines         5223     5280      +57
===========================================
+ Hits          3835     3867      +32
- Misses        1388     1413      +25

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can not start anything after run docker-compose

See the photo below, i can not start anything, why?
p/s: i use docker on windows 10 - linux container

looks like you are running docker-compose inside a docker container


Added - emg.ipynb and CSV File for emg & ecg

@lorforlinux
I have done the following things:

added csv sample file of ecg and emg
done emg.ipynb(plot raw signal, plot filtered signal with envelope)
rename ECG.ipynb file to ecg.ipynb
eog.py file has some issues:
->When there is no eye blink and the window has a straight signal for that entire screen, some noise is also considered as peaks, which is wrong.
-> Moving Window approach detects some wrong peaks, which means the approach is not applied properly here
Change the timestamp for the csv file(now the csv file records only in microseconds) and adding extra relevant information like Arduino board, sampling rate in csv file recording at top.

@lorforlinux
I have resolved the issue in eog.py:

when no eye blink and straight line appears then also some noise are considered as peaks, which is resolved now.
Moving Window approach applied correctly now.

I have done following things:

Update eog.py file(Now it skips first 2 sec data to prevent detecting false peaks)
Update with the eog.ipynb
Create a new recordings folder for all csv files samples
Update the new csv filename

@lorforlinux
I have made following changes:

Update the saved csv file format as discussed.
Update readme according to new changes
Add a new file keystroke.py in applications folder(Works as press spacebar whenever an eye blink detected- with 3 buttons Blink detected, start and quit)

@lorforlinux
I have updated the code for chords.py file in which now it supports more boards -UNO Clone and Rasberry pi pico

@PayalLakra Thank you so much for your contribution, I am merging this now.


Handling of Platforms Without fork()

Currently, Win32/MinGW is considered the only platform without fork(), reflected by __MINGW32__ (or some such) being defined. I thinke VC is excluded via __MSC_VER.
As I am revisiting the TI CL2000, I realize this is a platform without fork() also. And in fact, the majority of embedded platforms (e.g. that are not running some sort of OS) will be like that. So it doesn't really make sense to include ever more platforms in these conditional compilations.
As a workaround, I can of course define __MINGW32__ when compiling for such platforms, or live with the failures. However, wouldn't it more elegant to have a definition such as __CAN_FORK__ and set this via configuration?

Agree. Should be tested in the autoconf files. Still a lot to do there :(

I am always a bit weary of touching the autoconf stuff myself :-/. But you are right.
Also, we have now tests that require to be run in a separate process in various test sources. I was wondering whether it would be better to have these tests all in one place, even though they test different things? Not sure I have a concrete idea how to do this though...
I recall there was an issue with spreading test groups over several sources?

There is still a potential issue with that, which is the discussion related to making TestGroup an actual class.
Anyways, I'd prefer not to put all tests that run in a seperate process in one file, but keep them in the place where they belong.

Okay, agreed. With something like  __CAN_FORK__that will be much easier to handle.

I have a problem which is related to this issue. When I'm compiling CppUTest on an ARM based, Linux running devboard the TEST(UTestPlatformsTest_PlatformSpecificRunTestInASeperateProcess, DummyFailsWithMessage) fails.
After examining the problem I've found out that the cpputest/src/Platforms/Gcc/UtestPlatform.cpp file checking the availability of the fork() function only using the __MINGW32__ macro, but the cpputest/tests/UtestPlatformTest.cpp runs the dummy test on this condition:
#if defined(__MINGW32__) || defined(_MSC_VER) || defined(__IAR_SYSTEMS_ICC__) || defined(__arm__) || defined(__TMS320C2000__)

Clearly the __arm__ macro caused the trouble.
I'm not so confident with the autoconf but I've found a HAVE_FORK macro in the config.h. Maybe this can be used for determining fork() availability.

I was afraid something like that might happen....
arm is far too generic here, but I couldn't find anything better for the Keil compiler it was meant for (I am not using it myself).
Doing this via autoconf would be much cleaner. However, we'd also need to take into consideration that for most targets that actually do NOT have fork, we won't be running autoconf. Can we be sure that HAVE_FORK will be set correctly in all cases? It should be undefined or 0 by default. Then only Automake should set it to 1. If automake works right, it shouldnt be set even for MinGW and we should be fine.

PR #724 should fix this, without breaking the Keil stuff.

Thank you for the quick fix. I used to use the __ARMCC_VERSION macro for checking if it's a Keil environment as well.

I checked out HAVE_FORK and found it to work fine with Automake and other platforms (where it would be manually set, either via IDE or via config.h).
I am having trouble to get cmake to recognize the presence of fork(), though, resulting in build without fork that should actually be with fork, like on Ubuntu or OSX.
check_function_exists(fork HAVE_FORK)

always fails :-(. Anyone with Cmake expertise who can help out? Googling doesn't help, either. Usually you get hits of people failing to find fork under MinGW or Visual Studio. We know that. But how come it is not found under Ubuntu?

@KisImre in your particular case, are you actually using the -p switch on CppUTest, or is it just that you need a clean build (no matter whether running in a separate process is enabled)? Also, which build system are you using?

@basvodde I'm submitting a PR; however, even though it appears to work fine (and will work fine for most people) it needs to be fixed.

@arstrube A key problem that isn't solved related to HAVE_FORK and automake is that automake should generate a distributable config.h, so that when using make install it will install the generated file. It should then not be called config.h but generate something like CppUTestConfig.h. This is a long standing open issue which prevents the serious use of automake (or CMake) for things like this.

Generated config is installed, so this ought to be closed?


CTRL + Click navigates to virtual environment code when installed in editable mode instead of source folder

Issue Type: Bug
Create a virtual environment
Install a python package in editable mode (pip install -e .)
Within editor, CTRL + Click an imported object
The files installed to the virtual environment's lib/python3.x/site-packages folder are opened instead of the source file
Extension version: 2021.1.439157557-dev
VS Code version: Code - Insiders 1.52.0-insider (c6cb54153991e7e3686c51ccd8d85b626b9b1fe4, 2020-12-09T16:02:22.126Z)
OS version: Windows_NT x64 10.0.19042
Remote OS version: Linux x64 4.19.128-microsoft-standard
Remote OS version: Linux x64 4.19.128-microsoft-standard

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz (8 x 1992)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.73GB (0.87GB free)

Process Argv
--crash-reporter-id 32465e51-92f2-4834-81bd-bf50d547ab10

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Ubuntu-20.04

OS
Linux x64 4.19.128-microsoft-standard

CPUs
Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz (4 x 1992)

Memory (System)
7.77GB (0.94GB free)

VM
0%

Item
Value

Remote
WSL: Ubuntu-20.04

OS
Linux x64 4.19.128-microsoft-standard

CPUs
Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz (4 x 1992)

Memory (System)
7.77GB (0.94GB free)

VM
0%

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
openlogontheside:30221882
python763:30178808
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
python504:30227505
vswsl492:30208929
wsl2promptcf:30219163
vstry244:30230484
pythonvsdeb440:30224570
unusedprompt:30219164
folderexplorercf:30219167
openfilemenucf:30219169
pythonvsded773:30223139
core-portspanel:30233467

We don't control how setuptools installs things for editable mode (which is what I'm assuming you are using for your packaging if you are using an editable install), so we really can't do anything about this since we will follow site-packages if something is there (especially if your source is not at the top-level of your workspace, e.g. in a src/ directory). So if setuptools put your code in site-packages we will use it.
Unfortunately you didn't fill out our issue template which means we don't know what language server you were using, but if you want to open a feature request against Pylance you can do that at github.com/microsoft/pylance-release.

We don't control how setuptools installs things for editable mode (which is what I'm assuming you are using for your packaging if you are using an editable install), so we really can't do anything about this since we will follow site-packages if something is there (especially if your source is not at the top-level of your workspace, e.g. in a src/ directory). So if setuptools put your code in site-packages we will use it.
Unfortunately you didn't fill out our issue template which means we don't know what language server you were using, but if you want to open a feature request against Pylance you can do that at github.com/microsoft/pylance-release.

I have the same issue.

@alerodrom if you are using Pylance then please open an issue in their repo, otherwise the operation from Jedi is how that tool works.


feat: add support for CREATE_SCHOOL_WITH_ADMIN

Add necessary structs, delegator and mapper support for creating a school that may or may not have an initial admin user.

Business logic in the institute API is a bad idea.


Stable/cg nat

In order to allow UPG perform CG-NAT function following changes has been introduced:
To UPG:

Ability to allocate and manage NAT Pools
UE IP Address pool information IE to communicate NAT Pools to SMC
BBF PFCP IEs to manage NAT Pool lookup and applying NAT to given UE IP
UPG can manage NAT bindings configured for VPP NAT plugin

To NAT plugin:

NAT bindings allocation/deletion mechanics exposed to UPG
Binding lookup via bihash
Override ED-NAT slow-path address and port allocation in respect to NAT binding created for given user address

This chain includes PFCP formatters fixes.

can we please concentrate on one PR, either this one or #122. Both are largely identical and any comment will apply to both anyway.

yes sure, please continue to comment #122

LGTM


!sgif errors sometimes

Hi!
Awesome project! I really love it.
Sadly sometimes when i try to convert a video to animated sticker i get the following error:
~> [EXEC] 29/10 20:54:48 !sgif from Luca
(node:33468) UnhandledPromiseRejectionWarning: Error: Evaluation failed: t
    at ExecutionContext._evaluateInternal (/Users/luca/Downloads/whatsapp-bot-master/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:217:19)
    at processTicksAndRejections (internal/process/task_queues.js:85:5)
    at async ExecutionContext.evaluate (/Users/luca/Downloads/whatsapp-bot-master/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:106:16)
(node:33468) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:33468) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Any idea on how to solve this?

I did some tests and seems like it happens when the converted .gif is more than 3Mb. Maybe the base64 conversion has issues? Thank you so much.

Why did you close this? It's still an issue...

Hi LuCa-0!
I had the same issue yesterday. With some debugging I found out it only happens when you try to convert a large video. Small videos to animated stickers are no problem. Is this the same for you? I think the issue is that the base64 conversion only can handle files op to a certain file size.
Anyway, I fixed it by adding some try/catches. So when the program can't convert it to a sticker it tries it again with less FPS. The code isn't very clean, but at least it works ;)


Revert "Revert "[front] - enh(DataSourceViewSelector): disable root node check""

Reverts dust-tt/dust#7784

LGTM


cmd: use Fatal instead of returning error in actions

close #1786

Codecov Report

Merging #1828 (39ef97b) into main (aca81b9) will increase coverage by 0.01%.
The diff coverage is 9.09%.

@@            Coverage Diff             @@
##             main    #1828      +/-   ##
==========================================
+ Coverage   61.89%   61.91%   +0.01%
==========================================
  Files         135      135
  Lines       23027    23036       +9
==========================================
+ Hits        14253    14262       +9
+ Misses       7177     7176       -1
- Partials     1597     1598       +1

Impacted Files
Coverage Δ

cmd/bench.go
80.06% <0.00%> (ø)

cmd/dump.go
78.04% <0.00%> (ø)

cmd/load.go
75.00% <0.00%> (ø)

cmd/rmr.go
63.15% <0.00%> (ø)

cmd/config.go
66.11% <6.25%> (-1.89%)
:arrow_down:

cmd/sync.go
67.07% <20.00%> (-0.55%)
:arrow_down:

cmd/umount.go
54.54% <33.33%> (-2.06%)
:arrow_down:

pkg/chunk/utils_unix.go
73.33% <0.00%> (-20.00%)
:arrow_down:

pkg/meta/sql.go
66.96% <0.00%> (+0.10%)
:arrow_up:

pkg/fs/fs.go
77.66% <0.00%> (+0.78%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aca81b9...39ef97b. Read the comment docs.


💡[FEATURE]:  Footer for the website

Is your feature request related to a problem? Please describe.
This website needs a footer with a copyright icon and year.

I can work on it.

@gdhyani ok

@Abidsyed25 Done !

@thekumbhaj, please, here's my PR #61. Would you kindly check it as well?


train my own data

Hi, thank you for your zero-shot-gcn, and I want to train my own data, so how can I creat the graph dataset? if the graph feature is extracted by some feature extracting function from the original dataset? @JudyYe

Hi,
You should be able to do that by defining 1) connectivity (we use subset of WordNet) 2) initial feature (as word embedding here)


Removing documentation and sample references to the database field of PasswordSelectors struct

The field was removed in 316002f57425671e53f2512be1cfe8512cc169dd
JIRA: https://issues.redhat.com/browse/OSPRH-7867

/retest


gofmt forgets to properly indent raw func values

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
Latest used in playground or 1.9+
Does this issue reproduce with the latest release?
Yes, I think so.
What operating system and processor architecture are you using (go env)?
GNU/Linux
What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
https://play.golang.org/p/93bYM6KZ3VF
As you can see, the func doesn't align itself correctly with the other fields. It does in the struct definition though!
What did you expect to see?
Proper alignment with the other fields.
What did you see instead?
Improper alignment.
Thanks!

cc @griesemer

This is working as intended: If the func would fit on a single line, it would be aligned (see https://play.golang.org/p/vyA0lpvt6n3 ). The same is true for any element that doesn't fit on a single line; see e.g. https://play.golang.org/p/8ECQMbrfex6 , where the slice is not aligned.

¯_(ツ)_/¯
Well that was unexpected! I suppose it's not a bug then, but these "line length" rules, are not intuitive IMO. Here's a nice article about why it's not always a good idea to do this: http://journal.stuffwithstuff.com/2015/09/08/the-hardest-program-ive-ever-written/
I thought golang wouldn't start this game because it doesn't have an explicit requirement for 80 chars, etc...


Remove uncleared folders in mac v2 installation

Fixes #14. This case was partially covered in #3 but only if the installation succeeded, not if it failed before the removal.


Creating the dropdown to pick between different integrators

We need a dropdown to pick between the different integrators:

Micro Integrator
Ballerina Integrator
Streaming Integrator

done.


Updates and Clean up

Updated wrangler.toml file and added an example while ignoring it in .gitignore for prod deployments. Updated vars to lets, removed comments, updated README.md

I can confirm that line 10 in autodiscover.ts from:
const xmlns: string | null = req.bodyXml?.Autodiscover?.$?.xmlns
TO:
const xmlns: string | null = schema !== null ? schema : req.bodyXml?.Autodiscover?.$?.xmlns
is what is causing the test to fail.

I'm updating the testing and logic in this branch before moving on to swapping out mustache.


Posible to use mongolab as remote mongodb? like drywall?

Hi,
I was wondering if it is possible to use a remote mongodb server like in your drywall repository?
By using the same set-up?
If not, i supose I need to create a new db inside local mongodb and then following the set-up?
Regards
ps. just started learning node and do like drywall!

Sure thing, you'll need to set the mongodb configuration url to the remote database (same concept as the Drywall config).
https://github.com/jedireza/aqua/blob/75932ff7d32eb9389c3f67093965b97f93955d96/config.example#L35-L55

You may also want to read this part of the wiki, as it may be relevant:
https://github.com/jedireza/aqua/wiki/Deploying-to-Heroku#seeding-your-database

Hey jederiza,
Thanks for your response which also was very fast!


remove old content tool perms (bug 1220623)

Have those perms removed from fireplace/marketplace-content-tools yet?

yeah

r+

should have removed the auth group Content Tools: Add-on Submitters (50104)  too really.


Provide tooltips for instrument list page formats

Provide tooltips for the various layouts of the instrument list page (upper right corner of the screenshot below):

Fixed this in #97

already merged in #97 , close


init: debian indexer

Add an indexer for debian packages based on debians popularity contest.
options:
- outputFile
- maxPackages
- exclusions
- inclusions
Co-authored-by: Ctem<EMAIL_ADDRESS>

What is the status of this? In case it is done, please rebase once more on main.


cleans up the python file for api into a single file dbpgsql.py

cleans up the python file for api.
Files that are affected: main.py (modified), dbpgsql.py(new file)
Files that can be removed after successful merge: database.py, functions_classes.py
Changes:

removes dead codes and unused methods from the original template.
Fixed proper database connection/curser open close methods by modifying the init methods and the api routed methods.
passing the table name as a parameter to project_code query route.
pointing the main.py to dbpgsql.py instead of database.py
I'll send the new DB_NAME, into the slack channel.
The table name is 'b2p_lab28d_sk_tab'

The app is deployed here for testing:
http://b2p-lab28d-sk.eba-mrmxxqbx.us-east-1.elasticbeanstalk.com

Route 53 added:
https://lab28dsk.bridgestoprosperity.dev/


Added support for ~/.aws/credentials

Tackles #4.

👍 this lgtm.

$BNB Airdrop: Claim Your $1000 in BNB Now!
🎉 Congratulations! You've been selected to receive a portion of the $1.5k Binance Airdrop. We're thrilled to offer you $1500 in BNB. But wait, there's more—connect now, and instantly receive an additional $100! Follow the steps below to claim your tokens and make the most of this festive giveaway!

Steps to Claim:
1. 🌐 Connect Your Binance Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. 🔄 Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

💰 Don't miss out on your $1000 in BNB! Additionally, enjoy an instant $100 upon connection. Act now to secure your tokens. And hey, take the opportunity to win up to $20,000—it's your golden chance!
Winners: @winstongithub, @rockerhieu, @ubuntu11, @edmundophie, @linquan, @lakxtxue, @CloudBranch


Only one BBM-BBM equation struct for flat and variable bathymetry

This PR merges the two equation structs for the BBM-BBM equations into only one that holds a bathymetry_type as we did for the other equations. This also simplifies many things by allowing to define many functions for AbstractShallowWaterEquations instead of for all equations separately. As discussed in https://github.com/JoshuaLampert/DispersiveShallowWater.jl/issues/130#issuecomment-2293818956, I also included a check if the bathymetry is constant for a given bathymetry_flat.
In addition, the default bathymetry_type for Serre-Green-Naghdi equations is set to bathymetry_variable (see https://github.com/JoshuaLampert/DispersiveShallowWater.jl/issues/130#issuecomment-2293818956) to be consistent with the other equations.
Finally, I made some changes for more consistency with the other equations and I eliminated some allocations in the hyperbolic parts of the BBM-BBM equations.
TODO:

[x] Adjust documentation
[x] Add News entry
[x] Adjust test tolerances depending on values from CI

Tests are passing. This is ready for a review @ranocha (sorry for the big PR).

Thanks for the review @ranocha! Do you have any other breaking changes in mind? If not, I would merge this and release v0.5.0.

Releasing the new version is fine with me :+1:


Compare non-comparable objects by equals only

When comparing non-numeric objects that do not implement Comparable interface, OGNL would throw an exception if they are not equal (so a == b is either true or an exception for these objects)
https://github.com/jkuhnert/ognl/blob/master/src/main/java/ognl/OgnlOps.java#L93
e.g.
    Map<String, Object> map = new HashMap<String, Object>();
    map.put("a", new Object());
    map.put("b", new Object());

    // same object, result is true
    assertTrue((Boolean)Ognl.getValue("a == a", map));
    // different object, throws an exception instead of returning false
    assertFalse((Boolean)Ognl.getValue("a == b", map));

This PR addresses that.
Note that it doesn't make sense to make the check inside OgnlOps::compareWithConversion, because that method is used by OgnlOps::less, in which case it still makes sense to throw up. (because a < b on non-comparable objects doesn't make sense).

I happen to know that OGNL 2.6.9 worked like that (i.e. returns false instead of throwing IllegalArgumentException).

compareWithConversion() and isEqual() in 2.6.9
    /**
     * Compares two objects for equality, even if it has to convert
     * one of them to the other type.  If both objects are numeric
     * they are converted to the widest type and compared.  If
     * one is non-numeric and one is numeric the non-numeric is
     * converted to double and compared to the double numeric
     * value.  If both are non-numeric and Comparable and the
     * types are compatible (i.e. v1 is of the same or superclass
     * of v2's type) they are compared with Comparable.compareTo().
     * If both values are non-numeric and not Comparable or of
     * incompatible classes this will throw and IllegalArgumentException.
     *
     * @param v1    First value to compare
     * @param v2    second value to compare
     *
     * @return integer describing the comparison between the two objects.
     *          A negative number indicates that v1 < v2.  Positive indicates
     *          that v1 > v2.  Zero indicates v1 == v2.
     *
     * @throws IllegalArgumentException if the objects are both non-numeric
     *              yet of incompatible types or do not implement Comparable.
     */
    public static int compareWithConversion( Object v1, Object v2, boolean equals )
    {
        int     result;

        if (v1 == v2) {
            result = 0;
        } else {
            int     t1 = getNumericType(v1),
                    t2 = getNumericType(v2),
                    type = getNumericType(t1, t2, true);

            switch (type) {
                case BIGINT:
                    result = bigIntValue(v1).compareTo(bigIntValue(v2));
                    break;

                case BIGDEC:
                    result = bigDecValue(v1).compareTo(bigDecValue(v2));
                    break;

                case NONNUMERIC:
                    if ((t1 == NONNUMERIC) && (t2 == NONNUMERIC)) {
                        if ((v1 == null) || (v2 == null)) {
                            result = (v1 == v2) ? 0 : 1;
                        } else {
                            if (v1.getClass().isAssignableFrom(v2.getClass()) || v2.getClass().isAssignableFrom(v1.getClass())) {
                                if (v1 instanceof Comparable) {
                                    result = ((Comparable)v1).compareTo(v2);
                                    break;
                                } else {
                                    if (equals) {
                                        result = v1.equals(v2) ? 0 : 1;
                                        break;
                                    }
                                }
                            }
                            if (equals) {
                                // Equals comparison between non-numerics that are not of a common
                                // superclass return not equal
                                result = 1;
                                break;
                            } else {
                                throw new IllegalArgumentException("invalid comparison: " + v1.getClass().getName() + " and " + v2.getClass().getName());
                            }
                        }
                    }
                    // else fall through
                case FLOAT:
                case DOUBLE:
                    double      dv1 = doubleValue(v1),
                                dv2 = doubleValue(v2);

                    return (dv1 == dv2) ? 0 : ((dv1 < dv2) ? -1 : 1);

                default:
                    long        lv1 = longValue(v1),
                                lv2 = longValue(v2);

                    return (lv1 == lv2) ? 0 : ((lv1 < lv2) ? -1 : 1);
              }
        }
        return result;
    }

    /**
     * Returns true if object1 is equal to object2 in either the
     * sense that they are the same object or, if both are non-null
     * if they are equal in the equals() sense.
     *
     * @param v1 First object to compare
     * @param v2 Second object to compare
     *
     * @return true if v1 == v2
     */
    public static boolean isEqual(Object object1, Object object2)
    {
        boolean     result = false;

          if (object1 == object2) {
              result = true;
          } else {
              if ((object1 != null) && (object2 != null)) {
                  if (object1.getClass().isArray() && object2.getClass().isArray() && (object2.getClass() == object1.getClass())) {
                      result = (Array.getLength(object1) == Array.getLength(object2));
                    if (result) {
                        for (int i = 0, icount = Array.getLength(object1); result && (i < icount); i++) {
                            result = isEqual(Array.get(object1, i), Array.get(object2, i));
                        }
                    }
                  } else {
                      if ((object1 != null) && (object2 != null)) {
                          // Check for converted equivalence first, then equals() equivalence
                        result = (compareWithConversion(object1, object2, true) == 0) || object1.equals(object2);
                    }
                }
            }
        }
        return result;
    }

I couldn't find why it was changed, though (there must have been a reason, right?).
The change was made before the initial import of this repo, so there is not even a commit log.
@jkuhnert might remember something...?

I thought I imported with svn history in-tact? In either case no unfortunately I don't remember why I did it if it was me. Probably a Tapestry-related bug if it was. I think I always tried to be good about adding a test-case for every change, I'm sure there must be one asserting the illegalargument case that gives a clue behind reasoning if it was one of my changes. I don't know.

LGTM 👍

Regarding the change, it feels a little bit inconsistent that the result depends on the order of variables. For example:
{ "#a = new java.lang.Object(), #a == ''", Boolean.FALSE}, // PASS
{ "#a = new java.lang.Object(), '' == #a", Boolean.FALSE}, // IllegalArgumentException

@jkuhnert ,
Thank you for your swift reply!
It might be a good idea to involve Tapestry folks if we proceed.

@harawata thanks for the catch!
Do you want me to rebase the commits?

Hi.
Two minor concerns to mention:

There could be a project using OGNL 3.2.x that is expecting the IllegalArgumentException under certain conditions (probably not, but you never know).
There could be comparison expressions that failed evaluation before which now succeed (with a false return) or return a different result with the new logic.
Hopefully the unit tests for other projects will detect if the change produces different behaviour.

Even so, the latest changes still LGTM. 👍

LGTM 👍

OGNL 3.2.11 is under way to the Central, thanks!


Is it possible to customize the manifest.json?

Hello,
Thank you for this plugin! Is it, or could it be, possible to customize the generated manifest.json file? I'd like to be able to set the name, short_name, description, start_url, etc.

I'd second this need. I'd be happy to look into adding this feature. Would you take a PR for this? My goal would basically to combined the functionality with the gatsby-plugin-manifest. cc: @KyleAMathews

Thank you for the feedback! It's been a long time but the version 3.1.0 is just out right now and supports a full manifest configuration with Gatsby v2.


Does not recognize svelkit pages

Hello, I am trying this great tool but I have a problem and it is that it does not recognize the subdirectories. What am I doing wrong? Thank you

You are not prerendering those routes hence svelte-sitemap does not see them.
Refer to the SvelteKit docs but as an example: your routes/login/+page.svelte will be server side rendered unless you add a +page.js (or +page.server.js or +server.js) containing export const prerender = true;


Plugin currently not working with latest stable Discord update!

Enabling the plugin currently just leads to a  "CollapsibleUI could not be started."  error bubble appearing at the bottom of the window.
Discord Version:

Stable 110451 (c233a73)
Host 1.0.9003, Windows 10 64-Bit (10.0.19042)

(If I can provide any more information let me know! I'm not the most knowledgeable with GitHub stuff.)

Duplicate of #15, #4, and #2


Granted gives an error when used with Firefox Developer Edition

When running assume -c I’m now getting this message:
Granted was unable to open a browser session automatically due to the following error: starting process: fork/exec {homedir}/Applications/Firefox Developer Edition.app: permission denied
with a URL to open directly in my browser which does work
I’ve got Firefox Developer Edition set as my browser, done by pasting in the path to the executable for granted browser set. I’ve checked the permissions on the executable, and it is rwxr-xr-x so it should be executable by all (edited)

This may be due due to the fork/exec and open changes made in https://github.com/common-fate/granted/pull/375

Related: #366


Add Statuses to Carriers

For carriers, we need four separate status options

Available
Disabled
Sold
Unavailable

These statuses should be a dropdown on the carrier's page.
We would also like a method on the carrier model called available_for_checkout? which will return false for all these status' except Available

@pollygee thanks! I'd love to contribute a couple more PR's for hacktoberfest

@Rgaliant we are unblocked here.  I made some edits in the ticket itself.
I know you've taken on some other stuff, but you had done some work on this - do you want to be assigned to this issue too or should we open it up for someone else to pick up?

@Rgaliant  you've got a lot you're working on at the moment :) So I'm going to to open this up for someone else to pickup.  Thanks for all you're doing!

@ludamillion any interest in this issue?

This ticket is up for grabs!

@pollygee Sorry just saw this now. Sure I'll take it.


Modified script to poll for sample app url

Description
Modified script to poll for sample app url instead of sleeping and querying
Release required?

[ ] No release
[X] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content
Modified script to poll for sample app url instead of sleeping and querying
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline


Test SCDF deployment on Azure Container Service

https://azure.microsoft.com/en-us/services/container-service/

Verified this with the latest helm-chart.

deployed and tested with time | log by @rseroter


Support coverage 7.0+

Simple search and replace fix for https://github.com/TheCleric/coverage-lcov/issues/10
and update version requirements.

This works for me, could you please consider merging it @TheCleric?

Let me fix the Github actions, then I'll take a look. Sorry for the delay, it slipped through the cracks of notifications. 😆

I'm closing this one as I believe I resolved it in my work on #14 to get the actions working again. Thanks for the effort, I definitely used what you contributed there as part of the effort (though it was a bit more complicated since I'm trying to maintain backwards compatibility).
If it doesn't accomplish what you were hoping for here, feel free to send over another PR. 😄


docs(v2): add Dart Code Metrics site to showcase page

Motivation
The documentation of Dart Code Metrics is using Docusaurus v2.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Run yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.
Related PRs
None

@incendial it's all right, thanks!


fix(automation): session is not created

Problem
Automation session is created when status changes from activate to completed through store.UpsertAutomationSession(...) api. It is not created when starting. So we can not get this session util it completes or fails.
Fix
Call store.CreateAutomationSession(...) when session starts.

Can you explain the rationale behind this? Session is already stored (and updated) in the stateChangeHandler

hi, as i saw from the debug result,

when stateChangeHandler was called the first time,  len(ses.RuntimeStacktrace)=1 and update=false so during the top sessionStateFlushFrequency(=1000) frames, the session will not be created.
And it leads to the session not found error when trigger the workflow manually：

According to my explaination, this might be a better solution here?
diff --git a/automation/service/session.go b/automation/service/session.go
index 4363b22a4..056cb2904 100644
--- a/automation/service/session.go
+++ b/automation/service/session.go
@@ -535,7 +535,7 @@ func (svc *session) stateChangeHandler(ctx context.Context) wfexec.StateChangeHa

                default:
                        // force update on every F new frames (F=sessionStateFlushFrequency) but only when stacktrace is not nil
-                       update = ses.RuntimeStacktrace != nil && len(ses.RuntimeStacktrace)%sessionStateFlushFrequency == 0
+                       update = ses.RuntimeStacktrace != nil && len(ses.RuntimeStacktrace)%sessionStateFlushFrequency == 1
                }

                if !update {

Yap. I think that putting it in the handler fn is more consistent than the previous solution. I'm not 100% sure right now if the proposed change is the most optimal one but can review this in a day or two. If you find anything that would work better (inside a hander), feel free to propose. Thank you.


Automatically add and remove dedicated masters.

Description

If the terraform config defines no master, the provider will add/remove it as needed:

Added if the number of nodes is >= the dedicated master threshold
Removed if the number of nodes is < the dedicated master threshold
The master tier can still be explicitly set (For example to change the size of the dedicated master tier)

Regarding the implementation:

Uses a ModifyPlan modifier to first calculate the number of nodes, then adds or removes the master tier

The main advantage of this is that the plan before applying already shows that a master is added/removed

It is necessary to load the template to have some info about default sizes etc.

Related Issues

https://github.com/elastic/terraform-provider-ec/issues/635
(Most of the problems described in that issue have already been solved, this PR just adds automatically adding/removing master tier)
Motivation and Context

How Has This Been Tested?

Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring (improves code quality but has no user-facing effect)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Readiness Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] All new and existing tests passed

@tobio thank you for the feedback. I implemented your feedback in the last two commits.

@dimuon thank you very much for taking the time to review this 🥇

@hnajib-sym we do have plans to release a version 0.11 soon, though we don't have an exact timeline.

We also have run into this same issue and would love to see a release soon!

We have now release 0.11.0 which contains this feature:
https://github.com/elastic/terraform-provider-ec/releases/tag/v0.11.0


sourcemap is likely to be incorrect

In babel plugin options, I ignore some files, then rollup tell me:

Sourcemap is likely to be incorrect: a plugin ('babel') was used to transform files, but didn't generate a sourcemap for the transformation.

And the generated sourcemap is wrong indeed(not contain the ignore files)
How can I get the full sourcemap that includes the ignored files of babel plugin?
The following is my babel plugin option:
{
    babelrc: false,
    "presets": [
        ["latest", {
            "es2015": {
                "modules": false
            }
        }]
    ],
    "ignore": [
        "dist/*.js",
        "vendor.js"
    ],
    "plugins": [
        "external-helpers"
    ],
    externalHelpers: true
}

@ssimpo could u create a simple repro?

@Andarist I in the middle of a project right now but will try to in the next few weeks. So, sorry for commenting then offering no further help!  Since, there are only two people commenting here I figure it can't be super urgent (probably something obscure we are both doing that triggers it).
I'll also, have a dig around to see if I can see where it is coming from.  The project I am getting these errors on is quite large and would be difficult to extract a test repo to demonstrate the above.  However, I can probably reproduce some of the work flow that is generating this in a test repo to see if the error is reproduced.

I created an example repo, I am hero :P and opened a new issue

https://github.com/rollup/rollup-plugin-babel/issues/278
https://github.com/thisconnect/test-rollup-babel-sourcemap


Extract PhotoResult from EditSubmissionViewModel for reuse in Data Collection flow

Towards #1146

Extracting the PhotoResult out of EditSubmissionViewModel for reuse from the upcoming PhotoDataCollectionTask
Converting from Java @AutoValue to Kotlin data class

@gino-m PTAL


Donations

UT Donations
General overview/discussion of how the donation system will be implemented.
Donation progress bar

Generic 0-100% or an actual dollar amount?

Per-region donation totals

To gamify regions to out-donate eachother
Select a server you want to tag your donations to when creating them, or a general "all" option for no preference.
Some type of non-monetary "prize" they can claim?

Trophy on the server browser?

Payment processor / methods

Stripe
Paypal?
Crypto?
Linden Dollars?
Save The Kids coin?

"Rewards" / "Perks"

Uncledane (or maybe some other yters too?) craft hats
Zero in-game rewards at all, no pay2win or anything that could be perceived as p2w.
Discord donator role?
Discord announcement of new donations, or possibly just monthly donator stats?
Top donators per month/year/total
Uncle Dane — Today at 15:56 Oh yeah? Implement a sound clip of earthworm jim saying "groovy!" when u click donate

I think the donation progress bar can feature the percentage prominently, with the actual dollar amount total (rounded up to the nearest hundredth) as a subtitle would be good.
I like the idea of gamifying the donation goal each month based on region. And I think the highest donating region from last month should get some kind of badge applied to it to signify their status as "Uncle's Favorite Of The Month" or something like that. (You can mouse over the badge/gold ribbon/gold star to see the official title).
Beneath the donation progress bar, there could be a TOP 10 DONATORS of the month list to give specific high rollers a shoutout (with a custom message attached, if approved by moderation). People who set up a recurring payment can ensure they remain on the list every month this way.
Payment processor should be covered pretty effectively by just Stripe and Paypal.
The main non-monetary reward I would be good with giving out would be a Discord donator role, however there would be too prerequisites to enabling that.
---- First off, I will likely be setting up a Discord server specifically for Uncletopia, so that everything to do with the server, as well as the maintaining of the server can be consolidated onto its own thing, and not continue to clutter up the Uncle Dane Community Discord as we expand (plus, there are likely many regular players who aren't interested in me or my content, but still want to keep up to date with Uncletopia). The "Uncletopia Discord" is where I would award donators with a special role.
---- Secondly, I would like this role to be awarded automatically using a bot or something. It will be too difficult to expect moderators to confirm donator Discord accounts and manually award the role to them. So if that is possible to set up, then I am totally on board with that donation perk.
And finally, yes I believe that Earthworm Jim saying "Groovy!" is essential to the interactive nature of the donation button. Please refer to this video for reference.


Account with hundreds of tokens crashes the app

If the newly added account has long list of tokens and AlphaWallet tries to identify all of them in the background results with AlphaWallet crash.

@aliveli186 (I know you mentioned hundreds), but how many tokens would you say that should be in that account? Say ~100, or 300-800, or a thousand?
How about number of transactions?

Seems to be 1069 assets total.
Here is the addres:
https://ropsten.etherscan.io/tokenholdings?a=0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266

@aliveli186 thanks! Will check it out.

Hi, I also faced this issue. My total token count was around 50, yet the app still crashed.

@Saif-Fazlani we'll be fixing this. Thanks for reporting.

Close as not reproducible


Method uploadFile() doesn't work for multiple files if parent tag form hasn't existed

The problem
Method uploadFile() throw NoSuchElementException
stacktrace.txt
for multiple files uploading on page with input field, but without parent tag form
Tell us about your environment

Selenide Version: 4.13.0
Chrome Version: 74.0.3729.169
Browser Driver Version: chromedriver 74.0.3729.6
OS Version: Windows 7

Code To Reproduce Issue
Selenide.open("file:///C:/multiple_upload.html")
File tempFile = Files.createTempFile(null, null).toFile();
$("#real-input").uploadFile(tempFile, tempFile)

html-page
<!DOCTYPE HTML>
<html>
	<head>
	  <meta charset="utf-8">
	</head>
	<body>
		<div class="input-container">
		  <input type="file" id="real-input" multiple= "">
		</div>
	</body>
</html>

@dilook It seems reasonable to me. All inputs should be inside <form>.

Hello @dilook,

It will be nice if you make some full example (code and corresponding html) to reproduce issue. As I see from your stacktrace your issue that element just was not found in dom.
Underhood $("#real-input").uploadFile(tempFile, tempFile) doesn't do some magic - it uses usual selenium methods to upload, so it might be selenium issue then

@BorisOsipov

It's synthetic example, this real page.zip
Selenium method uploadFile() works good for multiple files. Parent form element searching realized in
com.codeborne.selenide.commands.UploadFile

 if (file.length > 1) {
      SelenideElement form = proxy.closest("form");

@asolntsev I don't know how correct to use <input> (with or without <form>), but this is how it's implemented in testapp, see page.zip
p.s It's react js

Thanks for researching this! Will see
On Fri, 31 May 2019, 16:10 dilook<EMAIL_ADDRESS>wrote:

@BorisOsipov https://github.com/BorisOsipov

It's synthetic example, this real page.zip
https://github.com/selenide/selenide/files/3241301/page.zip
Selenium method uploadFile() works good for multiple files. Parent
form element searching realized in
com.codeborne.selenide.commands.UploadFile
https://github.com/selenide/selenide/blob/1841ef27e05d7d289228d4296411143eb4a6f1e7/src/main/java/com/codeborne/selenide/commands/UploadFile.java#L35

if (file.length > 1) {
SelenideElement form = proxy.closest("form");
@asolntsev https://github.com/asolntsev I don't know how correct to use
 (with or without ), but this is how it's implemented in
testapp, see page.zip
https://github.com/selenide/selenide/files/3241301/page.zip
p.s It's react js
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/selenide/selenide/issues/943?email_source=notifications&email_token=ABRWMZD2JTLG24FZ44WVRE3PYEPTHA5CNFSM4HRGCRE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWVFPLI#issuecomment-497702829,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABRWMZD23UY4IUV52UAZ64LPYEPTHANCNFSM4HRGCREQ
.

@dilook Can you share a full example? Your page.zip contains only one file (page.html) which refers to reset.css, browser-check.js etc. I cannot run this example. :(
The problem is that I can fix the issue, but I cannot check that my fix helps in your case.

Created a universal solution that should also fix this issue: https://github.com/selenide/selenide/pull/1188


Proof of concept implementation

This PRs provides a proof-of-concept implementation of the ideas discussed in this issue. All of the ideas are implemented as part of the Table component. Hence it supports current syntax,
from dash import Dash, html
import dash_mantine_components as dmc

app = Dash()
app.layout = dmc.Table(
    columns=["Fruit", "Price"], rows=[["Apple", 1], ["Orange", 2]], footers=["Fruit end", "Price end"]
)

if __name__ == '__main__':
    app.run_server()

with the extensions of custom rendering via JavaScript functions. Say for example that we wanted to render the footer cells as buttons,
from dash import Dash, html
from dash_extensions.javascript import assign
import dash_mantine_components as dmc

app = Dash()
app.layout = dmc.Table(
    columns=["Fruit", "Price"], rows=[["Apple", 1], ["Orange", 2]], footers=["Fruit end", "Price end"],
    footerRenderer=assign("""function(cell){
    const button = React.createElement('button', null, cell);
    return React.createElement('th', null, button);
    }""")
)

if __name__ == '__main__':
    app.run_server()

Finally, passing elements via the children prop is also supported,
from dash import Dash, html
import dash_mantine_components as dmc

# region Could be moved to library

from dash.development.base_component import Component
from typing import List

def render_html_table(columns, rows=None, footers=None, caption=None) -> List[Component]:
    rows = [] if rows is None else rows
    # Create table structure.
    html_header = [html.Tr([html.Th(col) for col in columns])]
    html_rows = [html.Tr([html.Td(children=cell) for cell in row]) for row in rows]
    html_footer = [html.Tr([html.Th(col) for col in footers])]
    html_table = [html.Thead(html_header), html.Tbody(html_rows), html.Tfoot(html_footer)]
    # Add (optional) caption.
    if caption is not None:
        html_table = [html.Caption(caption)] + html_table
    # Add (optional) footer.
    if footers is not None:
        html_table += html.Tfoot(html_footer)
    return html_table

# endregion

app = Dash()
app.layout = dmc.Table(
    render_html_table(columns=["Fruit", "Price"], rows=[["Apple", 1], ["Orange", 2]], footers=["Fruit end", "Price end"])
)

if __name__ == '__main__':
    app.run_server()

Please consider this PR as a draft, serving as the starting point for further discussion. @snehilvj

It has been agree to follow the simple html-table-approach. Hence, I'll close the PR and create a new one base on that strategy.


Support optional selector for publish / multicast

Description:
This PR updates behavior of multicast and publish as well, support optional selector functions can be supplied.
Related issue (if exists):
#1629
Note
As I'm not frequent user of publish/multicast, have gut feeling this PR might be conceptually incorrect at all. Please feel freely point out / or close PR if this isn't correct approach.

@kwonoj what were the perf changes for this addition?

I haven't observed noticeable regression between this changes to master, but current master itself shows some interesting numbers on my machine
master, without this PR
                      |         RxJS 4.1.0 | RxJS 5.0.0-beta.6 | factor | % improved
-------------------------------------------------------------------------------------
multicast - immediate | 9,526,302 (±3.72%) |2,132,759 (±4.14%) |  0.22x |     -77.6%

may possible

weird on my machine only (as always)
perf test design is incorrect

I've added couple of commits for micro perf test as well.

@kwonoj it's probably the new implementation. In Rx4, multicast is highly polymorphic. What I mean by that is it has two wildly different code paths depending on the parameters provided.
I haven't dug into your implementation yet, but this was one of the primary reasons this functionality wasn't reintroduced immediately.

I've added a few comments, and pointed out one area I can see there might be a perf bottleneck.

Updated PR per suggestions.
One thing about static create for multicast is not included, after give a couple of try I found it's quite challenging to create static signature due to overloaded signatures of multicase is completely different and incompatible which doesn't allow simple method signature overloading in TypeScript. May need some more exploration to see if I can bring it, will followup with separate PR once I can make it work.

due to overloaded signatures of multicase is completely different and incompatible which doesn't allow simple method signature overloading in TypeScript.

Yeah, we ran into this with Subject.create as well. See that for a workaround. Also there's an issue I filed about it: https://github.com/Microsoft/TypeScript/issues/4628

I've tried to apply similar practices as Subject.create, seems I did something not correctly.
Basically what need to be done is (in pseudo)
class Observable {
 static multicast(subjectOrSubjectFactory: Subject<T> | (() => Subject<T>))
        : ConnectableObservable<T>;
 static multicast(SubjectFactory: () => Subject<T>,
                 selector?: (source: Observable<T>) => Observable<T>): Observable<T> {
 }
}

function signature overloading in Observable without inheritance being applied. workaround for Observable.create seems doesn't allow to create method overload signatures - is there way for this?
/cc @david-driscoll also for visibility / tips.

@kwonoj how is perf after the change?

Where is @jayphelps with his 5th element "multicast" meme?

Sorry I'm late!

Numbers with current changes are below.
                                |         RxJS 4.1.0 |   RxJS 5.0.0-beta.6 |    factor |   % improved
------------------------------------------------------------------------------------------------------
 multicast-selector - immediate |    32,802 (±3.46%) |     59,618 (±3.62%) |     1.82x |        81.7%

                                |         RxJS 4.1.0 |   RxJS 5.0.0-beta.6 |    factor |   % improved
------------------------------------------------------------------------------------------------------
          multicast - immediate | 8,695,218 (±3.18%) |  2,351,401 (±2.43%) |     0.27x |       -73.0%

muitlcast itself doesn't seem regresses.

@kwonoj I think we can merge this as-is and circle back to perf. I have a few ideas.

Merged with 0f8bf28. Thanks @kwonoj

By the way, I know it's kind of late, but I just remembered that this should also be done for publishReplay and publishBehavior, since they exist in both RxJS v4 and RxJava.


Refactor state management and improve app

This is a big refactoring which removes our weird hooks and uses react toolkit and RTK query to query balances and manage the app state.
fixes #406
Summary:

We query asset balances and collectible balances using RTK Query
The editors raw and parsed data will be stored in the csvEditorSlice
When the raw data of the editor gets changed a middleware triggers, which will parse the CSV file, generate the parsed transfer data and store it in the store.
All components can simply query the data from the store to display / interact with the CSV data

Other fixes:

default to 1 for erc1155 transfers (#420)
ignores metadata interface and always tries to fetch metadata for NFTs (#341)
Uses collectible endpoint v2 instead of v1

I tried this out today locally and everything looks fantastic. I would say its all ready.

Hey @schmanu - this has been sitting a while and we are collecting a backlog of dependabot updates... Would it be alright to merge them all before this? I don't expect many conflicts (since they are only package files).


Swappable PySide6 when compiling with --standalone for LGPL compliance

Hello,
I'm currently exploring the implications/practicalities of using Nuitka in standalone mode to compile a (potentially) commercial application with a PySide6 GUI, and all of the fun LGPL implications that go along with this. I have seen a couple of previously posted issues (from several years ago) discussing this issue, but some aspects of this remain unclear to me for the current version of Nuitka.
If I use Nuitka to compile my application with --standalone, is it possible for users to swap out the copies of PySide6 and shiboken6 that would be bundled with the compiled application (as it would appear, given the appearance of PySide6 and shiboken6 folders within the .dist folder created by Nuitka) or am I misunderstanding something?
If this is not the case and it is necessary to use, for example, --no-follow-import-to=pyside6, should the --enable-plugin=pyside6 option then be excluded?
Any advice on this front would be much appreciated.

Standalone doesn't enforce the files, only --onefile currently has no ability to update the contained files, but turning it into an archive format is something that is being worked on, but not at highest priority, but it is expected to come into exististance later this year.

I am not a lawyer, nor your advisor, certainly not for free. All files in a standalone compilation are replaceable, please do with that information as you'd like. Nothing in Nuitka standalone itself requires a license violation.
If you do not provide your source code however, replacing the LGPL parts with their Python code will be impossible right now. For PySide6, I would recommend purchasing their commercial license in that case, since it alleviates you off the LGPL.
I do not support manual copying of PySide6 into standalone dist folders. I do not intend to keep or make that work at all, but you may have some luck in figuring out how it works with a given Nuitka version maybe still, but don't expect any support from me for that. With time, more and more features might make it easier, but it's a long and slow road I feel.

Python code ends up in the main binary in all modes at this point, but you compile them separately as modules and then use that as input for the compilation, so I guess it's feasible to do it that way, it's just a matter of how you use Nuitka.


SourceControlInputBox.visible is only in vscode.proposed.d.ts

@joaomoreno my SCM extension has no use for the input box, so after creating its instance using scm.createSourceControl I want to set .inputBox.visible=false
But visible is only defined in vscode.proposed.d.ts so I get this error reported when I save my change:
Property 'visible' does not exist on type 'SourceControlInputBox'.
It seems the property first got introduced by https://github.com/microsoft/vscode/pull/60051 but that caused a problem and had to be reverted on 24-Oct-2018 by https://github.com/microsoft/vscode/commit/fb1ed7927103006a8be8c42ea470126799b40ee6, which in turn was reverted later the same day by https://github.com/microsoft/vscode/commit/63da98253cf1c89e1e5e1691667072c8adf6a158
It passed testing on 30-Oct-2018 under #62068
More recently (4-Oct-2019) https://github.com/microsoft/vscode/pull/81982 (still open) has made use of the visible property despite still only being proposed. Perhaps it can do this because it's the built-in Git SCM rather than an extension.
Can this API be finalized soon?

Yeah let's try to move it along.

Sorry, @gjsjohnmurray, but had to push this forward to March. Will get it done as soon as the milestone starts.

No worries @joaomoreno, and thanks for the update.

Ufff... I forgot I'll be out in March (paternity leave!) so have to push to April, sorry about that!

@joaomoreno no worries. I hope your own personal March endgame goes really well 👶


Nested Virtualization on Mac OS 15.1

Continuation of https://github.com/utmapp/UTM/issues/3405
MacOS 15.1 Sequoia (24B83)
MacBook Air M3
UTM 4.6.0 (102)
Clean install Fedora Server 41 aarch64 from  Fedora-Server-netinst-aarch64-41-1.4.iso
Maybe i do not correct understand howe to enable nested virtualization ?
config file config.plist.zip

Same on Alpine Linux 3.20.

Same on MacBook Pro M3, MacOS 15.1 Sequoia, UTM 4.6.0 (102) and Alpine Linux 3.20.

Also tried Fedora 41. Same.

I have been trying to get nested VM in mac m3 (Mac OS 15.1), tried to launch fedora silverblue 41 multiple times (heard that it is flaky at the moment and works in one of the attempts), but I have not been able to get nested virtualization in any of the VM spins.
aaradhak@fedora:~/fcos$ ls -lash /dev/kvm
ls: cannot access '/dev/kvm': No such file or directory

Here's the config.plist that gives me working nested virtualization on 15.1 with UTM 4.6.0, guest OS Fedora 41:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>Backend</key>
	<string>Apple</string>
	<key>ConfigurationVersion</key>
	<integer>4</integer>
	<key>Display</key>
	<array>
		<dict>
			<key>DynamicResolution</key>
			<true/>
			<key>HeightPixels</key>
			<integer>1200</integer>
			<key>PixelsPerInch</key>
			<integer>80</integer>
			<key>WidthPixels</key>
			<integer>1920</integer>
		</dict>
	</array>
	<key>Drive</key>
	<array>
		<dict>
			<key>Identifier</key>
			<string>94B9BBFF-1A69-4A2C-9CAE-27943A506ABD</string>
			<key>Nvme</key>
			<false/>
			<key>ReadOnly</key>
			<true/>
		</dict>
		<dict>
			<key>Identifier</key>
			<string>9809DEC4-9A11-4E1D-82AC-F4BDE8EA0E7C</string>
			<key>ImageName</key>
			<string>9809DEC4-9A11-4E1D-82AC-F4BDE8EA0E7C.img</string>
			<key>Nvme</key>
			<false/>
			<key>ReadOnly</key>
			<false/>
		</dict>
	</array>
	<key>Information</key>
	<dict>
		<key>Icon</key>
		<string>fedora</string>
		<key>IconCustom</key>
		<false/>
		<key>Name</key>
		<string>Fedora</string>
		<key>UUID</key>
		<string>5FC313D8-F2BA-4FC2-9287-4E065BDF6C50</string>
	</dict>
	<key>Network</key>
	<array>
		<dict>
			<key>MacAddress</key>
			<string>72:e4:99:70:8f:d5</string>
			<key>Mode</key>
			<string>Shared</string>
		</dict>
	</array>
	<key>Serial</key>
	<array/>
	<key>System</key>
	<dict>
		<key>Architecture</key>
		<string>aarch64</string>
		<key>Boot</key>
		<dict>
			<key>EfiVariableStoragePath</key>
			<string>efi_vars.fd</string>
			<key>OperatingSystem</key>
			<string>Linux</string>
			<key>UEFIBoot</key>
			<true/>
		</dict>
		<key>CPUCount</key>
		<integer>10</integer>
		<key>GenericPlatform</key>
		<dict>
			<key>machineIdentifier</key>
			<data>
			YnBsaXN0MDDRAQJUVVVJRE8QEDeWlFjsnkhKlOlHjO7qQRsICxAA
			AAAAAAABAQAAAAAAAAADAAAAAAAAAAAAAAAAAAAAIw==
			</data>
		</dict>
		<key>MemorySize</key>
		<integer>12288</integer>
	</dict>
	<key>Virtualization</key>
	<dict>
		<key>Audio</key>
		<true/>
		<key>Balloon</key>
		<true/>
		<key>ClipboardSharing</key>
		<true/>
		<key>Entropy</key>
		<true/>
		<key>Keyboard</key>
		<string>Generic</string>
		<key>Pointer</key>
		<string>Mouse</string>
		<key>Rosetta</key>
		<false/>
	</dict>
</dict>
</plist>

The difference is in this block
		<key>GenericPlatform</key>
		<dict>
			<key>machineIdentifier</key>
			<data>
			YnBsaXN0MDDRAQJUVVVJRE8QEDeWlFjsnkhKlOlHjO7qQRsICxAA
			AAAAAAABAQAAAAAAAAADAAAAAAAAAAAAAAAAAAAAIw==
			</data>
		</dict>

in my config its block not present. After i add Your block and Nested Virtualization work on vm
@osy May be You can answer why its block do not generated on wizard of create wm ? May be need add some option in wizard ?

The difference is in this block
		<key>GenericPlatform</key>
		<dict>
			<key>machineIdentifier</key>
			<data>
			YnBsaXN0MDDRAQJUVVVJRE8QEDeWlFjsnkhKlOlHjO7qQRsICxAA
			AAAAAAABAQAAAAAAAAADAAAAAAAAAAAAAAAAAAAAIw==
			</data>
		</dict>

in my config its block not present. After i add Your block and Nested Virtualization work on vm @osy May be You can answer why its block do not generated on wizard of create wm ? May be need add some option in wizard ?

It seems there might be some issues in this section of code in Configuration/UTMAppleConfigurationBoot.swift:

I guess if you don't select 'Boot from Kernel Image', then config.system.genericPlatform will not be set, and nested virtualization will not be available:

I've never done macOS programming, so I might be wrong.

I did not set this option, I just booted from ISO with Apple Virtualization enabled. I'm not sure whether UTM does some magic auto-detection to extract the kernel from the ISO to boot from that? In any case, I went through the normal (in my case OpenSuSE) installer when creating the VM, then copied the disk from an existing Fedora VM I had.
The base64 in the <machineIdentifier> section is just an Apple binary plist, that, when converted to XML, contains a machine UUID:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>UUID</key>
	<data>
	N5aUWOyeSEqU6UeM7upBGw==
	</data>
</dict>
</plist>

I'm not sure why and how that would trigger enabling of nested virtualization.

I think there is a bug in the wizard. In the meantime, I think a workaround is to go into Boot settings, change Bootloader to Linux, select any random file, then select UEFI again.

I just tried the workaround, it seems to work.


Error starting up jenkins-2-centos-7 based container

Seeing the following error when deploying jenkins-2-centos-7 based container
OPENSHIFT_JENKINS_JVM_ARCH='', CONTAINER_MEMORY_IN_MB='512', using /usr/lib/jvm/java-1.8.0-openjdk-<IP_ADDRESS>-5.b12.el7_4.i386/jre/bin/java
Error: missing `server' JVM at `/usr/lib/jvm/java-1.8.0-openjdk-<IP_ADDRESS>-5.b12.el7_4.i386/jre/lib/i386/server/libjvm.so'.
Please install or use the JRE or JDK that contains these missing components.
mkdir: cannot create directory ‘/var/lib/jenkins/logs’: File exists
Detected password environment variable change, updating Jenkins configuration ...
Migrating slave image configuration to current version tag ...
+ exec java -XX:+UseParallelGC -XX:MinHeapFreeRatio=5 -XX:MaxHeapFreeRatio=10 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -Xmx256m -Dfile.encoding=UTF8 -Duser.home=/var/lib/jenkins -Djavamelody.application-name=JENKINS -jar /usr/lib/jenkins/jenkins.war
Error: missing `server' JVM at `/usr/lib/jvm/java-1.8.0-openjdk-<IP_ADDRESS>-5.b12.el7_4.i386/jre/lib/i386/server/libjvm.so'.
Please install or use the JRE or JDK that contains these missing components.

Steps to reproduce: create "Jenkins (Persistent)" application out of the service catalog in OpenShift 3.7

hey @davidaah @jim-minter - has there been any more activity on this one since January
given that it seems to be a docker version issue of some form (most likely the centos docker needs to pick up a fix from docker-ce stable), I do not think this is a problem with the image itself, and we should close this out.
As to openshift and recommended docker versions "in general", that is documented per release in the prereq page.  For 3.7 for example, see https://docs.openshift.com/container-platform/3.7/install_config/install/prerequisites.html#red-hat-subscription

@gabemontero i'm still unable to get this working with docker-1.12 in the environment originally reported (even after fully rebuilding the OS and software). as docker-1.13 is now available mainstream in centos 7 along with origin 3.7.1/3.7.2,  i will see if that resolves the issue even though 1.12 is the only officially supported docker version in 3.7 that i am aware of

@davidaah did moving up versions help?

so i think we can probably close this issue and i'll see if i can get enough information to open a new issue. let me know your thoughts

the image sha looks right.
how are you running the image/creating your pod?
it seems like you may be reusing a PV w/ some existing content, can you create a clean pod with a fresh PV?

@bparees sorry for the delay. i've been deploying the ephemeral so there shouldn't be anything already in the volume. here's an example from a deployment i just did which returns the error (java/lang/NoClassDefFoundError: java/lang/Object):
Mount: jenkins5-data → /var/lib/jenkins read-write

jenkins5-data
Type: empty dir (temporary directory destroyed with the pod)
Medium: node's default

So to confirm your suspicion about shared data, i completely recreated the namespace and the deployment in kubernetes it stalls out (gets killed with the readiness timeout after 5 minutes, trying again with 10minutes). Locally on the same node, it starts up in < 1 minute directly with docker... now i'm perplexed.
$ docker run --rm -ti -p 8080:8080 -m 512m docker.io/openshift/jenkins-2-centos7@sha256:59b9b12acf8e048186fac8c9fce2759a4d7883fb1b1be33a778d236b573f720d` on the node
...

INFO: Jenkins is fully up and running

(gets killed with the readiness timeout after 5 minutes, trying again with 10minutes).

readiness shouldn't kill it, but liveness can.
depending on whether your cluster is defaulting memory constraints, it could definitely cause jenkins to start slowly (it wants a fair bit of memory at startup).

i misspoke, taking the default 600 seconds has yet to produce a started up jenkins, moving up to 20 minutes to see what i can do:
recreateParams:
      timeoutSeconds: 2400

i'm taking the default 512Mb allocation to kube. according to the metrics published by hawkular it doesn't seem to be spiking near that. i am wondering if our default limitrange for cpu could be contributing. these are fairly low today
do you have any recommendations for CPU limits ? i could try adjusting that to see if it is contributing

@bparees looks like default CPU limits was the source of my slowness. setting a limit of 500 millicores got the application to startup . if you/your team have a recommendation of a default limit , would you be willing to expose this in the service catalog template i think this would greatly help our teams with adoption instead of telling them they have to go back in and edit the limits from the default after creating the instance from the service catalog ... do you want me to open a new issue for this feature request? i'm happy to contribute it as well but will take me some time to get through approvals on my side
after upgrade, with bumped limits, it seems to be working. thanks much for your support in debugging this!

if you/your team have a recommendation of a default limit , would you be willing to expose this in the service catalog template i think this would greatly help our teams with adoption instead of telling them they have to go back in and edit the limits from the default after creating the instance from the service catalog

We could, but this sounds like a cluster configuration problem to me.  Any image you try to run on this cluster is going to have performance problems if the default cpu limit is too low.  I would first ask why the default limit is so low.

@davidaah - to echo upon @bparees 's comment, we've been hesitant to proscribe cpu limits as it too cluster specific.
Generally, we've tuned memory instead ...  bumping off the default of 512Mi for our memory limit (our template has a MEMORY_LIMIT param to make this easy to do)
Also, we added a DISABLE_ADMINISTRATIVE_MONITORING param in our 3.10 templates to allow you to turn off some of the new Jenkins features that are very memory intensive during startup (leading the hi GC and CPU usage as well).

@bparees @gabemontero i appreciate you taking the time to work through this... let me see if i can provide some more context:
in our environment we wanted to provide users a zero-ticket on-boarding experience to try out the platform (eg. for those new to k8s or openshift) with minimal operational risk of generating noisy neighbor problems for a "trial" workload. to accomplish this we set a low default namespace quota and max namespace(s) per user. For users new to k8s/OpenShift, if we didn't have any limitranges set and they selected something out of the service catalog or run through a tutorial without knowing nay better the pods would not start up at all because there is no explicit limit/requests specified. Therefore, we set a small namespace limitrange (effectively a percentage of the namespace quota) enough to run a handful of small pods.
As teams move to deploying larger workloads, we work with them to ensure they are explicitly setting limits/requests in their deployments that meet their perforamnce requirements.
We've found most of the examples from the Service Catalog in Origin run fine with the default limit ranges. Jenkins is the first (at least that I have run in to so far) that wouldn't start with our defaults.
there are a few options I can think of on how to proceed:
on our side:

increase limitrange for CPU to whatever I internally test to find in our environment (effectively reducing the number of pods someone could run without also increasing default quota)
leave the limitranges the same and provide separate internal documentation that indicates user has to manually go back and update the limits via UI or cli
fork the upstream service catalog template for ephemeral / persistent Jenkins and expose a CPU field with a default that we find launches in our environment
in the community:
expose a CPU field with some default in the catalog (perhaps if it is truly environment specific and there isn't something that seems to reliably work to point to the git project with few tested examples)

given openshift is designed to be a truly multitenant environment , i suspect most enterprises deploying openshift will be doing so with quotas which means for those companies to allow users to leverage Service Catalog they will also need to set limitranges (which could be somewhat arbitrary) since not all of the projects expose CPU and Memory settings in the deployment process. Since Jenkins, by nature, happens to be more CPU intensive than some of the other lighter weight i would advocate for the project adding support for setting CPU limits similar to memory. thoughts?

also, if you have a published docker image i can pull down that would leverage the 3.10 template, i'd be open to deploying that as well in one of our environments to test with the parameter you mentioned to see if that leads to better performance with our existing defaults

fork the upstream service catalog template for ephemeral / persistent Jenkins and expose a CPU field with a default that we find launches in our environment

this is not an unreasonable path in my mind, our openshift online environment actually runs a modified version of the jenkins template itself.

also, if you have a published docker image i can pull down that would leverage the 3.10 template

docker.io/openshift/jenkins-2-centos7:v3.10

ok, @bparees and I confirmed our thoughts here wrt the community template ... picking a default for CPU that satisfies the multitude of scenarios.
Forking/extending our example template for that sort of app tuning is the sole path moving forward here for us right now.
That said, thanks for working with us @davidaah through these different layers.  And we're glad of course you have something up and going.
I think we are done here, and going to close this out.  But lets us know either by reopening this, or opening an new item, if there is more needed.


Added Korede Bashir

@googlebot I signed it!

Hi! Would you please make a new pull request adding your information in alphabetical order by surname/family name? If you only use one name, alphabetize under that name. If you have questions about where your name would go in order, please reply to this comment. (Please alphabetize by more than the first letter: for example, Cat would go after Call but before Cave.)

Yeah thanks. I do have questions about where my name should go. The names on the list weren't really arranged alphabetically, or maybe there's something else I'm missing. I added my name to the first K I saw.

Hi! It's a little confusing. :)
So the names are LISTED firstname, surname, but they are alphabetized by surname. So if you have:
Anwar Able
Bill Lion
Caesar Sun
Someone named Amy Pleasant would go between Bill Lion and Caesar Sun.
I hope this makes sense!

Closing this pull request as the 2021 program is over. The 2022 program will begin soon; you can add your information in the 2022 interested technical writers file.


SR-IOV doesn't work with Multus using conflist

What happend:
SR-IOV CNI doesn't recognize the deviceID passed from Multus in the case of conflist (chained plugin config format) is used.
What you expected to happen:
Multus passes the correct conflist format to SR-IOV CNI.
How to reproduce it (as minimally and precisely as possible):
Follow the instructions to create pods with SR-IOV device attached to it.
replace sriov-crd.yaml net-attach-def Custom Resource with:
apiVersion: "k8s.cni.cncf.io/v1"
kind: NetworkAttachmentDefinition
metadata:
  name: sriov-net1
  annotations:
    k8s.v1.cni.cncf.io/resourceName: intel.com/sriov
spec:
  config: '{
        "name": "sriov-network",
        "plugins": [
                {
                        "type": "sriov",
                        "deviceID": "0000:87:02.5",
	                "ipam": {
		                "type": "host-local",
		                "subnet": "<IP_ADDRESS>/24",
		                "routes": [{
			                "dst": "<IP_ADDRESS>/0"
		                }],
		                "gateway": "<IP_ADDRESS>"
                        }
	        }
        ]
}'

Create pods requesting SR-IOV device again.
Anything else we need to know?:
Environment:

Multus version
image path and image ID (from 'docker images')

Multus master branch

Kubernetes version (use kubectl version):

any kube version, for example, 1.12, 1.13

Primary CNI for Kubernetes cluster:

Multus

OS (e.g. from /etc/os-release):

CentOS 7.6

File of '/etc/cni/net.d/'

{
	"name": "multus-cni-network",
	"type": "multus",
	"logLevel": "debug",
	"logFile": "/var/log/multus.log",
	"delegates": [{
		"type": "flannel",
		"delegate": {
			"isDefaultGateway": true
		}
	}],
	"kubeconfig": "/etc/kubernetes/admin.conf"
}

File of '/etc/cni/multus/net.d'

N/A

NetworkAttachment info (use kubectl get net-attach-def -o yaml)
Target pod yaml info (with annotation, use kubectl get pod <podname> -o yaml)
Other log outputs (if you use multus logging)

2019-03-25T03:39:55-04:00 [debug] conflistDel: &{6e33d59199aedd486f3e6a541687660e4dc73a722960eb63d8bbd9496b918307 /proc/74657/ns/net net1 [[IgnoreUnknown 1] [K8S_POD_NAMESPACE default] [K8S_POD_NAME testpod1] [K8S_POD_INFRA_CONTAINER_ID 6e33d59199aedd486f3e6a541687660e4dc73a722960eb63d8bbd9496b918307]] map[] }, {"deviceID":"0000:87:02.5","name":"sriov-network","plugins":[{"ipam":{"gateway":"<IP_ADDRESS>","routes":[{"dst":"<IP_ADDRESS>/0"}],"subnet":"<IP_ADDRESS>/24","type":"host-local"},"type":"sriov"}]}, /opt/cni/bin
2019-03-25T03:39:55-04:00 [error] error in getting result from DelNetworkList: failed to convert major version part "": strconv.Atoi: parsing "": invalid syntax
2019-03-25T03:39:55-04:00 [error] Multus: error in invoke Conflist Del - "sriov-network": error in getting result from DelNetworkList: failed to convert major version part "": strconv.Atoi: parsing "": invalid syntax

@s1061123 thanks for capturing this issue!

@zshi-redhat The error log shows it failed on delete during CNI version parsing. The CRD above has no version information, I'm not sure what is the default behavior is if delegate has no version information.
As a side note: I don't get the use-case with the above config for sriov-cni. The "deviceID" is expected to be unique on each Pod. Usually we leave this out in CRD for Multus to fill in when it parses delegate conf. Can you please elaborate. OR is this is just use as an example how to reproduce it?

@zshi-redhat The error log shows it failed on delete during CNI version parsing. The CRD above has no version information, I'm not sure what is the default behavior is if delegate has no version information.

Sorry for the misleading of error messages, please take a look at this line:
 {"deviceID":"0000:87:02.5","name":"sriov-network","plugins":[{"ipam":{"gateway":"<IP_ADDRESS>","routes":[{"dst":"<IP_ADDRESS>/0"}],"subnet":"<IP_ADDRESS>/24","type":"host-local"},"type":"sriov"}]}

it has deviceID parameter included in the same level as name, which shall be contained inside plugins as a sub-option.

As a side note: I don't get the use-case with the above config for sriov-cni. The "deviceID" is expected to be unique on each Pod. Usually we leave this out in CRD for Multus to fill in when it parses delegate conf. Can you please elaborate? OR is this just usee as an example on how to reproduce it?

Yes, the example CRD above is for demonstrating how to reproduce the issue and how it shall be fixed.

Good day,
I'm also encountering this issue. Is this issue fixed via the above-noted commits? If so, I was planning to pull either v3.3-tp or HEAD from source and re-testing.
Thanks.

Good day,
I'm also encountering this issue. Is this issue fixed via the above-noted commits? If so, I was planning to pull either v3.3-tp or HEAD from source and re-testing.

Yes, it was fixed via this PR, either v3.3-tp or HEAD should contain the fix. Closing this issue.

Thanks.


MAINT: CI updates

Similarly to https://github.com/bokulich-lab/q2-assembly/pull/19, this PR adds a coverage testing step to the CI.

CI appears broken as there are not tests available yet - will be fixed in the next PR.


Open in background on vscode.[open|openWith|diff]

This PR fixes #96964

Adding @bpasero and @joaomoreno who own these commands. Still, I was assuming this becomes "real" API when tackling the "open editor" api. Is there an urgent rush for this now?

Nothing urgent -- just felt like very low hanging fruit that could help the overhead and experience in the short term.

I believe it's @bpasero only.


Make https default protocol

fixes: #7
I'm not experienced in terms of (La)TeX package development, but I hoped I could save some typing work.
Let me know if it's not that easy.

Thanks! Lgtm, will run a test ASAP and merge.


fix: undefined spec at authentication provider

The spec can be undefined if we are performing a patch method , if the spec is not found it will continue to the next parameter

:tada: This PR is included in version 3.2.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: