VideoPlayerController is not disposing.

So when navigating to another page video is still playing.

Solved in Android. iOS crash all others controllers when disposing a controller.


Icons for NavBottom

Right now, I just have text. I think we will want icons for:

Home
Taxes
Services
Report

related to #13

@VictoriaODell here are the icons for the tab bar
PNGs.zip

@brainnews 👌

Can we get them in svgs too @briannews?
Might be helpful if we want to change the colors or later add hover styling for desktop

SVGs:
SVG.zip

You're a ⭐  @brainnews


No module named '_curses'

First of all, thanks a lot for your work. epr looks fantastic and I can't wait to be able to use it.
I was trying to install it on SailfishOS using pip but I got an error during installation related to _curses module missing. I tried also to execute the epr.py file directly fetched from git, but I get a similar issue:
[nemo@Sailfish Downloads]$ python3 epr.py
Traceback (most recent call last):
  File "epr.py", line 50, in <module>
    import curses
  File "/usr/lib/python3.8/curses/__init__.py", line 13, in <module>
    from _curses import *
ModuleNotFoundError: No module named '_curses'

Here are the ncurses packages I have currently instaled:
Information for package ncurses:
--------------------------------
Repository     : jolla
Name           : ncurses
Version        : 6.1+git1-1.4.1.jolla
Arch           : armv7hl
Vendor         : meego
Installed Size : 167.7 KiB
Installed      : Yes (automatically)
Status         : up-to-date
Source package : ncurses-6.1+git1-1.4.1.jolla.src
Summary        : Ncurses support utilities

Information for package ncurses-base:
-------------------------------------
Repository     : jolla
Name           : ncurses-base
Version        : 6.1+git1-1.4.1.jolla
Arch           : armv7hl
Vendor         : meego
Installed Size : 320.4 KiB
Installed      : Yes (automatically)
Status         : up-to-date
Source package : ncurses-6.1+git1-1.4.1.jolla.src
Summary        : Descriptions of common terminals

Information for package ncurses-devel:
--------------------------------------
Repository     : jolla
Name           : ncurses-devel
Version        : 6.1+git1-1.4.1.jolla
Arch           : armv7hl
Vendor         : meego
Installed Size : 352.7 KiB
Installed      : Yes
Status         : up-to-date
Source package : ncurses-6.1+git1-1.4.1.jolla.src
Summary        : Development files for the ncurses library

Information for package ncurses-libs:
-------------------------------------
Repository     : jolla
Name           : ncurses-libs
Version        : 6.1+git1-1.4.1.jolla
Arch           : armv7hl
Vendor         : meego
Installed Size : 504.3 KiB
Installed      : Yes (automatically)
Status         : up-to-date
Source package : ncurses-6.1+git1-1.4.1.jolla.src
Summary        : Ncurses libraries

I tried installing ncurses-libs and ncurses-term but that didn't help. I couldn't see the minimal ncurses versions epr depend on in the README. Does it need a more recent installation of ncurses?

Hey there, thanks... I don't think epr uses ncurses but python package named curses... Have you tried to install curses with pip install curses?
I am not familiar with SailfishOS, I'll try having a look at it...

Unfortunately I can't find any curses module using pip. Is that the exact name?
Defaulting to user installation because normal site-packages is not writeable
ERROR: Could not find a version that satisfies the requirement curses (from versions: none)
ERROR: No matching distribution found for curses
[nemo@Sailfish ~]$ pip3 install curses
Defaulting to user installation because normal site-packages is not writeable
ERROR: Could not find a version that satisfies the requirement curses (from versions: none)
ERROR: No matching distribution found for curses

Once pip is installed and provided that the modules are available for arm, I don't think there are any peculiarities about SailfishOS. This is the packages I currently have:
[nemo@Sailfish ~]$ pip list
Package     Version
----------- ---------
asciimatics 1.11.0
asciinema   2.0.2
curses-menu 0.5.0
Cython      0.29.19
future      0.18.2
keyboard    0.13.5
Lyvi        2.0-git
meson       0.50.1
Pillow      5.4.1
pip         20.1.1
plyr        1.0.2
psutil      5.7.0
pyfiglet    0.8.post1
pygobject   3.24.1
setuptools  41.2.0
urwid       2.1.0
wcwidth     0.1.9

I installed curses-menu when trying to solve the issue with epr, but that didn't change the error.

Some progress after installing curses-util, but it still looks like missing dependencies:
[nemo@Sailfish ~]$ pip install curses-util
Defaulting to user installation because normal site-packages is not writeable
Collecting curses-util
  Downloading curses-util-0.0.25.tar.gz (6.5 kB)
Using legacy setup.py install for curses-util, since package 'wheel' is not installed.
Installing collected packages: curses-util
    Running setup.py install for curses-util ... done
Successfully installed curses-util-0.0.25

[nemo@Sailfish epr]$ python epr.py
Traceback (most recent call last):
  File "epr.py", line 61, in <module>
    from urllib.parse import unquote
ImportError: No module named parse

[nemo@Sailfish epr]$ pip install parse
Defaulting to user installation because normal site-packages is not writeable
Collecting parse
  Downloading parse-1.15.0.tar.gz (29 kB)
Using legacy setup.py install for parse, since package 'wheel' is not installed.
Installing collected packages: parse
    Running setup.py install for parse ... done
Successfully installed parse-1.15.0
[nemo@Sailfish epr]$ python epr.py
Traceback (most recent call last):
  File "epr.py", line 61, in <module>
    from urllib.parse import unquote
ImportError: No module named parse

I'm not sure which one is missing here. Shouldn't pip automatically install dependencies?
Note that the error is unchanged after installing curses-util if I try to run epr.py with python3:
[nemo@Sailfish epr]$ pip3 install curses-util
Defaulting to user installation because normal site-packages is not writeable
Requirement already satisfied: curses-util in /home/nemo/.local/lib/python3.8/site-packages (0.0.25)

[nemo@Sailfish epr]$ python3 epr.py
Traceback (most recent call last):
  File "epr.py", line 50, in <module>
    import curses
  File "/usr/lib/python3.8/curses/__init__.py", line 13, in <module>
    from _curses import *
ModuleNotFoundError: No module named '_curses'

Hey there, I've been looking up SailfishOS... And what I found so far is that cmiiw SailfishOS probably is not based on any Linux distribution. As far as I know curses python pkg only supported in Linux and Mac officially and windows unofficially...

Uh, no I don't think that's correct. SailfishOS most definitely is Linux. It runs a Linux kernel, has a full blown / and /home, runs Wayland, bash by default, installs rpm packages with zypper, can run flatpaks, and has all base packages other distributions have. I am not saying that means epr should run out of the box on it, and perhaps some libraries are not available in the repository, but I don't know which ones I should check. I have other ncurses applications running on it at the moment, but I don't know if they use the python curses or the base Linux ncurses. Do you know if somehow python curses is limited to some architectures only, and is available for arm for instance?

Those are the curses occurrences I can find using pip:
[nemo@Sailfish ~]$ pip search curses
livestreamer-curses (1.5.2)      - Livestreamer-curses is a curses frontend to livestreamer
curses-ex (0.3)                  - Provide additional curses functions.
pycopy-curses (0.0.0)            - Dummy curses module for Pycopy
micropython-curses (0.0.0)       - Dummy curses module for MicroPython
haddock-curses (0.1.5)           - Random curses from Captain Haddock.
windows-curses (2.1.0)           - Support for the standard curses module on Windows
toga-curses (0.0.0)              - A Curses backend for the Toga widget toolkit.
polka-curses (1.3.0)             - The curses interface for the Polka website (https://polka.academy/)
curses-menu (0.5.0)              - A simple console menu system using curses
  INSTALLED: 0.5.0 (latest)
galaxie-curses (0.3.3)           - Galaxie Curses is a free software ToolKit for the NCurses API
curses-ui (0.0.2)                - Curses UI with native window management and keyboard support
multitail-curses (1.0.5)         - A curses-based utility script for tailing multiple files simultaneously.
curses-util (0.0.25)             -
  INSTALLED: 0.0.25 (latest)
curses-questions (1.4)           -
pocket-curses (0.1)              - An ncurses interface to Pocket API
Canto-curses (0.9.9)             - Next-gen console RSS/Atom reader
youtube-curses (0.1)             - YouTube browser built with ncurses
curses-snake (1.0.3)             - Snake game in console based on cureses.
curses-2048 (1.4)                - 2048 implementation with python and ncurses
cursetup (0.0.5)                 - avoid cursing at curses
curses-check-for-keypress (0.3)  - curses_check_for_keypress: loop until user presses a key.
hexes (0.4.0)                    - Curses for humans.
cursed (0.2.1)                   - Simplified curses
cpager (0.0.6)                   - Curses Pager
cpick (0.1.3)                    - Curses List Picker
cansi (0.0.4)                    - Curses ANSI Parser
shipit (0.0)                     - A curses interface to GitHub
cfortune (0.0.2)                 - Curses Fortune Browser
purses (0.0.12)                  - Purses, a Pandas Curses
ncmpy (1.5.6)                    - a curses mpd client;
cursebox-lib (1.0.2)             - Curses made simple
checkmk-commander (1.3.0)        - Curses interface to Checkmk Raw.
mccurse (0.5.1)                  - Minecraft Curse CLI Client
vdgalcon (1.12)                  - Galactic Conquest in curses, on VisiData
battleship (0.1a)                - a battleship game with a curses interface
SimpleMenu (1.2)                 - Create simple Curses menus
pysysmon (0.0.25)                - A curses-based system monitor.
pymatrix-rain (0.1.0)            - matrix rain using curses
pamixer (0.1.4)                  - PulseAudio Curses Mixer Application
aneris (0.6)                     - curses time/project planner
skyCurses (2.0.15.post5)         - Official curses client for the SkyChat
klipz (0.2.2)                    - Clipboard manager using curses
pyctu (0.1dev)                   - A curses interface to configure xbees
Tymeventure (0.1.2)              - A curses-based adventure game
ezcurses (0.3.1)                 - library to help with curses programming
cpyvke (1.2.7)                   - A Kernel and variable explorer in Curses
cursedmongo (0.1)                - A curses based MongoDB browser
comp (0.4.6)                     - Curses Omni Media Player
sshplaces (0.1.15)               - A curses menu of ssh places.
pubnub_curses (1.5.2)            - PubNub Curses Terminal Client
tmsg (0.1)                       - A curses based client for Facebook Messenger
Wikicurses (1.4)                 - A simple curses interface for accessing Wikipedia.
tinywin (0.2.5)                  - A tiny Curses window management library.
cursy (1.0.1)                    - Little and simple wrapper for curses application.
igrepper (0.0.2)                 - Interactive curses-based grepping tool
pulsemixer (1.5.1)               - pulsemixer - CLI and curses mixer for PulseAudio
py_curses_editor (1.2.1)         - A configurable curses text editor window
diet_analysis (0.1)              - Curses-based diet logging tool
interactive-input (0.5.1)        - curses based interactive value input
gunicorn-console (0.1.16)        - A curses application for managing gunicorn processes.
pymarietje (0.1.0a2)             - Curses client for MarietjeD music daemon
culour (0.1)                     - Print colored strings in a curses window
splutter (0.1.0)                 - A modern curses UI framework for Python.
dbcurses (0.0.1)                 - Curses-based application for database visualization
cursesinquirer (0.1.1)           - A library to create curses based CLIs
clockr (1.0)                     - Simple curses clock written in Python
booger (0.4.5)                   - Pretty curses-based nose frontend
mmw (1.1)                        - This is a library for displaying curses-like windows
tyrs (0.6.2)                     - Twitter and Identica client using curses
pyCDK (0.1)                      - Python binding to the Curses Development Kit
snipe-im (0.dev4)                - curses client for persistent IM systems
treepick (0.1.4)                 - Curses Tree Style Path Picker
ssfm (0.0.1)                     - Curses based File Manager application
pyramid_bpython_curses (0.1.3)   - bpython bindings for Pyramid pshell in a curses variant
Glances (<IP_ADDRESS>)                - A cross-platform curses-based monitoring tool
  INSTALLED: <IP_ADDRESS> (latest)
xmlcurses (1.2.2)                - An interface for python's curses library using XML
pytermfx (0.4.3)                 - Terminal interaction and formatting for Python without curses
curseradio-improved (0.3.8)      - An improved Curses interface for listening to internet radio.
PyTone (2.2.4)                   - Powerful music jukebox with a curses based GUI.
blkmenu (0.3.1)                  - Tiny curses wrapper around lsblk and udisksctl
Pygcurse (1)                     - Curses emulator module that runs on top of Pygame
pycpmc (0.1.1)                   - A curses-based CPM (typing speed) calculator.
xoinvader (0.2.0)                - (not so) small python curses space game
UniCurses (1.2)                  - A unified OS-independent Curses wrapper for Python
juc2 (0.1.1)                     - juc2 - Just Use Curses (Mark 2)
eichhoernchen (2.0)              - Lightweight curses-based time tracking tool.
cplay-ng (3.0.0)                 - A curses front-end for various audio players
UniCurses-for-Python (1.2)       - A unified OS-independent Curses wrapper for Python
dabbiew (0.6)                    - A curses-based DataFrame viewer inspired by TabView.
gremlin (0.6)                    - Curses-based command-line scripting library
cursgame (0.2.0)                 - An easy interface for writing games using curses.
curtsies (0.3.1)                 - Curses-like terminal wrapper, with colored strings!
visidata (1.5.2)                 - curses interface for exploring and arranging tabular data
sdreaper (1.0.1)                 - CLI and curses UI for talking to Arduino Reaper library
winCurses (0.2.1)                - A curses wrapper to draw some HTML-like windows
esc-calc (1.0.0)                 - extensible stack-based RPN calculator based on curses
Elatom (1.0.10)                  - Podcast downloader in Python 3 with Curses and Tkinter interfaces.
humu-download (1.1.5)            - CLI and curses UI for dowloading Humu data files
zeitzono (0.4.1)                 - city based timezone converter with a curses (TUI) interface
pacurses (0.1.1)                 - A curses graphical interface to the PulseAudio sound system for the terminal.

However, I suppose some of them are limited to just some distributions or all architectures (?), that might be the problem.

I believe this might be related: https://github.com/jquast/blessed/issues/99#issuecomment-314238398
Perhaps I would have more luck trying to build Python on my device (I should have the ncurses headers), but that appears risky considering I have already several things running on the python packages shipped in my repo. Not sure yet if I should try, but that's sad, I really wanted to get epr working.
In any case, it is probably not an epr issue, sorry about that.

Confirmed here: https://together.jolla.com/question/213413/python-37-missing-curses/?answer=213491#post-id-213491
Our version of Python was compiled without curses support, but this should be fixed soon. In the mean time I could build my own (but I think I'll just wait).

Ahh thanks for troubleshooting this issue... Sorry can't help much, I'm unfamiliar with sailfishOS and having no means to experiment with it...


Feature/preview app iframe

wrapped preview app box into a custom iframe, related to https://github.com/witheve/Eve/issues/734

Hi Wilk, thanks for taking the initiative on this. I found that the addition of the iframe breaks embedded CSS blocks. For example, this program does not display correctly in the iframe branch: http://play.witheve.com/#gist:06c780db535d63cf104f75f42993aa16-root-foo.eve
(don't mind the first empty CSS block, it's a known bug that the contents of the first CSS block don't get injected into the page )

@cmontella yep, you're right: now CSS blocks are supported correctly -> https://github.com/witheve/Eve/pull/762/commits/a092db097fc588656f375ec0c1752fb412f5a00a


Added Note and Important cards, and some additional explainations

+ the documentation concerning the getters and setters.
+ A ToC.
+ Some NOTE and IMPORTANT cards to clarify some points.
+ fixed some typos.

Looks good, thank you for this!


Add the ability to save profiles

Saving profile products will be a necessity, considering how long it can take to generate things like density profiles.

Initially was thinking that this would be done by saving profiles in fits files, so they could be viewed in topcat etc. This is a nice idea, but I had forgotten just how complicated my profile objects are, and I think I'm just going to pickle them. Seems to work with temperature and sb profiles, including saving model fits chains etc.
The resulting profile files can be quite large (sb profile with a model fit was 56MB in a quick test, but I can accept that.

I'm thinking that the initial save will be done when the profile is added to a source with update_products, then subsequently it will be re-saved whenever extra changes are made


Arrow not shooting from bow and crossbow

When trying to shoot an arrow from a bow or crossbow, no arrow shoots or gets used.
This happens when registering either CombatFeatures.modernVanilla() or CombatFeatures.VANILLA_PROJECTILE_ITEM and CombatFeatures.VANILLA_BOW (or crossbow).

Are you sure you are using the latest Minestom version? This is a recently fixed bug in Minestom

I updated it to the latest commit, and it works now. Thank you!


Add in JNumber number conversions

In response to https://github.com/mdedetrich/scalajson/issues/17#issuecomment-312140277, we should add JNumber converters to various number formats (since its likely most users will get this wrong)

+1

@axel22 What are your opinions of this PR https://github.com/mdedetrich/scalajson/pull/38?

I like it, would be good to have that! About the ScalaMeter tests, it's possible that you would get a better accuracy by adding a loop inside the benchmarked snippet (to increase the number of iterations).
About the @inline annotations on constants, if you use defs everywhere, it's almost certain that the JIT compiler will inline all invocations to them.

I like it, would be good to have that! About the ScalaMeter tests, it's possible that you would get a better accuracy by adding a loop inside the benchmarked snippet (to increase the number of iterations).

Thanks, I will add more benchmarks + add this inner loop

About the @inline annotations on constants, if you use defs everywhere, it's almost certain that the JIT compiler will inline all invocations to them.

Try, I use @inline for 2 reasons

This is a cross platform library (so it will target scala-native and it currently targets Scala.js). So I wan't really make sure that it inlines (although I am fairly sure that these projects should inline such code)
It shows the intent of what is meant to happen, i.e. they really are constants

Makes sense!


[r] Vignette follow-up from #1417

Addresses
https://github.com/single-cell-data/TileDB-SOMA/pull/1417/files/7248f6b1924a5a0aa478985a55f21db3e9a27930#r1205705303

Codecov Report
Patch coverage has no change and project coverage change: -11.66 :warning:

Comparison is base (bfb9556) 63.82% compared to head (8dd4664) 52.16%.

:exclamation: Current head 8dd4664 differs from pull request most recent head b26d6de. Consider uploading reports for the commit b26d6de to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1418       +/-   ##
===========================================
- Coverage   63.82%   52.16%   -11.66%
===========================================
  Files          98       68       -30
  Lines        8190     5726     -2464
===========================================
- Hits         5227     2987     -2240
+ Misses       2963     2739      -224

Flag
Coverage Δ

python
?

r
52.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 30 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fixing platform detection regression for keystrokes in #30

Attempting to fix issue #30 that I reported earlier. Using logic from background-tips package to determine the correct platform-specific keystrokes depending on the command listed in the guide.

Sorry for the delay in looking at this, but I tried it today and there were a few issues.
The humanized keystroke had some styling issues probably due to the font not being set as monospace.

Also, if the welcome was shown immediately at startup then the keybinding did not display since keybindings are loaded asynchronously.

I pushed a simple fix in commit 701cfc20fe204307b42e13eb41a49dbd98ce4035 to check the platform and use ctrl-shift-p on non-Mac. Obviously this isn't as robust of a solution as you had here where it actually picks it up from the atom.keymaps but at least it makes it accurate for the first time you run Atom and no keybindings have been changed yet.
I'm going to close this pull request for now since it no longer merges cleanly but if you still want to address the issues mentioned and update it, please comment when it is ready for review, thanks.


Electron App crashes on startup on Catalina

Preflight Checklist

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details
Electron app crashes on startup with the helpful message … quit unexpectedly.

Electron Version:: That’s the problem …

Operating System::  MacOS 10.15.2 Catalina

Last Known Working Electron version:: 5.0.13

Expected Behavior
Not crashing … ?
Actual Behavior
After a few seconds, the application quits without ever showing a window. The OS message is … quit unexpectedly.
To Reproduce
Start application
Additional Information
I am using electron-packager to compile the application. Using npm start is fine.
I have tried the following:

Comment out all of the code in main.js and in index.html
Using electron-rebuild to recompile node modules
Various versions of electron before and after 5.0.13

I have also used electron-log and logged messages from main.js. Up to 5.0.13, of course, everything is fine. After that version, the main script runs, but anything from app.on or ipcMain.on doesn’t get triggered.

Please don't file the same issue in multiple projects. This is an issue not specific to Electron Packager.
Duplicate of https://github.com/electron/electron/issues/21674


Implementation of sqlite3_update_hook

I'm posting this because of the comment in the code requesting that issues be created for use cases requiring access to the underlying sqlite3 handle.
I do not see an implementation for sqlite3_update_hook. It is exposed in sqlite3_sys as follows:
pub unsafe extern fn sqlite3_update_hook(p: *mut sqlite3,
                                     f: Option<sqlite3_update_hook_callback>,
                                     p: *mut c_void)
                                     -> *mut c_void

We have a unique-ish use case where integration with a system is performed by opening the sqlite3 db for read while the main module writes to the database. Update notifications are required to trigger a re-scan of rows in question. I don't think this functionality is currently implemented in rusqlite; I don't know whether it would be something you'd be interested in implementing.
Thank you.

rusqlite 0.14 released

Thanks!


⚠ ClamAV has degraded performance

In f4dda53, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 66 ms

Resolved: ClamAV performance has improved in e1c29d0.


Extend LinearSmoothScroller to handle resting Focus

When smooth scrolling, Focus is being done very hacky right now.  The better way instead of using a handler, is probably to extend LinearSmoothScroller, and override the stop method, and reset the focus on the item it has stopped scrolling too.  Need to make sure this works correctly with the D-Pad.

This is implemented with this commit: 6a4ceb3c50


Fix authentication of edit and delete

After testing previous pull request, some features, such as deleting a poll, were still doable by users. Fixed constraints so that admin status is checked rather than managing polls. This also fixed the rspec admin test, which had been failing previously.

Rad! The hound complaints seem valid mostly, would you fix those and merge please?

Unsure why the admin test has again stopped passing. The rspec file and all other parts other than proper formatting stayed the same.

Strange behavior. All users can destroy polls still, but publish button is disabled, edit does not work, new poll does not show up nor work via direct url, and users still see all buttons. However, non-users can no longer access polls viewing, so their access to destroying polls has been disabled. Still need to fix authorization of destruction. Will need to include another rspec test for users/admin deleting in next pull request.


AWK Parsing Not Working

This doesn't work for me on KDE Neon - the AWK run in the line linked below is always returning nothing, instead of returning the rotation. I assume this is due to text line format change (ah yes - the fun life of updating CLI parsers)
https://github.com/donbowman/kde-auto-rotate/blob/master/auto-rotate#L17
monitor-sensor | awk '/Accelerometer orientation changed:/ { print $NF; fflush();}' | while read line
Would you accept a patch overwriting this line with a more robust solution? I have one nearly working locally on my touchscreen Thinkpad hybrid (a helix, I believe).

Got a PR? I'll take it!
its still running for me on my laptop last i checked.

What OS are you on? I suspect this could be relating to Neon's 18.04 base.
I'll format into a PR when I'm able.

Its 18.04 kubuntu

hm. Odd.

Anyways, I'll try and get a PR in to look at.


adding new copy method

fixes #8

@sherl0cks Received the following error while testing the PR
$ ansible-playbook -i inventory.yml eap6.4-rhel7.yml
Enter Your Red Hat Customer Portal Username: <user>
Enter Your Red Hat Customer Portal Password: <password>
ERROR: file could not read: /Users/ablock/Projects/ansible-middleware-playbooks/git/jboss_eap/tasks/{{ download_method }}.yml

Is there supposed to be a default value?

@sabre1041 I can reproduce your error with ansible 1.9. I've been developing on fedora 23 which recently bumped up to ansible <IP_ADDRESS>. I'm going to fall back to 1.9 for development going forward

@sabre1041 I think I'm going to try this again, building with 1.9 from the start. I seem to have broken a few things and I don't really understand how. I'm going to close this and then open a new one.


Preflight: enforce network limits

Not all limits are implemented right now.
This issue tracks both adding the missing ones enforced at validation/apply time, and enforcing them during preflight.

[ ] int64 txMaxSizeBytes; // maximum size an xdr encoded transaction can be (also enforced by the tx endpoint)
[ ] int64 txMaxGas; // maximum gas per transaction
[ ] uint32 txMaxReadLedgerEntries; // maximum number of ledger entry read operations per transaction (footprint)
[ ]  int64 txMaxReadBytes;  // maximum number of bytes that can be read per transaction
[ ]  uint32 txMaxWriteLedgerEntries; // maximum number of ledger entry write operations per transaction (footprint)
[ ]  int64 txMaxWriteBytes; // maximum number of bytes that can be written per transaction
[ ] uint32 txMaxExtendedDataSizeBytes; // maximum size of extended data produced by a transaction (this
[ ] int64 txMaxResultSizeBytes; // maximum size of a transaction result (gets folded into txMaxExtendedDataSizeBytes if we replace this by the hash in history archives)

I grabbed most of this list from https://github.com/stellar/stellar-protocol/blob/master/core/cap-0046-07.md but there could be more.

@sisuresh FYI

Updated fee-related network limits:
    // Maximum instructions per transaction
    int64 txMaxInstructions;

    // Memory limit per transaction.
    uint32 txMemoryLimit;

    // Maximum number of ledger entry read operations per transaction
    uint32 txMaxReadLedgerEntries;

    // Maximum number of bytes that can be read per transaction
    uint32 txMaxReadBytes;

    // Maximum number of ledger entry write operations per transaction
    uint32 txMaxWriteLedgerEntries;

    // Maximum number of bytes that can be written per transaction
    uint32 txMaxWriteBytes;

    // Maximum size of extended meta data (mostly from events) produced by a transaction
    uint32 txMaxExtendedMetaDataSizeBytes;

(see the google sheet for their relation to the fee calculation)
Other limits that may also need to be validated:
    // Maximum size in bytes for a transaction
    uint32 txMaxSizeBytes;

    // Maximum allowed size of contract code in bytes (relevant for install install contract and update contract code)
    uint32 contractMaxSizeBytes;

    // TBD: contract data key size (see issue 629), ledger entry size (see issues 716)

These value are all specified ConfigSettingEntry from the network and preflight needs the additional logic to compare the simulateTransaction output against these limits (and provide the info to the user).
(Discussed offline with @tsachiherman and @dmkozh )


[Icons] Missing Material Icons

Steps to Reproduce

Execute flutter run on the code sample

Expected results:
The Material Icons for Icons.sports_martial_arts and Icons.handshake should be shown.
Actual results:
Empty or wrong Icons

Code sample

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Missing Icons Demo',
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        primarySwatch: Colors.red,
      ),
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({Key? key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text("Missing Icons Demo"),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: const [
            Icon(Icons.sports_martial_arts),
            Icon(Icons.handshake),
          ],
        ),
      ),
    );
  }
}

Logs

With flutter run --verbose nothing is logged

With flutter analyze nothing is logged

Output for flutter doctor -v
[✓] Flutter (Channel stable, 2.10.0, on macOS 12.2 21D49 darwin-arm, locale de-DE)
    • Flutter version 2.10.0 at /Users/xyz/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5f105a6ca7 (vor 4 Tagen), 2022-02-01 14:15:42 -0800
    • Engine revision 776efd2034
    • Dart version 2.16.0
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/kg/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)

[✓] VS Code (version 1.64.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.34.0

[✓] Connected device (2 available)
    • Pixel 5 (mobile) • XYZ • android-arm64  • Android 12 (API 31)
    • Chrome (web)     • chrome         • web-javascript • Google Chrome 97.0.4692.99

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

The same problem was reproduced in my environment.
Output for flutter doctor -v
[✓] Flutter (Channel stable, 2.8.1, on macOS 12.2 21D49 darwin-arm, locale ja)
    • Flutter version 2.8.1 at /opt/homebrew/Caskroom/flutter/2.5.2/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (7 weeks ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/yamashita/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.64.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.34.0

[✓] Connected device (2 available)
    • Pixel 3a (mobile) • 93GAY0BAJD • android-arm64  • Android 12 (API 31)
    • Chrome (web)      • chrome     • web-javascript • Google Chrome 97.0.4692.99

• No issues found!

This problem is similar https://github.com/flutter/flutter/issues/97767

Closing as duplicate of #97767.
The issue has been fixed on master, and there's a cherry-pick request for it to be hotfixed into 2.10 in #97767. Kindly follow up there for more information.
Thank you


v1.14 Backports 2024-10-10

[ ] #29867 (@chancez) :warning: resolved conflicts

ℹ Hit minor conflicts due to different surrounding context; accepted combination.

[ ] #35267 (@aanm) :warning: resolved conflicts

ℹ hit minor conflicts with https://github.com/cilium/cilium/commit/04e8828756541506ee596a6dee75f80cbe46f675 (".github/workflows: change GH runners"); simply accepted combination. Additionally hit conflict in conformance-k8s-kind.yaml as https://github.com/cilium/cilium/commit/91b7c88cfeb06eaaca35d1bf05430618a3f79331 ("gha: use GH_RUNNER_EXTRA_POWER for conformance-k8s-kind workflow") had not been backporter to v1.15. Accepted the incoming change to ensure consistency.

[ ] #35236 (@aanm)
[ ] #35288 (@oneumyvakin)

Once this PR is merged, a GitHub action will update the labels of these PRs:
 29867 35267 35236 35288

/test-backport-1.14


Updated UGDG

Pull Request Test Coverage Report for Build 481

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.953%

Totals

Change from base Build 472:
0.0%

Covered Lines:
2166

Relevant Lines:
2491

💛  - Coveralls


Support Core 18

Codecov Report

Merging #32 (e6517a9) into master (c45cb4f) will increase coverage by 3.28%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
+ Coverage     57.76%   61.04%   +3.28%
  Complexity      347      347
============================================
  Files            89       89
  Lines          1707     1707
  Branches        275      221      -54
============================================
+ Hits            986     1042      +56
  Misses          556      556
+ Partials        165      109      -56

Impacted Files
Coverage Δ

...org/dashj/platform/dpp/document/DocumentFactory.kt
50.00% <0.00%> (+1.00%)
:arrow_up:

...org/dashj/platform/dpp/identity/IdentityFactory.kt
38.23% <0.00%> (+1.47%)
:arrow_up:

...p/statetransition/StateTransitionIdentitySigned.kt
86.76% <0.00%> (+2.94%)
:arrow_up:

...ashj/platform/dpp/errors/ConcensusErrorMetadata.kt
71.87% <0.00%> (+3.12%)
:arrow_up:

...rc/main/kotlin/org/dashj/platform/dpp/util/Cbor.kt
57.74% <0.00%> (+4.22%)
:arrow_up:

...tform/dpp/contract/DataContractCreateTransition.kt
86.95% <0.00%> (+4.34%)
:arrow_up:

...rg/dashj/platform/dpp/errors/DriveErrorMetadata.kt
57.14% <0.00%> (+4.76%)
:arrow_up:

...in/org/dashj/platform/dpp/identifier/Identifier.kt
50.00% <0.00%> (+5.55%)
:arrow_up:

...c/main/kotlin/org/dashj/platform/dpp/BaseObject.kt
76.47% <0.00%> (+5.88%)
:arrow_up:

.../dashj/platform/dpp/document/DocumentTransition.kt
34.48% <0.00%> (+6.89%)
:arrow_up:

... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


problem

Challenge Size your Images has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2683.0 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
 But your code is incorrect.
GitHub Issues are for reporting bugs on the website only.
Please use the Help chat room for getting challenge related help.
Happy Coding.


Make modules more consistent

This is a big change but I think it makes sense for it to happen in 0.6. There are two primary motivations:

More contexts are actually useful now that stack safety is built in and now that we have an approach to effect capture for stuff like Try in iteratee-files.
There was some inconsistency about what contexts we provided modules for. There were no Either modules, no modules for the standard library's Try or Future, etc.

There's one big organizational change: because we now have a bunch of modules in core (either, eitherT, eval, future, id, option, try_, and xor) I've moved them to a new modules package to avoid polluting io.iteratee.
Some other stuff:

All modules are now tested. Before we weren't very consistent about this—e.g. option   had no tests.
pure is now id. This is more consistent with the other names. I would have made xor xorT as well, but since XorT is going away in upcoming Cats releases I just deprecated it instead.

seems fine to me. Minor comment about a test seeming to be in a strange spot.

:+1:


Kinesis putrecords sampler

Have created a Kinesis put records sampler as per the request - https://github.com/JoseLuisSR/awsmeter/issues/3. Please check and share any feedback you have.

@JoseLuisSR If you don't have any concerns, can you kindly merge this?

@JoseLuisSR Bumping this up


core/entry_point: Start the heap at app_heap_break

Start the app's head size at the value of app_head_break passed by the
kernel.
This gives us more space to work with which allows us to create large
buffers (such as for passing to/from the HMAC).
It also means we do what the kernel expects us to do
Signed-off-by: Alistair Francis<EMAIL_ADDRESS>

This gets a no from me, https://github.com/tock/libtock-rs/commit/65c3b4a9029e8a0138d341a5f74a72e018bf2267
Is there an issue with just increasing the app's heap size as part of the binary? The kernel will always guess wrong as it has no knowledge of what's in the app's binary.

Yep, so I dug into this a bit more and https://github.com/tock/libtock-rs/commit/65c3b4a9029e8a0138d341a5f74a72e018bf2267 is not the right solution.
We are currently telling the kernel a value for app_heap_break and then ignoring that (it just happens that we re-calculate the correct value later).

Ahhh this makes more sense, thanks for digging into this. I'll take a closer look on Monday.

@jrvanwhy If you think this PR is fine, could you bors r+ or bors d+?

bors d+

@jrvanwhy If you think this PR is fine, could you bors r+ or bors d+?

I was waiting for Laura to review the PR.

bors r+


How to connect using https instead of websocket in tdweb?

How to connect using https instead of websocket in tdweb?
Thanks,

It is not possible.


What to expect re: Android Nearables support?

Hi Estimote!
I'm working on an Android project using Beacons now, and the client asked if we could also support Nearables. Noticed that Nearables are not yet part of the Android SDK & don't seem to be otherwise mentioned in this repo; is there anything you can share re: roadmap? I'd love to offer them an educated answer.
Keep up the good work :+1:

We have just update our Estimote app in Play Store with Nearables support. Expect SDK update in couple of days.

Thanks! Looking forward to the update

Released: https://github.com/Estimote/Android-SDK/releases/tag/0.7


Plugin is not compatible with the current version of the Intellij IDEA IDE v233.*

Is your feature request related to a problem? Please describe.
The IDE gives the following error message:
Plugin 'PostgreSQL Debugger' (version '232.0.3') is not compatible with the current version of the IDE, because it requires build 232.* or older but the current build is IU-233.11799.241
Describe the solution you'd like
A new version of Intellij IDEA is out and the plugin cannot be loaded.
Build #IU-233.11799.241, built on December 2, 2023
Please remove the version restriction or similar to make it possible to load the plugin assuming that is all that is really required.
Describe alternatives you've considered
The alternative is to downgrade used version of Intellij IDEA.
Additional context
N/A

Thanks for reporting, compatible release will be available in couple of days on market place, you can also find 233.0.1 in the releases page of this repo.


TTS Highlight Current Text

cant we implement  a method to detect the status of tts? currently speaking text that can be use to highlight the speaking text?

Could you describe how you use the tts function of sherpa-onnx?
If you integrate it into your app, i.e., use the tts engine service, then I think it is feasible. You can send sentence by sentence to sherpa-onnx. You can highlight the current sentence that is being synthesized.

isn't it possible to detect the current speaking text to highlight

Yes, I think it is possible. Would you like to contribute?
The idea is

Split the text into sentences
For the current sentence, highlight it, synthesize it, play it, de-highlight it, and go to 3
Process the next sentence

any ideas to implement non fake highlighter

I suggest highlighting a sentence that is being synthesized instead of a word.
The callback is called whenever a sentence is finished synthesizing.
Since the synthesize speed is faster than real-time, i.e., faster than the play speed, you may need to save the
samples obtained from the callback in a FIFO.
If the FIFO is not empty, you can deque the samples from the FIFO, play them, and at the same time highlight the sentence corresponding to the current samples that are being played.
You need to track which samples in the FIFO correspond to which sentence.
For piper VITS models, the code to break text into sentences is
https://github.com/k2-fsa/sherpa-onnx/blob/763a51486ed1aa58c3808e9438832e6cb3c510d2/sherpa-onnx/csrc/piper-phonemize-lexicon.cc#L232
(You can assume it uses ., ?, ! to break text into sentences).

If you want to highlight at the word level, then you can pass a single word instead of the whole text for synthesizing and you treat each word as a sentence.

@studionexus-lk
I just learned it is possible to locate where each input word is in the returned wave. It requires changing the onnx export code and the C++ API to return such information.

@csukuangfj
Any update ?

requires changing the onnx export code and the C++ API to return such information.

@studionexus-lk
I just learned it is possible to locate where each input word is in the returned wave. It requires changing the onnx export code and the C++ API to return such information.

where i can find the export code and c++ api.

You can wait for our next version of TTS models, which can output the duration of each token.

sorry, not yet


MSID: 86633 Version: 2 DOI: 2<IP_ADDRESS>8013

[PLACE MANUSCRIPT AND EDITOR DETAILS HERE WHEN AVAILABLE] See step 3
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[ ] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v1/by-publisher/elife/get-by-manuscript-id?manuscript_id=86633)

or (only one should be ticked. remove other from description.)

[ ] Confirmed with Ted at bioRxiv that MECA archive is available

Send the following email to Ted and wait for his reply.
Hi Ted,

Please can you prepare the preprint MECA for 10.1101/2<IP_ADDRESS>8013

Thanks

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/86633/v2)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews
Who can help: Editorial team

[ ] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>8013)
[ ] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/86633/v2/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/86633)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/86633

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/86633

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/86633/v2/86633-v2.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/86633)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

(V2 should use preprint V2)


refactor: remove dependency on terminate package

Motivation and Context

Resolves https://github.com/wundergraph/wundergraph/issues/1355
Marketing Changelog

Removes the only GPL-licensed NPM dependency
Checklist

[X] run make test
[X] PR title must follow conventional-commit-standard
[X] tests and/or benchmarks are included
[X] documentation is changed or added
[X] commit message and code follows the Code of conduct

Can you share with me how you're generating that example so that I can reproduce it?


Change Textobj: Subword outer textobj includes the preceding delimiter when it's the last word.

Change requested
When selecting the last word, the Subword outer text object includes the preceding delimiter.
Sample Text
111-222-333

When cursor on 111, subword outer is 111-
When cursor on 222, subword outer is 222-
When cursor on 333, subword outer and inner both are 333.
In this case, -333 for subword outer would be more in line with expectations.
In other words, subword outer only includes the following delimiter, but when it's the last subword, subword outer switches to include the preceding delimiter.
Checklist

[X] The textobj would be useful to more users than just me. (You can use the API to create custom textobj.)
[X] This is a feature request to change an existing textobject, not a bug report. (Use the bug report form for those.)

Also, when removing the first subword in a camelCased word with daS I would expect the remaining word to still be camelCased. However, currently the word becomes PascalCased:
Current behaviour (with cursor at ^):
fooBarBaz
 ^

After pressing daS:
BarBaz

Expected behaviour (with cursor at ^):
fooBarBaz
 ^

After pressing daS:
barBaz

Note that would still expect iS to not alter the case of the preceding word. That way if I wanted to just change the first subword, I could use ciS and get BarBaz (not barBaz).
This is also how vim-textobj-variable-segment works. Do you also agree with this behaviour?

@mawkler That's a very different request, I thus created a separate issue for it #113

fixed


Batch ,scale,origin

Hi.
When drawing TextureRegion with SpriteBatch, and origin set to centre (or != {0,0}),
changing scale shifts image to bottom-left. I can see that in code the corners are scaled but not the origin. Is it a bug? Am I reading this wrong? Will that fix it:
650/770		final float worldOriginX = x + scaleX == 1 ?  originX : originX * scaleX;
651/771		final float worldOriginY = y + scaleY == 1 ?  originY : originY * scaleY;
Same goes for PolygonSpriteBatch.
Regards,
Mariusz

No comments?

https://github.com/libgdx/libgdx/wiki/Issue-Tracker
Please use the forum or IRC if you need help. If you think you found an actual issue then include the required information to reproduce it.


Fix formatting in update-checkout-config.json

3-spaces formatting is inconsistently used for some keys instead of 4 spaces. This change makes the formatting consistent in update-checkout-config.json.

@swift-ci please smoke test

@swift-ci please smoke test

@shahmishal would you mind if this is merged as NFC? Thanks!

@swift-ci smoke test and merge


Role to create a new user in the runtime local user registry (eg. eas…

Role to use the reorganized aac/user_registry.user.py code, to create a user in the local user registry. (eg. easuser)

Answer to https://github.com/IBM-Security/isam-ansible-roles/issues/109


SpeechCommands v2

Could I ask what kind of bugs are for SpeechCommnds V2 in torch audio?
Now, I use it and do find any bugs about it.
Thus, I can check my results.

Hi,
https://github.com/YuanGongND/ast/blob/master/egs/speechcommands/run_sc.sh should be a one-click recipe for speechcommends v2 (by ./run_sc.sh after setting up the environment). If you have get any error running it, please copy and paste the error message and I can take a look. Thanks!
-Yuan

Hi,
https://github.com/YuanGongND/ast/blob/master/egs/speechcommands/run_sc.sh should be a one-click recipe for speechcommends v2 (by ./run_sc.sh after setting up the environment). If you have get any error running it, please copy and paste the error message and I can take a look. Thanks!
-Yuan

Hi,
Many thanks for your response!

You are welcome. Let me know if the problem is still there.

You are welcome. Let me know if the problem is still there.

Thank you. The problem is addressed.


v0.3.0 removes tarball prefix flag

There is no notice the changelog of 0.3.0 having a breaking change in the form of removing --prefix, which was done in #126. It is also not noted in the PR itself.
Was there a reason to remove it? If so, it should be noted in the changelog, otherwise would a PR to reinstate it be accepted?
@simonpasquier @SuperQ

Was there a reason to remove it?

I can't find a good reason why I committed this unrelated change... I'll send a PR to fix it. Thanks for reporting!

Thanks!


compressFirmwareXz: never compress lib/firmware/edid

this allows us not to pass compressFirmware = false; inside EDID derivations as this mechanic very tricky to discover.
related to #279789
Description of changes
Always skips edid directory when doing compression, leaving it intact.
Things done
I have tested it end-to-end through https://github.com/nazarewk-iac/nix-configs/commit/b9d935fca851e63a719e9bf6242c91bb10e1fe7d by using nixos-rebuild switch and inspecting image with lsinitrd:
$ lsinitrd $(cat /boot/loader/entries/*.conf | grep initrd | tail -n 1 | sed 's#initrd /efi#/boot/EFI#g') | grep 'firmware'
drwxr-xr-x   0 root     root            0 Jan  1  1970 ./nix/store/1419nq86gk6fkicq1y847d0ivgikap74-linux-6.6.10-modules-shrunk/lib/firmware/
drwxr-xr-x   0 root     root            0 Jan  1  1970 ./nix/store/1419nq86gk6fkicq1y847d0ivgikap74-linux-6.6.10-modules-shrunk/lib/firmware/edid/
-r--r--r--   0 root     root          128 Jan  1  1970 ./nix/store/1419nq86gk6fkicq1y847d0ivgikap74-linux-6.6.10-modules-shrunk/lib/firmware/edid/PG278Q_120.bin
-r--r--r--   0 root     root          128 Jan  1  1970 ./nix/store/1419nq86gk6fkicq1y847d0ivgikap74-linux-6.6.10-modules-shrunk/lib/firmware/edid/PG278Q_60.bin
-r--r--r--   0 root     root          128 Jan  1  1970 ./nix/store/1419nq86gk6fkicq1y847d0ivgikap74-linux-6.6.10-modules-shrunk/lib/firmware/edid/U2711_60.bin
drwxr-xr-x   0 root     root            0 Jan  1  1970 ./nix/store/1419nq86gk6fkicq1y847d0ivgikap74-linux-6.6.10-modules-shrunk/lib/firmware/rtl_nic/
-r--r--r--   0 root     root          864 Jan  1  1970 ./nix/store/1419nq86gk6fkicq1y847d0ivgikap74-linux-6.6.10-modules-shrunk/lib/firmware/rtl_nic/rtl8105e-1.fw.xz
...

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This change should be fine, as EDID files are a static 256 bytes in size. So skipping compressing edid files should not increase initrd size.

@ofborg eval


Bitbucket rejects public key

Carrying on from my previous woes, bitbucket rejects my public key.  I've verified that it gets copied across from my data/ssh folder, but I still get the following:
TASK: [repository | git | install git application] ****************************
failed: [localhost] => (item={'path': '/var/www/3dpixel.net/httpdocs', 'name': 'Maybestand', 'install': 1, 'options': {'pre_install': [], 'source': 'git@bitbucket.org:snetty/maybestand.git', 'provider': 'git', 'post_install': [], 'revision': 'master'}}) => {"cmd": ["/usr/bin/git", "ls-remote", "git@bitbucket.org:snetty/maybestand.git", "-h", "refs/heads/master"], "failed": true, "item": {"install": 1, "name": "Maybestand", "options": {"post_install": [], "pre_install": [], "provider": "git", "revision": "master", "source": "git@bitbucket.org:snetty/maybestand.git"}, "path": "/var/www/3dpixel.net/httpdocs"}, "rc": 128}
stderr: Warning: Permanently added the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
Permission denied (publickey).
fatal: The remote end hung up unexpectedly

msg: Warning: Permanently added the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
Permission denied (publickey).
fatal: The remote end hung up unexpectedly

FATAL: all hosts have already failed -- aborting

I am having the same issue for ansible. Can you help me to rectify this with your steps ?
_Jidnesh

I got the resolution. Just added<EMAIL_ADDRESS>... "git@" solve the issue.
Example -

name: Git
git: repo={{ item }} dest=/home/ubuntu/ accept_hostkey=yes key_file=/home/ubuntu/.ssh/id_rsa clone=yes
with_items:

<EMAIL_ADDRESS>

the same problem with me

Try with this.
https://confluence.atlassian.com/bitbucket/set-up-ssh-for-git-728138079.html


Unit Tests for Adding channel items

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Refactors the "Add item.vi" by adding the Create Read/Write Waveform code into a subVI.
Adds Unit Tests for Adding Items into the Addon

Why should this Pull Request be merged?

In order to provide test coverage for the adding and removing of channel items.

What testing has been done?

All added unit tests run successfully on the development machine.
FPGA Addon built and the adding of channels was tested manually to make sure no bugs were introduced during the refactor.

Nice implementation, with good coding style ... I think it does test the required cases in proper manner.
Make sure to update your local copy with the most recent PR merges, and update your current PR.

Conflicts on the "FPGA Addon.lvproj" file were solved.
Adding Channel Items Unit Tests run successfully.
All build specs run without error.


Swap my github username

@winkingturtle-vmw could you confirm you are @aminjam?

✔

FYI, we're waiting on a CLA authorization to be able to merge this.

I have signed the CLA under my new username. Under this username, I will not sign the CLA since the previous one (Pivotal one) was inherited.

Hey, Amin, I'd prefer not to have to manually bypass the CLA protection checks. Would you mind re-submitting this change under your @winkingturtle-vmw handle so that the CLA check passes? Thanks!

Excellent. Here is the new PR (https://github.com/cloudfoundry/community/pull/504).


Pls add .bins for ESP32-2432S024R

🚀 ESP32 Marauder for ESP32-2432S024R (Beta) 🧪
Hello, @Fr4nkFletcher
Please add the .bin files from this repository to Web Flasher: ESP32Marauder_ESP32-2432S024R_CYD. The files are located in the esp32_marauder/build/esp32.esp32.d32_pro directory.
Note that there are still some issues with the touch screen, but it will function and display images. This should reduce the number of questions regarding this module. 💡
Please indicate that this is a Beta version. 🧪 Also, mention that all functions are operational through the CLI, and that work is being done on the touch screen. 🔧
Thank you! 🙏

Coming soon, just waiting on the module so I can test myself before adding.

@Asmodeux2 I just calibrated and made all the changes for the 2.4" and tested without any touch issues. What were you running into? Adding to the flasher soon for you to test

Hi, @Fr4nkFletcher  , I have already looked at and tested your version, the global problem for both me and you is the CTS820 sensor driver which is not initialized. I will look at yours now, but anyway thank you very much for your work

Ok cool I'll look into this

@Asmodeux2 Are you certain you're not working with the 2432S024C?

@Asmodeux2 Pretty certain the resistive touch models don't employ the CST280


Applying style to a prompt throws an error

This is the error I am getting.

This is my styling.

This one's containing the question and prompt.

Tried going over throw the library itself, but couldn't find any potential fix. Any help would be much appreciated.
Thanks,
Rudransh :)

I am getting the same error, no idea why either

@yiheinchai
I don't know why but this library is buggy, I recommend switching over to InquirerPy. It works flawlessly.

This works:


Abstract Access Key with Cookies

The access key endpoint is only partially abstracted.
Given an access key, generate a random access key. When the client accesses a endpoint with this key, replace any given cookies or authorization cookies with the current session that created the access key.

Added in 1.2.0.


Change Display UI and toString methods of events/persons

Codecov Report

Merging #102 (ee642a1) into master (172a554) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #102      +/-   ##
============================================
+ Coverage     49.81%   49.83%   +0.02%
  Complexity      508      508
============================================
  Files           124      124
  Lines          2459     2460       +1
  Branches        322      322
============================================
+ Hits           1225     1226       +1
  Misses         1143     1143
  Partials         91       91

Impacted Files
Coverage Δ

.../java/seedu/address/logic/commands/AddCommand.java
100.00% <ø> (ø)

...edu/address/logic/commands/CancelEventCommand.java
0.00% <ø> (ø)

...va/seedu/address/logic/commands/DeleteCommand.java
78.84% <ø> (ø)

...java/seedu/address/logic/commands/EditCommand.java
76.99% <ø> (ø)

...ava/seedu/address/logic/commands/EventCommand.java
0.00% <ø> (ø)

...seedu/address/logic/commands/FindEventCommand.java
0.00% <ø> (ø)

...java/seedu/address/logic/commands/ListCommand.java
100.00% <ø> (ø)

...seedu/address/logic/commands/RemoveTagCommand.java
76.08% <ø> (ø)

.../java/seedu/address/logic/commands/TagCommand.java
80.95% <ø> (ø)

...c/main/java/seedu/address/model/person/Person.java
71.26% <100.00%> (+0.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 172a554...ee642a1. Read the comment docs.


On-the-fly formatting

This library is great and imo superior to the other phone number libs out there. However, I can't figure out how to implement proper on-the-fly formatting with Flutter's TextInputFormatter.
I tried to reference the TextInputFormatter from https://github.com/bottlepay/flutter_libphonenumber/blob/master/lib/src/input_formatter/input_formatter.dart
however, this library's formatting doesn't really seem to work with phone numbers while they are being typed and still incomplete.

You can check phone_form_field library it does on the fly formatting with this library


$::jenkins::proxy::url not resolved

Hello,
I'm currently trying to get from an old fork to the 1.7.0 version of this module. I had an issue with undefined variable that got corrected by cherry-picking this commit https://github.com/jenkinsci/puppet-jenkins/commit/52fbf0b1cfa86a89e0d7b727be91b79b5e8eb03d.
Yet, there is still an issue with proxy_server    => $::jenkins::proxy::url,. Using puppet-language for testing, I get the following error message:
Could not resolve variable $::jenkins::proxy::url in context jenkins::proxy or root at # SourcePos {sourceName = "./modules/jenkins/manifests/plugin.pp", sourceLine = Pos 169, sourceColumn = Pos 15}
Adding inclue jenkins::proxy is solving the problem.
Any ideas on how to properly solve that?
Cheers,
Thomas

I'm not sure I'm following... this is an issue with the current master branch?

Yes, the issue remains with the latest revision of master.

@jhoblitt I think there was a bug with undefined variables and commit 52fbf0b1cfa86a89e0d7b727be91b79b5e8eb03d tried to fix this but missed one place.
Indeed, in manifest/direct_download.pp, it changes the same call (https://github.com/jenkinsci/puppet-jenkins/blob/52fbf0b1cfa86a89e0d7b727be91b79b5e8eb03d/manifests/direct_download.pp#L34):
 proxy_server => $::jenkins::proxy::url,
but also adds the include (https://github.com/jenkinsci/puppet-jenkins/blob/52fbf0b1cfa86a89e0d7b727be91b79b5e8eb03d/manifests/direct_download.pp#L13):
 include ::jenkins::proxy
Could you check if that's right and, if applicable, provide a fix?
Cheers.

Hi,
I wrote 52fbf0b, though otherwise have nothing to do with the puppet-jenkins project. I've just tried moving from using 52fbf0b to using release 1.7.0. With release 1.7.0 I found that these warning came back (which is what brought me here):
Warning: Unknown variable: '::jenkins::proxy_server'. at /tmp/puppet-deploy/manifests/.modules-contrib/jenkins/manifests/direct_download.pp:32:23

While 52fbf0b was merged to the master branch in:
https://github.com/jenkinsci/puppet-jenkins/pull/648
...release 1.7.0 is much older, and doesn't include the fix.
I've just tried out the latest master commit (822dd4a0f243c6f183994fb6a8ba39224cdf2a91) by using :git etc. in my Puppetfile, and I don't see any of these warnings. Although, I think I did sometimes see similar warnings the first time deployed manifests when I was using 52fbf0b, so there might be a little more work still required on master in this area.


audiobridge join does not seem to return AUDIOBRIDGE_EVENT_JOINED

when I do audioHandle.join(...)
I get Promise<{ feed, room, participants }> in return.
This matches janus except that it seems to return without the 'display' field.
However, the docs seem to indicate it should return Promise<AUDIOBRIDGE_EVENT_JOINED>
Maybe just a documentation error?

That is a documentation error.
AUDIOBRIDGE_EVENT_JOINED is not correctly defined.

I've double-checked how those events are emitted from Janus, fixed the payloads and the documentation accordingly.
The commit is https://github.com/meetecho/janode/commit/d82f0c068ded9830188ebe7e2a3fef8fe0f36b59.
Please verify that everything works as expected.

looks good!
The 'display' is still not being returned on the join request.
Is that maybe a janus issue?

The Janus doc mentions the display in the joined event, but the actual code does not insert that field in the json.
I could add the display by returning the one passed by the user.

Closing the issue since the original problem has been solved.
Please open a new issue for other questions.


Being able to limit number of files selected/uploaded with "multiple"

Hello,
There isn't a way to limit the number of files a user can select when multiple file uploads are enabled. Or, there isn't an easy way, at least. I was doing a custom solution by adding and subtracting from an internal counter (through ngf-validate-fn, which is called for every file selected so a good place to count) but that seems to be difficult to manage and messy especially when there are other validation errors for a file defined through ngf-validate (in which case ngf-validate-fn isn't always called first, and there isn't a way to subtract from the internal number of files counter on ngf-validate errors, since there is no error callback).
Does anyone have a good solution for this?
Thanks!

Hi. I have got the same problem recently, so I will try to find a solution. I think that ngf-max-files validation constraint would be useful.

Currently I do not have much time for this enhancement. Maybe someone will get interested in this.

It would be great if this feature can be implemented. For now I'm not too worried because I'm preventing it on the server side anyway.
Just FYI the solution below works nicely if an image is selected one by one and added to the array, instead of all at once:
HTML:
<div id="newImages" class="btn btn-default btn-file"
ngf-select
ngf-multiple="true"
ng-model="images"
ngf-validate-fn="validateImage($file)"
...
Angular:
$scope.validateImage = function(image)
{
if($scope.images.length>=10)
return "TOO_MANY_IMAGES";
return true;
}

Fixed at 11.1.0 'ngf-max-files`


ci: add testing job

Changes
Add a new job to run tests when building go, rust or solidity contracts.

Solves #1047

Closing this one as we already run tests based on the modified files.


Replace all occurrences of 'pi'.

🚀 Feature
You are given a string, you have to replace all the occurrence of "pi" into 3.14.
Example :
1)Input: xpighpilmpipi
Output: x3.14gh3.14lm3.143.14
2)Input: abcpipikjpilk
Output: abc3.143.14kj3.14lk
Have you read the Contributing Guidelines on Pull Requests?
Yes
Motivation
This question ensures better understanding of recursion and its concepts.
Pitch
It enhances problem solving techniques.

@HarshCasper I would like to work on this issue please assign it to me. I am participant of GSSOC.

Do tell us the language you would use to implement it. It will help us in adding the respective label to this issue.

I will be working on this issue in C++.


allow nested lists by default

It's common to author content in markdown, and then programmatically generate html from it.
Markdown compilers typically do not include ways to add custom classes to their output.
Consequently, missing.css is relatively unusable with markdown generators when the content includes nested lists, since there's no easy way to add the class.
The potential content-side solutions include:

using javascript to inject the class; this does not seem like an appropriate use for js
parsing the output html and modifying it in-line; this is extremely complex for a script that otherwise just shells out to cmark (for example)
overriding the missing.css css in a second file

Since one of the goals of missing.css is to "build common components using plain, semantic HTML", and generated markdown is about as plain and semantic as it gets, this seems to be a good fit.
Of additional note, it's also a notable downgrade from classless css libraries, since those typically handle this use-case fine.
Potential solutions include:

having the nested-list behavior be the default
have an override that handles something like ul:has(li ul)

In markdown, you can use a loose list by adding empty lines between list items:

a

b

c

d

e

as opposed to a tight list which doesn't have them:

a
b

c
d

e

This will create even spacing between all list items.
The problem we were having with removing margin automatically is that sometimes you want the margin:

Hello! I am a long list item containing some content.     Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.

I am a nested list. I shouldn't hug the paragraph above or the one below.

  I am the continuation in the list item.

This rarely occurs in Markdown since it will wrap the content in paragraphs, but it does occur in handwritten HTML.


Implement target-features flag

This is a beginner's shot at #1137. Not sure this is the way you'd want to do this, but I'm happy to learn from mistakes ;)

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see CONTRIBUTING.md for more information.

Thanks for the PR! Right now, however, Cargo isn't trying to expose an exhaustive set of flags from the compiler at the top level (that would be quite a few). Instead we've been holding out for extensible strategies to solve issues like https://github.com/rust-lang/cargo/issues/544 (for example https://github.com/rust-lang/cargo/issues/595).
It's also not 100% clear to me whether configuration like this belongs in the Cargo.toml's [profile] sections or on the command line.

:umbrella: The latest upstream changes (presumably #1561) made this pull request unmergeable. Please resolve the merge conflicts.

Admittedly, I am scratching my own itch here, but I think it is important to expose that particular flag, because it is actually influencing whether a build succeeds or not, while other arguments regarding "somehow passing flags" to the compiler have been revolving around adding flags to debug issues, or change subtleties in optimisation. The impression I had of the [profile] feature is that it serves the same purpose, specifying things like optimisation levels or debug information, which is why I think it might not be the right place for this flag.

The unfortunate part is that the compiler exposes many options like this, and Cargo either needs to bind all of them or provide a generic means of specifying them to the compiler. This is the purpose of the cargo rustc command partly (generically specifying flags for any crate).
Configuration options such as this are very target-specific, and also arguably belong in a custom target specification that's read in by the compiler.

Configuration options such as this are very target-specific, and also arguably belong in a custom target specification that's read in by the compiler.

Could you elaborate a bit on this? Is this a deliverable that would be independent from the "generic" solution cargo rustc?

Ah indeed! Custom target specifications are a means of passing a custom --target flag which is described by a JSON file. The file describes how all artifacts for that target should be built, including the set of features which are passed down to LLVM.

Closing due to may last comment,  plus cargo rustc is now implemented!


Access variables in Md header files

Hi,
I would like to use variables in header of my markdown files (like "base_url"). I tried but it doesn't return the content but just the variable's name.
Is this a bug or maybe we can find a workaround ?

Hi @Majstor,
Not sure based on your comment if you're writing your own Twig template or using an existing one, but you'll need to run the header item through Pico's URL filter if you want the variables replaced.
This would look something like {{ my_header_item|url }} in your twig template.
I'd be happy to help more if you need it.  Just give me some more context and I can walk you through everything. 😉

Hi,
Thanks and sorry, i'm going here :
I use the dimension theme.
I can variables like %base_url% right in the "body" of the Md file, not in the header (between the double "---"), sorry i'm not sure if i'm clear.

Sorry, I didn't notice you replied right away.
You were clear before, but I guess I wasn't.😅
So, by default, these variables, like %base_url% don't get replaced in markdown headers.  That's just Pico's default behavior.   They're passed along, as-is, to the theme and it's up to the theme to do the replacing via the url filter if needed.
Typically, this would be done by the author for whichever fields they were expecting a url in.  For Dimension, I only see this being done to the image header. (On top of that, it seems like it was only added more recently, by another user: https://github.com/BesrourMS/dimension/commit/5fcb7da32260ca375c8fb4e92b0b257dae55c7a1).
Which header item are you trying to use %base_url% in?  I can tell you what line to change in themes/dimension/index.twig to fix it for you.
I think I'll also put in a Pull Request with @BesrourMS to add it to all of them for the future, lol. 😜
Actually, for that matter, since it's likely either the form or social links, here are the relevant changes for those (note the addition of |url on the relevant items):
Form, Line 67:
<form method="post" {% if meta.form %} action="{{ meta.form|url }}" {% endif %} >
(Also adding an If statement here because I noticed on a recent project that HTML Validation doesn't like you having an empty form action.  It's probably not really necessary though, and there could be other errors in the theme anyway, lol.)
Social Links, Line 88:

{{ icon }}

If it's either of those two items, adding the |url should give you the behavior you're looking for.  If not, let me know and we can take it from there. 😉

Hey great response, i like :)
I use Pico like Nextcloud extension, maybe it differs sometimes.
To be more clear, i would like to let users to put their own css if they want, and i modified the dimension's twig with this :
		{% if meta.css is defined %}
		<link rel="stylesheet" href="{{ meta.css }}" />
		{% endif %}

So, the user in the index.md should put one line for inserting his css like this :
Css: %assets_url%/custom.css
But it returns the variable name in the html code.

lol, yes, I've done that a lot with themes in the past.  I try to include a custom CSS option like that every time. 😉
Just change it from {{ meta.css }} to {{ meta.css|url }} and it should solve your problem.
Again, it's just how Pico works.  Unlike with your content, they aren't automatically replaced in the metadata headers.
Content gets a little more pre-processing before it ends up in the {{ content }} tag, which includes replacing those variables, parsing the markdown into HTML, etc.  Metadata headers on the other hand are pretty much exposed as-is, with the YAML being directly converted into an array you can access from your Twig template.
Whenever you want the %base_url%, %assets_url%, etc variables replaced in a string, such as those that get generated from your metadata headers, just run them through that URL Filter (|url).
Alternatively, on some of my older themes, I used to hardcode it as {{ base_url }}/{{ meta.css }}, but I really don't recommend using that option unless you need to. Using {{ meta.css|url }} is much more versatile in just about every use case (and it's what I use on my more modern work too).

Our Docs are a bit dense and hard to read at the moment.  We've wanted to clean them up for ages now, but our volunteer time is unfortunately limited.  Still, they can be a good resource if you can manage to sift through them. 😅 (And Ctrl+F is your friend! We'll get them cleaned up someday... 😒)
Another great resource if you're doing any theming are the Twig Docs.  I just about always have them open in a tab if I'm doing any Pico theming.  I can't recommend them enough as a resource.

Let me know if this works for you.  If it doesn't for some reason, I'd be happy to keep troubleshooting it with you. 😁
And if you have any other questions, don't be afraid to ask!

OK I will keep all this in mind thanks !
Sorry if it's not in right place to ask those things !

No worries, this is absolutely the right place to ask things. 😉
Our Issues Tracker acts as our catch-all for bug reports, support requests, discussions, and everything else.
Were you able to get your CSS code working? Just curious. 😜

Hey,
I will put here or somewhere when i'ill finish.
Even i try to modify some themes of Besrour's themes, i love them, he did a nice job. When i started to try Pico (excellent CMS in my eyes), i was disapointed to see many themes aren't been updated for a long time.
I'll publish certainly my modification.

When i started to try Pico (excellent CMS in my eyes), I was disappointed to see many themes aren't been updated for a long time.

Yeah, it's unfortunately that's how most of them have been.  Users tend to develop a theme once, post it on GitHub, then move on to newer projects.  (I'm also guilty of this, with many of my themes being overdue for some care 😅).
Every theme in the gallery should still "work", but the bar is pretty low at the moment.  Most of them could really use some more polish.
@BesrourMS's themes are pretty good, lol.  They're mostly ports from bigger HTML template sites/creators.  Since they are some of the better looking themes in our gallery, I plan to go through and revise these ports someday. I'd like to bring them a little more inline with what I'd like to see the "standard" be in terms of quality, usability, documentation, etc for our themes.  Almost all the themes available for Pico have some kind of paper cuts or rough edges when it comes to usability.
In reality though, I've got plenty of my own themes I've got to improve before I get around to revising other peoples. 😒😅
If you do make some decent improvements to Dimension, or any of his other themes, I'd encourage you to open a PR with @BesrourMS, he's usually pretty quick at responding to Issues and Pull Requests.
And if you find yourself getting into Pico theming at all, go check out some of the free HTML website templates you can find online.  Depending on the template it can be super easy to make these Pico compatible, and we'd always love to see more themes come to our gallery. 😉

Hi @mayamcdougall , I found this website : untree.co, All html templates of Untree.co are licensed under the Creative Common Attribution 3.0 Unported (CC BY 3.0)

Very nice!
They're a bit too corporate-y looking for my taste, but they could still be a good resource.
Maybe I should make a list of these sites on either the website or the wiki at some point . 🤔
Something like "Looking for inspiration? Check out these template sites:" with links to some of the sources we've used, like HTML5 UP!, Start Bootstrap, FreeHTML5.co, Untree.co, etc.


React18

Fixes #784
Covers #781

Any updates on this?

I'm also waiting for this to be merged.

Same

Ok, thanks for the fix. May take a bit to release to NPM.

Ok, thanks for the fix. May take a bit to release to NPM.

will there be a new beta release number? currently on npm there is version 2.0.0-beta.4 that has been released 10 months ago?

@mtraj good question. I assume this will come alongside the next beta release (beta.5), right? @alexkrolick

When will this be available through NPM? Still can't install on react 18. Its stopping us from deploying to our host!

I really wonder what was fixed because right now I have the same issue which happened two years ago


1.19 port

Work on 1.19 port for this mod. Maybe adding some new stuff and updating my code.

This version will include the Korean translation by @gyular


Failure to load whats new file no longer causes crash

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Pr 13 eslint

@gadi-ray Very cool.
Two questions:

Do we want to engage with additional linters like eslint-plugin-promise and eslint-plugin-security?

Does the lint check currently pass?

Thanks @i0natan :)

Sure those are very good eslints, i can add them and use their recommended rules for start.
BTW this is just the skeleton for eslints, anyone can add more :+1:
No, there are many errors and warning, I thought of taking care of it in a new PR

@gadi-ray Forgot to ask, you have permissions to merge, right?


Polyglot Notebook: [DevExE2E][Regression] After stopping the cell, no variable is shown in POLYGLOT NOTEBOOK: VARIABLES page.

Describe the bug
After stopping the cell, no variable is shown in POLYGLOT NOTEBOOK: VARIABLES page.
Note: It's a regression issue. It doesn't repro on - VSCodeUserSetup-arm64-1.81.1 + dotnet-interactive-vscode-1.0.4454011.vsix + dotnet-sdk-7.0.400-win-x64.
Detailed Repro Build info: VSCodeSetup-x64-1.83.1 +dotnet-interactive-vscode-1.0.4514021.vsix+ dotnet-sdk-7.0.402-win-x64
VS Code: https://update.code.visualstudio.com/1.83.1/win32-x64/stable
Version: 1.83.1 (system setup)
Commit: f1b07bd25dfad64b0167beb15359ae573aecd2cc
Date: 2023-10-10T23:48:05.904Z
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.25398
dotnet-interactive-vscode-1.0.4514021.vsix
Build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2291238&view=artifacts&pathAsName=false&type=publishedArtifacts
Steps:

Open the notebook from https://github.com/dotnet/interactive/blob/main/NotebookTestScript.dib.
Execute the 3rd scenario -> Stop the cell
using System.Threading.Tasks;
using Microsoft.DotNet.Interactive;

var output = string.Empty.Display("text/plain");
var counter = 1;
while (!KernelInvocationContext.Current.CancellationToken.IsCancellationRequested)
{
await Task.Delay(500, KernelInvocationContext.Current.CancellationToken);
output.Update($"{counter++}");
}
Expected Results:
After stopping the cell, variables "output", "counter" should be shown in POLYGLOT NOTEBOOK: VARIABLES page.

Actual Results:
After stopping the cell, no variable is shown in POLYGLOT NOTEBOOK: VARIABLES page.

Please complete the following:
Which version of .NET Interactive are you using? (In a notebook, run the #!about magic command. ):

OS

[√] Windows 11
[ ] Windows 10
[ ] macOS
[ ] Linux (Please specify distro)
[ ] iOS
[ ] Android

Browser

[ ] Chrome
[ ] Edge
[ ] Firefox
[ ] Safari

Frontend

[ ] Jupyter Notebook
[ ] Jupyter Lab
[ ] nteract
[√] Visual Studio Code
[ ] Visual Studio Code Insiders
[ ] Visual Studio
[ ] Other (please specify)

I'm not able to repro this.

I still repro this issue on VS Code 1.85.1 + dotnet-interactive-vscode-1.0.4611011.vsix + dotnet-sdk-8.0.100.

This issue doesn't repro on VS Code 1.93.1 + dotnet-interactive-vscode-1.0.5468011.vsix + dotnet-sdk-8.0.401-win-x64. Hence closing it.


Update terraform to 1.5.7

Prepare a 0.6.0 release, building from the last MPL licensed terraform version 1.5.7.
Fixed test workflow failing on Windows.

Given there are no library changes, only updates to terraform, would it be more appropriate to only bump the patch version to 0.5.1?
I have another branch where terraform is upgraded to 1.6.6. I can raise another PR if this change is accepted.

Thanks for contributing. It would be nice to get another PR.


Target profile page rewrite: (Known drugs details) otTable download breaks for csv and tsv

Downloading the table in JSON works fine.
However the data is not mapped correctly for SCV and TSV formats, where it attempts to insert whole objects in the row, resulting in something like[object Object],,,,[object Object],,,,[object Object].

This should be fixed, pending PR approval.

PR has now been merged.


Depth question

    # final depth is the sum of first and second columns of the depth input
    depth.adj <- depth.timestep[1] + abs(depth.timestep[2])

need to better understand and document how the code compute the dz parameter.

newer model format does not contain a depth adjustment parameter.


Add packages needed to authenticate to gmail

Needed to correctly authenticate using a gmail relay

What kind of issues are you running into without these packages, for future reference?

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Hi,
I got the same errors referred in this post:
https://stackoverflow.com/questions/20238922/postfix-sasl-authentication-failure-no-worthy-mechs-found
Boky<EMAIL_ADDRESS>wrote:

What kind of issues are you running into without these
packages, for future reference?

Sent using Mailpile, Free Software from www.mailpile.is
-----BEGIN PGP SIGNATURE-----
iQGcBAEBCgAGBQJcb3WDAAoJEAypDzjVQLnsehoL/1HY7pLE76VjY+8ytBDoNqRj
QPFwAVhwQu/OyEHZaLPtpaKSRhtyE/U6h0brXPUnji7wZMWXsYPcWdnj4pYy5WSX
jRawNtUUa4beOReI5nu5RvWWnazBvbSgqrZrUHfI9Zige5b4ELM7FyqxoQrXTWNl
Zbgql5V+a30nIoHVKSZ6ceiS4cn2EXoUc/5BybYuoJeuyZe056Zd0PUJLO3QTbc2
tJlWBKzhM/dehzbh9b+C6xhxd8l2Qf0A9ObHSfgICQbg2N/9VSGqzREmXoUIbsVY
FpsJwWW+vVu6DNWZd8uk3b4V+d+r4D6Am/x3FuMrYjVp01+Y8Mobe4iqvaXkJRYS
mk4d/dtLM3eHy4jSjx9X7U548jnERzRZcm0PWBj8m+A3mz5zzWnMjjtDDKLxabKZ
kTj8kJL09YOxkrH5FqSSABTwWjXMpbiSzFtp72l2gaNeB0bfYexvWjLaYQYEO7+9
4gTrhEbTDCroQgrR26Qd5KrX5bDaeW2t7WGiVOZwfQ==
=Mn2N
-----END PGP SIGNATURE-----

Thank you for your commit!


Added link to alexjustesen/speedtest-tracker

Added https://github.com/alexjustesen/speedtest-tracker to documentation

Good call! I just made it simpler :)
Thanks again for working this out


Misinterprets closing tag when using Vue generic component

When using Vue generic component, oxc misinterprets the closing tag if using another generic inside the generic attribute.
Here is an example:
<script setup lang="ts" generic="T extends Record<string, string>">
defineProps<{ value: T }>()
</script>

In the above example, generic includes Record<string, string>. Since it has >, it looks like that oxc interprets that > as the closing tag of script.
Here is the result of oxlint:
❯ npx oxlint@latest

  × Unterminated string
   ╭─[src/components/Sample.vue:1:1]
 1 │ ">
   · ───
 2 │ defineProps<{ value: T }>()
   ╰────

It looks like the vue loader doesn't currently support the generic syntax.

I didn't know this is a thing.
We'll have to parse the html attributes now :-)

Is this what causes that error as well?


When the source property of a profile is set to "Windows.Terminal.PowerShellCore", the name and startingDirectory properties are ignored.

Environment
Windows build number:  10.0.19042.0
Windows Terminal version (if applicable): 1.5.10411.0

Any other software? Not needed for this repro.

Steps to reproduce

Paste the following into the settings file:
{
    "$schema": "https://aka.ms/terminal-profiles-schema",
    "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
    "profiles": {
        "list": [
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Test",
                "source": "Windows.Terminal.PowershellCore",
                "startingDirectory": "%UserProfile%\\Documents"
            }
        ]
    }
}

Open the Terminal app.

Expected behavior

I start out in the %UserProfile%\Documents folder with the tab title set to "Test".
Actual behavior

I start out in the %UserProfile% folder with the tab title set to "Windows PowerShell".
Other notes
If I use any of these configs instead, the error does not reproduce.

Note: the GUIDs must match. That's a requirement for this to work.

{
    "$schema": "https://aka.ms/terminal-profiles-schema",
    "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
    "profiles": {
        "list": [
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Test",
                "source": "Windows.Terminal.PowershellCore",
                "startingDirectory": "%UserProfile%\\Documents"
            },
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Test",
                "startingDirectory": "%UserProfile%\\Documents"
            }
        ]
    }
}

{
    "$schema": "https://aka.ms/terminal-profiles-schema",
    "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
    "profiles": {
        "list": [
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Test",
                "startingDirectory": "%UserProfile%\\Documents"
            },
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Test",
                "source": "Windows.Terminal.PowershellCore",
                "startingDirectory": "%UserProfile%\\Documents"
            }
        ]
    }
}

{
    "$schema": "https://aka.ms/terminal-profiles-schema",
    "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
    "profiles": {
        "list": [
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Test",
                "startingDirectory": "%UserProfile%\\Documents"
            },
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "source": "Windows.Terminal.PowershellCore"
            }
        ]
    }
}

{
    "$schema": "https://aka.ms/terminal-profiles-schema",
    "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
    "profiles": {
        "list": [
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "source": "Windows.Terminal.PowershellCore"
            },
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Test",
                "startingDirectory": "%UserProfile%\\Documents"
            }
        ]
    }
}

The pattern I've detected is that the source must be separate from the name and starting directory for those two to work. Of these two configs, the first shows the right name, but loads the wrong directory, and the second loads the right directory but shows the wrong name.
{
    "$schema": "https://aka.ms/terminal-profiles-schema",
    "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
    "profiles": {
        "list": [
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Test",
                "source": "Windows.Terminal.PowershellCore"
            },
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "startingDirectory": "%UserProfile%\\Documents"
            }
        ]
    }
}

{
    "$schema": "https://aka.ms/terminal-profiles-schema",
    "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
    "profiles": {
        "list": [
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "startingDirectory": "%UserProfile%\\Documents",
                "source": "Windows.Terminal.PowershellCore"
            },
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Test"
            }
        ]
    }
}

Possibly related: https://github.com/microsoft/terminal/issues/7197

The “Windows PowerShell” profile was not originally generated by the “Windows.Terminal.PowershellCore” generator (source), so when we load the settings block with the source it is ignored.
Source has a dual meaning. The first and primary meaning is, “this profile came from a generator”. If we cannot find evidence when we ask the generator that it did, in fact, make that profile... it gets ignored. This is how we make sure that when you uninstall a PS Core or WSL instance we delete the profile too. The second meaning is as a combined database key with the guid to connect it to your settings.
Remove source from this profile and don’t re-add it. :smile:

@DHowett So what's your recommendation for resolving this on my end beyond removing the source, to ensure it's a PowerShell shell?

@isiahmeadows it’ll automatically be a PowerShell shell so long as the commandline points to a powershell executable. Ah, i see. I missed that at first! You can set the commandline to point to any version of PowerShell on your computer. The “source” version is only for one autodetected profile per version of powershell(!), which is something we’re working on letting you configure.


Lorem Ipsum text changes.

-Remove the Note.
-The text will be ‘Open your PDF copy which is password protected with your Secret Answer’.

-Take out the text.

-Take out the note.

The text will be: ‘Select your local currency’

-Sent Successfully screen:

The sub title will be: Transactions successfully submitted
2.The lorem Ipsum will be:
The transaction has been submitted to the Bitcoin network. View transactions on the account
screen for details

-Top subtitle: if your 2FA is not working follow one of the below steps

@cakesoft-swati to confirm


Colors incorrect when drawing tiles with scale set in software

See example code: https://gist.github.com/wmarsh/3dd9082c1cee6644dbc8
Only happens in software mode. Happens in neko and Android (at least) - basically anything using native.
Scale = wrong colors (random on each run)
Scale + alpha = fine

Sounds like this is related to https://github.com/openfl/openfl/issues/350