Recommend noc_async_write_flushed() on examples

As an alternative of noc_async_write_barrier(), this commit updates examples to recommend noc_async_write_flushed() that can be faster than noc_async_write_barrier() because it waits until the write request is sent.
Ticket
No Github issue, but I met a case that noc_async_write_barrier() causes an infinite loop, while noc_async_write_flushed() finishes the kernel correctly. You can reproduce it by updating this line to noc_async_write_barrier(). I explained this issue on Discord channel.
Problem description
I met a case that noc_async_write_barrier() causes an infinite loop, while noc_async_write_flushed() finishes the kernel correctly. You can reproduce it by updating this line to noc_async_write_barrier().
What's changed
I added comments on programming examples for tt-metal to recommend noc_async_write_flushed().
Checklist

[ ] Post commit CI passes
[ ] Blackhole Post commit (if applicable)
[ ] Model regression CI testing passes (if applicable)
[ ] New/Existing tests provide coverage for changes

I am curious .. when I can possibly have an infinite loop because of noc_async_write_barrier().
My example has that issue. noc_async_writes_flushed() fixed the issue, so I used noc_async_writes_flushed() instead.

Hey @jaebaek,
I think this note is a good addition to the examples, however, if you use noc_async_writes_flushed(), you should still have a final noc_async_write_barrier() at the end of your kernel so that all writes have actually completed when the kernel terminates, as our runtime expects kernels to complete all transactions before they terminate. We can add this as part of your comment about using flush. An example of why this might be a problem is because if we don't have the final barrier then your kernel finishing doesn't mean your output data has actually been committed, and if we try to read back the output tensor after the operation executed it's possible the writes have not completed and we read back garbage data.
As for the issue you're facing where you seem to hang using noc_async_write_barrier(), it's possible that you are issuing an illegal NOC transaction, for example targeting an incorrect core, so the write never finishes. We have a tool called watcher that can help catch issues like this. You can try running your test with TT_METAL_WATCHER=1 set you see if it catches any issues.

Thank you for clarifying it :)
I actually realized my example code multicast-sent a tile to the sender itself. I guess that's the root cause of the infinite loop but definitely I want to try the watcher tool.
I updated this PR. I added the comment only on the examples with multiple noc_async_write_barrier() calls. I also explained we have to use noc_async_write_barrier() at least once at the end of the data move kernel.

By the way, I finally fixed the bug of the infinite loop on noc_async_write_barrier() from my example. Thanks a lot!

Closing in favour of https://github.com/tenstorrent/tt-metal/pull/11448

Thanks!


Andoid OS

I m sorry, but I m curious,, are there plan to make android apk (native)?

No, but the code should be portable. Send me a PR!


Update Carthage dependencies and Remove deprecated xcconfigs

@tiennou please merge this branch. Master is not buildable anymore for me but I can build this fork.

I gave a spin to that (had to update to 10.15/Xcode 12 to get a working build env again), and I hit build errors with Quick (or Nimble still being Swift 3 (which is unsupported). So I've updated #688, and this one builds for me (at least the Mac scheme does). Can you confirm that it's okay for you as well ? I'll try to wrangle the iOS build in the meantime…


Introduce Dataflow Flex Templates for csv2bt pipeline

Add an option to build Dataflow Flex Templates. Existing Classic Template hardcodes some buckets into the template.
New instances of custom DC must have access to DC internal buckets in order to run csv2bt pipelines. Flex templates are flexible in the sense that the construction of the job graph (template generation) is delayed at execution stage. Parameters such as staging directory can be specified as arguments instead of being hard coded.
Tested by running ./test.sh cache run-cache-flex and run-csv-flex commands.
Results:
https://pantheon.corp.google.com/dataflow/jobs/us-central1/2022-12-15_13_22_37-16044195536509474754;logsSeverity=ERROR;graphView=0?project=google.com:datcom-store-dev&mods=-monitoring_api_staging&pageState=("dfTime":("l":"dfJobMaxTime"))
https://pantheon.corp.google.com/dataflow/jobs/us-central1/2022-12-15_13_31_17-7288624071136476449;logsSeverity=ERROR;graphView=0?project=google.com:datcom-store-dev&mods=-monitoring_api_staging&pageState=("dfTime":("l":"dfJobMaxTime"))
Existing template (and its reference to internal buckets)

Good catch on the existing reference! Changed website-dev.yaml to point to the flex template for testing purposes.

Also, does the GCF dataflow template invocation logic work as is with the new flex templates?

It should but I think it needs more testing. I'm hoping to do more tests on website-dev instance and migrate it over once I'm more confident. So for now I'll change only website-dev.yaml and test as new Custom DC instances are created.


add nginx reverse proxy

This PR is included in version 1.0.0 :tada:

This PR is included in version 1.0.0 :tada:

This PR is included in version 1.0.0 :tada:


docker compose autocompletion content refresh

Proposed changes

Unreleased project version (optional)

Related issues (optional)

This incorporates changes from #8092

Deploy preview for docsdocker ready!
Built with commit 51cac2184dfd24efaf5d435143e04f08545ad6bf
https://deploy-preview-8329--docsdocker.netlify.com


[bugfix] Remove the validation of the name of the test's base classes

close #451

Codecov Report

Merging #480 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
+ Coverage   91.36%   91.38%   +0.01%
==========================================
  Files          70       70
  Lines        8790     8782       -8
==========================================
- Hits         8031     8025       -6
+ Misses        759      757       -2

Impacted Files
Coverage Δ

reframe/frontend/loader.py
93.87% <100%> (-0.47%)
:arrow_down:

unittests/test_policies.py
100% <0%> (+0.9%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1294eeb...3167c2a. Read the comment docs.


Fixes: "kotlinx-serialization-runtime" dependency error

Fixes for below issue
https://github.com/truongsinh/appium-flutter-driver/issues/41

@shibupanda this change only affects the example. Should we do such that it is applied to the finder itself?

@truongsinh definitely let me try to build the kotlin jar having serilization runtime 0.14 build.
It's really helps if you can share the environment details for kotlin and build command so that I can test it as well.

Here's my java runtime:
java version "1.8.0_131"
Java(TM) SE Runtime Environment (build 1.8.0_131-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode)

For Kotlin, I don't have it installed in the environment, I just have it installed via dependencies, in this case
version 1.34.0 https://github.com/truongsinh/appium-flutter-driver/blob/master/finder/kotlin/build.gradle.kts#L10

Could it be possible that Maven (pom.xml) is not compatible with Gradle?
May be
But let me check I have built the jar having "kotlinx-serialization-runtime v0.14.0" .
Testing in progress

@truongsinh looks like Maven is not compatible with gradle.
So it is not retrieving the jar in the maven local repository. And the same is happening for whaterver dependencies we have added in https://github.com/truongsinh/appium-flutter-driver/blob/fb3aa42149e245bd86b5593cb5ef57d769d02e2f/finder/kotlin/build.gradle.kts#L20

@truongsinh Got the fixes. I will update the commit soon.

@truongsinh added argument in waitFor and waitForAbsent function by default it is 10 * 1000 ms if it is undefined.
Fixes done for kotlin finder (tested working as expected), it is retrieving the jar from maven central and added into .m2 folder (local repository).
In previous build it failed and .m2 folder didn't contain the dependency jar.
Old Kotlin Build:

New Build with the changes:

eagerly waiting for this fix. I am trying to run appium flutter driver in a real ios device. :)

cc @truongsinh

@shibupanda thanks again for your contribution. However, it's better to have each PR to address separate issue (single-responsibility principle applies not only in classes :D)
I will try to "isolate the code" used for "kotlinx-serialization-runtime" first, and either of us can open the 2nd PR for wait command

These 2 has been merged by #51 and #52, all credits to @shibupanda


Better github code reference.

Better github code reference: inspired by this comment
Probably we have all except the code endline: anyway here it is what I think we have to watch out for.

needs exact line numbers for: docstring startline, endline
needs exact line numbers for: code startline, endline

MAIN ISSUES: To watch out if there are empty lines or commend lines between docstring end and code start lines
txt_startln: Must be the start line of the single/tripple quoted docstring or aside open bracket in case it goes over multiple lines
txt_endln: Must be the end line of the single/tripple quoted docstring or aside end bracket
code_startln: Must be the actual code start disregarding any empty or commentlines between docstring and code
code_endln: Must be the actual end line of the code: e.g for a function the last end
"""  #txt_startln
our nice documentation function

""" #txt_endln

# some funny empty and comment lines added by the coder
# this could happen eventhough it should not.

function nice_documentation() #code_startln
    txt_startln = 123
    txt_endln = 138
    code_startln = 145
    code_endln = 163

end #code_endln

If we have that we have all options for instance to reference the whole block line form txt_startln - code_endln or the split txt, code option.

Could do, might be possible to do this from the Lexicon side completely since we'll have stored the file paths and it might be easier to find endings in the text source rather than parsed Exprs.

As much line info as needed is now being stored in metadata. The rest of the concerns here can be met in Lexicon.


输入光标靠下的问题

Description
在linux 上使用 24.1.0 版本 发现以下问题：
当输入行前存在字符时 光标会下移，而在空白行的行首时不会
当然 没有图片中那么夸张 因为截图工具截取不了闪烁的光标，所以我画了一条线来表示

事实上在之前的版本上就已经发现这个问题了 只是一直没有反馈
DBeaver Version
24.1.0
Operating System
deepin v23 RC2
Database and driver
database oracle 11gr2
driver odbc11:release<IP_ADDRESS>
Steps to reproduce
No response
Additional context
No response

当光标在括号中间的时候更明显 括号会上移 光标会下移，光标移除括号之后括号显示恢复正常

The following issues were found when using version 24.1.0 on Linux:
When there are characters before the input line, the cursor will move down, but it will not move down at the beginning of a blank line.

When the cursor is in the middle of the parentheses, it becomes more prominent. The parentheses will move up ,the cursor will move down, and after the cursor moves out of the parentheses, the display of the parentheses will return to normal

Regarding the parentheses - you can turn this off in preferences

I'm closing this issue as a duplicate of #8552

Question 1 has already been described in issue https://github.com/dbeaver/dbeaver/issues/8552 . We haven't decided to change this behavior yet. However, you can vote for the mentioned issue with 👍 under the issue description to promote it to a higher priority.
Question2 - is expected behavior. If you don't like it, you can turn this off in the preferences.

Q1: I didn't express myself clearly
This picture may better illustrate the problem

Q2 I understood

I get your explanation. This issue is closed in order to avoid duplication of similar requests. Here is the issue about the same thing, that is already exist https://github.com/dbeaver/dbeaver/issues/8552#issuecomment-627093247


Country page: Replace "Change country" menu with a "Browse sites" link to the Sites landing page

UPDATE: With #1205 we are removing the entire Browse menu, so that we don't end up with a menu that has a single option: Sites. We are expanding this ticket to not just remove the Country menu but replace it with a link to Browse all sites
Issue
On the Country page, the "change country" menu above site map is pretty fidgety. You have to click it just so, and it's difficult to switch to more than one country in sequence. You have to un-focus on the menu, then re-focus. Sometimes it reacts before I've had a chance to make a selection. It's just... not good. That menu is redundant at this point, now that we have a much more user-friendly Country and Program search box in the top nav bar, immediately above the "change country" menu.
For reference, here's the current site map with "Change country" menu.

Acceptance criteria

[x] 1. There is no longer a "change country" menu above the site map, next to the Country name.

[x] 2. There is a new "Browse all sites" link in line with the Country name. It takes me to the same place our top nav "Browse > Sites" option used to take me.

Styling note: I mocked up the "Browse all sites" link to be right-aligned with the map rather than immediately after the country name. While I think this makes the link more visible, it might cause problems with a longer country name like Democratic Republic of the Congo. If that's the case or it's otherwise problematic, it's fine to place it where the "Change country" menu currently lives.
Housekeeping

[ ]  Unit test/s written wherever applicable
[ ]  i18n tags included wherever applicable
[ ]  Functionality is accessible to people using screen readers

It does seem pretty redundant.

Removed estimate because the scope of the ticket has changed.

I did this with the right aligned setup per mockups, looks fine with DRC:

I worry that the CSS on this is.... jaw-droppingly ugly.  If @axoplasm has a chance to look at it (it's on 663d86d) it could probably be done in a less horrifying way.

Here's what I see after Paul's updates -- looks fine.

The link also goes where it is supposed to go.


Fix unexpected behaviours in legends

@arianaescobar has found some cases where legends are not behaving as expected.
Here I have solved the ones related to Frontend:
Input values get changed automatically (https://github.com/CartoDB/cartodb/commit/8d0bbfd523bebd54524f052f33aecfda6c9f8f83)
When opening the new Color/Size dialog (and before that, as well), we check that we have a range to style points based on it. The thing was that, when setting min and max to the same value in the dialog, it believed that there was a fixed value instead of a range with same bounds.
Responsive behavior (https://github.com/CartoDB/cartodb/commit/77ff16906139b217c020567a97b7f1682a9e7aba)
There was a case in the max-width: $sMedia-tablet - 1 media query for embed styles where we were assuming that there will always be widgets in all visualizations, so we were adding the height of that view to the max-height calculation while we shouldn't because obvious reasons.
Remove extra margin in collapsed legends (https://github.com/CartoDB/cartodb/commit/19185f314d15dd2cf9bc51674fc1eee0953e25c8)
Seems like we put a margin to the legends view that added 10px to the bottom padding, where there shouldn't be any margin.
Related to https://github.com/CartoDB/carto.js/issues/2146 and https://github.com/CartoDB/cartodb/issues/14091

Bandera ✨


add keepKeepIndexOnChange

Add the keepIndexOnChange that allows controlling the scroll behavior when items is changed.
The default behavior is that when items changes the scroll value is persisted, setting keepIndexOnChange to true will persist current sliced items and update the scroll value.
Also included #57 and #56

I'm sorry. Since this PR has merge conflicts that have not been resolved, it can't be merged. Because the PR hasn't been updated in almost a year I'm assuming this request has been abandoned. I'm closing this for now, but willing to reconsider if the merge conflicts are resolved & the PR re-submitted.
This PR also includes extensive code changes that look complex which make me nervous about regression testing to ensure we're not inadvertently breaking existing features. If it were re-submitted I'd want to discuss the purpose & design a bit more before proceeding.
Thanks again for your contribution. I know it can be frustrating when a PR isn't accepted right away. I want to work with you to make sure the code changes provide the most beneficial to all users. If you have any future ideas, please don't hesitate to contribute again.


Rename section_id to section_number in sections table and use section_title in system

We treat the section_id as the section_number anyway in the classlist, so might as well have that column name reflect this. We'd also want to get rid of the auto-increment on the table and have users hand put the number.
Additionally, we want to start using "section_title" in various parts of the system (such as in grading table) as right now, it's not used for anything and kind of a pointless column.

Done in f2647d0a412bc31e4746ed65ccd45c5bc1109ed1


[Feature Request] Support for Swarm Services

It would be great if Ouroboros detect and update services deployed in a Docker Swarm cluster.
A support for swarm services is already in dockerpy:
https://docker-py.readthedocs.io/en/stable/services.html

@computeralex92 added in develop. Please take a few moments to test it out and ensure it works as intended. Currently it only works with labels with the mentality of "If you can use swarm, you can use labels"

While the dry mode is working without any issue, the update of a service is failing:
python3 ./ouroboros -o -S
2019-02-07 10:16:16 : INFO : ouroboros : Version: 1.2.0-develop
2019-02-07 10:16:16 : INFO : base : Scheduler started
2019-02-07 10:16:16 : INFO : base : Added job "Run Once container update for ********unix://********.sock" to job store "default"
2019-02-07 10:16:16 : INFO : base : Running job "Run Once container update for unix://var/run/docker.sock (trigger: date[2019-02-07 10:16:16 CET], next run at: 2019-02-07 10:16:16 CET)" (scheduled at 2019-02-07 10:16:16.457317+01:00)
2019-02-07 10:16:16 : INFO : base : Removed job 4d22e7bc754644738f6fd59d60080a06
2019-02-07 10:16:18 : INFO : dockerclient : mirror_nginx will be updated
2019-02-07 10:16:18 : ERROR : base : Job "Run Once container update for unix://var/run/docker.sock (trigger: date[2019-02-07 10:16:16 CET], next run at: 2019-02-07 10:16:16 CET)" raised an exception
Traceback (most recent call last):
  File "/root/ouroboros/virtualenv/lib/python3.7/site-packages/apscheduler/executors/base.py", line 125, in run_job
    retval = job.func(*job.args, **job.kwargs)
  File "/root/ouroboros/application/pyouroboros/dockerclient.py", line 406, in update
    self.notification_manager.send(container_tuples=updated_service_tuples, socket=self.socket, kind='update')
  File "/root/ouroboros/application/pyouroboros/notifiers.py", line 57, in send
    ) for container, old_image, new_image in container_tuples
  File "/root/ouroboros/application/pyouroboros/notifiers.py", line 57, in <listcomp>
    ) for container, old_image, new_image in container_tuples
AttributeError: 'str' object has no attribute 'short_id'
2019-02-07 10:16:18 : INFO : base : Scheduler has been shut down

So good and bad news. that is not the service, but the notifier that is erroring. Can you confirm the service did not update as well?

It seems that the update itself was working; the container in the service is used for testing were recreated.
Btw:
I get now this error when I run it in dry mode:
Traceback (most recent call last):
  File "/root/ouroboros/virtualenv/lib/python3.7/site-packages/apscheduler/executors/base.py", line 125, in run_job
    retval = job.func(*job.args, **job.kwargs)
  File "/root/ouroboros/application/pyouroboros/dockerclient.py", line 369, in update
    sha256 = image_string.split('@')[1][7:]
IndexError: list index out of range```

the above fixes the notification error. I am going to need the output of image_string to know whats going on there. can you add a print(image_string) on the next line (370) in dockerclient.py and give me the output?

I added the print in both branches of the code; the result is in both cases the same:
2019-02-12 08:33:39 : INFO : ouroboros : Version: 1.2.0-develop
nginx:stable-alpine
2019-02-12 08:33:39 : ERROR : base : Job "Run Once container update for unix://var/run/docker.sock (trigger: date[2019-02-12 08:33:39 CET], next run at: 2019-02-12 08:33:39 CET)" raised an exception
Traceback (most recent call last):
  File "/root/ouroboros/virtualenv/lib/python3.7/site-packages/apscheduler/executors/base.py", line 125, in run_job
    retval = job.func(*job.args, **job.kwargs)
  File "/root/ouroboros/application/pyouroboros/dockerclient.py", line 426, in update
    sha256 = image_string.split('@')[1][7:]
IndexError: list index out of range

lots of updates since i posted that. looks like line 425 needs the print now. (basically the line above the error line)

OK, i added the line; the code part here is:
         for service in self.monitored:
             image_string = service.attrs['Spec']['TaskTemplate']['ContainerSpec']['Image']
             print(image_string)
             tag = image_string.split('@')[0]
             print(image_string)
             sha256 = image_string.split('@')[1][7:]

The error message is:
# python3 ./ouroboros -A -o -S
2019-02-12 08:45:19 : INFO : ouroboros : Version: 1.2.0-develop
nginx:stable-alpine
nginx:stable-alpine
2019-02-12 08:45:19 : ERROR : base : Job "Run Once container update for unix://var/run/docker.sock (trigger: date[2019-02-12 08:45:19 CET], next run at: 2019-02-12 08:45:19 CET)" raised an exception
Traceback (most recent call last):
  File "/root/ouroboros/virtualenv/lib/python3.7/site-packages/apscheduler/executors/base.py", line 125, in run_job
    retval = job.func(*job.args, **job.kwargs)
  File "/root/ouroboros/application/pyouroboros/dockerclient.py", line 425, in update
    sha256 = image_string.split('@')[1][7:]
IndexError: list index out of range

interesting... its totally missing the sha. I appreciate you working with me (I cant seem to replicate it myself so this helps). Can you put another print in that shows all the attrs?
         for service in self.monitored:
             print(service.attrs)
             image_string = service.attrs['Spec']['TaskTemplate']['ContainerSpec']['Image']
             print(image_string)
             tag = image_string.split('@')[0]
             print(image_string)
             sha256 = image_string.split('@')[1][7:]

Here is the output:
{'ID': 'v3q5os7qywevqvk6km1ml44rk', 'Version': {'Index': 2466}, 'CreatedAt': '2019-01-15T12:40:15.681790818Z', 'UpdatedAt': '2019-02-12T07:27:08.750889355Z', 'Spec': {'Name': 'mirror_nginx', 'Labels': {'com.docker.stack.image': 'nginx:stable-alpine', 'com.docker.stack.namespace': 'mirror', 'com.ouroboros.enable': 'true', 'traefik.backend': 'Mirror', 'traefik.docker.network': 'mirror', 'traefik.enable': 'true', 'traefik.frontend': 'Mirror', 'traefik.frontend.rule': 'Host:HOST', 'traefik.port': '80'}, 'TaskTemplate': {'ContainerSpec': {'Image': 'nginx:stable-alpine', 'Labels': {'com.docker.stack.namespace': 'mirror'}, 'Privileges': {'CredentialSpec': None, 'SELinuxContext': None}, 'Mounts': [{'Type': 'bind', 'Source': '/opt/docker/mirror/nginx/nginx.conf', 'Target': '/etc/nginx/nginx.conf', 'ReadOnly': True}, {'Type': 'bind', 'Source': '/opt/mirror/', 'Target': '/var/www/vhosts/mirror', 'ReadOnly': True}], 'StopGracePeriod':<PHONE_NUMBER>0, 'DNSConfig': {}, 'Isolation': 'default'}, 'Resources': {}, 'RestartPolicy': {'Condition': 'any', 'Delay':<PHONE_NUMBER>, 'MaxAttempts': 0}, 'Placement': {'Platforms': [{'Architecture': 'amd64', 'OS': 'linux'}, {'OS': 'linux'}, {'Architecture': 'arm64', 'OS': 'linux'}, {'Architecture': '386', 'OS': 'linux'}, {'Architecture': 'ppc64le', 'OS': 'linux'}, {'Architecture': 's390x', 'OS': 'linux'}]}, 'Networks': [{'Target': 'j8ma50vt0chbvwjf3fvwfw6t7', 'Aliases': ['nginx']}], 'ForceUpdate': 1, 'Runtime': 'container'}, 'Mode': {'Replicated': {'Replicas': 8}}, 'UpdateConfig': {'Parallelism': 1, 'FailureAction': 'pause', 'Monitor':<PHONE_NUMBER>, 'MaxFailureRatio': 0, 'Order': 'stop-first'}, 'RollbackConfig': {'Parallelism': 1, 'FailureAction': 'pause', 'Monitor':<PHONE_NUMBER>, 'MaxFailureRatio': 0, 'Order': 'stop-first'}, 'EndpointSpec': {'Mode': 'vip'}}, 'PreviousSpec': {'Name': 'mirror_nginx', 'Labels': {'com.docker.stack.image': 'nginx:stable-alpine', 'com.docker.stack.namespace': 'mirror', 'com.ouroboros.enable': 'true', 'traefik.backend': 'Mirror', 'traefik.docker.network': 'mirror', 'traefik.enable': 'true', 'traefik.frontend': 'Mirror', 'traefik.frontend.rule': 'Host:HOST', 'traefik.port': '80'}, 'TaskTemplate': {'ContainerSpec': {'Image': 'nginx:stable-alpine@sha256:b96aeeb1687703c49096f4969358d44f8520b671da94848309a3ba5be5b4c632', 'Labels': {'com.docker.stack.namespace': 'mirror'}, 'Privileges': {'CredentialSpec': None, 'SELinuxContext': None}, 'Mounts': [{'Type': 'bind', 'Source': '/opt/docker/mirror/nginx/nginx.conf', 'Target': '/etc/nginx/nginx.conf', 'ReadOnly': True}, {'Type': 'bind', 'Source': '/opt/mirror/', 'Target': '/var/www/vhosts/mirror', 'ReadOnly': True}], 'Isolation': 'default'}, 'Resources': {}, 'Placement': {'Platforms': [{'Architecture': 'amd64', 'OS': 'linux'}, {'OS': 'linux'}, {'Architecture': 'arm64', 'OS': 'linux'}, {'Architecture': '386', 'OS': 'linux'}, {'Architecture': 'ppc64le', 'OS': 'linux'}, {'Architecture': 's390x', 'OS': 'linux'}]}, 'Networks': [{'Target': 'j8ma50vt0chbvwjf3fvwfw6t7', 'Aliases': ['nginx']}], 'ForceUpdate': 1, 'Runtime': 'container'}, 'Mode': {'Replicated': {'Replicas': 8}}, 'EndpointSpec': {'Mode': 'vip'}}, 'Endpoint': {'Spec': {'Mode': 'vip'}, 'VirtualIPs': [{'NetworkID': 'j8ma50vt0chbvwjf3fvwfw6t7', 'Addr': '<IP_ADDRESS>/24'}]}, 'UpdateStatus': {'State': 'completed', 'StartedAt': '2019-02-07T09:16:18.486639368Z', 'CompletedAt': '2019-02-07T09:17:01.251909255Z', 'Message': 'update completed'}}
nginx:stable-alpine
nginx:stable-alpine
2019-02-13 17:19:43 : ERROR : base : Job "Run Once container update for unix://var/run/docker.sock (trigger: date[2019-02-13 17:19:43 CET], next run at: 2019-02-13 17:19:43 CET)" raised an exception
Traceback (most recent call last):
  File "/root/ouroboros/virtualenv/lib/python3.7/site-packages/apscheduler/executors/base.py", line 125, in run_job
    retval = job.func(*job.args, **job.kwargs)
  File "/root/ouroboros/application/pyouroboros/dockerclient.py", line 438, in update
    sha256 = image_string.split('@')[1][7:]
IndexError: list index out of range```

I only removed all hostnames etc which are included in the trace.

I cant seem to replicate your issue :/
>>> service.attrs['PreviousSpec']['TaskTemplate']['ContainerSpec']['Image']
'busybox:latest@sha256:7964ad52e396a6e045c39b5a44438424ac52e12e4d5a25d94895f2058cb863a0'
>>> service.attrs['Spec']['TaskTemplate']['ContainerSpec']['Image']
'busybox:glibc@sha256:d9fbf8e504f3fbdd6718621bcb21e98b962dd2621aab7b99890c639c5dffeb4e'

even when i do an update, the update still shows the spec with the sha. Im not sure what is going on in your environment. For now i can add a check/skip if there is no sha, because without the sha there is no other way to know what image it is using

OK, that is strange:
I made a test with a another stack:

Only the new stack: No error appears
The new stack the old one: No error appears
Only the old one: No error appears

I think the reason why now the old stack is working without any issue is that the containers where recreated when I disabled the label for ouroboros.
And Bingo; I think I found the "reason" for the issue:
I run for the old stack ouroboros without the dry mode; and this error appears:
2019-02-13 19:34:23 : ERROR : base : Job "Run Once container update for unix://var/run/docker.sock (trigger: date[2019-02-13 19:34:21 CET], next run at: 2019-02-13 19:34:21 CET)" raised an exception
Traceback (most recent call last):
  File "/root/ouroboros/virtualenv/lib/python3.7/site-packages/apscheduler/executors/base.py", line 125, in run_job
    retval = job.func(*job.args, **job.kwargs)
  File "/root/ouroboros/application/pyouroboros/dockerclient.py", line 475, in update
    self.notification_manager.send(container_tuples=updated_service_tuples, socket=self.socket, kind='update')
  File "/root/ouroboros/application/pyouroboros/notifiers.py", line 57, in send
    ) for container, old_image, new_image in container_tuples
  File "/root/ouroboros/application/pyouroboros/notifiers.py", line 57, in <listcomp>
    ) for container, old_image, new_image in container_tuples
AttributeError: 'str' object has no attribute 'short_id'

And in dry mode again, our old error friend appears again:
2019-02-13 19:34:50 : ERROR : base : Job "Run Once container update for unix://var/run/docker.sock (trigger: date[2019-02-13 19:34:50 CET], next run at: 2019-02-13 19:34:50 CET)" raised an exception
Traceback (most recent call last):
  File "/root/ouroboros/virtualenv/lib/python3.7/site-packages/apscheduler/executors/base.py", line 125, in run_job
    retval = job.func(*job.args, **job.kwargs)
  File "/root/ouroboros/application/pyouroboros/dockerclient.py", line 438, in update
    sha256 = image_string.split('@')[1][7:]
IndexError: list index out of range

So the first error while updating the service produce the second one.
Btw: the container will be recreated while the update failure.

So you are saying the issue was transient of the other issue, and with the above fix it self resolved?

i forgot to pin the fix for the notification manager. Its pinned as of the just now push

So you are saying the issue was transient of the other issue, and with the above fix it self resolved?

I think so, but the issue was solved with the recreation of the containers after the first update of the config.
It seems that the broken update process damage something which cause the issue when running the tool again.

Sweet. Ok ill close this out as its being pushed to develop and then master tonight :) thanks for all your help!


Docs: Another solution for the "no space left on device"

The another solution is editing the ~/boot2docker/.profile and change the DiskSize key.

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:gustavohenrique/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

This will update the existing PR, so DO NOT open a new one.

very thumbs up, thankyou @gustavohenrique for this
LGTM - @docker/docs-owners

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:gustavohenrique/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

This will update the existing PR, so DO NOT open a new one.

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:gustavohenrique/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~3
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

This will update the existing PR, so DO NOT open a new one.

Ping @moxiegirl!

@gustavohenrique oh, :cry: it looks like this PR needs a rebase, because the docs were moved from /docs/sources/ to /docs/ this document can now be found here: /docs/articles/b2d_volume_resize.md.
Are you able to rebase and update with the text that @moxiegirl provided, or would you like one of the doc maintainers to carry this for you?

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:gustavohenrique/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~8
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@thaJeztah, I used the text provided by @moxiegirl.
Thanks @moxiegirl

Thanks @gustavohenrique much better. Before we can merge, please rebase and squash your commits. This page explains how: http://docs.docker.com/project/create-pr/#rebase-your-branch
If you can't do this happy to carry.

@moxiegirl done! Can you check it, please?

@gustavohenrique Looks like it got all wonky.  Would you like me to carry this change @gustavohenrique?

@moxiegirl Yes, please!


Max call stack exceeded / Out of stack space when using lots of sagas

We have an app that is making heavy use of sagas. With versions 0.13.0 and up we sometimes run into max call stack errors due to the recursive scheduler and having too many things on the queue. The exact error depends on the browser and circumstance (for example: "Maximum call stack size exceeded" or "Out of stack space") . There is a PR to fix this and a lot of relevant discussion in that PR: https://github.com/redux-saga/redux-saga/pull/790
Our workaround so far has been to revert and pin to<EMAIL_ADDRESS>Opening this as a separate issue here because:

It will be easier to find when searching for the error. I happened to stumble upon the PR via google search after not finding any GH issues about it.
This issue can be a place for discussion about things like workarounds that are unrelated to that PR itself
If for some reason that PR doesn't work out then the issue is still valid

This is PR attempting to solve this issue, however author abandoned it due to lack of time. Would you be willing to give it a shot? Not much there to finish the work. Would be happy to merge it in asap when its finished.

Hi @Andarist - I've got some time to work on this now. Logistically, how should that work - open a new PR?

@wilsaj I think the best way is to:
git remote add pbadenski https://github.com/pbadenski/redux-saga.git
git fetch pbadenski
git checkout pbadenski/master
git checkout -b BRANCH_NAME

and start from there

Hi Guys,
I'm still getting this issue at 0.15.6
When utilizing a lot of Sagas, in high traffic / concurrency, my app will break:
redux-saga error: uncaught at fetchCategoryAPI
RangeError: Maximum call stack size exceeded
    at /var/ruparupa/frontend/node_modules/redux-saga/lib/internal/middleware.js:68:23
    at /var/ruparupa/frontend/node_modules/redux-saga/lib/internal/middleware.js:72:22

It doesn't always break at the same Sagas
Should I increase my OS limit on the stack size ? I doubt that will answer the issue.
it seems to point to this part of the redux-saga code
return function (next) {
      return function (action) {
        if (sagaMonitor && sagaMonitor.actionDispatched) {
          sagaMonitor.actionDispatched(action);
        }
        var result = next(action); // hit reducers --> recursion on line 72
        sagaEmitter.emit(action);
        return result;
      };
    };

Could this be another issue on the recursion ? @wilsaj @Andarist
Many thanks in advanced for the responses


Only report to slack no CI

Hi, I am not sure how I can use this to only report on slack. I have the slack webhook , but all i want is that when I run npm test
to run all the specs and generates a report on its own at the end and posts it on slack.
I followed this
https://medium.com/@you54f/slack-reporting-for-cypress-io-421064865a83
You say I do this $ export SLACK_WEBHOOK_URL=yourWebhookUrlHere
I dont have a CI or anything.
"reporter": "cypress-multi-reporters",     "reporterOptions": {         "reporterEnabled": "mochawesome",         "mochawesomeReporterOptions": {             "reportDir": "cypress/reports/mocha",             "quite": true,             "overwrite": false,             "html": false,             "json": true         }     }
and in my package.json I have
    "cy:run": "CYPRESS_RETRIES=3 cypress run "",     "clean:reports": "rm -R -f cypress/reports && mkdir cypress/reports && mkdir cypress/reports/mochareports",     "pretest": "npm run clean:reports",     "scripts": "cypress run",     "combine-reports": "mochawesome-merge cypress/reports/mocha/*.json > cypress/reports/mochareports/report.json",     "generate-report": "marge cypress/reports/mochareports/report.json -f report -o cypress/reports/mochareports",     "posttest": "npm run combine-reports && npm run generate-report",     "test" : "npm run cy:run|| npm run posttest"
"dependencies": {     "cypress": "^5.2.0",     "cypress-cucumber-preprocessor": "^2.5.4",     "cypress-file-upload": "^4.0.7",     "cypress-multi-reporters": "^1.4.0",     "faker": "^4.1.0",     "mocha": "^8.2.1",     "mochawesome": "^6.2.1",     "mochawesome-merge": "^4.2.0",     "mochawesome-report-generator": "^5.1.0"   },

Hi,
Running it with --ci-provider none should give you the required behaviour of sending a report only to slack, based on your test results.


Update for usace issue

in the config file usace_timeslices_folder  : usace_timeslices/ the letter 's' was missing and that was causing the t-rout skip usace_timeslices folder. By adding 's' it would go through the folder but since the usace files are all empty it throw an error and couldn't process it. So the update in nhd_io.py checks if the size is zero then return empty dataframe
Additions

Removals

Changes

Testing

Screenshots
Notes

Todos

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Target Environment support

[ ] Windows
[ ] Linux
[ ] Browser

Accessibility

[ ] Keyboard friendly
[ ] Screen reader friendly

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Flexible from small to large screens
[ ] No linting errors or warnings
[ ] JavaScript tests are passing

I'm weighing in here, b/c I'm presently working on the related
pydantic check of the gage folders.
We do have situations where all of the USACE files are empty, including our
beloved Lower Colorado test example. I would advise against throwing an
error in such situations. I believe the user needs to be told somewhere if
all the USACE files are empty, but there is no reason not to run the
simulation.
On Fri, May 24, 2024 at 2:21 PM Amin Torabi @.***>
wrote:

@.**** commented on this pull request.
In src/troute-network/troute/nhd_io.py
https://github.com/NOAA-OWP/t-route/pull/768#discussion_r1614035505:

if all_empty:

   LOG.debug(f'DataFrames in the list are empty.')

   return pd.DataFrame()

it ends the function. if its all empty we don't need to continue, we can
just return empty dataframe (similar to else: statement)
—
Reply to this email directly, view it on GitHub
https://github.com/NOAA-OWP/t-route/pull/768#discussion_r1614035505, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BBPBYNIF2XXLOFJMQCRISPDZD6VNJAVCNFSM6AAAAABIGEC5N2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZYGA3TEMJTGA
.
You are receiving this because your review was requested.Message ID:
@.***>

To be more specific: I understand that we could just turn off reservoir
persistence for usace, but if we have a situation where someone wants
to run the same model over a long and then a shorter time period, and we
happen to not have gage data over the shorter period, then the
simulation would throw an error if we disallow empty gage files. Which
would be difficult to understand for a user.
On Fri, May 24, 2024 at 2:40 PM Jurgen Zach - NOAA Affiliate <
@.***> wrote:

I'm weighing in here, b/c I'm presently working on the related
pydantic check of the gage folders.
We do have situations where all of the USACE files are empty, including
our beloved Lower Colorado test example. I would advise against throwing an
error in such situations. I believe the user needs to be told somewhere if
all the USACE files are empty, but there is no reason not to run the
simulation.
On Fri, May 24, 2024 at 2:21 PM Amin Torabi @.***>
wrote:

@.**** commented on this pull request.
In src/troute-network/troute/nhd_io.py
https://github.com/NOAA-OWP/t-route/pull/768#discussion_r1614035505:

if all_empty:

   LOG.debug(f'DataFrames in the list are empty.')

   return pd.DataFrame()

it ends the function. if its all empty we don't need to continue, we can
just return empty dataframe (similar to else: statement)
—
Reply to this email directly, view it on GitHub
https://github.com/NOAA-OWP/t-route/pull/768#discussion_r1614035505,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBPBYNIF2XXLOFJMQCRISPDZD6VNJAVCNFSM6AAAAABIGEC5N2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZYGA3TEMJTGA
.
You are receiving this because your review was requested.Message ID:
@.***>


conmon/pause: Allow user-specified CFLAGS

-std, -O, and -W are all options that the caller should be able to set for themselves.  My personal preference is to drop these defaults (and leave it up to the compiler and system configuration to get reasonable defaults, #1361), but that approach was not acceptable to the CRI-O maintainers.  This pull-request moves options that CRI-O doesn't really need into a fallback ?= definition.  The options that we do need stay in the override += append.  The main drawback to this approach (vs. dropping the ?= definition default completely) is that a user setting, for example, CFLAGS=-O2 will clobber our default -std, etc. values.  But I can't see a way around that besides the approach in #1361.
CC @rhatdan and @giuseppe, who both had opinions about #1361.

LGTM
@runcom @mrunalp @umohnani8 PTAL

LGTM as well

LGTM


As a standardbounties user, id like to be able to fulfill after the expiration date.

https://beta.bounties.network/bounty/v1/29
https://github.com/MarketProject/Dapp/issues/30
Expected behaviour
I should be able to submit work after the expiration date.
or
As a bounty submitter, I should be able to configure my bounty such that the expiration date is a soft target.
Current behaviour
Users submission throws() when submission happens after expiration date
http://bits.owocki.com/1I3P2W0r1x0U/Screen Shot 2018-02-12 at 10.04.52 AM.png

@mbeylin Got a bump on this from a community member looking for this functionality. Any word on where it is on the roadmap?

Deadlines are being removed in version 2.0 of StandardBounties so this won't be an issue when we eventually complete and deploy that.
However in the meantime, 3 solutions exist:

bounty issuers pick a deadline, and can extend it if they desire (this functionality exists in the currently live standard bounties contract)
bounty issuers pick a deadline that's really far in advance knowing they don't care about deadline
the deadline you enter on gitcoin is stored off-chain (in the JSON object that's on IPFS), and the on-chain deadline is just max_int or something like that to ensure it never really expires

As a funder, I've been posting my tasks with a 1 week expiration. Can I got back and update the time frame in the ticket?

I like this solution: the deadline you enter on gitcoin is stored off-chain (in the JSON object that's on IPFS), and the on-chain deadline is just max_int or something like that to ensure it never really expires

@owocki Very nice!

https://github.com/gitcoinco/web/pull/566
deployed this today!


refactor: Get rid of namespaces

Namespaces are kind of a legacy concept. They should be removed and replaced with functions in normal modules. There really isn’t any call for using them here.

ScalarConverter
StringHelpers
NumHelpers

Removed namespaces in https://github.com/GregRos/parjs/pull/85


[Bug] arbitrum-one not working

Bug report
Every time the graph-node restarts I see these logs bellow.
This makes the pod to take more time restarting.
I found these logs bellow to help defining the fix
Affected Image tag: 55cff04
Working Image tag: fc80657
Relevant log output
After every graph-node restart:

graph-node Nov 22 11:08:46.708 DEBG Trying again after IPFS.Gateway.send_test_request failed (attempt #3) with result Err(RequestFailed(RequestError(reqwest::Error { kind: Status(403
) })))
graph-node Nov 22 11:08:47.170 DEBG Trying again after IPFS.Gateway.send_test_request failed (attempt #4) with result Err(RequestFailed(RequestError(reqwest::Error { kind: Status(403
) })))
graph-node Nov 22 11:08:53.800 DEBG Trying again after IPFS.Gateway.send_test_request failed (attempt #5) with result Err(RequestFailed(RequestError(reqwest::Error { kind: Status(403
) }))

Nov 22 11:18:33.794 ERRO Provider 'arbitrum-firehose-pinax' does not support extended blocks on chain 'arbitrum-one'
Nov 22 11:18:33.794 ERRO Unable to get a connection for block ingestor, err: all providers failed for chain 'arbitrum-one', component: EthereumFirehoseBlockIngestor
Nov 22 11:18:34.046 ERRO Unable to get a connection for block ingestor, err: all providers failed for chain 'arbitrum-one', component: EthereumFirehoseBlockIngestor

IPFS hash
No response
Subgraph name or link to explorer
No response
Some information to help us out

[X] Tick this box if this bug is caused by a regression found in the latest release.
[ ] Tick this box if this bug is specific to the hosted service.
[X] I have searched the issue tracker to make sure this issue is not a duplicate.

OS information
Linux

Pinax supports extended blocks for arbitrum-one only for nitro blocks.  For classic blocks, they are base blocks.
Pinax returns the type of block supported as "hybrid".

GRAPH_NODE_FIREHOSE_DISABLE_EXTENDED_BLOCKS_FOR_CHAINS="arbitrum-one"

thanks @matthewdarwin . this worked fine and now I see arbitrum-one blocks ingested

is there any update on this issue? I had to disable the extended blocks support for all these chains bellow
              value: "arbitrum-one,optimism,mainnet,starknet-mainnet,matic,sepolia,bsc,solana-devnet"


Range input colors

Adds branded colors for range input, see https://github.com/cfpb/cf-forms/pull/43 for details

:+1: the true reason no one merged this or #187 is the leading space on @gray-10;

@wpears Ack! Can't unsee!

This will probably need a follow-up, pending the resolution of this related comment on a cf-forms PR.


Custom domains for dev_setup/bin/vcap_dev_setup

The cookbooks support a custom domain, but the vcap_dev_setup wrapper script does not. This branch adds a -D flag to vcap_dev_setup to declare what your domain will be.
Includes an update to the dev_setup/README

pulled.  thanks


test(maintenance): add ESM output to e2e test

Description of your changes

This PR switches some of the integration tests to use the ESM builds of the Powertools for AWS Lambda utilities so that we can increase confidence in these builds.
To achieve this I made the following changes:

modified the TestNodejsFunction construct to use either CJS or ESM based on inputs
switched ~50% of the functions in the e2e to use ESM
added a new test case for the Lambda Layers test to include ESM (with corresponding refactor)*

While at it, I also enabled minification and some other small bundle optimizations for the functions in our e2e tests.

This is true, excluding Node.js 16 for which I maintained only the CJS tests for the Layer. This is due to this and I also added a sentence in the docs to call out this limitation for Node.js 16, Layer, and ESM.

Related issues, RFCs

Issue number: #2346
Checklist

[x] My changes meet the tenets criteria
[x] I have performed a self-review of my own code
[x] I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my change is effective and works
[x] The PR title follows the conventional commit semantics

Breaking change checklist
Is it a breaking change?: NO

[ ] I have documented the migration process
[ ] I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

This is a passing result for the e2e tests:
https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/8722852303


Some sites broken by preferences

FYI... @Roman-Nopantski you can delete this post after reading
Nothing new, but there are some sites identified
network.http.sendSecureXSiteReferrer = false > breaks login at aliexpress
dom.indexedDB.enabled = false > breaks Outlook Web Access (at least on Exchange 2013)
full-screen-api.enabled = false > breaks fullscreen video (youtube, etc...)
Cheers

Better safe than sorry.

I do, I find your work here very very good and I am using your user.js as a base, which doesn't mean that I agree with every settings... so I have some differences for sure. ;)
I am just trying to help you guys identifying some stuff out-of-the-box. Nothing more.

@Atavic, I don't mind your "Better safe than sorry" campaign but please don't flip off the few users who want to help out and contribute. @crssi is not asking for help or moaning that we broke his facebook, instead he traced down the problem with specific sites/services to a specific pref, which IMO is valuable information.
@crssi, please keep participating here, I appreciate your input and we can use every help we get. Thank you

sendSecureXSiteReferrer will be removed soon and we are looking into improving the referer prefs anyway, so I don't think we need to add this to the warning list. Agreed?
dom.indexedDB.enabled is in the warning list already and has a WARNING
full-screen-api.enabled - is pretty self-explanatory, no need for a warning IMO, but @Roman-Nopantski you have the last word. If we can agree that we don't need to do anything for this issue, let's close it.

Don't get me wrong, people reporting site breakage is a good thing - it will help us build our knowledge for troubleshooting etc. But....
The readme when finished will make it crystal clear that there will be site breakage, and the wiki will provide a troubleshooting guide (how to narrow down a pref as culprit). The readme will explain how to integrate this: read and edit it first, then implement in a new profile or portable and test it for a while etc (a wiki for setting up second profile or grabbing a portable). On top of that we have a troubleshooting section of numbers and warnings (built from 18 months feedback) which will stay in the js so users have a local reference. And lastly we (will) have yet more info/caveats in the section header for 1600 when it is revamped - just like we have warning in section 0400 section header. Not sure what else we can do.
In other words, I expect users to sort their own problems out re site breakage and not have several hundred issues made. We can't cover the top 1 million alexa sites! That said, I do expect people to report issues with major sites.
Agreed, we can close this

In other words, I expect users to sort their own problems out re site breakage and not have several hundred issues made. We can't cover the top 1 million alexa sites! That said, I do expect people to report issues with major sites.

I agree, I don't think someone comes with an issue with some porn sites, lol since most of 'em sucks, but still reporting major, common, famous web sites are welcome. Plus reporting any web site included how the user solved its issue would be nice... I like to read the Issues section, kind of learning curve.


Please set a license

Could you please add a license to you code? With no license indicated, it means that no one except you has the right to run/modify/use your code. Even downloading it could be questionable.

License set. Thank you.


storage: Refactor causes classic GAE to not compile

I updated this package and the new storage refactor is causing my classic App Engine app to not compile, due to Go 1.5 incompatibility.
goapp deploy --application=xxx --version=zzz
05:26 PM Application: xxx (was: None); module: yyy; version: zzz (was: None)
05:26 PM Host: appengine.google.com
05:26 PM
Starting update of app: xxx, module: yyy, version: zzz
05:26 PM Getting current resource limits.
05:26 PM Scanning files on local disk.
05:26 PM Cloning 240 application files.
05:26 PM Uploading 1 files and blobs.
05:26 PM Uploaded 1 files and blobs.
05:26 PM Compilation starting.
05:26 PM Compilation: 238 files left.
05:26 PM Error 422: --- begin server output ---
Compile failed:
2015/12/14 16:26:35 go-app-builder: build timing: 31×6g (4.469s total), 0×6l (0 total)
2015/12/14 16:26:35 go-app-builder: failed running 6g: exit status 1

golang.org/x/net/http2/transport.go:584: req.Cancel undefined (type *http.Request has no field or method Cancel)
golang.org/x/net/http2/transport.go:961: cs.req.Cancel undefined (type *http.Request has no field or method Cancel)
--- end server output ---
05:26 PM Rolling back the update.
Error 422: --- begin server output ---

@bradfitz @dsymonds @okdave
Did something change in the past ~ week? I ran a sample on App Engine just fine about a week ago.

Update golang.org/x/net/http2. The bug breaking Go 1.4 users was fixed ~90 minutes after it was introduced.

That fixed it. Thanks for the tip!

Sorry for the breakage. I forgot Request.Cancel was added so recently.


More infos added in Exception Message for analysis this error:

More infos added in Exception Message for analysis this error:
PHP Fatal error:  Uncaught exception 'InvalidArgumentException' with message 'Argument $base58 contains invalid characters.'

Great, let me know when you can create a new release, to I can put this version live and see the logs!
Thanks


TypeDesc ctr from string: accept "box2f", "box3f"

The official names we use are "box2" and "box3", but users of Imath
know these as box2f/box3f, so accept these as synonyms when
constructing a TypeDesc from a string.

@grdanny


rego-cpp inconsistently replaces malloc

I suspect this may be a Trieste problem inherited by rego-cpp.
The headers appear to substitute snmalloc's malloc and operator new.  This causes problems when system-provided shared libraries do not and borrow buffers.  For example, __cxa_demangle takes a malloc'd buffer and expects to be able to call realloc on it.  If the caller has included the rego-cpp headers then the malloc'd buffer does not come from the system malloc and so the realloc call corrupts the heap.

@davidchisnall I had a look, and Trieste seems to be including snmallocshim-static, which I thought would be correct?  Could you post me a repro, so I can investigate further?

https://github.com/CHERIoT-Platform/cheriot-audit
Linking on macOS, we call __cxa_demangle, which is provided by /usr/lib/libc++.1.dylib.  This gets its malloc symbol from /usr/lib/libSystem.B.dylib.
Running this test:
https://github.com/CHERIoT-Platform/cheriot-audit/blob/main/Tests/demangle_compartment_call.query
Crashes with a malloc error if this malloc is too small:
https://github.com/CHERIoT-Platform/cheriot-audit/blob/8192fd3857d93e20bbe6bffbe177a6c942c9e780/audit.cc#L132
I've added a hack to make it try to guess an adequate size.
In general, a library replacing malloc for an entire program is not a good idea.  It would be nice if Trieste had an option to use snmalloc, but didn't do it unconditionally, then we could turn it off.

(Note: for that specific case, I can pass nullptr to force the callee to allocate, but then I get back a malloc'd pointer and I need to free it with the system malloc.  I'm not sure what happens if I pass it to snmalloc's free)

(Note: for that specific case, I can pass nullptr to force the callee to allocate, but then I get back a malloc'd pointer and I need to free it with the system malloc. I'm not sure what happens if I pass it to snmalloc's free)

Another crash.

https://github.com/CHERIoT-Platform/cheriot-audit
Linking on macOS, we call __cxa_demangle, which is provided by /usr/lib/libc++.1.dylib. This gets its malloc symbol from /usr/lib/libSystem.B.dylib.
Running this test:
https://github.com/CHERIoT-Platform/cheriot-audit/blob/main/Tests/demangle_compartment_call.query
Crashes with a malloc error if this malloc is too small:
https://github.com/CHERIoT-Platform/cheriot-audit/blob/8192fd3857d93e20bbe6bffbe177a6c942c9e780/audit.cc#L132
I've added a hack to make it try to guess an adequate size.
In general, a library replacing malloc for an entire program is not a good idea. It would be nice if Trieste had an option to use snmalloc, but didn't do it unconditionally, then we could turn it off.

Probably best to have it off by default, and then we can turn it on where we know it works.  It is already off for Windows as that doesn't work.

I've updated to the latest version of Trieste, which has an explicit flag to disable snmalloc new override, which I believes resolves this issue.


HL-600 | Add TET GDPR API

Description :sparkles:
TODO
Issues :bug:
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #1631 (d7096b6) into develop (a603ad6) will increase coverage by 15.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #1631       +/-   ##
============================================
+ Coverage    65.88%   81.15%   +15.26%
============================================
  Files         1048       78      -970
  Lines        28936     2727    -26209
  Branches      2972        0     -2972
============================================
- Hits         19064     2213    -16851
+ Misses        9424      514     -8910
+ Partials       448        0      -448

Impacted Files
Coverage Δ

backend/shared/shared/ytj/ytj_client.py
27.58% <0.00%> (-65.52%)
:arrow_down:

backend/shared/shared/common/decorators.py
37.93% <0.00%> (-58.63%)
:arrow_down:

...nd/shared/shared/service_bus/service_bus_client.py
27.65% <0.00%> (-57.45%)
:arrow_down:

backend/shared/shared/yrtti/yrtti_client.py
39.39% <0.00%> (-51.52%)
:arrow_down:

backend/shared/shared/audit_log/viewsets.py
45.12% <0.00%> (-51.22%)
:arrow_down:

backend/shared/shared/common/lang_test_utils.py
60.00% <0.00%> (-40.00%)
:arrow_down:

backend/shared/shared/suomi_fi/utils.py
33.33% <0.00%> (-33.34%)
:arrow_down:

backend/shared/shared/models/mixins.py
66.66% <0.00%> (-33.34%)
:arrow_down:

backend/shared/shared/audit_log/audit_logging.py
76.59% <0.00%> (-23.41%)
:arrow_down:

backend/shared/shared/common/utils.py
78.04% <0.00%> (-21.96%)
:arrow_down:

... and 972 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


ensure exclusions win over inclusions for scanning

If any inclusion is "**anything" then DirectoryScanner will browse excluded folders. It completely defeats most of exclusions and typically let the plugin go through target and node_modules which can be very time consuming.
With this patch, my license check (only) went from 25s to 2.5s.

@rmannibucau shouldn't this be suggested as default implementation of DirectoryScanner in maven-shared-utils

@McFoggy I don't know, can clearly discuss it but I fear some plugins will use that as a feature (binary scanners out of my head which scan target more than src) so it will likely end up with a flag which is more or less the exact same impact for this plugin (+ it is way faster to include and release like that).
Will start the discussion on maven side in between but if it is possible to get this fix soon I would be very welcomed.

@mathieucarbou the PR from Romain should not change the behavior, ie the final result, unless DirectoryScanner itself is wrong or broken. It will "just" allow to exclude some files faster than before.
From DirectoryScanner javadoc

Only files/directories which match at least one pattern of the include pattern list or other file selector, and don't match any pattern of the exclude pattern list or fail to match against a required selector will be placed in the list of files/directories found.

@rmannibucau I was not saying that we should not integrate it here as a workaround of the bad performance behavior the standard DirectoryScanner.
Let's be pragmatic by opening an issue/PR at maven-shared-utils and integrate this PR as a performance workaround until the issue is resolved in the right place.

@mathieucarbou @McFoggy updated the PR, migrated to maven-shared-utils (plugin was using plexus) and added a flag to be able to implement this behavior, MSU scanner has an API for that but it is not the default (guess for compatibility too).
Side note: I'm not sure the meaning of the defaults of the plugin without this flag on though since it will visit the ignored folders but ignore the found files but while we can deactivate this very slow behavior I'm happy.

@McFoggy : how sure you are ? We are safe in your opinion to have that as a default behavior and safely remove the boolean flag ?
@rmannibucau : thank you for the PR update. Could you plese rebase with the latest changes ? There has been a big PR merged.

@mathieucarbou rebased (but it broke config no?).
BTW the change is safe cause today excluded files end up in getExcludedFiles and this is not used by the plugin so this collection is useless in this context. In other words, getExcludedFiles will no more be populated with my change but since it is not queried anyway it does not change anything functionally for the plugin.

@mathieucarbou rebased (but it broke config no?).
BTW the change is safe cause today excluded files end up in getExcludedFiles and this is not used by the plugin so this collection is useless in this context. In other words, getExcludedFiles will no more be populated with my change but since it is not queried anyway it does not change anything functionally for the plugin.

Ok i see. Understand more. I thought your changes could potentially change the outcome of the scanner. But it only makes it faster. I was confused.
So yes, let's make that the default behavior and remove this Boolean flag that I proposed to add since the current behavior (current outcome of the scanner) is preserved. This is just an optimization.

done

@rmannibucau : build is failing:
Failed tests:

  SelectionTest.test_exclusions_respect_with_fastScan:73->assertIncludedFilesInFakeProject:80 expected:<[included.txt, module/src/main/java/not-ignored.txt, module/sub/subsub/src/main/java/not-ignored.txt]> but was:<[included.txt]>

@mathieucarbou windows I assumed? pushed a commit about it but didn't test it

@mathieucarbou windows I assumed? pushed a commit about it but didn't test it

no, it's building on Ubuntu...

@mathieucarbou hmm, i can't reproduce either in intellij nor in CLI. Any possibility the temp folder matches the exclusion and is not /tmp as the default?

@mathieucarbou hmm, i can't reproduce either in intellij nor in CLI. Any possibility the temp folder matches the exclusion and is not /tmp as the default?

I ran into some issues one day about the tmp folder in docker... You could try by creating the tmp directories in the target folder, by passing the "target" folder as a root of the junit rule perhaps.

@mathieucarbou can you give a try setting this exclude array in the test please:
new String[] {"target" + File.separator + "**", "module/**/target" + File.separator + "**"}

?

@mathieucarbou can you give a try setting this exclude array in the test please:
new String[] {"target" + File.separator + "**", "module/**/target" + File.separator + "**"}

?

Would be far easier for you to continue handling your PR.
You can even directly edit your branch from GitHub website.

@mathieucarbou agree but since I can't reproduce it is mainly random guess tries. Any way to reproduce it, you mentionned docker, is the setup documented anywhere?

the travis build is using openjdk7
docker run --rm -it openjdk:7 /bin/bash
cd ~
mkdir dev && cd dev
wget -o http://apache.mirrors.ovh.net/ftp.apache.org/dist/maven/maven-3/3.6.3/binaries/apache-maven-3.6.3-bin.zip
unzip apache-maven-3.6.3-bin.zip
export PATH=$PWD/apache-maven-3.6.3/bin:$PATH
git clone https://github.com/rmannibucau/license-maven-plugin.git
cd license-maven-plugin
git checkout rmannibucau/enforce-exclusions
mvn test

@rmannibucau : reason I am asking you to handle the PR until it is complete is because on my side I do not have time to help now (2y old kid at home + newborn).  I can only review / merge / release with the time I have.
@McFoggy and @adamretter are on the MLP team and can also help you and review / merge once the problem is found, but they also have limited time.
This is the only last PR before I trigger a 4.0.rc1 release. It would be nice to have this improvement.  But if you think that solving this issue will take time, I can still trigger the 4.0.rc1 release without this PR and trigger an rc2 after 😄

Think I spotted the issue, will fix it now

Should be good now, perf improvement is not that impressive but it /2 and impl is correct now ;)
Thanks for the patience.

Should be good now, perf improvement is not that impressive but it /2 and impl is correct now ;)
Thanks for the patience.

 Let's get a release now :-)


Autocomplete and score animation

:tada: This PR is included in version 2.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


iOS webview running getNativeViews(focused: true) or enterTextbyIndex twice crashes

Steps to reproduce

follow setup guide
run test with enterTextbyIndex twice in a webview (auth0 login webview)

example test code:
        final views = await $.native.getNativeViews(Selector(
          focused: true,
        )); // fails here

        print(views.map((v) => v.className));

        await $.native.enterTextByIndex(
<EMAIL_ADDRESS>          index: 0,
        );

        await $.native.enterTextByIndex(
          'Test123456',
          index: 1,
        ); // fails here, if I call this enter text first then the other enterTextByIndex fails

Actual results
flutter: Patrol (native): getNativeViews() failed
flutter: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
flutter: The following ClientException was thrown running a test:
flutter: Connection closed before full header was received, uri=http://localhost:8081/getNativeViews

flutter: Patrol (native): enterTextByIndex() succeeded
flutter: Patrol (native): enterTextByIndex() started
flutter: Patrol (native): enterTextByIndex() failed
flutter: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
flutter: The following PatrolActionException was thrown running a test:
flutter: Patrol action failed: NativeAutomatorClientException: enterTextByIndex() failed with Invalid
flutter: response: 400 The operation couldnât be completed. (patrol.PatrolError error 0.)

Logs

Logs
Posted in Actual results

Patrol version
patrol: ^3.9.0
Patrol Doctor output

Patrol Doctor output
Patrol CLI version: 3.0.0
Flutter command: flutter
  Flutter 3.22.2 • channel stable
Android:
• Program adb found in /usr/local/bin/adb
• Env var $ANDROID_HOME set to /Users/user/Library/Android/sdk
iOS / macOS:
• Program xcodebuild found in /usr/bin/xcodebuild
• Program ideviceinstaller found in /usr/local/bin/ideviceinstaller

Flutter Doctor output

Flutter Doctor output
[✓] Flutter (Channel stable, 3.22.2, on macOS 14.5 23F79 darwin-x64, locale en-NO)
    • Flutter version 3.22.2 on channel stable at /Users/user/fvm/versions/3.22.2
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (5 weeks ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0-rc1)
    • Android SDK at /Users/user/Library/Android/sdk
    • Platform android-35, build-tools 35.0.0-rc1
    • ANDROID_HOME = /Users/user/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11609105)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11609105)

[✓] VS Code (version 1.91.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.92.0

[✓] Connected device (2 available)
    • iPhone 15 Pro (mobile) • uuid • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator)
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 126.0.6478.127

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Closing, we'll continue investigation in Discord since it probably is not a bug. Link to our DC server: https://discord.gg/ukBK5t4EZg. Link to our conversation: https://discord.com/channels/1167030497612922931/1261246311005683752


Array element type inference not working in array methods when array is union type

TypeScript Version:  4.1.0-dev.20200903

Search Terms:
Union array type element inference in methods
Code
type Unpack<T> = T extends ReadonlyArray<infer P> ? P : never;

const test: ['a', 'b'] | ['c', 'd'] = ['a', 'b'] as any;

test.forEach(el => el); //error
test.forEach((el: Unpack<typeof test>) => el);
const element = test[1];

Expected behavior:
Both forEach calls should infer col in the same way: el should be 'a' | 'b' | 'c' | 'd'
Actual behavior:
First call can't infer el type.
Playground Link:
https://www.typescriptlang.org/play?ts=4.1.0-dev.20200903#code/C4TwDgpgBAqgdmAhgYwNYB4AqA+KBeKTKCAD2AjgBMBnKAJQkUoHs4AbEAQQCdvER0ASzgAzCNygAFXAH4pUAFxQ4EAG7iA3ACgtyVtWBRyBpQG0A5InMAaKOYBG5gLpQAPlAvIbdys-wfLbwc-RFpEOBBtLWNgADoRZm4AURQACwAKCDZ8XCyASm0Y+MSU5AzMtiV4JDR0UEhmESMIA2w8nOI2At19QyyIAFsKQwIY0wBGJw0gA
Related Issues:

This looks like duplicate of https://github.com/microsoft/TypeScript/issues/36390 which in turn related to https://github.com/microsoft/TypeScript/issues/7294

I don't get This expression is not callable error, for me it's just el is inferred as any.

@IvanZatravkin A closer duplicate would be #34605.

Looks like it, thanks


[Business Approvals Kit - Feature]: Add new parameter "External Reference" in custom connector

Is your feature request related to a problem? Please describe.
Currently we cannot update the approval outcome to the source as we do not have any provision to store reference of the external source.
Describe the solution you'd like
This change will require the following updates:
1.Add a new optional parameter to the custom connector.
2.Add a new External Identifier column to the Business Approval Workflow table.
3. Update flow to store reference in above table.
Describe alternatives you've considered
No response
Additional context?
No response
AB#2178

Included in February 2024 Release https://github.com/microsoft/powercat-business-approvals-kit/releases/tag/BusinessApprovalKit-February2024


[SPARK-30719][SQL] do not log warning if AQE is intentionally skipped and add a config to force apply

What changes were proposed in this pull request?

Update InsertAdaptiveSparkPlan to not log warning if AQE is skipped intentionally.
This PR also add a config to not skip AQE.
Why are the changes needed?

It's not a warning at all if we intentionally skip AQE.
Does this PR introduce any user-facing change?

no
How was this patch tested?

run AdaptiveQueryExecSuite locally and verify that there is no warning logs.

cc @maryannxue @JkSelf

Test build #117833 has started for PR 27452 at commit fb89132.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22596/
Test PASSed.

Test build #117833 has finished for PR 27452 at commit fb89132.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117833/
Test PASSed.

Test build #117884 has started for PR 27452 at commit 841273e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22646/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22657/
Test PASSed.

Test build #117895 has started for PR 27452 at commit 215435d.

Test build #117884 has finished for PR 27452 at commit 841273e.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #117895 has finished for PR 27452 at commit 215435d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117895/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117884/
Test FAILed.

LGTM.

retest this please

Test build #117917 has started for PR 27452 at commit 215435d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22681/
Test PASSed.

Test build #117917 has finished for PR 27452 at commit 215435d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117917/
Test FAILed.

retest this please

Test build #117931 has started for PR 27452 at commit 215435d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22694/
Test PASSed.

Test build #117931 has finished for PR 27452 at commit 215435d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117931/
Test PASSed.

Test build #117975 has started for PR 27452 at commit a796d19.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22739/
Test PASSed.

Test build #117975 has finished for PR 27452 at commit a796d19.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117975/
Test FAILed.

retest this please

Test build #117982 has started for PR 27452 at commit a796d19.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22747/
Test PASSed.

Test build #117982 has finished for PR 27452 at commit a796d19.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117982/
Test PASSed.

Thanks! Merged to master/3.0

@gatorsmile Add unit test in #27515.


Create error handling

Please, implement an error handling routine and error displaying functionality.
It should display errors using our error screen which is based on common info-box (#58).

This need to be adjusted still, leaving it open


Running sourcegen -w doesn't re-trigger on changes in additional source directories

I have a Smithy project, for which I have written a codegen script. I have then added this script to the project where the Smithy sources reside, and running the codegen works fine.
Now, if I do bleep sourcegen -w shared, where shared is the project with the Smithy sources, it doesn't retrigger the codegen script when I change any of the smithy files, even though the the smithy folder is added as a source root in my bleep.yaml.
As show:
  shared:
    dependencies:
      - com.disneystreaming.smithy4s::smithy4s-core:0.18.22
      - com.disneystreaming.alloy:alloy-core:0.3.8
    extends: template-common
    sources: ./src/smithy
    sourcegen:
      main: Smithy4sCodegen
      project: scripts

Not sure if I'm doing something wrong or missing a piece of configuration. Any help is appreciated :D

If you could try two things:

move the sources: ./src/smithy to scripts project. changing thing in the shared project shouldn't affect the sourcegen in another project
another options is that the sourcegen structure supports a sourceGlobs field, which are for other files read by the sourcegen script outside of the build. I think this is relative to the project folder for shared

It would be great if you can experiment a bit with two options and report back, so we can update the docs

I tried both approaches.

This works well, and the sourceGen is fast enough so no complains here.
This feels like it should work. The description of sourceGlobs says that it is relative to the project of the script. So for me, I should add a sourceGlobs: ../shared/src/smithy to it. That however, doesn't seem to have any effect. Neither does sourceGlobs: ./src/smithy, assuming it's relative to the shared project and not the scripts project.


Multipart uploading

Allowing multipart ie chunking files for faster uploading.

It is helpful to be able set independent upload and download speed limits to reduce disruption from link congestion of large transfers.
regards CB

Thanks for the feature request.
By the way were you able to check if your issue https://github.com/rakyll/drive/issues/29 got resolved?

I have been watching but it was't clear when the required merge actually
occurred so I have been waiting for the current flurry of activity to
settle to something like a stable version. I think #48 might be the same
problem.
On Sun, Jan 4, 2015 at 1:59 PM, Emmanuel Odeke<EMAIL_ADDRESS>wrote:

Thanks for the feature request.
By the way were you able to check if your issue rakyll#29
https://github.com/rakyll/drive/issues/29 got resolved?
—
Reply to this email directly or view it on GitHub
https://github.com/odeke-em/drive/issues/25#issuecomment-68620124.

Oh I should clarified in asking whether you can check if my current fork solves your problem ;)

I have repeated 2 small tests and both passed correctly, I will try a larger test tomorrow. Is it worth a 'drive version' command or a version number printed in the help command so users can clarify exactly which build is in use.
regards CB

Great idea about versioning. Coming in the next release.


Alt Text for Images

Add descriptive alt attributes to your images for better accessibility. For example, in the project section and in the footer.

@mt638 if this issue is not solved can you assign it to me?


Doesn't always play

I'm using about 30 videos per app and every now and then on Android the video doesn't pkay, this is two separate issues

Video doesn't play, meaning video is Frozen on first frame and won't move.

Video just shows a white screen (this issue may not be related to this library and shouldn't be the focus of this post)

After a lot of research, in the senarios is doesn't play.
This library doesnt seem to seek to a negative number (when the video doesn't play it's always because the seek is a negative number)
The other issue is that after this occors once you must click play and it will play but throughout any next concurrent videos it won't auto play again  It doesn't auto play after this

We can include a max(0, seekTime) here
https://github.com/react-native-community/react-native-video/blob/master/Video.js#L55

After 2 whole days on this bug, found this. https://github.com/react-native-community/react-native-video/issues/1151
Please add this to the library, this library is getting a scary amount of Issues for such a well-used library.


Remove docs

Just link to docs.rs
Resolves #9

FYI, it looks like you already pushed a new version with this to crates.io (super-thanks for that!) but forget to push the corresponding tag to github.

Just did. Thanks for catching that.


Param metadata

Param metadata cleanup as discussed here. https://github.com/mavlink/qgroundcontrol/issues/3012#issuecomment-219168089

Thanks!


Preventing panning when dragging certain descendent elements.

Hi, I've got a drag and drop field inside of my <MapInteractionCSS /> component. Is it possible to prevent panning when mousedowning on draggable elements? stopPropagation on mouseDown doesn't seem to be doing the trick. The docs hint that this is possible but I'm not sure what I'm missing. Thanks.

did u find a solution it seems to be a popular question with no answer


Unrecognized syntax error for href='#...'

See the fiddle, whenever clicking on the items starting with '#' jquery Sizzle fires the error:
Sizzle.error = function( msg ) {
    throw new Error( "Syntax error, unrecognized expression: " + msg );
};

Although the execution is not affected and the page loads as expected in all cases the error is really annoying. Reproducible in any browser.

Will be fixed in the next bugfix version.

Thanks, are there any workarounds meanwhile?

You van wrap the code in a try/catch.

Not sure how can do that, say for given example

You can ignore the error. Just because Sizzle throws an error, doesn't stop it from working.

Should be fixed in the latest version.

Thanks! 5.3.1 resolves the issue


ES6 Module Release

Hi!
I'm looking for a little bit of info on how pixi filters can be integrated into an app that doesn't use the global PIXI var, but also isn't an npm workflow.
Basically, I'm using pixi 6.2.2 and a self-hosted pixi.min.mjs file. My first thought was to try ES6 imports for the provided release file (so, import {GlowFilter} from './libs/pixi-filters.js'), but while it seems you can do that in Node JS, it doesn't seem to be possible with the browser-based pixi ESM.
So I came up with this dirty-feeling hack to get filters applied to objects:
import * as PIXI from './libs/pixi.min.mjs';
window.PIXI = PIXI; //workaround for filters
const getFilter = function(filterName){
    return window.PIXI.filters[filterName];
}
export{getFilter}

Since filters are only applied after the pixi-filers.js file is loaded, I can call getFilter(name) and have it return the proper filter.
While this works, I can't help but feel I'm missing something here. I'd prefer to not set up a whole browserify workflow in an app that otherwise doesn't need it.
Am I missing something in the docs, or is this what you'd have to do to get things working with filters without a browserify/webpack/etc workflow?

Same here...

I'll work on adding browser modules 👍

I know it's been a while, but I'll comment on this now. Time seems to get away from me sometimes, so I apologize!
I know it's not an amazing solution, but could we go with something like a dynamic import of Pixi? Instead of a hard-coded solution, passing in either the Pixi object/namespace or string of where to look for it may be a little more generic. That does require a little more setup on the part of whoever's using it, but it also means that if you self-host Pixi, you can use that self-hosted version.


AndroidThings Hardware Acceleration (Raspberry Pi)

Steps to Reproduce

flutter run --release to a Raspberry Pi running AndroidThings
Notice how the app does not refresh
flutter run --profile --enable-software-rendering
Notice how the app now refreshes, but only @ ~5fps.

I know we're a bit off from supporting other platforms, but is there a low hanging fruit here to get hardware acceleration working on the Raspberry Pi?
Alternatively, is it possible to build an apk with software-rendering only?

Similar to #12012?

@pauldemarco I hit exactly the same issue 2 months ago and got no answer from the Team. Its basically the same issue as yours so i wont bother to reference it here.
Did you ever move further with this ?
I also had issues with the Google Cole for Android things. It would not accept the Flutter apps compiled for it.

Has there been any progress on this? I just installed android things on a raspberry pi 3b and I'm getting around 3.4 fps.

Considering AndroidThings has been shutdown, I am not sure if this issue is valid anymore. @pauldemarco Is there a way to check at your end to see if you still get reported behavior ?


circleci improvements: dont match master cache, speed up linux builds

Matching master cache as a default was causing some builds to pass in a branch but fail once they got to master.
Also use a fix from david to speed up linux builds (mainly cache restore)
cache expires after 15 days, so when debugging strange failures, keep that in mind, any dependancies that were updated in 15 days should be suspects.

 I'm also noticing that this change removes several levels of incremental fallback -- it busts the cache entirely if deps change, which shouldn't be necessary.
The idea of the caching scheme was that you'd wind up on the "closest thing" to an up-to-date cache, which should be OK because the install/setup code is idempotent. If that's not what's going on, I probably didn't understand what was going on (and I want to!)

also I thought I'd set ramdisk on everything already, my bad 🤦

How did the master cache cause a build to fail? I'm also noticing that this change removes several levels of incremental fallback -- it busts the cache entirely if deps change, which shouldn't be necessary.

busting cache shouldn't be necessary but it was in a case earlier this week, because pip is not a real package manager (or at least before the very latest version that is supposed to come out, or has come out as of today?)
a case that happened was:
master has package Y version X in cache
branch specified requirements_dev of X+1 for package Y,  this matched the fallback on master
branch built fine even though X+1 was not available, pip didnt care to enforce what was requested (see pip issues in dependency management)
merged branch into master
master failed because its fallback was different than the fallback that the branch used (different set of unversioned packages were already in this cache)
Basically, i dont want a branch to succeed when it will fail when it gets to master.
I think the root cause of the problems seen were:

pip sucks at enforcing dependencies (will be fixed or is fixed as of today's pip)
having different incremental fallbacks causes strange behavior as there could be different cache expiry times

So if we do add incremental fallback, this would be safer:
              - v0.5-toxenv-{{ .Environment.CIRCLE_BRANCH }}-{{ .Environment.CIRCLE_JOB }}-{{ checksum "tox.ini" }}-{{ checksum "setup.py" }}-{{ checksum "requirements.txt" }}-{{ checksum "requirements_dev.txt" }}
              - v0.5-toxenv-{{ .Environment.CIRCLE_BRANCH }}-{{ .Environment.CIRCLE_JOB }}-{{ checksum "tox.ini" }}
              - v0.5-toxenv-{{ .Environment.CIRCLE_BRANCH }}-{{ .Environment.CIRCLE_JOB }}
              - v0.5-toxenv-master-{{ .Environment.CIRCLE_JOB }}-{{ checksum "tox.ini" }}-{{ checksum "setup.py" }}-{{ checksum "requirements.txt" }}-{{ checksum "requirements_dev.txt" }}
              - v0.5-toxenv-master-{{ .Environment.CIRCLE_JOB }}-{{ checksum "tox.ini" }}
              - v0.5-toxenv-master-{{ .Environment.CIRCLE_JOB }}

This way it is more likely that a branch and master would have the same base cache.   Would you prefer that?

Yeah, the cache strategy you laid out above is what I'd hoped to achieve.

Yeah, the cache strategy you laid out above is what I'd hoped to achieve.

Turns out, pip release that fixes this is in pre-release, but im fine living on the edge for a bit:
https://news.ycombinator.com/item?id=25145396
https://pypi.org/project/pip/#history

Changes made @davidwallacejackson , please re-review


Implement --no-fail-fast flag for cargo test.

This flag can be used to force cargo to run all tests, even if previous
tests failed. See #1904

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Some notes about this:

In this implementation, the --no-fail fast option does not work for doctests. A quick fix would be to return Ok(Ok(compile)) from build_and_run, even if some tests fail and the --no-fail-fast flag is set. This does not feel very clean though.

--no-fail-fast can easily be extended to work for cargo bench, is this desired?

Thanks! Could you also add a test for this?

I think it may also be useful to tweak the logic a bit to ensure that doctests run even on normal test failure, but you can feel free to tweak signatures/reorganize here and there. I think it's also fine to not extend to cargo bench for now, those aren't tests that normally fail.

I'm not really sure why the test fails sometimes.

Ah currently panicking tests on i686 MSVC cause an abort of the process, you can just not run the test if ::can_panic returns false. While you're at it actually, could you make can_panic return true for x86_64-pc-windows-msvc as well?

Oh and feel free to ping this PR whenever it's updated, unfortunately github doesn't send out notifications for a force push :(

I will try to refactor a bit to implement your suggestions. Will stop force pushing now and only squash before merge ;)

Oh feel free to force push, I guess I should say github doesn't send out notifications for any pushes in general, so it's not necessarily contained to force pushes

So this new commit adds a new Error CargoTestError (I'm not good with naming things).
I am not really sure about its design. We can create a new CargoTestError from a Vec<ProcessError>, but this will only join the descriptions for now, and take the exit code of errors[0] as its own. I'm not really sure what to do with the cause field.
Furthermore I refactored cargo_test.rs a bit to avoid code duplication, it should all be fine since the tests still pass (at least on my machine)

Thanks, looking good! Could you check the output and return code (just manually is fine) of cargo test with one failing test and with two failing tests? So long as it doesn't lose too much information over today I think it's fine.

I just pushed the new changes.
Exit statuses look fine to me:

1 failing test: 101
2 failing tests: 101
5 failing tests: 101
0 failing tests: 0

@bors: r+ 4a30bcd01ecda73b3475f645ad49338b27c3e378
Thanks!

:hourglass: Testing commit 4a30bcd with merge 833b947...

:sunny: Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64


build: Initialize typetest scripts on lts branch

Upgraded the lts build-tools to the latest version.
Updated the scripts to use flub instead of fluid-type-validator.
Updated policy-check scripts to use flub as well.
Applied policy-check fixes (npm run policy-check:fix).
Updated some CI pipeline configs to accomodate new build-tools.
Ran npm run typetests:prepare -- -b lts to prepare the package.json for typetests.
Ran npm i to update lockfiles.

@sonalivdeshpande Do you know if there were changes to the bundle-size-tools that need to be made in order to use the new build-tools? The error above from danger does not make sense to me, and I'm not sure where to start investigating. Any ideas?

I think the branch name is passed as undefined. We would have to set the env variable: https://github.com/microsoft/FluidFramework/blob/main/tools/pipelines/templates/build-npm-package.yml#L396

Also, the bundle-size on lts is still under tools folder

Thanks for the review, @alexvy86!


Could you remove shadow properties or set false for all the ionic core components?

Could you remove shadow properties or set false for all the ionic core components

+1

Thanks for the issue. Certain Ionic components were built with the Shadow DOM in mind, so disabling the Shadow DOM would break the current styling and interfere with component functionality.
We moved to the Shadow DOM for certain components because of the performance and encapsulation  improvements it brings. The Shadow DOM allows us to do things such as dynamically theme your app at runtime without having multiple CSS bundles. Having multiple bundles slowed down build times, startup times, etc. As of now, we do not currently have plans to disable the Shadow DOM on these components. Thanks!


Add a Zig implementation

This is a Zig implementation of hmac-bcrypt.
Zig's bcrypt API intentionally doesn't allow salts to be application-defined when generating crypt()-like strings, so this complicates things a little bit (due to the post-hashing).

ping?

@epixoip ?


Can't see remote node properties if it's a tool script

Godot version:

Godot v3.1
OS/device including version:

Windows 10
Issue description:

I tried checking the node properties on the remote tab in the scene tree when running the scene but since the script of the node is a tool script it returns this error:
Script inherits from native type 'Control', so it can't be instanced in object of type: 'ScriptEditorDebuggerInspectedObject'
Steps to reproduce:

Create a scene
Create a node
Make a script, attach the script to the node and then make that script a tool script
Run the scene normally
Check the node in the remote tab
Engine returns above error

Duplicate of https://github.com/godotengine/godot/issues/29506

Closing as duplicate.


Issues finding XLinkPublicDefines.h

Hi, I am trying to integrate compiled dynamic libraries into a project in Xcode based on openframeworks. But I run into a wall, as the compiler cant find the XLinkPublicDefines.h, included in the XLinkConnection.h file (#include <XLink/XLinkPublicDefines.h>
) Can you may help me how to procede? What details of information do you need from me, in order to help me?

Hi @jonasfehr.
If you aren't using CMake to integrate the library (preferred) - then you'll have to add the necessary dependencies (include paths) as well.
These are:

include/depthai/
include/depthai-shared
include/depthai-shared/3rdparty
include/depthai-bootloader-shared
lib/cmake/depthai/dependencies/include

Above paths are relative to installation directory (by default [build_dir]/install)


[SIG-scale] Profile KubeVirt control plane under high load

/kind enhancement
Stress the KubeVirt control plane and profile the virt-api, virt-handler, virt-controller, and virt-launcher code to locate any scale or performance bottlenecks.  Here are the steps to run for each test:

Start profiling a component https://github.com/kubevirt/kubevirt/pull/6211
Generate load https://github.com/kubevirt/kubevirt/pull/6191
Remove load
Analyze

Stress tests

[ ] VMIs

[ ] 300
[ ] 500
[ ] 1000

[ ] nodes

[ ] 10
[ ] 50
[ ] 100
[ ] 200
[ ] infinity*

/assign @knopt

^

/assign @knopt

/remove-lifecycle stale


About distribution of angles and dihedral angels

Hi, wonderful work!
I wonder if the mols generated follow the same angle distribution and dihedral angel distribution with real mols.

Yes, Pocket2Mol can generate molecules with similar distributions of bond angle and dihedral angle with the real molecules.


How to get duration in flv.js

if (flvjs.isSupported()) {
    let videoElement = this.$refs.video

    flvPlayer = flvjs.createPlayer({
          type: 'flv',
          url: '/flv'
    })

    flvPlayer.attachMediaElement(videoElement)

    flvPlayer.load()

    console.log(flvPlayer.duration)

}
but the result is NaN

I have same question, Would you give me some suggestions, please?