Copy command is broken

Remove the $ in the commands provided since clicking the copy button copies the prompt also and cannot be pasted directly to the terminal.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e2197cba-30ac-1749-e25a-6f39c9ee9d20
Version Independent ID: bcd14f13-ab59-8e69-5c83-42fee6e51f87
Content: Deploy Microsoft Defender ATP for Linux manually - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/linux-install-manually.md
Product: w10
Technology: windows
GitHub Login: @Dansimp
Microsoft Alias: dansimp

Hello @laughingman42. Thank you so much for letting us know about this. It's fixed, and the updates will render live soon.


Add triage workflow.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?
[x] Have you successfully run brew man locally and committed any changes?

Partially implements 2. and 3. of https://github.com/Homebrew/brew/issues/9224.

Review period will end on 2020-11-24 at 02:18:40 UTC.


Fix for #251

See discussion in https://github.com/gdsfactory/gplugins/pull/253

Hi Lucas,
for me the spectrum does not look the same

Strange, I've just removed all cached results, re-run the notebook, and got

got it working,

I can push here so i'll open a new PR
thank you Lucas!


Feature/mfc

This change is

Reviewed 15 of 67 files at r3, 12 of 26 files at r4, 3 of 4 files at r5, 7 of 7 files at r6.
Review status: all files reviewed at latest revision, 36 unresolved discussions.

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 15 at r6 (raw file):

class MFCCompletePaymentViewController: ByuTableDataViewController {
    //MARK: Outlets
    @IBOutlet weak var tableView: UITableView!

private for all of these

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 25 at r6 (raw file):

    //MARK: Private Properties
    var subtotal: Double {

private for all of these

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 64 at r6 (raw file):

                cell.textLabel?.numberOfLines = 0
                cell.textLabel?.text = tableData?.row(forIndexPath: indexPath).text
//                cell.textLabel?.attributedText = formattedLegaleseText()

Uncomment when finished

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 76 at r6 (raw file):

        spinner.startAnimating()
        finishButton.isEnabled = false
        let alert = UIAlertController(title: "Confirm Payment", message: "I agree to the terms and conditions", preferredStyle: .alert)

Fill in the actual agreement text

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 115 at r6 (raw file):

                    super.displayAlert(error: err)
                } else {
                    self.displayAlert(title: "Payment Confirmation", message: "Your transaction has been successfully processed. A copy of your receipt has been sent to your email address.") { (_) in

super.

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 137 at r6 (raw file):

//        ]

        //TODO: Make this work like parking's legalese text

Do it

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentDetailViewController.swift, line 11 at r6 (raw file):

import UIKit

private let CELL_ID = "cell"

Isn't this default?

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentDetailViewController.swift, line 21 at r6 (raw file):

    //MARK: Outlets

    @IBOutlet weak var tableView: UITableView!

private

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentHistoryViewController.swift, line 18 at r6 (raw file):

    //MARK: Outlets

    @IBOutlet weak var tableView: UITableView!

private

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentHistoryViewController.swift, line 51 at r6 (raw file):

            let selectedPayment: MFCPayment = tableData?.object(forIndexPath: indexPath) {

            vc.title = DESTINATION_VC_TITLE

Can't we just do this in the storyboard? Also, I don't like that title... Pick a better one :)

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentHistoryViewController.swift, line 52 at r6 (raw file):

            vc.title = DESTINATION_VC_TITLE
            if let paidCharges = selectedPayment.paidCharges {

Add this to the big if let above

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentHistoryViewController.swift, line 74 at r6 (raw file):

    override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
        performSegue(withIdentifier: "showPaymentDetail", sender: nil)
        tableView.deselectRow(at: indexPath, animated: true)

Can't we do this in the viewDidAppear?

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 17 at r6 (raw file):

    //MARK: Outlets
    @IBOutlet private weak var tableView: UITableView!
    @IBOutlet weak var spinner: UIActivityIndicatorView!

private

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 20 at r6 (raw file):

    //MARK: Public properties
    var charges: [MFCCharge]?

Can't we make this non-optional? In fact, we can use a "!" here

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 23 at r6 (raw file):

    //MARK: Private properties
    private var accounts: [String: [MFCPaymentAccount]]?

Non-optional?

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 54 at r6 (raw file):

    override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
        if let cellId = tableData?.cellId(forIndexPath: indexPath),

I've noticed these two lines happen a lot... Could we add a dequeueCell function on the TableData object?

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 95 at r6 (raw file):

                    }
                }
                self.tableData = TableData(sections: [Section(title: "E-Checks", cellId: ACCOUNT_CELL_ID, rows: eCheckRows), Section(title: "Credit Cards", cellId: ACCOUNT_CELL_ID, rows: creditCardRows)])

If they're all the same CELL_ID, can't we use the default?

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 106 at r6 (raw file):

    private func accountFor(indexPath: IndexPath) -> MFCPaymentAccount? {
        guard let row = tableData?.row(forIndexPath: indexPath) else { return nil }

Can we use optional chaining to do this?

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 11 at r6 (raw file):

import UIKit

private let checkedImage = UIImage(named: "checkmark")

ALL CAPS for these two

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 13 at r6 (raw file):

private let checkedImage = UIImage(named: "checkmark")
private let notCheckedImage = UIImage(named: "blank_checkmark")
private let CELL_ID = "cell"

inline if we only use once

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 19 at r6 (raw file):

    //MARK: Outlets
    @IBOutlet private weak var tableView: UITableView!
    @IBOutlet weak var totalView: UIView!

Make all of these private

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 27 at r6 (raw file):

    private var selectedIndexPaths = [IndexPath]()

    private var isEnabled: (Bool, CGFloat) {

Comment above this one

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 50 at r6 (raw file):

        super.viewDidAppear(animated)

        loadCharges()

Can we move this into the viewWillAppear? Is there a specific reason why we wait until the view appears to start loading?

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 67 at r6 (raw file):

    override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
        if let rowData = tableData?.row(forIndexPath: indexPath),
            let cellId = tableData?.cellId(forIndexPath: indexPath),

What is this line doing? Isn't it just always "cell"?

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 76 at r6 (raw file):

            imageView.frame = CGRect(x: 0, y: 0, width: 20, height: 20)
            cell.accessoryView = imageView
            cell.selectionStyle = .none

Can we set this in the storyboard?

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 90 at r6 (raw file):

        }

        (checkout.isUserInteractionEnabled, checkout.alpha) = isEnabled

Comment here

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 101 at r6 (raw file):

        tableView.hideEmptyCells()

        totalView.layer.borderWidth = 0.5

What are these doing? Could we do this in the storyboard?

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 109 at r6 (raw file):

            self.spinner.stopAnimating()
            if let charges = charges {
                self.tableData = TableData(rows: charges.map { return Row(cellId: CELL_ID, object: $0) })

Doesn't it default to "cell" already if we don't pass it in?

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 122 at r6 (raw file):

        if let rows = tableData?.rows(inSection: 0) {
            for indexPath in selectedIndexPaths {

use .reduce (higher order function). See me for help. Or see this site: https://medium.com/@mimicatcodes/simple-higher-order-functions-in-swift-3-0-map-filter-reduce-and-flatmap-984fa00b2532

byuSuite/Apps/MyFinancialCenter/model/MFCCharge.swift, line 21 at r6 (raw file):

        desc = dict["description"] as? String
        if let tmp = dict["due_date"] as? String {
            dueDate = dateFormat.date(from: tmp)

We could make an extension for this... Might be worth it because we do this a lot...

byuSuite/Apps/MyFinancialCenter/model/MFCCharge.swift, line 30 at r6 (raw file):

            let dueDateString = dateFormat.string(from: tempDate)
            return [
                "amount": amount,

Because we use each of these keys twice, let's extract this into variables

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 11 at r6 (raw file):

class MFCClient: ByuClient2 {
//    private static let BASE_URL = "https://api.byu.edu/domains/mfcmobile/v1"
    private static let BASE_URL = "https://1qfwwzh773.execute-api.us-west-2.amazonaws.com/PROD"

Change to WSO2 url. Wait... How is this working not through WSO2? The lambda wouldn't have a JWT... Also, move this out of the class

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 14 at r6 (raw file):

    static func getUnpaidCharges(callback: @escaping([MFCCharge]?, ByuError?) -> Void) {
        let request = ByuRequest2(url: super.url(base: BASE_URL, pathParams: ["unpaid_charges"]), authMethod: .NO_AUTH)

extract a "createRequest" function that will create the ByuRequest2 object for you. This way we don't duplicate a bunch of code, and we can switch to sandbox more easily

byuSuite/Apps/MyFinancialCenter/model/MFCPaymentResponse.swift, line 9 at r6 (raw file):

//

import UIKit

Remove UIKit from all classes that don't need it

byuSuite/Apps/MyFinancialCenter/view/MFCPaymentAccountTableViewCell.swift, line 13 at r6 (raw file):

class MFCPaymentAccountTableViewCell: UITableViewCell {
    //MARK: Outlets
    @IBOutlet weak var accountTypeImage: UIImageView!

private for all of these

byuSuite/Apps/MyFinancialCenter/view/MFCTransactionTableViewCell.swift, line 19 at r6 (raw file):

    //MARK: Properties
    var charge: MFCCharge? {

Possibly make MFCCharge and MFCPayment extend MFCTransaction? Talk to me about this one

Comments from Reviewable

Review status: all files reviewed at latest revision, 37 unresolved discussions.

byuSuite/Apps/MyFinancialCenter/view/MFCTransactionTableViewCell.swift, line 23 at r6 (raw file):

            descriptionLabel.text = charge?.desc
            if let date = charge?.dueDate {
                dateLabel.text = "Due: \(MFCUtils.formatDate(date: date))"

If the due date is <= today, make it red also

Comments from Reviewable

Review status: all files reviewed at latest revision, 37 unresolved discussions.

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 122 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
use .reduce (higher order function). See me for help. Or see this site: https://medium.com/@mimicatcodes/simple-higher-order-functions-in-swift-3-0-map-filter-reduce-and-flatmap-984fa00b2532

let total = selectedIndexPaths.reduce(0.0, { (total, indexPath) -> Double in
    let charge = tableData?.rows(inSection: 0)[indexPath.row].object as? MFCCharge
    return total + (charge?.amount ?? 0)
})

Comments from Reviewable

Reviewed 7 of 7 files at r7.
Review status: all files reviewed at latest revision, 35 unresolved discussions.

Comments from Reviewable

Reviewed 6 of 6 files at r8.
Review status: all files reviewed at latest revision, 28 unresolved discussions.

Comments from Reviewable

Reviewed 1 of 1 files at r9.
Review status: all files reviewed at latest revision, 27 unresolved discussions.

Comments from Reviewable

Reviewed 6 of 6 files at r10.
Review status: all files reviewed at latest revision, 16 unresolved discussions.

Comments from Reviewable

Reviewed 4 of 4 files at r11.
Review status: all files reviewed at latest revision, 15 unresolved discussions.

Comments from Reviewable

Reviewed 4 of 4 files at r12.
Review status: all files reviewed at latest revision, 13 unresolved discussions.

Comments from Reviewable

Reviewed 2 of 2 files at r13.
Review status: all files reviewed at latest revision, 13 unresolved discussions.

Comments from Reviewable

Reviewed 1 of 1 files at r15.
Review status: all files reviewed at latest revision, 13 unresolved discussions.

Comments from Reviewable

Reviewed 3 of 3 files at r17.
Review status: all files reviewed at latest revision, 20 unresolved discussions.

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 87 at r17 (raw file):

    private func startPayment() {
        if let paymentCharges = charges {
            MFCClient.startPayment(charges: paymentCharges, payWithCreditCard: self.selectedAccount.isCreditCard) { (response, error) in

rename to "usingCreditCard"

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 88 at r17 (raw file):

                    }
                }
                self.tableData = TableData(sections: [Section(title: "E-Checks", cellId: ACCOUNT_CELL_ID, rows: eCheckRows), Section(title: "Credit Cards", cellId: ACCOUNT_CELL_ID, rows: creditCardRows)])

We should only add a section if the section has rows

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 50 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Can we move this into the viewWillAppear? Is there a specific reason why we wait until the view appears to start loading?

Maybe we should do this with a delegate pattern... Only reloading when a payment was actually completed

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 64 at r17 (raw file):

    //MARK: UITableViewDatasoure/Delegate callbacks

    override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {

I don't know where, but we need to show an emptyTextLabel if there are no charges. Also, do this in all other vcs in this feature

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 98 at r17 (raw file):

    //MARK: Private functions

    private func loadCharges() {

We need to start the spinner on the first line here (so that when we reload, we get a spinner)

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 11 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Change to WSO2 url. Wait... How is this working not through WSO2? The lambda wouldn't have a JWT... Also, move this out of the class

Just move out of the class now

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 39 at r17 (raw file):

    static func startPayment(charges: [MFCCharge], payWithCreditCard: Bool, callback: @escaping(MFCPaymentResponse?, ByuError?) -> Void) {
        //TODO: Change to underscore casing

Do it (once Jamie's stuff is changed)

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 78 at r17 (raw file):

    }

    static func getRequest(url: URL, body: Data? = nil) -> ByuRequest2 {

Rename "createRequest)

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 78 at r17 (raw file):

    }

    static func getRequest(url: URL, body: Data? = nil) -> ByuRequest2 {

Add pathToReadableError

Comments from Reviewable

Reviewed 1 of 1 files at r18.
Review status: all files reviewed at latest revision, 20 unresolved discussions.

Comments from Reviewable

Reviewed 1 of 1 files at r19.
Review status: all files reviewed at latest revision, 20 unresolved discussions.

Comments from Reviewable

Review status: all files reviewed at latest revision, 38 unresolved discussions.

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 15 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
private for all of these

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 25 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
private for all of these

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 76 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Fill in the actual agreement text

Is the actual agreement text being passed back by a service?

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 115 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
super.

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 87 at r17 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
rename to "usingCreditCard"

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentDetailViewController.swift, line 11 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Isn't this default?

Yes but we need it in order to register the nib.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentDetailViewController.swift, line 21 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
private

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentHistoryViewController.swift, line 18 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
private

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentHistoryViewController.swift, line 51 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Can't we just do this in the storyboard? Also, I don't like that title... Pick a better one :)

Done?

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentHistoryViewController.swift, line 52 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Add this to the big if let above

Done?

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentHistoryViewController.swift, line 74 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Can't we do this in the viewDidAppear?

Done?

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 17 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
private

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 20 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Can't we make this non-optional? In fact, we can use a "!" here

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 95 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
If they're all the same CELL_ID, can't we use the default?

We could use the default but we still need to save it here to use for registering the nib.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 106 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Can we use optional chaining to do this?

Done?

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 88 at r17 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
We should only add a section if the section has rows

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 11 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
ALL CAPS for these two

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 19 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Make all of these private

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 27 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Comment above this one

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 50 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Maybe we should do this with a delegate pattern... Only reloading when a payment was actually completed

Done. I used notificationCenter.

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 67 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
What is this line doing? Isn't it just always "cell"?

Yes but I don't want to assume that since theoretically that could be changed in the future. I couldn't think of another way to get the cellId which I needed for cell.  It complained when I tried doing it out of the if lets

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 90 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Comment here

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 101 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
What are these doing? Could we do this in the storyboard?

Done...?

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 109 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Doesn't it default to "cell" already if we don't pass it in?

Yes but we still need the CELL_ID to register the nib. So I figured I'd set a cellId for the row incase anybody in the future changes the cellId on this vc but forgets to add it to tableData.

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 64 at r17 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
I don't know where, but we need to show an emptyTextLabel if there are no charges. Also, do this in all other vcs in this feature

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 98 at r17 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
We need to start the spinner on the first line here (so that when we reload, we get a spinner)

Done.

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 11 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Just move out of the class now

What do you mean by move out of the class?

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 14 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
extract a "createRequest" function that will create the ByuRequest2 object for you. This way we don't duplicate a bunch of code, and we can switch to sandbox more easily

Done.

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 78 at r17 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Rename "createRequest)

Done.

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 78 at r17 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Add pathToReadableError

What is that?

byuSuite/Apps/MyFinancialCenter/model/MFCPaymentResponse.swift, line 9 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Remove UIKit from all classes that don't need it

Done?

byuSuite/Apps/MyFinancialCenter/view/MFCPaymentAccountTableViewCell.swift, line 13 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
private for all of these

Done.

byuSuite/Apps/MyFinancialCenter/view/MFCTransactionTableViewCell.swift, line 23 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
If the due date is <= today, make it red also

Would this override the dateLabelColor?

Comments from Reviewable

Reviewed 6 of 6 files at r20.
Review status: all files reviewed at latest revision, 14 unresolved discussions.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentHistoryViewController.swift, line 18 at r20 (raw file):

    @IBOutlet private weak var tableView: UITableView!
    @IBOutlet private weak var footerView: UIView!

Do we need to save this? I think we can get it with tableView.footerView

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentHistoryViewController.swift, line 85 at r20 (raw file):

            if let payments = payments {
                if payments.count == 0 {
                    self.footerView.isHidden = true

Why do you hide the footer when payment is empty?

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 17 at r20 (raw file):

    //MARK: Outlets
    @IBOutlet private weak var tableView: UITableView!
    @IBOutlet private weak var footerView: UIView!

see comment above

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 99 at r20 (raw file):

                }

                if sections.count == 0 {

self.footerView.isHidden = section.count != 0. Also do in other classes

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 67 at r6 (raw file):
Previously, ecbrady (Erik Brady) wrote…
Yes but I don't want to assume that since theoretically that could be changed in the future. I couldn't think of another way to get the cellId which I needed for cell.  It complained when I tried doing it out of the if lets

Do what we talked about with extensions

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 20 at r20 (raw file):

    //MARK: Outlets
    @IBOutlet private weak var tableView: UITableView!
    @IBOutlet private weak var footerView: UIView!

See above comment

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 11 at r6 (raw file):
Previously, ecbrady (Erik Brady) wrote…
What do you mean by move out of the class?

Move the variable outside of the class (like we normally do with private let)

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 39 at r17 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Do it (once Jamie's stuff is changed)

This is done. Just remove the todo

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 78 at r17 (raw file):
Previously, ecbrady (Erik Brady) wrote…
What is that?

ByuRequest2 has a property called pathToReadableError. You can pass it in the constructor. It will be "error.user_message"
ByuRequest2(url: url, ......, pathToReadableError: "error.user_message".....)

byuSuite/Apps/MyFinancialCenter/view/MFCTransactionTableViewCell.swift, line 23 at r6 (raw file):
Previously, ecbrady (Erik Brady) wrote…
Would this override the dateLabelColor?

I think I already did this by using dateLabelColor. Double check that it works

Comments from Reviewable

Review status: all files reviewed at latest revision, 13 unresolved discussions.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentHistoryViewController.swift, line 18 at r20 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Do we need to save this? I think we can get it with tableView.footerView

That accesses the footerView for a specific section and not the custom view we attach to the whole tableView.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentHistoryViewController.swift, line 85 at r20 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Why do you hide the footer when payment is empty?

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 99 at r20 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
self.footerView.isHidden = section.count != 0. Also do in other classes

Done.

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 11 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Move the variable outside of the class (like we normally do with private let)

Without static?

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 39 at r17 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
This is done. Just remove the todo

Done.

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 78 at r17 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
ByuRequest2 has a property called pathToReadableError. You can pass it in the constructor. It will be "error.user_message"
ByuRequest2(url: url, ......, pathToReadableError: "error.user_message".....)

Done.

Comments from Reviewable

Reviewed 4 of 4 files at r21.
Review status: all files reviewed at latest revision, 10 unresolved discussions.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentHistoryViewController.swift, line 18 at r20 (raw file):
Previously, ecbrady (Erik Brady) wrote…
That accesses the footerView for a specific section and not the custom view we attach to the whole tableView.

What? Really? But I've used that before! You're saying that self.tableView.footerView isn't accessing the tableView's footer

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 11 at r6 (raw file):
Previously, ecbrady (Erik Brady) wrote…
Without static?

Yup. When it's outside of the class, it's automatically static

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 78 at r17 (raw file):
Previously, ecbrady (Erik Brady) wrote…
Done.

Do it on both. Or somehow make it so that we don't have to do it twice... Try to replace the two constructor calls into one somehow.  Let me know if you can't come up with anything

Comments from Reviewable

Reviewed 5 of 5 files at r22.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

Comments from Reviewable

Reviewed 5 of 5 files at r23.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable

Review status: 27 of 34 files reviewed at latest revision, 7 unresolved discussions.

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 64 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Uncomment when finished

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 137 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Do it

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentHistoryViewController.swift, line 18 at r20 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
What? Really? But I've used that before! You're saying that self.tableView.footerView isn't accessing the tableView's footer

Sorry I didn't see .tableFooterView.  I only saw footerView forSection

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 54 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
I've noticed these two lines happen a lot... Could we add a dequeueCell function on the TableData object?

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 17 at r20 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
see comment above

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 67 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Do what we talked about with extensions

Done for dequeCell. Nib's coming shortly.

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 20 at r20 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
See above comment

Done.

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 11 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Yup. When it's outside of the class, it's automatically static

Done.

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 78 at r17 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Do it on both. Or somehow make it so that we don't have to do it twice... Try to replace the two constructor calls into one somehow.  Let me know if you can't come up with anything

Is this done? I saw from the commit messages that you worked on it but I couldn't tell if you resolved this specifically

Comments from Reviewable

Reviewed 7 of 7 files at r24.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 61 at r24 (raw file):

            cell?.textLabel?.numberOfLines = 0
            cell?.textLabel?.attributedText = terms?.getFormattedText()
            return cell ?? UITableViewCell()

Why default this to a UITableViewCell? Why not just put the let cell into the if like all the other ones?

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 67 at r6 (raw file):
Previously, ecbrady (Erik Brady) wrote…
Done for dequeCell. Nib's coming shortly.

Great. Could you also update the other features using tableData to use the new .dequeueCell function?

Comments from Reviewable

Reviewed 7 of 7 files at r25.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable

Review status: 29 of 38 files reviewed at latest revision, 5 unresolved discussions.

byuSuite/Apps/MyFinancialCenter/controller/MFCCompletePaymentViewController.swift, line 61 at r24 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Why default this to a UITableViewCell? Why not just put the let cell into the if like all the other ones?

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCPaymentSourceViewController.swift, line 23 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Non-optional?

Done.

byuSuite/Apps/MyFinancialCenter/controller/MFCUnpaidChargesViewController.swift, line 67 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Great. Could you also update the other features using tableData to use the new .dequeueCell function?

Done.

byuSuite/Apps/MyFinancialCenter/model/MFCCharge.swift, line 21 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
We could make an extension for this... Might be worth it because we do this a lot...

Done.

byuSuite/Apps/MyFinancialCenter/model/MFCCharge.swift, line 30 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Because we use each of these keys twice, let's extract this into variables

Done.

byuSuite/Apps/MyFinancialCenter/view/MFCTransactionTableViewCell.swift, line 23 at r6 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
I think I already did this by using dateLabelColor. Double check that it works

Done.

Comments from Reviewable

Reviewed 9 of 9 files at r26.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Reviewed 1 of 1 files at r27.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

byuSuite/Apps/MyFinancialCenter/model/MFCClient.swift, line 10 at r27 (raw file):

private let BASE_URL = "https://api.byu.edu/domains/mfcmobile/v1"
private let SANDBOX = true

Set to prod

Comments from Reviewable

Reviewed 4 of 4 files at r28.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Reviewed 1 of 1 files at r29.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Reviewed 1 of 1 files at r30.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Reviewed 1 of 1 files at r31.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Reviewed 1 of 1 files at r32.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Reviewed 3 of 5 files at r33.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Reviewed 1 of 1 files at r35.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions.

a discussion (no related file):
Wait for testing

Comments from Reviewable

Reviewed 1 of 1 files at r36.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Reviewed 4 of 4 files at r38.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Reviewed 1 of 1 files at r39.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Reviewed 2 of 2 files at r40, 1 of 1 files at r41.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Changes for proposed recyclarr template sync

To support a proposed new recyclarr feature, config templates have been relocated to a single folder. A new templates.json file has been created, and the metadata.json and metadata schema have been updated with the new variables.
Pull request
Purpose
At present, recyclarr allows users to create a default configuration file. A proposed new feature would allow for users to list any available templates, and generate a fresh config file from one or more available templates. These changes lay the groundwork in the guide to enable building this function in recyclarr
Approach

Relocate all recyclarr config files to a single location
create a new templates.json file to store locations and IDs (names) of all config files
Update the guide metadata.json and metadata schema files with new variables

Open Questions and Pre-Merge TODOs
Check all boxes as they are completed

[x] Use github checklists. When solved, check the box and explain the answer.

Learning
If you're adding a new Custom Format make sure you follow the Radarr/Sonarr Custom Format (JSON) Guidelines.
Requirements
Check all boxes as they are completed

[x] These changes meet the standards for contributing.
[x] I have read the code of conduct.

@rcdailey - here's the PR for the new templates feature for recyclarr. Would be good to get your eye on this one in case I missed anything - thanks again for all your help with this so far!

Thanks @yammes08, I will try to get a review in for you this week.

Indeed - even though the templates are stratified by service, and hopefully the list command would look something like:
Radarr
SQP-1
Hd-Bluray-web
Sonarr
Web-1080p
...I'd still expect each ID to be globally unique. If we ended up in a situation where we wanted two IDs to have the same name, then I'd update the IDs in the json to be prepended with <service>-.

I should have said: The directory path is not something I feel strongly about. It was (and should have been noted as) a nitpick.
The whole idea behind metadata.json is that you should be able to easily move the configs later and update the path there and the tools won't care.
I'm happy to keep it how it is. I just shared a future-proofing thought but I'm probably thinking too far ahead.

I've left the folder as it is for now. @TRaSH- I don't know how to resolve the conflicts with web_1080p_v4.yml and web_2160p_v4.yml - I think it's because I just updated them to add Comedy Central as per the last update on them, but the ones showing here as conflicting will be deleted/moved to the new location anyway. You should be fine to accept the ones in my PR as the ones to go with. If you're happy, this is all ready to merge.


updateSqlToolsServiceForaDacFxFix

This PR fixes https://github.com/microsoft/azuredatastudio/issues/11114

Pull Request Test Coverage Report for Build 248585694

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 39.158%

Totals

Change from base Build 248544078:
0.002%

Covered Lines:
19093

Relevant Lines:
44555

💛  - Coveralls


Automated Package Upgrade

:tada: This PR is included in version 12.4.119 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Installing<EMAIL_ADDRESS>failed.

I will try to install react but atom say
Failed to install react because Git was not found.
The react package has module dependencies that cannot be installed without Git.
You need to install Git and add it to your path environment variable in order to install this package.
You can install Git by downloading, installing, and launching GitHub for Windows: https://windows.github.com
Run apm -v after installing Git to see what version has been detected.
but i have already installed git and i will created lots off repo in git.

+1 on this. Actually every update you pushed so far made me uninstall and reinstall this package again. Not that I care, but might be something to look at. Could also be on my end but this is the only package where this problem occurs.
So far so good, great package. Love it!
Sincerely

Thanks for your help.


[proposal] add an @unstable annotation

More context in https://github.com/dart-lang/linter/issues/4763.
@eernstg: word-smithing welcome!

Here's a sample of an existing annotation that informs a lint. (@eernstg: it should look familiar as IIRC you helped write it!)
/// Annotation for intentionally loosening restrictions on subtyping that would
/// otherwise cause lint warnings to be produced by the `implicit_reopen` lint.
///
/// Indicates that the annotated class, mixin, or mixin class declaration
/// intentionally allows subtypes outside the library to implement it, or extend
/// it, or mix it in, even though it has some superinterfaces whose restrictions
/// prevent inheritance.
///
/// A class, mixin, or mixin class declaration prevents inheritance if:
///
/// * it is marked `interface` or `final`
/// * it is marked `sealed`, and is implicitly `interface` or `final`
///   based on the modifiers of its superinterfaces
/// * it is an anonymous mixin application, and is implicitly `interface` or
///   `final` based on the modifiers of its superinterfaces
///
/// A declaration annotated with `@reopen` will suppress warnings from the
/// [`implicit_reopen`](https://dart.dev/tools/linter-rules/implicit_reopen)
/// lint. That lint will otherwise warn when a subtype has restrictions that are
/// not sufficient to enforce the restrictions declared by class modifiers on
/// one or more superinterfaces.
///
/// In addition, tools, such as the analyzer, can provide feedback if
///
/// * The annotation is applied to anything other than a class, mixin, or mixin
///   class.
/// * The annotation is applied to a class or mixin which does not require it.
///   (The intent to reopen was not satisfied.)

I guess my concern is not necessarily future conflicts but being accidentally used instead of @experimental. It's perhaps a rare mistake that would only happen a first time or only until the term "stable getter" is more widely understood.
Also currently, I believe it would render on dart doc pages as @unstable without other information. I imagine that could definitely be mistaken as being an experimental marker.

/// Annotation for a final instance variable indicating that the implicitly induced
/// getter of that variable is not intended to be stable.
///
/// This annotation is associated with the lint `avoid_unstable_final_fields`,
/// and it has no effect unless that lint is enabled.
///
/// When a final instance variable does not have this annotation, it is assumed
/// to induce a stable getter, and the lint will flag the overriding declarations
/// that cause this getter to be unstable (that is, the overriding getters which
/// may return different results on different invocations with the same receiver).
///
/// When a final instance variable has this annotation, it is not assumed to
/// induce a stable getter, and overriding getters are not flagged, whether or
/// not they are stable.
///
/// Intuitively, this combination of lint and annotation is intended to have the
/// following effect: By default, every final instance variable is an immutable
/// property of the receiver. If a property is declared as a final instance
/// variable, but it is not intended to be immutable then it should have this
/// annotation. The lint will flag locations where this assumption is violated.
///
/// In addition, tools such as the analyzer, can provide feedback if the
/// annotation is applied to anything other than a final instance variable.

Perhaps we should make it @unstableGetter after all.

I'm ok with that.

Perhaps we should make it @unstableGetter after all.

I'm ok with that.

Me too.

Cf. https://dart-review.googlesource.com/c/sdk/+/330101.


Compile to JavaScript, add travis.yml for TravisCI to compile tagged …

…branches and push to npm on success
Setup needd on the TravisCI and npm sides to make it fully functional and automated.
Once done, update the version with npm which will also tag the code. push the code to github including the --follow-tags option.
I did not include building a bundle to publish, or pushing the JavaScript back to github.

Pull request is in relation to https://github.com/ronzeidman/ng2-ui-auth/issues/1


Bump nixpkgs to latest master

This PR is a lot of work…

[x] Bumps nixpkgs to latest master
[x] Because of that, a lot of Haskell related version bumps and other stuff can go
[x] Also, all nixpkgs patches can be dropped. Leave nixpkgs-patching code in place, but improve so that it does not do anything if there are no patches.
[x] Simply cabal2nix machinery; no need to repeat list of packages mentioned in nix/generate.nix
[x] Use .gitattributes to mark generated files as such
[x] Maintenance of the non-nix workflow that pushes the docs.
[ ] The static Haskell build no longer works (https://github.com/NixOS/nixpkgs/pull/130441), trying something else now. See below for more info

I am a bit stuck now, and the problem is the static build of ic-ref, which ships with dfx.
Previously, I used a compiler built against musl (via nix’s pkgsMusl), which allows static linking just fine. But this broke at some point in nixpkgs (see https://github.com/NixOS/nixpkgs/pull/129606#issuecomment-881323743, although there isn't much information).
I tried to use pkgsStatic instead, but that fails because then GHC cannot do Template Haskell, as dependencies have no .so files in this configuration.
I could try haskell-nix-static, but that’s yet another dependency, and I am worried about keeping the versions in sync between that and nixpkgs.
It would be easiest if we can just drop the static build. I am not sure what the plans with the emulator in dfx are; we never advertised it. Is it still used and useful, @ericswanson-dfinity?

Finally green!
I suggest to squash merge using the PR description as the commit message (this is what mergify would do, maybe we should start using this.)
Also, I'd appreciate admin rights again, like I  have on Motoko, so that I can do such maintenance and infra work more easily. Who do I need to ask about that?


Save screenshot not correct

Hi Marcomusy,
Thank you so much for your vtkplotter module.
I found the screenshot png size is not correct, the object seems not in the centre of the screenshot and be changed.
Could I output vector figure using vtkplotter?
Thank you so much.
Longkai

Hi Longkai
on some systems the screenshot function seems to behave a bit weird. Try adding
from vtkplotter import settings
settings.screeshotLargeImage = True
settings.screeshotScale = 1

ps: vtk to my knowledge does not really support vector figures

Thank you marcomusy, I tried your solution not worked. The details of the problems as follows(figure attached)
  offscreen = True
 offscreen = False
Selection_019.pdf This one is I cut the section using Shutter, it seems a higher quality figure than 'screenshot' function, I also tried to set (size = (2000.2000)) or settings.screeshotScale = 10(This makes the file very large) in vtkplotter but not work.
I hope I describe my problem clearly, if not, please tell me.
Thank you.
Longkai

What is "Shutter"?
I would try to use a smaller window size. What happens if you set
settings.screeshotScale = 1
settings.screeshotLargeImage = True
Plotter(size=(500,500))
...

Hi, Shutter is just shortcut screenshot tool.
There is blank png I got if set following you. However, I thought this is not the problem of vtkplotter, because I tried some examples also get the same results.
If I move the figure in renderwindow, then save the screenshot. It seems the figure is limited to top-left of renderwindow and shrunk with a ratio in height level.

hi, sorry for the delay in the followup, i'm not sure I understand your last message, did you manage to make it work in the meantime?


Edited gallery page

Added screenshots. The pics display in two columns on screens  and wraps to a single column on small screens. Addtionally each pic has a caption

The last picture has no caption but instead I used a dummy caption "add caption". So it should be edited


How to apply background color transition to VerticalNavigation buttons ?

Description
Hello,
I am currently attempting to utilize the  component and would like to enhance its smoothness. Specifically, I am seeking assistance in implementing a transition effect for the background color to gradually appear rather than abruptly spawning.

You should be able to achieve that with the transition-colors class from the ui prop or the app.config.ts:
<UVerticalNavigation :ui="{ base: 'transition-colors' }" />

It appears that utilizing the ui prop has achieved my desired outcome. For instance, employing the following line:
<UVerticalNavigation :ui=“{ inactive: ‘before:hover:bg-red-500 before:transition-all before:duration-300’ />, I found in the documentation that the background is utilizing the :before tag. Thanks for your help.


update Circle-CI config to push tagged images to ECR

Signed-off-by: Issif<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area tests

What this PR does / why we need it:
The tagged images are not pushed to ECR, only latest, see: https://gallery.ecr.aws/falcosecurity/falcosidekick-ui
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: de6185de713d9501aed85d39faa246b319078695


Avoid various warnings on ansible 2.8

Fixes https://bugzilla.redhat.com/1667511

See https://github.com/ansible/ansible/issues/53428

Successfully verified on ansible 2.7 and 2.8


Output size of Adaptation network

Thanks alot for sharing your codes. it's a meaningful work.
I have a question about the output of Adaptation Network. For cifar10 dataset, the output size of the adaptive network is 32 * 32 * 16. Why did you select 16 for the channel number? Is choosing a number smaller or larger than 16 OK? How do different values affect the results？
：）  ：）

@wyinggui
I'm sorry for replying to your question too late...
We optimally decide the channel size 16. It means Adaptation Network may show multiple candidates for scramble image's features. It OK to adjust the channel size, and larger channel size improve the classification accuracy and so on.
We did not investigate the result of the difference channel size because it does not relate to the paper's story.
If you have additional questions and want to get the answer quickly, please email my address directly.


[Enhancement] support discrete partition in mv

Why I'm doing:

The basic assumption of mv mapping is that partitions of base table is continuous, it doesn't support discrete partitions

What I'm doing:

Adjust the partition mapping mechanism to support discrete partitions

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[x] 3.0
[ ] 2.5

@Mergifyio rebase

@Mergifyio rebase

@Mergifyio rebase


tour: [Option to change language]

Context: https://tour.golang.org/
Can u add an option to change the language on navigation menu or hamburger menu? So that i can change the language anywhere in the web (https://tour.golang.org/)

I think it would waste a lot of space for little gain. We link to the tour translations at the beginning of the tour; most people then go on with the English version or click on their language translation, and I think they'd be pretty annoyed to see the full list of translation on every page.
Closing here.


allow custom user environment variables

This allows passing custom env in the config via :env this is useful for some repls like deno which needs NO_COLOR=1

Merged to develop, thank you! I've altered it a little so we merge opts.env into the hard coded table, not the other way around. That prevents mutating opts.env (since a.merge! mutates values, hence the !) and allows callers to override those defaults.


Add TryCatch in case window.nostr is missing

... or if anything went wrong with window.nostr.signEvent

Great idea, thanks alot!


Define the annotations for ballerina to comply with swagger 2.0

Need to go through swagger schema and identify the required annotations. We should not go for JAX-RS spec since it is only required for Java.

This is no longer a requirement for ballerina since we are going with our own annotation definitions which mapped with swagger.


latest page displays warning

Hi there! We use ReadTheDocs for a couple of sites, and noticed that our stable pages appear to ahve a notice on them making it seem they are not the latest.

https://warehouse.pypa.io/
https://blog.pypi.org/
These sites have this checkbox selected, if that changes how things are evaluated:

I don't know exactly where the bug lies, but it seems likely to be related to https://github.com/readthedocs/addons/issues/71
cc @ewdurbin @di

Hi, looks like a bug, we aren't taking into consideration the case of single version projects. I'm looking into a way to disable this feature for your projects in the meantime.

This feature should be disabled for those two projects now.

Thanks for the speedy handling @stsewd ! I can confirm things looks clear now. Do we need to have anything else done after the bug has been fixed?

Do we need to have anything else done after the bug has been fixed?

Nope, going to track this at https://github.com/readthedocs/addons/issues/140.


Ability to pass fetch instead of window.fetch

Not sure if this is me doing something wrong, is there a way  in SvelteKit to pass fetch instead of window.fetch ?
buf.knit.gateway.v1alpha1.KnitService/Fetch using window.fetch. For best results, use the fetch that is passed to your load function:

Protobuf-ES doesn't use fetch at all.
Did you mean to file an issue in https://github.com/bufbuild/knit-ts ?


The unidirectional edge getOrigin / getDestination functions should check validity

At present, the functions getOriginH3IndexFromUnidirectionalEdge and getDestinationH3IndexFromUnidirectionalEdge assume a valid edge. This leads to some weird behavior when non-edges are passed in:
getOriginH3IndexFromUnidirectionalEdge('891ea6d6533ffff'); // '891ea6d6533ffff'
getOriginH3IndexFromUnidirectionalEdge(0); // '800000000000000'

I don't think we need to call h3UnidirectionalEdgeIsValid, since it might(?) have more performance implications, but perhaps adding a bit check like
if (H3_GET_MODE(edge) != H3_UNIEDGE_MODE) {
  return H3_INVALID_INDEX;
}

would catch some common bad cases?

What are the quotes?

Anyway, I think throughout the library, you should be using better error checking where possible. As of now, my biggest concern is still calloc returning NULL when OOM occurs. If you are really concerned about performance, you can always follow this classic, ugly C pattern:
int func(int argc, const char* argv[])
{
#ifndef NDEBUG  // If not not debugging... AKA in debug mode
    const int returnCode = checkTheAssumptions(args);
    if (returnCode != 0) {
        return returnCode;
    }
#endif  // NDEBUG
...
    return 0;
}

What are the quotes?

Sorry, I'm working on the JS bindings, so this was copied from there. It still holds in C.

Fixed in #74


Fix memory leak

Make sure we dont have a reference to the closure in the exception stack trace.
fix https://github.com/guzzle/guzzle/issues/2606
fix https://github.com/hyperf/hyperf/issues/1486
fix #109

Heh, interesting. Good work. 👍

👍🏻

Thank you for the reviews


Allow optional compilation database directory to be a relative path

cquery doesn't find compile_commands.json in the build directory if I specify "cquery.misc.compilationDatabaseDirectory" in the vscode directory as a relative path ("build" or "./build")

This is probably because the cquery working directory is not the project directory.


Fixed issue with folder path not being stored with document.

Value must be set as a string before being saved to the database.

thanks


changed prefix in comment

It should be a reference to the user's meteor developer account name, no?

@simonv3 I think that depends if it's a local package or a published one but I'm not sure..
Can you make sure and post it here?

@Urigo Hmm, you're right, they are different, but if it's a local package it doesn't need the my-app bit at all, then you just do my-package. I guess what's different is that the package name of a published package just includes the developer name - ie simonv3:simon-package would be the full name of the package, and the : would just get replaced with a _.

so maybe can you edit it to be a bit more understandable, like saying package name and give an example?

thanks!


Changes/UI search

I am using Meilisearch ui as a management console
with mater key create a profile for others to work
Made some changes in the UI
Improve Search UX
Changes some validations for instance creation to allow multiple same instances with different keys.

Hey @Navin009 thanks a lot!
It would be nice if we could merge this nice contribution :)
But some files of this pr should be adjusted before merge.(github files, author info, parts unaccepted style modification...)
If I can merge this PR into my own PR to do this?
Or you have any other ideas about this we can discuss?

Sure, firstly I have modified this project as per my own use cases at the end to contribute.
There are a few points l like to share and will add

The dashboard should be revamped again LangSelector is removed
On Creation of a new index refresh the left panel after a second to show update.
Using this UI for managing products if the search contains any URL that shows the image in the popup better to manage the product.

Thanks for your response,
Love to contribute if I find available time


cherry-pick using stream rather than removeIf

This PR cherry pick #1057

/run-all-tests

I think nothing is changed?


Advanced flex server example checks for wrong timeout error code?

Consider the following lines in http_session::on_write in advanced_server_flex.cpp:
// Happens when the timer closes the socket
if(ec == net::error::operation_aborted)
    return;

I guess "the timer" now refers to the timer inside the tcp_stream, but if so, according to the tcp_stream documentation, the error code to check for is timeout, not operation_aborted.

You got some eagle eyes there... "the timer" refers to the broken timer code which I removed from advanced-server-flex, and I forgot to delete that code you quoted. Old code:
https://github.com/boostorg/beast/blob/boost-1.69.0/example/advanced/server-flex/advanced_server_flex.cpp#L291
"the timer"
https://github.com/boostorg/beast/blob/boost-1.69.0/example/advanced/server-flex/advanced_server_flex.cpp#L247
I'm pretty sure this is broken in 1.69, timers are hard to get right and thus the motivation for building it directly into tcp_stream and websocket::stream.
You really should join us on Slack, https://slack.cpp.al for the invite

Yep, this morning I decided I don't want to wait for 1.70 anymore, and will use Boost master for a few weeks in order to start taking advantage of all the recent Beast improvements. And since my application is based on the advanced flex server example, that's the part of the Beast code that I end up studying closest, to find out the recommended way of doing things. :)


How to set multiple cookies

I encountered a streamlit.errors.DuplicateWidgetID error, which seems to arise when attempting to set multiple cookies using the cookie manager. The error message indicates that there are multiple widgets with the same 'key' set.
The error occurs in the following block of code:
st.session_state['cookie_manager'].set('user_token', access_token, expires_at=expires_at)
st.session_state['cookie_manager'].set('refesh_token', refresh_token, expires_at=expires_at)

Is there any way to set multiple cookies like this?
Thank you

You can provide different key parameter for those individual call.

@karunpoudel-chr suggestion is valid. If folks want a batch add method, then emote 👍 on this comment.

I have added a batch add method to the cookie manager. Please upgrade to 0.1.70+

where is documentation about batch add method


Fix CI

Currently the visual regression test setup is failing in CI, so here attempting to fix it.

It works!


Android Studio License

Hello,
So I have the latest version of android studio, and it doesn't have any licenses and flutter is looking for them and can't see them find them and it gives the user a issue.
`$PATH`>flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, v1.12.13+hotfix.8, on Microsoft Windows [Version 10.0.18363.693], locale en-US)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    X Android license status unknown.
      Try reinstalling or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-setup for detailed instructions.
[√] Android Studio (version 3.6)
[√] VS Code, 64-bit edition (version 1.42.1)
[!] Connected device
    ! No devices available

There are no License on the latest version of the android studio .

Hi @Prajwal-Koirala
Could you add your flutter doctor --android-licensesoutput?

https://github.com/flutter/flutter/issues/20976


Add ability to define environment variables to be set for command execution

Given we're using ProcessBuilder, this is the most accurate form I could find to add environment variables to be set for the command execution

Looks reasonable enough. I would however like there to be a test that verifies the new behavior. Could be as simple as echoing the provided environment variable to stdout and checking the stdout contains the correct value. Which is similar to how some of the other tests are performed.


Add infer code

This PR add a file that contains the minimal code to infer the model with a consistent output.
This seems very slow to infer 100 tokens but output a consistent output
What do you think?

This PR add a file that contains the minimal code to infer the model with a consistent output.
This seems very slow to infer 100 tokens but output a consistent output
What do you think?

Hi, thanks for your contribution! I will test it.
When you say "slow", is it in comparison to generating of the same amount of tokens with the base model? did you add the amount of "thoughts" tokens in the comparison?

My tests are based on a 4070 ti that's why there is load_in_8bits=True in the script (to fit the model in the 12Go VRAM)
Of course the model mistral 7 (for the roiginal model I take mistral instruct)

model
quiet star
original model

token generated
400
50

usefull token
50
50

time to generate (s)
1055
17

token per second
0.38
2.94

second per token
2.64
0.34

Hi @ostix360, thank you so much for the contribution! I've run your infer code but the output doesn't make much sense to me... Can you explain it a bit more?

This is the whole output, it looks even weirder...


refactor: OPTIC-924: Remove Stale Feature Flag - ff_back_dev_2915_storage_nginx_proxy_26092022_short

PR fulfills these requirements

[x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[x] Tests for the changes have been added/updated (for bug fixes/features)
[x] Docs have been added/updated (for bug fixes/features)
[x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[ ] Backend (Database)
[x] Backend (API)
[ ] Frontend

Describe the reason for change
Remove long time stale feature flag

/git merge


refs 114: character sprite scaling regions

Every region in the room can be set as "scaling":

than you can set scale for the top and bottom of the region (meant as the highest and lowest position of region's polygon
every character stores info about scaling region he's standing on, in form of dictionary.
than game calculates scale proportionate (linear) for the character's opsition.
Warnings:

needs additional changes to be merged with my anti-glide (i have it ready, but i can't pull request it in reasonable way until it's merged).
acts a bit wirdeley in one edge case:
if there is drastic change of scale at the top of the region, character enters and exits region multiple times.
to avoid it, collishion shape for character's have to be reduced to [0,0, 0,0, 0,0, 0,0]

For further infos #114

There is another edge case (or is it a bug?):

If you create a region that encloses the character in its original position, scaling won't be applied until it starts moving. (sorry for the audio in the video)

https://github.com/mapedorr/popochiu/assets/4536477/7a30221f-9770-46cc-89dc-3ab24d6775ad

There is another edge case (or is it a bug?):

If you create a region that encloses the character in its original position, scaling won't be applied until it starts moving. (sorry for the audio in the video)

no_scaling_until_moves.mp4

that's right. I've checked it onli with anti-glide and then _update_position was called fust after sprite load.
Without anti_glide - no. Now it should be fixed!


feat: Http weight forwarded rules

Description
This PR add 'weighted-forward' dynamic action block to use with the http_tcp_listener_rule for multiple weighted target_group.
It is very close to #224 but manage the http.
Motivation and Context
This adds a dynamic action block for a "weighted-forward" action_rule.type for the http_tcp_listener_rules . It allows us to create a listener rule like:
{
  http_tcp_listener_index = 0
  priority                = 30

  actions = [
    {
      type = "weighted-forward"
      target_groups = [
        {
          target_group_index = 1
          weight             = 1
        },
        {
          target_group_index = 0
          weight             = 0
        }
      ]
    }
  ]

  conditions = [{}]
}

Breaking Changes
No breaking changes
How Has This Been Tested?

[X] I have tested and validated these changes using one or more of the provided examples/* projects

I created the resources and visually verified the correct rules made it onto the load balancer.
+ forward {
  + stickiness {
    + duration = 0
    + enabled  = false
  }

  + target_group {
    + arn    = "arn:aws:elasticloadbalancing:eu-west-1:../21b716c2bd84930d"
    + weight = 1
  }
  + target_group {
    + arn    = "arn:aws:elasticloadbalancing:eu-west-1:../6c33705a9ab0897a"
    + weight = 2
  }
}

Also complete  fixes #211

Hello @antonbabenko
Could you review my PR ?
Regards,

Hello @antonbabenko
Could you review my PR ?
Regards,

This PR is included in version 6.9.0 :tada:

Thank you @gbloquel !
Sorry that it took some time for this to be merged.


Add fgpio driver support for NXP frdm_ke17z and frdm_ke17z512

Tested tests/drivers/gpio/gpio_basic_api sample.

Hi @hakehuang , please help connect J1-14 and J1-16 on the two boards and test them, thanks!

@ankeXiao , board testing pass.


filesystem.suffix_base not present on TenantCreated

Describe the bug
I have  a value set for filesystem.suffix_base but it seems this has not been loaded when I use the example  CreateFrameworkDirectoriesForTenant on https://tenancyforlaravel.com/docs/v3/realtime-facades
It still uses the default "tentant" at this stage. Later when running the application storage_path returns the correct suffix_base from the config.
Steps to reproduce
Set a value for filesystem.suffix_base
Add CreateFrameworkDirectoriesForTenant to your TenantCreated job pipeline like shown on https://tenancyforlaravel.com/docs/v3/realtime-facades
Expected behavior
Should use the value from tenancy-config.
Your setup

Laravel version: 8.20.0
stancl/tenancy version: 3.4.0

I have a value set for filesystem.suffix_base

What's the reason for that?

Sorry, it works as expected. I was using an old tinker session.


Loop stops when tries to call cleanup method

Hi,
After several hours running pynotify watching a folder, It suddenly stops with the following stacktrace.
File "/app/meteo/filechangeswatcher.py", line 46, in run
    self.notifier.loop()
  File "/usr/local/lib/python2.7/dist-packages/pyinotify.py", line 1424, in loop
    self.process_events()
  File "/usr/local/lib/python2.7/dist-packages/pyinotify.py", line 1322, in process_events
    self._sys_proc_fun.cleanup()  # remove olds MOVED_* events records
AttributeError: 'NoneType' object has no attribute 'cleanup'

I'm listening to the following events: pyinotify.IN_CLOSE_WRITE|pyinotify.IN_CREATE|pyinotify.IN_MOVED_TO.
My process handler looks like:

class EventHandler(pyinotify.ProcessEvent):

    def  __init__(self,conn,logger):
        pyinotify.ProcessEvent.__init__(self)
        // something here....

    def process_IN_CLOSE_WRITE(self, event):
        self.__process(event.pathname)

    def process_IN_CREATE(self, event):
        self.__process(event.pathname)

    def process_IN_MOVED_TO(self, event):
        self.__process(event.pathname)

    def __process(self, f_abspath):
          // something here

Hi, can't help you much but a couple of observations:

Even if it is probably unrelated to your issue you should not call the constructor of ProcessEventdirectly see this comment for an alternative.
From your stack trace, the only way _sys_proc_fun could be None is if the method stop() got called previously. I'm not sure why but it seems to process events after it is stopped and it shouldn't happen.

Closing, feel free to reopen it if you have more details.

Sorry, I completely forgot to answer. You were right I was calling to stop by accident.

[...] the only way _sys_proc_fun could be None is if the method stop() got called previously. I'm not sure why but it seems to process events after it is stopped and it shouldn't happen.

Seems to be the case for me too, using the package from PyPI. Should this not be a separate issue/bug report? I don't think I'm familiar enough with the code to fix it myself.


Can't Create the Azure Bot resource

Describe the bug
I'm following the doc of "Provision and publish a bot" and in the step of "Create resources with ARM templates" I opened another doc "Use Azure CLI to create or update an Azure Bot resource" to follow but in the second doc the step "Create the Azure Bot resource" is giving errors.
I made a corebot on vs and hosting it locally on the emulator but Iam trying to deploy it in azure to connect it to another web application I made in vs by asp.net core mvc .
Related command
az deployment group create --resource-group testbot --template-file D:\y4t2\GP2\CoreBot1\DeploymentTemplates\DeployUseExistResourceGroup\template-AzureBot-with-rg.json --parameters "@D:\y4t2\GP2\CoreBot1\DeploymentTemplates\DeployUseExistResourceGroup\parameters-for-template-AzureBot-with-rg.json"
Errors
{"status":"Failed","error":{"code":"DeploymentFailed","target":"/subscriptions/note I hide it /resourceGroups/testbot/providers/Microsoft.Resources/deployments/template-AzureBot-with-rg","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.","details":[{"code":"InvalidBotData","message":"Bot is not valid. Errors: Display name is required.  See https://docs.microsoft.com/azure/bot-service/bot-service-resources-bot-framework-faq?view=azure-bot-service-4.0 for detailed requirements."}]}}
Issue script & Debug output
{
"code": "DeploymentFailed",
"target": "/subscriptions//resourceGroups/testbot/providers/Microsoft.Resources/deployments/template-AzureBot-with-rg",
"message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.",
"details": [
{
"code": "InvalidBotData",
"message": "Bot is not valid. Errors: Display name is required.  See https://docs.microsoft.com/azure/bot-service/bot-service-resources-bot-framework-faq?view=azure-bot-service-4.0 for detailed requirements."
}
]
}
Expected behavior
Create the Azure Bot resource
Environment Summary
azure-cli                         2.58.0
core                              2.58.0
telemetry                          1.1.0
Dependencies:
msal                              1.26.0
azure-mgmt-resource             23.1.0b2
Python location 'C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\DELL.azure\cliextensions'
Python (Windows) 3.11.7 (tags/v3.11.7:fa7a6f2, Dec  4 2023, 19:24:49) [MSC v.1937 64 bit (AMD64)]
Legal docs and information: aka.ms/AzureCliLegal
Your CLI is up-to-date.
Additional context
No response

Thank you for opening this issue, we will look into it.


Discord

I just tried the above link and it indicated it is invalid.
Thanks

Yeah same here, don't know why though.

Hi @jpitz31 @mrandyt
Try this: https://discord.com/invite/k4DAyQwZ


Better support for BetterDummy + Sidecar, Airplay or DisplayLink

Dummies including BetterDummy is now intentionally skipped from controlling displays (Display.isDummy checks).
Virtual Displays (like Sidecar, Airplay, DisplayLink displays) that support only shade control are banned from control when in mirrored setups (DisplayManager.isDisqualifiedFromShade).
Each of these factors are prohibiting BetterDummy mirrored Virtual Displays to benefit from shade based dimming.
An exception must be implemented to solve this issue.

Should it work at this point? I use displaylink and BetterDummy.

Hmm. Yes, BetterDummy->Sidecar/DisplayLink mirrored display brightness control via shading should be working in the latest version under Monterey.

How about Big Sur? Should it work as well?

Probably should, but never tried it. :)
The No Control / unspecified control status is interesting though, I did program the app to show that message as a last resort - it seems like the app just has no idea what to do with a combination of DisplayLink and BetterDummy on Intel.
A few questions:

Are you using the latest version of the app?
If you do not enable BetterDummy, does the app work?
If you try BetterDummy + a naitve (non-displaylink) display, does the app work?

What might help is if you could provide me with the console log of the app during startup, when the display detection is done. Here is how to do that: https://github.com/MonitorControl/MonitorControl/discussions/851


Add metadata support for stargz format

Is there any plan to support  [stargz image format by CRFS in the near future? Thanks!

We don't have any plans for adding CRFS support to distribution I'm afraid.

Thank you for the reply!


kernel throws "not a text" on lilu plugins with Lilu 1.2.1

Hello
I have two plugins working along my lilu kext:

shiki
AppleALC

Since I upgraded today from Lilu 1.0.0, I have the following sequence of messages in the Console (2x).
If I remove one plugin, I only have it once.
For AppleALC (latest version), it is working properly, but still shows the warnings.
For Shiki, I have some issues, but I do not think it is related to that.
With Lilu 1.0.0, I only had AppleALC, and it didn't give any message.

09/12/17 19:14:54,000 kernel[0]: kext submap [0x - 0x], kernel text [0x - 0x]
09/12/17 19:14:54,000 kernel[0]: "name" not a kext
09/12/17 19:14:54,000 kernel[0]: "FailedCLUT" not a kext
09/12/17 19:14:54,000 kernel[0]: "FailedImage" not a kext

Hi,
TL;DR it is not related to Lilu, and it happens when you inject any kexts with a bootloader. Basically it is a bug in Clover, and you should direct your issue to Clover team (or another bootloader dev team if you do not use Clover).
This message happens within XNU OSKext::createExcludeListFromBooterData, which iterates over IODeviceTree:/chosen/memory-map properties, and sees non-kext properties before the others. name, FailedCLUT, and FailedImage are not kexts, but parameters, e.g. the latter two describe how to visually display boot failure (colour/image).
Why does it do it: If booter kext injection is used XNU expects to find 2 com.apple.driver.KextExcludeList kexts instead of 1. Firstly the one from booter, then the actual one from prelinked.
It is not clear why would it insist on all memory-map parameters preceding KextExcludeList to be kexts, since they obviously may not be (all the three are and should be present even on real macs), so you could even file a radar, but I guess it is likely that KextExcludeList will come first anyway and thus avoid the message.
If you just need a workaround, you may try injecting some dummy/empty com.apple.driver.KextExcludeList via Clover. From my point of view, this is something Clover should do by default (since clearly XNU expects it), and therefore I consider it a bug.


Migrate UI tests to Kakao framework

Migrate internals of testing DSL to Kakao framework

Merged in PR #48


cmd/uninstall: check for dependent casks

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?
[x] Have you successfully run brew man locally and committed any changes?

This PR aims to add the ability to check for casks dependent on formulae when running brew uninstall, as requested in #10570.
Output:
➜ brew uninstall mono
Error: Refusing to uninstall /usr/local/Cellar/mono/<IP_ADDRESS>
because it is required by godot-mono, which is currently installed.
You can override this and force removal with:
  brew uninstall --ignore-dependencies mono

~TODO: Comments for the new find_cask_dependents method and tests.~

Review period will end on 2021-02-10 at 01:23:57 UTC.

Review period ended.

I'm 👍🏻 on sharing code on them if it makes sense.

I've done this with the latest commit(s). I thought it would be better to have Keg.find_some_installed_dependents get dependents of kegs irrespective of whether those dependents are kegs themselves or casks. I hope my thinking isn't incorrect here.

I don't think there should be any references to casks in keg.rb though; casks never have/use kegs.

If I am wrong and/or this point (any references) takes precedence, I'll move the handling to cask/.

With the latest commit, I've moved find_some_installed_dependents from keg.rb to a new installed_dependents.rb (hope I understood the suggestion right).
This method had quite a few tests and so I've moved them as-is from the previous keg_spec.rb, along with an additional test that is cask-related.


[RELEASE] MinIO Server RELEASE.2023-12-02T10-51-33Z

MinIO Server RELEASE.2023-12-02T10-51-33Z has changes that impact the docs:

[ ] Adds Websocket Grid functionality (but maybe not in the main docs; more for internal reference for now) (PR #18461)
[x] Adds snowball functionality to batch replicate jobs (PR #18485)

[x] Related: adds ability for immediate tiering for snowball replication (PR #18508)

[ ] Adds ability to use external cache for GET/HEAD functions (for HDD drives primarily) (PR #18239)
[x] Relaxes batch limits for Kafka events (PR #18513)
[ ] Adds a drive max timeout (PR #18501)
[x] Adds support for an age conditional for bucket policies for pre-signed URLs (PR #18529)
[x] Additional Kafka variables for compression (PR #18562)
[x] Adds new expiration job type to the batch job framework (PR #17946)

18329 needs to be handled separately.


KeepAlive support

Description:
As a user I would like to enable and configure tcp keep-alive for 2 cases

downstream with client
upstream with server

here is the config needed in Envoy

upstream
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/core/v3/address.proto#config-core-v3-tcpkeepalive

downstream
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/core/v3/socket_option.proto#config-core-v3-socketoption

How other Envoy based implementations express this as an API

Emissary has support https://www.getambassador.io/docs/emissary/latest/topics/using/keepalive#keepalive (unsure if this is downstream or upstream socket)
Istio supports Upstream Keepalive https://istio.io/v1.1/docs/reference/config/networking/v1alpha3/destination-rule/#ConnectionPoolSettings-TCPSettings-TcpKeepalive
Contour : TODO

@youngnick do you think this is something that we will need to drive in EG first as an extension or do you think there is enough implementations out there that this can be directly defined in the Gateway API ?

similar to https://github.com/envoyproxy/gateway/issues/1169#issuecomment-1474081362


ymapMarker created after map init not showing

Hi,
I'm trying to use the <ymap-marker> component to generate markers for an array of places which are loaded asynchronously. However it seems like creating <ymap-marker> after the map initialization doesn't trigger anything.
I created a codepen:
https://codepen.io/Owumaro/pen/LYYqrRK
I used a setTimeout to fake an async loading. After the timeout, there are 3 ymap-markers but they are not showing.
The problem is that the drawing of the markers is handled by the Map component, however the map is not watching its default slot to get new ymap-marker.
The map component reads its ymap-markers  at creation (using this.$slots.default), but if a ymap-marker is created after, it will not be known by the map.
Maybe the ymap-marker should register itself at creation to the parent Map. I'm not sure of how the map keeps track of its children ymap-marker currently.
Another solution would be to delegate the creation of markers to the ymap-marker component itself. I also use vue-googlemaps which works that way:
https://github.com/Akryum/vue-googlemaps/blob/master/src/components/Marker.js#L96
As you can see the marker component gets the map reference and creates the map marker by calling the google maps method. This also allows each marker to be independent and would simplify a lot of code here. But that would be a big change.
What do you think ?
Thanks,

надо добавить Events для карты,
myMap.container.fitToViewport();

Thanks for the answer,
Do you mean calling this manually every time ymap-markers are added ?
This is against the principle of using vue components : update data and delegate the rest to the components.

согласен), тогда ждем ответа разработчика

@antoinematyja Yeah. It is a bug. I deleted an observer, but forgot to implement marker creation in created hook. I'll fix it tomorrow and will think about your another issue #183

Thanks !
Also note that the last solution proposed in this issue would also solve #183 .

@antoinematyja replacing logic into markers - is a good idea and it is in my roadmap. But i haven't a time to implement it for now (

Ok, good to hear !
I'll work on a PR if I find the time too...

получается еще не устранили проблему?, есть еще такая проблема, при смене zoom, ели я выбираю область, или регион, я передвигаю карту по координатам, и у каждого региона свой зум, почему то он иногда косячит, а именно зум сработает а координаты оставит на месте


Cleanups to make tslint pass and format with clang.

Changes to make this project conform to coding style guidelines.

These are changes made either by automated tools, or to fix tslint warnings. Nothing should actually change code.


TS-4132 Open source Yahoo's ats-inliner plug-in

@bryancall for your considerations,
there are still README file pending

@sc0ttbeardsley do you think this README files explains it well? https://github.com/dmorilha/trafficserver/blob/28456734fbc604b0115d1582dd2bf1b230263cdf/plugins/experimental/inliner/README

Let's squash this branch a bit to improve clarity. All the code changes should go into the first commit, then the build integration and documentation in the second.
WRT  printf formats, please use PRId64.

@jpeach all done

@dmorilha You mean "%" PRId64 ""

good point!

Re: doc. I think the read me is a great start. Is the plugin a global or remap plugin?

@dmorilha ya, looks pretty good. We should add some details about adding the remaps for image asset urls since that is a bit tricky. Also we should add in this image?

I will make sure to squash it again once we reach an agreement here.

I reviewed this before in our work repository and I am happy with it.

@mlibbey it is a global plugin. @dmorilha we should add a "how to configure and use" section in the readme. I'll send you a PR if I get a chance


Add extra methods for authentication and management of users

Add method for create email/password user
Add method that generates the email action link for sign-in flows, using the action code settings provided

@martinjhm Can you add some tests for these functions? -
create_email_password_user & generate_sign_in_with_email_link

@martinjhm Can you add some tests for these functions? -
create_email_password_user & generate_sign_in_with_email_link
Also update the README file.

Sure, No problem

@nitinstp23 Done.

@martinjhm Thanks! ❤ 💙 💚 💛 💜

@martinjhm Can you fix the failing tests in master?
https://travis-ci.org/scripbox/firebase-admin-ex/builds/541131441


Add Navbar-3

Thanks for your contribution ❗❗ and don't forget to  leave a like if you liked this repository .
Happy coding ❤


Zustand v5

Is your feature request related to a problem? Please describe.
The Zustand package uses v4, it would be awesome if it supported v5
Describe the solution you'd like
The Zustand package supporting v5
Additional context
N/A

Done in #2077 . It will be release soon.

Thanks @SugarDarius 🙌🏻


preview-docs and build-docs do not include tag-description-override decorators

Describe the bug
I have a simple redocly.yaml file that has one tag-description-override section for an API.  This works fine when using bundle to generate followed by build-docs or preview-docs:
# redocly bundle -o /tmp/thebundle.yaml path/to/spec.json
# redocly build-docs /tmp/thebundle.yaml

However, simply calling preview-docs or build-docs on the same path/to/spec.json does not include the overrides referenced by the decorators.
This wouldn't matter if the tag allowed a $ref in its description, or if there was some extension like x-description-ref that allowed a ref.
And yes, I am aware that I could embed the CommonMark in the spec directly. However, we use JSON for the majority of our specifications and embedding CommonMark in JSON is at best painful.
To Reproduce
Steps to reproduce the behavior:

Given this redocly.yaml file

# See https://redocly.com/docs/cli/configuration/

apis:
  # Update the apiName with your actual API name, and the version with your actual API version.
  Example@2:
    root: ./openapi.json
    rules:
      operation-4xx-response: off
      tag-description: off
      no-empty-servers: off
      security-defined: off
      info-license: off
    decorators:
      tag-description-override:
        tagNames:
          Example: ./EXAMPLE.md

extends:
  - recommended

theme:
  openapi:
    generateCodeSamples:
      languages:
        - lang: curl
        - lang: Node.js
        - lang: Python

And this OpenAPI file(s)

{
  "openapi" : "3.1.0",
  "info" : {
    "title" : "Example",
    "version" : "1.0",
    "summary" : "Example summary"
  },
  "components" : {
  },
  "paths" : {
    "/example":
    {
      "get" : {
        "operationId" : "example",
        "responses" : {
          "200" : {
            "content" : {
              "application/json" : {
                "schema": {
                "properties": {
                  "status": { "type": "string" }
                },
                "required": [
                  "status"
                ],
                "type": "object"
              }
              }
            },
            "description" : "Succeeded"
          }
        },
        "summary" : "Example summary",
        "tags" : [
          "Example"
        ]
      }
    }
  },
  "tags" : [
    {
      "name" : "Example"
    }
  ]
}

And this external description EXAMPLE.md

# An Example Description

This is a CommonMark description of the example tag.

Run this command with these arguments... redocly bundle and you will see the external file included
Run this command with these arguments... redocly build-docs and examine the generated redoc-static.html file
The external file contents are not included

Expected behavior
I would expect the external referenced files to be included.
OpenAPI definition
Using OpenAPI 3.1.0
Redocly Version(s)
1.0.2
Node.js Version(s)
14.15.5

Hi @halindrome, thanks for reporting! This is the same issue as #1078.
By the way, maybe provided solution can help you?

Thank you - yes, a similar work around has been implemented by us locally. A real fix would be nice, since without it the VS Code plugin and associated preview option is somewhat confusing.

Good point! I am going to attach this issue to the VS Code extension too!

I think this is a really good fit for the VSCode extension, but that the commands in the CLI should remain separate; the functionality is correct as it stands, but we're also working on some changes to make it easier to combine multiple steps. I'll close this specific issue, since we won't add decorators into the build-docs step.