Manual changes needed to fix the automated TF --> TFLM sync.

import changes from upstream TF:

https://github.com/tensorflow/tensorflow/commit/2f824e0ce28b2d533ac4edb0d01c38f8758b39a4
https://github.com/tensorflow/tensorflow/commit/856fd18fcf0b33908d8fec243953d3fa97bf49fa

make the corresponding changes in the TFLM code, following:

http://cl/449226814
http://cl/449192972

BUG=http://b/233257155
NO_CHECK_TFLITE_FILES=manually imported files from upstream TF due to an API change.

Closing in favor of #1164


how do I remove the checkmarks in desktop icons

Description of the new feature / enhancement
No more checkmarks in the desktop icons
Scenario when this would be used?
Personal preference - this feature was available in an earlier version of the program
Supporting information
No response

Do you mean this guy? /needinfo

Most definitely. I’m running Windows 11
Sent from my iPhone

On Mar 8, 2022, at 5:28 PM, Franky Chen @.***> wrote:

Do you mean this guy? /needinfo
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.

/dup https://github.com/microsoft/PowerToys/issues/9756

👍
Sent from my iPhone

On Mar 8, 2022, at 7:30 PM, msftbot[bot] @.***> wrote:

Closed #16904.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.


DFSDM for l4x6

Get DFSDM working for l4x6.  One of the discovery kits for the L4, 32L496GDISCOVERY, uses an L496 and has some onboard mics attached to the dfsdm, but it's disabled in lib.rs for l4x6.  Looks like the register layout is not the same as the l4x5 so it's not super straight forward.

I'd like to work on this next, looking for input and to see if anyone has tried it yet.

Yea - it looks like rather than breaking the PAC commands down by channel, it's set up in the same namespace. Rust docs hasn't built the L4 PAC for L4x6, but I'd bet it's similar to the L5 impl here. It's a matter of feature-gating using that PAC syntax.
Ideally, the fix would be consolidation on the PAC side, but I'm happy with a bandaid here.

Thanks for the input David.
I think it would be better to have a consistent implementation between l4 variants at least and the current pac is even missing registers for filter1 on l4x6.  I made a bug over at stm32_rs https://github.com/stm32-rs/stm32-rs/issues/760 and put in a PR so we'll see what happens.

I'm working the bandaid. This will make the code a lot more verbose and messy, but worth it IMO.

Just pushed a change that should hopefully get this tarted. The good news: I got it working on L5. The bad: it doesn't yet work on L4 (Other than x5). Any ideas?

I build the docs for L4x6, L4x5, and L552.  L4x6 uses dfsdm1 for the module and the channel regs look like chcfg0r1, L552 uses dfsdm1 for the module and the channel regs look like ch0cfgr1, and L4x5 uses dfsdm for the module and has the channels separated like you have already.  :face_with_spiral_eyes:
I made a topic branch that almost compiles for L4x6, but I ran into the problem where the pac crate doesn't have registers for filter 1.

Great finds re the details. Long term solution is to make all the PACs the same, ideally with the channel-based indexing we see on H7.
Some further notes:

It turns out it was never working properly with L4x5; I had feature gated out some sections
The only family I've actually tested DFSDM with on hardware is H7, but I think it's likely it'll work on other families once we sort through these compile/PAC differences and errors
I'm going to take a stab on working around the l4x6 compatibility with the current PAC, as I did with L5, thanks you your clarification on the reg name format
This module is rapidly turning into a mess with these verbose feature-gates; there might be a cleaner way to consolidate them, but I'm going with quick+dirty now

Could you post the L4x6 register names for all the relevant DFSDM regs? Like you did for cfgr1. Maybe a screenshot of the docs you built?

Sorry, I've been busy lately.  Here are the docs: https://drive.google.com/file/d/1Xq-w1swOkWfiuLY3aT9OrzUZ8TOLLZkX/view?usp=sharing
You can also build them from this repo, but only if everything builds ex: cargo doc --features l4x6 --open

Thank you. From looking at that, I'm assuming the filter x regs are called dfsdmx_ on L4x6, but haven't tested. My current plan is to wait until the PAC gets fixed with the work you've done there. Might try to patch in these reg names for L4x6 as an alternative, but I'm not sure if it's viable, even ignoring filter 1. Thoughts?

You're correct about the filter regs on L4x6.  I'm fine waiting for the PAC, but I don't know how active they are, I haven't had any feedback on my pr yet.  In my branch that I linked above I made separate register access structs for each different register config (L4x6, and L4x5) I think it makes the driver code cleaner, but I'm pretty new to rust so there may be better tools to do that.

Implemented on l4x6 in latest commit; give it a shot

Released in 1.5.2
Closing as fixed. If you have any issues getting DFSDM to work with those mics, please open another issue.
I hope the PAC eventually unifies; I'm not happy with how long the DFSDM module here got addressing this, but it was IMO worth it.


Add test ACustomerMessageTest (shows Size min not defaulting)

Size min expected to default to 0 according to the error messages we have.
So given:
    @NotBlank @Size(max = 5)
    final String name;

Generates:
    this.nameValidationAdapter =
        ctx.<String>adapter(Size.class, Map.of("max",5))
            .andThen(ctx.adapter(NotBlank.class,Map.of()));

And we can get the validation message where the {min} is not replaced (with say 0 or indeed 1):
size must be between {min} and 5

The default value for Size min is 0, so we reasonably expect the {min} to be replaced by 0.
I note that we know in this case that there is also the @NotBlank and technically that means that the Size min should really be 1 (because we know with the NotBlank that 0 isn't a valid minimum number of chars).
Perhaps ... we could ensure the ordering such that NotBlank, NotEmpty, NotNull are higher precedence and the generated code always puts those first and IF that happened and the context knew that a NotBlank proceeded the Size THEN ... it could deduce that the default min should be 1.
Regardless it looks like the way SizeAdapter is created needs adjustment to allow for the min defaulting to 0.

yeah, with the exception of Pattern (since its values are accessed via prisms), there are no default values added to the attribute map.


Add test container for UT of MySQL passwordless feature

Context
Now we have PasswordlessMySQLIT to test our passwordless feature for Azure MySQL single server, but it can't run on local env and it takes a lot of time to run(> 10mins).
With Testcontainers for java, we can create data access layer integration tests and run the tests locally to ensure our code quality.
Goal

Use Testcontainers to mock Azure MySQL single server.
Add test class to test passwordless feature with Testcontainers.

Design

Add test class under test folder in spring-cloud-azure-integration-tests.
In the test class:

Use DefaultAzureCredentialBuilder to build DefaultAzureCredential to get token with scopes "https://ossrdbms-aad.database.windows.net/.default".
the scopes vary in different Clouds.("Public,UsGov,China")
use the token as the password to initialize the test container with mysql.
specify the spring.datasourcce.* properties with the test container url.

  private DockerImageName dockerImageName = DockerImageName.parse("mysql");

    @Container
    public MySQLContainer mySQLContainer = new MySQLContainer(dockerImageName);

    @BeforeEach
    void setUp() {
        DefaultAzureCredential build = new DefaultAzureCredentialBuilder().build();
// the scopes vary in different Clouds
        String password = build.getToken(new TokenRequestContext().addScopes("https://ossrdbms-aad.database.windows.net/.default"))
                .block()
                .getToken();
        mySQLContainer.withUsername("passwordless-test")
                      .withPassword(password);
    }

    @Test
    void testMysqlPassword() {
        // add your
    }

Our own authentication plugin will generate the packet send to MySql Server,
but with Testcontainers run as MySql Server, it's not able to recognize this package,
it will throw bad handshake exception.

Does this have anything to do with SSL?

According to the pipeline results, macOS and windows environment doesn't support test container, So do we continue work on this feature skipping macOS and windows environment tests? @saragluna @backwind1233
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2035024&view=logs&j=9b2d956e-2d7d-5748-773c-4213a0cc31b4&t=18c6a9f8-d3e2-5c20-8ffa-39c028cee927&l=89
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2035024&view=logs&j=5fe92c1d-3c25-55b7-1c07-fa5c3c25e91d&t=55c333a2-afdf-54d6-1385-c643b91b3f0b&l=23

Hi, testcontainers has an azure pipeline, see here. Hope this help.

Can we use something like this https://wesome.org/junit-5-conditional-test-execution-operating-system-conditions for conditional on Windows?

https://github.com/Azure/azure-sdk-for-java/pull/32570

There's another issue with using the test container. Our authentication plugin's name is mysql_clear_password. However, users created in MySQL container are identified with the mysql_native_passowrd plugin.

Sorry, not that much experience on this but I wonder if the following url param work authenticationPlugins
withUrlParam("authenticationPlugins", "com.mysql.cj.protocol.a.authentication.MysqlClearPasswordPlugin")
LDAP and PAM are provided by the Enterprise Edition :/

@saragluna, you said:

the compatible server plugin for mysql_clear_password are PAM or LDAP, which I think is not available for MySQL test container.

If this is an enterprise edition feature, what is the issue with using an enterprise edition image together with Testcontainers' MySQLContainer and following @eddumelendez's suggestion of using .withConfigurationOverride("somepath/mysql_conf_override")?

@kiview I don't think there will be an issue using an enterprise edition image (if we are allowed to use it). I haven't tested that and think it would be an option. PR is welcome if you are interested.

@saragluna Unfortunately, I don't think there is a publicly available version of the enterprise edition image, the old image was deprecated: https://hub.docker.com/_/mysql-enterprise-server
It might be possible to put the regular image into an enterprise mode, however, the docs have the following section:

For users of MySQL Enterprise Edition: A subscription is required to use the Docker images for MySQL Enterprise Edition. Subscriptions work by a Bring Your Own License model; see How to Buy MySQL Products and Services for details.

It is only available from OCR.

@kiview thanks for the update. Seems like we donn't have a feasible solution here.

Hi again, I wonder if Percona (build on top of MySQL) can help with this https://docs.percona.com/percona-server/8.0/security/pam_plugin.html

forgot to mention that Percona is compatible with MySQLContainer
var percona = DockerImageName.parse("percona:8.0.32-24").asCompatibleSubstituteFor("mysql")
MySQLContainer mysql = new MysqlContainer(percona);

@eddumelendez thanks for updating, we will take it into consideration

Hi @eddumelendez, I guess it's possible. The core point is to create a user in the Percona and this user will be identified by auth_pam. In the plugin we developed, it would auth the user with mysql_clear_password plugin. I haven't tried it yet, but if we can set up all these, then it is possible.


Add new index to techinsights

This improved query for latest facts from several seconds to milliseconds on our instance
Hey, I just made a Pull Request!
After tech-inisights working for some time, without purging old data the performance was super bad.
Adding index helped it so much.
Before:

After:

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Can I get a rerun of tests? It doesn't seem to be affected by me deleting knexfile.js

Can I get a rerun of tests? It doesn't seem to be affected by me deleting knexfile.js

Rebased, as it seems I need https://github.com/backstage/backstage/pull/16327

@benjdlambert Got approve from @Xantier . Anything missing here?


Add Czech locale (cs).

ping @nicolaskruchten

Thanks for this! Sorry for the delay in merging :)


[Marker.io] higher resolutions- av in footer is not scaling properly. there is too much gap between links and this image

Steps to reproduce:
Actual result:
Expected result:

Reported by: vinod<EMAIL_ADDRESS>- Contact via Marker.io
Source URL: https://proav-stg.webflow.io/contact
Issue details: Open in Marker.io
Device typedesktopBrowserSafari 17.3Screen Size3840 x 2160OSOS X 10.15.7Viewport Size3777 x 2033Pixel Ratio@1x

🤖 Marker.io bot - This issue was marked as ✅ Resolved in Marker.io


New version: Faker v0.3.5

Registering package: Faker
Repository: https://github.com/neomatrixcode/Faker.jl
Created by: @neomatrixcode
Version: v0.3.5
Commit: e049eeec6e00ee28c5cac54294afb8c6d9449fe9
Git reference: HEAD
Description: generator of fake data for julia
Release notes:

New features

Faker.ssn() , thanks @aalexandersson
First names with gender-specific , thanks @aalexandersson

Faker.female_first_name()
Faker.male_first_name()
Faker.first_name("F")
Faker.first_name("M")

I'm going to manually merge this PR but the solution to avoid problems with mismatched git tags is to not manually create them and instead use TagBot

I understand, thank you very much


⚠ Samsung has degraded performance

In fcfc6c1, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2634 ms

Resolved: Samsung performance has improved in f08f584.


Daily and Weekly data incorporation

Dear @brandynbok and @eric-qian ,
Thank you for this code. You have done an amazing work.
I am currently trying to incorporate daily and weekly data into the current model. The research paper by Modugno is a bit difficult to understand.
In the code :
You give a tent type structure from quarterly to monthly
r_mat = [2, -1, 0, 0, 0; 3, 0, -1, 0, 0; 2, 0, 0, -1, 0; 1, 0, 0, 0, -1]
Could you explain where this come from and how I can change this for my daily/ weekly model.

Hi @AJKBajwa, thank you for your interest! The tent structure is simply a product of the first order log-approximation of growth rates. Mariano and Murasawa (2003) contains a more in-depth discussion (see https://onlinelibrary.wiley.com/doi/abs/10.1002/jae.695 for details).
In principle, a similar scheme could be used for higher frequencies.


Images are compressed again after being moved

I moved some pics from one directory to another one (from /picgo to /gallery and /cover), and some of these pics are compressed again in the next PR.
I think it is meaningless to compress them again, because the size reduced was quite small and it affects image quality.
I hope this problem can be fixed.
Thank you.

Hello, there are a few config options that might help you in this case: https://imgbot.net/docs/#configuration .
The first one you can try is the ignoredFiles options to exclude the files you don't want to optimize.
You can also use the minKBReduced option to setup a higher threshold for the optimization.
They are both described in the documentation, but feel free to reach out for any questions.

You mean moved images should be manually added to ignoredFiles to avoid being compressed again? It may be fussy.
Is there any way to ignore moved files by reading the move operation in git comments? I think it is a reasonable and neccessary feature.


Small changes to UX

scroll to start or end of graph by pressing right or left arrow key.
get the timestamp of candle by ctrl+click.
show any range of graph (user changeable) when it first loads

Nice, but I'd move the additional code to a mixin (can be placed in src/mixins) to keep the basic app clean & simple.

Nice, but I'd move the additional code to a mixin (can be placed in src/mixins) to keep the basic app clean & simple.


Enable pytype

A few notes:

Fixes type errors detected by pytype.
setup.cfg disables pytype's pyi-error. This is necessary due to incomplete type stubs in https://github.com/python/typeshed.
This only enables pytype's Python3.6 checks. Python2.7 is supported by pytype but incomplete type stubs cause spurious type errors.

These changes do not add, remove or change any part of the API.

I'm going to close this PR for now and see if I can reproduce the Travis error. Sorry for the inconvenience!


Docker hub integration VMware

Use case
Deploy dockers in VMware based infrastructure
http://docs.opennebula.io/5.12/advanced_components/marketplace/market_dh.html

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Evaluate also adding formatted volumes.


Can not get IMU data on Android using D435i

Camera Model  : D435i
Firmware Version: 5.12.1
Platform : Android
librealsense SDK: build 2.31.0
I am trying to get IMU data using D435i camera on android and i get below  error
2019-12-26 14:28:01.323 7311-7377/? I/librs: Motion Module - no intrinsic calibration, Depth Module V2 intrinsic invalidated : Accel !
2019-12-26 14:28:01.324 7311-7377/? I/chatty: uid=10299(com.samsung.id8.caneapp) identical 3 lines
2019-12-26 14:28:01.330 7311-7377/? I/librs: Motion Module - no intrinsic calibration, Depth Module V2 intrinsic invalidated : Accel !
2019-12-26 14:28:01.346 7311-7377/? I/librs: Motion Module - no intrinsic calibration, Depth Module V2 intrinsic invalidated : Accel !
2019-12-26 14:28:01.350 7311-7377/? I/librs: Motion Module - no intrinsic calibration, Depth Module V2 intrinsic invalidated : Accel !
2019-12-26 14:28:01.352 7311-7311/? E/CaneApp: streaming, error: this profile is not extendable to MOTION
2019-12-26 14:28:01.352 7311-7311/? D/InputMethodManager: prepareNavigationBarInfo() DecorView@e341840[MainActivity]
2019-12-26 14:28:01.352 7311-7311/? D/InputMethodManager: getNavigationBarColor() -855310
2019-12-26 14:28:01.352 7311-7311/? V/InputMethodManager: Starting input: tba=com.samsung.id8.caneapp ic=null mNaviBarColor -855310 mIsGetNaviBarColorSuccess true , NavVisible : true , NavTrans : false
2019-12-26 14:28:01.352 7311-7311/? D/InputMethodManager: startInputInner - Id : 0
2019-12-26 14:28:01.356 7311-7377/? I/librs: Motion Module - no intrinsic calibration, Depth Module V2 intrinsic invalidated : Accel !
2019-12-26 14:28:01.361 7311-7377/? I/librs: Motion Module - no intrinsic calibration, Depth Module V2 intrinsic invalidated : Accel !
2019-12-26 14:28:01.362 7311-7377/? I/librs: Motion Module - no intrinsic calibration, Depth Module V2 intrinsic invalidated : Accel !

Apologies that you did not receive a response to your question before now.
The ability to access IMU data with a D435i on Android was added in RealSense SDK version 2.26.0 in August 2019, so you should have been able to access it with the SDK version 2.31.0 that you were using in December 2019.
https://github.com/IntelRealSense/librealsense/pull/4605
Are you still experiencing this problem please with the current RealSense SDK version, or can this case be closed?  Thanks!


Incorrect Markdown Formatting in Extracted Content

I encountered an issue with the markdown formatting in the extracted content when using the crawl4ai library. The image markdown syntax seems to be incorrectly escaped, leading to improperly formatted images in the output.
![\\"Nobel](\\"https://photo2.tinhte.vn/data/attachment-
files/2024/10/8480950_giai-thuong-nobel-ai-su-mo-nhat-va-tinh-thuc-
tien.jpg\\"/)

Expected:
![Nobel](https://photo2.tinhte.vn/data/attachment-files/2024/10/8480950_giai-thuong-nobel-ai-su-mo-nhat-va-tinh-thuc-tien.jpg)

Steps to Reproduce (ipynb file)
import asyncio
from crawl4ai import AsyncWebCrawler

async def main():
    async with AsyncWebCrawler(verbose=True) as crawler:

        result = await crawler.arun(url="https://tinhte.vn/thread/tren-tay-chuot-carbon-rog-harpe-ace-extreme-chi-47-gram-gia-hon-6-trieu.3837734/",
        css_selector="#__next > div.jsx-2814768367.thread-view > div > div.jsx-3437297739.threadpage.false > div.jsx-3437297739.section.bg-white.false > div.jsx-3437297739.fst.false > div > div > div.jsx-1103166024.thread-view--content-wrapper > main")

        print(result.markdown)

# Check if an event loop is already running
if not asyncio.get_event_loop().is_running():
    asyncio.run(main())
else:
    await main()

This is my local fix :

Thank you for your hardwork.

@truonghoangnguyen  Thank you for using Crell for AICrawl4ai. Actually, you pointed out something interesting. We spotted the issue and we already fixed it. The new version (0.3.6), which will be released tomorrow, will fix this as well. We converted to mock down before sanitizing the string. And in this version, everything is good. I tested with your link. I'll paste a picture here so you can see how it goes. Again, thank you so much.


Networking: Rename cnci-agent to ciao

Rename cnci agent to ciao-cnci-agent. Also update systemd scripts.

@mcastelino there are a couple of bugs in 2293e2e.
Sending a pull request now


Znpcs hook enabled without usage of Znpcs

What is your Quests version / build number (do not say "latest")?
Quests-5.0.0-rc.3
Describe the problem and how to replicate it.
I am not using Znpcs, but the hook and its processes are still enabled and visible in spark report

Any console errors to share?
[11:12:40] [Server thread/ERROR]: [Quests] ZNPCsPlus was enabled but NpcApiProvider was null. Disabling linkage.
[11:12:41] [Server thread/ERROR]: [Quests] Failed to register events for class org.browsit.mythicmobsquests.MythicMobsItemDeliverObjective because io/github/znetworkw/znpcservers/npc/interaction/NPCInteractEvent does not exist.

If applicable, can you provide an example quest from quests.yml?
No response

@PikaMug problem was solved in this build, but still occurs in the newest one on Spigot (and the new dev builds)

@PikaMug problem was solved in this build, but still occurs in the newest one on Spigot (and the new dev builds)

Please open a new ticket with a spark report created from the Spigot release. Thanks!


Feature: Content moderator should be able to insert a booth for sponsors

Not sure if this is tackeld somewhere else or a new feature. But Your Surprise for instance has a booth within it's gold package however I am not able to add it for them. Same for for instance the silver and brons packages.. I can now only see the companies applying for a booth which makes it an incomplete list of booth owners.

Closed in #283


[BUG] Logfile name uses wrong elements in timestamp

Describe the bug
The generated logfile name was intended to use a name like <timestamp>.<service>.<action>.log. The timestamp format was specified as yyyy-MM-dd-HH.mm.ss. However, this is wrong when used in DB2 VARCHAR_FORMAT SQL function:

mm does not specify minutes, but instead means month. To get the minutes, the mi specifier should be used.
HH specifies 12 hour format, where it probably should be 24 hour format HH24.

To Reproduce
Check the logfiles generated by the current version of Service Commander.
Expected behavior
Verbose output
Run the command with the -v option and share the output here.
Additional context
Add any other context about the problem here.

Resolved by #204. Thanks!


Add a functionality that will allow a single handler to interact with multiple IdentityProviders

Currently only a single IdentityProvider is serviced at a time. This requires multiple handlers with either a different endpoint per IdentityProvider (via RedirectUri) or catching validation exceptions, understanding the exceptions should be pushed to the next handler and coding it up.
It would be much better if there was multiplexing on the identity providers.
For example, find a handler that can deserialize the token, then find the appropriate keys etc, then continue.

Closing as this belongs in a different assembly.


Support Go-style artifacts for Windows.

Go uses 386 and amd64 to target 32-bit and 64-bit architectures, respectively. This change includes these as artifacts for Windows targets.
Depends on #48. Not sure how stacked PRs work. 👍 🔥 💥

It appears I am required to sign a CLA in order for this PR to be merged, which I will not be doing. Someone else is free to make this change if they desire.


Fix all issues related to continent

Solve the following issues:

#73
#74
#75
#76
#78
#79
#80
#81
#82
#83
#84
#85
#86
#87
#88
#89
#90
#91
#92
#93
#94
#95
#96

Hi @StEvUgnIn
Thank you for taking your time to update the incorrect continent information! It seems there were numerous errors occurred when we switched the data source to OpenAlex last year.
I will apply the changes right away :)


add dependabot configuration

See https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/

Can we go to weekly instead of daily?

I do agree, this is aggressive.
can we configure to have a notification instead of opening a PR automatically ?

As a side note, I sent this same PR to most of the other modules, so when we agree in a configuration, I can update them
Thank you!

let me review the other config options before

I think we want at least to set a few dependencies we want to ignore like jackson or guava, because we update those and we are aware of CVEs related to them quickly. In addition such dependencies are never updated autoomatically in our stack because we want to do it at once otherwise it would create conflicts with transitive closure.

we just need to define the set of black listed dependabot dependencies here before and then you update this PR accordingly and update the other PR's

here is the start of a list of dependencies we want to exclude:

guava
jackson
netty
loggers

here is the start of a list of dependencies we want to exclude:
* guava

* jackson

* netty

* loggers

@vietj I updated the configuration with your suggestions


masking clean commit

This is a PR to allow for easy MASKing of strings within the data. Examples are included.

@Jeffail can this be approved please or does it need changes?


Where do icons go?

I made an icon for a language on http://exercism.io/languages that doesn't have one yet. I don't see a place for it to go in the language's github repo; where should I send this so someone can review it and add it to the site?

It didn't occur to me that http://exercism.io itself is actually hosted on github. I found where to put the pull.

Cool. Eventually we should probably stick this in each of the track repositories... I just hadn't thought that far.


Add parent to context

This would allow a markdown file to link to its parent directory.

Ended up making a parent filter for this functionality.


expose emoji unicode regexp that is internally used for emoji parsing…

expose emoji unicode regexp that is internally used for emoji parsing (read only)
This can be useful for advanced usage not to add extra package with emoji regexp, when it's already contained in and used in twemoji package.
Consider this example - I have extension for CodeMirror to replace emoji, but I have to know exactly where emoji were found in text and should be replaced with images for CodeMirror api. Of course I can parse string and then search for  tags, and then strip them to restore original positions, but it seems like overhead when all I need is regexp and it's already contained in library (just in private section).
function CodeMirrorEmojione (cm) {
  return CodeMirrorReplace(cm, window.emojione.regUnicode,
                           window.emojione.unicodeToImage)
}

function CodeMirrorTwemoji (cm, options) {
  return CodeMirrorReplace(cm, window.twemoji.re,
                           text => window.twemoji.parse(text, options))
}

function CodeMirrorReplace (cm, regex, toHtml) {
  function createElement (text) {
    const html = toHtml(text)
    if (typeof html !== 'string') return html
    const span = document.createElement('span')
    span.innerHTML = html
    return span.firstChild
  }

  function replaceMatch ([line, ch, text]) {
    cm.markText(
      {line, ch},
      {line, ch: ch + text.length},
      {replacedWith: createElement(text)}
    )
  }

  function findMatches (fromLine, fromCh, lines) {
    const matches = []
    let match
    lines.forEach((line, lineIndex) => {
      // eslint-disable-next-line
      while (match = regex.exec(line)) {
        matches.push([
          fromLine + lineIndex,
          (lineIndex ? 0 : fromCh) + match.index,
          match[0],
        ])
      }
    })
    return matches
  }

  findMatches(0, 0, cm.getValue().split(cm.lineSeparator())).map(replaceMatch)
  cm.on('change', (cm_, change) => {
    findMatches(change.from.line, change.from.ch, change.text).map(replaceMatch)
  })
}

P.S. I didn't regenerate sources to make pull request looks more clean

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'd recommend using https://github.com/twitter/twemoji-parser for this use case


Fix no releases yet in the repo

After merge, test on https://github.com/amitsingh-007/test-next-release-tag and then delete it


iOS List apps error

Electra Jailbreak on iOS device (11.3.1).
I connected the device and when I try to run list_apps the following error appears below:
scrounger misc/list_apps > run
2018-08-30 11:46:57 -                         device : running: which listapps
[-] Exception: listapps binary not found.

scrounger misc/list_apps > 2018-08-30 11:51:57 -                         device : ssh session killed

That's because you've not pushed / installed the bundled binaries in the device.
Try running misc/ios/install_binaries first and then the misc/list_apps again.
Let me know if it worked fine.

Thank you, this worked now as I was able to list the apps now.


Extract crashes when .cbin does not have associated .not.mat file

Thanks @senakoko.
Fixed this with commit f0ef1af3767defd26666eb483723f1d0d15a2811.
I'll need to update the package on Anaconda cloud and you'll need to reinstall before it works for you. In the meantime the workaround of just putting .cbins without .not.mats in a subfolder should work.


Cursor doesn't work; Very dark screen; No internet connection

Three issues:

On boot, after half of the loading bar passes, the screen is VERY dark (almost impossible to see anything).
Neither touchpad nor a USB mouse connected via WD19TB or USB-A adapter works, but I'm able to navigate the menu via keyboard.
(Most importantly) There's no internet connection from WD19TB and I'm not able to set up WiFi because of the cursor issue. I'm unable to continue the installation without internet.

For USB creation I'm using:
`
Catalina(10.15)
python ./macrecovery.py -b Mac-00BE6ED71E35EB86 -m<PHONE_NUMBER>0000000 download
`
Has anybody found a fix for any of the mentioned issues?

For ones that were having same issues:

Very dark screen fix: Wait LONGER (up to 10 mins). Only laptop screen is so dim. If you plug the external display it's normal.
Same thing with touchpad/mouse - you need to wait REALLY long.
Wifi also works after waiting few more minutes after the display stops being dim.

For dark screen and mouse wait use that:
https://github.com/acidanthera/WhateverGreen

@Krzysztof-Dziardziel
Don't have theses issues with my 9500 everything is working eine with big sur

I wasn't able to upgrade to big sur. Had to reinstall Mojave once more - when upgrading to big sur about 1/3 of the progress bar loaded and then nothing happened. Have you changed anything between the versions?

I had See you has different cpu,
I had Changed a Lot zachs didn't responsed here for auch while...
My Machines Use an 10750h processor
You could give it a try if you also have an uhd 630 graphics

I have the same GPU. I will try your solution :)
Should I do a clean install or can I just boot into system upgrade with your kexts?

Prefer a Clean install

Thanks. I will update soon! :)


Support for use_sim_time = false

What are your thought about running the bridge with use_sim_time false? Would you be open for a PR like this: https://github.com/gazebosim/ros_gz/pull/545
Please give me your thoughts.
Thanks!

Could you elaborate on the purpose for this? ros_gz is meant to be used with Gazebo, so I would think use_sim_time would always be true, but maybe there are other use cases?

Sure, we have two reasons for this:

When running a gazebo instance in a hardware in the loop set-up, some other nodes in the ros2 graph require real timestamps in order to function
Subscribing to the /clock topic for each running node in our ros2 set-up, introduces a lot of CPU load, especially for the python processes. This is more related to the performance of ros2 but in some cases and on some platforms, we can only run proper simulations if we set use_sim_time to false.

Any thoughts @azeey ?

Those seem like good reasons to me. My only concern is that we don't break any existing users since use_sim_time is assumed to be true for ros_gz by default. Is there a way we can ensure that the parameter is true if not set explicitly by the user?

Thanks for your reply @azeey , I don't think we can and I don't think we should modify the default node behavior:
https://github.com/ros2/rclcpp/blob/343b29b617b163ad72b9fe3f6441dd4ed3d3af09/rclcpp/src/rclcpp/time_source.cpp#L257
Here the parameter is set to false by default.
This line:
https://github.com/nobleo/ros_gz/blob/714660e86e9b4e7ff60c1ce46bbc43a54d8a6bd3/ros_gz_bridge/src/bridge_handle_gz_to_ros.cpp#L74
will simply ask the node whether the simulation time is active.

Well, that would be a blocker then since it will likely break existing users. What about using additional parameter or environment variable to enable checking use_sim_time?

What about adding indeed an additional parameter, e.g. use_wall_time that defaults to false and log a warning when it is conflicting with node->ros_time_is_active()? In order to supress this warning, the user should align these two parameters, either:

use_wall_time=true, use_sim_time=false
use_wall_time=false, use_sim_time=true

And in the implementation, we use the value of the use_wall_time_parameter. What do you think?

Or make this new behavior default as per ROS2 Jazzy. As breaking changes are typically allowed between distros.

ping @azeey

The job of the bridge is to convert messages from Gazebo to ROS. It shouldn't really have its own concept of time. The timestamps are provided by Gazebo. Overwriting this timestamp with some other value should be an opt-in, so I would not be in favor of changing the current behavior. I would support adding a use_wall_time parameter, better yet, a override_timestamps_with_wall_time parameter. But I don't think it should give a warning in the default case, but your suggestion seems like it would, i.e, the default is override_timestamps_with_wall_time=false, use_sim_time=false. Do we really need to align the parameters? Can we not simply check override_timestamps_with_wall_time?

For me just adding the override_timestamps_with_wall_time parameter is fine. Thanks for your elaborate reply. I will update my PR accordingly and publish it.


added Difficulty events

What feature do you want to get added on the base engine?
:/ I just wanted change each difficulty events had different event (Like Accelerant Hank for FUCKED)
example:
normal  = events
easy = events-easy (if you want the easy version events)
hard = events-hard
custom = events-your-custom-difficulty
To test your sight, and reliability, please select the option of what should NOT be requested.
A good idea

here take this now close this
function onEvent(name, value1, value2)
	if name == 'example_name' then
		if difficulty == 2 then --if difficulty is hard
			--code only for hard
		elseif difficulty == 1 then --if difficulty is normal
			--code for normal
		elseif difficulty == 0 then --if difficulty is easy
			--code for easy
		end
	end
end

i think it would be a good idea. I'll try to code it at source

switch(varname) {

    case 1:
        //normal code

        case 2:
            //hard code

            case 0:
                //easy code

}

i literally have no life XD

switch(eventname) {

    case 'YOUREVENTNAME':
        switch(difficulty_varname_idk)
        {
            case (2): // hard
            // hard mode code

            case (1): // normal
            // normal mode code

            case (0): // easy
            // easy mode code

        }

}

idk the name of the difficulty var so just find it

you can already do that, just dont save the events as events.json, its saved in the json file if has events

One I somewhat want this but more like events then a second one that only works on curtain difficulties

you can already do that, just dont save the events as events.json, its saved in the json file if has events

true

You can already load difficulty specific events by saving the events on the same chart as the notes chart. (Simply don't clear your events).

You failed the test, congratulations.


Updated documentation of getDerivedStateFromProps

Renamed parameters to be more informative

I took myself the time to make the change proposed in #925, in case it gets accepted.

This was just changed: https://github.com/reactjs/reactjs.org/pull/910


Refactor Check Result Messages

Refactor Check Result Messages to use the check catalogue service that pulls the results from the database
The query for the checks I showed...
select *
from camdecmpsmd.vw_qa_certification_api_check_catalog_results
where "checkTypeCode" = 'IMPORT'
and "checkNumber" = 14
order by "resultCode"
Testing
For regression testing Need to confirm that all of the Check Messages are correct for the following test types:
linearity-injection-checks
linearity-summary-checks
rata-checks
test-summary-checks

Errors are firing

Vishnu will put together a list to make more targeted tests to check


bootstrap3 edit view broken on smaller screens

This probably applies not only to the edit view, but our main gripe is with that.
https://github.com/flask-admin/flask-admin/blob/master/flask_admin/templates/bootstrap3/admin/lib.html#L104 (what worked for me was adding col-xs-5 aside col-md-2 and a bunch of CSS to preserve alignment, etc.)

Here's a screenshot of the edit view on a smaller screen: http://i.imgur.com/FeWfg2B.png
It looks fine to me. Can you show a screenshot of your issue?

Oh, this is very embarassing. I accidentally broke it all myself.
Sorry!


Add examples

Having some examples in the repo would be useful for new developers

A PR would be appreciated. Preferably using an Example function in a test file.


fix: Expose the experimental server to the same URL as Beerus

The experimental server expose its JSON-RPC interface at the path /rpc while Beerus does that at the root path.
This PR makes the experimental server use the root path as well so both behaviors are consistent.

I'm not sure what is the purpose of this change.
I was imagining that experimental server might serve the page that exposes WASM-based Beerus implementation on the / endpoint, then maybe some user-friendly documentation in /docs and in such setup serving RPC from separate endpoint (e.g. /rpc) makes sense to me.


Create description component

Fix #924.

Merging into main!
Thank you @juyeongk365 for this PR. Whenever you get the notification if it's approved, feel free to squash and merge. I did it for you this time!


Trim districts to water

To avoid:

Sorry, merpeople.

Also, separately, need to throw out any districts that have IDs ending with ZZZ, as those are water-only placeholders.


Language localization for Bangla language

I'm submitting a ...

[ ] feature request

Do you want to request a feature or report a bug?

feature request

What is the current behavior?

There are no Bangla language option on language drop-down

What is the expected behavior?

Expect Bangla option on language drop-down

What is the motivation / use case for changing the behavior?

Language localization for Bangla language

Other information

I am interested to develop the feature

We decided to drop language support. Too easy to translate via external tools.


Postinstall breaks when package.json is missing (for instance on a pnpm fetch)

Describe the bug
It appears #6949 broke pnpm fetch when no package.json is present.
In the context of a Docker build like the following:
FROM node:18 as builder
RUN corepack enable
WORKDIR /workspace
# Step 1
COPY pnpm-lock.yaml ./
RUN pnpm fetch
# Step 2
COPY package.json ./
RUN pnpm install --frozen-lockfile --offline
# [...]

where Step 1 can be cached as long as pnpm-lock.yaml stays the same, even if package.json changes (for instance on a config or script change that does not require package re-install).
But from what I understand it means when postinstall is run in pnpm fetch, it doesn't have access to a package.json file.
Reproduction
In any SvelteKit repo, create the lock file by running install:
pnpm install

Remove the installed packages and the package.json file:
rm -r node_modules/ package.json

Now, running pnpm fetch will fail on versions 1.0.0-next.495 onward (Logs provided below).
Logs
<EMAIL_ADDRESS>postinstall$ node install.js
<EMAIL_ADDRESS>postinstall: Done
.../node_modules/@sveltejs/kit postinstall$ node postinstall.js
.../node_modules/@sveltejs/kit postinstall: node:fs:599
.../node_modules/@sveltejs/kit postinstall:   handleErrorFromBinding(ctx);
.../node_modules/@sveltejs/kit postinstall:   ^
.../node_modules/@sveltejs/kit postinstall: Error: ENOENT: no such file or directory, open 'package.json'
.../node_modules/@sveltejs/kit postinstall:     at Object.openSync (node:fs:599:3)
.../node_modules/@sveltejs/kit postinstall:     at Object.readFileSync (node:fs:467:35)
.../node_modules/@sveltejs/kit postinstall:     at file:///workspace/node_modules/.pnpm/@sveltejs+kit@1.0.0-next.499_svelte@3.50.1+vite@3.1.3/node_modules/@sveltejs/kit/postinstall.js:10:27 {
.../node_modules/@sveltejs/kit postinstall:   errno: -2,
.../node_modules/@sveltejs/kit postinstall:   syscall: 'open',
.../node_modules/@sveltejs/kit postinstall:   code: 'ENOENT',
.../node_modules/@sveltejs/kit postinstall:   path: 'package.json'
.../node_modules/@sveltejs/kit postinstall: }
.../node_modules/@sveltejs/kit postinstall: Node.js v18.9.0
.../node_modules/@sveltejs/kit postinstall: Failed
 ELIFECYCLE  Command failed with exit code 1.
The command '/bin/sh -c pnpm fetch' returned a non-zero code: 1

System Info
System:
    OS: Linux 5.15 Ubuntu 20.04.5 LTS (Focal Fossa)
    CPU: (16) x64 AMD EPYC 7B13
    Memory: 26.52 GB / 62.80 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 18.8.0 - ~/.nvm/versions/node/v18.8.0/bin/node
    npm: 8.18.0 - ~/.nvm/versions/node/v18.8.0/bin/npm
  npmPackages:
    @sveltejs/adapter-node: 1.0.0-next.95 => 1.0.0-next.95
    @sveltejs/kit: 1.0.0-next.499 => 1.0.0-next.499
    svelte: ^3.50.1 => 3.50.1
    vite: ^3.1.3 => 3.1.3

Severity
annoyance
Additional Information
No response

This is confusing behavior on pnpm's part.
from https://pnpm.io/cli/fetch

Fetch packages from a lockfile into virtual store, package manifest is ignored.

That description does not read like it would be calling postinstall hooks.
Maybe it is to populate the "side effects cache", so as a workaround disabling that via npmrc might help https://pnpm.io/npmrc#side-effects-cache
One possible fix for us would be to wrap the postinstall code in a try/catch to ensure it always exits with 0.

One possible fix for us would be to wrap the postinstall code in a try/catch to ensure it always exits with 0.

That might be a good idea in general. Since it's just to generate types that would get generated the first time the user ran dev or build anyway, having the types be missing (perhaps with a quiet warning message) sounds pretty much always better than making the install fail.

install fails for me since #6969 in a monorepo using turbo and yarn. Here's the error I get:
yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
[5/5] Building fresh packages...
[1/2] ⠈ @sveltejs/kit
error /home/user/src/monorepo/node_modules/@sveltejs/kit: Command failed.
Exit code: 1
Command: node postinstall.js
Arguments:
Directory: /home/user/src/monorepo/node_modules/@sveltejs/kit
Output:
file:///home/user/src/monorepo/node_modules/@sveltejs/kit/postinstall.js:15
	for (const directory of pkg.workspaces) {
	                            ^

TypeError: pkg.workspaces is not iterable
    at file:///home/user/src/monorepo/node_modules/@sveltejs/kit/postinstall.js:15:30

my root package.json is configured like follows:
	"workspaces": {
		"packages": [
			"packages/*"
		]
	},

@sveltejs/kit is a devDependency in one of the packages.

@gaarf When is workspaces not an array of strings? I can't find any examples of that anywhere. This is Yarn's documentation...

...and this is Turborepo's:

On second thoughts @gaarf can you create a new issue for this please? It doesn't belong in this one, which is about not running postinstall when package.json is missing

@Rich-Harris will do. I changed our workspaces to an array in my project to solve the install failure issue, did not seem to matter in this project. Others may be affected tho, here's a reference to the pattern: https://classic.yarnpkg.com/blog/2018/02/15/nohoist/

Ah, gotcha. I added handling for that case in #6998


Use the same fontsize for Compare version widget

The compare version widget uses a smaller font size than all other components in the toolbar. (14 vs 16px)

Hey team! Please add your planning poker estimate with ZenHub @andraskvr @bartv @Stijnkool


General improvement of QC module

See: https://sourceforge.net/p/spinalcordtoolbox/discussion/help/thread/b97dd880/?limit=25
To evaluate the state of the QC module, run the following: ./batch_processing.sh. And at the end, run sct_qc as explained.
Use this QC for more functions.

sct_deepseg_gm
sct_deepseg_sc

Added sct_deepseg_* qc calls.
As for the "general improvements"... not sure what to do at this point. qc is called inside a module's main function, to generate (for smoke-testing purposes) a pair of background/overlay images and append some execution context information in a JSON file. Then there's a simple web GUI, which is pretty explicit as to what it does.
I'd propose to refactor the code, to allow each process to expose how it would be performing generation of smoke-testing data (as is done now) as well as A/B-testing by using common code (see #1603 about "diff reports"... the generated data could be included in these reports... a refactoring could deal with all these related issues).

Fixed by #1647


vue map libre

Hello,
First of all, thanks to the team for maplibre js (and thanks to mapbox too btw).
I worked on a lib for vue 3, if you are interested I can update the cd to deploy to npm
Demo: https://atlastories.app.gitlab.io/vue-maplibre
Repo: https://gitlab.com/atlastories.app/vue-maplibre

Yes true there is already a vue 3 plugin, it lacks of v-model (two way binding props) and I am not really sure the props are truly reactive, meaning that if you change the value of a layout property the method setLayoutProperty won't trigger. That's why I coded another one. Just another happy mess in js.
I wanted to simplify the props so i prefered to cut down the 'layout' and 'paint' properties so the component observe change on each prop.
instead of  (from the existing lib)
here it s  that's the opinionated part.

Does the library you have has a npm package?
Why not fork an existing one (for example vuemabox) and adjust it to maplibre?
I'm maintaining ngx-maplibre-gl but I did not create it from scratch as it has a lot of quirks when it comes to 2 way binding with layers and sources when removing and adding those.
In any case, as I said, I'm good with adding it here.

for now it s not published on npm, only in the gitlab registry https://gitlab.com/atlastories.app/vue-maplibre/-/packages/11321276
I contacted the author of vue-maplibre-gl.
Good question, about forking vuemapbox, I wanted to learn the maplibre/mapbox api rather than finding the diff/adapting. Also I tend to prefer the <script setup> syntax for vue3 components and it s probably a shitload of work to remove all the this. from vue-mapbox

@vdcrea if @atlastories/vue-maplibre was public on npm, then it could be added. Seems to be private.


Popover wrapper

Description
Provides new feature - Inline popover mode for pickers. Also provides some code reorganization

Do you feel comfortable maintaining ts types separately? It's forced you to make too deep folders.

@TrySound I am actually ts fan but I have no time to completely rewrote to typescript this lib

@TrySound after updating babel runtime I am steel seeing errors with es modules umd build
(!) Unresolved dependencies https://github.com/rollup/rollup/wiki/Troubleshooting#treating-module-as-external-dependency @babel/runtime/helpers/builtin/interopRequireWildcard (imported by commonjs-external:@babel/runtime/helpers/builtin/interopRequireWildcard, <EMAIL_ADDRESS>...
(!) Missing global variable names Use output.globals to specify browser global variable names corresponding to external modules ...

It seems like you still have old transform-runtime in your node_modules

@TrySound thanks, your advice was really helpful 👍


[Central] Question input is difficult

It is difficult to properly enter a question using the game creator on central. Additionally, when a question is answered verbatim, there are a number of issues with the question content on the backend that prohibit the game from launching correctly. These are:

In choices, false answer fields don't contain "isAnswer": false
Any apostrophes require double apostrophes as an escape character.

Hi Zach,
I wanted to come back to this to add in a bit more detail. I think as you're working on this, you'll run into a couple issues.

you won't be able to get questions added to the games, or games created. Clicking the create game button won't do anything. I think predominantly, this is related to having an apostrophe in any of the text fields. When you escape that character by adding in another apostrophe, the game should create ok. In RDS on the backend, you can see this more clearly.

If I'm trying to update the description of the pizza game and don't escape characters you can see that the string isn't correctly being parsed here:

But when I escape the apostrophes with an additional single quote:

You can see that the string is being parsed correctly and the command can be run.
So I think one task for the question creation screen will be to automatically escape any apostrophes in the string with an additional single quote.

If you get all the information added correctly into a game with questions, you'll sometimes still not be able to launch a game. When the game launches, it will just hang. I've found that once the apostrophes are escaped, this is caused by the choices object not being generated correctly.

In RDS, you can see when we first create a generic question, the choices look like:

Note here that only the correct field receives an isAnswer value. If we were to try to launch this game it would hang, however, if we set the choices field so that each answer got an isAnswer value, it will launch properly. Like so:

So the second part of the task will be to ensure that when we are generating questions, the choices object is being created properly.
I've found that when I resolved these two issues (on the back end at least) I could reliably get games to populate on the game explorer page and launch consistently.


BUG:many modules of this library aren't working eg.: imdb , crckbuzz,  Rankings,Academia,BBC News

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
When importing these libraries from the module they are running into import error I ran them on my pc and on a kaggle notebook and they are running into same error.(I have attached the screenshot of the error.)

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a Hacktoberfest'23 contributor
[X] I want to work on this issue

Because they are not yet on PyPi.
This is not a bug, I will update the package on 15th October.


Bot Emulator: feedback from students to clarify steps

Module: 07
Lab/Demo: Create a Bot with the Bot Framework SDK
Fixes # .
Changes proposed in this pull request:

Clarify some steps, many think the emulator is a website

Thanks @unaihuete93


Returned nmrium.json schema is not complaint with new schema

Received:

Expected:
{     "data" : {         "source" : [],         "spectra" : [             {                 "selector": {}             }         ],         "molecules" : []     },     "version": 4 }

Closing this as this issue is related to the nmrXiv data structure


Can't update, says on read only volume

Issue Type: Bug
VS Code says it's on a read only volume and can't update. It's not.

VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-11T01:11:34.018Z)
OS version: Darwin x64 20.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
4, 3, 3

Memory (System)
16.00GB (0.11GB free)

Process Argv
--crash-reporter-id 69f7fc60-9d49-4aa3-994a-ae8107e76b0c

Screen Reader
no

VM
0%

Extensions: none

So...just downloaded the new versions, put them in my Applications folder (stable and insiders).
Insiders has the same problem...but stable works now?
Stable: 1.52
Insiders: 1.53

So...just downloaded the new versions, put them in my Applications folder (stable and insiders).
Insiders has the same problem...but stable works now?
Stable: 1.52
Insiders: 1.53

The application is very likely in quarantine, which the this link explains. Follow the link for resolution. Let me know how this goes.

The application is very likely in quarantine, which the this link explains. Follow the link for resolution. Let me know how this goes.

I've tried running:
sudo chown $USER ~/Library/Caches/com.microsoft.VSCode.ShipIt/*
xattr -dr com.apple.quarantine /Applications/Visual\ Studio\ Code.app

But I get
zsh: no matches found: /Users/arturogoicochea/Library/Caches/com.microsoft.VSCode.ShipIt/*

Not sure what steps to try next.
Also, at least in my case the message is confusing as the app is not in a read only volume.

I've tried running:
sudo chown $USER ~/Library/Caches/com.microsoft.VSCode.ShipIt/*
xattr -dr com.apple.quarantine /Applications/Visual\ Studio\ Code.app

But I get
zsh: no matches found: /Users/arturogoicochea/Library/Caches/com.microsoft.VSCode.ShipIt/*

Not sure what steps to try next.
Also, at least in my case the message is confusing as the app is not in a read only volume.

xattr -dr com.apple.quarantine /Applications/Visual\ Studio\ Code.app

This is the important step. Run that one.

Also, at least in my case the message is confusing as the app is not in a read only volume.

The message is correct. When apps are in quarantine, macOS runs them from a read only volume.

xattr -dr com.apple.quarantine /Applications/Visual\ Studio\ Code.app

This is the important step. Run that one.

Also, at least in my case the message is confusing as the app is not in a read only volume.

The message is correct. When apps are in quarantine, macOS runs them from a read only volume.

Thanks! As it was Insiders, I did (and it worked):
xattr -dr com.apple.quarantine /Applications/Visual\ Studio\ Code\ -\ Insiders.app

Still, I wouldn't have guessed my app was in quarantine, which means it is run from a read only volume. This feels like a UX problem.
CC: @misolori, what do you think?

Thanks! As it was Insiders, I did (and it worked):
xattr -dr com.apple.quarantine /Applications/Visual\ Studio\ Code\ -\ Insiders.app

Still, I wouldn't have guessed my app was in quarantine, which means it is run from a read only volume. This feels like a UX problem.
CC: @misolori, what do you think?

Hmm...I'm not sure it's obvious that "read-only mode" means the app is in "quarantine", which I've personally never heard before. My first guess would be that my app is in Downloads, and if that wasn't the case then I would assume that this is a bug and wouldn't click on the link because it wouldn't apply to me. Feels like the language could be improved to mention this? Something like:
...The application is either in a read-only volume or in quarantine mode. See our docs to get your application out of this mode."

Hmm...I'm not sure it's obvious that "read-only mode" means the app is in "quarantine", which I've personally never heard before. My first guess would be that my app is in Downloads, and if that wasn't the case then I would assume that this is a bug and wouldn't click on the link because it wouldn't apply to me. Feels like the language could be improved to mention this? Something like:
...The application is either in a read-only volume or in quarantine mode. See our docs to get your application out of this mode."

This is exactly why we have the link:

This is exactly why we have the link:

My main point is if you believe your volume isn't read only then you wouldn't click the link because it doesn't apply to you.

My main point is if you believe your volume isn't read only then you wouldn't click the link because it doesn't apply to you.

OK, I've improved the message. 👍

OK, I've improved the message. 👍


Add feature to scan DB schema to detect potential misconfiguration

This would be very helpful for compliance. See #109 for some context.

This is being looked at by @sou-chon


How to use filter  ?

I need filter if STATUS = 5
$.result[*].[STATUS=5]

Haven't tested it, but I think you should be able to use the ? operator to filter results.
For an array like this:
{
  "result": [
    {
      "name": "Foo",
      "status": 5
    },
    {
     "name": "Bar",
      "status": 3
    },
  ]
}

You could write this:
<EMAIL_ADDRESS>== 5)].name

to get this:
["Foo"]

thk! is working!


Adding a Predicate

I'm attempting to swap out @Query in SwiftUI for @SectionedQuery. It works beautifully without a predicate, but I can't figure out how to add a predicate which updates in response to searchTerm
    @State private var searchTerm = ""

    @SectionedQuery(sectionIdentifier: \MyObject.id ,
                        sortDescriptors: [
        SortDescriptor(\MyObject.property1),
        SortDescriptor(\ MyObject.property2)
    ],
           animation: .smooth
    )
    var sections

    // stuff

    List {
        // my list consuming sections
    }
    .searchable(text: $searchTerm)

Figured it out!
List {
    // list code
}
.onChange(of: searchTerm) {
    togglePredicate()
}

@MainActor
func togglePredicate() {
    guard !searchTerm.isEmpty else {
        sections.predicate = nil
        return
    }

    sections.predicate = #Predicate<MyThing> {
        $.someProperty.localizedStandardContains(searchTerm)
    }
}

Adrian, thanks for the feedback.  I had already started preparing to add this function to the demo project for you when you posted your solution.
BTW, I was surprised to see that the #Predicate macro gets a compile error when prepending "self." to searchTerm in the call to Contains().  Am I missing something or does this seem to be a bug in the #Predicate macro?
FYI, you also left off the '0' after the '$' in your comment.
Thanks again.


[ DARK MODE ] fix nav

when I switch to dark-mode, navbar remains as it was in light-mode. this should be fixed.
current behaviour: nav-bar with light background in dark-mode
expected behaviour: nav-bar with dark background in dark-mode

Can I work on it?

would be happy to fix this


Analytics and Tools for developers (publishing tools)

I'm going to close this as out of scope for this tooling. Anything in this regard will likely roll into another initiative/repo.


Port to Python3 and Qt5 + others

Hey there,
Not an issue, more of a pull suggestion :-)
Just wanted to let you know that I did bit of work on a branch over here: https://github.com/beville/comictagger
I started off just wanting to get the setup.py installer working again, and ending up doing a port to Python3 and PyQt5, neither of which was very much work.
I also added configuration for the unrar library to the GUI and the settings.  Not an issue for the binary distros, but handy if you're just running form source.
If you're interested in merging, let me know, and I'll help if I can.  If not, no worries!
More details are on the README at the "py3qt5_dev" branch.
Thanks for all the work you've done on this project!

@beville You should already have push access to the main repo, so feel free to push the new branch there :-)

I pushed the new branch here and updated the windows build script used by appveyor: upgrading to python3 and qt5 is definitely a life saver. Here's the latest build: https://ci.appveyor.com/project/davide-romanini/comictagger/build/1.0.39/artifacts
I still have some problems though:

the windows build made with pyinstaller seems to use a vintage qt theme from the 90's.. Maybe it's related to this pyinstaller issue, https://github.com/pyinstaller/pyinstaller/pull/3439 I need to double check. It doesn't happen when launching locally with python.
reading rars doesn't work out of the box (it works when launghing locally with python)
there's that nasty problem reading images behind ssl

After solving these problems I hope to merge to whole thing into develop and create a new release.

Cool.
Sounds like you are seeing the same style problem under Windows that I saw on my Mac.  It was definitely solved by getting a pre-release of pyinstaller as referenced in the answer here: https://stackoverflow.com/questions/48626999/packaging-with-pyinstaller-pyqt5-setstyle-ignored.   I didn't need to do anything special on Windows, though, just generic pip installs. Unfortunately, my windows laptop is at the repair shop now, so I can't reference it.
With respect to your unrar issue:  I never actually never got my Windows mingw libunrar build working, so just worked around it with my brief attempt at the Windows pyinstaller build.
The new settings tab for RAR will hide the unrar library selection GUI controls if the app finds libunrar.so in the comictagger module folder (or in sys._MEIPASS in the case of the bundled exe). So if you do see those GUI controls, that means that that file isn't there in the exe.   Based on the your original code that looks for the library, I was assuming that even under Windows, the binary file will be called "libunrar.so".  Is that still correct?  Hopefully this helps, and it's something simple!

I finally merged the branch in develop. I also released a windows version. Unfortunately I don't have access to a mac anymore, so I cannot build and test the osx version. I think we're making some little progress, so I close this one at least. Thanks for your work.


Add GlitchSecure to list of Penetration Testers

This PR adds GlitchSecure to the list of Penetration Testing providers alongside Cobalt, Doyensec, our friends at Kobalt, and Rapid7.
Existing formatting for the layout was used, and the addition follows the same alphabetical order seemingly used to list existing auditors, consultants, and pen testers.
p.s love the guide and have already started sharing this resource with our customers!

Awesome, thank you. Also, if you feel like there is something missing from here that you feel doesn't well capture your services, please let me know. It's hard to strike a balance between not overwhelming and comprehensive, but more context always helps.

Thanks @wparad! I'll do some thinking here.
I had considered adding a note, but wasn't sure how much context would make sense.
Things like which methodologies are used, if remediation testing and verification is included or an extra charge, and for how long one can request remediation testing are all potentially useful pieces of information since not all providers will be comparable. The first might not be something people pursing SOC 2 care about, but the later might heavily impact their decision.

So I definitely want to avoid drowning in marketing information, but that feels very relevant here and can be distilled down to:

Testing Methodologies (some short list, maybe 2-3 points)
Re-testing is definitely a thing, and the associated pricing
relevant contract lifetimes

I'm tempted to punt on the third one, unless some provider was super unreasonable here (or especially unique in their offering), but the first two I think are great. To be honest, I not sure how I want to prepare "details sections" for each of the companies on the site. I'm not a UI expert (as you can probably tell), but a short text block is definitely what I am thinking about adding.
Would it be possible to share something short about the first two points (maybe in a separate github issue), and then when I've got a good handle on the display, I can pull those points in?

relevant contract lifetimes
I'm tempted to punt on the third one

I've talked to a few people who were locked in for multiple years without realising it with one of the vendors listed. That said, I think it was the exception for that specific vendor and not an industry norm so might just be something for the notes section.

Would it be possible to share something short about the first two points (maybe in a separate github issue), and then when I've got a good handle on the display, I can pull those points in?

Sure thing! I'll create a table in a Github issue and pull together what I can from each vendor including sources for the information.

Sure thing! I'll create a table in a Github issue and pull together what I can from each vendor including sources for the information.

Wow, thank you. I was honestly just asking for yours, but I'm not going to say no to having more information.


Update dependencies

Updating core-setup and corefx dependencies manually to workaround issues with the bot and diamond dependencies.

Yeah.


ARROW-6570: [Python] Use Arrow's allocators for creating NumPy array instead of leaving it to NumPy

This has some benefits:

Move pandas-related memory allocations to the same default allocator as the rest of the Arrow platform, rather than mixing jemalloc and the system allocator as things currently are
NumPy/pandas-related memory allocations are now accounted for in pyarrow.total_allocated_bytes()
Better performance (10+% faster, from quick benchmarks) when using libraries with ARROW_JEMALLOC=ON

There are a couple other usages of the system allocator in arrow_to_pandas.cc but they are for smaller internal bits ("placement" arrays) of data relating to pandas. These can be fixed later if they are deemed bothersome

+1. If there are any follow ups on this I'll be happy to address them


Tab completion broken when file names contain underscores.

e.g.
mkdir test
touch a.z b.z c.z d.z a_.z b_.z c_.z
ls <tab>

on the first tab you see
ls .z

on the second, you see
a.z  b.z  c.z  d.z

files with underscores are not shown.

I took time to find (and understand) this bug, here is what I found:
The r:|[._-]=* matcher makes any completion with ., _, or - in file names useful when:

to complete veryverylongfile.c rather than veryverylongheader.h [...] you can just type very.c before attempting completion. - http://zsh.sourceforge.net/Doc/Release/Completion-Widgets.html#Completion-Matching-Control

But really does not seem worth it: it makes any completion with ., _, or - in file names really annoying, and you already can type very[TAB]c.
So, here it fixes #1398, #4599, and #4063 (and keeps the other neat substring completion):
diff --git a/lib/completion.zsh b/lib/completion.zsh
index f5b2924712..85c892165d 100644
--- a/lib/completion.zsh
+++ b/lib/completion.zsh
@@ -12,14 +12,14 @@ zmodload -i zsh/complist

 ## case-insensitive (all),partial-word and then substring completion
 if [ "x$CASE_SENSITIVE" = "xtrue" ]; then
-  zstyle ':completion:*' matcher-list 'r:|[._-]=* r:|=*' 'l:|=* r:|=*'
+  zstyle ':completion:*' matcher-list 'r:|=*' 'l:|=* r:|=*'
   unset CASE_SENSITIVE
 else
   if [ "x$HYPHEN_INSENSITIVE" = "xtrue" ]; then
-    zstyle ':completion:*' matcher-list 'm:{a-zA-Z-_}={A-Za-z_-}' 'r:|[._-]=* r:|=*' 'l:|=* r:|=*'
+    zstyle ':completion:*' matcher-list 'm:{a-zA-Z-_}={A-Za-z_-}' 'r:|=*' 'l:|=* r:|=*'
     unset HYPHEN_INSENSITIVE
   else
-    zstyle ':completion:*' matcher-list 'm:{a-zA-Z}={A-Za-z}' 'r:|[._-]=* r:|=*' 'l:|=* r:|=*'
+    zstyle ':completion:*' matcher-list 'm:{a-zA-Z}={A-Za-z}' 'r:|=*' 'l:|=* r:|=*'
   fi
 fi

:+1: Thanks for taking the time to look into that. This is still one of the biggest annoyances to date for me.

I'm not sure why this has been closed? The changes haven't been committed, and this problem is still present three years after a fix was proposed. This also breaks completion for files with internal hyphens.
FWIW I could put either fix's zstyle… line in ~/.zshrc after sourcing OMZ, and this worked fine.

I have these files:

zproject.gsl
zproject_ruby.gsl
zproject_java.gsl
...

When i type zp<tab>, it completes to zproject., and another tab completes the whole argument to zproject.gsl, completely skipping the zproject_*.gsl files. I guess this is due to the same bug?
Please, please fix this.

#5435 fixes this, I guess I can merge it immediately given that you've been running with that since January. Thanks guys!

I have quite some files that look like foo-bar-baz, foo-day-err, foo-day-ess, etc. I could type f-b-b<TAB> to get foo-bar-baz and type f-d-er<TAB> to get foo-day-err. It is quite convenient. But it no longer works after this change has been merged.
I can workaround this by adding zstyle ':completion:*' matcher-list 'm:{a-zA-Z}={A-Za-z}' 'r:|[._-]=* r:|=*' 'l:|=* r:|=*' into my .zshrc. But is f-b-b -> foo-bar-baz supposed to work at all, or is it just a side-effect of some other features? I find it quite handy in my use case.

@wks, look at https://github.com/robbyrussell/oh-my-zsh/issues/1398#issuecomment-169163149.
Yes, this fix intentionally broke f-b-z -> foo-bar-baz. It was the r:|[._-]=* basically saying that any ., _, or - should match any character in the completion, I think it transforms f-b-z to f*b*z to match completion candidates.
So yes, zstyle ':completion:*' matcher-list 'm:{a-zA-Z}={A-Za-z}' 'r:|[._-]=* r:|=*' 'l:|=* r:|=*' in your .zshrc (after source $ZSH/oh-my-zsh.sh) should re-enable it.

@wks see this comment for a solution: https://github.com/robbyrussell/oh-my-zsh/issues/5470#issuecomment-250155435

I am looking to properly fix this issue, without breaking completion of https://github.com/robbyrussell/oh-my-zsh/issues/1398#issuecomment-249771828, #5435 , and #5560.
But now I think I better understand the issue and matcher-list, I cannot choose between 2 solutions, and I need to ask you (anyone):
For example, having the files www, wine, and downloads, if you did:
ls w<tab>

Would you want to see downloads in the list or not ?
For short, I cannot decide between the safest solution (does not hide any candidates):
 zstyle ':completion:*' matcher-list 'r:|=* r:|[._-]=* l:|=*'

Or, a "refinement" that suggests only "beginning with" candidates first (downloads comes back if ls wn<tab>):
zstyle ':completion:*' matcher-list 'r:|=*' '+ r:|[._-]=* l:|=*'

(I did not bring both full diff lib/completion.zsh to not pollute the post)

Me personally, I would not like to see downloads if I've only typed ls w<tab>. It just doesn't make sense. In case of ls wn<tab>, it would make more sense, being an actual, multi-character part of downloads.

Ok, after "real world" testing, I also find the "hide downloads" best.
And it is the current behavior of oh-my-zsh so it does not breaks the "omz completion experience".
So, here is my proposal: Properly fixes #1398, #4063, and #4599. Re-enables partial words (hyphen, underscore, and dot separated words) fixing https://github.com/robbyrussell/oh-my-zsh/issues/1398#issuecomment-249771828, #5560, and https://github.com/robbyrussell/oh-my-zsh/pull/5435#commitcomment-19315117. And fix insensitive completion (found no omz issues, but found some stackoverflow):
diff --git a/lib/completion.zsh b/lib/completion.zsh
index bbd0216565..2f274967c1 100644
--- a/lib/completion.zsh
+++ b/lib/completion.zsh
@@ -13,14 +13,15 @@ setopt always_to_end
 bindkey -M menuselect '^o' accept-and-infer-next-history
 zstyle ':completion:*:*:*:*:*' menu select

-# case insensitive (all), partial-word and substring completion
+# complete on the right side only, and if there are no candidates,
+# then also look for partial-word and left side completion
 if [[ "$CASE_SENSITIVE" = true ]]; then
-  zstyle ':completion:*' matcher-list 'r:|=*' 'l:|=* r:|=*'
+  zstyle ':completion:*' matcher-list 'r:|=*' '+ r:|[._-]=* l:|=*'
 else
   if [[ "$HYPHEN_INSENSITIVE" = true ]]; then
-    zstyle ':completion:*' matcher-list 'm:{a-zA-Z-_}={A-Za-z_-}' 'r:|=*' 'l:|=* r:|=*'
+    zstyle ':completion:*' matcher-list 'm:{a-zA-Z-_}={A-Za-z_-} r:|=*' '+ r:|[._-]=* l:|=*'
   else
-    zstyle ':completion:*' matcher-list 'm:{a-zA-Z}={A-Za-z}' 'r:|=*' 'l:|=* r:|=*'
+    zstyle ':completion:*' matcher-list 'm:{a-zA-Z}={A-Za-z} r:|=*' '+ r:|[._-]=* l:|=*'
   fi
 fi
 unset CASE_SENSITIVE HYPHEN_INSENSITIVE

Here is the explanation of the fix:
matcher-list matchers are evaluated in order one by one, and stops at the first matcher having candidates.
Pre-#5435 the partial words completion [1] was in the matcher list before the matcher for substring completion [2]. So, if a completion on the left-side added one of ._-, then, the next <tab> would stop at the "magic dash" matcher (if matches) and suddenly would not look for left completion (showing less candidates than the first <tab>).
[1]: partial word is r:|[._-]=* for ls ~/.o-m-z<tab>
[2]: substring works with l:|=* that makes completion on the left side
The fix puts "magic dash" and substring in the same matcher, so all candidates from both are always shown, so no surprises where candidates disappear on the second tab.
Fix bonus: makes insensitive completion insensitive all the way: try touch fooKbar ls k<tab>. The fix adds + to make the second matcher include the previous one, so the "partial word dash+substring" matcher become also insensitive, it was not before.

I'm also working on having a better default that works for everybody. So far, I found this proposal from stackoverflow that enables fuzzy matching and it also works for the original files that had issues completing (https://github.com/robbyrussell/oh-my-zsh/issues/1398#issue-8184366).
For now you can use this (add it at the end of your zshrc file), until I have the proper time to test each candidate, read up on @Gravemind's proposal and present a viable PR.
Enjoy and report back any issues:
zstyle ':completion:*' matcher-list 'r:[[:ascii:]]||[[:ascii:]]=** r:|=* m:{a-z\-}={A-Z\_}'

Also, subscribe to #5560 for updates on this particular issue.


footer detail

Should fix #1641
From the feedback earlier:

the datetime can be generated in Python
the report-template should probably use the passed build_id from Python for checking the ID

The CI failures also need to be checked, it seems they all fall with:
CRITICAL| Unable to generate report: expected token 'end of statement block', got ':'


Update CI vulnerability scans to work with multiple apps

Currently, the ci-vulnerability-scans workflow hardcodes the application to app. This ticket is to update that workflow to work with multiple apps, similar to how cd works. Note that cd works by having a callable workflow deploy.yml that is then called by app-specific workflows cd-app.yml. This ticket should do something similar, make a callable workflow that takes app_name as a parameter that can be then called from a workflow specific to each app.
Take a look at https://github.com/HHS/grants-equity/pull/508/files as a reference for this was done on another project.
Open question for consideration:

I wonder if we can move the vulnerability scan call to the template-application-* repos. We can reference the callable workflow directly from template-infra (see https://docs.github.com/en/actions/using-workflows/reusing-workflows#access-to-reusable-workflows) and if a project wants to, they can switch that reference to reference a local reusable workflow.

See 🔒 slack thread
credit to @daphnegold for the suggestion

I wonder if we can move the vulnerability scan call to the template-application-* repos. We can reference the callable workflow directly from template-infra (see https://docs.github.com/en/actions/using-workflows/reusing-workflows#access-to-reusable-workflows) and if a project wants to, they can switch that reference to reference a local reusable workflow.

I thought about it a little, and I'm not sure about this to be honest. There's something to be said about keeping as many of the workflows in the same place as possible. Also weird if a team doesn't use an app template & infra template. I didn't include anything for this in the PR, but if you want, we can follow up.

@daphnegold should we re-open this issue or break out the part about moving the ci-app-* files to the application repos into a separate ticket?


Suggestion: Open debug view automatically when hitting a breakpoint or exception

Steps to Reproduce:

Create a simple hello world program for node js.
Add configuration.
Go back to file view tab from the debug view tab.
Add a breakpoint.
F5

Expected:
VSCode switches to debug view when hitting breakpoint - I want to be able to see the callstack pane.
Actual:
VSCode hits breakpoint, but does not show the callstack (still in file view tab).

We try not to change vscode ux state too much automatically.
Currently we open the debug viewlet when the debug session starts, but doing this on every breakpoint hit can be annoying - what if the user actually wants to have the explorer revelead and the debug viewlet constantyl gets opened.
Due to the reasons above closing as will not fix


Make course search faster using FlexSearch

Changed the main page's search mechanism from requesting the backend requests to only frontend FlexSearch.

lookin nice :100:


Check performance against similar solutions

It's very likely performance is a bit worse than in 0.x series, so let's check it and improve it if needed.
TODO

[x] ActiveModel::Validations
[x] ActiveRecord
[x] Sequel set up is too complex, esp that by default it does not use I18n. Giving up for now.
[x] strong_parameters this actually makes no sense, dry-schema should be used standalone instead, and it is faster
[ ] ???

I know it's not the same thing, but I assume JSON Schema validation is used for very similar use cases. So https://rubygems.org/gems/json_schemer, might be another candidate to compare with.

I spent some time on this and it's hard to come up with good scenarios. There's so much that's involved here that it's tricky to get a fair comparison. Overall dry-validation seems to be much faster in case of invalid input and ~1.5-2x slower with valid input (compared to AM, AR is slower in all cases).
Here are some sample results:
Valid input
∞ [ruby-2.6.3][node-v8.12.0] dry-validation git(master) ✗ be ruby benchmarks/benchmark_form_valid.rb
-- create_table(:users)
   -> 0.0036s
<EMAIL_ADDRESS>:age=>19} errors={}>
true
Warming up --------------------------------------
ActiveModel::Validations
                         4.721k i/100ms
        ActiveRecord     1.555k i/100ms
      dry-validation     2.245k i/100ms
Calculating -------------------------------------
ActiveModel::Validations
                         51.292k (± 3.5%) i/s -    259.655k in   5.068410s
        ActiveRecord     15.803k (± 2.7%) i/s -     79.305k in   5.022299s
      dry-validation     23.058k (± 2.0%) i/s -    116.740k in   5.064849s

Comparison:
ActiveModel::Validations:    51292.4 i/s
      dry-validation:    23058.2 i/s - 2.22x  slower
        ActiveRecord:    15802.6 i/s - 3.25x  slower

Invalid input
#<Dry::Validation::Result{:email=>"", :age=>18} errors={:email=>["must be filled"], :age=>["must be greater than 18"]}>
false
false
Warming up --------------------------------------
         ActiveModel   196.000  i/100ms
        ActiveRecord   173.000  i/100ms
      dry-validation   694.000  i/100ms
Calculating -------------------------------------
         ActiveModel      1.993k (± 2.5%) i/s -      9.996k in   5.019657s
        ActiveRecord      1.763k (± 2.3%) i/s -      8.823k in   5.007969s
      dry-validation      6.927k (± 3.2%) i/s -     34.700k in   5.014876s

Comparison:
      dry-validation:     6927.2 i/s
         ActiveModel:     1992.7 i/s - 3.48x  slower
        ActiveRecord:     1762.7 i/s - 3.93x  slower

Notice that these benchmarks are not written in a way that we compare the same functionality. dry-validation does more checks through dry-schema than AR/AM do. It's not even possible to write a benchmark where AR/AM would do the exact same type of validation. Still worth to have some comparison though.
I'm sure we can make valid case faster, possibly faster than AM. This is something to investigate after 1.0.0.
I'm closing this for now, no need to keep it open as it's not a release blocker.

@ahx thanks for the suggestion, a PR adding it to the benchmarks would be cool 😄


config: update listen regex to allow IPv6 addresses

The current regex for validating SMTP/HTTP listen addresses doesn't allow for IPv6 addresses.
This tweak changes the default to listen on both v4 and v6 by default, and updates the regexp so that it matches v4 and v6.

Thanks for this, it makes sense, at least from the perspective of being able to set an IPv6 address (validation). I'm not sure about the default config value change though (simply due to the default startup message) as I think that is probably quite confusing for the average user:
INFO[2023/04/11 15:14:40] [smtp] starting on [::]:1025
INFO[2023/04/11 15:14:40] [http] starting server on http://[::]:8025/

Is your local machine running on IPv6, or did you change the default <IP_ADDRESS> in the config just in case of someone having IPv6 locally?

I changed the default while I was testing as I it was a reasonable default - going from listening on all v4 addresses to listening on all v4 & v6 addresses.
Happy to revert that bit if you'd prefer to keep the current default!

For context, yes - I'm using this on a machine with v4 & v6 addresses to catch mail being sent over both v4 and v6.
I've tested receiving mail on my test machine and also accessing the web UI over v4 and v6 and both seem to work fine.

Thanks - I have merged this in, however Mailpit will now "overwrite" the logging to say <IP_ADDRESS>: if it is set to [::] to try avoid any confusion. I realise that in doing so it may itself cause some confusion, but hopefully less than the other way around :) I am also concerned that [::] may not work on systems where IPv6 isn't "a thing", however I couldn't replicate that on my end so I'm hoping it's OK. If it does cause issues then I may have to revert to <IP_ADDRESS>.


libtock/spi: Split out subscribe and allow commands

Signed-off-by: Alistair Francis<EMAIL_ADDRESS>

Ping

bors r+


Converting basic residual blocks to bottleneck blocks

Hi,
I am attempting to convert the basic residual block to a bottleneck so I can increase the depth of my 3D ResNet (I had messaged you previously about this and the results look amazing so thank you for your help!) The following is what I have come up with using the ResNet34 code in the book as a starting point and the section on bottleneck layers:
class ResidualUnit(keras.layers.Layer):

    def __init__(self, filters=1, strides=1, activation="relu", **kwargs):
        super().__init__(**kwargs)
        self.activation = keras.activations.get(activation)
        self.main_layers = [
            keras.layers.Conv3D(filters, (1,1,1), strides=strides,
                                padding="same", use_bias=False),
            keras.layers.BatchNormalization(),
            self.activation,
            keras.layers.Conv3D(filters, (3,3,3), strides=strides,
                                padding="same", use_bias=False),
            keras.layers.BatchNormalization(),
            self.activation,
            keras.layers.Conv3D(filters*4, (1,1,1), strides=1,
                                padding="same", use_bias=False),
            keras.layers.BatchNormalization()]
        self.skip_layers = []
        if strides > 1:
            self.skip_layers = [
                keras.layers.Conv3D(filters, (1,1,1), strides=strides,
                                    padding="same", use_bias=False),
                keras.layers.BatchNormalization()]

    def call(self, inputs):
        Z = inputs
        for layer in self.main_layers:
            Z = layer(Z)
        skip_Z = inputs
        for layer in self.skip_layers:
            skip_Z = layer(skip_Z)
        return self.activation(Z + skip_Z)

    def get_config(self):
        base_config = super(ResidualUnit, self).get_config()
        return base_config

But when I try to run this with the same filter set up as the ResNet34:
for filters in [64] * 3 + [128] * 4 + [256] * 6 + [512] * 3:
    strides = 1 if filters == prev_filters else 2
    model.add(ResidualUnit(filters, strides=strides))
    prev_filters = filters

I get the following error:
ValueError: Dimensions must be equal, but are 256 and 64 for 'residual_unit_57/add' (op: 'AddV2') with input shapes: [?,23,28,23,256], [?,23,28,23,64].
Are there additional steps that need to be taken to ensure that the input can be added to the output to complete the residual connection?
Thanks!
Brady

Hi @willi3by ,
Thanks for your question, sorry for the late response, and I'm really happy that you got great results. :))
When you have a residual connection going around a block of layers, you need to ensure that the input of this block of layers has the same shape as its output (as in Figure 14-17, in the 2nd edition, or 13-14 in the 1st edition). Otherwise, you need to transform the inputs so that they end up with the same shape as the output before you add them to the output (as in Figure 14-18, in the 2nd edition, or 13-15 in the 1st edition).
In your code, notice that the main layers contains TWO Conv3D layers with stride=strides. When strides=1 and padding="same", that's fine, since the input shape is the same as the output shape. But when strides>1, the output shape will be smaller than the input shape. In this case, we need to add a Conv3D layer to the inputs with the same number of strides before we add them to the outputs. Unfortunately, in your code the code after if strides > 1 only adds ONE Conv3D layer with stride=strides. So the shapes will not be equal on both paths.
Here's a variant of your model that seems to work (but I didn't try training it):
from tensorflow import keras
from functools import partial

DefaultConv2D = partial(keras.layers.Conv2D, kernel_size=3, strides=1,
                        padding="SAME", use_bias=False)

class ResidualUnit(keras.layers.Layer):

    def __init__(self, filters=1, strides=1, activation="relu", **kwargs):
        super().__init__(**kwargs)
        self.activation = keras.activations.get(activation)
        self.main_layers = [
            keras.layers.Conv3D(filters, (3,3,3), strides=strides,
                                padding="same", use_bias=False),
            keras.layers.BatchNormalization(),
            self.activation,
            keras.layers.Conv3D(filters, (3,3,3), strides=1,
                                padding="same", use_bias=False),
            keras.layers.BatchNormalization()]
        self.skip_layers = []
        if strides > 1:
            self.skip_layers = [
                keras.layers.Conv3D(filters, (1,1,1), strides=strides,
                                    padding="same", use_bias=False),
                keras.layers.BatchNormalization()]

    def call(self, inputs):
        Z = inputs
        for layer in self.main_layers:
            Z = layer(Z)
        skip_Z = inputs
        for layer in self.skip_layers:
            skip_Z = layer(skip_Z)
        return self.activation(Z + skip_Z)

    def get_config(self):
        base_config = super(ResidualUnit, self).get_config()
        return base_config

model = keras.models.Sequential([
    keras.layers.Conv3D(64, (7,7,7), strides=2, padding="same",
                        use_bias=False, input_shape=[224, 224, 100, 3]),
    keras.layers.BatchNormalization(),
    keras.layers.Activation("relu"),
    keras.layers.MaxPool3D(pool_size=3, strides=2, padding="same")
])

prev_filters = 64
for filters in [64] * 3 + [128] * 4 + [256] * 6 + [512] * 3:
    strides = 1 if filters == prev_filters else 2
    model.add(ResidualUnit(filters, strides=strides))
    prev_filters = filters
model.add(keras.layers.GlobalAvgPool3D())
model.add(keras.layers.Flatten())
model.add(keras.layers.Dense(10, activation="softmax"))

model.summary()

It outputs this:
Model: "sequential"
_________________________________________________________________
Layer (type)                 Output Shape              Param #
=================================================================
conv3d (Conv3D)              (None, 112, 112, 50, 64)  65856
_________________________________________________________________
batch_normalization (BatchNo (None, 112, 112, 50, 64)  256
_________________________________________________________________
activation (Activation)      (None, 112, 112, 50, 64)  0
_________________________________________________________________
max_pooling3d (MaxPooling3D) (None, 56, 56, 25, 64)    0
_________________________________________________________________
residual_unit (ResidualUnit) (None, 56, 56, 25, 64)    221696
_________________________________________________________________
residual_unit_1 (ResidualUni (None, 56, 56, 25, 64)    221696
_________________________________________________________________
residual_unit_2 (ResidualUni (None, 56, 56, 25, 64)    221696
_________________________________________________________________
residual_unit_3 (ResidualUni (None, 28, 28, 13, 128)   673280
_________________________________________________________________
residual_unit_4 (ResidualUni (None, 28, 28, 13, 128)   885760
_________________________________________________________________
residual_unit_5 (ResidualUni (None, 28, 28, 13, 128)   885760
_________________________________________________________________
residual_unit_6 (ResidualUni (None, 28, 28, 13, 128)   885760
_________________________________________________________________
residual_unit_7 (ResidualUni (None, 14, 14, 7,<PHONE_NUMBER>
_________________________________________________________________
residual_unit_8 (ResidualUni (None, 14, 14, 7,<PHONE_NUMBER>
_________________________________________________________________
residual_unit_9 (ResidualUni (None, 14, 14, 7,<PHONE_NUMBER>
_________________________________________________________________
residual_unit_10 (ResidualUn (None, 14, 14, 7,<PHONE_NUMBER>
_________________________________________________________________
residual_unit_11 (ResidualUn (None, 14, 14, 7,<PHONE_NUMBER>
_________________________________________________________________
residual_unit_12 (ResidualUn (None, 14, 14, 7,<PHONE_NUMBER>
_________________________________________________________________
residual_unit_13 (ResidualUn (None, 7, 7, 4,<PHONE_NUMBER>8
_________________________________________________________________
residual_unit_14 (ResidualUn (None, 7, 7, 4,<PHONE_NUMBER>2
_________________________________________________________________
residual_unit_15 (ResidualUn (None, 7, 7, 4,<PHONE_NUMBER>2
_________________________________________________________________
global_average_pooling3d (Gl (None, 512)               0
_________________________________________________________________
flatten (Flatten)            (None, 512)               0
_________________________________________________________________
dense (Dense)                (None, 10)                5130
=================================================================
Total params: 63,535,690
Trainable params: 63,518,666
Non-trainable params: 17,024
_________________________________________________________________

Hope this helps!

@ageron
No worries!
Ah of course, I had some other ideas of how to get the shapes to match but I think I was overcomplicating it. This code works perfectly!
I can't thank you enough for your time, it is greatly appreciated.


core: Fix AsyncCallbackManager to honor run_inline attribute and prevent context loss

Description
This PR fixes the context loss issue in AsyncCallbackManager, specifically in on_llm_start and on_chat_model_start methods. It properly honors the run_inline attribute of callback handlers, preventing race conditions and ordering issues.
Key changes:

Separate handlers into inline and non-inline groups.
Execute inline handlers sequentially for each prompt.
Execute non-inline handlers concurrently across all prompts.
Preserve context for stateful handlers.
Maintain performance benefits for non-inline handlers.

These changes are implemented in AsyncCallbackManager rather than ahandle_event because the issue occurs at the prompt and message_list levels, not within individual events.
Testing

Test case implemented in #26857  now passes, verifying execution order for inline handlers.

Related Issues

Fixes issue discussed in #23909

Dependencies
No new dependencies are required.

@eyurtsev: This PR implements the discussed changes to respect run_inline in AsyncCallbackManager. Please review and advise on any needed changes.
Twitter handle: @parambharat

hi @eyurtsev . Just checking in. Any update on merging this here ?


Apk size huge increase after adding SqlCipher support (v1.0.2+)

After upgrading to latest version, apk size is increased by 13MB .so files, that ,as I guess, are used to support SqlCipher. Is there a way to exclude it?

@androideveloper solved
Using Android Debug Database Library in your application
Add this to your app's build.gradle
debugImplementation 'com.amitshekhar.android:debug-db:1.0.5'

Using the Android Debug Database with encrypted database
debugImplementation 'com.amitshekhar.android:debug-db-encrypt:1.0.5'

@amitshekhariitbhu Thanks, it saves ~8MB on every build! But it seems that something is broken with querying.
select * from CUSTOMERS returns list of customers, but select fNAME from CUSTOMERS return nothing. Chrome Version 72.0.3626.109 (Official Build) (64-bit). Tried also on Edge, the same there.

@androideveloper Can you please create a separate issue for that so that we track and fix that too.

https://github.com/amitshekhariitbhu/Android-Debug-Database/issues/147


Missing dependency

spoonx/aurelia-api is injected in several files, but is not a listed JSPM dependency in package.json.
separately installing it is required.
Also you can remove the legacy "aurelia-http-client" dependency while you are in there, as I believe you solely rely on fetch client now.

@meash-nrel Yes, yes and yes. You're right on the money!

Would you mind submitting a PR if you have time? I'm currently working out some other repos!
If not, I'll do this later today or tomorrow


Triplanar mapping is not working correctly

Triplanar node seems to break textures when using Frequency.
Using the default uv chart from blender, it breaks the resulting image (see below), when changing the Frequancy parameter to increase image size.
This is how is viewed:

And this is how is the map (screenshot):

triplanar.zip

Also, note that packed files are not working, you have to unpack them first.

This is more of an appleseed issue.  It should be posted on it's repository

@luisbarrancos What's your opinion on this?

Without more information i can only speculate, but at first glance it seems the user set the coordinate system of the surface point to world space, instead of object space. It's covered in the documentation here

I've asked @Asticles on Discord and he tried to plug Surface Position into Surface Point and change the coordinate system but to no avail.

Here's a full Blender 2.80 scene (based on @Asticles' scene, but with grid.png file bundled next to it and setup to repro the problem out of the box):
triplanarFranz.zip
Playing with frequency, offset or rotation doesn't seem to have any effect. Maybe I'm missing something obvious, but in that case our users are likely to as well.

Actually, the exported *.appleseed file bundled in the ZIP above renders correctly in appleseed.studio:

Well now it works fine even in Blender...

I can no longer reproduce the issue with the triplanarFranz02.zip file I posted above. I'm now doubting that I was ever able to reproduce it earlier.
I'm going to close this ticket. Please reopen it if you can reproduce the bug, with the scene I posted or another one.


feat: DeepMarkRequired

PR Checklist

[x] Addresses an existing open issue: related to #315
[x] Steps in Contributing were taken

Overview

Added DeepMarkRequired

As part of the solution, I added LastOfUnion and UnionToTuple (didn't export it to prevent unintentional usage, it is a hazardous utility type which can be broken in any TypeScript version, the mitigation - testing TypeScript versions on CI)
The solution intentionally accumulates mutations of required paths in place (therefore, the known limitation is the number of iterations over union elements)
Added AreNonDistributiveEqual

Covered DeepMarkRequired with basic unit tests (objects-only)

@som-sm I appreciate that you spent some time on the review. If you have time next week, would you be so kind to re-review it? I addressed all your comments, I'm happy to merge my PR

@Beraliv I've gone through the changes, and everything LGTM! Feel free to merge the PR.

@som-sm although this change is ready, this will be scheduled for 10.1 release, so I'd like to finish all smaller changes and then I will merge this one

@Beraliv Sounds good! Let me know if there’s anything I can help with—I’d be happy to contribute.


Add locale TR

Hi, can you add 'tr' support for formkit locale? thank you.

Just added,
glad you try out this module.
Greetings,
Tom