How to use AS5048a degree to move stepper to position?

Hello gin66,
I have hard time trying to figure out how to make this work in an easy step and I hope you can help me with it.
Basically what I'm trying to do is moving the stepper to the specified degree without using relying on the stepper stepping feature. More of in case of misstepping or anything like it. I see everyone uses PID for this purpose but it's way over my ability so basically I'm trying to compare the current degree of the AS5048a and ask the motor to move continuously until the AS5048a says it reaches the same degree.
until now it somewhat works to a certain degree but it is terribly slow, that's because I'm moving it 1 step each loop, if I increase the number of steps I'll be in the risk of not getting to the degree for positions closer than the number of steps specified.
Here's a snip it of the code:

#include <SPI.h>
/*PINS
   Arduino SPI pins
   MOSI = 11, MISO = 12, SCK = 13, CS = 10
   STM32 SPI pins
   MOSI = PA7, MISO = PA6, SCK = PA5, CS = PA4
*/
#include "FastAccelStepper.h"
#include <TMCStepper.h>
#include <TMCStepper_UTILITY.h>

#define dirPinStepper 6
#define enablePinStepper 5
#define stepPinStepper 7
#define SERIAL_PORT Serial1 // TMC2208/TMC2224 HardwareSerial port
#define DRIVER_ADDRESS 0b00 // TMC2209 Driver address according to MS1 and MS2
#define DRIVER_ADDRESS2 0b01 // TMC2209 Driver address according to MS1 and MS2
#define xJoy A0
#define yJoy A1
#define preset_btn 4
#define RSENSE 0.11f // Match to your driver
TMC2209Stepper fDriver(&SERIAL_PORT, RSENSE, DRIVER_ADDRESS);
TMC2209Stepper zDriver(&SERIAL_PORT, RSENSE, DRIVER_ADDRESS2);
bool btnFlag;
volatile long currentPos;
long distance;
FastAccelStepperEngine engine = FastAccelStepperEngine();
FastAccelStepper *stepper = NULL;

const byte CS_pin = 53; //Chip select pin for manual switching

uint16_t rawData = 0; //bits from the encoder (16 bits, but top 2 has to be discarded)
float degAngle = 0; //Angle in degrees
float startAngle = 0; //starting angle for reference
float correctedAngle = 0; //tared angle value (degAngle-startAngle)
float totalAngle = 0; //total accumulated angular displacement
float numberofTurns = 0;
float rpmCounter = 0; //counts the number of turns for a certain period
float revsPerMin = 0; //RPM
int quadrantNumber = 0;
int previousquadrantNumber = 0;
 int new_degree = 135;
uint16_t command = 0b1111111111111111; //read command (0xFFF)

float timer = 0; //timer for updating the LCD and sending the data through the serial port
float rpmTimer = 0; //timer for estimating the RPM

void setup()
{
  SPI.begin();
  Serial.begin(19200);
  Serial.println("AS5048A - Magnetic position encoder");
  pinMode(CS_pin, OUTPUT); //CS pin - output
  pinMode(preset_btn, INPUT);
  digitalWrite(preset_btn, LOW);
  //Checking the initial angle
  readRegister();
  startAngle = degAngle;
  SERIAL_PORT.begin(115200);      // HW UART drivers
  //fDriver.beginSerial(115200);
  fDriver.begin();                 //  SPI: Init CS pins and possible SW SPI pins
  // UART: Init SW UART (if selected) with default 115200 baudrate
  fDriver.toff(2);                 // Enables driver in software
  fDriver.rms_current(600);        // Set motor RMS current
  fDriver.microsteps(16);
  fDriver.en_spreadCycle(false);   // Toggle spreadCycle on TMC2208/2209/2224
  fDriver.pwm_autoscale(true);

  Serial.println("Starting");
  Serial.flush();
  engine.init();
  stepper = engine.stepperConnectToPin(stepPinStepper);
  if (stepper) {
    stepper->setDirectionPin(dirPinStepper);
    stepper->setEnablePin(enablePinStepper, true);
    stepper->enableOutputs();
    stepper->setAutoEnable(false);
    stepper->setSpeedInUs(200);  // the parameter is us/step !!!
    stepper->setAcceleration(4000);
  } else {
    Serial.println("Stepper Not initialized!");
    delay(1000);
  }
}

void loop()
{
  joystick ();
  callPreset();
  readRegister(); //read the position of the magnet
  correctAngle(); //normalize the previous reading
  checkQuadrant(); //check the direction of the rotation and calculate the final displacement

    if (millis() - timer > 250)
    {
      Serial.print("Turns: ");
      Serial.println(numberofTurns);

      Serial.print("Total Angle: ");
      Serial.println(totalAngle, 2);

      timer = millis();
    }

  if (millis() - rpmTimer > 15000) //check and calculate RPM every 15 sec
  {
    revsPerMin = 4 * rpmCounter; //60000/15000 = 4 (we assume the same speed for the whole minute)

    rpmCounter = 0; //reset
    rpmTimer = millis();
  }
}

void readRegister()
{
  SPI.beginTransaction(SPISettings(3000000, MSBFIRST, SPI_MODE1));

  //--sending the command
  digitalWrite(CS_pin, LOW);
  SPI.transfer16(command);
  digitalWrite(CS_pin, HIGH);

  delay(10);

  //--receiving the reading
  digitalWrite(CS_pin, LOW);
  rawData = SPI.transfer16(command);
  digitalWrite(CS_pin, HIGH);

  SPI.endTransaction();

  rawData = rawData & 0b0011111111111111; //removing the top 2 bits (PAR and EF)

  degAngle = (float)rawData / 16384.0 * 360.0; //16384 = 2^14, 360 = 360 degrees

}

void correctAngle()
{
  //recalculate angle
  correctedAngle = degAngle - startAngle; //this tares the position

  if (correctedAngle < 0) //if the calculated angle is negative, we need to "normalize" it
  {
    correctedAngle = correctedAngle + 360; //correction for negative numbers (i.e. -15 becomes +345)
  }
  else
  {
    //do nothing
  }
  //Serial.print("Corrected angle: ");
  //Serial.println(correctedAngle, 2); //print the corrected/tared angle
}

void checkQuadrant()
{
  /*
    //Quadrants:
    4  |  1
    ---|---
    3  |  2
  */

  //Quadrant 1
  if (correctedAngle >= 0 && correctedAngle <= 90)
  {
    quadrantNumber = 1;
  }

  //Quadrant 2
  if (correctedAngle > 90 && correctedAngle <= 180)
  {
    quadrantNumber = 2;
  }

  //Quadrant 3
  if (correctedAngle > 180 && correctedAngle <= 270)
  {
    quadrantNumber = 3;
  }

  //Quadrant 4
  if (correctedAngle > 270 && correctedAngle < 360)
  {
    quadrantNumber = 4;
  }
  //Serial.print("Quadrant: ");
  //Serial.println(quadrantNumber); //print our position "quadrant-wise"

  if (quadrantNumber != previousquadrantNumber) //if we changed quadrant
  {
    if (quadrantNumber == 1 && previousquadrantNumber == 4)
    {
      numberofTurns++; // 4 --> 1 transition: CW rotation
      rpmCounter++;
    }

    if (quadrantNumber == 4 && previousquadrantNumber == 1)
    {
      numberofTurns--; // 1 --> 4 transition: CCW rotation
      rpmCounter--;
    }
    //this could be done between every quadrants so one can count every 1/4th of transition

    previousquadrantNumber = quadrantNumber;  //update to the current quadrant

  }

  totalAngle = (numberofTurns * 360) + correctedAngle; //number of turns (+/-) plus the actual angle within the 0-360 range
}

void joystick () {

  if (analogRead(xJoy) > 600) {
      stepper->runForward();
  } else if (analogRead(xJoy) < 450) {
     stepper->runBackward();
  } else {
    stepper->stopMove();
  }

}

// this is the function I'm referring to
void callPreset() {

        if ( (int)totalAngle> new_degree) { // move counter-clocwise
          stepper->move(-1);
          //  stepper->runBackward(); // works but when it reaches the location moves back few steps
          Serial.print("new position is");
          Serial.println(totalAngle);

        } else if((int)totalAngle< new_degree) { // move clocwise
         stepper->move(10);
         // stepper->runForward(); // works but when it reaches the location moves back few steps
          Serial.print("new position is");
          Serial.println(totalAngle);

        } else{
          stepper->stopMove();
          }
}

From what I understand from the code, loop() does not exactly this: I'm trying to compare the current degree of the AS5048a and ask the motor to move continuously until the AS5048a says it reaches the same degree
in joystick() the code asks the stepper to run forward or backward. But immediately afterwards in callPreset() the stepper gets either command move(-1), move(10) or even stopMove(). Then   readRegister(); correctAngle(); checkQuadrant(); is executed and then in joystick() the stepper is asked again to run forward/backward or stop, which overwrites the move() command. Apparently the code shall run somehow to new_degree = 135 !?
Anyway - as you say - the code is "single stepping" the motor and this is the reason, why the ramp generator is not able to increase speed to maximum, but rather has to stay at minimal speed.
Perhaps try this approach:

Via joystick determine a new target position/angle
From the target position/angle calculate the number of steps to run - assuming no lost steps/angle deviation
Ask the stepper to move those steps with stepper->move(+/- steps)
Wait (!) for the stepper to stop using isRunning()
Measure the angle
If the angle is identical to the target angle, then finished
Otherwise calculate the deviation and translate this in steps and go back to 3

A more fancy implementation could - while running - measure the angle, derive the deviation to the expected angle based on actual number of steps and calculate a prediction value, how many steps less/more for the end position. Just this correction should be intelligent enough to not add the corrected number of steps again and again and again on each measurement of the angle.
Besides, it is better to not call move() or moveTo() on every loop()

Thank you so very much for your prompt reply. This really means a lot. I'll try and change the code based on your suggestion but there are few points which I understood but maybe don't know how to practically apply but will give them a try tomorrow. However, your comments have raised few questions in my mind, can I do this using moveForward or Backward functions instead of move or move to? Is that what you meant when you said to not use moveto or move in every loop? The problem I had with moveforward and backward is it reaches 135 degree and then move backs few steps.
The idea with joystick is to move the motor forward and backward based on the joystick and I'm using stopMove because otherwise it will keep moving after I leave the joystick. other buttons will be used to recall presets but I wanted to figure out how to recall the position before dealing with button press and so on. Do you think this is what causing all this issue?

runForward() and runBackward() are intended to let the motor run for a while without taking care for the position too much. If runForward() and runBackward() is used, then the application would need to poll periodically the position and take action e.g. stopMove(), if a specific position is reached. Should be feasible, but perhaps not the best approach. I have meant to use move().
In the code above, the runForward() and runBackward() has been constantly overwritten with move() and vice versa. If the joystick is left, so that the motor shall stop at the current position, then there is no use to read the angle and issue a move, as the current code does. And that is overwritten by stopMove() immediately afterwards. So perhaps once a while a step is generated with joystick left alone.
So better to use the joystick for target setting (angle) and use as a switch (to stop).
BTW: In the above code joystick() only calls runForward() or runBackward(), but actually new_degree should be modified (,too).

Hello again gin66,
I've been thinking about the actual code to do what you suggested but honestly I couldn't get my head around everything in your comment, and I felt embarrassed asking for clarification which implies that this whole thing is not meant for me. However, we all started at some point and I feel although I'm not awesome at math or coding but I still can learn.
I'll try and repeat your suggestion just to make sure that I can translate it into coding, but first it's important to make it clear that at this point I'm not testing if the joystick moves at all or not, or if the encoder is reading the motor's new angle after the joystick is moved. This is a battle for another day. What I'm concerned with at present is finding (and testing) a way that when I start up the program which means the encoder is in 0 degree, it knows that and moves the motor regardless of the number of steps it knows it has to travel, it just moves until the encoder reads it reaches the goal angle (135 degree) and it stops. so here what I think you meant:
void callPreset() {
  long distance = new_degree - (int)totalAngle; //measuring the distance from the current position to 135 degree
        if ( (int)totalAngle> new_degree||(int)totalAngle< new_degree) { //if the current position is higher or lower than the final degree
          stepper->move(distance); // move the same number of steps measured
            Serial.print("distance is");
          Serial.print(distance);
          Serial.print("\tnew position is");
          Serial.println(totalAngle);

        }
        while (stepper->isRunning()){
  delay(10);
 }
}

this is the result of this code:
https://www.youtube.com/watch?v=Qq7-85rFmbk

From your info I have collected:

AS5048a outputs 16384 values/revolution and your code translates this into degrees (360°/revolution)
Your stepper motor is a NEMA17 with 200 steps/revolution
Your stepper driver is set to 16 microsteps/step

So the relation from AS5048A ang to position is:
ang/360 = position/3200
position = ang * 3200/360 = ang * 80 / 9 = ang * 8.888

So the target position for 135° is 1200 steps. In your code, you use steps = ang. So the stepper runs only 9/80 of the required steps. Your code will let the stepper run these movements:
At 0°:  135 steps to pos=135, ~15°
At 15°: 120 steps to pos=255, ~29°
At 29°: 106 steps to pos = 361, ±41°
At 41°: 94 steps to pos = 455, ±51°
and so on

And for each move the stepper will accelerate from and decelerate to speed = 0. So what is seen in the video fits to the analysis.
Using the relation from angle to position, your code becomes:
void callPreset() {
  float deltaAngle = (float)new_degree - measuredAngle;
  int32_t deltaSteps = (int32_t)(deltaAngle * 8.888);
  if (deltaSteps != 0) {
    stepper->move(deltaSteps); // move the same number of steps measured
    Serial.print("distance is");
    Serial.print(distance);
    Serial.print("\tnew position is");
    Serial.println(totalAngle);
    while (stepper->isRunning()){
      delay(10);
    }
  }
}

I'm really grateful. It finally works. I thought it had something to do with the calculation but I'd never thought of these formulas.
there are 2 issues that came up with this solution though:
1- with this, I cannot go beyond 360 degree for some reason.
2- I tried applying the formula using variables (in case I needed to change microstepping or add a gearbox) but the result is not the same. This is what I used:
stepsCal = 200*microstepping*gear/360
it works but it overshoots by few steps after reaching the correct position.
other than that everything is working perfectly. Thanks again, we couldn't have pulled this off without you.

Glad to be of help. The proposed approach is definitely not the best solution, but may work for you. If the position is overshooting, then the predicted amounts of steps is too high and the formula/factors may need some tweaking. Or there is some play in the whole mechanics, or….
Plenty of possibilities and plenty of ways to work on a better implementation. Starting with the question, why is it limited to 360°….

So what do you suggest as a smarter and better way to achieving this?

The drawback of this solution is, that the motor comes to a full stop first - and if there is a position mismatch, need to add few more steps - more or less in single stepping.
Better would be to predict the deviation (if any) while running or at least shortly before the stop. But this needs a more complex algorithm and good understanding of timing relation between angle measurement and current stepper position. And in addition I would expect, that the float calculation is too slow for this purpose.

I see what you mean. This is why I initially thought of a way to make the motor move blindly like runForward or backward and stop when the new angle reaches the desired angle. But this in its own require a way to stop the program at this function until it reaches the desired angle without going into different loops to work, which is something I don't think can be done. I tried while loop for isRunning and maybe it's not an ideal solution considering if I need to alter another function while the motor is moving to a position especially for long distances with slower speeds


Create LICENSE

All contributors should approve this PR so we have a record of all copyright holders agreeing to use this license.
I approve this PR.


Latest firebase pod version + iOS 12 issue

I am having issue where scheduled notification from firebase console will not send the notification to iOS devices (iOS 12).
The devices will receive notification if the notification is "Send now" from the firebase console. can anyone help me please? thanks

Scheduled notifications rely on silent notification delivery behavior, which may have changed between iOS 11 and 12. If this is the case, there's unfortunately not much we can do about it.


Update universe planning

Upgrade the planning related packages to the almost latest version of autoware.universe  (i.e. commit f8923b0f0735315fd94c1723bbfa0b5e7184c313) and resolve compilation errors.

Add python launch files for packages as follows: mission_planner, planning_evalutator, planning_validator, rtc_auto_mode_manager, ad_api_adaptors, external_velocity_limit_selector, motion_velocity_smoother and scenario_selector.

remove unnecessary packages which were used to run the planning simulator.

Removed packages:
** visualization**
rtc_manager_rviz_plugin
autoware_auto_perception_rviz_plugin
bag_time_manager_rviz_plugin
rtc_manager_rviz_plugin
tier4_adapi_rviz_plugin
tier4_automatic_goal_rviz_plugin
tier4_calibration_rviz_plugin
tier4_control_rviz_plugin
tier4_datetime_rviz_plugin
tier4_debug_rviz_plugin
tier4_localization_rviz_plugin
tier4_perception_rviz_plugin
tier4_planning_rviz_plugin
tier4_screen_capture_rviz_plugin
tier4_simulated_clock_rviz_plugin
tier4_state_rviz_plugin
tier4_traffic_light_rviz_plugin
tier4_vehicle_rviz_plugin
launch
tier4_autoware_api_launch
tier4_control_launch
tier4_localization_launch
tier4_map_launch
tier4_perception_launch
tier4_planning_launch
tier4_simulator_launch
tier4_system_launch
tier4_vehicle_launch
polar_grid
localization
pose_initializer
ekf_localizer
gyro_odometer
initial_pose_button_panel
localization_error_monitor
pose2twist
stop_filter
twist2accel
control
control_performance_analysis
external_cmd_selector
mpc_lateral_controller
obstacle_collision_checker
operation_mode_transition_manager
trajectory_follower_node
pure_pursuit
pid_longitudinal_controller
shift_decider
trajectory_follower_base
vehicle_cmd_gate
common
component_interface_tools
path_distance_calculator
tier4_api_utils
simulator
simple_planning_simulator
fault_injection
sensing
vehicle_velocity_converter
system
component_state_monitor
emergency_handler
mrm_comfortable_stop_operator
system_error_monitor
system_monitor
vehicle
accel_brake_map_calibrator
external_cmd_converter
raw_vehicle_cmd_converter

I would suggest you keep the autoware_auto_perception_rviz_plugin and tier4_perception_rviz_plugin, as they are definitely included in euclidean cluster package

I would suggest you keep the autoware_auto_perception_rviz_plugin and tier4_perception_rviz_plugin, as they are definitely included in euclidean cluster package

no problem. I will bring them back.

I would suggest you keep the autoware_auto_perception_rviz_plugin and tier4_perception_rviz_plugin, as they are definitely included in euclidean cluster package

I have restored the two  packages.

cool, just add to that, you can also remove tier4_perception_rviz_plugin as that's for visualization of tier4 messages in rviz2; for autoware_auto_perception_rviz_plugin that's not directly used but would be necessary in visualization of autoware_auto_perception_msgs::msg::DetectedObjects in rviz2

cool, just add to that, you can also remove tier4_perception_rviz_plugin as that's for visualization of tier4 messages in rviz2; for autoware_auto_perception_rviz_plugin that's not directly used but would be necessary in visualization of autoware_auto_perception_msgs::msg::DetectedObjects in rviz2

Gotcha. have removed tier4_perception_rviz_plugin.

Thank you for working on this! I assume you have compiled everything and it compiles without error on Galactic? Also, for future pull requests, please split them into individual PRs per feature. A single PR with 1800+ changed files is not feasible for anyone to review.

Thank you for working on this! I assume you have compiled everything and it compiles without error on Galactic? Also, for future pull requests, please split them into individual PRs per feature. A single PR with 1800+ changed files is not feasible for anyone to review.

Yes. But I forgot to run colcon test. I believe that is alos a must.  I will run colcon test and see if there is any error I need to fix.  And thank you for the reminder.


Code to function

Hi,
we want to have code transfered to a new global function so we can use that function in Event Subscriber.
The Code we want to have in the new function is what is inside the repeat of those functions.
Codeunit 99000773 Calculate Prod. Order; Function  TransferRouting
Codeunit 99000773 Calculate Prod. Order; Function  TransferBOM
Codeunit 99000809 Planning Line Management; Function TransferRouting (the big repeat not the small one)
Codeunit 99000809 Planning Line Management; Function TransferBOM(also the big repeat)
Thanks in Advance

This issue has been resolved and will ship in a future update.


chartPadding top right bottom left

Hi Gion
Would be nice if chartPadding is array of numbers for top, right, bottom and left padding.
In case of 'fullWidth: true' and 'chartPadding: 0' is the right point cropped:
http://codepen.io/martinsznapka/pen/JoLLYK
I think 'chartPadding: [0, 5, 0, 0]' can solve it.

Maybe also support using an object, like
chartPadding: {
    right: 5
}

to set just the values you want to set, like in CSS.

Yepp, that's better.

Hey Martin
Thanks for this issue! It's definitely desirable to have this configuration. This would also help the fullWidth line charts to fix the last label rendering (and the point) like described in #198
Currently only a global padding can be specified that will pad the Chart from all four sides with the same pixel value. It's desired however, for multiple reasons, to have the ability to specify the chart padding individually for each side. This could be done, as suggested here by @danieldiekmeier, by using individual properties for top, right, bottom, left like in CSS. Additionally the configuration should also be possible with a number which will internally then be used for all four sides.
Internally, most of the code should work fine, if the chartRect calculation will be amended, so it takes this new configuration into account. Most subsequent layout processes use the chartRect object. However, there are certain positionings that rely on the chartPadding being a number. This needs to be refactored.

Possibly related with https://github.com/gionkunz/chartist-js/issues/842


Falco Alerts: an example logrotate config is a broken link

What is wrong with the website or needs to be cleaned?

If you'd like to use a program like logrotate to rotate the output file, an example logrotate config is available here.

"here" link is broken. https://github.com/falcosecurity/falco/blob/master/examples/logrotate/falco returns 404.

https://falco.org/docs/alerts/#file-output
https://falco.org/ja/docs/alerts/#ファイル出力

Thanks for pointing the issue @oke-py .
The correct link is: https://github.com/falcosecurity/falco/blob/ffd8747ec0943db2546c3270826e1700dc4df75f/examples/logrotate/falco

Thanks for pointing the issue @oke-py .
The correct link is: https://github.com/falcosecurity/falco/blob/ffd8747ec0943db2546c3270826e1700dc4df75f/examples/logrotate/falco


"Migrations information" grammatical error

This should be "Virtual machine (or VirtualMachine, which looks strange) migration information".
"migration" is an adjective in this context, modifying "information". English adjectives do not have plural forms.
https://github.com/kubevirt-ui/kubevirt-plugin/blob/639780605c3e468f677f5459df1aea3745a62a73/locales/en/plugin__kubevirt-plugin.json#L838

this been changed to "VirtualMachineInstanceMigrations information": "VirtualMachineInstanceMigrations information" so it would fit with the resource name for VMIM, should we still remove the plural?

Yes, you should remove the plural.
"VirtualMachineInstanceMigration" is an adjective, not a noun. English adjectives do not have singular/plural forms.
It modifies "information", which is a noun. So this should be "VirtualMachineInstanceMigration information".

Fixed


perf: fast path operations for small non-native values

Description
This PR enforces small non-native values to work on zero or one limb. I also added some fast-path operations when we can deduce the result without needing to perform any operations (mul by zero for example).
Also adds a few more emulation parameters useful for implementing small-fields.
Type of change

[x] New feature (non-breaking change which adds functionality)

How has this been tested?
Existing tests succeed
How has this been benchmarked?
Updated the stats.
Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I did not modify files generated from templates
[x] golangci-lint does not output errors locally
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

lgtm. Shouldn't we also have fast path for Div / Inv / Sqrt ?

We should. I'll see how we could be able to implement them.

lgtm. Shouldn't we also have fast path for Div / Inv / Sqrt ?

We should. I'll see how we could be able to implement them.

Added fast paths to Div/Sqrt methods. For inverse we don't support inverse of zero (different from gnark-crypto imo where we take inverse of zero to be zero), so omitted it.
Also added test for checking that the fast paths are complete against short zero (on zero limbs) and large zero.


Jetson orin nano /camera/imu

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
D435i

Firmware Version
<IP_ADDRESS>

Operating System & Version
Linux (Ubuntu 20.04)

Kernel Version (Linux Only)
5.10

Platform
NVIDIA Jetson Orin Nano

SDK Version
legacy / <IP_ADDRESS>

Language
python

Segment
Autonomous Robot

Issue Description
When I tried to use /camera/imu topic, any data does not come and also i couldn't visualize in rviz. Realsense-viewer send some error for motion module.

I tried to solve this problem with this issue solution.
https://github.com/IntelRealSense/realsense-ros/issues/2563
I got this
https://github.com/user-attachments/assets/b8256df1-6baf-4086-b3f1-9058068bb719

Hi @CSARobotics  When the control_transfer returned message generates continuously, it can indicate that there is a communication problem between the camera and the computer / computing board, typically an issue with the US port or the USB cable.
In the RealSense ROS wrapper, the IMU topics are disabled by default.  They can be enabled and published in the /imu topic by adding the commands below to your ROS launch instruction.
ROS1
enable_gyro:=true enable_accel:=true unite_imu_method:=linear_interpolation
ROS2
enable_gyro:=true enable_accel:=true unite_imu_method:=2

Hi @CSARobotics  Do you have an update about this case that you can provide, please?  Thanks!

Thank you for your interest. When I try it on my laptop with the same cable, there is no problem. So I don't think it's the cable. There does not appear to be a problem with ROS Wrapper. I think the problem is with the SDK. I installed the SDK using this repo https://github.com/jetsonhacks/installRealSenseSDK. There is no problem with RGB and Stereo camera, but I cannot view IMU data even with Realsense Viewer.

When using the installRealSenseSDK repo, did you install from packages with the installLibrealsense.sh script or build from source code with the buildLibrealsense.sh script?
The buildLibrealsense script should have a similar effect to using the libuvc backend procedure mentioned earlier in this discussion, as both the libuvc script and the buildLibrealsense script include the CMake build flag -DFORCE_LIBUVC=ON.
However, if you used installLibrealsense.sh to build from packages then the IMU would not be supported on JetPack 6.

I used the buildLibrealsense script. The flags were as follows: /usr/bin/cmake ../ -DBUILD_EXAMPLES=true -DFORCE_LIBUVC=ON -DBUILD_WITH_CUDA="$USE_CUDA" -DCMAKE_BUILD_TYPE=release -DBUILD_PYTHON_BINDINGS=bool:true -DPYTHON_EXECUTABLE=$(which python3)
I'm currently using JetPack 6, but it doesn't matter to me. I can also switch to Jetpack 5 if it will work there.

Yes, I would strongly recommend trying JetPack 5.1 if you do not mind trying a downgrade of your JetPack.

So, JetPack 5.1.2 or 5.1.3? Also, when I tried them with the buildLibrealsense script before, I got the same result. Is there an SDK installation guide where I can run IMU for JetPack 5?

I'm currently flashing JetPack 5.1.3. I will try it as soon as it is finished and write the results.

Realsense d435i became operational with all its functions.
Installation Method:
1 - Install Jetpack 5.1.3.
2 - Clone this repo https://github.com/jetsonhacks/installRealSenseSDK.
3 - Run installLibrealsense.sh
4 - Congratulations, the installation is completed.
Thank you very much for your help @MartyG-RealSense

You are very welcome, @CSARobotics - it's great to hear that JetPack 5.1.3 was a successful solution for you.  Thanks very much for the update and for sharing your method!


Version script does not check vs-common version

version.sh unify does change the vs-common version
Ir is however not checked by verify.

Closed in favor of #381


add to_list_item

Hi there,
I'd like to add "to_list_item" into ERB template.
Our team want to add just a simply list, no need checklist.
In this case, I think this is better for we can choice the way of adding a PR list.
Thank you!

@onk Hi Onaka-san, How about this proposal?
I understand you're busy, sorry to disturb you.
I'm appreciate if you review this.

@onk Thank you very much for your answer! My issue was solved this solution.


remove mock-data scripts and use catalog.locations for adding examples

Figured we can clean up all of the extra steps required to add mock data to the catalog, and just use static location configurations in app-config.yaml instead. It's also easy to override in app-config.local.yaml for local development.

Something wrong with the zombie package for E2E test on Windows. It randomly pops up sometimes. 😅
I wonder if we should switch to a more stable headless browser for E2E testing - puppeteer is a good one.

@OrkoHunter goal with zombie was to have something very lightweight that can just do a very quick and dirty verification. We're running more elaborate e2e tests with Cypress. It's idd only an issue on the Windows runner, so would wanna see if we can work around that first instead of swapping it out. I can also say that my experience with puppeteer is no better than zombie x)

@Rugvip Ah, I see. Thanks for explaining.
(My experience with all headless browsers is the same - try/catch/try/catch until it works. xD)


build system updates - V2

Changes
v2:

added new patch: "build: add soletta's specific help listing"

Rationale
This pull request brings 2 patches, 1 to generate make dependency chains with gcc -MM and friends, and one another to make sure to remove python generated code with dependency-resolver tests.

@barbieri it seems not to be working, would involve some time to update it or see what's missing, I can drop it until we have it working - if we want it to.

just drop it

ok, applied with the requested changes...


Removes references for props in class

.js code:
class A {
    b() {
        this.a = 5
        this.a = 6
        this.a = 7
        console.log(this.a)
    }
}

If trigger on this.a it display only only console.log(this.a) it seems with this pattern its possible to have a few definitions
If you trigger on console.log(this.a) it will display all of them, which seems to be more logical
Its caused by tsEssentialPlugins.removeDefinitionFromReferences, so I think it would be logical to just disable this feature on this

I decided to disable removeDefinitionFromReferences when in this.anyProperty request positions because of ambiguity.


bug: MetaMask connector.ready evaluates to false in Chrome if you have coinbase wallet or core wallet installed

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
0.7.15
Current Behavior
The MetaMask connector.ready is evaluating to false in Chrome when coinbase wallet or core wallet is installed in the browser. The same issue is happening on mobile, where if you have those applications downloaded on your phone it will also evaluate to false, but once you delete them it evaluates to true.
Is this the expected behavior that you cannot have other EVM wallets installed on your browser / mobile device and use the MetaMask connector?
Expected Behavior
MetaMask connector.ready should evaluate to true
Steps To Reproduce
On Chrome: Install metamask extension and core wallet or coinbase extension
On mobile: Install metamask application and core wallet or coinbase application
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

Does my reply here make sense to why this is happening for desktop?
Note: the MetaMaskConnector inherits the InjectedConnector, which is only available on browsers that support window.ethereum (ie. desktop browsers), so it's expected that connector.ready is falsy on mobile browsers (no injected window.ethereum). Maybe the naming "InjectedMetaMaskConnector" would make more sense here.

Does my reply here make sense to why this is happening for desktop?
Note: the MetaMaskConnector inherits the InjectedConnector, which is only available on browsers that support window.ethereum (ie. desktop browsers), so it's expected that connector.ready is falsy on mobile browsers (no injected window.ethereum). Maybe the naming "InjectedMetaMaskConnector" would make more sense here.

The reply makes sense, but just to confirm the behavior so I can plan how to handle it - the user an ONLY have metamask installed (not any other wallets that inject into window.ethereum for the metamask connector to work?

Yep, that's pretty much right. Unfortunately it is a drawback of the window.ethereum model at the moment.

Adding a bit of extra context: MetaMaskConnector attempts to work when other wallets are installed, but sometimes falls short due to window.ethereum and other wallets trying to make themselves look like MetaMask (e.g. window.ethereum.isMetaMask = true).

Got it, thanks both for your clarification!


Align Close Button Right configuration is not working

Using Hyper 2.1.2 on Windows 10 (for WSL).
The close button still stays on the left after setting closeAlign: 'right'. See screenshot

Be sure to place your hyperTabs:{} config before the closing curly brace of config:{}, which comes before plugins:[].


Release Request

Could you please cut a release including:
https://github.com/tyarkoni/transitions/pull/158
https://github.com/tyarkoni/transitions/pull/166
Thanks

Good idea, thanks for the reminder. @aleneum, let me know if you want to pull the trigger on PR #151 in the next few days; if so, I'll include it in the 0.4.3 release. Otherwise I'll bump now and we can  add that next time.

Go ahead. A release is a good idea.  #151 takes some more work and I wont be able to tackle this soon. Let's save it for 0.4.4 or later.


Take into account all repos in PR Dashboard

Today, Kanban PR Dashboard takes into account Prestashop repository.
As a user (PM, developer...), i want to visualize :

all PRs coming from different repositories of Open Source Project.

Should some repositories be excluded ?

exluding PRs labelled "TE" + "E2E Tests
tbd

@kpodemski you had in mind other repositories to exclude ?


Update retrieve-images.md

Variable k4a_capture_t capture not defined.

@cdedmonds
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

emailed author

sent Teams message to author to review


Client - Getting AttributeError when using ./start

Describe the bug
There instances that when we open the client using ./start command on CLI, we are getting AttributeError: module 'lib' has no attribute 'X509_V_FLAG_NOTIFY_POLICY'. Did you mean: 'X509_V_FLAG_EXPLICIT_POLICY'?
(hummingbot)  ✘ ralph@hbot01  ~/github/hummingbot/6887   feat/coinbase_advanced_trade_v2.1  ./start
Traceback (most recent call last):
  File "/home/ralph/github/hummingbot/6887/./bin/hummingbot_quickstart.py", line 32, in <module>
    from hummingbot.core.management.console import start_management_console
  File "/home/ralph/github/hummingbot/6887/hummingbot/core/management/console.py", line 10, in <module>
    import asyncssh
  File "/home/ralph/miniconda3/envs/hummingbot/lib/python3.10/site-packages/asyncssh/__init__.py", line 31, in <module>
    from .agent import SSHAgentClient, SSHAgentKeyPair, connect_agent
  File "/home/ralph/miniconda3/envs/hummingbot/lib/python3.10/site-packages/asyncssh/agent.py", line 34, in <module>
    from .public_key import KeyPairListArg, SSHCertificate, SSHKeyPair
  File "/home/ralph/miniconda3/envs/hummingbot/lib/python3.10/site-packages/asyncssh/public_key.py", line 35, in <module>
    from .crypto import ed25519_available, ed448_available
  File "/home/ralph/miniconda3/envs/hummingbot/lib/python3.10/site-packages/asyncssh/crypto/__init__.py", line 58, in <module>
    from .x509 import X509Certificate, X509Name, X509NamePattern
  File "/home/ralph/miniconda3/envs/hummingbot/lib/python3.10/site-packages/asyncssh/crypto/x509.py", line 32, in <module>
    from OpenSSL import crypto
  File "/home/ralph/miniconda3/envs/hummingbot/lib/python3.10/site-packages/OpenSSL/__init__.py", line 8, in <module>
    from OpenSSL import crypto, SSL
  File "/home/ralph/miniconda3/envs/hummingbot/lib/python3.10/site-packages/OpenSSL/crypto.py", line 1579, in <module>
    class X509StoreFlags(object):
  File "/home/ralph/miniconda3/envs/hummingbot/lib/python3.10/site-packages/OpenSSL/crypto.py", line 1598, in X509StoreFlags
    NOTIFY_POLICY = _lib.X509_V_FLAG_NOTIFY_POLICY
AttributeError: module 'lib' has no attribute 'X509_V_FLAG_NOTIFY_POLICY'. Did you mean: 'X509_V_FLAG_EXPLICIT_POLICY'?

Note: For monitoring purpose
Steps to reproduce
TBA
Release version
dev-1.27.0
Type of installation
Source
Attach required files
No response

Reproduced

as workaround do clean reinstall with conda clean -a
./clean
conda deactivate
./uninstall
conda clean -a

Then
./install
conda activate hummingbot
./compile

any progress on this bug?
Having the same issue after updating the development branch and always completely building the conda-env from fresh is not that funny.
@nikspz any idea what is causing that bug?

I cathed this when changed port for gateway. On latest version can't reproduce this one.
P.s.
Also some commit on development had this issue for ./start command

fix merged to latest development now

That sounds great, thanks for the fix. Will see if it works after the next development-branch pull.

I just had the issue again on a pull from main today.


CollisionCostTermCGG.hpp for online trajectory generation

Hi, now I am trying to use the code in /ct_ros_nodes/examples/HyA/HyANLOC_ObastacleAcc.cpp for online trajectory generation. So I need to change the target position for end effector as well as obstacle position online! Could you tell me how can I make it?
Now, I just tried:
       std::vector<NLOptConSolver::OptConProblem_t::CostFunctionPtr_t> costs = nloc.getCostFunctionInstances();
        for (int i = 0; i < nloc.getCostFunctionInstances().size(); i++)
        {
            costs[i]->getIntermediateTermById(intTermID)->updateReferenceState(x_d);
            costs[i]->getFinalTermById(term_quad_final_id)->updateReferenceState(x_d);
        }

but, then the nloc.solve() did not get the desired trajectory!

It is because of my own code bugs! Problem solved! Thanks a lot!


Implement Service Workers as background service?

For push notifications, etc.

That would be nice, but the user should approve of that and be able to turn them off later - per web app or even per service, if it's feasible.

It would be great to have a very basic push notification service integrated into WebApps. Especially for social media sites such as Twitter and Instagram.


Support explicitly passing in local files in options.stylsheets

Without these changes, if you run UnCSS with a remote HTML file, there is no way I could find to override stylesheets with local stylesheets using options.stylesheets. Any path in there gets handled as a relative or absolute path based on the remote HTML path.
This PR supports local stylesheets by resolving options.stylesheets paths that start with file: locally no matter what.

Coverage increased (+1.7%) to 98.347% when pulling ea8649ebc65d30c5197ae7a37cd86ee0c17fe0b9 on tobek:master into 50cb679572d4723315f02c7e7fdbdaadf32021d0 on giakki:master.

@tobek ping?

Though this is a valid feature, I'm in favor of closing this since the PR is outdated and isn't being updated. @mikelambert @XhmikosR ?

@RyanZim: it's just 2 lines if one wants to update it. Also note that we can force push to the person's who made the PR fork.

I guess @tobek doesn't have the option which allows us to push enabled.
See #329

Sorry guys, was really busy when I made this PR and didn't have time to do the cleanup of pre-existing code that was requested in the comments. Thanks @XhmikosR for picking this up!


Is the project still alive?

Hey there! Quick question, is tippecanoe still an actively supported project? Did the community move on? Which fork should I use then to efficiently generate vector tilesets?

See #876

It's here! https://github.com/felt/tippecanoe
See also https://felt.com/blog/erica-fischer-tippecanoe-at-felt


Request for Replication Script for LLaMA 7B on MMLU

Hi,
I'm trying to replicate the LLaMA 7B model's performance on the MMLU benchmark as reported in your paper but am seeing significant differences in results. Could you share the exact scripts or steps you used for LLaMA 7B? Access to these would be incredibly helpful for accurately reproducing the results.
Thanks for your help

This issue has been resolved. After getting in touch with the author, he provided some excellent suggestions. Thanks to the author.

This issue has been resolved. After getting in touch with the author, he provided some excellent suggestions. Thanks a lot.

This issue has been resolved. After getting in touch with the author, he provided some excellent suggestions. Thanks a lot.

Hello, could you please share the configuration for reproduce LLAMA7b? Thanks a lot!


BUG: Form Allignment is bad

Login form is not align properly.

Please assign to me this issue under gssoc-ext and hacktoberfest-accepted with level-2:)

can i take this issue?


remove rounding errors with FT conversion

move FT conversion to after module operation or after difference between two times to avoid rounding errors
fixes issue #21

bors try

bors r+


Live

Docs Build status updates of commit 07f41ab:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Nox tests-3.9 failing

All nox tests are passing with the exception of tests-3.9. Check dev testing packages.

Attempted to fix issue by rolling back several packages:

coverage
pytest-cov
django-coverage-plugin
pytest

Various version combinations were attempted without success or change in the initial
error message. tests-3.9 will remain disabled. Application runs fine under
3.9. This appears to be an issues with one of the testing packages.


[Developer Preview] Bug fixes

Summary of the Pull Request
What is included in the PR:
When finished this PR fixes:

https://github.com/microsoft/PowerToys/issues/15930
https://github.com/microsoft/PowerToys/issues/15907
https://github.com/microsoft/PowerToys/issues/15752
https://github.com/microsoft/PowerToys/issues/15726

How does someone test / validate:

Use files with some special unicode chars

Quality Checklist

[x] Linked issues: https://github.com/microsoft/PowerToys/issues/15930 https://github.com/microsoft/PowerToys/issues/15907 https://github.com/microsoft/PowerToys/issues/15752 https://github.com/microsoft/PowerToys/issues/15726
[x] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[x] Localization: All end user facing strings can be localized
[x] Docs: Added/ updated
[x] Binaries: Any new files are added to WXS / YML

[x] No new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

Ready for review!

@Aaron-Junker Pipeline failed by file missing. Please confirm.

@Aaron-Junker Pipeline failed by file missing. Please confirm.
installer\PowerToysSetup\Product.wxs(835,0): Error LGHT0103: The system cannot find the file 'C:\a_work\1\s\installer\PowerToysSetup....\x64\Release\modules\FileExplorerPreview\languages.json'.

@Aaron-Junker , @franky920920
Projekt solution file needs an update. That's all.

/azp run

The build succeded

The build succeded

I can confirm that UTF8 problem is solved. File too big message is still not shown for me.. Also, keyword coloring is gone as well.
@stefansjfw I'm not able to reproduce your bugs:

@stefansjfw Could you build monacopreview in debug mode. Then when previewing a file developer tools should open. Can you look what is written here:

Never mind, it works now, probably it was something on my side. So, both file too big message and coloring are OK.
Just check my other comments and it should be good to go

I added a small "fix" for #16081

Update Product.wxs and comments, and everything should be good to go

Oops I accedently reverted the change in product.wxs

Update Product.wxs and comments, and everything should be good to go

Oops I accedently reverted the change in product.wxs

I just pushed the fix. no worries

Update Product.wxs and comments, and everything should be good to go

Oops I accedently reverted the change in product.wxs

I just pushed the fix. no worries

Thanks!

/azp run

@stefansjfw So can we merge it or do I need another approval?

Feel free to merge it. I didn't manage to reproduce NullReference bug. Or any other. Nice work!!

Feel free to merge it. I didn't manage to reproduce NullReference bug. Or any other. Nice work!!

Thanks


Do not check services endpoint when running jobs

We currently check the dynamo hosted web collection to see id types and countries supported before summiting jobs to the API.
The check is no longer necessary.

Please update the change log with an unreleased entry

Done


02_add_event_data migration error on MariaDB 10.3

Hello,
"RENAME INDEX" syntax is not supported by MariaDB 10.3 (which is the default version on Ubuntu 20.04). yarn update-db command fails.
Applying migration `01_init`
Applying migration `02_add_event_data`
Error: P3018

A migration failed to apply. New migrations cannot be applied before the error is recovered from. Read more about how to resolve migration issues in a production database: https://pris.ly/d/migrate-resolve

Migration name: 02_add_event_data

Database error code: 1064

Database error:
You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'INDEX `session_uuid` TO `session_session_uuid_key`;
ALTER TABLE `session` DR...' at line 2

Please check the query number 16 from the migration file.

error Command failed with exit code 1.

I ran the migraiton against MariaDB manually, and 01/02 files deploy just fine on it.  I tested our custom renaming index function as well, successfully.
We did perform another release of 1.37.0 without incrementing the release.  Please get the latest version and try again.
More information on troubleshooting can be found here.
https://github.com/umami-software/umami/discussions/1434

Hello @briancao , I can confirm that issue on older MariaDB versions
RENAME INDEX support was added in 10.5.2 (https://mariadb.com/kb/en/alter-table/#rename-indexkey)
I had to drop the indexes and recreate them.
By the way, that issue left aside, I'm surprised Prisma managed to handle the procedure, because running that 02 migration without Prisma requires a change of DELIMITER, like that:
DELIMITER ;;
CREATE PROCEDURE ...........
[...]
END;;
DELIMITER ;

It seems you helped a few Prisma users https://github.com/prisma/prisma/issues/12912 with that migration.
:)

Thank you for all the details!  For whatever reason, I had no issues running the migrations in full against MariaDB, despite no DELIMITER.
Closing this.  Please use 10.5.2 or higher when using MariaDB.


compress/zlib: reading data with known length

When the length of the compressed data is known a priori, and one reads precisely as many bytes from the ReadCloser returned by zlib.NewReader, the zlib checksum isn't read. One needs to attempt to read past the end of the compressed stream to get zlib to read it, which I think this is counterintuitive, and makes it so that one pretty much has to use ioutil.ReadAll to safely read zlibbed segments embedded in a larger stream.
Obligatory play.golang.org link: https://play.golang.org/p/KvqnDU36Q2
A good solution, I think, would be to arrange to have Close read and check the checksum if it hasn't been done yet, as it should be called when one is done reading anyway.
Tested on go1.5 linux/amd64.

I think the safest thing we can do here is document this. Changing the behavior of Close to start doing reads and changing the return value from Close seems like an Go 1 compatibility promise change at this point.
Btw, a more convincing play.golang.org snippet might include checking return values, such as: https://play.golang.org/p/dI-lca_rjR ... because notably, the zlib.Reader docs explicitly says it can over-read from the underlying reader, so what you should be testing isn't the number of bytes remaining, but what your desired return values are.

I don't think having Close do a 4-byte read is a valid solution. The zlib format does not encode the uncompressed size, so there is no way for Close to know that the next 4 bytes is the checksum. This happens to work for you since you know that information, but the Reader implementation does not know that. It only knows to read the checksum when it receives an EOF from the underlying flate.Reader. However, the current implementation of that flate.Read always returns (n, nil) if n is positive. Thus, zlib.Reader cannot get an EOF unless it attempts to read past the length of the stream.
Thus, I agree with @bradfitz that the best solution is to just document this situation.
On a side note, the documentation about "The implementation buffers input and may read more data than necessary from r." should probably be updated since it is not always true. If the reader passed in satisfies the io.ByteReader interface, it will not read more data than necessary.

If altering Close is not acceptable, Read could be changed such that when it detects that the stream has been exhausted, it goes ahead and reads the checksum too. This should be possible since the last block in a DEFLATE stream is explicitly marked as such.
I used bytes remaining as my measure in the snippet because that's my actual use case: reading multiple consecutive zlibbed segments from a stream. Looking at the zlib.NewReader docs now, I see I've actually been depending on undefined behavior... but I wonder if the warning about over-reading was just a documentation oversight, since the zlib implementation simply delegates its reading to compress/flate, whose own NewReader docs say that over-reading only happens if the argument io.Reader does not also implement io.ByteReader.

You are correct that the last block in DEFLATE is marked as such, but as I noted above, the current implementation of compress/flate does not make that easily known. We could alter flate to report EOF more agressively, but that would be a more invasive change to flate. It's certainly do-able, but it's also very fragile, because it means that zlib is dependent on more strict behavior than what io.Reader promises.
I'm wondering, you seem to be attempting to read a series of zlib encoded stream back-to-back and you know the uncompressed size. Can you do something similar to the following?
var rd io.Reader // Let's say your data stream is in here
chunks := []int64{13, 1323, 251} // Uncompressed size of each chunk

// Wrap your reader with bufio.Reader to ensure that it satisfies io.ByteReader.
rd = bufio.NewReader(rd)

for _, nchk := range chunks {
	zr, err := zlib.NewReader(rd)
	if err != nil {
		panic(err)
	}

	var buf bytes.Buffer
	n, err := io.CopyN(&buf, zr, nchk+1)
	switch {
	case err == nil || n > nchk:
		panic("ZLIB stream is longer than expected")
	case err != io.EOF:
		panic(err)
	case n < nchk:
		panic("ZLIB stream is shorter than expected")
	}

	if err := zr.Close(); err != nil {
		panic(err)
	}
}

@dsnet, btw, I've made a number of changes over the years to return (n, io.EOF) instead of (n, nil) + (0, io.EOF) more aggressively. Either is valid under the io.Reader contract, but there are a number of performance reasons for returning io.EOF early. I'd be in favor of doing so in compress/flate if it doesn't already.

@bradfitz, I'd be happy to make that change in the inflate code :)
What are your thoughts on my concern about having zlib be dependent on flate.Read always returning io.EOF aggressively? It seems brittle to me...

Define "dependent"? If we want the final zlib.Reader.Read (the (non-zero, io.EOF) read) to return an error if the 4 byte checksum following is bogus, that doesn't seem fragile: it's a dependency is the same repo, and we write tests.

SGTM, I'll submit CLs in the near future.

@dsnet: Yes, reading back-to-back zlib streams with known uncompressed sizes is my use case. Getting it done isn't a problem - I've just been using ioutil.ReadAll to date - but I raised this issue to see if, sometime in the future, I could maybe get it done with io.ReadFull and some appropriately pre-allocated slices.

I thought about this over the weekend and I don't think compress/flate should be changed since this changes some subtle behavior with regard to how flushing works. By convention, a DEFLATE reader stops reading when it encounters the first [empty, raw block] as a signal that all data read so far should be flushed to the user.
Consider the following DEFLATE stream:
[non-empty N=10, raw block] [empty, raw block]*100 [final, empty, fixed block]
In this situation, suppose you performed read exactly 10 bytes (knowing that was the length of the stream), in order for the DEFLATE to know that EOF was encountered, it must read through all empty blocks until it either 1) hits another block with data, or 2) hits an empty block with the final bit set. However, this might break some network protocols that have subtle dependencies on flushing (for example, that the read offset of the underlying reader was left immediately after the distinctive 0x0000ffff marker of empty raw blocks).
Let's just document this situation.


chore: Fix OSConfig generation, in terms of gRPC generated code

This just suppresses warnings around obsolete types.

I'm going to force merge this, regenerate #7961, then fetch and modify that PR to fix it with https://github.com/googleapis/gapic-generator-csharp/pull/444.


Svelte: files in the public directory are served at the root path

Describe the bug
The default index.html template uses the /public/global.css and /public/favicon.ico paths to link respectively the app css and favicon. When serving the app, we get the following warning in the CLI:
files in the public directory are served at the root path.
Instead of /public/global.css, use /global.css.
files in the public directory are served at the root path.
Instead of /public/favicon.ico, use /favicon.ico.

To Reproduce

npm i -D @nxext/svelte --legacy-peer-deps
nx g @nxext/svelte:app svelte-app

Expected behavior
No warning about static files.

Thank you for the contribution :)


owners: promote Stephan and Greg to senior maintainer!

More responsibility, yay! ;)

@envoyproxy/maintainers


[Feature] Display name of contributor on hovering

Description
In the contributor page, currently only the images of contributors are being displayed.
It would look better if the contributor's GitHub username is also being displayed on hovering above his/her image.
Screenshots
This is the current contributors page:

This is with a sample case:
(I wont change other components like background image/colour, below is just an example for displaying name additionally on hovering)

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@Rakesh9100 Please assign me this issue under GSSOC 2024

Go ahead @NidhiTornekar


CDI-646 Annotated configurators

After convincing Martin to keep removeAll methods, this has my +1 :)

Yes using predicates is nice idea. +1


Optimized makefiles.

Optimized makefiles.
Synced with mainstream ps2sdk:

Clear USB Mass Storage Device status to 0 at initialization-time (8997094)
Changed UsbMassRegisterCallback to call the callback once if a device is connected (cf385c0)

Hi AKuHAK, first of all: You're welcome. But mate... This is my repo (some commits behind ifcaro's one - And the master is the later one). Please, you should send your pull requests to ifcaro's one (as recommended on my bitbucket post). BTW, I strongly encourage you to ask ifcaro for granting you write permission on his repo, so you could direct commit there, whenever you have new features and improvements to add to OPL. I also must confess that due to the real life I will probably have less time for working with PS2 Homebrew than before. Feel free for making your decision.


I have noticed that your project doesn't have CONTRIBUTING.md and CODE_OF_CONDUCT.md file!

Please assign this issue to me so that I can work into that...

Hello,
I'd like to work on this issue. Please assign it to me.
P.S: Please add gssoc-ext and hactoberfest-accepted labels


Pact contract testing

Introduce pact contract testing
Closes #164

@holly-cummins I updated the commit for the PR based on what we discussed in this comment.
Would you mind reviewing? I added documentation as well, so please review that too :)

I also added <pact_do_not_track>true</pact_do_not_track> to the surefire setup because I didn't think that https://docs.pact.io/telemetry was something we wanted enabled. Seems its enabled by default and you have to opt out of it.


Use include with references to build relations instead of left_join

Hello dear community,
Preambule
ActiveRecord handles multiple .joins calls carefully. For example, User.joins(:profile).joins(:profile) generates only one INNER JOIN statement. ActiveRecord::QueryMethods#references generates LEFT OUTER JOIN, but combination of .joins and .references with the same relation name produces correct SQL query with single INNER JOIN.
Some people often write controllers like
user = User.where(condition)
user = user.joins(:profile).where(profile: {first_name: params[:first_name]}) if params[:first_name]
user = user.joins(:profile).where(profile: {last_name: params[:last_name]}) if params[:last_name]
user = user.joins(profile).where(profile: {active: true})

and if we always use the same join style, the SQL builder will handle it and generate single INNER JOIN profiles ON ... statement. It works as "some people" expect.
Everything goes wrong when we use mix of left_joins and joins methods. The builder builds "LEFT OUTER JOIN profiles" with "INNER JOIN profiles" in the same time, in the same query. And databases (PG, for example) raise exception when meet several joins on the same table with (or without) the same aliases.
Problem
CanCanCan 2.0 used include with references to build relations for accessible_by method. CanCanCan 3.0 replaced it with left_join. As the result, a lot of legacy smelly code is broken.
For example, this code will generate invalid "LEFT OUTER JOIN profiles ON ... LEFT JOIN profiles ON` query:
# Controller:
user = User.accessible_by(current_ability)
user = user.joins(:profile).where(profile: {first_name: params[:first_name]}) if params[:first_name]
user = user.joins(:profile).where(profile: {last_name: params[:last_name]}) if params[:last_name]

# Ability:
can :read, User, profile: { active: true }

Fix
I returned old behavior. I cannot see valuable advantages to use left_join instead of the old includes.references chain. Please correct me if I'm mistaken.
Thank you.

Yes, I understand it is a new major version of gem, and it's not required to be 100% compatible with a previous one. But this very small change corrupts a lot of legacy code diligently written by people who do not think about the consequences.

The change to left_joins was made in https://github.com/CanCanCommunity/cancancan/pull/512, and I think the rationale there in terms of minimising how much loading cancan actually does makes sense. I agree there's been some teething issues though. Assuming it's causing you problems, can you please check if https://github.com/CanCanCommunity/cancancan/pull/600 fixes them?

There are different advantages in using left_joins over joins. the main issue that was tackled was the problem of eager loading too many associations when not needed.
I would consider adding an option to the accessible_by method, like accessible_by(current_ability, :index, [true|false]) to use joins instead of left_joins but I'd like to have a regression test for a case that is currently not working. I'd suggest you to open a PR, with a regression test, simulating the case that is causing the issue, or provide a gist. I'll therefore look into it more closely and decide how to proceed. Thank you!


Change Paper (PDF) should have "Summary of Changes" links jump to sections within the PDF file

Description
From Kate in Zulip:

Thanks Peter - re the internal links, we would like items listed in the summary to take the user to the relevant changes section within the PDF document and not link to the dictionary website. This is because the user needs to see the changes made and not the existing definition. Links within the changed item to existing items should go to the live dictionary.

Notes
From James in Zulip, on whether this is possible:

Yes, I think it should be. I think the easiest way is to define every key pointing at the data dictionary website, and then re-define the keys that point at topics in the change paper dita. I think the 'internal keys', 'external keys' should be correctly ordered so that if a key points to a topic within the same document that will take precedence, otherwise it'll find the external link to a url

I don't actually think this is possible with the current dita-dsl library. It should be possible to add a <keydef> to a .ditamap file like this:
<map>
  <title>Internal Links Map Key Definitions</title>
  <keydef keys='data_set_diagnostic_imaging_data_set' href='../changes.dita#data_set_diagnostic_imaging_data_set' scope='local' />
</map>

The href would represent the dita file the sub-topic is in (always changes.dita in this case), then specifically identify the topic key to link to, with scope set to local. The resulting PDF file will have any links to this keydef jump to the correct page in the PDF file, not go externally to a webpage.
The problem is that the DitaProject class does not produce this specific output for the ditamap files it does produce. The existing ditamap files produced comes from code which does not allow specifying a Dita file with topic identifier.
This will have to be considered as a future enhancement once the dita-dsl library is updated.


Add templating to Specialist

When you specify {{style}} in Specialist Task or Persona, make a new "Style" string input appear, so that it could be filled in separately.
Do this for any mustache-style placeholders in Task or Persona.

@billbyrne wants this


refactor: upgrade dependencies & transfer to Vitest

Codecov Report
Attention: Patch coverage is 92.72727% with 8 lines in your changes missing coverage. Please review.

Project coverage is 94.01%. Comparing base (c67a967) to head (28ed027).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

scripts/register.js
0.00%
7 Missing :warning:

packages/ts/common-frontend/src/ConnectionState.ts
96.42%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   98.30%   94.01%   -4.29%
==========================================
  Files           3        4       +1
  Lines         650      301     -349
  Branches       37       36       -1
==========================================
- Hits          639      283     -356
- Misses         11       18       +7

Flag
Coverage Δ

unittests
94.01% <92.72%> (-4.29%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Replace deprecated/removed auto_ptr by unique_ptr.

Signed-off-by: Daniela Engert<EMAIL_ADDRESS>

Compiles and passes assign's testsuite like vanilla develop with msvc 9.0, 10.0, 12.0 and 14.1 - the latter in C++17 mode which defines BOOST_NO_AUTO_PTR and thereby triggers the new code paths.


Incorrect alignment of radio buttons w/o text inside table

Select one ...  (check one with "x")
[x] bug
[ ] feature request
[ ] enhancement

Expected behavior
Radio buttons without text line up correctly in a table with centre alignment.
Actual behavior
Radio buttons without text appear slightly offset of centre alignment.
Reproduction of behavior
https://plnkr.co/edit/PkAqKe?p=preview
Environment details

Angular version: 4.1.2

Clarity version: 0.9.6

OS and version: Windows 10 Pro

Browser: Chrome 58.0.3029.110 (64-bit) | Firefox 53.0.3 (32-bit)

Hi @brinton-chand, I don't see this as a bug because cell content has text-align: center by default.  If cell content needs to be aligned, you could take advantage of left-aligned table cells. Example: https://plnkr.co/edit/TZjE6nr7SXE6jpriJKuv?p=preview

@brinton-chand : We haven't heard back in a while. I'm going to close this issue under the assumption that @Shijir 's workaround was satisfactory. Thanks!


Dependency graph / table are not showing same dependency relationships, many mismatches

Page: /reference/architecture/
Feedback:
There appear to be several mismatches between the "System Dependency Graph" diagram, and the table view.
For example:

the diagram indicates Echo depends on Orca
the table indicates Orca depends on Echo

Looking closely at it, there are a lot of discrepancies between them.
Which is correct? Are they supposed to represent the same information?

The table indicates that orca and echo are dependent on one another.
The table more accurately reflects the dependencies if every feature of Spinnaker is enabled, and includes dependencies relating to very low-level things like publishing events to the eventing bus or persisting configs.
The diagram is more of a conceptual overview of what spinnaker services are typically involved when performing Spinnaker operations or executing pipelines.
That said, you have a good point that we should make all of this clearer; we are working on it.


Cannot stream output

Describe the bug
为什么别人的代码是边计算边输出，我这边是计算完成后才统一输出，这是什么问题
Why the output not display rightly but display over the model caculate
Reproduction
.
System Info
Centos Stream 9, node 18.4

Used Package Manager
npm
Validations

[x] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

用了 nginx 代理吗，可能 nginx 代理配置 proxy_buffering 会把流式传输的特性搞没了

用了 nginx 代理吗，可能 nginx 代理配置 proxy_buffering 会把流式传输的特性搞没了

谢谢！已解决！


MARP-1440 Finalize chat gpt assistant fix for explain feature in v11

Hi @ivy-rew,
Currently, I am working on story https://1ivy.atlassian.net/browse/MARP-1440. When I made a release for story https://1ivy.atlassian.net/browse/MARP-747 in version 10, I encountered a compile error that required 3 arguments instead of 2.

I fixed this issue and updated the pom file to use "nightly-10.0" and running "mvn clean install".
It seems like it cannot find the library in version 10: javax.ws.rsch.ivyteam.ivy.rest.client.exec'.

I tried removing this from the MANIFEST.MF file. Now the build has passed, and it works well in version 10.

Do you agree that if I remove "javax.ws.rsch.ivyteam.ivy.rest.client.exec" in the MANIFEST.MF file for only version 10 ?


Data Request

Hello, I recently read your GraphPCA paper and was thoroughly impressed by your research and findings. The insights provided are incredibly valuable.
However, while following the tutorial provided: https://graphpca-analyses.readthedocs.io/en/latest/Tutorial1_DLPFC.html , I encountered difficulties in locating the corresponding data as per the instructions. Despite my best efforts, I was unable to find the necessary datasets to proceed with the experiments.
Could you kindly provide the following data needed in Tutorial 1:

sample_data in h5ad format
groundtruth data
SVG_list data

Your assistance in this matter would be greatly appreciated. Thank you for your time and consideration.
My email is<EMAIL_ADDRESS>

Dear Young,
Thank you for your kind words regarding our GraphPCA paper. I'm delighted to hear that you found the research and findings valuable.
I understand that you are experiencing difficulties in locating the necessary datasets for Tutorial 1. We have organized the specific files you mentioned—sample_data in h5ad format, groundtruth data, and SVG_list data—and they can be accessed at the following link:
GraphPCA_analysis - Google Drive
Note that the DLPFC raw data is too large! You can visit https://github.com/LieberInstitute/spatialLIBD to download the DLPFC data directly.
I hope this will enable you to successfully perform the algorithm outlined in our tutorial. If you have any further questions or need additional assistance, please feel free to reach out.
Best regards

Dear YANG,
Thank you very much for providing the data, they are extremely helpful. I am grateful for your prompt assistant and generosity in sharing these resources.
Best regards


panic in vendor/github.com/lucas-clemente/quic-go/h2quic/server.go:145

if qerr, ok := err.(*qerr.QuicError); !ok{
errorCode = qerr.ErrorCode  //  painc in here
s.logger.Errorf("error handling h2 request: %s", err.Error())
}

When does that panic occur?

when I  fix the above code : "!ok" -> "ok" in h2quic/server.go.144 , the error is InvalidHeadersStreamData: InternalError: TooManyOpenStreams.

You're right. Good catch!
Can you send a Pull Request with the fix please?


Popup panel on Login

I am using Authentic theme 19.07 on Ubuntu 16.04.2 with Webmin 1.872.
I switched to the night screen sometime ago as I like the darker colours, but I have noticed that I get a Popup on Login that I have never seen before.  It may not be connected to the night theme, or even the theme itself, but I am at a loss as to what it is. Even my server hosting experts dont know :/
It does not always happen and I cannot reproduce it at will. I also do not know what to click when it appears. Has anyone seen this or know what it is Please.

Thanks in advance.

Interesting.
When you see this screen, what happens if you reload the page simply?
You must update to 19.09.1, because 19.07 is dated.

Thanks for the reply. I have updated to 19.07 by forcing an update (no idea why it didn't display that it needed one).
Referring to the above jpeg, if I click on the right button, the popup closes but some of the button text on other screens are labelled "false" and not what they should be labeled until I reload the page.
If I click on the left button, the popup is closed and everything appears to be normal.
This popup does not always appear, usually at the start of day or if I have not been on WebMin for a while.
Thanks

Yes, it wouldn't display anything, there was a change at the code, regarding to versioning.
Could you force update the theme to the latest?
But before that:
Can you make sure that the session is active? Like, click at Dashboard for example and make sure that it opens. Then right click (context-menu) on the logout button and click Open at New Tab. Then  click Dashboard again, or any other link you can find.
Will you get the same popup screen again??

Did you use:

Proxy?
Servers Index?
Cloudmin?

Not as far as I know. I am logging on from my home office system where I always work.

What browser are you using?

Mac Safari V 11.0.3

Okay, I'll take a closer look on Safari. Thanks.
And it just happens after, supposedly your session expires?

Appears so, but intermittently. I just tried on Firefox, I got the Session expired popup, but not the "false" (although I dont always get that on Safari either).
Thanks in advance

Interesting.
I tried Safari in incognito mode, then terminated the session, and clicked a link - popup came with all texts in-place.
I can't reproduce it. It seems as caching issue.

Thanks. At least I know what the popup is now and what the buttons should be.
Cheers.

Cheers.
You would not be able to get false strings only on that part of the interface. It would happen all over.
The only reasonable explanation that I have is server caching that doesn't push latest files.
What is your language set to?

I don't recall setting any language field. My Mac is in English, but I dont remember setting Language on the server. Where should I check?

I think it's just English.
It's in Webmin Configuration/Language or in Webmin/Change Language and Theme.

It defaults to Global Language. Should I set the choice to English?

Check what is global set to in Webmin Configuration/Language

English US but use browser language is off.

It's all cool.
All should be just fine.

Excellent, thanks again.

hi ilia, I got the also the session expired popup with everything displaying 'false' on chrome.
strange ...

gnadelwartz: this is the dialog box it is supposed to be.  It is your session timing out and for some reason the fields are not being updated in the popup. I have not had it since the latest update (19.09.2), but it only appears sporadically anyway, so time will tell.

I'd like to know, if it happens again. I have an idea remotely of why it could happen but not sure yet.

here also! is it a issue of time?

I use Safari exclusively for my WebMin server management. It usually happens when I have closed the window as I dont usually log out. Hence when I start the browser again and select the WebMin window from my bookmarks, the session has often timed out.
I select the right "false" (re-authentice) and it unlocks things normally. Although sometimes I have seen other buttons labeled "false" even once I am in. I refresh the browser and all is labeled correctly.
Hence it is only a text issue, the labels probably have localisation associated with them, and this is not being picked up correctly. My guess anyway, as this is what happen when I have screwed up localisation in Unity.
Hope this helps. Dont stress, now I know what it is, it is no drama. ;)

No, no. It has to be perfect. I'll find the source of the issue; hate fixing just only the outcome.
Do you use private tab?
Thank you for reporting.

No, I do not use a private window. Hence my password is always cached. But it is a private computer. ;)
Cheers.

the false problem happens also on update popup

Fixed at https://github.com/qooob/authentic-theme/commit/830ee347923146ed4fe237f9b103cc3cba7ecfb4

Not sure it is fixed. Installed 19.10beta 1 and still got this.

I can not reproduce it.
Please provide steps to reproduce it. Starting from which browser and OS for client/server was that, installed browser plugins, Language settings.
Did you clear browser's cache after installing the update?

Nope, didn't clear cache. Will do that and see if it happens again.
Client is Mac osx 10.13.3, using Safari 11.0.3, no installed plugins.
Server is Ubuntu 16.04.2, Usermin 1.734, Webmin, 1.880, default language of English.

Here is the problem. I logged in to Safari, then I opened private tab, logged in and flushed the first session, when I came back, I saw the following:

I have again the same problem on tablet with Yandex browser, but this is a strange beast regarding cache. even if you clear the cache it had files in the cache for 24 more hours, may be because of android doing also some caching :-(
On Desktop it work's like it should (Yandex, Vivaldi, Chrome, Firefox) ...


Fix E2E tests - they fail intermittently

Out of many runs the E2E tests fail intermittently
see TeamCity server history:  https://sushicoin.xyz/viewType.html?buildTypeId=SushiCoin_1MainBuild&branch_SushiCoin=<default>&tab=buildTypeStatusDiv

Fixed


Add ChangeDisplayCurrencyLocal Stellar RPC

Note: I did not remove GetAccountDisplayCurrency mock yet, even though it's not used by stellar code right now (calls remote.GetAccountDisplayCurrency instead of s.remoter.GetAccountDisplayCurrency). I suspect in the future some tests might be conducted in a way where kbweb doesn't even know about the account, so this mock could be brought back then.

   record CurrencyLocal {
     string description;  // "USD ($)", "CAD ($)", etc.
     string code;         // "USD", "CAD", etc.
     string symbol;       // "$"
     string name;         // "US Dollar", "Thai Baht", etc.
   }
   array<CurrencyLocal> getDisplayCurrenciesLocal(int sessionID);

@patrickxb  should string code; be of type OutsideCurrencyCode instead?

@zapu frontend requested plain strings whenever possible.  They also didn't ask for code or name I just included them, so they might get scrapped once they start using it, who knows.

so maybe void changeDisplayCurrencyLocal(int sessionID, AccountID accountID, OutsideCurrencyCode currency); should take string as currency as well?

let's ask them what they prefer

Having both of type OutsideCurrencyCode makes it clear what the valid inputs to changeDisplayCurrencyLocal are, and where they should be sourced from.


Request to check all the contributors: 200 points received or not. If yes, move to another repo because this repo has score resctrictions

Regards,
Project Admin

hey @Sulagna-Dutta-Roy i can do this

hey @Sulagna-Dutta-Roy i can do this

This is not an Issue to work. @dhairyagothi


Use C type casting instead of static_cast.

Looks good to me

@LaszloLango: I've updated the PR.

@rtakacs, thanks. LGTM

Landed (efc994b112e30cd0a20f8a2365ea94c84bec0eec)


Start context validation

Start visiting the AST for context validation.

@amihaiemil this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2023-01-01T15:43:03.197256.
Estimation here is 60 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
If you don't have time or simply don't want to work on this, you can always resign.

@amihaiemil please keep in mind that manual assignment of tickets is a bad practice and it is discouraged. Next time, please let me elect the assignee.

@amihaiemil Don't forget to close this ticket before the deadline (2023-01-01T15:43:03). You are past the first half of the allowed period.

@amihaiemil Looks like you've missed the task deadline (2023-01-01T15:43:03). You are now resigned from this task.
Please stop working on it, you will not be paid. I will assign it to someone else soon.

@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role DEV available or because the project does not have enough funds.
Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.


Updated link to Monaco API docs...

Update dead link to Microsoft Monaco API docs.
--Thanks for the autocomplete PR

Added this in #120 with other small fixes. It will be released in BlazorMonaco v3.2.0


add patch for azure-iot-sdk-c CVE-2024-21646

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

add patch for azure-iot-sdk-c CVE-2024-21646
Change Log

add patch for azure-iot-sdk-c CVE-2024-21646
upstream patch: https://github.com/Azure/azure-uamqp-c/commit/12ddb3a31a5a97f55b06fa5d74c59a1d84ad78fe

Does this affect the toolchain?

NO
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2024-21646

Test Methodology

local package build with RUN_TEST=y
Buddy build pipeline: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=485188&view=results

Auto cherry-pick results:

main :x:

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=487273&view=results


Bump nokogiri from 1.11.4 to 1.13.3

Bumps nokogiri from 1.11.4 to 1.14.3.

Release notes
Changelog
Commits

updated-dependencies:

dependency-name: nokogiri
dependency-type: indirect
...

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>

Bumps nokogiri from 1.11.4 to 1.14.3.

Release notes
Changelog
Commits

updated-dependencies:

dependency-name: nokogiri
dependency-type: indirect
...

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>
https://github.com/sparklemotion/mechanize


Promotion Rational number to Float32 fails

In the code below, I follow the advice of the Julia language description to write my fraction as a Rational as this can be promoted to Float32, whereas 1/2 would be promoted to Float64 and requires a cast to make it Float32. It does not work, however with the @tturbo macro with error: ERROR: LoadError: promotion of types Rational{Int64} and VectorizationBase.VecUnroll{7, 16, Float32, VectorizationBase.Vec{16, Float32}} failed to change any arguments
using LoopVectorization
using BenchmarkTools

function set_ghost_cells_bot_kernel!(
    a, a_bot, a_gradbot, dzh, ks)

    # fac = 0.5f0 # This works.
    fac = 1//2 # This does not work.

    @tturbo for j in 1:size(a, 2)
        for i in 1:size(a, 1)
            a[i, j, ks-1] = -a_gradbot[i, j]*dzh[ks] + a[i, j, ks]
            a_bot[i, j] = fac * (a[i, j, ks-1] + a[i, j, ks])
        end
    end
end

TF = Float32
# TF = Float64

a = rand(TF, 50, 50, 50)
a_bot = rand(TF, 50, 50)
a_gradbot = rand(TF, 50, 50)
dzh = rand(TF, 50)
ks = 2

@btime set_ghost_cells_bot_kernel!($a, $a_bot, $a_gradbot, $dzh, $ks)

Fixed by VectorizationBase 0.12.35.

Thanks again. Thanks to this fix I have been able to implement the option for Float32 or Float64 in my code (https://github.com/Chiil/MicroHH.jl). It is amazing that with LoopVectorization I manage to reach performance comparable to an already highly optimized C++ code.


Task does not run with a hold in xcode

I have submitted a question on stackowerflow.
Could there be a bug in the this library? Because when I run the react-natove-background-fetch example app it works.

Thanks for updating.  Just for reference, the solution from Stack Overflow:

Solved. At the end I realized the background fetch checkbox was not checked in the project settings. After checking it does work.

I'll add a note about making sure this is enabled to the project readme.


connectTimeoutMS default

The default connectTimeoutMS value, as documented in the ReplSet docs, is 0.
I found the following line that suggests the default value is 10000 ms: https://github.com/christkv/mongodb-core/blob/master/lib/topologies/replset.js#L177
Which value is the correct default? Thanks!

10000 ms is the correct value, updated docs.


[SPARK-47207][CORE] Support spark.driver.timeout and DriverTimeoutPlugin

What changes were proposed in this pull request?
This PR aims to support spark.driver.timeout and DriverTimeoutPlugin.
Why are the changes needed?
Sometime, Spark applications fall into abnormal situation and hang.
We had better provide a way to guarantee the termination after pre-defined timeout via a standard way.

spark.plugins=org.apache.spark.deploy.DriverTimeoutPlugin
spark.driver.timeout=1min

$ bin/spark-shell -c spark.plugins=org.apache.spark.deploy.DriverTimeoutPlugin -c spark.driver.timeout=1min
Setting default log level to "WARN".
To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
Welcome to
      ____              __
     / __/__  ___ _____/ /__
    _\ \/ _ \/ _ `/ __/  '_/
   /___/ .__/\_,_/_/ /_/\_\   version 4.0.0-SNAPSHOT
      /_/

Using Scala version 2.13.12 (OpenJDK 64-Bit Server VM, Java 17.0.10)
Type in expressions to have them evaluated.
Type :help for more information.
24/02/28 06:53:34 WARN NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
Spark context Web UI available at http://localhost:4040
Spark context available as 'sc' (master = local[*], app id = local-1709132014477).
Spark session available as 'spark'.

scala> 24/02/28 06:54:34 WARN DriverTimeoutDriverPlugin: Terminate Driver JVM because it runs after 1 minute

$ echo $?
124

Does this PR introduce any user-facing change?
No, this is a new feature and a built-in plugin.
How was this patch tested?
Manually because this invokes System.exit.

Timeout with 1 minute

$ bin/spark-shell -c spark.plugins=org.apache.spark.deploy.DriverTimeoutPlugin -c spark.driver.timeout=1min
...
scala> 24/02/28 06:54:34 WARN DriverTimeoutDriverPlugin: Terminate Driver JVM because it runs after 1 minute

$ echo $?
124

DriverTimeoutPlugin will be ignored if the default value of spark.driver.timeout is used.

$ bin/spark-shell -c spark.plugins=org.apache.spark.deploy.DriverTimeoutPlugin
...
24/02/28 01:02:57 WARN DriverTimeoutDriverPlugin: Disabled with the timeout value 0.
...
scala>

spark.driver.timeout will be ignored if DriverTimeoutPlugin is not provided.

Was this patch authored or co-authored using generative AI tooling?
No.

Could you review this PR too, @LuciferYang ?

The PR is updated according to your advice, @LuciferYang .

Thank you so much! Merged to master for Apache Spark 4.0.0. This plugin PR is irrelevant to CIs.


Exporting prototypes fail due to error when trying to analyze/flatten symbols

Sorry, for adding another one… 😅
Description
As of Sketch 80+ the export fails, due to some error in the /command-export-html.js. It seems like the plugin has some trouble analyzing the Sketch document.
Outcome

The export fails and no error or success message is displayed within Sketch.
The export destination (folder) only contains an image of the first screen. Indicating that the export failed already on the first screen/artboard.
Within the Sketch document, the element that lead to the failure of the export (e.g. an navigation header symbol), has been duplicated and detached from the original symbol.

Screenshots
Below I've added two screen grabs from the Sketch DevTools console:

Fixed in v0.2.9 (commit 3ad002dcf1c69b1cd9bded7f4923335f6e57694f)


Cannot start a container on windows because of mount error

All worked fine, and from some reason stopped working.
I cannot start a container, and windows restart did not work. This is the error:
Caused by: com.github.dockerjava.api.exception.InternalServerErrorException: {"message":"error while creating mount source path '/c/mydir/myproject/.testcontainers-tmp-XVoe9': chown /c/mydir/myproject/.testcontainers-tmp-XVoe9: no such file or directory"}
any help will be appreciated

Hi @ori-n! What are you using, Docker for Windows or docker-machine (as part of Docker Toolbox)?

win10 with docker for win

Did you share the directory with your Docker for Windows installation? There is a tab for shared drives in GUI.

the share is probably the default - entire HD drive.
Again - it worked, and from some reason stopped working

Funny, (or not, not sure). Restarted docker and it works again.
weird that last time I check windows restart did not help...

I think as a default, nothing is shared.
And I myself have problems with the Windows permissions when sharing these drives with Docker, so not sure about the maturity of this Docker feature on Windows.
Can we assume this is a Docker for Windows specific problem and has nothing to do with Testcontainers? I'd close the ticket in this case.

I tried both docker on win 10 (not toolbox) and ubuntu and got the same result

From: Kevin Wittek<EMAIL_ADDRESS>Sent: Sunday, December 10, 2017 12:32 PM
To: testcontainers/testcontainers-java
Cc: ori-n; Mention
Subject: Re: [testcontainers/testcontainers-java] Cannot start a container on windows because of mount error (#481)
Closed #481https://github.com/testcontainers/testcontainers-java/issues/481.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/testcontainers/testcontainers-java/issues/481#event-1380312882, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfvrAJ0K6zAgujQPcKaJy9bmgxJj1xJCks5s-7NJgaJpZM4QPppK.

Can you please share your code?
Are you sure wanted to answer to this issue, since you've stated on Nov 07 that it worked for you?

Sorry my bad, posted to the wrong thread. Please close the issue.
Every time I run to this problem I restart docker for win and then it works as expected. Guess it is a docker issue

From: Kevin Wittek<EMAIL_ADDRESS>Sent: Sunday, December 10, 2017 1:23 PM
To: testcontainers/testcontainers-java
Cc: ori-n; Mention
Subject: Re: [testcontainers/testcontainers-java] Cannot start a container on windows because of mount error (#481)
Can you please share your code?
Are you sure wanted to answer to this issue, since you've stated on Nov 07 that it worked for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/testcontainers/testcontainers-java/issues/481#issuecomment-350541392, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfvrAG8k2fU5DBxkmme3uqvC374utQgpks5s-79GgaJpZM4QPppK.


When a column is missing data fromCsv yields incorrect output

Totally possible that this is user error, but this test fails which I find strange
const csv_string = """"first","second",third"
1,2,3
1,,3
"""

type Row = object
  first,second,third: string

let rows = csv_string.fromCsv(seq[Row])

doAssert  rows == @[Row(first: "1", second: "2", third: "3"), Row(first: "1", second: "", third: "3")]

Is there something else I'm supposed to do here to handle missing data?

You are missing double quotes starting at third". Other wise this works:
block:
  # When a column is missing data fromCsv yields incorrect output.
  const csvData = """"first","second","third"
1,2,3
1,,3
"""

  type Row = object
    first, second, third: string

  let rows = csvData.fromCsv(seq[Row])

  echo rows

  doAssert rows == @[
    Row(first: "1", second: "2", third: "3"),
    Row(first: "1", second: "", third: "3")
  ]


[1.21][Fabric] Crashes near structures generated by Repurposed Structures

So basically I was roaming in my world and suddenly I saw a Overworld End City (from Repurposed Structures) and shortly after, my game crashed. So after I removed Repurposed Structures, the structure is visible, but no crash. I reenabled the mod again and located (using the locate command) to find another repurposed structure in an unloaded chunk, found it, teleported to it and it crashed again.
Crash Report - https://mclo.gs/jHp3a1D
Latest.log - https://mclo.gs/PbImesw

#14


how did you project the estimated segmentation on the corresponding RGB images?

Hi, thanks for sharing your great work. I saw the predicted segmentation is projected on the RGB images in Figure 1  in your paper. Some are dotted and some are transparent squares. What's the meaning of them? And how to visualize them?

Hey!
Thanks for the kind words :) The dots correspond to the bird's-eye view vehicle segmentation that has been discretised and projected back into the RGB image. The transparent paths correspond to the future trajectories in bird's-eye view projected to RGB.
To obtain these, you need to use the intrinsics and extrinsics to go from bird's-eye view space to image space.

Thanks a lot for your quick reply. The visualizing code in this repo doesn't include this part right?

Could you please help me figure out how to go from bird's-eye view space to image space in detail?

I wrote this part by myself, but it didn't work. Could you please release this visualization part? This is very important to me.


PPL fieldsummary command

Description
This PR implements the fieldsummary PPL command.
Issues Resolved
https://github.com/opensearch-project/opensearch-spark/issues/662
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Would you mind change the PR status to DRAFT if you are going to refactor?

@LantaoJin plz review
I've removed the topValues in favour of performance - and added the next issue for enhancement of the top, rare commands


Code formatting and links not working together

Contributions

[X] I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates
These 3 pages have typos in formatting:

https://docs.getdbt.com/reference/dbt-classes
https://docs.getdbt.com/reference/dbt-jinja-functions/ref
https://docs.getdbt.com/guides/migration/versions/upgrading-to-v1.0

What part(s) of the page would you like to see updated?
Here are screenshots of each (with the erroneous section highlighted in blue):
https://docs.getdbt.com/reference/dbt-classes

https://docs.getdbt.com/reference/dbt-jinja-functions/ref

https://docs.getdbt.com/guides/migration/versions/upgrading-to-v1.0

Additional information
I did not investigate further or try any fixes.

Looks like this has been fixed


fix: update layout tokens to match IDL

Closes #469
Changelog
Changed

layout tokens

token
current(mu)
IDL(mu)

layout01
2
1

layout02
3
2

layout03
4
3

layout04
6
4

layout05
8
6

layout06
12
8

layout07
20
10

layout08

12

layout09

15

@vpicone should we update these in scss as well?

We had a solid convo about this, and in the end we decided that having two disparate but overlapping spacing and layout scales without a clear definition of when each would be used isn't worth the overhead.
The layout scale could be combined to include the spacing scale by adding a 1/2mu value at the bottom end of the scale. I'd have to dig a bit to see if this would cause issues with components.

The layout tokens are used in a couple places in carbon-components, so when we update the vendor tokens we'll need to also correct that.

Yeah! Sounds good @vpicone. We should add some docs on the process either in carbon-components or carbon-elements too 👍

Rather than change the layout tokens, I've just consolidated the missing layout tokens into the spacing scale.
In this way, we can switch to using the combined spacing scale rather than maintaining to conflicting/disparate scales. This approach also prevents breaking changes downstream.
Eventually the layout tokens can be deprecated.


[ISSUE] Clans not being added to object manager

For New Contributors
How to contribute
Description

Clans are currently not being added to the object manager
Intended Design

Clans being added to the object manager
Location

Create a branch based from development
Related Issues

Requirements

Additional information

Definition of Done

[ ] Class level comments exist for all new classes.
[ ] XUnit tests exist for every method that does not require the game to be ran.

Is this a server or a client issue?

A both issue, there's no place they are added. There's a list for it so I would guess the idea is to have it in there.