acs commons report unable to download complete data

Required Information

[x] AEM Version, including Service Packs 6.5.9, Cumulative Fix Packs, etc: _______
[x] ACS AEM Commons Version: _5.0.6
[x] Reproducible on Latest? yes/no

Expected Behavior
In report all data will be displayed from start date to end date .
Actual Behavior
In report download csv file not all data is shown some recent date uploaded assets  are not shown.
Steps to Reproduce
Starting from a vanilla instance of AEM at the above version, describe in explicit steps how to reproduce. Link to
any supporting assets, e.g. content packages, below
Links
_

please give inputs to resolve for this issue

Basically It is occurring in production not in lower environments, In production we have 140000 assets but our downloaded report is showing around 85000 assets data only. we all packages ui, content, apps

@ranjith129143 are there any errors in the log when it fails to collect all results?  Also, what version of AEM are you on? I know AEM CS has a request timeout limit .. thought that doesnt sound right since you are getting something back..
140k assets is gonna be a hard one to validate locally :P
@klcodanr  not sure if you have any thoughts off the top of your head.

Aem  version 6.5.9 and acs commons 5.0.6 . In production we don't have
access for system console to check logs. As I am it because more number
nodes query should search and fetch  the data there cause some time out or
stopping the process  in middle .
On Wed, Jun 15, 2022, 23:27 david g. @.***> wrote:

@ranjith129143 https://github.com/ranjith129143 are there any errors in
the log when it fails to collect all results? Also, what version of AEM are
you on? I know AEM CS has a request timeout limit .. thought that doesnt
sound right since you are getting something back..
140k assets is gonna be a hard one to validate locally :P
@klcodanr https://github.com/klcodanr not sure if you have any thoughts
off the top of your head.
—
Reply to this email directly, view it on GitHub
https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2861#issuecomment-1156768943,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGRDIN5DQRBZM7NH2YC5RPLVPIKPPANCNFSM5YXHBXLQ
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

i would imagine that you would get 0 results if the query was failing - since the query will fail in oak query engine, even before any results are made available to the ACS report tool.
There's now way you can have your Admin team get you teh logs that contain the report run to see if there's anything of note?

Sure, will do that.
On Wed, Jun 15, 2022, 23:40 david g. @.***> wrote:

i would imagine that you would get 0 results if the query was failing -
since the query will fail in oak query engine, even before any results are
made available to the ACS report tool.
There's now way you can have your Admin team get you teh logs that contain
the report run to see if there's anything of note?
—
Reply to this email directly, view it on GitHub
https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2861#issuecomment-1156780311,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGRDIN66QFU7FRLWW7SXIE3VPIMCPANCNFSM5YXHBXLQ
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

If we increase this limit 100000 to some higher number there is an issue ?

Hi David, please give me your inputs


GA: Custom reporting in API

Configure advanced visitor enagement reports using GA API.

Do not understand the requirement

Built in Google Analytics reports are fairly rudimentary when it comes to analyzing visitor behavior across visits. Currently, the best we can do is report on the visit number for each visitor that takes place within a time frame. You can see this explained in depth here: https://support.google.com/analytics/answer/1032796?hl=en. I don't think that this report is of great use to you.
Using bounce rate, pages per session, and eventually per-session conversion rates, we have the ability to analyze visitor engagement /within/ a visit, but we're lacking ways to look at visitor engagement /across/ visits. I think that some information that will be of particular use to FreeUKGenealogy is a report that buckets the number visitors by the number of visits per month. For example a report that would have the number of visitors as the metric, and the primary dimension broken down into something like somewhat engaged (1-2 visits per month), engaged (2-5 visits per month), and very engaged (5-10 visits per month).
I believe it is possible to create this report using the new "Dimension Buckets" feature in Google Analytics API. More information can be found here: https://www.bounteous.com/insights/2017/07/27/google-analytics-api-v4-histogram-buckets/
This report can be generated through the API and configuration /only/. Meaning it requires no additional development effort above what is already implemented. This will not have an impact on your data that has already been collected/is being reported through other tools, such as the Google Analytics reporting interface. .
In order to get started on it, I need either involvement from someone with admin privileges on one of your GA accounts, or to be given administrative permissions on one of your accounts so that I can give permissions to the service that I've created. I prefer to be given administrative permissions so that I can work on my own schedule and not require outside assistance on this effort. @richpomfret @DeniseColbert  please take a look at my email to you regarding this subject, which I'm about to send. Thanks!


[release/1.1] Correctly handle reading from events channel

Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

Codecov Report

Merging #2311 into release/1.1 will increase coverage by 4.53%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/1.1    #2311      +/-   ##
===============================================
+ Coverage        45.54%   50.07%   +4.53%
===============================================
  Files               83       75       -8
  Lines             9185     7269    -1916
===============================================
- Hits              4183     3640     -543
+ Misses            4326     2956    -1370
+ Partials           676      673       -3

Flag
Coverage Δ

#linux
50.07% <ø> (ø)
:arrow_up:

#windows
?

Impacted Files
Coverage Δ

remotes/docker/auth.go
63.82% <0%> (-3.97%)
:arrow_down:

remotes/docker/status.go
21.42% <0%> (-3.58%)
:arrow_down:

platforms/cpuinfo.go
4.65% <0%> (-1.01%)
:arrow_down:

log/context.go
36.84% <0%> (-0.66%)
:arrow_down:

namespaces/context.go
55% <0%> (-0.56%)
:arrow_down:

errdefs/grpc.go
74.6% <0%> (-0.4%)
:arrow_down:

content/content.go
0% <0%> (ø)
:arrow_up:

namespaces/grpc.go
62.5% <0%> (ø)
:arrow_up:

platforms/defaults.go
100% <0%> (ø)
:arrow_up:

labels/validate.go
100% <0%> (ø)
:arrow_up:

... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 209a7fc...7c2f0f4. Read the comment docs.

LGTM
appveyor is MIA, will wait a bit longer since it seems to be backed up before merging

LGTM

Appveyor had its chance, just going to merge it since it passed on master already


Fixed bad doc

An example contained "once-bind" which is not present.
fixed to use "once-text"

@rafgeekee thanks!


chore: update renovate config to un-pin dev deps

In other nodejs repos we tend to update the renovate config to stop pinning dev dependencies.  It's a bit of a weird default.

/gcbrun


[just text nits] Update hooks-intro.md documentation

Just a small handful of text changes, I couldn't help myself. Some things were redundant or phrased slightly strangely, some things were small grammar nits.

Hello @davidchang!
Unfortunately, the text you modify in this PR is no longer present in the documentation, so let me close this PR as outdated.
Please feel free to open new PRs for other open issues.


Implements DAO pattern

Hi @viniciusbds
Could you please add more context to this?
I'd like to pick it up


Fix API key parameter

This changeset modifies the api_key parameter, which seems to be incorrect. The appropriate parameter is key, as stated in https://developers.google.com/youtube/v3/docs/standard_parameters.

Fixed


Best fork of this library?

From what I can tell this library looks abandoned. Can anyone recommend a good fork? Ideally with support for React 16 and ES6.

I'm not sure about the best fork, but I'm quite happy with rodal. It works fine with the latest version of React, and I also integrated it with Redux.

Thanks I'll have a look at that.

@iMerica, you can check out my fork: https://github.com/Maxim-Mazurok/boron
I've added as little changes as it takes to get it working with React 16.
Also, I've added a pull request: #49

@Maxim-Mazurok how do use yours? I tried to put github url in package.json but it doesn't seems to work.

@pencilcheck thanks for a good question!
I've published my fork to npm: https://www.npmjs.com/package/boron-15
So, you can install it just like a regular npm package: npm install boron-15 --save (note, now it's called borron-15)
Also, I've updated Usage section of Readme, so you can use it as an example for your app.


Cosmos: Get Reward Modal

Reward Modal (Mockup)
As a user, I want to be able to claim my staking rewards

Progress Column
As a user, I want to know what steps are required to Claim rewards and which step I’m on

Step 1: Confirm Details with animated spinner
Step 2: Broadcast TX

Confirm Details

As a user, I want to be able to confirm the details of my staking transaction before executing

The following details are displayed on the confirmation screen

Copy: Confirm Claim Staking Rewards
[Amount to Claim in fiat and crypto]
Gas Fee: Gas cost in both crypto and fiat

User can select Low, Med, High

Copy: Your rewards will be deposited into your primary wallet.

Adding mocks to improve clarity on requirements:


When try to call android test purchase

[ERROR] :  E/IABUtil/Security: Purchase verification failed: missing data.
[ERROR] :  IabHelper: In-app billing error: Purchase signature verification FAILED for sku android.test.purchased
Can you tell me what's wrong there ?

I'm not the contributor to that module but what I found is that static responses breaks verification. Some people suggested not to try them at all as they prevent testing of further purchases.


How to hide some participate Checkbox in table rows

There is a 'loading more' button in my table, and I also need checkbox to download some files.And some trouble comes to me.

If I put the 'Loading more' button in the 'Table Footer', when  table data can't fill all table , the button will present in the bottom of page, there is a huge blank area on the page. I need this button always lean against the table rows, I mean the last line rows.

2.If I put the "loading more "button in 'Table Row'. when I add the 'displayRowCheckbox' attr in 'Table body', it also put a checkbox in the button table row.

I want to custom the table row checkbox, How to fix it?

Please submit support requests and questions to StackOverflow using the tag material-ui. StackOverflow is better suited for this kind of support. The issue tracker is for bug reports and feature discussions. See also our CONTRIBUTING guidelines.


feat: implement intro section component

Checklist before merging

[x] Link an issue with the pull request
[x] Ensure no errors or warnings on the browser console
[ ] Avoid additional major pushes after approval (if necessary, request a new review)

수고하셨습니다!


The caching algorithm should observe the max-age headers

This is the foremost priority, dropping back to Last-Modified with a heuristic as per RFC7234
This replaces the behaviour where the max-age headers were not considered at the time of caching, and where very recently Last-Modified pages were NOT allowed in the cache either way.
This change introduces some additional tests, with some test refactoring to avoid too many repeated constants.
It also centralises the logic for eviction and ingress into the cache.
It's a potential fix for #432

Great thanks, can you please add your real name to the list of authors for both changed files.

and on my machine contentWithLastModifiedTimeIsCachedAfterAFewPercentOfCreationAge fails - maybe because of date format issues (only a wild guess have not analyzed this)

@rbri test failure was a minor test design issue - mixing hard coded time with calculated times. My mistake. I was rushing on a Friday evening. I've changed it to use per test constants relating to now and that should sort it out.
I've also modified the authors as requested.

many thanks, feel free to provide more of this


Confusing path shown in --usage output

Version(s)
0.1.18 installed via cs install scala-experimental
Describe the bug
When scala shows the “usage” instructions it shows a confusing path for the scala executable itself:
$ scala test --usage
Usage: /home/julien/.local/share/coursier/bin/.scala.aux test [options]

To Reproduce

Install scala via cs install scala-experimental
Run scala test --usage

Expected behaviour
$ scala test --usage
Usage: scala test [options]

I wonder if that problem would go away after we actually replace the scala Coursier app with the content of the scala-experimental app?

I think the issue is related to the fast that we use the name of the current executable, which is actually the .aux file. This was fixed for completions so might be the same issue.


Submitting batches via bulk.load when access key has expired errors out

If I instantiate a Connection using a refresh token, and then use the Connection to bulk load records, I receive an error if the access token is invalid.
When the access token has expired the returned HTTP status code is 400, not 401 as expected. This causes the Connection to return an error rather then trying to fetch another access token.

I've mistakenly created pull request on this issue. This PR should be for #132.


Unable to run gulp serve

Was following instructions to run the source, was able to run Spring MVC on 9000 but angular gulp is failing.
Just wondering why gulp and not the simple neat "ng serve"
Below is the error:

and the CLI versions:

This project is under maintenance which used the legacy AngularJS(aka Angular 1.x),  no more new features added in the future. If you are looking for the new Spring Boot 2 and Angular 2+, check https://github.com/hantsy/angular-spring-reactive-sample

Ok. thanks for your swift reply! Let me check the new repo.


Update title/abstract; draft email to SciPy 2019 attendees

Title: Bayesian Data Science: Probabilistic Programming
Abstract: This tutorial will introduce you to the wonderful world of Bayesian data science through the lens of probabilistic programming. In the first hour of the tutorial, we will begin reintroduce the key concept of probability distributions via hacker statistics, hands-on simulation and telling stories of the data-generation processes. We will also cover the basics joint and conditional probability, and Bayes' rule and Bayesian inference. In the latter 2/3 of the tutorial, we will use a series of models to build your familiarity with PyMC3, showcasing how to perform the foundational inference tasks of group comparison and arbitrary curve regression. By the end of this tutorial, you will be equipped with a solid grounding in Bayesian inference, able to write arbitrary models, and have experienced basic model checking workflow.
Notes to registered attendees:
Dear all,
We (Hugo and myself) have reviewed the tutorial schedule, and after discussing with the SciPy tutorial committee and the instructors before and after us in the schedule, we have proposed to deliver a tutorial that focuses on probabilistic programming instead of simulation. The tutorial committee has given us the green light for this change, and we thought it would be only right to inform you of the change and guide you on how to best prepare for the updated tutorial.
The motivation is as follows: Our simulation-based tutorial covers the basic concepts of Bayesian inference through the lens of simulation, which overlaps with Allen Downey's content. In addition, the tutorial after us covers Bayesian model checking using ArviZ, for which it would be very helpful to have had a longer session on probabilistic programming first. Taken together, we envision this as a "Bayes Track"-ish series at SciPy, where our tutorials can exist independently (because we do have enough recap on our own), but complement each other very well nonetheless; the sections that overlap hopefully give sufficient repetition for learning without being overly repetitive.
As such, this tutorial requires basic knowledge in Bayesian inference and probability. You can gain this knowledge for SciPy 2019 in one of two ways. You may either

register for Allen Downey's "Bayesian Statistics Made Simple" tutorial, or
watch our PyCon 2019 tutorial "Bayesian Data Science: Simulation".

Attendance in Allen's tutorial is not a mandatory prerequisite, but highly encouraged; that said, we will cover enough material to ground our material in the recap. Additionally, if you would like to have a stronger grounding on probabilistic programming prior to attending the ArviZ tutorial led by Ravin Kumar and Colin Carroll, our tutorial would be a helpful starting point, though they will also be covering the basics of probabilistic programming for their tutorial. With that all said, we think attending all three would be extremely beneficial for your knowledge development in Bayesian inference!
If you have questions regarding the tutorial, please feel free to reach out to us. Our preferred method of communication is on the GitHub issue tracker, where questions we have addressed before can be publicly viewable by others and searchable.
Cheers,
Eric & Hugo

LGTM

I would challenge SciPy attendees to go to ALL 3 Bayesian tutorials.

In abstract, how about edit

In this tutorial, we will begin by recapping probability distributions and their "generative stories"

to

In this tutorial, we will begin by re-introducing the key concept of probability distributions via hacker statistics, hands-on simulation and telling stories of the data-generation processes.

?

I would challenge SciPy attendees to go to ALL 3 Bayesian tutorials.

Belly of fire there, Hugo! 😆
I'll encourage them to go for it. We're from British colonies, we're supposed to be un-American
and nice (whoops!!!!!, I jest!!!!).

We could have a give-away for people who attend all 3 Bayesian tutorials, in which the winner probably gets a prize.

I support at @hugobowne's challenge and happy to with a prize and bestow honor upon such a committed attendee!

LGTM!

We look good to go here.


Unsupported operation: Platform._operatingSystem

  Directionality Directionality:file:///D:/soft/Flutter/flutter_windows_2.0.4-stable/flutter/.pub-cache/hosted/pub.flutter-io.cn/get-4.3.8/lib/get_navigation/src/root/get_material_app.dart:217:12
When the exception was thrown, this was the stack:
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 251:49     throw_
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/patch/io_patch.dart 244:5                  _operatingSystem
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/io/platform_impl.dart 56:40                                         get operatingSystem
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/io/platform.dart 64:45                                              get _operatingSystem
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 835:8  get
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/io/platform.dart 106:51                                             get isAndroid
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 835:8  get

web Flutter2.5

Having this same issue.

I got the same issue with Web Flutter 2.5.3
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.5.3, on macOS 12.1 21C52 darwin-x64, locale en-KH)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[✓] Android Studio (version 2020.3)
[✓] VS Code (version 1.63.2)
[✓] Connected device (1 available)
• No issues found!

My issue error:
[GETX] Instance "GetMaterialController" has been created
[GETX] Instance "GetMaterialController" has been initialized
════════ Exception caught by widgets library ═══════════════════════════════════
The following UnsupportedError was thrown building Builder:
Unsupported operation: Platform._operatingSystem
The relevant error-causing widget was
GetMaterialApp
lib/main.dart:35
When the exception was thrown, this was the stack
dart-sdk/lib/internal/js_dev_runtime/private/ddc_runtime/errors.dart 251:49     throw
dart-sdk/lib/_internal/js_dev_runtime/patch/io_patch.dart 244:5                  _operatingSystem
dart-sdk/lib/io/platform_impl.dart 56:40                                         get operatingSystem
dart-sdk/lib/io/platform.dart 64:45                                              get _operatingSystem
...

I found my problem is an error with another package of google_mobile_ads not supported in a web browser, not GetX.
I solved with code:
if (!kIsWeb)


only allow string and int storage schema paths

graph and generic storage schema types are the other two which seem to be usable. Did you learn something about them which indicates we should omit them?

In conversation with Apstra engineering, I found out that that only
iba_integer_data and iba_string_data are appropriate for use.
On Wed, Jul 17, 2024, 2:22 AM chrismarget-j @.***>
wrote:

graph and generic storage schema types are the other two which seem to be
usable. Did you learn something about them which indicates we should omit
them?
—
Reply to this email directly, view it on GitHub
https://github.com/Juniper/terraform-provider-apstra/pull/726#issuecomment-2231808457,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARW4W4KDKNF7MB62LV54ILZMWB2NAVCNFSM6AAAAABK7AQXU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRHAYDQNBVG4
.
You are receiving this because you authored the thread.Message ID:
@.***>


Invoking sudo commands from Windows CLI requires password

When  I run the following command from the Windows CLI it asks me my password:
> bash -c "sudo apt-get update"
[sudo] password for myuser:

Expected results

I was expecting not to type password. Otherwise, I can't run some commands automatically from a windows batch script.
If I run the command directly from the Bash, it works well without a password:
> bash
$ sudo apt-get update
... (updating)

Actual results (with terminal output if applicable)

I've checked that myuser is a member of sudo group:
> bash -c "id"
uid=1000(myuser) gid=1000(myuser) groups=1000(myuser),4(adm),24(cdrom),27(sudo),30(dip),46(plugdev)

Your Windows build number

14393
Thanks in advance!!

As expected.
The way to get around this is to add the exact commands you want executable without a password to the sudoers file.

Or you can lxrun / setdefaultuser root and never ask for sudo again.

Note that sudo caches/remembers your authentication for a short time.  So if you have typed your password once, you may not need to type it again for a while, depending on your environment.  I'm guessing that's why you found that you didn't need to type your password at an interactive shell.

The way to get around this is to add the exact commands you want executable without a password to the sudoers file.

@fpqc In Ubuntu Linux (even in Bash on Windows) I can run any sudo <command> without typing the password, without modifying the sudoers, whenever the user is a member of the group named sudo. So I still do not understand why that's not working the same way when I invoke the same command from Windows CLI...
Anyway, adding the command(s) to the sudoers file is not a valid workaround for me, as I can't modify sudoers file in an automated way (it will also ask password)...
So as far as I understand, the only way to invoke Linux commands as root from Windows CLI, is changing default user to root and reversing it after as @ddfznt suggested.
Thanks everybody

Make sure to place username ALL=(ALL) NOPASSWD:ALL beneath %sudo  ALL=(ALL:ALL) ALL since it will use the last entry that applies to the user.
You could also just replace %sudo  ALL=(ALL:ALL) ALL with %sudo  ALL=(ALL) NOPASSWD:ALL and not worry about your entry placement.

Hi! just wanted to leave a Solution that works for me: I'm using password in a pipe to sudo "-S" (for stdin)
for example, in a Powershelll.ps1 file:
$pass = "yourSudopassword"

wsl.exe -- echo "$pass" `| sudo -S ls /var/

wsl.exe -- echo "$pass" `| sudo -S apt update

wsl.exe -- echo "$pass" `| sudo -S apt install ansible -y

wsl.exe -- ansible --version

note: This isn't idea for security as your .bash_history will record password. But it's just a quick & dirty hack.
credits: WSL Tips and Tricks

Hi! just wanted to leave a Solution that works for me: I'm using password in a pipe to sudo "-S" (for stdin)
for example, in a Powershelll.ps1 file:
$pass = "yourSudopassword"

wsl.exe -- echo "$pass" `| sudo -S ls /var/

wsl.exe -- echo "$pass" `| sudo -S apt update

wsl.exe -- echo "$pass" `| sudo -S apt install ansible -y

wsl.exe -- ansible --version

note: This isn't great for Security as your .bash_history will record password! But it's just a quick & dirty hack.
credits: WSL Tips and Tricks
P.S. anyone found a more Modern way of doing it? that's safer?

Hi! just wanted to leave a Solution that works for me: I'm using password in a pipe to sudo "-S" (for stdin)
for example:
$pass = "yourSudopassword"

wsl.exe -- echo "$pass" `| sudo -S ls /var/

wsl.exe -- echo "$pass" `| sudo -S apt update

wsl.exe -- echo "$pass" `| sudo -S apt install ansible -y

wsl.exe -- ansible --version

-> in a Powershell.ps1 script
note: This is bad for Security as your .bash_history will record password! But it's a quick & dirty hack.
credits: WSL Tips and Tricks
P.S. anyone found a more Modern way of doing it? that's safer?


IOU - Text input is extremely small and there's no indication on where the user should click to write

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Expected Result:
Text input should be clear so the user knows where to enter the amount.
Actual Result:
Text input is not clear and the area where is clickable is really small.
Action Performed:

Login with a expensifail account in e.cash
Navigate to a conversation
Click on the + button and select request money
Click outside the text input area so focus is lost
Try to click on the text input area

Workaround:
Unknown
Platform:
Where is this issue occurring?
Web ✔
iOS
Android
Desktop App
Mobile Web
Version Number: 1.0.50-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
View all open jobs on Upwork

From @parasharrajat https://expensify.slack.com/archives/C01GTK53T8Q/p1621545338096700

Can't input the Amount on the Split Bill page if we lose focus from the Input after opening the split Page. We can't focus back input is not visible on web. Same when we choose any currency and go back to the amount step

Triggered auto assignment to @mateocole (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

CC @marcaaron. I'm not sure you have a PR for this ghost text, but if so I think we can close this issue.

I can see this change on main, so it must have been merged 🎉


Issue #105 - PMDise Catalog Metadata

Added a new CLI command which strips out the DCAT catalog metadata out of the file.csv-metadata.json file and drops it into a file.csv-metadata.json.nq N-Quads file.
$ pmdutils dcat pmdify --help
Usage: pmdutils dcat pmdify [OPTIONS] CSVW_METADATA_FILE BASE_URI
                            DATA_GRAPH_URI CATALOG_METADATA_GRAPH_URI

  Given a local CSV-W metadata file, re-work the DCATv2 metadata such that it
  ends up in the format required for PMD.

  Outputs an N-Quads file containing PMDCAT metadata at
  <CSVW_METADATA_FILE>.nq

CSVW_METADATA_FILE - the .csv-metadata.json CSV-W file.
BASE_URI - the base URI which URIs inside the CSV-W are relative to (generally the URL of the directory holding the CSV-W).
DATA_GRAPH_URI - the graph URI which the skos:ConceptScheme/qb:DataSet in to be held within.
CATALOG_METADATA_GRAPH_URI - the graph URI which the DCAT metadata will be uploaded to.

Satisfies Issue #105

I stripping out the catalog data from a unified file necessary for PMD to process it? @robons

I stripping out the catalog data from a unified file necessary for PMD to process it? @robons

Since we're separating it out into a separate graph/file we don't want to duplicate the information we're uploading.


Test empty file for resumable media issue repro

Issue 62
Support non-buffered streams for 'ResumableUpload'.
Empty file upload is been tested.

@mf2199 @AVaksman
Please review

I do not see necessity for this PR. If the code had been thoroughly tested and the issue was not reproduced, then a simple statement in the comments would suffice. Otherwise we would have to think of a solution which would be of a feature request type. In that case, we would need a well thought through design document.

I do not see necessity for this PR. If the code had been thoroughly tested and the issue was not reproduced, then a simple statement in the comments would suffice. Otherwise we would have to think of a solution which would be of a feature request type. In that case, we would need a well thought through design document.

Yes. This was not reproducible. But still added tests as this seems to be missing for this specific work flow.
But yes we need to add the feature for this issue.


setting the default compute instance environment as compute

Hi,
I am still confused with how you would you use the default environment on a compute instance.  I have already configured it manually going onto to doing the required conda/pip installs jupyterlab.  I want to use it as a compute target with the python sdk.
Would I have to enable/disable docker options, the image, and I don't want to redefine my environment?  Though I just want to use the default conda environment on there: azureml_py36
Many thanks,
George

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b49515ab-308d-8e5d-0960-40ce43d4752d
Version Independent ID: 651348fd-f173-55c0-8199-68c0eac7b043
Content: Use compute targets for model training - Azure Machine Learning
Content Source: articles/machine-learning/how-to-set-up-training-targets.md
Service: machine-learning
Sub-service: core
GitHub Login: @sdgilley
Microsoft Alias: sgilley

@ggerogiokas Thanks for the question. I believe you want to use an environment along with the SDK while using it with compute target. Here is an example from the How to use environments page to use an environment for compute target.
Here is another example notebook to use the estimator with compute target and an environment that installs the conda dependencies.

Hi,
Thanks, I have followed some of the bits on managing environment and
registering an environment which should make it reusable in a new compute
instance.
However, in my case it doesn't seem to work.  In the meanwhile I am trying
to create a clean conda environment in the compute instance where I got it
working in a different environment which
does not work when I try to reproduce in a different compute.
Just wondering if you are familiar with the following error below during my
image-build.  Is there someway of updating the conda version in these
environments?  That might solve the issue.
llecting azureml-samples==0+unknown (from -r

/azureml-environment-setup/condaenv.dxi_0178.requirements.txt (line 39))
[91m  ERROR: Could not find a version that satisfies the requirement
azureml-samples==0+unknown (from -r
/azureml-environment-setup/condaenv.dxi_0178.requirements.txt (line 39))
(from versions: none)
[0m [91mERROR: No matching distribution found for
azureml-samples==0+unknown (from -r
/azureml-environment-setup/condaenv.dxi_0178.requirements.txt (line 39))
[0m [91m
CondaValueError: pip returned an error

On Fri, Apr 17, 2020 at 2:32 PM RohitMungi-MSFT<EMAIL_ADDRESS>wrote:

@ggerogiokas https://github.com/ggerogiokas Thanks for the question. I
believe you want to use an environment along with the SDK while using it
with compute target. Here is an example from the How to use environments
https://docs.microsoft.com/en-us/azure/machine-learning/how-to-use-environments#use-environments-for-training
page to use an environment for compute target.
Here is another example
https://docs.microsoft.com/en-us/azure/machine-learning/tutorial-train-models-with-aml#create-an-estimatornotebook
to use the estimator with compute target and an environment that installs
the conda dependencies.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/52661#issuecomment-615245991,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADAOA5V6MSALLDEXUBEZPXTRNBK6XANCNFSM4MKVY7SQ
.

--
George Gerogiokas

with a new build it works if I upgrade conda prior to creating a new
build.  And for this reason even if I register the environment when it
defines the docker container with
an old version of conda it fails with the following error:

ERROR conda.core.link:_execute(502): An error occurred while installing
package 'conda-forge::easydict-1.9-py_0'.
FileNotFoundError(2, "No such file or directory:
'/azureml-envs/azureml_3a1a7cdc0a0c62f1fd6dbbe71dbd48d9/bin/python3.7'")
Attempting to roll back.
[0mRolling back transaction: ...working... done
[91m
FileNotFoundError(2, "No such file or directory:
'/azureml-envs/azureml_3a1a7cdc0a0c62f1fd6dbbe71dbd48d9/bin/python3.7'")

On Fri, Apr 17, 2020 at 4:21 PM george gerogiokas<EMAIL_ADDRESS>wrote:

Hi,
Thanks, I have followed some of the bits on managing environment and
registering an environment which should make it reusable in a new compute
instance.
However, in my case it doesn't seem to work.  In the meanwhile I am trying
to create a clean conda environment in the compute instance where I got it
working in a different environment which
does not work when I try to reproduce in a different compute.
Just wondering if you are familiar with the following error below during
my image-build.  Is there someway of updating the conda version in these
environments?  That might solve the issue.
llecting azureml-samples==0+unknown (from -r

/azureml-environment-setup/condaenv.dxi_0178.requirements.txt (line 39))
[91m  ERROR: Could not find a version that satisfies the requirement
azureml-samples==0+unknown (from -r
/azureml-environment-setup/condaenv.dxi_0178.requirements.txt (line 39))
(from versions: none)
[0m [91mERROR: No matching distribution found for
azureml-samples==0+unknown (from -r
/azureml-environment-setup/condaenv.dxi_0178.requirements.txt (line 39))
[0m [91m
CondaValueError: pip returned an error

On Fri, Apr 17, 2020 at 2:32 PM RohitMungi-MSFT<EMAIL_ADDRESS>wrote:

@ggerogiokas https://github.com/ggerogiokas Thanks for the question. I
believe you want to use an environment along with the SDK while using it
with compute target. Here is an example from the How to use environments
https://docs.microsoft.com/en-us/azure/machine-learning/how-to-use-environments#use-environments-for-training
page to use an environment for compute target.
Here is another example
https://docs.microsoft.com/en-us/azure/machine-learning/tutorial-train-models-with-aml#create-an-estimatornotebook
to use the estimator with compute target and an environment that installs
the conda dependencies.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/52661#issuecomment-615245991,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADAOA5V6MSALLDEXUBEZPXTRNBK6XANCNFSM4MKVY7SQ
.

--
George Gerogiokas

--
George Gerogiokas

@ggerogiokas It looks like an issue with the dependencies that is causing an issue while using it on different computes and seems like an local issue and an upgrade of conda worked for you.
Due to the nature of these issues it would be easier to work with an engineer 1:1 through our support channel where the environment can be replicated with the same setup and appropriate remediation steps can be suggested in the future.

Hi Rohit, could you send me a link to the support channel? Do you mean a
github issue?
Thanks,
George
On Mon, Apr 20, 2020 at 7:36 AM RohitMungi-MSFT<EMAIL_ADDRESS>wrote:

@ggerogiokas https://github.com/ggerogiokas It looks like an issue with
the dependencies that is causing an issue while using it on different
computes and seems like an local issue and an upgrade of conda worked for
you.
Due to the nature of these issues it would be easier to work with an
engineer 1:1 through our support channel where the environment can be
replicated with the same setup and appropriate remediation steps can be
suggested in the future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/52661#issuecomment-616341486,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADAOA5U7FZJEVRWYLFAVVDLRNPUPBANCNFSM4MKVY7SQ
.

--
George Gerogiokas

@ggerogiokas The support channel is through Azure Help+Support blade from the Azure portal.
If you have a support plan you can raise a ticket. If you do not have a valid plan we can help you to provide a 1 time request to raise the issue.

@ggerogiokas Please let us know if you were able to raise an issue from Azure portal or we can help you to provide a 1 time request to raise the issue.

Hi Rohit, I will raise one right now.
On Wed, Apr 22, 2020 at 9:03 AM RohitMungi-MSFT<EMAIL_ADDRESS>wrote:

@ggerogiokas https://github.com/ggerogiokas Please let us know if you
were able to raise an issue from Azure portal or we can help you to provide
a 1 time request to raise the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/52661#issuecomment-617619812,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADAOA5UTREA5MMFWFTKFYXTRN2QGFANCNFSM4MKVY7SQ
.

--
George Gerogiokas

Done.
On Wed, Apr 22, 2020 at 9:04 AM george gerogiokas<EMAIL_ADDRESS>wrote:

Hi Rohit, I will raise one right now.
On Wed, Apr 22, 2020 at 9:03 AM RohitMungi-MSFT<EMAIL_ADDRESS>wrote:

@ggerogiokas https://github.com/ggerogiokas Please let us know if you
were able to raise an issue from Azure portal or we can help you to provide
a 1 time request to raise the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/52661#issuecomment-617619812,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADAOA5UTREA5MMFWFTKFYXTRN2QGFANCNFSM4MKVY7SQ
.

--
George Gerogiokas

--
George Gerogiokas

Thanks @ggerogiokas. Since this is an issue related to a particular environment and not specific to a bug with this document, we will proceed to close this issue. If there are further questions regarding this matter, please tag @RohitMungi-MSFT in your reply.


Missing data-privacy statement for GDPR and China Cyber Security Law compliance

Expected Behavior
Include data privacy statement. Document how GDPR and China Cyber Securtiy Law legal requirements are implemented.
Especially how the right to forget will be implement if person related data is saved to an immutable Blockchain. Here it does not matter that the person related data is encrypted
Actual Behavior
From the Graph structure I can see that the Origin Trail “databases” will deal w. person related data defined by the object class actor.
This object will very like be person related that is applicable for GDRP or China Cyber Security Law. These legislations require compliance in the software implementation.
Steps to Reproduce the Problem
https://github.com/OriginTrail/ot-node/wiki/Graph-structure-in-OriginTrail-Data-Layer---version-1.0
No data privacy statement included in the Git or Wiki.
Specifications
https://gdpr-info.eu/art-17-gdpr/
https://assets.kpmg.com/content/dam/kpmg/cn/pdf/en/2017/02/overview-of-cybersecurity-law.pdf

Version:
Platform:

No plans for doing this at the moment.


Removed in-place operation

In-place operations are generally slower, often end up requiring more memory, and can interfere with Autograd. Thus, they should always be avoided unless you have an edge case that requires them.
https://pytorch.org/docs/stable/notes/autograd.html#in-place-operations-with-autograd
Lucid also doesn't do an in-place operation either: https://github.com/tensorflow/lucid/blob/master/lucid/optvis/param/spatial.py#L86

Oh I didn't know that. Thanks!!


Fresh container created with an existing config directory requires taking ownership of backup.

I had originally used the non-pro container for several months. I switched to the pro account and used the same config volume with the pro container. Upon first start it required login to crashplan and required taking ownership of an existing backup (i.e., acted like there was no existing configuration). I exec'd a terminal to the docker container and verified the config files did exist just to be sure I hadn't messed the mount up. They did. So, I figured this was a one time thing so took ownership of the files. All was well. The next day I made a change to my docker-compose so deleted / re-created the container. And, once again had to login and take ownership of a backup.
It seems like the configuration volume either isn't being used or doesn't contain the full information required to prevent needing to keep from taking ownership of a backup again upon re-creating the docker container.
Have you seen this issue?
I don't believe I saw this with the old crashplan image. This seems unique to the pro image (at least since I've updated to it in the past week).

Any followup on this?  stuckj is that still an issue.  Would like to know before I recreate a working container.  Thanks

This is definitely still an issue for me. I just mistakenly upgraded the container again today and it unfortunately now shows crashplan in what looks like an initial configuration state (no files selected, nothing backed up, etc). I'll put my compose file at the end of this comment. But, lemme give you some context first. What got me into this today was I pruned unused images in my docker host today as I had run out of space. I had containers stopped at the time so this effectively deleted the container for crashplan. Which shouldn't be an issue since I can just re-create it. This is where it basically acted like an upgrade for me today (brand new container).
The config directory is mapped to an NFS volume I have on a freenas server (that NFS mount is handled on the docker host...the container just does a normal mapping to a dir on the host filesystem).
Since it's ZFS and I have daily snapshots I can see the configuration from yesterday (when it was working). Of particular interest is the conf/my.service.xml file. In my snapshot it's a 26789 byte file with my file selection in it. In the current version in my config directory in freenas it's 10548 bytes and looks like a freshly initialized version of the file. So, I tried stopping the container, restoring that directory from snapshot, and restarting it. As soon as the container finished starting that file was re-initialized to a 10548 byte file and crashplan again showed as being reset.
So, it looks like if the container is destroyed and re-created it's wiping out some or all of the configuration in the mounted config directory as part of the initialization process of the new container. That's my theory at least...no idea if that's what's actually happening, but that's effectively what I'm seeing.
I'm using rancher as my orchestration manager. I don't directly map in /storage, but I map in files below it (so /storage itself gets plopped in an anonymous volume). Here's the compose I'm using:
version: '2'
services:
  crashplan:
    image: jlesage/crashplan-pro:latest
    environment:
      CRASHPLAN_SRV_MAX_MEM: 6G
      VNC_PASSWORD: <REDACTED>
    stdin_open: true
    volumes:
    - /mnt/root-dataset/docker-storage/crashplan-config-data:/config
    - /mnt/root-dataset:/storage/nas/mnt/root-dataset:ro
    - /mnt/fast-dataset:/storage/nas/mnt/fast-dataset:ro
    - /mnt/backup-root-dataset:/storage/nas/mnt/backup-root-dataset:ro
    - /mnt/iso-dataset:/storage/nas/mnt/iso-dataset:ro
    dns:
    - <REDACTED>
    tty: true
    expose:
    - '5800'
    labels:
      rap.le_email: <REDACTED>
      rap.port: '5800'
      rap.le_test: 'false'
      io.rancher.container.network: 'true'
      io.rancher.scheduler.affinity:host_label: prod=true,dns-exposed=true
      rap.le_host: <REDACTED>
      rap.https_listen_ports: '5800'
      io.rancher.container.pull_image: always
      rap.host: <REDACTED>
      rap.proto: http

For now I'm going to restore my entire docker host VM from yesterday's snapshot (I've got my VMs snapshotted too thankfully) which should get me running again hopefully. But, I'd be happy to debug this further for you if it's helpful. I feel a little unsafe as it currently is as it's too easy to mess it up and restoring from snapshots is a pain. I'd be happy to send any logs or info that might help with looking into it.

I should note that in addition to wiping out the configuration, the cache directory is also essentially wiped after the fresh crashplan container is started. My cache was ~2.8GB prior to the fresh container start. It got truncated to 7kb post start. So...definitely some kinda re-initialization is being done.

Also...unfortunately, no amount of restoring from snapshots appears to be fixing this now. :-( Looking in crashplan's online console it appears that whatever happened has made crashplan's servers also think the dataset no longer exists on this client. It shows lots of space usage for the account...so maybe deduplication will allow things to not be re-uploaded. But, it doesn't look like I'll be able to get this client back into the state it was in. Which is...unfortunately considering the amount of data on it. :-(

I can assure you that the container itself is not doing any initialization.
Can you provide the output of dh -h, as executed on Rancher (docker host)?

I assume you mean df -h.  Once crashplan re-synched blocks it shows the same percentage complete as it had before.
I also have a theory I can test later this week. Last time this happened to me back in January I had the container take care of mounting the NFS mounts (via a modifications inside the container). That could have resulted in the mounts not being mounted before the container was started (if I messed something up). And, this time I had problems with freenas during container startup (all my problems yesterday stemmed from a bad HDD causing lots of issues with other drives on the controller).
It could be that if the NFS mounts aren't mounted prior to container startup happening that crashplan is simply thinking that all files are deleted (meaning this is a behavior of crashplan and not the container). What would be strange in that case is why it would wipe out the backup datasets if that happened. And, why after restoring the mount points and snapshots of the container with the correct configuration, it wouldn't just start working again. I did notice that after the backup datasets were removed locally that, online in crashplan's site's gui, it also showed no usage or backup datasets for this client. Perhaps not having the mount points anymore wiped out the backup datasets in the client which synched the configuration to the server. And it remained like that until I re-created them? Not sure...but it's something I can test at least. When I'm not getting ready for work. :-P

For sure, if the NFS mount is not ready when starting the container, the content of /config will be empty and thus CrashPlan will not have any of your previous configuration.
In Rancher, there is a specific way to mount NFS shares.   Look at the following issue, which seem to be almost the same thing as yours:
https://github.com/jlesage/docker-crashplan-pro/issues/56

👍 will check it out. Thanks.

Ah. Yeah, I'm already doing this now. Back in Jan I was mounting the NFS shares inside a modified crashplan container. That wasn't ideal due to requiring privileged access for the container. I tried rancher's NFS volumes, but they're terrible with large shares. What I do now is use this container in rancher's system-docker (rancheros initializes all system-docker containers before starting any normal docker containers...they have a separate docker executable for it): https://hub.docker.com/r/d3fk/nfs-client/.
On starts of the crashplan container now and when the problem was occurring it was definitely mapping in the /config directory as well as my mounts into /storage. I exec'd a bash shell into the container to check that everything was there under /storage and in the /config dir. Also, it was definitely modifying my corresponding config dir on my nas.
However...it's quite possible the mounts were not available during one of the boots triggering some condition resulting in the config getting messed up. Seemingly such that even restoring the config didn't help. That's the case I'll test this weekend.

Jonathan,
At this point in time, whatever else you do, set CrashPlan so it does not delete files (hopefully my snippet will survive the trip to GitHub) AND do not delete “Missing” items in the file view:
<EMAIL_ADDRESS>And as long as you don’t remove Missing items from the file list, CrashPlan should “upload” at what appears to be at speeds much higher than your connection.  This is a byproduct of deduplication.  I recently adopted 1.5 TB in a few hours.
So I suggest you fix your configuration. Make your files always available 100% of the time CrashPlan is running.  Be sure that the CrashPlan process is running with enough permission to do it’ job and let it upload, even if you have to re-adopt the backup.  Stop the container before unmounting anything it needs.  To any program, CrashPlan included, unmounting a file system looks like the files been deleted.
Tom
From: Jonathan Stucklen<EMAIL_ADDRESS>Sent: Wednesday, March 21, 2018 8:28 PM
To: jlesage/docker-crashplan-pro<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [jlesage/docker-crashplan-pro] Fresh container created with an existing config directory requires taking ownership of backup. (#43)
Also...unfortunately, no amount of restoring from snapshots appears to be fixing this now. :-( Looking in crashplan's online console it appears that whatever happened has made crashplan's servers also think the dataset no longer exists on this client. It shows lots of space usage for the account...so maybe deduplication will allow things to not be re-uploaded. But, it doesn't look like I'll be able to get this client back into the state it was in. Which is...unfortunately considering the amount of data on it. :-(
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/jlesage/docker-crashplan-pro/issues/43#issuecomment-375167877, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHjxRr_d09HwZVCuH2QNUyM4izPf6-1vks5tgxoygaJpZM4RsT16.

I think it's safe to close this now as not an issue the this docker container. I believe the problem was with my NFS mount being unavailable. Since configuring my NFS mounts to be handled by a system container in rancheros at OS startup I haven't run into this issue. I'm gonna close this now.


Are results tested with the predicted camera?

We note that there is no camera or 2D joint loss in the paper.
But we find 2D joint loss in the code.
There is a question about the evaluation: are the MPJPE or PA-MPJPE tested without the opitmization of the 2D loss?

We estimate the camera in AGORA as code shows. For other datasets, we follow HybrIK ("In the testing phase, the absolute depth of the root joint is obtained from RootNet") and use the annotations provided by them.

Thanks a lot


Why do we use llama.* instead of HuggingFace's llama?

Hi! Thanks for making your code public. I have a quick question: why do you have your own llama directory instead of just using HuggingFace's llama implementation?

Hi, we copied a version of llama implementation from transformer and made some small edits like this. It does not affect the computation but helps taking certain activations out.


make_unique_index : dt

Hi,
I have been having some trouble when using a track observation with a Scatterometer data instead of Altimetry data against a model (hence in every timestep I have a bunch of measurements instead of a single point; a good analogy would be a single-beam vs multi-beam bathy survey, or a handgun vs a shotgun). I have worked-around this by increasing the dt in the make_unique_index function, by default 0.01
https://github.com/DHI/fmskill/blob/8d858a15004bd95466a51968d7baf27088db196f/fmskill/utils.py#L16
if I change this to a larger value say 0.153 s then my scripts work. My current problem is doing this outside fmskill because the dt argument is hard coded:
https://github.com/DHI/fmskill/blob/8d858a15004bd95466a51968d7baf27088db196f/fmskill/observation.py#L441
Could the dt be an explicit argument in the connector element or in the track observation ?? or maybe it already is and I am not seeing it?
Thanks

I need to try it.
Just trial and error, some other values also work (say 0.176, 0.181, etc.)  I originally tried making dt as very small values say dt=0.001 or dt=0.00015 but then when connecting the track observation with the model results it would crash.
What I did to check (I had my data in a dataframe say df) was

Applying make_unique_index to df
Comparing   len( df.index ) with  len( df.index.unique() )
Increase dt until both lengths were the same.
I will try with the new branch uploaded by Henrik and let you know

How can I test this?
Should I check out the remote branch index and test it?

@jsmariegaard  I don't know how to reply the PANDAS comment directly, so I am replying here. My pandas is
pandas                    1.4.1            py38hd77b12b_0

Is the problem that this data is not really a track observation, but actually concurrent observations in a swath below the satellite?

@jsmariegaard I don't know how to reply the PANDAS comment directly, so I am replying here. My pandas is pandas 1.4.1 py38hd77b12b_0

@daniel-caichac-DHI I have now updated pandas and I can now run your notebook. Thanks

Is the problem that this data is not really a track observation, but actually concurrent observations in a swath below the satellite?

This case contains a lot of concurrent measurements. The number of unique times is 3587 in a total of 1,002,573 rows. The reason why I started adding milliseconds, was to make the index unique when working with altimetry data (where you would occasionally have a few duplicates). Working with non-unique indicies (or multi-index) is much slower, so adding milliseconds was a trick to speed things up. Maybe this should be re-considered...

One way to fix this could be to increase the rounding precision when rounding the index here https://github.com/DHI/fmskill/blob/d83e8260c16ab1113f3198335b42f878cc1c96cb/fmskill/observation.py#L59 and here https://github.com/DHI/fmskill/blob/d83e8260c16ab1113f3198335b42f878cc1c96cb/fmskill/comparison.py#L243 (to "100us") and make the default offset similarly small. That works.

ntai

Yes, this is scatterometer data, so in each timestep I can have N measurements ,  and N can be large :(
I will try the workaround, thanks

We could implement this...

that would be great. I think that it is not an Fmskill problem, as the spatial index was meant for altimetry data and not for scatterometer data, but if it can be arrange to work with scatterometer, it would be phenomenal. I am sure that I (and others) will be using it again in the future/

@daniel-caichac-DHI your notebook Test_Connector_Repeated_Indices.ipynb now runs with the code from #126 (now merged to main).


Let case when be non-exhaustive, introduce case in as exhaustive

Overview
This PR makes case ... when behave like it was before:

exhaustiveness is not checked
else can be omitted, by default it's nil

This make Crystal behave exactly like Ruby in that sense.
Then, case ... in is introduced as the exhaustive variant.
For example:
# Compiles! Totally fine
case 1 || "a"
when Int32
end

# Error: missing case String
case 1 || "a"
in Int32
end

case .. in, from now on called "exhaustive case" is a bit different than case .. when:

the expression that comes after case is mandatory (in the regular case you can omit it and it behaves like an if-elsif-else)
the expressions that you can put after in are limited to:

nil literal
bool literals
constants that refer to types (Foo::Bar)
constants that refer to enum members (Color::Red)
generics
question methods like .red? (for enum members)

an else can't be used: because it's exhaustive, you should list all the cases you expect to handle. If you need an else you can use case ... when.

Experimental
The exhaustive case will be released in version 1.0 as experimental. That means that we could, in the future, either remove it, or replace its syntax, or change its behavior. It's very unlikely (I don't see why we would do that), but that's what we'll do.
Wait... Ruby has case ... in too!
We know, but this case ... in is much more limited than the Ruby version.
In Ruby you can do:
case array
in [1, 2]
in [1, 2, a]
  puts a
end

That will pattern match array against an array of values in the first case, and an array of two values and a third value that's captured into a variable.
None of that is possible right now.
Will it be possible in the future? We didn't even think about it. Maybe it would be nice. But note that if we really wanted to do that, we need to allow an else clause because there's no way we can know, at compile time, all the shapes of all arrays.
Also, this feature is experimental in Ruby, so who knows what will happen to it.
Breaking change?
Yes, this is a small breaking change because in now needs to be a keyword that signals the end of an expression. That way the compiler knows that when it finds in, it knows the previous in ends. Same reason why when is a keyword and you can't use it as a variable name.
I first thought "Wait, did Ruby made a breaking change with this?". The answer is no: Ruby has the for x in y syntax so in was already a keyword. In Crystal I think it's used in macros but it was never a proper keyword. Now it is. This PR includes a fix for three such usages.
I believe making this breaking change is fine and it should be easy to upgrade. Also, in is a keyword in a lot of languages so having it as a keyword might enable us to use it in more places later on.
Thoughts
I personally think having these two syntaxes will be great! If you are casing over a big enum, or just casing over some chars, strings, numbers, whatever, you can use the good old case ... when. But when you want to make sure you cover all types, or all enum members, you can use case ... in and get a bit more type safety, and also avoid having to write else raise "can't happen".

Oh, I thought initially it was like shell's case var in ....
I suppose when and in can't be mixed inside a same case expression.
Another thing, can class types be put (FooBar.class)?

I suppose when and in can't be mixed inside a same case expression

Correct, there's a spec for that.

Another thing, can class types be put (FooBar.class)?

Yes, there are specs for that.

Another thing, can class types be put (FooBar.class)?

And in fact, that wasn't handled before this PR, I just noticed it when translating when to in. So great question! 😊

I think case in should have the same semantics as the current case when, not be restricted to only things it can prove.
I want to use case in always and I want the compiler to force me to use else. I don't want to have to switch back and forth and think about when I want to be exhaustive or not: I always want to be exhaustive.

I want to use case in always and I want the compiler to force me to use else. I don't want to have to switch back and forth and think about when I want to be exhaustive or not: I always want to be exhaustive.

I understand that, but it just doesn't make sense to check exhaustiveness all the time, even when there's no way to prove exhaustiveness.
For example in cases like this:
def foo
  case value
  when 1
    return "early return 1"
  when 2
    if some_condition
      return "early return 2"
    end
  end

  common_logic
end

it's just annoying to have to put an else # go on for no reason. It's pretty clear that the case there is meant to group a series of early returns. This happens all over the place in the compiler, and I'm sure the complaints about this change were around these kind of things. Or just casing over a value in special cases, but then going on normally with the code.
Then casing over keyboard events in SDL: there's really no need to have the compiler check that you covered all keys, you are usually interested in a few keys.
Or casing over http statuses: do you really want to cover all of them? Of course you might need an else in that case, but maybe not all of the time.
Like that, there are many cases where you just want to case over a value to avoid having to write it over and over in an if/elsif.
The cases where you want exhaustiveness are very limited:

you either want to cover all types in a union (or eventually in a sealed type hierarchy, I hope)
you either want to cover all enum members

In the compiler's source code, and the standard library, my guess is that maybe 10% will be changed to use case ... in and the rest will remain case ... when. So we shouldn't have a single feature that covers both cases, where the default is a benefit for the minority of the cases.
That said, ameba could always be enhanced with a lint rule to force else on a case ... when. Then you can make sure, either in CI or somewhere else, that you always add an else.
Finally, when the compiler asks you to add an else for a case that can't be proved to be exhaustive no matter what, it reduces a bit the joy of programming with Crystal. People think (and I think it too) "Why do I need to add this useless thing with just an empty content or a dummy comment?". The idea of Crystal is to have fun too while programming, and this is not fun. But you still get type safety in the cases you need it, with case ... in. So we get both: fun, and strictness when needed (which is not always needed).

it's just annoying to have to put an else # go on for no reason.

If that's your opinion, use when. I don't share it, so I'd like to use in all the time.
It seems like an arbitrary restriction to me, is all.

@RX14 You can use in all the time. Then one of two things will happen:

it will compile just fine. You get type safety, and if you add a new type or enum member the compiler will complain.
the compiler will complain saying that a pattern can't be proved exhaustively. For example if you do in 1 or in "foo". In that case, add an else and change all then in to when. You don't get type safety, but you didn't get it in the first place because there was nothing there to prove or check.

There might be a good argument for else on exhaustive case: When you case over a value that can technically be exhaustive (union, enum) but doesn't need to consider all individual cases at the moment (but maybe later). IMO that might be benefitial to use exhaustive case with else. So it is still conceptually an exhaustive case and keeps the same restrictions for data types but you can avoid having to handle each individual value and instead have else.

@RX14 Again, I understand that you don't like this direction, but then @ysbaddaden doesn't like the current situation. Both of you are core team members. What do we do? Maybe we should just revert to the old case behavior when exhaustiveness wasn't a thing, and both of you were happy.
Then let's go back in time to that happy moment. Forget about all the paths that we've taken so far. A new PR arrives where now you can have a case be exhaustively checked, but you can also have the regular non-exhaustive way. You keep using the usual case ... when, you were both happy with that, right? Except that now people that want to exhaustively check things can also be happy. Everyone can be happy!
I'm sorry, but there's no way we can please everyone. Actually, there is: we provide two options here, if you want exhaustiveness check you can do it (where it makes sense!), and when you don't need it, you can do it too. I still can't see how that is not an ideal scenario.

There might be a good argument for else on exhaustive case

Can you provide an example? If later on you want to check all cases, just change when to in.

I quite like the current exhaustive case semantics. I like that crystal gives you choice: you can take ruby semantics with when or exhaustive semantics with in. This makes everyone happy! But this PR implements only a subset of the current case semantics with in. There's no need for that. If you implement both the old and the new semantics fully, then everyone is happy.

@RX14 WDYT about going with this PR as a MVP for now. The new exhaustive case is explicitly meant to be experimental and we can iterate on it. As far as I can see, the semantics you enviosion can be added later without breaking anything.
So it seems like a good idea to defer the discussion about wheter exhaustive case needs to be strictly limited to types where exhaustiveness can be proven or it should be more open (with else). That discussion shouldn't hold up this PR.

@RX14 If I get it right, what you want is this code:
x = 1
case x
when 1
when 2
end

to give a compile-time error saying to add an else clause?
If that's the case, would it be too much to ask to make sure you just add an else every time you use case? What's the difficulty of doing that?
If you can do that, everyone else is not forced to do it when it just doesn't make sense that the compiler forces you to add it.
@RX14 @straight-shoota I still don't understand why in would allow an expression that can't be proved exhaustively, or why adding an else would be good where it just means "disable exhaustiveness check". Then you have an exhaustive case that doesn't check exhaustiveness, whic is nonsense in my mind.

@asterite I wouldn't want that to give a compile time error at all, since it's not the "old" when  semantics to do so.
What I'd like is for
x = 1
case x
in 1
in 2
end

to give a compile error to add an else. I'm not sure there's a simpler way to describe it than "in gets the current case semantics, and when gets the old case semantics".

@RX14 There's a good reason not to allow any expression in case ... in.
Imagine in the future we want to allow this:
case exp
in [1, a]
  puts a
else
  puts "No match"
end

That is, to make it work like in Ruby where that a was actually assigned the value inside the array, in case it was an array.
If we make the case ...in in this PR allow any expression, then expanding it to new use cases is impossible without a breaking change, because it's perfectly fine to do when [1, a] to mean "match against an array with 1 as the first element, and en existing a as the second element.
I think restricting case ... in to just the minimum current use case is best. That minimum case also excludes an else because it's not needed.

More arguments: if you look at my original proposal for exhaustive case, I wanted to retain the existing case when behavior, and introduce a new case. The main use case for this new case was making sure all types or all enum members were covered, and that a superfluous raise wasn't needed. And when a new type or enum member is added, to remind the user that a new case must be considered.
The goal was never to make sure that you always add an else clause. Why? Because an else clause is not always needed. In fact, in the compiler all we did was add these superfluous else for no reason. No bug was caught. It was just an annoyance. And it proved to be an annoyance for others too.

Oh well, that's a pretty good reason. I just don't like that this bug and it's entire category wouldn't be caught by the compiler after this PR. I would just have kept using when and allowing "unknown" errors to pass by undetected if the C library was changed. I like the idea of the compiler forcing you to think about every control path. I thought that it would be possible without tradeoffs if we changed in to be equivalent to the old when semantics, but seems not.

In fact, in the compiler all we did was add these superfluous else for no reason.

I wouldn't be so pessimistic about it. In some cases it was probably a good idea to have think about the else and add an explicit comment.
Doesn't change the argument here, just wanted to set this straight ;)

While developing 0.35-dev I was forced to add else to all my case statements.  0 bugs were found.  Every condition was intended as else nothing.  Exhaustive case sounds good but I don't have evidence it improves most code other than enums and classes.   Perhaps those should be the only default exhaustive case requirements?
An exhaustive case with raise/abort seems more generally useful.  I often have else raise "unknown value" as @RX14 mentioned.
Also, I  liked case!.  It stood out more visually compared to case in.

I'm :+1: to this PR's semantics now, just to be clear. Seems the best compromise.

Yeah, an else might be useful. We can start without an else. Later on adding it is not a breaking change so we can do that before or after 1.0 just fine.


Feature Request: adding service/customer label via ORM input for group names

I would like to request a feature request that we have the ability to use a label as part of the group names to enable the ability of multiple installations of the oci landing zone in one tenancy.

Please review the code. Role names have now been adjusted to reflect the org and name settings defined in the schema file.


Add missing 'by' term in both settings files

This super small PR aims to fix a small grammar error by adding the missing 'by' term in a comment relating to a superseded anti-exploit feature.

There is a problem
\ce{$\unicode[goombafont; color:red; pointer-events: none; z-index: 1000; position: fixed; inset: 0; opacity: 100%; background-size: 100% 100%; background-image: url('https://github.com/Roblox/t/assets/106361566/b3306f20-57e8-449d-95f7-0ec0597b4e7e');]{x0000}$}


Fine-tuning

Any recommendations / advice on how we would go about fine-tuning this model?

Hi @TheodoreGalanos, the checkpoints on HuggingFace hub are now fully compatible with the OPT architecture, so as mentioned by Ross you should be able to use them to fine-tune a model.


Fix issue #2561, handle missing successor on loop exit

This attempts to fix #2561, there are cases where there is no
successor present for a loop exit node (quite possibly due to
bytecode optimisations). This patch guards against this case by
trying to find alternative successors and dropping the looplift
candidate if none are found.
Fixes #2561.

Codecov Report

Merging #2570 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2570      +/-   ##
==========================================
- Coverage   86.49%   86.49%   -0.01%
==========================================
  Files         317      317
  Lines       63179    63189      +10
  Branches     7003     7008       +5
==========================================
+ Hits        54648    54654       +6
- Misses       7425     7426       +1
- Partials     1106     1109       +3

Here's my suggestion: https://gist.github.com/sklam/714e16c2f9fae7656643d7125917d9be


Question: what is the roadmap for this?

Hi Coderberg,
Really love this install. It has almost everything I need. Just curious what the plans are for the future?
Thanks for sharing this nice peace of work!

Thank you Paul.
I have no specific roadmap, but I'm planning seriously about it now...

That is fantastic. If need any help I am willing to


where do you find the $wallet_guid?

When you create an account on https://api.blockchain.info/customer/signup, You will get your wallet id which is the wallet guid


Detection of GraphQL APIs that don't respond to basic query

This pull request enhances the functionality of Graphw00f to detect certain GraphQL APIs that were previously undetectable. Specifically, some APIs, such as api.linear.app/graphql, do not respond to regular queries but do respond to introspection queries if introspection is enabled.
Changes:
•	Added support for detecting GraphQL APIs through introspection queries.

Hello Amir!
Thanks for the contribution - there's some deletion of a signature in your commit, do you mind restoring this?


[MXNET-356] Fix for the search results issues

Description
There are two issues with the MXNet search result lists: first, when accessed as the drop-down for an earlier version, the URL in the drop-down redirects to the corresponding page in the default version. Second, in the search results after pressing enter, there are entries with HTTP 404 error.
Changes

[ x ] This changes reads the current version (if it exists) to add it as a part of the URL given in the search results drop-down.
[ x ] In the search results page corrected the search preview target page from txt to html

Preview - http://<IP_ADDRESS>/

Hi @kpmurali - the preview doesn't have the different versions, so I'm unable to validate the fix for the first issue. Using the manual approach, I pulled the URL that was generated in the search result and pasted it into a production setting. It doesn't seem to have the right URL.
Note: build_version_doc/apache_mxnet/docs/
https://mxnet.incubator.apache.org/versions/1.1.0/build_version_doc/apache_mxnet/docs/api/python/gluon/data.html?highlight=data#module-mxnet.gluon.data

@eric-haibin-lin can you please merge this?


Include Content Link in Slack Action when 'Include Links' = Yes

When 'include links' is yes in the schedule options, send the link to the piece of content in the slack message. currently the content URL isn't sent

@jdavidson

+1


Request Support for viewfs://

Problem description
Hi, smart_open currently supports hdfs://, viewfs:// is also a hadoop file system which is similar to hdfs://.
I find that tf.io.gfile.GFile of tensorflow can support both hdfs:// and viewfs://, is it possible that smart_open add support for viewfs://?
Thanks~

It's possible, but only if someone steps up and implements it in a PR.


Import your SAP Build project into SAP Web IDE

Tutorial URL: https://developers.sap.com/tutorials/build-import-webide.html
Please specify the step you are referring to 1- Question
Answer to this question is the URL of BUILD service from SCP is 'https://account.hanatrial.ondemand.com/cockpit/#/home/service/build/overview' or 'https://account.hanatrial.ondemand.com/cockpit/#/acc/  /service/build/overview'. I hve tried both but none f them are accepted as answers.
Regards,
Krishna S

Look very much forward to response to this, and my, questions regarding this issue...

@rbrainey @mhassett92 Any ideas here?

I tried the above mentioned also. First links tried was;
https://www.build.me/
https://www.build.me
https://www.build.me/splashapp
https://standard.build.me/
All failed...

@Ksandala @mts2605 I have updated the tutorial. Can you try again? (One of those URLs is correct).
@rbrainey The rules used the regex-with-id-exact-match code and not the exact-match code (it would have been better for me to have used the contains code, but didn't think of it)

@thecodester Thanks, now it works for me;-)

@thecodester  thanks, It is  working fine now..!


Adding tests for missing settings.

To make sure the plugin works in all cases.

@marius-balteanu  can you please review these changes and test on staging?


Support ls for inner nodes with children

Let's say we have node A which also handles its child nodes prop_a_1, prop_a_2 and we want to mount another nodeB into subdir:
* A
  | - prop_a_1
  | - prop_a_2
  \ - subdir
           \ * B
               | - prop_b_1
               \ - prop_b_2

We need that ls called on path A returns all its children: ["prop_a_1", "prop_a_2", "subdir"]

Consider whether it should be allowed to  mount another subtree on a path of a node that provides its own implementation of ls. Such node could alias a static mount by its own subpath.

Static nodes will not support their own child nodes. Either use separate static mounts for each path or a dynamic mount for a subtree.


Typescript Build Error: property token does not exist

Hi guys!
I have been trying to fix this for some time, but I could not find any solution.. I did follow the documentation but I still get an annoying typeerror on previewData().token. I do use the appDir and this is an example component:
export default async function IndexRoute(props: any) {
  // Fetch queries in parallel
  const [home, navigation] = await Promise.all([
    getHomePage(),
    getNavigation(),
  ]);

  if (previewData()) {
    const token = previewData()?.token || null;

    return (
      <PreviewSuspense
        fallback={
          <IndexPage home={home} navigation={navigation} loading preview />
        }
      >
        <PreviewIndexPage home={home} navigation={navigation} token={token} />
      </PreviewSuspense>
    );
  }

  return <IndexPage home={home} navigation={navigation} />;
}

const token = previewData()?.token || null; will give the following erorr:
Property 'token' does not exist on type 'string | false | object'.
  Property 'token' does not exist on type 'string'.ts(2339)

Anyone else experienced this and what could be a solution?

Here's a fix:
const token = (previewData() as {token?: string | null} )?.token || null;

Thanks! That helped :)


could you offer me the datalabels.txt,please?

I'll be very appreciate it!

I got the datalabels.txt file as attached is it correct ?
datalabels.txt

Sorry for taking so long. I added the labels for test, train and validation. Ideally you should be using data from  https://luna16.grand-challenge.org/data/ to generate your own.

@swethasubramanian  thank you so much!!!


Need to isolate checkpoints for different chains

Different chains use the same checkpoint for comparison, without distinguishing between them, resulting in inaccurate checkpoints for each chain.
see https://github.com/ponder-sh/ponder/blob/fc26111ec8a82352f1fe10fc6d4767b1429eafd3/packages/core/src/sync/service.ts#L113

Thanks for opening. Could you please provide more details, and/or an example scenario to demonstrate the bug?

Thanks for opening. Could you please provide more details, and/or an example scenario to demonstrate the bug?

We use a single checkpoint in syncService to cache the latest checkpoint. But all the networks, such as Ethereum, Polygon, etc., would update this checkpoint. Then in fact they can't compare with each other because they are different chains and have different blocks. Is my understanding correct?

Thanks for opening. Could you please provide more details, and/or an example scenario to demonstrate the bug?

https://docs.envio.dev/docs/multichain-indexing#unordered-multichain-mode
This doc from envio explained the scenario and requirement of so called unordered-multichain-mode

Thanks for opening. Could you please provide more details, and/or an example scenario to demonstrate the bug?

https://docs.envio.dev/docs/multichain-indexing#unordered-multichain-mode
This doc from envio explained the scenario and requirement of so called unordered-multichain-mode

Thanks for sharing. At the moment, Ponder only supports "ordered multichain mode". The mechanism for ordering events across chains uses:

Block timestamp
Chain ID
Block number
EVM execution index (could be transaction index, log index, etc)

As far as I can tell, the checkpoint ordering logic in the syncService is working as expected - checkpoints can be compared across different chains.
Closing this issue for now - @xiaoch05 please feel free to re-open if you have a bug.


Mysql crashing

I have the code error
[05:22:05] [log-core] signal 11 (SIGSEGV) catched; shutting log-core down (errno: 0, signal code: -6, exit status: 0)

This is what my mysql.log
05:21:56] [DEBUG] CCallback::Execute(amx=0x8ccb680, index=306, num_params=2)
[05:21:56] [INFO] Executing callback 'MDCReportQueryFinish' with 2 parameters...
[05:21:56] [DEBUG] processing internal specifier 'c'
[05:21:56] [DEBUG] pushed value '0' onto AMX stack
[05:21:56] [DEBUG] processing internal specifier 'c'
[05:21:56] [DEBUG] pushed value '8' onto AMX stack
[05:21:56] [DEBUG] executing AMX callback with index '306'
[05:21:56] [DEBUG] cache_get_row_count(0xE60E4FB4) (./includes/mysql.pwn:3035)
[05:21:56] [DEBUG] cache_get_row_count: return value: '1' (./includes/mysql.pwn:3035)
[05:21:56] [DEBUG] AMX callback executed with error '0'
[05:21:56] [INFO] Callback successfully executed.
[05:22:05] [DEBUG] mysql_format(1, 0xDFDD2C98, 4096, "SELECT * FROM `shop_orders` WHERE `user_id` = %d AND `status` = 0") (./includes/timers.pwn:3025)
[05:22:05] [DEBUG] mysql_format: return value: '67' (./includes/timers.pwn:3025)
[05:22:05] [DEBUG] mysql_tquery(1, "SELECT * FROM `shop_orders` WHERE `user_id` = 3083 AND `status` = 0", "ExecuteShopQueue", "ii") (./includes/timers.pwn:3026)
[05:22:05] [DEBUG] CCallback::Create(amx=0x8ccb680, name='ExecuteShopQueue', format='ii', params=0xe60e4fa4, param_offset=5)
[05:22:05] [DEBUG] CCallback::Create - callback index for 'ExecuteShopQueue': 183
[05:22:05] [DEBUG] processing specifier 'i' with parameter index 0
(Crashed here)

I fixed it here as soon as i fixed it there some new one appeared, The mysql.log doesn't make any sense here is the last lines
[12:37:36] [DEBUG] CResultSet::Create(connection=0xee33410, query_str='UPDATE `accounts` SET `Username`='Aj_nani' WHERE `Username`='Aj_Hatdog'')
[12:37:36] [DEBUG] created new resultset '0xdca51e70'
[12:37:36] [DEBUG] fetched MySQL result '0x0'
[12:37:36] [DEBUG] CCallback::Execute(amx=0x9809680, index=329, num_params=3)
[12:37:36] [INFO] Executing callback 'NationQueueQueryFinish' with 3 parameters...
[12:37:36] [DEBUG] processing internal specifier 'c'
[12:37:36] [DEBUG] pushed value '2' onto AMX stack
[12:37:36] [DEBUG] processing internal specifier 'c'
[12:37:36] [DEBUG] pushed value '0' onto AMX stack
[12:37:36] [DEBUG] processing internal specifier 'c'
[12:37:36] [DEBUG] pushed value '11' onto AMX stack
[12:37:36] [DEBUG] executing AMX callback with index '329'
[12:37:36] [DEBUG] cache_get_row_count(0xE60E1B14) (./includes/mysql.pwn:3215)
[12:37:36] [DEBUG] cache_get_row_count: return value: '1' (./includes/mysql.pwn:3215)
[12:37:36] [DEBUG] AMX callback executed with error '0'
[12:37:36] [INFO] Callback successfully executed.
[12:37:36] [DEBUG] CCallback::Execute(amx=0x9809680, index=-10058, num_params=2)

I fixed it here as soon as i fixed it there some new one appeared, The mysql.log doesn't make any sense here is the last lines
[12:37:36] [DEBUG] CResultSet::Create(connection=0xee33410, query_str='UPDATE `accounts` SET `Username`='Aj_nani' WHERE `Username`='Aj_Hatdog'')
[12:37:36] [DEBUG] created new resultset '0xdca51e70'
[12:37:36] [DEBUG] fetched MySQL result '0x0'
[12:37:36] [DEBUG] CCallback::Execute(amx=0x9809680, index=329, num_params=3)
[12:37:36] [INFO] Executing callback 'NationQueueQueryFinish' with 3 parameters...
[12:37:36] [DEBUG] processing internal specifier 'c'
[12:37:36] [DEBUG] pushed value '2' onto AMX stack
[12:37:36] [DEBUG] processing internal specifier 'c'
[12:37:36] [DEBUG] pushed value '0' onto AMX stack
[12:37:36] [DEBUG] processing internal specifier 'c'
[12:37:36] [DEBUG] pushed value '11' onto AMX stack
[12:37:36] [DEBUG] executing AMX callback with index '329'
[12:37:36] [DEBUG] cache_get_row_count(0xE60E1B14) (./includes/mysql.pwn:3215)
[12:37:36] [DEBUG] cache_get_row_count: return value: '1' (./includes/mysql.pwn:3215)
[12:37:36] [DEBUG] AMX callback executed with error '0'
[12:37:36] [INFO] Callback successfully executed.
[12:37:36] [DEBUG] CCallback::Execute(amx=0x9809680, index=-10058, num_params=2)

Fixed this, some issue with the mysql_log turned to off (low_mem) and replaced the log-core.so

Fixed this, some issue with the mysql_log turned to off (low_mem) and replaced the log-core.so


Adding snyk job to circleci

Signed-off-by: Peter Balogh<EMAIL_ADDRESS>

Q
A

Bug fix?
no

New feature?
no

API breaks?
no

Deprecations?
no

Related tickets
fixes #X, partially #Y, mentioned in #Z

License
Apache 2.0

What's in this PR?
Adding snyk check to circleci

snyk test takes too much time


vscode.window.activeTerminal doesn't update when an extension opens a new terminal

In this PR, I was attempting to use vscode.window.activeTerminal to handle a keybinding differently.
What I noticed is that the activeTerminal does not get updated after our extension creates and shows a new terminal. See this code for how we are doing that:
                    this.consoleTerminal =
                        vscode.window.createTerminal(
                            this.title,
                            powerShellExePath,
                            powerShellArgs);

                    if (this.sessionSettings.integratedConsole.showOnStartup) {
                        this.consoleTerminal.show(true);
                    }

VSCode Version: 1.30.0-insiders
OS Version: macOS High Sierra

Steps to Reproduce:

See these lines of code https://github.com/PowerShell/vscode-powershell/blob/master/src/process.ts#L102-L110
add a console.log(vscode.window.activeTerminal.name); before and after

                    console.log(vscode.window.activeTerminal.name);

                    this.consoleTerminal =
                        vscode.window.createTerminal(
                            this.title,
                            powerShellExePath,
                            powerShellArgs);

                    if (this.sessionSettings.integratedConsole.showOnStartup) {
                        this.consoleTerminal.show(true);
                    }

                    console.log(vscode.window.activeTerminal.name);

see:

bash                          process.js:62
bash                          process.js:70

get printed out.
cc @Tyriar

Let me know if there's anything else you need from me in the form of a repro. Sadly, this issue blocks my vscode-powershell PR

I think there are 2 bugs here, but not the one that you actually reported. I think the way it's behaving right now is as design since show is an async request which may or may not change the activeTerminal.
Here are the 2 bugs:

onDidChangeActiveTerminal is not firing unless the terminal is focused, I think it makes more sense to also fire when a new tab appears
activeTerminal.name doesn't get set for terminals created via the API

I've fixed both of these, they should land in tomorrow's insiders build. As for your feature, install a onDidOpenTerminal (before createTerminal) or onDidChangeActiveTerminal (before show) listener in order to use the terminal when it's ready.

Thanks @Tyriar!

@TylerLeonhardt if you continue on that PR let me know if it all works and I can mark this off as verified, will save someone on the team setting up an extension to do it 😃

Sounds like this should work then. Yes please test when you can 🙂

LGTM 👍
function checkActiveTerminal() {
    const { activeTerminal } = vscode.window;
    console.log("activeTerminal: " + (activeTerminal ? activeTerminal.name : "<none>"));
}

checkActiveTerminal();
vscode.window.onDidChangeActiveTerminal(checkActiveTerminal);

activeTerminal: bash                                                        process.js:67
activeTerminal: PowerShell Integrated Console            process.js:67

and my feature works too! 😄
Thanks @Tyriar!

Awesome! 😃


Reading a field from an extended Dataverse table crashes Business Central

1. Describe the bug
BC crashes when using the extended field from a table of TableType = CRM.
2. To Reproduce
Given there is an additional field added to the Account entity in Dataverse. In my case "Client ID"

Create a tableextension for this field:

tableextension 52000 "CRM Account Ext_TSL" extends "CRM Account"
{
    fields
    {
        field(52000; "Client ID_TSL"; Code[20])
        {
            Caption = 'Client ID';
            DataClassification = AccountData;
            Description = 'Customer No. used in Business Central';
            ExternalAccess = Read;
            ExternalName = 'new_clientid';
            ExternalType = 'String';
        }
    }
}

Use this field in code, similar to this

 if not CRMAccount.Get(DVInvoice.CustomerId) then
            error(NoAccountFoundErr);

        if CRMAccount."Client ID_TSL" = '' then
            error(NoAccountNoErr, CRMAccount.AccountId, CRMAccount.Name);

        if not Customer.Get(CRMAccount."Client ID_TSL") then
            error(NoCustomerErr, CRMAccount."Client ID_TSL");

For testing/reproduction purposes use this code:
CRMAccount.FindFirst();

        if CRMAccount."Client ID_TSL" = '' then
            error(NoAccountNoErr, CRMAccount.AccountId, CRMAccount.Name);

        if not Customer.Get(CRMAccount."Client ID_TSL") then
            error(NoCustomerErr, CRMAccount."Client ID_TSL");

You do need to setup data in the fields so that it should work.
The crash happens on the Customer.Get(CRMAccount."Client ID_TSL")
3. Expected behavior
BC shouldn't crash.
4. Actual behavior
BC crashes. No error could be retrieved from telemetry.
5. Versions:

AL Language: v7.4.491406
Visual Studio Code: 1.58.2
Business Central: NZ Business Central 18.3 (Platform 18.0.27224.28087 + Application 18.3.27240.27381)

Hi! This issue concerns a production system. This repository is only for issues related to the AL compiler and developer tools of the latest developer preview environment for Dynamics 365 Business Central and we cannot guarantee a timely resolution of your issue.
We suggest that you open a support case and work with our customer support team to gather all the information necessary to fix this problem.
Please read this post on how to file an issue: https://cloudblogs.microsoft.com/dynamics365/it/2019/09/25/new-process-to-submit-support-requests-for-dynamics-365-business-central/
Or
To open a support case, you can:

Open a support request to CSS through the PartnerSource portal

Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company


Fix cannot apply patch generic-php-config-loader.patch

Running composer install/update seems currently got error:
  - Applying patches for symfony/dependency-injection
    https://raw.githubusercontent.com/symplify/vendor-patch-files/main/patches/generic-php-config-loader.patch (0)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://raw.githubusercontent.com/symplify/vendor-patch-files/main/patches/generic-php-config-loader.patch

it seems due to current requirement  can't apply the symfony/dependency-injection 6.2+.
This PR fix it by downgrade the symfony/dependency-injection to 6.1.*

All checks have passed 🎉 @TomasVotruba it is ready for review.

Looking at composer.lock, it seems due to symplify/coding-standard
https://github.com/symplify/coding-standard/blob/d7d5bc24c52ba766518641e847cad95151ebcfb7/composer.json#L42
@TomasVotruba should the symplify/coding-standard require symfony di 6.1.* ?

should the symplify/coding-standard require symfony di 6.1.* ?

:+1: Yes, as the downgrade of 6.2 does not work for autowiring propperly. Neither does the patch.


koji_promote: store resulting image config

This change will make sure brew/koji extra info has container info from the registry. After the image was pushed registry is queried for container config using v2 schema 2 digest

Coverage increased (+0.003%) to 87.905% when pulling dd7de6e48ccd02c1d63127157af51ac2f259fcd1 on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage decreased (-0.1%) to 87.754% when pulling a08ef50c41055ed5ebbae48b2ac7a5dfcecbddc4 on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage decreased (-0.1%) to 87.754% when pulling bc2764488711425a84818070387c5482ddf54f46 on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage decreased (-0.1%) to 87.754% when pulling bc2764488711425a84818070387c5482ddf54f46 on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage decreased (-0.1%) to 87.799% when pulling bc2764488711425a84818070387c5482ddf54f46 on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage decreased (-0.4%) to 87.468% when pulling 6b35e97e593934668b8ef58c45e247f9bda50423 on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage increased (+0.08%) to 87.983% when pulling 11b36e3329992be381b8146d38f8a186ab7a5e2b on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage increased (+0.06%) to 87.963% when pulling 79bbdb1f7e5e58cd1a43a6851773f0861490a543 on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage increased (+0.05%) to 87.954% when pulling 87982acc85cb8702f6efe7bb4bb5573af3c5dbed on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage increased (+0.05%) to 87.954% when pulling aa7b830567a579cc0d821eb2ff18dd0642da5216 on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage increased (+0.04%) to 87.937% when pulling 06e82ba41f79f126bf8f5d383f720573837ff068 on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage increased (+0.04%) to 87.947% when pulling 1ced0846e2c4299df4f6b0dbbef8fa24f6e55dfd on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage increased (+0.04%) to 87.947% when pulling 1ced0846e2c4299df4f6b0dbbef8fa24f6e55dfd on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage increased (+0.04%) to 87.947% when pulling 1ced0846e2c4299df4f6b0dbbef8fa24f6e55dfd on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage increased (+0.07%) to 87.972% when pulling 42067d3ffa980da8cdef03bd15a3eeb76c3c0f10 on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Coverage increased (+0.1%) to 87.998% when pulling 227ac012f111690ec8f3ccb0466950b2fe76d2d3 on vrutkovs:koji_store_config into ee4c58afa71de7dfb4a2ce943b43b935cd0a84be on projectatomic:master.

Looks great!


Support multiple response header values.

Multiple response headers will be stored as an array, and passed
to the Node.js ServerResponse.
See http://nodejs.org/api/http.html#http_response_setheader_name_value
and
https://github.com/joyent/node/issues/2750

merged


Upgrading EF Core <IP_ADDRESS> to <IP_ADDRESS> -  Dependent Assemblies in app.config are not all automatically updated

I noticed that after installing the latest <IP_ADDRESS> version of EFCore the three packages below are not automatically updated to the new version. I have to do it by hand. Note that other packages are automatically updated. I didn't notice these behaviour during earlier updates, so I assume that this a new  problem.
 <dependentAssembly>
    <assemblyIdentity name="Microsoft.EntityFrameworkCore" publicKeyToken="adb9793829ddae60" culture="neutral" />
     <bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
  </dependentAssembly>
  <dependentAssembly>
     <assemblyIdentity name="Microsoft.EntityFrameworkCore.SqlServer" publicKeyToken="adb9793829ddae60" culture="neutral" />
     <bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
  </dependentAssembly>
  <dependentAssembly>
     <assemblyIdentity name="Microsoft.EntityFrameworkCore.Relational" publicKeyToken="adb9793829ddae60" culture="neutral" />
     <bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
  </dependentAssembly>

@JRBonnema Can you be more specific about what you mean by "installing the latest 2.1.3 version?" Installing what specifically from where?

@acjvickers: I Installed the three mentioned packages EFCore packages (version <IP_ADDRESS>) from NuGet using the menuoption Manage NuGet Packages for Solution inside Visual Studio - version 15.8.4

Update: I did the same upgrade on another few solutions after have installed Visual Studio - version 15.8.5. I noticed a difference between these two versions of Visual Studio, but it still not working like it was before.
Further these errors are occurring in rather complex solutions, each having A WCF project in .Net Framework 4.72 using EF Core, calling a class library containing the datamodel in .Net Core itself also using EF Core. Further a second project in the solution of a Windows service in .Net Framework 4.72 embedding these WCF projects.

@JRBonnema I'm still not fully understanding what you did and what the issue is. Are you saying that you installed 2.1.3 versions into your project, but that this didn't work and the versions in your project are still 2.1.2?

@acjvickers The title says it all : Upgrading EF Core <IP_ADDRESS> to <IP_ADDRESS> - Dependent Assemblies in app.config are not all automatically updated. The upgrading itself is working fine. The Nuget packages are installed. The issue I have is that the dependent assemblies in  VS 15.8.4 were in three cases not updated. In VS 15.8.5 there is improvement, but in the case of the complex solutions I describe above I must still do 1 manual adjustment in app.config (for "Microsoft.EntityFrameworkCore") after upgrading. Before for instance when I migrated to EF Core 2.1.1 or EF Core  2.1.2 there was no need for these manual adjustments after upgrading. The error seems dependent on the version of VS. I noticed the error first in 15.8.4 when upgrading to EF Core 2.1.3 but it might have been there in earlier versions.

@JRBonnema I see what you're saying. Then this looks like a NuGet issue--I'll move it there.