Loader isn't unwrapping physical devices in extension functions

The layer currently wraps physical devices in terminator_EnumeratePhysicalDevices and then unwraps on any function (e.g. vkGetPhysicalDeviceFeatures that goes from app -> layer dispatch chain with loader_unwrap_physical_device.
Unfortunately this only happens for functions in trampoline.c, so e.g. vkDebugMarkerSetObjectNameEXT goes straight through from the application to the first layer in the dispatch chain, but the application's physical device handle is to a loader-wrapped object, and if the layer tries to use it as its own type of object it will get garbage back.
I think this means that for proper function the loader needs to implement any extension that uses physical devices so it can unwrap them. Which then puts a burden on the loader to implement them and stay up to date, and means a new loader version is needed for layer support of any new extension. I think this would hold true even for the ICD implemented extensions without layers as there's no terminator function.

This is not a trivial change as the loader will have to implement not only a trampoline but also a terminator for each function that can access a physical device.  This is because the loader wraps the physical device in both, and we have to unwrap the terminator physical device pointer.  It's going to have to sit as a TODO for a while as I have other items to take care of.

Wouldn't we need to do this to support the PhysicalDevice queries we've been talking about?

This is different, it's a known function so should have a specific trampoline/terminator.  I think we already do this in our loader for one of the KHRSurface functions, I can't remember which off-hand.  Since these are "device" functions and not "physical device" functions, it has to be handled in this specific way.

Currently being fixed with pull-request #1147.

Fixed with commit  9510c1446e1a9891b57de0baba6cb298b2890893


repl::ReplSession::new function is private

Thanks for the wonderful library.
I want to create my custom ReplSession, but ReplSession::new function is private. So how can I create ReplSession from some sessions outside of this library?
I want to run program following:
let session = expectrl::repl::ReplSession::new(
    expectrl::spawn("mycommand").unwrap(),
    "EXPECT_PROMPT".to_string(),
    None, false);
let recv = session.execute("send");

Sorry for the lack of explanation.
Currently, I'm working on creating lib to log in automatically and then do one shot command.
I thought it would be easier if I could use ReplSession, which is already implemented since I would have to use some repl cli at the remote.
So really I want to like this:
let session = expectrl::spawn("telnet remote").unwrap();
// session.expect("login:)....
// Do something log in procedure here
// It depends on remote machine, *nix, switches, special hardware and so on.
let session = expectrl::repl::ReplSession::new(session, "EXPECT_PROMPT".to_string(), None, false);
let recv = session.execute("send");

No problem, as I am in no hurry to publish it.
Thanks.

released in 0.4.0
please open an issue if there any more ones.
Thank you once again to addressing it.


Trained model?

Hello, I am interested in trying your method on my own underwater images.
However, downloading full NYU image sets requires for V1 90GB (Raw images) and for v2 it's 428GB for V2. I simply don't have enough space or time to wait to download all this.
So, I was wondering if you could upload pre-trained UWGAN/U-Net models instead that one could simply download and try on real life underwater images? It would be a great help.

I met the same problem

@branimir29 @02250119
Thank you very much for your interest in our project.
Our computer server crashed two weeks ago due to some unexpected reasons, resulting in data loss on the server, including pre-trained models for our project. We are trying to recover the data or retrain our model, but this may take several weeks. Please be patient.
We used only part of the data in the NYU Depth Datasets to train UWGAN, and this part of the data was uploaded to Baidu Cloud Link. With these RGB-D data and underwater RGB images, you should be able to use UWGAN to synthesize underwater-style images, and then you can train U-net using image pairs.
You are welcome to follow our project at any time, if there is any update, we will push it on Github.

Thanks for quick reply @infrontofme . There is no way for me to access Baidu Cloud, any chance you could forward me that package from Baidu via WeTransfer, GDrive, Dropbox?
It would be a great help.

@branimir29
We have uploaded datasets to Google Drive, you can find underwater images here [WaterImages[https://drive.google.com/open?id=1S2T5gZbdNe9KvVqGf-Neul3clRrpymPo]], and you can find RGB-D images here [NYU[https://drive.google.com/open?id=1q1FEcuhMPtqjJgaPSriL8EiBYA-mNGZv]].
If you have any questions about our project, please contact us.

Thank you for your reply.It will help me.

That's really nice of you, thx. I downloaded Water images, but NYU require your permission to access. I sent access request from my gmail address you'll see.

@infrontofme did you recover the trained model and make it publicly available?

the trained model has been recovered, the pre-trained model and datasets will be made publicly available soon.

Hello, @infrontofme, can you please provide me the requirement.txt file? I want to run the code with a small dataset.


docs?

Hi, the documentation website seems to be unavailable. Also, there is no snapshot of its subpages in the internet archive. If this is not a temporary problem, maybe you can organize the docs somewhere else?
Thanks!

Hello!
Yes, this site is (was) self-hosted but our server has been under maintenance for the past 2 weeks. This issue should be resolved next weekend, but you're right I should look into putting the docs somewhere else, perhaps simply on Hackage.

Just found out the website's source is available at https://github.com/flupe/site --- in the meanwhile I can read the documentation there, so no worries 🙂

Ah yes, completely forgot the source was available!
Although I have to be honest, I made some changes to the library and did not update the documentation, so some of it might be out of date by now.
The most noteworthy breaking change I can think of is the removal of the Recipe type family. Recipe m a b would just be a -> Task m b in the current version of the library (not uploaded to Hackage yet, but on the master branch of the repo).
Don't hesitate to ask questions if you need some pointers, pretty sure I'm the only user of this library so I haven't spent that much time documenting it and making it comprehensible.
And if you need a similar, more robust and maintained alternative, you might have better luck with Ema, made by the creator of Rib, which I just found out about.

Interesting, thanks for the info! For now I'm just reading about a few alternatives supporting pandoc. I want to add a nice display of org-roam notes (an emacs thing) in my blog and for that I would have to do some manipulation on what's parsed by pandoc and maybe generate new pages based on that. I know very little Haskell so this is also a long term project for me to learn more about the language.


WGLMakie JSServe example gives error

I copy and paste the code wgl.md and try to make it works like this WGLMakie JSServe demo. But serve() throw errors below.
lift(f, obs...; init=f.(obs...), typ=typeof(init)) is deprecated. Use lift(typ, f, obs...), or map!(f, Observable(), obs...) for different init.
Detailed log

Log
→ evaluating code [ex] in (blog/2021/09/WGLMakie.md
┌ Warning: Everything from AbstractPlotting.jl got moved to Makie.jl.
 │ Have a look at the README for information on how to upgrade:
 │ https://github.com/JuliaPlots/AbstractPlotting.jl
└ @ AbstractPlotting ~/.julia/packages/AbstractPlotting/2A5iv/src/AbstractPlotting.jl:261
┌ Warning: Everything from AbstractPlotting.jl got moved to Makie.jl.
 │ Have a look at the README for information on how to upgrade:
 │ https://github.com/JuliaPlots/AbstractPlotting.jl
└ @ AbstractPlotting ~/.julia/packages/AbstractPlotting/2A5iv/src/AbstractPlotting.jl:261
┌ Franklin Warning: in <index.md>
  │ There was an error of type 'ErrorException' when running a code block.
 │ Checking the output files '/home/dzc/Documents/paperrec/__site/assets/blog/2021/09/WGLMakie/code/output/ex.(out|res)'       │ might be helpful to understand and solve the issue.
 │
 │ Relevant pointers:
 │ - evaluation of Julia code blocks: https://franklinjl.org/code/
 │

Details:
│ lift(f, obs...; init=f.(obs...), typ=typeof(init)) is deprecated.  But I still don't now how to fix it.
Some experiment
I delete some lines in App() do … end, and find
Only one case works for me
I also found that if the App() only contain JSServe.Slider(1:3), then it do give a slider
app = JSServe.App() do
    return DOM.div(
        JSServe.Slider(1:3)
    )
end

These don’t work
app = JSServe.App() do
    return DOM.div(
        scatter(1:4)
    )
end

app = JSServe.App() do
    return DOM.div(
        surface(rand(4, 4))
    )
end

In these cases, it gives error lift(f, obs...; init=f.(obs...), typ=typeof(init)) is deprecated. Use lift(typ, f, obs...), or map!(f, Observable(), obs...) for different init.
Julia version
Julia 1.6.2
(paperrec) pkg> st
      Status `~/Documents/paperrec/Project.toml`
  [713c75ef] Franklin v0.10.51
  [824d6782] JSServe v1.2.3
  [97e4c2e4] JSXGraph v0.1.6
  [2bd173c7] NodeJS v1.3.0
  [276b4fcb] WGLMakie v0.3.5

Both JSServe and WGLMakie are the same version as in /demo/

Hello @ChasingZenith WGLMakie is deprecated and so using it is touchy, also I'm very unfamiliar with it and maybe I should just remove that demo.
Can you ask on the Makie slack channel what is the recommended way now to go instead of WGLMakie+JSServe? please ping me and sdanisch in that conversation. I'll be grateful for your help in fixing this demo to whatever is the recommended way to do it now.
I'll close this here as this is not a Franklin issue

Update here. It seems that PlotlyJS.jl does not block WGLMakie.jl anymore. And both work well with Franklin.jl!
Status `~/Documents/newsite/Project.toml`
 [713c75ef] Franklin v0.10.53
 [824d6782] JSServe v1.2.3
 [2bd173c7] NodeJS v1.3.0
 [f0f68f2c] PlotlyJS v0.18.7
 [276b4fcb] WGLMakie v0.4.6

They are all up-to-date versions. (2021.9.14)


Cleanup compilation warnings

Cleaning up some compilation warnings for new features code not being under corresponding CFG flag, and an unused  use I saw while testing the package.
PD: 0.9 is published in AUR ;)

Thanks @alosarjos. LGTM generally. Let's wait for the checks to make sure we don't miss anything.

By bad, this AnyHowContext needs to be in the Scope if any of two different features is enabled. I think it should be fine now.


Features used for SLT Arctic

How many features are used for the SLT Arctic recipe? In RESULTS.md, I see lines such as
Labels: state_align; Network: [416->5] LR 0.002 [4 TANH] [4*512];

for the duration model and
Labels: state_align; Network: [425->187], LR 0.002 [4 TANH] [4*512];

for the acoustic model.
However, in the paper Merlin: An Open Source Neural Network Speech Synthesis System, there is a line that says 491 input features were used for all neural networks. What is the correct number of features?

It depends on the question file you use and how many features are in there. There are always 9 more acoustic features than duration features for the same question file. If you run the model training, you can see in the inter_module directory in the directory names how many features are used.

I am using questions-radio_dnn_416.hed, which I understand contains 416 features. I am also using the 9 subphone features, which explains 425 features in the acoustic model. Where are the remaining 66 features? Are they not used?

No, those are the features that are used.

Just to clarify, only 416/425 features are used?

Yes

Thank you for the clarification.
On an unrelated note, I am trying to train a model using only the QS features in the .hed file. I created a new .hed file that is similar to questions-radio_dnn_416.hed but does not contain the CQS features. I also modified the configuration files to point to the new questions file. However, when I tried this I received an error.
Traceback (most recent call last):
  File "/home/xxxxxx/merlin/src/run_merlin.py", line 1320, in <module>
    main_function(cfg)
  File "/home/xxxxxx/merlin/src/run_merlin.py", line 672, in main_function
    label_normaliser.prepare_dur_data(in_label_align_file_list, file_paths.dur_file_list, cfg.label_type, cfg.dur_feature_type)
  File "/home/xxxxxx/merlin/src/frontend/label_normalisation.py", line 148, in prepare_dur_data
    self.extract_dur_features(ori_file_list[i], output_file_list[i], label_type, feature_type, unit_size, feat_size)
  File "/home/xxxxxx/merlin/src/frontend/label_normalisation.py", line 155, in extract_dur_features
    A = self.extract_dur_from_state_alignment_labels(in_file_name, feature_type, unit_size, feat_size)
  File "/home/xxxxxx/merlin/src/frontend/label_normalisation.py", line 228, in extract_dur_from_state_alignment_labels
    if(label_continuous_vector[0, 1]==1 or current_phone in list_of_silences): ##pos-bw and c-silences
IndexError: index 1 is out of bounds for axis 1 with size 0

I looked through the code, and it seems like it requires continuous/CQS features to compute the durations.
My questions: Can the model be trained without using CQS features? If so, what do I need to do to get the code to ignore the continuous features?


Need python examples for env variables

Where the doc reads...
The function app settings values can also be read in your code as environment variables. For more information, see the Environment variables section of these language-specific reference topics:

...the python runtime is missing. Please consider adding.
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b2646ad4-34b7-fc5e-dcc9-d53a061df394
Version Independent ID: bbff4fda-24e4-2b62-24b9-94cda5f53bed
Content: Work with Azure Functions Core Tools
Content Source: articles/azure-functions/functions-run-local.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@SeaDude Thanks for the feedback. We are currently investigating into the issue and will update you shortly.

@SeaDude I have assigned this to content author for further review and update as appropriate.

@SeaDude great catch!
Fixed in linked PR #please-close


Bug in MqttTcpServerAdapter

Describe the bug
After upgrading to 3.0.6 I am no longer able to start the hosted MQTT server with encrypted endpoint.
Which project is your bug related to?

Server

To Reproduce
Steps to reproduce the behavior:

Using this version of MQTTnet '3.0.6'.
Build server options with MqttServerOptionsBuilder
WithEncryptionCertificate(certificate)
Server is unable to start due to null reference exception in MqttTcpServerAdapter line 51

Code example
Can be fixed with this code (line 51 in MqttTcpServerAdapter)
// Original
var tlsCertificate = new X509Certificate2(options.TlsEndpointOptions.Certificate, options.TlsEndpointOptions.CertificateCredentials.Password);
// Modified
var tlsCertificate = new X509Certificate2(options.TlsEndpointOptions.Certificate, options.TlsEndpointOptions.CertificateCredentials?.Password);

@erikkj Are you using a certificate without password? Or when exactly does this exception occur? This seems to be an with CertificateCredentials being null by default and trying to access it in MqttTcpServerAdapter.
In my opinion, this should be fixed with something like this:
if (options.TlsEndpointOptions.CertificateCredentials == null)
{
    throw new ArgumentException("The certificate credentials are not set.");
}

@SeppPenner
I export the certificate like this: new X509Certificate2(_settings.CertificatePath, _settings.CertificatePassword, X509KeyStorageFlags.Exportable).Export(X509ContentType.Pfx)
The final certificate I send to WithEncryptionCertificate is without password.
The code ran smooth before the upgrade without using credentials.

@erikkj Okay, I didn't use this without password yet. If this was possible before, you're right.

@SeppPenner @erikkj Please try again with 3.0.7-rc1. It should work again.

I had the same problem. With 3.0.7-rc1 it is now working again for me.

I can confirm that the problem is fixed in 3.0.7-rc1. Thank you!

Good to know ;)


Pin protobuf version dependency for grpcio-tools

Fixes #24897
Since both the protobuf and grpcio-tools packages include libprotobuf as a shared library, an application loading both of them has symbol conflicts that need to be resolved by the operating system's runtime linker. In most cases, the runtime linker uses the first loaded symbol, ignoring the second. In corner cases, such as in MacOS in #24897, some startup functions were run by the version from grpcio-tools while the version packaged with protobuf was called at runtime. This resulted in corruption from the perspective of the version of libprotobuf packaged by the  protobuf wheel because internal data structures had changed between the two versions.
By requiring an exact version, this is no longer an issue. This also brings Python into line with other wrapped languages, including Ruby, C#, and Objective-C. Since updating the Protobuf version has been a tedious manual process in the past, I went ahead and pulled all languages into the templating system so in the future, only one instance of the protobuf version string will have to be changed -- in build_handwritten.yaml.
CC @jtattermusch since some of these changes will have to be reconciled with https://github.com/grpc/grpc/pull/24855. Once this is merged, I'll update the "Updating third_party/protobuf submodule in grpc" document accordingly.
CC @yulin-liang since this also touches Obj C files.

Btw the protobuf and grpcio-tools conflict only happens in python because of the weird way the protoc binaries are distributed in python (as a python native extension as opposed to just binaries). FWIW it might be useful to simplify the grpcio-tools package by not duplicating the entire protobuf build (for which we extract the build metadata from protobuf's bazel - which has always been a hack).

Unrelated failure: https://github.com/grpc/grpc/issues/24937


Feature/mcuboot single image dfu

Commit [nrf fromlist] zephyr: Allow single image applications is also reviewed here:
~~https://github.com/zephyrproject-rtos/mcuboot/pull/18~~
https://github.com/JuulLabs-OSS/mcuboot/pull/741
https://github.com/JuulLabs-OSS/mcuboot/pull/752
West update here:
https://github.com/nrfconnect/sdk-nrf/pull/2291

The DT macros that pick flash image differ between this and upstream pull request as the upstream already uses new DT API.

Some checks failed. Please fix and resubmit.
Gitlint issues
Commit 894144773b:
1: UC3 Title does not follow [subsystem]: [subject] (and should not start with literal subsys:): "[nrf noup] Single image application support for PM"
Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Remove [DNM] as patch is already accepted upstream.

No longer needed.


feat: link LibUV

@ydewit Yes, the ultimate goal is support for non-blocking IO. Note however that this PR only links against LibUV and it might take a very long time until we actually start building anything on top of it, so if you have need for asynchronous IO right now then it probably makes sense to explore alternatives such as lean-libuv for now.

We should probably add to the docs page on building Lean that you need to have libuv installed right? Alternatively we could do something similar to the CaDiCal PR and declare libuv as an external project that gets downloaded and compiled by our build system directly.

Thanks, I've updated the build instructions. We don't want to build libuv as part of our build system, but use either system libraries (when building manually) or take static libraries from Nix (when creating release versions via CI), just as we do it with GMP.


Fixes XML character escaping in 'spo listitem batch set' command.

Closes #6430

Thank you @Saurabh7019!

Hi @milanholemans, I modified an existing test to simulate input with special characters and verified escaped output. Please let me know if this works or if an additional test is required.

Merged manually, thank you for the fix!


pg_num always 64

% ceph osd pool get rbd pg_num
pg_num: 64
I've set in production/group_vars/all:
pool_default_pg_num: 4096
pool_default_pgp_num: 4096
but this seems to be ignored in some way, suggestions? Thanks.

During the monitor bootstrap I have the impression that ceph does not honor the value set in the ceph.conf. The default value in the playbook is 128 anyway ao it's probably ceph. What do you get if you run rados mkpool foo?

% rados mkpool foo
successfully created pool foo
% ceph osd pool get foo pg_num
pg_num: 4096
so yes, the problem is during bootstrap. I have 10 OSDs, two nodes, 1 SSD on each node for journal.
With pg_num 64 I get:
health HEALTH_WARN
31 pgs peering
64 pgs stuck inactive
64 pgs stuck unclean
too few PGs per OSD (12 < min 30)
Any ideas how to fix? Thanks.

Just increase the PG size like this:
$ sudo ceph osd pool set rbd pg_num 512
Wait a bit and then run:
$ sudo ceph osd pool set rbd pgp_num 512

Already tried:
% ceph osd pool set rbd pg_num 512
Error E2BIG: specified pg_num 512 is too large (creating 448 new PGs on ~10 OSDs exceeds per-OSD max of 32)
% ceph osd pool set rbd pg_num 128
Error EBUSY: currently creating pgs, wait
I can rebuild the whole ceph thing easily from scratch via ansible ceph as I wrote a purge complete script which brings me in a clean state on both nodes from where I can start over, problem persists anyway. I think the rbd pool must be created with higher pg_num during initial deployment (just guess). Thanks

and...
Error EBUSY: currently creating pgs, wait
will last forever, seems.

it'll finish, but it may have to move a lot of data.  However, you must have had a prior set pg_num in progress?

Ceph has been set up from scratch there's no data inside and only the rbd pool. The problem arises after each new ansible deployment, disks are completely cleaned up before so ansible ceph recreates also the partitions, so 100% sure no data is inside ceph.

could be then that with two nodes the crushmap is set up to try to replicate across nodes rather than osds, and thus can't get to replication level 3 (the default)?...

Replication level is 2, I set it to that as far as I've 2 nodes for now, a third node will join soon. But for now 2 and all is set up accordingly.

dunno.  I'm sure this works, though; maybe hop on #ceph and ask

Ok, thanks. Anyway it seems that pg num 64 in my case is not enough for rbd pool, it's all about increasing this value during bootstrap I presume.

As Dan mentioned it will eventually finish. Check the status of your cluster. I've never seen thus process getting stuck unless you have a crush map issue.

Alright, I'll wait and let you know. Anyway for now thanks to all the support, very appreciated!

At which point during deployment the rbd ceph pool is being created? Maybe we miss some parameters during creation which should specify a pg_num > 64? Thanks.

I've redeployed the whole cluster from scratch, two times, and now % ceph osd pool set rbd pg_num 256 works fine. No idea. Furthermore, is something like this correct?
devices:

/dev/sdb
/dev/sdc
/dev/sdd
/dev/sde
/dev/sdf

osd_auto_discovery: false
journal_collocation: false
raw_multi_journal: true
raw_journal_devices:

/dev/sdg
/dev/sdg
/dev/sdg
/dev/sdg
/dev/sdg

Thanks.

Problem seems to be related to private/public network config, set correctly. Now during deployment I can e.g. run: % watch -n 1 "ceph osd pool set rbd pg_num 512 ; ceph osd pool set rbd pgp_num 512" which sets pg_num and pgp_num fine now.

Glad to hear that it works now. Your config is correct yes.

Thanks Leseb. One last question: In case /dev/sdg (SSD Journal) dies I'll lose all my OSDs, can I mix having some OSD journals on /dev/sdX (SSD) and also on /dev/sdf2 let's say? Something like:
devices:
/dev/sdb1
/dev/sdc1
/dev/sdd1
/dev/sde1
/dev/sdf1
osd_auto_discovery: false
journal_collocation: false
raw_multi_journal: true
raw_journal_devices:
/dev/sdg
/dev/sdg
/dev/sdg
/dev/sdf2
/dev/sdf2
Thanks.

Yes you can, the current mapping will do:

/dev/sdb1 will have /dev/sdg1 as journal
/dev/sdc1 will have /dev/sdg2 as journal
/dev/sdd1 will have /dev/sdg3 as journal
/dev/sde1 will have /dev/sdf1 as journal
/dev/sdf1 will have /dev/sdf2 as journal

I don't think we support using partitioned device for the journal. So you can't use /dev/sdf2, use the whole device instead.

Allright, thanks Leseb.


Clean dangling widget in test

Description

in test_making_plugin_dock_widgets we test if the widget is correctly removed from napari viewer but do not ensure that it is deleted.
Type of change

[x] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change
[ ] example: I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

This is the nasty error we see everywhere right? Let's get it in asap :P

Yes, It is try to fix this.

Looks liek you got it, nice!

I will restart the tests a few times to ensure.

Is this one to maybe waive the 24 hr clock and just get merged?

The problem that I see is that all min req tests are timeout

The problem that I see is that all min req tests are timeout

Ok. Bug is unrelated to this PR. It is our bad minimum requirement configuration. It stuck on the dependency resolver.

@brisvag @psobolewskiPhD, what did you think about this. Could I merge this with the hanged minimum requirement test?

Hmm, I mean it's definitely progress?
Still results in the ❌ but maybe a more easily ignored ❌?

Yes, let's merge. The minreq failure is unrelated and we sould handle it elsewhere, but at least this solves the other test failures.


Cache utils related cleanup

What does this PR do?
Removes obsolete code related to the previous cache system for training.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Let's merge this after the release, shall we ?

Merging before the release since we need the fix to be able to fetch from a remote cache repo.


Concept note

Finalize on the concept note

Contents of the concept note have been adapted to the research proposal, with relevant adjustments.


Network param instances

Embedding the network parameter component in places where they were mentioned, or where they may be useful.
I think we would benefit from a style guide for how we use these, as there are a few patterns at the moment. Maybe that's fine though!

I'd be happy with a style guide/limiting the configurability of the component to Do The Right Thing. I think it's used in enough places that it would make sense to have some rules, so far I have more molded it to the text that exists rather than thinking about consistency - happy to change.

I agree @edd! I think we have enough "live" examples of different ways to express the idea, so we could audit and have a conversation about what we think is most readable.


Wireguard plugin API call

I wanna automate user creation for OpnSense Wireguard plugin.

I can create new user by /wireguard/client/addclient api call (an example new peer have uuid "7cd840ca-d649-4df5-aa01-5c2f783980c7") .

Now I need to enable new user (Peer) in VPN>Wireguard>Local>Peers

I call /wireguard/server/set API with JSON
{
"server": {
"enabled": "1",
"peers": {
"7cd840ca-d649-4df5-aa01-5c2f783980c7": {
"selected": "1"
}
},
"uuid": "9cdba781-2611-4168-97f2-1ff25c61a64f"
}
}
where "9cdba781-2611-4168-97f2-1ff25c61a64f" is my Wireguard server uuid
and next call /wireguard/service/reconfigure API
But unfortunally new peer stay uncheked in VPN>Wireguard>Local>Peers :(((((
What I do wrong?

Can you give an sample of the payload you are sending to create the client, I am still just trying to create the client :)

This is part of Jenkins job (sh call):
header="Content-Type: application/json"
auth="${env:opnUser}:${env:opnPassword}"
url="http://<IP_ADDRESS>/api/wireguard/client/addClient"
data='{"client": {"enabled": "1","name": "${env:uName}_${env:ulName}","pubkey": "${env:pubkey}","tunneladdress": "${env:vpnAddr}","persistentkeepalive": "25"}}'
curl -X POST -H "$header" -u "$auth" -d "$data1" "$url"
Subscribe if you can solve my problem :))))))))

Here it is made with wireguard/server/setServer: https://github.com/FingerlessGlov3s/OPNsensePIAWireguard/blob/main/PIAWireguard.py
Still I couldn't get it to work. Do I need to repost all existing peers? I tried it, but the new one still is not "selected" in the GUI.

Ok, I found out how to set an single peer active:
send {'server': {'peers': SinglePeerUUID}} to wireguard/server/setServer, then SinglePeerUUID gets enabled.
But, my problem is, all others that were enabled before are disabled now. How can I either leave them alone, or set multiple peers enabled? I triewd to post a list of UUIDs instead of SinglePeerUUID, but this doesn't work. Any help appreciated.

Ok, I figured this out and posted here: https://forum.opnsense.org/index.php?topic=33177.msg163175#msg163175:
To set an single peer active send {'server': {'peers': SinglePeerUUID}} to wireguard/server/setServer/ServerUUID, then SinglePeerUUID gets enabled. To set multiple active: {'server': {'peers': 'SinglePeerUUID1,SinglePeerUUID2' }}
Take care, not to send a json array ['SinglePeerUUID1','SinglePeerUUID2'], but a string with comma separated values.
Still I consider this a bug - in the documentation. IMO this belongs on this page: https://docs.opnsense.org/development/api/plugins/wireguard.html

I made a little project which allows to make a new wireguard peer and push it to the opensense: https://github.com/pkoevesdi/wg-keygen-notrust. Can also be used as a demo for the wireguard API.


"Azure Function Example" doesn't work as sxpected.

I've followed all step to run the given example and all the outputs are same as the given tutorial.

But the HTTP Trigger function is not working in the port 9574.

And the API call also not working as expected.

@shehand can you verify whether the docker container is working manually?


Problem with google cloud speech client on UWP application

When attempting install google cloud speech client library to UWP application, I got the error message from nuget console as below:

Install-Package : Package Google.Cloud.Speech.V1 1.0.1 is not compatible with uap10.0.16299 (UAP,Version=v10.0.16299). Package
Google.Cloud.Speech.V1 1.0.1 supports:

net45 (.NETFramework,Version=v4.5)
netstandard1.5 (.NETStandard,Version=v1.5)

Yes, I'm afraid our client libraries don't currently support UWP.

Thank you @jskeet , shall your client libraries support UWP application in the future ?
Currently, is there any way to use google cloud speech service on UWP application ?

We would like to support UWP, but it's further down the priority list than Unity and probably Xamarin support.
You could try using the Google.Apis.Speech.v1 API, which talks via HTTP1/REST instead of HTTP2/gPRC, but:

That library still doesn't officially support UWP, and in particular the authentication aspects may well cause problems. (You'd be able to use a service account, but distributing that is not ideal to say the least.)
That library won't support any streaming operations.

I'm going to close this issue as we're not expecting to take any direct action on it in this repo - you can still add comments, of course. We'll update the supported platforms documentation if and when UWP is supported.


Export Wordpress

Background
Allows exporting translations to Wordpress .
Two components:

Flask endpoint - this endpoint gets triggered to send the request to add a translation in Wordpress
Wordpress Plugin - processes the trigger so it can create the translated content.

Sample Flask Request
You would need to run ~/ingestion/ingest-wordpress.py in order to execute this.
POST /wp-export

JSON
{
    "id": 1,
    "lang": "fr",
    "content": "
Bonjour le monde! Je suis Rapi Castillo
",
    "title": "Bonjour le monde!",
    "excerpt": "Hello this is a french translation xx",
    "status": "publish"
}

TODO

Enable update in Wordpress for an already existing translation

When you rebase against master, ingestion/ingest_wordpress.py will have moved to import_export/import_wordpress.py
Can you make a new file export_wordpress.py and move your py code there?

@nyccto-rapicastillo  is this PR still valid or should it be closed?


Use self-contained widgets for UI elements (e.g. the version switcher)

Context
Currently, we have a number of "widgets" that can be turned on in the navbar of the theme. These are configured with a combination of two things:

Some configuration in html_theme_options. For example, for icon links + a version switcher, as we use in our docs now:    "icon_links": [
        {
            "name": "PyPI",
            "url": "https://pypi.org/project/pydata-sphinx-theme",
            "icon": "fas fa-box",
        },
        {
            "name": "Pandas",
            "url": "https://pandas.pydata.org",
            "icon": "_static/pandas-square.svg",
            "type": "local",
        },
    ],
    "switcher": {
        # "json_url": "/_static/switcher.json",
        "json_url": "https://pydata-sphinx-theme.readthedocs.io/en/latest/_static/switcher.json",
        "url_template": "https://pydata-sphinx-theme.readthedocs.io/en/{version}/",
        "version_match": version_match,
    },

Defining an HTML template in some theme location, e.g. for the icon links above:html_theme_options = {
      ...
      "navbar_end": ["version-switcher", "navbar-icon-links"],
      ...
}

Separating out the "configuration" from the "placement" of these components has a couple of downsides.

It means that creating a new kind of UI also means creating a new theme configuration variable in theme.conf, which is already quite long.
It makes it more difficult to re-use the same configuration structure for different parts of the theme (for example, a language switcher is basically the same thing as a version switcher, but with the current setup we'd need to define a new HTML template + configuration variable for it.
Separating the configuration from the placement means keeping track of the same kind of information in two different places, which seems artificial and may lead to confusion.

Since we already ask people to provide a list of templates, we could simplify things by instead letting people provide a list of configurations that would define the elements inserted into that section of the page.
Proposal
Instead of using two configuration variables to configure and place theme UI elements, we instead combine these into a single configuration. For the major UI areas, rather than accepting a list of template names, they would instead accept a list of dictionaries of configuration that corresponds to a type of widget to be inserted.
For example, below would be the same configuration as above, but also shows off how we could define a second dropdown switcher by re-using the same config:
html_theme_options = {
    # Widget configuration for the end of the navbar
    "navbar_end": [
        # First few items are icon links
        {
            "kind": "link",
            "label": "PyPI",
            "url": "https://pypi.org/project/pydata-sphinx-theme",
            "icon": "fas fa-box",
        },
        {
            "kind": "link",
            "label": "Pandas",
            "url": "https://pandas.pydata.org",
            "icon": "_static/pandas-square.svg",
            "type": "local",
        },
        # Now a widget of type "switcher"
        {
            "kind": "switcher",
            "json_url": "https://pydata-sphinx-theme.readthedocs.io/en/latest/_static/switcher.json",
            "version_match": version_match,
        },
        # We could then define a different switcher w/ the same widget type like so:
        {
            "kind": "switcher",
            "json_url": "https://pydata-sphinx-theme.readthedocs.io/en/latest/_static/switcher_language.json",
            "version_match": language_match,
        },
    ]
}

You could also re-use the same widgets in multiple places, with different configurations. For example, if you wanted some icon links in the navbar, but other icon links in the sidebar or footer.
ref: this is inspired by the furo topbar theme, but uses a list of dictionaries so that we could re-use the same widget type multiple times in the same UI area.
How could this be implemented?
One way to implement this would be to define a variable in the HTML context called something like html-widgets. This would be a dictionary of the form <widget-kind> : <jinja macro>. It would work like this:

The kind key of our widget configuration would be used to select a widget macro from html-widgets
The macro would then accept all other keys for that widget's configuration (other than kind) as key/val pairs
The macro would be expected to return a blob of HTML

In our theme templates, we could use this html-widgets dictionary like so:
{% for config in context.get("theme_navbar_end", []) %}
{% set kind = config.pop("kind") %}
{{ context["html-widgets"][kind](**config)
{% endfor %}

With a structure like that, it would also be possible for other packages to piggy-back on the same functionality, by adding their own widget-kind/macro pairs with a Sphinx event, which users could then insert into their theme configuration via the same mechanism described above.
We could define and register these macros like so:
{% macro mywidget(text) %}
{{ text }}
{% endmacro %}
{% context["html-widgets"].append({"mywidget", mywidget}) %}

(I'm not positive this is the right syntax but I think you can do something like this in Jinja.)
Or you could similarly define a function in Python, and add it to the context html-widgets list in the same way. It would just need to output an HTML string.
Longer term
Longer term, I think that it would be best if we tried to standardize these configuration structures across themes, such as Furo and the Book Theme, so that users could port their configurations for common things across themes. This has also already been discussed in the book theme in this issue on pluggable widgets and there's also an implementation to play around with here. I'm opening up the issue in this repository in case we can use this as a chance to prototype some functionality in this theme and see how it feels.
Feedback?
I'd love to hear what people think about the general idea, and about the specific configuration proposed above. Does this seem like it would be useful?

@choldgraf pinged me via another channel about this... and this is something I've been thinking about a bunch.
I think what we should do for version switchers is have them be external-to-the-theme, provided to the templates as context variables.
This can happen either via html_context manually provided by a user (or, more realistically, by a Sphinx extension or RTD's injection logic). That way (a) this would be transferable across themes, (b) would externalise the complexity of "how do I specify multiple versions" away from the theme and into an extension; allowing that to be a replaceable thing and (c) has a clearer separation of concerns.
We effectively have a design to make portable for this, in sphinx-multiversion. See also https://github.com/pradyunsg/furo/issues/372 and https://github.com/python/docs-community/issues/4 as well, for context.
x-ref: https://github.com/pradyunsg/sphinx-basic-ng/issues/12


Kafka seekTImestamp should also support timestamp in 2024-01-29T19:35:21.959 format

Related to Issue https://github.com/authorjapps/zerocode/issues/615
// 1) Currently we supply the timestamp this way i.e. either hardcoding or getting it from earlier steps/props
// (implemented in #615 )
"seekTImestamp": "1706244382000".

The below TODO after #615 is done
Support The Following also:

As a user of the library e.g. as a Dev/Tester, how will the user supply/generate the timestamp value during the test run?

AC1:
So, provide the mechanism to get the Long epoch value inferred from the datetimestamps formated values:
e.g.
The following also should be acceptable to the framework:
// 2) hardcoded or getting it from earlier steps/props
"seekTImestamp": "2024-01-29T19:35:21.959"

// 3) Generating via a placeholder token (this mechanism is already available)
"seekTImestamp": "${LOCAL.DATETIME.NOW:yyyy-MM-dd'T'HH:mm:ss.SSS}"

So we need to support all of the above usages.
Actually points 2 and 3 will work identical way once implemented.

@authorjapps  In addition to this, do you think out of the box, doing something like:
"seekTImestamp": "${$.prior_step.resonse.generated_timestamp}" will work
Then we can generate the timestamp to consume from on a previous step?

@authorjapps In addition to this, do you think out of the box, doing something like: "seekTImestamp": "${$.prior_step.resonse.generated_timestamp}" will work?
Then we can generate the timestamp to consume from on a previous step?

Hello @a1shadows , I suggest you please pick this after your other PR is done or at least after it comes to a logical end.
Also I would advice not to distracted by this new ticket ✋

Ok, now to answer your query, let me try to explain:
"${$.prior_step.resonse.generated_timestamp}" => This works anyways in the existing framework. That's not the problem here
The problem is, your current PR implementation may not work(or may work once you complete the full implementation) for timestamps other than ECPOCH time in long/integer format.
This ticket #621 was raised to support the below format as well, so that we allow EPOCH as well as the standard format i.e.
"seekTImestamp": "2024-01-29T19:35:21.959"
If your current PR will allow both formats, I think we can simply close this ticket #621 without further spedning time on this.

Related to Issue #615
// 1) Currently we supply the timestamp this way i.e. either hardcoding or getting it from earlier steps/props
// (implemented in #615 )
"seekTImestamp": "1706244382000".

The below TODO after #615 is done
Support The Following also:
* As a user of the library e.g. as a Dev/Tester, how will the user supply/generate the timestamp value during the test run?

AC1: So, provide the mechanism to get the Long epoch value inferred from the datetimestamps formated values: e.g. The following also should be acceptable to the framework:
// 2) hardcoded or getting it from earlier steps/props
"seekTImestamp": "2024-01-29T19:35:21.959"

// 3) Generating via a placeholder token (this mechanism is already available)
"seekTImestamp": "${LOCAL.DATETIME.NOW:yyyy-MM-dd'T'HH:mm:ss.SSS}"

So we need to support all of the above usages.
Actually points 2 and 3 will work identical way once implemented.

@authorjapps I can definitely incorporate this into my PR, but I have a concern here. If we want to support formatted strings, for instance 'yyyy-MM-dd'T'HH:mm:ss.SSS' should we not be taking the pattern as input as well along with the actual timestamp? Or will we only support one pattern?
Or would it be better to make LOCAL.DATETIME.NOW support epoch format as well?

Related to Issue #615
// 1) Currently we supply the timestamp this way i.e. either hardcoding or getting it from earlier steps/props
// (implemented in #615 )
"seekTImestamp": "1706244382000".

The below TODO after #615 is done
Support The Following also:
* As a user of the library e.g. as a Dev/Tester, how will the user supply/generate the timestamp value during the test run?

AC1: So, provide the mechanism to get the Long epoch value inferred from the datetimestamps formated values: e.g. The following also should be acceptable to the framework:
// 2) hardcoded or getting it from earlier steps/props
"seekTImestamp": "2024-01-29T19:35:21.959"

// 3) Generating via a placeholder token (this mechanism is already available)
"seekTImestamp": "${LOCAL.DATETIME.NOW:yyyy-MM-dd'T'HH:mm:ss.SSS}"

So we need to support all of the above usages.
Actually points 2 and 3 will work identical way once implemented.

@authorjapps I can definitely incorporate this into my PR, but I have a concern here. If we want to support formatted strings, for instance 'yyyy-MM-dd'T'HH:mm:ss.SSS' should we not be taking the pattern as input as well along with the actual timestamp? Or will we only support one pattern?
Or would it be better to make LOCAL.DATETIME.NOW support epoch format as well?

@a1shadows, Good question mate 👍
I think it would be better the below way, if you can accommodate in your PR please.
This will make things clean in terms of usability as well as implementation.
e.g.

For Epoch:

"seekEpoch": "<Epoch long number>"  <---- Keep this as String type please (not Long/Int)

and
for Timestamp:

"seekTImestamp": {
   "dateTimestamp" : "2024-01-29T19:35:21.959",
   "format" : "yyyy-MM-dd'T'HH:mm:ss.SSS"
}

"seekTImestamp": {
   "dateTimestamp" : "2024-01-29T19:35:21.959340",
   "format" : "yyyy-MM-dd'T'HH:mm:ss.ssssss"
}

// This was user will have more flexibility to supply the values.

I suggest you implement this "seekTImestamp" in a separate PR, but I will leave to you to decide :-)

@authorjapps I think we can close this as well

Closed by #615


Fix markdown conversion issues in the variance section.

Fixes part of https://github.com/dotnet/csharpstandard/issues/617. @Nigel-Ecma for review.


[Bug]: Can't install using composer require

What happened?
Filament: v2.17.49
I tried to install this package into my Laravel filament app but can't install it, I got an error, maybe PHP or Laravel or composer version error.
filament@bar:~$ composer require fastofi-corp/filament-printables
Info from https://repo.packagist.org: #StandWithUkraine

In PackageDiscoveryTrait.php line 331:

  Could not find a version of package fastofi-corp/filament-printables matching your minimum-stability (stable). Require it with an explicit version constraint allowi
  ng its desired stability.

I had to install it this way composer require fastofi-corp/filament-printables:dev-main. I think this can be resolved in two ways, first, change the Readme docs so everyone installs this version or allow to install the latest version by default using composer.
How to reproduce the bug
Run composer require fastofi-corp/filament-printables command with the version od PHP, Laravel and Filament version I've installed.
Package Version
latest
PHP Version
8.1.18
Laravel Version
10.14.0
Which operating systems does with happen with?
macOS
Notes
No response

Sorry for the delay.
You can use the composer command normally. We released a 1.0.0 version.

use composer require fastofi-corp/filament-printables
not
composer require fastoficorp/filament-printables

@alvleont kindly update README appropriately


Makefile.dev: No such file or directory

Hello,
after cloning the repository and creating the ../bin folder , command make doesn't work and returns the following message:
Makefile:6: Makefile.dev: No such file or directory make: *** No rule to make target 'Makefile.dev'.  Stop.
am I making something wrong? Thanks for your support!

Closed by #7


Default clear color not applied on some projects.

Operating system or device - Godot version:
Godot 2.1 stable, Windows 8.1, Intel HD4600.
Issue description (what happened, and what was expected):
In some projects the new clear color is applied only in editor.
In the other projects the new clear color is applied only in the running game. After a restart the color is applied in the editor too, as expected.
Steps to reproduce:
In the "SAT collision test" demo set another default clear color.
Link to minimal example project (optional but very welcome):
The "SAT collision test" official demo  ;)

I think we will need to check if this bug will be still present after renderer rewrite in Godot 3.0

Bump, I think I saw it fixed in some gif, was it?

I tested this and does not seem to be happening any longer


Native aarch64, ppc64le, s390x support?

Travis CI supports aarch64, ppc64le, s390x now so maybe it is time to switch and generate binaries for all archs?
Would probably require bumping protoc version to something newer with binaries for all those architectues (3.11.1 has them).

This is not directly binary but docker image for these arch are generated :
https://hub.docker.com/r/skydive/skydive/tags
It is generated by this script by the CI :
https://github.com/skydive-project/skydive-ci/blob/master/scripts/create-docker-image.sh

In OpenStack Kolla we use that binary for own images :D
Anyway if some user will want to run it on non-x86 then they will have an option.
Thanks.


Update specify-how-fonts-should-degrade.md

At the end of the second sentence "These generic font families include monospace, serif and sans-serif" the period was missing.
Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Mind me i'm just a beginner


Couldn't remove comma and dot from android keyboard

I have set keyboardType to TextInputType.numberWithOptions(signed: false, decimal: false) but on android it still on keyboard and there is no inputFormatters for incoming input.
sorry for my english.

I'm not sure why this would happen. It looks like this isn't working for a regular text field too.
Anyway, I added support for input formatters with v2.1.0 so you can do something like this:
PinCodeFields(
  keyboardType: TextInputType.number,
  inputFormatters: [FilteringTextInputFormatter.digitsOnly],
)


Use standard OF flow identifier

Currently, we use a non-stardard hash for OF 1.0. For OF 1.3 compatibility, it will be changed in kytos/flow_manager#1.

of_stats must use Flow ID in the database. This is being implemented in of_core's generic Flow.


Add libSwiftScan entry-points to query supported compiler flags and compiler features

For the client library (libSwiftDriver), this is critical for multiplexing library instances, and for compatibility with different versions of libSwiftDrvier.
Resolves rdar://73631930

@swift-ci please test

Thanks for adding these! Can we change the design to returning the full list of supported arguments and features instead of checking if one is supported? The benefit is that the client side has better debuggability because we have the full list visible from swift-driver. The logic of checking if an argument is supported can be trivially implemented from the client side.

Thanks for adding these! Can we change the design to returning the full list of supported arguments and features instead of checking if one is supported? The benefit is that the client side has better debuggability because we have the full list visible from swift-driver. The logic of checking if an argument is supported can be trivially implemented from the client side.

Yeah, I think that's a better thing to do, I'll make the change.

@nkcsgexi, I've changed the query format as per your suggestion.

@swift-ci please smoke test

Build failed
Swift Test OS X Platform
Git Sha - 92e9a75fb9f344a686d485e4cea3b6aff6a255f1


There is no compass control for OpenLayers 3

Many mapping libraries provide a compass overlay which you can use to both indicate north and reset to north.  OL3 has the rotate control, but if north did not start at 0 it does not point north (nor does it try to represent a compass).
I would like to contribute a similar compass control along with a (configurable) northward pointing icon.  Unfortunately I do not see how or where to contribute the icon; aside from the logo-70x70.png in config/jsdoc/api/template/static, I don't see any icons contributed to OpenLayers 3.
Can a regular contributor respond to this issue and let me know if it's a good approach to include an icon as a default background image for OL3, and if this compass control would be useful?
thanks
Tamar

Alternately I could extend the rotate control to have an initial angle (which may differ from the view's rotation angle) and the user could customize the label style if wanted.  So that would be 2 modifications to the rotation control.

Ok I have written my own solution, but it does seem like it would be easy to either extend Rotate to be customizable, or to create an ol.control.Compass.  Here is my implementation:
/**
* Update the rotate control element.
* @param {ol.MapEvent} mapEvent Map event.
* @this {ol.control.Rotate}
* @api
*/
ol.control.Rotate.prototype.render = function(mapEvent) {
var frameState = mapEvent.frameState;
if (!frameState) {
return;
}
var rotation = frameState.viewState.rotation;
rotation = rotation - 1.5708;  // rotate back 90 degrees because this icon is pointing to the right
rotation = rotation - app.options.DEFAULT_ROTATION;
if (rotation != this.rotation_) {
var transform = 'rotate(' + rotation + 'rad)';
if (this.autoHide_) {
goog.dom.classlist.enable(
this.element, ol.css.CLASS_HIDDEN, rotation === 0);
}
this.label_.style.msTransform = transform;
this.label_.style.webkitTransform = transform;
this.label_.style.transform = transform;
}
this.rotation_ = rotation;
};
        	/**
        	 * @private
        	 */
        	ol.control.Rotate.prototype.resetNorth_ = function() {
        	  var map = this.getMap();
        	  var view = map.getView();
        	  if (!view) {
        	    // the map does not have a view, so we can't act
        	    // upon it
        	    return;
        	  }
        	  var currentRotation = view.getRotation();
        	  if (currentRotation !== undefined) {
        	    if (this.duration_ > 0) {
        	      currentRotation = currentRotation % (2 * Math.PI);
        	      if (currentRotation < -Math.PI) {
        	        currentRotation += 2 * Math.PI;
        	      }
        	      if (currentRotation > Math.PI) {
        	        currentRotation -= 2 * Math.PI;
        	      }
        	      map.beforeRender(ol.animation.rotate({
        	        rotation: currentRotation,
        	        duration: this.duration_,
        	        easing: ol.easing.easeOut
        	      }));
        	    }
        	    view.setRotation(app.options.DEFAULT_ROTATION);
        	  }
        	};

        	return new ol.control.Rotate({autoHide:false,
        		                           render: ol.control.Rotate.prototype.render,
        		                           label: '\u27A4'});

and this code does not work when I'm running with ol.js instead of ol-debug.js, because I can't override the resetNorth method.  So now my suggestion is to extend the Rotate control to expose resetNorth.  I will submit that code as a pull request, that seems low risk.


feat: temp dir

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@ca3e47d). Click here to learn what that means.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage        ?   68.19%
=======================================
  Files           ?       26
  Lines           ?     1003
  Branches        ?        0
=======================================
  Hits            ?      684
  Misses          ?      319
  Partials        ?        0

Impacted Files
Coverage Δ

chamber-cli/src/bin/chamber.rs
2.43% <0.00%> (ø)

chamber-core/src/temp_dir.rs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca3e47d...c1989e5. Read the comment docs.


Proper computation of GLM divergence cleaning speed

The current implementation of calc_max_dt for the ideal GLM-MHD equations updates the value of the cleaning speed c_h to be the fastest wave speed in the final element.
Instead the cleaning wave speed c_h should be reverse engineered from the maximum time step and/or wave speed c_f (the fast magnetoacoustic wave speed). Thus, the value of c_h should be initialize and then subsequently updated after each stable time step calculation.

[ ] Implement into Trixi as a method
[ ] Implement into Trixi as a library using callback structure
[ ] Update all MHD test values

[ ] elixir_mhd_alfven_wave.jl
[ ] elixir_mhd_alfven_wave_mortar.jl
[ ] elixir_mhd_blast_wave_shockcapturing_amr.jl
[ ] elixir_mhd_ec.jl
[ ] elixir_mhd_orszag_tang_shockcapturing_amr.jl
[ ] elixir_mhd_rotor_shockcapturing_amr.jl
[ ] parameters_mhd_alfven_wave.toml
[ ] parameters_mhd_alfven_wave_mortar.toml
[ ] parameters_mhd_blast_wave.toml
[ ] parameters_mhd_ec.toml
[ ] parameters_mhd_orszag_tang.toml
[ ] parameters_mhd_rotor.toml

Right now, in Taal it's not even reset to the value of the last element but in each time step calculation, the maximum is taken from the current and the new value. Thus, c_h is strictly non-decreasing in Taal :point_up:

Right now, in Taal it's not even reset to the value of the last element but in each time step calculation, the maximum is taken from the current and the new value. Thus, c_h is strictly non-decreasing in Taal ☝

Okay good to know

Taal has basic 3D capabilities, so you also have to look at these parts.

I left some comments including the link https://github.com/trixi-framework/Trixi.jl/issues/257 where stuff needs to be changed in that hack #324.

Thanks! Also, if anyone attempts to implement MHD for 1D before this issue is resolved, remember to implement the c_h hack also for 1D ;-)

I removed the "bug" label since we now have a (dirty) workaround in master. However, we should revisit this issue and provide a proper fix for it.


Add a closing double quote to rbenv-init for non fish shell on MacOS …

#1176
Add a closing double quote at the end of the rbenv-init file.

What's the bug this is for? and which shell?
This PR generates invalid shell. For bash:
$ ./bin/rbenv init - bash
export PATH="/usr/local/var/rbenv/shims:${PATH}"
export RBENV_SHELL=bash
source '/Users/code/rbenv/rbenv/libexec/../completions/rbenv.bash'
command rbenv rehash 2>/dev/null
rbenv() {
  local command
  command="${1:-}"
  if [ "$#" -gt 0 ]; then
    shift
  fi

  case "$command" in
  rehash|shell|update)
    eval "$(rbenv "sh-$command" "$@")";;
  *)
    command rbenv "$command" "$@";;
  esac
}"

I don't see the unmatched opening quote which this PR attempts to fix.
The output on master looks as intended:
$ ./bin/rbenv init - bash
export PATH="/usr/local/var/rbenv/shims:${PATH}"
export RBENV_SHELL=bash
source '/Users/code/rbenv/rbenv/libexec/../completions/rbenv.bash'
command rbenv rehash 2>/dev/null
rbenv() {
  local command
  command="${1:-}"
  if [ "$#" -gt 0 ]; then
    shift
  fi

  case "$command" in
  rehash|shell|update)
    eval "$(rbenv "sh-$command" "$@")";;
  *)
    command rbenv "$command" "$@";;
  esac
}

Most rbenv users, including myself, use a non-fish shell. If the output of rbenv-init for these shells were broken, we would have noticed by now.  I'm not sure what exactly this fixes, but like @jasonkarns points out, looks like it just breaks things by adding an unmatched quote.

Well, that's the problem on my side, and like #1176 issue report it.
If I do not add a " at the end. It just don't work.
I don't know why.

@Maartz Can you drop the output of rbenv init - in here? (and perhaps also run rbenv-doctor) My only thought is perhaps your install of rbenv got mangled and needs a fresh install? (Possible, if you were editing the rbenv-init file. I'd ensure a fresh checkout of master if installed from git; or update from homebrew)


RecordReader config is not correctly wired in SegmentGenerationAndTaskExecutor

SegmentGenerationAndTaskExecutor doesn't correctly wire recordReader.prop.<keys>. Due to this, record reader config (e.g. delimiter for csv file) cannot be configured in SegmentGenerationAndTaskExecutor.
SegmentGenerationAndPushTaskExecutor: L286
      RecordReaderSpec recordReaderSpec = new RecordReaderSpec();
      recordReaderSpec.setDataFormat(taskConfigs.get(BatchConfigProperties.INPUT_FORMAT));
      recordReaderSpec.setClassName(taskConfigs.get(BatchConfigProperties.RECORD_READER_CLASS));
      recordReaderSpec.setConfigClassName(taskConfigs.get(BatchConfigProperties.RECORD_READER_CONFIG_CLASS));
      ...

      --> We need to add the following line:
      recordReaderSpec.setConfigs(IngestionConfigUtils.getRecordReaderProps(taskConfigs));

We should also add the test to check if the record reader config gets propagated to the segment generation logic properly.

Please assign the ticket to me. I will work on it. Thanks

@abhioncbr  FYI, Johan from OSS reported this and he showed the interest to pick this ticket. I mentioned you in the discussion thread from Apache Pinot Slack Channel.

Here it is


⚠ LabBricks has degraded performance

In c816353, LabBricks (https://labbricks.com) experienced degraded performance:

HTTP code: 523
Response time: 14513 ms

Resolved: LabBricks performance has improved in fcda2a4 after 2 hours, 14 minutes.


Fix price field for version 3.0.0 of ha_epex_spot

With upcoming version 3.0.0. of ha_epex_spot the price values will change to price_per_kwh instead of ct_per_kwh. This PR reflects this change.

@mampfes Can you maybe also add me as a maintainer s.t. I can merge these Pull Requests?

@mampfes Can you maybe also add me as a maintainer s.t. I can merge these Pull Requests?

Done


MPD server with bluez-alsa headless

Hi!
I currently have an Arch-powered RPi B as my MPD server, and I was using pulseaudio to get audio to Bluetooth speakers. I didn't like that setup very much, but managed to make it work somehow.
Today I saw this implementation and decided to give it a try.. and it worked! It also managed to drop the high cpu usage I had with the pulseaudio setup.
But there is one problem. If I power off the speaker, and then I power it on while MPD is playing music, then there will be no music output until MPD changes to the next song.
These are the logs when I power off the speaker:
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:609: Endpoint method call: org.bluez.MediaEndpoint1.ClearConfiguration()
bluealsa[11464]: /usr/bin/bluealsa: transport.c:349: Freeing transport: A2DP Source (SBC)
bluealsa[11464]: /usr/bin/bluealsa: transport.c:839: Releasing transport: A2DP Source (SBC)
bluealsa[11464]: /usr/bin/bluealsa: Couldn't release transport: GDBus.Error:org.freedesktop.DBus.Error.UnknownObject: Method "Release" with signature "" on interface "org.bluez.MediaTransport1" doesn't exist
bluealsa[11464]: /usr/bin/bluealsa: transport.c:994: Exiting IO thread
bluealsa[11464]: /usr/bin/bluealsa: transport.c:839: Releasing transport: A2DP Source (SBC)
bluealsa[11464]: /usr/bin/bluealsa: Couldn't release transport: GDBus.Error:org.freedesktop.DBus.Error.UnknownObject: Method "Release" with signature "" on interface "org.bluez.MediaTransport1" doesn't exist
bluealsa[11464]: /usr/bin/bluealsa: transport.c:965: Cleaning PCM FIFO: /var/run/bluealsa/hci0-00:0C:8A:70:E8:7D-1-0
bluealsa[11464]: /usr/bin/bluealsa: transport.c:972: Closing PCM: 12
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:399: PCM close for 00:0C:8A:70:E8:7D type 1 stream 0
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:572: +-+-
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:522: Client closed connection: 10
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:572: +-+-

When I power it on, the following appears:
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:609: Endpoint method call: org.bluez.MediaEndpoint1.SetConfiguration()
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:572: +-+-
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:541: A2DP Source (SBC) configured for device 00:0C:8A:70:E8:7D
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:543: Configuration: channels: 2, sampling: 44100
bluealsa[11464]: /usr/bin/bluealsa: transport.c:669: State transition: 0 -> 0
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:663: Endpoint already registered: /A2DP/MPEG24/Source/1
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:663: Endpoint already registered: /A2DP/MPEG24/Sink/1
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:663: Endpoint already registered: /A2DP/SBC/Source/2
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:663: Endpoint already registered: /A2DP/SBC/Sink/1
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:1028: Signal: PropertiesChanged: org.bluez.MediaTransport1
bluealsa[11464]: /usr/bin/bluealsa: transport.c:669: State transition: 0 -> 1
bluealsa[11464]: /usr/bin/bluealsa: transport.c:813: New transport: 13 (MTU: R:672 W:895)
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:1028: Signal: PropertiesChanged: org.bluez.MediaTransport1
bluealsa[11464]: /usr/bin/bluealsa: transport.c:669: State transition: 1 -> 2
bluealsa[11464]: /usr/bin/bluealsa: transport.c:105: Created new IO thread: A2DP Source (SBC)
bluealsa[11464]: /usr/bin/bluealsa: io.c:55: Opening FIFO for reading: (null)
bluealsa[11464]: /usr/bin/bluealsa: Couldn't open FIFO: Bad address
bluealsa[11464]: /usr/bin/bluealsa: transport.c:839: Releasing transport: A2DP Source (SBC)
bluealsa[11464]: /usr/bin/bluealsa: transport.c:867: Closing BT: 13
bluealsa[11464]: /usr/bin/bluealsa: transport.c:994: Exiting IO thread
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:1028: Signal: PropertiesChanged: org.bluez.MediaTransport1
bluealsa[11464]: /usr/bin/bluealsa: transport.c:669: State transition: 2 -> 0

And when the next song plays, the following is logged:
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:551: New client accepted: 10
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:572: +-+-
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:572: +-+-
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:324: PCM requested for 00:0C:8A:70:E8:7D type 1 stream 0
bluealsa[11464]: /usr/bin/bluealsa: transport.c:813: New transport: 14 (MTU: R:672 W:895)
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:572: +-+-
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:1028: Signal: PropertiesChanged: org.bluez.MediaTransport1
bluealsa[11464]: /usr/bin/bluealsa: transport.c:669: State transition: 0 -> 2
bluealsa[11464]: /usr/bin/bluealsa: transport.c:105: Created new IO thread: A2DP Source (SBC)
bluealsa[11464]: /usr/bin/bluealsa: io.c:55: Opening FIFO for reading: /var/run/bluealsa/hci0-00:0C:8A:70:E8:7D-1-0
bluealsa[11464]: /usr/bin/bluealsa: io.c:409: Starting IO loop: A2DP Source (SBC)
bluealsa[11464]: /usr/bin/bluealsa: transport.c:669: State transition: 2 -> 2
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:572: +-+-

Thanks you for any help.

Hi,
I'm not sure, if it will be possible what you are trying to achieve. ALSA is not PulseAudio. It is a simple interface to the underlying hardware. A lot of fancy things which are possible with PulseAudio is not possible with ALSA, or at least requires some tinkering (e.g. writing an ALSA plug-in). And this case (playing audio when a sound card is re-plugged) is one of those.
You might try something as follows (if you have or can borrow some USB sound card):

connect external USB sound card
configure MPD to use this external sound device
eject USB sound card
plug it back and see what happens

If MPD plays sound via the external sound card immediately, then it might be possible to achieve the same thing with bluez-alsa. However, if the sound is not played immediately, then you're out of luck (due to ALSA design and the MPD ALSA output implementation).
== SOME EXTRA ISSUE, BEYOND YOUR CASE ==
However, the case you've provided is kinda strange :| When you've powered on the BT speaker, in logs I can see transport.c:669: State transition: 0 -> 1 which should not appear if one is using BT speaker. This line is OK if one connects e.g. smartphone and starts to play music. Anyway, I'm not a MPD user, so it is rather hard for me to reproduce your case.
Which version of MPD, bluez and alsa-lib you are using? Also, is this case reproducible (e.g. every time you power cycle BT speaker, this case happens)? Could you provide logs from MPD (if it's possible)?
I've tried to reproduce it with my setup, and the behaviour was correct. When the headset (I do not have BT speaker) was powered off, player (mpv/mplayer and cmus) has stopped playback. So, when the headset was reconnected, I had to start playback manually.
What really concerns me is the line transport.c:669: State transition: 0 -> 1 in the logs. Could you also post here (or somewhere else, because there might be a lot of data) logs obtained with dbus-monitor --system (as root user). Be aware not to expose some private data (if there are any), I'm only interested in bluz <-> bluealsa communication.

Thanks for your answer! I know ALSA is not PulseAudio, and I wanted to try to see if this case could work.
I forgot to mention that I also have MPD streaming to http, this is what makes MPD not stop its playback when I disconnect the BT speaker. I disabled the http stream and I had the same behavior you mentioned (MPD stops playback when BT speaker is disconnected, need to start playback manually again).
The logs are always reproducible when I do the power cycle (with http output enabled).
MPD did not log anything extra.
D-Bus communication log: dbuscomm.txt
These are the versions I'm currently using:
MPD: 0.20.13-1
bluez-alsa: v1.2.0.r47.g564a092-1 (from aur)
alsa-lib: 1.1.5-1
These are the power cycle logs without http:
Power off:
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:609: Endpoint method call: org.bluez.MediaEndpoint1.ClearConfiguration()
bluealsa[11464]: /usr/bin/bluealsa: transport.c:349: Freeing transport: A2DP Source (SBC)
bluealsa[11464]: /usr/bin/bluealsa: transport.c:839: Releasing transport: A2DP Source (SBC)
bluealsa[11464]: /usr/bin/bluealsa: Couldn't release transport: GDBus.Error:org.freedesktop.DBus.Error.UnknownObject: Method "Release" with signature "" on interface "org.bluez.MediaTransport1" doesn't exist
bluealsa[11464]: /usr/bin/bluealsa: transport.c:994: Exiting IO thread
bluealsa[11464]: /usr/bin/bluealsa: transport.c:839: Releasing transport: A2DP Source (SBC)
bluealsa[11464]: /usr/bin/bluealsa: Couldn't release transport: GDBus.Error:org.freedesktop.DBus.Error.UnknownObject: Method "Release" with signature "" on interface "org.bluez.MediaTransport1" doesn't exist
bluealsa[11464]: /usr/bin/bluealsa: transport.c:965: Cleaning PCM FIFO: /var/run/bluealsa/hci0-00:0C:8A:70:E8:7D-1-0
bluealsa[11464]: /usr/bin/bluealsa: transport.c:972: Closing PCM: 12
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:399: PCM close for 00:0C:8A:70:E8:7D type 1 stream 0
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:572: +-+-
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:522: Client closed connection: 10
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:572: +-+-

Power on:
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:609: Endpoint method call: org.bluez.MediaEndpoint1.SetConfiguration()
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:541: A2DP Source (SBC) configured for device 00:0C:8A:70:E8:7D
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:572: +-+-
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:543: Configuration: channels: 2, sampling: 44100
bluealsa[11464]: /usr/bin/bluealsa: transport.c:669: State transition: 0 -> 0
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:663: Endpoint already registered: /A2DP/MPEG24/Source/1
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:663: Endpoint already registered: /A2DP/MPEG24/Sink/1
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:663: Endpoint already registered: /A2DP/SBC/Source/2
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:663: Endpoint already registered: /A2DP/SBC/Sink/1
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:1028: Signal: PropertiesChanged: org.bluez.MediaTransport1
bluealsa[11464]: /usr/bin/bluealsa: transport.c:669: State transition: 0 -> 1
bluealsa[11464]: /usr/bin/bluealsa: transport.c:813: New transport: 13 (MTU: R:672 W:895)
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:1028: Signal: PropertiesChanged: org.bluez.MediaTransport1
bluealsa[11464]: /usr/bin/bluealsa: transport.c:669: State transition: 1 -> 2
bluealsa[11464]: /usr/bin/bluealsa: transport.c:105: Created new IO thread: A2DP Source (SBC)
bluealsa[11464]: /usr/bin/bluealsa: io.c:55: Opening FIFO for reading: (null)
bluealsa[11464]: /usr/bin/bluealsa: Couldn't open FIFO: Bad address
bluealsa[11464]: /usr/bin/bluealsa: transport.c:839: Releasing transport: A2DP Source (SBC)
bluealsa[11464]: /usr/bin/bluealsa: transport.c:867: Closing BT: 13
bluealsa[11464]: /usr/bin/bluealsa: transport.c:994: Exiting IO thread
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:1028: Signal: PropertiesChanged: org.bluez.MediaTransport1
bluealsa[11464]: /usr/bin/bluealsa: transport.c:669: State transition: 2 -> 0

Play (in MPD, because it got paused)
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:551: New client accepted: 10
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:572: +-+-
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:572: +-+-
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:324: PCM requested for 00:0C:8A:70:E8:7D type 1 stream 0
bluealsa[11464]: /usr/bin/bluealsa: transport.c:813: New transport: 14 (MTU: R:672 W:895)
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:572: +-+-
bluealsa[11464]: /usr/bin/bluealsa: bluez.c:1028: Signal: PropertiesChanged: org.bluez.MediaTransport1
bluealsa[11464]: /usr/bin/bluealsa: transport.c:669: State transition: 0 -> 2
bluealsa[11464]: /usr/bin/bluealsa: transport.c:105: Created new IO thread: A2DP Source (SBC)
bluealsa[11464]: /usr/bin/bluealsa: io.c:55: Opening FIFO for reading: /var/run/bluealsa/hci0-00:0C:8A:70:E8:7D-1-0
bluealsa[11464]: /usr/bin/bluealsa: io.c:409: Starting IO loop: A2DP Source (SBC)
bluealsa[11464]: /usr/bin/bluealsa: transport.c:669: State transition: 2 -> 2
bluealsa[11464]: /usr/bin/bluealsa: ctl.c:572: +-+-

Closing stale issue. Related issue #174.


Remove unncessary one-time workaround from the digest updater GHA

This change was never intended to be merged as it was marked with the DONT COMMIT message in the draft PR. Since it got merged and the GHA has been executed updating the base images for the new N (2024b) version, we can safely remove this workaround now.
This is a followup of #716.
Note: I presume that 2024b branch manifests in this opendatahub-io org will be updated by merging changes from main to 2024b, correct? :thinking: @harshad16 If not, then this should stay open until this GHA is run over the 2024b branch also.

Description

How Has This Been Tested?

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

/lgtm

/override ci/prow/images

Note: I presume that 2024b branch manifests in this opendatahub-io org will be updated by merging changes from main to 2024b, correct? :thinking: @harshad16 If not, then this should stay open until this GHA is run over the 2024b branch also.

Actually, it depends what branch we will use for the manifest reference... probably main is used for the ODH, in which case, we don't care about the manifests content in 2024b branch?

Note: I presume that 2024b branch manifests in this opendatahub-io org will be updated by merging changes from main to 2024b, correct? :thinking: @harshad16 If not, then this should stay open until this GHA is run over the 2024b branch also.

Actually, it depends what branch we will use for the manifest reference... probably main is used for the ODH, in which case, we don't care about the manifests content in 2024b branch?

This was confirmed on Monday meeting.

Since this is just gha change, I'll go ahead with just one lgtm.
/approve


nuke: fix no_reboot only being present in the cli and add unit tests

This is causing errors in many jobs now due to lack of ctx.no_reboot in internal nuke callers.

@susebot run deploy


Increse cpu resources to unbblock License Service installations on sm…

…all and medium CS
[LS] License Service cannot install with small and medium CS installation
#40398

/assign @chenzhiwei

please create PR on this repo: https://github.ibm.com/IBMPrivateCloud/bedrock-size-yaml
We will sync to this repo.


Update README.md

The command to install a plugin via the cordova CLI is cordova plugin add not cordova plugin install

how embarrasing.

:rabbit: :+1:
We'll probably have some more issues/PRs coming your way... We're implementing this today hopefully!


CloudBlob...

Please could you slap a warning on this page that CloudX has been removed in newer versions of the API? It seems I've just wasted some time following this article :(
Source for removal assertion: https://github.com/Azure/azure-storage-java/issues/487
It'd be great to have some sample code for using the new version with Spring too - there's some unofficial stuff to work from on the page linked above.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5faf500d-b6e5-1059-6dc5-a87d7578bb73
Version Independent ID: 6e522a89-82b0-6a6e-4c59-e68db879a5cf
Content: How to use the Spring Boot Starter with the Azure Storage API
Content Source: java/spring-framework/configure-spring-boot-starter-java-app-with-azure-storage-api.md
Service: storage
GitHub Login: @bmitchell287
Microsoft Alias: brendm

@sehaswell thanks for the feedback! We'll investigate and update the topic.

The new version of spring initializr has not integrated Azure Storage module, if you want start a new Azure Storage application we suggest you look this
[link](https://docs.microsoft.com/azure/developer/java/spring-framework/configure-spring-boot-starter-java-app-with-azure-storage#create-an-azure-storage-account-and- blob-container-for-your-application) @sehaswell

@KarlErickson - can we close out this issue, since the PR has been merged?


IDE plugin

Purpose
To generate Rebugger calls automatically
Usage

User presses Alt + Enter in editor
IDE shows an option called Add Rebugger here
Selecting the option generates a Rebugger call that has all the args and states used in the composable

Votes needed to start development

10

Wow!! 30+ votes!! You guys got the deal! 👍  I'll start working on the plugin tomorrow 😄

UPDATE: Development started : https://github.com/theapache64/rebugger-plugin/

Please let me know if I'm not improving?

@Akyongpogi28 On Weekdays I'll be mostly busy with office stuff. Major development will be happening on weekends or during free time.

UPDATE: First prototype
https://user-images.githubusercontent.com/9678279/230740996-a47b93c2-e772-48fd-96ef-dde175822c7c.mov

Here's the first version (0.0.1) of Rebugger Plugin.
https://user-images.githubusercontent.com/9678279/235495415-800925e8-ff09-45e4-b29f-b5365de8126e.mov
The next version will be published via JetBrains marketplace (https://github.com/theapache64/rebugger-plugin/issues/3)
NOTE: The above version has only basic analysis implemented. Future versions will cover more use cases :)
Thanks for all the support folks 🙇


Uncaught TypeError: Cannot read property 'style' of undefined

[Enter steps to reproduce below:]

...
...

Atom Version: 0.175.0
System: Mac OS X 10.10.2
Thrown From: git-diff package, v0.28.0
Stack Trace
Uncaught TypeError: Cannot read property 'style' of undefined
At /Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/lib/space-pen.js:516

TypeError: Cannot read property 'style' of undefined
  at [object Object].$.fn.isHidden (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/lib/space-pen.js:516:20)
  at [object Object].$.fn.isVisible (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/lib/space-pen.js:511:18)
  at GitDiffView.module.exports.GitDiffView.renderDiffs (/Users/dl1/.atom/packages/git-diff/lib/git-diff-view.coffee:109:27)
  at atom-text-editor.<anonymous> (/Users/dl1/.atom/packages/git-diff/lib/git-diff-view.coffee:1:1)
  at atom-text-editor.handler (/Applications/Atom.app/Contents/Resources/app/src/space-pen-extensions.js:112:34)
  at atom-text-editor.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4681:9)
  at atom-text-editor.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4359:46)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:243:29)
  at CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:3:61)
  at CommandRegistry.module.exports.CommandRegistry.dispatch (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:156:19)
  at TextEditorView.jQuery.fn.trigger (/Applications/Atom.app/Contents/Resources/app/src/space-pen-extensions.js:64:23)
  at [object Object].module.exports.React.createClass.componentDidUpdate (/Applications/Atom.app/Contents/Resources/app/src/text-editor-component.js:273:54)
  at CallbackQueue.mixInto.notifyAll (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/CallbackQueue.js:75:22)
  at ReactReconcileTransaction.ON_DOM_READY_QUEUEING.close (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactReconcileTransaction.js:88:26)
  at ReactReconcileTransaction.Mixin.closeAll (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:214:42)
  at ReactReconcileTransaction.Mixin.perform (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:155:16)
  at ReactUpdatesFlushTransaction.Mixin.perform (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:141:20)
  at ReactUpdatesFlushTransaction.mixInto.perform (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:98:38)
  at Object.flushBatchedUpdates (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:176:19)
  at ReactDefaultBatchingStrategyTransaction.Mixin.closeAll (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:214:42)
  at ReactDefaultBatchingStrategyTransaction.Mixin.perform (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:155:16)
  at Object.ReactDefaultBatchingStrategy.batchedUpdates (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactDefaultBatchingStrategy.js:70:19)
  at Object.enqueueUpdate (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:209:22)
  at [object Object].ReactCompositeComponentMixin.replaceState (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeComponent.js:878:20)
  at [object Object].ReactCompositeComponentMixin.setState (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeComponent.js:850:10)
  at [object Object].module.exports.React.createClass.focused (/Applications/Atom.app/Contents/Resources/app/src/text-editor-component.js:619:14)
  at [object Object].boundMethod [as focused] (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeComponent.js:1295:21)
  at atom-text-editor.TextEditorElement.focused (/Applications/Atom.app/Contents/Resources/app/src/text-editor-element.js:199:55)

Commands
     -7:53.2 core:save-as (atom-text-editor.editor)
     -6:30.7 grammar-selector:show (atom-text-editor.editor)
     -6:28.4 editor:consolidate-selections (atom-text-editor.editor.mini)
     -6:28.4 core:cancel (atom-text-editor.editor.mini)
 34x -6:26.1 core:backspace (atom-text-editor.editor)
  2x -5:55.3 editor:newline (atom-text-editor.editor)
  3x -5:45.9 core:backspace (atom-text-editor.editor)
  2x -5:20.9 core:move-left (atom-text-editor.editor)
     -5:19.2 core:move-right (atom-text-editor.editor)
 33x -5:17.2 core:backspace (atom-text-editor.editor)
     -4:39.2 core:select-all (atom-text-editor.editor)
     -4:38.0 core:copy (atom-text-editor.editor)
     -0:00.0 window:install-shell-commands (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-atom-dark-syntax.theme-atom-light-ui)

Config
{
  "core": {
    "themes": [
      "atom-light-ui",
      "atom-dark-syntax"
    ]
  }
}

Installed Packages
# User
git-diff, v0.28.0

# Dev
No dev packages

/cc @atom/core

From the debugging output above ("Installed Packages" section) it seems that you have a super-old version of git-diff installed locally (v0.28.0). The current version of that package is v0.50.0.
If you remove the local package, this should resolve itself.

Thank you a lot!
Yes, very old piece of software, already uninstall, all ok now
--
Денис Лепескин/Denis Lepeskin
Операционный директор/Chief Operating Officer
АПР Групп Азия/APR Group Asia
BAIYUN DISTRICT, GUANGZHOU CITY , CHINA.
广州白云区石井潭村宝鸭北路100号石井创意园L02栋
Mobile: +86<PHONE_NUMBER>4
Office: +86<PHONE_NUMBER>
QQ:<PHONE_NUMBER>
skype: lepeskin
http://www.aprconsulting.ru
http://www.aprgroup.ru

Ivan Žužak<EMAIL_ADDRESS>9 февраля 2015 г., 21:58
From the debugging output above ("Installed Packages" section) it
seems that you have a super-old version of git-diff installed locally
(v0.28.0). The current version of that package is v0.50.0.
If you remove the local package, this should resolve itself.
—
Reply to this email directly or view it on GitHub
https://github.com/atom/git-diff/issues/48#issuecomment-73512110.


[RFC] Alternative Reveal button hint for missing votes

This is an alternative approach to #57.
Instead of the two-step process, the button will be displayed with a hint for the number of votes.

I have updated the PR as discussed with a blue button, better centering and always counting all votes


Update Node engine to a supported GCF version

There are three cases where the node version was still on 8, which isn't allowed to be deployed anymore. Updated to be 12, the version used elsewhere in the project.

@inlined thanks for this!

@inlined thanks for this!


Fix jsdoc variadic type nodes not being remapped to equivalent TS in output

Fixes #38242
Extracted from #38234~

@typescript-bot cherry-pick this to release-3.9


fix(CONTRIBUTING): added note about who merges a PR

A piece of folk knowledge got lost somewhere along the way: Core contributors should merge their own PRs. I added this to CONTRIBUTING where it seems to make the most sense.

@technosophos Were you going to merge this? (oh the irony 😆)


Document using Envoy's annotations for Contour external-dns integration

Contour component supports ingress_hosts parameter, which can be used for integrating Contour with external-dns until #13 is resolved.
We should document this workaround.

The workaround is no longer needed, so we should remove it instead of documenting, as mentioned in #13 and #589.


task: add mesos agent ID to dcos task table

This makes it easy to see a task, and ssh into the agent using either the private ip or the mesos id.

thanks @jimenez! updated


#491 - Remove "of" word.

Changes:

remove of from lexer
remove of from messages file
remove of from tests
remove of from printer
remove of from parser generator

Most important part is the change within reason_parser.mly.
Thanks @yunxing for the tips.

Thanks so much!


DeprecationWarning: Call to init()

DeprecationWarning: Call to init() is deprecated since version 0.21.0 and will be removed in version 1.0. UserControl is deprecated. See https://flet.dev/docs/getting-started/custom-controls.
super().init()

meanwhile i cant see anything in the https://flet.dev/docs/getting-started/custom-controls and my app is not running too

it mean you can`t import class from anther file
write the class in same file , and it will be sloved

Please fill up all details as required by the issue template.
As the message says, UserControl is deprecated and will be removed in the future.

error is coming fro this class Main(UserControl):
def init(self, page:Page,):
super().init().. code was working until i upgraded flet... old flet version doent have some properties i required....and this error shows up when i try running my app

this is what i have......
from pages.forgotpassword import ForgotPassword
from pages.login import Login
from pages.signup import SignUp
from pages.home import Home
from flet import *
class Main(UserControl):
def init(self, page:Page):
super().init()
self.page = page
self.page.title="Portal"
self.page.horizontal_alignment=MainAxisAlignment.CENTER
self.page.vertical_alignment=CrossAxisAlignment.CENTER
#self.page.alignment=MainAxisAlignment.CENTER
self.page.window_width=1800
self.page.window_height=1000
self.page.window_center=True
self.page.padding=30
    self.init_helper()
def init_helper(self,):
    self.page.on_route_change = self.on_route_change
    self.page.go('/')

def on_route_change(self, route):
    newpage ={
        "/":Home,
        "/login":Login,
        "/signup":SignUp,
        "/forgotpassword":ForgotPassword

    }[self.page.route](self.page)
    self.page.views.clear()
    self.page.views.append(
        View(
            route,
            [newpage]

        )

    )

app(target=Main,assets_dir='assets')

Please build some reproducible code so we can test.


Update array signatures with copy

Align all __array__-methods according to the new signature.
mypy can raise very hard to read errors if these are not correct, see #9237 for an example.
References:

https://numpy.org/doc/stable/user/basics.interoperability.html#dunder-array-interface
https://github.com/numpy/numpy/blob/d031cac46a17dca63cd2dc3bb147d0d3fceaefe0/numpy/__init__.pyi#L1861-L1868

can you also remove the warning ignore in pyproject.toml, please?


Fix: Removed dependency ad-network config line-ending on user os

Hello!
There are MacOS & Window users in our dev team, and we have some headache with Dependencies.xml config for AdNetwork and VCS.
Because System.Xml.Linq.XDocument respect os-system line-endings, I fix this problem via using System.Xml.XmlWriter
If you need this fix - use it

Looking over the code, have you not had the same problem with the configuration in Assets/DeltaDNA/Resources/ddna_configuration.xml? We're writing that here.
I'm trying to understand whether the issue is resolved by using XmlWriterSettings, or whether it's the NewLineChars property.

Please re-open if this isn't solved for you.

Please re-open if this isn't solved for you.


Bug: TM wont apply correctly.

Using TM in overworld after you moved your moves in the list cause it to be applied in the wrong slot temporally until you enter and quit any dungeon, this is kinda buggy. i have recorded a video to explain that better, notice the Helping hand.
TMbehaviour.zip

Fix in https://github.com/RogueCollab/RogueEssence/commit/2a9a3ea832c5c634e37b89702c57f72a3e8e0bdc


Project review (Viyad)

Good work on https://github.com/airavata-courses/DCoders/wiki/Git-branching-and-release-strategy
I did not see in any other project.
Well explained https://github.com/airavata-courses/DCoders/wiki/local-runbook
Later improvement: User authorization can be added in next milestone.

I tried running UserManagement service, running fine.

Thanks a lot for the feedback.


Fix Internal server Error #3

Summary
fix #3

INFO:     <IP_ADDRESS>:52592 - "GET /kachaka/get_map_list HTTP/1.1" 500 Internal Server Error
ERROR:    Exception in ASGI application
Traceback (most recent call last):
  File "/home/kachaka/.local/lib/python3.10/site-packages/uvicorn/protocols/http/h11_impl.py", line 408, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
  File "/home/kachaka/.local/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in __call__
    return await self.app(scope, receive, send)
  File "/home/kachaka/.local/lib/python3.10/site-packages/fastapi/applications.py", line 292, in __call__
    await super().__call__(scope, receive, send)
  File "/home/kachaka/.local/lib/python3.10/site-packages/starlette/applications.py", line 122, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/home/kachaka/.local/lib/python3.10/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/home/kachaka/.local/lib/python3.10/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/home/kachaka/.local/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/home/kachaka/.local/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/home/kachaka/.local/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 20, in __call__
    raise e
  File "/home/kachaka/.local/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 17, in __call__
    await self.app(scope, receive, send)
  File "/home/kachaka/.local/lib/python3.10/site-packages/starlette/routing.py", line 718, in __call__
    await route.handle(scope, receive, send)
  File "/home/kachaka/.local/lib/python3.10/site-packages/starlette/routing.py", line 276, in handle
    await self.app(scope, receive, send)
  File "/home/kachaka/.local/lib/python3.10/site-packages/starlette/routing.py", line 66, in app
    response = await func(request)
  File "/home/kachaka/.local/lib/python3.10/site-packages/fastapi/routing.py", line 291, in app
    content = await serialize_response(
  File "/home/kachaka/.local/lib/python3.10/site-packages/fastapi/routing.py", line 154, in serialize_response
    raise ResponseValidationError(
fastapi.exceptions.ResponseValidationError: 1 validation errors:
  {'type': 'dict_type', 'loc': ('response',), 'msg': 'Input should be a valid dictionary', 'input': [{'name': 'マップ1', 'id': '81fe70c9-62f1-4ae9-bb85-6db5b529c757'}, {'name': '27F', 'id': 'ed9b33d4-854a-410c-b5e8-e9c4b2b6daa7'}], 'url': 'https://errors.pydantic.dev/2.6/v/dict_type'}

各種APIを叩くとエラーが出てしまうのですがこちらもなにか本件に関係ありますかね？

INFO:     <IP_ADDRESS>:52598 - "GET /kachaka/get_robot_pose HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:47802 - "GET /kachaka/get_robot_pose HTTP/1.1" 200 OK

get_robot_poseは治りました。


UX UI Design improvement

I think this issue is related to the following issues :) :

https://github.com/jhipster/jhipster-lite/issues/9490
https://github.com/jhipster/jhipster-lite/issues/10934
https://github.com/jhipster/jhipster-lite/issues/11102

Asceline will put some feedbacks and new ideas from users soon


Volume Buttons Unresponsive During Calls on Pixel Phone

Describe the bug
Google pixel 6a
Samsung Flip 4
Samsung Note10+
In this device, the volume button doesn't directly adjust the call sound. Instead, it controls a progress bar that visually increases or decreases, but it doesn't affect the call volume. The call volume is adjusted independently through the media volume controls.
export const VideoPlayer = React.forwardRef((props: React.DetailedHTMLProps<React.VideoHTMLAttributes<HTMLVideoElement>, HTMLVideoElement>, ref: any) => (
  <video ref = {ref} {...props}  />
))

Screenshot

SDK Version:
"@100mslive/hms-noise-suppression": "^0.9.19",
 "@100mslive/react-sdk": "^0.8.19",

@ygit Can you kindly look into this?

Sure @bhishakBitcanny

Phone volume can control the audio of the call. not the media volume one. it is across all devices for webrtc calls.

Phone volume can control the audio of the call. not the media volume one. it is across all devices for webrtc calls.

So @raviteja83 in the above configuration, we should be able to get audio output. Unfortunately, we are not receiving any output audio unless we change the media volume. We have tried headphones and speakers but same behaviour is observed.

Kindly let me know if there are any findings.

is autoplay error handled? can you check console if you get an error with error code 3008.

@raviteja83 I confirm that we are not getting any error as such.

@raviteja83 is this reproduced on your end?


Want to use TestOutputOrganizer class in a Java code under the <project>/src/main/java directory

If I am going to support resolving the <projectDir>/src/main/java, then I should rename the class TestOutputOrganizer to ProjectOutputOrganizer becuase the scope of the class is stretched wider

I am not going to do this.
You can do it by
TestOutputOrgianizer too =
    new TestOutputOrganizer.Builder(class)
        .addCodeSourcePathElementsUnderProjectDirectory(
            new CodeSourcePathElementsUnderProjectDirectory("build", "classes", "main", "java"));
        ...

You can do it by

But I haven't documented it yet.!


RunspaceConfiguration missing

Hi, I need to use RunspaceConfiguration, which is not part of this package.
Is this a known issue or is there an other way of adding an  SnapIn?
Thats the code:
 RunspaceConfiguration runspaceConf = RunspaceConfiguration.Create();   PSSnapInException PSException = null;   PSSnapInInfo info = runspaceConf.AddPSSnapIn("Microsoft.Exchange.Management.PowerShell.E2010", out PSException);   Runspace runspace = RunspaceFactory.CreateRunspace(runspaceConf);   runspace.Open();   Pipeline pipeline = runspace.CreatePipeline();   pipeline.Commands.Add(command);   Collection<PSObject> result = pipeline.Invoke();

This is by design. This was excluded from standard library and RunspaceConfiguration is no longer part of 7 and those methods are no longer available. Also, snapins are not supported in PSV7.


Fix a bug in rose-pine.tmux

Extraneous "-g" causes rose-pine.tmux to crash for my at the moment, meaning the window title changes are not applied. Fixed here.

Haven't noticed a crash and have been running it daily. I use some scripts to change both window and session names and didn't notice it. Will test it out, but for now I accept it