Use U-Boot for the Raspberry Pi 4-specific image

This is part of the effort to slowly move the Raspberry Pi 4 support to the mainline-based generic AArch64 image.
With this change, the image is now structurally compatible with the mainline AArch64 image. This means that when mainline Linux has been verified to work on the Raspberry Pi 4 enough for the end-user to gain a foothold into ARM-land, we can finally remove the Raspberry Pi 4-specific SD image.
The idea being that if mainline is not working well enough for specific use cases, or incompatible with the Raspberry Pi Foundation's ecosystem of hardware, drivers and software, the user now has the ability to either switch the running kernel and rebuild, or even now build AArch64 packages. The Raspberry Pi 4 might be that user's first and only way to build AArch64 things!
With this change, we should be able to somewhat reduce the difficulties in supporting, and answering questions about the Raspberry Pi 4. It should work, structurally speaking, just like the Raspberry Pi 3 images.
One last change, for the rpi-5.4.y kernel branch, we need to drop the cma= parameter from the kernel command line. The kernel command line takes precedence from the pre-configured CMA set in the FDT; which in turn allocates in an area that VC cannot read. The pre-configured CMA value works just fine. Using the configuration option (1) clears up the kernel command-line a bit, and (2) fixes that issue since it has lower precedence.
This includes changes from:

Closes #97258 by including the commit directly (Thanks! @Luflosi)
Closes #70796 by being basically the same change (oops)
Closes #97732 by integrating its (fixed) changes

This changes nothing for existing Raspberry Pi 4B users. Only images made from the moment this change lands are going to be different.
Should this get backported? Well, the main part of this PR, changing to U-Boot for the Raspberry Pi 4 image, does not apply as there is no Raspberry Pi 4 image on stable. The kernel update might be relevant, but might bring breaking changes.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc #63720

Since I'm including modified changes from @matthewbauer and keeping authorship, I'd like for him to review at least that part of the changes.

I spent most of my weekend testing these changes with @samueldr's help on IRC. Here is what I've found:

U-Boot works fine, no issues there
hardware.deviceTree doesn't work with the traditional bootloader
Kernel 5.4 works fine on the RPi4, however you must not set the cma flag, otherwise it fails to find the sd card and everything breaks.
Kernel 4.9 should not be removed from the tree, as there are a number of RPi-specific things that still rely on that older kernel. The display I use, for example, requires a dtbo which simply refuses to load using 5.4.
Kernel 5.4 should be the default, but users need a mechanism to use the old 4.9 kernel when required.

I am now testing whether hardware.deviceTree works using U-Boot + 4.9 kernel

Another noticed side-effect of this: USB ports on the Pi4 don't work at all when you boot with U-boot

Raspberry Pi 4 USB works for me after also upgrading to u-boot 2020.10.

So this just needs an update?

FWIW I rebased this PR locally on current master by dropping the raspberrypifw commit (master has a newer version) and fixing the conflict in all-packages.nix. SD image built fine & boots fine, installed system has been running fine afaict.

maybe we should close this PR in favor of @OPNA2608 releasing their changes as a new PR?

@OPNA2608 I think this needs rebasing again.

@samueldr Can you rebase this PR?

Rebased (which made the linux-rpi update obsolete), updated armstubs to 2020-10-08

nixos.sd_image_raspberrypi4.aarch64-linux does not boot on my rpi4 8g:
PM_RSTS: 0x00000020
RPi: BOOTLOADER release VERSION:45291ce6 DATE: Jul 16 2020 TIME: 16:15:51 BOOTMODE: 0x00000006 part: 0 BUILD_TIMESTAMP=1594912546 0x53eb7634 0x00d03114
uSD voltage 3.3V
Initialising SDRAM 'Micron' 32Gb x2 total-size: 64 Gbit 3200
Boot mode: SD (01) order f4
SD HOST: 250000000 CTL0: 0x00000000 BUS: 100000 Hz actual: 100000 HZ div: 2500 (1250) status: 0x1fff0000 delay: 1080
SD HOST: 250000000 CTL0: 0x00000f00 BUS: 100000 Hz actual: 100000 HZ div: 2500 (1250) status: 0x1fff0000 delay: 1080
CID: 0002544d53413332472425f51c0100fc
CSD: 400e00325b590000e74f7f800a400000
SD: bus-width: 4 spec: 2 SCR: 0x02358003 0x01000000
SD HOST: 250000000 CTL0: 0x00000f04 BUS: 50000000 Hz actual: 41666666 HZ div: 6 (3) status: 0x1fff0000 delay: 2
MBR: 0x00004000,   61440 type: 0x0b
MBR: 0x00013000, 5351024 type: 0x83
MBR: 0x00000000,       0 type: 0x00
MBR: 0x00000000,       0 type: 0x00
lba: 16384 oem: 'mkfs.fat' volume: '  V       ^ '
rsc 4 fat-sectors 60 c-count 15321 c-size 4 r-dir 1 r-sec 32
PM_RSTS: 0x00000020
Partition: 0
lba: 16384 oem: 'mkfs.fat' volume: '  V       ^ '
rsc 4 fat-sectors 60 c-count 15321 c-size 4 r-dir 1 r-sec 32
Read config.txt bytes      650 hnd 0x00000035 hash '56f54a69c71c5a3c'
recover4.elf not found (6)
recovery.elf not found (6)
Read start4.elf bytes  2213312 hnd 0x000005f2 hash '19bbfbc3ec1da69d'
Read fixup4.dat bytes     5428 hnd 0x0000003a hash '5481e23d9a139ecb'
0x00d03114 0x00000000 0x0000003f
MEM GPU: 76 ARM: 948 TOTAL: 1024
Starting start4.elf @ 0xfec00200 partition 0

U-Boot 2020.10 (Oct 05 2020 - 15:15:32 +0000)

DRAM:  7.9 GiB
RPI 4 Model B (0xd03114)
MMC:   mmcnr@7e300000: 1, emmc2@7e340000: 0
Loading Environment from FAT... *** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
Net:   eth0: ethernet@7d580000
PCIe BRCM: link up, 5.0 Gbps x1 (SSC)
starting USB...
Bus xhci_pci: probe failed, error -110
No working controllers found
Hit any key to stop autoboot:  0
switch to partitions #0, OK
mmc0 is current device
Scanning mmc 0:2...
Found /boot/extlinux/extlinux.conf
Retrieving file: /boot/extlinux/extlinux.conf
829 bytes read in 18 ms (44.9 KiB/s)
1:      NixOS - Default
Retrieving file: /boot/extlinux/../nixos/lsj0ndrcb660zp76nfwbwrwbl3ccb533-initrd-linux-5.4.79-1.20201201-initrd
8195099 bytes read in 367 ms (21.3 MiB/s)
Retrieving file: /boot/extlinux/../nixos/vw8c6pmm21rqyi78zmrb9r00x493n6a2-linux-5.4.79-1.20201201-Image
"Synchronous Abort" handler, esr 0x96000004
elr:<PHONE_NUMBER>0a2dac lr :<PHONE_NUMBER>0a2de8 (reloc)
elr: 000000003b37bdac lr : 000000003b37bde8
x0 : ffffffffffffffe0 x1 :<PHONE_NUMBER>000000
x2 : 000000003af54e50 x3 :<PHONE_NUMBER>000015
x4 : b900001f58000540 x5 :<PHONE_NUMBER>000015
x6 : 000000003b3d3118 x7 : 000000003b3d3118
x8 :<PHONE_NUMBER>000001 x9 :<PHONE_NUMBER>000008
x10:<PHONE_NUMBER>000006 x11: 000000003af6c820
x12:<PHONE_NUMBER>02ef90 x13:<PHONE_NUMBER>000001
x14:<PHONE_NUMBER>080000 x15: 000000003af48fd0
x16: 000000003b385128 x17:<PHONE_NUMBER>000000
x18: 000000003af54d90 x19:<PHONE_NUMBER>000000
x20:<PHONE_NUMBER>001d28 x21:<PHONE_NUMBER>000006
x22:<PHONE_NUMBER>000000 x23: 000000003af46248
x24: 000000003b3bb720 x25:<PHONE_NUMBER>000eda
x26:<PHONE_NUMBER>000000 x27: 000000003b3ec348
x28:<PHONE_NUMBER>01a268 x29: 000000003af461c0

Code: eb02003f 54000061 d2800000 d65f03c0 (f9400401)
Resetting CPU ...

resetting ...

nixos.sd_image_raspberrypi4.aarch64-linux does not boot on my rpi4 8g:
PM_RSTS: 0x00000020
RPi: BOOTLOADER release VERSION:45291ce6 DATE: Jul 16 2020 TIME: 16:15:51 BOOTMODE: 0x00000006 part: 0 BUILD_TIMESTAMP=1594912546 0x53eb7634 0x00d03114
uSD voltage 3.3V
Initialising SDRAM 'Micron' 32Gb x2 total-size: 64 Gbit 3200
Boot mode: SD (01) order f4
SD HOST: 250000000 CTL0: 0x00000000 BUS: 100000 Hz actual: 100000 HZ div: 2500 (1250) status: 0x1fff0000 delay: 1080
SD HOST: 250000000 CTL0: 0x00000f00 BUS: 100000 Hz actual: 100000 HZ div: 2500 (1250) status: 0x1fff0000 delay: 1080
CID: 0002544d53413332472425f51c0100fc
CSD: 400e00325b590000e74f7f800a400000
SD: bus-width: 4 spec: 2 SCR: 0x02358003 0x01000000
SD HOST: 250000000 CTL0: 0x00000f04 BUS: 50000000 Hz actual: 41666666 HZ div: 6 (3) status: 0x1fff0000 delay: 2
MBR: 0x00004000,   61440 type: 0x0b
MBR: 0x00013000, 5351024 type: 0x83
MBR: 0x00000000,       0 type: 0x00
MBR: 0x00000000,       0 type: 0x00
lba: 16384 oem: 'mkfs.fat' volume: '  V       ^ '
rsc 4 fat-sectors 60 c-count 15321 c-size 4 r-dir 1 r-sec 32
PM_RSTS: 0x00000020
Partition: 0
lba: 16384 oem: 'mkfs.fat' volume: '  V       ^ '
rsc 4 fat-sectors 60 c-count 15321 c-size 4 r-dir 1 r-sec 32
Read config.txt bytes      650 hnd 0x00000035 hash '56f54a69c71c5a3c'
recover4.elf not found (6)
recovery.elf not found (6)
Read start4.elf bytes  2213312 hnd 0x000005f2 hash '19bbfbc3ec1da69d'
Read fixup4.dat bytes     5428 hnd 0x0000003a hash '5481e23d9a139ecb'
0x00d03114 0x00000000 0x0000003f
MEM GPU: 76 ARM: 948 TOTAL: 1024
Starting start4.elf @ 0xfec00200 partition 0

U-Boot 2020.10 (Oct 05 2020 - 15:15:32 +0000)

DRAM:  7.9 GiB
RPI 4 Model B (0xd03114)
MMC:   mmcnr@7e300000: 1, emmc2@7e340000: 0
Loading Environment from FAT... *** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
Net:   eth0: ethernet@7d580000
PCIe BRCM: link up, 5.0 Gbps x1 (SSC)
starting USB...
Bus xhci_pci: probe failed, error -110
No working controllers found
Hit any key to stop autoboot:  0
switch to partitions #0, OK
mmc0 is current device
Scanning mmc 0:2...

I haven't looked at all, but maybe the regression was fixed for the next stable version?
If it wasn't, we'd need to investigate, first confirming whether it's 8GB specific or not.

@misuzu have you tried upgrading u-boot too?
I haven't looked at all, but maybe the regression was fixed for the next stable version?
If it wasn't, we'd need to investigate, first confirming whether it's 8GB specific or not.

Disregard trying with total_mem, @makefu on IRC reported (coincidentally) the same issue on a 4GB variant.
I suspect something other than the memory amount.
Though, a new thought (I shared with @makefu on IRC) is that it could be related to the firmware installed to the eeprom. I don't know which version I have, but I did confirm that it boots on my setup. I know that an arbitrary date in the past I updated the eeprom, so I only know that it's not the one it shipped with, and not the latest.

Disregard trying with total_mem, @makefu on IRC reported (coincidentally) the same issue on a 4GB variant.
I suspect something other than the memory amount.
Though, a new thought (I shared with @makefu on IRC) is that it could be related to the firmware installed to the eeprom. I don't know which version I have, but I did confirm that it boots on my setup. I know that an arbitrary date in the past I updated the eeprom, so I only know that it's not the one it shipped with, and not the latest.

@misuzu have you tried upgrading u-boot too?

2021.01-rc5 is working, but it still hangs on "Starting kernel ..." without that kernel cmdline from https://github.com/NixOS/nixpkgs/pull/97883#issuecomment-756059726 event with total_mem=4096 in config.txt.

@misuzu have you tried upgrading u-boot too?

2021.01-rc5 is working, but it still hangs on "Starting kernel ..." without that kernel cmdline from https://github.com/NixOS/nixpkgs/pull/97883#issuecomment-756059726 event with total_mem=4096 in config.txt.

Oh, so is it the kernel command-line that fixes the issue, and not changing the u-boot version?
(I really don't know what is going on here.)

Oh, so is it the kernel command-line that fixes the issue, and not changing the u-boot version?
(I really don't know what is going on here.)

Oh, so is it the kernel command-line that fixes the issue, and not changing the u-boot version?
(I really don't know what is going on here. And I cannot reproduce and test due to some difference in setups.)

It's both. u-boot-2020.10 is broken and that kernel command-line is required to boot.

Oh, so is it the kernel command-line that fixes the issue, and not changing the u-boot version?
(I really don't know what is going on here. And I cannot reproduce and test due to some difference in setups.)

It's both. u-boot-2020.10 is broken and that kernel command-line is required to boot.

Given that 2021.01-rc5 works with the cmdline, and they're most probably releasing next week, we'll sit on that until next week, where we'll be able to update u-boot and fix part of the issue.
Do you know which command-line parameter is required? Or is it a combination of some? All? Sorry again for the harsh interrogation. I'd like to say it didn't work on mine either.

Given that 2021.01-rc5 works with the cmdline, and they're most probably releasing next week, we'll sit on that until next week, where we'll be able to update u-boot and fix part of the issue.
Do you know which command-line parameter is required? Or is it a combination of some? All? Sorry again for the harsh interrogation. I'd like to say it didn't work on mine either.

Testing a bit more, with the same build, headless, actually headless, HDMI ports both unpopulated, I can say that 8250.nr_uarts=1 makes the serial work, otherwise it "hangs" at "Starting kernel ...".
Looks like this is approx. equivalent to using uart1-overlay.
Added it to the raspberry pi 4 nixos on arm wiki page.
So I figure that the "no serial console" issue is solved via the command-line parameter, but we still have that odd U-Boot failing to boot. (Until the next stable release, soon enough.)

Testing a bit more, with the same build, headless, actually headless, HDMI ports both unpopulated, I can say that 8250.nr_uarts=1 makes the serial work, otherwise it "hangs" at "Starting kernel ...".
Looks like this is approx. equivalent to using uart1-overlay.
Added it to the raspberry pi 4 nixos on arm wiki page.
So I figure that the "no serial console" issue is solved via the command-line parameter, but we still have that odd U-Boot failing to boot. (Until the next stable release, soon enough.)

I'm so sorry I can't be more helpful here. I only have the 8GB version and I don't have an HDMI cable or equipment to use the serial port. I tested this in a headless setup so I couldn't see many of the issues you are having.

I'm so sorry I can't be more helpful here. I only have the 8GB version and I don't have an HDMI cable or equipment to use the serial port. I tested this in a headless setup so I couldn't see many of the issues you are having.

@petabyteboy It seems the issue here happens, too, in a headless situation. And don't worry, I can't reproduce it either, though I'm sure something makes the error happen.
Now it'd be nicer if we could figure out what is the issue. It seems that the revision of the board itself doesn't matter, as [I / @makefu] have a 4GB 1.1 board, it works for me, fails for him; both of you [@petabyteboy / @misuzu] have an 8GB board (1.4 obligatory) and works for one of you, fails for the other.
I have personally tested:

plugged to an HDMI capture card
headless with UART

Both situation didn't produce a "Synchronuous abort". Though I can confirm that in Linux, something needs to be done for UART to work, one solution is 8250.nr_uarts=1 on the cmdline. I would be willing to bet there are other ways.

@petabyteboy It seems the issue here happens, too, in a headless situation. And don't worry, I can't reproduce it either, though I'm sure something makes the error happen.
Now it'd be nicer if we could figure out what is the issue. It seems that the revision of the board itself doesn't matter, as [I / @makefu] have a 4GB 1.1 board, it works for me, fails for him; both of you [@petabyteboy / @misuzu] have an 8GB board (1.4 obligatory) and works for one of you, fails for the other.
I have personally tested:

plugged to an HDMI capture card
headless with UART

Both situation didn't produce a "Synchronuous abort". Though I can confirm that in Linux, something needs to be done for UART to work, one solution is 8250.nr_uarts=1 on the cmdline. I would be willing to bet there are other ways.

Though I can confirm that in Linux, something needs to be done for UART to work, one solution is 8250.nr_uarts=1 on the cmdline.

Adding only 8250.nr_uarts=1 indeed fixes my issue. The weird part is that network doesn't work without it.

Though I can confirm that in Linux, something needs to be done for UART to work, one solution is 8250.nr_uarts=1 on the cmdline.

Adding only 8250.nr_uarts=1 indeed fixes my issue. The weird part is that network doesn't work without it.

@misuzu what do you mean network doesn't work?
I'm asking, because I have the weirdest problem related to the network.
On nixos configuration.nix I've got  networking.firewall.allowPing = true; (anyway the default is true)
but the raspberry pi doesn't respond to ping, so undectectable by nmap. I can ssh into it fine, but for some reason, ping doesn't work.
Not only that, but I've tried enabling
services = {
    avahi = {
      enable = true;
      publish = {
        enable = true;
        addresses = true;
        workstation = true;
      };
};

To no avail.
My raspberry pi is connected over ethernet cable, I haven't tried connecting to wifi.

@misuzu what do you mean network doesn't work?
I'm asking, because I have the weirdest problem related to the network.
On nixos configuration.nix I've got  networking.firewall.allowPing = true; (anyway the default is true)
but the raspberry pi doesn't respond to ping, so undectectable by nmap. I can ssh into it fine, but for some reason, ping doesn't work.
Not only that, but I've tried enabling
services = {
    avahi = {
      enable = true;
      publish = {
        enable = true;
        addresses = true;
        workstation = true;
      };
};

To no avail.
My raspberry pi is connected over ethernet cable, I haven't tried connecting to wifi.

@misuzu what do you mean network doesn't work?

There are no DHCP requests over ethernet from my rpi4 when started without 8250.nr_uarts=1. I suspect the kernel just not starting.

@misuzu what do you mean network doesn't work?

There are no DHCP requests over ethernet from my rpi4 when started without 8250.nr_uarts=1. I suspect the kernel just not starting.


Re-Write of Squad

Re-Write squad generic module, add web settings. Add Skeleton for Vote Config

Tests pending if someone else can validate it?

I'm not sure why this one is in testing. It needs regex and I believe maybe something else. I think it was removed from draft too soon.

i noticed after the fact don't merge this yet.

nvm. i figured out how to re-mark as draft.

Module Largely in a good state. This Template is awaiting feature https://github.com/CubeCoders/AMP/issues/573 in order to be able to set the server password through AMP's Web Settings. but other than that. This module should be ready for testing.


Revise OpenMP statements?

E.g., perhaps we could add COLLAPSE(3) statements for the loops, or simply wait until DO CONCURRENT is ready for prime time (and then minimize OpenACC & OpenMP directives)?

This may be done in a branch that is synced with the main one and may be switched as tools support these features better.

For future reference, example on how to combine OpenACC w/ DO CONCURRENT below. Note that STDPAR doesn't support async, so essentially we should add redundant locality specifiers for both OpenMP, DO CONCURRENT, and OpenACC.
! cat test_stdpar async
program main
  implicit none
  integer, parameter :: n = 100
  integer :: nn(3)
  real(8), arr(n,n,n), tot
  integer :: i,j,k
  nn(:) = n
  !$acc enter data create(arr) copyin(nn) async(1)
  !$acc kernels default(present) async(1)
  arr(:,:,:) = 1.d0
  !$acc end kernels
  tot = 0.d0
  !$acc parallel loop collapse(3) default(present) reduction(+:tot) async(1)
  do concurrent(k=1:nn(3),j=1:nn(2),i=1:nn(1)) shared(arr) reduce(+:tot)
    arr(i,j,k) = i*j*k
    tot = tot + 1
  end do
  !$acc exit data copyout(arr) async(1)
  !$acc wait(1)
  print*,arr(10,10,10)
end program main

to be compiled with nvfortran -acc -Minfo=accel test.f90.

OMP statements have been simplified and are looking good (close to OpenACC) for now, so I'm closing this for now and may revisit for future reference.


Return Moment Object

Code refactoring
Using ngModel to get Moment.js object of the selected date
Added support for $viewValue for input fields
Min/Max date now support Strings or Moment.js objects

This should close #60, #63, #53, #8, #90.

I've completed the refactoring of the directive in order to use Moment.js Objects in combination with Angular's ngModel native directive.
No breaking change has been introduced!

BEFORE:
You should use the directive like this:
<input moment-picker="myDate" ng-model="myDate" format="YYYY-MM-DD">

 {{ myDate }}

Where myDate was a formatted string date using YYYY-MM-DD format (e.g. 2016-11-29).

NOW:
You can still keep the previous code and use formatted date strings, or you can handle Moment.js object using ngModel directive like this:
<input moment-picker ng-model="myDate" format="YYYY-MM-DD">

The format property is useful to render the view value of the model and to calculate minView/maxView view automatically.
You can even use both formatted string value and Moment object like this:

   {{ formattedDate }}

and then use all Moment.js method in your controller:
var nextDate = momentDate.add(1, 'day');

In the end: minDate and maxDate could be either Moment.js object or String in the same format of the formatted date in order to keep backward compatibility.

I've completed the refactoring of the directive in order to use Moment.js Objects in combination with Angular's ngModel native directive.
No breaking change has been introduced!

BEFORE:
You should use the directive like this:
<input moment-picker="myDate" ng-model="myDate" format="YYYY-MM-DD">

 {{ myDate }}

Where myDate was a formatted string date using YYYY-MM-DD format (e.g. 2016-11-29).

NOW:
You can still keep the previous code and use formatted date strings, or you can handle Moment.js object using ngModel directive like this:
<input moment-picker ng-model="myDate" format="YYYY-MM-DD">

The format property is useful to render the view value of the model and to calculate minView/maxView view automatically.
You can even use both formatted string value and Moment object like this:

   {{ formattedDate }}

and then use all Moment.js method in your controller:
var nextDate = momentDate.add(1, 'day');

In the end: minDate and maxDate could be either Moment.js object or String in the same format of the formatted date in order to keep backward compatibility.

This is now available in v0.8.0.


docs: improvements for layouts page

What kind of changes does this PR include?

Minor content fixes (broken links, typos, etc.)
New or updated content

Description

Closes #1781

What does this PR change? Give us a brief description.
Improvements in markdown layouts example.

Did you change something visual? A before/after screenshot can be helpful.
before:

Now:

And, i am taking part in hacktoberfest!!

@sarah11918 , i have some good suggestions for blog posts related to using multiple integrations and would like to work on a few myself as well, If we have a community forum/slack/discord , please let me know :)

Yes we do, please join us on Discord at https://astro.build/chat !


Understanding the PAF file output

I tried xRead out on some of my own data -- I get a PAF file and a FASTA file as output. Looking at the PAF output, the read names in columns 1 and 6 are just numbers, and don't correspond to any read names in the FASTA input or output. Is there some way to recover the relationship between the numbers in the PAF output and the FASTA input?

Following up -- some of the PAF file output doesn't make sense. There are about 3.6M lines of output in the PAF file. About 2% of them (~820k) have more matches (column 10) than bases in one of the reads (column 2 or 7) or than the alignment span (column 11).


docs: Clarify LICENSE on README

It's APL not Affero, apparently.
Pull Request Checklist
If you are a community contributor, copy and paste the PR template from Dendron Community PR Checklist and add it to the body of the pull request.
If you are a team member, copy and paste the template from Dendron Extended PR Checklist.
To copy the template, click on the Raw button on the gist to copy the plaintext version of the template to this PR.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update README.md

just testing

/test help

/test help

/test pull-libguestfs-appliance-build

@rmohr it works :))

/close

@rmohr it works :))

Great. Next step would be the periodic publisher.


Add a command in birdwatcher, get stats of files in etcd

can we add a command in birdwatcher, get stats of files in etcd.
Like:
How many delta logs are there in total, how many stats logs are there in total?
This might be very important for such use cases.
Also we need to think of how to handle these bugs
Originally posted by @xiaofan-luan in https://github.com/milvus-io/milvus/issues/28549#issuecomment-1817732870

/assign MrPresent-Han


[0.10.0] Meta service doesn't shut down correctly

Version:
version 0.10.0.n1453795235, branch master, commit 9d3c9329a69c1dbd2ed7058acd8c2711c781d571

When issuing a service start followed shortly (< 5 seconds) by a service restart on the cluster seed node, the meta service seems to have issues closing properly. Log output:
[run] 2016/01/27 20:33:33 Signal received, initializing clean shutdown...
[run] 2016/01/27 20:33:33 Waiting for clean shutdown...
[cluster] 2016/01/27 20:33:33 cluster service accept error: network connection closed
[snapshot] 2016/01/27 20:33:33 snapshot listener closed
[copier] 2016/01/27 20:33:33 copier listener closed
[shard-precreation] 2016/01/27 20:33:33 Precreation service terminating
[continuous_querier] 2016/01/27 20:33:33 continuous query service terminating
[retention] 2016/01/27 20:33:33 retention policy enforcement terminating
[monitor] 2016/01/27 20:33:33 shutting down monitor system
[monitor] 2016/01/27 20:33:33 terminating storage of statistics
[handoff] 2016/01/27 20:33:33 shutting down hh service
[subscriber] 2016/01/27 20:33:33 closed service
[meta] 2016/01/27 20:33:33 server closed
[meta] 2016/01/27 20:33:33 <IP_ADDRESS> - - [27/Jan/2016:20:33:31 +0000] GET /?index=9 HTTP/1.1 500 25 - Go 1.1 package http 3b01e799-c535-11e5-801b-000000000000 1.605537495s
[meta] 2016/01/27 20:33:33 server closed
[meta] 2016/01/27 20:33:33 <IP_ADDRESS> - - [27/Jan/2016:20:33:31 +0000] GET /?index=9 HTTP/1.1 500 25 - Go 1.1 package http 3b01f350-c535-11e5-801c-000000000000 1.605878792s
[meta] 2016/01/27 20:33:33 server closed
[meta] 2016/01/27 20:33:33 <IP_ADDRESS> - - [27/Jan/2016:20:33:31 +0000] GET /?index=9 HTTP/1.1 500 25 - Go 1.1 package http 3b01f462-c535-11e5-801d-000000000000 1.607085805s
[metaclient] 2016/01/27 20:33:33 failure getting snapshot from influx1:8091: meta server returned non-200: 500 Internal Server Error
[run] 2016/01/27 20:33:33 server shutdown completed
2016/01/27 20:33:34 InfluxDB starting, version 0.10.0.n1453795235, branch master, commit 9d3c9329a69c1dbd2ed7058acd8c2711c781d571, built 2016-01-26T08:01:53.793059

Where the meta client is still receiving requests after it has supposedly stopped (returning 500's). Once this issue occurs, the service fails to start properly again afterwards, stopping at:
2016/01/27 20:33:34 InfluxDB starting, version 0.10.0.n1453795235, branch master, commit 9d3c9329a69c1dbd2ed7058acd8c2711c781d571, built 2016-01-26T08:01:53.793059
2016/01/27 20:33:34 Go version go1.4.3, GOMAXPROCS set to 1
2016/01/27 20:33:34 Using configuration at: /etc/influxdb/influxdb.conf
[meta] 2016/01/27 20:33:34 Starting meta service
[meta] 2016/01/27 20:33:34 Listening on HTTP: [::]:8091
[metastore] 2016/01/27 20:33:34 Using data dir: /var/lib/influxdb/meta
[metastore] 2016/01/27 20:33:34 Node at influx1:8088 [Follower]

And never binding to port 8086.

/cc @dgnorton @corylanou

/cc @e-dard
More information on this issue: I believe this actually has more to do with the a service restart across every member of the cluster. If I run a service restart against a single node in the cluster, the node has no issues re-joining the cluster. If I restart all nodes in the cluster at once, I can't get the cluster to reform again.
On my three node cluster, on nodes 2 and 3 (the non-seed nodes) the logs stop at:
[run] 2016/02/02 16:32:35 server shutdown completed
2016/02/02 16:40:45 InfluxDB starting, version 0.10.0.n1453795235, branch master, commit 9d3c9329a69c1dbd2ed7058acd8c2711c781d571, built 2016-01-26T08:01:53.793059
2016/02/02 16:40:45 Go version go1.4.3, GOMAXPROCS set to 1
2016/02/02 16:40:45 Using configuration at: /etc/influxdb/influxdb.conf
[meta] 2016/02/02 16:40:45 Starting meta service
[meta] 2016/02/02 16:40:45 Listening on HTTP: [::]:8091
[metastore] 2016/02/02 16:40:45 Using data dir: /var/lib/influxdb/meta

On the seed node, the logs stops at:
2016/02/02 16:33:10 InfluxDB starting, version 0.10.0.n1453795235, branch master, commit 9d3c9329a69c1dbd2ed7058acd8c2711c781d571, built 2016-01-26T08:01:53.793059
2016/02/02 16:33:10 Go version go1.4.3, GOMAXPROCS set to 1
2016/02/02 16:33:10 Using configuration at: /etc/influxdb/influxdb.conf
[meta] 2016/02/02 16:33:10 Starting meta service
[meta] 2016/02/02 16:33:10 Listening on HTTP: [::]:8091
[metastore] 2016/02/02 16:33:10 Using data dir: /var/lib/influxdb/meta
[metastore] 2016/02/02 16:33:10 Node at influx1:8088 [Follower]

And the service on all three servers just sits idle, never continuing on with the rest of the startup process.
Prior to the service restart on the non-seed nodes, these messages start appearing:
[cluster] 2016/02/02 16:27:12 accept remote connection from <IP_ADDRESS>:34294
[metaclient] 2016/02/02 16:27:43 failure getting snapshot from <IP_ADDRESS>:8091: meta server returned non-200: 500 Internal Server Error
[cluster] 2016/02/02 16:27:43 close remote connection from <IP_ADDRESS>:34294
[write] 2016/02/02 16:27:49 write failed for shard 3 on node 2: read message type: EOF
[monitor] 2016/02/02 16:27:49 failed to store statistics: write failed: read message type: EOF
[meta] 2016/02/02 16:27:53 <IP_ADDRESS> - - [02/Feb/2016:16:27:44 +0000] GET /?index=39 HTTP/1.1 200 204 - Go 1.1 package http e3564126-c9c9-11e5-800c-000000000000 9.485829756s
[cluster] 2016/02/02 16:27:54 accept remote connection from <IP_ADDRESS>:34300
[metaclient] 2016/02/02 16:27:54 failure getting snapshot from <IP_ADDRESS>:8091: meta server returned non-200: 500 Internal Server Error
[cluster] 2016/02/02 16:27:54 close remote connection from <IP_ADDRESS>:34300
[write] 2016/02/02 16:27:59 write failed for shard 3 on node 2: read message type: EOF
[monitor] 2016/02/02 16:27:59 failed to store statistics: write failed: read message type: EOF
[meta] 2016/02/02 16:28:08 <IP_ADDRESS> - - [02/Feb/2016:16:27:55 +0000] GET /?index=41 HTTP/1.1 200 204 - Go 1.1 package http ea2be387-c9c9-11e5-800d-000000000000 12.594775415s
[cluster] 2016/02/02 16:28:08 accept remote connection from <IP_ADDRESS>:34307
[run] 2016/02/02 16:32:34 Signal received, initializing clean shutdown...
[run] 2016/02/02 16:32:34 Waiting for clean shutdown...
[copier] 2016/02/02 16:32:34 copier listener closed
[cluster] 2016/02/02 16:32:34 cluster service accept error: network connection closed
[snapshot] 2016/02/02 16:32:34 snapshot listener closed
[cluster] 2016/02/02 16:32:34 unable to read type-length-value read message type: read tcp <IP_ADDRESS>:49875: use of closed network connection
[cluster] 2016/02/02 16:32:34 close remote connection from <IP_ADDRESS>:49875
[cluster] 2016/02/02 16:32:34 unable to read type-length-value read message type: read tcp <IP_ADDRESS>:34307: use of closed network connection
[cluster] 2016/02/02 16:32:34 close remote connection from <IP_ADDRESS>:34307
[shard-precreation] 2016/02/02 16:32:34 Precreation service terminating
[continuous_querier] 2016/02/02 16:32:34 continuous query service terminating
[retention] 2016/02/02 16:32:34 retention policy enforcement terminating
[monitor] 2016/02/02 16:32:34 shutting down monitor system
[monitor] 2016/02/02 16:32:34 terminating storage of statistics
[handoff] 2016/02/02 16:32:34 shutting down hh service
[metaclient] 2016/02/02 16:32:34 failure getting snapshot from <IP_ADDRESS>:8091: meta server returned non-200: 500 Internal Server Error
[subscriber] 2016/02/02 16:32:35 closed service
[run] 2016/02/02 16:32:35 server shutdown completed

Is there a way to recover from this?
I'm experiencing the same as rossmcdonald's comment and am also unable to get the cluster to reform. This is making it unusable.

@grvr If you restart the nodes individually are they still unable to cluster properly? If so, can you paste the contents of the logs since the last restart?

This should be fixed by this PR https://github.com/influxdata/influxdb/pull/5602

Closing, as this was fixed by #5602


Compile error

Arduino: 1.8.5 (Windows 10), Board: "NodeMCU 1.0 (ESP-12E Module), 80 MHz, 4M (1M SPIFFS), v2, Disabled, None, 115200"
C:\Program Files (x86)\Arduino\ESP8266-HTTP-IR-Blaster-master\IRController\IRController.ino: In function 'bool setupWifi(bool)':
IRController:364: error: use of deleted function 'ESP8266WebServer& ESP8266WebServer::operator=(const ESP8266WebServer&)'
 server = ESP8266WebServer(port);

        ^

In file included from C:\Users\x\Documents\Arduino\libraries\WiFiManager/WiFiManager.h:17:0,
             from C:\Program Files (x86)\Arduino\ESP8266-HTTP-IR-Blaster-master\IRController\IRController.ino:8:

C:\Program Files (x86)\Arduino\hardware\esp8266com\esp8266\libraries\ESP8266WebServer\src/ESP8266WebServer.h:69:7: note: 'ESP8266WebServer& ESP8266WebServer::operator=(const ESP8266WebServer&)' is implicitly deleted because the default definition would be ill-formed:
class ESP8266WebServer
   ^

C:\Program Files (x86)\Arduino\hardware\esp8266com\esp8266\libraries\ESP8266WebServer\src/ESP8266WebServer.h:69:7: error: use of deleted function 'std::unique_ptr<_Tp, _Dp>& std::unique_ptr<_Tp, _Dp>::operator=(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = HTTPUpload; _Dp = std::default_delete]'
In file included from c:\users\x\appdata\local\arduino15\packages\esp8266\tools\xtensa-lx106-elf-gcc\1.20.0-26-gb404fb9-2\xtensa-lx106-elf\include\c++\4.8.2\memory:81:0,
             from C:\Program Files (x86)\Arduino\hardware\esp8266com\esp8266\cores\esp8266/FS.h:24,

             from C:\Program Files (x86)\Arduino\ESP8266-HTTP-IR-Blaster-master\IRController\IRController.ino:1:

c:\users\x\appdata\local\arduino15\packages\esp8266\tools\xtensa-lx106-elf-gcc\1.20.0-26-gb404fb9-2\xtensa-lx106-elf\include\c++\4.8.2\bits\unique_ptr.h:274:19: error: declared here
   unique_ptr& operator=(const unique_ptr&) = delete;

               ^

exit status 1
use of deleted function 'ESP8266WebServer& ESP8266WebServer::operator=(const ESP8266WebServer&)'

This looks like a problem with your Arduino installation or one of the installed libraries. I would reinstall and try again
Sent from my iPhone

On Dec 2, 2017, at 01:38, Twist3d<EMAIL_ADDRESS>wrote:
Arduino: 1.8.5 (Windows 10), Board: "NodeMCU 1.0 (ESP-12E Module), 80 MHz, 4M (1M SPIFFS), v2, Disabled, None, 115200"
C:\Program Files (x86)\Arduino\ESP8266-HTTP-IR-Blaster-master\IRController\IRController.ino: In function 'bool setupWifi(bool)':
IRController:364: error: use of deleted function 'ESP8266WebServer& ESP8266WebServer::operator=(const ESP8266WebServer&)'
server = ESP8266WebServer(port);
    ^

In file included from C:\Users\x\Documents\Arduino\libraries\WiFiManager/WiFiManager.h:17:0,
         from C:\Program Files (x86)\Arduino\ESP8266-HTTP-IR-Blaster-master\IRController\IRController.ino:8:

C:\Program Files (x86)\Arduino\hardware\esp8266com\esp8266\libraries\ESP8266WebServer\src/ESP8266WebServer.h:69:7: note: 'ESP8266WebServer& ESP8266WebServer::operator=(const ESP8266WebServer&)' is implicitly deleted because the default definition would be ill-formed:
class ESP8266WebServer
^
C:\Program Files (x86)\Arduino\hardware\esp8266com\esp8266\libraries\ESP8266WebServer\src/ESP8266WebServer.h:69:7: error: use of deleted function 'std::unique_ptr<_Tp, _Dp>& std::unique_ptr<_Tp, _Dp>::operator=(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = HTTPUpload; _Dp = std::default_delete]'
In file included from c:\users\x\appdata\local\arduino15\packages\esp8266\tools\xtensa-lx106-elf-gcc\1.20.0-26-gb404fb9-2\xtensa-lx106-elf\include\c++\4.8.2\memory:81:0,
         from C:\Program Files (x86)\Arduino\hardware\esp8266com\esp8266\cores\esp8266/FS.h:24,

         from C:\Program Files (x86)\Arduino\ESP8266-HTTP-IR-Blaster-master\IRController\IRController.ino:1:

c:\users\x\appdata\local\arduino15\packages\esp8266\tools\xtensa-lx106-elf-gcc\1.20.0-26-gb404fb9-2\xtensa-lx106-elf\include\c++\4.8.2\bits\unique_ptr.h:274:19: error: declared here
unique_ptr& operator=(const unique_ptr&) = delete;
           ^

exit status 1
use of deleted function 'ESP8266WebServer& ESP8266WebServer::operator=(const ESP8266WebServer&)'
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I uninstalled and deleted the libraries.  I downloaded the portable client and reinstalled the libraries/core board and I still get the same error.

The error is coming from the ESP8266WebServer class not from the script itself. That class is part of the arduino core perhaps try reinstall that?
Sent from my iPhone

On Dec 2, 2017, at 05:24, Twist3d<EMAIL_ADDRESS>wrote:
I uninstalled and deleted the libraries. I downloaded the portable client and reinstalled the libraries/core board and I still get the same error.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Yeah, I deleted everything again and reinstalled the core and it worked. Not sure what happened the first two times.

Glad it’s working


Make log file name configurable

At the moment, it's always tuf.log in the current working directory.

I like this feature request.  It had occurred to me in the past, but I was fine with it being fixed during development.
Instead of having a fixed path for the log file (See https://github.com/theupdateframework/tuf/blob/develop/tuf/log.py#L77), we can make it configurable by adding an option to conf.py (which is where we store all configurable settings).
What about another option to disable file logging entirely?

Yes, that would be useful too.

Options to disable file logging entirely and configure the logger file were implemented in #304
Let us know if this solution works for you.

That works fine - ta

Unfortunately, just importing tuf.conf (in order to set the log file) sets it to and creates tuf.log:
david@david-Latitude-E6440:~/dtuf$ rm tuf.log
david@david-Latitude-E6440:~/dtuf$ python
Python 2.7.10 (default, Oct 14 2015, 16:09:02)
[GCC 5.2.1 20151010] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import tuf.conf
>>>
david@david-Latitude-E6440:~/dtuf$ ls
docs  htmlcov   python      requirements.txt  setup.py
dtuf  Makefile  README.md   setenv-hub.sh     test
dxf   pylintrc  README.rst  setenv-local.sh   tuf.log

https://github.com/theupdateframework/tuf/pull/307

Thanks for providing a fix for this!

This issue was fixed in PR #307 and #308


Only forward matching HTTP methods

Not the most elegant solution, but here goes...

Just saw this. Could you default the alternateMethods to empty string?

Just saw this. Could you default the alternateMethods to empty string?

Sure, but you already merged... 🤔
I can create a follow up PR if you wish?!

found some bugs. fixed them. You can help to review my changes.

found some bugs. fixed them. You can help to review my changes.

LGTM :+1:


broken styles on hover in activity

Description

both on main screen and profile
Gitea Version
trunk
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
docker
Database
None

It's related to the tippy style change @silverwind

Yes, this is related to the removal of the default 1rem padding.

Problem is, this lib does not expose any way to allow modifying these tippy instances:
https://github.com/razorness/vue3-calendar-heatmap/blob/955626176cb5dc3d3ead8120475c2e5e753cc392/src/components/CalendarHeatmap.vue#L200-L204

So I think the proper solution is to pass tooltip=false to the lib and instantiate our own tippy.

So I think the proper solution is to pass tooltip=false to the lib and instantiate our own tippy.

That's what I said in https://github.com/go-gitea/gitea/pull/30732#issuecomment-2085395594 :

I still do not think it is safe to backport.

Now we have limited time to fix this new regression.

It's fine, it's a minor cosmetical issue.

I also proposed one.  Fix activity heat map padding & locale #30823


Unable to create a link in plocal document database. Same works in a remote document db

Hello,
I see a strange difference in behavior when we try to create a link against a plocal & remote DB.
I ran the below commands on a database created as plocal and got the error mentioned below. If I create another db of type remote, it works just fine.
Am I missing something?

orientdb> create database plocal:mytestdb11 root root123 plocal
Creating database [plocal:mytestdb11] using the storage type [plocal]...
Database created successfully.
Current database is: plocal:mytestdb11
orientdb {db=mytestdb11}> create class Post;

Class created successfully. Total classes in database now: 11
orientdb {db=mytestdb11}> create property Post.id integer;
Property created successfully with id=1

orientdb {db=mytestdb11}> create class comments;
Class created successfully. Total classes in database now: 12

orientdb {db=mytestdb11}> create property comments.id integer;
Property created successfully with id=1

orientdb {db=mytestdb11}> create property comments.postid integer;
Property created successfully with id=2

_orientdb {db=mytestdb11}> create link commentsonpost from comments.postid to post.id;
[

Error: com.orientechnologies.orient.core.exception.OCommandExecutionException: Error on execution of command: sql.create link commentsonpost from comments.postid to post.id

Error: java.util.UnknownFormatConversionException: Conversion = '%'_

Hi @sukesh-soman
I'm checking it, I'll give you a feedback asap
Thanks
Luigi


Update office-365-network-mac-perf-overview.md

Added paragraph about network connectivity data sharing with Microsoft for linking from new UX setting.
FYI @kelleyvice-msft  @ivybarley

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@pandrew1

Ack, thank you @yogkumgit and @JohanFreelancer9

@pandrew1 - Could you please commit my suggestions? Thanks.

@JohanFreelancer9 Got it. Thanks for pointing that out


[Fix #3022][Fix #2909]: Add EnforcedStyle configuration to Style/Lambda cop

Overview of the change
This change implements configurable styles for the Style/Lambda cop, allowing you to indicate that you want the old, method style (lambda) or new, literal style (->) lambdas for both single line and multiline lambdas. The new configuration options are:

line_count_dependent
This is the old, default configuration. It enforces literal style for single line lambdas, and lambda style for multiline lambdas.

lambda
This configuration enforces lambda style for all lambdas.

literal
This configuration enforces literal style for all lambdas.

===
Suggestion messages
The messages will adjust to whatever configuration you're using, to make it clear what the user needs to do. With either of the optional styles, the message will tell the user to use the enforced style in all cases:

Use the old lambda method for all lambdas.

With the default style, it will advise the user in which cases to use which style:

Use the old lambda method for multiline lambdas.

With this change, I removed the part that would format the message to either contain arguments or not, depending on the actual offense, i.e. -> { ... } vs. ->(x) { ... }. Reason being that correctly constructing this would now take a lot more conditional logic, due to the added dimension of single line vs. multiline, and possibly require reading the configuration for Style/BlockDelimiters. In my opinion, the message is still very comprehensible, and I don't think it's worth the additional complexity of making it more specific.
====
Slight changes in semantics
Internally, I changed references to "new" and "old" to "literal" and "method", which is more semantic, and won't cause issues if a third style is introduced. In the messages presented to the users, I kept the "new" and "old" wording, in addition to mentioning "literals" or "methods".

Internally, I changed references to "new" and "old" to "literal" and "method", which is more semantic, and won't cause issues if a third style is introduced. In the messages presented to the users, I kept the "new" and "old" wording, in addition to mentioning "literals" or "methods".

Guess we can refer to those in the messages as lambda method and lambda literal (or stabby lambda).

With this change, I removed the part that would format the message to either contain arguments or not, depending on the actual offense, i.e. -> { ... } vs. ->(x) { ... }. Reason being that correctly constructing this would now take a lot more conditional logic, due to the added dimension of single line vs. multiline, and possibly require reading the configuration for Style/BlockDelimiters. In my opinion, the message is still very comprehensible, and I don't think it's worth the additional complexity of making it more specific.

Fine by me.

Guess we can refer to those in the messages as lambda method and lambda literal (or stabby lambda).

Yeah. This is how they are referred to in the user facing messages, in the suggested change.

Use the new -> { ... } lambda literal syntax for all lambdas.

Use the old lambda method for all lambdas.

I meant to say we should drop old and new. This is hardly new anymore...
On Sunday, 24 April 2016, Ted Johansson<EMAIL_ADDRESS>wrote:

Guess we can refer to those in the messages as lambda method and lambda
literal (or stabby lambda).
Yeah. This is how they are referred to in the user facing messages, in the
suggested change.
Use the new -> { ... } lambda literal syntax for all lambdas.
Use the old lambda method for all lambdas.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/bbatsov/rubocop/pull/3076#issuecomment-214038430

--
Best Regards,
Bozhidar Batsov
http://www.batsov.com

I meant to say we should drop old and new. This is hardly new anymore...

Yes. I tend to agree with this. I have removed it and pushed again.


Interface screw when any language with long name selected in script creating dialog

Godot version:
3cc94b2c0
OS/device including version:
Windows 10 x64
Issue description:

Steps to reproduce:

Open script creating window.
Select VisualScript.
See the bug.

Minimal reproduction project:
Not needed.

@akien-mga @groud @YeldhamDev
UPDETO! Looks like it's not with only "VisualScript", but all aside "C#".  I suspect that interface self-adjusting to contained string's length is to blame.

I'm unable to reproduce this.

@YeldhamDev
Not appeared for me too in random second attempt. Don't know, what's this.

Did you change the editor's scale when this happened?

@YeldhamDev
No, not at all. Fullscreen and that's it.

It looks somewhat similiar to https://github.com/godotengine/godot/issues/32790

@Teashrock Can you still reproduce this?

@YeldhamDev
Not tried intentionally, but didn't see it either.

I will close this for now, give me a heads-up if you see it again.


Header Template needs to be cleaned up to incorporate a better menu system

Menu is much better now, still will need a few more rounds of improvement.


Update README.md

Jenkins Build Details:
Build status: FAILURE
Build duration: 51 sec

Jenkins Build Details:
Build status: FAILURE
Build duration: 44 sec


Use Directory.Build.props/targets

MSBuild 15 will automatically import the first file named Directory.Build.{props,targets} in the project directory or any parent directory. This removes some duplication from our csproj files and makes it easier to apply properties to all projects in a particular folder. (Say, for example, you want to install a DotNetCliToolReference into all projects....)
There is also marginal benefit in ensuring our builds don't accidentally pick up a Dir.Build outside the repo in the event someone drops a file with this name into Universe or on the disk.


Future of RetinaNet (this repository)

Hi!
I really use and enjoy this RetinaNet repository because of actually great precision, learning and speed!
However I am considered about future because it seems almost dead.
I would be grateful for at least support for new NGC images with new TRT, ONNX and PyTorch versions.
I have managed to make sufficient changes myself but what is the plan for the future?
Best regards,
Martin

Hello Martin,
did you succeed to make this repo run with those newest NGC images? Would you be able to share the changes?
Thanks.

Hi batrlatom,
in Dockerfile try replacing base image with:
nvcr.io/nvidia/tensorrt:20.10-py3
Hope this helps,
Martin

Hello, this repository acts as a medium to run some experiments done internally. We try to update it as often as needed, but this is not in active development. The latest updates have been put in with container 20.11.

I would like ask complementary question - is RetinaNet from NVidia Transfer Learning Toolkit basically continuation of this experimental repository?


RenderList Expansion

The renderlist is powerful as it is, but as we add more rendering techniques, it needs to become a bit lower level to facilitate use of compute shaders, as well as dealing with all the variety needed in a real life renderer.
This is required for most enhancements going forward, so is top priority. This issue is mainly to organize my thoughts, but commentary is appreciated :)
The rewrite will contain major changes:

Add an initialization phase where persistent data can be stored.
Add support for custom buffers which can be initialized with data.
Add support for initializing custom textures with data.
Custom data should use opaque handles as identifiers, not clunky strings.
Custom data needs to be constructed/destroyed explicitly, though the renderlist can help make this easier by allowing create_or_reuse and marking other resources as transient.
Turn the concept of a renderlist into a trait:trait RenderList {
  fn init(&mut self, recorder: &mut RenderListCreationRecorder);
  fn render(&mut self, recorder: &mut RenderListFrameRecorder);
}

This will allow RenderLists to hold arbitrary state.
Each target will be recorded separately. When recording a pass, the parameters are:

The object filter (see #56) to determine which objects to start with.
If cpu-side frustum culling should be applied.
If cpu-side sorting should be applied.
The target (shadows, or a non-shadow texture view)

The function doing the recording will be a FnMut function which is provided:

The count of objects that match the filter.
Current renderer details like wave size and rendering mode.

Unlike the current design the user triggers draws that are aware of mode:

draw_cpu which looks similar to today's RenderOp.
draw_gpu which explicitly takes an indirect and count buffer as well as count.

There are added compute passes for compute shaders.

dispatch which takes an explicit size.
dispatch_indirect which takes an indirect buffer.

Passes can be named, the renderer will return statistics corresponding with those names.
MSAA support needs to be included (see #34)

Nah this is def now how we should do it.


Lokalise: Translations update

This pull request was initiated by Lokalise (user Agnieszka Galeza) at 2020-11-30 22:47:27

i still see on staging, do i need to wait some times to check

@adorapham yes, we didn't merge this yet.


MLIBZ 1453 Do not disconnect social identities on logout

Description
Remove code to disconnect social identities in Kinvey.User.logout.
Changes

Do not disconnect social identities in logout

Current coverage is 60.07% (diff: 100%)

Merging #75 into master will decrease coverage by 0.01%

@@             master        #75   diff @@
==========================================
  Files            53         53
  Lines          6093       6081    -12
  Methods         883        880     -3
  Messages          0          0
  Branches        938        937     -1
==========================================
- Hits           3661       3653     -8
+ Misses         2432       2428     -4
  Partials          0          0

Powered by Codecov. Last update 867a9db...e5bc2ef


Add HTML Structure for GStraccini-bot Main Page

User description

Closes #
📑 Description

✅ Checks

[ ] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed

☢ Does this introduce a breaking change?

[x] Yes
[ ] No

ℹ Additional Information

Description

Introduced a new index4.php file that serves as the main page for the GStraccini-bot.
The file includes a header, hero section, features display, and footer.
Added CSS styles for improved aesthetics and user experience.
This change enhances the overall presentation and functionality of the bot's web interface.

Changes walkthrough 📝
Relevant filesEnhancement

index4.phpNew HTML Structure for GStraccini-bot

Src/index4.php
Created a new HTML file for the GStraccini-bot.  Added a structured layout with header, hero section, features, and footer.  Included CSS styles for responsive design and animations.  Implemented sections to showcase features of the bot.

+158/-0

💡 Penify usage:
Comment /help on the PR to get a list of all available Penify tools and their descriptions

@gstraccini codacy bypass


Solver - [merged]

In GitLab by @cmastalli on Oct 16, 2018, 09:23
Merges solver -> devel
This PR request contain few improvements in the solver structure and its unit-test.
The changes are:

Armijo-like condition for acceptance the line search
Comparison between DDP solution and KKT solution (unit-test)
Using data.f for integration, instead of creating internally a data for it.
Simple tuning of mu for Value-function regulation.

All the changes were tested in the set of unit-tests, and in the DDP problem with the manipulator and quadruped robots.

In GitLab by @cmastalli on Oct 16, 2018, 09:23
merged

In GitLab by @cmastalli on Oct 16, 2018, 09:23
mentioned in commit 4b7b4d84471d783bb6ce0b7614238ef6a0190abd


No feedback when downloading

When you press download you have no idea if rhasspy is downloading or not responding.  Maybe adding some progress bar?

I would like to do this, but I'm not sure the best way. The browser itself isn't doing the downloading, it's the Rhasspy server. It's also happening in a separate thread from the web server, so it might be quite difficult to get any progress information pushed back through to the client.


Failed at the<EMAIL_ADDRESS>install script.

<EMAIL_ADDRESS>install /root/rasaui/node_modules/fibers
node build.js || nodejs build.js

make: Entering directory /root/rasaui/node_modules/fibers/build'   CXX(target) Release/obj.target/fibers/src/fibers.o cc1plus: error: unrecognized command line option "-std=gnu++1y" make: *** [Release/obj.target/fibers/src/fibers.o] Error 1 make: Leaving directory /root/rasaui/node_modules/fibers/build'
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
gyp ERR! System Linux 2.6.32-754.6.3.el6.x86_64
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--release"
gyp ERR! cwd /root/rasaui/node_modules/fibers
gyp ERR! node -v v10.13.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
node-gyp exited with code: 1
Please make sure you are using a supported platform and node version. If you
would like to compile fibers on this machine please make sure you have setup your
build environment--
Windows + OS X instructions here: https://github.com/nodejs/node-gyp
Ubuntu users please run: sudo apt-get install g++ build-essential
Alpine users please run: sudo apk add python make g++
sh: nodejs: command not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>install: node build.js || nodejs build.js
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:

I had the same exact issue in Windows10 and Followed the installation guide here. It seems that node-gyp is a pre-requisite, so try following OS specific steps and let me know if this helps.

@duybvk - is this issue resolved? Any feedback on what worked? Thanks!

Even I faced this error. I saw somewhere that it only works with node 4, 5 and 6. So I downgraded my node version to 6 and it worked for me

I also had to downgrade to node 6


Increase i maximum from 12 to 13

This pull requests increases the i maximum from 12 to 13, which allows Dumpling to locate the last user on the system.
I have tested this and confirmed it to work on my system; YMMV but hopefully not - you can download the files here or build it yourself

Ah, thanks for finding this. Will try and make a release with it soon!


Pylint doesn't automatically check the right place.
But if I run
pylint pdr_backend/*

Then many errors will pop up.
It means that pylint isn't configured properly to look into all the code. (Or any of the code!)
It's the first call that CI uses.
TODO: fix this

Note: to fix it, I explicitly put pdr_backend/ into the CI flow and the README.
I would have preferred to change pylintrc to make it work -- since a bit more automated -- but I could never get it to properly see the path. Ah well. Now we have a way.


[Feature] It would be nice to be able to specify the IP address of xdebug

I'm using Atom on OSX and developing on an Ubuntu virtual machine.  It doesn't look like there is a setting to specific the xdebug machine and so I will have to use SSH port forwarding.

Any reason why you closed this? Would be nice to have feature.

Addressed in #166 and PR #167


Updated function twos and tested

Please review "twos"

looks slow to me
git faster
np.sum(dice[dice == 2])

pytest returns no errors for two


[BUG]: Typescript issue

What version of drizzle-orm are you using?
^0.33.0
What version of drizzle-kit are you using?
^0.24.2
Describe the Bug
this working

if i makes as a object.

but directly put into values not working. giving typescript error.
giving this typescript issue
No overload matches this call.
  Overload 1 of 2, '(value: { emailId: string | SQL<unknown> | Placeholder<string, any>; userId: string | SQL<unknown> | Placeholder<string, any>; }): PgInsertBase<PgTableWithColumns<{ name: "tickets"; schema: undefined; columns: { ...; }; dialect: "pg"; }>, PostgresJsQueryResultHKT, undefined, false, never>', gave the following error.
    Object literal may only specify known properties, and 'isRead' does not exist in type '{ emailId: string | SQL<unknown> | Placeholder<string, any>; userId: string | SQL<unknown> | Placeholder<string, any>; }'.
  Overload 2 of 2, '(values: { emailId: string | SQL<unknown> | Placeholder<string, any>; userId: string | SQL<unknown> | Placeholder<string, any>; }[]): PgInsertBase<PgTableWithColumns<{ name: "tickets"; schema: undefined; columns: { ...; }; dialect: "pg"; }>, PostgresJsQueryResultHKT, undefined, false, never>', gave the following error.
    Object literal may only specify known properties, and 'emailId' does not exist in type '{ emailId: string | SQL<unknown> | Placeholder<string, any>; userId: string | SQL<unknown> | Placeholder<string, any>; }[]'.

let me show you my schema also
import { sql } from 'drizzle-orm';
import { boolean, integer, pgTable, serial, timestamp, varchar } from 'drizzle-orm/pg-core';

const tickets = pgTable('tickets', {
   id: serial('id').primaryKey(),
   emailId: varchar('email_id', { length: 255 }).notNull(),
   userId: varchar('user_id', { length: 300 }).notNull(),
   isRead: boolean('is_read').default(false),
   readAt: timestamp('read_at'),
   lastPingAt: timestamp('last_ping_at'),
   duration: integer('duration').notNull().default(0),
   readCounts: integer('read_counts').notNull().default(0),
   ipAddress: varchar('ip_address', { length: 100 }),
   location: varchar('location', { length: 200 }),
   browser: varchar('browser', { length: 100 }),
   deviceInfo: varchar('device_info', { length: 300 }),
   system: varchar('system', { length: 200 }),
   sendDate: timestamp('send_date').default(sql`CURRENT_TIMESTAMP`),
   createdAt: timestamp('created_at').default(sql`CURRENT_TIMESTAMP`),
   updatedAt: timestamp('updated_at', { mode: 'string' }).defaultNow(),
});
export default tickets;

same issue in second case
payload giving error

saying this error

when i uncomment the emailId and userId the error gone.

don't know why this issue happening.
Expected behavior
it's should be run but don't know why not working.
also if i removed everything only put
values inside
values({emailId,userId}) that time it's working directly in values. but have to remove other fields.
Environment & setup
development

Same issue here.

Same issue here.

have you find any solution ?

had to use any type while setting the attributes that were throwing this error:
await db.update(wordpress).set({
         lastUpdated: sql`NOW()`,
         plugins: JSON.stringify(plugins) as any,
         themes: JSON.stringify(themes) as any,
         core: JSON.stringify(core) as any
      }).where(eq(wordpress.websiteID, websiteID));

had to use any type while setting the attributes that were throwing this error:
await db.update(wordpress).set({
         lastUpdated: sql`NOW()`,
         plugins: JSON.stringify(plugins) as any,
         themes: JSON.stringify(themes) as any,
         core: JSON.stringify(core) as any
      }).where(eq(wordpress.websiteID, websiteID));

Ok 🥲

I ran into this too. I tried 0.32.2 and it still had the issue. I had to roll back to 0.31.4.

still got this in 0.33.0

I'm having the same problem

same issue, latest working version is 31.4

For the error i had was on an udpate(...).set({...}) and checking the change between 31.4 and 32.0 it seems that this change (attached screenshot) was responsible for it. Reverting back fix the typing for the set function.

just replying here in case someone needs, that if possible for you can enable nullStrictChecks: true in your TS config as explained in this issue

For the error i had was on an udpate(...).set({...}) and checking the change between 31.4 and 32.0 it seems that this change (attached screenshot) was responsible for it. Reverting back fix the typing for the set function.

I'm also getting the same error even in version 0.36.1

this issue still exists in v0.38.2


Upstream UFO Check: Validate GLIF

[ ] Add an upstream UFO check that uses https://github.com/davelab6/glif-schema and http://lxml.de/validation.html to validate GLIF files

we don't test upstream sources


Add link to license in readme

Thought it may be helpful/convenient to have a link to the license in the readme

Pull request https://github.com/LeeHolmes/watchysim/pull/6 would resolve this issue if merged


Firebase.get returns null after some time

I am using nodemcu along with Firebase-Arduino library. I use a combination of Firebase reads and writes in regular intervals of 10 seconds. But after the code runs for some time, usually a couple of hours, Firebase.getString(...) returns null value, BUT Firebase.setString(..) works fine.
Does anyone know what could be the reason for this?
Here is the code:
#include<ESP8266WiFi.h>
#include<ESP8266HTTPClient.h>
#include<ESP8266WebServer.h>
#include<WiFiClientSecure.h>
#include<WiFiUdp.h>
#include<SPI.h>//load the spi library
#include<EEPROM.h>
#include<ArduinoJson.h>
#include<TimeLib.h>
#include<time.h>
#include <FirebaseArduino.h>

#define MAX_WIFI_INFO_LENGTH 100

ESP8266WebServer server;

//FIREBASE AND SSID INITIALIZATION HERE

void Setup(){
    Firebase.begin(FIREBASE_HOST, FIREBASE_AUTH);
}

void GetFromOnline(){
  if (Firebase.failed()){
      Serial.print("setting /message failed:");
      Serial.println(Firebase.error());
      return;
  }
  Serial.print("Output is ");
  Serial.println(Firebase.getString("/flag"));
}

void WriteDataOnline(){
    Firebase.setString("/upld" , String(analogRead(A0)));
}
int previousTime = 0;
int interval = 10000;
void loop() {
  if(millis()-previousTime > interval){ //every 10 seconds
    previousTime = millis();
    GetFromOnline();
    WriteDataOnline();
  }
}

WriteDataOnline() works perfectly fine, BUT GetFromOnline() works for certain duration (a couple of hours).
Initially, the output of GetFromOnline() is as such:
Output is 1
But after sometime, the output is:
Output is
setting /message failed:

So I am guessing Firebase.failed() becomes true after sometime, but there is no error message that is printed after "setting /message failed:"
Any help is appreciated.

i have the same problem =(

did you solve the problem ?

Is there any other solution other than Restarting ?


ARROW-7717: [CI] Have nightly integration test for Spark's latest release

@ursabot crossbow submit test-conda-python-3.6-spark-2.4.4 test-conda-python-3.7-spark-master

AMD64 Conda Crossbow Submit (#90452) builder has been succeeded.
Revision: ce2060550fdab643808cc8e4dfba4ae052771832
Submitted crossbow builds: ursa-labs/crossbow @ ursabot-505

Task
Status

test-conda-python-3.6-spark-2.4.4

test-conda-python-3.7-spark-master

@kszucs I did some local testing and I think there are a number of issues with getting Spark 2.4.4 tests working with the latest pyarrow and pandas >= 1.0.0. It might be better to setup a test for the upcoming release of Spark 3.0.0, the branch has been cut here https://github.com/apache/spark/tree/branch-3.0, that should work fine.

SGTM

@BryanCutler @kszucs what do you think about setting up a Spark 3.x integration test?

Definitely, I'm going to roll up this PR and create a jira for spark 3.0 integration testing.

Or just try to add it in this PR.

@github-actions crosbow submit spark

@github-actions crossbow submit spark

@BryanCutler could you please fix the build errors? I'm not sure what compatibility constraints do we/spark have, perhaps we'll need to stop testing spark 2? The master and spark 3 might error might need to be fixed on spark's side.

@github-actions crossbow submit test-conda-python-3.6-spark-2.4.6

Yeah, definitely would be good to test against Spark 3.0. I'll have to work on a patch to handle some of the recent changes to Arrow Java to fix the build.

Thanks You! Although Spark 2 seems to fail as well.

Yup, the Spark 2 issues are probably due to the same changes - I'll take a look

@kszucs I submitted a patch to fix Java compilation with Spark master and branch-3.0, and tested locally with the latest pyarrow so Spark integration tests should pass for these as of this morning.
For Spark branch-2.4, it will require applying a different patch with the testing script, but maybe we should rethink this strategy a little. Spark 2.4.x will not upgrade Arrow Java anymore, so it would be more correct to take the latest Spark 2.4.6 release out of the box and test that with pyarrow from master. Is that possible to setup, wdyt?

@kszucs I submitted a patch to fix Java compilation with Spark master and branch-3.0, and tested locally with the latest pyarrow so Spark integration tests should pass for these as of this morning.

Thanks Bryan!

For Spark branch-2.4, it will require applying a different patch with the testing script, but maybe we should rethink this strategy a little. Spark 2.4.x will not upgrade Arrow Java anymore, so it would be more correct to take the latest Spark 2.4.6 release out of the box and test that with pyarrow from master. Is that possible to setup, wdyt?

I'm not sure that I understand you correctly :)

keep arrow master <=> spark branch-3.0
keep arrow master <=> spark master
and keep arrow master <=> spark 2.4.6 but execute only the pyarrow tests?

I mean the current process for integration tests with the master branch is to build Spark with Arrow Java master, then run Java and Python tests. That process is good for Spark master and branch-3.0, but with Spark branch-2.4, it doesn't make too much sense to rebuild Spark with Arrow Java master. This is because the dependency on Arrow Java is pretty much frozen for branch-2.4 (unless there is a serious enough bug), but different versions of pyarrow can be used. It would be best to take the latest Spark 2.4.6 release out of the box and run the pyspark tests from the script with pyarrow from master. We are not really concerned about Java compatibility since it can't be upgraded anyway, but that still allows us to flush out any Python problems.

@kszucs the nightly against Spark master have been passing. Do you think you could update this to just add the test against branch-3.0 and remove branch-2.4 for now? I'm not sure if the bot will pick it up from this PR, but I'll try to kick it off a test run.

@github-actions crossbow submit test-conda-python-3.7-spark-branch-3.0

@github-actions crossbow submit  test-spark

This is great, thanks @kszucs !


[CARBONDATA-3885] [CARBONDATA-3884] Fix for load failures with isSIenabled = false and fix for concurrent load failure

Why is this PR needed?
Issue 1:
In some concurrent scenarios it was found that certain segment folders were getting deleted for the SI table. When the segment was being inserted again back to the SI table during a new load to the main table by doing isSIenabled = false, the load to the SI table failed.
Root Cause: It was found that when the segment folder gets deleted and it's entry from table status file is manually deleted then, during new load to SI when table status is changed to InsertInProgress during the loading previously deleted segments the stale .segmentfile still exists which was pointing to the mergeindexfile which does exist anymore(since the segment folder is deleted). Since that mergeindexfile does not exist anymore the load to SI table failed
Issue 2:
In some concurrent load scenarios in main table with SI table with isSITableEnabled = false , load to SI table fails.
Root Cause: When concurrent loading is done with isSITableEnabled = false, maintable details are taken earlier in the code and SItable details are taken later. It was found that there were some scenarios where another concurrent load to main table finishes and can change the number of segments in the main table due to which there is mismatch in number of segments in the SI table and in the main table. Due to this mismatch when the validmaintableload method is called, there can be scenarios where the load fails.
What changes were proposed in this PR?
Solution for Issue 1: Whenever isSIenabled is set to false and it tries to load previously deleted SI segments to the SI table we go and delete the stale .segment file from the metadata folder if it exists. Due to this, while loading a new .segment file will be created thus having a new index file path.
Solution for Issue 2: Whenever isSIenabled is set to false and it tries to load previously deleted SI segments, just before adding segments in SIFailedSegmentList checking again if the loadname is present in the main table. Only adding in SIFailedSegmenList if the loadname is present in the main table and it's in SUCCESS state.
Does this PR introduce any user interface change?

No

Is any new testcase added?

No

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3201/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1475/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3307/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1569/

@vikramahuja1001 the  issue reproduce steps, please mention in jira and for PR description, give proper issue, root cause and solution proposed.

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3326/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1586/

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3351/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1610/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3352/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1611/

LGTM


Consistent formatting in docs and README.

Eventually I'd prefer monospace to be used in most places where italics is now used – at least for directory paths and file names, command lines and format string attributes.
Current documentation is a mixture of monospace and italics.
The above applies to the change log.
But it's probably best to do this improvement in a separate issue and PR.
Originally posted by @akaihola in https://github.com/akaihola/darglint2/pull/33#discussion_r1199817934

Lets use italics for

names (of people, projects, ...)
technical terms when they are introduced (e.g. when explaining the term 'complain')
maybe instead of quoting in cases like the above?

Lets use monospace for

paths
file/directory names
command lines, command line arguments
config options
complaint codes
code snippets
code elements like function names, format string attributes, ...

This one is mechanical enough that I could contribute the PR.

This one is mechanical enough that I could contribute the PR.

As you wish. However I would find it more valuable if you wrote the texts for #3.

more valuable if you wrote the texts for #3

Fair enough, I'll focus on that first!


[MODULE] - Whisper brick

Please describe the module you would like to add to bricks
Whisper article; wouldn't it be amazing if i could have one brick transferring speech to text, and then another one chained to detect the emotion/sentiment/entities from the text?
Do you already have an implementation?
Whisper is open-source
Additional context
See discussion #182; this is not pure JSON, but would be some format of audio data

At some point TTS/ STT is a must for us. We might not even need whisper. The azure cognitive services for example are also really great and dirt cheap, too.

How do you see the dependency of bricks towards different compute requirements or platforms?
I assume there could be multiple offerings for Speech to Text, one would use Azure Cognitive Services, one could be Whisper running on Hugging Face Inference endpoints and another one could be offered via AWS.
Do you have a manifest or something similar to express these dependencies in bricks?
(HF Inference endpoints for Whisper seems price competitive if you look at investigation by @philschmid here: https://www.philschmid.de/whisper-inference-endpoints - look at the bottom half).

100% agree, there should be multiple options, and Whisper should be one of them.
We're still trying to figure out how to best structure dependencies. If you have an idea or example of how you think such a manifest could look like, I'd be really interested in that!
Our rule of thumb is going to be: anything that can be self-hosted should be available as a brick that runs on your own machine; if it's available via API, then there will be some brick just coordinating the calls and using a user-provided token. This is where we differentiate "python functions" and "premium" (in the web interface)

I suppose the get_config, README, code_snippet does some of it. Looking at the GPT-3 summariser it has e.g. state, issue ID etc:
def get_config():
    return build_generator_premium_config(
        function=gpt3_tldr_summarization,
        input_example=INPUT_EXAMPLE,
        data_type="text",
        issue_id=195,
        state=State.PUBLIC
    )

Are you deriving these tags from the folder structure (premiums folder drives the Premium tag)?

For example progressive web apps, the browser needs some information about the app, examples of how it looks, how to run it, what it needs to run it: https://web.dev/add-manifest/
An advantage being that you can index manifest files without running the code, you could also offer a more declarative API plugin where you don't need to write any Python code but express the endpoints and inputs in a JSON manifest.
Not sure what fits your plans best, I was only curious in the context of contributing a brick that would depend on a specific compute resource or API and was looking for a way to express this in a meta-data kind of structure.
Such meta-data structure could look like:
{
    "name": "GPT-3 tl;dr; summarization",
    "description": "GPT-3 model which can be used to summarise text inputs.",
    "category": "generators",
    "dataType": "text",
    "issueId": 195,
    "state": "PUBLIC",
    "tier": "Premium",
    "dependencies": {
        "inputs": [
            {
                "name": "API_KEY",
                "label": "OpenAI API Key",
                "required": true,
                "type": "text",
                "description": "An API key for the OpenAI API. Can be provided by us or be obtained directly from OpenAI"
            },
            {
                "name": "model",
                "label": "GPT-3 model to use",
                "required": false,
                "default": "text-davinci-003",
                "type": "text",
                "description": "The model offered by OpenAI to use. Defaults to `text-davinci-003`."
            }
        ],
        "resources": [
            {
                "name": "openai",
                "label": "OpenAI API access",
                "type": "api",
                "description": "You need access to the OpenAI API to use this generator. This is subject to usage based charges by OpenAI which can be found here: https://beta.openai.com/pricing",
                "required": true
            }
        ]
    }
}

I'm not familiar with the integration path in Refinery, perhaps model is input at the same level as prompt.
Inputs and resources in this example bleeds a bit into one another. The dependency on OpenAI is implied with he API key and can be communicated there. It could look different if it was a requirement on AWS Recognition service. The resources would ask for AWS subscription details, IAM roles etc, and the inputs would be specific to the service you want to use.
But it probably needs more thinking to design this right 😄

Thank you, Martin! That's some excellent input. Yes, the tags are derived from the folder structure, meaning that premium functions are stored in a different location than the python functions that do not require an API key.
Currently, most of the information relevant to our CMS is stored in the config.py file, while we provide relevant information for the actual endpoint in the __init__.py file (which can contain placeholders for API keys or resource locations). For example, our brick module using the Azure cognitive services contains information like this:
from pydantic import BaseModel
from typing import List
import requests, uuid

INPUT_EXAMPLE = {
    "text": "Hallo, guten Tag.",
    "fromLang": ["de"],
    "toLang": ["en"],
    "apiKey": "<api-key-goes-here>",
    "region": "northeurope"
    }

class MicrosoftTranslatorModel(BaseModel):
    text: str
    fromLang: List[str]
    toLang: List[str]
    apiKey: str
    region: str

    class Config:
        schema_extra = {"example": INPUT_EXAMPLE}

Although combining all of this into a single meta-data structure like you suggested might also make sense for us at some point.
You said that you would like to contribute a brick that would depend on a specific compute resource/ API. Could you go into further detail on what brick you would like to build and what requirements such a module would have? Perhaps we could support this by providing a fitting structure for such a brick module.

Hi @martinnormark, quickly wanted to loop back just to let you know that we haven't forgotten about your suggestion. It makes perfect sense and we'll get back to it as soon as possible.
Currently, we're preparing a couple of major updates for our company that are crucial to our business model - and for the time being, we need to focus on it. Just to be fair and transparent :)


feat(core): Seccomp Profile for Kubearmor

Purpose of PR?:
Part of securing kubearmor in issue #1186
This PR introduces seccomp profile for both kubearmor and kubearmor-init container, by only allowing necessary syscalls needed by Kubearmor to run and function properly.
Does this PR introduce a breaking change?
Although there may not be any breaking change, we may need to be on the lookout incase we missed to whitelist any necessary syscall.
Additional information for reviewer? :
Couple of things that still needs to be done:
~Define custom Kubelet directory incase it is different than default  (Default is /var/lib/kubelet/seccomp)~ Also will be done later.  Seccomp will simply not load but kubearmor will run normally if path is different, and that's okay for now

[ ] Tests to see if seccomp is being enforced (?)

Runtime default seccomp for all other Kubearmor pods. Will be done in another PR/release
Checklist:

[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Commit has unit tests
[ ] Commit has integration tests

Add an option to not add seccomp to security context of daemonset based on config crd

Won't squash these 3 commits,  might need them for reference


Update ng2-smart-table.scss

making ng2-smart-table.scss empty enables users to define their own style.

@amineparis it's not a fix when you just delete our ng2-smart-table styles.

@lexzhukov  I can't see a better way to fix it. I am doing the same manually and it works great


fix #299, fix test timeout, as the message in the downstream test task is not flushed

duplicate of #342


Prevent common transfer mistakes in StandardToken

Maybe we should add checks to prevent:

sending to 0x0 address
sending to self (the token contract)

See: https://github.com/status-im/status-network-token/blob/2152b17aa2ef584a2aea95533c707a345c6ccf69/contracts/MiniMeToken.sol#L214

Why do you think this would be beneficial @maraoz ?
I tend to dislike deviations from standard ERC20 functions gas costs. Do you think those edge cases justify the sum of every agent losing a bit more gas in every transaction?
(Genuinely interested in getting everyone's opinion, these are not rhetorical questions 😄 )

Agree with your gas concerns @GNSPS.
The design direction we're taking is making StandardToken super secure and gas-intensive, and later we want to add a gas-optimized version with less security precautions.

I just realized the phrase "Agree with your gas concerns" can be very funny if taken out of context ^^

Laughed hard! 😂

Actually it depends on the case, sometimes it makes sense to spend ~8k gas for the above checks, however the StandardToken is definitely not the case.

Just for the record, a single require of a comparison between a state variable and a constant costs about 60 gas.

@maraoz we have been reviewing this issue, and while I agree on preventing sends to 0x0, I can think of some scenarios where the StandardToken is extended with additional functionality and is expected to hold some of its own tokens. WDYT about adding that restriction into a SaferToken (see https://github.com/OpenZeppelin/zeppelin-solidity/pull/447/), instead of on the Standard Token?

+1


jekyll(css): add experimental note

While working on #15194, I found out the "note" block design was not really welcoming for new users:

This PR adds a new note type called experimental that will look like this:

Also needs to upgrade Font Awesome because the vial icon is missing with the current release we have.
Not that I moved the Font Awesome library to an assets directory because accessing the resources from their css moved the fonts to a webfonts folder which is relative to their css. I didn't want to add another folder to root path of this repo as it's already bloated and I think it makes more sense to have the resources dedicated to the libraries in their respective folders so you know which css is linked to which font (same for javascript).
I think we should also do the same for other "assets" we have in css, js, favicons, fonts folders and move these into the assets folder in a follow-up.
Maybe also in the future use npm and a package.json to manage these dependencies. (cc @mark-dr)

I recall I did some testing for redesign these in https://github.com/docker/docker.github.io/pull/11641 as well

I recall I did some testing for redesign these in #11641 as well

Ah looks neat! I'm using admonition on personal repos and I think they look great: https://squidfunk.github.io/mkdocs-material/reference/admonitions/#supported-types

Yeah, my intent with that PR was to have a clear "box" for these (as some are quite lengthy), without being too much separate from the content (i.e., not a "in your face" background color, so that we also don't have to re-invent colour-schemes that "work" for each and every one of them). Also to make sure it's all just CSS, and not too much HTML markup needed.

@mark-dr Could you PTAL?

Thanks @crazy-max. Going forward, we need to use {:.experimental} to use the new style for experimental commands. Is this correct? Also, is there anything else we should do to get this style? TIA

Thanks @crazy-max. Going forward, we need to use {:.experimental} to use the new style for experimental commands. Is this correct? Also, is there anything else we should do to get this style? TIA

yes indeed, see https://github.com/docker/buildx/pull/1236

The changes look good to me on a technical level, but we should be careful about Docs drifting away from the design system. Our existing alerts are based on the Alerts in this figma doc:
https://www.figma.com/file/R0GyrsN8tRxJIbti0KY6S3/✨Components-%26-Patterns?node-id=2%3A8
In there, we use green to indicate success (i.e. the thing you just attempted was successful). Maybe this should be an info alert, or maybe even a "special" purple one. WDYT, @MCallaghanDocker?

See conversation here - it's currently leaning toward blue being the right colour for this.
https://docker.slack.com/archives/C0324PUQMFF/p1658928599667639

we should be careful about Docs drifting away from the design system. Our existing alerts are based on the Alerts in this figma doc:
https://www.figma.com/file/R0GyrsN8tRxJIbti0KY6S3/✨Components-%26-Patterns?node-id=2%3A8

Of course! Let me know what would work best for us.

In there, we use green to indicate success (i.e. the thing you just attempted was successful). Maybe this should be an info alert

IMO there are two patterns to take into account. There is callouts and actionable/story states. Callouts being passive like this "experimental" note and "success" for actionable ones or describing a story.

or maybe even a "special" purple one.

This one LGTM too.

@crazy-max, how about blue (i.e. the "info" colour), with the vial?

@crazy-max, how about blue (i.e. the "info" colour), with the vial?

Yes sgtm!

@mark-dr Here it is using the same palette as current info note.

Ok let's get this one in if ci ok


Can't setup a personal VPN from the app on versions prior to iOS 14

Your code works well on ios 14, but not on older version  (can't even connect to VPN server)

this is strange to hear because iOS didn't exist when I wrote this

this is strange to hear because iOS didn't exist when I wrote this

iOS did not exist?

iOS 14 – definitely did not exist that time
have you solved the issue, can you share the workaround?

But it works on iOS 14 (as I mentioned above). It  does not work on iOS 11-13

The reason was in the wrong config.
On iOS 14 they changed default
ikeSecurityAssociationParameters.integrityAlgorithm, ikeSecurityAssociationParameters.encryptionAlgorithm, ikeSecurityAssociationParameters.diffieHellmanGroup etc

@AntonBelousov could you make pr to fix this?

@AntonBelousov could you make pr to fix this?


Tomhaile/ch11997/sort child universes to show winning universe

https://app.clubhouse.io/augur/story/11997/sort-child-universes-to-show-winning-universe-at-top

force a fork,
migrate a little rep to each universe
verify that REP supply is ordered descending on account universe page.
finalize the fork and verify winning universe is at the top.

Coverage remained the same at 66.592% when pulling f4a1d4dd39a028df7ab76930f9575b2c7b1a6ea0 on tomhaile/ch11997/sort-child-universes-to-show-winning-universe into 5cfbba05016a308de8392999c101b985e0b04c87 on master.


DOCS-848: Replaces two or more whitespace lines with one

In partial fulfillment of https://tigera.atlassian.net/browse/DOCS-848
Removes extra blank lines, for two reasons:

it's cleaner
multiple lines are messing up our formatting in the new docs site

Preview: https://deploy-preview-6899--calico-master.netlify.app/about/about-calico

@bmckercher123

-4k whitespace lines, wow!


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_0f_k3xvinl/clone/recipe/meta.yaml:40: duplicate_key_in_meta_yaml: The recipe meta.yaml contains a duplicate key
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_b3rqyc2kcm/clone/recipe/meta.yaml:40: duplicate_key_in_meta_yaml: The recipe meta.yaml contains a duplicate key
Errors were found


Add new compiled node abi's

See https://github.com/mattrglobal/jsonld-signatures-bbs/issues/35 we need to expand the push-release pipelines list of published binaries.

Support added for node 10, 11 and 12 for all OS's except windows node 11 due to an issue with neon


Column wins are not always determined correctly

In some cases (seemingly at random) a column win will not be determined as such and play will continue.

Problem fixed.  Thank you @jdeesy!