Subpath imports only work for first element in array

Describe the bug
I'd like to convert my codebase from tsconfig paths and vite.js resolves to using import subpaths, but I don't want to start using extensions in all my imports in order to do so.  So, I've set up my package.json imports to look like this:
  "imports": {
    "#components/*": [
      "./src/components/*.ts",
      "./src/components/*.tsx",
      "./src/components/*/index.ts"
    ],
  },

TypeScript is able to use this to find type definitions for #components/foo whether the file actually ends in .ts, .tsx, or a barrel file is used.
However, Vite is not able to start in dev or complete a build, because it only looks at the first element in that array, and if it does not find it, will throw an error.
Reproduction
https://stackblitz.com/edit/vitejs-vite-tkzih5?file=src%2Fmain.ts
Steps to reproduce
You'll see the error when you load the reproduction.  Commenting out the import and uncommenting the working version, then restarting vite dev will work correctly.  The only difference between the two is the order of the patterns in the array in package.json.
System Info
sh: envinfo: command not found

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

After a bit more research, I see that it's possible only TypeScript supports the use of arrays like this, and node.js may not (at least it doesn't seem to be documented).  I would understand if Vite does not want to support this kind of syntax, though it would be frustrating for me as a user to find a different way to migrate my codebase (I'd likely need to add file extensions to thousands of imports).

Yeah we've discussed this at https://github.com/vitejs/vite/issues/4439#issuecomment-1465224035 before and concluded to not support it as it's not spec-compliant.

Thanks, that doesn't work for TypeScript, but this does seem to do the trick:
  "imports": {
    "#components/*": ["./src/components/*", "./src/components/*.ts"]
  }

The key is to set the extensionless star first, so that Vite finds it, and then all the other possible extensions afterwards, so that TypeScript finds it.

That's true, but it is allowed in the spec proposal: https://github.com/jkrems/proposal-pkg-exports/, even though Node chose a different approach.  And it's supported by Webpack as well.  Vite's module resolution (including ESM) has been a bit more lax than Node in the past, so it's not unheard of to diverge here as well.  Especially for those of us who have not been using extensions (though I recommend using them in new projects now).  There are other reasons that this fallback array can be useful, including a test mocking approach that Storybook is experimenting with.  I'd at least encourage the Vite team to keep an open mind and listen to users as they start to try out subpath imports, and maybe reconsider the decision if it becomes a point of friction.  Also, it would be great to clarify what kind of syntax is and isn't supported somewhere in the docs.  I had to use trial-and-error to find the approach above that works for both Vite and TypeScript.

but it is allowed in the spec proposal: https://github.com/jkrems/proposal-pkg-exports/

I don't think it does. It says:

Fallback arrays allow validation failures to continue checking the next item in the fallback array providing forwards compatiblitiy for new features in future based on extending these validation rules to new cases.

and the validation rules are:

The following validations are performed for an exports start to resolve:
The exports target must be a string and start with "./" (URLs and absolute paths are not currently supported but may be supported in future).

The exports target cannot backtrack below the package base.
Exports targets cannot map into a nested node_modules path.

For directory resolutions the following validations also apply:

Directory exports targets must end in a trailing "/".
Directory exports targets may not backtrack above the package base.
Directory exports subpaths may not backtrack above the target folder.

In the validation, it does not check whether the file exists or not.

it would be great to clarify what kind of syntax is and isn't supported somewhere in the docs.

I think it'd nice to add about the fallback array in the Node docs, then we can have a link to there.
Also I guess TypeScript's docs needs to be updated as well.

Thanks, it sounds like TypeScript's support is actually a bug, and Vite has the correct behavior, as much of a bummer as it might be.  👍


Key in KeyedMessage ignored when deciding partition

From personal testing and looking at the code for baseProducer, it looks like the key in KeyedMessage is not used for determining the partition of each message.
Is this correct? If so, what is the purpose of this key if it is not for determining the partition of a message?
Thanks in advance!

Can anyone confirm this:
const payload = { topic: 'Test', messages: new KeyedMessage('key_in_message','message1'), key: 'key_in_payload' };
The key_in_payload is used to decide the partition, but this key is ignored afterwards and is not sent on as part of the message.
The key_in_message is ignored when deciding the partition, but IS sent on as part of the message to the Kafka topic.
So essentially both need to be used.

I could be wrong on this but I think of the key as metadata about the message. In the kafka world it's optional but it can be used for partitioning-- it's up the the implementer of the partitioner.

Hi @michallevin,
you could achieve deterministic partition production per topic very very easily.
As @hyperlink said it should be up to the producer to deal with this.
Checkout this example to achieve a key-to-partition-determination:
getPartitionForKey(key, partitionCount = 0){

        if(typeof key !== "string"){
            return Promise.reject("key must be a valid string");
        }

        if(partitionCount === 0){
            partitionCount = this.partitionCount;
        }

        return Promise.resolve(murmur(key) % partitionCount);
    }

note that I am using const murmur = require("murmurhash").v3;

@hyperlink - I faced the same issue, on by more analysis I found the key must be a string only but earlier I was using integer value as a key, in that case "hashCode" function was always returning the same hash and due to which Keyed partition was not working for me.
I have created a PR, in which a key can always be converted to string to get the hash code for a given value. please check that out here -  https://github.com/SOHU-Co/kafka-node/pull/870

My testing revealed that the key in keyedMessage is not used.
I had to set the key and partitioner in payload.
However we just discovered that it doesn't appear to be keying the same as murmur2 with partitioner 3.

Partitioner 0 (default) and partitioner 3 (keyed) are not partitioning the same as Kafka Java.

I am having the same problem. So should we set the key even in the payload and not only in the keyedMessage ?

That worked for us.

for use as well!


Add a form for task creation

The user should be able to add a task through a form on the website.

should this be closed @giordano-lucas?


trim down run-time DimSpec for GenericPeek

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
@havardpe please review

@havardpe PTAL


Error when I open atom

hi?

+1 got the same error. Will look to fix and send PR in evening if I get a change

I think this is the problem - http://pipetree.com/qmacro/blog/2015/01/atom-snippets-tabs-and-cson-parsing/
If I get a chance, would implement it.

I'll try that
Enviado pelo meu Windows Phone

From: Divyendu<EMAIL_ADDRESS>Sent: 23/01/2015 16:56
To<EMAIL_ADDRESS>Cc: Luís<EMAIL_ADDRESS>Subject: Re: [ionic-atom-plugin] Error when I open atom (#3)
I think this is the problem - http://pipetree.com/qmacro/blog/2015/01/atom-snippets-tabs-and-cson-parsing/
If I get a chance, would implement it.

Reply to this email directly or view it on GitHub:
https://github.com/imsingh/ionic-atom-plugin/issues/3#issuecomment-71244797

I am little busy with my app promotion. I am also working on better snippets. Looking into this issue soon.

@luisrudge @divyenduz Thanks for pointing this out. Working on fix.


lgi.GLib.String('') does not work: bad argument #1 to 'pairs' (table expected, got string)

lgi = require('lgi')
s = lgi.GLib.String('')
/usr/share/lua/5.2/lgi/record.lua:123: bad argument #1 to 'pairs' (table expected, got string)
stack traceback:
[C]: in function 'pairs'
/usr/share/lua/5.2/lgi/record.lua:123: in function </usr/share/lua/5.2/lgi/record.lua:108>
(...tail calls...)
stdin:1: in main chunk
[C]: in ?

Just s = lgi.GLib.String() works, as does s = lgi.GLib.String({}).
It appears to be used like this in the tests: https://github.com/pavouk/lgi/blob/master/tests/dbus.lua#L102
My intention is to use https://developer.gnome.org/glib/stable/glib-Strings.html#g-string-hash in awesomeWM's lua interface.

This appears to work:
lgi.GLib.String():append("foo"):hash()

I'm not able to reproduce.  Your transcript looks like lgi was not able to associate g_string_new() with Glib.String class as an constructor, so default record/struct constructor will kick in (and this is the one which hates string constant as an argument).
What version of lgi are you using?  Do you have the locale (LC_ALL) set to something non-english?  If yes, are you able to reproduce even after setting LC_ALL=en_US.UTF8?  If this is the case, would lgi 'master' help - recently a fix for turkish locale went in, and this one could also be related to this problem.

I've been using lua-lgi:amd64 0.7.2-1 (Ubuntu Trusty).
After upgrading it this issue appears to be solved:

The following packages will be upgraded:
libglib2.0-0 [2.40.2-0ubuntu1 -> 2.42.0-2]  libglib2.0-0:i386 [2.40.2-0ubuntu1 -> 2.42.0-2] libglib2.0-bin [2.40.2-0ubuntu1 -> 2.42.0-2]  libglib2.0-dev [2.40.2-0ubuntu1 -> 2.42.0-2] lua-lgi [0.7.2-1 -> 0.8.0-2]


Added DHS (Dylib Hijeck Scanner)

Thank you for the contribution. It needed some fixes, so they were made in e425908c9d813df5ff04d9b3f08e58e5efacd63d. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

It's ok :) It was my first new cask

It was mostly fine (it was still functional), which is definitely good. Quick tip: run brew cask style --fix {{cask_name}} to fix common styling mistakes, prior to submission.

ok thank you, cause I am writing next one :+1: (Going for reinstall so want to have this apps)


Need for testimonials about using VS Code & Z Open Editor

Testimonials
Hi,
This may not be the purpose of the GitHub site to make this request, but I have not identified other ways to do so.
If my request is a problem for the administrators of the site, I authorize them to mean it in response to this message, and to close this issue.
We are in the process of defining our new COBOL development workshop, which should replace our current solution based on a COBOL code generator (IBM VisualAge Pacbase, in use for us since 1988, still active, but no longer maintained).
We are convinced of the qualities of the VS Code product and the Z Open Editor extension, and that we are making the right choice by choosing these solutions. However, the highest authorities of our company ask us to justify our choices and to validate them with major market compagnies.
These solutions are recent and not widely used, at least in France, and we have not succeeded at this time in finding users testimonials who have already implemented these solutions and already use them on a daily basis.
I am therefore asking the users of this GitHub site who could give us their testimony in the use of the VS Code and Z Open Editor solutions in a more advanced context than ours:

what feeling on the part of the users (developers),
what productivity obtained by developers compared to another earlier solution,
what difficulties may have been encountered in setting up the solution,
what additional developments were necessary to finalize the solution,
what are the potential risks, on the products, and on their implementation, on the impact on users,
etc.

Some information about our context:

between 600 and 700 developers, 50% in service with a significant turnover,
between 300 and 400 active developers per day on COBOL coding activities,
around 30,000 COBOL programs active in production, (note: without any COPYBOOK because it does not make sense with the use of a code generator ... we have work to do on adapting this legacy to maintain it in a traditional way),
around 1,800 applications, each application to be managed in its Git repository,
COBOL (V6) /  Endevor / CICS / Db2 / MQ technical background

Answers can be provided on this GitHub site, if the administrators authorize it, or by personal messaging.
Thanking in advance the people who will be able to answer my request.

Thanks. We would definitely be interested in responses to these questions as well.


Contrast errors on the learning resources page

Describe the bug
Contrast errors on the #tags below the learning resources cards
To Reproduce
Steps to reproduce the behavior:

Install the WAVE browser extension either chrome or firefox would be cool.
Enter the protege URL => https://protege.dev/learning-resources
Go the wave extension and active it by clicking on its icon
You will see contrast errors on the detail tab

Expected behavior
There should be no contrast errors
Screenshots

Desktop (please complete the following information):
N/A
Smartphone (please complete the following information):
N/A
Additional context
Add any other context about the problem here.
No

Closed with comment on #208


sorting should be numerical rather than lexical.

Here sorting should be numerical rather than lexical.

Moreover, number are usually right-aligned, and preferably there should be an option in the GUI for setting the number of significant digits.

+1


Use a nested structure for docker info

This makes sure things still work with es2 while the field names remain
the same
Fixes #11
Alternative to #12

:+1:

+1

Thanks for fixing this.


Silent renew stops when reloading the page

I'm working in a jsclient (SPA), the automatic silent renew is working fine but when I reload the page (e.g: pressing F5) it does not anymore, I can even see the valid token in the storage but it seems that the userManager does not "realize" that it is going to expire.
This scenario worked without any problem with the oidc-token-manager (I'm migrating). Is it about some new validation or a bug that the timer is turned off after the page-reload?
Best regards.

Hi,
I think I'm experiencing the exact same issue. My application is a React based SPA, with the Oidc.UserManager being initialised in the entry index.js file. I've enabled logging of info messages, and can see that on the first load of the application UserManager and AccessTokenEvents are configured and timers are setup to handle token refresh. At this point tokens are renewed as expected.
If I then refresh the page (e.g. CTRL+F5), a far smaller set of messages are logged and from this point no attempts to refresh the token are ever made. I've included the post CTRL+F5 logging output below, and can provide more logs as required (please excuse the anonymised URL / Client strings!)
Thanks

automaticSilentRenew is configured, setting up silent renew
oidc-client.min.js:26UserManager.getUser
oidc-client.min.js:26_loadUser
oidc-client.min.js:26WebStorageStateStore.get user:https://www.dummy.co.uk:dummy-ui
oidc-client.min.js:26UserManager.getUser
oidc-client.min.js:26_loadUser
oidc-client.min.js:26WebStorageStateStore.get user:https://www.dummy.co.uk:dummy-ui
oidc-client.min.js:26UserManager.getUser
oidc-client.min.js:26_loadUser
oidc-client.min.js:26WebStorageStateStore.get user:https://www.dummy.co.uk:dummy-ui
oidc-client.min.js:26user storageString loaded
oidc-client.min.js:26User.fromStorageString
oidc-client.min.js:26user storageString loaded
oidc-client.min.js:26User.fromStorageString
oidc-client.min.js:26user storageString loaded
oidc-client.min.js:26User.fromStorageString
3oidc-client.min.js:26user loaded

Possibly. I'll have a look when I can.

The problem extends when I open a new tab, one tab does the renewal and the other not. So, if I close the first one, the second expires soon.

Same problem for me as well, after the refresh the 'Events.load' don't show up in the log.
Initial page load log:
automaticSilentRenew is configured, setting up silent renew
…REMOVED SOME LOG ITEMS...
claims processed
got signin response
_storeUser storing user
User.toStorageString
WebStorageStateStore.set user:https://localidentity.XXX.it/identity/:XXX
user stored
UserManagerEvents.load
AccessTokenEvents.load
canceling existing access token timers
access token present, remaining duration: 10799
registering expiring timer in: 10699
registering expired timer in: 10800
Raising event: User loaded

Log on Page Refresh (F5)
automaticSilentRenew is configured, setting up silent renew
UserManager.getUser
_loadUser
WebStorageStateStore.get user:https://localidentity.XXX.it/identity/:XXX
user storageString loaded
User.fromStorageString
user loaded

I've not looked at this yet (I'm traveling, but I will on Friday), but I suspect when the user is loaded from the local store we're simply missing the check to initiate the timer.

I get the same in an angular app.
@brockallen yes, the timer is only initiated after a fresh sign in without a user in storage.

Ok, fixing this issue: https://github.com/IdentityModel/oidc-client-js/issues/43 has caused this one. I'll see if I can thread this correctly...

Ok, I pushed a fix under 1.1.0-beta.3. Very sorry for how long it took me to get to this -- as always, super busy.

@brockallen No need to apologise - it's much appreciated you looked at the issue at all! I've just tried the fix locally and after my initial tests it seems to work perfectly for me. If there is any further information / testing I can provide please let me know.
Thanks for the fix!

Ok, thanks. I'll close this now.

@brockallen thans for your response. But the problem persist in my case with the beta3. @JMonono , @MichielNL83 , @mbeckenbach have you tested this new release? is it working ok for you?

@Wilsonmg from the looks of it, it seems to be working correctly now. User loads correctly from storage and AccesTokenEvents timers are running.
I'm not in the office right now so i can't connect to my local IdentityServer with short lived tokens so i haven't tested the actual refresh.

@Wilsonmg I can confirm that beta3 fixed the issue for me as well. On first load of the application and after refreshing the page UserManager and AccessTokenEvents are configured and timers are setup to handle token refresh.

@Wilsonmg maybe you have a cached version?

Thank you all. @brockallen it might be that... I haven't had enough time to work more on this again, I'll be back when I can.
Regards and thanks for the fix.


Install security plugin from individual artifacts

Description
Tries to create a local cluster using the demo certificates that the security plugin provides. The goal of this change is to run security tests directly instead of through using the docker image. It pulls the individual artifacts from the snapshot repo and tries to install them if security is enabled.
Right now, it is able to bring up a cluster*. However, the wait for cluster health yellow checks are failing, so the tests are not able to run. Sharing here to potentially get assistance debugging and also get initial feedback if this is a good approach to take for #901. Code of interest is: https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchCluster.java#L570-L579. Error message I am getting:
* What went wrong:
Execution failed for task ':run'.
> `cluster{::integTest}` failed to wait for cluster health yellow after 40 SECONDS
    IO error while waiting cluster
    401 Unauthorized

To run cluster, first comment out: https://github.com/jmazanec15/k-NN-1/blob/issue-901/build.gradle#L382-L383 and then:
./gradlew run -Dsecurity.enabled=1

curl "https://admin:admin@localhost:9200/_cluster/health?wait_for_nodes=>=1&wait_for_status=yellow" -k --cert <PATH>/k-NN-1/build/testclusters/integTest-0/config/admin-cert.pem --key <PATH>/k-NN-1/src/test/resources/security/admin-key.pem

Issues Resolved
#901
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Windows is failing with flaky test: https://github.com/opensearch-project/k-NN/issues/1368.

https://github.com/opensearch-project/k-NN/actions/runs/7391155507/job/20107434607?pr=1307 unrelated as well.


Version Number

Hi!
I am using Nlog 4.5.1 in my application.  The version number and is identical to earlier versions of Nlog 4.0
I suppose this would not matter much if the older version was not in the GAC.  When an older version of Nlog is in the GAC, it becomes a problem.  Here is what i found:

the assembly in the GAC takes precedence and loads first - which causes my application to crash.
Windows Installer does not install the newer version in the GAC because the version numbers (and token ?) are identical.
Binding redirects are not possible - same version number.

to work around the issue, i had to uninstall my application and the other application.  That removed NLog from the GAC.
Then i installed my application, followed by the older application.  Both work OK.
I am now stuck on this version of NLog until you support changing the version number.
If I must upgrade to a newer version of NLog, i must uninstall and reinstall both applications, or persuade the author of the application to not use the GAC.
Please consider updating the version number in each release.
Regards
Habib
ps.  you can see more info here:
https://stackoverflow.com/questions/54548591/nlog-system-methodaccessexception-only-in-vmware-horizon-view-client

Hi,
This is by design, see also https://github.com/NLog/NLog/issues/2939 and #1765
We know this system isn't perfect, but it's the best option in our opinion. Also other libraries are using this approach (e.g. JSON.NET)

The version number and is identical to earlier versions of Nlog 4.0

The assembly version will be same for the whole major version, but the file version will be updated each release

If there is a new - and better - solution nowadays, we are open for proposals

Closing this due to inactivity. Please let us know if this still an issue and please provide the requested info -
thanks!


Does this webview support Android ?

I try to build with gomobile , but I receive these error message:
gomobile: go build -buildmode=c-shared -o /tmp/gomobile-work-845335157/lib/armeabi-v7a/libapptest.so apptest failed: exit status 2
github.com/zserge/webview
In file included from webview.cc:3:
In file included from ../github.com/zserge/webview/webview.h:419:
In file included from /usr/include/gtk-3.0/gtk/gtk.h:30:
In file included from /usr/include/gtk-3.0/gdk/gdk.h:30:
In file included from /usr/include/gtk-3.0/gdk/gdkconfig.h:13:
In file included from /usr/include/glib-2.0/glib.h:30:
In file included from /usr/include/glib-2.0/glib/galloca.h:32:
/usr/include/glib-2.0/glib/gtypes.h:463:3: error: static_assert failed due to requirement 'sizeof(unsigned long long) == sizeof(unsigned long)' "Expression evaluates to false"
/usr/include/glib-2.0/glib/gmacros.h:742:31: note: expanded from macro 'G_STATIC_ASSERT'

This does not support Android at the moment.

I have uploaded some code to implement Android support, also with a project template.
It is not so good yet, but it can be tested now, so use it with care.

It's a great job! I am writing my app in native mode of android now, I will implements it with this webview of golang after the java version finished. Thank u very much !

nice job.
Does anyone know if IOS is or is not supported with this project ?

I'm pretty sure it doesn't support iOS now. I don't have any Mac or XCode to test it though.

Closing this as we can track this issue in the PR by @rainbyte https://github.com/webview/webview/pull/426

This does not support Android at the moment.
I decided to make my own temporary thing for Go Android webviews because of this: https://github.com/pufflegamerz/gowebview
(Shameless self-promotion)

I'm following yours. Hopefully apps perform well on lower end phones with this.


'Quick Open' doesn't show any node_modules folders -- regression in 1.17.1

VSCode Version: Code 1.17.1 (1e9d36539b0ae51ac09b9d4673ebea4e447e5353, 2017-10-10T14:10:17.189Z)
OS Version: Darwin x64 16.7.0
Extensions:

Extension
Author (truncated)
Version

vscode-svgviewer
css
1.4.3

vscode-eslint
dba
1.3.2

githistory
don
0.2.3

gitlens
eam
5.6.5

json-tools
eri
1.0.2

prettier-vscode
esb
0.24.0

flow-for-vscode
flo
0.7.2

debugger-for-chrome
msj
3.3.1

Repro project: vscode-test.zip
Steps to Reproduce:

Unzip the attached file, open the resulting vscode-test folder in VS Code.
Launch quick-open (Cmd+P)
Type in 'find'

I expect quick-open to find the 'Code/node_modules/find_this.js' file, but it doesn't.  This worked in VSCode 1.16, and no longer works in 1.17.1
Some background:  Our project has '/node_modules' for external dependencies, plus a '/Code/node_modules' which contains importable internal code.  Yes I know this is not an ideal structure :)
We have configured .vscode/settings to exclude /node_modules, but include /Code/node_modules for searching and quick-open, as in the attached project.  This worked in 1.16 but no longer works.
I am happy to provide more information, or debug this myself if you point me in the right direction.
Thank you for making VSCode, it's a great product and I enjoy using it!
Reproduces without extensions: Yes

Ah, one more thing to note -- everything works as expected in the file tree and for searching.  The Quick Open behaviour is harder to understand, it seems to be a mixture of search.exclude and files.exclude, and changing each of them impacts the Quick Open list in unpredictable ways.

Will check what text search does differently here. From the settings:
{
    "search.exclude": {
        "node_modules": true,
        "Code/node_modules": false,
        "**/node_modules": false
    },

    "files.exclude": {
        "node_modules": true,
        "Code/node_modules": false,
        "**/node_modules": false
    }
}

@roblourens It seems -g !node_modules is like -g !**/node_modules. Should I just add a / when the pattern does not start with *? (Same issue occurs with *.js.)

Oh yeah, I think you should. Search now resolves those patterns to absolute paths, so it will have the right behavior. But before I was doing that, I was doing a search out of the workspace folder as cwd, and I'm pretty sure I did exactly that, prepend / when needed to get the expected behavior.

Spectacular -- you guys are heroes. Thank you very much!


feat(text-editor): add disableAutoReformat prop & refactor to use DataLoader for loading ux

To Reviewers

[ ] Skipping review is not a problem (style, chore ONLY)
[ ] Not that difficult

Type of Change

[ ] New feature
[ ] Bug fixes
[x] Feature improvement

[ ] These changes require a usage change

[x] Others (performance improvement, refactoring, CI/CD, etc.)

Checklist

[x] Updated Storybook documents
[x] Tested with console

Description

Add disableAutoReformat prop

https://user-images.githubusercontent.com/26986739/191896917-66246dc8-5ed5-43ab-9e67-16d9748441a0.mov

Use DataLoader component for loading UX

https://user-images.githubusercontent.com/26986739/191893527-4adffc8a-9460-4723-989a-f784007983f2.mov
Things to Talk About

:tada: This PR is included in version 1.1.0-beta.394 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


YouTube [PCSA00062]

App summary

App name: YouTube
App serial: PCSA00062
App version: 1.00

Vita3K summary

Version: v0.2.0
Build number: 3691
Commit hash: https://github.com/vita3k/vita3k/commit/31826697
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary

Tested by: Benjamin Toledo
OS: Windows 11
CPU: AMD Ryzen 5 4600G
GPU: AMD Radeon(TM) Graphics (Vega 7 integrated graphics)
RAM: 16 GB

Issues

Opens, but doesn't connect. Same as the other versions

Screenshots

Log
vita3k.log
Recommended labels

Ingame +

This should probably amended to either 'Menu' or 'Ingame -' given you can't actually do anything with it. Also, either 'online-only' or 'networking bug' should be added.


Exclude from coverage exception line

This could happen accidentally, no need to cover that.

@blueyed take a look a this trivial PR please 🙏

@blueyed thanks!


(PUP-4930) Improve instances error message

CLA signed by all contributors.

CLA signed by all contributors.


MVC.Testing incompatible with conventional routing in current MVC apps

See also #7615. This issue appears unrelated though the scenarios are similar. In particular, this one is about conventional routing rather than redoing pre-compilation (and failing).
Repro Steps
The following is similar to the Preview 1 functional testing instructions but done In Visual Studio using Preview 2 bits:

Create new ASP.NET Core Web Application

Later steps make more sense if "Create directory for solution" is enabled

Choose Web Application (Model-View-Controller) i.e. an MVC app (not Razor) and your favourite authentication scheme
Hit F5 or Ctrl-F5 to confirm app works fine
Add an xUnit Test Project (.NET Core) to the solution
Edit test project file to bump up the target framework: <TargetFramework>netcoreapp2.1</TargetFramework>

current Microsoft.AspNetCore.App package used in web application project is not compatible with a lower TFM

Add a reference from the test project to the web application project
Use Manage NuGet Packages to add a Microsoft.AspNetCore.Mvc.Testing package dependency to the test project

choose same version e.g. 2.1.0-preview2-30552 as Microsoft.AspNetCore.App package in the web application project

Edit UnitTest1 to perform a simple test:using System.Net;
using System.Net.Http;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Mvc.Testing;
using RazorApp1;
using Xunit;

namespace FunctionalTest
{
    public class UnitTest1 : IClassFixture<WebApplicationFactory<Startup>>
    {
        private readonly HttpClient _client;

        public UnitTest1(WebApplicationFactory<Startup> factory)
        {
            _client = factory.CreateDefaultClient();
        }

        [Fact]
        public async Task Test1()
        {
            // Arrange & Act
            var response = await _client.GetAsync("https://localhost/");

            // Assert
            Assert.Equal(HttpStatusCode.OK, response.StatusCode);
        }
    }
}

use "http://localhost" if you chose not to include HTTPS support when creating the web application project

Use Test Explorer to Run All tests

Expected
The one test succeeds.
Actual
Test fails because the site returns a 404 status code.
Versions
Microsoft Visual Studio Enterprise 2017: 15.7.0 Preview 3.0 [27604.0.d15.7]
.NET Core SDK: 2.1.300-preview2-008523
Microsoft.NETCore.App: 2.1.0-preview2-26403-06
Microsoft.AspNetCore.App: 2.1.0-preview2-30552
Microsoft.AspNetCore.Mvc.Testing: 2.1.0-preview2-30552

Similar scenario using .NET Framework 4.6.1 succeeds. Major differences in successful case are the TFM and use of .NET Framework-compatible packages (not Microsoft.AspNetCore.App).

Found while verifying aspnet/Release#257.

Expected an attribute routing scenario to get much further or even succeed. But, above setup also fails when action has [HttpGet("/api/test")] for example.

@kichalla, can you please look into this? Thanks!

/cc: @danroth27

I suspect this is related to the application part changes. @pranavkm

Investigated this further. In 2.1.0-preview1, this worked because we always returned a part for the EntryAssembly regardless of if it depended on Mvc:
https://github.com/aspnet/Mvc/blob/2.1.0-preview1-final/src/Microsoft.AspNetCore.Mvc.Core/Internal/DefaultAssemblyPartDiscoveryProvider.cs#L78
The problem resurfaces if the web application under test references a class library which references Mvc. Essentially any reference to the shared runtime or one of it's dependencies gets erased and is unreliable. It's super weird how it works. Maybe this is yet form of https://github.com/dotnet/sdk/issues/2092.
Anyway, the fix here which seems like the right thing to do is to use CompileLibraries rather than RuntimeLibraries to determine if a library depends on Mvc. It also allows us to remove this - https://github.com/aspnet/Mvc/commit/5e019bd707497b0d28a7387c7ed66447a1907d59 - since querying the compile libraries correctly states that Microsoft.AspNetCore.All depends on Microsoft.AspNetCore.Mvc.
cc @eerhardt to get his thoughts on this.
cc @JunTaoLuo for the Microsoft.AspNetCore.All stuff

Filed https://github.com/aspnet/Mvc/issues/7632 to track verifying this E2E once we have a shared runtime

Is there a workaround to this whilst awaiting the next release?

@tbertenshaw @pranavkm fixed this in the next release. In the meantime, you can change affected projects to reference individual packages e.g.
<PackageReference Include="Microsoft.AspNetCore" Version="2.1.0-preview2-final" />
<PackageReference Include="Microsoft.AspNetCore.CookiePolicy" Version="2.1.0-preview2-final" />
<PackageReference Include="Microsoft.AspNetCore.HttpsPolicy" Version="2.1.0-preview2-final"/>
<PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.1.0-preview2-final" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.ViewCompilation" Version="2.1.0-preview2-final" PrivateAssets="All" />
<PackageReference Include="Microsoft.AspNetCore.StaticFiles" Version="2.1.0-preview2-final" />

instead of a shared runtime
<PackageReference Include="Microsoft.AspNetCore.App" Version="2.1.0-preview2-final" />

Still get razor errors, do I need to reference all in the test and the web projects?

@tbertenshaw Can you post the errors here? That way we can identify what references might be missing

Test Name:	Timbo.Spike.Web.Functional.Tests.AnonUserHomePageActions.CanGetAboutPage
Test FullName:	Timbo.Spike.Web.Functional.Tests.AnonUserHomePageActions.CanGetAboutPage
Test Source:	C:\dev\github\Timbo\Timbo.Core\src\Tests\Timbo.Spike.Web.Functional.Tests\AnonUserHomePageActions.cs : line 37
Test Outcome:	Failed
Test Duration:	0:00:03.865

Result StackTrace:
at Microsoft.AspNetCore.Mvc.Razor.Internal.RazorViewCompiler.CompileAndEmit(RazorCodeDocument codeDocument, String generatedCode)
   at Microsoft.AspNetCore.Mvc.Razor.Internal.RazorViewCompiler.CompileAndEmit(String relativePath)
   at Microsoft.AspNetCore.Mvc.Razor.Internal.RazorViewCompiler.OnCacheMiss(String normalizedPath)
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.RazorPages.Internal.DefaultPageLoader.Load(PageActionDescriptor actionDescriptor)
   at Microsoft.AspNetCore.Mvc.RazorPages.Internal.PageActionInvokerProvider.OnProvidersExecuting(ActionInvokerProviderContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ActionInvokerFactory.CreateInvoker(ActionContext actionContext)
   at Microsoft.AspNetCore.Mvc.Internal.MvcAttributeRouteHandler.<>c__DisplayClass12_0.<RouteAsync>b__0(HttpContext c)
   at Microsoft.AspNetCore.Builder.RouterMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.TestHost.HttpContextBuilder.<>c__DisplayClass10_0.<<SendAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.TestHost.ClientHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.FinishSendAsyncBuffered(Task`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)
   at Timbo.Spike.Web.Functional.Tests.AnonUserHomePageActions.CanGetAboutPage() in C:\dev\github\Timbo\Timbo.Core\src\Tests\Timbo.Spike.Web.Functional.Tests\AnonUserHomePageActions.cs:line 40
--- End of stack trace from previous location where exception was thrown ---
Result Message:
Microsoft.AspNetCore.Mvc.Razor.Compilation.CompilationFailedException : One or more compilation failures occurred:
boyllm3c.oka(4,41): error CS0234: The type or namespace name 'Razor' does not exist in the namespace 'Microsoft.AspNetCore' (are you missing an assembly reference?)
boyllm3c.oka(5,44): error CS0234: The type or namespace name 'RazorPages' does not exist in the namespace 'Microsoft.AspNetCore.Mvc' (are you missing an assembly reference?)
boyllm3c.oka(4,82): error CS0518: Predefined type 'System.Type' is not defined or imported
boyllm3c.oka(4,122): error CS0518: Predefined type 'System.String' is not defined or imported
boyllm3c.oka(4,145): error CS0518: Predefined type 'System.String' is not defined or imported
boyllm3c.oka(5,89): error CS0518: Predefined type 'System.String' is not defined or imported
boyllm3c.oka(5,113): error CS0518: Predefined type 'System.Type' is not defined or imported
boyllm3c.oka(9,11): error CS0246: The type or namespace name 'System' could not be found (are you missing a using directive or an assembly reference?)
boyllm3c.oka(10,11): error CS0246: The type or namespace name 'System' could not be found (are you missing a using directive or an assembly reference?)
boyllm3c.oka(11,11): error CS0246: The type or namespace name 'System' could not be found (are you missing a using directive or an assembly reference?)
boyllm3c.oka(12,11): error CS0246: The type or namespace name 'System' could not be found (are you missing a using directive or an assembly reference?)
boyllm3c.oka(15,36): error CS0234: The type or namespace name 'ViewFeatures' does not exist in the namespace 'Microsoft.AspNetCore.Mvc' (are you missing an assembly reference?)
boyllm3c.oka(31,35): error CS0234: The type or namespace name 'Razor' does not exist in the namespace 'Microsoft.AspNetCore' (are you missing an assembly reference?)
boyllm3c.oka(32,35): error CS0234: The type or namespace name 'Razor' does not exist in the namespace 'Microsoft.AspNetCore' (are you missing an assembly reference?)
boyllm3c.oka(31,78): error CS0518: Predefined type 'System.String' is not defined or imported
boyllm3c.oka(31,87): error CS0518: Predefined type 'System.String' is not defined or imported
boyllm3c.oka(31,132): error CS0518: Predefined type 'System.String' is not defined or imported
boyllm3c.oka(32,78): error CS0518: Predefined type 'System.String' is not defined or imported
boyllm3c.oka(32,87): error CS0518: Predefined type 'System.String' is not defined or imported
boyllm3c.oka(32,132): error CS0518: Predefined type 'System.String' is not defined or imported
boyllm3c.oka(33,65): error CS0234: The type or namespace name 'RazorPages' does not exist in the namespace 'Microsoft.AspNetCore.Mvc' (are you missing an assembly reference?)
boyllm3c.oka(36,67): error CS1983: The return type of an async method must be void, Task or Task<T>
boyllm3c.oka(36,39): error CS0400: The type or namespace name 'System' could not be found in the global namespace (are you missing an assembly reference?)
boyllm3c.oka(70,49): error CS0234: The type or namespace name 'ViewFeatures' does not exist in the namespace 'Microsoft.AspNetCore.Mvc' (are you missing an assembly reference?)
boyllm3c.oka(70,118): error CS0518: Predefined type 'System.Void' is not defined or imported
boyllm3c.oka(72,49): error CS0234: The type or namespace name 'IUrlHelper' does not exist in the namespace 'Microsoft.AspNetCore.Mvc' (are you missing an assembly reference?)
boyllm3c.oka(72,71): error CS0518: Predefined type 'System.Void' is not defined or imported
boyllm3c.oka(74,49): error CS0234: The type or namespace name 'IViewComponentHelper' does not exist in the namespace 'Microsoft.AspNetCore.Mvc' (are you missing an assembly reference?)
boyllm3c.oka(74,87): error CS0518: Predefined type 'System.Void' is not defined or imported
boyllm3c.oka(76,59): error CS0234: The type or namespace name 'IJsonHelper' does not exist in the namespace 'Microsoft.AspNetCore.Mvc.Rendering' (are you missing an assembly reference?)
boyllm3c.oka(76,83): error CS0518: Predefined type 'System.Void' is not defined or imported
boyllm3c.oka(78,59): error CS0234: The type or namespace name 'IHtmlHelper<>' does not exist in the namespace 'Microsoft.AspNetCore.Mvc.Rendering' (are you missing an assembly reference?)
boyllm3c.oka(78,71): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(78,71): error CS0246: The type or namespace name 'AboutModel' could not be found (are you missing a using directive or an assembly reference?)
boyllm3c.oka(78,95): error CS0518: Predefined type 'System.Void' is not defined or imported
boyllm3c.oka(79,49): error CS0234: The type or namespace name 'ViewFeatures' does not exist in the namespace 'Microsoft.AspNetCore.Mvc' (are you missing an assembly reference?)
boyllm3c.oka(79,81): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(79,81): error CS0246: The type or namespace name 'AboutModel' could not be found (are you missing a using directive or an assembly reference?)
boyllm3c.oka(80,16): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(80,16): error CS0246: The type or namespace name 'AboutModel' could not be found (are you missing a using directive or an assembly reference?)
boyllm3c.oka(36,67): error CS0115: 'Pages_About.ExecuteAsync()': no suitable method found to override
boyllm3c.oka(69,58): error CS0012: The type 'Attribute' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
boyllm3c.oka(69,10): error CS0518: Predefined type 'System.Void' is not defined or imported
boyllm3c.oka(71,58): error CS0012: The type 'Attribute' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
boyllm3c.oka(71,10): error CS0518: Predefined type 'System.Void' is not defined or imported
boyllm3c.oka(73,58): error CS0012: The type 'Attribute' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
boyllm3c.oka(73,10): error CS0518: Predefined type 'System.Void' is not defined or imported
boyllm3c.oka(75,58): error CS0012: The type 'Attribute' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
boyllm3c.oka(75,10): error CS0518: Predefined type 'System.Void' is not defined or imported
boyllm3c.oka(77,58): error CS0012: The type 'Attribute' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
boyllm3c.oka(77,10): error CS0518: Predefined type 'System.Void' is not defined or imported
boyllm3c.oka(44,13): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(44,13): error CS0103: The name 'BeginContext' does not exist in the current context
boyllm3c.oka(44,26): error CS0518: Predefined type 'System.Int32' is not defined or imported
boyllm3c.oka(44,30): error CS0518: Predefined type 'System.Int32' is not defined or imported
boyllm3c.oka(44,33): error CS0518: Predefined type 'System.Boolean' is not defined or imported
boyllm3c.oka(45,13): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(45,13): error CS0103: The name 'WriteLiteral' does not exist in the current context
boyllm3c.oka(45,26): error CS0518: Predefined type 'System.String' is not defined or imported
boyllm3c.oka(46,13): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(46,13): error CS0103: The name 'EndContext' does not exist in the current context
boyllm3c.oka(47,13): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(47,13): error CS0103: The name 'BeginContext' does not exist in the current context
boyllm3c.oka(47,26): error CS0518: Predefined type 'System.Int32' is not defined or imported
boyllm3c.oka(47,30): error CS0518: Predefined type 'System.Int32' is not defined or imported
boyllm3c.oka(47,34): error CS0518: Predefined type 'System.Boolean' is not defined or imported
boyllm3c.oka(53,13): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(53,13): error CS0103: The name 'EndContext' does not exist in the current context
boyllm3c.oka(54,13): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(54,13): error CS0103: The name 'BeginContext' does not exist in the current context
boyllm3c.oka(54,26): error CS0518: Predefined type 'System.Int32' is not defined or imported
boyllm3c.oka(54,30): error CS0518: Predefined type 'System.Int32' is not defined or imported
boyllm3c.oka(54,34): error CS0518: Predefined type 'System.Boolean' is not defined or imported
boyllm3c.oka(55,13): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(55,13): error CS0103: The name 'WriteLiteral' does not exist in the current context
boyllm3c.oka(55,26): error CS0518: Predefined type 'System.String' is not defined or imported
boyllm3c.oka(56,13): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(56,13): error CS0103: The name 'EndContext' does not exist in the current context
boyllm3c.oka(57,13): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(57,13): error CS0103: The name 'BeginContext' does not exist in the current context
boyllm3c.oka(57,26): error CS0518: Predefined type 'System.Int32' is not defined or imported
boyllm3c.oka(57,31): error CS0518: Predefined type 'System.Int32' is not defined or imported
boyllm3c.oka(57,35): error CS0518: Predefined type 'System.Boolean' is not defined or imported
boyllm3c.oka(63,13): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(63,13): error CS0103: The name 'EndContext' does not exist in the current context
boyllm3c.oka(64,13): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(64,13): error CS0103: The name 'BeginContext' does not exist in the current context
boyllm3c.oka(64,26): error CS0518: Predefined type 'System.Int32' is not defined or imported
boyllm3c.oka(64,31): error CS0518: Predefined type 'System.Int32' is not defined or imported
boyllm3c.oka(64,35): error CS0518: Predefined type 'System.Boolean' is not defined or imported
boyllm3c.oka(65,13): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(65,13): error CS0103: The name 'WriteLiteral' does not exist in the current context
boyllm3c.oka(65,26): error CS0518: Predefined type 'System.String' is not defined or imported
boyllm3c.oka(66,13): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(66,13): error CS0103: The name 'EndContext' does not exist in the current context
boyllm3c.oka(36,67): error CS0161: 'Pages_About.ExecuteAsync()': not all code paths return a value
boyllm3c.oka(79,183): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(79,183): error CS0103: The name 'PageContext' does not exist in the current context
boyllm3c.oka(79,139): error CS0234: The type or namespace name 'ViewFeatures' does not exist in the namespace 'Microsoft.AspNetCore.Mvc' (are you missing an assembly reference?)
boyllm3c.oka(79,171): error CS0518: Predefined type 'System.Object' is not defined or imported
boyllm3c.oka(79,171): error CS0246: The type or namespace name 'AboutModel' could not be found (are you missing a using directive or an assembly reference?)
C:\dev\github\Timbo\Timbo.Core\src\_web\Timbo.Spike.Web\Pages\_ViewImports.cshtml(1,28): error CS0234: The type or namespace name 'Identity' does not exist in the namespace 'Microsoft.AspNetCore' (are you missing an assembly reference?)
C:\dev\github\Timbo\Timbo.Core\src\_web\Timbo.Spike.Web\Pages\_ViewImports.cshtml(3,20): error CS0234: The type or namespace name 'Data' does not exist in the namespace 'Timbo.Spike' (are you missing an assembly reference?)
C:\dev\github\Timbo\Timbo.Core\src\_web\Timbo.Spike.Web\Pages\About.cshtml(4,14): error CS0518: Predefined type 'System.String' is not defined or imported
C:\dev\github\Timbo\Timbo.Core\src\_web\Timbo.Spike.Web\Pages\About.cshtml(4,25): error CS0518: Predefined type 'System.String' is not defined or imported
C:\dev\github\Timbo\Timbo.Core\src\_web\Timbo.Spike.Web\Pages\About.cshtml(6,1): error CS0518: Predefined type 'System.Object' is not defined or imported
C:\dev\github\Timbo\Timbo.Core\src\_web\Timbo.Spike.Web\Pages\About.cshtml(6,1): error CS0103: The name 'Write' does not exist in the current context
C:\dev\github\Timbo\Timbo.Core\src\_web\Timbo.Spike.Web\Pages\About.cshtml(6,16): error CS0518: Predefined type 'System.String' is not defined or imported
C:\dev\github\Timbo\Timbo.Core\src\_web\Timbo.Spike.Web\Pages\About.cshtml(7,1): error CS0518: Predefined type 'System.Object' is not defined or imported
C:\dev\github\Timbo\Timbo.Core\src\_web\Timbo.Spike.Web\Pages\About.cshtml(7,1): error CS0103: The name 'Write' does not exist in the current context

@javiercn

@tbertenshaw That sounds like a Razor compilation error.

Have you disabled compilation on build?
Have you disabled shadowcopying assemblies?

See instructions on how to do it in xUnit https://xunit.github.io/docs/configuring-with-json.html

Can you validate that there is a Timbo.Spike.Web.deps.json file on the test output folder?

Side note ... same thing here working with the sample app for the upcoming integration testing topic, but your workaround @dougbu worked :+1: :smile: ...
<ItemGroup>
  <!--<PackageReference Include="Microsoft.AspNetCore.App" Version="2.1.0-preview2-final" />-->
  <PackageReference Include="Microsoft.AspNetCore" Version="2.1.0-preview2-final" />
  <PackageReference Include="Microsoft.AspNetCore.CookiePolicy" Version="2.1.0-preview2-final" />
  <PackageReference Include="Microsoft.AspNetCore.HttpsPolicy" Version="2.1.0-preview2-final"/>
  <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.1.0-preview2-final" />
  <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.ViewCompilation" Version="2.1.0-preview2-final" PrivateAssets="All" />
  <PackageReference Include="Microsoft.AspNetCore.StaticFiles" Version="2.1.0-preview2-final" />
  <PackageReference Include="Microsoft.EntityFrameworkCore" Version="2.1.0-preview2-final" />
  <PackageReference Include="Microsoft.EntityFrameworkCore.Abstractions" Version="2.1.0-preview2-final" />
  <PackageReference Include="Microsoft.EntityFrameworkCore.Analyzers" Version="2.1.0-preview2-final" />
  <PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="2.1.0-preview2-final" />
  <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="2.1.0-preview2-final" />
  <PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="2.1.0-preview2-final" />
  <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="2.1.0-preview2-final" />
  <PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="2.1.0-preview2-final" />
  <PackageReference Include="Microsoft.AspNetCore.Hosting" Version="2.1.0-preview2-final" />
  <PackageReference Include="Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore" Version="2.1.0-preview2-final" />
</ItemGroup>

Managed to fix it by adding
    <PackageReference Include="Microsoft.AspNetCore.App" Version="2.1.0-rc1-final" />
to my FunctionalTests csproj.
Seems obvious but didn't spot updated docs so wasn't sure what steps were needed.

@tbertenshaw Docs are in the works :point_right: https://github.com/aspnet/Docs/pull/6086
Fairly early stages tho ... engineering hasn't looked at the PR yet ... so keep that in mind if you read/follow any advice provided.

FYI the workaround was discussed in #7710


Do we have adblocker option for this library?

Can we use adblocker on this library?

What means 'adblocker' ?
I don't know the feature, and probably it is not implemented in the official (TypeScript version of) Playwright

This one
https://www.npmjs.com/package/@cliqz/adblocker-playwright

https://www.npmjs.com/package/@cliqz/adblocker-playwright
This is a third party library, and not included in Playwright.

playwright-ruby-client can provide functions only defined in Playwright.

https://playwright.dev/docs/api/class-route
With playwright, we have to manually define request interceptions with Route class, for accepting or denying each request.

Ok, would you like to build playwright ruby adblocker gem in the future?
Or do you have any idea how to block ads? I have no idea how to block ads using https://playwright.dev/docs/api/class-route

I have no plan to create such library because I don't understand the concrete usecase of ads blocking feature with browser automation.

Please refer https://github.com/YusukeIwaki/playwright-ruby-client/issues/35 when you learn request interception.

The usecase of this library is to crack strong website protection like datadome. According to online refs, datadome use google ads to track the movement and activity on the website. To prevent this, I want to add adblocker to our playwright scraper. I already implemented playwright stealth(https://github.com/AtuboDad/playwright_stealth). But it could not crack datadome.co protection

I see, but the purpose of developing stealth plugin is very far from the scope of Playwright library development.
I still have no plan to develop such plugin.
Actually, developing such function is illegal in our country.

Ok got it
listener = -> (req) { puts "a request was made: #{req.url}" }
page.on('request', listener)
page.goto('https://example.com/') # => prints 'a request was made: https://example.com/'
page.off('request', listener)
page.goto('https://example.com/') # => no print

I've tried this but nothing happens.
Is there anything wrong with it?

I just want to block some requests and this documentation(https://playwright-ruby-client.vercel.app/docs/api/route) is not completed yet

Why it always open with incognito mode? Do we have a way to open with normal browser?

Ok got it

listener = -> (req) { puts "a request was made: #{req.url}" }

page.on('request', listener)

page.goto('https://example.com/') # => prints 'a request was made: https://example.com/'

page.off('request', listener)

page.goto('https://example.com/') # => no print

I've tried this but nothing happens.
Is there anything wrong with it?

Could you create another issue using bug-report template?

Ok got it
listener = -> (req) { puts "a request was made: #{req.url}" }

page.on('request', listener)

page.goto('https://example.com/') # => prints 'a request was made: https://example.com/'

page.off('request', listener)

page.goto('https://example.com/') # => no print

I've tried this but nothing happens.
Is there anything wrong with it?

Could you create another issue using bug-report template?

I've learned how to do that

Why it always open with incognito mode? Do we have a way to open with normal browser?

Can you please answer me this question?

A guest account is used by default in Playwright. It is not incognito mode.
Playwright assumes each browser execution context should be isolated.
Could you share what is the expected behavior of 'normal browser' in detail?
Using persisted cookie? Requiring long-term browsing history?
playwright-ruby-client doesn't implement BrowserType#launch_persistent_context (a method for re-using the browser execution context) yet. However I don't think the feature is so frequently used because another solution exists in most case.

BrowserType#launch_persistent_context is already released in playwright-ruby-client >= 0.6.5.
Documentation is also updated: https://playwright-ruby-client.vercel.app/docs/article/guides/semi_automation#working-with-chrome-extensions


To change the IDENTITY property of a column, the column needs to be dropped and recreated

I am getting the following error when I attempt to update my database from the Package Manager Console.

To change the IDENTITY property of a column, the column needs to be dropped and recreated.

I realize there are existing issues about this same error, but they seem to involve primary keys where the remark about IDENTITY makes sense. I can't see how IDENTITY applies in my case as the column I'm changing is not a primary key and is not indexed.
Steps to Reproduce
My table definition was as follows:
CREATE TABLE [dbo].[Areas] (
    [Id]          INT            IDENTITY (1, 1) NOT NULL,
    [UserId]      NVARCHAR (450) NOT NULL,
    [Title]       NVARCHAR (150) NOT NULL,
    [Description] NVARCHAR (MAX) NULL,
    [CssClass]    NVARCHAR (32) NOT NULL,
    [Sequence]    INT            NOT NULL,
    [OnHold]      BIT            NOT NULL,
    [Created]     DATE           NOT NULL,
    CONSTRAINT [PK_Areas] PRIMARY KEY CLUSTERED ([Id] ASC),
    CONSTRAINT [FK_Areas_AspNetUsers_UserId] FOREIGN KEY ([UserId]) REFERENCES [dbo]. [AspNetUsers] ([Id]) ON DELETE CASCADE
);
GO
CREATE NONCLUSTERED INDEX [IX_Areas_UserId]
    ON [dbo].[Areas]([UserId] ASC);

I changed the model so that string CssClass is removed, and added int StyleId instead. But when I update the database, I get the error described above.
So I manually edited the table definition as follows.
CREATE TABLE [dbo].[Areas] (
    [Id]          INT            IDENTITY (1, 1) NOT NULL,
    [UserId]      NVARCHAR (450) NOT NULL,
    [Title]       NVARCHAR (150) NOT NULL,
    [Description] NVARCHAR (MAX) NULL,
    [StyleId]     INT NOT NULL,
    [Sequence]    INT            NOT NULL,
    [OnHold]      BIT            NOT NULL,
    [Created]     DATE           NOT NULL,
    CONSTRAINT [PK_Areas] PRIMARY KEY CLUSTERED ([Id] ASC),
    CONSTRAINT [FK_Areas_AspNetUsers_UserId] FOREIGN KEY ([UserId]) REFERENCES [dbo]. [AspNetUsers] ([Id]) ON DELETE CASCADE
);
GO
CREATE NONCLUSTERED INDEX [IX_Areas_UserId]
    ON [dbo].[Areas]([UserId] ASC);

But when I try to update the database again (to ensure everything is in sync), I get the same error.
Update Output
Here's the output from the update process.
PM> update-database
Microsoft.EntityFrameworkCore.Infrastructure[10403]
      Entity Framework Core 3.0.0 initialized 'ApplicationDbContext' using provider 'Microsoft.EntityFrameworkCore.SqlServer' with options: None
Microsoft.EntityFrameworkCore.Database.Command[20100]
      Executing DbCommand [Parameters=[], CommandType='Text', CommandTimeout='30']
      SELECT OBJECT_ID(N'[__EFMigrationsHistory]');
Executing DbCommand [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT OBJECT_ID(N'[__EFMigrationsHistory]');
Executing DbCommand [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT OBJECT_ID(N'[__EFMigrationsHistory]');
Microsoft.EntityFrameworkCore.Database.Command[20100]
      Executing DbCommand [Parameters=[], CommandType='Text', CommandTimeout='30']
      SELECT OBJECT_ID(N'[__EFMigrationsHistory]');
Executing DbCommand [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT [MigrationId], [ProductVersion]
FROM [__EFMigrationsHistory]
ORDER BY [MigrationId];
Microsoft.EntityFrameworkCore.Database.Command[20100]
      Executing DbCommand [Parameters=[], CommandType='Text', CommandTimeout='30']
      SELECT [MigrationId], [ProductVersion]
      FROM [__EFMigrationsHistory]
      ORDER BY [MigrationId];
Microsoft.EntityFrameworkCore.Migrations[20402]
      Applying migration '20191230173411_StyleIdNowInt'.
Applying migration '20191230173411_StyleIdNowInt'.
System.InvalidOperationException: To change the IDENTITY property of a column, the column needs to be dropped and recreated.
   at Microsoft.EntityFrameworkCore.Migrations.SqlServerMigrationsSqlGenerator.Generate(AlterColumnOperation operation, IModel model, MigrationCommandListBuilder builder)
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.<>c.<.cctor>b__71_4(MigrationsSqlGenerator g, MigrationOperation o, IModel m, MigrationCommandListBuilder b)
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.Generate(MigrationOperation operation, IModel model, MigrationCommandListBuilder builder)
   at Microsoft.EntityFrameworkCore.Migrations.SqlServerMigrationsSqlGenerator.Generate(MigrationOperation operation, IModel model, MigrationCommandListBuilder builder)
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.Generate(IReadOnlyList`1 operations, IModel model)
   at Microsoft.EntityFrameworkCore.Migrations.SqlServerMigrationsSqlGenerator.Generate(IReadOnlyList`1 operations, IModel model)
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.GenerateUpSql(Migration migration)
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.<>c__DisplayClass15_2.<GetMigrationCommandLists>b__2()
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.Migrate(String targetMigration)
   at Microsoft.EntityFrameworkCore.Design.Internal.MigrationsOperations.UpdateDatabase(String targetMigration, String contextType)
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.UpdateDatabaseImpl(String targetMigration, String contextType)
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.UpdateDatabase.<>c__DisplayClass0_0.<.ctor>b__0()
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.Execute(Action action)
To change the IDENTITY property of a column, the column needs to be dropped and recreated.

Migration File
Here is my migration file. (Note that the name is different because I regenerated it. But it's getting the same error.)
public partial class CssClassToStyleId : Migration
{
    protected override void Up(MigrationBuilder migrationBuilder)
    {
        migrationBuilder.DropColumn(
            name: "Discriminator",
            table: "AspNetUsers");

        migrationBuilder.DropColumn(
            name: "CssClass",
            table: "Areas");

        migrationBuilder.AlterColumn<int>(
            name: "Id",
            table: "Areas",
            nullable: false,
            oldClrType: typeof(int),
            oldType: "int")
            .OldAnnotation("SqlServer:Identity", "1, 1");

        migrationBuilder.AddColumn<int>(
            name: "StyleId",
            table: "Areas",
            nullable: false,
            defaultValue: 0);
    }

    protected override void Down(MigrationBuilder migrationBuilder)
    {
        migrationBuilder.DropColumn(
            name: "StyleId",
            table: "Areas");

        migrationBuilder.AddColumn<string>(
            name: "Discriminator",
            table: "AspNetUsers",
            type: "nvarchar(max)",
            nullable: false,
            defaultValue: "");

        migrationBuilder.AlterColumn<int>(
            name: "Id",
            table: "Areas",
            type: "int",
            nullable: false,
            oldClrType: typeof(int))
            .Annotation("SqlServer:Identity", "1, 1");

        migrationBuilder.AddColumn<string>(
            name: "CssClass",
            table: "Areas",
            type: "nvarchar(32)",
            maxLength: 32,
            nullable: false,
            defaultValue: "");
    }
}

Further Technical Details
Database provider: Microsoft.EntityFrameworkCore.SqlServer
Target framework: .NET Core 3.0
Operating system: Windows 10
IDE: Visual Studio 2019 16.4.2

Is it because my new column ends in Id? Was it automatically interpreted as a primary or other key? If so, how the heck do I stop that?

UPDATE
Looking at the migration file, I see the blocks that call AlterColumn appear to be changing my primary key (to the same name and type). If I comment out these blocks, I can update-database without error.
But I'm still not clear why these blocks were added. They don't appear to be necessary. This question is a few days old now. I'm hoping someone can take a look at this issue. There appears there might be a problem.

@SoftCircuits Please post a small, runnable project that reproduces the behavior you are seeing so that we can investigate.

@SoftCircuits Please post a small, runnable project that reproduces the behavior you are seeing so that we can investigate.

Well, if the code wouldn't compile it's hard to see how it would be runnable. At any rate, since there's a database involved, that's more easily said than done. Moreover, if not everyone is reporting this, I have no reason to think that creating a new project would include this error.  So I'll probably just let it go if no one else is worried about it.


MenuAnchor crashes when a child has tooltip and is hover

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
Simply run the following code, click the bell icon and hover the item. Haven't tried on mobile this was tested on windows desktop.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: Scaffold(
        body: Center(
          child: MenuAnchor(
            builder: (BuildContext context, MenuController controller, Widget? child) {
              return IconButton(
                onPressed: () {
                  if (controller.isOpen) {
                    controller.close();
                  } else {
                    controller.open();
                  }
                },
                icon: const Icon(Icons.notifications),
              );
            },
            menuChildren: [
              Tooltip(
                message: 'some tip',
                child: Padding(
                  padding: const EdgeInsets.all(16.0),
                  child: Text('hover me'),
                ),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

Flutter Doctor output
Doctor output
[√] Flutter (Channel stable, 3.13.0, on Microsoft Windows [Version 10.0.22000.2360], locale en-US)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.6.4)
[√] Android Studio (version 2022.3)
[√] Connected device (3 available)
[√] Network resources

@BananaMasterz
There's a similar issue reported describing your case https://github.com/flutter/flutter/issues/133545 which is caused as mentioned here.
I suggest you subscribe to that issue so that once it is fixed, you can re-run your scenario on latest master and confirm if it works for your case or not.
For now, I'll close as duplicate. If you disagree, write in comments and I'll reopen it.


Effective encoder extraction

hey I was wondering instead of copy pasting the entire file for our own use, if we can have a similar feature like: this, where you can just query the encoder`s name and we can use the structure directly for our task?

Sure!


bug in contact-us form

The issue which i saw was that a user was able to send a blank from without the name of sender and subjects with only payload of the message given . Even after the message is  sent The message is still present in the message box and it should also not be present .
So , if its okay for you I would like to work in this issue.

This issue is already solved in PR #14
Kindly look for any other issue.


Moved planet to /PickerView

Project URL

https://github.com/kwallet/planet
Category

/PickerView
Description

A country picker view controller for iOS

          1 Warning

:warning:
Found 1 link issue, a project collaborator will take care of these, thanks :)

Link issue by awesome_bot

Line
Status
Link

2878
302
http://www.ios-blog.co.uk/ redirects tohttp://www.ios-blog.co.uk/cgi-sys/suspendedpage.cgi

  Generated by :no_entry_sign: Danger


Document the subtleties associated with using relative/absolute paths

We had a bit of a discussion on #228 on this topic and the results should be in the documentation.

This is related, in the same that both should be documented in about the same place, but not the same as #229


Add JSON output format options

It'd be nice to support a JSON benchmark output format a la Google Bench. This would make scripted perf tracking for nvbench runs much simpler.

Did you try --json <filename>? (Output Formats)

No, but now I did and it works 😊
Thanks!


Update extension-based-hybrid-runbook-worker.md

Added information on known issue with the Azure Connected Machine agent update causing folder permissions to be lost. This causes HRW jobs which use a custom credential to go into a suspended state until the folder permissions are reapplied.

@microsoft-github-policy-service agree company="Microsoft"

@SnehaSudhirG
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Cannot execute CLI Jar after building locally.

Currently working on detekt and after building detekt with
gradle build shadow and then running the JAR throws the following error:
--- mauin/detekt (mr/naming_length_multi_rule* RM)» java -jar detekt-cli/build/libs/detekt-cli-1.0.0.RC2.jar -i .
no main manifest attribute, in detekt-cli/build/libs/detekt-cli-1.0.0.RC2.jar

Did I just completely break something on my branch or is there an issue?

I'm having no issues on local master ^^

Oh, I see. I was running detekt-cli-1.0.0.RC2.jar which shows the error above. But running detekt-cli-1.0.0.RC2-all.jar is successful.


Improve find by other fields besides the eateries’ name

As a user I can filter food by tags so that I can see only the options that suit my preferences.
As a user I can filter food stalls by location so that I can choose food from a certain area to eat.

Ideally, merge the separate find commands into one simple command and facilitate cross-field searches.


Development of environment for handling modules structure and listing of classes

The following activities are to do:

[x] assignment of tasks;

[x] presentation of requirements that need to be implemented (code, issues, other things);

[x] presentation of performed activities;

[x] #860

[x] #876

[x] #888

Methods, functions or classes to implement are as follows:

[x] #773

[x] #894

[x] #895

[x] #896

[x] #897

Class ModuleStructure is stored in dynpy/utilities/creators.py

Update:

lister method returns list of classes with parent submodule in tuple format

tree method was added to print class list in tree format.

Added help() with class and methods description

Added functionality to get import command for any class
The code was checked with the following code:
from dynpy.utilities.creators import ModuleStructure

ModuleStructure.get_import('ObjectCode')

All subtasks are closed, task finished


Filter a specific file

I am wondering if there is a way to filter a specific file? Sometimes I want to quickly filter the output for just one file. Is there a magic filter syntax for that?

Not right now. But that's a good point.

Hi, any progress on this? Would be a great feature.

+1 for this!

If this feature request allows you to remove lines on the fly based on a keyword match rather like the highlight feature works then that would be great. Or looking at this another way round and maybe more useful only show lines that have a certain keyword in them


PHP 8 on Windows - inet_pton not found

Describe the bug
When running PHP 8.0 version on Windows, the inet_pton function is not found.

https://www.php.net/manual/en/function.inet-pton.php
https://github.com/phpstan/phpstan/blob/894c59fcf79df09aba631ac52230efbcd15048e0/.github/workflows/build.yml#L15-L50

Version

[x] I have checked releases and the bug exists in the latest patch version of v1 or v2.
[x] v2
[ ] v1

Runners

[x] GitHub Hosted
[ ] Self Hosted

Operating systems

Windows
PHP versions

8.0
To Reproduce

Run composer update with composer:snapshot on PHP 8.0 windows-latest
Expected behavior

Screenshots/Logs

https://github.com/phpstan/phpstan-src/runs/992276871?check_suite_focus=true

@ondrejmirtes it should be there
https://github.com/shivammathur/test-setup-php/runs/993405799?check_suite_focus=true

Oh, sorry, looks like a Composer bug here then: https://github.com/composer/composer/blob/0eebdcf2e655f28107aa2c5c33f6d7a4c948457b/src/Composer/Repository/PlatformRepository.php#L128

Reported here: https://github.com/composer/composer/issues/9128

Yes, it changed here https://github.com/composer/composer/commit/7e1ef19a5a544af35a3b063652659637c711fb2a
So it should work with composer:v2.

Is it possible that composer:v2 on Windows has an older out of date version? I'm using composer:snapshot there.

composer:v2 is 2.0.0-alpha3 release currently and this changed after that release.

I'm using composer:snapshot - looks like on Linux it already has this change but on Windows it doesn't.

I actually don't know if Linux or Windows have newer composer:snapshot - I'm not sure if the linked Composer commit fixes or introduces the bug.

Composer snapshot is same in both OS, The issue is in composer or php-src.

@ondrejmirtes Updated the composer builds cache after fix. The workflow should pass now.

Thank you, it works!


cc: add ability to run interval commands from dash

This adds the ability to run interval CCs immediately from the dashboard, as title states.
Mostly useful for testing (no need to wait for it to trigger / put it into another CC).
To prevent spam, there is a 5s cooldown -- let me know if you want this changed.

Second one looks particularly ugly but I couldn't find a better place to put it, suggestions are appreciated.

Here, button image would be 🔄 emoji. What do you think?

For your first screenshot, I think user may hit Run now and/or Delete buttons by accident, trying to click Edit. I suggest this:

🔁 emoji feels too subtle to me to be honest.
That's a good idea, will switch around the order in a moment...

This dosen't work when the webserver is not running on the same process as the bot itself, you should either make a pubsub that triggers on the bot side, or just set the next run time to immediately and update the scheduled event for it

Switched to a pubsub event in https://github.com/jonas747/yagpdb/pull/896/commits/703d0fa9bacacd3dde6453304b067930262c530a, still works fine (as far as I can tell) but I haven't tested with the webserver/bot on different processes.


upgrade zip to 0.6.2, reduce features to only needed ones

Upgrading zip broke because it added zstd compression, but with a different version than we do.
While checking the default features I saw that we could also remove some other features we don't use.
Sadly no changelog, but: https://github.com/zip-rs/zip/compare/v0.5.11...master (I scanned over the commit messages but didn't see anything problematic for us. Also we have tests covering archives.

r? @Nemo157 @jyn514


Balloon colors

Any chance the color yellow could be changed to something darker.  Very hard to see on map

Same problem, not easy to see on phone in sunlight

Doing some tweaking of the yellow colour on testing.v2.sondehub.org
I've darkened the yellow colour slightly, and also increased the opacity of the prediction traces a little bit.

hello Mark, no worries on my PC at home, but on my phone and in the car, the yellow color remains very difficult to see on the map with the sun, (blue, green, red) are perfect in mobile.

So the current colours in the rotation are:
["red", "blue", "green", "yellow", "purple", "orange", "cyan"];
Are purple, orange and cyan ok? I'm thinking maybe we'll just drop yellow from the rotation.

actually, giving up yellow would be a good idea, for purple, orange, and cyan colors it's OK, thank you

Yellow has been removed from the balloon colour lineup.


#2420 - fix searchbar on mobile

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[x] Bugfix
[x] Feature
[ ] Refactoring

What's new?

[x] PR closes #2420
[x] showing searchbar in gallery ~and collections~ on mobile as before, but hiding it when navbar expands. I'll follow next week in https://github.com/kodadot/nft-gallery/issues/2261

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[x] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[x] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

https://user-images.githubusercontent.com/73316633/155182728-5df16f73-7b11-4dda-a8e9-78f40fff2a96.mp4

#2425 was merged, you've got green runway ;)

I've changed the order of text in search section, in my opinion this still wasn't good:

Here's the current version:
https://user-images.githubusercontent.com/73316633/156026081-4ec555eb-3290-42f4-b1a9-fec805c02b94.mp4

@yangwao I've kept the search bar located in the navbar in case of collections instead of what I've described in #2420 since I've mistakenly thought that the searchbar located in navbar is "collections" on collections page. Since in navbar there's always only "gallery", it makes sense to keep it there. The gallery is fixed here, tomorrow I'll start looking into the unification of Gallery/Collections search experience.
https://user-images.githubusercontent.com/73316633/156027835-11db5b77-fe1c-4af7-aa9e-d5058578654b.mp4

pay 100 usd

😍 Perfect, I’ve sent the payout
💵 $100 @ 123.91 USD/KSM ~ 0.807 $KSM
🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
🔗 0x18c4b4defd1c60ca878a33361c45b08bc16b946841bf145773d120a28b895d02
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


use python_package_requires_python as the default for docker_python_version

It makes sense (to me) to use the same setup as on github actions
https://github.com/AllenInstitute/copier-pdm-npc/blob/main/project/.github/workflows/publish.yml.jinja#L27-L32

@bjhardcastle That value can be >=3.9 or the other various conventions that pdm supports. jinja2 appears to support slicing but not regex for variables. There could be a more complex solution using jinja2 extensions but I figured simpler would get the job done and potentially be more stable.

Ah I see, the Dockerfile doesn't use the same syntax.. then I agree it's not worth parsing the version number.


Reset Button in Retirement Calculator(Phase 2)

I want to work on this issue under JWOC phase 2 @Srijita-Mandal
I want to add reset button in retirement calculator and also the alignment of input box of initial investment is not proper , I want to fix it.

@priyanka1551 Go for it.


How to set Page Break Preview

HI. Thanks to you, I am making excel file to download.
But I have an issue.

I uploaded an excel template on "smw0" which has a setting of "PAGE BREAK PREVIEW".
If I download it without abap2xlsx, the setting of page break preview maintains.
However, I have to write on that template and then download.
in that process, I use abap2xlsx classes, but the setting of page break preview are cleared.
I don't know why, and I don't know how to solve the problem

Can you help me? it s urgent.
below is the code which has problem:
DATA(ls_key) = VALUE wwwdatatab( relid = 'MI' objid = 'TEMPLATE' ).

CALL FUNCTION 'WWWDATA_IMPORT'
    EXPORTING
      key               = ls_key
    TABLES
      mime              = lt_mime
    EXCEPTIONS
      wrong_object_type = 1
      import_error      = 2
      OTHERS            = 3.

  IF sy-subrc <> 0.
    RETURN.
  ENDIF.

  TRY.
      lv_templ_xstr = cl_bcs_convert=>xtab_to_xstring( lt_mime ).
    CATCH cx_bcs.
      RETURN.
  ENDTRY.

  CREATE OBJECT lo_reader TYPE zcl_excel_reader_2007.
  lo_excel = lo_reader->load( lv_templ_xstr ).

  cl_writer = NEW zcl_excel_writer_2007( ).

  DATA(lv_xstring) = cl_writer->write_file( lo_excel ).

  cl_wd_runtime_services=>attach_file_to_response(
  EXPORTING
    i_filename      = 'test'
    i_content       = lv_xstring
    i_mime_type     = lc_mim_type
     ).

Hi.
What is this "page break preview"?
Could you provide the Excel template?
Could you provide a minimal reproducible example? One good recent example of program to reproduce (compiles and runs without effort): https://answers.sap.com/questions/13998912/abap2xlsx-2-worksheets-both-with-method-bind-table.html.
Sorry to hear that you're in a hurry. This is a community tool maintained by volunteers, support is not guaranteed. To increase your chances to get a better support, please be as much precise as possible. I hope you understand.

thanks for your reply!
This is an example of "Page Break Preview". Because of the security policy, i post this alternatively.
(https://support.microsoft.com/en-us/office/insert-move-or-delete-page-breaks-in-a-worksheet-ad3dc726-beec-4a4c-861f-ed640612bdc2)
on the view tab, in the workbook views group, click page break preview.
And then you can see blue line.
I want to set this "blue line".'

Hi @MINMINH-log ,
can't you just create a sample that doesn't contain any confidential data?

It's not a matter of file type, it's a matter of data (even images could contain confidential data). I see that it's "empty", i.e. no confidential data/no private data, so could you please attach this "empty" Excel file? I'll then try to reproduce by running the demo program which opens an Excel file and save it (open and save based on the abap2xlsx classes zcl_excel_reader_2007 and zcl_excel_writer_2007).

abap2xlsx_page break preview.xlsx
can you see it?

thank you for all of your reply.
But it s hard to send a file that includes a setting of a page break preview.
fortunately, it is determined not to include the setting.
if you know how to set it, then plz comment at here.
thank you: )


Improve perf of SolidPolygonLayer

This is a big change to an existing core layer, and utilizes an under-tested feature (multi-model layer). More testing will be required.

Remove PolygonTesselatorExtruded class
SolidPolygonLayer now renders filled sides or wireframe with an instanced model

Before:

Test
Result

SolidPolygonLayer#initialize (flat)
28.4 iterations/s (0.35s)

SolidPolygonLayer#initialize (extruded)
8.21 iterations/s (1.22s)

SolidPolygonLayer#initialize (wireframe)
21.8 iterations/s (0.46s)

SolidPolygonLayer#initialize (flat,fp64)
14.1 iterations/s (0.71s)

SolidPolygonLayer#initialize (extruded,fp64)
7.25 iterations/s (0.14s)

SolidPolygonLayer#initialize (wireframe,fp64)
13.4 iterations/s (0.75s)

After:

Test
Result

SolidPolygonLayer#initialize (flat)
26.3 iterations/s (0.38s)

SolidPolygonLayer#initialize (extruded)
24.8 iterations/s (0.40s)

SolidPolygonLayer#initialize (wireframe)
26.7 iterations/s (0.38s)

SolidPolygonLayer#initialize (flat,fp64)
16.4 iterations/s (0.61s)

SolidPolygonLayer#initialize (extruded,fp64)
14.5 iterations/s (0.69s)

SolidPolygonLayer#initialize (wireframe,fp64)
15.5 iterations/s (0.64s)

Tested: node, browser, layer-browser, website examples

@Pessimistress This is a fantastic speed improvement that should have a tremendous impact on impacted applications.
Since we are getting close to beta, before I start reviewing, what do you think of putting this version of the polygon layer into experimental-layer's for now? Then we would have more time to think through adding multi model layers to our core catalog...

@ibgreen Will do.


Matlab chapter?

Matlab still has a large userbase in many fields. In many projects, we come across Matlab code. Most of the time, we translate it into other languages, but we still need to be aware of the basics, if only for faithful reproduction.
Is this worth a chapter? Can we simply refer to other guides? Is this worth our effort or is this a trivial problem?

Our projects are about developing reusable code and encouraging open science, while Matlab is a closed-source commercial product. Therefore it looks like Matlab does not match our values and I am not sure if we should write Matlab code.


Poll for Changes Independent of Browser Resize

This is a feature request.
It would be wonderful to have the option to constantly poll for element changes. Many complex applications implement panel systems - panel slides onto page and squeezes the page's content.
In this case, the width of the page's content is narrowing and I need to apply EQCSS to handle UI changes. Unfortunately, EQCSS won't be applied because there was no browser resize event.
I understand that EQCSS may be called manually when the panel is triggered to open. Calling EQCSS manually will work properly if it's called AFTER the transition is complete (after panel slides onto page and page content is squeezed). This tactic would require that the transitions are implemented using JS. But if transitions are implemented using CSS, it makes it tough to time properly.
Any thoughts / advice would be appreciated. Thanks!

One could also add an event listener for "animationend" to trigger eqcss after css animations.

Hi @mcraiganthony! I see what you mean about wanting it to wait to execute until the CSS animation completes. Did the idea from @acicali help at all?
Do you have any demo code that illustrates the issue that we can play with and find a fix for?

@mcraiganthony! Have you found a workaround/solution to the animation issue? When you say:

In this case, the width of the page's content is narrowing and I need to apply EQCSS to handle UI changes. Unfortunately, EQCSS won't be applied because there was no browser resize event.

That does make me think of something similar I do. On some element query demos I have a script that will add a little drag handle for touchscreen users so they can drag to resize the demos. This function, (which you can spot at the bottom of http://elementqueries.com) has code like this:
document.addEventListener('mouseup',drop)
document.addEventListener('touchend',drop)
…
function drop(e){
  grabbed = undefined
  EQCSS.throttle()
}

There are functions that run on click/touchstart which grab the element, mousemove/touchmove which resize the element, and then every mouseup/touchend event I recalculate EQCSS manually with EQCSS.throttle().
You can call EQCSS.throttle() as frequently as you want and it will throttle it to running no more frequently than every 200ms. If you want EQCSS to recalculate instantly (could be performance heavy, depending on how many queries + elements) you can also call EQCSS.apply() directly, bypassing the throttle entirely.
It sounds to me like you need to find a way to determine an event JavaScript can listen to on your page that would manually call one of these two functions.

Thanks @tomhodgins I appreciate the insight! It's certainly a tough problem to solve especially when trying to keep performance at an optimal level.
Unfortunately I had to (temporarily) pull EQCSS from my project. I was prototyping in Codepen using LESS and it was working wonderfully for nearly 2 months. Then, about a week ago, Codepen started throwing errors regarding LESS directives. I spent a full day trying to use EQCSS in LESS with no luck. I saw an issue here where someone inquired about using EQCSS in LESS and it was closed without much discussion. I'm going to revisit the issue and see if I can find a way to make it work - at which point I'll gladly share.

I saw an issue here where someone inquired about using EQCSS in LESS and it was closed without much discussion.

In response to a couple of tickets regarding preprocessors, we went ahead and pushed out an update to make sure EQCSS was working well with SCSS, Less, and Stylus.
You're able to replace any meta-selector in EQCSS that starts with $ (like $this, $root, $parent, $next, or $prev) with eq_(like eq_this, eq_root, eq_parent, eq_next, or eq_prev) which seemed to be the biggest issue with preprocessors.
If you have any questions about how to use EQCSS or write element queries, or have code samples you're working on (like on Codepen) feel free to join us in the Gitter channel and we can troubleshoot and figure stuff out together!

@tomhodgins Oh man that's great news! My gut was telling me that it was a Codepen issue since EQCSS worked for a couple of months and then suddenly stopped. I'll let you know if I run into any problems using it outside of Codepen. I appreciate the help!


Finetuning a Pretrained Model Using MuP

Somewhat of a naive question, but say we have pretrained a model and now want to finetune it on a downstream task. Is there any reason we shouldn't replace the MuP layers with the equivalent torch layers? I have to imagine that we don't need to use MuP here, but want to make sure that this doesn't break anything if we replace them

If it's already pretrained, you can replace torch layers with muP layers to
allow you to use muP optimizers (that can scale per layer lr with shape
info), as long as you make sure to keep the model forward pass invariant
when you switch out layers.
On Wed, Dec 7, 2022, 6:13 AM Zach Nussbaum @.***> wrote:

Somewhat of a naive question, but say we have pretrained a model and now
want to finetune it on a downstream task. Is there any reason we shouldn't
replace the MuP layers with the equivalent torch layers? I have to
imagine that we don't need to use MuP here, but want to make sure that
this doesn't break anything if we replace them
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/mup/issues/31, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMWHHMY2DARLGILJMLQBUQDWMCZRLANCNFSM6AAAAAASXAFWV4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Sorry I was not clear! If we pretrained using MuP, we should replace the
Readout layers with normal torch layers when fine tuning correct?
On Wed, Dec 7, 2022 at 11:42 AM Greg Yang @.***> wrote:

If it's already pretrained, you can replace torch layers with muP layers to
allow you to use muP optimizers (that can scale per layer lr with shape
info), as long as you make sure to keep the model forward pass invariant
when you switch out layers.
On Wed, Dec 7, 2022, 6:13 AM Zach Nussbaum @.***> wrote:

Somewhat of a naive question, but say we have pretrained a model and now
want to finetune it on a downstream task. Is there any reason we
shouldn't
replace the MuP layers with the equivalent torch layers? I have to
imagine that we don't need to use MuP here, but want to make sure that
this doesn't break anything if we replace them
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/mup/issues/31, or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AMWHHMY2DARLGILJMLQBUQDWMCZRLANCNFSM6AAAAAASXAFWV4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/mup/issues/31#issuecomment-1341254650, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AIBFIPKDDKW4CZHTYJC4FADWMC45RANCNFSM6AAAAAASXAFWV4
.
You are receiving this because you authored the thread.Message ID:
@.***>

I think this is up to you. It's possible to replacing muP layer with torch
layers can make it easier to apply established hyperparameters for
fine-tuning. On the other hand, the muP layers themselves can open up
better hyperparameter choices for fine-tuning as well.
On Wed, Dec 7, 2022, 6:47 AM Zach Nussbaum @.***> wrote:

Sorry I was not clear! If we pretrained using MuP, we should replace the
Readout layers with normal torch layers when fine tuning correct?
On Wed, Dec 7, 2022 at 11:42 AM Greg Yang @.***> wrote:

If it's already pretrained, you can replace torch layers with muP layers
to
allow you to use muP optimizers (that can scale per layer lr with shape
info), as long as you make sure to keep the model forward pass invariant
when you switch out layers.
On Wed, Dec 7, 2022, 6:13 AM Zach Nussbaum @.***> wrote:

Somewhat of a naive question, but say we have pretrained a model and
now
want to finetune it on a downstream task. Is there any reason we
shouldn't
replace the MuP layers with the equivalent torch layers? I have to
imagine that we don't need to use MuP here, but want to make sure that
this doesn't break anything if we replace them
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/mup/issues/31, or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AMWHHMY2DARLGILJMLQBUQDWMCZRLANCNFSM6AAAAAASXAFWV4

.
You are receiving this because you are subscribed to this
thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/mup/issues/31#issuecomment-1341254650, or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AIBFIPKDDKW4CZHTYJC4FADWMC45RANCNFSM6AAAAAASXAFWV4
.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/mup/issues/31#issuecomment-1341262212, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AMWHHM6MONS54U5QXTIQVC3WMC5TJANCNFSM6AAAAAASXAFWV4
.
You are receiving this because you commented.Message ID:
@.***>


Get contact form working

Contact form works now. Uses Netlify Forms --> Zapier --> email to<EMAIL_ADDRESS>Will demo this in #12


version1.3.9: endpoint去掉http:// 或 https:// 头信息

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.maguoxin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Syntax Highlighter: PHP requries C-like modes

I noticed that Kirki isn't calling clike.js file when using PHP in syntax highlighter.
If you remove clike.js from it, it fails terribly: http://codemirror.net/mode/php/index.html
Haven't actually tried in Kirki. @aristath
If you want I can send a patch. :)

Fixed on https://github.com/aristath/kirki/commit/a650b9af756fd8448a00b4f6a619e5836e0e817c#diff-24df45ecd0f9ef2889cd46ce356c74b8


test-lib: check if  $CID_FILE_DIR not empty in ct_cleanup

Partially fixes https://github.com/sclorg/varnish-container/issues/111

[test-all]

[test-all]

[test-all]

[test-all]


oauth2proxy redirects back to sign in page instead of home page

Describe the bug
oauth2proxy redirects back to janus idp sign in page after oauth flow is complete.  It is highly likely that there was a bug introduced in https://github.com/janus-idp/backstage-showcase/pull/602.
Expected Behavior
The user should be redirected to the janus idp homescreen after the oauth flow is complete.
What are the steps to reproduce this bug?

Set up an oauth2proxy using keycloak (rhsso)
Install a gitlab self hosted instance and configure gitlab as an identity provider in keycloak
login to janus, select the gitlab identity provider from keycloak, authenticate
You will be redirected back to the sign in page instead of the home page

Versions of software used and environment
image pr-602 and later fail.  All previous images work fine.

Looks like there has been a change to the sign in page.  I've updated my app-config and replaced the old oauth2Proxy config with signInPage: oauth2Proxy.  I no longer get the sign in page but do receive a new error:

{"error":{"name":"NotFoundError","message":"Unknown auth provider 'oauth2Proxy'"},"request":{"method":"GET","url":"/api/auth/oauth2Proxy/refresh"},"response":{"statusCode":404}}