[HeroSystem6eHeroic] Fix for color styling in dark mode.

Changes / Comments
Fix for dice result colors in roll template.
Possible fix for white background issue (only appears in public server and not dev).
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[X] Does the pull request title have the sheet name(s)? Include each sheet name.
[X] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.

@Villain1nGlasses There appears to be merge conflicts on this PR.


!help command with detailed game instructions

A !help command that displays game instructions (maybe with a link to some form of documentation) and the idea of playing planning poker in general could be useful for inexperienced users.

Hi @Fubinator can I take this issue? Thanks in advance

Of course @jooaodanieel, go ahead! If you have any quuestions feel free to ask.


Code of Conduct

While I cannot contribute to any of the technical aspects for this project, I can draft a "code of conduct" to create a greater sense of inclusion and community for contributors. If you assign this issue to me I can get one ready for you in a couple of minutes.

Sure

Comment here so that i can assign and accept pull request


Undo / redo does not fire onBeforeChange() in controlled component

When making a change within the editor, and hitting CMD-Z to undo your changes, the onBeforeChange() event does not fire. However, the onChange() event does fire.
I'm willing to use onChange() to get around the issue, but all of the documentation around the controlled component states that onBeforeChange() should be used for managing the value of the component.
Here's a GIF of the problem in action:

Easiest way to reproduce:
Do as I did in the GIF: Visit the provided example with the React DevTools extension opened in Chrome, and you can see that the value of the input does not update in component state (done via onBeforeChange); though you do see the change event firing in the console, and the text within the component reflects what we see in the console.

Hm interesting, thanks for bringing this up. I know codemirror manages some form of state internally in regards to history so the undo updating you're seeing if mostly codemirror itself.
I do think using onBeforeChange is appropriate here. Will keep you posted!

Thanks for the quick response. FWIW it's not included in the GIF above, but once you CMD-Z, not only does it fail to update the component's value immediately; any key input after that point places the key input in the wrong spot within the value and you end up with a completely broken experience.

@cephirothdy2j Hey again, this should be fixed with the 3.0.4 release. Working with the codemirror history api proved to be quite difficult, but I think I was able to get through it. Can you please try the new release out?
Also, the side effect you had mentioned should be resolved, I too ran into that and think this fix should squash it.

Thanks for looking into this so quickly. I feel your pain on working with codemirror history; I forked your repo and attempted to fix this morning but could only fix about 60% of the problem. e.g. I'd get the undo stack working but lose the redo stack at the same time, or changes would undo correctly but misplace the cursor.
3.0.4 is MUCH better than 3.0.3 but there is still an issue when "fast-undoing". See the attached GIF, where I'm making some changes in the example and then holding down Cmd-Z to undo them all. One character gets left behind, and the codemirror instance becomes out of sync with your controlled component. The result is I can't even delete the leftover character unless I delete the entire line.

@cephirothdy2j Yep,I too can reproduce this. I don't think it has to do with the speed as I can get the same result my slowly undo/redo-ing all of the inputs as well on your <div> example, but maybe the auto indentation codemirror is doing - specificially on electricInput. Unsure fully yet...
I'll be working through this today and will share my findings with you. Thanks for the collaboration!

@cephirothdy2j  Wow, this was tough! Thanks again for all the help on this. I believe I finally got this working with the 3.0.5 release. Let me know if better? Please reply back here if you should notice anything else weird again, but I'm feeling confident you'll get the behavior you're expecting this time. The only lingering thought might be an inconsistency in the cursor position so be sure to pay careful attention to it 🤞

It's perfect! I can't recreate any of the previous issues and so far I haven't seen any cursor weirdness.
Looking at the commit, you had to wade pretty deep into Codemirror to get to the root of the issue. Thanks for looking into this and resolving it so quickly.

Np 👍 Going to close this out for now. Please re-open should you notice anything odd and thanks for using react-codemirror2!


cxxopts: unstable-2020-12-14 -> 3.0.0

Motivation for this change
Update to the latest stable version. The issue with -Wsuggest-override is seemingly resolved in upstream https://github.com/jarro2783/cxxopts/commit/174510285a451d5e2ab2c4054bc88ce8b4ba933d
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 153621 run on x86_64-linux 1

7 packages built:

chia
cxxopts
libtree
pass-wayland
python38Packages.chiapos
python39Packages.chiapos
ydotool

@ofborg build chia cxxopts pass-wayland python39Packages.chiapos


[ROCKETMQ-64] Remove duplication code line in BrokerOuterAPI.registerBroker method

Remove duplicated 'result.setHaServerAddr(responseHeader.getHaServerAddr());' in  BrokerOuterAPI.registerBroker method

link to jira issue 64

Thanks @naughtybear


Bad DB Credentials and no errors

Hi @krzysiekpiasecki ,
I'm beginning using your gentelella symfony ready to use skeleton application...
Thanks a lot again for all the team for your really nice work :).
I installed this repository. I ran doctrine commands, but my credentials were wrong.
No errors occured. Maybe we should try to check if db credentials are ok before running all scripts.
So I got "Database has been created ..." which was a wrong information when I checked the database.
 <exec command="php bin/console doctrine:database:create --if-not-exists"/> <echo msg="Database has been created ..." />
Regards,
Ousama.

Run the command php vendor/bin/phing -verbose
You should see then such an exception

-- [Doctrine\DBAL\Driver\PDOException] [exec]   SQLSTATE[HY000]: General error: 1364 Field 'locked' doesn't have a default value

It comes from UserBundle library.

Thank you for this feedback.
I was just asking if it was possible to add check on build.
If a step fail then tell user stepXXXX failed :).
I will have a look on it and if I have some news I'll open a pull request.
Regards

@ousamabenyounes  At the moment --verbose parameter is the only road map. PR always welcome.
May I ask you that you close this ticket if you haven't got any notices?

Thank you for your feedback


man: System manpages have higher priority than user manpages

Describe the bug
/run/current-system/sw/share/man has higher priority than /etc/profiles/per-user/$USER/share/man because /run/wrappers/bin is earlier in the PATH, and it's set to /run/current-system/sw/share/man in the MANPATH_MAP.
Steps To Reproduce
Steps to reproduce the behavior:

Install packages with conlicting manpages on the system and the user (e.g., moreutils and parallel).
Try to open the manpage as the user (e.g., man parallel).
Manpage for package installed systemwide is opened.

Expected behavior
It should have opened the manpage for the one installed for the user, as that corresponds to the program that would be executed.
Additional context
I think that the easiest solution here is to remove the MANPATH_MAP entry for /run/wrappers/bin, though maybe this should be behind a setting (I could make a PR for this if desired). I think that ideally there would be a separate manpage collection just for wrappers, but I don't think this is feasible.
Note that this issue started with #65844.
Notify maintainers

@sternenseemann
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.11.2-xanmod1, NixOS, 24.11 (Vicuna), 24.11.20241014.a3c0b3b`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.24.9`
 - nixpkgs: `/nix/store/xnjw9gmfmpppdj6bxpw6cfkspc3h6xwl-source`

Add a :+1: reaction to issues you find important.

cc @matthewbauer
I think variants of this issue can't really be solved with how man-db works. Maybe we should move more of the configuration into the man-db nixos module, so it's easier for users to work around such problems.

What about just switching to environment variables?


branch-2.1 fix miss writer in concurrency incremental open (#38605)

pick https://github.com/apache/doris/pull/38605

run buildall


Demangler: Incorrect demangling

Originally reported by @q1o1p in https://github.com/avast-tl/demangler/issues/1.
elliptic function like ?debugf@@YAXPB_WZZ demangling wrong.
now: void __cdecl debugf(wchar_t const *)
must be: void __cdecl debugf(wchar_t const *,...)
lose ...

This is being worked on by one student as his bachelor thesis - see milestone and the referenced forked repository.

With the new demangler (#95):

?debugf@@YAXPB_WZZ -> void __cdecl debugf(wchar_t const *) : still bad
_ZL21size_of_encoded_valueh : OK
gcc examples to look at : OK
ms and borland examples to look at : nothing, but they look crazy, https://demangler.com/ will not handle them either.

So the only one to look at is ?debugf@@YAXPB_WZZ.


Fixed docs for derive(WorldQuery).

For derive(WorldQuery), there are three structs generated, Item, Fetch and State.
These inherit the visibility of the derived structure, thus #![warn(missing_docs)] would
warn about missing documentation for these structures.

[ ] I'd like some advice on what to write here, as I personally don't really understand Fetch nor `State.

I thought that #[automatically_derived] items wouldn't trigger a warning.

Done. Sorry :( I cannot believe I didn't notice.

@BoxyUwU @james7132 are my docs for the generated structs basically fine?

havign docs on a doc(hidden) thing seems weird to me. the docs on the item type I think would be wrong for the ReadOnly version as it would link to the wrong worldquery?

I added a suggestion; I don't know if it improves things or not :(

@BoxyUwU have you seen what I've suggested we change it to?
Hopefully this works for you.

I'm not sure what you mean by "suggested"- anyway the docs look fine to me but it seems like no commits were added? Whoops I must have misread the docs last time sorry

Do you not see this

Nope; you need to finish your review. That's what "pending" means.

I've messed this up. I was waiting for Boxy, but it turns out that I was the one creating confusion. Here's what I suggested. The thing is that the link to [ReadOnlyWorldQuery] doesn't seem to work.

@CGMossa I think Alice is fine with it as is. Could you resolve conflicts?

Ah.. I have to rebase.. I'll see if I get to it tomorrow.

Please @bzm3r to look at the changes once more, and see if something was lost the messy rebase I did on this.

Don't merge this please; Testing if it serves it purpose shows that something is missing:
(base) PS C:\Users\angus\Documents\GitHub\bevy_fresh> cargo check --examples
    Blocking waiting for file lock on build directory
    Checking bevy v0.9.0-dev (C:\Users\angus\Documents\GitHub\bevy_fresh)
error: missing documentation for a struct
  --> examples/ecs/custom_query_param.rs:41:1
   |
41 | pub struct ReadOnlyCustomQuery<T: Component + Debug, P: Component + Debug> {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: the lint level is defined here
  --> examples/ecs/custom_query_param.rs:14:11
   |
14 | #![forbid(missing_docs)]
   |           ^^^^^^^^^^^^

error: could not compile `bevy` due to previous error

This is now fixed.

bors r+


added patch for missing sha on image string

added patch as images in gitlab registrys dont have @sha256: part of the image therefore it needs to be pulled from the image name 'RepoDigests"

Closing out all these old PRs. Feel Free to re-open if still valid.


Added MTU value to peripheral on successful handshake

Added a quick update to retrieve the MTU value for a specific peripheral. Majority of the code was already there but for whatever reason the NobleBindings.prototype.onMtu method was left blank 🤔

Please confirm those changes are working well in latest @abadonware/noble release


Incorrect routes with restrictions on babalmandab

``Hello,
As you know with the current situation of the red sea crisis, most of the vessels are passing through the cape of good hope instead of taking the babalmandab region . My problem is concerning routes for  origin/destination ports such as Singapore and Jeddah , where the vessels are passing through the cape of good hope then suez canal to meet the port call Jeddah. However, with the current argument in the route calculation function the restriction for 'babalmandab' does not seem to have any effect as I still get the route that passes through this region ( babalmandab ) .
route = sr.searoute(origin, destination,restrictions=['babalmandab'])

Hi @Niloufar375,
This was obviously a bug in the marnet network which had a hidden connected line on top of "babalmandab" passage, now it's fixed and will be visible in version 1.4.0 from pypi.
Meanwhile you can use this commit https://github.com/genthalili/searoute-py/commit/4dce9f57ea435a3ca2beefe7e3249b02496d011e

Thanks for reporting this!

Hey @genthalili !
Thanks for making the change , can I ask if you have a rough idea of when you will release the new version ?

it should be ready during coming days, latest next week.
there is a need to test some new functionalities as some important changes have been made, also feel free to test at your end for your specific case.


Secure command line flags should be configurable via environment variables

It should be possible to set the --http_credentials, --ssl_keystore_password and --ssl_keystore_path secure flags via environment variables. There is a security issue with passing them in via command line flags as their values will be visible in the process list.

That was fixed. Or is anything missing? @swartzrock

Yup fixed, thanks


Flagsmith's 'useFlags' doesn't return actual cached flags when request failed

Steps to reproduce:

open sandbox example
make sure that flags are loaded and you see rendered 'single_brand.enabled -> true' and 'multi_brand.enabled -> true'
open developer console -> 'Network' tab
find 'https://api.flagsmith.com/api/v1/flags/' request and block it using 'Block request url' feature
refresh rendered view in the sandbox using 'refresh' button

Actual behavior: when we reload the sandbox view, flagsmith sometimes loads flags with 'false' flags and sometimes with actual values from the cache.
Expected behavior: when we reload the sandbox view, flagsmith always loads flags with actual values from the cache.
Attaching gif with the reproduced issue:

Hi @vik-buchinski , thank ou for bringing this to our attention. We will take a look a prioritize it in consequence.

Hi @vik-buchinski, we already solved the problem with this PR https://github.com/Flagsmith/flagsmith-js-client/pull/193


Engine Preroll flow can lead to extra nested entries in the RasterCache

While working on fixing the cached child used in OpacityLayer (see https://github.com/flutter/engine/pull/17914) I discovered that the way we perform Preroll can lead to a parent caching an entire tree, but a child of that parent also caching its portion even though the child's cached entry will not be used during Paint.
The reason for this is that when a parent caches its subtree then we will not be recursing to the children during the Paint cycle, but we always recurse to the children on a Preroll cycle and the decision and actions to cache a layer are made during Preroll. Thus, the children always see a Preroll - and may decide to cache themselves at that point - even if they won't be Painted. There is no information currently passed down to indicate to them that they won't be eventually Painted.
While we might be able to avoid a Preroll recursion if the child layers were reused from a previous frame and have already done the Preroll processing, the actual role of Preroll in the rasterization process isn't well defined enough to understand the implications of avoiding a fresh preroll on every frame - for instance, the preroll actions might change due to CTM (easy to notice and account for) and changes in embedder status and whether we are rasterizing the frame for display or snapshot (both harder to account for).
A simpler solution may be to just null out the RasterCache when recursing to children if a given layer is planning on doing its own caching of the full subtree. We'd still need to investigate the implications of that change, though, as decisions about whether to cache a given layer are usually made after the Preroll recursion to the children so at the time when we pass the PrerollContext to the children, the decision to cache a given layer is still speculative at that point.

As a data point, hacking in the "null out the RasterCache for the children" type of solution into my fix for the OpacityLayer benchmark fix improved the 99%/worst frame times about 10% and the average and 90% about 4-5%, but in that case the child was only doing picture caching which ended up not adding a cache entry because a picture is only cached when its entry is painted multiple times and the lack of recursion during Paint() meant that we were only saving the additional calls to RasterCache::Prepare. If the child in that benchmark contained a layer that was doing its own layer caching, then the savings would be greater. More benchmarking and testing is needed to see how much that could save.

I'm wondering if there have been some work around this issue in the last months

This was fixed by https://github.com/flutter/engine/pull/31892


API improvement proposal

This is my -fresh eyed opinion- on how I believe the API should look like.
I haven't looked into the implementation intentionally (more like lazily), and just stayed at an "informed user level".
Of course this is a fake PR, it's just a way for me to convey my two cents to the conversation.

I'm still grappling with how to find the config for the given "domain" and want to use a simpler atom key instead of Module key, so I like this API better-- just need to settle on how to do that without being tedious (it's a key to module mapping somewhere).
For the defaults, yeah I think that can work now.
Can you rebase from main? Then I'll merge.

I'm not trying to erase @mayel work, I just didn't know how to solve some git related issues.

np! Merging because even a conversation is worth contribution credit :)

I think using the function for the default (such as SEO.OpenGraph.build is going to be better because developers' editors can provide docs on the function which can provide hints on what data matters for the domain, whereas plain maps or lists have no chance for those hints. That said, both will work, but I think the example will use the function.


feat: use multiple GPUs for inner product proof (PROOF-716)

Rationale for this change
Use multiple GPUs to compute inner product.
Note: the format check is failing because I think because of a difference between clang-format in the nix environment and the docker image.
What changes are included in this PR?

Rewrote inner product GPU driver to use transform algorithm
Refactored code to use a common workspace structure

Are these changes tested?
Yes. Reuses existing tests and adds a few others.

:tada: This PR is included in version 1.16.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add support for JDBC to DB's running outside ICP (e.g. DB2, Oracle)

For customers not wishing to deploy to a containerized database manager, it would be nice if there was an option to deploy the ODM components, pointing to either a DB2 or Oracle running elsewhere.

@robomeister were you able to figure this out on your own?  I am trying to get this setup now and would appreciate any pointers on how you got it working.

@lindsae This describes the topology for the ODM Standard Docker image, which has to be built manually using Docker Compose.  The steps to complete this are outlined here.
I personally ran into numerous script issues building this image in Windows and it should be easier to build in a POSIX system.

I confirm Windows is a little bit tricky due to the docker windows support. A better way on windows is to use a VM with Ubuntu.


flights widget fix (prepopulate with airport code also)

details: https://github.com/lonelyplanet/rizzo/issues/1494
related p/r: https://github.com/lonelyplanet/need-to-know/pull/365

:+1:


Add default value of assets_dir

Make asset_dir an optional variable by adding default value as assets.
This will be one less variable user has to provide when starting out.

This sounds OK to me. Tagging @johananl for UX opinions :)

Yes! :clap: I think we can default to .assets (hidden) and ensure we bail out if lokoctl is executed in a directory which doesn't contain a *.lokocfg file to avoid accidentally overwriting an unrelated directory named .assets. We could also decide to be extra safe and set the default to .lokoctl_assets.
Another note - if we make asset_dir transparent to the user, we should consider removing the "you can delete the assets dir now" message.

Another note - if we make asset_dir transparent to the user, we should consider removing the "you can delete the assets dir now" message.

But this will clutter the disk space, as asset dir is not small :/

Yes! clap I think we can default to .assets (hidden) and ensure we bail out if lokoctl is executed in a directory which doesn't contain a *.lokocfg file to avoid accidentally overwriting an unrelated directory named .assets. We could also decide to be extra safe and set the default to .lokoctl_assets.

.lokoctl_assets as default value seems reasonable to me.
However, assuming that *.lokocfg files are versioned using Git, it would be good to put asset directory outside the current directory. We could use for example $XDG_DATA_HOME/lokoctl/<cluster name> (so by default $HOME/.local/share/lokoctl/<cluster name>). But maybe that's too complicated for now.


Dependency conflict between spring-ai-redis-store and spring-data-redis

Bug description
Dependency conflict between spring-ai-redis-store-spring-boot-starter and spring-boot-starter-data-redis also spring-boot-starter-data-redis-reactive.
implementation 'org.springframework.boot:spring-boot-starter-data-redis'
implementation 'org.springframework.boot:spring-boot-starter-data-redis-reactive'
implementation 'org.springframework.ai:spring-ai-redis-store-spring-boot-starter'

Environment
Spring Boot version: 3.2.5
Spring AI version: 1.0.0-SNAPSHOT
Java version: 21
Redis vector store
Steps to reproduce
I want to use both RedisTemplate and RedisVectorStore at the same time, but I got this error.
***************************
APPLICATION FAILED TO START
***************************

Description:

The bean 'redisConnectionDetails', defined in class path resource [org/springframework/boot/autoconfigure/data/redis/RedisAutoConfiguration.class], could not be registered. A bean with that name has already been defined in class path resource [org/springframework/ai/autoconfigure/vectorstore/redis/RedisVectorStoreAutoConfiguration.class] and overriding is disabled.

Action:

Consider renaming one of the beans or enabling overriding by setting spring.main.allow-bean-definition-overriding=true

After adding spring.main.allow-bean-definition-overriding=true in application.properties got this error.
***************************
APPLICATION FAILED TO START
***************************

Description:

Parameter 2 of method vectorStore in org.springframework.ai.autoconfigure.vectorstore.redis.RedisVectorStoreAutoConfiguration required a bean of type 'org.springframework.ai.autoconfigure.vectorstore.redis.RedisConnectionDetails' that could not be found.

Action:

Consider defining a bean of type 'org.springframework.ai.autoconfigure.vectorstore.redis.RedisConnectionDetails' in your configuration.

Minimal Complete Reproducible example
plugins {
	id 'java'
    id 'org.springframework.boot' version '3.2.5'
    id 'io.spring.dependency-management' version '1.1.4'
}

group = 'com.example'
version = '0.0.1-SNAPSHOT'

java {
    sourceCompatibility = '21'
}

repositories {
	mavenCentral()
	maven { url 'https://repo.spring.io/milestone' }
}

ext {
	set('springAiVersion', "1.0.0-SNAPSHOT")
}

dependencies {
	implementation 'org.springframework.boot:spring-boot-starter-data-redis'
	implementation 'org.springframework.boot:spring-boot-starter-web'
	implementation 'org.springframework.ai:spring-ai-openai-spring-boot-starter'
	implementation 'org.springframework.ai:spring-ai-redis-store-spring-boot-starter'
	testImplementation 'org.springframework.boot:spring-boot-starter-test'
	testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
}

dependencyManagement {
	imports {
		mavenBom "org.springframework.ai:spring-ai-bom:${springAiVersion}"
	}
}

tasks.named('test') {
	useJUnitPlatform()
}

Hi @Mr-LiuDC, I've raised #1067 in order to fix this and rely on the implementations provided by spring-boot.
I talked with @tzolov about it couple of weeks ago and agree that the Redis Vector Store implementation should rely on existing Redis AutoConfiguration.

Thanks to @eddumelendez , ,this should be resolved by 0a07f65d6ab3873ecfcc6006a4afd631ab1507b7
Feel free to reopen the issue if the issue is still present.

Hi @eddumelendez , It seems that JedisClient authorization not pick up. here is same issue #1128
java.lang.RuntimeException: Could not add document: redis.clients.jedis.exceptions.JedisDataException: ERR Protocol error: unauthenticated bulk length


🐛 [cloud_firestore] runTransaction stopped working on web.

I just updated firebase to the last version and the following code is breaking on the web. On macOS it works fine.
This is the previous version I was using, which worked:
direct dependencies:
async                                 *2.8.2     *2.8.2      *2.8.2      2.9.0
cloud_firestore                       *3.3.0     3.4.0       3.4.0       3.4.0
cloud_functions                       *3.3.2     3.3.3       3.3.3       3.3.3
firebase_auth                         *3.4.2     3.5.0       3.5.0       3.5.0
firebase_core                         *1.19.2    1.20.0      1.20.0      1.20.0
firebase_database                     *9.0.19    9.0.20      9.0.20      9.0.20
firebase_storage                      *10.3.2    10.3.3      10.3.3      10.3.3
flutter_multi_formatter               *2.5.7     2.5.8       2.5.8       2.5.8

This is the code I'm running, there is nothing abnormal:
await FirebaseFirestore.instance.runTransaction((transaction) async {
          for (final data in data.websitesHistory) {
            transaction.set(documentReference, serverData.toJson());
          }
});

This is the error message (in console only, no message in IntelliJ):
Error: firebase_firestore.TransactionOptions is not a constructor
main.dart.js?v=2887564051:62600

TypeError: firebase_firestore.TransactionOptions is not a constructor

It is an horrible bug because a try/catch won't catch it. Might be coming from the platform.
Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
➜ flutter doctor -v
[✓] Flutter (Channel stable, 3.0.5, on macOS 11.4 20F71 darwin-x64, locale
    en-BR)
    • Flutter version 3.0.5 at /usr/local/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (9 days ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

Same problem here across projects.

Same problem here across projects.

The possible fix seems to have been merged https://github.com/firebase/flutterfire/pull/9188 and new version of the plugin (web) is also released: https://pub.dev/packages/cloud_firestore_web/changelog#281.
Please try using latest plugin version and see if it works.

On changelog it should be "fix runTransaction" because it is a lot more severe than it is written.


[#1519] V2 - While sending request to signatory 500 is returned when only spaces is provided for the authority_name api bugfix

Fix the issue reported by Nirupama regarding authority_name provided as space than giving 500 internal server error.
Update the validation while checking empty before that doing string trimming.

Signed-off-by: Rinkesh Bhutwala<EMAIL_ADDRESS>

@rinkeshbhutwala yes, let's move this validation to the swagger spec and allow the framework to catch these. This also has the benefit of communicating field value restrictions to the client/user/caller.


Investigate P.T. numbers under an orchard

During sprint review planning, Sabina discovered an issue where valid parent tree numbers are being displayed as invalid.
How it works:

front end retrieves a list of parent tree under an orchard
if a user types in a p.t. number that is not present in that list, then it will show up as invalid.

The sql query for fetching all p.t. under an orchard:
 SELECT DISTINCT PT.PARENT_TREE_ID AS \"parentTreeId\",
              PT.PARENT_TREE_NUMBER AS \"parentTreeNumber\",
              O.ORCHARD_ID AS \"orchardId\", Q.SEED_PLAN_UNIT_ID AS \"spu\"
            FROM PARENT_TREE PT
            JOIN PARENT_TREE_ORCHARD PTO
              ON PTO.PARENT_TREE_ID = PT.PARENT_TREE_ID
            JOIN ORCHARD O
              ON O.ORCHARD_ID = PTO.ORCHARD_ID
            JOIN PARENT_TREE_GENETIC_QUALITY Q
              ON PT.PARENT_TREE_ID = Q.PARENT_TREE_ID
            WHERE O.ORCHARD_STAGE_CODE != 'RET' AND PT.VEGETATION_CODE = ?1

@craigyu @SLDonnelly could you please provide some examples of this behavior (parent tree number and orchard ID)?

Hello @thiagosanchezenc and @craigyu, during testing I was adding valid parent tree numbers into the SMP mix screen. I believe that the rules in the front end need to be updated. In the SMP mix screen, the front end should allow parent trees outside of the orchard, but parent tree numbers that have been registered and are the correct species


Convert /pages/administrator/ShowMinorPage.jsx to Bootstrap

[ ] Conversion to Bootstrap
[ ] Implement testcafe

Ask moore about necessity of this page.

seems deprecated because UpdateMinorParticipantsWidget.jsx lists all Minor Participants


Adding ILO

Institution/School Name
I Liceum Ogólnokształcące im. Adama Mickiewicza w Białymstoku
Instiution/School Website
https://ilo.pl
Email Users

[x] Students
[x] Academic/Teaching Staff
[ ] Other/Support Staff
[ ] Alumni

Education Levels

[ ] Post-graduate research
[ ] Graduate School
[ ] College (University) or Undergraduate School or equivalent
[ ] Community College or equivalent
[x] High School or equivalent
[ ] Elementary School or equivalent

Other stuff
wikipedia page (in polish)
wayback machine site records dating from 2003

@Pavahali First stage of verification passed, official domain is ilo.pl as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@Pavahali Thank you for your patience while waiting for a review and processing your request. Pull request merged.


On Firefox, the finally method from Promise prototype don't work when a Vue project is included as a library

Version
3.8.4
Reproduction link
https://github.com/Gnuk/vue-cli-polyfill-finally-firefox-issue
Environment info
Environment Info:

  System:
    OS: Linux 5.1 Arch Linux undefined
    CPU: (8) x64 Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
  Binaries:
    Node: 10.15.3 - ~/.nvm/versions/node/v10.15.3/bin/node
    Yarn: 1.16.0 - /usr/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v10.15.3/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: 67.0.4
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0
    @vue/babel-plugin-transform-vue-jsx:  1.0.0
    @vue/babel-preset-app:  3.8.0
    @vue/babel-preset-jsx:  1.0.0
    @vue/babel-sugar-functional-vue:  1.0.0
    @vue/babel-sugar-inject-h:  1.0.0
    @vue/babel-sugar-v-model:  1.0.0
    @vue/babel-sugar-v-on:  1.0.0
    @vue/cli-overlay:  3.8.0
    @vue/cli-plugin-babel: ^3.8.0 => 3.8.0
    @vue/cli-plugin-typescript: ^3.8.0 => 3.8.1
    @vue/cli-service: ^3.8.0 => 3.8.4
    @vue/cli-shared-utils:  3.8.0
    @vue/component-compiler-utils:  2.6.0
    @vue/preload-webpack-plugin:  1.1.0
    @vue/web-component-wrapper:  1.2.0
    typescript: ^3.4.3 => 3.5.2
    vue: ^2.6.10 => 2.6.10
    vue-class-component: ^7.0.2 => 7.1.0
    vue-hot-reload-api:  2.3.3
    vue-loader:  15.7.0
    vue-property-decorator: ^8.1.0 => 8.2.1
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.6.10 => 2.6.10
    vue-template-es2015-compiler:  1.9.1
  npmGlobalPackages:
    @vue/cli: 3.8.4

Steps to reproduce
From finlib folder, launch npm i and then npm run build:lib to build the Vue project as a library.
Publish it in a npm registry (i used Verdaccio).

I don't test it using npm link.

From finhost folder, launch npm i (you propably should edit .npmrc to add your registry URL and remove package-lock.json before).
Launch the project using npm run serve and open the app on:

Firefox - You should see this message inside the terminal:[Vue warn]: Error in created hook: "TypeError: promise.finally is not a function"

found in

---> <HelloWorld> at src/components/HelloWorld.vue
       <App> at src/App.vue
         <Root> vue.runtime.esm.js:619

Chrome - There is a native usage, you will see:Finally should work

What is expected?
The finally method from Promise should work without side effects from another Vue library.
What is actually happening?
The finally method from Promise don't work on Firefox.

Maybe Firefox is not the only browser with this issue.

I am having the exact same issue on Firefox (though it seems to work without problem on Chrome)

In my research I saw that ES6 Promise is the only one exported when I use a Promise in my library part. I never tried to use finally inside the library, maybe ES7 finally Promise will be exported I don't know.

This could be possibly related to your problem:

Yes I think you're right @san-kumar but es7.promise.finally is not included inside the exported library file, you can check it with the example I put above.

Well, this seems to be a quite tricky problem.
The root cause is the same as this one: https://github.com/babel/babel/issues/9705
The promise & promise.finally polyfill used by finhost is overridden by the promise polyfill from finlib and that one does not contain the finally feature.
Because for library target we don't add default polyfills for size concerns, the promise polyfill is auto-detected and added by @babel/preset-env's usage feature.
One workaround is to change finlib/babel.config.js to:
module.exports = {
  presets: [
    ['@vue/app', {
      polyfills: ['es6.promise', 'es7.promise.finally']
    }]
  ]
}

And rebuild & republish it.


Checking instruct-pix2pix models?

Can this tool be used on instruct-pix2pix models?
When I load the original instruct-pix2pix-00-22000.safetensors model, it says that it is missing a UNET (CLIP and VAE are "broken"), and out of 1831 keys (7.17GB) there are 1386 unknown (6.4GB), and 197 useless (469MB). It says it would be pruned to 159MB. That doesn't sound right.

added in 7136a7122da6e5724c47679af37cf5939a1a65f8


feat: formatting with google style and added pre commit hooks

Description

Closes : https://github.com/devs-from-matrix/hexagonal-spring-boot-java/issues/140
Checklist:

[x] My code follows the contribution guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] My commits follow conventional commit message guidelines

was merged with https://github.com/devs-from-matrix/hexagonal-spring-boot-java/pull/156


Targeted Processor

This page should state whether the enqueued DPC runs on the processor that enqueued it, or the processor on which the ISR would run, either or neither.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52a724e2-e5ab-749c-f321-4e8e4cbc2fd9
Version Independent ID: 4425cc3f-cb48-1cc5-4518-022e2eb9300f
Content: WdfInterruptQueueDpcForIsr function (wdfinterrupt.h) - Windows drivers
Content Source: wdk-ddi-src/content/wdfinterrupt/nf-wdfinterrupt-wdfinterruptqueuedpcforisr.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Thanks @jakeoshins for the suggestion.
Fixed in #558, should be live in 10 min


.abort()

so we can test ya know

Any updates on this issue? It seems to be supported by super-agent, so it should be quite straightforward to implement…

Hey @rimiti, could you elaborate on why this issue was closed?

@rimiti friendly ping


[CVE-2019-10086] Are you using commons-beanutils

In the pom.xml, there is a section regarding commons-benutils:
https://github.com/bohnman/squiggly/blob/78598ffffeebeb8536c6056de0e77ab463abbdb1/pom.xml#L74-L78
This version of cmmons-benutils has security vulnerability CVE-2019-10086
I did a quick scan of code, it does not seem you are using it or it is pulled in by other dependencies.
Please help to clarify it. Thanks.
Derek.

Im facing the same problem. To make things worst, beanutils brings commons-logging and commons-collections which are unecessary deps. Im just excluding it for now.


Productive Card: Support for dropdown  along with actionIcons in header and footer

What package(s) are you using?

[x] Carbon for IBM Products (or Carbon for IBM Cloud & Cognitive)
[ ] Legacy/CDAI
[ ] Legacy/Security

Detailed description
Current Productive card component does not support other actionable icons or input elements ( eg: dropdown) along with overflow menu in header section. Would be nice if we have that flexibility in header and footer components of productive card to include the dropdown items or other elements along with action icons

Is this issue related to a specific component?
yes, productive card component
https://ibm-products.carbondesignsystem.com/?path=/docs/ibm-products-components-cards-productivecard--docs

What version of the @carbon/ibm-products (or @carbon/ibm-cloud-cognitive)
package are you using?
v2.7.0

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

Turbonomic
Additional information

@ArunJoshiIn This is an interesting use case we haven’t seen much of before. May be worth raising in #ibmproducts-pal for more design input before we explore this pattern further.

@ArunJoshiIn Were you able to share this with the design guild yet? If not, maybe worth reaching out to @carrenelloyd or Tomer to help advance this.

@ArunJoshiIn Were you able to share this with the design guild yet? If not, maybe worth reaching out to @carrenelloyd or Tomer to help advance this.

@elycheea - actually our implementation is being driven by design and their requirements

<EMAIL_ADDRESS>


Latency is big issue with ms bot framework

Hi,
I have developed one test bot using ms bot framework, there is so much latency in replies from the bot.
When ever user says hi, my bot also greets user, its just a simple text message preparation from app side to send it back to the user, even this whole process is taking around 10 sec with out any back end api calls to any service. I don't know where the issue is. Can please clarify on this latency issues.

@venkey1000 Take a look at this issue that might clarify some things https://github.com/Microsoft/BotBuilder/issues/915 (10 seconds is too much in any case).
I agree that latency in the directline channel has a lot of room for improvement.

Using Application Insights to track calls can be really valuable from a diagnosis perspective; and at development levels of traffic it's free to use (up to millions of events currently).
There shouldn't be any reason a request would take 10s; useful information for us would be what region your bot is deployed in, what region your user is in, and which channel you're using.

Hi @palmerabollo, @jameslew , my bot is deployed in India, if i move the deployment of bot to US, will it make any difference in latency? I am using facebook channel. Here are some of the application insights that i have found in the case of greeting user with hello message, i am accessing session stored values to get the name of the user.
Time taken(in seconds)
user->app start point (1 sec)
luis dialog match (1 to 3 sec)
after luis dialog match to preparing prompt inside dialog(1 to 2 sec)
prompts.send to user(till he receives the message) (3 to 4 sec)
Please let me know if if you find any thing from insights this case to improve latency.

I'm seeing a similar issue. There's a significant several seconds delay from the moment I'm sending a message in the bot code until it get's delivered to the FB Messenger client.
I'm developing on Linux using ngrok and I'm based in Israel.
When I deploy the bot to Azure on West-US the delay is gone and response time is good.
However, since I'm using the local setup + ngrok for development this huge delay is a major issue.

@jameslew I am facing similar issue for telegram, slack, kik, messenger, skype. There is significant delay in the response. I tried creating a bot which directly interacts with the channel (without using MBF) then the response is pretty fast. But if I use MBF then there is at least 5 second delay in the response.
My bot is deployed on Amazon in us-east-1 region.

Up until about a week ago we were only in West and East US data centers.  We now have BF data centers in SEAsia and North Europe, which should help quite a bit.  That said, for best results you should consider having your bot deployed into multiple data centers as well to have it be as local to the BF and channel services as possible.

"That said, for best results you should consider having your bot deployed into multiple data centers as well to have it be as local to the BF and channel services as possible" >> How can i do it ?

I am also facing this huge latency issue.
Isn't there any other way that moving the bot to US region?

@spreddy2714, tell us more about where your bot is deployed and what service you're using.  Its also useful to know if you're using the bot state store, luis, etc as these all take round trips to the cloud.

Bot is deployed in India. I am predominantly using on luis service & rest api calls. this is the core for my bot. Please suggest me if there are any possible tweaks/options to make it more faster.
I've used it with trail version on azure, it was fast and instant. Then I moved it to my production server(local private cloud, where the whole communication backend rest api is available.)
Then the results got too slow, but local emulator is still quick(don't understand how?).

So should we use Azure server for bot ?  i think we need a document for it on Bot Documents

I am also facing the same issue the bot is getting too much time to respond. First response is taking around 10 - 12 seconds then onwards 5-6 seconds. I am developing this bot for prestigious customer and the customer is now taking a step backward to release the bot due to this performance issue.  Can anybody help?

@spreddy2714 you're definitely paying a cross-world latency tax then for your LUIS calls, as that dc is in the US.  We're expanding our presence world-wide soon so there should be a datacenter closer to you.
That said, do you have any sort of trace representing the latencies you're seeing?  Are you seeing the Bot Builder and seeing bot state store requests as well?

@astrung there is no reason you need to use Azure servers for bot, though of course they work really well and we'd be happy to have you use them :).  Wherever you deploy though, if there's a traffic management solution (such as Azure Traffic Manager and I'm sure AWS has something as well), they can help with routing.  That said, if your users are in a similar region to where your bot and the services you depend on are, there's no need for such a distribution.

@jerinkurian Depending on how you've built your bot, that first request can be warm up time of the service your bot is hosted on; ie a cold bot on azure servers can take a few moments to warm up that isn't seen on subsequent requests.
Do you have any more information on where the time is being spent in your bot?  Have you done any profiling of which calls are taking a long time?

@jameslew
I created two bots.
Bot #1
In this bot I have a DB call(MS SQL DB hosted in azure) and few checking to the state service. I found that is taking atleast 2- 3 seconds to reach the message to the bot application. Then after DB checking and state service checking it is taking another 3 seconds so total 6 seconds.
Another problem I found that the bot is not at all responding even after 6 seconds. Feels like it is freezing and start responding after sometime. For example I asked to bot "hi" then no reply again "hi" still no reply but after sometimes I get the answer for both "hi" at the same time.
Bot #2
This is just a reply bot, whatever you are asking it will give you an echo. There is no DB check and state service check. Still it is taking 3 seconds to reply.
Some of my thoughts
My bot is deployed in Azure, and I am using the basic web app. If I use a standard price tier web app in azure to deploy the Bot will it make any difference? Same applies to MS SQL DB.

@jerinkurian @venkey1000 are you using C# or Node SDK for BotBuilder?

@nwhitmont I am using node js SDK

A lot of things are changing in Bot Framework this week. If you are still experiencing the problem, open a new issue. Thx

My Bot run perfectly fine in local machine, but i deploy in azure and test in azure, it behaves weird. Waterfall steps are sometimes not correct, it start from first step anywhere from the middle with correct input as well.

Stack Over Flow: Sorry, we are no longer accepting questions from this account.


Add support for ephemeral nodes via a special type of pre-auth key.

Also add some tests for that feature.
Other fixes: clean up a few typos in comments. Fix a bug that caused the tests to run four times each. Be more consistent in the use of log rather than fmt to print errors and notices.

This is just awesome! I am learning so much :)


Video controls design implementation

Use video player components https://www.figma.com/design/f15L42P8qyLqNkzm0Eeo8G/Owntube?node-id=16-704&t=hCyPFHcz8XjZy41R-1
to implement the video controls overlay in https://www.figma.com/design/f15L42P8qyLqNkzm0Eeo8G/Owntube?node-id=12-2107&t=hCyPFHcz8XjZy41R-1.
Add fullscreen functionality + volume control.

@mykhailodanilenko Added to Figma and here:


databingding问题

hi, can you offer app/build/intermediates/data-binding-layout-out directory structure ?

not found 'data-binding-layout-out' dir

what's your android gradle plugin's version? 3.0.1?

you can upgrade mess plugin with 'me.ele:mess-plugin:1.1.5' 😁


[Question] Can we set Tab space in WYSIWYG mode?

Currently it is 2 space for Tab, can I set it to 4?

@kelvinkoko
Currently that feature is not available. Can you explain why you need it?

@seonim-ryu
From my application user base, I got certain request about whether can change the tab to 4 space.
I think it is kind of user preference.
It may not be something everyone want. If I want to modify it, do you have any suggestion of which part of source code I can check about it.

@kelvinkoko Sorry, the answer is late.
But I have a question. In WYSIWYG, the tab is entering 4 spaces.

Didn't you originally ask that you want to change 4 to 2?


Doxygen issues

There are a few places where the Doxygen documentation appears to be processed incorrectly. For example, in Functional, a function called mathtt is listed, which seems to contain the documentation for multiple functions. Similarly, MonadPlus has a mathrm listed.

Thanks for reporting. Duping to #483.
The fundamental problem is that Doxygen is kind of broken. I just tried to fix some of the issues and failed, I think we may have to rewrite the documentation using a different tool. I remember I had stretched Doxygen to its limit when I wrote it initially, and maybe that wasn't a great idea in retrospect.


dry-run: introduce environment RESTIC_DRY_RUN

What does this PR change? What problem does it solve?
#4073
Various commands support the --dry-run flag. When restic is used as part of a scripted chain, adding/removing "--dry-run" to check the chain is tedious.
This commit introduces the evaluation of the environment variable RESTIC_DRY_RUN. If set, "--dry-run=true" is assumed. It applies to commands "backup", "forget", "prune" and "rewrite".

Was the change previously discussed in an issue or on the forum?
No.

Checklist

[x] I have read the contribution guidelines.
[x] I have enabled maintainer edits.
[x] I have added tests for all code changes.
[x] I have added documentation for relevant changes (in the manual).
[x] There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
[x] I have run gofmt on the code in all commits.
[x] All commit messages are formatted in the same style as the other commits in the repo.
[x] I'm done! This pull request is ready for review.

closed via https://github.com/restic/restic/issues/4073 and https://github.com/restic/restic/issues/3703


MVP

Update: first round of mockups is available in the designs directory (be sure to download the PDF to view all the 3 screens as the github preview doesn't seem to always render the first one).
Note: in what follows all the authentication / user account / profile creation & display is done by PREreview.
In terms of "release strategy" main idea would be to release this work under a rapid.prepreview.org subdomain under an experimental/beta flag to get user feedback asap, iterate on that feedback and then integrate the good parts to PREreview
Main page
The goal of the main page is to establish Rapid PREreview as the place where the outbreak science community comes to request, get and provide rapid feedback on their preprints.
The page is centered around:

a searchable list of preprints for which users have provided or expressed a desire to get feedback through Rapid PREreviews
clear call to actions to:

create a new Rapid PREreviews
get feedback on existing preprint content (request for Rapid PREreviews)
install the web extension to do the same thing even more easily (see section further down)

List
To start as simple as possible, the first implementation of the list will sort items by date of last Rapid PREreview created.
Later we could refine that with a score better suited to provide visibility to preprints with a high demand for feedback. Tentative definition:
score = (v+r) / (t+1)^g

where,
v = number of votes of an item
r = number of Rapid PREreviews of an item
t = time since request submission or first Rapid PREreview (unit (hours, days, weeks) to be determined)
g = tuning factor (to be determined)
Displayed data / controls for each item:

preprint title
preprint server
preprint DOI
number of Rapid PREreviews (and/or reviewer name (or anonymous alias) with link to their PREreview profile)
number of upvotes (request for Rapid PREreviews)
visualization of the aggregated data collected from the structured reviews
date of first & last review made
call to action to add a Rapid PREreview
call to action to request a Rapid PREreview or express the desire to see more reviews (upvote)

Search options:

Facets (filter by):

preprints with requests for Rapid PREreviews (votes)
preprints with Rapid PREreviews
Preprint server
Dates of last posted review (last week, last month, etc.)
Structured data collected by the Rapid PREreview creation form (see #6 for the list of facets)

Full text search:

Author name / username / anonymous alias of the Rapid PREreview creator
Rapid PREreview textual content (if any)
preprint title

Other indexes

preprint DOI
preprint URL

When users perform a search the end of the list will re-iterate the call to actions to start a new Rapid PREreview or request for Rapid PREreview in case the desired content wasn't found.
Users opting to view details about an item are taken to the Rapid PREreview display page (see section further down)
Note: this list (and associated search indexes) is only generated from the data collected during the rapid PREreview creation process to minimize complexity and avoid having to maintain a sync engine / index of all the different preprint servers content. However, PREreview already provides and maintains an index of all the different preprint servers so we could merge with PREreview at a later stage. In the same way, if the maintenance of the index is difficult, PREreview could adopt the simpler approach described here.
Create new Rapid PREreview call to action
Users clicking on the call to action are asked to provides a DOI (or URL) of the preprint to review. At that point we try to get as much metadata as we can from this information (see https://github.com/PREreview/rapid-prereview/issues/9) and transition the user to the Rapid PREreview creation and display page (see section further down). As a fallback, if we couldn't get metadata about the preprint the user will be asked to enter the DOI and title manually.
(if user is not logged in, user is sent through the PREreview login workflow and redirected to the page on login success)
Request for Rapid PREreviews call to action
Logged in users can:

add entries by providing a DOI (or URL) using the same workflow as described above
upvote existing entries (see score definition above)

Install web extension call to action
(see section further down for description)
Rapid PREreview creation and display page
This page is designed to work as a "fallback" in cases when users haven't / cannot / don't want to install the web extension (see dedicated section below). It is however fully functional (and styled).
The rendering logic depends on the Content Security Policy set by the preprint server hosting the content to review:

if framing is allowed, an iframe displaying the preprint content is rendered and complemented by:

a panel (or shell) containing the list of existing Rapid PREreviews
a shell containing the Rapid PREreview creation form (see #1  for screenshot of a "shell")

if framing is not allowed (e.g., Content-Security-Policy: frame-ancestors 'none') then a UI with a full window version of the list of existing Rapid PREreviews and the Rapid PREreview creation form is displayed (and complemented by metadata about the preprint (title etc.)).

The list of existing rapid PREreviews will be complemented with a summary view (interactive data visualization) allowing the user to quickly visualize aggregated results.
In both case a (permanently dismissible) call to action to install the Rapid PREreview browser extension is displayed.
When the user is not logged in (or is logged in but has already posted a Rapid PREreview), the UI to create new Rapid PREreviews is not displayed (a call to log in is added when the user is not logged in).
Note: this page is relatively similar to the one provided by PREreview with the main difference that the UI is designed to be able to also work in an extension context where we do not have control on the host page. It will be relatively easy to backport the structured review functionality to PREreview (allowing users to select the Rapid PREreview template from PREreview) or to modify the PREreview page to use a similar overlay UI and leverage the web extension described below.
Web extension
Note: development of the web extension will only start after the other parts of the MVP have been completed.
The goal of the web extension is to bring the features of Rapid PREreview where / when the user need it (therefore reducing the effort needed to write or request Rapid PREreviews). The extension is designed so that if a user visit a preprint, he/she is informed (in a non intrusive way) that he/she can Rapid PREreview it immediately (and without context switch) or ask for it to be reviewed (see upvotes and scores above).
Popup icon
the popup icon is part of the browser and lives next to the browser URL and as such is visible at all time
The icon is "highlighted" (different color / icon etc.) when:

user is on a preprint content page that has been reviewed by members of the Rapid PREreview community (in this case the icon is complemented by a badge indicating the number of Rapid PREreviews)
user is on a preprint content page that could be reviewed with a rapid PREreview
user is on a preprint content page object of a "request for rapid PREreview"  (in this case the icon is complemented by a badge indicating the number of requests (upvotes))

Popup UI
Clicking on the popup icon opens a popup window/menu (located right below the popup icon) containing (when relevant):

An invitation for the user to start to write a Rapid PREreview for the page currently visited by injecting new overlay UI to the page (see content script section below)
An invitation for the user to request for Rapid PREreview for the page currently visited
The list of preprints for which users have requested Rapid PREreviews sorted by score (see definition above)
A feedback section to improve the quality of the extension and allow users to easily:

report URLs where the popup icon should have activated but didn't
report URLs where the popup icon should not have activated but did

Content script
features injected by the extension to the webpage currently visited by the user
The content script will share its code with the Rapid PREreview creation and display page (see section above) and inject 2 UI elements (working as overlay) to the page visited:
Rapid PREreview editor
Rapid PREreview creation form displayed in a shell
Existing Rapid PREreviews panel
Panel (or shell) containing a list of existing Rapid PREreviews for the visited page content
Note: the web extension could easily be generalized to PREreview if proven useful (and we will track usage / adoption data).
See also:
#1, #3, #4, #6

History:

Rewrite of the main page section based on feedback from @halmos and @georgiamoon on slack (see https://prereview.slack.com/archives/CNCG9UC15/p1568777139003000)
Clarification of the intents / motivations of the main page and web extension
Updated link to form to https://github.com/PREreview/rapid-prereview/issues/6
Simplified list sorting for first version per @majohansson slack comment
Added link to mockups

🎉


Update instructions to help OS X users

Updating the docs to help OS X users. Some packages etc are automagically added by VS but not VS Code.

@davidfowl looks like all the changes were already integrated by other PRs, so closing. Cheers!


Requirements for streamlined publisher

Some thoughts:

Push changes to https://github.com/disinfoRG/datasets repo incrementally.
Upload packaged dataset files to Google Drive daily.
Upload newly published data to Elasticsearch incrementally.

(1) and (3) are by parsing time. (2) is by producer.  We may have to publish every few hours considering the data size.

Oops this belongs to ArticleParser.


Scan fails with error code -9

Hi,
I've been running clamscan in my ubuntu machine for the past few weeks and I've been able to run it successfully. However, when I try to run the same using the docker container using the dockerfile in AWS lambda, I keep running into error code -9. There is no specific reason as to why this is failing. I'm attaching the exception stack below:
[ERROR] Exception:
{
    "source": "serverless-clamscan",
    "input_bucket": "chatbot-nlu-models",
    "input_key": "clamscan/test1.log",
    "status": "ERROR",
    "message": "ClamAV exited with unexpected code: -9.\nOutput: "
}

Traceback (most recent call last):
  File "/var/task/lambda.py", line 80, in lambda_handler
    summary = scan(
  File "/var/task/lambda.py", line 289, in scan
    report_failure(input_bucket, input_key, download_path, e.message)
  File "/var/task/lambda.py", line 203, in report_failure
    raise Exception(json.dumps(exception_json))

What version of of the construct are you using?
Can you share a code snippet for how you are using it?

@dontirun, thanks for your reply.
So, I'm just using the Dockerfile and lamda from cdk-serverless-clamscan/assests/lambda/code/scan.
I'm using the exact same Dockerfile for building the image, and I've modified the lambda slightly. I'm downloading the av definitions to a temp directory and using the defs from this temp directory to scan. I'm attaching snippets here for reference. Please let me know if you need more information.
command = [
            "clamscan",
            "-v",
            "--stdout",
            f"--max-filesize={MAX_BYTES}",
            f"--max-scansize={MAX_BYTES}",
            f"--database={definitions_path}",
            "-r",
            f"--tempdir={tmp_path}",
            f"{download_path}",
        ]
        scan_summary = subprocess.run(
            command,
            stderr=subprocess.STDOUT,
            stdout=subprocess.PIPE,
        )

For downloading avdefs, I'm using download_s3_defs method in lambda provided under download_defs directory.
My clamav installation is done using the exact same dockerfile attached below.
Dockerfile.txt
Thanks in advance.

I'm downloading the av definitions to a temp directory

You're probably running out of space in /tmp unless you increased it to a larger limit

Thanks for the response @dontirun . I'm now able to run the scan successfully. I've configured the max limit of 10240MB for /tmp directory. What would be the ideal size to for this /tmp directory?

Depends on your situation, the /tmp directory is shared across concurrent executions of your Lambda function. So it depends on how many scans you are doing at a time and the size of the files

Got it, thanks for the clarification @dontirun . I'm closing this.


error 500 when trying to initialize the doc.page

I'm sure that there is an error from my side but I don't know what it is, because I'm not able to see the exception anywhere.
I'm trying to build the doc for https://github.com/vincenzopalazzo/changelog.dart and I configured the repository as the doc suggested. However, I receive the following error https://docs.page/vincenzopalazzo/changelog.dart
Any idea?

Interesting, could the cause be that your repo has "dot" in the name be the cause? Setup looked OK to me, just working on docs.page setup too.  So I just came here to check open issues to be aware of and saw your question. Maybe test with another dummy repo without "." in the repo name, just to test the theory.
My docs.page is still a work in progress: https://docs.page/rydmike/flex_color_scheme_docs (repo https://github.com/rydmike/flex_color_scheme_docs) but never saw any issue like that.
I must say I really like docs.page, so simple to work with. Sure not a super lot of features, but I don't really need more for a documentation site. I would not even mind using this for personal totally clutter and ad free tech/code blog :)

Yes! reproduced https://docs.page/vincenzopalazzo/cpstl
I think that the problem is the . in the name

Hey! thanks for reporting this - looking into it now. We've recently switched to remix and it could be the . isn't being handled correctly in the routes.

Hey! thanks for reporting this - looking into it now. We've recently switched to remix and it could be the . isn't being handled correctly in the routes.

Yeah, sorry but I love the dot convention in the name :)

ah i think I found the issue -
in your frontmatter you need to put the description in double quotes -
description: "changelog.dart: a collection of tools to manages in a fashion way a repository as maintainer."

I must say I really like docs.page, so simple to work with. Sure not a super lot of features, but I don't really need more for a documentation site. I would not even mind using this for personal totally clutter and ad free tech/code blog :)

Thanks! Any suggestions for features you might like?

Going to close this as it seems it's working for you :) feel free to reopen if it still has issues.


How can I add a CachedImage to the background of a content page ?

I'm using BackgroundImage property to set a image to the background of my content page.
And I'm using cached images inside of the content page.
Now I want to add a cached image to the background too. So how can I do it ?
This is the XAML in my content page heaader...
<ContentPage xmlns="http://xamarin.com/schemas/2014/forms"              xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"              x:Class="MdiChat.View.LoginPage"              xmlns:ffimageloading="clr-namespace:FFImageLoading.Forms;assembly=FFImageLoading.Forms"              Title="LoginPage" BackgroundImage="CoverC.jpg"              >

Hello @kgbuddhima
I think, it's very strange idea.
Are you sure you need it? :)
CachedImage is View, but BackgroundImage property of Page is ImageSource.
You aren't able to set CachedImage into this property.
But you are able to add AbsoluteLayout as ParentView of your page, then add CachedImage as first child with Bounds (0,0,1,1) and flags All. So, you can get result by this way.
But I want to repeat -> it's very strange idea)

Hello Andrei,
Thank you very much for your solution !
And I'll try like this.
Thank you again !

@AndreiMisiukevich  Thanks for a proposed solution. @kgbuddhima You can also use Grid/ StackLayout for that.


oninsertrow event documentation needs an update

Hi, I have been using jspreadsheet with jquery. I wanted to control when a new row is inserted and was using the event callback
oninsertrow(DOMElement el, Number rowNumber, Number numOfRows, Boolean insertBefore)
I looked at the documentation in https://jspreadsheet.com/v7/docs/quick-reference
But I realized that instead of the insertBefore variable, I was receiving the cells for the row inserted. I have tried and found that the insertBefore is returned in the next parameter and it is not documented. So it would be great to update this information for future users.
oninsertrow(DOMElement el, Number rowNumber, Number numOfRows, any[] rowRecords, Boolean insertBefore)

Hi,
Exact, thank you
@paulhodel it's for you 😊 (Pro version)


Suggested update to DataFrame#to_matrix

Hey ya'll. Trying to create a matrix of all my data including categorical. Why does Daru::DataFrame#to_matrix only include numerical data?
could we potentially create an opt out for this functionality?
Current:
    def to_matrix
      Matrix.columns each_vector.select(&:numeric?).map(&:to_a)
    end

Suggestion(untested):
    def to_matrix(only_numeric: true)
      if only_numeric
        Matrix.columns each_vector.select(&:numeric?).map(&:to_a)
      else
        Matrix.columns each_vector.map(&:to_a)
    end

I can put in a PR if you want? Just wanted get feedback and see if I am missing something first.


feat: focus indicators for accessibility.

Added focus indicator for button and hyperlinks in line with web aim accessibility, guides and converted span into hyperlinks so that they can be better accessed by people who rely on the keyboard for accessibility.
https://webaim.org/techniques/keyboard/

Feel free to reopen when ready


Fetch full dataset from EMPIAR for Chlamydomonas reinhardtii

Fetch all the data available for https://www.ebi.ac.uk/empiar/EMPIAR-11830/ to our s3 buckets.

This is complete!


Correct the include target file in LeanVTK-config.cmake

Without this linking a target "LeanVTK::LeanVTK" in cmake does not work.

Thanks very much for the fixes!!!


Add Window UIMove mode: face user, but rotate around Y only

Describe the feature
Currently, UIMove.FaceUser on WindowBegin() will result in a window that tilts forward/backward when it is placed above/below the user's head position. This isn't always desirable, although having the window rotate vertically (only) to keep facing the user usually is preferred.
Can we have a new UIMove.FaceUserYRotationOnly (or something like that) to only rotate the window around Y to keep facing the user?

You can quash extra rotation to try out a Y axis only! This does tilt a small bit while you are interacting with it, which isn't ideal, but may get you pretty close to what you're looking for.
UI.WindowBegin(...
windowPose.orientation.x = 0;
windowPose.orientation.z = 0;
windowPose.orientation.Normalize();

I don't really love Y axis only rotation for Windows, but I do really like it for object placement. I have been meaning to add something like this for a while, but the quaternion quashing has worked pretty well for me so far. I'm not sure I remember seeing the tilt previously, so maybe I've made a change recently that's doing that.

I actually would be quite interested in more specifics about what doesn't work well for the FaceUser for Windows! That's one I'd like to be basically a really good default for UI, so if I can improve it for that case, I'd love to know. Like what would you prefer to happen when the window is above or below the user's head? Would a reduced tilt suffice?

I think my main problem with the window tilt is that there's no easy way to get rid of it once it's introduced.
This usually happens when developing sitting down, starting the app, then getting up and so needing to move the window up to standing height. Now there's tilt to the window and it remains that way unless I try really hard to position my head height and hand grab position to get back to a vertical window again.
Another case is during demos when successive people of different height grab the window to move it up or down. This usually introduces tilt, which might match some people's height but other's definitely won't.


XLog encryption: check the possibility of not full pages writes and its implications

Also implications for replication of full_page_writes = off and/or walsender/walreceiver crash since we have to have a page header to calculate an IV

Non-full page writes may happen only during replication. Otherwise, it is always written and read by pages.
While XLog writes and reads we store the last observed page header so we can set proper IV if it happens that the read/write is from the middle of the page. That's pretty much enough as standby after the crash will request the XLog all the way from the beginning of the current segment (hence from the beginning of a page).  As well as the backend will load the full page to the XLog buffer after restart.
full_page_writes = off - is the Buffer pages, not XLog. This option doesn't influence XLogWrite/Read.
TOAST is always split into chunks that fit into a tuple and the XLog page.


Support for PySpark

Is your feature request related to a problem? Please describe.
Hello, I see that this package supports Pandas, but does it support pyspark? I'd like to use this on large datasets and pandas is insufficient for my use case.
Describe the outcome you'd like:
I'd like to be able to run this on large datasets over 10k+ rows. Do you think this would be possible?

Depends on how many columns you are also dealing with, but my first though is you should be fine at that data size, @gracemiguel. Thanks!

@gracemiguel any additional questions on this? Any luck using? Thanks!


where is the dataset?

@sunshineywz123 @ZuoJiaxing
Because the training dataset uses YouTube videos, which capture many people's faces, there are privacy and copyright issues involved, so we will publish the training-related content once we have resolved this aspect. We will do so as soon as possible. Please be patient with us for a little while longer, your ATTENTION is much appreciated.

@sunshineywz123 @ZuoJiaxing
Sorry for the long wait, I have now released the code for video data generation. Please refer to the README for relevant information.


Package Requested

[X] I would like someone else to build the manifest.
[ ] I would like help so I can submit the manifest.
[ ] I have performed a search and couldn't find this package.
[ ] I have checked that the installer for this package is not contained in a .zip file
[X] I think there is a new version available and I have provided the URL.

Please provide the following information
Current packages is 21.09 for CLI. Version 22.09 is available (zip only).
Download page: https://mediaarea.net/en/MediaInfo/Download/Windows

GUI added here https://github.com/microsoft/winget-pkgs/pull/83395
CLI is contained in a .zip package.

@denelon Could you please add the ZIP label?

MediaArea.MediaInfo is up to date


Feature request: for debug canvas draws, can we manipulate draw color by entity type

each entity in my system has a color assigned to it, it would be 'neat' if i could manipulate the canvas strokestyle by entity...
just a though...

each entity in my system has a color assigned to it, it would be 'neat' if i could manipulate the canvas strokestyle by entity...
just a though...

hello sorry for late reply
if you something like:
class Character extends Box {
  draw(context: CanvasRenderingContext2D) {
    context.strokeStyle = '#ff0000';
    super.draw(context);
  }
}

class Obstacle extends Box {
  draw(context: CanvasRenderingContext2D) {
    context.strokeStyle = '#0000ff';
    super.draw(context);
  }
}

https://github.com/Prozi/detect-collisions/blob/master/src/bodies/polygon.ts#L273C1-L275C1
you should achieve what you need. this will override the draw class of those bodies and when you use them with system.draw(ctx) or body.draw(ctx) it will work like you desire
best regards, Jacek.
does this solve your request?

class ColoredBox extends Box {
draw(context: CanvasRenderingContext2D) {
context.strokeStyle = this.color;
super.draw(context);
}
}

or something more generic like above

I will check this out and let you know what i come up with... thanks for getting back to me

I will check this out and let you know what i come up with... thanks for getting back to me

I think it's fair to assume it works, closing


Add "manual" clap alias for -A

This is requested as a feature, but because clap does not support
"short" aliases, we have to create another clap argument for this.
Not the best possible way to implement this (because the best way would
be to patch clap itself to allow short aliases) but the fastest one.

Closes #147

Here you go. Sorry, I was at work the whole day.


pytorch_lightning.utilities.exceptions.MisconfigurationException: ReduceLROnPlateau conditioned on metric val_loss

  | Name           | Type                | Params
-------------------------------------------------------
0 | encoder        | DimeNetPlusPlusWrap | 2.2 M
1 | decoder        | GemNetTDecoder      | 2.3 M
2 | fc_mu          | Linear              | 65.8 K
3 | fc_var         | Linear              | 65.8 K
4 | fc_num_atoms   | Sequential          | 71.2 K
5 | fc_lattice     | Sequential          | 67.3 K
6 | fc_composition | Sequential          | 91.5 K
-------------------------------------------------------
4.9 M     Trainable params
123       Non-trainable params
4.9 M     Total params
19.682    Total estimated model params size (MB)
/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py:631: UserWarning: Checkpoint directory /scratch/harsha.vasamsetti/hydra/singlerun/2023-05-26/perov exists and is not empty.
  rank_zero_warn(f"Checkpoint directory {dirpath} exists and is not empty.")
Validation sanity check: 0it [00:00, ?it/s]/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/torch_geometric/deprecation.py:13: UserWarning: 'data.DataLoader' is deprecated, use 'loader.DataLoader' instead
  warnings.warn(out)
/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/data_loading.py:116: UserWarning: The dataloader, val_dataloader 0, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 40 which is the number of cpus on this machine) in the `DataLoader` init to improve performance.
  rank_zero_warn(
Validation sanity check:   0%|                                                                | 0/2 [00:00<?, ?it/s]/scratch/harsha.vasamsetti/cdvae/cdvae/common/data_utils.py:622: UserWarning: To copy construct from a tensor, it is recommended to use sourceTensor.clone().detach() or sourceTensor.clone().detach().requires_grad_(True), rather than torch.tensor(sourceTensor).
  X = torch.tensor(X, dtype=torch.float)
/scratch/harsha.vasamsetti/cdvae/cdvae/common/data_utils.py:618: UserWarning: To copy construct from a tensor, it is recommended to use sourceTensor.clone().detach() or sourceTensor.clone().detach().requires_grad_(True), rather than torch.tensor(sourceTensor).
  X = torch.tensor(X, dtype=torch.float)
/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/utilities/data.py:59: UserWarning: Trying to infer the `batch_size` from an ambiguous collection. The batch size we found is 10. To avoid any miscalculations, use `self.log(..., batch_size=batch_size)`.
  warning_cache.warn(
/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/data_loading.py:116: UserWarning: The dataloader, train_dataloader, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 40 which is the number of cpus on this machine) in the `DataLoader` init to improve performance.
  rank_zero_warn(
/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/data_loading.py:412: UserWarning: The number of training samples (23) is smaller than the logging interval Trainer(log_every_n_steps=50). Set a lower value for log_every_n_steps if you want to see logs for the training epoch.
  rank_zero_warn(
Epoch 0: 100%|█| 23/23 [00:09<00:00,  2.53it/s, loss=91.2, v_num=t2wv, train_loss_step=80.70, train_natom_loss_step=Error executing job with overrides: ['data=perov', 'expname=perov']
Traceback (most recent call last):
  File "cdvae/run.py", line 167, in main
    run(cfg)
  File "cdvae/run.py", line 155, in run
    trainer.fit(model=model, datamodule=datamodule)
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 738, in fit
    self._call_and_handle_interrupt(
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 683, in _call_and_handle_interrupt
    return trainer_fn(*args, **kwargs)
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 773, in _fit_impl
    self._run(model, ckpt_path=ckpt_path)
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1195, in _run
    self._dispatch()
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1275, in _dispatch
    self.training_type_plugin.start_training(self)
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 202, in start_training
    self._results = trainer.run_stage()
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1285, in run_stage
    return self._run_train()
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1315, in _run_train
    self.fit_loop.run()
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 145, in run
    self.advance(*args, **kwargs)
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/loops/fit_loop.py", line 234, in advance
    self.epoch_loop.run(data_fetcher)
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 151, in run
    output = self.on_run_end()
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 303, in on_run_end
    self.update_lr_schedulers("epoch", update_plateau_schedulers=True)
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 441, in update_lr_schedulers
    self._update_learning_rates(
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 486, in _update_learning_rates
    raise MisconfigurationException(
pytorch_lightning.utilities.exceptions.MisconfigurationException: ReduceLROnPlateau conditioned on metric val_loss which is not available. Available metrics are: ['train_loss', 'train_loss_step', 'train_natom_loss', 'train_natom_loss_step', 'train_lattice_loss', 'train_lattice_loss_step', 'train_coord_loss', 'train_coord_loss_step', 'train_type_loss', 'train_type_loss_step', 'train_kld_loss', 'train_kld_loss_step', 'train_composition_loss', 'train_composition_loss_step', 'train_loss_epoch', 'train_natom_loss_epoch', 'train_lattice_loss_epoch', 'train_coord_loss_epoch', 'train_type_loss_epoch', 'train_kld_loss_epoch', 'train_composition_loss_epoch']. Condition can be set using `monitor` key in lr scheduler dict

When training the code, I am receiving this error.

  | Name           | Type                | Params
-------------------------------------------------------
0 | encoder        | DimeNetPlusPlusWrap | 2.2 M
1 | decoder        | GemNetTDecoder      | 2.3 M
2 | fc_mu          | Linear              | 65.8 K
3 | fc_var         | Linear              | 65.8 K
4 | fc_num_atoms   | Sequential          | 71.2 K
5 | fc_lattice     | Sequential          | 67.3 K
6 | fc_composition | Sequential          | 91.5 K
-------------------------------------------------------
4.9 M     Trainable params
123       Non-trainable params
4.9 M     Total params
19.682    Total estimated model params size (MB)
/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py:631: UserWarning: Checkpoint directory /scratch/harsha.vasamsetti/hydra/singlerun/2023-05-26/perov exists and is not empty.
  rank_zero_warn(f"Checkpoint directory {dirpath} exists and is not empty.")
Validation sanity check: 0it [00:00, ?it/s]/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/torch_geometric/deprecation.py:13: UserWarning: 'data.DataLoader' is deprecated, use 'loader.DataLoader' instead
  warnings.warn(out)
/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/data_loading.py:116: UserWarning: The dataloader, val_dataloader 0, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 40 which is the number of cpus on this machine) in the `DataLoader` init to improve performance.
  rank_zero_warn(
Validation sanity check:   0%|                                                                | 0/2 [00:00<?, ?it/s]/scratch/harsha.vasamsetti/cdvae/cdvae/common/data_utils.py:622: UserWarning: To copy construct from a tensor, it is recommended to use sourceTensor.clone().detach() or sourceTensor.clone().detach().requires_grad_(True), rather than torch.tensor(sourceTensor).
  X = torch.tensor(X, dtype=torch.float)
/scratch/harsha.vasamsetti/cdvae/cdvae/common/data_utils.py:618: UserWarning: To copy construct from a tensor, it is recommended to use sourceTensor.clone().detach() or sourceTensor.clone().detach().requires_grad_(True), rather than torch.tensor(sourceTensor).
  X = torch.tensor(X, dtype=torch.float)
/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/utilities/data.py:59: UserWarning: Trying to infer the `batch_size` from an ambiguous collection. The batch size we found is 10. To avoid any miscalculations, use `self.log(..., batch_size=batch_size)`.
  warning_cache.warn(
/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/data_loading.py:116: UserWarning: The dataloader, train_dataloader, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 40 which is the number of cpus on this machine) in the `DataLoader` init to improve performance.
  rank_zero_warn(
/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/data_loading.py:412: UserWarning: The number of training samples (23) is smaller than the logging interval Trainer(log_every_n_steps=50). Set a lower value for log_every_n_steps if you want to see logs for the training epoch.
  rank_zero_warn(
Epoch 0: 100%|█| 23/23 [00:09<00:00,  2.53it/s, loss=91.2, v_num=t2wv, train_loss_step=80.70, train_natom_loss_step=Error executing job with overrides: ['data=perov', 'expname=perov']
Traceback (most recent call last):
  File "cdvae/run.py", line 167, in main
    run(cfg)
  File "cdvae/run.py", line 155, in run
    trainer.fit(model=model, datamodule=datamodule)
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 738, in fit
    self._call_and_handle_interrupt(
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 683, in _call_and_handle_interrupt
    return trainer_fn(*args, **kwargs)
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 773, in _fit_impl
    self._run(model, ckpt_path=ckpt_path)
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1195, in _run
    self._dispatch()
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1275, in _dispatch
    self.training_type_plugin.start_training(self)
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 202, in start_training
    self._results = trainer.run_stage()
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1285, in run_stage
    return self._run_train()
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1315, in _run_train
    self.fit_loop.run()
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 145, in run
    self.advance(*args, **kwargs)
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/loops/fit_loop.py", line 234, in advance
    self.epoch_loop.run(data_fetcher)
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 151, in run
    output = self.on_run_end()
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 303, in on_run_end
    self.update_lr_schedulers("epoch", update_plateau_schedulers=True)
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 441, in update_lr_schedulers
    self._update_learning_rates(
  File "/home2/harsha.vasamsetti/miniconda3/envs/cdvae/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 486, in _update_learning_rates
    raise MisconfigurationException(
pytorch_lightning.utilities.exceptions.MisconfigurationException: ReduceLROnPlateau conditioned on metric val_loss which is not available. Available metrics are: ['train_loss', 'train_loss_step', 'train_natom_loss', 'train_natom_loss_step', 'train_lattice_loss', 'train_lattice_loss_step', 'train_coord_loss', 'train_coord_loss_step', 'train_type_loss', 'train_type_loss_step', 'train_kld_loss', 'train_kld_loss_step', 'train_composition_loss', 'train_composition_loss_step', 'train_loss_epoch', 'train_natom_loss_epoch', 'train_lattice_loss_epoch', 'train_coord_loss_epoch', 'train_type_loss_epoch', 'train_kld_loss_epoch', 'train_composition_loss_epoch']. Condition can be set using `monitor` key in lr scheduler dict

When training the code, I am receiving this error.

Hi, I have the same issue, Did you solve it?

Hi, I changed the 'strict' parameter in the scheduler to 'False' (by default it should be True) and solved the problem. Here is how I modified the configure_optimizer function:
def configure_optimizers(self):
        opt = hydra.utils.instantiate(
            self.hparams.optim.optimizer, params=self.parameters(), _convert_="partial"
        )
        if not self.hparams.optim.use_lr_scheduler:
            return [opt]
        scheduler = hydra.utils.instantiate(
            self.hparams.optim.lr_scheduler, optimizer=opt
        )

        return {"optimizer": opt,
                "lr_scheduler": {
                    "scheduler": scheduler,
                    "monitor": "val_loss",
                    "strict": False}}


Revise deprecated FromInt to FromInt32

Please provide a description of this PR:

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests-arm64

unit-tests_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests-arm64

unit-tests_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests

integ-basic-arm64_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests-arm64

unit-tests_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests

integ-basic-arm64_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test integ-basic-arm64

integ-ds_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests-arm64

unit-tests_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests

integ-basic-arm64_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test integ-basic-arm64

integ-ds_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test integ-ds

integ-distroless_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests-arm64

unit-tests_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests

integ-ds_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test integ-ds

integ-distroless_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test integ-distroless

integ-basic-arm64_istio
e96931b7db605fd0bd1f106245df57c422831c16
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests-arm64

unit-tests_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests

integ-ds_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test integ-ds

integ-basic-arm64_istio
e96931b7db605fd0bd1f106245df57c422831c16
link
true
/test integ-basic-arm64

integ-distroless_istio
e96931b7db605fd0bd1f106245df57c422831c16
link
true
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests-arm64

unit-tests_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests

integ-basic-arm64_istio
e96931b7db605fd0bd1f106245df57c422831c16
link
true
/test integ-basic-arm64

integ-distroless_istio
e96931b7db605fd0bd1f106245df57c422831c16
link
true
/test integ-distroless

integ-ds_istio
e96931b7db605fd0bd1f106245df57c422831c16
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
8b0e9159246e249e78e7230d1585ce9a6d5d0753
link
true
/test unit-tests

integ-basic-arm64_istio
e96931b7db605fd0bd1f106245df57c422831c16
link
true
/test integ-basic-arm64

integ-distroless_istio
e96931b7db605fd0bd1f106245df57c422831c16
link
true
/test integ-distroless

integ-ds_istio
e96931b7db605fd0bd1f106245df57c422831c16
link
true
/test integ-ds

integ-pilot_istio
e96931b7db605fd0bd1f106245df57c422831c16
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.