Mark read article as unread

There should be a filter to mark read files, as unread. I don't see a way to do that. Glenn

There should be a filter to mark read files, as unread

I'm not sure what you mean by "filter", but you can mark read articles as unread using the context (right or control-click) menu:

You are correct about the contextual menu option. However, in NNW 4.1 “Mark as unread”, is available in the “Article” pulldown menu item. Why not 5.x? And isn’t this a filter that changes the view of the item, but doesn’t actually delete it? I am not a programmer, so if I am not phrasing this correctly, I am sorry. Just trying to help make 5.x a great experience.
Glenn

On Mar 5, 2019, at 7:25 AM, Jason Madden<EMAIL_ADDRESS>wrote:
There should be a filter to mark read files, as unread
I'm not sure what you mean by "filter", but you can mark read articles as unread using the context (right or control-click) menu:
https://user-images.githubusercontent.com/1256082/53805295-5f73e180-3f0f-11e9-9edf-244bd39c0824.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/brentsimmons/NetNewsWire/issues/579#issuecomment-469661362, or mute the thread https://github.com/notifications/unsubscribe-auth/At2jRyY_6qMbBvRtC38ngx2nmlj5FgsVks5vTmJSgaJpZM4bd31c.

////////////////////////////////////
"It's a good idea to start getting used to Mac OS X, even if you're not a Mac person,
because Apple's advances usually light the way for the rest of the computer industry."
–New York Times 3/29/01

You’re right: it should be in the Article menu.
Other things that also work: the u key marks the current article as read. And the toolbar button (that looks like a checkmark in a circle) toggles the status (so, if it’s read, it’s marked unread).

Thanks for letting me know about the checkmark button. It every time I moused over it always said “Mark as unread”. Had no idea it was contextual.
Thanks,
Glenn

On Mar 5, 2019, at 4:14 PM, Brent Simmons<EMAIL_ADDRESS>wrote:
You’re right: it should be in the Article menu.
Other things that also work: the u key marks the current article as read. And the toolbar button (that looks like a checkmark in a circle) toggles the status (so, if it’s read, it’s marked unread).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/brentsimmons/NetNewsWire/issues/579#issuecomment-469859738, or mute the thread https://github.com/notifications/unsubscribe-auth/At2jRxXu-LhnLU9SqfQ-U7wd8Y3HePDtks5vTt5KgaJpZM4bd31c.

//////////////////////////
Never ask what sort of computer a guy drives.
If he's a Mac user, he'll tell you. If not, why embarrass him?
– Tom Clancy

The menu item 'Mark as Unread' is in fact present in the Article menu. It only appears if articles are selected and it makes sense to mark as unread.
@glenng6 Is that what you have in mind:


[Add] itemset function to fill in a scalar at the certain coordinates of a ndarray

Add itemset function to fill in a scalar at the certain coordinates of a ndarray.
It is similar to numpy.ndarray.itemset. It is better then __setitem__.
Now we have both item and itemset function to read and write a scalar into the array.
import numojo as nm

fn main() raises:
    var A = nm.zeros[nm.i16](3, 3)
    print(A)
    A.itemset(5, 256)
    print(A)
    A.itemset(List(1,1), 1024)
    print(A)

Considering that itemset got removed from numpy in 2.0 do we still want to have it or if we do should we name it that?

I think we should keep these features for now given the possibility that Mojo might not resolve the symmetric getter and setter problem anytime soon. In such case, having the item and itemset temporarily will be a good option. We can deprecate it later if needed.

Either we need to pin the numpy to <2.0 or we need to rewrite the numpy part of the test to use array[index]=value.

Yes. I will rewrite the file using A[0] = 1.

Talk about this. We can maybe use the following way for setitem and getitem to indicate that we want a scalar instead of a ndarray. Namely, enclose the coordinates in a tuple or list.
A[(0)]
A[(0, 1)]

Talk about this. We can maybe use the following way for setitem and getitem to indicate that we want a scalar instead of a ndarray. Namely, enclose the coordinates in a tuple (we now already have list as input).
A[(0)] A[(0, 1)]

Okay, it is not possible now because the Tuple type is not yet iterable.

@forFudan @MadAlex1997 What's your opinion of doing something like the following instead of item, itemset.
struct item():
    ...

var A = NDArray[i32](10, 10)
print(A[item(5,2)])  #__getitem__(self, idx: item)
A[item(5,2)] = 10.0 #__setitem__(self, idx: item)

This is almost same as item and itemset, but it will be more close to the Tuple syntax. We can easily switch it out with Tuple in future when Tuple is utterable. I think the transition will be easier.


Add 2.30 release date

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

LGTM. Should this be part of the release guide?
cc: @ihji

I think so if it is not already.

Made one more change. Could you PTAL again?

Made one more change. Could you PTAL again?

(Feel free to merge if the change looks good. My availability is sporadic.)

LGTM...


[SUPPORT] How debug hive sync?

To Reproduce
Steps to reproduce the behavior:

read parquet files from s3 prefix
write parquet files to s3 prefix with enable-hive-sync option

Expected behavior
Table created in hive catalog
Actual behavior
Everything works but table was not created in hive (glue) glue catalog
Environment Description

Hudi version : 0.9.0

Spark version : 2.4.4

Storage (HDFS/S3/GCS..) : s3

Running on Docker? (yes/no) : no

Additional context
The kye problem that there are no error or debug logs about hive syncing. Is there a way to turn them on to see some info why table is not created?
Thank you in advance!

There are log statements in hudi sources like: Starting commit  : but it does not appear in logs. Is there a way to turn it on?

@nikita-sheremet-clearscale can you show the exact configs you used and the environment? assume you're using deltastreamer, so can you show all the args too?

@xushiyan
Many thanks for reply!
It turned out that logs appeared in intecase log not in step logs in EMR. E.g. to see logstatement you have to open EC2 isntaces list on EMR and check their logs instead of submitted application.


Tracing private transactions feature

PR description
PR for adding priv_traceTransaction API
Fixed Issue(s)
https://github.com/hyperledger/besu/issues/5280

Hi @NickSneo - would like to see some unit and acceptance tests for this new method!

Hi @NickSneo - would like to see some unit and acceptance tests for this new method!

Hey @macfarla , Sure. I am just working on it. Will push the new commits by the end of this week.

I've noticed that there is a lot of code that is very similar to existing code (e.g. see PrivateTraceGenerator vs FlatTraceGenerator). I think it would be good to try to have less code duplication.

Hey @pinges ,
Thank you for reviewing the PR. I have resolved all the comments. For code duplication I have tried to have as less as possible, but since we want to make private and public code separate from each other, I have followed the similar approach as it is right now -> some code duplication is expected. Let me know if it is fine or I still need to change.
Also regarding the failing pipeline, It is not related to any of my change, should I try to fix that too in this PR?

Hey @pinges @macfarla ,
Please review this PR

I've noticed that there is a lot of code that is very similar to existing code (e.g. see PrivateTraceGenerator vs FlatTraceGenerator). I think it would be good to try to have less code duplication.

Hey @pinges ,
Thank you for reviewing the PR. I have resolved all the comments. For code duplication I have tried to have as less as possible, but since we want to make private and public code separate from each other, I have followed the similar approach as it is right now -> some code duplication is expected. Let me know if it is fine or I still need to change.
Also regarding the failing pipeline, It is not related to any of my change, should I try to fix that too in this PR?

Hey @pinges @macfarla , Please review this PR

I've noticed that there is a lot of code that is very similar to existing code (e.g. see PrivateTraceGenerator vs FlatTraceGenerator). I think it would be good to try to have less code duplication.

Hey @pinges ,
Thank you for reviewing the PR. I have resolved all the comments. For code duplication I have tried to have as less as possible, but since we want to make private and public code separate from each other, I have followed the similar approach as it is right now -> some code duplication is expected. Let me know if it is fine or I still need to change.
Also regarding the failing pipeline, It is not related to any of my change, should I try to fix that too in this PR?

would it make sense to have an abstract class that FlatTrace can extend?
For the failing test - i have created an issue for it #7108 -  that is not caused by this PR - but a lot of those permissioning tests are flaky lately - so if you feel like fixing them separately that would be super!

would it make sense to have an abstract class that FlatTrace can extend?
For the failing test - i have created an issue for it #7108 - that is not caused by this PR - but a lot of those permissioning tests are flaky lately - so if you feel like fixing them separately that would be super!

@macfarla  Sure, will create an abstract class that FlatTrace can extend. Also will look into the issue #7108

would it make sense to have an abstract class that FlatTrace can extend?
For the failing test - i have created an issue for it #7108 - that is not caused by this PR - but a lot of those permissioning tests are flaky lately - so if you feel like fixing them separately that would be super!

Hey @macfarla ,
I tried two approaches for FlatTraceGenerator and PrivateTraceGenerator -

Abstract Class - But the signatures are different, and I tried to have a common signature but then goes into a rabbit hole to change a lot of classes but still failed to resolve few issues like handling ExecutedPrivateTransaction and Transaction.
PrivateTraceGenerator inheriting FlatTraceGenerator - In this too failed to override common methods since singatures are different.

Right now not trying to modify logic for FlatTraceGenerator and PrivateTraceGenerator.
For FlatTrace and PrivateFlatTrace - I made the PrivateFlatTrace to inherit from FlatTrace with custom freshBuilder function.
I will push these changes, kindly let me know if above approaches sounds good?
Also, Can we get this merged soon, so I can pick other issues too. Thanks

Hey @macfarla @non-fungible-nelson ,
Can we get this PR merged soon? It is open from a long time, also I have spent a lot of time on it so it would be great to see this merged. Thanks!

@NickSneo I think we are very close to get this merged. If my comments about the gas do not make sense just let me know :-)

Hey @pinges , Thanks for reviewing. Comments make sense, actually I got stuck in other Besu PR - EIP196 constantine bindings. I will resolve the comments and push the changes

Hey @pinges Sorry for the delay on this, I just pushed new commits to resolve comments. Please review.
Thanks!

the privacy ATs are not running by default in GHA, have you run the new ATs locally to ensure they pass?

I ran the Privacy Acceptance tests - ./gradlew acceptance-tests:tests:acceptanceTestPrivacy
195 tests completed, 161 failed, 2 skipped
All the tests failed due to - org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quorumengineering/tessera:22.10.0
Seems issue with tessera. Running on Mac M2, openJDK 21. Any idea how can I fix the tessera thing or do I need to change any configuration or setting?

the privacy ATs are not running by default in GHA, have you run the new ATs locally to ensure they pass?

I ran the Privacy Acceptance tests - ./gradlew acceptance-tests:tests:acceptanceTestPrivacy
195 tests completed, 161 failed, 2 skipped
All the tests failed due to - org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quorumengineering/tessera:22.10.0
Seems issue with tessera. Running on Mac M2, openJDK 21. Any idea how can I fix the tessera thing or do I need to change any configuration or setting?

argh the tessera container tests - we tried so hard to refactor these to make them less brittle but haven't looked at them for a while. they try to pull in tessera as a dependency via a docker image, idk why it's not working - this is a problem with having tests that we aren't running. I consider it non-blocking for this PR

@pinges @macfarla Hey, I have resolved all the comments kindly review.
Thanks again!

@macfarla @pinges Hey, I have resolved all the comments. Can you please review again and merge?


How do I get what Linus has?

Just read an interesting article that features this project and an old developer we've all heard about. I imagine documentation isn't a top priority now, but is there enough to provide even a top-level installation guide? If so, where can I find it.

If you mean Linux on these machines in general, we've had an installer released since March linked from asahilinux.org.
If you mean Fedora specifically, that's listed here.


React Rails Front End

Hello :hand:
I hope you are doing well, For this part of the project I followed the next alignaments:

[x] Create a new React app called 'hello-react-front-end'

[x] Initialize your project with Git.

[x] Create the App component with react-router.

[x] Create the Greeting component that will display a greeting. Set it up as a route in your App component.

[x] Create a store, an action and a reducer that will connect to you API endpont to get the random greeting.

[x] Display the random greeting in your Greeting component.

Happy coding ! :rocket: :fire:

Status: Invalid 🔴
Hi @carreraprogrammer  🙋♀,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does meet all the submission requirements.

Please submit a link for the backend pull request and make sure that the backend repo has a fully documented README. The back end repo should also have a link to the front end.
Please removed the live demo section if the project is deployed. There should be no sections that are not documented.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers 🥂  and Happy coding!!! 👯
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @KDlamini  in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


net/http: allow sensitive headers in redirects from http to https

Fixes https://github.com/golang/go/issues/32240

This is a complex issue and my PR doesn't address enough of the complexities. I'll let someone else take the reins.


create super-linter workflow - WIP

Research which linter are required for our program languages & how to configure them properly

Both sprint 2 and 3 since error


All or nothing for Safe Docs?

Can you please confirm that this great, new feature is "all or nothing"? In other words, there is no way to turn it on for a limited set of users to pilot it first, before blasting it out to all Office client users in an organisation?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72ac8b1f-a7cf-3487-9a3c-8eff53e4adb5
Version Independent ID: 63773389-8a4f-926f-8430-8c80b19ff2da
Content: Safe Documents in Office 365 ATP - Office 365
Content Source: microsoft-365/security/office-365-security/safe-docs.md
Service: o365-seccomp
GitHub Login: @chrisda
Microsoft Alias: chrisda

@jose-camacaro, yes, currently the feature is on or off for the whole organization.


Password restrictions on account création

It would be nice to know what password creation restrictions are before filling a password.
Actually, we fill a password then we have the error message that tell us what's wrong with it.

Yes please.


Broken links on README

The 5 links to docs at end of this section are broken and need to be updated to the new location: https://qiskit.github.io/qiskit-serverless/.

Thanks for this issue.  This PR #1362 has fix for them.

From what I saw this issue is fixed so I proceed to close it, thank you!


chore: Organize code into Types, Models, and a Composer

Context
Our API response handling code is not very uniform or modular. It uses several methods, interchangeably, to perform operations on Database and LLM. Some of the code imports router functions instead of modules to perform tasks like completion.
Description

We should create a system that uses repeatable patterns to handle router logic and perform system tasks like DB calls and LLM operations.
We should create a centralized module to handle LLM features like message composition, RAG, tool calling, etc.

https://drive.google.com/file/d/1dWVcqctJbyVx0hWP6XE84kMpGYICCkic/view?usp=sharing

regarding Usage class:
https://github.com/defenseunicorns/leapfrogai/pull/963#discussion_r1746219829


[PA-1537-T2] Add DeleteObjectsByMultipleUsersFromNewAdmin

What this PR does / why we need it:
This PR adds a test case named "DeleteObjectsByMultipleUsersFromNewAdmin" to automate the use case of verifying backup, restore, schedule object from non-admin user is listed for multiple admins. This test case will increase the test coverage of Px-Backup TC Automation and ensure that the orphaned object feature functions as intended.
Which issue(s) this PR fixes (optional)
Closes #PA-1405
Special notes for your reviewer:
This test case is applicable to Px-Backup versions 2.6.0 and above.
TestRail: https://portworx.testrail.net/index.php?/cases/view/87567
Please review the following Jenkins builds:
v2.5.2
S3: I will update the results once the test run is complete.
NFS: I will update the results once the test run is complete.

Thank you for the reviews. These changes are now included in PR #1663.


Add healthCheck model and controller

With this PR:

add healthCheck endpoint

I also moved the unit tests written for the models out of integration/ and into a unit/ folder.

I also moved the unit tests written for the models out of integration/ and into a unit/ folder.

@vpchung While our tests may look like unit tests because we have one test per endpoint, I still consider them as integration test. For example, if we test DELETE Challenge, it's possible in the future that the controller will perform actions other than simply delete the challenge object from the DB. For example DB objects related to the challenge that are no longer needed may also be deleted by calling other controllers' functions, an email notification may be sent to the challenge manager, etc. Therefore testing and thus calling DELETE Challenge is not testing a single unit of the server but test how well DELETE Challenge integrates into the codebase. A unit test would be the testing of a single class, for example testing a Model class.

A unit test would be the testing of a single class, for example testing a Model class.

Agreed, and that's exactly what I did :) The tests for the endpoints remain in /integration; I only moved the tests for the models into /unit.

@tschaffter I'm not sure if a 404 Not Found status code is needed for healthCheck?  Since we are not querying for a specific element within the database, I didn't think we would encounter this error and so, have removed it.
Unless there are some plans down the line where we will query a heathCheck on a specific model perhaps?

I'm not sure if a 404 Not Found status code is needed for healthCheck? Since we are not querying for a specific element within the database, I didn't think we would encounter this error and so, have removed it.

I agree with you.


v0.8.0 failed to start linux machines

Describe the bug
start linux machines failed
To Reproduce
Steps to reproduce the behavior:

update orbstack from 0.7.1 to 0.8.0
the linux machines is started, after a few seconds, the UI report "Stopped with status 2"

Logs
the key vmgr.log is :
console | INFO[04-27 05:36:38] container started                             container=ubuntu2
console | nfs              | * Mounting nfsd filesystem in /proc ... [ ok ]
console | nfs              | * Exporting NFS directories ... [ ok ]
console | nfs              | * Starting NFS mountd ... [ ok ]
console | nfs              | * Starting NFS daemon ...[    1.840701] eth0: renamed from veth3hJ0v9
console | [    1.917508] conbr0: port 4(vethkVWHiJ) entered blocking state
console | [    1.917646] conbr0: port 4(vethkVWHiJ) entered disabled state
console | [    1.917753] device vethkVWHiJ entered promiscuous mode
console | [    1.917985] conbr0: port 4(vethkVWHiJ) entered blocking state
console | [    1.918062] conbr0: port 4(vethkVWHiJ) entered forwarding state
console | [    1.918934] eth0: renamed from veth1EccHR
console | INFO[04-27 05:36:39] container started                             container=ubuntu
console | INFO[04-27 05:36:39] container started                             container=rocky
console | [    1.981539] conbr0: port 1(vethkwGX8y) entered disabled state
console | [    1.982456] conbr0: port 2(vethDlRSsT) entered disabled state
console | [    1.982830] conbr0: port 3(vethOaPFEe) entered disabled state
console | [    1.982942] IPv6: ADDRCONF(NETDEV_CHANGE): vethkVWHiJ: link becomes ready
console | [    2.010703] systemd-rc-local-generator[33]: /etc/rc.d/rc.local is not marked executable, skipping.
console | INFO[04-27 05:36:39] container started                             container=docker
console | 2023-04-27T05:36:39.305844Z  INFO vcontrol: flag_data_resized
time="04-27 13:36:39" level=info msg="data ready"
console | 2023-04-27T05:36:39.306576Z  INFO vcontrol: flag_data_resized
time="04-27 13:36:39" level=info msg="data ready"
time="04-27 13:36:39" level=info msg="Mounting NFS..."
time="04-27 13:36:39" level=error msg="host-vsock forward: dial failed" error="Error Domain=NSPOSIXErrorDomain Code=54 \"Connection reset by peer\""
console |  [ ok ]
console | nfs              | * Starting NFS smnotify ... [ ok ]
time="04-27 13:36:41" level=error msg="NFS mount failed" error="mount nfs: mount(): connection reset by peer"
time="04-27 13:36:42" level=info msg="Mounting NFS..."
time="04-27 13:36:42" level=info msg="NFS mounted"
time="04-27 13:36:46" level=info msg="Setup not done in time, running setup..."
panic: mkdir /usr/local/bin/direnv: not a directory

goroutine 125 [running]:
github.com/kdrag0n/macvirt/macvmgr/conf.ensureDir({0xc000546120, 0x21})
	github.com/kdrag0n/macvirt/macvmgr/conf/dir.go:28 +0x7a
github.com/kdrag0n/macvirt/macvmgr/conf.DockerCliPluginsDir()
	github.com/kdrag0n/macvirt/macvmgr/conf/dir.go:169 +0x37
main.(*VmControlServer).doHostSetup(0xc00032a820)
	github.com/kdrag0n/macvirt/macvmgr/setup_mac.go:657 +0x1acc
main.(*VmControlServer).StartSetup(...)
	github.com/kdrag0n/macvirt/macvmgr/vmcontrol.go:96
main.(*VmControlServer).onStart.func1()
	github.com/kdrag0n/macvirt/macvmgr/vmcontrol.go:338 +0x85
created by main.(*VmControlServer).onStart
	github.com/kdrag0n/macvirt/macvmgr/vmcontrol.go:334 +0x56

It's not juct linux mahcines, containers are also can't start successful

OrbStack shouldn't panic in this case and we've fixed that, but it looks like you have a broken $DOCKER_CONFIG which is now respected (#158). We're doing the equivalent of mkdir -p $DOCKER_CONFIG/cli-plugins.
Make sure $DOCKER_CONFIG exists and that the path doesn't contain broken symlinks. Also check what it's set to (echo $DOCKER_CONFIG).

I'm not set this DOCKER_CONFIG env

Make sure $DOCKER_CONFIG exists and that the path doesn't contain broken symlinks. Also check what it's set to (echo $DOCKER_CONFIG).

The crash has been fixed. We handle invalid DOCKER_CONFIG gracefully now.
I'd still recommend checking your DOCKER_CONFIG though, as something is causing OrbStack to see it as /usr/local/bin/direnv:
grep -e DOCKER_CONFIG -e direnv ~/.*profile ~/.*rc

Adding onto the environment variable issue: it could differ from your main terminal shell if you've explicitly set a different login shell in your terminal settings. OrbStack uses the login shell set at the macOS user level.

Fix released in v0.8.1.


Basic formatter discarding file, line and mfa

Hi! Thanks for a great library. Just wondering why does the LoggerJSON.Formatters.Basic discard the file, line and mfa information? To me it looks like it's impossible to configure the basic formatter to include them, and that's what I specifically would like to do.

Hi @ppeerttu. This is by mistake, a PR would be welcome. I believe all you have to do is to remove those three: https://github.com/Nebo15/logger_json/blob/master/lib/logger_json/formatters/basic.ex#L22

@AndrewDryga awesome, I'll make a PR as soon as I can, perhaps already this week.


ci: add test for variable.

wait for https://github.com/datafuselabs/databend/pull/16239

Wait this https://github.com/datafuselabs/databend/pull/16239 pr released in latest image and run tests anain.

ready to rerun ci?


[FEATURE] Add support for custom images for Codebuild for execution

Is your feature request related to a problem? Please describe.
When running the deployspec.yaml to build some application specific modules, they might require complex build environments e.g:

Installing custom libraries or versions of frameworks
Potentially containing code artifacts which are not available from within Codebuild (but might be from on-prem or a developer laptop)
Include artifact build steps which take a very long time to run

For these cases it would make sense for us to package our dependencies into a Docker Image which would be used by seedfarmer/codeseeder when running the deployspec.yaml
Describe the solution you'd like
We would need:

A mechanism to specify a custom image uri for a module to use
This URI would need to be passed through seedfarmer -> codeseeder -> codebuild to tell it to use this image before executing the deployspec

There is a need for supporting custom images for Codebuild both on the global (all modules) or specific modules

@a13zen using the deployspec.yaml is not a viable option....we can support using a custom image, but not in that manner.  More to come...

Nice! 💪


Add json at wiki page

We need to created our wiki and include de database.json file

Por qué database.json?


Migrate to AndroidX

Most of the AndroidX packages are now stable. I believe it's time we update our app to use AndroidX. See the migration guide here.

Sure, go ahead @EdNgulele


bug fix

Summary
bug fix for distributed_table materialization

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

After few test, I thought here are the modifications to put:

{% do exchange_tables_atomic(backup_relation, existing_relation) %}
 {% do exchange_tables_atomic(backup_relation, existing_relation_local) %} (see comment in )

add    {{ create_distributed_table(target_relation, target_relation_local) }}  for the situation when the target table exists before the dbt run.

add the check as you mentioned.
{%- if adapter.get_clickhouse_cluster_name() is not none and obj_types == 'TABLES' %}
{%- if adapter.get_clickhouse_cluster_name() is not none and obj_types == 'TABLES' and 'Replicated' in engine_clause() %}

Could you please tell me how do you think about them?

I forked the project to make a better versioning on my side.
Can you please tell me how do you think about the following modifications?
https://github.com/zli06160/dbt-clickhouse/pull/1/files
It worked for me (multiple runs: well distributed, correct row counts).

I forked the project to make a better versioning on my side.
Can you please tell me how do you think about the following modifications? https://github.com/zli06160/dbt-clickhouse/pull/1/files
It worked for me (multiple runs: well distributed, correct row counts).

I think this fix makes sense -- @gunc do you want to add it, or @zli06160 do you want to open a new PR?

I  think @zli06160  you should open a PR  for this fix. I will close this PR. I am currently working on cluster tests and distributed materialization tests.

@gfunc @genzgd I opened the #184.


Support volume backup service with snapshot

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

/kind enhancement
What this PR does / why we need it:
Added support for Volume Snapshot before volume backup
Which issue(s) this PR fixes:

Fixes #
Test Report Added?:

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

Test Report:

Special notes for your reviewer:
Signed-off-by: Amit Roushan<EMAIL_ADDRESS>

lgtm


Parallel Typechecking

I stumbled upon this paper and was curious if some of the techniques it describes could be applied to improve the speed of the F# typechecker.

Abstract
Given the sophistication of recent type systems, unification-based type-checking and inference can be a time-consuming phase of compilation—especially when union types are combined with subtyping. It is natural to consider improving performance through parallelism, but these algorithms are challenging to parallelize due to complicated control structure and difficulties representing data in a way that is both efficient and supports concurrency. We provide a solution to these problems based on the LVish approach to deterministic-by-default parallel programming. We extend LVish with a novel class of concurrent data structures: Saturating LVars, which are the first LVars to safely release memory during the object’s lifetime. Our new design allows us to achieve a parallel speedup on worst-case (exponential) inputs of traditional HindleyMilner inference, and on the Typed-Racket type-checking algorithm, which yields up an 8.46× parallel speedup on type-checking examples drawn from the Racket repository.

http://www.ccs.neu.edu/home/samth/parallel-typecheck-draft.pdf

@cloudRoutine While the paper and topic is interesting, it's best not to use github issues in this repo for early stage discussions, i.e. please follow the guidelines in CONTRIBUTING.md and the template in ISSUE_TEMPLATE.md.
There's no really good place for general discussion threads, but either using the FSSF Slack group or opening an issue in https://github.com/fsharp/fsharp.github.io seems reasonable if you want the idea recorded.


[README.md] videoMimeType's description URL is broken

Description
The URL in videoMimeType's description is the one below:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-isTypeSupported.html
But it's broken. It should be, instead:
https://cs.chromium.org/chromium/src/third_party/blink/web_tests/fast/mediarecorder/MediaRecorder-isTypeSupported.html

thanks for letting me know @vitor251093, I'll get it fixed.


Add support for per-edge ideal length.

This allows a function to override the ideal edge length based on edge properties.
I have a case where I'd really like to keep some edges very short (to indicate particular node-to-node relationships). A function seems like a reasonably generic approach.

I would prefer to use only the existing option, idealEdgeLength, and allow it to take on either an integer value or a function value.  All the code could be changed to assume it's always a function, except the init code: If the init value is an int, then make a function from it, e.g. idealEdgeLength = edge => idealEdgeLengthInt.

One of the things that doesn't work for me is that I can't access the edge data from the edge that is passed into the function.
With the COSE layout, I can get edge.data().foo, but this passes in an edge that doesn't have these properties.

So then maybe my function-all-the-time idea is probably too strict.  The value could be cached as a plain int at some point in the layout code.  The main thing I wanted to get across is that the public API should be simple, using the same property.

Sorry Max, I meant with the code in the PR. Having it as a function all the time is fine (with my case), as long as that edge is the same as is in the other layout.
My function is:
idealEdgeLength: function(edge) {
 	return edge.data().weight; // weight is edge-dependent
 },

I agree that it would be nice if it were the same property, whether its a static int, or a function.

I think the layout makes its own element objects though, so it won't necessarily have access to the original data() or ele if idealEdgeLength uses a function everywhere.

Oh I see. Guess I'm stuck with COSE either way then. Thanks for pointing that out before I got super stuck and frustrated.

Both default COSE and Cola should support function edge lengths already.  Both Cola and COSE-Bilkent tend to produce nicer results than default COSE, but default COSE is relatively inexpensive.  It would be great to have function support in COSE-Bilkent directly though, as it by far produces the best results for compound graphs.

I originally started with just allowing idealEdgeLength to be a function or a constant, but there are two problems:

the option value gets assigned to a constant (in FDConstants and CoSEConstants) which is arguably public API,
the constants get used in other places, including places where we don't easily have an edge to work with (e.g. the circular node layout). I don't want to do that much refactoring, nor do I have confidence I understand all the consequences of such a change.

Those two things led me to adding an option.

I had a look at how hard it would be to add data(), and it turns out it will be somewhat messy.
Two options I came up with. First is to use the edge.id (which is already present) to do an element lookup. So you can set some property on the edge data (e.g. "myEdgeLength": "90") and then do something like this in the per-edge length function:
idealEdgeLengthFunction: function(edge) {
              if (edge.source.id === 'glyph33') {
                return 100;
              } else if (edge.id) {
                var el = cy.getElementById(edge.id);
                var data = el.data();
                if (data) {
                  var len = data.myTargetLength;
                  if (len) {
                    return len;
                  }
                }
                return 50;
              } else {
                return 50;
              }

If it turns out its an expensive lookup, you could cache them by edge.id, although I admit its now getting complicated.
The second alternative is to copy off data() in the LEdge constructor, and add an event listener to keep it up to date when the edge data changes. Unfortunately I couldn't find a cytoscape.js event that is per-edge, so I just update them all when the collection raises the data event.
The change looks like:
--- a/src/Layout/index.js
+++ b/src/Layout/index.js
@@ -167,6 +167,7 @@ _CoSELayout.prototype.run = function () {
     if(sourceNode.getEdgesBetween(targetNode).length == 0){
       var e1 = gm.add(layout.newEdge(), sourceNode, targetNode);
       e1.id = edge.id();
+      e1.setData(edge.data());
     }
   }

@@ -233,6 +234,14 @@ _CoSELayout.prototype.run = function () {
         cancelAnimationFrame(frameId);
       }

+      this.cy.eles().addEventListener('data', function() {
+        var gmedges = gm.edges;
+        for (var e = 0; e < gmedges.length; e++) {
+          var cyEdge = this.cy.getElementById(e.id);
+          e.setData(cyEdge.data());
+        }
+      });
+
       ready = false;
       return;
     }

(with a corresponding change to add the getter / setter in LEdge.js).
Then you can do something like:
idealEdgeLengthFunction: function(edge) {
              if (edge.source.id === 'glyph33') {
                return 100;
              } else if (edge.data() && edge.data().myTargetLength) {
                return edge.data().myTargetLength;
              } else {
                return 50;
              }
            }

Obviously a real application is probably doing some calculations / switch based on actual data, rather than a constant, but you get the idea.

That works super well with the small data sets I'm using, so I'm pretty happy. Once some other people show up tonight I can see how it will perform with a much larger one.

I think the simplest thing would be to store the per-element values in COSEEdge and COSENode, set in their constructors.  Every place in the code that uses the constants, for things like ideal edge length, would have to read from the element rather than the global constants.
I don't think the values need to be updated once the layout has started.  IIRC, other FD layouts don't do that.  Overall to change layout params, you stop the running layout and start a new one.  That has the same effect.

Also: I don't think sending just data is as general as it could be.  It's best to run directly on the Cytoscape element, like someForce(ele) so you can call things like ele.degree() inside someForce().  Using the full model object is also more consistent with other layouts.

Was there a specific reason why this didn't get integrated into the master?
I was hoping to be able to specify ideal edge length per edge, but can't seem to do that in version "cytoscape-cose-bilkent": "4.1.0"

I closed it because it wasn't going to be accepted and I didn't have time to work it. Feel free to rework it as required.

There are 2 major concerns about per edge ideal length specification:

Fine tuning: spring embedders are difficult to tune. When you change the ideal edge length, repulsion and spring forces no longer balance each other out and you get layouts far from ideal
Performance: as is, this is not a very fast layout, it will get slower with this

So I am for not making such a change.


RTL breakage in PDF

Describe the issue
Archived-At: https://mailarchive.ietf.org/arch/msg/auth48archive/_8ZjoHcPh5HfYxRQb3P4zVbdXUg
https://www.rfc-editor.org/authors/rfc9290.txt
https://www.rfc-editor.org/authors/rfc9290.pdf
https://www.rfc-editor.org/authors/rfc9290.html
https://www.rfc-editor.org/authors/rfc9290.xml
This is likely to lead to TI state.
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

This is an RTL support issue in WeasyPrint. I've created: https://github.com/Kozea/WeasyPrint/issues/1711


[ERROR]: Hardware requirements need to be updated

Is there an existing issue for this?

[X] I have searched the existing issues.

Issue
In this page: https://milvus.io/docs/v2.0.x/prerequisite-docker.md
In section "Hardware requirements", we say "Current version of Milvus does not support AMD and Apple M1 CPUs.", actually current milvus can support Apple M1 CPI, so we need to update the sentence to be "Current version of Milvus does not support AMD CPUs"
Suggestion
No response
Anything else?
No response

Closed with PR #1598


Tilemap: fix world-to-map & map-to-world

This PR is related to the two open issues #37394 and #31663
Tilemap functions "world_to_map" and "map_to_world" didn't respect the transforms of Tilemap-Node (& parents). This could be fixed also in GD-Script, but it's confusing for users. In addition also the documentation states "global" position.
Fix is simply done by using the inherited Node2D functions "to_local" and "to_global".
Remark to "map_to_world":
My change is only in the public function "map_to_world. Not sure if also the privat function "_map_to_world" should use this fix. "_map_to_world" is used multiple times inside the tile_map.cpp, I wasn't able to really understand all impacts of changing it -> as there are no bugreports for weird Tilemap behaviour, I assume no change needed.
May break compatibility with existing GD-Script workarounds!

I don't think this is a good idea,  most of the node keep their logic locally whenever possible, going to global automatically make things more confusing, not less.

But the functions could be renamed instead, like "map_to_local_position" or something like that, as the "world" might be confusing.

The intention with this function was global / world. But I'm fine with both, if rename will be choosen, also documentation needs to be adapted. 🙂

Perhaps there could be map_to_local/map_to_global/global_to_map/local_to_map, to support both usecases.

world is not meant to mean global in this case, it means "map (units) to world (units)". World units are pixels, map units are discrete cell coordinates.

Map_to_world documentation:
Returns the global position corresponding to the given tilemap (grid-based) coordinates.
So it's rather an documentation issue -> close PR?

Yeah the documentation is wrong and should be fixed.
It doesn't prevent discussing a separate proposal to change this API to actually return a global position though, but IMO local position is the most expected, as provided by most node APIs. (It can then be made global with to_global() if needed.)

If local is the intention, I would only change documentation and remark in documentation the posibillity to change to global by the node2d  functions "to_global" for output of map_to_world and "to_local" for input of world_to_map.
In my opinion no need to create new API for such a simple translation.


fixed typo

fixed typo in the examples

This file comes from Backbone.LocalStorage. Might be worth fixing there too.


feat: add custom tooling repo support

Closes #598

do we still need this with the source policies? https://project-copacetic.github.io/copacetic/website/faq#can-i-replace-the-package-repositories-in-the-image-with-my-own

After taking a look, this could potentially be seen as redundant. Do we still want a user flag for this kind of behaviour, or do we want the user to pass in these custom values exclusively via BuildKit source policies?
If this PR is still wanted, please let me know so I can make the necessary changes before it gets merged. I noticed this morning that I forgot to add some logic in dpkg.go to pass the new variable into the appropriate functions if a custom tooling repo is passed in.


Python 3.11

Hi Sylvain,
we are using the EODAG JupyterLab extension on the DPR project. We have recently moved our baseline to Python 3.11, which has broken the support for the EODAG extension.
I have seen that EODAG itself supports Python 3.11. Do you plan to also upgrade the extension to support Python 3.11 and if yes, in which timeframe ?
Thanks a lot

Finally, the experienced problem was not due to lacking support of Python 3.11, but a change in the installation from pip to mamba. When the extension is installed with pip and Python 3.11, it is available in JupyterLab.
I am closing the issue, sorry for the noice.


Split the index.css in /documentation-website

Context
We currently have an ever-growing index.css, that contains a lot of module specific code at the moment.
Goal
By making the css module(page or component) specific, we reduce the complexity and reduce the chance of unintended side effects. All modular css rules need to start with a class, that describes that module, so for example:
.page-example h1 {
  font-size: 10%;
}

Or
.component-layout div {
  display: grid;
}

I can help with this 😄

I can help with this 😄

thank you!


carousel: change transition element.

Change transition element from nextSlide to currentSlide.
This allows for custom transitions such as fade.
// Fade transition for carousel items
.carousel-fade {
	.item {
		left: 0 !important;
		.transition(.6s ease-in-out opacity); //adjust timing here
	}
}

@blowsie Is this still relevant in the current version? If so I will reopen. Closing for now.

@rvanbaalen hah, not sure to be honest, it was over a year ago. I will let you know if I get time to retest

Thanks for the time. We're actively going through all PRs and issues the upcoming weeks.

This email was sent from my iPhone and therefore subject to typos and other inaccuracies.

On 10 mrt. 2015, at 03:19, Sam Blowes<EMAIL_ADDRESS>wrote:
@rvanbaalen hah, not sure to be honest, it was over a year ago. I will let you know if I get time to retest
—
Reply to this email directly or view it on GitHub.


Refactors AbstractIndexManager by extracting template interactions

Description
Data Prepper plans to support by composable index templates as well as the legacy templates that it currently uses (#1275). This PR has done some refactoring to lay the groundwork for adding support for composable index templates.
The crux of the change is the new TemplateStrategy interface. This provides an abstraction over how to interact with templates. I based this design on some of the differences between the two types of templates (the data format is a little different and the APIs are different). The code in LegacyTemplateStrategy is mostly copied from AbstractIndexManager.
It also makes the AbstractIndexManager a little more manageable.
Issues Resolved
N/A
Check List

[x] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2454 (28e2957) into main (e8931f5) will decrease coverage by 0.12%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #2454      +/-   ##
============================================
- Coverage     93.86%   93.74%   -0.12%
- Complexity     2081     2083       +2
============================================
  Files           244      246       +2
  Lines          5789     5807      +18
  Branches        470      470
============================================
+ Hits           5434     5444      +10
- Misses          239      247       +8
  Partials        116      116

see 8 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Moment.js: Deprecation Warning

Moment.js is printing a warning to the console:

"Deprecation warning: moment construction falls back to js Date. This is discouraged and will be removed in upcoming major release. Please refer to https://github.com/moment/moment/issues/1407 for more info."

This is being caused by line 218 of jquery.rss.js:
date: moment(entry.publishedDate).format(this.options.dateFormat),

This usage of the moment() constructor is going to be deprecated soon. It is suggested that instead of dumping any date string into the constructor, one should instead use String + Format. For example:
date: moment(entry.publishedDate, "MM-DD-YYYY").format(this.options.dateFormat),

Or, as is mentioned in https://github.com/moment/moment/issues/1407, if one really needs to dump in random dates without specifying the format, another alternative is to let Date handle it:
date: moment(new Date(entry.publishedDate)).format(this.options.dateFormat),

For our use case -- an RSS feed reader -- I don't know if we can successfully use String + Format. RSS feeds are supposed to have a standardized date format, as shown in the RSS 2.0 specification:

All date-times in RSS conform to the Date and Time Specification of RFC 822, with the exception that the year may be expressed with two characters or four characters (four preferred).
Example: Sat, 07 Sep 2002 0:00:01 GMT

..but, my impression is that feeds in the wild don't predictably follow this standard, so anticipating what format the dates will use in any given feed is probably out of the question.
Should we go with letting Date parse the initial publishedDate string and hope for the best?
My guess is that we should, because Date is what Moment currently falls back to when the pubDate isn't ISO-8601 compliant. Using Date like this is a risky practice and doesn't always work, so they're removing this feature to wipe their hands clean of it. But, that doesn't stop us from using it.

Related: #54


EADDRINUSE on multiple test suites or test cases.

Similiar to https://github.com/visionmedia/supertest/issues/568.
One caveat is use request.agent(app.listen()) (on search for solutions), other is use describe sections.
Other method is requiring the app on each iteration:
beaforeEach(() => {
  require('../index.js')
})

But this isn't a option due to load all server configurations and route handlers, but could be a solution.
Some tests fail cause doesn't start the server because the port already in use.
Tested every solution proposed.
--
Jest version: 24.5
Node: 10.4
OS: GNU/Linux

Are you calling app.listen(..) within your index.js module?
If so, consider moving that block of code out. For example, check out the express generator project. It’s templated, but you’ll get the idea...
Then you’ll have the flexibility to require the “app” within tests and delegate listening to  supertest(app)
Happy to provide more examples later, on mobile at the moment :-)

I ran into a similar issue and none of the above suggested ways worked for me. I am using express for the server and mocha and supertest for testing. Specifically, I am running into two major issues.

The mere importation of the app.js file into the testing file eg.test1.js makes the tests hang for some reason even if all pass successfully. I have used a not so clever workaround by using the unix timeout command whenever I am running tests eg timeout 5s npm run test -s. I would appreciate learning a legit way to fix the issue. I have tried several suggestion from different places online: even tried using the mocha --exit flag but that does nothing.

I seem to get the EADDRINUSE error only when the app is running using the same port as the test. I don't get this error when the app.listen() is uncommented (not removed) from the imported app.js file.

On that case, the problem is there i was requering the index.js every time, so, it's istarting to listean the port 3000 every before each test, causing the issue.
The solution was to require index one time, onto imports atibuting to it the app variable on every test suite, call the request(app) and everything woks fine. On multiple test suites, the mocha clear runs in a way that this problem cannot occur.

On that case, the problem is there i was requering the index.js every time, so, it's istarting to listean the port 3000 every before each test, causing the issue.
The solution was to require index one time, onto imports atibuting to it the app variable on every test suite, call the request(app) and everything woks fine. On multiple test suites, the mocha clear runs in a way that this problem cannot occur.


When a boundary relation only has 2 ways, there'll be some rendering errors.

like this

Hi and welcome, @Daredemodaisuki. The screenshot you shared is related to a different project, the openstreetmap-carto rendered tiles. You'll need to try asking over there. Good luck!


Feature request: convenience functions for getting variables from scopes

There does not currently seem to be a good way to get a collection of variables that belong to a given scope. I've seen issue #7295, but the answer given by Yaroslav (at http://stackoverflow.com/questions/42073239/tf-get-collection-to-extract-variables-of-one-scope) does not nest:
import tensorflow as tf

def bar():
  with tf.variable_scope("bar") as scope:
    x = tf.Variable(0, name="x")
    print list(map(str, tf.get_collection(tf.GraphKeys.TRAINABLE_VARIABLES, scope=scope.name)))
    print list(map(str, tf.get_collection(tf.GraphKeys.TRAINABLE_VARIABLES, scope=scope.name + "/")))
  print list(map(str, tf.get_collection(tf.GraphKeys.TRAINABLE_VARIABLES, scope="bar")))

def foo():
  with tf.variable_scope("foo") as scope:
    with tf.variable_scope("bar_") as scope:
      y = tf.Variable(0, name="y")
    bar()

with tf.Graph().as_default():
  bar()
print
with tf.Graph().as_default():
  foo()

The snippet above outputs (on TF 1.0):
['Tensor("bar/x/read:0", shape=(), dtype=int32)']
['Tensor("bar/x/read:0", shape=(), dtype=int32)']
['Tensor("bar/x/read:0", shape=(), dtype=int32)']

['Tensor("foo/bar_/y/read:0", shape=(), dtype=int32)', 'Tensor("foo/bar/x/read:0", shape=(), dtype=int32)']
['Tensor("foo/bar/x/read:0", shape=(), dtype=int32)']
[]

The output shows that wrapping the scope "bar" in another scope ("foo") breaks Yaroslav's proposal of using tf.get_collection(..., "bar"). It also breaks tf.get_collection(..., scope.name) by including variables from outside the scope. The only version that works regardless of context is tf.get_collection(..., scope.name + "/"), which is ugly and too informed.
It would be great to have scope.trainable_variables(), or scope.get_collection(...), or even tf.get_collection(..., scope).

@cooijmanstim the function tf.get_collection(key, scope) does a prefix match in all variables belonging to the key collection. The Variable foo/bar_/y/read:0 and the scope foo/bar have same prefix.

@suiyuan2009 Indeed it does, and I would argue that that's an implementation detail leaking through. User code shouldn't have to muck with strings (i.e. + "/") when they have a reference to the Actual VariableScope object to which they want to constrain their selection.

@cooijmanstim we can modify the function def get_collection(self, name, scope=None) and check scope's type. I'll submit a pr.

I think add a function scope.get_collection(key) is better, since It's not a good idea to import ops lib in framework lib.

Looks like someone fixed this but didn't close the bug.


CODE?

Hello, thanks for your great work.
I was wondering if it's possible to make the code available.
Thanks

Sorry for the delayed reply.
You can find our code here: https://github.com/naver-ai/demystifying-ntk.
Thank you for your interest!


HyDAMO: immutable object id

We need an immutable object-identification, as:

We want to be able to link non-hydamo properties to an hydamo-object.
We want to link our modelled objects to HyDAMO. Models last +/- 5 years. After 5 years we still want to be able to link the model to the object so we can e.g. (1) update the modelled object with new parameters, (2) link modelled results to the object

What we see:

globalid is still changing between different table versions supplied by water authorities
nen3610id uses objectid which is the ArcGIS table index. This is quite dangerous as we assume objectid will change when a water authority re-indexes/rebuilds its database

For modelling purposes we propose to use the code column instead to introduce a field model_id to use in models and can be related to objects as long as they have a code.
Water Authorities have a wbhcode the probably want us to use. I propose to let model_id be:
NL.WBHCODE.{wbhcode}.{layer}.{code}
For other authorities, RWS, provinces, municipalities I propose to use bgt-codes:
NL.BGTCODE.{bgtcode}.{layer}.{code}
We'll introduce a method on a HyDAMO layer that will:

Validate if code is filled; return an exception if it is not. As an alternative we'll generate a unique code base on epsg:28992 XY coordinate (centroid if it is not a point-feature)," f"x:{int(x + 0.5)}-y:{int(y + 0.5)}",
populate a column with model_id
add the column to the layer-schema so it is saved when a user writes a geopackage

If we need, we concat on the fly; meta_waterbeheerder + code_waterbeheerder


feat: lg support for transcript imports

:tada: This PR is included in version 0.380.0 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Make sdk/worker_harness_container_image fully backwards compatible

Followup fix for #14557

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python Dataflow ValidatesContainer

R: @aaltay
R: @chamikaramj
R: @tvalentyn


Deploy cs-blocklist-mirror as a helm chart

Would be great to have cs-blocklist-mirror as a helm chart for Kubernetes environments using crowdsec.
Use case:

Running Security Engine in k8s
Integration with a firewall or WAF solution using blocklist-mirror

/kind enhancement

Hi @avthart,
It depends on your WAF or Firewall solution, but you can already use the integrations feature.


Delete all Markers on the map

Goodnight.
This is an excellent job.
I query a database, with the latitude and loingitud I created the Markers, but, How can I delete all the Markers on the map, so I can make a new query of my database and put the new Markers.
Thank you so much

I made a list, containing all the markers I created. To remove them all, I simply iterated over the list. I don't know, if there are any better solutions, but this should work in any case.

I don't believe there is currently a method to easily do this other than what @heymoha  described, but I've flagged this as an enhancement.

Google itself recommends keeping them in an array, iterating that and setting 'map' to null on each, per: https://developers.google.com/maps/documentation/javascript/examples/marker-remove
It would be possible to do that behind the scenes in the addMarker method of the GoogleMap object, and supply a method to clear them all.

The suggestions I've seen offer two options, one to remove the markers but keep them in the collection, the other to remove them and clear the collection. Perhaps just removing them all, and if the end-user wants to keep them in a collection they should be responsible for that? A map.addMarkers(List<>) would be useful in that case too.

Sample for test and use of bulk marker management below using changes in commit #97. Further enhancement might be needed to deal with adding events to the bulk markers, as they can't be added when the marker isn't associated with the map (I don't think...) End-user can iterate their own collection after addition and add listeners in the meantime.
public class SampleApp extends Application implements MapComponentInitializedListener {

    protected GoogleMapView mapComponent;
    protected GoogleMap map;

    private List<Marker> localMarkers;

    @Override
    public void start(Stage stage) {

        mapComponent = new GoogleMapView(Locale.getDefault().getLanguage(), null);
        mapComponent.addMapInializedListener(this);

        BorderPane bp = new BorderPane();
        ToolBar tb = new ToolBar();

        Button bClear = new Button("Clear Markers");
        bClear.setOnAction(a -> clearMarkers());

        Button bPlace = new Button("Place Markers");
        bPlace.setOnAction(a -> placeMarkers());

        Button bRS = new Button("Remove Some Markers");
        bRS.setOnAction(a -> removeSomeMarkers());

        tb.getItems().addAll(bClear, bPlace, bRS);

        bp.setTop(tb);

        bp.setCenter(mapComponent);

        Scene scene = new Scene(bp, 700, 700);
        stage.setScene(scene);
        stage.show();

    }

    @Override
    public void mapInitialized() {

        LatLong centre = new LatLong(-43.238968, 146.23352);

        MapOptions options = new MapOptions();
        options.center(centre)
                .zoom(6)
                .overviewMapControl(false)
                .panControl(false)
                .rotateControl(false)
                .scaleControl(false)
                .streetViewControl(false)
                .zoomControl(false)
                .mapType(MapTypeIdEnum.TERRAIN);

        map = mapComponent.createMap(options, false);

        createLocalMarkers();

        map.addMarkers(localMarkers);

    }

    private void clearMarkers() {
        map.clearMarkers();
    }

    private void placeMarkers() {
        map.addMarkers(localMarkers);
    }

    private void removeSomeMarkers() {

        Collection<Marker> sm = localMarkers.subList(0, 4);
        map.removeMarkers(sm);

    }

    private void createLocalMarkers() {

        localMarkers = new ArrayList<>();
        double lat = -43.238968;
        double lng = 141.23352;

        MarkerOptions mo = null;
        LatLong ll = null;

        for (int i = 0; i < 10; i++) {

            lng = lng + 1;

            mo = new MarkerOptions();
            ll = new LatLong(lat, lng);
            mo.position(ll)
                    .title("A Marker (" + i + ")")
                    .visible(true);

            localMarkers.add(new Marker(mo));

        }
    }
}

Many thanks for the modification to the library, it works excellent.
But now I have the problem to add an InfoWindow to each Marker in bulk process.
Please help me ,
Thank you so much

As noted above you'll need to iterate your collection of Markers after adding them to add the listeners, at least for now. Not sure how we could deal with adding the listeners during the bulk process, it's something we'll have to brainstorm over!

@rterp @blackbirdsr71br
I've just put through a pull request that includes an addMarkers method that will take a Callback that can be used to create event handlers on each Marker. Rob, I haven't merged this as you might not want to risk it in the new release, and it might need a bit more consideration and refinement, depending on how it serves in the real world.
Sample usage is as follows, replacing/inserting into yesterdays example. I've used anonymous classes rather than lambdas to make is clear what's happening.
public void mapInitialized() {
    ... code as above ...
    map.addMarkers(localMarkers, UIEventType.click, new Callback<Marker, UIEventHandler>() {
        @Override
        public UIEventHandler call(Marker param) {
            return new UIEventHandler() {
                @Override
                public void handle(JSObject jso) {
                    displayInfoWindow(new LatLong((JSObject) jso.getMember("latLng")), param);
                }
            };
        }
    });
}

private void displayInfoWindow(LatLong loc, Marker m) {
    InfoWindowOptions infoOptions = new InfoWindowOptions();
    infoOptions.content("
Info Window

Describing marker: " + m.getTitle() + " at location: " + loc.toString() + "
");
    InfoWindow window = new InfoWindow(infoOptions);
    window.open(map, m);
}

good morning
It is an excellent library, and the answers are very good, thank you very much for your help, I downloaded version 2.10.0 and it works great, this question is closed.
Thank you very much.


scrollbars sometimes visible in chrome

Could be fixed with:
 .resize-triggers > div::-webkit-scrollbar {

      display: none; /* Fixes the Chrome scrollbar bug */

    }

from http://www.backalleycoder.com/2013/03/18/cross-browser-event-based-element-resize-detection/

This has now been fixed.


War Photo Upload

Preview photo you are about to upload

Not sure if this is possible, also such a low priority I feel it's not worth having as an issue


Bot not trasfering any pokemon even with full bag

Expected Behavior
The bot should transfer the pokemon when the amount left in the pokemon bag is less or equal to the min_free_slotconfig
Actual Behavior
The bot doesn't start the transfer procedure
Your FULL config.json
http://pastebin.com/rxTyrFdV
Output when issue occurred
2016-08-26 09:46:14,597 [PokemonCatchWorker] [INFO] [pokemon_inventory_full] Your Pokemon inventory is full! Could not catch!

Steps to Reproduce
Set the bot to run on a full pokemon bag
Other Information
OS:
Mac OS X 10.11.3
Branch:
dev
Git Commit:
09403f5ff023f98086f97f647beb344b89188ae0
Python Version:
Python 2.7.10
Any other relevant files/configs (eg: path files)
None

I have the same issue, using linux.

@danijov88 were you also using keep best custom?

@mjmadsen sorry for late reply.. I use the default config, no changes.

@danijov88 Your bag is fuller than the minimum you have set?
@rdeeb I think there are issues with the keep best custom release tag.

#4689


Can you add a tool to check the consistency between filer and volume ?

Can you add a tool to check the consistency between filer and volume ?

Report the records in filer, and the volume lost blocks.
Delete the record with block loss from filer. (also delete the non-lost block in the record)
Report the blocks that are not recorded in the filer and exist in the volume. (Assuming seaweedfs only uses filer server to upload files)
(May want to consider avoiding detecting blocks of files uploading)
Remove 3. reported blocks from volume.

Considering the risk of the delete operation, you can provide a feature to transfer the data that to be deleted to another(or new) seaweedfs server. (data recovery or forensics for future)

I can build a tool to export <fileId, file> pairs from a filer.
And another tool to export all fileIds from all volumes.
Supposedly you can use unix tools to sort, join, and find out the intersections. Or even some spark jobs to do so.

This is OK for me, I just need to stop the upload task and clear the untracked blocks caused by upload unexpected interruptions at intervals. (Avoid excessive waste of space due to long-term accumulation or sudden large number of upload exceptions)
But I still hope you can implement this tool in the future, it can be used for disaster recovery check and error detection.
Thanks.

There could be multiple filers on the same cluster. The assumptions can easily break and the tool can be dangerous.

Yes, I also think this tool is dangerous, but its danger is manageable, after all, this is not an APP for ordinary consumers.
All features are optional. Operations 1 and 3 are used to generate read-only reports. Option 5 is used to reduce the risks of operations 2 and 4.
Among them, the user may be unclear about the assumptions and cause misoperation, but I think that is sufficient to avoid it through specific explanation or secondary confirmation.
If you are also worried about this, you can ask the user to enter all the addresses of the "weed filer" running on the volume for confirmation. It is better if you also consider directly support multiple filer :）

Added a weed shell command volume.fsck.
echo volume.fsck | weed shell


NRPE checks fail: Stderr: 'usage: check_reboot.py [-h] known_reboot_time

In testrun:
https://solutions.qa.canonical.com/testruns/testRun/2321f1c4-3dea-4af0-b692-5ca201d2bc35
with FCE console output:
https://oil-jenkins.canonical.com/job/fce_build/1623//console
A number of nrpe checks fail with:
Stderr: 'usage: check_reboot.py [-h] known_reboot_time
  check_reboot.py: error: argument known_reboot_time: time must be in format
  yyyy-mm-dd HH:MM:SS, same as output from `uptime --since`.
  '

I assume something in the check arguments or calling has changed.
Link to crashdumps (which also contains an exported bundle):
https://oil-jenkins.canonical.com/artifacts/2321f1c4-3dea-4af0-b692-5ca201d2bc35/index.html

Imported from Launchpad using lp2gh.

date created: 2022-05-02T13:46:02Z

owner: basdbruijne

assignee: None

the launchpad url

(by asbalderson)
A simple reproducer is deploying NRPE as shown from the charm help, and then running the check with no arguments:
juju deploy ubuntu
juju deploy nrpe
juju deploy nagios
juju add-relation ubuntu nrpe
juju add-relation nrpe:monitors nagios:monitors
juju wait
juju run-action --wait nrpe/0 run-nrpe-check name=check-reboot
Currently SQA has a nagios validator which

lists all the checks for a NRPE unit
runs the nrpe check for each check
reports the errors.

Check reboot comes up as an listed check, but when ran with no argument reports as a failed check. I feel like the check should be able to check the juju kv for the known reboot time, if there is no known reboot time, it does nothing, otherwise does the compare.
ack-reboot can then behave the way it does currently.

(by xavpaice)
in nrpe_helpers.py, the check is initially populated with a time from set_known_reboot_time(), and sent to get_check_reboot_context().
When I created a fresh cluster using the instructions in the bug description, the resulting NRPE check is this:
System reboot time (sub)
command[check_reboot]=/usr/local/lib/nagios/plugins/check_reboot.py "2022-05-03 05:12:03"
Running that manually:
root@juju-da6b2f-nrpe-0:/etc/nagios/nrpe.d# /usr/local/lib/nagios/plugins/check_reboot.py "2022-05-03 05:12:03"
OK: system is up since 2022-05-03 05:12:03
The action, however, fails:
ubuntu@xavpaice-bastion:~$ juju run-action --wait nrpe/0 run-nrpe-check name=check-reboot
unit-nrpe-0:
UnitId: nrpe/0
id: "2"
results:
Stderr: |
usage: check_reboot.py [-h] known_reboot_time
check_reboot.py: error: argument known_reboot_time: time must be in format yyyy-mm-dd HH:MM:SS, same as output from uptime --since.
check-output: ""
status: completed
timing:
completed: 2022-05-03 06:11:51 +0000 UTC
enqueued: 2022-05-03 06:11:48 +0000 UTC
started: 2022-05-03 06:11:51 +0000 UTC
This bug is therefore about the action, not the NRPE check itself.

(by xavpaice)
Looking at the action script (which is written in bash):
root@juju-da6b2f-nrpe-0:/home/ubuntu# check=check_reboot
root@juju-da6b2f-nrpe-0:/home/ubuntu# nrpedir="/etc/nagios/nrpe.d"
root@juju-da6b2f-nrpe-0:/home/ubuntu# checkfile="$nrpedir/${check}.cfg"
root@juju-da6b2f-nrpe-0:/home/ubuntu# command=$(awk -F "=" '{ print $2 }' $checkfile)
root@juju-da6b2f-nrpe-0:/home/ubuntu# echo $command
/usr/local/lib/nagios/plugins/check_reboot.py "2022-05-03 05:12:03"
root@juju-da6b2f-nrpe-0:/home/ubuntu# sudo -u nagios $command
usage: check_reboot.py [-h] known_reboot_time
check_reboot.py: error: argument known_reboot_time: time must be in format yyyy-mm-dd HH:MM:SS, same as output from uptime --since.
root@juju-da6b2f-nrpe-0:/home/ubuntu# echo $command  |xargs sudo -u nagios
OK: system is up since 2022-05-03 05:12:03
This is about the way bash passes args and quotes.


how do people make money from open source?

This would be a good question to answer on your site.

There's a whole section on "getting paid": https://opensource.guide/getting-paid/


Open DIV

https://github.com/kwk/docker-registry-frontend/blob/master/app/scripts/directives/repository-list-directive.html#L15
Should read </div> (and will mess up view in browseOnly);

See PR #42


Tracking issue for parse module

This is a tracking issue for a parse module in the Substrait crate.
Some requirements of Substrait can not be expressed via Protobuf definition or schema files. A parse module can provide types for the generated types, that when constructed are known to be checked. This enables producers and consumers to skip redundant checking of invariants described by the specification.
I want to propose incrementally building the parse module i.e. split up the intial work in #89 to help reviewers and to encourage collaboration.
Parser progress
Proto

[x] PlanVersion https://github.com/substrait-io/substrait-rs/pull/165

[x] Version https://github.com/substrait-io/substrait-rs/pull/164

[ ] Plan

[x] Version https://github.com/substrait-io/substrait-rs/pull/164
[x] SimpleExtensionUri https://github.com/substrait-io/substrait-rs/pull/169
[ ] SimpleExtensionDeclaration https://github.com/substrait-io/substrait-rs/pull/170

[ ] MappingType

[ ] ExtensionType
[ ] ExtensionTypeVariation
[ ] ExtensionFunction

[ ] PlanRel
[ ] AdvancedExtension
[ ] expected_type_urls

[ ]   PlanRel

[ ] RelType

[ ] Rel

[ ] ...

[ ] RelRoot

[ ] ...

[ ] ExtendedExpression

[x] Version https://github.com/substrait-io/substrait-rs/pull/164
[ ] ...

Text

[ ] SimpleExtensions

[ ] ...

Other tasks

[x] Add the parse module with traits to drive the parser https://github.com/substrait-io/substrait-rs/pull/164
[ ] Include core extensions in crate, so they can be added to a parse context
[ ] Add a parser cli
[ ] Add bindings to support using the parse module in other languages

Any plans to support parsing SQL directly?

Any plans to support parsing SQL directly?

Absolutely. I think a logical next step would be to add builders for the parsed types, which could be used to build a SQL to substrait tool.

Any plans to support parsing SQL directly?

Absolutely. I think a logical next step would be to add builders for the parsed types, which could be used to build a SQL to substrait tool.

Cool! I'm interested in this. Anything I can do?

Any plans to support parsing SQL directly?

Absolutely. I think a logical next step would be to add builders for the parsed types, which could be used to build a SQL to substrait tool.

Cool! I'm interested in this. Anything I can do?

If you want to contribute: this task would be a good one. Or else figuring out an ergonomic design for the builders.


TP2000-726 Content and UI amendments packaging queue view

TP2000-726 Content and UI amendments packaging queue view
Why
Small amendments could be made to improve the packaging queue UI.
What

Aligns 'Pause/Unpause CDS queue' button with table edge.
Amends 'Move' and 'Remove' text
Hides 3 'step process' icons

Before:

After:

Codecov Report
Base: 91.87% // Head: 91.90% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (b2eb24d) compared to base (b859f72).
Patch coverage: 98.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
+ Coverage   91.87%   91.90%   +0.03%
==========================================
  Files         394      398       +4
  Lines       25786    25882      +96
  Branches     1942     1943       +1
==========================================
+ Hits        23690    23788      +98
+ Misses       1716     1715       -1
+ Partials      380      379       -1

Impacted Files
Coverage Δ

publishing/forms.py
82.92% <ø> (ø)

publishing/views.py
61.81% <0.00%> (ø)

commodities/models/dc.py
74.80% <100.00%> (+0.03%)
:arrow_up:

commodities/tests/test_commodities_collection.py
100.00% <100.00%> (ø)

...dities/tests/test_commodities_collection_loader.py
100.00% <100.00%> (ø)

commodities/tests/test_commodity_tree_base.py
100.00% <100.00%> (ø)

commodities/tests/test_commodity_tree_snapshot.py
100.00% <100.00%> (ø)

importer/taric.py
79.73% <0.00%> (+1.30%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Completed Caesars Cipher algorithm passing and moving me backwards to an earlier waypoint

Issue Description
I am returned back to the Waypoint: Trigger Click Events with jQuery when I try to move to the next activity. I tried resetting by browser cache with no avail.

Steps To Reproduce
I punch Ctrl/Enter twice

Browser Information
Google Chrome
64 Bit Operating System
Your Code
function rot13(str) {
  var answer = [];
  for (var i in str) {
    if (str.charCodeAt(i) < 65 || str.charCodeAt(i) > 91) {
      answer.push(str[i]);
      continue;
    } else {
      if (str.charCodeAt(i) < 78) {
        answer.push(String.fromCharCode(str.charCodeAt(i) + 13));
        continue;
      } else {
        answer.push(String.fromCharCode(str.charCodeAt(i) - 13));
        continue;
      }
    }
  }
  return answer.join("");
}

Screenshot

That is the next challenge after Caesar's Cipher on the map, so that's expected.

Thanks and happy coding!


other: update specs2-core from 4.10.5 to 4.10.6

Updates org.specs2:specs2-core from 4.10.5 to 4.10.6.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2", artifactId = "specs2-core" } ]

labels: test-library-update, semver-patch

Codecov Report

Merging #16 (324dcc2) into master (9749aa8) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master       #16   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity        27        27
===========================================
  Files              1         1
  Lines            107       107
  Branches           8         8
===========================================
  Hits             107       107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9749aa8...324dcc2. Read the comment docs.


pkg-config no found yaml

branch zeus-draft
bitbake core-image-sato
Run-time dependency yaml-0.1 found: NO (tried pkgconfig)
meson.build:54:0: ERROR: Dependency "yaml-0.1" not found, tried pkgconfig
poky/meta/recipes-devtools/libmodulemd/libmodulemd_git.bb:do_configure) failed with exit code '1'

What DISTRO are you using? My guess is poky with rpm?
zeus-draft builds yaml version from ros:
meta-ros2-dashing/conf/ros-distro/include/dashing/ros-distro-preferred-providers.inc:PREFERRED_PROVIDER_libyaml = "libyaml-vendor"
meta-ros2-dashing/conf/ros-distro/include/dashing/ros-distro-preferred-providers.inc:PREFERRED_PROVIDER_libyaml-dev = "libyaml-vendor-dev"
meta-ros2-dashing/conf/ros-distro/include/dashing/ros-distro-preferred-providers.inc:PREFERRED_PROVIDER_libyaml-dbg = "libyaml-vendor-dbg"
meta-ros2-dashing/conf/ros-distro/include/dashing/ros-distro-recipe-blacklist.inc:PNBLACKLIST[libyaml] ?= "Provided by libyaml-vendor"

I've already blacklisted it in newer zeus-draft for Milestone 12:
https://github.com/shr-project/meta-ros/commit/66a93a8b4e
which unfortunately means that you need to use ipk package manager (like ROS and webOS DISTRO does).

ROS_DISTRO := "dashing"
vi poky/meta/recipes-devtools/libmodulemd/libmodulemd/0002-modulemd-v1-meson.build-do-not-generate-gir-or-gtkdo.patch
-yaml = dependency('yaml-0.1')
+yaml = dependency('yaml-0.1????')
What is the solution?

What OE DISTRO are you using? With ROS or webOS there is no dependency on libmodulemd.
The proper solution is to enable ros_opt_prefix for ROS2 as well (like ROS1 already does) and then let yaml-vendor to be installed for ROS components in /opt without affecting yaml in /usr prefix. But that's quite difficult to implement, it's still on our roadmap, probably after Milestone 14.

git://git.yoctoproject.org/poky
git://git.openembedded.org/meta-openembedded
machine jetson nano
https://github.com/madisongh/meta-tegra.git

The requirement is ROS2 operation on Xserver.
Running core-image-sato for the Xserver installs libmodulemd.
Is there a way to uninstall libmodulemd?
In yocto, do you use the Ros2 GUI unused?

I'm going to assume that the referenced pull requests work OK for you and everything was merged today, please create new issue ticket if you find some issues later.
"Silence implies consent" (see http://wiki.c2.com/?SilenceImpliesConsent).


Updated Template to display the Text element

Added the Text Component to the example.

Thanks for the PR! And sorry for the compilations troubles. I added a simple CI now for both projects. I also did release the patternfly-yew as 0.1.2 with your changes, so that the quickstart can pick it up.


Using Worktop in a Pages website

Hi Luke, I'm a big fan of your work! I'm trying to use Worktop in a Pages worker. The pages docs say I can use "advanced mode" to export a module worker like this
export default {
  async fetch(request, env) {
    const url = new URL(request.url);
    if (url.pathname.startsWith('/api/')) {
      // TODO: Add your custom /api/* logic here.
      return new Response('Ok');
    }
    // Otherwise, serve the static assets.
    // Without this, the Worker will error and no assets will be served.
    return env.ASSETS.fetch(request);
  }
}

Where should I put that env.ASSETS.fetch(request) call when using Worktop?

Hey, thanks!
So few approaches

If you know you only want to use worktop for /api/* routes, then you can build off of the snippet you shared:
import { Router } from 'worktop';
// NOTE: assumes worktop@next

const API = new Router;

API.add('GET', '/api/hello', async (req, context) => {
  return new Response('Example');
});

// ...

export default {
  async fetch(req, env, ctx) {
    const url = new URL(req.url);

    if (url.pathname.startsWith('/api/')) {
      ctx.bindings = env;
      return API.run(req, ctx);
    }

    // do fallback
    return env.ASSETS.fetch(req);
  }
}

Deploy a Module Worker (via worktop) and define a GET /* route last in your worktop app:
// NOTE: assumes worktop@next
import { Router } from 'worktop';
import * as cfw from 'worktop/cfw';

import type { Context } from 'worktop';
import type { Durable } from 'worktop/cfw.durable';

interface MyContext extends Context {
  bindings: {
    ASSETS: Durable.Namespace;
  };
}

const API = new Router<MyContext>();

API.add('GET', '/api/hello', async (req, context) => {
  return new Response('Example');
});

// ...

API.add('GET', '/*', (req, context) => {
  return context.bindings.ASSETS.fetch(req);
});

// initialize Module Worker
export default cfw.start(API.run);

Kinda similar to (2) but you use the onerror hook and if the handler if triggered with a 404 status you pass it off to context.bindings.ASSETS

I'd go with either 1 or 2 personally.
Hope that helps~

Here's another approach that essentially combines (1) and (2), making use of Router.mount to separate stuff into subrouters:
// NOTE: assumes worktop@next

// file: lib/types.ts
import type { Durable } from 'worktop/cfw.durable';

export type Context = import('worktop').Context & {
  bindings: {
    ASSETS: Durable.Namespace;
  };
}

// file: lib/router.api.ts
import { Router } from 'worktop';
import type { Context } from './types';

export const API = new Router<Context>();

API.add('GET', '/hello', () => new Response('GET /api/hello'));
API.add('GET', '/world', () => new Response('GET /api/world'));

// file: lib/router.main.ts
import { Router } from 'worktop';
import * as cfw from 'worktop/cfw';
import { API } from './router.api';

import type { Context } from './types';

const MAIN = new Router<Context>();

// All "/api/*" request to API subrouter
MAIN.mount('/api/', API);

// Everything else forward to `env.ASSETS` binding
MAIN.add('GET', '*', (req, context) => {
  return context.bindings.ASSETS.fetch(req);
});

// initialize Module Worker
export default cfw.start(MAIN.run);

Beautiful, thanks @lukeed. I'll use this as a stepping stone to build a full-stack app with server side rendering. Hoping to open-source it as a template if it works.
By the way, I had a great time using the current version of Worktop to make a back end example that talks to a database ❤ Keep up the good work, I really appreciate it! https://github.com/vladinator1000/cloudflare-workers-ts-graphql


[Proposal] Add option to unapprove other versions on page version scheduling

I'd added the message for editors to avoid misunderstanding about scheduling a new page version on #8311
However, many of my clients still misunderstand this "Schedule" button is for the page itself instead of the specific version of the page.
They claimed, Absolutely I set "To" date but the page still alive even if the time passed!
If this behavior is hard to understand, how about adding an option to make the "Schedule" button can control the page itself?

If you check this "Unapprove other versions" option, all versions will be unapproved, then "From" and "To" dates can control entire page.

I'm hung up on this, I'm having trouble figuring out whether this is the appropriate way to handle this problem, although I do understand why it's a problem.

OK


Audit: concatenate_input upbyte management

Actual output

The actual version does not cover the case for example where we have 0x01FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF, since the upper byte will return 0x02 instead of 0x01 (edge case)

Solution

Use instead the bitshift library, which make safely this operation

can I work on this issue


[UX] Don't force user to leave Dapp on tx

Current behavior
When I submit a transaction, I am forced to leave the dapp browser. Likely this is leftover from early dapp days, when most dapps did not track transaction progress.
Expected behavior
Make the default behavior to stay on the dapp browser page. Many dapps track tx progress now, and its very bad experience to "rip" them away.

hi. sorry for the belated response.
i suppose this issue had been addressed already.
please open a new one if needed. thanks.


Fix Static Code Analysis action

The semgrep scanning is complaining about GitHub Actions not being pinned, see https://github.com/finos/security-scanning/actions/runs/6416732661/job/17421042253 :
    .github/workflows/cve-scanning-docker.yml
       yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha.
  third-party-action-not-pinned-
       to-commit-sha
          An action sourced from a third-party repository on GitHub is not
  pinned to a full length
          commit SHA. Pinning an action to a full length commit SHA is currently
  the only way to use
          an action as an immutable release. Pinning to a particular SHA helps
  mitigate the risk of a
          bad actor adding a backdoor to the action's repository, as they would
  need to generate a
          SHA-1 collision for a valid Git object payload.
          Details: https://sg.run/koLA

           16┆ - uses: docker-practice/actions-setup-docker@master
            ⋮┆----------------------------------------
           21┆ uses: crazy-max/ghaction-container-scan@v2

@josspo - please review this issue and the resulting PR on https://github.com/finos/security-scanning/pull/291
It's very important that - before merging a PR - every GitHub Action passes, to make sure we're not introducing any regression; with the work on the Dependency Check action, the Semgrep action broke, due to the issue described here.

Done, all actions are green now!


Modernize projects, fix memory leak, set working dir

As discussed in #32 this PR:

Modernizes the solution / project formats
Converts the library to .NET Standard 2.0 for legacy and modern .NET compatibility
Updates DemoService to .NET Framework 4.8.1 (given 4.8 is the "forever" release of Framework)
Adds DemoModernService showing the implementation under .NET 8.0 (current LTS release)
Fixes the memory leak as described in #5
Applies the working directory fix described on StackOverflow

I know I said earlier I'd do two PRs, but since the modernization didn't touch ProcessExtensions.cs at all, I figured it would be easy to review both in this single PR. In my real-world project where I used a copy of this code, I also found that I needed the StackOverflow working directory fix, so I went ahead with that as well.

Looks great, thanks for putting this together!


the building sdk wiki maybe out  of date

https://github.com/dart-lang/sdk/wiki/Building
this wiki may out of date,  i build following the steps descride aboved, but tells missing various of files. can please update them?  thanks.

+1

@xiaohongjun0509 The Building page is fairly long. Can you tell us what steps are out of date, and what files were missing when you tried to follow the steps?


Things for Kyle

From Kyle's video...

Fix the ghosting when dragging a column header (actually a bug raised by Jeff)
Remove the drag handle and make the entire header cell draggable
Add isCounted and isReleased flags to the header cell. Only show when not isCounted or not isReleased.
Show the tool icon next to the title when there's an externalApp set

Fixes #17.

I've added my first attempt at fixed columns with their own fixed header. The complexity of this makes me sad :person_frowning: and gosh knows how the performance will be as there's a lot of things happening on the onscroll event :sob:
If this turns out to be buggy then I'm tempted to refactor the entire table into two tables.  The accessibility constraint might need to be softened if we want this behaviour.. but at least the code want be :dizzy_face:


Peer review

I removed some unused files, generated by Visual Studio wizard.
I also found that there were some unused references - removing them can speed up project building.

Looks Good.
Thanks.


added note about exchange email location

#965

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

@MaratMussabekov - please merge the commit on the copy/edit review done by JohanFreelancer9 or make the necessary changes on the PR following the suggestions made. Thank you.


AOT compilation stability

https://github.com/arcadia-unity/Arcadia/blob/develop/Source/arcadia/internal/map_utils.clj#L1 needs to require clojure.core.protocols to succeed at arcadia.compiler/aot-namespaceing  arcadia.core in one go.
arcadia.config option to :disable-build-compile (useful when you've manually aot'd your project, granular ignores per lib name might be nice down the road)
compile dependency caching - right now every user clj file will compile it's full dep graph. Assuming that full de-duplication is not easy, perhaps the arcadia and clojure subsets could compile earlier, to be be skipped when walking user deps?
sniff namspace meta - avoiding compilation of (ns ^:editor foo) could help prevent editor utilities breaking the build process - currently these kinds of namespaces have to be commented out or renamed when building.

for the last two, something like the following in arcadia.internal.editor-interop would work well.  I also believe you don't need assume an aot of clojure.core and arcadia.core, just a single user namespace pass.
(defn aot-user-namespaces! [out]
  (spit "Assets/dag.clj"
    (str (list 'ns 'dag
      (->> (all-user-namespaces-symbols)
           (remove (comp :editor meta find-ns))
           (remove #{'dag})
           (cons :require)))))
  (arcadia.compiler/aot-namespace out 'dag))

presumed closed as of a6b8fa7c2a23a731d2d2b01a66b1276ccdc984bc


No IDE validator message does not include a link to VS Code

Currently we only suggest downloading Intellij - this should be updated to include VS Code too.
FYI @csells

Also FYI @DanTup


Countdown timer javascript

Pull Request Type
What kind of change does this PR introduce?
[ ] Solved an issue/task
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?
Implementing a Countdown Timer through JavaScript
Issue Number: 1507
What is the new behavior?

Other information

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


fix(idle_connections): Fixing idle connections and formatting

This fixes #109 and adds some formatting.
Precommit-Verified: 1d89f3b71592aabf931814b50d0088977367f936c12a6819f45e9b1b8d6ec2c5

With the severity of this bug, I'm going to merge and get it out. It's causing some resource issues on our vcenter instance.

With the severity of this bug, I'm going to merge and get it out. It's causing some resource issues on our vcenter instance.

Fixes test
@@ -482,7 +482,7 @@ def test_collect():
         ).return_value = _succeed(True)
         stack.enter_context(mock.patch.object(collector, '_vmware_get_datastores')).return_value = _succeed(True)
         stack.enter_context(mock.patch.object(collector, '_vmware_get_hosts')).return_value = _succeed(True)
-        stack.enter_context(mock.patch.object(collector, '_vmware_disconnect')).return_value = _succeed(None)
+        stack.enter_context(mock.patch.object(collector, '_vmware_disconnect')).return_value = _succeed(True)
         metrics = yield collector.collect()

Looks like I need to to fix the tests so they don't freeze up. Not sure where to start

@pryorda The diff from @kremers fixes it for me

PR #108 has been updated, fixing all open PRs/Issues
Just saying

closing in favor of 108


How to maintain numbering when multiple people are working

Hi,
How do we maintain the numbering if more than one person is working on the project.
Meaning, if two people are working on the project, it is possible, they both can tend to name the script as 1.<script_name_xyz>.sql OR
1.<script_name_abc>.sql
Is there any constraint or requirement that the numbers should not collide?

Coordination is important when working with multiple developers.  Usually, teams will "claim" numbers in some kind of chat system (skype group, slack, flowdock, etc.), which works really well.  Order is often very important, so all scripts are run in order.  If scripts collide, a warning message will be given, letting you rename the script with a different number.

Ok. thanks for the prompt response.


Bump up rk-entry version to v2.1.4

Codecov Report

Merging #96 (c780183) into main (f595ef7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   89.53%   89.53%
=======================================
  Files           1        1
  Lines          86       86
=======================================
  Hits           77       77
  Misses          5        5
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2171ba8...c780183. Read the comment docs.


Support annotation.textcoords == "offset points"

This modifies _annotation to return the location at which the text should be rendered, and then adds support for offset points and offset pixels.
This should make it easier to add support for the other coordinate type too, but I'll leave that for someone who needs them.

You need to make format. Also, some of the test outputs are changing with this. Use test/refresh_reference_files.py to update.

Will do that if / when I get around to actually making a git checkout, and not just editing these files in site-packages and pasting into github...

Turns out I needed to switch to a different python installation, at which point editing site-package wasn't an option. Updated.

LGTM, thanks!