Re-enable CDH ITs and disable BasicSecondaryIndexIT on DynamoDB

I'm thinking that this commit should be split into two - disabling the DynamoDB test, and the CDH IT enable. The latter cannot be merged in without causing problems


TypeError: csv is not a function

Are the docs up to date?
When I try:
const csv=require('csvtojson');
csv()
.fromStream(response)
  .on('csv', csvRow =>{
    console.log(csvRow);
  })
  .on('done', error =>{
    console.error(error);
  });
});

I always get a console - TypeError: csv is not a function.
If I try to console.log(csv) I get: console - { Converter: { [Function: Converter] super_: { [Function: Transform] super_: [Object] } },...

Could you let me know what version of both  type/csvtojson and csvtjojson you are using?

On 21 Apr 2017, at 17:56, João Campos<EMAIL_ADDRESS>wrote:
Are the docs up to date?
When I try:
const csv=require('csvtojson');
csv()
.fromStream(response)
.on('csv', csvRow =>{
console.log(csvRow);
})
.on('done', error =>{
console.error(error);
});
});
I always get a console - TypeError: csv is not a function.
If I try to console.log(csv) I get: console - { Converter: { [Function: Converter] super_: { [Function: Transform] super_: [Object] } },...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I had the same issue. updating to newest version solved it. I'm guessing that either api have changed or error message have been corrected (I had a second error that my file path was wrong)

Using React and csvtojson (1.1.9), I had to require csvtojson rather than csv.
const csvtojson = require ('csvtojson')


Support rule parameter and arguments

Accidentally fixes https://github.com/langium/langium/issues/313 (My tests wouldn't run without fixing it)
Makes use of Chevrotain's semantic predicate feature to build GATES from the guard conditions of alternatives. Also adds validations to check for the correct amount of arguments and unused rule parameters.

Nice! I'm really looking forward to trying it out


Increasing drop area

How would you increase the drop area for a <Container>?

you can bind CSS classes to the container and configure the size of the container.
<Container :class="{mycontainer: true}" />

Cool, thanks.


aurbuild: hook support

I would like to propose adding support for some kind of hooks that allow users to define additional requirements that packages should fulfil before they are built.
The main idea would be to add pre-build hooks that have semantics similar to git pre-{commit,push,receive} hooks, i.e. the current action should be cancelled if a hook exits with non-zero.
I propose defining a folder in which hooks can be placed as executable files. aursync or aurbuild would execute them in the order returned by find.
Because of the strong coupling between aurutils and the system, I propose making this folder system-wide, such as /etc/aurutils/hooks/pre-build.d/.
The hooks could be passed the path to the untarred or cloned build files from AUR and maybe the pkgbase, name of the committer, etc.
Some applications I can think of:

check hashes for specific versions against a trusted database (which is what I am working on)
a trust management system (some maintainers are blindly trusted for specific packages, others require manual confirmation)
impose custom restrictions on the system by making a hook write-protected and immutable and preventing other users from changing that
turn your Philips Hue into a red strobe light whenever someone tries to build yaourt :wink:
anything you can think of
and generally allow loosely-coupled extensibility of aurutils, which is a great thing in itself.

I am ready to implement this, and it won't require much work to make it usable in a basic form.
I opened this issue to let people know what I plan on doing and to ask for feedback, especially what exactly others might want to use, and where the hooks should go.

I've talked a bit about this on #archlinux, and they suggested that instead of hooks, you could expand on the existing idea of using pipelines. For example:
aurchain <pkgs> | check_hashes | check_trust | aurbuild

Furthermore these parts of the pipeline could have varying outputs depending on their use case. e.g.  you could have aurbuild return failed/succesful builds on stdout, or have aurchain print pkgbase instead of pkgname.
How does that sound?

Sounds good for my own task, but I don't really see a way to make that loosely coupled.
The nice thing about hooks is that everyone could profit from them and no-one has to fork or patch aurutils for anything.

A pipeline is already loosely coupled while still having tight cohesion.
Any filter you write can be inserted where ever you wish so long as each tool properly makes use of the (universal interface)[http://dl.acm.org/citation.cfm?id=191771] without needing to hardwire unrelated mechanisms such as hooks or triggers.
http://www.leancrew.com/all-this/2011/12/more-shell-less-egg/

@Earnestly Thanks for the link, it's an interesting read. (A google books search did not find a mention of universal interface in the book, can you give me a page number?)
The problem is not distribution, people can easily make packages for that.
Rather, how would one enable filters without patching aursync or replicating it by hand?
What I like about hooks is that they allow a standard way of calling things automatically if they are configured, e.g. by symlinking to them.
Do you have an idea for how a similar usability can be achieved within a pipeline?
Other than that, I like the filter idea, except that they would most likely break dependency resolution - For most of the ideas I listed, outright cancelling everything like when a build fails would probably be a better solution.

Write programs that do one thing and do it well. Write programs to work together. Write programs to handle text streams, because that is a universal interface.

A quote from Doug McIlroy in the book by Salis.
Why would aursync need to be patched?  The original design concept of aurutils was to follow a pipeline approach, if that has changed, and the pipeline has become internal and proprietary to the tool (as so many tend to), then all of this simplicity is lost.

Thanks for your replies, you make me think and I appreciate that.
I think that one of us is missing something. It's one thing to write a program in such a way that it's parts are reusable, and another thing entirely to allow users to modify it's central pipeline.
What I want is users to be able to call aursync -scu and have their additions transparently included somehow (like plugins or hooks work).
Do you have an idea for how to implement that? The best I could come up with since your last message would be to allow users to specify an array of commands in a file, which would then be inserted into the internal pipeline. That doesn't sound very robust to me though.
Additionally, even if the above was doable somehow, there are still some potential issues with the pipeline approach for this specific use-case. I know how to build my project as a pipeline, and I will probably do that either way, but I cant' think of a sensible way to make filters work in aurutils.

They would have to be added after aurchain, which would completely break dependency resolution and make the entire thing unusable. Maybe I am missing something about the way aurutils works?
Pretty much every use-case I can think of would require a path to the downloaded/cloned build files. That output is not currently available in the pipeline AFAICT
I'm not sure that checksum verification would work well as a stream filter. It would probably be better to cancel the entire build process as soon as an error occurs, like what would happen if a gpg signature verification failed when calling pacman -Syu.

Do you understand what I mean? Maybe there is something I don't know - if so, please tell me :)

Do you have an idea for how to implement that? The best I could come up with since your last message would be to allow users to specify an array of commands in a file, which would then be inserted into the internal pipeline. That doesn't sound very robust to me though.
(...)
Pretty much every use-case I can think of would require a path to the downloaded/cloned build files. That output is not currently available in the pipeline AFAICT

aursync is different from the other scripts in that essentially, it's already the final pipeline. In other words, "a big lump of code". One of the reasons is what you mentioned on path information.
In the long term, splitting aursync to smaller, generic parts may be more effective, but I haven't looked yet at how to implement this.
They would have to be added after aurchain, which would completely break dependency resolution and make the entire thing unusable. Maybe I am missing something about the way aurutils works?

I'm not sure what you mean here. aurchain is the dependency resolution.
I'm not sure that checksum verification would work well as a stream filter. It would probably be better to cancel the entire build process as soon as an error occurs, like what would happen if a gpg signature verification failed when calling pacman -Syu.

Well, you can always use set -o pipefail if you want the entire pipe to abort when one its members does.

@AladW Thanks for your reply!
I will read that post when I get to it, thanks for that!

aursync is different from the other scripts in that essentially, it's already the final pipeline. In other words, a big lump of code. One of the reasons is what you mentioned on path information.

Right. Which means that it is not extensible the way @Earnestly would want it, correct? So hooks would work, adding pipeline elements wouldn't?

I'm unsure what you mean here; aurchain is the dependency resolution.

I know, and that's the problem. Anything filtered out after aurchain would mean that some packages may lose one of their dependencies, in which case outright cancelling the entire build in order to avoid an inconsistent state would be better, I think.

Well, you can always use set -o pipefail if you want the entire pipe to abort when one its members does.

Indeed. But that would defeat the entire point of the pipeline, wouldn't it? Because the filter would only ever output everything it read on stdin, or abort (in which case it would be better not to have written anything before, since the following program might otherwise already have produced side effects).
I think you understand my problem. Do you see why I think that hooks solve it, and do you know of a more elegant solution I could use instead? :)

To speed things up, hooks could be piped paths to all packages about to be built on stdin. That would still allow similar semantics, since one would probably want to abort completely if a verification for one package fails.

Right. Which means that it is not extensible the way @Earnestly would want it, correct? So hooks would work, adding pipeline elements wouldn't?

Well, aursync is an example of how to use the other aurutils scripts which do work with the pipelining approac. Ideally you'd isolate the useful parts and make creating your own specialized helper a simpler task.
Right now that isn't the case, e.g. with the AUR not handling pkgname transparently. In that sense tying more content to aursync via hooks is unlikely to improve on this situation (I assume aursync is the only script we're discussing hooks for at this point).

I know, and that's the problem. Anything filtered out after aurchain would mean that some packages may lose one of their dependencies, in which case outright cancelling the entire build in order to avoid an inconsistent state would be better, I think.
Indeed. But that would defeat the entire point of the pipeline, wouldn't it? Because the filter would only ever output everything it read on stdin, or abort (in which case it would be better not to have written anything before, since the following program might otherwise already have produced side effects).

I guess the objection here is that all tasks should be done in one, single pipeline?

To speed things up, hooks could be piped paths to all packages about to be built on stdin. That would still allow similar semantics, since one would probably want to abort completely if a verification for one package fails.

Right now that's not the case; e.g. with the AUR not handling pkgname transparently. Improving on this aspect is unlikely helped by tying more content to aursync (for example via hooks; I assume aursync is the only script we're discussing hooks for at this point).

Well, I think the semantics work out better if the hooks are executed by aurbuild, since I view the {hooks,plugins,whatever} as extensions to source integrity checking.

I guess the objection here is against doing all tasks in a single pipeline?

Against doing all tasks in a truly parallel pipeline, yes.

Can you give a simple code example of what this entails?

for hook in $hooks; do
    hook "$base" <"$queue" || exit 1

As a simple example of semantics more than syntax :)
Looking at the code for aurbuild, which I was not familiar with yet, I think that a good way to call hooks would be in the read loop, after line 143.
I am a little confused though to not see any exit status checks. How do you abort ifmake{,chroot}pkg fails?

I am a little confused though to not see any exit status checks. How do you abort ifmake{,chroot}pkg fails?

By relying on set -e. I'm not fond of this (see BashFAQ 101, but aurbuild is simple enough to not worry on edge cases.

Oh wow. Just glancing over that scared me. Thanks for the explanation :)
What do you think about my proposal?

Other examples for aurbuild hooks I could think of is rsync (to update a remote repository over ssh) or some alternate to makechrootpkg for chroot builds.
Either way I'll have to think a bit about this. Any other opinions?

No need to rush your decision, I'm not in a hurry :)

Any news? :)

@AladW I have a small question about the queue file.
Is it fair to assume that it will always be a text file, and not a FIFO or similar?
Specifically, I would like to assume that it is rewindable.
That would allow piping it's contents into every hook, substantially improving performance.
If not, I could try using stat to print a warning and not run the hooks, or maybe cancel, if the queue is not seekable.

To give you an idea of what I have in mind:
diff --git a/bin/aurbuild b/bin/aurbuild
index d92161c..2dc906c 100755
--- a/bin/aurbuild
+++ b/bin/aurbuild
@@ -8,7 +8,7 @@ machine=$(uname -m)
 tmp=$(mktemp -dt "$argv0".XXXXXXXXXX)

 declare -r PS4 argv0 base machine tmp
-declare -i chroot=0 sign_pkg=0
+declare -i chroot=0 sign_pkg=0 EHOOK=42

 gpg_args=(--verbose --detach-sign --no-armor)
 makechrootpkg_args=(-cu)
@@ -84,6 +84,13 @@ fi
 if [[ $queue ]]; then
     if [[ -r $queue && ! -d $queue ]]; then
         exec 3< "$queue"
+
+        # Execute pre-build hooks
+        msg "Executing pre-build hooks..."
+        while read -r hook; do
+            msg2 "$(basename "$hook")"
+            $hook <"$queue" || exit $EHOOK
+        done < <(find /etc/aurutils/pre-build-hooks.d/ -maxdepth 1 -L -executable -not -type d)
     else
         error "$argv0: queue: must be a readable file"
         exit 13

Is it fair to assume that it will always be a text file, and not a FIFO or similar?

Initially it was checked that the queue is an actual file (test -f), but that was changed to readable (test -r) so you can e.g. use aurbuild -a <(echo foo).

Thanks for the fast and helpful reply! :)
How about this then?
It has the disadvantage that some packages could already have been built when a hook failed, so it may be better to cancel if hooks exist and the queue is not seekable.
diff --git a/bin/aurbuild b/bin/aurbuild
index d92161c..a6e6085 100755
--- a/bin/aurbuild
+++ b/bin/aurbuild
@@ -8,7 +8,7 @@ machine=$(uname -m)
 tmp=$(mktemp -dt "$argv0".XXXXXXXXXX)

 declare -r PS4 argv0 base machine tmp
-declare -i chroot=0 sign_pkg=0
+declare -i chroot=0 sign_pkg=0 queue_not_seekable=0 EHOOK=42

 gpg_args=(--verbose --detach-sign --no-armor)
 makechrootpkg_args=(-cu)
@@ -84,6 +84,17 @@ fi
 if [[ $queue ]]; then
     if [[ -r $queue && ! -d $queue ]]; then
         exec 3< "$queue"
+
+        if [[ -f $queue ]]; then
+            # Execute pre-build hooks
+            msg "Executing pre-build hooks..."
+            while read -r hook; do
+                msg2 "$(basename "$hook")"
+                $hook <"$queue" || error "Hook $(basename "$hook") failed!"; exit $EHOOK
+            done < <(find /etc/aurutils/pre-build-hooks.d/ -maxdepth 1 -L -executable -not -type d)
+        else
+            queue_not_seekable=1
+        fi
     else
         error "$argv0: queue: must be a readable file"
         exit 13
@@ -133,6 +144,14 @@ fi
 while read -r -u 3 pkg _; do
     cd_safe "$base/$pkg"

+    if ((queue_not_seekable)); then
+        msg "Executing pre-build hooks..."
+        while read -r hook; do
+            msg2 "$(basename "$hook")"
+            $hook < <(echo .) || error "Hook $(basename "$hook") failed!"; exit $EHOOK
+        done < <(find /etc/aurutils/pre-build-hooks.d/ -maxdepth 1 -L -executable -not -type d)
+    fi
+
     if ((chroot)); then
         sudo PKGDEST="$pool" makechrootpkg -d "$pool" -d "$root" -r "$container" "${makechrootpkg_args[@]}"
     else

I've pushed a commit which makes -a optional. That way you can use a wrapper that calls aurbuild from the PKGBUILD directory using a similar while/read strategy, for example:
for hook in "${prebuild_hooks[@]}"
  "$hook" < ./queue || exit
done

while read -r -u 3 pkg _; do
  aurbuild -d custom
done 3< ./queue

There's some overhead from calling aurbuild on each package, in particular an additional pacman -Syu for chroot builds. However that case is neglible with makechrootpkg running rsync -delete on every invocation anyway. Is this acceptable for "hook support"?

I could use a wrapper, but ideally I would like to have something that integrates directly into whatever people would use, most notably aursync.
Just like pacman's signature verification and hooks work with yaourt, or ~/bin/pacman-wrapper, or whatever else one may use.
If you don't want to have hooks in aurbuild, I can work with this and will stop bothering you. It would be optimal to have a variable for aurbuild in aursync, similar to PACMAN, so people could do AURBUILD=aurbuild-hooks aursync ..., if that's okay with you?
Out of curiosity, what do you dislike about my proposals? I'd like to learn as much as possible out of this :)
Thanks for 2613522 in any case, that's a very useful feature to have :)

I suppose I can add an environment variable to aursync. Of course, you'd have to keep track of the command-line options and similar. If aursync is the main target, a better way might be to keep a minimal patch (i.e., which is likely to remain functional) you can add to the aurutils PKGBUILD:
diff --git a/bin/aursync b/bin/aursync
index 6f77396..ce18296 100755
--- a/bin/aursync
+++ b/bin/aursync
@@ -315,7 +315,15 @@ fi
 if ((build)); then
     aurbuild_args+=(-d "$repo" -r "$root" -a "$tmp"/queue)

+    if [[ -d /etc/aurutils/hooks.d/pre ]]; then
+        run-parts --exit-on-error --verbose /etc/aurutils/hooks.d/pre --arg foo
+    fi
+
     aurbuild "${aurbuild_args[@]}" -- "${makepkg_args[@]}"
+
+    if [[ -d /etc/aurutils/hooks.d/post ]]; then
+        run-parts --exit-on-error --verbose /etc/aurutils/hooks.d/post --arg foo
+    fi
 else
     msg "Sources saved to $PWD"
 fi

Or however complex you like, as long as it stays in the relatively invariant build block.

Out of curiosity, what do you dislike about my proposals? I'd like to learn as much as possible out of this :)
More that I find it preferable if you can achieve the same effect with external tools, rather than add code to the program itself. something something unix way.

FWIW, I've found some different way to share data between scripts, by adding options that let you specify the path of the temporary directory. That might address some of the concerns discussed earlier in this thread (https://github.com/AladW/aurutils/issues/184#issuecomment-257096066 ff.). For an example, see https://github.com/AladW/aurutils/blob/master/bin/aursync#L269.

Of course, you'd have to keep track of the command-line options and similar logic of aurbuild.

I would just forward everything.

If aursync is the main target, a better way might be to keep a minimal patch

That would have been the easy way. I wanted to try extending it first though, because I thought that others might be interested :)

More that I find it preferable if you can achieve the same effect with external tools, rather than add logic to the program itself. something something unix way.

That's good as long as no-one else wants to do the same thing. Heck, pacman's hooks could probably be replicated with something like etckeeper and some git hook magic. But that's not convenient if everyone wants to use it, or packages want to be able to ship hooks.
The temporary directory looks interesting :)

If this is your last word, feel free to close this issue and I will decide whether to use an environment variable and wrapper, provide a patched version, or write my own pipeline.

This should work (unless I decide to set PATH at some point):
hash -p ~/.local/bin/foobuild aurbuild
aursync <args>

Similar for other commands, such as aurcmp, aurfetch, aurchain etc.
Note that with #200, aursync is now being split to several independent programs; the goal is to have it be little more than a repository selection tool. So it should be easier to replace or modify for your own purposes. Thanks for the suggestions.
P.S. Also an opportunity to plug for repoctl, which as pre_action and post_action support.

Thanks a lot!
Would putting the hash command in ~/.bashrc work when calling aursync from zsh?

Well, afaik interactive scripts don't source ~/.bashrc, and hash doesn't seem to work when run from a script. You can try this though:
% cat myaursync
#!/bin/bash
aurbuild() {
	: # your code here
}

export -f aurbuild

command -- aursync "$@"

I've added a -p flag to aursync which prints packages in the queue together with their absolute paths, then instead of the above you can do something like this:
aursync -p | while IFS= read -r; do
  cd "$REPLY"
  my_pre_stuff
  aurbuild -d custom
  my_post_stuff
done


Input file not working

Hello,
this doesn't work for me, i'm using chrome version is 61.0.3163.100.
instead of the upload box, im seeing this: https://gyazo.com/47012759c87e36ba53b0fc094f38e9c6

Cannot replicate with Chrome 62.0.3202.38 on Mac OS X 10.12.4. Are you able to go to chrome://version and provide us with your full User Agent?

I'll hazard a guess that it's due to the fact that custom file input https://getbootstrap.com/docs/4.0/components/forms/#file-browser generates the text for placeholder/button based on language (i.e. lang(en)) and your language is set to dutch?

we should probably have a fallback (english) in the distribution version so that the custom file input doesn't look empty when the site author hasn't customised it to all possible languages that a site visitor may have. @mdo

user-agent:
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

xref https://github.com/twbs/bootstrap/pull/24259

The answer is what @patrickhlauke said 👍
Closed related to #24259


Build fails when "quote" dependency resolves to "1.0.3" (Fix available, publish to crates.io)

EDIT: This appears to be fixed with 88d3062 Would it be possible to publish this fix to crates.io?
Here is what cargo is outputting:
error[E0432]: unresolved import `quote::__rt`
  --> C:\Users\User\.cargo\registry\src\github.com-1ecc6299db9ec823\swc_macros_common-0.3.0\src\binder.rs:38:23
   |
38 | use quote::{ToTokens, __rt::TokenStream};
   |                       ^^^^ could not find `__rt` in `quote`

This occurs on both stable and nightly toolchains, and started happening after I ran cargo update on my crate. My crate depends on the most recent version of swc that's published on crates.io.
My guess is that the associated code was relying on undocumented features of the quote crate, and those features where changed when the quote crate was updated to 1.0.3. Hopefully this is just an easy patch to Cargo.toml to lock the version of that crate.
Please let me know if you need more info.
Finally, thank you all for this project! It's fundamental to what I'm working on and I'm very grateful for the work you all put in.

The fixed version has been published. Thanks!


Raise the Runtime error when DoFn.process uses both yield and return

addresses #22969:
Do not allow mixing yield and return statements in the process method for DoFn

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@tvalentyn PTAL.

Run PythonDocker PreCommit


Observing high CPU Usage when watching on large directories. Expected?

I have a few questions regarding the library itself

Since there is a constant file walking don't you think crawling in this manner
would spin the disks up all the time?
There are no asynchronous awake events, is there a possibility events might get lost?
Some small tests seem to work fine, but i am worried about large directories and deep d
directory structures?

Hey @harshavardhana,
High CPU would be expected when polling large directories (with a short polling duration at least). Unfortunately with filesystem polling and small poll durations, this is a side effect for trying to achieve real time events notifications.
There are alternatives such as fsnotify that may be better for this type of issue since it actually uses filesystem event notifications and not filesystem polling. Watcher was created to not have to use filesystem events, but there are pros and cons depending on what you're trying to achieve.
As for events getting lost, this also comes back to the previous point where if you were to poll for a long duration and before a poll cycle 3 writes happen to a file, you would only receive a single event once the poll cycle runs that the file has been modified. If you need 100 percent of events I would go with a non-polling option for sure.
On point 3, I still have lots more tests that need writing, but as of right now, I've manually tested/used watcher in deeply nested structures and haven't had any problems so far, but if anything comes up, let me know!
Regards, Benji


docs: add task modifier explainer

I've added the explainer for the task modifiers. This is still missing a couple of things IMHO:

[x] a good example for keepLatest (maybe fetching on some event that could be frequent enough so that you don't want to use restartable but are ok with loosing intermediate calls)
[x] a proper conclusion

But i'm putting this up now for you guys to proof read since i need to prepare something quickly for This Week in Svelte. I might go back to it if i finish soon.
I've modified @beerinho example component slightly for the use case, we can see if we want to keep it this way or not.

@BlueCutOfficial can you roast me on this pls? 🥺

Apparently disabling a button while the action completes is bad a11y, so using drop after submitting would be a good example of drop - https://mainmatter.slack.com/archives/C55DR890R/p1727435610148809


Use median instead of average for total cheat score

The current anti cheat module stores the likelihood of individual challenges having been cheated and then calculates the average as a total cheat score. When running the automated tests (which solve almost all challenges in mere minutes) there's usually a total cheat score of 85-89% calculated at the end of the suite.
The average drops off whenever a trivial or related challenge is solved, counting as 0% cheat probability and therefore bringing the average down. If the median would be used instead, the impact of such outliers would be reduced. Similarly, an honest user who just by coincidence solved one challenge "too fast" would no longer end up with an arbitrarily high total score.

Hey @bkimminich  I would like to work on this issue. Can you Please assign me this issue?

Sure, feel free to go for it!


Ego car does not move when I record scenarios using rosbag.

Describe the bug
When I try to record scenario test runner by setting record:= true, ego car does not move in the simulator. Same scenario runs as expected when I set record:= false. The following is the log obtained by changing only the record settings and executing a scenario with the other settings being the same.
launch-record-false.log
launch-record-true.log

Running command

ros2 launch -d scenario_test_runner scenario_test_runner.launch.py \
  architecture_type:=awf/universe \
  record:=true \
  scenario:='$(find-pkg-share scenario_test_runner)/scenario/RoutingAction.FollowTrajectoryAction-autoware.yaml' \
  sensor_model:=sample_sensor_kit \
  vehicle_model:=sample_vehicle

To Reproduce
Steps to reproduce the behavior:

Finish to set up for both Autoware and scenario simulator v2.
Execute above command where autoware is located.
See if the scenario running as expected.

Expected behavior
Ego car should move according to the scenario regardless of record setting.
Desktop (please complete the following information):

OS: ubuntu 22.04
Browser N/A
Version [e.g. 22]
ROS 2 version: humble
DDS

I solved it. This is related to https://github.com/tier4/scenario_simulator_v2/issues/1179 and is about an Autoware performance issue, not a bug in the scenario simulator.

https://autowarefoundation.github.io/autoware-documentation/main/support/troubleshooting/performance-troubleshooting/#check-the-dds-settings


[Feature Request] Add ability to change cms logo and logo url

We would really like to use your theme for our client sites but until this issue is fixed we are stuck using the silverstripe-cms-branding admin theme/module. So I thought that while I was here posting the other issue I might as well request that moderno supports the silverstripe-cms-branding module (because right now it doesn't seem to) or that you incorporate similar functionality into your admin theme.
Thanks in advance,
Mooror

That's a good suggestion as well, I'll also look into this for the next release.  :)

Thank you for your consideration. Do you happen to have a rough idea about when we could expect the next release?
Thanks,
Mooror
P.S. I can certainly understand if a timeline is not available at present. I myself find it hard to give time estimates because of the nature of programming (and bugs).

Hi again @mooror!  Looks like I'm going to take the 2nd route with this, and implement the CMS branding functionality within Moderno.  I took a quick look at the CMS branding module and it's... pretty awful lol, so I'm going to replicate it and push to master as soon as a I can.  I'll probably tag the next release after I push that change, so bear with me.

There we go @mooror - have a play around with the new branding tab under Moderno in settings. 😄

Thank you so much for adding this so quickly. I will try out the new settings as soon as I can and post my feedback here.
Thank you for your hard work,
Mooror
P.S. Sorry about the CMS branding module, I had not looked at its code so I had no idea it was "pretty awful".

So I just installed the new version with composer and tested it out and I gotta hand it to you, your version of the CMS branding is very slick. The ui is very nice and fits very well with the rest of the moderno design. Great work. Now I did come across one issue that I thought I would mention and that was to do with the custom loading image (which is an awesome feature btw). When I uploaded this test gif to try out the new setting. Nothing seemed to change when I would move between cms pages, the default loader still showed up. So I flushed the cache and initiated a dev/build to see if that would remedy the issue. This did indeed change something, as I spotted the custom loader when I traveled from my dev/build url back to the cms (admin/) back-end. But the custom icon was showing up above the default loader (instead of replacing it) and when I moved around inside the cms it was still displaying the default loader. I will try to get a screenshot of what I'm experiencing to clear up and misunderstanding.
Your work is appreciated,
Mooror

Here is a couple screenshots:
Moderno loader settings
Mooror

Ahh I see, no what Moderno (and likewise the CMS branding module) is doing is allowing you to customise the logo that appears on the loading screen, not the spinner.  However, I could add customisation of the spinner for a future release perhaps.  ;)

Oh okay, that makes sense. I apologize for the misunderstanding. I myself have not used the CMS branding module. A colleague of mine used it quite often, and therefor was having trouble moving over to moderno. That's why I requested similar features be added. Hopefully that helps explain my apparent lack of understanding for the "Loading Image" setting :D

Thanks!  Customising the spinner is a good idea though too, I'll keep that in mind. ;)


Financial management

We have money management, payment but don't have place to Financial management.
It's place when i can add credit card with the account, can plus money, minus money when needed

Hello @manhtd98 👋
Please follow the bug report issue template . Without the details, we can't really help you.

Hi, i created new here: https://github.com/saleor/saleor/issues/11144


Release tags discussion

Hi @pedroscaff,
What are your thoughts on release tags ?
I'm thinking it could be a great way to automate deliveries, and source tarballs. I do not know how tarball releases can be automated, but this can be a first way to do this.
I am thinking of this kind of things:
https://github.com/OP-TEE/optee_os/tags
Regards,
Raph

For information I just prepped locally each and every tags of the baseline. I also signed them, so users know they can trust it.
If you agree I can push them.
Regards,
Raph

hi @GallaisPoutine, I think it is a good idea! It would be nice to have the release tag + do a cargo version update (which I think it is already required for some automated archlinux packaging thing for our project). As a second step we could also add binaries to the releases. I'll create one issue and if you feel like working on it go for it! Thanks for bringing this up

https://github.com/pedroscaff/swaywsr/issues/39

https://github.com/pedroscaff/swaywsr/issues/40

@GallaisPoutine I created two issues, feel free to give your input there as well, I just tried to give some first guidance since I have good experience with devops/CI/CD.


CoreOS/MaaS integration

can we install CoreOS ISOs onto MaaS nodes?  Its unclear at the moment!

CoreOS is not listed as a supported operating system.
It appears that only paying users can use an OS other then an ubuntu variant.  This isn't great.

We can not install CoreOS via MaaS right now.  @countspongebob is going to try and see what can be done to give us access to do this.

or: http://askubuntu.com/questions/759109/maas-2-0-importing-custom-images-does-not-work
back to ToDo for this issue

this is 100% possible:  http://maas.ubuntu.com/docs/os-support.html?highlight=custom image
except that CoreOS is an immutable OS and that doesn't play with MaaS.  Should be available at the same time that ubuntu core is in April.  Mothballing until then.

We are expecting to see something from Canonical earlier than April... April is "GA". Expecting an update from them in the next week. Expecting that whatever solution they come up with with handle CoreOS and Ubuntu core.

Any news on this?  Would like to use MaaS to rollout a coreOS setup.  They just released Matchbox, which i may end up using in place.

@distributorofpain we had to let this drop for a bit.  We're planning on picking it back up in July/August.

@distributorofpain Can you say a bit more about your use case?


nextjs-ollama-llm-ui: 1.0.1 -> 1.0.2

Fixes Ollama response streaming instead of waiting for whole response and enables voice input.
See https://github.com/jakobhoeg/nextjs-ollama-llm-ui/releases/tag/v1.0.2
Fix cfg.ollamaUrl not taking effect.
Description of changes
Bump version (draft, because fixes aren't released yet)
Try this new version out by replacing the normal nextjs-ollama-llm-ui package as follows:
{
  inputs.nixpkgs-unstable.url = "nixpkgs/nixos-unstable";
  inputs.nixpkgs-nextjs-ollama-llm-ui.url = "github:malteneuss/nixpkgs/update-nextjs-ollama-llm-ui";
 ...
  outputs =
    inputs@{ self
     , nixpkgs-unstable
     , nixpkgs-nextjs-ollama-llm-ui
     , ...
    }: {
      nixosConfigurations.mynixos = nixpkgs-unstable.lib.nixosSystem {
        ...
        modules = [
           {
            config.services.nextjs-ollama-llm-ui.package = nixpkgs-nextjs-ollama-llm-ui.legacyPackages.${system}.pkgs.nextjs-ollama-llm-ui;
          }
        ];
    };
  };
}

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Already fixed with #347856


here we go again

here we go again...new software, new methods...who is the genius at MS that decides the old tools is no good any more and needs new instructions for the new stuff....you know what this will cause?  Searching for documentation for the right version...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 626ac155-c2df-20a5-a23f-14921c0c72ae
Version Independent ID: 63a9307c-d246-bd15-9a2b-178b8a49580b
Content: Deploy Office 2019 (for IT Pros)
Content Source: DeployOffice/office2019/deploy.md
Product: office-perpetual-itpro
GitHub Login: @DHB-MSFT
Microsoft Alias: danbrown

Don't get your hopes up - this bug report will most probably be deleted without further information.
C2R is here to stay without any alternative. What we crave for (a truly customizable installer like we were used to with "setup.exe /admin myconfig.msp") has been purposely ignored... at least that's all I can surmise from the lack of documentation and and transition information (2016 to 2019).
I'd truly appreciate a public statement ("no more customizable installer, live with it") instead of the "use ODT"... because ODT doesn't even remotely cover what you were able to do with the Office Customization Tool / OCT.

I tried to download the offline files for visio pro 2019, however when install, it gives me error
"Invalid product VisioPro2019Volume specified. Error configuring products!"

here is my XML file

Configuration
Add OfficeClientEdition="32"
Product ID="VisioPro2019Volume"
Language ID="zh-TW" /
ExcludeApp ID="OneDrive" /
/Product
/Add
Display Level="Full" AcceptEULA="TRUE" /
Updates Enabled="TRUE"  /
/Configuration
(Removed the arrow)

@YanWah2012 -- I used your xml file and was able to download, install, and open VIsio. When did you get the error message? I briefly saw a notification appear in the bottom right of my screen at the end of the install, but it disappeared before I could look at it more closely. And it was in zh-tw so couldn't immediately tell what it said at a glance.

I was able to download but not install Visio Pro 19, but it didn't throw an error or anything. Acted normally. Any ideas?

I'd truly appreciate a public statement ("no more customizable installer, live with it") instead of the "use ODT"... because ODT doesn't even remotely cover what you were able to do with the Office Customization Tool / OCT.

Although some of the methods used for customization differ in C2R, we have worked hard to ensure that the supported deployment scenarios in MSI and the OCT are still possible in C2R using the ODT.
The ODT natively supports customization of products to install, UI level, architecture, and upgrades, and licensing information.  We have also recently added the capability to customize thousands of Office application preferences at deployment time.  You can try this out today at https://config.office.com/
If there is a specific capability that you are looking for in the ODT that is not present or possible today, please do let us know so we can consider improvements in the future.

@YanWah2012 -- I used your xml file and was able to download, install, and open VIsio. When did you get the error message? I briefly saw a notification appear in the bottom right of my screen at the end of the install, but it disappeared before I could look at it more closely. And it was in zh-tw so couldn't immediately tell what it said at a glance.

issue resolved. it should the office CDN temp unavailable

@YanWah2012 -- glad to hear your issue was resolved.


Coverage badge

Adds a coverage badge. Since I was a little wasteful with the commits in this branch, I think "Squash and Merge" would be appropriate, if this PR is approved.

Wow, you gave this PR a lot of additional love 😊 ❤


support disabling triggers (never delete triggers that won't fire)

resolves issue #86

@bjustin-ibm this one for you to review and merge


Support begins with

What does this change?
Support begins_with function.
We can use begins_with like following if merged.
            let cond = QueryTestData1::key_condition(QueryTestData1::id())
                .eq("id0")
                .and(QueryTestData1::key_condition(QueryTestData1::name()).begins_with("j"));
            let res = client.query().key_condition(cond).run().await;

References

If you have links to other resources, please list them here. (e.g. issue url, related pull request url, documents)

Screenshots
If applicable, add screenshots to help explain your changes.
What can I check for bug fixes?
Please briefly describe how you can confirm the resolution of the bug.

ref #123


Python: Fix confusion about class attributes

Class attributes are NOT instance attributes. This example means instance attributes. My edit is as minimal as possible to fix that.

Screw that, this is a trivial change. If needed, I hereby declare it to be in the public domain.

No worries.  For what it's worth, the Attributes: section in class docstrings applies to any form of attributes so we don't want to restrict this to instance attributes here.

D'oh, you are right.


Expose Govee Lights as Switches?

What issue do you have? Please be as thorough and explicit as possible.
I was wondering if it was poossible to expose my Govee lights as switches/outlets in Homekit, rather than lights? I have them set to DIY scenes and would prefer they simply stay the way they are currently set, and be powered on/off from Homekit like a switch (rather than allowing Siri to change the color/brightness along with the other lights). Please advise.
Details of your setup.

Do you use Homebridge (with config-ui?) or HOOBS?
Homebridge

Which version of Homebridge/HOOBS do you have?
1.4.0

Which version of this plugin (homebridge-govee) do you have? Has the issue started since upgrading from a previous version?
4.28.0

I'm interested in this as well. I hate having to open the app to change it back to my favourite scene because HomeKit sets it to 100% with a specific colour. Really annoying

Is it not possible? Thanks.

Yes this definitely is possible to expose as a switch.
But it may be that the Eve app already offers what you are looking for.
When you create a scene or an automation in the Home app, with a light that supports colour, you are forced to choose a state (on/off) and if the state is ON then you must choose a brightness and a colour. When the scene or automation is run, homekit will change these three states (ON, BRIGHTNESS, COLOUR).
However, the Eve HomeKit app lets you create scenes and automations with just the items that you need. So in the Eve app it is possible to create scenes and automations that just control the state without changing the brightness and colour.
These Eve scenes and automations are still HomeKit scenes and automations so once made in the Eve app they will appear in the Home app and be controllable with Siri etc.
By making an Eve app scene/automation just controlling the state (ON/OFF) this will not change the brightness and the colour when the scene is called, so the device should stay in the same govee scene as it was before.

Hey bwp91,
I'm familiar with the Eve app and this is a fantastic solution for automations (wish the Home.app was this granular). However, what I'm trying to avoid is changing the color/brightness of Govee lights when speaking to Siri (i.e. "turn all lights red," or "dim the living room lights"), if that makes sense. So being able to expose a few strips as mere switches would be super helpful.

Closing this as a bit overwhelmed with issues.
Please update to the beta version of the plugin, and if you are still having issues, do reopen this ticket!
Thanks and apologies if closing prematurely.


[dv,sysrst_ctl] Add cross points to test plan

This PR adds the cross points for system reset control to the test plan, which are specified in this planning issue: https://github.com/lowRISC/opentitan/issues/17278

After some discussion with @crteja, I reorganized the cross points so that they make sense in the current test setup and the times we sample the current cover groups. I also added a few extra details on which registers and IO each cross should take into account.

@marnovandermaas , Thanks for the updates. Looks good to me.

I'm converting this to draft because adding these crosses might be optional as stated in: https://github.com/lowRISC/opentitan/issues/17278


error reading yaml file if extension is yml instead of yaml

Hello,
thanks for sharing sacred with us.
I was wondering if there is a strict policy checking on file types when adding configuration from a file.
Here's MWE of what I encountered as errror:
import sacred
expr = sacred.Experiment('test-experiment', interactive=True)
expr.add_config('params.yml')

Error:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/user/miniconda3/envs/experiments/lib/python3.7/site-packages/sacred/ingredient.py", line 195, in add_config
    kw_conf))
  File "/home/user/miniconda3/envs/experiments/lib/python3.7/site-packages/sacred/ingredient.py", line 218, in _create_config_dict
    return ConfigDict(load_config_file(abspath))
  File "/home/user/miniconda3/envs/experiments/lib/python3.7/site-packages/sacred/config/config_files.py", line 41, in load_config_file
    handler = get_handler(filename)
  File "/home/user/miniconda3/envs/experiments/lib/python3.7/site-packages/sacred/config/config_files.py", line 37, in get_handler
    return HANDLER_BY_EXT[extension]
KeyError: '.yml'

While I can very easily load and read any .yml file either using pyyaml or ruamel.yaml without any issues.
Cheers!

thanks @kirk86 for reporting this. That should be easy to fix. I will try to provide a PR soon.

@JarnoRFB Awesome! thank you.

@JarnoRFB I was quicker ;-)
@kirk86 Should be resolved by f400f34.


(Chore) Reduce error logs in the dapp

Description

adjust FV errors logging

About #3166
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist:

[x] PR title matches follow: (Feature|Bug|Chore) Task Name
[x] My code follows the style guidelines of this project
[ ] I have followed all the instructions described in the initial task (check Definitions of Done)
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] I have added reference to a related issue in the repository
[ ] I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
[ ] I have added screenshots related to my pull request (for frontend tasks)
[ ] I have pasted a gif showing the feature.
[x] @mentions of the person or team responsible for reviewing proposed changes

@omerzam Please, review and adjust if need

all GUN issues were kept logged as errors
all "human" issues are now logged as warning
there's a lot of wallet-related error logs you may need to review, as we weren't sure are they so critical or not

i'm not sure this is good
we need errors in order to identify something broken.
errors are logged into amplitude+mautic and allows to see "spike" an errors.
In order to turn an error into warning we need to be sure we dont need to track it

@sirpy we're logging as .warn the user-related errors (invalid input, validation, fv duplicate, fv liveness failed) mostly
There's also some cases where the error is ignored and we return false or null from fn. could you please please look them up and tell us which ones from them you would track and log as errors

@serdiukov-o-nordwhale
I agree with Hadar, we need to keep all sorts of errors, not just for the events also in case if we would want to trigger different actions in the future

@serdiukov-o-nordwhale
I agree with Hadar, we need to keep all sorts of errors, not just for the events also in case if we would want to trigger different actions in the future

@Esfir-E
Could we do not log user-related issues to Sentry ? Because we really don't need them in Sentry. I would like to see only unexpected issues here.
If you need some analytics - ok we will log them as before but to amplitude/GA only.
So, i suggest to log such issues (non-unexpected errors caused by user side) for analytic purposes only. Agreed ?

@serdiukov-o-nordwhale
I agree with Hadar, we need to keep all sorts of errors, not just for the events also in case if we would want to trigger different actions in the future

@Esfir-E we need input about which errors needs to be recorded on amplitude and which can be reduced to a warning status in which case they won't be recorded on amplitude, specifically FV related errors

@omerzam all issues of FV should be recorded to amplitude this is our most deliciated process.
and as i said i want to have an option in the future to trigger different content by third-party per different error

@omerzam all issues of FV should be recorded to amplitude this is our most deliciated process.
and as i said i want to have an option in the future to trigger different content by third-party per different error

@Esfir-E as i said, i'm ok with logging all FV errors to the Amplitude
But i would remove some of them from Sentry only. Could i remove all user-side issues (e.g. not match/failed liveness/dups found/failed to start session) ?


please consider disabling alerts & douncing dock icon on errors

My editor saves every time I switch file.  Is not ideal.
Love this tool though!

Yeah I'd love to change this. Any ideas how to stop Electron from firing alerts? I will take a poke through the docs today.

Ok, turns out it was twofold:

on uncaught errors, it was showing a dialog. Now it should print the error stack to console
tap-dev-tool was also causing the alert on syntax errors; now it should print errors into terminal/DevTools during development; and if babelify is used the errors will be nicely formatted

Pushed to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

This could still be improved so I will leave it open.

quitting with an exit code on uncaught errors
the changes to tap-dev-tool mean that the build succeeds even if there was a syntax error; this is not good for production builds... but maybe not such a big deal since tap-dev-tool would probably only be used during development?

@mattdesl ok so the behaviour now is to quit electron and log error to console? while this appears less broken, it's still a pain during development since it still requires intervention (restarting the tests) to get things working again.
I guess there's two use-cases here: autonomous tests and interactive tests.
For autonomous tests you don't need the autoreloading features at all, though the quit on syntax error is perfect behaviour for this use-case.
For interactive tests automatic reloading is great, but don't want the test environment to die until you explicitly tell it to.
Interactive tests is where smokestack currently falls short, which is why I've been using hihat.

Ok so here's the code in question:
# Don't quit on fatal error.
process.on 'uncaughtException', (error) ->
  # Do nothing if the user has a custom uncaught exception handler.
  if process.listeners('uncaughtException').length > 1
    return

  # Show error in GUI.
  stack = error.stack ? "#{error.name}: #{error.message}"
  message = "Uncaught Exception:\n#{stack}"
  require('dialog').showErrorBox 'A JavaScript error occured in the browser process', message

https://github.com/atom/electron/blob/02bdace366f38271b5c186412f42810ecb06e99e/atom/browser/lib/init.coffee#L33-L41
I'm thinking the hihat exception handler should basically do the same thing except not using this godawful    alert box:require('dialog').showErrorBox

@mattdesl I did a little proof of concept that displays build errors in the dev console: https://github.com/Jam3/hihat/compare/master...timoxley:log-errors
It should probably print to page instead of to dev console. Maybe.
Needs work, doesn't refresh when going from good build to bad build because the uncaught exception handler fires before the .on('update') which is being using to clear the existing error.

:+1:
So far my use case for hihat has also been interactive. The syntax errors should not stop the build, and with the 1.0.0 changes they are printing to dev tools for me:

(babelify does some fancy syntax error parsing)
Just curious what kind of build errors you are getting that are leading to uncaught exceptions? I'll try your PR this weekend.
I wonder if a flag like --once or --single could enable the "autonomous" mode? Not so much just for testing (smokestack is already better at that), but more aimed at tooling like generating hundreds of WebGL thumbnails offline (using Electron's file API), or simple video/audio processing tools that don't need ffmpeg. Though at that point it might just be worth splitting it into another module... I'll have to tinker.

The syntax errors should not stop the development cycle, and with the 1.0.0 changes they are printing to dev tools for me, with reloads still working.

This is exactly what I'd like to see. :D
@mattdesl this is what happens for me using<EMAIL_ADDRESS>
hihat goes away, along with electron.
My build errors are also coming out of babelify. It's interesting that it would require a different type of error handling.
 Seemed like maybe the transform was throwing asynchronously, thus only catchable by the uncaughtError handler, but that doesn't seem right. Tried both<EMAIL_ADDRESS>and<EMAIL_ADDRESS>same behaviour in both, so it's not just a faulty transform.

@mattdesl how are you invoking hihat?

I'm testing using the same command and a newly installed hihat/tap-dev-tool and it doesn't seem to crash:
hihat index.js -t babelify -t brfs -p tap-dev-tool
Are you using<EMAIL_ADDRESS>I've added better error handling there. Does it crash without -p tap-dev-tool?

It's interesting that it would require a different type of error handling.

Yeah, right now tap-dev-tool is using the same logic as errorify to pretty-print errors in console. It's kind of weird. :confused:

I've made a bunch of changes to things in 2.0, and pulled in some of the stuff you had in your fork.
You can use --quit to exit on errors, otherwise it tries to stay alive and log problems in the DevTools console.
Let me know if you see bugs or any problems, otherwise going to close this.


[QUERY] Monitor Exporter: Trace format inquiry

Library name and version
Azure.Monitor.OpenTelemetry.Exporter
Query/Question
I was wondering why this library doesn't send the traces to application insight with the format of the opentelementry properties (TraceId and SpanId) and does it with operationId. SpanId and TraceId are entered as custom properties in the application log traces, but HTTP dependencies do not include them.
Any help will be very welcome.
Environment
OD: Win10
NetCore7
running in localhost
VS2022 17.5.4
package version :
Azure.Monitor.OpenTelemetry.Exporter" Version="1.0.0-beta.12"
"OpenTelemetry.Instrumentation.Http" Version="1.5.0-beta.1" />

Hi @navba-MSFT, thanks for your quick response.
The logs of my application are already being included with TraceId and SpanId in the custom properties, but in the traces of the external HTTP dependencies they are not being included. When I see the HTTP dependency trace with the Console Exporter I see the TraceId and SpanId properties of the activities of the HTTP calls, but in Application insight they do not appear.
Attached file of the console output and AI output.

Any help will be great
Thanks

@makinsc Thanks for getting back. While I looked at our docs, I could see this.

OpenCensus Python enables you to correlate logs by adding a trace ID, a span ID, and a sampling flag to log records. You add these attributes by installing OpenCensus logging integration. The following attributes are added to Python LogRecord objects: traceId, spanId, and traceSampled (applicable only for loggers that are created after the integration).

Refer: https://learn.microsoft.com/en-us/azure/azure-monitor/app/distributed-tracing-telemetry-correlation#log-correlation

@makinsc In Application Insights, traceId is exported as Operation Id and spanId as Id. This is as per Application Insights schema. You should be able to see them on Dependency record.

@makinsc Hope this answers.
Thanks @vishweshbankwar .


Material Select remaining caret icon on destroy

When using the $('select').material_select('destroy') command, the select correctly disapear, but letting the caret icon in parent DOM element.
Here is a fiddle for example :
https://jsfiddle.net/4nbq2ymv/
Thx,

In addition:
Updating adds extra caret icons to the select
http://codepen.io/anon/pen/XbzMva

Can confirm I am experiencing the same issue.

:+1:  I am getting the same issue:
http://pastebin.com/zyS0yjTx

having the same issue

Fixed in cbcf4c8

@acburst is it not yet fixed in latest release 0.97.0.

if you click on https://github.com/Dogfalo/materialize/commit/cbcf4c8f6c229f42dba1dd3ccde1788d7f96ff80 you can see at the top left "master" which means that it is commited, but not released. if you see a number there in the future, e.g. 0.97.1, it's released

When will it be released?

I'm experiencing the same problem and waiting for the release.

I too experienced the same issue , waiting for the release ...

You can add $select.parent().find('input, i, .caret').remove(); on re-initialization to fix this issue until the next release.

I just tried a fresh checkout of the master and the problem still seems to be there. No change of the extra caret behaviour.
I'm using meteor, if that matters.

Has been fixed in v0.97.1 @serkandurusoy.


Select datastore by its association with the provider

Datastores on the same setup may have the same name.
However, there is an assumption that datastores names on the same
provider are unique. The selection of datastore by its name should be
narrow to the provider on which the vm is provisioned.
https://bugzilla.redhat.com/show_bug.cgi?id=1427498

@gmcculloug please review.

 Bug 1427498 - VM provision via restapi fail, if the chosen data store name exist more than once in CFME

@gmcculloug added tests.

@agrare @gmcculloug I think this incorporates all of the comments.
verified the following scenarios:

add disk via vm reconfigure
add disk via an automation script (restapi)
vm provision via UI
vm provision via restapi where disks were specified as part of the request.

Fine backport details:
$ git log -1
commit 44b7dfe9631e4a72a3234da5ce858e4266ab72bb
Author: Greg McCullough<EMAIL_ADDRESS>Date:   Thu Jun 8 10:51:54 2017 -0400

    Merge pull request #15245 from masayag/find_datastore_within_provider

    Select datastore by its association with the provider
    (cherry picked from commit ec5d10654285cab2f2e5461d098330cee0333048)

    https://bugzilla.redhat.com/show_bug.cgi?id=1462774


Anchors and rpn module for varied image sizes (width!=height)

Hi FurkanOM, Thanks for the great work!!
This repository works only for square images. What if i want to keep the aspect ratio of my images and train, like 1280x720. Then the anchor generation and anchor target generations have to be modified. Any thoughts on implementing this soon?

Hi,
In fact, the anchor generation processes were working the way you specified at first, but I changed it later.
You can find the working version that way by examining the previous commits but I don't plan to implement that way.
Since the bounding boxes are in a relative format, the size or aspect ratios of the images do not pose any problem.

Hi,
Thanks for the response. Can you point me the exact commit in which it is working that way. I can modify my code accordingly. Thanks.

Hi, sorry but i couldn't. I'm dealing with other things right now. You need to find that by yourself.


Access to /api/<camera_name>/latest.jpg via hass api

Is your feature request related to a problem? Please describe.
When someone rings the doorbell I would like to include a snapshot from that point in time, regardless of any event, to include in an android notification.
Describe the solution you'd like
A secure means to access the /api/<camera_name>/latest.jpg api.
Or perhaps, keep it unsecure, but add a mechanism to toggle it on/off via mqtt/hass switch so it could be used in an automation. enable latest api -> send notification -> disable latest api
Ideally there would also be a configurable auto disable timeout (just in case!)
Describe alternatives you've considered
I got the easy bit working by copying the NotificationsProxyView class. I was going to get it ready for a PR, until I noticed #153 which leaves this wide open without even the obscurity offered by an event id, nor would the expiration solution work.
I'm happy to have a go at the toggle functionality if this seems like a sensible approach.
Additional context

What are you using for notifications?

Just notify.mobile_app_

If you just want a live snapshot, not tied to an event, why not just use the native Home Assistant snapshot service? [Nothing Frigate specific about this at all]
e.g. something like:
- alias: 'Alert when doorbell pressed'
  trigger:
    platform: event
    event_type: zha_event
    event_data:
      command: 'button_single'
      device_ieee: '[device_ieee_goes_here]'
  action:
    # Snapshot into the media folder for (authenticated) notifications.
    - service: camera.snapshot
      target:
        entity_id: camera.front_door
      data:
        filename: '/path/to/an/accessible/folder/front_door.jpg'
    - service: notify.mobile_app_device_group
      # Below is for Android
      data:
        title: 'Doorbell!'
        message: ""
        data:
          image: '/path/to/an/accessible/folder/front_door.jpg'
          ttl: 0
          priority: 'high'
          clickAction: 'https://frigate.ondu.org/cameras/front_door'

See related camera.snapshot documentation.

This is what I was going to suggest. You can save the images in the www folder for easy public access.

That works perfectly, thanks! I'm new to home assistant and hadn't spotted that service.


Admin - customize footer, logo, and about pages

Provide admin tools to customize the footer, logo, and about page. Include an option to hide any of these instead.

As 2.5 is released, is there now any means to customise the layout (title, footer, logo) etc?
If not, could you point us in the directions of what files to manually edit?
Thanks.


Question: usage of Azure OpenAI backend

From the examples/docs, it's not quite clear how to configure the code for use with a model deployment in Azure OpenAI.
e.g. https://github.com/run-llama/LlamaIndexTS/blob/main/examples/vectorIndex.ts
On running, it tries to connect to the default OpenAI configuration. In the codebase, I see a class implementing Azure OpenAI backend, but in the example code the use of backend seems to be implicit.
I have set the Azure endpoint and key, which seem to get recognized, but get an Azure error regarding missing name of the deployment.
In the Python examples, there are more specific constructs:

llm = AzureOpenAI(
    model="gpt-35-turbo-16k",
    deployment_name="my-custom-llm",
    api_key=api_key,
    azure_endpoint=azure_endpoint,
    api_version=api_version,
)

OK I've got my head around it. The logic is here to wrap embed configuration in the GPT configuration.
The following example works for me (lllamaindexTS 1.0.0 and node 21.6.0
import fs from "node:fs/promises";
import { Document, VectorStoreIndex, serviceContextFromDefaults, OpenAI, OpenAIEmbedding } from "llamaindex";

async function main() {
  // Set Azure OpenAI environment variables to trigger Azure OpenAI logic in llamaindex!
  // in the environment, you need only endpoint and API key
  // AZURE_OPENAI_ENDPOINT
  // AZURE_OPENAI_API_KEY
  // your custom deployment names can be sourced from elsewhere

  // Load essay from abramov.txt in Node
  const path = "node_modules/llamaindex/examples/abramov.txt";

  const essay = await fs.readFile(path, "utf-8");

  const embedding = new OpenAIEmbedding( {azure: {deploymentName : "<YOUR_EMBEDDING_DEPLOYMENT_NAME>"}})
  const llm = new OpenAI( {azure: {deploymentName: "<YOUR_GPT_DEPLOYMENT_NAME>"}})

  // Create Document object with essay
  const document = new Document({ text: essay, id_: path });

  // Split text and create embeddings. Store them in a VectorStoreIndex
  const serviceContext = serviceContextFromDefaults({
    llm: llm,
    embedModel: embedding
  });

  const index = await VectorStoreIndex.fromDocuments([document], {
    serviceContext
  });

  // Query the index
  const queryEngine = index.asQueryEngine();
  const response = await queryEngine.query({
  query: "What did the author do in college?",
  });

  // Output response
  console.log(response.toString());
}

main().catch(console.error)

I need openai usage , but still not getting from above code

It's available in https://github.com/run-llama/LlamaIndexTS/tree/llm_usage branch . When this will be available inhttps://www.npmjs.com/package/llamaindex and in which version?


Move View.bind modifier to _SwiftUINavigationState

It's a more general helper that is immediately useful in most TCA apps, which export this internal module automatically.

@mbrandonw We could also make a _SwiftUINavigtionBind module if we don't want non-*State logic in the module.


Refactor stringify module

I'm not entirely happy with this, but this PR is blocking other changes.


2.016 broken, and 2.016 beta doesn't even work

error happens both on the beta and the non- beta(CookieMonster/CookieMonster.js and CookieMonster/CookieMonsterBeta.js)

PS: i am using book mark but have tried tampermonkey and console, neither work, although, if i comment out the part that gives an error, it actually loads, but payback time is broken and only working thing is golden cookies. that works.

It be nice if you took at look at Issue #223 and Issue #224 first...

i checked them, but it looked like that was before the 2.016 release. sorry if i messed up though.

Issue #224 says 2.016 in the title.  Oh well, it's fine.  I know everyone really wants this to be fixed, but please be patient.

Tried your latest commit, getting
Uncaught TypeError: Cannot read property 'toString' of undefined at CookieMonster.js:2911

on
eval('CM.Sim.getGrandmaSynergyUpgradeMultiplier = ' + Game.getGrandmaSynergyUpgradeMultiplier.toString().split('Game.Objects[\'Grandma\']').join('CM.Sim.Objects[\'Grandma\']'));

Thanks!  I should note the latest commit only says I did a version change.  I've not finished fixing yet.

Yeah no worries, just wanted to post about it :)

Partially fixed in Version 2.016.1, now to do the beta.

Beta is also fixed to Version 2.016.1


Support allocators

do people want allocators just for image data or also all the various things, like metadata?
Is allocator a global? If no, images need to retain their allocation method. If that is so, we need a user pointer to give to the allocator.
The problem of a global is that then the library needs initialization, which it currently doesn't.
At this point it would be handy to store some thing like that as metadata (for example: initial allocation method).

Discussion here =><EMAIL_ADDRESS>

Interesting design here: https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkAllocationCallbacks.html


output the CPU info of nodes to dedicated files

The cpu info will be output into dedicated files such as report-data/20220111/gce/pd-ssd/logs/c2-standard-8/jane-cldrprt23-c2-standard-8-1736669770_cpu_info.txt

TFTR!


Handle undefined PublicKeyCredential in browserSupportsWebAuthnAutofill helper

Describe the issue
Currently, calling the browserSupportsWebAuthnAutofill helper on a browser without webauthn support will cause an error since it is trying to evaluate isConditionalMediationAvailable of undefined.
The helper should check whether PublicKeyCredential is defined first and resolve false if it isn't, similar to the platformAuthenticatorIsAvailable helper.

Code Samples + WebAuthn Options and Responses
import {
  browserSupportsWebAuthn,
  browserSupportsWebAuthnAutofill,
  platformAuthenticatorIsAvailable,
} from "@simplewebauthn/browser";

export const getPasskeySupportInfo = async () => {
  const hasWebAuthnSupport = browserSupportsWebAuthn();
  const hasWebAuthnAutofillSupport = await browserSupportsWebAuthnAutofill();
  const hasPlatformAuthenticator = await platformAuthenticatorIsAvailable();

  return {
    hasWebAuthnSupport,
    hasWebAuthnAutofillSupport,
    hasPlatformAuthenticator,
  };
};

Error message:
iOS: undefined is not an object (evaluating 'e.isConditionalMediationAvailable')
Android: Cannot read properties of undefined (reading 'isConditionalMediationAvailable')

SimpleWebAuthn Libraries

$ npm list --depth=0 | grep @simplewebauthn
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS># ...

@clarafitzgerald This fix is now available in the recently-published<EMAIL_ADDRESS>✌


userpoints_badges

The userpoints_contrib module contains the userpoints_badges submodule. However, it is now it's own module-
https://www.drupal.org/project/userpoints_badges
and will soon be removed from userpoints_contrib-
https://www.drupal.org/node/2619420
Is there a way to get userpoints_badges removed from userpoints_contrib's "Replaces" section, so that it will install from the correct repo?

Hi, the replacenent will be removed in the next dev release automatically.
Am 19.11.2015 21:25 schrieb "albertvolkman"<EMAIL_ADDRESS>
The userpoints_contrib module contains the userpoints_badges submodule.
However, it is now it's own module-
https://www.drupal.org/project/userpoints_badges
and will soon be removed from userpoints_contrib-
https://www.drupal.org/node/2619420
Is there a way to get userpoints_badges removed from userpoints_contrib's
"Replaces" section, so that it will install from the correct repo?
—
Reply to this email directly or view it on GitHub
https://github.com/drupal-composer/drupal-packagist/issues/41.

Looks ok, right?
https://packagist.drupal-composer.org/packages/drupal/userpoints_contrib
https://packagist.drupal-composer.org/packages/drupal/userpoints_badges

Got it. Looks correct, thank you :)


Write API documentation for all of the Freer & Cofreer symbols

Types, functions, etc.

I'll take this!

@patrickt: 🙇🏻 thank you! I’ve added you to the repo as a collaborator.


update to last spring boot version

update spring boot version 1.3.5.RELEASE to 1.5.6.RELEASE + add profile sample

There is a lot going on here and I'd rather go with a documentation update for enabling a profile. There is really nothing specific here. The only thing you need to know is the property name to enable and how profiles work with Spring Boot.
The latter is documented in Spring Boot itself and I'd rather not duplicate this here. Thanks for the PR anyway!


Show slow down modal

If duration > 1, show hint if used less than 20% of the time.
Explain why taking time is useful, primary button is to continue working.
Mini info about remaining time.

yes, this task is next up

probably start with modal itself

showing it wouldn't be to hard to decide (time is already tracked)

small modal, no option to skip - because you can always show a worked example.


Use palette from the default colorscheme

Thank you for the awesome plugin. I would like to suggest to use user's colorscheme for colors by default. Of course I can overwrite it in configuration, but just to make default colors more universal.

At least for the initial version, that feature had omitted for simplicity. But I think it's worth to consider.

We can start it from POC code.
https://github.com/lambdalisue/glyph-palette.vim/blob/64469952e6fc67073900f8adf4ff56acac05e9af/autoload/devicons_palette.vim#L57-L66

@Shatur95 Please try #12


Pistache work on mac?

Very nice project, but i was unable to install and use it on a mac (osx 10.11.x).

Hello and thanks :)
Unfortunately, it does not support osx for now as it's using the epoll() system call underneath for I/O notification. To make it work on osx, I would have to use kqueue instead of epoll. If you're interested in contributing, I could guide through the process of updating the code to support kqueue instead of epoll :)

I am interested in working on this and contributing to the project. I have taken a look at the os.cc file and found where the epoll is used. Could you give more help or pointers on this?

Hello,
Sorry for the late response, I've been quite busy these last days.
Anyway, thanks for your interest in the project. Like you said, I implemented a tiny C++ wrapper around epoll() in the os.cc source file. Now, to make it work on OSX, it would have to use kqueue() or select() instead of epoll(). That being said, I did not bother making an abstraction around the polling system yet.
That being said, you could start creating an "interface" around the polling system (currently epoll). For example, such interface could support multiple operations:

Adding an FD to the interest list
Modifying / rearming an FD
Removing an FD (no-op with epoll() since close() automatically removes the fd from the interest list)
Polling the list from a set of ready fds.

Then, the polling system would have multiple implementations of this interface. We would then have:

Polling::Epoll
Polling::Select
Polling::Kqueue
...

The implementation would look something along those lines:
namespace Polling {

// Interface
class Poller {
public:
    virtual ~Poller() = default;

    // ...
};

// Implementation
class Epoll : public Poller {
};

class Kqueue : public Poller {
};

class Select : public Poller {
};

Then, at runtime, depending on the OS and maybe a configuration parameter (we could start with an environment variable), it would automatically detect and choose either of these polling systems.
Makes sense ?

It seems that it's not as simple as just wrapping kqueue() for os.h/c, as http, transport and probably a few others use other POSIX extensions. The transport layer is probably going to be the most intensive.

@oktal what is CpuSet::toPosix used for? It's conflicting with Mac build, but I cannot find any usage of this method inside pistache code. Can it be removed?

Any updates on this front?
@Marqin I noticed that the toPosix() function was never being called. I was able to remove it and compile with no complaints. Perhaps it's vestigial?
@oktal It looks like @Thomspoon is correct - the epoll specifics expand outside of the Polling namespace. I am happy to work on creating new implementations via select or kqueue, but epoll spills into mailbox.h, etc.
This is likely due to how the Epoll class handles new FDs: it simply accepts externally created FDs. Instead, it should create them internally or with a helper so that it can be abstracted. (ie - a virtual function called create or the like). @oktal would you be able to help kick this off? Happy to carry the torch on if we have some assistance with corralling functionality pieces.
Thanks!

has been there any updates to this issue? We would love to use this api, but really need osx and linux support.

Any changes to this? Would like to try it on OS X.

Not yet I'm afraid, if anything we've moved in the other direction so far. PRs are welcome.

Very nice project, but i was unable to install and use it on a mac (osx 10.11.x).

I ve the same issue, unfortunately

Working on it...

I would love to see macOS support too.

Is there a possible way to quickly bu

Working on it... 😎
@hyperxor I assume the make test call has 24/24 succeeded tests on Linux. Am I right?

Thanks a lot! Clone your branch and now I can install it on OSX! Switched to m1 macbook today, could not find any workaround cause no virtual machines or docker are supported yet.

Working on it... 😎
@hyperxor I assume the make test call has 24/24 succeeded tests on Linux. Am I right?

Working on it... 😎
@hyperxor I assume the make test call has 24/24 succeeded tests on Linux. Am I right?

Thanks a lot! Clone your branch and now I can install it on OSX! Switched to m1 macbook today, could not find any workaround for Linux as no virtual machines or docker are supported yet.

Working on it... 😎
@hyperxor I assume the make test call has 24/24 succeeded tests on Linux. Am I right?

Thanks a lot! Clone your branch and now I can install it on OSX! Switched to m1 macbook today, could not find any workaround for Linux as no virtual machines or docker are supported yet.

Please do not use my develop branch. I just managed it to compile, but all the timer stuff etc. wasn't working at all due to lack of support from the community.
Feel free to fix the source code in order to pass the test coverage. You may get it to work but I doubt someone ever will, unless we alter the complete logical structure.


bazel 0.5.1 build error on macos

On the same mac, pilot/ and mixer/ build fine but not istio/ (probably I'm missing some simple step)
ldemailly-macbookpro:istio ldemailly$ bazel build ...
INFO: Found 16 targets...
ERROR: /private/var/tmp/_bazel_ldemailly/b3234b5df793e8ff590992c9cc08b3a3/external/com_github_golang_glog/BUILD:5:1: null failed: Process exited with status 1 [sandboxed].
github.com/golang/glog/external/com_github_golang_glog/glog.go:74: can't find import: "bufio"
Use --strategy=GoCompile=standalone to disable sandboxing for the failing actions.
INFO: Elapsed time: 1.994s, Critical Path: 1.22s
ldemailly-macbookpro:istio ldemailly$ bazel build --strategy=GoCompile=standalone ...
INFO: Found 16 targets...
ERROR: /private/var/tmp/_bazel_ldemailly/b3234b5df793e8ff590992c9cc08b3a3/external/org_golang_google_grpc/keepalive/BUILD:3:1: null failed: go_default_library.a.GoCompileFile.params failed: error executing command  ... (remaining 1 argument(s) skipped): com.google.devtools.build.lib.shell.BadExitStatusException: Process exited with status 1.
google.golang.org/grpc/external/org_golang_google_grpc/keepalive/keepalive.go:38: can't find import: "time"
INFO: Elapsed time: 0.444s, Critical Path: 0.10s

ldemailly-macbookpro:istio ldemailly$ bazel version
Build label: 0.5.1-homebrew
Build target: bazel-out/darwin_x86_64-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Tue Jun 6 12:34:07 2017<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

it works with bazel 0.4.5 so there must be some incompatible changes (or bug) in 0.5.1 that istio/ build triggers (but not pilot nor mixer somehow)

I'm able to build the repo with Bazel 0.5.3. How about you?

same with 5.0.3 despite #508:
ERROR: /private/var/tmp/_bazel_ldemailly/0424bd2f1832ecd0e75f86f4852c06d9/external/com_github_golang_glog/BUILD:5:1: GoCompile external/com_github_golang_glog/go_default_library.a failed (Exit 1).
github.com/golang/glog/external/com_github_golang_glog/glog.go:74: can't find import: "bufio"

I no longer experience this. Is this still happen for you even after bazel clean --expunge?

it's quite strange, it fails the first time but if you try again it goes through !
ldemailly-macbookpro:istio ldemailly$ bazel version
Build label: 0.5.3-homebrew
Build target: bazel-out/darwin_x86_64-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Thu Jul 27 19:30:37 2017<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>
ldemailly-macbookpro:istio ldemailly$ bazel clean --expunge
INFO: Starting clean (this may take a while). Consider using --expunge_async if the clean takes more than several minutes.
ldemailly-macbookpro:istio ldemailly$ bazel build //...
...............
WARNING: /private/var/tmp/_bazel_ldemailly/0424bd2f1832ecd0e75f86f4852c06d9/external/io_bazel_rules_go/go/private/go_repository.bzl:134:3: com_github_golang_protobuf: new_go_repository is deprecated. Please migrate to go_repository soon.
WARNING: /private/var/tmp/_bazel_ldemailly/0424bd2f1832ecd0e75f86f4852c06d9/external/io_bazel_rules_go/go/private/go_repository.bzl:134:3: com_github_golang_glog: new_go_repository is deprecated. Please migrate to go_repository soon.
WARNING: /private/var/tmp/_bazel_ldemailly/0424bd2f1832ecd0e75f86f4852c06d9/external/io_bazel_rules_go/go/private/go_repository.bzl:134:3: org_golang_google_grpc: new_go_repository is deprecated. Please migrate to go_repository soon.
WARNING: /private/var/tmp/_bazel_ldemailly/0424bd2f1832ecd0e75f86f4852c06d9/external/io_bazel_rules_go/go/private/go_repository.bzl:134:3: org_golang_x_net: new_go_repository is deprecated. Please migrate to go_repository soon.
WARNING: /private/var/tmp/_bazel_ldemailly/0424bd2f1832ecd0e75f86f4852c06d9/external/io_bazel_rules_go/go/private/go_repository.bzl:134:3: com_github_gogo_protobuf: new_go_repository is deprecated. Please migrate to go_repository soon.
WARNING: /private/var/tmp/_bazel_ldemailly/0424bd2f1832ecd0e75f86f4852c06d9/external/bazel_tools/tools/build_defs/docker/docker.bzl:19:1: The docker_{build,bundle} rules bundled with Bazel are deprecated in favor of:
https://github.com/bazelbuild/rules_docker. Please change BUILD loads to reference: @io_bazel_rules_docker//docker:docker.bzl and add the following to your WORKSPACE:
git_repository(
    name = "io_bazel_rules_docker",
    remote = "https://github.com/bazelbuild/rules_docker.git",
    commit = "...",
)
load("@io_bazel_rules_docker//docker:docker.bzl", "docker_repositories")
docker_repositories().
WARNING: /private/var/tmp/_bazel_ldemailly/0424bd2f1832ecd0e75f86f4852c06d9/external/bazel_tools/tools/build_defs/pkg/pkg.bzl:196:9: pkg_tar: renaming non-dict `files` attribute to `srcs`.
ERROR: in target '//external:cc_toolchain': no such package '@local_config_cc//': BUILD file not found on package path.
INFO: Elapsed time: 12.157s

will close as it (sort of) works


[vm] Inlining heuristics should take into account instruction sizes

Not all instructions at the inlining phase result in the same number of bytes of code.
Inlining heuristics should do a better job of predicting code size.
In particlar,

[ ] Redefinitions reference existing values, so potentially generate no code.
[x] GenericCheckBounds annotated with pragma('vm:unsafe:no-bounds-checks') generates no code.
[ ] The length() input to GenericCheckBounds annotated with pragma('vm:unsafe:no-bounds-checks') often becomes dead after the check is removed.

//cc @alexmarkov


Suggestion to extend the examples in DateTime lib concerning epoch format

I'd suggest to keep the sentence in the Epoch time abstract:
"Notice that epoch time itself is independent on timezones and thus same around the world at a certain time. What local time a certain epoch time matches obviously then depends on the timezone."
Then append
"See also Python datetime  library."
And finally show these examples:

Source that can be copied for testing:
** Settings ***
Library    DateTime

*** Test Cases ***
Epoch time in RF refers to local time
    ${date_TS}    Get Current Date    time_zone=local    result_format=timestamp    exclude_millis=True
    ${dateEp1}    Convert Date    ${date_TS}    epoch    exclude_millis=True
    ${dateEp2}    Get Current Date    time_zone=UTC    increment=+ 0 hours    result_format=epoch        exclude_millis=True    # UTC is ignored
    Should Be Equal As Integers    ${dateEp1}    ${dateEp2}    # Always True, wherever on the world the test case is started

    ${dateEp3}    Get Current Date    time_zone=UTC    increment=+ 1 hours    result_format=epoch        exclude_millis=True    # UTC is ignored
    ${dateEp2}    Evaluate    ${dateEp2} + 3600
    Should Be Equal As Integers    ${dateEp2}    ${dateEp3}    # Always True, wherever on the world the test case is started

I agree documentation related to epoch time can be enhanced. I don't think adding a link to the discussion about aware vs. naïve datetime objects really help in this context, though, and believe that the proposed example is somewhat complicated as well. I've done some other enhancements and will commit them shortly. Hopefully you @UliSei can take a look at them and comment if there's something that can still be enhanced.


Wrong demo source reference link

The source link in paging demo 'Scrolling no virtual' is wrong. When we  click on to the 'Source', it redirect us on 'https://github.com/swimlane/ngx-datatable/blob/master/src/app/paging/paging-server.component.ts', which is not right. It should redirect us on 'https://github.com/swimlane/ngx-datatable/blob/704d9261eb72e8d439d8a63a4f6134e6878b6966/src/app/paging/paging-scrolling-novirtualization.component.ts'.
Please confirm

TY... will be fixed in next release.


Make tqdm optional

Codecov Report
Patch coverage is 100.00% of modified lines.

Files Changed
Coverage

src/gravitorch/loops/evaluation/accelerate.py
100.00%

src/gravitorch/loops/evaluation/vanilla.py
100.00%

src/gravitorch/loops/training/accelerate.py
100.00%

src/gravitorch/loops/training/vanilla.py
100.00%

:loudspeaker: Thoughts on this report? Let us know!.


Added example for an escaped string parser

Added a comprehensive example for how to parse a more complex escaped string. This parser supports regular escape sequences (\n, \r, \t) as well as rust-style escaped code points (\u{1F602}) and escaped whitespace (\     ). Thoroughly commented.

Coverage increased (+0.5%) to 86.786% when pulling eeda69c12c4625dd0eb869e03d1ec1fd8e5aedf1 on Lucretiel:string-example into 851706460a9311f7bbae8e9b7ee497c7188df0a3 on Geal:master.

wow that's an awesome example, thanks!


Memory leak ?

Based on the json example.
Expected Behavior
When the API is being stressed, the memory usage should be relevant compared to the load and then come to a lower level when there isn't any requests.
Actual Behavior
When the API is being stressed, the memory usage goes up to handle the incoming requests but doesn't come to a lower level.
Steps to Reproduce the Problem

Use the json example
Use a load testing tool like pewpew with the command pewpew benchmark http://my-url --rps 1000 -d 30

Specifications

Version: 1.2.28
Platform: GKE
Subsystem: distroless/cc

Note: the memory leak seems to be a redundant pattern with other tools like warp and actix web, probably related to tokio or serde_json but I'm not sure. The workaround would be to restart the pod and it will flush the memory, but this is not convenient and goes against Rust's principle of handling the memory usage.
A screenshot of the memory after a heavy load (120k requests after 2 minutes), the initial memory usage was 6MB.

I'll also leave here a very similar ticket that I've created for actix-web last year that got a lot of discussions about the origin of the "memory leaks": https://github.com/actix/actix-web/issues/1780 where the answer was that there was a cache that would prevent reallocating multiple time a request, and that there's no ttl so it would live until the server is shutdown.

Maybe take a look at this, I just ran some tests and found no obvious memory leaks.
https://github.com/hyperium/hyper/issues/1790

After reading it it seems that one of the answers seems relevant:

I'm assuming this indicates that this memory is actually freed, but the operating system doesn't recognize that?

I'll close as this doesn't seems to help that much, but perhaps take into account that restarting the server will clear the memory usage.


PIC Configuration

Hello i am trying to configure the PIC to handle the external interrupt in the SweRV Core. However i am able to configure the PIC by the help of documentation provided in the doc folder but i am facing an issue. I have configure the source 2 for the external interrupt when the interrupt is asserted in the core the core is jumping to the trap vector code successfully but the claim id is not getting save in the MEIHAP CSR due to which my code is not jumping at the correct ISR it is jumping at the base address of the interrupt vector table.

Thanks, I'll examine this. And you don't have RV_FAST_INTERRUPT_REDIRECT set in your common_defnes.vh build configuration ?
Also, how have you verified that the claimid is correct? Looking at waveforms?

How did you check the claimid is correct?

To diagnose this any further, I would either need to recreate the case, or look at your waveforms. Or, if you know verilog, you can follow the RTL and see if you can diagnose further yourself. The logic itself is trivially simple
assign wr_meihap_r = wr_meicpct_r;
rvdffe #(8)  meihap_ff (.*, .en(wr_meihap_r), .din(pic_claimid[7:0]), .dout(meihap[9:2]));
 assign dec_tlu_meihap[31:2] = {meivt[31:10], meihap[9:2]};
The code in question is https://github.com/chipsalliance/Cores-SweRV-EL2/blob/7045b803cab825bc3bb3dbca0cb019e55098acc4/design/dec/el2_dec_tlu_ctl.sv#L1647 and https://github.com/chipsalliance/Cores-SweRV-EL2/blob/7045b803cab825bc3bb3dbca0cb019e55098acc4/design/dec/el2_dec_tlu_ctl.sv#L1685


Add targets for KLLVM bindings

LGTM; will leave off merging so that @RaoulSchaffranek can take a look at it for context

@tothtamas28 any updates on this?


Automated Package Upgrade

:tada: This PR is included in version 21.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update to support IDEA 241.*

Adds support for IDEA 241
Bumps Fabric mod dependencies to latest versions for 1.20.4
Bumps Gradle to 8.8

Fixes #17

Could you please provide me with the compiled mod in *.jar format and the idea plugin in *.zip format for releasing?


Backport updates from dav1d 1.3.0

Remaining:

https://code.videolan.org/videolan/dav1d/-/commit/90a45d89de3a42058943efbab5fd9d35ae933dc7
https://code.videolan.org/videolan/dav1d/-/commit/d437510e9d4061a32845ece547b28cadd716900d
https://code.videolan.org/videolan/dav1d/-/commit/97becd73726c3d4c4bb8793d2215f846da8795af


Portals - changelog

Adds info on the changes made to the changelog.

i think this is good enough for the changelog.

Changes made, ready for another round.

:+1:


BUILD FAILURE

Whenever I execute the mvn clean package command when building the Echo client and server I get this error, please someone should help me out (Mind you I'm new to Network Programming) Thanks:
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Chapter 2. Your First Netty Application - Echo App                 [pom]
[INFO] Chapter 2. Echo Client                                             [jar]
[INFO] Chapter 2. Echo Server                                             [jar]
[INFO]
[INFO] ----------------------------< nia:chapter2 >----------------------------
[INFO] Building Chapter 2. Your First Netty Application - Echo App 2.0-SNAPSHOT [1/3]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @ chapter2 ---
[INFO]
[INFO] --------------------------< nia:echo-client >---------------------------
[INFO] Building Chapter 2. Echo Client 2.0-SNAPSHOT                       [2/3]
[INFO] --------------------------------[ jar ]---------------------------------
[WARNING] The POM for nia:utils:jar:2.0-SNAPSHOT is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Chapter 2. Your First Netty Application - Echo App 2.0-SNAPSHOT:
[INFO]
[INFO] Chapter 2. Your First Netty Application - Echo App . SUCCESS [  0.115 s]
[INFO] Chapter 2. Echo Client ............................. FAILURE [  0.067 s]
[INFO] Chapter 2. Echo Server ............................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.270 s
[INFO] Finished at: 2021-12-17T14:16:40+08:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project echo-client: Could not resolve dependencies for project nia:echo-client:jar:2.0-SNAPSHOT: ni
a:utils:jar:2.0-SNAPSHOT was not found in http://nexus.trasre.com/repository/infra-release/ during a previous attempt. This failure wa
s cached in the local repository and resolution is not reattempted until the update interval of nexus has elapsed or updates are force
d -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn  -rf :echo-client

@prd-fox

I don't see what this has to do with Tessera. Looks like you should post this to Netty instead.


WHAM ConvTasnet recipe 4.5dB worse than reported numbers

I have tried the Wham ConvTasnet recipe and the SI-SDR comes out to be 11.9dB whereas the reported numbers are 16.2dB, which is a huge gap. So, I am wondering what is wrong with my setup and config.
CONFIG:
(I have tried  different configs. Pasting the best config here)
data:
mode: min
nondefault_nsrc: null
sample_rate: 8000
task: sep_clean
train_dir: data/wav8k/min/tr
valid_dir: data/wav8k/min/cv
filterbank:
kernel_size: 16
n_filters: 512
stride: 8
main_args:
exp_dir: exp/train_convtasnet/
help: null
masknet:
bn_chan: 128
hid_chan: 512
mask_act: relu
n_blocks: 8
n_repeats: 3
n_src: 2
skip_chan: 128
optim:
lr: 0.001
optimizer: adam
weight_decay: 0.0
positional arguments: {}
training:
batch_size: 24
early_stop: true
epochs: 200
half_lr: true
num_workers: 8

Can you listen to the clean speech of wsj0?
It might seem like you generated them from wv1 instead of wv0. In such case, there is small background noise in the clean data.

Oh okay, thanks for the information! Yes, I did generate the waveforms from wv1. Do you mean wv2 instead of wv0. As far as I know, WSJ0 only comes with only wv[1-2] extensions, right?

Oh yes sorry, should be generated with wv1, not wv2, so you did right.
Did you look at the training log, how does it look like?

Can you also run evaluation from a pretrained model to validate that you have the good result?

The training log looks okay, but with the loss saturating around the 150th epoch.
I've tried the pre-trained model published here: https://zenodo.org/record/3862942#.XydLZfhKhQI and here are the results I get:
Overall metrics :
{'sar': 10.44097769122019,
'sar_imp': -138.711218817442,
'sdr': 8.450281738658656,
'sdr_imp': 8.146553121444242,
'si_sdr': 7.492973677180067,
'si_sdr_imp': 7.4944194836328,
'sir': 15.377501845990885,
'sir_imp': 15.073773228776457,
'stoi': 0.794393625040599,
'stoi_imp': 0.1356283198136183}
I am certain that there is some mismatch in the data preparation but, on listening to the mixed samples, they do sound clean mixed. I am not sure exactly what the issue is. I am trying to generate the data from scratch (I had pre-generated wham data so far) but previously when I tried preparing the data, it fails in the "Stage 1: Generating 8k and 16k WHAM dataset". I will look into this and get back(in another issue) if needed.

Can you listen to the clean files directly?
Please try to generate from scratch yes, the evaluation scores don't look right.

Thanks! I could replicate the results preparing the data from scratch. The reason for the degradation was due to data prepared from .wv2 instead of .wv1. Closing this issue.

Great to hear it !
Refs #166 #164