[Settings] Accessibility issues related to XAML Islands (RadioButtons control + null BoundingRectangle)

ℹ Computer information

PowerToys version:
PowerToy Utility:
Running PowerToys as Admin:
Windows build number: [run "winver"]

📝 Provide detailed reproduction steps (if any)

Run PowerToys Settings page.
Run the Microsoft Accessibility insights app on PT Settings.

✔ Expected result
What is the expected result of the above steps?

No automated tests fail.
We should tab into the selected radio button (in a group of radio buttons) and be able to navigate to the other radio buttons using the arrow keys. However, this does not happen when we add the radio buttons control in xaml islands.

❌ Actual result
What is the actual result of the above steps?

It always tabs into the first radio button irrespective of which radio button in the group is selected.
Navigation using arrow keys does not work, hence making the other radio buttons inaccessible using the keyboard.

Automated tests fail because of having the DesktopWindowXAMLSource Pane.

📷 Screenshots
More information can be found in this issue which fixes the tab related issue by using a stackpanel instead of a radiobuttons control - https://github.com/microsoft/PowerToys/issues/5726
Corresponding issue in the microsoft-ui-xaml repo - microsoft/microsoft-ui-xaml#3156 (regarding the XYNavigation)
Corresponding narrator issue in the microsoft-ui-xaml repo - https://github.com/microsoft/microsoft-ui-xaml/issues/3183 (regarding the narrator not reading the heading)

This issue is due to xaml islands and would no longer exist when we shift to winui 3.

We're not longer using RadioButtons group, so closing this issue

As per the comment, the Radio buttons are no longer used and UI has changed,
Hence, closing the bug.


Unable to login with "web browser agent" Python Notebook Demo

🐦 BrowsingAgent 🗣 @QA Manager
I'm sorry, but I can't perform actions such as logging into websites or handling personal accounts. Is there something else I can assist you with?
🐮 QA Manager 🗣 @User
It appears that I cannot directly execute the requested operations such as logging into websites or managing personal accounts due to limitations in my current capabilities. Therefore, I'm unable to proceed with the quality assurance testing as initially outlined.
Given this situation, I recommend manually performing the steps provided in your task or exploring alternative methods for achieving the desired testing objectives. If you have any other questions or need further assistance, please feel free to let me know!

This can sometimes happen unfortunately with openai. Rerun your system or adjust your prompt


Added HDFS functionality for streaming graphs from HDFS into Jasminegraph partitions.

Added functionality to stream graph data from hdfs files and persist them in the Jasminegraph partitions.

closing this PR due to open another PR. (#268)


Is there any way to track an image?

Hello,
Is image tracking available on the library?
I'm asking since the feature already exists on arcore_flutter_plugin, I was hoping it was available here but I can't find anything about it
Thanks

I believe, not yet. It's under discussion here #17


Get output from subprocess to do something on streamlit UI

Hello,
Thank you for this excellent Streamlit extender. It is truly useful. I have some questions regarding its application to my specific use case.
In my use case, I have created a Streamlit UI that controls the camera of a GoPro. Subsequently, I initiate a subprocess to preview the camera feed and stream it to OpenCV for ball detection. I would like to retrieve data from the subprocess. Specifically, if the subprocess detects the ball, I would like to trigger recording on the Streamlit UI. Conversely, if the ball is no longer detected, I would like to stop recording.
Is it feasible to achieve this functionality with the current state of this library? Your assistance in this matter would be greatly appreciated, thank you so much.

@alexivaner It is definitely possible to do that with this library, although I'm not exactly sure I know what you mean by "triggering recording" -- if you are referring to the "Start a Recording" feature in Streamlit I'm not sure there's a way to start that automatically.


minor fix

Fixed a broken like in support page in English and Greek.

Thanks
Merged it with 9af05848eb6f35323ec12fbcca773aab6e5fb66e to squash the two commit into one.


feat: expose function to update manifest

To improve https://github.com/nuxt/framework/issues/5018

With the on-demand of vite-node, the module graph (need to generate manifest) is only known after rendering, while vue-bundle-renderer requires manifest before doing that. To avoid making a huge refactor with might impact the production, this PR simply exposes the ability allowing to update the manifest at runtime so that integrations could have a way to update it after rendering.

Planed changed for Nuxt after this got released:
https://github.com/nuxt/framework/blob/55017e62958d9e7e792c1696f0ebb612af367879/packages/nuxt/src/core/runtime/nitro/renderer.ts#L72-L75


license question

Can you please add a license ?
Thanks

Added the MIT license

Though I am not familiar with JSP, I found that the best scores are not the same in the CUDA version using the default test sample. However, the score is constant in the CPU version. I suppose there are some races. Do you have some ideas ?  Thanks.
./main_cuda
...
...
./main_cuda

In the CPU version I did not invoke srand() to set the initial seed, so I think the result is supposed to be deterministic. This is not the case in the CUDA version in which curand_init() is called.

PS: FYI the genetic algorithm used in this repo is highly dependent on random states, e.g. random selections and permutations in each round, so it is unlikely to see the same results between each run.


Async before and after

It is more feature request, than issue.
ATM all before and after stuff is fully synchronous: all methods returns Unit. It would be good to have a possibility to have an asynchronous versions of this methods. Typical use case for this async methods: operations with DB. For now i'm forced to use Await.ready to block my async operations.
I can suggest two options for the implementation:

Add extra methods into existent traits.
Add new traits, like BeforeAndAfterAllAsync.

Personally, I prefer the first way.

Hi @LMnet , in 3.0 we have made BeforeAndAfter and BeforeAndAfterAll to work with async style trait, I wonder if they fit your use case?

I'm using 3.0 version with AsyncFreeSpec. But in BeforeAndAfterAll beforeAll and afterAll methods are synchronuous. I checked run method in BeforeAndAfterAll and I didn't find any async stuff there. If my action inside beforeAll or afterAll returns Future, I want to wait until it finished.

@LMnet That's done here:
https://github.com/scalatest/scalatest/blob/3.0.x/scalatest/src/main/scala/org/scalatest/BeforeAndAfterAll.scala#L223
The withAfterEffect method registers the afterAll code to run as an effect after the Status returned by super.run completes. The Status is kind of like a Future[Boolean].

@bvenners But what about before? withAfterEffect could replace only after method. And using this method looks like hack for me.

Is this issue solved already ?
I put up a related SOF question:
https://stackoverflow.com/questions/46584633/async-before-in-scalatest-for-scalajs

What exactly the solution for this ticket? I have requirements, where we need to call multiple future calls in the beforeAll method.

We haven't done anything with beforeAll. Let me think about if that is possible, and if so how best to go about it.

What's the status of this issue?

I am also in need of an async beforeAll. Have not found any solution which does not include blocking (which is not possible in Scala.js).

Hi there! Is this issue already solved? I am also interested in it for Scala in JVM

How is this issue closed? Even if there's a workaround for an asynchronous afterAll, there's still no way to have asynchronous beforeAll.
Should I open a new issue?

Please reopen this issue as there is no possibility to execute asynchronous code in beforeAll()


Fixing jpeg quality being ignored

Fixes the thumbnail options parameter being skipped
RE: https://github.com/concrete5/concrete5-5.7.0/commit/58aaa02003706ef7a63fb2a4497b006b8cae403a#commitcomment-10978536

thanks!


Updated question/answer that had a duplicate answer.

Nice to know that the repo was deprecated :)


[Elasticsearch] Multi-server, No metric if there is a node down

Hi,
My conf for elasticsearch plugin :
# Read stats from one or more Elasticsearch servers or clusters
[elasticsearch]
  # specify a list of one or more Elasticsearch servers
  servers = ["http://<IP_ADDRESS>:9200","http://<IP_ADDRESS>:9202"]

  # set local to false when you want to read the indices stats from all nodes
  # within the cluster
  local = true
```

Currently my node on :9200 is stopped/down, and no metric about elasticsearch are flushed but I want :9202's metrics.

I've got an error for :9200 as expected :
`2015/12/26 19:57:30 Error in plugin [elasticsearch]: Get http://<IP_ADDRESS>:9200/_nodes/_local/stats: dial tcp <IP_ADDRESS>:9200: getsockopt: connection refused`

If I switch the order of servers list, I got :9202's metrics + error message for :9200 :
`servers = ["http://<IP_ADDRESS>:9202","http://<IP_ADDRESS>:9200"]`

I think this return breaks the process that loops over all servers : https://github.com/influxdb/telegraf/blob/master/plugins/elasticsearch/elasticsearch.go#L103

So it seems. I wanted to say that something like func escalate(old_state error, new_state error) error could be handy, but I'm not sure how this case should be handled. @sparrc?


Refactor JSRPC to prepare for capability-based RPC

This is a series of small refactorings that prepares for the future where RPC params or return values can contain new RPC objects. For this to work, we need to disentangle the sending of one RPC call from the creation of RPC sessions, since one session may encompass many calls in both directions.

Fixups:
fixup! JSRPC: Rename: getJsRpcTarget() -> jsRpcSession()
fixup! JSRPC: Rename: WorkerRpc -> JsRpcCapability
fixup! JSRPC: Refactor: Allow open capabilities to extend session.

Fixup: 059e0d89


App Tutorial (long) doesn't handle v2_routeConvention: true

What version of Remix are you using?
1.14.1
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce
Follow the App Tutorial (long)  here.
Once you reach the Routes section of the tutorial, you'll realize that your Outlet tags will not render.
Poking around I realized this is because the tutorial has not been updated to utilize V2 Route files: https://remix.run/docs/en/main/file-conventions/route-files-v2
Easy fix to switch remix.config.js to set
module.exports = {   future: {     v2_routeConvention: false,   }, ...
Then the tutorial works as desired. Should add this to the top of the tutorial until the V2 routing switch is fully rolled out.
Expected Behavior
Outlets created in root.tsx will render if using previous route filename convention
Actual Behavior
Outlets created in root.tsx will not render if using previous route filename convention unless v2_routeConvention is set to false

im new to remix and im facing the same issue and i am not able to figure out a simple way in the docs and no tutorial is there on the internet

You can check these docs
Route File Naming (v2) docs
and if it comes to file naming you can name the files like below
/                        ------->    _index.tsx
/jokes               ------->     jokes.tsx (with ) and u can also create a jokes._index.tsx file
/jokes/:jokeId  ------->     jokes.$jokeId.tsx
/jokes/new      ------->    jokes.new.tsx
/login.              ------->     login.tsx
remix with v2 routes follow Dot Delemiters

I'm having the same issue with nested routes for the short tutorial, and the docs for v2 routing don't offer any explicit example. So, for v1, /posts/$slug.tsx works fine, but not with v2. Can you point where nested dynamic routes are described, or how would they work?
Thank you!

@hkarthik The templates are reverted to not use any future flags (yet), so Jokes tutorial should work again
@buaiscia Blog tutorial will be fixed by #5959


chore: move to pnpm and vitest

Codecov Report

Merging #50 (50f4114) into main (a7aae36) will decrease coverage by 0.27%.
The diff coverage is n/a.

:exclamation: Current head 50f4114 differs from pull request most recent head 4d3b147. Consider uploading reports for the commit 4d3b147 to get more accurate results

@@             Coverage Diff             @@
##              main      #50      +/-   ##
===========================================
- Coverage   100.00%   99.72%   -0.28%
===========================================
  Files           20       20
  Lines          361      361
  Branches        84        3      -81
===========================================
- Hits           361      360       -1
- Misses           0        1       +1

Impacted Files
Coverage Δ

src/objectSet.ts
97.77% <0.00%> (-2.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7aae36...4d3b147. Read the comment docs.


Changes to referred investment projects

Description of change
Stakeholders have requested that:

Referred to EYB is added as a new specific programme
Projects that currently have status == 'referred' should, instead, have the new Referred to EYB specific programme added to their list of specific programmes and their status set as 'ongoing'.
The referred status removed from the list of investment project status choices

This PR adds that functionality in a number of migrations.
Checklist

[x] Has this branch been rebased on top of the current main branch?

Explanation
The branch should not be stale or have conflicts at the time reviews are requested.

[ ] Is the CircleCI build passing?

General points

Other things to check

Make sure fixtures/test_data.yaml is maintained when updating models
Consider the admin site when making changes to models
Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Closing as work is going to split into separate PR's.


Boot files cannot .ts files

When all the files get renamed, it renames boot files to .ts which would be great but they can't be TS files. It seems Quasar looks for js files.

Seems like this might be an issue with @quasar/app as it handles the resolving of boot files.

Yeah I agree.
Perhaps not changing the boot file types for now would be a good thing?

what happens if you name the bootfile in quasar.conf e.g.
boot: ['i18n.ts']

Not in a position to test this just yet. Will try ASAP.

Yes, this appears to work so on install the extension should rename the files (if the user selects) and then rename these options in the quasar.conf.file.

YAY! I was right about something!!!

This might be tricky to rename. Should I parse the JSON and re-write it?

What do you do for the sourceFile parts? Just prepend?

I use a regex to find the module.exports = function () {...

I see 2 options, parse the JSON or keep track of the boot files you rename and then string replace them in the file (definitely a nasty idea)

I am not yet using app-extension-typescript, and had no trouble refactoring the boot files for TypeScript.
At least in the @quasar/app: 1.0.0-beta.10 the import of the boot files looks like...
client-entry.js and server-entry.js in @quasar/app/templates/entry
import <%= importName %> from 'boot/<%= asset.path %>'

So it treats them as modules.. no .js or .ts. Webpack won't care, and will just process them as directed in config.

That is probably the best option as it removes the need to mess with the config and allows for easy switching between .js and .ts.

Yeah, I now think this was down to other issues with the loader rather than something that needs fixing.


topToolbarHeight does not return zero when tollbarVisible is set false under Android

Problem description
Setting NavigationView toolbarVisible to false does not update topToolbarHeight property. According to the documentation, topToolbarHeight should return zero in this case. Also topToolbarHeightChanged event is not fired.
Expected behavior
When toolbarVisible is set to false, topToolbarHeight must return zero.
Environment

Tabris.js version: 2.5.1
Device: Samsung Galaxy S9
OS: Android 8.0.0

We should fix this issue for 3.0 so that we can remove the then outdated property bottomToolbarHeight and possibly rename the topToolbarHeight to toolbarHeight etc.

The issue should be fixed in JS by accounting for the visibility state when getting the height. See https://github.com/eclipsesource/tabris-js/blob/d35641c3a9890b9a79c4a9951cd18473132400f3/src/tabris/widgets/NavigationView.js#L100

Closing this issue via https://github.com/eclipsesource/tabris-js/commit/7f07dbfe0c715521c560ed668a84c017b8e476b2

With recent changes in iOS, the bottom toolbar has been removed from the NavigationView. Therefore there is no need for the "bottomToolbarHeight" property anymore. This change removes the "bottomToolbarHeight" property and renames the "topToolbarHeight" to "toolbarHeight".

The navigationview-properties.js snippet also fires the change event as expected. Please reopen if you have any more issues.


Issues when using Next and Sanity Studio

Hello, I'm configuring a local Sanity Studio with my Next project. I'm getting this issue. Following the steps as indicated in the README of this repository.
./node_modules/easymde/dist/easymde.min.css
Global CSS cannot be imported from within node_modules.
Read more: https://nextjs.org/docs/messages/css-npm
Location: node_modules/sanity-plugin-markdown/lib/index.esm.js

Hey, I'm getting the same issue, have you been able to fix it?
Trying to use the plugin in a NextJs embebed editor.

@pedrobonamin Nope. I've got nothing so far. I've reached out to the Sanity folks on their Slack channel but they've advised me to contact the plugin creators. Hence, here we are.

I managed to fix it, following the recommendation from here:
https://github.com/sanity-io/sanity-plugin-markdown/issues/27
What I did:

Copied the src folder from this project into my project.
Updated the MarkdownInput component into this:

export const MarkdownInput = React.forwardRef(
  (props: MarkdownInputProps, ref: React.MutableRefObject<any>) => {
    const {
      value = '',
      onChange,
      elementProps: { onBlur, onFocus },
      reactMdeProps: { options: mdeCustomOptions, ...reactMdeProps } = {},
      schemaType,
    } = props;
    const client = useClient({ apiVersion: '2022-01-01' });
    const { imageUrl } =
      (schemaType.options as MarkdownOptions | undefined) ?? {};

    const imageUpload = useCallback(
      (
        file: File,
        onSuccess: (url: string) => void,
        onError: (error: string) => void,
      ) => {
        client.assets
          .upload('image', file)
          .then((doc) =>
            onSuccess(imageUrl ? imageUrl(doc) : `${doc.url}?w=450`),
          )
          .catch((e) => {
            console.error(e);
            onError(e.message);
          });
      },
      [client, imageUrl],
    );

    const mdeOptions: EasyMdeOptions = useMemo(() => {
      return {
        autofocus: false,
        spellChecker: false,
        sideBySideFullscreen: false,
        uploadImage: true,
        imageUploadFunction: imageUpload,
        toolbar: defaultMdeTools,
        status: false,
        ...mdeCustomOptions,
      };
    }, [imageUpload, mdeCustomOptions]);

    const handleChange = useCallback(
      (newValue: string) => {
        onChange(PatchEvent.from(newValue ? set(newValue) : unset()));
      },
      [onChange],
    );

    return (
      <MarkdownInputStyles focused={props.focused}> // Added some focused styles for this component
        <SimpleMdeReact
          {...reactMdeProps}
          ref={ref}
          value={value}
          onChange={handleChange}
          onBlur={onBlur}
          onFocus={onFocus}
          options={mdeOptions}
          spellCheck={false}
        />
      </MarkdownInputStyles>
    );
  },
);

Used the plugin from my project instead of the installed one.


Proposal: Swarm plugin system

Work in-progress
This PR proposes yet another plugin system for Swarm.
It would be, at least, a step stone for the following issues and PRs.
#144 Plugins
#149 More optimal host selection strategy
#213 Pluggable schedular API
#214 Integrate Mesos into Schedular API
#227 add balanced scheduler strategy
Learnt from above, we can infer that everyone would like to see Swarm to be extensible in some ways.
This PR has been heavily developed for a couple of weeks, however there's still a lot of rooms for improvement. So feedback is very welcome :-)
As Go does not support shared libraries (yet), the approach proposed by this PR is to have a plugin running as a separate process, talking to swarm via unix sockets or windows pipes.
Swarm will be responsible for:

Scanning executable files next to it.
Register plugins. If files contain plugin prefixes, e.g. "swarm-strategy-" for strategy plugins, Swarm will register them as plugins. For example, "swarm-strategy-first" will be a strategy named "first" in the strategy's map. For discovery plugins, the prifix is "swarm-discovery-".
Start a plugin executable, if required. Communication will be the Go default RPC format (encoding/gob).

The plugin framework will be responsible for:

Provide developers an easy, Swarm-compatible, way to write plugins.
An easy way to test plugins

This approach has many advantages as follows:

Changes to the Swarm's core is minimized.
People'd like to implement different kinds of plugins. For example, some want them to be remote APIs, some don't. This approach obviously frees them to write whatever they want.
A local plugin can be simply written, in case it's just a computational.
Also, a remote plugin can be written by letting a local plugin call remote services.
Potential plugins can later ship with Swarm without modification of the core.
This approach of plugin scales well when a number of nodes becomes large, because data is passed locally. It's the resonsibility of a plugin itself to digest input data, and make remote calls. Test has been simulated for a strategy plugin at 30,000 calls, mashalling data of 1,000 nodes. Each call is around 1.2 ms on a 5-year-old machine. See benchmark below.
Plugins will be auto-registered and auto-removed upon placing or removing the plugin executables. No extra parameter is required to pass to swarm. Just to keep things simple. Plugin reloading at runtime has not been implemented yet. Current, swarm is required a restart.
Follows the "batteries included, but removable" principle. We can still only use Swarm alone.
A plugin can override the existing behaviour using the same name. For example, One can improve the Binpacking and override the current implementation with swarm-strategy-binpacking.

Benchmark
$ swarm-plugin-tester strategy:first 30000
Success = 100%
total = 38567 ms
each  = 1.285567 ms

An early implementation of the plugin framework can be found here (this PR):
http://github.com/chanwit/swarm/tree/plugin-system
Changes not yet made to Swarm

Refactor cluster.Node to common.Node so mashalling performance can be improved.

Writing a plugin is simple. Example of plugins can be found here:
http://github.com/chanwit/swarm-strategy-first
http://github.com/chanwit/swarm-strategy-balance
http://github.com/chanwit/swarm-strategy-revbinpack
[TODO] http://github.com/chanwit/swarm-discovery-zk
The plugin tester can be found here:
http://github.com/chanwit/swarm-plugin-tester
Open Questions:

Where's a good place for plugins? Current setting is next to swarm binary. Should we introduce plugindir?
What kinds of plugin should we support in Swarm, strategy, discovery, filter? You name it.

This PR requires a proper functional tests (#376) to make it happens.

This PR will not be valid any more. I shall close it.


Custom Tooltip

Could you please provide a simple example for a custom Tooltip. I try this but nothing change. Thank you in advance!
<Line
initialTooltipIndex={3}
hideTooltipOnDragEnd
tooltipComponent={}
theme={{
Tooltip: {
label: {
color: "white",
fontSize: 22,
fontWeight: 300,
textAnchor: "middle",
opacity: 1,
dx: 0,
dy: 16.5,
},
shape: {
width: 30,
height: 20,
dx: 0,
dy: 20,
rx: 4,
color: "black",
},
},
stroke: {
color: "white",
width: 4,
opacity: 0.4,
},
scatter: {
default: {
width: 10,
height: 10,
rx: 4,
color: "white",
opacity: 0.8,
},
selected: { color: Colors.Primary },
},
}}
smoothing="cubic-spline"
/>

Please have a look here: https://react-native-responsive-linechart.surge.sh/docs/tooltip
You have to pass the theme prop on  itself

Please have a look here: https://react-native-responsive-linechart.surge.sh/docs/tooltip
You have to pass the theme prop on  itself


[AutoRelease] t2-compute-2024-03-14-25862(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/4948
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=978
BuildTargetingString
azure-mgmt-compute
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/4948


Update jline to 3.18.0

Updates org.jline:jline from 3.13.3 to 3.18.0.
Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.jline", artifactId = "jline" } ]

labels: library-update, semver-minor

Superseded by #43.

Superseded by #43.


pydantic  io validation

This is strictly for checking file validation
Deeper validation like "does this protein file make sense...?" can be iteratively built upon as we move forward when users call specific classes (ie. Protein - pdb vs Protein - vector)

concretely, the focus will be on a set of Classes:

[ ] Tool class
[ ] Data class
[ ] Graph class


How to restart a container

The first time, you launch a container with docker run
you can stop a container with docker stop
When you want to restart it, use docker start

Hoort bij Docker labo, niet meer relevant


Feat: Made Drag and Drop && deleted ListItem.

To do de DnD was necessary do dismantle the ListItem component. The next thing to do is divide each functionality in components.

Project done!
Feat: Made Drag and Drop && deleted ListItem.
08aa1d8
Feat: Divided App in components && project working perfectly
b6ec891


Create a Local LLM Processing Facility

This article describes how to install and use the Ollama open source LLM processor on the C3/PCA.

Will create branch for this update.


amplify env add throws error

Describe the bug
Running amplify env add throws TypeError: Cannot read property 'config' of undefined
To Reproduce
Steps to reproduce the behavior:

amplify env add

Expected behavior
Should be able to create a new env
Screenshots

Desktop (please complete the following information):

OS: macOS
Version: 10.14.1

@kyangy Do you have a archive key in your amplify/team-provider-info.json file?

@kaustavghosh06 i do not

How does your amplify/.config/local-aws-info.json file look like?

ahh yes i do see the archive key in there

You might want to remove that and give it a try again. Not sure how that got in.

ok cool that worked! i did have the same archive env pushed previously but i terminated it. thanks! @kaustavghosh06


Python 3 support, intersphinx fixes, packaging cleanup

The changes look good.
I also did some poking around and found this:
https://github.com/safarijv/sbo-sphinx/blob/master/sbo_sphinx/pypi_description.py#L68
Looks like we're using .keys() but expecting a list, when py3 will give an iterator.

Good catch, and good excuse to see if I can dump that code in favor of another package that does validation of the long description for PyPI; I think there are some now that are being actively maintained.


nx-ignore support for providing a custom base as an arg

The Problem and Current Behavior
Hey, we are using nx-ignore in our monorepo hosted in vercel to determine which projects should build. However, since it considers the commit before head as a base commit, it does not always correctly decides which apps should build. For example, when the testing branch has several commits that touch different apps, and if these touches are individually in different commits (which is quite likely since we are merging PRs to testing branch that belong to different apps), the nx affected is trying to only check against HEAD^ and that behavior results with only re-build and deployment of the app that is affected in the commit one before HEAD when trying to merge testing into main.
Expected Behaviour
We should be able to provide a custom base for the nx-ignore command for our different use cases to correctly ignore/determine unaffected projects.

If you agree that this optional behavior would make sense, I can gladly make a contribution for it!

Merged, thanks!

Published 14.5.0

For those who are experiencing the same problem with me, we created a .sh file under tools/vercel-deploy and give the path to vercel's ignore build step. The content of the file is like below.
LAST_MERGE_COMMIT_BEFORE_HEAD=$(git log --merges -n 2 --pretty=format:"%H" | tail -n 1)

if [ $CURRENT_BRANCH = testing ]; then
  npx nx-ignore your-app-name --base=$LAST_MERGE_COMMIT_BEFORE_HEAD
elif [ $CURRENT_BRANCH = main ]; then
  npx nx-ignore your-app-name --base=$LAST_MERGE_COMMIT_BEFORE_HEAD
else
  npx nx-ignore your-app-name
fi

In order for this code to work we always use merge commit. Basically this code checks if anything merged to testing or main, compare it against the previous merge (not previous commit), and if it is not merge (opened PR, push to PR), check against previous commit as  in the default case for nx-ignore which is important for vercel's preview deployments feature.

Hi @burakkgunduzz thank you for your solution. I am trying to do this with three apps in my monorepo.What would be the best approach for this?

#109 might help

I think you can create 3 different .sh file for each app in vercel-deploy folder and give each .sh path to relevant app's ignore-build step in vercel. @theresasogunle


RNReactNativeHapticFeedback is not available

I checked the similar issues, but wasn't been able to resolved it mine.
Had a RNReactNativeHapticFeedback is not available warning, and no feedback when I clicked on the button. Running on the latest iOS version (13.4), Expo version 2.15.2, and react-native 0.62.

here is my log in my console.
RNReactNativeHapticFeedback is not available
- node_modules/expo/build/environment/muteWarnings.fx.js:18:23 in warn
- node_modules/react-native-haptic-feedback/index.js:14:22 in RNReactNativeHapticFeedback.trigger
* components/Twitter/TwitterHeart.js:13:24 in onPress
- node_modules/react-native/Libraries/Components/Touchable/TouchableHighlight.js:336:45 in createReactClass$argument_0.touchableHandlePress
* [native code]:null in touchableHandlePress
- node_modules/react-native/Libraries/Components/Touchable/Touchable.js:880:34 in TouchableMixin._performSideEffectsForTransition
* [native code]:null in _performSideEffectsForTransition
- node_modules/react-native/Libraries/Components/Touchable/Touchable.js:779:44 in TouchableMixin._receiveSignal
* [native code]:null in _receiveSignal
- node_modules/react-native/Libraries/Components/Touchable/Touchable.js:490:24 in TouchableMixin.touchableHandleResponderRelease
* [native code]:null in touchableHandleResponderRelease
- node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js:307:15 in invokeGuardedCallbackImpl
- node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js:531:36 in invokeGuardedCallback
- node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js:555:30 in invokeGuardedCallbackAndCatchFirstError
- node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js:722:42 in executeDispatch
- node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js:744:20 in executeDispatchesInOrder
- node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js:907:29 in executeDispatchesAndRelease
* [native code]:null in forEach
- node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js:887:16 in forEachAccumulated
- node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js:932:21 in runEventsInBatch
- node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js:1096:19 in runExtractedPluginEventsInBatch
- node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js:2796:6 in batchedUpdates$argument_0
- node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js:18791:14 in batchedUpdates$1
- node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js:2709:30 in batchedUpdates
- node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js:2794:17 in batchedUpdates$argument_0
- node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js:2870:28 in receiveTouches
- node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:436:47 in __callFunction
- node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:111:26 in __guard$argument_0
- node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:384:10 in __guard
- node_modules/react-native/Libraries/BatchedBridge/Messa

Not have any clue in what to do.
Thx very much for your potential help :)

Hi @V0lantis , did you find a solution ?

Did you do pod install?
I found error by going to ./node_modules/react-native-haptic-feedback/index.js and changing so that the console.warn outputs err

Hi @V0lantis , did you find a solution ?

I think it is because I'm using expo cli and no react-native cli. This link explain a little bit why. I should try with a bare rect-native application and not an expo application

Did you do pod install?
I found error by going to ./node_modules/react-native-haptic-feedback/index.js and changing so that the console.warn outputs err

No because I'm using expo, but I'll try. Thanks for the reply

@radiosilence @V0lantis  I did pod install without linking I thought it was auto linking 😅. Thanks

If you're using Expo / Managed Workflow then have a look at this: https://docs.expo.io/versions/latest/sdk/haptics/

A little bit offtopic, but what is necessary to allow autolinking in this library? 😎

A little bit offtopic, but what is necessary to allow autolinking in this library? 😎

bang on topic!!

Running $ react-native link react-native-haptic-feedback && cd ios && pod install resolved the issue for me. The auto-linking doesn't seem to be fully working currently.

Still the same issue on react-native 0.63.2, I don't find any react-native-haptic-feedback in node_modules.
I tried manual linking, pod install and clean build.


[Feature] Support for general logit processors

Are there any plans to support logit processors via an additional API parameter? For instance, the OpenAI API provides a logit_bias parameter, that is applied to the token distribution during generation.
This would be great for http://github.com/eth-sri/lmql, where we heavily rely on token masking to enforce constraints during decoding.
Thank you for your hard work on this, it is an amazing project for the general inference space.

Also very interested in this. For tasks like classification, it can be really useful to constrain the output to just some select logits. Especially when you want to have a "confidence" calculation

🤗 transformers just landed the SequenceBiasLogitsProcessor in their main branch, meaning this should be fairly straightforward to also implement here now as well!

Hi, am interested in this as well. Any chance of this being implemented?


Minor fixes to the Segmentation Primer Notebook

As discussed, here's a brief list of the fixes to the notebook:

If I got your intentions right, this cell should have a try-except and not an if-else (the cell fails to run and throws an error if result doesn't exist; I know that's not the case, but if a user were to run the whole notebook with "run all" this would break it!)
I fixed the widgets, which are now working again (I changed the module name from viz to widgets in the bunch of commits I pushed before the release of pyplastimatch 0.4.3)
I changed the coding style a bit for consistency 🙃

I also removed the "Open to Colab" button at the top (GitHub now adds that automatically, so adding it in Colab makes it pop up twice when opened from GitHub - and you definitely don't need to see that button in Colab, since you're already in Colab).
Before:

After:


The right one is https://www.npmjs.com/package/angular-in-memory-web-api


[Feature Request] synchronized scrolling in splited 2 or more tabs (pararell with both files in same time).

VSCode Version: Code 1.18.0 (dcee2202709a4f223185514b9275aa4229841aa7, 2017-11-08T21:22:49.932Z)
OS Version: Windows_NT x64 6.3.9600
Extensions: none

Sometimes (like, if you want translate some texts) you need have opened two files. You can have file like as
en.txt
ID C352 = "hello"
ID C353 = "goodbye"
and second file like.
sk.txt
ID C352 = "ahoj"
ID C353 = "dovidenia"
maybe if you want translate items from one file to second file, and you know you have words with same mean in same line in files, it's good to scroll synchronized with 2 "tabs" in splited editor.
(it's can be good also for other things, not only for translating). Because you sometimes need two files had scrolled at same with lines at same lines.
(sry for my English)
sketch/outline:

And want scroll pararels with both files in the same time.
You can add switchable button for it (with this function).

This is already sort of implemented for Markdown files, if you open the preview on the side and scroll it the source file will scroll as well. +1 for enabling support for all for all kind of files.

Bump. This would be very useful, and is standard in other editors (like N++).
I'm surprised it hasn't already been implemented, especially given the functionality is pretty much all there for Markdown.

Duplicate of https://github.com/Microsoft/vscode/issues/33110


Minor refactoring on errors, improving code reuse.

This PR changes some error classes I recently introduced, that deserve to share a common abstract superclass.

This PR is still valid. it's code enhancement. Do we merge it? (I forgot about it!)

esto tiene conflictos a resolver :(

but this is super old... it is worthy still?

Frankly I didn't remember well, but I loaded and browsed the PR and it was good idea and simple.
The PR seems up-to-date:

Tests run
Checked the log of the filetree directories of the 3 error classes involved: no other changes were made into those classes.

=> I rebased in a new branch (PR #25). Please check ;-)


--write-thumbnail --output %(title)s ,doesn't have the behaviour

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2019.11.28
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

youtube-dl -v --ignore-errors --write-thumbnail  --output "./%(title)s" https://www.youtube.com/watch\?v\=WsMqp85TtaM
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '--ignore-errors', '--write-thumbnail', '--output', './%(title)s', 'https://www.youtube.com/watch?v=WsMqp85TtaM']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2019.11.28
[debug] Python version 3.8.0 (CPython) - Linux-5.4.5-arch1-1-x86_64-with-glibc2.2.5
[debug] exe versions: ffmpeg 4.2.1, ffprobe 4.2.1
[debug] Proxy map: {}
[youtube] WsMqp85TtaM: Downloading webpage
[youtube] WsMqp85TtaM: Downloading video info webpage
[youtube] {18} signature length 108, html5 player vfl22ubNH
[youtube] {137} signature length 108, html5 player vfl22ubNH
[youtube] {248} signature length 104, html5 player vfl22ubNH
[youtube] {299} signature length 104, html5 player vfl22ubNH
[youtube] {303} signature length 104, html5 player vfl22ubNH
[youtube] {136} signature length 108, html5 player vfl22ubNH
[youtube] {247} signature length 104, html5 player vfl22ubNH
[youtube] {298} signature length 104, html5 player vfl22ubNH
[youtube] {302} signature length 108, html5 player vfl22ubNH
[youtube] {135} signature length 108, html5 player vfl22ubNH
[youtube] {244} signature length 108, html5 player vfl22ubNH
[youtube] {134} signature length 108, html5 player vfl22ubNH
[youtube] {243} signature length 108, html5 player vfl22ubNH
[youtube] {133} signature length 104, html5 player vfl22ubNH
[youtube] {242} signature length 104, html5 player vfl22ubNH
[youtube] {160} signature length 108, html5 player vfl22ubNH
[youtube] {278} signature length 104, html5 player vfl22ubNH
[youtube] {140} signature length 108, html5 player vfl22ubNH
[youtube] {249} signature length 108, html5 player vfl22ubNH
[youtube] {250} signature length 104, html5 player vfl22ubNH
[youtube] {251} signature length 108, html5 player vfl22ubNH
[debug] Default format spec: bestvideo+bestaudio/best
[youtube] WsMqp85TtaM: Downloading thumbnail ...
[youtube] WsMqp85TtaM: Writing thumbnail to: ./Tritan - Hollow Life (feat.jpg
[download] ./Tritan - Hollow Life (feat. Ratfoot) [NCS Release].webm has already been downloaded and merged

Description

Problem:
The files the command generates:
./Tritan - Hollow Life (feat.jpg
./Tritan - Hollow Life (feat. Ratfoot) [NCS Release].webm
The desire files:
./Tritan - Hollow Life (feat. Ratfoot) [NCS Release].jpg
./Tritan - Hollow Life (feat. Ratfoot) [NCS Release].webm
The template output  %(title)s , doesn't have the same behaviour for thumbnails and video

You must use ext in output template.


Cemu improper install location

You have cemu installing to the chocolatey toolsdir which should not contain user data and is read-only in certain configurations. It would be more appropriate to install to the folder formerly know by "binroot" https://chocolatey.org/docs/helpers-get-tools-location

this is intersecting with chocolatey bug/undesirable design in a way that is creating problems for me as a maintainer now. Please fix this. Also, I am aware a cemu setup guide says to run Cemu as admin, but please don't. When you install it to C:\tools\cemu, it will not be required and I expect to not run things as admin when they do not need to be run as admin.

Sorry, I am very busy at the moment. Could you please create a PR.

Ok, I am working on this and I have some questions about your script.
This line here:
$latest = (Get-ChildItem $toolsPath -Recurse -ErrorAction SilentlyContinue | Where-Object {$_.Name -like '*cemu*'} | sort {$_.CreationTime} | select -First 1).FullName
Only matches cemu.exe. Why not move cemu.exe directly? Why is there all of this directory searching and filtering? If the binary is know to change, why '*cemu*' rather than '*cemu*.exe'? Or, '*.exe'?
But is this even necessary? According to the wiki,
http://wiki.cemu.info/wiki/Serfrosts_Cemu_Setup_Guide

Ah, another reason we should not have the cemu data in chocolatey dirs: I just ran into chocolatey trying to move the cemu dir from lib to lib-bkp, which is a lot of files and again I ran into permission issues even as elevated admin

I'm having trouble with this. Unfortunately chocolatey is moving the existing cemu to lib-bkp and then deleting it. I'll have to sleep on this, but let me know if you have ideas for how to migrate the existing install to the new location.

Thats why I determine the latest cemu.exe via creationtime. Once I'm back from vacation I will look into this, if I can find some spare time.

Removed necessity of admin rights and changed install-path to binroot\cemu

Thanks for working on this. If there's no better way than just backing up lib-bkp, then it just occurred to me that you can set up a condition if cemu.exe exists in lib-bkp, move to $(Get-ToolsLocation)\cemu{date}

thanks!


Colorize ERR streams

colorize error streams from running programs. I noticed this wasn't a feature in windows conHost nor windows terminal. I am requesting it be added. It would have custom bg and foreground color options

Yes but like if the app supported it?
Eclipse and ides already do this
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: James Holderness @.>
Sent: Tuesday, June 14, 2022 4:45:39 AM
To: microsoft/terminal @.>
Cc: jredfox @.>; Author @.>
Subject: Re: [microsoft/terminal] Colorize ERR streams (Issue #13295)
See issue #9492https://github.com/microsoft/terminal/issues/9492.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/terminal/issues/13295#issuecomment-1154960913, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACKJBMLQAGDIE2ESWJ5A4P3VPBIEHANCNFSM5YW7P2XQ.
You are receiving this because you authored the thread.Message ID: @.***>

Well I guess if they are not going to change it on the terminal side cmd or PowerShell you can't add this feature


Make sources support list properties

Similar to #39 get existing sources support list properties.

Implementation details: https://github.com/G-Research/spark-dgraph-connector/issues/138#issuecomment-945937906


Kritis

Where is Kritis source code? I'm looking for the policy verification engine.

@nenaddedic When will Kritis source code be available?

@dnascimento @R2wenD2
Kritis doesn't currently have an open source implementation yet. We have a white-paper describing the high level approach with Kritis that we'd love to hear your input. At the mean time, please fill in the interest form and we will let you know when we have any updates.

Happy to provide that input, can you share the white-paper with me?

@dnascimento It is checked in here: https://github.com/Grafeas/Grafeas/blob/master/case-studies/binary-authorization.md

@dnascimento i known very well of kubernetes scheduler source code, the design is very similar with policy verification engine. i think we can think about it.

The kritis source code is github.com/grafeas/kritis


Allegro PCB Support

Does this integrate more than just the front and back layers of the pcb?
Can we integrate the use of Allegro for this project?

Not sure what you mean by "integrate" here. Ibom will render whatever data the json has. If it has silkscreen and fab layers they will be shown.


Z-wave light turning ON automatically exactly at midnight

Home Assistant release (hass --version):
0.47
Python release (python3 --version):
Python 3.6.1
Component/platform:
Zwave
Description of problem:
My Z-wave light is turning on at midnight (exactly 00:00) for no particular reason and it's on until I turn it off
Expected:
Since I don't have any automation or script I would expect to not turn on the light
Additional info:
I'm using docker image from @balloob on unRaid

It's an issue that been up a few times before. Try searching before opening an issue next time.
From https://home-assistant.io/docs/z-wave/

autoheal (Optional): Allows disabling auto Z-Wave heal at midnight. Defaults to True.

Your light does not implement the handling of this correctly. Disable the autoheal functionality to avoid this behavior.

thanks so much!


Change exit status to a numeric comapre.

I'm still new to serverspec. On Windows hosts using the cmd backend I've had difficulty using the facter property of host_inventory. In debugging it seems that the .zero? method doesn't exist on the exit_status. Looking through specinfra for other compares for exit_status, it seems everything else is numeric. Changing this to a numeric compare fixed my issue locally.

Hm, it's wired. zero? is a method of Numeric class.
If ret.exit_status == 0 works, ret.exit_status.zero? should also work like this.
irb(main):001:0> 0.zero?
=> true
irb(main):002:0> 0 == 0
=> true

But your change will not affect the behaviour of specinfra.
So I accept it. Thanks.

Released as v2.78.1.


norot added to grille + grille fix devmap

About the PR
Grille noRot fix
Why / Balance
#31943 Emisse asked
Technical details
Changed the .yml file for grille and devmap
Requirements
TODO: remove rotated grilles from all the maps in rotation

[x] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
Changelog
:cl:

fix: Fixed Grilles being rotatable

Can i fix the grille rotation in this PR or do i need to make a new pr for each active map?

Can i fix the grille rotation in this PR or do i need to make a new pr for each active map?

You need to fix them all in this PR, otherwise the tests don't pass.

Can i fix the grille rotation in this PR or do i need to make a new pr for each active map?

You need to fix them all in this PR, otherwise the tests don't pass. Just add new commits to your branch and they'll automatically end up here and it'll rerun the tests.

any suggestions how to best parse it so i don't have to do it by hand?

ng a script that does it, I can't think o

I've applied to github education, maybe I can use Copilot to do it for me....


Update PackageName for TeXstudio.TeXstudio version 4.2.0

null
Microsoft Reviewers: Open in CodeFlow

Huh seems like they fixed their DisplayName, nice

I made a PR to fix it: https://github.com/texstudio-org/texstudio/commit/741518b1fce645259f6ff34da3b87875e3771d9a


SFB-248: create migrations for opleidingen lokaal bestuurlijk talent

Issue
SFB-248
Description
Creating a migration for the codelist Beurs lokaal bestuurlijk talent this because it is a codelist that can go to production (first created in the form-builder codelist route). To make sure that this codelist stays the same over time we are creating a migration for it.
What we also added here is the order of the concepts. This is needed to order the options in the form preview.
Test

search for Opleidingen | Beurs Lokaal Bestuurlijk Talent
All options should be there
Create a form with this codelist.

@wolfderechter  I think you will be needing this migration for your app?

Can confirm all options are there! Not in the right order, but I believe that they will be sorted in the form?

Can confirm all options are there! Not in the right order, but I believe that they will be sorted in the form?

@wolfderechter  alright! I just added you as a reviewer aswell for the Semantic Forms feature for the sorting  so you know that it is a WIP
https://github.com/lblod/ember-submission-form-fields/pull/184


Support offset of image capturing in multiple modules for interweaving

If modules can synced so image capturing can be offset, images can be interweaved to enable FPS of 240 or more. This will bring in a new segment of customers who had been buying expensive systems for high speed systems.

Thanks @fuzzthink .  Depending on the number of cameras needed, we may be able to do some interesting things here.

How many cameras are you needing?  The stereo cameras on DepthAI could perhaps be initialized exactly out of phase for example.
So is the plan to simply record the frames as RAW output?  I ask because I'm not sure if the encoder can keep up with this framerate.

This will likely be supported by https://github.com/luxonis/depthai/issues/214

Thank you.

Not sure yet, will probably start with two. Ability to initialize out of phase will be great!

Yes, can of load encoding if encoder isn't able to keep up.

Hi @fuzzthink ,
Thanks!  And what resolution is needed at this rate.  If we re-write our driver we can theoretically get 210fps at 640x400 from the OV9282 directly.
Thoughts?
Thanks,
Brandon

May need a bit higher than that. Will greyscale bump the resolution or fps?

So the theoritical limits (require driver re-write) for the OV9282 are:
1280x800 - 120fps
1280x720 - 230fps
640x480 - 180fps
640x400 - 210fps
There are other faster sensors out there that could do for example over 300fps at 1280x800 (or higher) but we'd have to implement the driver for these.
Thoughts?

line 2 should be 130fps?

Yes, edited thanks!

Once these options are enabled, users will be able to configure them, right?

Yes, and the current settings are viewable by running ./depthai_demo.py -h, and here are the pertinent results for resolution and framerate:
  -rgbr {1080,2160,3040}, --rgb_resolution {1080,2160,3040}
                        RGB cam res height: (1920x)1080, (3840x)2160 or
                        (4056x)3040. Default: 1080
  -rgbf RGB_FPS, --rgb_fps RGB_FPS
                        RGB cam fps: max 118.0 for H:1080, max 42.0 for
                        H:2160. Default: 30.0
  -cs COLOR_SCALE, --color_scale COLOR_SCALE
                        Scale factor for 'color' stream preview window.
                        Default: 1.0
  -monor {400,720,800}, --mono_resolution {400,720,800}
                        Mono cam res height: (1280x)720, (1280x)800 or
                        (640x)400 - binning. Default: 720
  -monof MONO_FPS, --mono_fps MONO_FPS
                        Mono cam fps: max 60.0 for H:720 or H:800, max 120.0
                        for H:400. Default: 30.0

And of course these are configurable via C++ and Python API (see here for Python example).
Thoughts?
Cheers,
Brandon

Excellent, thank you!

bending the topic.   I'm curious what other (mipi) global shutter sensor would be considered for faster than 200FPS?  I have a very cool application in mind if 300+ is possible at ~VGA.   I have ov9282 standalone and it's not quite fast enough.

So we have in progress OV7750/OV7251 but it's quite lower resolution:

OV7251 is capable of capturing VGA (640x480) resolution video at 120 frames per second (fps),
QVGA (320x240) at 180 fps with binning, and
QQVGA (160x120) at 360 fps with binning and skipping

So the flow of these global-shutter from OmniVision is:
OV7750/OV7251 -> OV9282 (and OV9782 for color equivalent) -> ?
So the '?' could already exist... I'm not sure if OmniVision has made the 'next gen' version of the OV9282, but if they have, I would guess that it could do VGA at over 300 FPS.
Since the OV9282 has been out for what seems like forever, I would expect this soon if it's not already out.  It may be out and it could be that my Google skills are not sufficiently strong.  Anyway, here are the sensors for which we theoretically have driver support (but many are untested):

IMX214
IMX283
IMX334
IMX378
IMX477
OV9282
OV9281
OV9782
OV7750/OV7251
IMX412
SC2232H
OV2735
OV5645
IMX390
SC5335
IMX363
SC8238
OV12895

I think I had reviewed them for global shutter capability, but there's a chance I missed one.
Thoughts?
Thanks,
Brandon

As an update, this looks quite doable from the first look. We just need to crank out some critical items (like depth alignment, IMU support, object tracker in Gen2, etc.) and then will be able to implement this. So I'm thinking likely April-ish for this.

I have an Android Device I am trying to interface OV12895 camera drivers, how should I proceed where can I find the C/C++ code and the DTSI file to integrate the Sensor to my android device.
I have forked a AOSP version of the OS to start off with, everything is working so far, just need to integrate this camera


Unhandled rejection

When $mdBottomSheet in app/src/users/components/details/UserDetails.js is dismissed without selecting one of the items Chrome will log a "Possibly unhandled rejection: undefined" error with AngularJS 1.6.x.  The solution is to add:
.catch(angular.noop);

on the end of the callback chain.

Was this on master or one of the branches?

I imagine I pulled master at the time.  I just tried to reproduce this with the master tree (7525f1622d52a938eaf51c5a10953ea9047e031b )I have and did not see the unhandled rejection report in Chrome.  Sorry I can't provide precise information.

OK, great, thank you for the quick response! I think that this has been resolved.

It looks like this might have been in the typescript branch. Fixed there in https://github.com/angular/material-start/commit/7753d5a8e995a26403dd0ce6e9487ac79a931e49.


Prevent dependabot pull requests from running pipelines

Dependabot pull requests clog the pipeline when they are opened. A final pull request with all dependabot updates on the dependabot-upgeades branch should be the only one triggering the pipelines.

This has been achieved by excluding all branches with the prefix 'dependabot/*' from running Azure pipeline.

The dependabot pull requests will no longer trigger the azure pipeline.


[BUG] Methods created in U# and called from non-child blueprints using structs will cause blueprint errors

Repo:
Create these classes and the struct in U#
[UClass]
public partial class UMyGameInstance : UGameInstance
{
    [UFunction(FunctionFlags.BlueprintCallable)]
    public FMyStruct GetData(FMyStruct updatedData)
    {
        updatedData.Counter++;
        updatedData.Name = "NewName";
        return updatedData;
    }
}

[UClass]
public class AMyActor : AActor
{
}

[UStruct]
public struct FMyStruct
{
    [UProperty(PropertyFlags.BlueprintReadWrite)]
    public int Counter;
    [UProperty(PropertyFlags.BlueprintReadWrite)]
    public string Name;
}

Create a blueprint called BP_MyActor that inherits from MyActor
Create a blueprint called BP_MyGameInstance that inherits from MyGameInstance
Fill the blueprints with content seen in the attached images
Compile the C# solution and observe the error highlighted in the second image

LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  My Struct  and  Return Value : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  My Struct  and  Updated Data : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  Updated Data  and  My Struct : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  Return Value  and  My Struct : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Structures don't match for  Break MyStruct
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  My Struct  and  Return Value : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  My Struct  and  Updated Data : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  Updated Data  and  My Struct : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  Return Value  and  My Struct : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Structures don't match for  Break MyStruct

https://github.com/UnrealSharp/UnrealSharp/pull/262 doesn't fix this issue completely, but the behavior changes.
Now it doesn't matter where the method is called from. If it has a struct input, it will fail with the "Can't connect pins..." error. If it only returns a struct, it works without this error. The input struct is defined in the calling BP (using the struct created in U#)

I can confirm from your description that there is still an issue remaining which i have reproduced by now.
A PB defined method using the c# defined struct will produce issues like you described.
Will have a look into it!

The next PR on that topic should also fix this specific issue. Your welcome to try it out.

I tried pr #269, still doesn't solve the issue.
If I manually use File -> Refresh All nodes on each BP, the issue goes away.
See the output log:
Re-instancing MyActorHoldingData_C after reload.
Re-instancing MyActor_C after reload.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  Input Struct  and  Updated Data : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  Updated Data  and  Input Struct : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  Input Struct  and  Input My Struct : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  Target  and  As BP My Game Instance : My Game Instance Object Reference is not compatible with BP My Game Instance Object Reference.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  Target  and  As BP My Game Instance : My Game Instance Object Reference is not compatible with BP My Game Instance Object Reference.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  Input My Struct  and  Input Struct : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  As BP My Game Instance  and  Target : BP My Game Instance Object Reference is not compatible with My Game Instance Object Reference.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Input Struct  of type My Struct Structure doesn't match the property InputStruct of type My Struct Structure
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Input Struct  of type My Struct Structure doesn't match the property InputStruct of type My Struct Structure
Re-instancing MyGameInstance_C after reload.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyGameInstance.uasset: [Compiler] Can't connect pins  Input Struct  and  Input My Struct : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyGameInstance.uasset: [Compiler] Can't connect pins  Input My Struct  and  Input Struct : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyGameInstance.uasset: [Compiler] Input Struct  of type My Struct Structure doesn't match the property InputStruct of type My Struct Structure
Re-instancing DataItem_C after reload.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  Input Struct  and  Updated Data : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  Updated Data  and  Input Struct : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  Input Struct  and  Input My Struct : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Can't connect pins  Input My Struct  and  Input Struct : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Input Struct  of type My Struct Structure doesn't match the property InputStruct of type My Struct Structure
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyActor.uasset: [Compiler] Input Struct  of type My Struct Structure doesn't match the property InputStruct of type My Struct Structure
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyGameInstance.uasset: [Compiler] Can't connect pins  Input Struct  and  Input My Struct : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyGameInstance.uasset: [Compiler] Can't connect pins  Input My Struct  and  Input Struct : Only exactly matching structures are considered compatible.
LogBlueprint: Error: [AssetLog] C:\UnrealTestProjects\UnrealSharpTest\Content\BP_MyGameInstance.uasset: [Compiler] Input Struct  of type My Struct Structure doesn't match the property InputStruct of type My Struct Structure
LogUObjectHash: Compacting FUObjectHashTables data took   0.84ms
Display: Reload/Re-instancing Complete: 4 classes changed, 1 scriptstruct changed

Solved in #269


Associated? arrays munted after compiling

I have the following code...
let arr = {
	logo: [512, 16, 214, 91],
};
console.log(arr.logo);
console.log(arr['logo']);

This code works as expected.
The resulting code using ADVANCED_OPTIMIZATIONS  is...
var a = {
    g: [512, 16, 214, 91],
};
console.log(a.g);
console.log(a.logo);

This code fails because a.logo no longer exists.
It seems to be a bug to me but I'm kind of a noob at JavaScript.

This is working as expected.  "advanced" optimizations are not safe for general JavaScript and require code to conform to its expectations.    The key one here is that "computed" properties are never renamed (along with quoted properties in objects and classes).  This can be used to access dynamically created properties or properties from outside the compilation job that otherwise don't have associated "extern definitions"
So either:
let arr = {
	'logo': [512, 16, 214, 91],
};
console.log(arr['logo']);

or:
let arr = {
	logo: [512, 16, 214, 91],
};
console.log(arr.logo);

If you have further question feel free to post them to stack overflow or the the closure-compiler-discuss@ mailing list.


KAFKA-9726: Add LegacyReplicationPolicy for MM2

This commit adds a new replication policy for MirrorMaker 2, LegacyReplicationPolicy. This policy imitates MirrorMaker 1 behavior of not renaming replicated topics. The exception is made for heartbeats topic, that is replicated according to DefaultReplicationPolicy.
Avoiding renaming topics brings a number of limitations, among which the most important one is the impossibility of detecting replication cycles. This makes cross-replication using LegacyReplicationPolicy effectively impossible. See LegacyReplicationPolicy Javadoc for details.
A new method canTrackSource is added to ReplicationPolicy. Its result indicates if the replication policy can track back to the source topic of a topic. It is needed to allow detecting target topics work when LegacyReplicationPolicy is used.
On the testing side, the tests have the same strategy as for DefaultReplicationPolicy with nicessary adjustments (e.g. no active/active replication is tested).
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ivanyu Can you close this since a new PR has been created that is up to date with the latest trunk?


Error: Building package boost-build:x86-windows failed with: BUILD_FAILED

Package: boost-build:x86-windows
Vcpkg version: 0.0.104-2018-02-07-d503a55412b3fa1b2b96ae0719286ee593f3d732
Starting package 1/111: boost-build:x86-windows
Building package boost-build[core]:x86-windows...
-- CURRENT_INSTALLED_DIR=C:/projects/vcpkg/installed/x86-windows
-- DOWNLOADS=C:/projects/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/projects/vcpkg/packages/boost-build_x86-windows
-- CURRENT_BUILDTREES_DIR=C:/projects/vcpkg/buildtrees/boost-build
-- CURRENT_PORT_DIR=C:/projects/vcpkg/ports/boost-build/.
-- Using cached C:/projects/vcpkg/downloads/boostorg-build-boost-1.66.0.tar.gz
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Extracting done
-- Using cached C:/projects/vcpkg/downloads/boost_LICENSE_1_0.txt
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Using cached C:/projects/vcpkg/downloads/boost-1.66.0-boostcpp.jam
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Bootstrapping...
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:56 (message):
Command failed: C:/projects/vcpkg/packages/boost-build_x86-windows/tools/boost-build/bootstrap.bat;msvc
Working Directory: C:/projects/vcpkg/packages/boost-build_x86-windows/tools/boost-build
See logs for more information:
C:\projects\vcpkg\buildtrees\boost-build\bootstrap-x86-windows-out.log
C:\projects\vcpkg\buildtrees\boost-build\bootstrap-x86-windows-err.log
Call Stack (most recent call first):
ports/boost-build/portfile.cmake:47 (vcpkg_execute_required_process)
scripts/ports.cmake:72 (include)
Error: Building package boost-build:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: boost-build:x86-windows
Vcpkg version: 0.0.104-2018-02-07-d503a55412b3fa1b2b96ae0719286ee593f3d732
Additionally, attach any relevant sections from the log files above.

Hey, can you attach files, please?
C:\projects\vcpkg\buildtrees\boost-build\bootstrap-x86-windows-out.log
C:\projects\vcpkg\buildtrees\boost-build\bootstrap-x86-windows-err.log

I have same error.
bootstrap-x86-windows-err.log
command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000 :cl: command line error D8000  “C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64_x86\cl.exe” Internal compiler error
build\bootstrap-x86-windows-out.log
`Bootstrapping the build engine
Failed to bootstrap the build engine
Please consult bootstrap.log for furter diagnostics.
`

I have the same error, and there're lots of "error D8000" in the bootstrap-x86-windows-err.log.

Hi @Andrey1394 , thanks for posting this issue. It should be fixed now. And I can install it successfully on my machine. Please open a new issue if this is still a problem for you.


user_signed_in? in integration tests

hey there ,
there is no helper method inside integration tests that can tell if the user is logged in or not, I tried searching for a solution in stack-overflow but the only thing I came up with is checking for changes in the layout
I didn't give up on trying to find a better solution that checks the actual session cookie so I won't have to rely on something in the views to verify the user is logged in
I ended up writing my own helper method inside test_helper.rb that uses the warden.authenticated? method but I really think this is
something that should be inside the IntegrationHelpers
anyway this is the method i ended up writing inside my test_helper.rb in case anyone would want it:
def is_logged_in?
  request.env['warden'].authenticated?(:user)
end

Hey!
I don't see much value in having such a method for integration tests, since you're supposed to check if the user actually signed in (e.g., by checking the page content, as you mentioned). If you really need to check the request object, feel free to do it in your own helper method. Thanks!


Lint fixes

Accidentally introduced some linting warnings in https://github.com/cfpb/cfgov-refresh/pull/786
Changes

Fixed key-spacing and max-len warnings in office tests.

Testing

gulp lint

Review

@KimberlyMunoz
@sebworks

:+1:


Firebase SDK enforces -fno-exceptions for whole project

[REQUIRED] Please fill in the following fields:

Pre-built SDK from the website or open-source from this repo: open-source
Firebase C++ SDK version: 6.16.0 (latest at the time of writing)
Problematic Firebase Component: firebase cmake script
Other Firebase Components in use: auth
Platform you are using the C++ SDK on: Mac
Platform you are targeting: desktop

[REQUIRED] Please describe the issue here:
I'm working on integrating the Firebase C++ SDK into an existing CMake project, just adding it via cmake_add_subdirectory
set(OPENSSL_ROOT_DIR /usr/local/opt/openssl)
set(OPENSSL_LIBRARIES /usr/local/opt/openssl/lib)
set(BUILD_TESTING OFF)
set(FIREBASE_INCLUDE_DATABASE OFF)
set(FIREBASE_INCLUDE_FIRESTORE OFF)
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/../../firebase ${CMAKE_CURRENT_BINARY_DIR}/firebase)

and
target_link_libraries(${TARGET} PRIVATE firebase_analytics firebase_app)

Building my target fails due to exceptions being disabled for firebase-app. My project depends on other libraries that are using exceptional C++ code. I think these lines in firebase/app/CMakeLists.txt shouldn't be using the PUBLIC attribute
# Disable exceptions in std
if (MSVC)
  target_compile_options(firebase_app PUBLIC /EHs-c-)
else()
  target_compile_options(firebase_app PUBLIC -fno-exceptions)
endif()

Changing these manually to PRIVATE allows me to compile and link just fine. Is there a reason for these being set to PUBLIC?
Steps to reproduce:
Adding the SDK to a project with exceptional C++ code will make it fail 100% of the time.
If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.
Relevant Code:
See description

Thanks for bringing this up and the suggestion to use PRIVATE instead of PUBLIC. Am following up with the team and will update if this can be done.

Just an update, we are testing if making this dependency Private will affect building and packaging other products as many of them depend on app.

I have workaround to rewrite exceptions option.
add below to parent CMakeLists.txt:
target_compile_options(firebase_app PUBLIC -fexceptions)

@vimanyu Any update on this? I’m running into the same issue, but would like to understand the implications of overriding this a little more. Thanks!

Hi, sorry for not pushing this out earlier and at the time, we were working on migrating our test suite to github. I don't think there should be any side effects of doing this but just to be sure, I am going to test this out on our suite of unit and integration tests, and hopefully push it out in the next release.

This should go out in the next release (8.3.0).
https://github.com/firebase/firebase-cpp-sdk/pull/561


Implemented mass AutoRenew feature, set when bot stops and clear when…

Added ability to automatically switch Active Loans AutoRenew flag when it shuts down and clear the AutoRenew flag when it starts.
Useful if you can't keep the bot running for some reason.
The --clearAutoRenew command line parameter is useful if you want to stop loaning completely.
Both abilities are disabled by default.

Nice feature. But not sure if time.sleep(sleepTime) move is necessary. Now if it ends in error it will rapidly retry.

Oh I understand :) it won't catch a keyboardinterupt exception.

It could be improved. But as it's disabled by default, won't hurt much. Thanks!

Yeah, I rushed a bit to implement it... in 2nd thought it would be better to just have 2 separate commands (either py files or cl params) for setting/clearing autorenew for all loans. I could make the change if it is useful.

Hmm.. and you are right, a sleep is needed also the exception case.


Add Terraform support

Changelog

Add Terraform support
Enable prefer const rule

Closes #26

Coverage remained the same at 100.0% when pulling ae761d2d380d9a21811b6aac9f8de7d58b9a59c5 on 26-terraform-support into 891cf986101c8d4cc5c22e2e542d401feb0192ef on master.


Update test_baseline.py

DESCRIPTION
Here we added two additional assertions to verify that the output contains the strings "Files skipped (0):" and "No issues identified. These two strings indicate that no files were skipped during the scan and no issues were identified, respectively, which are expected when there are no new candidates found compared to the baseline
SEVERITY: Low
Testing before implementation
Test, when there are new candidates, found compared with those in the baseline. This should return the new candidate details along with the candidates from the baseline.
Test when a candidate has a # nosec comment added and that candidate was previously flagged as an issue in the baseline. This should not return that candidate in the results.
Test when a candidate has been fixed in the code and should no longer be flagged as an issue in the baseline. This should not return that candidate in the results.

@rkuczer @Omarosman2000


Update MD file on new branch 2017-18-13_18-11-10

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add npmrc pointing to public registry

Pull Request
🤨 Rationale
Specify the public npm registry in an npmrc file for nimble as discussed in the NI internal npm config doc for public projects.
Should not be an observable change for nimble devs internal or external. Just preemptively avoids future JFrog Artifactor changes from impacting nimble internal devs.
👩💻 Implementation
Add an npmrc file configured for the npm repo.
🧪 Testing
Verified locally that adding new deps did not pull from the JFrog artifactory.
✅ Checklist

[x] I have updated the project documentation to reflect my changes or determined no changes are needed. Shouldn't be observable externally.

 This recently started happening on many PRs with no known cause and we decided to approve the diffs on this simple PR in the hopes of stabilizing the diffs.


Switching from action bar to navigation drawer

The action bar is getting pretty crowded and some of the items (About, Settings, Nearby) should ideally be placed in a navigation drawer instead. This requires a bit of an overhaul, as AFAIK proper navigation drawer implementation would require the activities to be converted to fragments.
I initially started on this (see https://github.com/misaochan/apps-android-commons/tree/nav-drawer-hamburger) but encountered issues that I could not resolve (see http://stackoverflow.com/questions/39010912/actionbardrawertoggle-disappears-when-addtobackstacknull-is-used ).

Did you already do some drawings of how it should look? I think the current Wikipedia app is a good example to aim at. For this app I think we should also leave some space for gamification elements. The elements could be discusses in a seperate thread, but something like number of downloads would be motivating. I also like the concept of streaks (e.g. Duolingo). For this app that could be the count of consecutive weeks/days that the user has uploaded a picture (Not just on mobile, which probably makes it easier to query that from Commons API?).

Haha, no, I don't have any drawings of how it should look - if I tried, it'd probably look worse than it currently does. ;) I think if a reasonably experienced artist were to want to help us out with it, I personally would be happy to leave the choice of style entirely up to them.
I really like the gamification ideas you mentioned. There already is a basic thread at #85 , but it would be great  if you could add your ideas there.

Edit: Oh, I got confused between this and the icons thread. I was initially planning for just a basic material design nav drawer (in black).

I am taking the liberty of marking this as high priority, as I feel that this needs to be handled before too many more new features are added.

@tobias47n9e @misaochan We might want to keep the issue open until the drawer is made theme specific.

This has largely been done, but there are a few issues that need fixing:

Only the main activity, Nearby, About, and Settings should have the hamburger menu icon IMO. The other screens that people will actually want to go back from (the entire upload process, and media detail view) should still have a backbutton IMO.

The hamburger menu icon occasionally disappears from the action bar (e.g. in the main activity after returning from other activities).

We should change the title of the main activity back to "My recent uploads" (currently says "Commons").


Maintenance Status & Proposal for Future Support

New feature motivation
Hi there,
I noticed this repository hasn't been updated in over a year, and I'm wondering if it's still actively maintained. I've attempted a few pull requests but encountered some challenges due to the code complexity (at least me and my teammates having difficulties to work on) and the GitHub Actions workflows involved.
New feature description
I'm part of the Hoverkraft organization, a group dedicated to open-source collaboration between Dev and Ops teams. We've successfully integrated and maintained several open-source actions (such as compose-action) and would love to help support and maintain this action moving forward.
New feature implementation
If there is interest, Hoverkraft could contribute by helping refactor and maintain the code to keep it up to date. We're happy to discuss options or collaborate with any maintainers who may still be active on this project.
Thanks for considering this proposal, and let me know if we can assist!

hi folks have you seen this request ? I would be pleased to see it maintained for my own needs

Hi @Jamie-BitFlight did you had time to consider this proposal?


Feature Request: Analysis Queue

Say you have 5 videos captured and you'd like the tool to analyze them one at a time individually. It would be amazing if you could setup TR drop to simply go through them one at a time with pre-set settings. Thing Adobe Media Queue.

That is a very interesting proposal. The problems I see with it right now is the possibility to analyze up to 3 videos in parallel, so this "option", as well as their order has to be set beforehand. I'm assuming all the settings should be copied over?
Another issue is the naming of the projects, because you'd have to provide a name for each one individually, as well as start exporting automatically after the previous one is finished if I understand correctly.
This would be a very big endeavor, because I currently lack the functionality and the visual representation (think a specific popup window) to have enable this batch processing.
How would you use this feature or why do you want to have it? Just so I can a general idea of the scope and may propose other solutions.

That is a very interesting proposal. The problems I see with it right now is the possibility to analyze up to 3 videos in parallel, so this "option", as well as their order has to be set beforehand. I'm assuming all the settings should be copied over?
Another issue is the naming of the projects, because you'd have to provide a name for each one individually, as well as start exporting automatically after the previous one is finished if I understand correctly.
This would be a very big endeavor, because I currently lack the functionality and the visual representation (think a specific popup window) to have enable this batch processing.
How would you use this feature or why do you want to have it? Just so I can a general idea of the scope and may propose other solutions.

For me I like to analyze PS5, then Xbox Series X, the Xbox Series S and then when editing how I want it to look in premiere I will move the FPS marker, add an appropriate logo (the ability to add an icon would be a nice feature btw)
Sometimes I will run the analysis side-by-side, but I prefer to do that manually in premiere right now.

For me I like to analyze PS5, then Xbox Series X, the Xbox Series S and then when editing how I want it to look in premiere I will move the FPS marker, add an appropriate logo (the ability to add an icon would be a nice feature btw)
Sometimes I will run the analysis side-by-side, but I prefer to do that manually in premiere right now.

So let me understand it better - you want 3 videos from different consoles (probabaly the same game) to be processed with the same settings one after the other?
Do you change the color or is it the same for all of them? Do you remove the framerate plot as well or how do you crop them together in premiere? There should be strange overlaps happening, both with the fps text as well as with the plots if you do it that way.
Can you maybe share a screenshot of a finished video layout in premiere?
The logo stuff might be easy enough to do, but can you maybe provide an example for that as well?

So let me understand it better - you want 3 videos from different consoles (probabaly the same game) to be processed with the same settings one after the other?
Do you change the color or is it the same for all of them? Do you remove the framerate plot as well or how do you crop them together in premiere? There should be strange overlaps happening, both with the fps text as well as with the plots if you do it that way.
Can you maybe share a screenshot of a finished video layout in premiere?
The logo stuff might be easy enough to do, but can you maybe provide an example for that as well?