How to run a jQuery function on successful change/update?

I have a separate function in my $(function(){... } called update_amounts() and I usually call it on "keyup" event on similar forms when I have input fields, but here there are just values that are dynamically changed, so how can I execute this function (so it recalculates the totals in other columns once specific ones are updated via X-editable) on its own, only for specific editable columns?
I can't figure it out, and I'm sure it's super easy...

http://jsfiddle.net/cojad/g24nhx5m/
This is very simple sum calculator demo. Any number change in number1 or sum will update other input so the equation is always updated.
Sum-up:

Use $().editable() "success" option to obtain newValue.
Use $().editable( 'setValue', your_new_value) to change value of x-editable input

That's the thing, I don't want to calculate anything within x-editable - I have an outside function that, when run, does calculations based on 3 x-editable fields and updates 6 other unrelated, non-x-editable fields as well (and I don't want to replicate its functionality within x-editable). I am just trying to run it, as in function_name(); on successful update of either one of these 3 x-editable fields and I can't figure out how...

http://jsfiddle.net/cojad/csnoLqfb/1/
The only thing important is that you have to pass newValue to your function because by the time event "save" happen, the x-editable's value isn't updated yet. so you have to access the newValue with params.newValue.
The rest of x-editable's value which was not changed by user at that time can be safely access with method $().editable( 'getValue', true)

Hmm.. I can't even figure out how to run a simple jQuery line on successful update.
Here is what I have so far, as an example:
    $('.order_status').editable({
        type: 'select',
        url: 'post-orders.php',
        title: 'Approve / Cancel',
        placement: 'right',
        value: "",
        emptytext: '...',
        source: [
            {value: "Cancelled", text: "Cancel"},
            {value: "Processing", text: "Processing"},
            {value: "Approved", text: "Approve"},
            {value: "Sent", text: "Sent"},
        ],
        success: function(response) {
            console.log(response);
            var res = response.split(":");
            var status = res[0];
            var id = res[1];
            if(status == "Sent" || status == "Cancelled"){
                $("tr#"+id).hide();
            }
        }

and the response is coming in as "Status:XX" where XX is the ID of the order, and it's assigned to the  as an ID as well, hence why I try to use the $(tr#id).hide() above.
But it's not doing anything. And I don't know how to troubleshoot it or what I'm missing above.

My next question is kinda related to this one too -> https://github.com/vitalets/x-editable/issues/790


Feature Request: Emoji Support

A lot of editors now a days have emoji support. Not sure if this is something we'd want to add or not but it could at least be a good plugin to create once the plugin system has been implemented.

http://emojione.com - looks like a good option. Not only does it provide all the art files under Creative Commons, but the provided JS toolkit easily converts back and forth between Unicode representation, shortname and image.
This would however require:
<script src="https://cdn.jsdelivr.net/emojione/2.2.7/lib/js/emojione.min.js"></script>
<link rel="stylesheet" href="https://cdn.jsdelivr.net/emojione/2.2.7/assets/css/emojione.min.css"/>

to be added to any page in which the editor needs emoji support.
Perhaps one day we'll have a require directive for Javascript


Add additional unit tests to cron_test.go

Adds tests for:

Adding an invalid spec
Verify that running Start() twice is a no-op
Test the blocking Run() function

Since there is no mutex on the running flag, it may still be possible to trigger run() twice. Is this a concern? Or should concurrency be the responsibility of the caller?

Thanks! I think the docs specify that the caller has to arrange for a happens-before relationship when launching the cron


Request for Dataset Statistics: CIFAR100 and Tiny-ImageNet

Dear Authors,
Thanks for your excellent work. I've noted the statistics for CIFAR10 in ./stats/cifar10.train.npz. Would it be feasible for you also to release the statistics for CIFAR100 and Tiny-ImageNet?
Thank you for your time and consideration.

Thanks for your interest.
We didn't calculate the statistics for CIFAR100 or TinyImageNet. The CIFAR10 statistics are originally from pytorch-ddpm. Please refer to https://github.com/w86763777/pytorch-ddpm/blob/master/score/fid.py for calculating statistics.


[SPARK-39268][SQL][WIP] AttachDistributedSequenceExec do not checkpoint childRDD with single partition

What changes were proposed in this pull request?
do not checkpoint child rdd when it only has 1 partition
Why are the changes needed?
avoid necessary checkpoint
when child rdd only has 1 partition, zipWithIndex will not trigger an action
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing suites

There might be some test failure to fix but I think this fix itself should work.

The failed test seem weird to me, I need a lit more time to debug

Merged to master


Revert content duplication for caching fix

This reverts commit 07c4bbb6f3c051c012a2613b6345782a74bbefe2.
reverts the last commit from https://github.com/microsoft/pxt-arcade/pull/1013, which duplicated all files moved to avoid caching errors. This removes the old files that have been moved.
All caches should be invalided now, so this is good to go whenever

Use draft PR next time...

It's probably ready to be merged by now.


Global variable error.

Challenge Global vs Local Scope in Functions has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.103 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
I did not change the global variable but the program  thinks I did.
My code:
// Setup
var outerWear = "T-Shirt";

function myFunction() {
  // Only change code below this line

  outerWear="sweater";

  // Only change code above this line
  return outerWear;
}

myFunction();

Yup Confirmed.

Sorry, my bad.
@rkingkeo Your code actually is incorrect:
// Setup
var outerWear = "T-Shirt";

function myFunction() {
  // Only change code below this line

  outerWear="sweater";  // <<<<--------------------- this should be: var outerWear="sweater";

  // Only change code above this line
  return outerWear;
}

myFunction();

Please have a look at the example code, in the instruction.
You can further queries at Help Chat.

Thank you. It might have just been the computer I was working on.
On Mon, Feb 8, 2016 at 1:45 PM, Mrugesh Mohapatra<EMAIL_ADDRESS>wrote:

Sorry, my bad.
@rkingkeo https://github.com/rkingkeo Your code actually is incorrect:
// Setupvar outerWear = "T-Shirt";
function myFunction() {
// Only change code below this line
outerWear="sweater";  // <<<<--------------------- this should be: var outerWear="sweater";
// Only change code above this line
return outerWear;
}
myFunction();
Please have a look at the example code, in the instruction.
You can further queries at Help Chat https://gitter.im/FreeCodeCamp/Help
.
—
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/6830#issuecomment-181487682
.

--
Sam Kingkeo

Why is the Test is successful even without a semicolon for local variable ?

@praneethkumarpidugu JavaScript (and libraries like jQuery) can run without semicolons thanks to a language feature called Automatic Semicolon Insertion. However I think FCC have chosen to teach all campers to use a consistent code-style. The reason is probably to simplify the learning and let new developers focus on the fundamentals, not details like if they should use semicolons or not.
If you want more information, there's some great videos on YouTube if you search for "semicolons JavaScript". I personally don't use semicolons in my own projects since the last month, but I'm contexts like FCC I try to follow their style guides.
Hope this helped! :)


Atom default font does not look the same on Linux as on Windows and Mac

I just cloned the latest version of Atom after being away for a few weeks and I noticed that the font rendering looked a bit weird.
On Mac OS X, I found that the font Atom was using was (very close to if not the same as) Inconsolata, Monaco, Consolas, 'Courier New', Courier and when I entered that for the font style on Linux, I got a rockwell looking font which has the following CSS Rockwell, "Courier Bold", Courier, Georgia, Times, "Times New Roman", serif.
Here is a screenshot of the font on Linux in the settings (which appears to be the same as on Mac and Windows)

and here is the font rendered in the editor itself which looks completely different

@alexandernst yes Liberation Mono is a nice font, thanks :)

linux@linux-desktop:~$ fc-match "liberation mono"
LiberationMono-Regular.ttf: "Liberation Mono" "Regular"
linux@linux-desktop:~$ lsof | grep -i liberation


Can't create output model + plots (pytorch)

Hi,
I'm running the benchmark (./bench/dlrm_s_criteo_kaggle.sh) with the smaller dataset
I added to the command the --save-model=./output/model.pt and --memory-map flags
by using the memory map i was able to actually load the data, and I think the training was successful as I saw the following output:
Finished training it 297984/306969 of epoch 0, 41.97 ms/it, loss 0.449257, accuracy 79.112 %
Finished training it 299008/306969 of epoch 0, 41.55 ms/it, loss 0.446398, accuracy 79.331 %
Finished training it 300032/306969 of epoch 0, 42.07 ms/it, loss 0.448324, accuracy 79.166 %
Finished training it 301056/306969 of epoch 0, 41.56 ms/it, loss 0.447720, accuracy 79.162 %
Finished training it 302080/306969 of epoch 0, 41.75 ms/it, loss 0.443990, accuracy 79.356 %
Finished training it 303104/306969 of epoch 0, 41.58 ms/it, loss 0.445195, accuracy 79.299 %
Finished training it 304128/306969 of epoch 0, 41.76 ms/it, loss 0.448235, accuracy 79.118 %
Finished training it 305152/306969 of epoch 0, 41.64 ms/it, loss 0.447002, accuracy 79.177 %
Finished training it 306176/306969 of epoch 0, 41.81 ms/it, loss 0.446282, accuracy 79.279 %
Finished training it 306969/306969 of epoch 0, 41.33 ms/it, loss 0.445721, accuracy 79.342 %

A few points that I couldn't understand:

I see many filed that with .npz extension in my folder but I don't see the file name that is passed in the benchmark script ./input/kaggleAdDisplayChallenge_processed.npz
save model doesn't save anything to the output folder
How can I generate the plots from the benchmark?
What is the recommended hardware for training on the kaggle ad dataset? I'm using a machine with 64 cpu cores and it took about 5 hours

Any help will be greatly appreciated!

Let me answer your questions below:

If you use --memory-map the final pre-processed dataset is broken into multiple files (e.g. *_reordered.npz) rather than being packaged into a a single file (e.g. kaggleAdDisplayChallenge_processed.npz).

Please add a testing frequency flag, which will determine when the model is saved. So your command line would be something like

./bench/dlrm_s_criteo_kaggle.sh "--test-freq=20000 --save-model=./output/model.pt --memory-map"

What plots would you like to generate? If you are trying to reproduce the convergence plots on the webpage, you can preprocess the output log using Python or simply upload it into Excel spreadsheet and use "text to columns" function with data split by spaces.

We do not recommend a particular system. However, as a reference I wanted to mention that if we run on a system with a single GPU (V100), it typically takes around 1 hour for training (without testing) to finish with default parameters.

I'm assuming this is resolved. Closing.

Please add a testing frequency flag, which will determine when the model is saved. So your command line would be something like

./bench/dlrm_s_criteo_kaggle.sh "--test-freq=20000 --save-model=./output/model.pt --memory-map"

When --test-freq is added to the command line it still won't save the model unless the accuracy has increased, yes? As a result, when running on random data the model will never be saved since accuracy is always zero?
--

Technically you are correct, the accuracy needs to increase above 0 at least once for the model to be saved. However, I would expect a model to correctly predict at least a few items even on random data (following a saying that even a broken clock is right twice a day). Nonetheless, if you really want to force the model to be written out you can always adjust the if is_best: statement on line 1083 in dlrm_s_pytorch.py

Thank you so much for the quick response. What you say should technically happen but in practice, the accuracy remains always zero so no model is saved. My next question is then does it make sense to do inference using random data without a saved model? Just for profiling purposes.

If you run inference using the --inference-only flag, without providing the previously saved model, then the code will simply create the model with random values for its weights. I would say that if you are looking at system performance that should be fine. Perhaps a more important aspect that influences performance is the distribution of input indices, rather than the values of the weights.


Update realtime consumers on index config upload

Update the realtime consumer configuration for HLC and LLC on index
configuration upload, to ensure that the proper structure for each
consumer type is present when adding/removing a consumer type.

This is not complete, it's missing cleanup when removing a consumer type (eg. remove HLC segments when removing the HLC consumer type) and doesn't support adding HLC to an existing LLC table.


Feature/adapt to rollups 1.2.0

TODO:

[x] stop using volume for /deployments/$network/dapp.json with --dapp-deployment-file and get values.yaml using specific parameters;
[x] stop using volume for /opt/cartesi/share/deployments/$network.json and --rollups-deployment-file  and get from values.yaml using specific parameters;
- [ ] clean redis streams by default using an entrypoint for rollups-dispatcher container

When I want to deploy the chart in sepolia the dispatcher and authority server crashed.
Error: BlockchainError { source: JsonReadError { path: "/opt/cartesi/share/deployments/sepolia.json", source: Error("missing field `History`", line: 1200, column: 3) } }

Let's just update the Readme

Can you send a PR?


Form Actions Cause cookies.set error in SvelteKit

Bug report

[X ] I confirm this is a bug with Supabase, not with my own application.
[ ] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
The app breaks when trying to update a form action item in supabase.
To Reproduce
I installed auth-helpers-sveltekit with no problems, works in other modules with session correctly.
Expected behavior
I simply add a form action like so:
+page.server.ts
export const actions = {

  updateProfile: async ({ locals: { supabase } }) => {

    supabase.auth.updateUser({ data: {
      full_name: 'some name here'
    }});

  }

} satisfies Actions;

+page.svelte
<form method="POST" action="?/updateProfile">
  <button type="submit">Update</button>
</form>

System information

OS: Windows 11
Browser Chrome
Version of supabase-js: 2.21
Version of auth-helpers-sveltekit: 0.9.4
Version of Node.js: 18.13

/node_modules/@sveltejs/kit/src/runtime/server/respond.js:425
                                throw new Error('Cannot use `cookies.set(...)` after the response has been generated');
                                      ^

Error: Cannot use `cookies.set(...)` after the response has been generated
    at event.cookies.set (/node_modules/@sveltejs/kit/src/runtime/server/respond.js:425:11)
    at Object.setItem (file:///C:/web%20projects/code-build-new/node_modules/@supabase/auth-helpers-sveltekit/dist/index.js:152:15)
    at C:\web projects\code-build-new\node_modules\@supabase\gotrue-js\dist\main\lib\helpers.js:128:19
    at Generator.next (<anonymous>)
    at C:\web projects\code-build-new\node_modules\@supabase\gotrue-js\dist\main\lib\helpers.js:31:71
    at new Promise (<anonymous>)
    at __awaiter (C:\web projects\code-build-new\node_modules\@supabase\gotrue-js\dist\main\lib\helpers.js:27:12)
    at setItemAsync (C:\web projects\code-build-new\node_modules\@supabase\gotrue-js\dist\main\lib\helpers.js:127:46)
    at SupabaseAuthClient._persistSession (C:\web projects\code-build-new\node_modules\@supabase\gotrue-js\dist\main\GoTrueClient.js:1058:43)
    at SupabaseAuthClient.<anonymous> (C:\web projects\code-build-new\node_modules\@supabase\gotrue-js\dist\main\GoTrueClient.js:1053:28)

Related to https://github.com/supabase/auth-helpers/issues/466
J

You will need to produce a minimal reproducible example of this as I have this working in multiple apps without this issue. You can have a look at one here https://github.com/supabase-community/supabase-by-example/blob/main/user-profile/sveltekit/src/routes/(app)/account/update-email/%2Bpage.server.ts

You need to await the call so sveltekit waits before generating a response.
export const actions = {

  updateProfile: async ({ locals: { supabase } }) => {

    await supabase.auth.updateUser({ data: {
      full_name: 'some name here'
    }});

  }

} satisfies Actions;

Yup, it was not having await that was the problem. Thanks guys.


Create a unit test for resetting of lvol content

When a new lvol is created we should make sure that any previous content is gone by writing zeros to it (could be unmap on devices which support it). Not doing so can result in issues with using stale filesystem which existed on a previous lvol and is a security problem in general. We should have a unit test which verifies that.

Closing due to inactivity.


Make the game work?

im rewriting the entire game for the best security. So this is here till i get it to basically work

The game now saves to the server and restores points. Purchase from the site does not work yet but the game is usable


Fix "module with extension is not loaded (SwiftUIIntrospect)" build error

Fixes #90.

Thank you, brother. That fixed the problem. I wish you all the best. This is a useful component, and I hope you create something similar for the lists so we can animate the cells the same way as they appear.


Proposal: Cross-Platform CLI Tool for the Agent Protocol

Objective:
This proposal outlines the development of a cross-platform CLI tool aimed at simplifying interactions with the Agent Protocol. The goal is to improve user experience, streamline debugging, and facilitate automation within the agent protocol ecosystem.
Background:
The Agent Protocol involves managing tasks, steps, and artifacts, all identified by UUIDs (v4). Tasks represent high-level commands for agents, steps denote individual actions taken by agents, and artifacts correspond to files generated or used during agent operations. This proposal aims to create a user-friendly CLI application inspired by the ease of use of Docker's command-line interface.
Proposed CLI Commands:
To provide a clear vision for this tool, we propose the following CLI commands and their expected functionalities:

ap-cli connect [endpoint] - Connects to the specified agent endpoint.

Example: $ ap-cli connect http://localhost:8000

ap-cli task list - Lists tasks with their full UUIDs.

The response to this command (for tasks, steps, and artifacts alike) could be formatted in JSON (as the original API, to be sent to jq for scripting or etc.) or as a formatted table.

ap-cli task create [options] - Creates a new task.

Example: $ ap-cli task create

ap-cli task [task_uuid] step create --input="[input]" - Creates a new step within a task.

Example: $ ap-cli task 70e62fbb-0123-4567-89ab-cdef01234567 step create --input="Write 'Washington' to a file."

ap-cli task [task_uuid] artifact list - Lists artifacts associated with a task.

Example: $ ap-cli task 70e62fbb-0123-4567-89ab-cdef01234567 artifact list

Note: If multi-agent usage becomes a necessity, the agent name from the (not yet implemented) info endpoint could be used for individual calls.
Example:
$ ap-cli connect http://localhost:8000
> Connected to MyAgent

$ ap-cli connect http://localhost:8001
> Connected to NotMyAgent

$ ap-cli MyAgent task list

Goals of the CLI Tool:

Enhance user experience with an intuitive CLI interface.
Simplify debugging and monitoring of agent tasks and steps.
Enable automation of agent protocol interactions for CI/CD workflows.
Facilitate agent protocol compliance verification and testing.

Discussion Points:
This proposal serves as a technical framework for the CLI tool's development. Your input is essential to refine the design and functionality. Please share your thoughts on the proposed commands, suggest additional features or improvements, and highlight any potential challenges or considerations.
Let's collaborate to create a powerful and user-centric CLI tool that enhances the usability and effectiveness of the Agent Protocol.

@jzanecook for the 3rd command, what [option] can our users use?

Okay, I saw your PR: https://github.com/AI-Engineer-Foundation/agent-protocol/pull/76. I will check that one.

The options for the create command are whatever the options are in the spec, so input and additional_input for task/step and then for artifact it's that schema.
I have the structure of the commands/args pretty well set in the PR, it just needs to be refactored a bit and linked with the OpenAPI generated functions.


Getting rid of black background for the spinner

Hi
I am liking this library a lot but one thing. I wonder whether there is a way to get rid of black background on the spinner. I am using this library for my video player and whenever there is a video with white background, I see black spot due to black background of the spinner.
Any advises will be appreciated!

in draw rect function
add
CGContextSetRGBFillColor(context, xxx/255, xxx/255, xxx/255, 0.8);

The bezelView can now be directly accessed and customized.


Command Line Interface - Discussion

An issue to track discussion regarding the disign and implementation of notsotufs CLI.

On thing to keep in mind is that notsotuf just creates a standard python-tuf  repository.
We only provide some basic convenience methods and shortcuts on top of tuf. We do not touch the metadata nor do we modify the mechanics of the underlying tuf repository.
This implies that the repo tools from python-tuf, as well as any CLI tools that are (to be) developed for python-tuf, should also work for notsotuf.

true. But what I saw the cli do would be something like the following

Generate and store keys
Sign packages and handling metadata
moving files into the right places, so you could have something else just go "upload repo to server"

That's basically what the scripts in notsotuf-example do:
There's an init_repo.py and an add_target_to_repo.py, which I intend to be the basis for a CLI. Currently I am still just using them to try out different workflow implementations.
I just made the notsotuf-example repo publicly visible, and it is still very much a work in progress. I still need to adapt it to the latest version of notsotuf. The content is similar to the smaller examples in the notsotuf/examples folder.
This project illustrates what an actual application could look like, using both pyinstaller and notsotuf.
This also has to do with issue #8.

@dennisvang  had a chance to look at dennisvang/notsotuf-example and had the following comments in regards to the cli tool.

I saw that we had "init_repo.py" and "add_target_to_repo.py", which I think is a perfect example and gives us a good scope for what should be included in the cli

From that, I would say we could have the following commands.
notsotuf of course being the root command.

init (generate a setting file or something, where you can set paths for where to store stuff. We should have defaults for this)
key add/remove key pairs (with has like add role keypath encrypted)
artifact/target (or whatever we call an application tarball) path version (should add the target, create patch)
sign (don't know if this should be a separate command, might be a good idea, considering multiple workers (Windows and MacOS in a CD environment, writing to the repository to save the new versions in the metadata)

I know you said that uploading to a 3rd party server is out of scope, so haven't included this on purpose.
Looking forward to hearing your thoughts @dennisvang

See issue9 branch for an initial attempt.

Using main.py to call a package is old behaviour.
This can be done through pyproject.toml, so we can name the file and function whatever we like.
See example here https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html
I propose we change the name to cli.py so it becomes notsotuf.client:main and then move the cli specific code from init.py
I'll comment more, when the pr has been create, so I can comment on specific things.

@NicklasTegner

Using main.py to call a package is old behaviour.

As far as I know, main.py is still needed in order to support calling the package directly, as in python -m notsotuf. If you  try this call without main.py, you'll get No module named notsotuf.__main__; 'notsotuf' is a package and cannot be directly executed
In addition, an entry point is already defined in setup.cfg, so pip creates a script allowing us to call notsotuf ... directly from the command line.
So, users can call either  python -m notsotuf ... or notsotuf ... from the command line.

This can be done through pyproject.toml, so we can name the file and function whatever we like.
See example here https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html

As noted in the setup.py file, my plan for the future is to get rid of both setup.cfg and setup.py and only use pyproject.toml.
However, the project configuration via pyproject.toml is still marked "experimental." As long as that is the case, I wanted to stick to setup.cfg.

I propose we change the name to cli.py so it becomes notsotuf.client:main and then move the cli specific code from init.py

As for the name, I'm planning to convert the repo.py module to a package and put a cli.py in there, as the cli is only intended for the repo side.

To get on with things, I merged PR #15, so we now have a rudimentary CLI.
Some features left to do:

add proper command line feedback
add documentation
add command to set thresholds

... added some command line feedback in pr #19

@NicklasTegner Added some basic CLI functionality that looks reasonably usable to me.
Perhaps you could give it a try and let me know what you think?
Examples
Initialize repository by answering some questions on the command line. This creates key pairs and adds them to root:
notsotuf init

Add a new app version from some my/dist/ folder, sign using keys from some my/private/keys folder:
notsotuf targets add 1.0.1 my/dist my/private/keys

Create a new key pair with encrypted private key, and use this to replace an existing key:
notsotuf keys name_of_my_new_key -c -e replace name_of_my_old_key my/private/keys

Update snapshot expiration date to 2 days from now, and re-sign, show debug information:
notsotuf sign -d -e 2 snapshot my/private/keys

So I've only test the init command so far and I have the following:
We need sensible defaults. Like most of the places where it says "none" you can't actually answer nothing. And most the questions you don't actually know what mean, unless you know the inner workings of nst or tuf itself.

@NicklasTegner Thanks for the quick response. Those are some good points. :)

I'll set some defaults where possible, and provide examples otherwise.
The cli is still undocumented, but I'm planning to add some explanations regarding the init questions.

I do think it is imperative to understand the basics of TUF in order to use notsotuf properly.
We could add a kind of summary to the documentation, e.g. something along these lines:

TUF specifies 4 top-level roles: root, targets, snapshot, timestamp (see below)
each role has its own "metadata file" in the repository, e.g. root.json
metadata for each role must be signed after each modification, using one or more private keys, which may be encrypted with password
metadata for each role has an expiration date, after which it needs to be re-signed
metadata for each role has a version which is incremented after each change (this is done automatically by notsotuf)

Description of top-level roles (see TUF docs for details and reasoning):

root

defines known keys
assigns keys to roles (including root itself)
specifies how many signatures are required for each role  (number of signatures >= threshold)
modified when keys are added/removed (which should be rare), or upon expiry

targets

defines known files, i.e. in our case the archive files and patch files that are available for download
modified whenever a new app version is released, or upon expiry

snapshot

defines which version of targets metadata is currently valid
modified whenever targets role changes, or upon expiry

timestamp

defines which version snapshot metadata is currently valid
modified whenever snapshot changes, or upon expiry (typically every day)

Although it is not recommended, notsotuf allows the use of a single key for multiple roles.


Address #96

Add hindi translations for README.md in README.hi.md. Please review.

@namanpreetsingh, Awesome work. Can I reach out to you for reviews for any future changes to this tutorial? ( I do understand Hindi but I'd prefer to go to an expert)
I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.
I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com

@Roshanjossey Sure, I'd love to help anytime.
This tutorial is amazing yet simple. It is easy to understand and whole process was clearly explained. :) But one thing :stuck_out_tongue: I still didn't get to know that if my changes have been merged or not. :stuck_out_tongue_winking_eye:

@namanpreetsingh, It was not merged yet. Now I'm merging.


Add (header, payload) parameters to SqPlayer.TrackPosition.

Syntax: SqPlayer.TrackPosition(number_of_position_changes, header, payload);
Event: PlayerPosition(player, header, payload);
Example of usage:
player.TrackPosition(1, 1, "cmd_heal");
function onPlayerPosition(player, header, payload)
{
if(payload == "cmd_heal") player.Message("Healing failed.");
 }

Added the method except it's named SetTrackPosition(number_of_position_changes, header, payload) to not interfere with the name of the property which ignores the header/payload.
Also, the that header and payload will be sent continuously. So you should not expect that the next time the event is called that header/payload is 0/null but instead what you passed initially.


ENH Load CSV files from different dialects

This PR exposes some parameters of pyspark's CSV reader: sep, escape and multiLine, up to session.load_data.
This enables to load files in various dialects of CSV.

@gmichalo thanks, I've changed the base branch and resolved the conflicts.
Let me know if you have any other request !


D430 Exposure Time Behaviour USB 2.0 vs USB 3.0

Required Info

Camera Model
D430

Firmware Version
5.11.01

Operating System & Version
Raspbian

Kernel Version (Linux Only)
4.16.*

Platform
Raspberry Pi

SDK Version
2.18.1

Language
C++

Segment
others

Issue Description
Setting exposure time to 1000us, and 1280x720@6fps and taking photos on USB 2.0 and USB 3.0 yields different results. USB 3.0 shows the intended effect whereby motion blur is largely eliminated.
On USB 2.0

On USB 3.0

When the exposure time is set to 173us on USB 2.0 this happens:

Setting the camera to Auto-Exposure while on USB 2.0 yields slightly better results but is very unusable for our purposes.

As suspected, the camera works fine when taking at 640x480@30 fps. The increase in fps seems to have done something...

We noticed a similar effect on the D410, whereby increasing the FPS (through accepting lower resolution) significantly reduced the effect of rolling shutter. We suspected that a lower fps somehow caused the camera to have greater delay between reading each row.
We had thought that getting the D430 would eliminate that problem due to the global shutter, but it introduces a different problem of motion blur...

Hi
Blurry image is always visible if exposure time is too long, no matter the imager is global shutter or rolling shutter. One of the advantages of global shutter is that it is better than rolling shutter in terms of distortion on moving object. With that being said, you should see similar blur effect if imager was set at same exposure time.
Higher frame rate means the maximum exposure time is shorter than lower frame rate. For example, the maximum exposure time is 33ms under 30FPS, 66ms under 15FPS ....
The exposure time 173us as you mentioned for 640x480@30fps doesn't seem to be correct to me - it shouldn't be so bright. I guess you might have set it to 173ms, but that will make camera frame rate drop to <6fps.
Under manual exposure mode, if the image still looks dark, can you try increase the Gain (try 64, 128, 248 max)? (NOTE: more gain, more noise)
Thanks

Hi
Thank you for your reply.
The camera was at 1000us while tested during 640x480@30fps, not 173us.
The issue isn't related to exposure time nor gain, the issue is related to the camera behaving differently when used with a USB 2.0 connection relative to USB 3.0 under the same resolution, framerate and exposure settings.
USB 2.0 yields incorrect results (e.g. reducing exposure time does not reduce motion blur), while USB 3.0 yields correct results (e.g. reducing exposure time reduces motion blur).
The really bright image has an exposure time of 173us, the camera behaves like that when used with USB 2.0, but not with USB 3.0. Setting it with 174us on USB 2.0 yields semi-expected behaviour (image becomes very dark, but motion blur is still very strong).
Please advise,
Thank you

Hi
That's the trade-off between USB2 bandwidth vs imager performance.
Due to USB2 bandwidth limitation, the imager data readout time has to be extended 4x as compared under USB3. Since global shutter imager requires fast readout to ensure the shutter performance. Longer readout time causes lower shutter efficiency. That's why under USB2, you see the "ghost tail" effect.
Thanks

That makes sense, It'd be nice to formally document all the limitations that the USB 2.0 interface has, it would've saved time and money.
Thank you for your reply.


Retain fact code in files even when not checking on load

When running something like eastwood to lint test files, it's nice to be
able to not also run tests while linting.  Unfortunately setting
include-midje-checks to false means the test code that's meant to be
linted macro-expands to nil, so this patch puts the expanded code into a
defn where it won't be run but can still be linted.

Ping?

Sorry. I blame: conference + vacation + quitting my job + laptop&TimeMachine failure. Plus sloth.
Deployed as 1.9.0-alpha3


Fix org.

Remove activatedgeek; looks like he might have changed his GitHub id.
So we'll have to add him again.

This change is

/assign @abhi-g

Ok.
/lgtm
/approve


Error formatting python documents

This issue has been moved from a ticket on Developer Community.

[severity:It's more difficult to complete my work] [regression]
When working on a python document, I can no longer format the document, either through the keyboard shortcut or the menus.
It comes up with an error dialog saying 'A task was cancelled'.

Original Comments
Feedback Bot on 11/21/2022, 10:09 PM:
(private comment, text removed)

Original Solutions
(no solutions)

Image from feedback ticket

Going to close this out. If the issue still persists, please reopen with the information requested. Thanks.😊


Could not find d.ts file

mock-async-storage: 2.2.0
typescript: 3.8.3

Sorry, I forgot to add that types are not under the DefinitelyTyped repository either
$ npm install -D @types/mock-async-storage
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@types%2fmock-async-storage - Not found
npm ERR! 404
npm ERR! 404  '@types/mock-async-storage@latest' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

Hi, sorry i know i'm a bit late. I recently modernized the package. Now the ts definitions are included as well in the package.


[dart:mirrors] isSubclassOf not correctly migrated to NNBD

Code:
import 'dart:mirrors';

void main(){

  final stringMirror = reflect("").type;
  final objectMirror = reflect(Object()).type;

  objectMirror.isSubclassOf(stringMirror);

}

Expectations:
This runs without exceptions on projects that are migrated to NNBD.
Actual Behaviour:
throws
Unhandled exception:
type 'Null' is not a subtype of type 'ClassMirror' in type cast
#0      _ClassMirror.isSubclassOf (dart:mirrors-patch/mirrors_impl.dart:710:24)
#1      main (file:///Users/kami/development/mockoccino/test/subtype_test.dart:10:16)
#2      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:311:19)
#3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

Version:
dart --version
Dart SDK version: 2.12.0-29.10.beta (beta) (Tue Nov 17 10:50:22 2020 +0100) on "macos_x64"

It seems that this is also not fixed on master, though:
See https://github.com/dart-lang/sdk/blob/ea50b03cbee9971a3e3f1cc5c832fc2dfb941654/sdk/lib/_internal/vm/lib/mirrors_impl.dart#L710
The issue is the cast c.superclass as ClassMirror which throws if c.superclass is null (for Object).
bool isSubclassOf(ClassMirror other) {
    // TODO: Remove these null checks once all code is opted into strong nonnullable mode.
    if (other == null) {
      throw new ArgumentError.notNull('other');
    }
    ClassMirror otherDeclaration = other.originalDeclaration as ClassMirror;
    ClassMirror /*THIS SHOULD BE 'ClassMirror?' */ c = this;
    while (c != null) {
      c = c.originalDeclaration as ClassMirror;
      if (c == otherDeclaration) return true;
      c = c.superclass as ClassMirror /*THIS SHOULD BE 'as ClassMirror?' */;
    }
    return false;
  }

There's still a TODO indicating that the code hasn't been migrated to NNBD yet, but the other code in that file already uses nullable and non-nullable types. Since NNBD is now in beta, in my understanding all core dart:xxx libraries should work with NNBD as of now, is that correct?

I opened https://dart-review.googlesource.com/c/sdk/+/173900 to add the nullability suffix you suggested. That does fix the problem, but I don't know how this ever worked considering that there are migrated tests for this?

That does fix the problem, but I don't know how this ever worked considering that there are migrated tests for this?

Well, it did not. These tests are failing, e.g. https://dart-ci.appspot.com/log/any/dartk-strong-linux-release-x64/3084/lib/mirrors/relation_subclass_test, on all strong mode (sound nullability) configurations.
dart:mirrors library unfortunately is not maintained and it might end up being marked as deprecated and slated for removal any time now. Though decision is not made yet - leaving library hanging in the limbo state for now.

dart:mirrors library unfortunately is not maintained and it might end up being marked as deprecated and slated for removal any time now. Though decision is not made yet - leaving library hanging in the limbo state for now.

Good to know, I just started looking into a mirrors-based approach for making Mockito work as it did before sound nullability. But I think I'll quit doing that now - I noticed a few other quirks/missing features with null safety in mirros.

It looks like this can be closed now (thanks taking care of my CL @mraleph), but it would be nice to have some kind of warning that a core dart: library is essentially unmaintained.

but it would be nice to have some kind of warning that a core dart: library is essentially unmaintained.

Yeah, we are going to do that. I have pinged relevant folks - we need to assess impact and figure out clear migration path for users that depend on dart:mirrors currently.
Fixed by @simolus3 in 9818a0cc9340102afc4e46c8bcddffe7010a32e0

but it would be nice to have some kind of warning that a core dart: library is essentially unmaintained.

Yeah, we are going to do that. I have pinged relevant folks - we need to assess impact and figure out clear migration path for users that depend on dart:mirrors currently.
Fixed by @simolus3 in 9818a0c

I really want to know (from anyone with more experience than me), is that possible to "fix"Mockito with dart Mirrors? Considering that it will not be deprecated. If not, what other options we have then (if any)?

@pedromassango I spent a few hours yesterday on that and got promising results, even without runtime code generation.
I tried writing a createInstance(Type t); method that tries to create an instance from the given type.
It worked by looking up constructors of the class and trying to create an instance by looking up the constructors of the class and its subtypes and recursively calling createInstance() for the parameter types of the constructors until one of the constructors succeed.
By using a few heuristics (prefer empty constructors, and constructors with only primitive types) and fast paths for primitive types and known container types like Iterable (just return an empty iterable), Future (return a Future.error), Stream (return an empty stream...), I got it working pretty well.
Although there are probably a lot of edge cases (recursive classes like Trees, constructors that do a lot of custom validation on their parameters) where Mockito would need some additional hints from the user of the library to work.
And unfortunately, mirrors is missing some generics-related features that make it more difficult to support custom container-types (like Option for example) and some other quirks where dart:mirrors does not behave as expected with null safety.
So, is it possible to "fix" Mockito with mirrors with my approach? Not in the general case. But it would probably be possible to make it work for like 95% of the normal use cases and provide the user with some way to workaround this for the rest.
I don't know if it's worth it though. The user experience on the cases where that approach fails would probably be pretty bad (and intransparent, many users probably wouldn't know why it failed) and it would not be fun to support this library on GitHub ;).
And the performance wouldn't be great, since it iterating over ALL classes when a given is abstract and does not have a delegating constructor to find a suitable subtype that can create an instance of that given type.

@knaeckeKami when you say "fix" Mockito, are you saying that Mockito's null safety approach of using codegen is the thing that is broken?

I would not call it broken, we were just looking into alternatives to codegen to keep the current API even with Nullsafety and to keep Mockito as frictionless to use as it is now.
But given the current state of dart:mirrors I gave up on this for now. Codegen is not that bad anyway ;)

@knaeckeKami when you say "fix" Mockito, are you saying that Mockito's null safety approach of using codegen is the thing that is broken?

I can say, Yes.
It is hard to imagine running tests plus code-gen. We all know how code gen is not good in the sense that it takes lots of time, plus it is hanover thing in our routine to do.
Of course we have the option to use it without code gen, but it is not good as well because of all the boilerplate.
I will probably not migrate my tests file (by adding the SDK version in the head of the file), if that works I will definitely not migrate to NNBD too soon.

I would not call it broken, we were just looking into alternatives to codegen to keep the current API even with Nullsafety and to keep Mockito as frictionless to use as it is now.

I get it. You put "fix" in quotes so I thought I understood where you were coming from.
There was a lot of internal discussion about this aspect of null safety and mockito. Codegen (great tooling inside tooling, but definitely more friction for pub packages) and manual overriding (yuck for most cases) were the most viable options we landed on. We didn't explore mirrors too much because of the problems you've encountered. I feel like there is a good solution out there that would rely on some kind of macro support, but I haven't explored that, and I don't think the language team has explored much in terms of language-specified macro support. Such a macro system would be sort of a "runtime-supported codegen" rather than a "ahead-of-time, build-system codegen".

@pedromassango

It is hard to imagine running tests plus code-gen. We all know how code gen is not good in the sense that it takes lots of time, plus it is hanover thing in our routine to do.

I'm not really familiar with these downsides. But I haven't gotten my hands dirty either. Tests should be run with pub run build_runner test, right? Which would take extra time over pub run test the first go, but follow-up runs would not take much longer? Or do they? I should benchmark mockito's codegen in tests.
https://pub.dev/packages/build_runner#built-in-commands

Of course we have the option to use it without code gen, but it is not good as well because of all the boilerplate.

Yeah I can think of almost no situations where I would recommend the manual overrides over codegen. Sort of just an escape hatch for the hypothetical situation where codegen is a no go.
If you stub/verify ~1 method which has a non-nullable parameter or return type, it might make sense to manual override. But hopefully most of your APIs become non-nullable, rather than most of your APIs remaining nullable, so this seems very hypothetical.
Flutter also took a look at their mockito use cases and removed their mockito dependencies in many (all?) cases, because they were making very light use, and could replace with manual mocks or Fakes.

My biggest annoyance with codegen is that it interrupts the workflow.
Say I write a new tests with a new Mock, I need to write some code, run build_runner, wait (for big projects often > 1 minute), and then continue.
For this reason, I'll probably mostly use manual fakes and just use Mockito for some advanced use cases.
If build_runner was integrated transparently in the build process when running  'dart/flutter test', I think just that would also help a lot.

For this reason, I'll probably mostly use manual fakes and just use Mockito for some advanced use cases.

This means you will need to write more code (for manual fakes) as well!

Yes. But for me, that's not that big of an issue. I don't use Mockito that much.
Mostly for mocking API responses. For me it's not that big of a deal to write fakes for that. But I understand that code that relies more heavily on Mockito and uses more advanced features is more painful to migrate.


support the remaining break/continue tests

(by means of a workaround of EO#1077)

@rultor, release, tag is 0.24.0

@rultor, release, tag is 0.24.0

@dours OK, I will release it now. Please check the progress here

@rultor, release, tag is 0.24.0

@dours Done! FYI, the full log is here (took me 11min)


Environment File Not Being Found

I know this is mostly not specifically related to djcompiler, but I thought I'd give it a try, after compiling the django backend that has an .env file in the main app directory (the one that contains the settings) it outputs that it didn't find the .env file in the terminal, and when running the server it doesn't seem to read the environment variables from the file even though I copied the .env to the build directory. Can you confirm if this is an error on my side or on the side of cython?

it should work if you have .env file in required files in .djcompiler file or djcompiler.py depends on if you use .djcompiler file or py file please share more details about that like the .djcompiler and the files in the build directory.


Thanks!

I needed a version I could easily P/Invoke from C# (.NET 7), thanks! Saves me the trouble.
For those wondering:
[LibraryImport("texconv.dll", EntryPoint = "texconv")]
private static partial int Texconv(
    int argc,
    [MarshalAs(UnmanagedType.LPArray, ArraySubType = UnmanagedType.LPWStr)] string[] argv,
    [MarshalAs(UnmanagedType.Bool)] bool verbose,
    [MarshalAs(UnmanagedType.Bool)] bool initCOM,
    [MarshalAs(UnmanagedType.Bool)] bool allowSlowCodec,
    [MarshalAs(UnmanagedType.LPWStr)] string errorBuffer,
    int errorBufferSize = 0
);

How truely cross-platform is this, when Texconv itself uses DirectX interfaces for (parts) of its magic?

DirectX team is trying to make it cross-platform. And some features supports unix/linux systems already.
For DirectXTex, you can build it on unix/linux systems just by including DirectXMath and DirectX-Headers.
So, it was not hard to make texconv cross-platform.
I just removed winapi calls and GPU codec from texconv.


feat(graph-gateway): add indexers url builder functions

This PR introduces utility functions in the indexers client module to generate different indexer endpoints from a base URL (e.g., obtained from the graph network subgraph).

Note: These changes are included in #697 and #706


Include lib on quick deploy

Thanks man! Happy to add you as a collaborator if you have any interest!


Unique variable name detection

Variable names should be unique if they have default values specified or not -- right now it uses the raw value for detecting unique names.

Ok, there were some bad bugs in the variable substitution logic but they have been resolved now, pending additional testing (so far things are looking good though!)


Added network host

Summary
This PR fix a workflow error adding a stdin link using the docker image
Changes these areas

[x] Bugfixes
[ ] Feature behavior
[ ] Command line interface
[ ] Configuration options
[ ] Internal architecture
[ ] Snapshot data layout on disk

Nice. Tests seem to be working as expected now. Thanks!


HLIL optimises out stack stores, even when pointers to the stack escape

Using the following C code (compiled with clang -O3), the HLIL doesn't show the 1000 assignment.
struct params {
	int f1;
	int f2;
};

int func(void (*cb)(struct params *), int a2) {
	struct params p;
	p.f1 = a2;
	p.f2 = 1000;
	cb(&p);
}

This can be rectified by changing the type of var_10 to int[2], but there's nothing visible to indicate you should do that unless you check MLIL or lower.

Found this issue while looking for another bug, this is fixed now:
func:
   0 @ 00401110  int64_t rax
   1 @ 00401110  int64_t var_8 = rax
   2 @ 00401114  var_8.d = arg2
   3 @ 00401117  var_8:4.d = 1000
   4 @ 00401125  return arg1(&var_8)

This is fixed as of 2.3


[test-triage] rv_dm_jtag_dtm_idle_hint fails check DV_CHECK_EQ(rwdata, 0)

Hierarchy of regression failure
Block level
Failure Description
UVM_INFO @ 0 ps: reporter [RNTST] Running test rv_dm_base_test...
UVM_INFO @         0 ps: (rv_dm_env_cfg.sv:45) [cfg] ral_model_names: '{"rv_dm_regs_reg_block", "rv_dm_mem_reg_block"}
UVM_INFO @         0 ps: (rv_dm_env_cfg.sv:67) [cfg] Fixing reset values in jtag_dmi_ral
UVM_INFO @         0 ps: (sba_access_monitor.sv:62) uvm_test_top.env.m_sba_access_monitor [uvm_test_top.env.m_sba_access_monitor] sba_addrs: '{'h38, 'h39, 'h3c}
UVM_ERROR @   5197278 ps: (rv_dm_scoreboard.sv:83) [uvm_test_top.env.scoreboard] Check failed rwdata == 0 (1 [0x1] vs 0 [0x0])
UVM_INFO @   5197278 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]

From hw/ip/rv_dm/dv/env/rv_dm_scoreboard.sv, the DV_CHECK_EQ that fails:
      case (selected_dtm_csr.get_name())
        "bypass0", "bypass1": begin
          // TDI gets shifted out of TDO, and appears left-shifted by 1 - new write is ignored.
          uvm_reg_data_t rwdata;
          rwdata = get_field_val(selected_dtm_csr.get_field_by_name("bypass"), item.dout);
          `DV_CHECK_EQ(rwdata, 0)
          void'(selected_dtm_csr.predict(.value(item.dr), .kind(UVM_PREDICT_WRITE)));
        end

Steps to Reproduce

GitHub Revision: 856e402f740d40dbdb06013320f1697670154fc0
dvsim invocation command to reproduce the failure: ./util/dvsim/dvsim.py hw/ip/rv_dm/dv/rv_dm_sim_cfg.hjson -i rv_dm_jtag_dtm_idle_hint --build-seed<PHONE_NUMBER>0245376283659198434338498577935164172956485671224275001047693479661 --fixed-seed<PHONE_NUMBER>1956603334217608247540968399448993242661191135265525233160084858441

Tests with similar or related failures
This seems to be the same problem as in #23304 / rv_dm_smoke, even though historically this test has been less flaky than rv_dm_smoke.

This seems to be fixed now. Running against commit 4facfc972126b64a4032c875095f7feb58f0e0c3, I get a 100% pass rate:
## RV_DM Simulation Results
### Monday June 03 2024 10:35:56 UTC
### GitHub Revision: [`4facfc9721`](https://github.com/lowrisc/opentitan/tree/4facfc972126b64a4032c875095f7feb58f0e0c3)
### Branch: tmp
### [Testplan](https://opentitan.org/book/hw/ip/rv_dm/data/rv_dm_testplan.html)
### Simulator: XCELIUM

### Test Results
|  Stage  |        Name        | Tests                    |  Max Job Runtime  |  Simulated Time  |  Passing  |  Total  |  Pass Rate  |
|:-------:|:------------------:|:-------------------------|:-----------------:|:----------------:|:---------:|:-------:|:-----------:|
|   V2    | jtag_dtm_idle_hint | rv_dm_jtag_dtm_idle_hint |      6.000s       |    521.911us     |    50     |   50    |  100.00 %   |
|   V2    |                    | **TOTAL**                |                   |                  |    50     |   50    |  100.00 %   |
|         |                    | **TOTAL**                |                   |                  |    50     |   50    |  100.00 %   |


#1712 Bump to Polly 8.0

Closes #1712

#1712

Bump to Polly 8.0 and some code improvements

@RaynaldM Is it urgent or not?
Are you experiencing some problems with current /old version of Polly package in the project of your team?
I'm afraid it will be wrong to add this change to current release because of the package upgrading.
Let me know the urgency plz...

@RaynaldM Is it urgent or not? Are you experiencing some problems with current /old version of Polly package in the project of your team?
I'm afraid it will be wrong to add this change to current release because of the package upgrading. Let me know the urgency plz...

@raman-m no urgency currently

@RaynaldM commented on Oct 2

👌 I'm focusing on the release now...

Don't worry about failed build 2086, this is  Scenario: Open circuit should not effect different route
Next build should have green status. This is well-known bug-issue #1706 :

#1706

@ggnaegi  Hi! As you see, this test is constantly failing, rare, but it fails.
It seems we need to prioritize #1706 as High 😉 Do you have some time this week to spare on the bug?

⚠  Ray,
You are the member of the team. You can create feature branches right in this ThreeMammals/Ocelot repository 😉

Ray, I have refactored two classes. Are you OK with these changes?

@RaynaldM Are we going to merge? 😃

@RaynaldM I will come back in 2 hours... Answer, please, are you OK to merge or not?

Ray, I have refactored two classes. Are you OK with these changes?

Yes, I'm

@RaynaldM
Yes, I'm

How would you like to reuse this feature in your projects? Is it urgent to release?
Or are you building a local Ocelot solution from develop branch of your forked repo?

We've released a 20.0.1-alpha on our artifacts repo, so we're in no hurry, it's still in the test phase.
We're sticking as closely as possible to the original Ocelot, and will continue to do so for as long as possible. So, we sometimes make temporary "alpha (or beta)" packages (e.g. migration to .Net 7) while waiting for integration into the official package.

@RaynaldM commented on Oct 16 at 12:23 PM
We've released a 20.0.1-alpha on our artifacts repo, so we're in no hurry, it's still in the test phase...
...waiting for integration into the official package.

👌 We will have 20.0.1 official release these days because of ReadTheDocs build problem (the fix is merged into release/20.0 branch already). If you want, I can include your feature from develop? Otherwise, you & your team will have to wait until the first days of November for the October's release.

as you want @raman-m, for us, it's ok for begining of November


revert PR https://github.com/odeke-em/go-uuid/pull/6 [node: fix data race]

The locking in PR https://github.com/odeke-em/go-uuid/pull/6 causes hangs for users of the library. Let's revert that CL until a proper fix is made.

The branch with the original fix at https://github.com/odeke-em/go-uuid/tree/revert-data-race-fix.


"Are you sure?" alert on "Delete Snippet"

It looks like we are currently not prompting user if they really want to delete a snippet.
It will be nice to ask user again instead of deleting it immediately.

to be added in next release 👍🏼

feature added in https://github.com/tahabasri/snippets/pull/44


we deploy empty subdirectories

In a project with nested directories, even if no files are selected in them, we'll still deploy the empty subdirectories to Connect. We also autoinclude an empty .posit dir on every deploy.

This is due to how the bundling code works, now that we've switched from default-include-all to default-exclude-all. We need to switch the bundling code to a 2-pass mode, where the first pass traverses the whole tree looking for matches and creates a file list, and the second pass bundles those files.


[WIP] Windows support

Fixes #1640

When can we expect Windows support please?
@ThomasRaoux @ptillet @Jokeren @zahimoud @daadaada @peterbell10

@goostavz  @Superjomn Windows support please

We don't develop on Windows. Maybe we can merge as long as it doesn't break any Linux dependencies?

We don't develop on Windows. Maybe we can merge as long as it doesn't break any Linux dependencies?

And why is that? in 2023 why you don't develop Windows? Except Triton all the libraries I use works on Windows

And why is that? in 2023 why you don't develop Windows? Except Triton all the libraries I use works on Windows

I meant the people you pinned don't use Windows for development...

There is no plan to support windows. We could occasionally accept PRs that make Triton at least compile on windows, but we wouldn't actually test, maintain or support it. I didn't look too much at this PR because it was a draft and I'm on vacation, but was open to accepting it initially.
But frankly if committing to accepting these PRs mean we're gonna get tagged and interrupted then I don't think it's worth it. I'm closing this.

no plan to support windows

but why no plan to support windows? I really can't understand it

@ptillet - As an open-source maintainer, I fully respect the curation of PRs to align with the goal of the repo.
However, I'd encourage you to make explicit the intent of this repo - Is it intended to be "an open-source environment to write fast code at higher productivity than CUDA, but also with higher flexibility than other existing DSLs", or is it intended to primarily service OpenAI's internal development needs?
There are a growing number of people exploring the ML ecosystem (including development) from Windows environments. You've received a growing number of requests to offer Windows support, and now, PRs to contribute the support.
Expectation setting on the rationale for not supporting Windows would be helpful - It's clearly not "There's no demand for it from the open-source community"

@ptillet - As an open-source maintainer, I fully respect the curation of PRs to align with the goal of the repo.
However, I'd encourage you to make explicit the intent of this repo - Is it intended to be "an open-source environment to write fast code at higher productivity than CUDA, but also with higher flexibility than other existing DSLs", or is it intended to primarily service OpenAI's internal development needs?
There are a growing number of people exploring the ML ecosystem (including development) from Windows environments. You've received a growing number of requests to offer Windows support, and now, PRs to contribute the support.
Expectation setting on the rationale for not supporting Windows would be helpful - It's clearly not "There's no demand for it from the open-source community"

so many people expecting Windows
Tens of thousands of people everyday seeing this error message
no triton found some optimizations will not work

But frankly if committing to accepting these PRs mean we're gonna get tagged and interrupted

@FurkanGozukara you are really hurting the OSS ecosystem with such behavior. It is unacceptable to continuously ping maintainers on timelines without offering any help. Not only is this leading to maintainers simply closing the PR because you distract them from the work, but also you set a very bad example for newcomers.
Some things that I think can help you for the future:

never  ask "When can we expect this to be finished" on open PRs that are being worked on. Instead offer your help when PRs are stalling. Open-source maintainers of popular repos (such as this one) are flooded with notifications, be mindful to that.

Read the Contribution guide. Ever popular repo has a contributing guide. Triton's guide is here: https://github.com/openai/triton/blob/0cf3a67f043c949ef473c510f87f2549c6c3c6aa/CONTRIBUTING.md
You broke two rules:

Quality Contributions

Try to give more than you take. You cannot assume any open-source repository to do anything for you for free. That's not the spirit. Try to understand a repository, use it and then contribute to it. Don't blatantly just ask for features for your personal use.

Respectful Communication

@patrickvonplaten i have 0 personal usage of triton. If I needed I would just use it on linux.
But since I am making tutorials for general public who are mostly on Windows I am constantly getting messages from people.
They are asking me why they are getting no triton found error.
But as you said ok i won't bother anymore.

Just an update that I've built wheels for Triton v3.0.0 on Windows, and they work well for downstream applications like ComfyUI. Feel free to discuss there:
https://github.com/woct0rdho/triton

Just an update that I've built wheels for Triton v3.0.0 on Windows, and they work well for downstream applications like ComfyUI. Feel free to discuss there: https://github.com/woct0rdho/triton

Amazing work by @woct0rdho  thank you so much


Windows : Use Node.js from Atom instead of system Node.js

Currently blocked by https://github.com/atom/atom/issues/2887

Platform detect added : https://github.com/TypeStrong/atom-typescript/commit/2fb8c3167f18eda0d8dbb83019b3b406f5cb005e

@csnover if you are curious: Object.create for env breaks it + not setting the cwd breaks it.
I would be happy to rewrite history to remove iojs binaries if you want.


1.1.5 doesn't compile on Rust 1.57

Attempting to compile thread local on Rust 1.57 results in the following compiler error:
error[E0658]: use of unstable library feature 'thread_local_const_init'
   --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/thread_local-1.1.5/src/thread_id.rs:130:9
    |
130 |         thread_local! { static THREAD: Cell<Option<Thread>> = const { Cell::new(None) }; }
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #84223 <https://github.com/rust-lang/rust/issues/84223> for more information
    = note: this error originates in the macro `$crate::__thread_local_inner` (in Nightly builds, run with -Z macro-backtrace for more info)
For more information about this error, try `rustc --explain E0658`.
error: could not compile `thread_local` due to previous error

Not sure if this was intentional change to the MSRV or not. The README lists the MSRV as 1.36.0.

1.1.5 has been yanked due to another issue.

Closing as 1.1.5 has been yanked.

FYI the MSRV will be bumped to 1.59, which was released 11 months ago.


no .html

GitHub pages doesn't support setting arbitrary MIME types. It's only by file extension.
Common development servers such as live-server@cargo and live-server@npm also don't seem to.
So... we'll give up on this one for now.


App stopped without reason after upgrade flutter to version 1.5.4-hotfix.2

I wrote my flutter app in Flutter version 1.0.0!
when upgrade flutter to stable version (1.54-hot-fix-2) my app crashed.
flutter doctor -v
[✓] Flutter (Channel stable, v1.5.4-hotfix.2, on Linux, locale en_US.UTF-8)
    • Flutter version 1.5.4-hotfix.2 at /media/hassan/DriveD/android/development/flutter
    • Framework revision 7a4c33425d (4 weeks ago), 2019-04-29 11:05:24 -0700
    • Engine revision 52c7a1e849
    • Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /media/hassan/DriveD/android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /media/hassan/DriveD/android/sdk
    • Java binary at: /media/hassan/DriveD/software/AndroidStudio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b16-5323222)
    • All Android licenses accepted.

[✓] Android Studio (version 3.4)
    • Android Studio at /media/hassan/DriveD/software/AndroidStudio
    • Flutter plugin version 35.3.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b16-5323222)

[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 7.0 (API 24) (emulator)

my pubspec.yaml
name: whats_app2
description: A new Flutter application.

# The following defines the version and build number for your application.
# A version number is three numbers separated by dots, like 1.2.43
# followed by an optional build number separated by a +.
# Both the version and the builder number may be overridden in flutter
# build by specifying --build-name and --build-number, respectively.
# In Android, build-name is used as versionName while build-number used as versionCode.
# Read more about Android versioning at https://developer.android.com/studio/publish/versioning
# In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
# Read more about iOS versioning at
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.0.0+1

environment:
  sdk: ">=2.1.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter
  validators: ^2.0.0 # change to latest version
  http: ^0.12.0+2
  shared_preferences: ^0.5.2
#  connectivity: ^0.4.2
  cached_network_image: ^0.7.0
  sqflite: ^1.1.0
  google_maps_flutter: ^0.5.10
  location: ^2.3.5
  flutter_badge: ^0.0.1
  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^0.1.2

dev_dependencies:
  flutter_test:
    sdk: flutter

# For information on the generic Dart part of this file, see the
# following page: https://www.dartlang.org/tools/pub/pubspec

# The following section is specific to Flutter.
flutter:

  # The following line ensures that the Material Icons font is
  # included with your application, so that you can use the icons in
  # the material Icons class.
  uses-material-design: true

  # To add assets to your application, add an assets section, like this:
  assets:
    - assets/images/icon.png
    - assets/images/background.png
    - assets/images/placeholder-image.png

  # An image asset can refer to one or more resolution-specific "variants", see
  # https://flutter.dev/assets-and-images/#resolution-aware.

  # For details regarding adding assets from package dependencies, see
  # https://flutter.dev/assets-and-images/#from-packages

  # To add custom fonts to your application, add a fonts section here,
  # in this "flutter" section. Each entry in this list should have a
  # "family" key with the font family name, and a "fonts" key with a
  # list giving the asset and other descriptors for the font. For
  # example:
  fonts:
    - family: Samim
      fonts:
        - asset: assets/fonts/Samim.ttf
        - asset: assets/fonts/Samim-Bold.ttf
          weight: 700
  # fonts:
  #   - family: Schyler
  #     fonts:
  #       - asset: fonts/Schyler-Regular.ttf
  #       - asset: fonts/Schyler-Italic.ttf
  #         style: italic
  #   - family: Trajan Pro
  #     fonts:
  #       - asset: fonts/TrajanPro.ttf
  #       - asset: fonts/TrajanPro_Bold.ttf
  #         weight: 700
  #
  # For details regarding fonts from package dependencies,
  # see https://flutter.dev/custom-fonts/#from-packages

Screenshot of my emulator:

even just importing in the pubspec makes it crash, a simple hello world appbar crashes.

I had to create a new flutter app from v1.5.4 and move all files from old version to new app.
by this my problem resolved.

Hi @zaaferani
given your last message I feel safe to close this issue,
if you disagree please write in the comments
and I will reopen it.
Thank you


feat: update data structures and scrape content

Data structure now contains the plaintext of the site, the HTML of the section, as well as the URLs from where the scrape is taken from

@JunhaoWang I'll wait for your approval ^


fix(autocomplete): blur not being handled in compatibility mode

Fixes the blur event not being handled properly if the user uses mat-option, instead of md-option.

Closing in favor of #3188.


Cleanup travis appveyor

Minor cleanup of missing newlines and removal of commented out block from .travis.yml and appveyor.yml.

Odd that Travis failed for one test as nothing has actually changed in the driver or tests.
Issue is likely a race condition in one of the tests:
testQueryTimeout()  Time elapsed: 6.902 sec  <<< FAILURE!
org.opentest4j.AssertionFailedError: 2nd execution didn't take long enough. ==> expected: <6500> but was: <4354>
	at com.microsoft.sqlserver.jdbc.unit.statement.StatementTest$TCAttentionHandling.testQueryTimeout(StatementTest.java:208)

Thanks @sehrope! Will mark this failure. I kicked of the test again to pass.

Codecov Report

Merging #473 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #473      +/-   ##
============================================
- Coverage     46.26%   46.25%   -0.01%
+ Complexity     2201     2198       -3
============================================
  Files           108      108
  Lines         25227    25227
  Branches       4172     4172
============================================
- Hits          11672    11670       -2
+ Misses        11538    11530       -8
- Partials       2017     2027      +10

Flag
Coverage Δ
Complexity Δ

#JDBC41
46.06% <ø> (ø)
2187 <ø> (-5)
:arrow_down:

#JDBC42
46.15% <ø> (+0.03%)
2196 <ø> (-1)
:arrow_down:

Impacted Files
Coverage Δ
Complexity Δ

...om/microsoft/sqlserver/jdbc/ReaderInputStream.java
44.94% <0%> (-2.25%)
16% <0%> (ø)

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
43.82% <0%> (-1.13%)
104% <0%> (ø)

...n/java/com/microsoft/sqlserver/jdbc/Parameter.java
62.01% <0%> (-0.65%)
63% <0%> (-1%)

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
32.81% <0%> (-0.41%)
242% <0%> (-2%)

...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java
42.2% <0%> (-0.22%)
46% <0%> (ø)

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
63.11% <0%> (-0.13%)
0% <0%> (ø)

...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
52.58% <0%> (-0.07%)
239% <0%> (ø)

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
54.08% <0%> (+0.73%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a13577...6f0bc72. Read the comment docs.

Thanks @sehrope for your contribution!


Stab/194 support add with groups

This still needs more testing.
This is a change to allow someone to add a new member into groups in a single save, so that sign-up autoresponders will trigger consistently.

This looks good in our local testing.


Help with support for adding Kogan Portable Air Conditioner

Hi, I recently I got this Portable Air Conditioner from Kogan.
In HomeBridge, I get a message saying I am missing the schema for mode and work_status.
[08/01/2023, 14:41:44] [TuyaPlatform] [Portable Air Conditioner] Missing one of the required schema: [ 'mode' ]
[08/01/2023, 14:41:44] [TuyaPlatform] [Portable Air Conditioner] Please switch device control mode to "DP Insctrution", and set `deviceOverrides` manually.
[08/01/2023, 14:41:44] [TuyaPlatform] [Portable Air Conditioner] Detail information: https://github.com/0x5e/homebridge-tuya-platform#faq
[08/01/2023, 14:41:44] [TuyaPlatform] [Portable Air Conditioner] Missing one of the required schema: [ 'work_status', 'mode' ]
[08/01/2023, 14:41:44] [TuyaPlatform] [Portable Air Conditioner] Please switch device control mode to "DP Insctrution", and set `deviceOverrides` manually.
[08/01/2023, 14:41:44] [TuyaPlatform] [Portable Air Conditioner] Detail information: https://github.com/0x5e/homebridge-tuya-platform#faq

So I went to the Tuya website and set it from Standard Instruction to DP Instruction. These are the available options it gives me:
With DP Instruction mode selected

DP Instruction
Standard Instruction

Power
Power

temp_set
temp_set

temp_current
temp_current

mode
mode

windspeed
windspeed

C_F
C_F

Timer
Timer

coutdown
coutdown

Alarm
Alarm

SLEEP
SLEEP

With Standard Instruction mode selected

DP Instruction
Standard Instruction

Power
switch

temp_set
temp_set

temp_current
temp_current

mode
-

windspeed
windspeed

C_F
-

Timer
-

coutdown
-

Alarm
-

SLEEP
-

I added mode to my schema override but there is no option for "work_status".
Here is the device info from MQTT/Logs:
{
    "active_time":<PHONE_NUMBER>,
    "biz_type": 18,
    "category": "kt",
    "create_time":<PHONE_NUMBER>,
    "icon": "smart/icon/ay15253387844269Sg99/d5401b2b8f67cffe2a26530c926f4876.png",
    "id": "71770814483fda388a71",
    "ip": "",
    "lat": "",
    "local_key": "",
    "lon": "",
    "model": "KAWFPAC09YA",
    "name": "Portable Air Conditioner",
    "online": true,
    "owner_id": "",
    "product_id": "mhod7aykax0wbivn",
    "product_name": "Kogan Smarter Home™ 2.6kW Portable Air Conditioner",
    "status": [
      {
        "code": "switch",
        "value": false
      },
      {
        "code": "temp_current",
        "value": 25
      },
      {
        "code": "temp_set",
        "value": 24
      },
      {
        "code": "windspeed",
        "value": "1"
      }
    ],
    "sub": false,
    "time_zone": "+10:00",
    "uid": "",
    "update_time":<PHONE_NUMBER>,
    "uuid": "71770814483fda388a71",
    "schema": [
      {
        "code": "switch",
        "mode": "rw",
        "type": "Boolean",
        "property": {}
      },
      {
        "code": "temp_current",
        "mode": "ro",
        "type": "Integer",
        "property": {
          "unit": "℃ ℉",
          "min": -7,
          "max": 98,
          "scale": 0,
          "step": 1
        }
      },
      {
        "code": "temp_set",
        "mode": "rw",
        "type": "Integer",
        "property": {
          "unit": "℃ ℉",
          "min": 16,
          "max": 86,
          "scale": 0,
          "step": 1
        }
      },
      {
        "code": "windspeed",
        "mode": "rw",
        "type": "Enum",
        "property": {
          "range": [
            "1",
            "2"
          ]
        }
      }
    ]
  }

Using Debug in Homebridge I noticed that when changing between the three modes (Dry, Cool, and Fan) it sends this:
[08/01/2023, 14:44:05] [TuyaPlatform] [TuyaOpenMQ] onMessage:
topic = cloud/token/in/83c3ca57652a51a0b0cd48b937c0917c
protocol = 4
message = {
  "dataId": "c96f450c-1def-4b9c-a539-08a6ad81c93c",
  "devId": "71770814483fda388a71",
  "productKey": "mhod7aykax0wbivn",
  "status": [
    {
      "4": "FAN"
    }
  ]
}
t =<PHONE_NUMBER>
[08/01/2023, 14:44:15] [TuyaPlatform] [TuyaOpenMQ] onMessage:
topic = cloud/token/in/83c3ca57652a51a0b0cd48b937c0917c
protocol = 4
message = {
  "dataId": "36ce2748-4a56-4f19-b87b-3c080ab0c5ca",
  "devId": "71770814483fda388a71",
  "productKey": "mhod7aykax0wbivn",
  "status": [
    {
      "105": 117
    }
  ]
}
t =<PHONE_NUMBER>
[08/01/2023, 14:44:17] [TuyaPlatform] [TuyaOpenMQ] onMessage:
topic = cloud/token/in/83c3ca57652a51a0b0cd48b937c0917c
protocol = 4
message = {
  "dataId": "e22747a7-ed29-4cca-b265-fbb36473d089",
  "devId": "71770814483fda388a71",
  "productKey": "mhod7aykax0wbivn",
  "status": [
    {
      "4": "DRY"
    }
  ]
}
t =<PHONE_NUMBER>
[08/01/2023, 14:44:27] [TuyaPlatform] [TuyaOpenMQ] onMessage:
topic = cloud/token/in/83c3ca57652a51a0b0cd48b937c0917c
protocol = 4
message = {
  "dataId": "ca05df45-fa25-4901-af04-7f552bf2d892",
  "devId": "71770814483fda388a71",
  "productKey": "mhod7aykax0wbivn",
  "status": [
    {
      "4": "COOL"
    }
  ]
}
t =<PHONE_NUMBER>

And here is my override schema I created (hoping it is correct!):
"deviceOverrides": [
                    {
                        "id": "71770814483fda388a71",
                        "schema": [
                            {
                                "oldCode": "switch",
                                "code": "Power",
                                "type": "Boolean"
                            },
                            {
                                "oldCode": "SLEEP",
                                "code": "SLEEP",
                                "type": "Boolean",
                                "property": {
                                    "range": [
                                        "true",
                                        "false"
                                    ]
                                }
                            },
                            {
                                "oldCode": "temp_current",
                                "code": "temp_current",
                                "type": "Integer",
                                "property": {
                                    "min": -5,
                                    "max": 50,
                                    "scale": 0,
                                    "step": 1
                                }
                            },
                            {
                                "oldCode": "temp_set",
                                "code": "temp_set",
                                "type": "Integer",
                                "property": {
                                    "min": 16,
                                    "max": 30,
                                    "scale": 0,
                                    "step": 1
                                }
                            },
                            {
                                "oldCode": "windspeed",
                                "code": "windspeed",
                                "type": "Enum",
                                "property": {
                                    "range": [
                                        "1",
                                        "2"
                                    ]
                                }
                            },
                            {
                                "oldCode": "mode",
                                "code": "mode",
                                "type": "Enum",
                                "property": {
                                    "range": [
                                        "COOL",
                                        "FAN",
                                        "DRY"
                                    ]
                                }
                            }
                        ]
                    }
                ]

I had also set work_status to be the same as mode but that didn't work. I still get the message that both mode and work_status are missing from the schema.
Was wondering if you could assist in how I can fix this? Or is this something that needs to be changed in the plugin? I'm unsure if there's a way in the Tuya API to get all the DP instruction modes and their values.
Thanks!

there's no need to add all schema into the config, just keep those you want to modify. mode is the fallback of work_status, its okay without it. Can you describe how it didn't work?

I added the other schema in the config as I wanted to change the temperature min/max values as I only use celsius.
The issue I'm having is that after making the custom schema it still says that mode is missing from the schema. The aircon also doesn't appear in the list of HomeBridge Accessories and in HomeKit it says Not Supported.
I am wondering if my custom schema might just be getting ignored, as it seems like it should work?

after switch to dp mode, did you restart the homebridge? from your device info json, there's still missing mode.

Yeah I was restarting it everytime I changed the config but it appears to be working now, its properly registering as DP mode and after overriding Power to switch.
Now I have two new issues:
[09/01/2023, 01:27:10] [TuyaPlatform] [Portable Air Conditioner] Invalid mode range for TargetHeaterCoolerState: [ 'COOL', 'FAN', 'DRY' ] but I can ignore this as it still works.
In the HomeKit app or on the HomeBridge Accessories page, after turning on the air conditioner, about two seconds later it'll appear as offline and just display the current room temprature. (Could this be because I had to change Power DP to switch?)
The fan modes in HomeKit also show as "OFF, COOL, HEAT, AUTO" instead of "COOL, DRY, FAN". Are these modes able to be changed or is that a limitation by the HomeKit app? My Air Conditioner is for cooling only, it doesn't do heating as well.
Thanks!!

Please post your original mode schema. your config of these part:
{
                                "oldCode": "mode",
                                "code": "mode",
                                "type": "Enum",
                                "property": {
                                    "range": [
                                        "COOL",
                                        "FAN",
                                        "DRY"
                                    ]
                                }
                            }

is useless and invalid.
and everytime you editing deviceOverrides, better clean the accessory cache. If a AC have cooling only, fan and dehumidifier won't appear then.

The original mode schema is the exact same.
      {
        "code": "mode",
        "mode": "rw",
        "type": "Enum",
        "property": {
          "range": [
            "COOL",
            "FAN",
            "DRY"
          ]
        }
      },

Which is invalid.
I have overridden it to:
                            {
                                "oldCode": "mode",
                                "code": "mode",
                                "type": "Enum",
                                "property": {
                                    "range": [
                                        "cold",
                                        "wind",
                                        "wet"
                                    ]
                                }
                            }

After clearing cashe and restarting this then shows no mode options in HomeKit and shows 2 power buttons and a slider (for fan speed) with a power button in it.

The AC has cooling, fan, and dehumidifer modes (COOL, FAN, DRY)

@Sparoney hello,
Can you please help me how to change device code on Tuya. I can not find any detailed information on google.
Thank you!!


Closes #9871: Flex Topbar

This closes #9871.
The new docs codepen example already fixes this.
This just adds

[x] Titlebar tweaks to make it look similar to float one
[x] Add a test case for new docs example!
[x] Docs update with new codepen example

Here is the flex version codepen (with titlebar tweaks) => https://codepen.io/IamManchanda/pen/OmBVZE?editors=1100

@kball ,,,, i think the docs update should go in master (live) also!

@rafibomb can you take a look at this?

@rafibomb @kball Awaiting reply for above
Can we close this before 6.4 RC?

I don't know how I feel about removing the all in one responsive toggle docs example - it's nice to have but I get it needs work for flex version

It looks good from a bug fix perspective - merging!
What I'd like to see in the future:

[] title-bar has it's own docs page within navigation
[] title-bar inherits top-bar styles (height, color, background)
[] or eliminate the thing altogether and use top-bar on mobile and larger

Thoughts? @IamManchanda @kball @brettsmason @andycochran @colin-marshall


Adding a custom session store requires an app.js

When i add a custom session store ( which the docs say must be named application.js ) the build fails with file not found session-stores/app.js

Any more info on this?

Ember CLI/ESA versions
stack
contents of session-stores/application.js

Are you maybe trying to import session-stores/app.js somewhere yourself? ESA does use session-stores:application but certainly never app.

Closing due to lack of feedback.


[Bugfix] fix sharded state loader for lora

Short fix for the ShardedStateLoader when enable_lora=True. Users need to save the model also using enable_lora=True
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@Yard1

LoRA tensors will always be bigger or equal to base tensors, so we can just copy the loaded data into a slice. How about we just take that into account if lora is enabled? I think it should work in all cases.

right, that was the original approach but we found a bug with it. since the checkpoint is already sharded, but lora appends values to the end of the unsharded tensor, it left some weights empty where they shouldn't be. it was giving some garbage outputs which we don't see anymore with this fix

Hmm that's interesting! Let me think a little more about this. Do you have a script to reproduce?

Here's what I am thinking:
currently, LoRA added embeddings work in the following fashion:
TP 2:

[ base_embedding_0, base_embedding_1, base_embedding_2, base_embedding_3] ->[ base_embedding_0, base_embedding_1], [base_embedding_2, base_embedding_3]

[ base_embedding_0, base_embedding_1, base_embedding_2, base_embedding_3, lora_embedding_0, lora_embedding_1 ] -> [ base_embedding_0, base_embedding_1, base_embedding_2 ], [ base_embedding_3, lora_embedding_0, lora_embedding_1 ]

indeed, the way we shard LoRA embeddings means that we will not be able to reuse the shards made for the base case. However, we should  be able to easily do the following instead:
[ base_embedding_0, base_embedding_1, base_embedding_2, base_embedding_3] AND [ lora_embedding_0, lora_embedding_1 ] -> [ base_embedding_0, base_embedding_1, lora_embedding_0], [ base_embedding_2, base_embedding_3, lora_embedding_1 ]

we split the added LoRA embeddings into n-parts, and append each part to the original shards. Then we just need to modify the logic in https://github.com/vllm-project/vllm/blob/ee3eea0a1b2c690557455d97074d8829d5a98320/vllm/model_executor/layers/vocab_parallel_embedding.py#L90-L96 to account for that.
I should be able to get something out before EOW. Let me know if this makes sense (happy to also sync offline).

@Yard1 are you suggesting we actually change the way we pad and shard embedding+lora?

@sfc-gh-zhwang Yes, it should be a straightforward change. We simply distribute the LoRA-added embeddings differently so that they are always appended to base embedding shards. It should have the same runtime performance, too. I am happy to make that change.

@sfc-gh-zhwang Yes, it should be a straightforward change. We simply distribute the LoRA-added embeddings differently so that they are always appended to base embedding shards. It should have the same runtime performance, too. I am happy to make that change.

Oh I didn't know we were able to change this, if it's straightforward, then yeah, i think it's easier to do and less hacky. And going forward, we should follow the same principle for any potential paddings introduced by Lora 😄

Hmm that's interesting! I think I see the issue now, with the way the embeddings are sharded. Let me think a little more about this. Ideally we wouldn't need to have separate checkpoints. Do you have a script to reproduce?

thanks for looking into it! steps to reproduce are:

Download llama 3 8b: huggingface_hub.snapshot_download("meta-llama/Meta-Llama-3-8B")
Save the sharded checkpoint: python examples/save_sharded_state.py --model $HF_HOME/hub/models--meta-llama--Meta-Llama-3-8B/snapshots/62bd457b6fe961a42a631306577e622c83876cb6/ --tensor-parallel-size 8 --output ~/llama3-8b-tp8 --enable-lora
Run examples/offline_inference.py with model="~/llama3-8b-tp8", tensor_parallel_size=8, and load_format="sharded_state"


Citizenship screen created

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
The citizenship progress screen is created
#499
✅ Checklist

[x] Github issue details are up to date for people to QA.
[x] I have tested all my changes.
[x] Screen added
[x] step_progress_indicator dependency added
[x] new svgs added

🕵♂ Notes for Code Reviewer
I added animation to the progress bars but I need to know what will be the largest value on the screen to just fire the seState at that value and remove the others.
🙈 Screenshots

Spanish
English

👯♀ Paired with
"nobody"

"Reputation score" is not centered
"Reputation Score"  and other strings are not using correct text style
"Not enough space between "resident" text and "Progress Timeline" card.

Cool. animations.
About animations.
When the filed is 1/1 Animation is messed up
When the field is 3/5 animation is messed up
basically small number animations looks funny.
to fix this you need to make animations larger numbers.
You can still show the 1/1, but the animation values should be 100/100. Then the animations will look nice even for smaller numbers.

bout animations.

When the filed is 1/1 Animation is messed up
When the field is 3/5 animation is messed up
basically small number animations looks funny.
to fix this you need to make animations larger numbers.
You can still show the 1/1, but the animation values should be 100/100. Then the animations will look nice even for smaller numbers.

This is something I had also noticed but had not thought about how to solve it thanks for the idea 🚀