Definition/use of GO:0040035 hermaphrodite genitalia development

Discussed in https://github.com/geneontology/helpdesk/discussions/399

Originally posted by suzialeksander June 15, 2022
From Helpdesk email:

Dear curators,
Thank you for providing this excellent resource which I have been using for almost 15 years now. After this long period, I finally encountered a problem with Gene Ontology. In a recent manuscript, we reported some results of a Gene Ontology analysis for C. elegans genes. One of the terms that came up was 'hermaphrodite genitalia development' (GO:0040035).
One of the reviewers remarked:
"NB (page 7): Nematodes don’t have hermaphrodite genitalia. Hermaphroditic nematodes have female genitalia.
This looks like someone else’s terminology, but I think the wording could still be upgraded here."
I asked several colleagues and they all agreed with the reviewer's view.
Therefore, I would like to bring your attention to this issue and I would suggest to assess, whether a change in the Gene Ontology would be possible and appropriate. If you need another expert opinion, I would recommend to ask Paul Sternberg who is also listed as PI on the GO website.

Note @cmungall commented on the discussion:

it's in wbbt (which is linked indirectly via go->uberon->wbbt)
https://www.ebi.ac.uk/ols/ontologies/wbbt/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FWBbt_0005178&lang=en&viewMode=PreferredRoots&siblings=false

But the question remains whether hermaphrodite genitalia development is a gonad development

good catch
We can see the general classification of these terms here:

There are a number of oddities here, making a generalized system across all metazoa is hard

Medicine Net: Genitalia: The male or female reproductive organs. The genitalia include internal and external structures. The female internal genitalia are the ovaries, Fallopian tubes, uterus, cervix, and vagina. The female external genitalia are the labia minora and majora (the vulva) and the clitoris. The male internal genitalia are the testes, epididymis, and vas deferens.
Thus gonad development should be part_of genitalia development.

I've looked at the annotations from WB.
In many cases, it looks like we've been co-annotating to 'hermaphrodite genitalia development' (or morphogenesis) and a more specific term like 'vulval development' (or morphogenesis).
So, if we obsoleted 'hermaphrodite genitalia development' (and morphogenesis) and made sure that 'vulval development' (and morphogenesis) are children of 'female genitalia development', I think we'd be okay.
Whether or not we should broaden the definition of 'vulval development' to try to be more inclusive of other metazoans or update the name of this term to be more specific, e.g. 'nematode vulval development'  is TBD.
Does that get us closer to a workable solution?

I think the action is to

obsolete 'hermaphrodite genitalia development' (and morphogenesis)

I think this is ready?


Feature/14135 screen adjustments

added some textual changes and css changes for ess pages

Suraj, could you please resolve the merge conflicts. 13030 recently went into main, and main then went into the common branch, and now you have merge conflicts. Sorry

@crdandoukho conflicts resolved.


[Discussion] reproduce evaluation table

I can't reproduce SDR value with model trained with only Musdb data
I trained model with commend lines below
spleeter train --verbose -p configs/musdb_config.json -d
spleeter evaluate -p configs/musdb_config.json -o musdb_trained_spleeter_results --mus_dir  -m
and I got the result like below

and this page(https://github.com/deezer/spleeter/wiki/Separation-Performances) suggests that it should be larger then I got.
Did I miss something?
+) this is my training result
INFO:tensorflow:Saving dict for global step 200000: absolute_difference = 1.523042, bass_spectrogram = 0.19801405, drums_spectrogram = 0.35646605, global_step = 200000, loss = 1.523042, other_spectrogram = 0.56257313, vocals_spectrogram = 0.4059888
INFO:tensorflow:Saving 'checkpoint_path' summary for global step 200000: musdb_model/model.ckpt-200000
INFO:tensorflow:Loss for final step: 1.1176548.
INFO:spleeter:Model training done

Hi @100jy ,
your results seem to be indeed far off what we got.
This is very hard to tell where this difference could come from without further details.
A few possibilities that come to my mind:

there may be an issue in the last release (2.01) of spleeter that prevents proper training or separation (but reproducibilty of separation is tested in unit testing, so a problem in training is more probable). The results we reported were obtained with spleeter 1. What version of spleeter did you use? if it is spleeter 2, could you retry with one of spleeter 1 version (for instance 1.5.4) and check you still get such differences ?
you may be using a different version of musdb. For instance, if you have corrupted files in the training set, training should run correctly (with possibly some warnings) but a part of the database won't be used which may results in lower separation performances. Can you double check that your musdb dataset is complete (100 tracks in the training set) and with no corrupted files ?


package "mime" updated

Packages impacted by this PR
api-management-custom-widgets-tools
Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/27975
Describe the problem that is addressed by this PR
update of an outdated package
Checklists

[x] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x] Added a changelog (if necessary)

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure/api-management-custom-widgets-tools


Fix/lesq 627/landscape worksheets [LESQ-627]

Description
Music year: 1958

updates 2023 lesson overview MV to include worksheetIsLandscape field in line with 2020 api

Issue(s)
Fixes #
Worksheets not appearing in ladscape mode for migrated EYFS content
How to test

Go to https://deploy-preview-2244--oak-web-application.netlify.thenational.academy
Click on any new lesson
The worksheet should display correctly

Screenshots
How it used to look (delete if n/a):

How it should now look:

:tada: This PR is included in version 1.352.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


No fullscreen when editor is inside a modal

If the editor is placed inside a bootstrap modal, the fulscreen doesn't open successfully.

+1

+1

+1

+1

+1

Okay I'm afraid there is no "official" fix for this within the plugin. The .modal-dialog is containing the .md-editor.md-fullscreen-mode  block. If only css has a "parent selector" then this would be much easier :(
However, onFullscreen and onFullscreenExit events are the workaround to fix this issue. Modify modal-dialog css via js on the fly. onFullscreen event, turn it into:
.modal-dialog {
  width: 100%;
  height: 100%;
  margin: 0;
}

then remove them on fullscreen end


Selendroid seems to find Elements which are stale.

I can currently observe in a lot of my test cases that Selendroid reports way to many StaleElementExceptions. Thus i implemented a retry logic and the result was quite surprising to me. See the following example:
var e1 = find(By.id("a") => returns an element
e1.isDisplayed() => throws StaleElementException
var e1 = find(By.id("a") => returns an element
e1.isDisplayed() => throws StaleElementException
...
and so on
So i am using always the same query and i always get something back, but when i try to access the returned element it is always stale. I also checked the page source and the element was actually never there.
So i tried debugging it by enhancing KnownElements with log statements and figured out that it always run into this code block:
https://github.com/selendroid/selendroid/blob/master/selendroid-server/src/main/java/io/selendroid/server/model/KnownElements.java#L49
After that i just added the isViewChieldOfCurrentRootView with an log statement here (which seems to be called by findElement):
https://github.com/selendroid/selendroid/blob/67491a38a75b1990c4ee70bfbbf9686df82ca7eb/selendroid-server/src/main/java/io/selendroid/server/model/internal/AbstractNativeElementContext.java#L267
and it turned out that AbstractNativeElementContext returns for e.g. findElement an Element which would be always stale when accessing it.
For a client it seems to me impossible to figure out why this happens so Selendroid behavior should be changed from my point of view.
I actually cannot say how it must be changed because i don't understand why searchViews is actually returning the stale element. But if someone could help me to understand i will try to provide a fix.

@DominikDary any ideas whats going wrong here?

I think this is a duplicate of #800

@aluedeke Read #800. I'm pretty sure you're seeing the same issue.

closing this issues as it is an duplicate of #800


Detect URL through Parameter Checking and Patterns

With PII's there are many different types of identifiable information that can refer to a person, one being the URL. URL's can disclose things like file names, IP addresses, and possibly even login information for a website if the developer set it up to display this. However, it is important to use these as they provide access to user specific information, and allow for websites to make query's in order to hone in on a specific request. It's important to protect these as they are not only integral to many different systems, but they are also very personal to a user.
Source

What are some risks to consider in the event that a URL is not properly protected?

What are some risks to consider in the event that a URL is not properly protected?

In the event that a URL is not properly protected, hackers or unverified users can get into personal data and access things like accounts, profiles or more using a variety of different techniques like injection.


fix(utils): support auto fields

When fields marked as auto are passed to kong without a value they are auto generated by the gateway. In that case, comparing with "defaults" doesn't work, so in order to compute a correct diff they must be copied from Kong's configuration.
This commit addS a new FillPluginsDefaultsAutoFields utils function that in addition to default fields, adds auto fields to the configuration. It takes an additional parameter: oldConfig, which represents the config from Kong: auto fields are just copied from it so that they don't show up as differences in the diff.

Codecov Report
Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 44.02%. Comparing base (f96e181) to head (9bfa960).

Files
Patch %
Lines

kong/utils.go
50.00%
7 Missing and 2 partials :warning:

:exclamation:  There is a different number of reports uploaded between BASE (f96e181) and HEAD (9bfa960). Click for more details.
HEAD has 108 uploads less than BASE

Flag
BASE (f96e181)
HEAD (9bfa960)

3.0
6
2

community
44
29

integration
65
29

3.2
6
4

3.1
6
4

3.5
6
3

3.4
6
3

3.3
6
4

3.6
6
3

2.4
3
1

2.3
3
0

2.2
3
1

2.8
3
0

2.6
3
1

2.7
3
2

2.5
3
1

2.1
2
0

enterprise
21
0

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #465       +/-   ##
===========================================
- Coverage   59.85%   44.02%   -15.84%
===========================================
  Files          71       71
  Lines        4449     4461       +12
===========================================
- Hits         2663     1964      -699
- Misses       1167     2115      +948
+ Partials      619      382      -237

Flag
Coverage Δ

2.1
?

2.2
19.59% <50.00%> (-29.10%)
:arrow_down:

2.3
?

2.4
19.68% <50.00%> (-29.68%)
:arrow_down:

2.5
19.68% <50.00%> (-29.68%)
:arrow_down:

2.6
19.68% <50.00%> (-29.68%)
:arrow_down:

2.7
36.35% <50.00%> (-14.69%)
:arrow_down:

2.8
?

3.0
36.20% <50.00%> (-18.98%)
:arrow_down:

3.1
41.31% <50.00%> (-15.49%)
:arrow_down:

3.2
41.31% <50.00%> (-15.49%)
:arrow_down:

3.3
41.31% <50.00%> (-15.49%)
:arrow_down:

3.4
43.35% <50.00%> (-15.81%)
:arrow_down:

3.5
39.85% <50.00%> (-17.13%)
:arrow_down:

3.6
39.85% <50.00%> (-17.13%)
:arrow_down:

community
44.02% <50.00%> (-0.03%)
:arrow_down:

enterprise
?

integration
44.02% <50.00%> (-15.84%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Link is missing

The link to the configuration file from the manual is missing.

This has been fixed. For what it's worth there's a lot in that configuration including the use of this plugin https://github.com/geoffjay/dactl-plugin-arduino-udp that's not very well documented.


Add streaming support based on Mongo Change streams

https://www.mongodb.com/docs/manual/changeStreams/

Related https://github.com/haohanyang/mongodb-datasource/issues/29


Whenever I request a song with !play, this error is sent in chat

ERROR: Signature extraction failed: Traceback (most recent call last):
  File "C:\Users\George\AppData\Local\Programs\Python\Python35\lib\site-packages\youtube_dl\extractor\youtube.py", line 997, in _decrypt_signature
    video_id, player_url, s
  File "C:\Users\George\AppData\Local\Programs\Python\Python35\lib\site-packages\youtube_dl\extractor\youtube.py", line 912, in _extract_signature_function
    res = self._parse_sig_js(code)
  File "C:\Users\George\AppData\Local\Programs\Python\Python35\lib\site-packages\youtube_dl\extractor\youtube.py", line 975, in _parse_sig_js
    initial_function = jsi.extract_function(funcname)
  File "C:\Users\George\AppData\Local\Programs\Python\Python35\lib\site-packages\youtube_dl\jsinterp.py", line 239, in extract_function
    raise ExtractorError('Could not find JS function %r' % funcname)
youtube_dl.utils.ExtractorError: Could not find JS function 'wr'
 (caused by ExtractorError("Could not find JS function 'wr'",))

help me please

I am getting the same error. This is a recent problem, as it wasn't happening the last time I used the bot (maybe a week ago). Possibly some change in youtube's side of things?

Solution: Update your dependencies (update_deps.bat)

thanks cutie; if anybody has this issue, go into the music bot folder and look for update_deps.bat and run it as administrator.


Outdated examples

Thanks for the article
I must say it is very detailed, but the thing is that the examples are outdated
While version 2 of the test-app has been published (and is the supported version), the examples are specifically for version 1 of the test-app, and the differences between the DotNet Framework version and the DotNet core are too large (for example in the DotNet Framework project there is the WebConfig file and in the DotNet Core version there is the appsettings.json)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7537a789-92aa-2b04-30bf-028008948c62
Version Independent ID: d07f261b-29af-74af-f5a6-b4f93aaf5bee
Content: Customize claims to be emitted in id_token when using OpenID Connect or OAuth with AD FS 2016 or later
Content Source: WindowsServerDocs/identity/ad-fs/development/Custom-Id-Tokens-in-AD-FS.md
Product: windows-server
Technology: ad-fs
GitHub Login: @anandyadavMSFT
Microsoft Alias: billmath

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Auto-release master/main branch and tags

Master/main -> latest
tags -> numbered release
Automatic release with github actions.
Document development and build steps.

Only need to release the python app, the already compiled driver files should be good enough.

Python app information:
works with:

windows 11
python                  3.9.7
mediapipe             0.8.9
opencv-python     <IP_ADDRESS>
Pillow                    8.4.0
Needs a pipfile and a clean environment for testing.

Building single exe file

pyinstaller               4.6
pyinstaller-hooks-contrib 2021.3

Running the built exe so far was unsuccessful, need to figure out the configuration, 2 problems so far

missing ico file, can be resolved by passing it to --icon and --datas
missing mediapipe graph file, most likely also need to be added to datas


chore(remix): Apply deprecation warnings for remix

Description
We will cater the deprecated properties inside @clerk/backend, so we added a npm run command to the Remix package (for constancy) and we updated an option in an example of an error message.
Checklist

[ ] npm test runs as expected.
[ ] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[x] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[x] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

💯

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


bug: single rabbitmq instances don't need cluster readiness checks

For single instance environments we're using the following overrides on the rabbitmq chart. It also avoids the extra etcd dependency.
auth:
  default_user: rabbitmq
dependencies:
  service:
enabled_plugins:
images:
  pull_policy: Always
replicas: 1

Unfortunately, the cluster readiness probe still runs every 10 seconds. The error is not fatal but is extremely noisy.
07:01:07 [readiness:4188] Starting readiness probe at 2017-03-13 21:57:39
07:01:07 [readiness:4188] Unexpected health-check output, giving the node the benefit of the doubt
07:01:07 [readiness:4188] Error: {{badmatch,{error,"Backend is not configured"}},
07:01:07 [readiness:4188]         [{autocluster,with_startup_lock,1,
07:01:07 [readiness:4188]                       [{file,"src/autocluster.erl"},{line,564}]},
07:01:07 [readiness:4188]          {autocluster,cluster_health_check_report,0,
07:01:07 [readiness:4188]                       [{file,"src/autocluster.erl"},{line,632}]},
07:01:07 [readiness:4188]          {autocluster,cluster_health_check,0,
07:01:07 [readiness:4188]                       [{file,"src/autocluster.erl"},{line,627}]},
07:01:07 [readiness:4188]          {erl_eval,do_apply,6,[{file,"erl_eval.erl"},{line,670}]},
07:01:07 [readiness:4188]          {rpc,'-handle_call_call/6-fun-0-',5,[{file,"rpc.erl"},{line,187}]}]}
07:01:07 [readiness:4188] Ready to return 0
07:01:07 [readiness:4685] Starting readiness probe at 2017-03-13 21:57:49
07:01:07 [readiness:4685] Unexpected health-check output, giving the node the benefit of the doubt
07:01:07 [readiness:4685] Error: {{badmatch,{error,"Backend is not configured"}},
07:01:07 [readiness:4685]         [{autocluster,with_startup_lock,1,
07:01:07 [readiness:4685]                       [{file,"src/autocluster.erl"},{line,564}]},
07:01:07 [readiness:4685]          {autocluster,cluster_health_check_report,0,
07:01:07 [readiness:4685]                       [{file,"src/autocluster.erl"},{line,632}]},
07:01:07 [readiness:4685]          {autocluster,cluster_health_check,0,
07:01:07 [readiness:4685]                       [{file,"src/autocluster.erl"},{line,627}]},
07:01:07 [readiness:4685]          {erl_eval,do_apply,6,[{file,"erl_eval.erl"},{line,670}]},
07:01:07 [readiness:4685]          {rpc,'-handle_call_call/6-fun-0-',5,[{file,"rpc.erl"},{line,187}]}]}
07:01:07 [readiness:4685] Ready to return 0

@wilreichert This looks good.  Thanks for making these changes :)

looks good @wilreichert. thanks for the update!


ISPN-10857 Add infinispan-jboss-marshalling to server distribution fo…

https://issues.jboss.org/browse/ISPN-10857

Merged into master, thanks @ryanemerson


Use HTTPS for external images

This does not cause issue on github, because it proxies the image, but it triggers a mixed content warning on https://roughjs.com


fix: Send created_at in seconds

Customer.io plugin is an OnEvent app which should be running after the event has been ingested into ClickHouse. This means it receives created_at formatted for ClickHouse ingestion instead of as an integer Timestamp.
This PR parses the date input and turns it into an integer timestamp so that it can be ingested into Customer.io.
TODO: tests?

I don't know how to test this either but it seems like a pretty harmless change so I'd just merge it in and ask the customer if the problem is resolved.


Automatic reset attributes when modifying ldap objects

Hi chad,
i have another request for you: the setter methods of ldap objects are not aware about empty values. if you set an attribute with an empty value ('', NULL, []) then the persist process will fail. you have to explicity call the reset() method on attributes to clear (delete) them.
$user->setTitle('');
$user->set('title', '');
$user->title = '';

would it be possible to check the value inside the setters? so if the value is empty, reset an clear the attribute automatically?

This sort of feature has crossed my mind too as I've been making changes in the different attribute converters.  Thanks!


[Enhancement]: Vcpkg support

Current Behavior
Corrosion supports installation via submodule or FetchContent.
Expected Behavior
Vcpkg by default disables FetchContent, while it can be forced to allow it to work, it would be beneficial to provide a port for installing via Vcpkg. The added support is minimal as you already provide installation rules. It is 2 files that are added to the Microsoft vcpkg repo with small updates following a new release.
Steps To Reproduce
No response
Environment
- OS:
- CMake:
- CMake Generator:

CMake configure log with Debug log-level
No response
CMake Build step log
No response

I'm not familiar with vcpkg and currently don't have much free capacity. Corrosion is also available via homebrew, which is maintained by the community and not by me or any of the other maintainers directly. If someone contributed vcpkg support, I would gladly add it to corrosions documentation.

Cool, I can throw it together at some point this week. Do you know when the cmake install rules for the tool were added? I can add backwards compatibility support through that point. I know my use case is on v0.4.5 but I can take it back farther.

The install rules have been there from the beginning - at the very least starting from Corrosion 0.2.
It probably doesn't make much sense to add anything before v0.4 though, since I think v0.3 and before will not work properly on windows with the most recent Rust versions.  Corrosion also follows semver, so I'm not sure sure if there is much value adding v0.4 versions before the latest version (v0.4.7) since there shouldn't be any breaking changes.

The upstream vcpkg PR has apparently been rejected, so I'll be closing this issue.
Just to be clear, from my side I don't object adding corrosion to vcpkg, but I don't see any point in keeping this issue when upstream has rejected the proposal.

Agreed, the PR we applied a few weeks ago covers ensures compatibility with Vcpkg so I should be all set.


Some JSP pages cannot compile when running in OSGI

This issue rasied over at the jetty project belongs here:  https://github.com/eclipse/jetty.project/issues/4834

Fixed via commits:
https://github.com/jetty-project/jasper-jsp/commit/fe7de0ca0715b270d0af2f8a1a857dd32c3d43cc
https://github.com/jetty-project/jasper-jsp/commit/e329273366c7af2bc63d836dab8964bca5930b5e
https://github.com/jetty-project/jasper-jsp/commit/e9c0ddfd96fd46041b22b03b583ed2770eaa2a80

wouldn't it be better to test this via a PR rather than direct commit to master? :P


Resources become reading for binding before their connection secrets are fully populated

What happened?
Removing speculative requeueing from the resource claim controllers in #545 uncovered a race when writing and propagating connection secrets. Some managed resource types take a handful of requeues in order to fully populate their connection secrets. This was not an issue when the resource claim controller continually requeued, copying the managed resource connection secret to the claim connection secret each time resulting in eventual consistency.
Now that the resource claim controller watches managed resources instead of speculatively requeueing it will propagate the managed resource’s connection secret when the managed resource becomes ready for binding, but will not make any further attempts to copy the secret until either the managed resource changes or the global watch sync occurs. This can result in partially populated resource claim connection secrets existing for some time. The Azure SQL controllers and all Redis controllers are affected by this issue. I believe this is a bug in the managed resource controllers, and thus should be fixed in a separate PR.
How can we reproduce it?

Create a MysqlServer, PostgresqlServer, ReplicationGroup, Redis, or CloudMemorystoreInstance concrete resource via their relevant resource claim. Inspect the resource claim's connection secret immediately after the claim is bound; it will likely be missing critical information such as the endpoint, password, etc. This information can take up to the sync interval (one hour by default) to propagate.
What environment did it happen in?
Crossplane version: fb183a8

I've added this to the v0.3 milestone, hoping we can address this soon

I was worried about missing this issue for 0.3, but I see it's part of the milestone and actually seems to be mostly fixed. I believe:

https://github.com/crossplaneio/crossplane/pull/721 fixed this for the Azure database kinds.
https://github.com/crossplaneio/crossplane/pull/603 fixed this for AWS ReplicationGroups.
https://github.com/crossplaneio/stack-gcp/pull/4 will fix this for GCP CloudMemorystoreInstances.

This means the Azure Redis controller is the only one known to have this bug. I recall that controller was quite simple, so it may be worth fixing it by prioritising porting it to the generic managed resource reconciler.


Unauthorised images in viewer

This may be a silly idea, hence the draft PR, but I'd be interested in people's thoughts
Background
We had an inquiry over the weekend (16th - 17th Dec, 2023) about a work which is not displaying it's images. The image urls are returning '401 Unauthorized'.
A slack discussion about this issue explains that this is because "a bunch of Genetics Books" have some restrictions in place which ultimately means their images have a maxUnauthorised value set to 1000. Because we try and request images that are larger than this, those requests fail as unauthorised.
This is a policy rather than a technical issue and could be fixed by relaxing the rules (dating back to 2012) which restrict the image size.
In lieu of that solution:
What this PR does
If an image fails to load in the viewer, we try to load an image with it's longest dimension set to 1000px.
Before:

After:

Wowza! Decent fix for a problem that might be better making go away upstream. I think if we can relax the requirement as Digirati have suggested we should do that rather than add a change here, however it it seems like it might take time or be difficult to change then this is a decent workaround (and nice that the comments here point out the issue).

Agree that the policy change would be the way to go if possible, but, as you mention, just wasn't sure how easy/quick that would be

I agree the fix sounds logical and love the comments. Should we add a test around this?

Will deploy this the first week in Jan.
I've emailed the inquirer back with an update


Update utils.js

fixed a broken link
Before submitting a pull request, please make sure the following is done:

Fork the repository and create your branch from master.
Run yarn in the repository root.
If you've fixed a bug or added code that should be tested, add tests!
Ensure the test suite passes (yarn test). Tip: yarn test:dev is helpful in development.
Format your code with prettier (yarn prettier).
Run the Flow typechecks (yarn flow).

Thanks for the fix.


BUG: Remove no output warning in ImageSink filters

Filters derived from the ImageSink class frequently do not have a
primary output. This warning was emitted erroneously during the
PrintSelf method.
This issue was reported in SimpleITK/SimpleITK#1141.

PR Checklist

[x] No API changes were made (or the changes have been approved)
[x] No major design changes were made (or the changes have been approved)
[x] Added test (or behavior not changed)
[x] Updated API documentation (or API not changed)
[x] Added license to new files (if any)
[x] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[x] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

Merge?


A hacky approach for regexpr rewrite

This pr rewrites GpuRLike to GpuStartsWith for a special case with a hacky approach.
A general way will be to change RegexParser instead of string when overriding.
And the rewrite is actually wrong, we can't rewrite rlike abc(.*) to startsWith abc because the pattern can occur anywhere in the string. Only rlike ^abc(.*) can be rewritten. I did it intentionally wrong specifically for a customer's sql.

Will merge it to main, close now.


Is it possible to change IP

Hello, great project!!!
I noticed that every time I start, I get a different IP for the duration of the entire project launch.
Is it possible to change IP, for example by time or external command call? We need rotation.

Hello! Thanks!
Such feature is not implemented. I think hola-proxy will suit your needs better because it has larger choice of countries and servers. Both hola-proxy and opera-proxy have -list-proxies option which allows to export list of proxies and credentials to rotate them as you need. However, direct use of proxies exported by opera-proxy is tricky: #7 That's another reason to use hola-proxy for your purpose.

I want to share my own method for Rotate proxy with python 3
It does not cause any problems up to about 500,000 requests per day.
`import os
import time
import requests
import itertools
requests.packages.urllib3.disable_warnings()
def run_exe(exe_path):
username = ""
password = ""
p = os.popen(exe_path)
time.sleep(5)
for line in p:
if "Proxy login:" in line:
username = line.split(":")[1].strip()
if "Proxy password:" in line:
password = line.split(":")[1].strip()
p.close()
if username == "" or password == "":
return False
return username, password
proxy_data = run_exe("proxy.exe -country EU -list-proxies")
if not proxy_data:
print("Proxy Error")
exit()
proxy_username, proxy_password = proxy_data
All location opera proxy ip list.
proxy_list = ["<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443",
"<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443", "<IP_ADDRESS>:443"]
proxy_list_cycle = itertools.cycle(proxy_list)
for i in range(1, 10):
selected_proxy = {
"https": "https://" + proxy_username + ":" + proxy_password + "@" + next(proxy_list_cycle),
"http": "https://" + proxy_username + ":" + proxy_password + "@" + next(proxy_list_cycle)
}
response = requests.get("https://api.ipify.org/?format=json", proxies=selected_proxy, verify=False)
print(response.text)
`


feat: add additional input parameters and child module for App Insights AVM module

Description
closes #895
Pipeline

Adding a new module

[ ] A proposal has been submitted and approved.
[ ] I have included "Closes #{module_proposal_issue_number}" in the PR description.
[ ] I have run brm validate locally to verify the module files.
[ ] I have run deployment tests locally to ensure the module is deployable.

Updating an existing module

[ ] This is a bug fix:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] I have run brm validate locally to verify the module files.
[x] I have run deployment tests locally to ensure the module is deployable.
[x] I have read the Updating an existing module section in the contributing guide and updated the version.json file properly:

[ ] The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json.
[x] The PR contains backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] The PR contains breaking changes, and I have bumped the MAJOR version in version.json.

[x] I have updated the examples in README with the latest module version number.

Hey @tyconsulting, thanks for your contribution. @krbar will review it once he's back in the office :)
We're on it.

Hello @tyconsulting, nice contribution, thank you! Looks good to me, I just added a small suggestion to align the deployment name of the child module to the other. A re-generation of the ARM file will be needed. Please also re-run the workflow after the change.

hi @krbar thanks for reviewing this PR. I have updated it as per your suggestion. Please take another look. here's the result of the latest pipeline run:

@Azure/avm-core-team-technical-bicep PR is fine from my point of view and can be merged, please approve.


Example 1 is mostly inaccurate.

I just tried the code form example 1 and had to remove almost every parameter. I could only use "-name" and "-SourceMailboxes". All the rest gave me an error, "A parameter cannot be found that matches parameter name"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c994114-5ddc-27b5-dcd4-88ddfdf8c9d3
Version Independent ID: 126d4801-9617-e8f6-49cb-76feff8f4dd2
Content: New-MailboxSearch (exchange)
Content Source: exchange/exchange-ps/exchange/policy-and-compliance-content-search/New-MailboxSearch.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

@marshalanson, are you using Exchange Online or a specific version of Exchange Server? According to the topic, Also, does your account have the Mailbox Search role assigned to it (likely through a role group membership)? The Mailbox Search role isn't assigned to the Organization Management role group (administrators) by default.
I copy/pasted the example in ExO tenant and Exchange 2016, and the only error I got was about (naturally) non-existent recipients.

I am running on-prem 2016. My account has mailbox search permissions. I can create a search no problem. My issue is, the command parameters are no longer available. Try that command again, but with a live user.

@marshalanson, I used live mailboxes and the command worked just fine; no errors. I ran the following command, and every parameter in Example 1 was available to me (I sorted the output and removed common parameters for clarity).
[PS] C:\>(get-command New-MailboxSearch).parameters | ft Key

Key
---
AllPublicFolderSources
AllSourceMailboxes
Confirm
Description
DomainController
EndDate
EstimateOnly
ExcludeDuplicateMessag
Force
InPlaceHoldEnabled
InPlaceHoldIdentity
IncludeKeywordStatisti
IncludeUnsearchableIte
ItemHoldPeriod
Language
LogLevel
MessageTypes
Name
Recipients
SearchQuery
Senders
SourceMailboxes
StartDate
StatusMailRecipients
TargetMailbox
WhatIf


Add support to set KEDA_HTTP_DEFAULT_TIMEOUT in metrics server

We have KEDA deployed using helm, and we use several RabbitMQ Scalers with regex selection. Our problem is that some triggers needs to customize the KEDA_HTTP_DEFAULT_TIMEOUT to extend the default values because get the queues using regex needs 5-10 seconds in some cases (we have more than 1k queues in some clusters).
Right now it's supported the configuration of it in the operator but not in the metric server
I can open a PR with the change if you agree it

Sounds good, thanks!

Would you mind adding this env (with the default value) to the kedacore/keda as well? Both Operator and Metrics server? Thanks!

Would you mind adding this env (with the default value) to the kedacore/keda as well? Both Operator and Metrics server? Thanks!

I will take a look there also, np, but I think that I am using it right now 😆 .
At least, I edited the deployment manually and now I'm not getting any error but idk if the RabbitMQ cluster is responding faster for idk why xD

Yeah, it is being set there, but I mean to add it to Deployment spec, so it is there "visible" for users.

Sorry but I don't get the requirement :/
do you want to set it as default in kedacore/keda for example in the Dockerfile?
I'm a bit confused with the last message about adding it to Deployment spec, in the chart?

The Helm Chart entry is being applied to Operator Deployment and similar place for Metrics Server:
https://github.com/kedacore/keda/blob/fe032ccc41f1af1aa4dcdcf4f1d05bba9150fdbf/config/manager/manager.yaml#L57
I wanted to put the ENV in there as well, for users that don't use Helm Charts to install KEDA. So the Env is visible there. But it is not important and maybe we can skip that for now.

oh... I got it! I will do it also as part of this task :)

I think this issue should still be opened, the main goal is not merged yet (support it in helm).
wdyt @zroubalik ?

Yeah, GitHub closed this automatically. thanks!


using @rjsf/mui with layout

I am wnating to control the layout of my form a little better and this seem like the right tool.
I am using MUI for the styling of the components and is implemented in a "Form" component
If I use that component with the inner fields I get an error (obviously) and if I use the "Form" component from this library I get the layout and no styling, Is there a way that this works with the mui styling
Thanks

Hello John! I use MUI myself for most projects, many utilizing rjsf-layout and everything works smoothly. Can you provide a minimal reproduction to help me better-understand what is going on? Thanks!


fix(client-go): fix webbrowser merge error

The webbrowser code was moved to it's own package, but the windows fix pr was created from a point in time before that, so while the PR merged properly it didn't take the move into account.

Code LGTM.

Code LGTM


Hardware cursor visible while pointing at edge pixels

While pointing at pixels at the edge of the screen, the hardware cursor is visible.  The following linked video portrays this issue.
https://www.youtube.com/watch?v=-dJioE8i-58

It's how the software cursor works right now. It's a difficulty with OpenTK and I'm going to try solving this at a later time.

The fix I wrote for #276 should also resolve this issue, can you please test it and let me know if this works for you?

I have tested this myself and I could no longer see the hardware cursor when pointing at the window edges. I consider this issue resolved.

Yup, confirmed.


luci-app-adblock: Fix display issues with translation

Fixed display issues when applying translation.
Signed-off-by: INAGAKI Hiroshi<EMAIL_ADDRESS>

@dibdot  FYI


fix: milvus _get_docs_by_ids

Goals:
This PR is related to issue #857

[x] codes
[ ] add related test

Codecov Report
Base: 81.02% // Head: 66.96% // Decreases project coverage by -14.05% :warning:

Coverage data is based on head (c325629) compared to base (5fce6b6).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #859       +/-   ##
===========================================
- Coverage   81.02%   66.96%   -14.06%
===========================================
  Files         138      138
  Lines        7067     7066        -1
===========================================
- Hits         5726     4732      -994
- Misses       1341     2334      +993

Flag
Coverage Δ

docarray
66.96% <0.00%> (-14.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

docarray/array/storage/milvus/getsetdel.py
64.17% <0.00%> (-32.88%)
:arrow_down:

docarray/array/mixins/dataloader/helper.py
0.00% <0.00%> (-100.00%)
:arrow_down:

docarray/array/mixins/delitem.py
11.11% <0.00%> (-75.56%)
:arrow_down:

docarray/array/mixins/io/csv.py
23.68% <0.00%> (-65.79%)
:arrow_down:

docarray/array/storage/redis/getsetdel.py
31.42% <0.00%> (-64.29%)
:arrow_down:

docarray/array/mixins/plot.py
7.79% <0.00%> (-60.18%)
:arrow_down:

docarray/array/storage/elastic/getsetdel.py
39.68% <0.00%> (-58.74%)
:arrow_down:

docarray/array/mixins/sample.py
45.45% <0.00%> (-54.55%)
:arrow_down:

docarray/array/mixins/io/pushpull.py
23.27% <0.00%> (-52.59%)
:arrow_down:

docarray/array/storage/base/getsetdel.py
40.41% <0.00%> (-45.90%)
:arrow_down:

... and 48 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: Guard against NoneType value when using group in Amazon hub parsing

Proposed change

Fix NoneType error when Amazon Hub is in use
Type of change

[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests
[ ] Documentation update
[ ] Adds a new shipper
[ ] Update existing shipper

Additional information

This PR fixes or closes issue: fixes #568

Codecov Report

Merging #569 (7f283a3) into dev (8ce7846) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head 7f283a3 differs from pull request most recent head bba46e1. Consider uploading reports for the commit bba46e1 to get more accurate results

@@           Coverage Diff           @@
##              dev     #569   +/-   ##
=======================================
  Coverage   98.92%   98.92%
=======================================
  Files           6        6
  Lines        1298     1300    +2
=======================================
+ Hits         1284     1286    +2
  Misses         14       14

Impacted Files
Coverage Δ

custom_components/mail_and_packages/helpers.py
99.57% <100.00%> (+<0.01%)
:arrow_up:


First draggable shape clean not working

This bug is because storeLast is called when the canvas desnt have the correct dimension.
What's need to be done is to handle resize on the shapeManager: force canvasManager new Dimension, store last and redraw shapes


diamond: Implement canonical-data.json

We want to have a standard set of test inputs and outputs for each exercise to
make it easier to port them to new languages, as well as to help keep the
exercises in sync.
The Diamond exercise can be found in the ./exercises/diamond/ directory.
The step-by-step instructions for how to compile a canonical-data.json file is
described in this section of the contributing guide.
See http://exercism.io/contribute/canonical-data/diamond for the up-to-date list of
language tracks that have an implementation of the Diamond exercise.
The tracking issue has more context.

I'll happily pick this issue up: I recently built the exercise for the Java track and so surveyed the existing implementations.

And while we're on the discussion, I'll go ahead and say it can be interesting to encourage tracks to use some property-based testing rather than example-based testing, as indicated in the discussion of the PR that introduced the exercise: https://github.com/exercism/x-common/pull/191#issuecomment-254378776

Mmm, interesting. I am not sure how best to capture "write tests according to this philosophy if possible, but if not according to this other philosophy" in the existing canonical data structure. Any suggestions?

Me neither! Adding another facet to this problem, the property-based philosophy is at best unnatural to encode into JSON. I imagine that at best it would only be able to include something like the bulleted list in the README and then it is up to the individual tracks to implement the actual checks. In contrast, example-based tests are very easy to encode.
Indeed, in the domino problem, there is also the choice between example-based testing (true or false) versus property-based testing (https://github.com/exercism/x-common/blob/master/exercises/dominoes/canonical-data.json#L27). The best I came up with at the time was to leave a very lengthy comment in the file.
Even today I do not have a better suggestion. It may be that the example-based tests can go in the JSON file, with a comment saying "try out property-based testing".

Interesting problem. What I did when I created this exercise, is to setup the tests such that they could be solved using regular example based tests (using a couple of standard input letters), but that they are actually perfectly suited to property-based testing.
For example, I have a test Diamond has square shape, which is clearly a property test. For the F# track, I then chose not to use an actual full-fledged property-based testing framework, but to simply use parameterized tests with the parameterized values being the characters from 'a' to 'z'.
Maybe the best we can do is say something about how track implementers could try to write property-based tests when implementing it?

Existing implementations:
xcsharp
xecmascript
xelixir
xfsharp
xgo
xjava
xjavascript
xlua
xpython
xruby

Observations:

3/10 implementations use property-based testing; 7/10 use value-based
4/10 implementations test both boundaries (A and Z)
5/10 implementations test exactly the cases from the problem description, A, C, and E, and therefore never test an "even" letter (A, C, and E have positions 1, 3, and 5 within the alphabet)

I have to admit, this problem was my first exposure to property-based testing! It's an interesting approach. I'm not sure that the existing problem description, which describes the desired output in terms of its properties, is ideal - it doesn't really suit languages that currently use value-based testing. I'd be interested in making the description more "typical", and leaving it up to each track to decide whether this is an appropriate place to introduce the concept of and tooling around property-based testing. In terms of the canonical test data; I'm on board with @petertseng's suggestion to describe typical value-based tests, and use the canonical data's description block as a way to nudge implementors towards a property- based approach if they are feeling adventurous.

If using value-based testing, the following cases seem sufficient:

A (unique case: only one 'A' row)
B (unique case: no spaces between the central row of characters)
C (smallest typical case for an "odd" character)
D (smallest typical case for an "even" character)
Z (boundary case)

@stkent I think having those five test cases should indeed be sufficient. As long as we state somewhere in the comments that this exercise's test suite could also use property-based testing, I think it very much makes sense to use the value-based tests for the canonical data.

@ErikSchierboom awesome; how does the comment in https://github.com/exercism/x-common/pull/612 look to you?

@stkent Nothing to add, looks perfect to me! Great work. :thumbsup:


Support mail search folder

Support mail search folder requests:

List
List all messages
Get
Create
Update
Delete

Reference: mail search folder resource type

This is covered by mail folders since these is the same URLs.


feat(test): add target to update the tests

@JohelEGP - let me know when this is ready for review

I think it already is.

I think it already is.

Okay, cool -- I just saw you were still pushing changes yesterday.


docs don't say anything about where to place the babel config

I want to add some optional flags like bluebirdCoroutines, but the docs don't make it obvious how to.
using babel().transform("code", { optional: ["bluebirdCoroutines"] })  like the normal library, results in undefined is not a function.

OK, I saw the options bit, doh, which implies this should work:
        .pipe(babel({optional: ['es7.asyncFunctions']}))
but it doesn't...
I still get
Users/mgenev1271/Projects/ape-poll-service/lib/handlers/poll/questions.js:21
            handler: async function(request, reply) {
                           ^^^^^^^^
SyntaxError: Unexpected token function
    at exports.runInThisContext (vm.js:73:16)
    at Module._compile (module.js:443:25)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/mgenev1271/Projects/ape-poll-service/lib/handlers/index.js:8:17)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)```


Add: Helper Scripts

Description
Adds yarn clean and yarn test as helper scripts to the root level package.json
Type of Change

Non breaking change ('update', 'change')

Usage
yarn test packages/manager/src/App.test.tsx to run one test
yarn clean to remove top-level and package-level node_modules

@johnwcallahan addressed


Question about I2C driver for this joystick

Hi, I wanted to assembly joystick according to your project. I'm having a problem with the driver. It compiled, but the device is still not available. Maybe I did something wrong, help me figure it out please.

Hi!
Of course I can help :)
Did you check that the I2C is working on the raspberry?
https://learn.adafruit.com/adafruits-raspberry-pi-lesson-4-gpio-setup/configuring-i2c : with i2cdetect you should see the arduino at address 0x18.
It's an old project, so there might be some bugs (and I never finish the power switch stuff).

OK, device in Retropie appears at 0x18. Next, I copy the folder with the driver files to the Raspberry / home folder, then the make command and then I don’t know what to do.

The program run i2c-joystick-driver should poll the arduino for input event, and then to a an emulated input device.
So when you run it, a new joystick should appear on your system.
To start it in background mode just run ./i2c-joystick-driver & from the source directory.
But I think it should be used as a daemon to start it automatically with the system.
Which distribution are you using?
You can try to run jstest /dev/input/js0 while i2c-joystick-driver to see if the different buttons are working.

Hi
I added ./i2c-joystick-driver & to startup and the system detected one game device. I use Retropie 4.5. But the joystick buttons are not pressed. The I2C device is discovered at address 0x18, but the device at address 0x68 is also detected. jstest /dev/input/js0 does not detect keystrokes. System shutdown often occur spontaneously. If turn off the Atmega328 or change the address, spontaneous shutdown disappears.
I am not good at programming code, so all hope is for your advice.

Hi!
When you said "but the device at address 0x68 is also detected", is it still detected when the arduino is powered off? (it might be another I2C device inside your computer at address 0x68).
And how did you wire the button on the arduino?
To prevent the system shutdown, you can try to change ligne 261 in i2c_gamepad.ino to
stateFunction = runState;
and change ligne 157 to:
if(0) {
(instead of if(powerSwitchHasBeenReleased && powerSwitch.state == LOW && millis() - powerSwitchPressTime > 4000) {)

I changed lines 157 and 261 as You recommended and the buttons worked. I will move on. Thanks for answers!

Great! :)
The arduino wasn't in the right mode (it was in standby mode), and that's why it wasn't working as expected. I might change that and push a fix.
I'm wondering in what kind of project you are using it? Is it for a portable pi console?

Yes. Raspberry CM3 based portable console. LCD 4.3" DPI mode.

Hi
I don’t understand how the hat is connected. How to convert a hat from analog to digital buttons? I am not using volume control and these pins are free.

Seems like a very interesting project :)
Did you make a custom PCB for the compute module? That's what I wanted to do, but I never took time to finish my prototype back then! DPI screen is a really nice feature! Will you make it a public project?
For the "analog" hat wiring, I was using a voltage divider (0, 2.5v, 5v) for hat axis. But I just push a commit which should allow you to use digital pin instead for the hat (pin 20, 21, 16, 17, look lines 58 to 61) and disable volume control (and power management too).
At the top of the ino file I added compilation  configuration:
#define USE_VOLUME_BUTTON 0
#define USE_ANALOG_HAT 0
#define USE_POWER_FUNCTION 0
You can leave all of them to 0 in your case.

Hi
Thanks for your responsiveness.
At the moment this is a prototyping board. From the interesting will be the use of the ALC5628 DAC. I've spent some time studying it. DPI mode will occupy the entire GPIO Bank0.

This will be a public project, but maybe I'll be making kits for sale.

Up, down, left, right buttons are not defined by the system. I think the reason is in the driver, there they are not declared anywhere.

Hey!
 I wrote this I2C joystick driver a while ago, and never really finish the project... so I'm happy to know it could be useful to someone else :)
A DAC for audio is a really nice feature! I wanted to use a TDA1543 (hard to find the I2S one).
And you were right, the dpad event wasn't handle in the driver code! I just fixed it, and a push a new commit.
I couldn't test it, so I hope it works.
In linux DPad can be handle as button events or analog axis (xbox 360 gamepad for example generate axis event), so I added a compile option in i2c-joystick-driver.c (line 12, #define USE_ANALOG_DPAD 0) to use either one mode or the other.
Set it to 0 and it will generate button event (which I think should be fine for retropie)

Hi
The file JoystickDevice.c also needed to be fixed. I did it myself. Everything is working! Thanks! I'll keep you up to date.

Oh, did I forgot to register DPAD_BTN_*?
ret |= ioctl(fd, UI_SET_KEYBIT, BTN_DPAD_UP);
ret |= ioctl(fd, UI_SET_KEYBIT, BTN_DPAD_DOWN);
ret |= ioctl(fd, UI_SET_KEYBIT, BTN_DPAD_LEFT);
ret |= ioctl(fd, UI_SET_KEYBIT, BTN_DPAD_RIGHT);
If you want to make a merge request I'll accept it ;) (or I can fix it with a commit).
I'd love to be updated on your project! :) Thank you!

Hi! Thanks for the help! I never wrote but I was trying to finish this project but i had the same doubts as the other user. I'll prove what you said.
What and how is the use of the pwr mosfet gate pin? Thank you!

Hey!
 I should provide more information for the arduino code.
The power mosfet pin should be used to power on and off the raspberry pi. I can't remember if I tested or implemented it yet.
I wanted to make the arduino able to manage raspberry pi power state, but there may be other way of doing this now?


The target has transitive dependencies that include static binaries

Bug report
Summary
Maps is not building for iOS with SFLoginPods also included
Environment info
  react-native: 0.63.4
  react: 16.13.1
  react-native-maps: 0.28.0

Target Platform: eg: iOS - 13 Simulator/iPhone 12 using Google Maps

react-native info output:
System:
OS: macOS 11.3.1
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 353.87 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 14.15.1 - /usr/local/bin/node
Yarn: 1.22.10 - /usr/local/bin/yarn
npm: 6.14.8 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.5, DriverKit 20.4, macOS 11.3, tvOS 14.5, watchOS 7.4
Android SDK: Not Found
IDEs:
Android Studio: 4.2 AI-202.76<IP_ADDRESS>22048
Xcode: 12.5/12E262 - /usr/bin/xcodebuild
Languages:
Java: 15.0.2 - /usr/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: Not Found
react-native: Not Found
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
      react-native: 0.63.4
      react: 16.13.1
      react-native-maps: 0.28.0

Steps to reproduce

we have Salesforce mobile sdk dependency included in package.json as
"sdkDependencies": {
"SalesforceMobileSDK-Android": "https://github.com/forcedotcom/SalesforceMobileSDK-Android.git#v9.0.0",
"SalesforceMobileSDK-iOS": "https://github.com/forcedotcom/SalesforceMobileSDK-iOS.git#v9.0.0"
}
Pod install
While building for iOS vis Xcode we run into below error
[!] The 'Pods-SFLoginRN' target has transitive dependencies that include statically linked binaries: (/Users/tavant/Documents/ABC/sloginrn/SFLoginRN/ios/Pods/GoogleMaps/Base/Frameworks/GoogleMapsBase.framework, /Users/tavant/Documents/ABC/sloginrn/SFLoginRN/ios/Pods/GoogleMaps/Maps/Frameworks/GoogleMaps.framework, and /Users/tavant/Documents/ABC/sloginrn/SFLoginRN/ios/Pods/GoogleMaps/Maps/Frameworks/GoogleMapsCore.framework)

When changed provider to Apple it works. But we are looking for using Google Maps.

I'm going to close this for now, as I'm not really sure anyone on here will be able to help. If you believe that this is still relevant and caused by react-native-maps, please feel free to open a new issue. I hope you worked it out :)


AVRO-3853: [Rust] Support Local timestamp logical types for Rust SDK

AVRO-3853
What is the purpose of the change
Local timestamp logical types are missing in the Rust SDK.
It's nice to support them.
Verifying this change
Added new tests and modified existing tests.
Documentation

Does this pull request introduce a new feature? (no)

Thank you, @sarutak !

@martin-g
Thank you always!


Does not load related dlls.

It loads lazyLoaded.dll successfully when copied in _framework/_bin but it requires an other dll named 'netstandard.dll' which I think is being resolved incorrectly. In first place there should be a solution to build and copy all lazyload dlls.

Are you refering Sample or your own test case?
LazyLoaded.dll from sample references mscorlib, Microsoft.AspNetCore.Components and Microsoft.Extensions.DependencyInjection.Abstractions. All of those are already loaded in AppDomain during the main assembly (BlazorApp) load. MetadataAssemblyDependencyResolver watches for already loaded assemblies and should not try to load those referenced assemblies.
Please note: The assembly in Samples\01\LazyLoadedArea\bin\...\netstandard2.1\LazyLoaded.dll (1) differs from the one in Samples\01\LazyLoadedArea\bin\...\netstandard2.1\dist\_framework\_bin\LazyLoaded.dll (2). The first one is build with standard compiler (and references netstandard) while the second one is optimized to be used in Mono (and references mscorlib). You need to use the second one; unfortunatelly this was not described well in Usage section, hopefully it's clearer now.
If you'd like to use not linked version, you need to copy all referenced/needed assemblies manually, this is not in the solution scope.
Did that help or can you describe your case deeper for further investigation?

Thanks for the answer. It helped.


Battery Module

It would be great to see the battery level percentages of laptops with an icon that changes depending on its level.

It will not be implemented right now.


hack: Gather the InstallPlan resources in the test metering namespace.

/retest

Welp, not entirely sure what's happening here. It looks like the test cluster is using a 1.18.x kubelet/node/apiserver, but this is still being rendered as a 1.17.0 server version. After some light investigation, it looks like OLM determines this using a discovery client, so that shouldn't be an issue. Probably need to ping DPTP for further investigations as I imagine we're not the only component getting hit by this.
- group: operators.coreos.com
    kind: ClusterServiceVersion
    message: 'CSV version requirement not met: minKubeVersion (1.18.0) > server version
      (1.17.0)'
    name: metering-operator.v4.6.0
    status: PresentNotSatisfied
    version: v1alpha1

/retest

Okay, looks like these recent e2e failures are due to a recent rebase with the openshift apiserver. Just going to force-merge this change for now as it's purely for test debugging.


storage-driver btrfs not supported

BUG REPORT
/kind bug
Podman is refusing to work with btrfs as storage-driver

Steps to reproduce the issue:
Easy way:
Specify desired storage driver as parameter
podman --storage-driver btrfs info
"Right" way:

adjust storage.conf

Change
[storage]
  driver = "vfs"

to
[storage]
  driver = "btrfs"

Empty $HOME/.local/share/containers/storage/

Make sure $HOME/.local/share/containers/storage/
is emtpy or emtpy it

run podman info or any other podman comand
podman info

Describe the results you received:
ERRO[0000] Failed to GetDriver graph btrfs /home/koko/.local/share/containers/storage
Error: could not get runtime: failed to GetDriver graph btrfs /home/koko/.local/share/containers/storage: driver not supported
Describe the results you expected:
Podman info page, something similiar to the vfs version:
host:
BuildahVersion: 1.12.0
CgroupVersion: v1
Conmon:
package: 'conmon: /usr/libexec/podman/conmon'
path: /usr/libexec/podman/conmon
version: 'conmon version 2.0.10, commit: unknown'
Distribution:
distribution: neon
version: "18.04"
IDMappings:
gidmap:
- container_id: 0
host_id: 1000
size: 1
- container_id: 1
host_id: 100000
size: 65536
uidmap:
- container_id: 0
host_id: 1000
size: 1
- container_id: 1
host_id: 100000
size: 65536
MemFree:<PHONE_NUMBER>
MemTotal:<PHONE_NUMBER>2
OCIRuntime:
name: runc
package: 'containerd.io: /usr/bin/runc'
path: /usr/bin/runc
version: |-
runc version 1.0.0-rc8+dev
commit: 3e425f80a8c931f88e6d94a8c831b9d5aa481657
spec: 1.0.1-dev
SwapFree:<PHONE_NUMBER>
SwapTotal:<PHONE_NUMBER>
arch: amd64
cpus: 4
eventlogger: journald
hostname: skopelos
kernel: 5.3.0-28-generic
os: linux
rootless: true
slirp4netns:
Executable: /usr/bin/slirp4netns
Package: 'slirp4netns: /usr/bin/slirp4netns'
Version: |-
slirp4netns version 0.4.3
commit: unknown
uptime: 9h 4m 0.5s (Approximately 0.38 days)
registries:
search:

docker.io
quay.io
store:
ConfigFile: /home/koko/.config/containers/storage.conf
ContainerStore:
number: 0
GraphDriverName: vfs
GraphOptions: {}
GraphRoot: /home/koko/.local/share/containers/storage
GraphStatus: {}
ImageStore:
number: 0
RunRoot: /run/user/1000/containers
VolumePath: /home/koko/.local/share/containers/storage/volumes

Additional information you deem important (e.g. issue happens only occasionally):
just in comparison: Docker detects btrfs automagically, uses that btrfs storage driver and works as expected.
Output of podman version:
Version:            1.7.0
RemoteAPI Version:  1
Go Version:         go1.10.1
OS/Arch:            linux/amd64

Output of podman info --debug:
If (btrfs is set in storage.conf):
ERRO[0004] Failed to GetDriver graph btrfs /home/koko/.local/share/containers/storage
Error: could not get runtime: failed to GetDriver graph btrfs /home/koko/.local/share/containers/storage: driver not supported

Podman info --debug (with vfs):
debug:
  compiler: gc
  git commit: ""
  go version: go1.10.1
  podman version: 1.7.0
host:
  BuildahVersion: 1.12.0
  CgroupVersion: v1
  Conmon:
    package: 'conmon: /usr/libexec/podman/conmon'
    path: /usr/libexec/podman/conmon
    version: 'conmon version 2.0.10, commit: unknown'
  Distribution:
    distribution: neon
    version: "18.04"
  IDMappings:
    gidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
    uidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
  MemFree:<PHONE_NUMBER>
  MemTotal:<PHONE_NUMBER>2
  OCIRuntime:
    name: runc
    package: 'containerd.io: /usr/bin/runc'
    path: /usr/bin/runc
    version: |-
      runc version 1.0.0-rc8+dev
      commit: 3e425f80a8c931f88e6d94a8c831b9d5aa481657
      spec: 1.0.1-dev
  SwapFree:<PHONE_NUMBER>
  SwapTotal:<PHONE_NUMBER>
  arch: amd64
  cpus: 4
  eventlogger: journald
  hostname: skopelos
  kernel: 5.3.0-28-generic
  os: linux
  rootless: true
  slirp4netns:
    Executable: /usr/bin/slirp4netns
    Package: 'slirp4netns: /usr/bin/slirp4netns'
    Version: |-
      slirp4netns version 0.4.3
      commit: unknown
  uptime: 9h 10m 40.41s (Approximately 0.38 days)
registries:
  search:
  - docker.io
  - quay.io
store:
  ConfigFile: /home/koko/.config/containers/storage.conf
  ContainerStore:
    number: 0
  GraphDriverName: vfs
  GraphOptions: {}
  GraphRoot: /home/koko/.local/share/containers/storage
  GraphStatus: {}
  ImageStore:
    number: 0
  RunRoot: /run/user/1000/containers
  VolumePath: /home/koko/.local/share/containers/storage/volumes

Package info (e.g. output of rpm -q podman or apt list podman):
Listing... Done
podman/unknown,now 1.7.0~5 amd64 [installed]

Additional environment details (AWS, VirtualBox, physical, etc.):
physical xbuntu (KDE neon)
Release: 18.04
Codename: bionic

This is an issue with the way the package was built, the BUILD TAGS are disabling btrfs support.

@lsm5 @jnovy PTAL

Please open a bugzilla with the distro that you got the package from.

@rhatdan the package is from the open side build server as described in the installation docs. The problem remains with podman 1.8.0-2 .. distro is Ubuntu lts 18.04 as described in the initial text

Reopening, we do handle OBS issues here for lack of a better venue

@delight should be fixed by 1.8.0~5, will be available in an hour or less. Please re-open if it doesn't.

@lsm5 just tryed 1.8.0~5 and 1.8.0~6
Both are able to start the btrfs storage drive.
Downloading the image and starting a container works. Podman creates subvolumes in btrfs as expected.
Removing thou won't work correctly.
Simplest way of reproducing the error is something like
podman pull ubuntu
and then trying to delete it again
podman rmi ubuntu
result in
Error: remove /home/koko/.local/share/containers/storage/btrfs/subvolumes/27b97a061bd85ff57a9e5a6d40205f5c600d09319d23baaf69a4f0bd468c0ae7: operation not permitted
This behavior results ultimately in a bunch of unexpected errors e.g.:

When a container is created and deleted again
ERRO[0024] Error removing container a8819fc16eef827bca67f8642dda849f78000c07d1b4fe893c8f1926afd53c3f: error removing container a8819fc16eef827bca67f8642dda849f78000c07d1b4fe893c8f1926afd53c3f root filesystem: remove /home/koko/.local/share/containers/storage/btrfs/subvolumes/53f23057d3f31b4992ff75faa784cbb3f8d3ef275b61eab04ecccc216bb0df94: operation not permitted

and even though podman ps -a is an empty list podman rmi ubuntu will result in an error like:
A container associated with containers/storage, i.e. via Buildah, CRI-O, etc., may be associated with this image: ccc6e87d482b
Error: image is in use by a container

When trying to remove a just downloaded image the initially described permission error occurs ... now the image is not in the list anymore podman image ls but when trying to download the image again it acts like the image layers are already there ... resulting in wrong image.

Only workaround I found is to remove the btrfs subvolumes after removing something with podman ... though this is not really a workaround because you won't be able to tell easily which subvolume hash is associated with a certain image or container.
tltr;
In general the btrfs storage driver is loading but it is unusable because of the problem with not removing the created subvolumes

I guess the problem is already known see #3963
something around https://github.com/containers/storage/blob/1c8d809f3db40ab852112332457e2ea7a09ba859/drivers/btrfs/btrfs.go#L635 ?

OK, using the mount option "user_subvol_rm_alowed" is a pragmatic workaround IMO .. a little documentation on the topic would be desirable. I'll check for the right place but would appreciate if you could pin-point me to a good place.
Closing this ticket.

I would guess in storage.conf man page? in github.com:containers/storage.


Improve the EKS Blueprints Add-ons description

Please rename the point With the EKS Blueprints Framework to With the EKS Blueprints Framework for Terraform. Otherwise, it gives an impression that Argo CD is capable of deploying Kubernetes clusters.
Also, this
Please see the ArgoCD add-on documentation for details on how to easily bootstrap an EKS cluster
That 'bootstrap' thing. As if you are able to deploy a Kubernetes cluster with Argo CD from scratch.
Please mention that you need to create a cluster with Terraform in the first place

Thank you for the feedback - this project was originally designed to serve two different methodologies: EKS Blueprints for CDK and EKS Blueprints for Terraform. The Terraform flavor is currently undergoing some changes and you will see some updates coming soon for this - for now here is the repository that manages addons using the Terraform route https://github.com/aws-ia/terraform-aws-eks-blueprints-addons
Here is the issue that talks more about the changes happening on the Terraform side https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/1421
And for the GitOps based deployments, we have an open issue where we are collecting feedback as we re-think the integration between Terraform and GitOps operators https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/issues/114


⚠ Samsung has degraded performance

In bbbaa1a, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2477 ms

Resolved: Samsung performance has improved in e655946.


🛠 [TASK] : PoC to use integration_test

Summary
Proof of possibility to use integration_test for Web/iOS/Android
Description
Validate and demonstrate the functionality and support of Flutter's integration_test package across different platforms - Web, iOS, and Android, ensuring that the package facilitates seamless integration testing on these platforms.

FIY @stevenj @kukkok3

This ends up with an actual set-up for integration tests for Web, iOS, and Android.


Time not refreshing

In the latest version (pydPiper-0.3-alpha) the time widget it's not refreshing.
Anyone else having the same problem?

I haven't issued a new version in a long time and do need to get that done.  This is fixed in the latest version.  The issue was I slowed the update of the system variables to every five minutes to prevent some of the rapidly changing values like disk space from constantly causing display updates.  Unfortunately, I missed that this was also the routine I was using to update the time variables.  If this is your problem, your time should update but only after 5 minutes have elapsed.
You may want to try pulling down a copy of the code from the main branch and see if that resolves your problem.


how to remove the line vertical in grid?

How to remove these lines vertical?

It can be removed only with the entire grid: set the grid color to transparent. https://github.com/C451/trading-vue-js/blob/master/src/TradingVue.vue#L55

Hi @C451
I just want to remove the vertical line  and keep the horizontal line

There no API for that for now, but I can suggest you a little hack: add 1ms to every timestamp in your dataset.

Hi @learntolearn99
Could you tell me more detail?
Thanks

[1539016200001,0.49395,0.49497,0.49125,0.49319,2483674.4],[1539018000001,0.49319,0.49385,0.49177,0.4932,1802643],[1539019800001,0.49311,0.494,0.4925,0.49337,1591872],
...

Remember, this is a hack, not the proper solution.


Will there be a demo ?

Hi. Thanks for your creation. Will there be a demo bot? For instance, return RSS Feed URL generated based on RSSHub route when receiving URL like Twitter account.

Hello! Thank you for your interest in the program!
Unfortunately, there will not be an open demo for this program. This is because the program is designed to subscribe the generated RSS Feed URL to your RSS reader (e.g. TTRSS), rather than simply generating a Feed URL. Besides, this program is so simple that the location of RSS reader is just fixed in the config. If a demo were opened, any URLs sent to it would be subscribed to the creator's RSS reader, which would not be ideal.
You can still use your program in a simple way by using Docker: https://github.com/yindaheng98/RSSBot#use-it


Add enum Kind { Digraph, Graph } and GraphWalk::kind

Add enum Kind { Digraph, Graph } and GraphWalk::kind
This allows graphs to declare themselves Digraphs (default) or Graphs.
The latter use keyword graph and edgeop -- in the graphviz syntax,
the latter default to no arrows in their graph style.
Fixes #3

Kind might not be the best name.
I think this is the best place to put it, already in the trait GraphWalk? Default is digraph of course.

Hm, the default for Labeller::edge_end_arrow is a bit problematic. Maybe this is better off on the Labeller trait?

Updated with a second commit to use Labeller instead. This is a bit more invasive, but it makes more sense for arrow styles this way.

cc @Ygg01 since it touches arrow shapes

@bluss

Kind might not be the best name.

Why not? I don't see a better name? Type?  Is there a formal name to Undirected/Directed graph distinction? I'd use that, but if there isn't, Kind sounds like a good name.

I can't think of an obviously better name than Kind, so I suggest stick with it :-)

I like the Arrow::default() thing too. All the test cases blew up with it, since they "hardcode" in none-normal endings, not default. So that made me aware of the minor breaking change.
I'm fine either way.

@bluss I don't understand how the test cases 'blow up' in the case of Arrow::default().  Surely the digraph tests will be unchanged and the 'graph' tests are added in this PR, so they can be easily changed?

@bluss I'm not sure what you mean, test compare their output to a string, afaik the output string should be unchanged?

It depends on the implementation strategy I guess.
I added Arrow::default() and used an empty Vec for its internal representation. Then in render, you test if the arrows are default or not. Since neither none() nor normal(), as they were hardcoded in the testcases, match default, then attributes are emitted to set these arrow ends explicitly. In that sense, all the tests failed. I could just update the testcases to use ::default(), but you see in which sense I say it's a minor breaking change?

Hmm would replacing:
    if !options.contains(&RenderOption::NoArrows) &&
        (!start_arrow.is_none() || !end_arrow.is_default_end_for_kind(kind))

with
   if !options.contains(&RenderOption::NoArrows) && !is_default_arrows(g, e)

Work? Then in default arrows would check that either:
Both arrows are Arrows::default().
If kind is Digraph, check that start arrow is none and end arrow is normal.
If kind is Graph, check both arrows are none (I haven't made too many dot graph, so not too clear on the matter).
IIUC, Arrow::default() means, never print anything. It's the implicit default.  A vector containing only arrows that are equivalent to default should be virtually indistinguishable from it. They are the explicit default.

That would be kind of a combination of the strategies. I don't see the point of adding default for that case. Is Arrow::default a desireable thing in the public API? That could be a good reason.

In presence of different kinds of Graph I believe its very desirable. Basically, it's the don't make me remember which ones are default arrows. Then in test example you can say:
        start_arrow: Arrow::default(),
        end_arrow: Arrow::default(),

And not deal with Graph kind. In hindsight, I would have added it, but it didn't seem obvious.

Ok, I'll add Arrow::default()

Thanks both for the discussion, I'm sorry to drag you into the confused ramblings of my previous experiments.
I've added Arrow::default(), but it does not bring the simplifications that I'd want nor as you'd want @GrahamDennis, the reason is as discussed above 1) it would be a change in output for existing code  2) It's “nice” to detect the default arrow and simply skip it.

As usual, will rebase/squash on request.

@bluss I think changes to the output for existing code is acceptable (agree @Ygg01?).  @Ygg01 only added support for Arrow types a week or two ago.
I suspect we can drop the special handling of Arrow::none and Arrow::normal for Digraph and Arrow::none for Graph.  If you explicitly mention Arrow::none or Arrow::normal, then we'll add the attributes for those whether or not they are needed for a given graph type.  But if you specify Arrow::default then we won't create any attributes and dot will manage the default for us.

Ok sounds good to me

Updated

I think changes to the output for existing code is acceptable

Sure, better to change now than later, when people start massively using it. I just used it for some toy examples.

I suspect we can drop the special handling of Arrow::none and Arrow::normal for Digraph and Arrow::none for Graph.

I think, it should be ok, the only thing ArrowShape::none is used is to hide arrow or allow for spacing inside complex arrow shapes (e.g. crow none tee is different crow tee, because there is  small gap between the Crow foot and Tee arrow).
Small bikeshed, does edge_source_arrow/edge_target_arrow make more sense to you guys than edge_start_arrow/edge_end_arrow`? I'm thinking former are perhaps a better names, but its a bikeshed issue.

Maybe there's some API surface we can remove (make private) too, for example the to_dot_string() methods, that I plan to make obsolete anyway.

Looks good to me!
On the naming of edge_source_arrow / edge_start_arrow, I have no strong opinions.  I'm happy to merge this if you're happy @bluss.

Thanks for all your work!

I'm happy with this, I've squashed it down to just one commit.

@Ygg01 I think source / target is better. It's something to consider if there is a breaking changes version bump.

@bluss: Thanks for all the work :D
I don't have strong opinion on source/target so as far as I'm concerned - change away!

Yes. Semver doesn't care to define rules for the range before 1.0, but your description is how cargo behaves.

I'll leave the soft questions like start/source to the maintainer and continue to focus on the features I want. See you on the next PR.

Merged!  Yay!

@bluss would you like me to publish a new version to crates.io or wait on your next PR?

I don't need a packaged version yet, so it's fine either way


COVID19 Tests in Austria missing in metrics

Hi,
The metric shows „no data“ and is missing.
That’s the reason why the stat in dashboard is not functional now.
Thanks JO

Hi, any updates on this? Looks like a parsing issue. Thanks

Fixed.


[AutoPR healthcareapis/resource-manager] testing integration test generation tools

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7107

(message created by the CI based on PR content)


Fix same uniforms in fragment and vertex shaders not working in Metal

Describe your changes
Context: in OpenGL API setting shader uniforms works at the program level, which means that same named uniforms in vertex and fragment shaders are treated as the same variable, so when you set a uniform it is set in both shaders at once. In Metal API uniforms are set for vertex and fragment shaders separately.
In current Axmol's Metal implementation if you have a same named uniform in vertex and fragment shaders, then only the vertex shader's variable is set, which is different from OpenGL. This PR fixes Metal part to match OpenGL semantics.
This PR may have breaking changes as it modifies UniformLocation and ShaderModuleMTL::getUniformLocation(). But probably it's not a common thing to access UniformLocation internals or calling ShaderModuleMTL::getUniformLocation().
Issue ticket number and link
Checklist before requesting a review
For each PR

[ ] Add Copyright if it missed:
- "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

[ ] I have performed a self-review of my code.
Optional:

[ ] I have checked readme and add important infos to this PR.
[ ] I have added/adapted some tests too.

For core/new feature PR

[ ] I have checked readme and add important infos to this PR.
[ ] I have added thorough tests.

Please fix the ci check: https://github.com/axmolengine/axmol/actions/runs/8620021129/job/23625989923?pr=1808#step:4:3879

Pushed fix. Also noticed a uniform type mismatch in positionNormalTexture.vert and colorNormalTexture.frag, so fixed that too.