Using ObjC assembly from Swift assembly not working

I am trying to modularize my Assembly files per the instructions, but it doesn't seem to be working when I have a base Assembly class written in Objective C that's being accessed by another Assembly written in Swift. The injected assembly isn't nil, but I get a EXC_BAD_ACCESS error when I try to pull anything off of it.
Is this a known limitation, or am I doing something explicitly wrong?
I'm currently using Typhoon v4.0.3. When I was previously using 3.1.6, this seemed to work.
Here is my code for reference:
ObjC Assembly:
@interface CoreComponents : TyphoonAssembly

@implementation CoreComponents

-(Preferences*) preferences {
    return [TyphoonDefinition withClass:[Preferences class] configuration:^(TyphoonDefinition *definition) {
        [definition useInitializer:@selector(getInstance)];
    }];
}

Swift Asssembly:
public class DeviceComponents: TyphoonAssembly {

    public var coreComponents: CoreComponents!

    public dynamic func peripheralManager() -> Any! {
        return TyphoonDefinition.withClass(PeripheralManager.self, configuration: { definition in
            definition!.useInitializer(#selector(PeripheralManager.init(preferences:))) { initializer in
                initializer!.injectParameter(with: self.coreComponents.preferences())
            }
        })
    }
}

Your code looks ok. This might be bug because of Mixing Swift and Objective-C. Typhoon v4 was reworked to have much better performance, but there is major changes in assemblies. Can you please try same code but all in Objective-C and confirm it works fine then?

Any progress?

Try this. It should work with Typhoon 4.0.4 and Swift 4
// AppDelegate
@UIApplicationMain
class AppDelegate: UIResponder, UIApplicationDelegate {
    var window: UIWindow?
    @objc var helloService: HelloService?

    func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
        // Override point for customization after application launch.
        self.helloService!.sayHello()

        return true
    }
}

// ApplicationAssembly.swift
public class ApplicationAssembly: TyphoonAssembly {
    @objc dynamic var coreComponents: CoreComponents!

    @objc public dynamic func appDelegate() -> AnyObject {
        return TyphoonDefinition.withClass(AppDelegate.self) { definition in
            definition!.injectProperty(#selector(getter: AppDelegate.helloService), with: self.coreComponents.helloService())
            definition!.scope = TyphoonScope.singleton
        } as AnyObject
    }
}

// CoreComponents.swift
public class CoreComponents: TyphoonAssembly {
    @objc public dynamic func helloService() -> AnyObject {
        return TyphoonDefinition.withClass(HelloService.self) { definition in
            definition!.scope = TyphoonScope.singleton;
        } as AnyObject
    }
}

// HelloService.swift
@objc public class HelloService: NSObject {
    public func sayHello() {
        print("Hello world")
    }
}

Printing description of configuration:
(TyphoonDefinitionBlock) configuration =

I have encountered similar issues. My solution is similar to @hydra1983.
Some key points:

The class ApplicationAssembly may need @objc
The function helloService() should be mark as @objc & dynamic, and the return type should be AnyObject
The member, coreComponents, should be mark @objc and dynamic

Closing this issue @acommoner.
We're working on a Pure Swift DI library (easy to migrate from Typhoon) if you like - Pilgrim.


wizard.form.media not outputted in template

Greetings,
I have a SessionWizardView that I converted to SessionMultipleFormWizardView (using v0.1.20). The first wizard step only has a single form containing some django-autocomplete-light widgets that require {{ wizard.form.media }} to work. In SessionWizardView the media files are outputted, but somehow not in SessionMultipleFormWizardView (the form outputs fine though). I have made sure to modify the wizard template to according to formtools_addons/templates/formtools_addons/wizard/wizard_form.html. Any idea how to fix this?
Here's how the code looks:
 class ExampleWizard(SessionMultipleFormWizardView):
    form_list = [
        ('step1', MyForm),
        ('step2', (
                ('step2_1', MyForm2),
            )
        ),
        ('step3', MyForm3)
    ]
    file_storage = FileSystemStorage(location=os.path.join(settings.MEDIA_ROOT, 'example_wizard'))

    def get_template_names(self):
        template_name = 'example/wizard_form.html'
        if self.steps.current == 'step2':
            template_name = 'example/wizard_form_step2.html'
        return template_name

    def get_context_data(self, forms, **kwargs):
        context = super(ExampleWizard, self).get_context_data(forms=forms, **kwargs)
        if self.steps.current == 'step2':
            context.update({ 'some_var': True })
        return context

    def dispatch(self, request, *args, **kwargs):
        return super(ExampleWizard, self).dispatch(request, *args, **kwargs)

    def get_form_initial(self, step):
        """
        Better way to pass initial data to form.
        """
        initial = self.initial_dict.get(step, {})
        initial.update({ 'user': self.request.user })
        return initial

    def process_wizard(self, form_list, form_dict):
        form_data = [form.cleaned_data for form in form_list]
        # print form_data
        # print form_dict

    def done(self, form_list, form_dict, **kwargs):
        self.process_wizard(form_list, form_dict)
        messages.success(self.request, _('Thank you for trying the example wizard.'))
        return redirect('/')

Edit: I use Django 1.9.7
Regards,
SN

Update
Looks like doing this in the template works:
{% for form in wizard.forms %}
    {% if form.forms %}
        {% for form in form.forms %}
            {{ form.media }}
        {% endfor %}
    {% else %}
        {{ form.media }}
    {% endif %}
{% endfor %}


Implement Rounded Cuboids and Convex Hulls

I needed rounded convex hulls for my project so here it is! I also added rounded cuboids because I might need them and because they were easy.
I implemented debug rendering for rounded cubes and that works perfectly, but it's not worth my time currently to implement debug rendering for rounded convex hulls. I don't quite know how to do the math to make that one work right. As an interim solution, I simply rendered circles at each of the convex hull's points with hulls border radius. This at least gives an impression of the effect that the border radius has, even if it is not fully accurate.

Let me know if there are any problems!

Hi, thank you very much for this contribution :)
It looks nice. I'll try to review it toroughly during the week.

I don't quite know how to do the math to make that one work right

I think I know how. I'lll give it a try ;-)

I merged #118. You can now rebase an keep only 72fc4f3 ;-)

There you go! I also replaced some of the remaining cfg(feature = "2d") annotations with cfg(dim2).

Awesome, thank you!


[WIP]Osra421 add styling to all rails views

https://osraav.atlassian.net/browse/OSRA-421
Added:

styling to all views based on the wireframe
responsive design

TODO:

fix tests
add styling to login form if needed

Previews with the new design:

Nice! :+1:

Looks very nice :D
The look of the pagination is outstanding :+1:
Very nice the button tab for filters


Is there will be an example for running TensorFlowOnSpark for transfer learning?

Hi team,
It is great to see that we usually can get a quick response. I am cureious is there going to be an example for image retraining with TensorFlowOnSpark for transfer learning?
Sample from Tensorflow
https://github.com/tensorflow/hub/tree/master/examples/image_retraining
As this is a common example from Tensorflow. But I am having a hard time of how to incorporate it with TensorFlowOnSpark. It will be great if I can get some insights of how to do it.
Thank you,
Heng

@heng2j This example appears to only use a single-node, so the first hurdle will be to convert it to a distributed TF application.  Once that's done, converting it to a TFoS app (for InputMode.TENSORFLOW, should be relatively trivial).  Unfortunately, "converting to a distributed TF app" can be a bit daunting, so I'd first look for any distributed examples and then try to work off that...

Hi @leewyang, thank you for your response. I also having a hard time to find the distributed examples. There is not much distributed examples out there. And I may have to convert it myself. So I was wondering if your team had came across the solution since your team has the example to train from scratch. And I was wondering if transfer learning was also been explored.

No, unfortunately, we don't have a transfer learning example yet.  Most of the examples were just intended to demonstrate the process of converting an existing (distributed) TF app to TFoS.

Thank you @leewyang for the response.


Do not indent raw string literals that are not followed by either trimIndent() or trimMargin()

Description
Closes #1375
Checklist

[X] tests are added
[X] CHANGELOG.md is updated

Replaced with #1401. Due extracting wrapping logic from IndentationRule to WrappingRule merging this PR became too difficult. So reimplemented the change.


Extract Adapter.read/5 routine into tight read loop and add typespecs

It seems that there is a way to speed up the read/5 function by reducing number of reduction it produces during execution.
Name                ips        average  deviation         median         99th %
read            14.48 K       69.05 μs    ±16.52%       66.80 μs       88.02 μs
read_with        5.87 K      170.47 μs    ±11.91%      163.60 μs      263.02 μs

Comparison:
read            14.48 K
read_with        5.87 K - 2.47x slower +101.42 μs

Name      Reduction count
read               5.62 K
read_with         12.50 K - 2.22x reduction count +6.88 K

The benchmark in form of a livebook, assembly code and the rest of results you can find here: https://gist.github.com/asakura/8aabd3fed8859b36949f2df9d02e685a

BTW the lint job fails with funny reason:
:dialyzer.run error: Old PLT file /home/runner/work/bandit/bandit/priv/plts/dialyzer.plt

It seems the performance improvement is achieved by avoiding to access the opts in every function call.
If we rewrite the existing read function to something like this, we achieve equal performance numbers (and 1 reduction less 😄):
defmodule ReadWith do
  def read(socket, to_read, opts \\ [], already_read \\ []) do
    read_size = min(to_read, Keyword.get(opts, :read_length, 1_000_000))
    read_timeout = Keyword.get(opts, :read_timeout)
    remaining_bytes = max(to_read, 1)

    do_read(socket, remaining_bytes, already_read, read_size, read_timeout)
  end

  defp do_read(socket, to_read, already_read, read_size, read_timeout) do
    with {:ok, chunk} <- ThousandIsland.Socket.recv(socket, read_size, read_timeout) do
      remaining_bytes = to_read - byte_size(chunk)

      if remaining_bytes > 0 do
        do_read(socket, remaining_bytes, [already_read | chunk], read_size, read_timeout)
      else
        {:ok, [already_read | chunk]}
      end
    end
  end
end

Benchmark Results
##### With input Bigger #####
Name                ips        average  deviation         median         99th %
read_with      229.71 K        4.35 μs   ±122.37%        4.21 μs        7.71 μs
read           213.29 K        4.69 μs   ±119.91%        4.54 μs        8.08 μs

Comparison:
read_with      229.71 K
read           213.29 K - 1.08x slower +0.34 μs

Memory usage statistics:

Name         Memory usage
read_with        15.65 KB
read             15.65 KB - 1.00x memory usage +0 KB

**All measurements for memory usage were the same**

Reduction count statistics:

Name      Reduction count
read_with          3.51 K
read               3.51 K - 1.00x reduction count +0.00100 K

**All measurements for reduction count were the same**

##### With input Micro #####
Name                ips        average  deviation         median         99th %
read             9.75 M      102.54 ns ±12767.57%          83 ns         208 ns
read_with        9.69 M      103.21 ns ±19875.14%          83 ns         167 ns

Comparison:
read             9.75 M
read_with        9.69 M - 1.01x slower +0.67 ns

Memory usage statistics:

Name         Memory usage
read                184 B
read_with           184 B - 1.00x memory usage +0 B

**All measurements for memory usage were the same**

Reduction count statistics:

Name      Reduction count
read                   41
read_with              40 - 0.98x reduction count -1

**All measurements for reduction count were the same**

##### With input Small #####
Name                ips        average  deviation         median         99th %
read_with        1.99 M      502.36 ns  ±3108.22%         458 ns         584 ns
read             1.87 M      535.10 ns  ±3005.37%         500 ns         625 ns

Comparison:
read_with        1.99 M
read             1.87 M - 1.07x slower +32.74 ns

Memory usage statistics:

Name         Memory usage
read_with         1.59 KB
read              1.59 KB - 1.00x memory usage +0 KB

**All measurements for memory usage were the same**

Reduction count statistics:

Name      Reduction count
read_with             329
read                  330 - 1.00x reduction count +1

**All measurements for reduction count were the same**

Benchmark's results acquired through testing in the same controllable environment:
Name                 ips        average  deviation         median         99th %
read_with2       19.56 K       51.12 μs    ±64.54%       48.22 μs       70.01 μs
read             14.12 K       70.80 μs    ±87.12%       67.52 μs       97.27 μs
read_with         5.87 K      170.42 μs    ±14.50%      163.03 μs      277.13 μs

Comparison:
read_with2       19.56 K
read             14.12 K - 1.39x slower +19.68 μs
read_with         5.87 K - 3.33x slower +119.30 μs

Name       Reduction count
read_with2          3.51 K
read                5.62 K - 1.60x reduction count +2.11 K
read_with          12.50 K - 3.56x reduction count +8.99 K

So yes, not calling min/2 BIF allows to bump number of IPS and reduce reductions count. Regarding using with expressions: it compiles to absolutely same byte code (at least I couldn't spot difference) so there is no magic behind it.

It seems that moving already_read acc left or right in argument list of defp do_read(socket, to_read, already_read, read_size, read_timeout) drops performance up to 16%. Does any one knows what causing this?

PLT error is fixed - on occasion the Github CI setup wedges on a stale PLT cache & I have to clear it manually.

Unfortunately the version suggested by @moogle19 won't work: it would try to read more than client has to transmit which leads to different broken tests due to :timeout. So min/2 has to stay unless there is a way to overcome this problem.

Where is to see the Benchmark task collected data points?

Yeah, they're definitely an imperfect instrument. I look mostly at the 'requests per second' graphs for the request type under consideration, and then see if the difference is both 1. material (more than 5-10% typically), and 2. mostly one-sided. In this case:

you'll notice that we have about a 3-5% boost that's basically across the board. This is good!

Great! Sounds like a success, right?

I think so! I'm generally adopting a perf approach of compounding small wins.  Thanks for finding (and fixing!) one! I'll have a proper review done by afternoon UTC tomorrow.

Sorry for the delay; this looks great!


Use postcss-preset-env to make flexbox easier to work with

Flexbox could be used to simplify some of our layouts (#1409) and is being used to fix bugs (#1919) but it can be a bit of a pain to get it right across multiple browsers.  This is because some browser versions require prefixing of style properties/values.  Some browsers also have various bugs in old implementations of flexbox.  postcss-preset-env promises to handle this for us.  It also integrates with browserslist allowing us to easily specify which browsers we'd like to support.

https://github.com/csstools/postcss-preset-env/blob/master/INSTALL.md#webpack shows how to set this up.


Change GitOps repository information

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I think this PR was opened by mistake. Please let us know if otherwise.


Scroll is not working in Mobile devices

Hello, I'm using this ng-scrollbar to make beautiful scrolling view in my HTML pages. It seems good in desktop website but didn't work in mobile devices. Am I missing something? or This library support desktop websites only?

Same thing. I'm trying to fix it, but, maybe it will be better to write my own from scratch andcreate new unuseable thing.

Was this ever resolved?
Thought it was my implementation(inside a resizing div, inside a flexbox layout :s ) , but the demo confirms the issue is with the plugin itself.

Would it work to possibly replace
thumb.on('touchstart', function (event) {
lastOffsetY = event.originalEvent.changedTouches[0].pageY - thumb[0].offsetTop;
win.on('touchend', _touchEnd);
win.on('touchmove', _touchDragHandler);
event.preventDefault();
});
with
transculdedContainer.on('touchStart).......
?

Id do pull/push thingy from git if I can ever work out how that works!

@CosyStudios the first replace, how and where to place it? can you paste the whole solution?


Add gh-extension topic to repository for discoverability

Firstly, @rneatherway, thank you for creating this beautiful CLI extension!
Secondly, I'd like it to be discoverable when using gh ext browse, which requires a gh-extension topic on the repository as describe in GitHub Docs:

Optionally, to help other users discover your extension, add the repository topic gh-extension. This will make the extension appear on the gh-extension topic page. For more information about how to add a repository topic, see "Classifying your repository with topics."

Should be easy peasy, then lemon squeezy.

Done!

✨ thanks, Robin; hope you've been enjoying your new journey ❤

Cheers!


One more step - Existing virtual network or subnet

Variable subnet0Prefix was commented out in step 1 of Existing virtual network or subnet. This variable occurs one more time in service template. Additional step (as I described) is needed for successfull service deployment.

@Miro-A : Thanks for your contribution! The author, @rwike77, has been notified to review your proposed change.

@Miro-A Thanks for the update, looks good.  #sign-off


Bulk assessment in "Observations" view

It would be nice to have the possibility to make an assessment for a vulnerability across all products at once.
Example: All products contain libssh, libssh has a vulnerability that can be exploited if you use it in an SSH server, but non of the products contain an SSH server.
This requires the removal of the dependency on the product id in the observations_bulk_assessment endpoint. Instead, the permissions to update an observation (which are based on the product) have to be checked for each observation separately. Only if the user has permissions to create assessments for all observations included in the bulk, the bulk assessment should be successful (all or nothing).

released with 1.11.1


Variable CurrentJnlBatchName as Protected

Can you please the Global var CurrentJnlBatchName in Object Page 5636 „FA Reclass. Journal“ set as Protected var ?
var
    FAReclassJnlManagement: Codeunit FAReclassJnlManagement;
    CurrentJnlBatchName: Code[10];
    FADescription: Text[100];
    NewFADescription: Text[100];
    grec_FA: Record "Fixed Asset";

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: .


Update Spec Definition Based on 7/25 call

Handling unified form to do group by topic and group by entity
https://hackmd.io/a50I9MlkRVOQJOYgf7b3hA?both

Handled in #21 #22


Fix readability issues and add missing meta tags

Fixes an issue when using Firefox's readability mode on a post. Adds a <header> and <main>  element to the posts' <article> element.
Also adjusts some CSS for lists and adds meta tags for post published/modified dates.

Chrome still has some issues with rendering the reader mode, but I can't find a way to trigger it consistently for the same article. So, whatever.


Fix issue with clamping in the tours component

@jcreamer898 What was the issue here? I'm starting to see text overlapping and I'm thinking this is related. If I change the default back to 18, I don't notice overlapping.


Finish TileMap documentation

Yeah, I don't know what clip_uv does in draw_rect_region either.

From my observations, clip_uv does absolutely nothing

From my observations, clip_uv does absolutely nothing

It is given to the CanvasShaderGLES3, but that's the only time it gets used:
https://github.com/godotengine/godot/blob/4569f5ec82964e0abe543337c9537e0af9164c11/drivers/gles3/rasterizer_canvas_gles3.cpp#L694-L700

Thanks!


fix trainer tutorial evaluate example code

Example code in https://docs.chainer.org/en/stable/tutorial/trainer.html#evaluate-a-pre-trained-model is broken.
y = model(x) raises IndexError because x is just one data, not a minibatch of length 1. (I have no idea about chaier's interface yet, but maybe it works at some previous version?)
And because the resulting y is not np.array anymore, we should access y.data instead. (or y.array ? which is better?)

LGTM. Thank you for pointing this out!


Subcategory Login Issue

I have a client that's using this module for their website. We recently noticed that if a guest user is on a subcategory product page and they click the Login button that this module is redirecting the URL to an empty Emma login page on the same site.
For example, an unauthenticated user is on a subcategory page with the URL of http://www.sayiwont.com/youth/hoodies. For this page "Youth" is the parent category and "Hoodies" is the subcategory. Clicking the "Login" button in the top right should take the user to a URL of http://www.sayiwont.com/customer/account/login/ as it does on all other pages. However, the user is instead taken to https://www.sayiwont.com/index.php/emma/account/login/.
I see in etc/config.xml that there are a couple of rewrites:
<rewrite>
  <emma_onepage>
    <from><![CDATA[#^/checkout/onepage/#]]></from>
    <to>/emma/onepage/</to>
  </emma_onepage>
  <emma_register>
    <from><![CDATA[#^/customer/account/#]]></from>
    <to>/emma/account/</to>
  </emma_register>
  <emma_manage>
    <from><![CDATA[#^/newsletter/manage/#]]></from>
    <to>/emma/manage/</to>
  </emma_manage>
</rewrite>

Would appear that the  emma_register node is handling the rewrite but I'm confused as to why it doesn't happen on all of the pages.
Have you seen this before or have any ideas on how to fix?

Discovered that the subcategory page links were not receiving SSL links but standard HTTP. I updated the site to force SSL for all links and the issue has resolved itself for my site.


Copying directories should ignore vim swap files

When copying folders using the "m c" command while files in these folders are currently opened, NERDtree also copies the swap (.*.swp) files.
When I then try to open the newly-created destination file, vim complains because a .swp file already exists.
It would be great if NERDtree could be a bit smarter about this, and not copy .swp files corresponding to files that are opened in the same instance of vim. This would be consistent with the behavior for renaming or deleting files; there, NERDtree warns me about files that are currently being opened, and takes the appropriate actions.

This issue is quite old.  I'm afraid I also disagree with adding the feature described here.  A far better solution is to use the 'directory' setting included with Vim.  This will allow you to place your own swap files in a designated location.  Read more by running :help 'directory' in a Vim window.  Thanks!


As an admin, I can disable access to the marketplace using a feature flag

Today, the /v2/services and /v2/service_plans endpoints are exposed to users who are not authenticated. We have heard feedback from users who don't want unauthenticated users to be able to view these endpoints.
This change implements a feature flag (hide_marketplace_from_unauthenticated_users), which when enabled, makes these endpoints not visibile to users who are not authenticated. This feature flag is not enabled by default, meaning there is no behaviour change for existing users, unless they flip this flag.
Associated story in SAPI teams backlog https://www.pivotaltracker.com/story/show/160093242
Thanks!
Alex + @jenspinney

[x] I have reviewed the contributing guide

[x] I have viewed, signed, and submitted the Contributor License Agreement

[x] I have made this pull request to the master branch

[x] I have run all the unit tests using bundle exec rake

[x] I have run CF Acceptance Tests

The CAPI CI is blocked now, but we (SAPI team) can merge this PR ourselves once CI is green.


Question: how to source setup.bash before press F5 launch launch.json

how to source setup.bash before press F5 launch launch.json ? the shell where gdb running must has the foxy environment variables, otherwise

error while loading shared libraries: librclcpp.so: cannot open shared object file: No such file or directory

Are you using the provided dockerfile or did you roll your own?

I think you have 2 options here:

Either the shell environment has the appropriate environment variables set up
You add a pre-launch task to source setup.bash

launch.json
    // Example gdb launch of a ros executable
    {
      "name": "(gdb) Launch (merge-install)",
      "type": "cppdbg",
      "request": "launch",
      "program": "${workspaceFolder}/install/lib/${input:package}/${input:program}",
      "args": [],
      "preLaunchTask": "source",
      "stopAtEntry": true,
      "cwd": "${workspaceFolder}",
      "externalConsole": false,
      "MIMode": "gdb",
      "setupCommands": [
        {
          "description": "Enable pretty-printing for gdb",
          "text": "-enable-pretty-printing",
          "ignoreFailures": true
        }
      ]
    },

tasks.json
        {
            "label": "source",
            "detail": "Source the directory",
            "type": "shell",
            "command": "source install/setup.bash", // path to your setup.bash file
            "problemMatcher": []
        }


Add stdout/stderr properties to TestNode

Add stdout/stderr properties for the TestNode to the spec.

I'm not sure how this is possible for an adapter without:

provide an abstraction on console that needs to be used by the user
don't substitute the console out soon as possible(if it's possible) and lock somewhere, with all the problem of appdomain and static substitution of the output

I was wondering if make more sense have something more high level and less "low level" like notes-info/notes-error/notes-warning (naminc TBD)
@Evangelink

I think the point of @MarcoRossignoli is more to question having some "output" related to a "test node". You are taking a specific use-case and making it a component of the protocol that is supposed to represent a functional abstraction. I think it's better to think that a node can have messages attached (whether this is an output or something else is an implementation detail).

I think the point of @MarcoRossignoli is more to question having some "output" related to a "test node".

If we rename output to messages or logs does it make the meaning of the property abstract enough? messages wouldn't be linked to stdout/stderr, and more generally would encompass any loggable messages, allowing adapters to log additional diagnostic messages too. On the other hand, the property name notes feels too disconnected from logging concepts.
@evangelink do you have a preference of which of the two styles would be better. Whether { "messages.info": ..., "messages.warning": ..., "messages.error": ... } or { "messages": [ListOfMessages] }

allowing adapters to log additional diagnostic messages too

Is this problematic? You have a point that we do need different "levels" and that maybe logging is indeed more generic.

After an offline discussion, I updated the spec to be based on the client/log rpc instead and support log message association to the specific runId/nodeUid couple. This should allow batching of logged messages, support more logging levels than just output/error and allow to send output updates during a test run without the need to resent the entire TestNode all the time.


Test /puppet-sloth

Adds a /puppet-sloth route for testing / getting to know the code.

This heroku review app functionality is pretty rock and roll -- it deployed an instance of this branch to https://ds-mdata-responder-pr-527.herokuapp.com/ 🎸

For better or worse, I've committed some code to this branch and configured my test playground campaign to respond back. the test mData is pointing to the review app URL.


On statements: Indicate the community who is doing the billing

Statements need to indicate which community they're for, and who to make the check out to.

GO: "Great Oak Cohousing Association", memo: meals
SW: "The Common Kitchen"
TS: I've forgotten

Make checks payable to "Touchstone Cohousing" and mail to:
Touchstone Meals
560 Little Lake Dr #16
Ann Arbor, MI 48103
Make checks payable to "Great Oak Cohousing Association (put 'Meals' in memo)" and mail to:
Great Oak Meal System
500 Little Lake Dr
Ann Arbor, MI 48103
Make checks payable to "The Common Kitchen" and mail to:
The Common Kitchen
424 Little Lake Dr. #41
Ann Arbor, MI 48103
Originally created by Willie Northway at 2015-11-24 01:59, migrated from redmine-#3680

Description updated (diff)

Estimate set to 0.50 h

By Tom Smyth at 2015-11-24 07:22

Status changed from New to Closed

By Tom Smyth at 2015-11-24 07:46


fix: lake: do not fail --no-build on fetch

Lake's --no-build option will no longer exit with an error if the build action in question is simply a cache fetch.

Closing in favor of #5583.


Key systemd services don't auto-restart on bastion

Haproxy , named, squid service in bastion is not configured with Restart=always or Restart=on-failure. Consequently any crash of the service will not restart it automatically.

May be a contribution to the helpernode playbook?

Squid is in house so this issue is still valid for such services.

Either contribution to helpernode, or we can add a role in our playbook to create systemd dropin to add the configuration. Something like this
cat <<EOF | sudo tee /etc/systemd/system/{haproxy, squid, named}.service.d/restart.conf
[Service]
Restart=always
EOF

Closed via https://github.com/ocp-power-automation/ocp4-playbooks/pull/93

Closed via https://github.com/ocp-power-automation/ocp4-playbooks/pull/93


Build error

Hi, thanks for the library!
I have some trouble building this library. Apparently, they are caused by the dependencies (Pairing-plus and/or pointproofs-paramgen).
After configuring rand_core = "*" and rand_xorshift = "*" (because if the version is left empty, there will be other errors), some errors like this come up:
error[E0599]: no function or associated item named `deserialize` found for struct `PointproofsParams` in the current scope
   --> src/pairings/param.rs:300:64
    |
300 |     let param = match pointproofs_paramgen::PointproofsParams::deserialize(reader, true) {
    |                                                                ^^^^^^^^^^^ function or associated item not found in `PointproofsParams`
    |
    = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
    |
4   | use pairing_plus::serdes::SerDes;
    |

Could you have a look? Thanks in advance!

I had the same problem, did you solve it?

I had the same problem, did you solve it?

Yeah, try specifying the branch of the pairing-plus dependency in Cargo.toml. In other words, replace this line (line 20, Cargo.toml):
pairing-plus = { git = "https://github.com/algorand/pairing-plus"}
by the following line:
pairing-plus = { git = "https://github.com/algorand/pairing-plus", branch="master"}


[tsserver 2307] [E] Cannot find module 'react-router-dom' or its corresponding type

I don't know why I get this warning if all the routes are properly configured. It happens with all the files that I want to import. In VSCode I don't get any problem.

Should be problem of your language server, checkout https://github.com/neoclide/coc.nvim/wiki/Debug-language-server#using-output-channel


Missing default profile in a fresh install of 16.09

Issue description
I have just installed NixOS 16.09 in a VM on WMware Workstation (not sure if it matters) using the standard installation DVD image. After the install the link /root/.nix-profile is created but its target /nix/var/nix/profiles/default does not exist so the link points nowhere.
Steps to reproduce
Install NixOS 16.09 according to the instructions (partition, format, nixos-install, etc)
Technical details

System: 16.09.741.354fd37 (Flounder)
Nix version: nix-env (Nix) 1.11.4
Nixpkgs version: 16.09.741.354fd37

It should get created when you install something "into the profile". I'm not certain that adding some empty directories would really improve the situation.
It's really a nix "issue", not nixos specific and not root-specific.

Issue moved to NixOS/nix #1101 via ZenHub

Heh, the issue-moving button is weird.


Document

Are there any documentation or examples? I run ‘ListIdentity’, no item return.

Is hard to dissect from source code if you install the go-cip it pulls this repo as a dependency but is using an old commit from this repo. Not the latest repo code which is using an entire different structure.
Reading through this code, I can't figure out how to do anything meaningful other than reading all tags with a NewController... object.
I also tried to use goplc repo and that one I couldn't even connect to the plc.
Side note: I am working on porting pylogix to go because I can't find anything reliable in go.

Have a look at this wrapper for libplctag I am working on. Latest stable version is v0.0.4, and beta v0.0.3-beta6
https://github.com/libplctag/goplctag

I add some example.
Maybe can help u.


optional embeddings generation

@rultor release, tag is 0.0.22

@rultor release, tag is 0.0.22

@h1alexbel OK, I will release it now. Please check the progress here.


added Javascript tutorials podcast in english

What does this PR do?
Add resource JavaScript tutorials for beginner in English.
For resources
Description
This is an beginner level JavaScript tutorial for anyone who want to get hands on the JavaScript basics.
Why is this valuable (or not)?
Using this podcast anyone can learns the basics of JavaScript within minutes.
How do we know it's really free?
It is available for free on the YouTube
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Thanks, and welcome to free-programming-books!


Scroll the provisioning log as events are retrieved

Is your feature request related to a problem? Please describe.

The provisioning log does not track the output of the log
Describe the solution you'd like

The log output should automatically (or option via tick-box, etc.) track the log events as they are retrieved
Describe alternatives you've considered

Manual scrolling
Additional context
Rancher v2.7.4 (any version with the provisioning log should reproduce)
Reproduction steps:

Create, or update an existing downstream cluster in Cluster Management
Click on the 'Provisioning Log' tab
Provisioning events appear as they are retrieved
Viewing the events as they are displayed requires manually scrolling to get to the end of the page

It would be nice to have a default option of following the output as it appears

Sure @richard-cox, I have added more information.


[Core][SPARK-18778]Fix the scala classpath under some environment

What changes were proposed in this pull request?
under some environment, the Dscala.usejavacp=true option seems not work, pass the -usejavacp directly to the repl fix this.
How was this patch tested?
we test in our cluster environment.

Can one of the admins verify this patch?

What are the environments?

Paging @jodersky
I'm not sure about this ... isn't -usejavacp a legacy option? I don't know of any other reports of this so it is possibly specific to your env.

@rxin our jdk is jdk1.8.0_91, and we do not install the scala, the OS is Debian 4.6.4.

The command line parameter -Dscala.usejavacp is something directly passed to the JVM and should not be OS-dependent. I'm wondering if the issue may not arise from the way the parameter is defined in the spark-shell launcher scripts. Debian Etch is very old and probably has a older version of bash.

I wonder if it wouldn't be better to avoid this by moving the logic to add this parameter to SparkSubmitCommandBuilder. As in, if the class is the REPL's main class, add that option to the JVM.
(That also avoids the duplicate logic in Unix and Windows scripts.)

+1 to implementing it in the command builder. However I'm not sure if the command option -usejavacp or property scala.usejavacp is the suggested way to add the java class path to the REPL. I skimmed through the scala compiler's code and it seems both do slightly different things. I'll check this out in further detail

@jodersky Yes. I try different ways, here is the result:
SPARK_SUBMIT_OPTS="$SPARK_SUBMIT_OPTS -Dscala.usejavacp=true -usejavacp"

and
SPARK_SUBMIT_OPTS="$SPARK_SUBMIT_OPTS -Dscala.usejavacp=true -Dusejavacp"

will output
Exception in thread "main" java.lang.AssertionError: assertion failed: null
        at scala.Predef$.assert(Predef.scala:179)
        at org.apache.spark.repl.SparkIMain.initializeSynchronous(SparkIMain.scala:247)
        at org.apache.spark.repl.SparkILoop$$anonfun$org$apache$spark$repl$SparkILoop$$process$1.apply$mcZ$sp(SparkILoop.scala:990)
        at org.apache.spark.repl.SparkILoop$$anonfun$org$apache$spark$repl$SparkILoop$$process$1.apply(SparkILoop.scala:945)
        at org.apache.spark.repl.SparkILoop$$anonfun$org$apache$spark$repl$SparkILoop$$process$1.apply(SparkILoop.scala:945)
        at scala.tools.nsc.util.ScalaClassLoader$.savingContextLoader(ScalaClassLoader.scala:135)
        at org.apache.spark.repl.SparkILoop.org$apache$spark$repl$SparkILoop$$process(SparkILoop.scala:945)
        at org.apache.spark.repl.SparkILoop.process(SparkILoop.scala:1059)
        at org.apache.spark.repl.Main$.main(Main.scala:31)
        at org.apache.spark.repl.Main.main(Main.scala)

SPARK_SUBMIT_OPTS="$SPARK_SUBMIT_OPTS -usejavacp"

will output:
Unrecognized option: -usejavacp
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

I find the reason, because we pass some  SPARK_SUBMIT_OPTS defined by ourself, so it seem that spark only parse the opts defined by ourself, ignore the -Dscala.usejavacp=true.
Since we want user to use the SPARK_SUBMIT_OPTS, the best way it to separate the -Dscala.usejavacp=true  from the SPARK_SUBMIT_OPTS, maybe move to SparkSubmitCommandBuilder is good idea as suggestioned by @vanzin.

I'm still not clear how to reproduce this. I can't repro with Java 8, Debian, on 2.x. Is this really necessary or somehow band-aiding some other deployment problem? that is, why does this work for anyone at all?

@srowen Sorry for late reply and thanks for your reproduce!
As I have mentioned in last reply, this is not a  environment problem, but a misunderstand of SPARK_SUBMIT_OPTS by ourself, or a deployment  problem. This works for anyone because few people use the SPARK_SUBMIT_OPTS option and do not put SPARK_SUBMIT_OPTS in the spark-env.sh file.
It maybe better to separate the Dscala.usejavacp=true from the SPARK_SUBMIT_OPTS in the spark-shell file to avoid the misunderstanding.

The bug was filed as an improvement, and I think this is fine as an improvement. (By this I mean the suggestion of moving the handling of that option to Java code.)
That way we can get rid of SPARK_SUBMIT_OPTS, which is not documented and only the Spark shell scripts use. Users should be using "spark.driver.extraJavaOptions" and friends.

OK. This PR doesn't move the handling / get rid of SPARK_SUBMIT_OPTS. Should this then be closed and the JIRA updated?

Yes, this PR do not consider well, I will close this and update the JIRA.


Performance optimization: async attached to async can be called in the same cycle

Attaching an a-sync event to another a-sync event can be optimized. Currently each event is fired in yet another Node.JS cycle. For all use cases, it is enough to only schedule through setImmediate() once.

fixed in commit b47250a5c86ddbc698eb8b9a671a42eb0674ff6c


Using PropertyRenameAndIgnoreSerializerContractResolver to rename a property dynamically

Hello,
I have a use case to rename a property in a json in run time. The property in question here belongs to a nuget package which I have no control over. The nuget applies certain JsonProperty attributes on some of its properties. more explanation below.
Class structure.
public class Foo{
[JsonProperty(Name="alllowercase")]
public string AllLowerCase;

[JsonProperty(Name="code")]
public string Code;
}

Referring code
public class Details {
  public Foo details;
}

Problem : Update the alllowercase to allLowerCase when serializing your class object Details.
Solution : I used the following code to achieve this.
public class Details {
  [JsonConverter(typeof(DynamicNameConverter))]
  public Foo details;
}

public class DynamicNameConverter : JsonConverter<Foo>
    {
        public override Foo ReadJson(JsonReader reader, Type objectType, Foo existingValue, bool hasExistingValue, JsonSerializer serializer)
        {
            return serializer.Deserialize<Foo>(reader);
        }
public override void WriteJson(JsonWriter writer, Foo value, JsonSerializer serializer)
        {
            var jsonResolver = new PropertyRenameAndIgnoreSerializerContractResolver();
            jsonResolver.RenameProperty(typeof(Foo), "alllowercase", "allLowerCase");

            serializer.ContractResolver = jsonResolver;
            serializer.Serialize(writer, value);
        }
    }

With this change, there are 2 things which are happening now.

When serializing, the object's Code property is not lower cased, so the JsonConverter is overwriting any existing property formattings done in the class, is it possible to preserve the formatting done by the class Foo here, and only replace the one field which i want to update ?
There is another class where i am using Foo class, as shown below, since i have not added the dynamicNameConverter attribute here, it should now follow the default serialization / deserialization.

public class Details2 {
  public Foo details;
}

var temp = JsonConvert.SerializeObject(new Details2());
Expected output : should serialize with "alllowercase" and "code"
Actual : serializes with "allLowerCase" and "Code".
ON debugging i found out that the ContractResolver is now tied to this class, hence not taking the property names from the class Foo any more.
Please let me know what is the best way to use this so that i only rename the properties i want to, without loosing any formatting which the Foo class did itself.

I think you need to use PropertyRenameAndIgnoreSerializerContractResolver as the general resolver of the serializer settings and not just change it in the converter.


http client examples?

Does uws have some http client examples?Or it just for http server?

You can try engine.io or socket.io.
Engine.io wraps uws by default from version 2.

https://github.com/uWebSockets/uWebSockets/issues/395


resolved the bug and made the youtube video iframe centered

+
+
+

Can you use the hacktoberfest-accepted label, as it would help me to complete 4 PR during Hacktoberfest challenge.

This repo has hacktoberfest, so you don't worry about to get accepted from Hacktobefest.

Ok


[Mangle] Include generic arguments of extensions for the Objective-C runtime

The remangler for the Objective-C runtime was dropping generic arguments
of extension contexts, leading to collisions with @objc class names.
Include the generic arguments of extensions.
Fixes rdar://problem/45956357.

@swift-ci please smoke test


feat: rpc state reader

This change is

Codecov Report
Attention: Patch coverage is 57.50000% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 61.29%. Comparing base (1d45e65) to head (725dda9).
Report is 3 commits behind head on main.

Files
Patch %
Lines

crates/gateway/src/rpc_state_reader.rs
57.33%
27 Missing and 5 partials :warning:

crates/gateway/src/rpc_objects.rs
60.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   62.32%   61.29%   -1.04%
==========================================
  Files          11       13       +2
  Lines         292      372      +80
  Branches      292      372      +80
==========================================
+ Hits          182      228      +46
- Misses        105      134      +29
- Partials        5       10       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tmp1.patch line 0 at r1 (raw file):
What is this file? It seems like something related to the git diff

crates/gateway/src/rpc_objects.rs line 19 at r1 (raw file):
Previously, Yael-Starkware (YaelD) wrote…
I'm trying to be consistent with the spec structure,
the block id is an enum of blockTag, BlockNumber and blockHash, but currently we only use BlockTag so I didn't want to add additional options. it can be added in the future.

Add a link to the spec to the code? Or is it too dynamic to be in code. At least link in this thread :   )

#64  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Yael-Starkware and the rest of your teammates on  Graphite


Describe KDF a KDF_INTERNAL purpose

Currently, PowerAuth 2.0 uses in fact two types of KDF - one for "client use" (AES with Long index) and one for "internal use" (HMAC with Byte[] index). We should mention this in the docs, since this point of view is sometimes handy.

Postponing to 0.14.0 - we have more documentation to do... :(

I added a note to implementation notes:
https://github.com/lime-company/powerauth-crypto/wiki/Implementation-notes#key-derivation-functions


Can no longer execute Unit Tests on UNC Path

Required Information
Question, Bug, or Feature?
Type: Question
Enter Task Name: VsTestV2
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks/VsTestV2
Environment

Server - Azure Pipelines or TFS on-premises?
Azure DevOps Server

If using TFS on-premises, provide the version:
17.143.28912.1 (AzureDevOps2019.0.1)

Issue Description
Our organization just upgraded from TFS 2018 RTM on-prem to Azure DevOps Server which includes upgrading the VsTest task from v2.1.9 to 2.143.9 which can no longer use UNC paths in the Search Path parameter. I can find no documentation stating why this is not allowed nor when exactly this change was made. We have many in-house libraries that are used across many in-house applications creating a lot of dependencies that we check before deployment using Unit Test DLLs for each of our libraries stored on a file share.
Currently we have 18 Unit Test DLLs and this number will only grow as we continue development so copying all of the required test files for every application Release is not a very good solution for us (suggested solution given here in response to this question).
Is there a way for us to re-enable this capability or some other suitable solution for what we would like to do?
Error logs
##[error]Error: Path to test sources search folder cannot be a UNC path. Please provide a rooted path or a path relative to $(System.DefaultWorkingDirectory).

@RichJeanes This feature is no longer supported. You will need to copy the files to the agent machine in a prior step.


Need more information about distributed training

Hi Fairseq Team,
I have just went through the fairseq documentation about distributed training and I have following questions.
Does Fairseq use only NCCL library to perform distributed training? Please correct me if I'm wrong.
Is there any example available where horovod has been used with fairseq specially in Neural Machine Translation task? If yes can you please share the link?
Is there any detail documentation available on how to set up servers and worker(node) in order to run distributed training using fairseq with NCCL? If yes can you please share the link?
Thanks,
Jalaj

fairseq uses PyTorch's DistributedDataParallel, which uses NCCL under the hood: https://pytorch.org/docs/stable/nn.html?highlight=distributeddataparallel#torch.nn.parallel.DistributedDataParallel
Once you have setup PyTorch and NCCL properly, instructions for doing distributed training with fairseq can be found here: https://fairseq.readthedocs.io/en/latest/getting_started.html#distributed-training

Hi @myleott  Thanks for the response.
Can you please share the information about how you setup the entire infrastructure for performing distributed training? I'm kind of struggling on how can I set up the infrastructure (i.e Servers and workers and how they communicate with each other). Is it parameter server based architecture or All reduce kind of architecture?
Specially how we need to use --distributed-init-method?
I'm not finding the detail documentation on this front. If I'm missing some critical information then please let me know.
Thanks,
Jalaj

Hi Fairseq team,
I'm getting the similar error when I'm running the distributed training. I have referred the following  issues
https://github.com/pytorch/fairseq/issues/138
https://discuss.pytorch.org/t/nccl-error-in-torch-c-dist-broadcast-tensor-src-group-when-train-in-two-nodes/28787/3
https://discuss.pytorch.org/t/multi-node-distributed-training-runtimeerror-nccl-error-in-torch-lib-thd-base-data-channels-datachannelnccl-cpp-322-unhandled-system-error/33412/2
but seems it didn't help me much
I have simple multinode GPU architecture 2 nodes in total and 1 GPU on each node so total GPUs are 2.
LOG on Worker node:
Traceback (most recent call last):
  File "software//fairseq-py/train.py", line 347, in <module>
    distributed_main(args)
  File "software/fairseq-py/distributed_train.py", line 39, in main
    single_process_main(args)
  File "software/fairseq-py/train.py", line 87, in main
    train(args, trainer, task, epoch_itr)
  File "software/fairseq-py/train.py", line 125, in train
    log_output = trainer.train_step(sample, update_params=True)
  File "software/fairseq-py/fairseq/trainer.py", line 137, in train_step
    (sample_sizes, logging_outputs, ooms_fwd, ooms_bwd)
  File "software/fairseq-py/fairseq/distributed_utils.py", line 77, in all_gather_list
    torch.distributed.all_gather(out_buffers, in_buffer.cuda())
  File "venv/lib/python3.6/site-packages/torch/distributed/__init__.py", line 439, in all_gather
    return all_gather_multigpu([tensor_list], [tensor], group)
  File "venv/lib/python3.6/site-packages/torch/distributed/__init__.py", line 413, in all_gather_multigpu
    group)
RuntimeError: NCCL error in: /pytorch/torch/lib/THD/base/data_channels/DataChannelNccl.cpp:322, unhandled system error

CUDA 10.1
CUDANN 7.6.4
NCCL 2.4.6
Pytorch 1.1.0
NCCL environment variables
export NCCL_SOCKET_IFNAME=ens3
export NCCL_DEBUG=INFO
export NCCL_IB_CUDA_SUPPORT=0
export NCCL_P2P_DISABLE=0
export NCCL_IB_DISABLE=1
export NCCL_NET_GDR_LEVEL=3
export NCCL_NET_GDR_READ=0
export NCCL_SHM_DISABLE=0

Is there anything I'm missing? Any help or suggestion is appreciable.
Thanks,

Hi is there any updates in this issue? I also having trouble running fairseq with torch.distributed.launch

@xiongchenyan I will be trying out few new experiments soon, Will update here if I can resolve this issue

I think the documentation should be updated? https://fairseq.readthedocs.io/en/latest/getting_started.html#distributed-training
torch.distributed.launch is said to be deprecated soon and torchrun should be used instead. Plus now most projects use fairseq-hydra-train which seems does not support torch.distributed.launch (the local_rank argument is not expected in hydra).
Any instruction on using fairseq-hydra-train with multi-nodes distributed training? @myleott


Issue linking React as a target dependency in Xcode for React Native iOS apps: 'RCTLog.h' file not found within react-native-branch npm package

Description
Dear fellow, hard-working developers,
I write to you this message to discuss with you a major issue I have been struggling with for the past two weeks related to creating an archive for our project's React Native iOS application.
Before I go in-depth with the issue, I want to mention that our team lead is enrolled in the Apple Developer Program for which we have a valid distribution signing certificate and distribution provisioning profiles associated with our application: this is necessary in archiving an iOS app for distribution.
I also want to state that I have already followed the steps in this Prepare for app distribution page  to prepare our app for distribution and all the requirements have been met to create an archive for our app. I have also looked around the Developer Documentation and "Apple Developer Forums" for a solution to this and tried precisely twelve different solutions to fix this depending on posts from other users of the forum as well as from Github issues and Stackoverflow links, but none seemed to resolve this.
After contacting the Apple Developer Technical support through our Apple Developer Program paid account (we submitted a TSI (technical support request), they stated that Apple "doesn’t support third-party libraries or dependency tools". After, they suggested me to contact "the React Native development community to identify the cause of and a fix for this issue". Hence, I decided to make a post on here to see if this is a major issue and perhaps if the way in which the react-native or react npm packages are linked to Xcode in RN iOS projects needs to be changed or updated, considering the many people who have encountered this issue in the past: this is evident from multiple posts I have seen as linked Github issues, on Stackoverflow and the Apple Developer Forum.
The technical issue is as follows: it seems to be appearing in the RNBranchConfig.m file within the react-native-branch package for iOS specifically in lines 9 and 23 that 'React/RCTLog.h' file not found and Use of undeclared identifier 'RNBRANCH_VERSION' respectively in the links below:
https://github.com/BranchMetrics/react-native-branch-deep-linking-attribution/blob/3b3b3df9b72bc832d1c525627253ec9ac7955c1d/ios/RNBranchConfig.m#L9
https://github.com/BranchMetrics/react-native-branch-deep-linking-attribution/blob/3b3b3df9b72bc832d1c525627253ec9ac7955c1d/ios/RNBranchConfig.m#L23
Now, you may be wondering that this issue may be related to the package provider but for the former error, it seems as though the package cannot detect the React target dependencies and in particular, this RCTLog.h file which is located within the React Native framework. Thus, it seems to me that this may be an issue within React Native itself, somehow not able to link to the Xcode project.
A screenshot of the error message is provided below:

React Native version:
System:
    OS: macOS 10.15.5
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 696.23 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 12.14.1 - ~/.nvm/versions/node/v12.14.1/bin/node
    Yarn: 1.9.4 - /usr/local/bin/yarn
    npm: 6.13.4 - ~/.nvm/versions/node/v12.14.1/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.4, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK:
      Android NDK: 21.3.6528147
  IDEs:
    Android Studio: 4.0 AI-193.69<IP_ADDRESS>26763
    Xcode: 11.4/11E146 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.13.1 => 16.13.1
    react-native: ^0.63.3 => 0.63.3
  npmGlobalPackages:
    react-native: 0.61.5

Steps To Reproduce
To reproduce the issue, do the following:

Open .xcodeproj in Xcode and add the RNBranch.xcodeproj manually into the Library directory as follows:

I did the above to remove the -lBranch not found error I was experiencing in Xcode before as below:

2) Go to Product > Clean Build Folder to start the build process afresh.

Make sure that the device to run the target app on is Generic iOS Device in the top-left corner next to the Run symbol as shown below:

Click on Product > Archive to start the archiving process of generating the .ipa file which compresses the app into a file that can be distributed to other software (I am using this so that I can distribute the app to BETA testers). This is shown below:

For me, during the archiving process, it pops up a terminal window showing that dependency graphs have been loaded, as it should as follows:

After a minute or so, there are two compile-time errors, both in the same aforementioned file. I will show the full image here after the failed archiving process showing all the details:

Expected Results
I followed the steps for creating an archive on this link: http://www.idev101.com/code/Distribution/build.html
The steps on the website highlight that after creating an archive for the app, I should be able to “view the Archive build log by clicking on the Logs tab at the top of the navigator frame.” After that, once the build is complete, the Organizer window should open automatically (or go to Window -> Organizer) where the newly archived app will appear. I can export this archived file (a compressed version of the full application and associated packages) into a distribution tool to distribute the app to BETA testers to test on their phones. I am hoping to achieve exactly this.
Solutions already tried:
These are the solutions I have tried so far:

Adding React target dependency to to my project's target as below:

Adding React as a target itself to the project schemes and unchecking parallelize build as below:

Manually adding the React.xcodeproj as a Library to use in the project under <project>/Library and then adding libReact.a into the following:
a) Build Phases > Link Binary with Libraries as below:

b) General > Frameworks, Libraries and Embedded Content as below:

The React.xcodeproj was added in the following Library directory manually:

Commenting out line 9 and line 23 in the first image to see if those two are even needed. It turns out that even after this, the archiving fails with the other remaining warnings.

Trying to use the following react-native package versions: 0.60.0, 0.61.2, 0.62.1 and 0.63.3 with react peer dependency versions: 16.13.1 and 16.90 and in different combinations with each other to see if perhaps the file can be found in different versions of React. In some Github posts I read that the issue occurs only with RN versions lower than 0.61, which is why I chose to also downgrade the version. Initially, I had been using 0.62.1 and after that I was playing around with the various versions aforementioned.

Making sure that pod React is correctly added in my Podfile to link with the correct podspec as below is a line in my Podfile:

Adding subspecs for the various other React dependencies to my podfile and then running pod install within ios directory to ensure that the subspecs are also included as below:

When I tried the above, it threw me an error after doing pod install that some of the podspec files like the ones corresponding to RCTLinkingIOS and DevSupport cannot be found and therefore, pod install would fail:

I ensured I have $(inherited) in the header search paths and I also added ${SRCROOT}/../../../ios/Pods/Headers to the header search paths so that the project can detect the React dependency and associated files. I tried both of these with recursive and non-recursive strategies just for the sake of it. This is show below:

I have also ensured that I have $(inherited) as non-recursive in the Library search paths for both debug and release as shown below:

10)I have tried setting the Always Search User Paths (Deprecated) to both Yes and No. I tried Yes because according to Xcode help it states that enabling it may allow Xcode to search for libraries in the format <React/RCTLog.h> as well as in the format "RCTLog.h" as stated in the Xcode help window below (I am attaching it here for reference):

The setting is located under Build Settings > Search Paths as show below:

I downloaded the RCTLog.h file provided by React in this LINK and manually added it into the RNBranch.xcodeproj directory too as show below:

I then changed the import to: #import "RCTLog.h" in line 9 and line 23 to: NSString * const RNBNC_PLUGIN_VERSION = @"5.0.0"; of RNBranchConfig.m to let the file know that the RCTLog.h is located within its own Xcode project and that the current react native branch version is 5.0.0 (hardcoded) as show below:

After I try to archive the app; it fails again.

The last solution I tried was following the steps outlined on this Github issue post, but instead of linking react-native-branch, I tried linking and then doing pod install for both<EMAIL_ADDRESS>and<EMAIL_ADDRESS>hoping that when I run react-native link react-native and react-native link react, the machine will think that cocoapods is not installed, which apparently according to the link, is able to correctly link the React dependencies into the Xcode project and detected by packages using React.xcodeproj. For further details on the solution I tried, visit this issue comment: LINK. I followed the same steps even when linking the react-native-branch package, as that is the package causing this issue. But after much trial and error, the same error pops when I go to archive.

Now that I have described the all the solutions I have tried, you can see that I have tried so many different things to get RNBranchConfig.m to detect RCTLog.h in the React dependency, but NONE worked! I am currently out of options and that is why I ask for some help. We need to get our app release for BETA testing within two weeks now so: I hope this issue can be prioritized.
Snack, code example, screenshot, or link to a repository:
I have not created a Snack example since this issue is most likely related to project structure and configurations . Nor can I provide a link to our Github repo since this is a private, confidential project. Thus, I managed to reproduce this issue in newly created fresh React Native project with minimal code and created a public Github repository out of it: https://github.com/farhankassam2/PNM_179_Test_Project/.
Below I also provide the link to the library file precisely where the error is found (in the react-native-branch repo): https://github.com/BranchMetrics/react-native-branch-deep-linking-attribution/blob/3b3b3df9b72bc832d1c525627253ec9ac7955c1d/ios/RNBranchConfig.m.
Please do refer to screenshots of the above file structures too to get an idea of how the iOS project's sub-folder and sub-files were structured in the main project. You can find a screenshot of the error messages below:

I also have an Xcode archive log, which I shall attach below as a text file:
Archive PhoneMe_2020-10-14T23-10-15.txt
I also have a build log exported from the IDE when trying to build the React Native iOS app from the IDE here: build_log.pdf.
Any help is greatly appreciated.

I am referring only to the title, since the message is a bit long for my busy morning... :)
I faced similar errors while migrating a RN android app to iOS.
I fixed one error, and got a similar one for another file, and so on.
The solution in my case (more of a workaround) was to create a new project and copy over my app's files.

The solution in my case (more of a workaround) was to create a new project and copy over my app's files.

How do you know which files to copy. I created a completely new RN project, added the react-native-branch package and linked it manually (due to the package being old and requiring manual linking) and tried to build and it fails.
Here checkout this Github repo. Can you please try reproducing the error in your machine, perhaps with a different version fo macOS or Xcode? I want to see if it works with different versions of macOS or Xcode. It is very quick. Greatly appreciated if you can.
Thanks.

When i run pod install I get:
Auto-linking React Native module for target `PNM_179_Test_Project`: react-native-branch
Analyzing dependencies
Fetching podspec for `DoubleConversion` from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`
Fetching podspec for `Folly` from `../node_modules/react-native/third-party-podspecs/Folly.podspec`
Fetching podspec for `glog` from `../node_modules/react-native/third-party-podspecs/glog.podspec`
[!] CocoaPods could not find compatible versions for pod "Flipper-Folly":
  In snapshot (Podfile.lock):
    Flipper-Folly (= 2.3.0, ~> 2.2)

  In Podfile:
    Flipper-Folly (~> 2.2)

None of your spec sources contain a spec satisfying the dependencies: `Flipper-Folly (~> 2.2), Flipper-Folly (= 2.3.0, ~> 2.2)`.

You have either:
 * out-of-date source repos which you can update with `pod repo update` or with `pod install --repo-update`.
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

I assume that you are saying that you haven't copied your app's files yet, and you get the sample app. Right?

Yes I cannot as it is confidential and private. So I tried reproducing the error with just a fresh RN project with the package installed that causes the build-time error.

In 0.62.2 linking is supposed to be done automatically, but I did face issues when I also needed to link manually.

Indeed, I understand it should not be manually linked. But because the package is written in an old way, it requires manual linking unfortunately to fix another bug faced initially. So the linking only happens correctly if it is manually linked after de-integrating cocoapods, making the package think that the project has no cocoapods (and so it somehow links correctly because of this reason). I tested this multiple times and got this verified solution from another Github post with many thumbs ups.

Anyway, when i run pod install I get:

Oh just delete your ios/Podfile.lock file by doing rm -rf ios/Podfile.lock and then run pod install again. If that does not work, what you can even try is just remove the following files by doing rm -rf Podfile.lock Pods PNM_179_Test_Project.xcworkspace and then run pod install again. Installing pods regenerates these 3 files anyway and they may be blocking the pods installation error you face.
Let me know what versions of Xcode and macOS you are also using. It is okay if it is a version different from mine, as that is what I would like to test. Thank you 👍

I am using macOS Catalina, version 10.15.6, Xcode 11.5.
I have deleted the files as you suggested.
Running pod install gives the following output:
[!] Invalid `Podfile` file: undefined method `[]' for nil:NilClass.

 #  from /Users/yossi/Documents/frank/PNM_179_Test_Project/ios/Podfile:7
 #  -------------------------------------------
 #  target 'PNM_179_Test_Project' do
 >    config = use_native_modules!
 #
 #  -------------------------------------------

Hi @farhankassam2
The most descriptive issue description i have ever seen. Thanks for your effort :)
I downloaded sample project from github (https://github.com/farhankassam2/PNM_179_Test_Project/).
react-native-branch was already added in Podfile, therefore manual linking was not needed.
I removed RNBranch.xcodeproj under the Libraries, libRNBranch.a from Build Settings.

The RNBranch files already linked by cocoapods are shown the screenshot below.

After pod install, build succeeded.

If these steps solve the problem, please close the issue :)

Hi @gokhandoslu ,
Thank you for your comment. So RNBranch was already in the project because I had already built the project and pre-installed the npm package in the public repository (with manual linking when I had done it) so that those who are helping me test this would not run into the same first error I was facing, something along the lines of -lBranch not found.
In your case, it seems that you removed references to the RNBranch package and thence, managed to build and run the app via Xcode. However, this is not a valid soln. because I want to be able to use the RNBranch package for deep linking in our iOS app and this build issue only occurs AFTER having installed and configured the package correctly.
Either way, I did manage to find a solution that successfully builds the app with RNBranch package, and this solution is so trivial it blew my mind I am not even sure why it works but here it is:
I uninstalled react-native-branch version 5.0.0 and removed it from the yarn list of packages too by doing yarn remove react-native-branch. It seems as though I had two package managers, npm and yarn, that was configuring the package, which could be one cause of the problem. I decided to stick to using only npm for managing the package. After uninstalling, I followed the following steps precisely (similar to what is mentioned here but using npm as my package manager instead: https://github.com/BranchMetrics/react-native-branch-deep-linking-attribution/issues/361#issuecomment-415149270):
yarn remove react-native-branch
npm uninstall --save react-native-branch
react-native unlink react-native-branch
pod deintegrate ## removes the previously installed pods in the Pods directory
rm Podfile
npm install --save<EMAIL_ADDRESS>react-native link react-native-branch
git checkout -- Podfile ## puts the Podfile back
pod update Branch
pod install

My Podfile contained the following two necessary Pods before I ran any command starting with pod above:
  pod 'react-native-branch', path: '../node_modules/react-native-branch'
  pod 'Branch'

You may have noticed that I specified the installation of version 5.0.0-rc.1 as that is the one that removes this error. Perhaps the package mantainers need to look into why the newer version 5.0.0 fails to build the app.
After doing all the above, I simply went into the iOS directory and opened the project workspace. This allows me move to explaining my next mistake: I was mainly trying to build the app from the .xcodeproj but what worked for me was building the app from .xcworkspace. I opened the Xcode workspace of the app from within iOS directory and first, did Product > Clean Build Folder and after, Product > Build or Archive and tadaaaa!!! The app built successfully and now allows me to archive the app.
Since I have been stuck on this issue for some time, I had experimented a lot of different solutions as you can see from the issue description, but some experimentation still remains (I did not exhaust all possible solutions fully to give you an idea of precisely where the problem lies).
Certainly, the problem was not react-native related but that the package providers were not importing React dependencies into their package correctly. Therefore, some manual linking was required even despite my react-native version being >0.60 (for which we don't usually manually link by running react-native link). I did not try experimenting more after this simply because I wanted to avoid getting stuck again, but what I got from this is that the problem lies in either the following:

react-native-branch package has misconfigured something in their latest release of 5.0.0 and so the previous 5.0.0-rc.1 release resolves this build time error OR,
Linking a package via two package managers like yarn and npm is likely to cause some misconfiguration of the package as it is installed and configured twice by two different package managers. Therefore, it is recommended to only install and link a package via one package manager!!! OR,
Building and archiving of the app with this specific package only works in the Xcode workspace and not the Xcode project for some reason.

The former two are more likely the cause of the problem because I did experiment building and archiving with version 5.0.0 in the Xcode workspace but the had also failed for me.
I hope this fix helps those who are struggling with the same issue 👍

I am using macOS Catalina, version 10.15.6, Xcode 11.5.
I have deleted the files as you suggested.
Running pod install gives the following output:
[!] Invalid `Podfile` file: undefined method `[]' for nil:NilClass.

 #  from /Users/yossi/Documents/frank/PNM_179_Test_Project/ios/Podfile:7
 #  -------------------------------------------
 #  target 'PNM_179_Test_Project' do
 >    config = use_native_modules!
 #
 #  -------------------------------------------

I got this error too, Could you fix this issue?

You may want to try doing pod install --repo-update. If that does not work,
I think something is wrong with your Podfile itself because I am able to
install pods successfully with the steps I've highlighted in the sample
project.
Let me know.
On Fri, 30 Oct 2020, 3:57 am Whale<EMAIL_ADDRESS>wrote:

I am using macOS Catalina, version 10.15.6, Xcode 11.5.
I have deleted the files as you suggested.
Running pod install gives the following output:
[!] Invalid Podfile file: undefined method `[]' for nil:NilClass.
from /Users/yossi/Documents/frank/PNM_179_Test_Project/ios/Podfile:7
-------------------------------------------
target 'PNM_179_Test_Project' do

config = use_native_modules!

-------------------------------------------
I got this error too, Could you fix this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/30221#issuecomment-719485156,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFM7MOJLXXHVO52PHKQB4W3SNKLYRANCNFSM4SZKQDIA
.

use_native_modules

I upgraded my project to React-Native 0.63.3, but I got this error.  It's seem to Podfile can not find use_native_modules defined.So it can not install pod depends completely, such as React-Core、RCTText and so on. It only install yoga and Folly In my project, I can not figure out what happen, so anybody can help?

You may want to try doing pod install --repo-update. If that does not work, I think something is wrong with your Podfile itself because I am able to install pods successfully with the steps I've highlighted in the sample project. Let me know.
…
On Fri, 30 Oct 2020, 3:57 am Whale, @.***> wrote: I am using macOS Catalina, version 10.15.6, Xcode 11.5. I have deleted the files as you suggested. Running pod install gives the following output: [!] Invalid Podfile file: undefined method `[]' for nil:NilClass. # from /Users/yossi/Documents/frank/PNM_179_Test_Project/ios/Podfile:7 # ------------------------------------------- # target 'PNM_179_Test_Project' do > config = use_native_modules! # # ------------------------------------------- I got this error too, Could you fix this issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30221 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFM7MOJLXXHVO52PHKQB4W3SNKLYRANCNFSM4SZKQDIA .

I upgraded my project to React-Native 0.63.3, but I got this error.  It seems to Podfile can not find use_native_modules defined.So it can not install pod depends completely, such as React-Core、RCTText and so on. It only installs yoga and Folly In my project, I can not figure out what happen, so anybody can help?
The environment：
Xcode: 11.7
React-Native: 0.63.3

Sorry for the delay. I wasn't in the office for few days...
I also kept getting the same error, so I created a new project, installed react-native-branch, and the project still builds successfully and is running without any error.

Hi Yossi,
Thanks for your response. I did find a solution to it: the problem was
occuring in the latest release of react native branch. Did you install
branch version 5.0.0-rc.1 and so is that why the project built
successfully? I suspect that is why it built successfully.
Moreover, to archive our iOS app, I archived the workspace and not the
Xcode project itself. I am not sure if that is also what you did. Try more
providing more details in your comments next time.
On Mon, 2 Nov 2020, 9:15 am Yossi<EMAIL_ADDRESS>wrote:

Sorry for the delay. I wasn't in the office for few days...
I also kept getting the same error, so I created a new project, installed
react-native-branch, and the project still builds successfully and is
running without any error.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/30221#issuecomment-720607099,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFM7MOPT3ENDMJGJEFS2KXTSN3SMBANCNFSM4SZKQDIA
.

I installed the default - 5.0.0

My issue was resolved by updating the flipper to the latest version. I updated it from 2.3.0 to 2.5.


Add Wrapped MarbleCards and Marblecoin

Wrapped Marblecards
https://wrappedmarble.cards
https://etherscan.io/token/0x8AedB297FED4b6884b808ee61fAf0837713670d0
Marblecoin
https://medium.com/marblecards/an-introduction-to-marblecoin-mbc-bb17cff3ea78
https://etherscan.io/token/0x8888889213dd4da823ebdd1e235b09590633c150

Hi @estebanmino this is very helpful! I'll add the watchAsset code to the site for now!

Address not active


review FINOS documentation site, define what content should be merged into GS documentation site

@aitana16 - not sure I understand what content are you referring to; is this task already done? If not, what is missing? TY!


Needs a release!

I need a release! Please do away with my impatience.

(👍's for this Issue mean: "I love this project!")

😆
It's coming.

Delivered!
(Windows only for now)
https://github.com/HughIsaacs2/DatPart/releases/tag/0.0.1


Logging of JWT token to logs

Needs cleanup
https://github.com/digital-asset/daml-dit-if/blob/d05cf5e8a85a00f63ac02e4e44a570639c0c1b07/daml_dit_if/main/jwt.py#L46

resolved - only log the key now


lax.switch compilation time is super-linear in number of switch options

To demonstrate this, you can run the following (results below):
from time import time

import matplotlib.pyplot as plt

from jax import jit, lax
import jax.numpy as np

def time_switch(n):
  # Create list of functions
  inners = []
  for i in range(n):
    inners.append(lambda x: x ** 2)
  switch = jit(lambda i, x: lax.switch(i, inners, x))
  t0 = time()
  switch(0, 3.)
  return time() - t0

def bench_switch(ns):
  return [time_switch(n) for n in ns]

ns = [256, 512, 768, 1024, 1280, 1536, 1792, 2048]
times = bench_switch(ns)
plt.plot(ns, times)

The bottleneck appears to be in XLA compilation; I profiled time_switch (with n=1500 on CPU) and almost all time is spent in backend_compile:
.
Benchmark results (y-axis in seconds)
CPU

GPU

TPU

This isn't a critical issue for me, and I think it can be worked around by using nested switches, which seem to compile faster, but I thought it was worth raising nevertheless.

To be honest, I'm not that surprised that compilation time is superlinear for this kind of program. Looking at a C++-level profile, the majority of time is spent inside LLVM. So I doubt there's an easy fix here.

Closing since this is apparently caused by LLVM so out of our control.

(and I'm not in any way blocking on it).


Added support for adding a custom weapon instead of vandal

Saw a lot of people on discord asking if they can change the default vandal to phantom etc.. So with this PR they should be able to do so.
After the config file is created the user is asked to enter a weapon they use the most (The message could be cleaned up a bit I just wrote it as an example) after they enter the name it will be stored in the config file. Because it's stored in the config file and is not hardcoded the user can later change the weapon name without having to change the code and compile themselves like how it is now.

Small bug that occurs when running the script for the first time the prompt for the user to enter the weapon name is not shown and after you get into a game this error is shown -> "file not found or invalid file" even though the config.json file exists in the same directory.  But when the script is run a second time the error goes away and the prompt for the user to enter their weapon is shown.

The above commits solved the issue with the "file not found or invalid file" error I was having before. Basically in the current version config.json file is created when the FileNotFound error is caught in a try except block. This was the reason why it was not working, due to the code required to store the weapon name is never ran because the FileNotFound error was caught in the except block so it created the file before running the user prompt. That was why it only worked when it was ran a second time. Now I have made it so that the first thing it does is check if the file exists, if not create it before any other config related code is run.


On the acl /, everything is filtered out when self = false and ancestors = false

It seems to be due to that check: https://github.com/BlueBrain/nexus/blob/master/delta/app/src/main/scala/ch/epfl/bluebrain/nexus/delta/routes/AclsRoutes.scala#L190


Create a dedicated SSH keypair for the local env VM

That way, we ensure we get a hold on the whole env without being too
invasive.
This PR has:

[X] Appropriate testing (molecule, python unit tests)
[X] Appropriate documentation (README in the role, main README is up-to-date)

/approve

/approve
This has been tested locally, and CI will validate it (needed to add the community.crypto collection)

/lgtm


[Bug]: lucia (beta) package is marked as deprecated on npm

Package
lucia-auth
Describe the bug

I assume this is because the package name is being reused, and formerly referred to something else.
If you now control that package, you can undeprecate it: https://docs.npmjs.com/deprecating-and-undeprecating-packages-or-package-versions#undeprecating-a-package-or-version

No, that was my mistake. Accidentally published 1.0 instead of beta.x. Should be fine since we're starting with 2.0.

NPM didn't let me delete it :(

@pilcrowOnPaper But this is the correct package to use for Lucia 2.0?


can not run

Type of issue
Typo
Description
[在此处输入反馈]
C:\Users\AAAAAA>dotnet --list-sdks
'dotnet' 不是内部或外部命令，也不是可运行的程序
或批处理文件。
C:\Users\AAAAAA>dotnet --list-sdks
'dotnet' 不是内部或外部命令，也不是可运行的程序
或批处理文件。
C:\Users\AAAAAA>dotnet --list-runtimes
'dotnet' 不是内部或外部命令，也不是可运行的程序
或批处理文件。
Page URL
https://learn.microsoft.com/zh-cn/dotnet/core/install/how-to-detect-installed-versions
Content source URL
https://github.com/dotnet/docs/blob/main/docs/core/install/how-to-detect-installed-versions.md
Document Version Independent Id
79ec96d5-9c2c-1eaa-feb8-40b0afee6a30
Article author
@adegeo
Metadata

ID: 7f2842ce-ee53-ec35-90c6-791a952dfc3b
Service: dotnet-fundamentals
Sub-service: install

Hello @handsome12345,
The errors you see are caused by the missing dotnet.exe in the PATH of your system. Please see
Check for install folders in the article you linked.
Also, please go through the Install .NET on Windows article to make sure you have correct setup.

Hello @handsome12345,
The errors you're encountering are due to the missing dotnet.exe in your system's PATH. Please refer to the "Check for install folders" section in the article you mentioned. Try to set the path and try it again brother

Hello, I believe the comments here should help you solve the problem. Feel free to add more information if it didn't. Thanks!


Does not work under MacOS

@raghavmecheri #6
<EMAIL_ADDRESS>1): Library not loaded: @rpath/libc10.dylib
      Referenced from<EMAIL_ADDRESS>      Reason: image not found

@raghavmecheri #6
<EMAIL_ADDRESS>1): Library not loaded: @rpath/libc10.dylib
      Referenced from<EMAIL_ADDRESS>      Reason: image not found

I think the below discussion post is a good starting point
https://discuss.pytorch.org/t/how-to-make-c-programs-portable/68401

I think the issue is caused by the cmake library import mechanisms under MacOS. The cmake always link the library using absolute path on building. Since I introduced the prebuild tool recently, the library path on github action's machine are different from the path on your machine.
Related cmake docs and discussion:
https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/RPATH-handling
https://github.com/conan-io/conan/issues/3996
From the docs I think add the following code to cmakelists can solve the problem.
if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
    set(MACOS TRUE)
    set(CMAKE_BUILD_WITH_INSTALL_RPATH ON)
endif()

However, I do not have a MacOS machine, so I cannot test if it works. If you want to give it a try, you can make a pull request and download the pull request build artifact for MacOS. Then, replace the torch-js binary in your node_modules to the downloaded one and test if it works.

@arition Unfortunately, none of the situations I found online to make this work are working out. Do you think it makes sense to prebuild for Linux and Windows, and just build on install for MacOS?

I think setting the DYLD_LIBRARY_PATH may fix the issue, can you try pr #9?

Just going full circle here and confirming that #9 isn't the way to go. @arition Lemme know if you want me to remove the prebuild stuff if you're busy today, may have some time over the second half of the day :)

I have already delete the prebuild from github release. The prebuild script should no longer be able to download prebuilds on MacOS and Linux.

I have already delete the prebuild from github release. The prebuild script should no longer be able to download prebuilds on MacOS and Linux.

Do we need to bump the version on npm or something? yarn add torch-js@npm:@arition/torch-js still installs the prebuilt version for me

I have already delete the prebuild from github release. The prebuild script should no longer be able to download prebuilds on MacOS and Linux.

Do we need to bump the version on npm or something? yarn add torch-js@npm:@arition/torch-js still installs the prebuilt version for me

I tried on my linux machine and it do a build install. Maybe cache on your machine?

I have already delete the prebuild from github release. The prebuild script should no longer be able to download prebuilds on MacOS and Linux.

Do we need to bump the version on npm or something? yarn add torch-js@npm:@arition/torch-js still installs the prebuilt version for me

I tried on my linux machine and it do a build install. Maybe cache on your machine?

Yep -- prebuild has its own cache folder that I wasn't aware of -- fixed it :)


bot: signed commit

this is to fix CI error due to signed commit requirement
Push to branch main
Pushing to https://github.com/sustainable-computing-io/kepler.git
POST git-receive-pack (4[9](https://github.com/sustainable-computing-io/kepler/actions/runs/3120435867/jobs/5061011691#step:9:10)5 bytes)
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: Commits must have valid signatures.

@rootfs it seems that you need to sign your commit ;)

It looks -s is not sufficient for signed commits.

It looks -s is not sufficient for signed commits.

Humm, it should be....Probably there is a problem verifying the signed commits...

@marceloamaral you are right, signed and sign off are different. Signed commits look quite a logistic challenge. I disabled it. For the purpose of DCO, let's use commit signoffs.


fetch-intercept in React

Hi, the question is not complicated. How to use correctly your library with React?
I make a function call in this way:
import fetchIntercept from './fetchIntercept';

const App = () => {

  fetchIntercept(); <---

  return (
    <>
      ...content...
    </>
  );
};

Use the function once in the main file of your application like
import fetchIntercept from './fetchIntercept';

fetchIntercept(); <---

const App = () => {
  return (
    <>
      ...content...
    </>
  );
};

I've just done, but thanks for your reply! (forgot to close issue=) )


Missing map files cause error during initial editor launch

Steps to reproduce:

Close Unity.
Remove the map files.
Launch project.

Error message:
[Eflatun.SceneReference] Scene GUID to path map file not found!
UnityEngine.Debug:LogError (object)
Eflatun.SceneReference.Logger:Error (string) (at ./Packages/com.eflatun.scenereference/Runtime/Logger.cs:7)
Eflatun.SceneReference.SceneGuidToPathMapProvider:Load () (at ./Packages/com.eflatun.scenereference/Runtime/SceneGuidToPathMapProvider.cs:66)
Eflatun.SceneReference.SceneGuidToPathMapProvider:LoadIfNotAlready () (at ./Packages/com.eflatun.scenereference/Runtime/SceneGuidToPathMapProvider.cs:55)
Eflatun.SceneReference.SceneGuidToPathMapProvider:get_SceneGuidToPathMap () (at ./Packages/com.eflatun.scenereference/Runtime/SceneGuidToPathMapProvider.cs:27)
Eflatun.SceneReference.Editor.MapGeneratorTriggers.SceneAssetPostprocessor:OnPostprocessAllAssets (string[],string[],string[],string[]) (at ./Packages/com.eflatun.scenereference/Editor/MapGeneratorTriggers/SceneAssetPostprocessor.cs:11)
UnityEditor.AssetPostprocessingInternal:PostprocessAllAssets (string[],string[],string[],string[],string[],bool)

The map files are expected to be missing during the initial launch, so we should not print any errors at that point. Though the map generation still turns out fine, I am still marking this issue as a bug since it looks like one.

Fixed in #89. Will be included in the next release.

Included in 3.2.1.


5/eula interface

Create functional UI interface with 1) chat interaction 2) chat history 3) sidebar with file list
Basic VI

The Proce and eus in the logo are not centered (vertically or horizontally) and my OCD is kicking in.


[WIP] C API: adding error message handling

This is just an idea of what error message handling may look like.
Related to #74 (though that was for old interface).
Things to do:

[x] Change DTK_error to return const char *
[x] Do not change the signature for DTK_set_function
[x] Set errno to 0 for all API functions
[x] Add more tests for errno

Trigger a DTK_UNINITIALIZED error in tstInit.cpp
Call DTK_error() on success at least once and check that the message is an empty string.

[ ] Figure out DTK_UNKNOWN_ERROR

Codecov Report

Merging #263 into master will decrease coverage by 0.36%.
The diff coverage is 89.53%.

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   96.95%   96.59%   -0.37%
==========================================
  Files          49       49
  Lines        2496     2522      +26
==========================================
+ Hits         2420     2436      +16
- Misses         76       86      +10

Impacted Files
Coverage Δ

packages/Interface/test/tstC_API.c
97.43% <100%> (+0.04%)
:arrow_up:

packages/Interface/src/DTK_C_API.cpp
94.2% <88.88%> (-4.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af548d...c0ba528. Read the comment docs.

Yeah I think this is a great start. Do we want to keep as WIP or think about merging?

I'll update the PR later today.

I added a check list for the remaining items. Please update it if I missed anything.

[ ] Do not change the signature for DTK_set_function

I don't get that one

I don't get that one

In the previous patches I changed it to return int. This is not necessary as we can figure out if we failed by just checking errno.

OK.  From your answer to Stuart ("The return codes and errno play together...") I thought you wanted to keep it.  Anyway that's fine.  I understand that we can get the error code without it.

From your answer to Stuart ("The return codes and errno play together...") I thought you wanted to keep it.

No, I think we don't have to. It's just libc functions usually work that way. I'm not sure (and I would certainly like to know) what libc functions that return a meaningful thing (like a pointer, etc) do with errno and how do they check for errors.

Addressed everything but DTK_UNKNOWN_ERROR.

I think this is good. Looking at it again your use of DTK_UNKNOWN is appropriate as you are using it with catch(...). So I don't think it needs to be addressed unless you were thinking of doing something else.

How about the documentation for DTK_error()?

How about the documentation for DTK_error()?

Delegated to @dalg24.

So I don't think it needs to be addressed unless you were thinking of doing something else.

Theoretically, we could catch specific exceptions, store the exceptions message somewhere, and then return in in DTK_error. But it sounds like an overkill to me now. We don't even know if this model will last a long time.

sounds like an overkill

I agree

Do we just need to document DTK_Error() on this one? Not sure what needs to be resolved with DTK_UNKNOWN_ERROR

Do we just need to document DTK_Error() on this one?

I believe so. And rebase on top of master.

Ready for review.


CAMEL-14029 attempt to demonstrate issue w/ tests

https://issues.apache.org/jira/browse/CAMEL-14029
tried to demonstrate the issue w/ tests
not sure I understand the problem so feedback welcome

Oh it was about if there are no message body / empty body, then camel-netty / http components should take notice of this and use http status 204 instead as also mentioned here
https://httpstatuses.com/200
So the unit test you do setting that header in the route should not be done, but camel should figure this out itself and use 204 instead of 200

@davsclaus
Ah, gotcha. I misread that, thinking that the component was adding "No Body" and shouldn't.
I can take a crack at detecting an empty body and changing the status code.
I assume that capability should be for both when the component is used as a from() and a .to() endpoint

@davsclaus
so when the HTTP response body is "empty" we should change status code from 200 to 204
I assume empty = "", null, and a trim that results in ""
I assume that we would not switch status code unless it was a 200?

As today some return a fixed hardcoded text like "No body" or "No content".
if the body has the value "No content" or "No body" that would not be empty. Do we want to change that to empty and switch the status code in that case?

@davsclaus
so when the HTTP response body is "empty" we should change status code from 200 to 204
I assume empty = "", null, and a trim that results in ""
I assume that we would not switch status code unless it was a 200?

Yeah only if there is not explicit status code set, eg the end user may set 200 or what he/she wants.

As today some return a fixed hardcoded text like "No body" or "No content".

if the body has the value "No content" or "No body" that would not be empty. Do we want to change that to empty and switch the status code in that case?

Yes that was the point of the JIRA.

Is this what you have in mind
I know there is some cleanup to be done (remove commented out code etc)

@davsclaus
also this change (assuming it is close) is breaking other tests
    @Test
    public void testEncodedPath() throws Exception {
        String path = URLEncoder.encode(" :/?#[]@!$", "UTF-8") + "/" + URLEncoder.encode("&'()+,;=", "UTF-8");
        MockEndpoint mock = getMockEndpoint("mock:encodedPath");
        mock.message(0).header(Exchange.HTTP_PATH).isEqualTo("/" + path);
        mock.message(0).header(Exchange.HTTP_QUERY).isNull();
        mock.message(0).header(Exchange.HTTP_RAW_QUERY).isNull();

        // cannot use template as it automatically decodes some chars in the path
        HttpClient httpClient = new HttpClient();
        GetMethod httpGet = new GetMethod("http://localhost:" + port4 + "/nettyTestRouteC/" + path);
        int status = httpClient.executeMethod(httpGet);

        assertEquals("Get a wrong response status", 200, status);  <------------------- now gets a 204
        assertMockEndpointsSatisfied();
    }```

@omarsmak
let me know if the newer changes fulfill the issue

Thanks there is also camel-jetty & camel-servlet which would be good to have this logic too


Add ZoneId to ActorContext

An offset does not give enough information for time computation, because of daylight saving time transitions.
In addition to the offset, we need a zone ID for the case of possible time-related computations.

Closing as resolved.