[MP] Fix division by zero in network profiler

The debugger reports synchronizers with empty state to the editor even if no data is being sent to other peers.
The editor conditional to avoid division by zero was checking the wrong variable.
Fixes #96354 .
Draft status:

As reported in #96450 we might want to show 0 for outgoing sync too, to clarify that no data is being set (although the synchronizer is still being processed).

Just tested this fix, it seems to be working great now! No crash and an accurate sent size is being displayed!

how am I supposed to debug the actual send size, if it is constantly reported as being zero?

Currently, if it the state size is reported as zero, it means no data is being sent for state synchronization ("Always" variables).
I believe the network profiler has never been updated to include delta synchronization ("On Change" variables).
I'll create a proper proposal for a network profiler revamp to make the information clearer and include "On Change" states, but I think we should merge this as a crash fix in the meantime.

how am I supposed to debug the actual send size, if it is constantly reported as being zero?

Currently, if it the state size is reported as zero, it means no data is being sent for state synchronization ("Always" variables).
I believe the network profiler has never been updated to include delta synchronization ("On Change" variables).
I'll create a proper proposal for a network profiler revamp to make the information clearer and include "On Change" states, but I think we should merge this as a crash fix in the meantime.

Yeah, I agree, merging this first should be a priority.

Thanks!

Cherry-picked for 4.3.1.


Cocoapod Modules not Found

URGENT - Cocoapod Modules not Found
Description of the issue
When running Xcode tests, after pod installation, the Modules are not being found and failing. This is not the case on Local
/Users/vagrant/git/<ProjectName>/<ProjectName>.h:20:9: error: module 'Alamofire' not found @import Alamofire;         ^ <unknown>:0: error: could not build Objective-C module '<ProjectName>'
Environment:
Where did the issue happen?
Xcode 8.2 (Sierra) Test run
If on Bitrise.io: which stack? If not on Bitrise.io: on what operating system? (Plus any other information you can share)
Which build Step causes the issue and which version of the step?
Run Cocoapod Install - Always Latest Version
Xcode Test - Always Latest Version
Reproducibility

Does a "Rebuild" help? (You can trigger a rebuild from the Build's page, by clicking the "Rebuild" button in the top right corner of a finished build) : YES/NO

Rebuild never helps

Does a rebuild without caches help? (You can remove the Cache:Pull and Cache:Push steps temporarily to not to use the cache, or you can delete all the caches on the Settings tab of the app. : YES/NO

Not caching

If you have multiple different build configurations (workflows), does the issue affect all/more than one? : YES/NO

Yes this is happening on ALL projects at the moment

If it's an issue which happens sporadically, what's the frequency? (e.g. Once a day ; about x% of the builds) :

100%

Does upgrading the build Step to the latest version help? : YES/NO

No

When did the issue start? :

Few weeks now
Linux/Android stack builds
Can it be reproduced by running the build locally, after doing a clean git clone (git clone the repository, into a new directory, somewhere on your Mac/PC) and running the build from there with the Bitrise CLI ( https://www.bitrise.io/cli )? If no, can it be reproduced with Docker (using the same docker images / environment we use on bitrise.io)? Related guide: https://bitrise-io.github.io/devcenter/docker/run-your-build-locally-in-docker/ .
Nope
Other stacks
Can it be reproduced by running the build locally with our CLI ( https://www.bitrise.io/cli ), after doing a clean git clone (git clone the repository, into a new directory, somewhere on your Mac/PC) and running the build from there with the CLI ( https://www.bitrise.io/cli )?
Nope
Build log
Please attach the build log (you can download the build log from the build's page,
once the build is finished, using the "Download log" button - floating at the bottom right corner of the log viewer),
or if you can't attach the whole log then send the full log through a private channel (e.g. email - https://www.bitrise.io/contact ), with a link to the related GitHub issue.
Logs are private sorry, please request

If you use CocoaPods, you have to build/use the .xcworkspace, not the .xcodeproj. You most likely have the "project path" configured in your App Env Vars, with the key BITRISE_PROJECT_PATH - just change the value (the key should remain BITRISE_PROJECT_PATH!) from X.xcodeproj to X.xcworkspace.
Relevant parts of the log:
+------------------------------------------------------------------------------+
| (4<EMAIL_ADDRESS>                                                      |
+------------------------------------------------------------------------------+
| id: xcode-test                                                               |
| version: 1.18.1                                                              |
| collection: https://github.com/bitrise-io/bitrise-steplib.git                |
| toolkit: go                                                                  |
| time: 2016-12-16T06:29:42-08:00                                              |
+------------------------------------------------------------------------------+
|                                                                              |
INFO[06:29:42]  * [OK] Step dependency (xcode) installed, available.
INFO[06:29:42]  * [OK] Step dependency (go) installed, available.

Project Parameters:
- ProjectPath: REDACTED.xcodeproj
...

...
| ✓ | cocoapods-install                                             | 18 sec   |
+---+---------------------------------------------------------------+----------+
| x |<EMAIL_ADDRESS>(exit code: 1)                              | 69 sec   |
+---+---------------------------------------------------------------+----------+
| Issue tracker: https://github.com/bitrise-io/steps-xcode-test/issues         |
| Source: https://github.com/bitrise-io/steps-xcode-test                       |
...

Perfect, don't know why that has started defaulting to that value. Thanks

My guess is that when you did the initial setup of the project you did not have CocoaPods (Podfile) in your repository, and you added that later. This environment variable is set/generated during the app setup, and not changed after that, unless you change it.

Thanks for reporting btw, I'm sure this will help others in the future! ;)


Scene.pickWithRay fails if Scene.useRightHandedSystem = true

See the repro here: https://playground.babylonjs.com/#J05VA5
The sphere should be picked and tinted red, but it is not.  If rightHandedSystem is set to false all works as expected.

Thanks for the quick fix!


Revert "Minor cleanups"

This PR collides heavily with the inflight IPFS rebase. Will need to roll this back and reapply after the IPFS rebase is completed in the next day or so.
Attn: @gubatron will reopen the original PR after this is merged

Coverage remained the same at 34.074% when pulling be84e7a8d40484081f6cb1f4ee21df2e05c6e97d on revert-1306-minor-cleanups into 6ffe3c770363e4a092ad313ddb018b987d5de88a on master.


getPosteriorLogDensity method of conjugate samplers doesn't modify target value

DO NOT MERGE.
Creating PR to trigger testing.

This PR has passed testing, suggesting the conjugate samplers still function correctly with these changes.
Waiting for @paciorek to determine if this fixes the problem he observed (#924) in the crossLevel sampler.

Looks good, except I'll note that even in identity link cases we write back into the model even though model[[target]] has not changed. Is it worth checking and only doing this if necessary? Or best just to always do it?

@danielturek I'd like to merge this in soon. Can you look at the identity link case and see what you think vis-a-vis my comment above?

@paciorek Apologies that this slipped by me back in August.
I've just updated the crossLevelFix branch to reflect your suggestion: the conjugate sampler will not "restore" the value of the target node, nor call model$calculate(...), when the link is "identity", in which cases they should not have been modified.
Please take a look any time, and let me know if you agree.
Assuming so, I'm fine for you to merge this in.


bug: Suggestion CC possible regex error with prefix +

Describe the bug in as much detail as possible:
Prefix of the server is + and whenever the suggestion cc is set with that regex (the cc regex to match server prefix) it fails and errors to "Did not set regex to match Server Prefix" which it shouldn't. Reach out to <@676260964064165908> on discord (ღRuniRiotღ#6782) if you have a fix for this.
To Reproduce:

Set prefix to + and bring the suggestions cc and change the - to +
Try to run with +suggest testing for science or something
And find that it defaults to "Did not set regex to match Server Prefix"

Expected behavior:
It should just send the suggestion, but it does not.
Screenshots:
Error with + prefix

Works with prefix of -

happened to me once, if my server prefix is ? and the regex is - then it will error that

happened to me once, if my server prefix is ? and the regex is - then it will error that

You should probably reread the issue. The problem occurs when when both, server AND CC prefix is set to +

What is your regex for suggest command?

Fixed in #131


Add autosuggest to author fields

Describe the improvement
Authors' first and last name fields are currently free text fields. An autosuggest on these fields to be able to select from the data in the UGent employees/students would allow to add user ids and to avoid typos.
To Reproduce

Go to 'publication' page
Click on 'Authors & Editors' tab
Click on 'Add author'
Fill in first name and last name fields

Expected behavior
When I start typing a first or a last name, I receive suggestions based on the UGent employee/student listing from which I can select the correct author. After selection, both first and last name fields are filled with the result of the selection. Possible, this needs to be done using 1 field for first and last name combined.
Screenshots
current:

future

@sdebodt @nics and if there is not a match (external author), how should we split the input back into first and last name?

Implemented


Adding a management command to add domains and devices

Related to #
Description of changes
Adding a new management command for adding devices and domains
Notes
Legal

[x] I certify that I have all necessary rights to publish this contribution under the MIT license. I agree to the Trustpoint CLA and have added my name to the AUTHORS.md file.

Hi @FHatCSW , there was a circular import error in the serializer, which got fixed with the main merge.
We now load the onboarding_protocols instead of hardcoding, so that when we merge the browser_onboarding it gets automatically added.
Otherwise my question. What is the usecase of this command? Since we don't add an IssuingCA we can not onboard the devices.

Hi @BytesWelder,
thanks for the clarification. The main idea was to populate the database with some realistic values of machine devices and domains. Mainly for showcasing stuff. We could randomly assign the available Issuing CAs to the domains to extend this.

I would recommend it. So in a showcase situation, if asked we can also demonstrate an onboarding :)

Looks good to me too. I'll merge the pull request.


Add a simple language selector.

https://github.com/mikebryant/ac-nh-turnip-prices/issues/136
The selector at the bottom of the page.
Demo

The selector could use some styling love, but we can raise that in another issue if that's outside your wheelhouse.

The selector could use some styling love, but we can raise that in another issue if that's outside your wheelhouse.

OK, I’ll try it.

From the UX side we should investigate as @theRTC204 mentioned.
I think we need to move the language selector also to the top of the page that people directly can see that they can switch the language.

I thought about suggesting moving it, but then since the app automatically changes to your system language, I felt being at the bottom was ok.


[APIM-4.0.0] Upgrade httpcore-nio to v4.4.15 to avoid CPU spike

Description
CPU getting spiked suddenly even with a very low load and never goes down. This results to a step by step CPU overload (20% then 40% etc until 100%), and the only thing to do about that is to restart the gateway.
This issue is known since APIM-3.2.0 as a httpcore-nio issue which causes CPU leak. It was resolved in httpcore-nio 4.4.15 version but APIM-4.0.0 still use httpcore-nio 4.4.14.
I found a link to download the last 4.4.x version here and pasted it in /repository/components/plugins folder. Now I want to manually patch APIM4.0.0 to use this httpcore-nio version instead of the buggy one.
So my questions are :

Do I need to use httpcore 4.4.15 too if I use httpcore-nio 4.4.15 ?
Which files do I need to modify to use v4.4.15 ? I found a file called repository/components/artifacts.xml, do I just need to replace the httpcore-nio version inside it ?

Any help would be very appreciated.
Affected Component
APIM
Version
4.0.0
Environment Details (with versions)

debian-11
wso2am-4.0.0
openjdk-11.0.2

Related Issues
https://github.com/wso2/product-apim/issues/9685
Suggested Labels
No response

I replaced the three files impacted by 4.4.15 patch from 4.4.15 to 4.4.14 and re-created the 4.4.14 jar archive.
Here is a link if someone want to use it : https://filetransfer.io/data-package/btAL8nKz#link
Just rename it httpcore-nio_4.4.14.wso2v1.jar, overwrite the original one and restart.

Hi @Johnson66666 ,
I'm having the same issue here with our production environment
Could you please share more in-depth instructions on resolving this issue or share needed jar files one more time? The link https://filetransfer.io/data-package/btAL8nKz#link seems expired.
More in-depth steps of issue resolution would be greatly appreciated :)


[Enhancement]: jsx-handler-names reports error with inline ternary conditional callbacks

Is there an existing issue for this?

[x] I have searched the existing issues and my issue is unique
[x] My issue appears in the command-line and not only in the text editor

Description Overview

Conditionally applying callback functions with inline ternary statements violates the rule, even when the condition will satisfy the rule.
<MyComponent
  onClick={isClickDisabled ? undefined : handleClick}
/>

ESLint: Handler function for onClickNext prop key must be a camelCase name beginning with 'handle' only(react/ jsx-handler-names)

Expected Behavior

If there is an inline ternary condition and it returns the properly named function, it should pass.
eslint-plugin-react version
v7.37.2
eslint version
v8.57.0
node version
v20.17.0

I hope it's ok that I've changed the name to Enhancement. Since it's not technically a bug because it is not written to support this, it's a request for enhancement.


ProxymanLLC.Proxyman version 0.7.0

Submission containing materials of a third party: Copyright © 2022 Proxyman LLC. All rights reserved.
https://proxyman.io/eula

[ ] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree


Table Data Entry Suggestions

Selecting a cell does not allow data entry, it currently needs to be double-clicked - once to open the cell editor and once to get the focus onto the cell.  Then typing is allowed but it is not sticky unless the user overwrites an existing character - prepended or appended digits go missing on exit of cell.  Thus, we need four clicks to edit the cell - 1. select the cell, 2. open the editor, 3. allow data entry, 4. select existing string.
Suggestion: It would be ideal if selecting a cell allowed for immediate editing.  An interim solution would be to reduce the clicks to two and provide for prepending and appending.

Some additional explorations uncovered some finer points here.
Scenario 1: click on a cell, click to open editor, click to put mouse at end of existing string, append a digit, click another cell in the same row, digit goes missing.
Scenario 2: click on a cell, click to open editor, click to put mouse at end of existing string, append a digit, click  a cell in ANOTHER row, digit sticks.
The above scenarios work for prepending as well.  The differing behavior between the two scenarios is also evidenced if a non-digit is entered: Scenario 1 recovers gracefully and removes the non-digits, while scenario 2 throws an unhandled illegal argument exception and hangs up the editor.


Some ItemStack mappings from yarn.

Any reason why this never got merged/reviewed?

Any reason why this never got merged/reviewed?

Any reason why this never got merged/reviewed?

Afaik 6pak didn't have time to


Connection protocol testdev

Added Some Connection Protocol Tests.
Test Harness enhancements.
Dockerize the Test Harness.
New Quick Start Guide

Unfortunately, I'm seeing some problems and am not able get this running.  I think we are leaving you too much on your own about issuing we've solved. We need to get together to talk things over. Definitely not your fault.  We just need to see if we can help more.  These are all minor issues, but they need to addressed.

preference would be that you forked this repo and then did PRs from branches in your fork.  That's the normal dev model we use.
the 5 commits are not signed, which is not permitted.  See the DCO notice above. Obviously I forgot to make sure you knew that.  Likely that can be fixed - see the "All checks failed" link above and the "Details" on the DCO.
I couldn't get the agents to run - the method of finding the genesis file didn't seem to work.  Not sure what the issue is, but the easiest solution is to likely just get this into a docker-compose file so that (a) we don't have to do that finding the docker gateway IP and (b) so that we can run everything in the same terminal session.  I think we can get some help on this as soon as we can get this running.

I'm sure things are working for you, so would really like to see a demo tomorrow/Wednesday of the tests and test cases!

Just read the rest of the Quick Start guides. Can't wait to get things running so we can try everything!

Thanks. I did not know about the fork requirement.
The DCO stuff is my fault. You had mentioned it in chat and I glossed over it not know what it was, and didn't follow up with the research.
Can you tell me what error you are getting. I did a fresh pull of everything in a clean environment and all seemed to work fine.
I think the docker compose is a great idea but I think it is a little pre-mature. We are not sure yet if the test harness will provision the agents are not, so it may look really different in the not too distant future. The way it is now is far easier than it was a few weeks ago.
I'll see if I can fix the DCO stuff and create a fork and submit a new PR.

I guess that would help, eh?  The error message is: Error retrieving ledger genesis transactions
I also tried a number of variations on the LEDGER_URL other than what was suggested, including using localhost and Dockerhost, but all gave the same error.
FYI - why do I need to git clone the indy-sdk?  I didn't do that, inc case that matters.

Re: the docker-compose.  The quickstart should allow just go and run so I don't think it is early for that.  There needs to be docs about how the user would then use the environment - e.g. write their own backchannel, run their own agent, etc.

I was under the assumption that in order to run the ledger you needed the indy-sdk. Does not the von-network use that? Ian had it in the original guide along with von-network.
I have the DCO signing fixed. Now working on figuring out how to fork and move my branch commits to it.

No need to move these commits over - we can accept these now that they are signed.  Just in future, use a fork.  von-network embeds the indy-sdk, as do the ACA-Py agents.  No need to have it on your system.

Ah yes you are right. indy-sdk was never copied into the container anyway. I'll remove that line.


Extension download

hi, can you add an extension that has the function of enter download links and choosing a folder to save right on web ui, because every time you need to download more vae, the model, lora...other is not in civitai, you need to turn off webui and run the wget command

thanks for the idea @yesyeahvh123 we have now Colab Run Command inside Hugging Face extension


[Windows] Add dotfuscator component to VS2022

Description
Dotfuscator comes installed with VS in the windows-2019 image, but not in the windows-2022 image. Installation time in runtime varies from 4 to 6 minutes so better have it preinstalled.
Related issue:
https://github.com/actions/virtual-environments/issues/5936
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run windows2022


Add cursor left-right handling

also makes sure empty messages don't clutter the history

Awesome, thank you very much!

After some testing, it still doesn't display the cursor in the right place for me. I think it's being reset when the line is cleared or something, not sure. Also there's still debug prints, but that's not a big deal

To be clear - it works, but the cursor isnt visually in the right place yet


Add carrier frequency for GNSS Satellite

Summary

uORB/sensor: Add carrier frequency for GNSS Satellite
The struct sensor_gnss_satellite.cf(carrier frequency) can be parsed from GSV.signal_id(e.g. NMEA 0183 v4.11) and struct sensor_gnss_satellite.constellation(sv_type)
See https://github.com/apache/nuttx/pull/15296
uORB/sensor: Update macro of sensor_gnss format string

Impact
uORB/sensor
Testing
NuttX CI (depends on https://github.com/apache/nuttx/pull/15296)

@Donny9  Could you review this PR please?


computed callback is triggered unexpectedly

Vue version
3.3.4
Link to minimal reproduction
https://play.vuejs.org/#eNptkM1ugzAQhF9l5QtQUSgcW4PUZ+ix7gGZjUHyn4yhB8S7d1NKlCY57oznm/Wu7N37YpmRvTI+yTD6CBPG2bfCjsa7EGGFgKccpDN+jtjn8N1FOcAGp+AMJJRNhBVWOjtFiGFUCgM051BaZW/CAhymrEg/OGmaQdMegWLp9IzwBC9H5LcllVUO+8MzwmkstFNpQiQ5dFZhn2Q3HfV9x6esdv7XDbx+DK//w3m5H4ZOQkNE43UXkSYAPlTtul5+vW28JOXKoUUfiHUR3QeFrKL6a3+0tDcsz8b1qBvB/sCCkc3LSzXbfgCirI+4
Steps to reproduce

Make a computed variable always return the same value whatever its dependency changes.
Create another computed variable which wraps the previous computed value with an array (or Object), in this way it will always return different reference (value) whenever its element changes.
Watch the second computed value.

What is expected?
The second computed value shall never trigger watch callback because its dependency never changes, thus it never create a different reference.
What is actually happening?
But it triggered unexpectedly, that may lead to duplicating side effects
System Info
No response
Any additional comments?
No response

This is expected, because the trigger is determined by comparing the oldValue and the newValue. In your example, const c2 = computed(() => [c1.value]);, even though c1.value didn't change (so the first watch was not triggered), you wrapped it in an array when returning it, which always made it unequal, like [0] === [0] was always false, so the second watch was triggered.

Thank you qijizh for answering! The point is that the first computed (c1) has not changed, it might recompute because its dependency's value has changed, but the output of the computation remains the same (0 === 0). Thus the watcher observing c1 is not triggered, but why is c2's recomputation triggered if its only dependency has not changed?
I believe the triggering rules for both 'watch' and 'computed' were identical, which means if the dependency of a watch does not trigger the watch's callback, then the same dependency will not trigger a recomputation of computed properties.

Not meant to close

Not meat to close this

related (i guess) https://github.com/vuejs/core/pull/5912


Modify map_shapefile to colour by attribute value

Proposed changes
I've just created a new PR that follows on from #499 as the fork it was based on doesn't exist any more. This includes all the main changes implemented by @Gabzgit , plus a few extras on top:
gabzgit changes:

Adds the gdf as a choropleth onto the ipyleaflet. Requires a column name to colour by.
If remap is false, it will colour based on the values in the specified column. This is better for continuous variables.
If remap is true (default) the values will be changed for better visualization. This is better for categorical data. For example, if original values are 111, 112 and 215, on a colour ramp 111 and 112 will be very similar. So remap to 0, 1 and 2.

robbibt changes:

Polyline shapefiles plot as black only in map_shapefile due to the Choropleth function only controlling fill colour. To address this, I've used a bit of a hack by extracting the raw geojson using choropleth.data, copying fill colours to line colours, and then plotting this directly for line features.
Have renamed remap=True to continuous=False to make it it a bit more intuitive to choose the right option for your data
Added a **style_kwargs kwarg so that users can pass in custom style params
Based hover_col off the field selected by attribute for simplicity

I've updated all the notebooks based on map_shapefile so they work with the new function. Example of it in action in the machine learning notebook (@s-m-t-c ):

Closes issues (optional)

Closes Issue #477

@Gabzgit Good idea, will add this as an option

@Gabzgit I've updated it so the default hover_col value True will use the attribute field, but the user can pass in a custom string giving a different attribute field if they want to


[x] Unit tested (coded, passed, included)?
[x] Requested at least 2 reviewers?
JIRA: MT-738

Why so many PR?
Is the a sequence you are following, wrt merging to master?

@mmphego The sequence we are trying to follow is that the PRs cascade.
You should review them in order from the earliest one first and merge them in that way also.
This is my interpretation of

The idea is to create small incremental PR's and deliver value instead of one giant intimidating PR.

We wanted to carry on yesterday as there were not many people reviewing the PRs and it was blocking us from carrying on.
Knowing your love for blog posts you can read these below.
https://graysonkoonce.com/stacked-pull-requests-keeping-github-diffs-small/
https://github.com/frappe/erpnext/wiki/Cascading-Pull-Requests

PR is blocked by #106


these lines set CXTranslationUnit_Flags.CXTranslationUnit_DetailedPreprocessingRecord always, is it is wrong settings?

https://github.com/xoofx/CppAst.NET/blob/6c262241d4f37a952189bac5dd2be87c26ab672b/src/CppAst/CppParser.cs#L117-L121

Yep likely


E2E test for trust domain alias client side secure naming.

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

Hi @liwenhao0810. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@incfly

Oh I remembered it's because without DestinationRule. Auto mTLS will send
plaintext traffic to the server side. This should be commented around the
config. Something like:
// We explicitly configure the client side to send mTLS traffic via
Destination Rule.
// The server applications are naked without sidecar injection.
// By default, auto mTLS makes clients send plain text traffic for
endpoints without sidecar.

On Thu, Oct 22, 2020 at 6:44 PM liwenhao0810<EMAIL_ADDRESS>wrote:

@liwenhao0810 commented on this pull request.
In
tests/integration/security/ca_custom_root/trust_domain_alias_client_test.go
https://github.com/istio/istio/pull/28206#discussion_r510549248:

"path"

"testing"
+)

+const (

HTTPS  = "https"
POLICY = `
+apiVersion: "security.istio.io/v1beta1"
+kind: "PeerAuthentication"
+metadata:
name: "mtls"
+spec:
mtls:
mode: STRICT
+---
+apiVersion: "networking.istio.io/v1alpha3"

getting error without the destination rule.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/28206#discussion_r510549248, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMVXB5YUBPDFVVOUK355CLSMDNXXANCNFSM4S32L3HA
.

/ok-to-test

@liwenhao0810: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test lint_istio

analyze-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test lint_istio

analyze-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test analyze-tests_istio

release-notes_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test lint_istio

analyze-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test analyze-tests_istio

release-notes_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test release-notes_istio

gencheck_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test lint_istio

analyze-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test analyze-tests_istio

release-notes_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test release-notes_istio

gencheck_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test gencheck_istio

integ-security-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test lint_istio

analyze-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test analyze-tests_istio

release-notes_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test release-notes_istio

gencheck_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test gencheck_istio

integ-security-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test lint_istio

analyze-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test analyze-tests_istio

release-notes_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test release-notes_istio

gencheck_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test gencheck_istio

integ-security-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test lint_istio

analyze-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test analyze-tests_istio

release-notes_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test release-notes_istio

gencheck_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test gencheck_istio

integ-security-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test lint_istio

analyze-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test analyze-tests_istio

release-notes_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test release-notes_istio

gencheck_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test gencheck_istio

integ-security-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test lint_istio

analyze-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test analyze-tests_istio

release-notes_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test release-notes_istio

gencheck_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test gencheck_istio

integ-security-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test lint_istio

analyze-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test analyze-tests_istio

release-notes_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test release-notes_istio

gencheck_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test gencheck_istio

integ-security-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test lint_istio

analyze-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test analyze-tests_istio

release-notes_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test release-notes_istio

gencheck_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test gencheck_istio

integ-security-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test analyze-tests_istio

release-notes_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test release-notes_istio

gencheck_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test gencheck_istio

integ-security-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test unit-tests_istio

lint_istio
c72ef3ff0f56156dc06d436740194cc5df5046fb
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test analyze-tests_istio

gencheck_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test gencheck_istio

integ-security-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test unit-tests_istio

lint_istio
c72ef3ff0f56156dc06d436740194cc5df5046fb
link
/test lint_istio

release-notes_istio
c72ef3ff0f56156dc06d436740194cc5df5046fb
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
05174f3f6705d1273289ef9b1305ffc4cb4c2663
link
/test integ-telemetry-k8s-tests_istio

lint_istio
c72ef3ff0f56156dc06d436740194cc5df5046fb
link
/test lint_istio

release-notes_istio
c72ef3ff0f56156dc06d436740194cc5df5046fb
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
c72ef3ff0f56156dc06d436740194cc5df5046fb
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
c72ef3ff0f56156dc06d436740194cc5df5046fb
link
/test lint_istio

release-notes_istio
c72ef3ff0f56156dc06d436740194cc5df5046fb
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
c72ef3ff0f56156dc06d436740194cc5df5046fb
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c72ef3ff0f56156dc06d436740194cc5df5046fb
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
c72ef3ff0f56156dc06d436740194cc5df5046fb
link
/test lint_istio

integ-multicluster-k8s-tests_istio
c72ef3ff0f56156dc06d436740194cc5df5046fb
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c72ef3ff0f56156dc06d436740194cc5df5046fb
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
8006371015685053f8c73e0f0c1e740d33b71d0d
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8006371015685053f8c73e0f0c1e740d33b71d0d
link
/test release-notes_istio

integ-telemetry-k8s-tests_istio
8006371015685053f8c73e0f0c1e740d33b71d0d
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn mind taking a look as wg test-release/doc owner? Thanks!

@istio/wg-docs-maintainers @istio/wg-test-and-release-maintainers could you take a look of this PR? Thanks.

/cherrypick release-1.8

@liwenhao0810: new pull request created: #29017

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Detect uncaught rejection in Promise

If I trigger an event from a promise onFulfilled function and an error is thrown from the handler of the event mocha doesn't detect this Error.
I create a fiddle where this can be seen: http://jsfiddle.net/dsrhmvLz/3/.
AFAIK there is no standard way of detecting this unhandled promise rejection but using bluebird it can be detected with the unhandledrejection event as seen in the fiddle. Could it make sense adding support for this in mocha? There is another way of detecting this? If I'm not wrong currently something like this is done in mocha with the uncaughtException event.
With this little change (http://jsfiddle.net/dsrhmvLz/4/) the error is detected by mocha but it would seem nicer seeing the uncaught rejection in mocha without that trouble.

We could take advantage of https://nodejs.org/api/process.html#process_event_unhandledrejection in newer versions of node as well

I'd like to see support for tracking unhandledRejection included as well.  For reference, I'm currently converting any unhandledRejection into unhandledException in a global helper using the following code.  This seems to work quite well for me.
if (typeof process !== 'undefined') {
  process.on('unhandledRejection', function (reason) {
    throw reason;
  });
} else if (typeof window !== 'undefined') {
  // 2016-02-01: No browsers support this natively, however bluebird, when.js,
  // and probably other libraries do.
  if (typeof window.addEventListener === 'function') {
    window.addEventListener('unhandledrejection', function (evt) {
      throw evt.detail.reason;
    });
  } else {
    var oldOHR = window.onunhandledrejection;
    window.onunhandledrejection = function (evt) {
      if (typeof oldOHR === 'function') oldOHR.apply(this, arguments);
      throw evt.detail.reason;
    };
  }
} else if (typeof console !== 'undefined' &&
    typeof (console.error || console.log) === 'function') {
  (console.error || console.log)('Unhandled rejections will be ignored!');
}

I agree that it would be great to have this support, especially in addition to the timeout message. Today when an error unintentionally gets caught in a Promise, eg. because an error was thrown from within callback that wasn't expected to be called from a Promise chain, one just gets a timeout error and no indication on what the cause may be.
Adding any unhandled rejection data to at least the timeout error would be very helpful:
  1) Foo should bar:
     Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.

(The possibility of generally considering unhandled rejections to be test failures would also be kind of nice)

@voxpelli I've written some stuff around the capability to detect and properly handle uncaught async exceptions here, but probably haven't covered this use-case.
Originally, I had wanted to even detect async execution via async_wrap, but depending on the version of Node.js used, even a console.log() will make an async write to the stdout stream...

Are this and #2640 duplicates of each other?

closing, see duplicate #2640


Repository Upgrade according to guide-open-source v22 version

https://github.com/MyPrivateRepositories/guide-open-source

https://github.com/Ruben-Arushanyan/react-component-shell/releases/tag/v3.0.0


[SDWebImage] How can I use this alongside FFImageLoading without breaking the linker with duplicate symbols?

[SDWebImage]
I have an existing Xamarin.iOS application that uses SDWebImage that I want to start adding Native Forms to, and for the Native Forms pages I want to use FFImageLoading. However, when I add them both to the project (and then also use a bit of their code in AppDelegate.cs) I get tons of errors like:
Native linking failed, duplicate symbol: '_WebPAllocateDecBuffer'.

Duplicate symbol in: /.../liblibwebp.a(buffer_dec.o) (Location related to previous error)

Duplicate symbol in: /.../WebP.a(libwebpdspdecode_neon_la-alpha_processing_neon.o) (Location related to previous error)

Is this because they both have their own bindings to WebP? How can I work around that?

I have this issue as well when I want to create a custom Forms renderer that uses SDWebImage while FFImageLoading is already being used in Forms. Until this issue is fixed, I can't make further progress.
@Redth Is there a temporary workaround?

@SotoiGhost can you comment on this?

Czy masz jakieś pomysły, jak sobie z tym poradzić? Chcę również używać SDWebImage wraz z FFImageLoading.

Resolved this by deleting FFimage in favor of SDWebImage & Glide. I decided on that move because i wanted to share 1 library for all of my iOS projects. (Apple TV OS and XF iOS app)

There could be a complex workaround for this, which is to remove the WebP part of one of the libraries but I'm not really sure if this will work. A solution could be updating SDWebImage to v5.x which removes the WebP part from their framework. I think we have the update task in our TODO list but we don't have an ETA for the release. If someone wants to update SDWebImage, Community PRs are very welcome! 😊

I think we have the update task in our TODO list

@SotoiGhost Is this being tracked anywhere so we have more visibility?

@adrianknight89 I think no, we haven't created any issue or task publicly.

Is there any black magic like an mtouch argument that worths exploring? I have a similar situation, already tried --registrar:static and made sure all libs have SmartLink = true.


az monitor activity-log list help document categorize the argument wrongly.

16:42 $ az monitor activity-log list -h

Command
    az monitor activity-log list: Provides the list of activity log.

Arguments
    --filters          : The OData filter for the list activity logs. If this argument is provided
                         OData Filter Arguments will be ignored.
    --max-events       : The maximum number of records to be returned by the command.  Default: 50.
    --select           : The list of event names.

OData Filter Arguments
    --caller           : The caller to look for when querying.
    --correlation-id   : The correlation id of the query.
    --end-time         : The end time of the query. In ISO format with explicit indication of
                         timezone: 1970-01-01T00:00:00Z, 1970-01-01T00:00:00-0500. Defaults to
                         current time.
    --resource-group   : The resource group.
    --resource-id      : The identifier of the resource.
    --resource-provider: The resource provider.
    --start-time       : The start time of the query. In ISO format with explicit indication of
                         timezone: 1970-01-01T00:00:00Z, 1970-01-01T00:00:00-0500. Defaults to 1
                         Hour prior to the current time.
    --status           : The status value to query (ex: Failed).

Global Arguments
    --debug            : Increase logging verbosity to show all debug logs.
    --help -h          : Show this help message and exit.
    --output -o        : Output format.  Allowed values: json, jsonc, table, tsv.  Default: table.
    --query            : JMESPath query string. See http://jmespath.org/ for more information and
                         examples.
    --verbose          : Increase logging verbosity. Use --debug for full debug logs.

The resource group, resource id, resource provider, start time, status are not odata filter.

These parameters are in the OData Filter Arguments group because they are exclusively used in the construction of the OData Filter. Closing.


Remove the buildflags from the non-native cli build command.

The -i buildflag tries to install dependencies into the pkg directory.
This requires root auth. The flag is not necessary when building the
cli for other OSes.

Please don't merge this yet. The changes are much more than just the CLI

Refer to PR #461 for a more comprehensive fix.


adding new annotation

Summary

Short summary of what's included in the PR
Give special note to breaking changes: List the exact changes or provide links to documentation.

Checklist
For Code changes

[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog
[ ] PR contains the label area:operator
[x] Link this PR to related issues
[x] I have not made any changes in the charts/ directory.

For Helm Chart changes

[ ] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog
[ ] PR contains the label area:chart
[ ] PR contains the chart label, e.g. chart:k8up
[ ] Variables are documented in the values.yaml using the format required by Helm-Docs.
[ ] Chart Version bumped if immediate release after merging is planned
[ ] I have run make chart-docs
[ ] Link this PR to related code release or other issues.

Hi
Haven't yet looked at the code, but please give this PR a more meaningful title and summary. They will be used to generate the changelog for the next release.


Better support for cross-compiling to 32 bit

After these changes, all of the following now work correctly and produce a different target triple (in particular, compiling 32 bit on 64 bit host will put outputs into i386-pc-linux-gnu):
$ make # compiles normally
$ make -i ARCH=i386 # compiles for 32 bit x86, uses -m32 if host is x86_64
$ make -i CC=aarch64-linux-gnu-gcc # compiles for aarch64
$ make -i MACHINE=aarch64-linux-gnu # same as above

Sweet, thanks!


⚠ Bofrost.at has degraded performance

In 7602df9, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1885 ms

Resolved: Bofrost.at performance has improved in a980743.


ChatGPT response for issue #38

Adding a file containing the ChatGPT gpt-3.5-turbo response for issue #38:
Option Explicit
Sub RainbowColors()
'Declaring the variables
Dim ColorName As String
Dim ColorIndex As Variant

'Prompt user to enter the color name
ColorName = InputBox("Enter the color name of the rainbow:", "Rainbow Colors")

'Check if the color name entered by user is valid
Select Case LCase(ColorName)
    Case "red"
        ColorIndex = 3 'Red color index is 3
    Case "orange"
        ColorIndex = 45 'Orange color index is 45
    Case "yellow"
        ColorIndex = 6 'Yellow color index is 6
    Case "green"
        ColorIndex = 50 'Green color index is 50
    Case "blue"
        ColorIndex = 23 'Blue color index is 23
    Case "indigo"
        ColorIndex = 55 'Indigo color index is 55
    Case "violet"
        ColorIndex = 13 'Violet color index is 13
    Case Else
        MsgBox "Invalid color name. Please enter a valid color name of the rainbow.", vbCritical, "Rainbow Colors"
        Exit Sub
End Select

'Set the background color of the active cell to the selected color
ActiveCell.Interior.ColorIndex = ColorIndex

End Sub

This has an extra . in the file name


Alignment of icons between live-map and lists/results

As discussed in #1202 I had the idea to align the icon-overlays between live-map and list/results
With "Final defined" it was started to align the cache-symbols/icons between live-map and lists/results.
It would only be consistent if we do not use different means for displaying the same thing.
In detail I would propose for the display of result-list or stored-list:

Instead of having the string "Offline" the cache-icon could get the same disk-symbol on the upper right
Instead of showing the "Green bar" for found the cache-icon could get the yellow smiley on the upper left
Instead of showing the "Orange bar" for Offline-Log the cache-icon could get the orange smiley on the upper left
For caches already stored (or on stored list) also the personal-note and final defined marker could be shown in search result

What do you think ?
I think it would make the usage and understanding of the symbols easier and more consistent throughout the app.
On the other hand (like @Bananeweizen commented in #1202) the overlays make the cache-type icon hard to see and there is more space in the lists to put those markers somewhere else in the cache-row.

Here is an example of how it would look (this is done in code, not drawing program). You can see that all four overlays get a bit crowded.

How will the user understand why personal note and user-defined coords markers don't show up at first since they aren't retrieved when viewing a list, but only when full details are viewed.

Thanks for this experiment.
I agree, that it is a bit to much overlay,how about showing them in front of the GC-code as separate icons ?
Regarding the differences and limitations between results and stored-lists:

I would only show note and final marker in results if the cache is stored in order not to confuse the user
On the stored lists I would never show the stored marker, as the user knows it applies for all of them anyway

I will see what I can do about showing icons in front of the GC code. It will be more difficult than just changing existing icon. Also, it will push the other text out of view (such as cache size). But, maybe not too much.
While I understand that showing stored marker on a stored list is redundant, removing it destroys the uniform appearance that we would be trying to achieve. Also, it would be harder to remove it than to leave it ;)

While I understand that showing stored marker on a stored list is redundant, removing it destroys the uniform appearance > that we would be trying to achieve. Also, it would be harder to remove it than to leave it ;)

Yes, that's a valid argument. For aligned appearance maybe it should also be shown in the stored list. So the user "learns" what it means when it is appearing on the map.

As I already suggested it in the other thread: There is no need for overlays at all in the list view. There is more than enough space to place those small icons either beside or below the main icon. I feeld that you are trying to solve problems which essentially don't exist.
And if the small icons are not shown as overlays, it is also quite easy (and still consistent in look and feel) to leave the stored marker away completely.

@Bananeweizen Where do you suggest putting them? If it is beside the main icon, then cache name will be pushed to the right and maybe cut off.
Are you thinking all icons in a single row?

Another column left next to the cache-icon, vertically, space for 3 icons.

Or right above the Fav-points.

Another column left next to the cache-icon, vertically, space for 3 icons.

Sounds good. If the found-marker is kept as overlay (which is OK for my point of view) three icons are enough.

Or right above the Fav-points.

That's already in use for the "Has TB" icon.

I tired to experiment with this tonight by building a single image with layer drawables just like is done for cache icons.
But, the image I put in the center always wants to scale to full height. I can't figure out why.

@campbeb Where can i have a look at your code ? Are you using insets ?

A simple RelativeLayout or LinearLayout with some ImageViews should work.

@blafoo I was trying to use insets
The code is here https://github.com/campbeb/c-geo-opensource/tree/fix1210a
Its all in cacheListAdapter and caches.xml (Its pretty ugly code at the moment as I was just trying to get the images in place to see how it would look).

Is this something we want for the next release (scheduled for one week away?) or should it wait and we concentrate on other fixes for now?

Regarding the next release:
The overlay-icons are new for the market release anyway, so for me it is just the question if time permits to implement it or better to keep it as a "goody" for the overnext release..
On the other hand the concept and the meaning of those icons could be more understandable if they are used throughout the app.

So, as said in #1528, here is a quick hack to test things.
If I can sum up, we may:

reuse markers of the map
strip the floppy disk when we're in "saved list"
remove the left colored bar

Should we keep the orange circle?
Is this ok for everyone? Am I missing something?

Let it open so we can continue working on the issue.

yep...will take a look on it next days. Time is a little limkted until end of August for me. Nice work however in principle.

@kumy: Small question: How did you bring this orange circled cache into a list (as seen in your screenshot above)?

@Lineflyer orange circles comes when exact coordinates cannot be retrieved (exactly the same as in the map view (it's the same code)). The list you seen, was a search "found by user".

I was just wondering how a search result can contain approximated coordinates ever. Either it contains precise coords (always for PM) or no coords (for BM).

General feedback:
I think this is a good implementation.
I am also happy to see, that you kept the green/orange line in front of found/offline logged caches in addition to the smiley overlay. Removing these, would change the UI too drastic.
With the current implementation I do only see advantages and no drawback.
One remark would be, that the overlays on the lower edges overlap with the text below (i.e. the geocode). But I would rather not scale down the complete icons, we could only make all overlays a little smaller (if this is possible independently from the used overlay icons on the map as these should not get smaller).

Am I the only one where the "pen overlay" is bigger than the other ones (and way more blurred)?

@Bananeweizen how can I reproduce?

Select filter "with own information" -> "with personal note", assuming you have some with personal note. I can upload an image later, when I'm at home.

I'll try to set the same size as other overlays.

Scaled bottom overlay (same sizes as upper ones)

Looks much better on the screenshot. Seems like you nailed it.

Still need to drift the bottom line, so it doesn't overlap in lists.

Bottom items drifted a bit in cache lists only.
Before:

Now:

I'm not able to test on other resolution, hope there will be no issue.

@kumy  If you tell me what resolutions (or even better: what matching devices) would need a test, I can try to do that.
And another side note:
I have just seen, that the floppy icon is shown in the search results, which is very nice!!

@Lineflyer sorry I just seen in the code that we support multiple resolutions. That's all I know.

This looks well done now on all my devices.
Lets close this issue and many thanks to @kumy for implementing this.


remove large gapes between rows

am looking for a way to remove large gapes between rows
any ideas about this???

Hi @nelsonwilliam11,
Could you provide a sample project or at least a code snippet, where the problem you are facing is demonstrated and could be used for debugging?


Completed DCGAN tutorial

I have completed the DCGAN tutorial with detailed explanations, a diagram and learning resources. Please review and approve the pull request.

I somehow can't get github's notebook visualizer to show me this file. It seems to be a single line of code as opposed to the many lines before your edit; do you know if there's a way to reexport the ipynb?

@alextp, I was able to show the notebook through the github notebook visualizer although at times it doesn't seem to work. I have reexported the notebook to better reflect the code diff. Looking forward to your review and feedback.

Thanks @alextp for your review and feedback! I made updates accordingly.

Thank you @margaretmz! I added some edits to the text (it was easier to commit the source of my Jupyter Notebook rather than copy / pasting them in, I hope I didn't clobber anything!)

Thank you @asimshankar for suggesting we use the Sequential model instead of model subclassing for the Generator and Discriminator classes. The current code is using  tf.contrib.eager.defun to boost performance. Can we still use defun with the Sequential model? My understanding is that defun is typically applied in the forward computation, backward computation for the gradients and applications of gradients to variables.

Thanks @random-forests for your edits to make the tutorial more concise! I verified that the edited notebook looks good.

@margaretmz defun and sequential should work well together, so this should be fine.

@asimshankar, thanks for the suggestion on sequential. I added a note about that in the notebook. In this case, I'd prefer to keep subclassing (even though its more verbose), just so we have more examples on tf.org in this style - in case it'll help folks modify this for other projects down the road.

Silly CLA bot.

@margaretmz : Yup, it should work, see https://github.com/tensorflow/tensorflow/commit/96c7397e08a8fde1bdf069b4e7dd74b5a8d79a31 :)
@random-forests : I have a slight preference for using Sequential here since I think we do want to encourage that style, not only because of brevity, but also because it provides a bunch of other benefits in terms of serialization, introspection (e.g., iterating over the layer structure of a network) etc. Till a couple of months ago there were a bunch of pain points with Sequential in eager that have since been addressed. Long story short: I think using Sequential here will be good for users and instructive. But if you still feel strongly, I won't object.

I've made updates for your requested changes, @alextp.
Thanks @alextp and @asimshankar for confirming that Sequential and defun work well together. I agree with @random-forests - what we have right now in the tutorial will let the readers see both styles and there are plenty of examples on Sequential already.

@asimshankar, @alextp and @random-forests - I updated the generator and discriminator models to use Sequential, and updated the text accordingly. I modified the generator model during the conversion and the network now generates resembling digits after only 50 epochs. Please review and provide your feedback. Thanks.

@asimshankar, @alextp and @random-forests, I have made updates per all your review feedback. Looking forward to your approval and PR merge. Thanks.


Change peer API for single squeak

Return the raw data of the squeak/resqueak.
Then the downloader can parse the raw bytes as either a squeak or a resqueak.

https://github.com/squeaknode/squeaknode/pull/2195


How can I get parameters for using ScstRewardCriterion()?

I want to know how to get "gt_res, greedy_res, sample_res, sample_logprobs", thank you in advance

We don't use the ScstRewardCriterion(). But I think "gt_res" denotes the ground truth (sentence or list of sentences); "greedy_res" denotes the greedy search results (sentence or list of sentences); "sample_res" denotes your predicted results (sentence or list of sentences); "sample_logprobs" denotes the probabilities of "sample_res" .


Gradient of norm doesn't account for axis argument

I see that Autograd currently implements the gradient of norm in numpy.linalg, but it doesn't handle any of its options. Support for the "axis" option would be useful.

Seconded; just ran into this.

though FWIW, np.sqrt(np.sum(x*x, axis=1)) does work as a workaround for L2 norm

Try out the commit I just pushed, and please reopen the issue if it's busted.
Gradients of np.linalg.norm should now support the axis argument and I also added support for the ord argument for vector p-norms with p > 1 using a formula on wikipedia. I didn't add support for improper p-norms or matrix norms other than Frobenius norm, though there's a nice writeup of the reverse-mode grad of spectral norm in Giles's pdf. I added some basic tests as well.

Seems to work fine, thanks!

>>> _norm.shape
(14,)
>>> gz.shape
(14, 128)
>>> x.shape
(14, 128)
>>> grad = autograd.numpy.linalg.make_grad_norm(_norm, x, 2, 1)
>>> grad(1).shape
(14, 128)
>>> grad(gz).shape
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "build\bdist.win32\egg\autograd\numpy\linalg.py", line 59, in norm_grad
ValueError: operands could not be broadcast together with shapes (14,128) (14,)
>>>

What i should supply into grad func? gradient from top layers? In this case it raises value error. Or i am doing something wrong?

Can you say a bit more with what you're trying to do with calling make_grad_norm? And if you're having a problem, can you open a new issue instead of commenting on this closed one?
Users wanting to compute a gradient should only need to call np.linalg.norm as usual, not make_grad_norm:
In [1]: from autograd import grad

In [2]: import autograd.numpy as np

In [3]: grad(lambda x: np.linalg.norm(x))(np.ones(3.))
Out[3]: array([ 0.57735027,  0.57735027,  0.57735027])

In [4]: grad(lambda x: np.linalg.norm(np.linalg.norm(x, axis=1), axis=0))(np.ones((3,3)))
Out[4]:
array([[ 0.33333333,  0.33333333,  0.33333333],
       [ 0.33333333,  0.33333333,  0.33333333],
       [ 0.33333333,  0.33333333,  0.33333333]])

The function returned by make_grad_norm takes as its argument the gradient of the final output with respect to the value returned by np.linalg.norm. In particular, if the arguments to np.linalg.norm were as in np.linalg.norm(x, axis=1) where x had shape (14,128), then the argument to the function returned by make_grad_norm should have shape (14,) (and its output will have the same shape as x).

Im making L2 norm layer for Chainer, so i need linalg.norm and its gradient wrt its inputs and top gradient.
I am just doing np.divide after np.linalg.norm and that i seems need to take grad first, so shape whould be (14,) after that. Im now trying to figure out how to take grad of np.divide now.
As for new issue, i was not sure if its my bug or not, so why would i create new issue if im mistaken, to not flood your Issues. Thank you for the help.


[Feat]: Add a fade plugin

Closes: #39.

Hey @davidjerleke, thanks for making this plugin! One thing I would like to see is an option to change how the slide fade happens. I have a use case where I would like to keep the outgoing slide at 100% opacity the incoming slide has reached 100% opacity, this way I can avoid the flash of background when both slides are at that 50% opacity point. I'd be happy to make a PR for this, but do you have any idea how you'd like to see this exposed as a user option? Thanks :)


Error happens when a table has the same ID as a tableextension object

If you create a table and a tableextension object with the same ID, accessing the page over the table that was extended results in the following runtime error:
"Invalid application object code was found. Recompile all objects."
Example code:
tableextension 71234567 Extension extends Customer
{
fields
{
field(71234567;Test;Integer) {}
}
}
table 71234567 DuplicateId
{
fields
{
field(1;Code;Code[10]) {}
field(2;Description;Text[50]) {}
}
}
After deploying this, try accessing Customer List, or Customer Card pages, and you get the error: "Invalid application object code was found. Recompile all objects."
If a tableextension is a separate object type, then this should not be a problem.

This was a bug. The fix will be shipped in May Update.

Thanks Vjeko, I was chasing this message for the last few days.


Update service.md

Suggest removal of an as it makes the sentence awkward.

/close
This is fix is out of a misunderstanding of the sentence.


Feedback related to spacings of different sections

"In this article" section can use less space. It's very hard to read main section by scrolling up and down the page content and code comparison. You could add a feature of resizing different sections.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1899cdf5-3dfd-5f6b-bf3b-8d12bdba4138
Version Independent ID: 7f7f2176-8131-2693-13c2-9ed33c1d6cb8
Content: Migrate confidential client applications to MSAL.NET - Microsoft identity platform
Content Source: articles/active-directory/develop/msal-net-migration-confidential-client.md
Service: active-directory
Sub-service: develop
GitHub Login: @jmprieur
Microsoft Alias: jmprieur

@prathamMantri
Thanks for your feedback! We will investigate and update as appropriate.


WinError 5

I have this error when i try to convert a manga (translate to English):
[WinError 5] access deny: 'C:\...\AppData\local\Temp\KCC-TMP-6tijioj6\OEBPS\Images\Manga Name 61' -> 'C:\...\AppData\local\Temp\KCC-TMP-6tijioj6\OEBPS\Images\Manga-Name-61'
Traceback:
File "kcc\KCC_gui.py", line 429, in run
File "kcc\comic2ebook.py", line 1145, in makeBook
File "kcc\comic2ebook.py", line 734, in sanitizeTree

I convert from images to kindle paperwhite on Windows 8.1 x64
Directory structure:
Manga Name
|__ Chapter 1
|          |_ Image 1
|          |_ Image 2
|          |_ Image ...
|__ Chapter 2
|         |_ Image 1
|          |_ Image 2
|          |_ Image ...
|__ ...
Conversion of single files or chapters seems to work

Something lock directory and prevent name change. Try disable your AV or other software that might use that directory and let me know if that help.

AV deactivated, KCC with UAC admin privileges seems to work,
last version worked with Avira on

Admin privileges are not necessary.
Nothing changed in last few versions that can cause that - it is random problem that should no longer occur. Even with AV so shitty like Avira.
I will try to invent yet-another layer of workarounds.


Allow passing cap to VideoCapture constructor

Currently working on a project where i need functionality of passing explicit CAPs to VideoCapture, figured i contribute a little.

Please try to match parameters names from openCV:
VideoCapture(const String &filename, int apiPreference=[CAP_ANY])
Opens a video file or a capturing device or an IP video stream for video capturing with API Preference.
the parametere is named apiPreference, not cap

I live you check why some CI tack fail.

Tests should pass now on all OSes

the test still failed on macos.

LGTM


Integration with tasker

In future there will be integration with Tasker?
For example, change notification tones

+1,definitely a must have

+1

+1

+1
But in the meantime, does Telegram accept intents to send messages?


Update CHANGELOG

Motivation
Update CHANGELOG for v1.7.6.
Description
Only update CHANGELOG in preparation for release.
Test Plan
n/a
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

bors merge


Error code: 400: context_length_exceeded

Please provide us with the following information:

This issue is for a: (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Send about 5-6 questions in the chat mode that are generating about 8-10 lines in the answers

Any log messages given by the failure

Error code: 400 - {'error': {'message': "This model's maximum context length is 4096 tokens. However, you requested 4201 tokens (3177 in the messages, 1024 in the completion). Please reduce the length of the messages or completion.", 'type': 'invalid_request_error', 'param': 'messages', 'code': 'context_length_exceeded'}}

Expected/desired behavior

Catch this error and reduce the size of the history removing the first question, so the prompt size is under control.
Another approach could be to identify if the last question is related to the previous one (with a call to the LLM model) so if the context has changed send only the last question

OS and Version?

Windows 11

azd version?

azd version 1.5.1

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

We do already have logic that truncates the message size based on token counts, but there must be a bug in it. Is your conversation in the English language?

Hi Pamela,
In my case, the documents and conversations are in Spanish.
Thanks for your support!
Regards,
Angel
El dom, 4 feb 2024 a las 23:10, Pamela Fox @.***>)
escribió:

We do already have logic that truncates the message size based on token
counts, but there must be a bug in it. Is your conversation in the English
language?
—
Reply to this email directly, view it on GitHub
https://github.com/Azure-Samples/azure-search-openai-demo/issues/1199#issuecomment-1925942225,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEEINSIRHFVE7R5KO2HP733YSABO7AVCNFSM6AAAAABCPSBB2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVHE2DEMRSGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Fixing in https://github.com/Azure-Samples/azure-search-openai-demo/pull/1233


Added border config for info and signature window

[x] I have read CONTRIBUTING.md
[x] I have read CODE_OF_CONDUCT.md

Thanks for making a PR!
Initially I intentionally didn't add this customization because it added spaces for a little gain (in my opinion). But recently I changed opinions about aesthetic side of Neovim. So I'll take time thinking if this should be added and maybe repurpose config.window_dimensions into config.window_config to allow further customization (like winblend or any future ones).

Yeah, I thought of using window_config but don't  want to add any breaking changes. ☺

@mainendra, thanks for this PR!
I ended up making breaking change of renaming config.window_dimensions to simply window and adding both config.window.info.border and config.window.signature.border (with you as co-author). Should be no in main.
(Side note: separate thank you for bringing up window borders. 'mini.base16' default highlight group for borders makes them not show border symbols (as per original base16), so I didn't really look into customizing them. No test-driving some options, and I really like them!)


Seeding in 'reset_game'

I have a question regarding the method reset_game in Base_Agent. The first few lines read:
    def reset_game(self):Calling seed
        """Resets the game information so we are ready to play a new episode"""
        self.environment.seed(self.config.seed)
        self.state = self.environment.reset()

I am concerned about the seeding. If I understand correctly, 'reset_game' is called any time an episode is completed.
Assume we implement the seed method in our environment like this:
    def seed(self, seed=None):
        self.np_random, seed = seeding.np_random(seed)
        return [seed]

This is actually the method  used in Bit_Flipping_Environment.
If we were to actually use self.np_random for resetting the environment, we would always see the same initial state over and over again. At least that is the behaviour I appear to be experiencing.
The environments implemented in this repository, e.g. Bit_Flipping_Environment, seems to circumvent this issue by not using self.np_random at all.  Instead, the random module is used. In fact, I don't quite understand why np_random is a member of Bit_Flipping_Environment at all.
Correct me if I'm wrong, but doesn't this make the use of seeds completely pointless (because random is not seeded)?
I would have expected the environment seed method exactly once per run. Calling it once per episode simply doesn't make sense to me.
Please correct me if I misunderstood anything but this doesn't seem right to me.
Best,
Markus

Hi, I’d have to check it but it sounds like I made a mistake and you are correct it shouldn’t be there


t = 0 (t = t + 1, t + 2 ... t + 6 values),

Hello, I am very interested in your article and I have a question to ask you. for time t = 0, only the next one value (t = t + 1 value) was predicted? If I would predict the next 6 data sets at time t = 0 (t = t + 1, t + 2 ... t + 6 values), will your method work best?  I look forward to hearing from you very much.

Thank you for your interest. The model is specifically developed as a multi-step-ahead model, and it would thus be suitable to your application where you are looking for multiple forecasts (t = t + 1, t + 2 ... t + 6). I suggest having a look at our paper (see the link in the readme file), which will provide the details of how the model achieves this.


Creating bars with Flxbars on lua

What feature do you want to get added on the base engine?
Like makeBar(x, y, weight,  height, variable, max value, min value, color, direction)
x = the x position
y = the y position
weight = the weight
height = the height
variable = the variable that the bar will follow to the bar represent
max value = the maximum value
min value = the minimum value
color = the color of the bar
direction = the direction (from this: https://api.haxeflixel.com/flixel/ui/FlxBarFillDirection.html )
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

you can already do this fairly simple in lua.

you can already do this fairly simple in lua.

How? I tried but it didn't work

it would be simple if you knew what you were doing though direction could be a bit tricky.
it would be a lot of code (which I dont want to write out) though would be easy to understand (I think)

youd have to use a image/graphic and then use scaleObject or something else that can change the image/graphic's scale

though this is possible in lua it would be helpful a lot for saving time and for biggening coders so I think ill up this

youd have to use a image/graphic and then use scaleObject or something else that can change the image/graphic's scale

good idea

runHaxeCode

runHaxeCode

oh yea i forgor

runHaxeCode

runHaxeCode can be used with FlxBar's but it doesn't support FlxBarFillDirection, which is kinda inconvenient for some uses

Nothing flipXY can't fix

Nothing flipXY can't fix

i suppose this is true

Barely any instances where it could be used, so i won't add it

Ok ig


Don't automatically clear the board on level transition

After update 1.0.6 was released adding progressive leveling, I have noticed that after transition to a new level after 10 lines the whole board is cleared instead of the game continuing. Could this be changed to keeping the game board as is to reflect actual tetris more accurately?

Closed in b0c7f6c55789b235da77bf78ca1fa301e4e09c12


Implement GCSFileSystem.info() without full bucket ls

Fixes #186. I basically just took the base .info() that @TomAugspurger linked to and tried to ls() the specific path instead of the bucket; it seems pretty likely that I'm missing something here since the s3fs analog seems a fair bit more complicated...? But it seems to work for a simple test case.

I guess the original issue is the self.ls(self._parent(path)) in https://github.com/intake/filesystem_spec/blob/e6b7e1c6b85553f0f4df17f8a8ea8ee049de1f5a/fsspec/spec.py#L509
@martindurant do you recall why that's necessary, rather than just doing self.ls(path, detail=True)?
Not sure what's up with the CI.

Don't worry about the CI, vcrpy is evil and I can sort it out.
Before going ahead with this, we should consider the use cases: where you want the details of one file among many in a bucket (or prefix), this is clearly faster; this is probably what dask workers normally want. When you want the details of all files, this is clearly slower; this is what the dask client normally wants.
At the very least, we should check if the parent directory is in the cache, and if it is, use the info there. That should cover walk and glob cases.
The reason for the current implementation, by the way, is that for some backends (ssh, ftp, maybe others), you cannot "list" a single file at all.

On the other hand, a number of the CI problems seem real: to do with files existing and info on directories...

When you want the details of all files, this is clearly slower; this is what the dask client normally wants.

Isn't that best determined by the caller? If you want the details of all the files aren't you doing self.ls(directory, details=True) I don't see why a File.info would need to concern itself with that.

We are hoping to make access times best for people by making a reasonable choice, but we don't know what access pattern they intend to make. I suppose we should follow what s3fs does, and check for parent dir in the cache and use direct info if not there.

You know better than me, but what use-case is served by FileSystem.info()
doing an ls on the parent directory?
On Wed, Oct 23, 2019 at 8:47 AM Martin Durant<EMAIL_ADDRESS>wrote:

We are hoping to make access times best for people by making a reasonable
choice, but we don't know what access pattern they intend to make. I
suppose we should follow what s3fs does, and check for parent dir in the
cache and use direct info if not there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/gcsfs/pull/187?email_source=notifications&email_token=AAKAOIWF2BXOROXSTAZ4ONDQQBIYDA5CNFSM4JDR5QS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECBPCLQ#issuecomment-545452334,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKAOIR4RLHWNHVKSCVG4MDQQBIYDANCNFSM4JDR5QSQ
.

The one where you intend to access many/most files in the same directory, but didn't have the foresight to do the ls() beforehand. That would happen when opening all of the files in a parquet dataset, for instance, if the paths were taken from metadata rather than by walking the directory tree (I am not talking about a Dask workflow here).

Nevertheless, for this PR, the code should check whether the info is already in the cache, and not call remote at all if so. A number of tests seem to be genuinely failing on exactly a loss of sync between expected and actual, i.e., any of the ones that don't have vcr stuff in the traceback.

^ ignore that for now, the vcr tests are tripping me up so I need to dig a little more to see what the expected return for .info() is for files vs buckets; I think I should be able to sort it out but for vcrpy I'll definitely need some assistance :)

Short version: real http calls can change, so vcr often doesn't find the match when you come back to run a test. You will need to delete the offending YAML file out of tests/recordings, and rerun the test with a set of GCSFS_* environment parameters as listed in the settings.py file https://gcsfs.readthedocs.io/en/latest/developer.html#testing-and-vcr
(then rerun pytest again without those variables to ensure it worked).

all right, I think I have a better handle on what's going on now:
# info on file; does not hit cache
fs.info('gs://gcsfs_test/blah.txt')
{'kind': 'storage#object',
 'id': 'gcsfs_test/blah.txt/1571708493657835',
  ...
 'type': 'file'}

# info on file after ls'ing; does hit cache
fs.ls('gs://gcsfs_test/', detail=True)
fs.info('gs://gcsfs_test/blah.txt')
{'kind': 'storage#object',
 'id': 'gcsfs_test/blah.txt/1571708493657835',
  ...
 'type': 'file'}

# info on directory; does not hit cache no matter what, is that ok?
fs.info('gs://gcsfs_test/')
{'name': 'gcsfs_test/', 'size': 0, 'type': 'directory'}

i'll take a look at the vcr stuff in a bit, but if you can confirm that the above seems right that'd be helpful

info on directory; does not hit cache no matter what

There are two cases here: if it's a bucket, we can only know if it exists (and is an implied directory) by trying to list it, so it's OK. If it's any deeper prefix, then it should show up in a parent directory listing if it exists OR if it itself has been listed, then we also know it exists and is a directory. In the latter of those cases, though, we still need to check if there happens to be a key with the same name as the directory, which is allowed on GCS.

I think that makes sense at a high level, I'm out for a few days though so if either of you is interested in taking a stab feel free to push whatever to my branch :)

@martindurant @TomAugspurger I think I got the cache behavior matching what's in master; a couple of tests still fail locally but I think they might just be flaky ones? let me know if it looks generally ok

Can you post which tests are failing - they pass when run against real google?

The ones failing with real google on both master and my branch are test_pickle and test_map_pickle; it looks like there's also a real issue with test_rm_recursive due to slightly incorrect handling of the ['/a', '/a/b'] case:

If it's any deeper prefix, then it should show up in a parent directory listing if it exists OR if it itself has been listed, then we also know it exists and is a directory. In the latter of those cases, though, we still need to check if there happens to be a key with the same name as the directory, which is allowed on GCS.

If we have listed gs://bucket/a/ and therefore know it's a directory from the cache, but haven't listed gs://bucket and don't know if a exists, is it ok to go look that path up remotely? Doesn't that kind of defeat the purpose of checking the cache for bucket/a/?

 I'll have to think about that one.

Regardless of what the ideal state is, I think this currently matches the cache hit behavior on master; the only test that's still giving me trouble is test_get_put_recursive, where I guess something something subtle must have changed with the logic of checking if a directory exists inside a directory; even the old test seems to accidentally put some stuff at '/temp_dir/temp_dir' instead of /temp_dir/ but for whatever reason the test still passes whereas mine doesn't... :/

Hmm, locally your branch is passing aside from a few tests that look like stale caches. Let me try merging master.

I notice that gcsfs/tests/test_core.py::test_get_put_recursive[gcs://] pass when run by itself.
There's a leftover temp_dir that's lingering between tests.

OK, this is passing for me locally when I rewrite the tests... The diff is a bit messy now, but it's basically just @bnaul's changes + a couple of test setup changes
diff --git a/gcsfs/core.py b/gcsfs/core.py
index 3f02565..c65ff78 100644
--- a/gcsfs/core.py
+++ b/gcsfs/core.py
@@ -682,6 +682,29 @@ class GCSFileSystem(fsspec.AbstractFileSystem):
         self._call('delete', 'b/' + bucket)
         self.invalidate_cache(bucket)

+    def info(self, path, **kwargs):
+        """File information about this path."""
+        path = self._strip_protocol(path)
+        # Check directory cache for parent dir
+        parent_path = norm_path(self._parent(path)).rstrip("/")
+        parent_cache = self._maybe_get_cached_listing(parent_path + "/")
+        if parent_cache:
+            for o in parent_cache['items']:
+                if o['name'].rstrip("/") == path:
+                    return o
+        # Check exact file path
+        out = [o for o in self.ls(path, detail=True, **kwargs)
+               if o['name'].rstrip("/") == path]
+        if out:
+            return out[0]
+        # Check parent path
+        out = [o for o in self.ls(parent_path, detail=True, **kwargs)
+               if o['name'].rstrip("/") == path]
+        if out:
+            return out[0]
+        else:
+            raise FileNotFoundError(path)
+
     @_tracemethod
     def ls(self, path, detail=False):
         """List objects under the given '/{bucket}/{prefix} path."""
diff --git a/gcsfs/tests/utils.py b/gcsfs/tests/utils.py
index 3bf4027..ae885e2 100644
--- a/gcsfs/tests/utils.py
+++ b/gcsfs/tests/utils.py
@@ -10,6 +10,7 @@ import sys
 import tempfile
 import vcr

+import gcsfs.utils
 from gcsfs.core import GCSFileSystem
 from gcsfs.tests.settings import (TEST_BUCKET, TEST_PROJECT, RECORD_MODE,
                                   GOOGLE_TOKEN, FAKE_GOOGLE_TOKEN, DEBUG)
@@ -194,18 +195,23 @@ def gcs_maker(populate=False):
         try:
             gcs.mkdir(TEST_BUCKET, default_acl="authenticatedread",
                       acl="publicReadWrite")
-        except:
+        except gcsfs.utils.HttpError:
             pass
+
+        # ensure we're empty.
+        gcs.rm(TEST_BUCKET, recursive=True)
+
         for k in [a, b, c, d]:
             try:
                 gcs.rm(k)
-            except:
+            except FileNotFoundError:
                 pass
         if populate:
             for flist in [files, csv_files, text_files]:
                 for fname, data in flist.items():
                     with gcs.open(TEST_BUCKET+'/'+fname, 'wb') as f:
                         f.write(data)
+        gcs.invalidate_cache()
         yield gcs
     finally:
         for f in gcs.find(TEST_BUCKET):

I apparently am not able to re-record successfully. I did the first one, but the GCSFS_RECORD_MODE=once failed. Presumably, since the recursive rm in the gcs_maker depends on the content of the bucket...
Looking into if we vcr can ignore certain requests (in the setup & teardown).

Looking into if we vcr can ignore certain requests

I'm pretty sure no - but you can catch the exceptions.

It's kinda ugly: https://vcrpy.readthedocs.io/en/latest/advanced.html#ignore-requests
I'm trying another approach. Hopefully it's more robust.

I actually may have misunderstood the error earlier. It's saying something about
E               vcr.errors.CannotOverwriteExistingCassetteException: Can't overwrite existing cassette ('/Users/taugspurger/sandbox/gcsfs/gcsfs/tests/recordings/test_simple.yaml') in your current record mode ('once').
E               No match for the request (<Request (POST) https://oauth2.googleapis.com/token>) was found.
E               No similar requests, that have not been played, found.

which may be because I used a service account token. I'll try with an oauth2 token...

You may need to delete the previous run's recording (in on of the tests/recordings/test_*.yaml) each time you try to rerecord

Pushed a (hopefully passing) re-recording. On a call with @martindurant, we discovered that some values may not have been appropriately text-replaced when saved to the recording database. 4b5588556ab9b463f0abce39596e8203c8564531 should fix that.

All green! Thanks for the patience, and for working on this @bnaul.