Code cleanup

This time I updated the examples.

r? @ned14
(maidsafe_highfive has picked a reviewer for you, use r? to override)

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from the review on Reviewable.io

Nice work ! good to see those loops fixed and more unwraps gone.

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from the review on Reviewable.io


Question: Can set the execution mode of some classes is synchronous and other is asynchronous?

OrientDB Version: Enterprise 2.2.26
Java Version: 1.8
OS: CentOs
Expected behavior

I have two servers,one is master, another is replica, I set the execution mode to asynchronous, so
the insert/update is very fast.
Now I have an scenario, if I insert one record(op1), and then update the record(op2). Now the question
is if op1 does not sync to replica, looks like master will lock the record so that op2 have to wait until op1 sync to replica.

As above, I think if I can set some classes is asynchronous and other is synchronous, then it will be more fine.
Actual behavior

Steps to reproduce

Yes, you can specify this in the distributed-config.json configuration per cluster. So if a class X has 4 clusters X1, X2, X3 and X4, you have to put this in all the X* cluster configuration.


Add "How to Structure a React Project?" post

This is for React Indie Bundle.
CC @StephenGrider

Great post! Thanks :+1:


Pagination widget showNext and showLast disable problem (v1)

This is issue
Pagination widget showNext and showLast disable problem #1938
https://github.com/algolia/instantsearch.js/issues/1938
But geared for version 1. Requesting to backport bug fix found on v2 and v3.
Do you want to request a feature or report a bug?
bug
Bug: What is the current behavior?
In Pagination widget showNext and showLast are not disabled when number of hits is 0
Bug: What is the expected behavior?
To be disabled.
Bug: What browsers are impacted? Which versions?
Feature: What is your use case for such a feature?
Feature: What is your proposed API entry? The new option to add? What is the behavior?
Calculation for total pages:
https://github.com/algolia/instantsearch.js/blob/v2.2.5/packages/react-instantsearch/src/components/Pagination.js#L110
totalPages = 0 because number of hits is 0 ->
https://github.com/algolia/instantsearch.js/blob/v2.2.5/packages/react-instantsearch/src/connectors/connectPagination.js#L48
https://github.com/algolia/instantsearch.js/blob/v2.2.5/packages/react-instantsearch/src/components/Pagination.js#L110https://github.com/algolia/instantsearch.js/blob/v2.2.5/packages/react-instantsearch/src/components/Pagination.js#L111
lastPage = 0
https://github.com/algolia/instantsearch.js/blob/v2.2.5/packages/react-instantsearch/src/connectors/connectPagination.js#L11
in searchState there is no key = page ->
https://github.com/algolia/instantsearch.js/blob/v2.2.5/packages/react-instantsearch/src/connectors/connectPagination.js#L49
currentRefinement = 1
https://github.com/algolia/instantsearch.js/blob/v2.2.5/packages/react-instantsearch/src/components/Pagination.js#L153
https://github.com/algolia/instantsearch.js/blob/v2.2.5/packages/react-instantsearch/src/components/Pagination.js#L163
disabled = false
Possible solution:
disabled: currentRefinement === lastPage || lastPage <= 1
What is the version you are using? Always use the latest one before opening a bug issue.
v1.11.2

@vvo per your request.

Could be reproduced in instantsearch.js v2: https://jsfiddle.net/bobylito/cq17ut1r/
As a side note, that's a bit of an outlier as the default behavior is to hide automatically the pagination when there are no results.


⚠ Bofrost.de has degraded performance

In 34ba936, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1057 ms

Resolved: Bofrost.de performance has improved in 17abc49 after 6 minutes.


node-packages: update & cleanup

update packages for v4
remove files and generation for v0_10 and v5 packages as nodejs-5_x and nodejs-0_10 are no longer supported

(also discussed in #19966)

Nitpick: in pkgs/development/node-packages/node-env.nix you seem to be just adding spaces to empty lines.

We were discussing switching the nodejs default version from v4 to v6 - maybe you want to add this to this PR? Then i can close #19966

@gilligan [x] done
@vcunat this file is generated and I didn't want to touch it manually

@cko This PR updated nodejs to export nodejs-6 but nodePackages is still set to nodePackages_4_x;!


Initial Threat Model

This task is to add an initial threat model to RMM covering threats specific to Realm world.

The patch is in review here : https://review.trustedfirmware.org/c/TF-RMM/tf-rmm/+/20477

The threat model has been merged and can be found here : https://tf-rmm.readthedocs.io/en/latest/security/threat_model/index.html


Rename Deriver -> DataEncoder and all sub-types

Not going to do since we are searching for a different name for the DataEncoder.


Tree shaking

This changes API for runtime-checking casts to allow for tree-shaking it.
size comparison for editor example

old
new

no minify
75.9kiB
148kiB

minify
66.4kiB
1.51kiB

In this PR I also updated generated definitions in out directory and added package-lock.json generated by npm 5.
I also updated examples to match newly generated bindings.

Sorry for the slow response. Thanks.

Awesome! Thnak you for merging it :-)


Identifiers validation failed for dataset Inventario de especies de vertebrados para apoyar la creación del Ordenamiento Ecológico y la Reserva de la Biósfera Janos, Chihuahua

Identifier validation failed for the dataset Inventario de especies de vertebrados para apoyar la creación del Ordenamiento Ecológico y la Reserva de la Biósfera Janos, Chihuahua:

Crawler attempt: 322
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 725
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 725 total records; 725 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3740315/step

New IDs sample:

Old IDs sample:

006261f09b219c32e5e49e24ac2cc0f9
011741bb5eb895817e893694146be8f0
02ee037a3b65821d03e78e9d26ae7d18
050f4f11b431b13708e561b2ecb30260
05cdaeb6a9f07bb72284cf62dd9ccae3
0691b568af54de34c2140c5dd3e1db19
08ca8f733ed73de3e2269045f663fb6c
0b092c02025483f04dff3f35b951aa13
0b899b1bc6384ef91564956b7e63f0e7
0c352bbba98d75c4372a38afcfef0b2d

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Inventario de especies de vertebrados para apoyar la creación del Ordenamiento Ecológico y la Reserva de la Biósfera Janos, Chihuahua : https://doi.org/10.15468/zwhbuw.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Inventario de especies de vertebrados para apoyar la creación del Ordenamiento Ecológico y la Reserva de la Biósfera Janos, Chihuahua:

Crawler attempt: 323
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 725
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 725 total records; 725 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3741161/step

New IDs sample:

Old IDs sample:

006261f09b219c32e5e49e24ac2cc0f9
011741bb5eb895817e893694146be8f0
02ee037a3b65821d03e78e9d26ae7d18
050f4f11b431b13708e561b2ecb30260
05cdaeb6a9f07bb72284cf62dd9ccae3
0691b568af54de34c2140c5dd3e1db19
08ca8f733ed73de3e2269045f663fb6c
0b092c02025483f04dff3f35b951aa13
0b899b1bc6384ef91564956b7e63f0e7
0c352bbba98d75c4372a38afcfef0b2d

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Inventario de especies de vertebrados para apoyar la creación del Ordenamiento Ecológico y la Reserva de la Biósfera Janos, Chihuahua : https://doi.org/10.15468/zwhbuw.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Inventario de especies de vertebrados para apoyar la creación del Ordenamiento Ecológico y la Reserva de la Biósfera Janos, Chihuahua:

Crawler attempt: 325
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 725
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 725 total records; 725 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3741783/step

New IDs sample:

Old IDs sample:

006261f09b219c32e5e49e24ac2cc0f9
011741bb5eb895817e893694146be8f0
02ee037a3b65821d03e78e9d26ae7d18
050f4f11b431b13708e561b2ecb30260
05cdaeb6a9f07bb72284cf62dd9ccae3
0691b568af54de34c2140c5dd3e1db19
08ca8f733ed73de3e2269045f663fb6c
0b092c02025483f04dff3f35b951aa13
0b899b1bc6384ef91564956b7e63f0e7
0c352bbba98d75c4372a38afcfef0b2d

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Inventario de especies de vertebrados para apoyar la creación del Ordenamiento Ecológico y la Reserva de la Biósfera Janos, Chihuahua : https://doi.org/10.15468/zwhbuw.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.


Safebrowsing removal in windows

Why does windows build require more in depth removal of safebrowsing compared to other platforms?
Would insertion of  windows-fix-building-without-safebrowsing.patch to other platform builds results in better safebrowsing removal since big part of code removed is not windows specific?

Why does windows build require more in depth removal of safebrowsing compared to other platforms?

A while ago, I had problems trying to update the Windows version without removing Safe Browsing entirely. I think this pattern has since carried forward.

Would insertion of windows-fix-building-without-safebrowsing.patch to other platform builds results in better safebrowsing removal since big part of code removed is not windows specific?

I've wondered about this for a while. It'd be beneficial for macOS, and could solve some bugs in Linux builds relating to the partially removed Safe Browsing code.
@Zoraver Since you've updated ungoogled-chromium in recent versions, what are your thoughts on combining changes from this Windows patch back into ungoogled-chromium?

I will give it a try applying it on macos build. So far I realised everything in fix-disabling-safebrowsing.patch in macos repo is done in windows-fix-building-without-safebrowsing.patch as well, and there's probably something similar in linux repos.

Successfully built and working on macOS with some minor changes. Merging windows-fix-building-without-safebrowsing.patch into fix-building-without-safebrowsing.patch results in 6k lines long patch, which is painful to work with. Maybe finding some meaningful logic to split it in more smaller patches?
@Eloston can this issue be moved to core repo?

@Eloston I don't think that merging windows-fix-building-without-safebrowsing.patch back into ungoogled-chromium is a good idea. Although the macOS-specific fix-disabling-safebrowsing.patch does contain a subset of the changes, it is less than one tenth the size and not much of a hassle to maintain. As far as I know, no similar patch is required to build on Linux.
From my perspective, merging it back to ungoogled-chromium will just increase the (already nontrivial) amount of work required to port ungoogled-chromium to a new major version of Chromium with little to no payoff for people who don't use Windows. This will likely result in longer delays between the release of a new major version of Chromium and ungoogled-chromium being available for it.

Maybe it can be left as optinal, so each version bump can be done without it and it would be left to the bravest among us to work on.
That patch is mostly removal of large chunks of code or removal of safebrowsing headers. Large chunks removal can be modified by using flags, it would make patch smaller and would bring less headache when the new version is released. As for headers removal, maybe it could be automated to remove certain headers in certain files?
The main reason why I opened this issue is to question what's the difference under the hood comparing windows and other platforms UC. Is it the same product since one has 5k more lines to remove?

@Eloston can this issue be moved to core repo?

The core repo currently lives under my personal account, whereas this repo lives under the ungoogled-software organization. GitHub won't allow me to move issues across users/organizations. As a workaround, we could cross-link this issue to a new one, but I don't think that's immediately necessary.

As far as I know, no similar patch is required to build on Linux.

The reason I suggested the idea is we will sometimes have obscure crashing bugs (e.g. migrating Chrome profiles to ungoogled-chromium) because we don't completely patch out the components we do not want. Technically it is safer to completely remove components we do not want, because it forces us to properly fix all code paths during compile time.
However, I agree with your point that our current development workflow would make updates prohibitively slow. Considering the majority of use-cases (most don't migrate profiles from Chrome) and platforms we support (Linux is probably the most popular in our user base), it is probably not a good idea to merge this Safe Browsing patch into the main repo right now. I'll expand on this point a bit more below.

As for headers removal, maybe it could be automated to remove certain headers in certain files?

This is a part of my idea in https://github.com/Eloston/ungoogled-chromium/issues/1087. In theory, that new tool would make it feasible to maintain a huge Safe Browsing patch. However, we'd need to do quite a bit of research first to test the feasibility of the tool. For example, I'm interested to see how practical it is to use AST representations of the C++ code to automate common patch-breaking code changes.
In summary, I don't think there's much we can do about this issue until we develop that better tool. Of course, I'm also open to other suggestions.


Update test schema to include Text DataType

Add a testText property to the classes in the schema files in the test/schema folder;
{
    "name": "testText",
    "@dataType": [
        "text"
    ],
    "description": "Value of testText."
},

This can be closed after the merge_batching_and_netwpork_queries is merged with develop


Add new Interval Timer App

Hello, I would like to add my new Interval Timer app to the app loader. I have tested the app on my Bangle.js 2. It may work on the Bangle.js 1 as well as I have used the layout library for all of the views, but I do not have one to test with.

Looks great, thanks! I'm a bit busy to test it now but hopefully someone will be able to see if this works on Bangle 1. I guess it might work in the emulator?


RareCheese - C83224, low stock

JLCPCB has a low stock on the C83224 (M3406-ADJ). Is the C22462728 (MT3406) a suitable replacement?

Yes of course, and you can also use TI's TLV62569DBVR (C141836) instead, they are pin-to-pin compatible.


CASMINST-5874: Update Goss tests for CRUS removal

Summary and Scope

Fixes: CASMINST-5874
Relates to: CASMCMS-8396
csm PR

Issue Type

RFE Pull Request

Update Goss tests to version modified to handle removed CRUS service.
See source PR for details.
Risks and Mitigations
Without this change, one Goss test will fail after CRUS is removed.

Replacing this with combo PR: https://github.com/Cray-HPE/csm-rpms/pull/728


server.py is very sensible to path's format

Hi,
Server.py crashed when I tried to do python ./server.py --full-rescan /home/polochon/Musique/MPD because I omitted the trailing slash; /home/polochon/Musique/MPD/ worked, though.
Just thought it would be cool to report - the database is being built as I speak :p
Thanks!

Should be fixed by https://github.com/Phyks/Blissify/commit/adabeffa7f4501676e8a3cc05a96ab1814993ab7.


Page header adjustments

Summary

Relevant Technical Choices

To-do

User-facing changes

Adds 4px border-radius to Page
Adds more room for the title input and uses ellipses when it's longer than the input

Testing Instructions

Verify that the Page has 4px rounded corners, also with bg color and bg media.
Verify that if the title is longer than the input, ellipses is displayed when not focused on the inout.

Fixes #5694

Adds more room for the title input and uses ellipses when it's longer than the input

Yesss!!!!!

Adds more room for the title input and uses ellipses when it's longer than the input

Yesss!!!!!


change pointerstyle when result is clickable

ref: https://gitter.im/JuliaLang/julia?at=57ebd746783fe9b945a40c35

I've sort-of been using bold to indicate clickability, which may be ok if we're consistent about it.
I'm not a big fan of the hand thing, which is very ugly and web-y.


Using Docker: PHP Fatal error (memory)

Hello,
I installed Cachet yesterday using Docker and everything was working perfectly, until some hours ago.
I'm getting in the /var/log/nginx/errors.log file (from Docker) errors like this:
2015/10/07 15:04:09 [error] 78#0: *15 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 82 bytes) in /var/www/html/bootstrap/cache/compiled.php on line 9645" while reading response header from upstream, client: XX.XX.XX.XX, server: localhost, request: "GET / HTTP/1.1", upstream: "fastcgi://<IP_ADDRESS>:9000", host: "XX.XX.XX.XX:XX"

I can edit the PHP config, but this shouldn't be happening, right?
Thanks

Ping @cachethq/docker

Seems like the app is running out of memory, not really a Docker issue per se.
It would be possible to increase the php memory_limit, however that may just delay the issue from occurring again if there is a memory leak.

@ThePooN how much free RAM on your docker host?
Looks like nginx ran out of memory

https://img.cartooncraft.fr/UjRD/89a1ca
Is that enough?

i doubt 32Mb is enough

actually, it is 32Gb

you're right

This is a limit in the php config, there is plenty of RAM on the system itself.
I guess we could add an ENV variable to specify a different php.ini memory_limit
I have not run into this issue myself, been running Cachet in Docker for months now

i'm not either PHP dev or Cachet expert, but looks like we've got memory leak :)

http://stackoverflow.com/questions/561066/fatal-error-allowed-memory-size-of-134217728-bytes-exhausted-codeigniter-xml

People, changing the memory_limit by ini_set('memory_limit', '-1'); is NOT a solution at all.
Please don't do that. Obviously php has a memory leak somewhere and you are telling the server to just use all the memory that it wants. The problem has not been fixed at all. If you monitor your server, you will see that it is now probably using up most of the RAM and even swapping to disk.
You should probably try to track down the exact bug in your code and fix it.

i can upload you my mysql database if you want.

Why would Cachet be leaking memory? We don't have any long running processes, perhaps the queue but that's Laravel?

I can try to set the limit to -1 and see how many memory it uses.

Please direct all docker issues to https://github.com/cachethq/Docker/issues.

I'm gotta reinstall and see what happens - still with docker - with a different database. Will open a new issue in the Docker repo if this happens again. Thanks for your support.

it is memory issue, not docker
try to start the same cachet instance on host itself, and see what happens

already too late. i wasn't satisfied of my actual db setup anyway.


[DCA] Better handling of the envvar & doc

What does this PR do?
nests the dd_cluster_agent_enabled to have:
cluster_agent:
  enabled: true
  auth_token: foobar

Motivation
Easier deployment.

@DataDog/container-integrations - I spotted that the go routine c.apiClient.StartMetadataMapping() was called in the detect method of the kubernetes collector of the tagger, therefore in the node agent. This method should only be used by the Cluster Agent.
This is unnecessary as we do a processKubeServices  when calling addToCacheMetadataMapping (in the Pull and the Fetch) which uses the list of pod collected from the kubelet, thus local, and lists the Endpoints from the API server.
I am leaving the kubernetes_apiserver_poll_freq as it is meant to be used by the Cluster Agent. It will have no effect on the Node Agent. On the other hand, the kubernetes_metadata_tag_update_freq will not change, it is the frequency at which the Node Agent fetches cluster level metadata (from the APIserver or the Cluster Agent).
The benefits:

Backward compatible, and we fix a bug
Can separate the 2 different processes (pulling from the DCA, pulling from the APIServer).

The drawback:

Confusing

Thoughts ?


SizeLimitHandlerTest is flaky

seen here https://github.com/GoogleCloudPlatform/appengine-java-standard/actions/runs/11845075033/job/33013808086?pr=304
[stderr] INFO: Stopped timer for request<PHONE_NUMBER>000001 0.121 CPU / 0.122 wallclock (99.2%), 203.963<EMAIL_ADDRESS>hotspot, 0.000 GC]
Error:  Failures:
Error:    SizeLimitHandlerTest.testResponseContentAboveMaxLengthGzip:205
Error:    SizeLimitHandlerTest.testResponseContentAboveMaxLength:146
Expected: <500>
     but: was <200>
Error:    SizeLimitHandlerTest.testResponseContentAboveMaxLength:144
Error:  Errors:
Error:    SizeLimitHandlerTest.testResponseContentAboveMaxLengthGzip:199 » Timeout

We have similar files runtime/test/src/test/java/com/google/apphosting/runtime/jetty9/SizeLimitHandlerTest.java
and runtime/test/src/test/java/com/google/apphosting/runtime/jetty9/SizeLimitIgnoreTest.java
and only the first one seems flaky. Can you study the diffs there? @lachlan-roberts

it seems SizeLimitIgnoreTest has just been copied from SizeLimitHandlerTest with 2 extra tests. I opened #313 to reduce the duplication.


Add IsReady() methods to ensure assets loaded successfully

I found I kept on re-checking what data within the structs to check in order to make sure assets were loaded successfully. Is it .data != NULL? .buffer? Having consistent helper methods will make it easier to check if the assets are ready for use. These match the IsWindowReady() pattern...
IsAudioStreamReady()
IsShaderReady()
IsImageReady()
IsFontReady()
IsWaveReady()
IsSoundReady()
IsMusicReady()

These arn't really needed, but they do clean up the code, and make it easier to read.

I tend to come into this pattern a lot. I think these functions are useful.

@RobLoach This is a nice addition! Actually, I think we can take advantage of those functions to do a more careful validation of the loaded/not-loaded assets. For example, not only checking image.data but also image.width > 0, valid image.format, etc.


Feature/naming conventions

Description
Changed file and top level component names to match parent component. Closes #29
Type of change

[x] New feature (non-breaking change which adds functionality)

Testing

[x] Tests do not apply

this looks just like a refactor but ... i tested and i seem to run into some issues
Go in the wizzard add folder name and structure and press study and then fill in form and i get
Error occurred while trying to proxy request /folders from localhost:3000 to http://localhost:5430 (ECONNREFUSED) (https://nodejs.org/api/errors.html#errors_common_system_errors)

Am I doing something wrong ?

Hmm, I'm not able to reproduce. I've tried:

Restart backend
Delete local branch and pull from git

I'll keep trying to reproduce.

figured it out I was using a branch that had auth enabled. if i disable auth checks it works


C sshnpd - stability enhancements and testing

My main focus for this sprint is putting tests in place for C sshnpd.
Getting it from MVP to beta status.
This will involve:

Ensuring child processes are handled correctly (srv, ssh-keygen)
Adding C sshnpd to end2end tests
ephemeral ssh keys are properly cleaned up
implementing npt_request for sshnpd

Will open a new npt_request ticket, the rest has either been completed, or no longer needed because we removed the ephemeral tunnel


update model_fixes.js to set CardAction.channelData as an optional property

First fix for #639
Description
Add "channelData" as an optional property for the CardAction interface.
Note: This doesn't fix #639 directly as the library needs to be regenerated. This PR sets it up so that then the library is properly regenerated (via the generateClient scripts), #639 will be fixed.

Pinging @sgellock as FYI

Pull Request Test Coverage Report for Build 2239

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.06%) to 82.098%

Files with Coverage Reduction
New Missed Lines
%

libraries/botframework-config/src/botConfigurationBase.ts
2
85.59%

Totals

Change from base Build 2217:
-0.06%

Covered Lines:
2633

Relevant Lines:
3088

💛  - Coveralls


WIP MAID-2109 feat/logger: winston logger integration

winston logger integrated. winston instance is passed to the plugins in the register function

I'm closing this as this seems to be for our beaker browser. If the same enhancement is needed for Peruse, let's adapt the code for it and send a new PR.


ISPN-6470 Ignored CapacityFactorsFunctionalTest

https://issues.jboss.org/browse/ISPN-6470

Integrated. Thanks!


autofill.js > inferInputType freezing page with heavy html content

Description

I have a localhost page that generates a 12.5k lines html content, with a bunch of inputs. When the Chrome extension is enabled (doesn't matter if ignoring the localhost domain or not), the pages freezes for around 12s before allowing me to click around.
By turning on the console's Performance Insights, I was able to pinpoint the cause to the Duckduckgo extension:

Steps to Reproduce

Install the Duckduckgo Privacy Essentials extension on Chrome
Load a html page with a lot of lines and inputs
You won't be able to click around for a good while

Expected behavior:

Be able to use the page right away despite having the extension enabled.
Actual behavior:

The page freezes for a long time.
Versions

Extension: 2023.3.3
Browser: Chrome
OS: Windows

Additional Information

Happens every time and took me a week to identify it wasn't on my app. After I did a bunch of performance improvements, noticed it wasn't on my side. Oops.

We've now released this changes, so the performance issues with autofill should largely be solved. Please re-open if you continue to see performance issues.


Make sure node-version is always specified in the GitHub CI file

At the moment, when you generate a v2 addon using the --pnpm flag, no node-version is specified in the CI file. wyvox/action-setup-pnpm uses actions/setup-node internally.
The actions/setup-node docs mention the following:

The node-version input is optional. If not supplied, the node version from PATH will be used. However, it is recommended to always specify Node.js version and don't rely on the system one.

So seems best to specify a version?
This way, a node-version is always specified in the CI file, regardless of the chosen package manager.
Results:
npm:
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: 16
          cache: npm
      - name: Install Dependencies
        run: npm ci
      - name: Run Tests
        run: npm run test

yarn:
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: 16
          cache: yarn
      - name: Install Dependencies
        run: yarn install --frozen-lockfile
      - name: Run Tests
        run: yarn test

pnpm:
    steps:
      - uses: actions/checkout@v3
      - uses: wyvox/action-setup-pnpm@v2
        with:
          node-version: 16
      - name: Run Tests
        run: pnpm test

So seems best to specify a version?

I've been on the fence about this.
With v2 addons specifically, node version doesn't matter, so wyvox uses whatever volta is configured for -- which is what you'd use for local development.
Given how volta is optional, I'd also be a fan of a volta flag that undid adding the node-version in ci.

With v2 addons specifically, node version doesn't matter

True, but you still want CI to be as predictable as possible I think, so specifying a Node version seems better / clearer to me than relying on a fallback.

Given how volta is optional, I'd also be a fan of a volta flag that undid adding the node-version in ci.

Makes sense indeed!


check-meta: Improve performance

See c3c31aa798551a2808981d14537d04de8f51dff8
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Couldn't (and shouldn't) the inherit thing` be done as an optimization in the interpreter? That way all Nix files would benefit from it.

Couldn't (and shouldn't) the inherit thing` be done as an optimization in the interpreter? That way all Nix files would benefit from it.

Yes but I'm not that familiar with the nix codebase.
There was some discussion in https://github.com/NixOS/nixpkgs/pull/266886

Round 1

Couldn't (and shouldn't) the inherit thing` be done as an optimization in the interpreter? That way all Nix files would benefit from it.

@roberth @Ericson2314 Could you bring that up into the nix repo? I do not think I can adequately describe it for an issue.

It's unclear how easily and broadly such a transformation can be applied. We don't want to accidentally make currently light weight closures heavier in places where we humans would not apply the rule. Here's an issue for it:

https://github.com/NixOS/nix/issues/9592


local files problem

While this plugin would be great, it's for many just not useable, because we can't access local files.
cdvfile://

url: cdvfile://localhost/library-nosync/images/img.jpg
error without csp: url not supported
error with csp: Refused to load cdvfile://localhost/library-nosync/images/img.jpg because it does not appear in the img-src directive of the Content Security Policy.

file:// (works in sim, but not on device)

url: file:///var/mobile/Containers/Data/Application/UUID/Library/NoCloud/images/img.jpg
error with and without csp: requested URL not found on this server

relative path (bundled inside www)

url img/placeholder.png
error: none but what if resources are downloaded/created after installation?

relative path (not bundled inside www)
Since the Filesystem is:
/var/mobile/Applications/<UUID>/
- appname.app/
-- www/
- Library
-- NoCloud

The relative path to NoCloud should be ../../Library/NoCloud/images/img.jpg.

url: ../../Library/NoCloud/images/img.jpg
error: same as file:// requested URL not found on this server

Related Issues
Issue #74
Issue #73
Issue #63
Issue #33
Issue #9
Issue #77 with PR #76 (fixes file:// under appname.app so won't help)
Issue in cordova-plugin-file is marked as wontfix.
more
stackoverflow:

angularjs-on-wkwebview-any-solution-for-handling-file-on-ios-9
wkwebview-not-loading-local-files-under-ios-8
wkwebview-does-load-resources-from-local-document-folder
-state-of-wkwebview-on-cordova-ios-9

github:

xwebview
GCDWebServer
apache non core plugin wkwebview-engine-localhost -> they also limit access to inside www and they use GCDWebServer

webkit:

154916

### even more
It's also hard to google the problem, since there where a time where no file:// urls worked at all.  After they fixed it, there remained the problem to access file:// via xhr/ajax. Now the problem is we can't access the documents and library directories and we are in appname.app, read more about the file system
But you can define a directory where relative url's are allowed apple docs loadfileurl

Accessing local files is very important! Hoping for a fix soon.

Some good news, although it's more a workaround for IOS and may not works for any use cases. But I made a plugin to sync files and ensure you can access them in WKWebView. You can define the path to where the files will be downloaded, like this you can them download them to a place where you still have access to from within wkwebview.
It's my first Plugin and I used swift, since it has an easier syntax. And there is still some work to do although I'm already using it in production.
The plugin is cordova-plugin-file-sync

Hi again, since giving up is not an option 😄
Found a cordova-webserver, easy to configure and use:
https://github.com/floatinghotpot/cordova-httpd
There is also a open PR to serve multiple folders open, which also is cool.
I do server the folder
/Users/pm/Library/Developer/CoreSimulator/Devices/<UDID>/data/Containers/Data/Application/<AppId>/

So I have access to all files.
The angular service I made:
function webserverService($ionicPlatform, $q) {

    "use strict";
    console.info("------>  webserver Service loaded");

    // private variables
    // ----------------------

    // exposed
    // ----------------------
    var service = {
        start: startServer,
        stop: stopServer,
        getUrl: getUrl,
        getLocalPath: getLocalPath,
        isRunning: isRunning
    };
    return service;

    // functions not in plugin
    // ----------------------
    function getPlugin() {
        var defer = $q.defer();

        $ionicPlatform.ready().then(function () {
            if (cordova && cordova.plugins && cordova.plugins.CorHttpd) {
                defer.resolve(cordova.plugins.CorHttpd);
            } else {
                console.error("webserverService: CorHttpd not found");
                defer.reject("CorHttpd not found")
            }
        });

        return defer.promise;
    }

    function isRunning() {
        var defer = $q.defer();

        getUrl().then(function (url) {
            if(url.length > 0) {
                defer.resolve(true)
            } else {
                defer.resolve(false)
            }
        });

        return defer.promise;
    }

    // functions
    // ----------------------
    function startServer(options) {
        var defer = $q.defer();

        console.log('serving from ', cordova.file.applicationStorageDirectory.replace( 'file://', '' ));

        isRunning().then(function (isRunning) {
            if (isRunning) {
                console.warn('webserverService: already running');
                defer.resolve(true);
            } else {
                return getPlugin();
            }
        }).then(function (httpd) {
            httpd.startServer({
                www_root : cordova.file.applicationStorageDirectory.replace( 'file://', '' ) || options.www_root,
                port : 8080 || options.port,
                localhost_only: true || options.localhost_only
            }, function(url) {
                console.log('webserverService: server started at ', url);
                getLocalPath().then(function (path) {
                    console.log('webserverService: localPath', path);
                });
                defer.resolve(url)
            }, function (error) {
                console.error('webserverService: could not start webserver');
                defer.reject(error);
            })

        });

        return defer.promise;
    }

    function stopServer() {
        var defer = $q.defer();

        getPlugin().then(function (httpd) {
            httpd.stopServer(function() {
                defer.resolve(true);
            }, function(error) {
                defer.reject(error);
            });
        });

        return defer.promise;
    }

    function getUrl() {
        var defer = $q.defer();

        getPlugin().then(function (httpd) {
            httpd.getURL(function(url) {
                defer.resolve(url);
            }, function (error) {
                defer.reject(error);
            });
        });

        return defer.promise;
    }

    function getLocalPath() {
        var defer = $q.defer();

        getPlugin().then(function (httpd) {
            httpd.getLocalPath(function(path) {
                defer.resolve(path);
            }, function (error) {
                defer.reject(error);
            });
        });

        return defer.promise;
    }
}

This issue is on the todo list of the ionic developers to look into. Be patient.

Haha I'm shure Ionic is doing what they can and they have a lot to do. But the workaround with the local webserver is working.

The workaround presented by @mnewmedia is very similar to the approach used by the Telerik WkWebview plugin. Unfortunately, that plugin is poorly maintained (most notably, it doesn't support Cordova iOS 4+).
It seems like running a web server is the only way to fully solve the file:/// protocol issues of WkWebview, which means that it is probably smarter to serve the entire app through the web-server rather than just assets. Doing so would remove the need for the XHR polyfill and probably simplify this project a lot.
It is really great that the Ionic crew is building a new wkwebview plugin, as this has been a weak part of the Cordova toolchain for a long time. I do hope that they'd consider the webserver approach, as it would probably be more robust and remove the issues surrounding the XHR polyfill (external library compatibility).

I've been looking into this whole WKWebview + file:// issue for a long time now and came up with this PR: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/26
I'm not entirely sure but I think it would replace the need for this fork entirely... would love to see feedback...

@rubenstolk @mnewmedia @kristfal @dylanvdmerwe
Can you reinstall WK and try again? WK 2.0 was released!!
https://github.com/driftyco/cordova-plugin-wkwebview-engine/commit/114a9b190a06285d3ae6ac0384e85e0401942d56

@manucorporat I saw the code for 2.0 but I don't really understand how you've solved the file access. Can you explain the philosophy behind 2.0?
Really eager to try it out though! Especially wondering if it would also allow FileReader stuff...

@rubenstolk of course.
Basically we fool WKWebView into thinking it is performing a HTTP request, but actually there is not a HTTP server involved.
I found a way to hijack the request at the Foundation (apple framework) level, this way we override the current behavior of a HTTP request if the host === ionic.local.
Instead of performing the request, we read the path:
http://ionic.local/var/mobile/Containers/Data/Application/UUID/Library/NoCloud/images/img.jpg

and we read the dick normally, then we fulfill a NSURLMutableResponse, and we return it back to WK

@manucorporat but it wouldn't solve access to uploaded files right? I think I'll have to stay with https://github.com/apache/cordova-plugin-wkwebview-engine/pull/26 for another while...

yes, I would solve the access to uploaded files!

Oh hey, this indeed works... that's kind of magic!

@rubenstolk told you!!! haha
Also this new plugin will allow us to run all the image prefetching in ion-img inside web workers, expect HUGE performance improvements in Virtual List with hundreds of images (Instagram-like apps)

Do you have any documentation on how to use web workers?

no yet, we are still figuring out a lot things :)

@manucorporat I think there would be merit in releasing the version with the file access solved as a separate (non-ionic-specific) branch. It would help non ionic users as well.

Can confirm that files such as images work, but others such as videos do not. This includes reading from assets and on the file system. @manucorporat I have sent you a test project to help reproduce this.

@manucorporat this is looks really great!  I have just installed from the git repo been reading through these comments to try and work out how to address local files.  I was thinking it would be beneficial if urls starting with file:/// could be automatically replaced so that we don't have to perform any platform specific logic when using this plugin.
I'm more than happy to help you out with testing this in different scenarios if that is useful

This is great nice work, my only problem I'm using (file, file transfer, chromium zip) plugins and therefore using cdvfile:// and it wont navigate to the page. but at least it allows me to download the page in the first place. a definite step forward

cdvfile urls should work fine passing references to files and file locations between plugins, I also use the file transfer, file and media plugins, all of which support cdvfile in their native code.
You can't use cdfile:// urls directly in your templates with wkwebview though.  You can use the full path to the file:

//map the filesystem dataDirectory
this.fs = cordova.file.dataDirectory;

//path to access a file
this.targetPath = this.fs+this.imageCacheDir+"/"+"filename.jpeg"

//set the target download path for images (for ios slice off the file:/// for wkwebview)
if(this.targetPath.startsWith("file:///") && this.isWKWebview){
      this.targetPath = this.targetPath.slice(7);
}

Event I didn't try it out yet, but i will soon =)
I would like to say: Thank You @manucorporat 🎉 ❤ 😄

@manucorporat just found out that while using regular XHR's to external hosts, no JSON body is being sent.
I'm getting more convined that we should put our energy in convincing Webkit/Apple to open up the api for: "https://github.com/apache/cordova-plugin-wkwebview-engine/pull/26" so that we can stay away from hacky workarounds...

@manucorporat
As you suggested, I used the latest code to try to show an image:
<img src="/var/mobile/Containers/Data/Application/UUID/Library/NoCloud/images/img.png" />

It threw following errors on iOS10.2-Device. This worked fine on the iPhoneSimulator(10.2). It worked fine with UIWebview.
[Error] Failed to load resource: The operation couldn’t be completed. (kCFErrorDomainCFNetwork error 1.)
[Error] Failed to load resource: The operation couldn’t be completed. Operation not permitted

@manucorporat thx for the plugin version 2!
the really neat tricks you described above to do not index images with file:// but without shouldn't be documented in the README? I guess many persons could be interested by that nice workaround

plz revert back to ionic.local instead of localhost as it's easier to whitelist them

@manucorporat thanks! Stripping file:// from the URL worked for us.

@ghenry22 This is really elegant! How do you do feature detection like this? this.isWKWebview

@krishnagopinath it is a small function that checks if the platform is iOS and if indexdb is available as in the readme for this repo.  Seems to work.  Make sure to check for iOS as well though, otherwise android systems with indexDB will misdetect.

Hi guys,
Is this working in recent versions?
Thank you!

Yes this all works perfectly.

Yes, you are right!
I removed everything (plugin, platforms, node_modules) and I installed again!
Now all works!
Thank you!


Contact-Card Formatting JSON not working

[ 1 ] Bug
Expected or Desired Behavior
I was expecting the view as displayed on Github, but instead just see a blank page.
To get to this, these were the steps that were performed:

List created based on the column requirements.
Pulled the code down from Github
Edited the Google Map API key with a newly generated key
Pasted the code in the Format current view and click on saved
Nothing happened, can't see any information

Please let me know if i am doing something wrong or is it something else

@Ishan-seth I'm not sure I understand the issues you are experiencing. This format is designed to use a Picture column (these columns are just URLs to images stored elsewhere, presumably a local document library). If the picture column is blank for a row, the standard no profile image is used (/_layouts/15/userphoto.aspx?size=M).
To get more details you can add `"debugMode":true to the top of the "rowFormatter". You can also check for any error messages in the console using your browser's dev tools (Generally press F12).
Any extra details would be really appreciated! Thanks!


Support max_pods in node pools

Add support to the node-pools for setting max pod count.
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/kubernetes_cluster_node_pool

Adding in docs on reason we need to be able to set max_pods for dynamic node pools.
https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/azure-subscription-service-limits#azure-kubernetes-service-limits

Related to #43

Fixed in #78

Fixed in #78


feat(gateway): add WithBlockNum option

Rationale
I have a use case where each organization has an application that listens to chaincode events through the gateway and react accordingly.
All events should be processed, even when starting the application after the other organizations.
Proposed changes
Currently the gateway only supports listening to new events, not existing ones, although the event client has such capability.
This PR introduces a new gateway option to let the user specify from which block to start listening to events.
Design choices
FromBlockSet is a flag since 0 would be a valid block number, we need to determine if the user has explicitly set a starting block number.

@andrew-coleman


Add a UI tutorial

Create a UI tutorial that follows the same style and layout as other CL tutorials.

@hyounes4560 we want to split the new UI tutorial in 2 chapters:

tutorial-3.rst: Analyze Docker Image (Web UI)

Similar to the command line tutorial (with a different input) and uses the Web UI. Using docker://alpine/httpie as input in the "Download URL" field to expose the image fetching feature.
The goal here is to create and launch a pipeline and to provide a walk through of the various UI features only as related to a pipeline creation, launch, its runtime, log and completion as well as its possible runtime errors.

tutorial-4.rst: Review Scan Results (Web UI)

The "Review Scan Results" chapter is the direct continuation of "Analyze Docker Image", where the presented results are related to the previous pipeline run.
The goal here is to show how the web UI is used to review scan results, to focus on the UI features to navigate the summary and graps, browse package and resources details and hyperlinking between these different areas in order to guide on how scan results can be review.


Upgrade to go-1.18

Hello, this PR can be closed since latest released version is already using Go 1.18.


Better Request Error Results

Is your feature request related to a problem? Please describe.
Currently, invalid request errors are boxed into a high-level client error; this isn't particularly helpful in diagnosing what specific issues the MBTA API had with the request (typically invalid query parameters or non-existent resources).
Describe the solution you'd like
ureq errors have a Status error that contains a status code and a response object with a known schema. This means that a helpful "error" response could be returned that indicates to the user what issues the API had with the request. Refactoring would convert the existing Response struct into an enum with some kind of Success variant and Error variant, with the Success variant containing the current Response schema and the Error variant containing the error response schema.
Describe alternatives you've considered
N/A
Additional context
N/A

Revising the proposed solution, it probably makes more sense to define the error schema as an Error variant to avoid signaling that an API request error is an "okay" response.


[MM-48061]: Allow CTRL/CMD + K to insert link formatting when text is selected

Summary

This PR resolves two issues.

If the user hits CTRL/CMD + K then add the markdown link formatting (same as if they hit CTRL + Alt + K).
If the clipboard contains a URL beginning with http:// or https:// and the user pastes, format it as a markdown hyperlink with the selected text.

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/21575
Screenshots

If the user hits CTRL/CMD + K then add the markdown link formatting (same as if they hit CTRL + Alt + K).

https://user-images.githubusercontent.com/59413880/220940058-09446d46-1b74-40d3-814b-495cbef8ff22.mov

If the clipboard contains a URL beginning with http:// or https:// and the user pastes, format it as a markdown hyperlink with the selected text.

https://user-images.githubusercontent.com/59413880/220939735-d7e9b92f-b8d6-4280-ae9d-757616d0fa04.mov
Release Note

Allow CTRL/CMD + K to insert link formatting when text is selected

Hello @kyeongsoosoo,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

Thank you for the PR @kyeongsoosoo, this is sweet!

@AshishDhama can you help look into why the test server won't fire up?

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/e2e-test

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

/update-branch

Hey there!, Thank you for your PR.
Webapp is now part of mattermost monorepo now at https://github.com/mattermost/mattermost-server/tree/master/webapp Would you be interested in opening the PR over there?

The web app now lives in the webapp/channels over in https://github.com/mattermost/mattermost-server. We decided to move it to be a monorepo to make both development and our CI pipelines easier, but it's unfortunately disruptive right now. We've updated our setup docs and added some steps for migrating to working with the monorepo.
Copying the changes over there hopefully shouldn't be too hard. There's a few changes to file paths (such as the code living in a dedicated src subdirectory), but most things should look the same as they do now.
Let us know if you could use any help with this. Hopefully the process is smooth.

@hmhealey  @M-ZubairAhmed  I'll open the PR soon!

Hi @kyeongsoosoo, Can you please assign me a new PR for QA review?


ChangeBlockEvent.Break fired with misleading cause upon chunk generation

ChangeBlockEvent.Break is fired upon chunk generation with a cause containing only the player.
Example:
Cause[{Name=Source, Object={EntityPlayerMP['Dark_Arc'/208, l='Wilderness', x=274.00, y=116.00, z=2962.00]}}]

@DarkArc is this still an issue with latest build? If not, please close.

It's fixed for sure, sorry, I wasn't available yesterday.


Origin quota per user

We need to track how many origins a particular user account has used and stop them from using more once they hit a high quota, as this is how we're billing for the service.

After discussion we've decided to track per group rather than per user. That way, large organizations don't all have to share the same user account.

Still to add:

Good user feedback about the quota
When queries fail due to a cluster restart, we need to "refund" that query to the user's quota.

Done.


WebApp:The Java example of "az webapp create" is wrong

The Java examples are confusing with respect to the runtime version, 8 and 11.
While indeed the string java|11|Java SE|8 is returned by az webapp list-runtimes, I expect the text to describe what this means ... is it java 8 or 11?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2983e943-cce1-effd-57d0-cce4b0c0a7e1
Version Independent ID: 4262c40a-7140-b420-58b5-5cf40ab2316e
Content: az webapp
Content Source: latest/docs-ref-autogen/webapp.yml
Service: app-service-web
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

route to appropriate team

@calvinsID can you please respond here.

Hi @ciufudean, it is java 11, using java se 8 application server. I'll update the help doc

@calvinsID is this already updated?

now it is :)


uguid: Expand code coverage

Codecov Report

Merging #49 (3aa5947) into main (60e1cc5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   90.61%   90.61%
=======================================
  Files          16       16
  Lines        1492     1492
=======================================
  Hits         1352     1352
  Misses        140      140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e1cc5...3aa5947. Read the comment docs.


Optimizing the apply function

I integrated a custom serializer and deserializer (in order to put gzip the content using lz-string lib). However, changing a certain setting caused all the keys to get reset in localStorage. Besides the entry that needs changing, also other entries are refreshed where this is not needed. Combine that with a rather slow/expensive compress function, this leads to performance degradation.
The PR checks if the key is actually changed before resetting it in the storageProvider.

I'm not sure why the test is failing, it looks like the $apply function is used in other usecases as well. Maybe someone can shed some light on that?

Allright! I managed to get the optimization working without breaking the tests. The problem was that the tempstorage reference always needs to be deleted, even if we don't persist the value into storage.


use OpenSUSE 15.5 for uyuni master, released and prs

What does this PR change?
use OpenSUSE 15.5 for uyuni master, released and prs

These are useless without changing https://github.com/mbussolotto/sumaform/blob/15.5/modules/server_containerized/variables.tf#L276 to default

Well, not exactly useless, we need both ;)
And keep in mind that this will affect all the environments, so let's announce it so everyone is aware.


Running this start up script from terminal works fine in OS X but throws off errors when using Launchd

I can run the following shell script to start the VeraHomeKitBridge, but when I try to load it from Launchd, it throws of Error 1 and the following log - any ideas/suggestions?
Marker - Dec 21, 2016, 1:33:03 AM

cd /usr/local/src/VeraHomeKitBridge
/usr/local/bin/npm run start

npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "start"
npm ERR! node v4.5.0
npm ERR! npm  v2.15.9
npm ERR! file sh
npm ERR! path sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn sh
npm ERR<EMAIL_ADDRESS>start: node app.js
npm ERR! spawn sh ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node app.js'.
npm ERR! This is most likely a problem with the VeraHomeKitBridge package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node app.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs VeraHomeKitBridge
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls VeraHomeKitBridge
npm ERR! There is likely additional logging output above.
npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "start"
npm ERR! node v4.5.0
npm ERR! npm  v2.15.9
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: node app.js
npm ERR! Exit status -2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node app.js'.
npm ERR! This is most likely a problem with the VeraHomeKitBridge package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node app.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs VeraHomeKitBridge
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls VeraHomeKitBridge
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /usr/local/src/VeraHomeKitBridge/npm-debug.log

cd /usr/local/src/VeraHomeKitBridge
/usr/local/bin/npm run start

npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "start"
npm ERR! node v4.5.0
npm ERR! npm  v2.15.9
npm ERR! file sh
npm ERR! path sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn sh
npm ERR<EMAIL_ADDRESS>start: node app.js
npm ERR! spawn sh ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node app.js'.
npm ERR! This is most likely a problem with the VeraHomeKitBridge package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node app.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs VeraHomeKitBridge
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls VeraHomeKitBridge
npm ERR! There is likely additional logging output above.
npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "start"
npm ERR! node v4.5.0
npm ERR! npm  v2.15.9
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: node app.js
npm ERR! Exit status -2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node app.js'.
npm ERR! This is most likely a problem with the VeraHomeKitBridge package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node app.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs VeraHomeKitBridge
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls VeraHomeKitBridge
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /usr/local/src/VeraHomeKitBridge/npm-debug.log

OK - Found the problem... Had to set the correct PATH environment for Launchd


Feature Request: Work trhu proxy with Integrated/Kerberos Authentication

This is valid for VSCode too, when you specify proxy and that proxy requires NTLM/Kerberos authentication its not working at all, every time we need to create local proxy with Fiddler or CNTLM applications.

Closing this older issue as upstream.  If this gets fixed in vscode we'll pick up that in a future source code refresh.


FML: Mod could not be found OpenMods: [0.7,0.8)

I just updated my personal modpack and this thing popped up.
Error line from the console:
[19/9/2015 13:27:57 PM] [Client thread/ERROR] [FML]: The mod OpenPeripheral (OpenPeripheralAddons) requires mod versions [OpenMods@[0.7,0.8)] to be available
I believe this is just a typo in the @Mod annotation

No, it's not a typo, it's open interval. OpenPeripheral-AIO-4b requires OpenModsLib 0.7 or 0.7.* (like 0.7.2), but 0.8 is incompatible. Update to AIO-5.


Add gitignore as a supported file type/language tag (with syntax highlighting set to as atom/language-shellscript)

Preliminary Steps
Please confirm you have...

[x] reviewed How Linguist Works,
[x] reviewed the Troubleshooting docs,
[x] considered implementing an override,
[x] verified an issue has not already been logged for your issue (linguist issues).

Regarding overrides, I think gitignore should just be a first-class alias in linguist. Also, .gitignore files should be highlighted correctly without requiring any configuration.
Problem Description
If I try to use gitignore as a language tag, I do not get any syntax highlighting. Example: https://gist.github.com/binki/8e9146122509a2bd1375c7b961e810ab where no syntax highlighting is shown when explicitly setting lang=gitignore and https://gist.github.com/binki/7e0710d92863276ba39091cb299725bd which shows that .gitignore is being detected as “text”.
I think linguist should provide at least an alias of gitignore and perhap just use the shell syntax highlighting for it.
URL of the affected repository:
https://gist.github.com/binki/8e9146122509a2bd1375c7b961e810ab
https://gist.github.com/binki/7e0710d92863276ba39091cb299725bd
https://github.com/binki/promise-delay-ts/blob/1b1fc0c311e3442ff8050b95e66c1d1a8850ee98/.gitignore
Last modified on:
2018-08-07
Expected language:
gitignore with syntax highlighting configured to use atom/language-shellscript or shell.
Detected language:
text

If I try to use gitignore as a language tag, I do not get any syntax highlighting.

What's wrong with using shell as the language tag if you want your .gitignore file to be highlighted as Shell code?
In my opinion, detecting .gitignore files as Shell is a bit of a no-go because it would also affect language statistics, and most users wouldn't understand why they get a small percentage (or 100% if they have no programming files) of Shell code detected in their repositories for a configuration file.

@pchaigno

If I try to use gitignore as a language tag, I do not get any syntax highlighting.

What's wrong with using shell as the language tag if you want your .gitignore file to be highlighted as Shell code?

I think you answered your own question. See:

In my opinion, detecting .gitignore files as Shell is a bit of a no-go because it would also affect language statistics, and most users wouldn't understand why they get a small percentage (or 100% if they have no programming files) of Shell code detected in their repositories for a configuration file.

gitignore should be a first class supported language tag and atom/language-shellscript should just be the syntax highligher for the gitignore language.
Additionally, one shouldn’t have to use .gitattributes to hackily set their .gitignore to shell just to get syntax highlighting to work when looking at their .gitignore in their own repository. It may be an acceptible workaround for fenced code blocks in markdown in the meantime, though.

Oh I see, my bad. So you want to add support for gitignore as a language and use the Shell grammar to highlight it? I think that would be ok. Do you want to submit a pull request?

No problem!
I can try submitting a PR. It might take me a bit to get around to it, though.

Is it best to cover all of those various files in this one issue or should they each be separate issues?

... errr , did I just reply to your last comnent by writing over the top of it?

COME OUT FROM HIDING, i CAN'T SEE YOU.  I feel I'm in a thread with poltergeists at the moment. :D

@binki To give you a bit of context: as co-maintainers we can edit everybody's posts on the repository. I honestly think this is not something we should be able to do, but anyways. It happens to be handy to copy rendered code from someone you want to quote, such as your earlier link. @Alhadis, being very tired, apparently was in the process of doing so, but wrote in your comment instead of creating his own... I've always fear that would happen to me, but looks like @Alhadis is even more tired than I am at the moment.
@Alhadis You need to sleep.

@pchaigno I figured something like that was happening. I wish GitHub had a readonly “raw markup” view for comments to make block quoting easier myself—it’s unfair how I have to manually rebuild all the markdown after copy/paste just because I’m not a contributer! :-p

Closing this one. @binki Feel free to send a pull request (even if it doesn't support all file types at first) when you have the bandwidth.

I see that this issue was closed, but I don't see the resolution.  Has this been added?  Is it WONTFIX?  If it's a feature that would be added but hasn't yet, where is that being tracked?

I see that this issue was closed, but I don't see the resolution.  Has this been added?  Is it WONTFIX?  If it's a feature that would be added but hasn't yet, where is that being tracked?

@ianfixes Support for .gitignore was added in #4343, albeit under the name Ignore list (since the language entry was used for several formats with similar or identical syntax to .gitignore files).

@ianfixes Support for .gitignore was added in #4343, albeit under the name Ignore list (since the language entry was used for several formats with similar or identical syntax to .gitignore files).

Testing 123, via https://webapps.stackexchange.com/q/119452
# Common editor swap files
*.swp
*~
*\#*

Nice!

Testing 123, via https://webapps.stackexchange.com/q/119452
# Common editor swap files
*.swp
*~
*\#*

Nice!

This apparently has been added to linguist: https://github.com/github/linguist/pull/4343
The tag you should use is Ignore list, as in

Two slight corrections:

The tag should be ignore-list (or simply gitignore, which is supported as an alias
You can replace the word "apparently" with "definitely". 😉

Note that fenced code-blocks must be tagged with a single-word identifier; i.e., something like Ignore list should be replaced with ignore-list. Note that GitHub performs some magic in order to pair a code-bock's tag with a language entry.

This apparently has been added to linguist: https://github.com/github/linguist/pull/4343
The tag you should use is Ignore list, as in

Two slight corrections:

The tag should be ignore-list (or simply gitignore, which is supported as an alias
You can replace the word "apparently" with "definitely". 😉

Note that fenced code-blocks must be tagged with a single-word identifier; i.e., something like Ignore list should be replaced with ignore-list. Note that GitHub performs some magic in order to pair a code-bock's tag with a language entry.


[XLA] Make sure HloComputation::Equals takes dangling side-effects into account.

Current implementation does not take dangling side-effect instructions such as outfeeds or rngs into account.
For example:
c1 (arg0.1: f32[], arg1.2: f32[2], arg2.3: f32[1,1,2,2]) -> () {
  %arg0.1 = f32[] parameter(0)
  %arg2.3 = f32[1,1,2,2]{3,2,1,0} parameter(2)
  %arg1.2 = f32[2]{0} parameter(1)
  // Do some computation
  %result = fp32[] ....
  %aa = token[] after-all()
  %feed = token[] outfeed(result.35, aa)
  ROOT %tuple.53 = () tuple()
}

c2 (arg0.1: f32[], arg1.2: f32[2], arg2.3: f32[1,1,2,2]) -> () {
  %arg0.1 = f32[] parameter(0)
  %arg2.3 = f32[1,1,2,2]{3,2,1,0} parameter(2)
  %arg1.2 = f32[2]{0} parameter(1)
  ROOT %tuple.53 = () tuple()
}

then *c1 == *c2 evaluates to true.

Note that we could simplify this by saying "two computations can never be equal if they have side effects". And it seems like most instructions with side-effect override identical to false but there are exceptions like the all-reduce in this test.

@georgepaw Can you please resolve conflicts? Thanks!

It has been 15 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

@georgepaw gentle ping to resolve conflicts? Thanks!

I'm going to go ahead and close this PR, because it seems to have stalled. If you're still interested in pursing this (and responding to my comments), please feel free to reopen!


Clarify why to use trust over rust-everywhere

From an initial look the only difference between trust and rust-everywhere is the use of cross, and maybe one or two additional architecture. The advantages should listed in the README.

Done in https://github.com/japaric/rust-everywhere/commit/ea191c8ba817a56d1911b08213a650ae67e568b5


Add draft search API docs

This is a straw man for the search API. Hopefully it should include most of the use cases and features that people/servers may want to support.
Note: A lot of the API is optional, and the likelihood is that Synapse will only implement a subset of the features. The reason for including features in this design document is so that we have an idea of how those features would fit into the search API in the future.

Rendered

Can you give some use cases for facets, and spell out how pagination interacts with groups/facets?
I like the idea of a slightly more structured search API than google's ?q=term, but worried this is getting too complicated and faffy for clients to implement - both for constructing the query and navigating the response.
(also, why markdown? :/)

On 7 Oct 2015, at 06:01, Erik Johnston<EMAIL_ADDRESS>wrote:
This is a straw man for the search API. Hopefully it should include most of the use cases and features that people/servers may want to support.
Note: A lot of the API is optional, and the likelihood is that Synapse will only implement a subset of the features. The reason for including features in this design document is so that we have an idea of how those features would fit into the search API in the future.
Rendered
You can view, comment on, or merge this pull request online at:
https://github.com/matrix-org/matrix-doc/pull/86
Commit Summary
Add draft search API docs
Fixup JSON format
File Changes
A drafts/search_api.md (198)
Patch Links:
https://github.com/matrix-org/matrix-doc/pull/86.patch
https://github.com/matrix-org/matrix-doc/pull/86.diff
—
Reply to this email directly or view it on GitHub.

Can you give some use cases for facets, and spell out how pagination interacts with groups/facets?

I'll add some examples at the bottom too.

I like the idea of a slightly more structured search API than google's ?q=term, but worried this is getting too complicated and faffy for clients to implement - both for constructing the query and navigating the response.

Yeah, I'm a bit concerned with making sure that request/responses aren't too complicated. I think this API allows clients to ignore most of the bits if they don't need to support it.

(also, why markdown? :/)

I completely forgot we used rst for docs :(

I like the general design. I think a few "helper" endpoints could make the API easier to use.
In the design doc, we clearly have an idea of which search type to use for which search category:

m.room.message:

content.body - FTS
msgtype - exact match

m.room.name:

content.name - FTS / substring

Yet the API gives you the flexibility to choose which one:
POST /search
{
    "search_categories": {
        "room_events": {
            "constraints": [
                {
                    "type": "FTS",
                    "key": "content.body"
                    "value": "lazy dog",
                }
            ],
        },
    }
}

I propose the addition of another endpoint which effectively snips everything in that JSON object down to the value:
POST /search/rooms
{
  "value": "lazy dog"
}

Likewise, I would propose having helper endpoints for "the common use cases":
POST /search/profiles
{
  "value": "mike"
}

POST /search/rooms/$ROOM_ID
{
  "value": "banana"
}

POST /search/all
{
  "value": "github"
}

Whether this remains a JSON object for extensibility and whether we should default to arrays and not strings are open questions, but I feel some helper endpoints with "sensible defaults" would be a good improvement.
I do not propose changing the response format (though I would also propose not bothering with groups or facets for the initial cut, which keeps the response format pretty trivial).

+1 to kegan's feedback

can we kill this, now that a search API has landed?

@erikjohnston - what's the deal on the search API?

The search API has landed in the main spec

@erikjohnston so this PR can be closed?


CI and Build Script

Fixes #9.
Also includes a few path changes which were brought up by running the tests from a different location.
CHANGES.txt is predominantly a placeholder for now!

Issues...

The Appveyor build seems not to be using the generated file suffix to publish packages.

We don't normally package with the travis build

The travis build has some test failures that are unrelated to the script, but others are related - they can't be run on travis because they require a display.

D'oh - more worryingly, I wasn't throwing an exception to fail the build on test failure. :-/ Will sort that tomorrow - presume we're better just not running the tests on Unix than trying to categorize them. (That said, is there even a need to build it?)

The Appveyor build seems not to be using the generated file suffix to publish packages.

Think I see what you mean on the GUI repo, didn't realise we did that. Will add it in.

It would be OK to temporarily disable the tests on Travis but in the long run we need to build and test there. Debian and most of its derivatives only package software that they can build from source. So we have to build on Linux. We could skip testing, but only if we don't care whether it works. :-)

Ok, sure. Will dig in to it! :-)

Ok, the changes here should fix most issues. (I've also checked that failed tests actually fails the build this time - whoops!)
The failures on Unix (once the GUI stuff were in) were due to Path.AltDirectorySeparatorChar being a forward slash on mono - contrary to what MSDN states. Looking at the code, it seems the path resolution stuff is intended for resolution of paths generated within the program, rather than files transferred between OS's, so adapting the code didn't seem the right solution. I instead excluded the tests with Windows paths on Unix, to match what was already done for RelativePathTest.
This is ready for review again.

So I see you're using AppVeyor but I'm confused as to where the appveyor project is (ie the url to see latest builds)

See https://ci.appveyor.com/project/CharliePoole/nunit-project-editor


Allow to scan multiple image variants in one go

I build several variants of the image (alpine/distroless), would it be possible to specify several images to scan instead of necessity to define scan job multiple times ?

@ ammohant this looks like a fair ask. Will this change anything for the ASC scenario?

@azooinmyluggage  - Supporting this will be a superset of current ASC requirements. Nothing changes for ASC as such

@grzesuav It will take us a sprint or two to prioritize this. We are open for contribution :)
Let us know either way. Thanks!!

thanks :)

@grzesuav PR or no PR? :)
Do let us know. Ok both ways

hi, unfortunately cannot commit to anything in near future

@shigupt202 would you like to pick this up?

CONTAINER SCAN - V1
Container Scan GitHub action has been in v0 for about a year now. Here’s a bunch of enhancements we’re proposing to make the experience of customers better.
CREW:
@ajinkya599
@ds-ms
@shigupt202
PROBLEM STATEMENT:
Let’s say you are to scan image1 and image2 in your container registry. Your snippet of workflow currently would look like this:
- uses: azure/container-scan@v0
  with:
    image-name: loginServerUrl/myImage1
    username: ${{ secrets.DOCKER_USERNAME }}
    password: ${{ secrets.DOCKER_PASSWORD }}
- uses: azure/container-scan@v0
  with:
    image-name: loginServerUrl/myImage2
    username: ${{ secrets.DOCKER_USERNAME }}
    password: ${{ secrets.DOCKER_PASSWORD }}

Although both the images are in the same registry, we have to add the action multiple times. This proposal is to reduce the duplication of the same snippet to ensure a cleaner workflow as well as making the container-scan action more efficient.
FEATURE REQUEST:
Allow users in container-scan to scan multiple docker images in one go.
The new workflow with our proposal would look like this:
- uses: azure/container-scan@v1
  with:
    images: |
      loginServerUrl/my-image1
      loginServerUrl/my-image2
    username: ${{ secrets.DOCKER_USERNAME }}
    password: ${{ secrets.DOCKER_PASSWORD }}

Solving this problem isn’t straightforward, we have listed out the requirements and potential solutions we’ve identified:
SOLUTION:

Requirement
Solution

Input for multiple images
1. Continue with the same input image-name and use image-names for multiple images.  2. [BREAKING] Remove image-name and include images for single as well as multiple images.

Allowedlist file
1. Use the same list of vulnerabilities for all the images.  2. Add image specific nodes in the file, parallel to general (example below)

Scan-report
1. Create a new output variable called scan-reports for multiple images, and keep the existing scan-report for single image scan. 2. [BREAKING]      a. Update the structure of the report and make it an array of jsons in a single file.      b. Create multiple files for each scan and make the output variable (scan-reports) an array of .

Check-run for scan summary
1. Create a separate check-run for each image scan. Showing summary of all the scans may not be possible because of character limit with check runs.

Registry credentials
1. Support only single registry, to avoid taking inputs for multiple registry credentials and their mapping with the image. For scenarios with images from different registries, the user can pull the images on the runner before running this action.

[Example]: AllowedList with image specific nodes:
general:
 vulnerabilities:
   - CVE-2003-1307
   - CVE-2011-3374
 bestPracticeViolations:
   - CIS-DI-0005
   - DKL-DI-0006
image-name-1:
 vulnerabilities:
   - CVE-2003-2207
   - CVE-2011-9074
 bestPracticeViolations:
   - CIS-DI-0205
   - DKL-DI-1106

Solution 1:
In this approach, we try to maintain back-compat and update v0 version of the action with the following changes:

Introduce input image-names which is a newline separated list of images to be scanned. If image-names is provided, ignore image-name input.
Start supporting image specific nodes in allowedList file.
Introduce a new output variable scan-reports which is an array of individual scan-report file paths separated by comma. Example scan-reports:
temp/scan-report-image-1,temp/scan-report-image-2
Create check-runs for each scanned image with the details of scan.

Solution 2:
In this approach, we introduce a new version v1 for the action that has breaking changes:

Replace image-name input by images input, which is a newline separated list of images to be scanned.
Start supporting image specific nodes in allowedList file.
Replace scan-report output variable with scan-reports which is an array of individual scan-report file paths separated by comma. Example scan-reports:
temp/scan-report-image-1,temp/scan-report-image-2
Create check-runs for each scanned image with the details of scan.

Side effects:
Today, azure/publish-security-assesments understands the scan-report generated by container-scan. Currently, it directly consumes the result of container scan using syntax like ${{ steps.container_scan.outputs.scan-report-path }} as shown in the snippet below:
- run: docker build . -t contoso.azurecr.io/k8sdemo:${{ github.sha }}

- name: Scan container image for vulnerabilities
  id: container_scan
  uses: Azure/container-scan@v0
  with:
    image-name: contoso.azurecr.io/k8sdemo:${{ github.sha }}

- name: Publish container scan results to ASC
  uses: azure/publish-security-assessments@v1
  with:
    subscription-token: ${{ secrets.asc_subscription_token }}
    instrumentation-key: ${{ secrets.ai_instrumentation_key }}
    scan-results-path: ${{ steps.container_scan.outputs.scan-report-path }}

This integration will keep working if we don’t modify the scan-report schema. There will be a requirement to have an extra step to parse the right scan report path in case of multiple scans though. We can document this.
If we introduce breaking changes in scan-report schema, we will need to modify the implementation to understand this change. (Note that the integration will still keep working with v0 version of container-scan action)

Captured the proposal based on internal discussion above, for visibility.

Closing as this is captured in the v1 proposal.


an issue about DataView constructor

When executing the testcase below, jerry throws a RangeError when the third argument is present and the value is undefined. According to ES6.0, the expected output should be 0. The value of [[ByteLength]] internal slot may not satisfy the spec. This is an issue about DataView constructor.
version
bd1c4df
testcase
var NISLFuzzingFunc = function(){
    var a = DataView(new ArrayBuffer(256),0,undefined);
    print(a.getInt16(0));
};
var result = NISLFuzzingFunc();

output
RangeError: Start offset is outside the bounds of the buffer.

expected output
0

Contributor:@YuanWangC

Disclaimer: The issue report may or may not be valid, I haven't checked. But. According to git rev-list --count bd1c4df..master, the reported revision is 104 commits older than master at the time of writing my comment. Please, do update your local copy more frequently!


When I finished installing Visual Studio Code, the black screen shows.

When I finished installing Visual Studio Code, the black screen shows.

@ZimKhan What operating system are you using? Have you been able to successfully install previous version of VSCode? Does launching VSCode with code --disable-gpu fix the problem?


DBeaver Nightly: Add version 24.3.0-2024-11-20

Add new manifest for DBeaver Early Access. https://dbeaver.io/files/ea/

[X] I have read the Contributing Guide.

All checks are passing. Please review this.

Please @HUMORCE 🙏🏻

/verify

Sorry, manifest was already a day old. Updated again now.

/verify

Only the version needs to be captured.

The 24.3.0 part doesn't change until the next release. Only the date part changes with the daily version. If I remove the date part, I'll lose out on the daily versions, which is the goal of this package.

Renamed to dbeaver-ea

Thanks!

Have an extra "," at the end
> scoop search dbeaver
ConvertFrom-Json : 传入的数组无效，结尾多出了“,”。 (840): {
    "version": "24.3.0-2024-11-20",
    "description": "Database tool for developers, SQL programmers, database administrators and analys
ts. (Early Access)",
    "homepage": "https://dbeaver.io",
    "license": "Apache-2.0",
    "suggest": {
        "java": [
            "java/oraclejdk",
            "java/oraclejre8",
            "java/openjdk11"
        ]
    },
    "architecture": {
        "64bit": {
            "url": "https://dbeaver.io/files/ea/dbeaver-ce-24.3.0-win32.win32.x86_64.zip",
            "hash": "a164dd477e070b3e0e50aa062fdcd32b46aba74025eed265ec6a5a618ed1724f"
        }
    },
    "extract_dir": "dbeaver",
    "bin": [
        [
            "dbeaver.exe",
            "dbeaver-cli.exe"
        ],
        [
            "dbeaver-ea.exe",
            "dbeaver-cli.exe"
        ],
    ],
    "shortcuts": [
        [
            "dbeaver.exe",
            "DBeaver EA"
        ]
    ],
    "checkver": {
        "url": "https://dbeaver.io/files/ea/",
        "regex": "href=\"dbeaver-ce-(?<ver>[\\d.]+)-win32.win32.x86_64.zip\".*	(?<date>\\d{4}
-\\d{2}-\\d{2}) \\d{2}:\\d{2}:\\d{2}	",
        "replace": "${ver}-${date}"
    },
    "autoupdate": {
        "architecture": {
            "64bit": {
                "url": "https://dbeaver.io/files/ea/dbeaver-ce-$matchVer-win32.win32.x86_64.zip"
            }
        }
    }
}
所在位置 C:\Users\123\scoop\apps\scoop\current\libexec\scoop-search.ps1:101 字符: 66
+ ... e]::ReadAllText($_.FullName) | ConvertFrom-Json -ErrorAction Continue
+                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [ConvertFrom-Json], ArgumentException
    + FullyQualifiedErrorId : System.ArgumentException,Microsoft.PowerShell.Commands.ConvertFromJson
   Command

Results from local buckets...

Name       Version              Source   Binaries
----       -------              ------   --------
dbeaver    24.2.5               extras
dbeaver-ea 2024.3-243.21565.212 versions

https://github.com/ScoopInstaller/Versions/commit/ff7b7be5eb4ae5c3184f575191ec7d5011e5d2b9


CI: Adding unit test cases for arista.avd.defined plugin

Change Summary

Add unit test cases for arista.avd.defined plugin

Related Issue(s)
Fixes N/A
Component(s) name
ansible-test
Proposed changes

Added unit tests arista.avd.defined plugin

How to test

Run unit and integration test cases using command
$ ansible-test units OR ansible-test units -vvvv OR ansible-test units --python 3.8

Checklist
User Checklist

N/A

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[] I have updated molecule CI testing accordingly. (check the box if not applicable)

in defined it will never be "undefined" because we have the default "null"
value on the function arguments.
On Fri, Feb 11, 2022 at 4:25 PM Tony Reddy Goda @.***>
wrote:

@.**** commented on this pull request.
In ansible_collections/arista/avd/plugins/test/defined.py
https://github.com/aristanetworks/ansible-avd/pull/1489#discussion_r804754407
:

     elif str(fail_action).lower() == 'error':

         if var_name is not None:
             raise AnsibleError(f"{var_name} was set to {value} but we expected {test_value}!")
         else:
             raise AnsibleError(f"A variable was set to {value} but we expected {test_value}!")

   if run_tests:

       return False, display._warns
   return False

elif str(var_type).lower() in ['float', 'int', 'str', 'list', 'dict', 'tuple', 'bool'] and str(var_type).lower() != type(value).name:

I modified the test as below:
@pytest.mark.parametrize("VALUE", VALUE_LIST)
@pytest.mark.parametrize("VAR_TYPE", VAR_TYPE_LIST)
def test_defined_plugin_var_type_fail_action_None(self, VALUE, VAR_TYPE):
    type_list = ['float', 'int', 'str', 'list', 'dict', 'tuple', 'bool']
    if not isinstance(VALUE, Undefined) and VALUE is not None:
        resp = defined(VALUE, var_type=VAR_TYPE)
        if str(VAR_TYPE).lower() in type_list and type(VALUE).__name__ != str(VAR_TYPE).lower():
            assert resp is False
        else:
            assert resp is True

—
Reply to this email directly, view it on GitHub
https://github.com/aristanetworks/ansible-avd/pull/1489#discussion_r804754407,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALTLO5IXAKLB5AJEVBAOME3U2US5XANCNFSM5N2V3AVQ
.
You are receiving this because your review was requested.Message ID:
@.***>

--
http://t.sidekickopen06.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XYg7fKbwdW3M2q-65v_YVxW643TLH56dGkDdvPMNP02?t=http%3A%2F%2Fwww.arista.com%2F&si=6319566969110528&pi=ac752613-cb17-47a3-cc75-a83c7b19afc2
Software Driven Cloud Networking
http://t.sidekickopen06.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XYg7fKbwdW3M2q-65v_YVxW643TLH56dGkDdvPMNP02?t=https%3A%2F%2Fwww.youtube.com%2Fuser%2FAristaNetworks&si=6319566969110528&pi=ac752613-cb17-47a3-cc75-a83c7b19afc2
http://t.sidekickopen06.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XYg7fKbwdW3M2q-65v_YVxW643TLH56dGkDdvPMNP02?t=https%3A%2F%2Fwww.linkedin.com%2Fcompany%2Farista-networks-inc&si=6319566969110528&pi=ac752613-cb17-47a3-cc75-a83c7b19afc2
http://t.sidekickopen06.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XYg7fKbwdW3M2q-65v_YVxW643TLH56dGkDdvPMNP02?t=https%3A%2F%2Ftwitter.com%2Faristanetworks&si=6319566969110528&pi=ac752613-cb17-47a3-cc75-a83c7b19afc2
https://www.facebook.com/AristaNW/
Claus Holbech
Advanced Services Engineer
e. @.***
m. +45 2516 2109
www.arista.com http://www.arista.com/
Unsubscribe from receiving marketing emails
https://solutions.arista.com/hs/manage-preferences/unsubscribe-simple?via_redirect=true


Implemented webAPI to fetch meanings of word.

The following changes has been done (regarding issue #3 ) : -

A webAPI has been implemented. (https://dictionaryapi.dev/)
'ConnectToService' button is removed as it is not required after implementation of webAPI
App will be able to handle error cases like no internet connection/ spelling mistakes or wrong words

Display of definition of word

Error Handling of wrong word

Happy to know if require any further changes! :)

Great work done 👍!

Thanks!!


Integrating Tailwind CSS for styling easily & more productive

In Bootstrap you can't customize how much radius explicitly in class utility. From this we know that bootstrap has limitation on the utility explicity also it would be hard to implement design guideline because the design guideline have a lot of different sizing and radius px. I think it would be easier if we can implement the design guideline with Tailwind CSS because you can explicitly set the css unit on the class utility and of course we can easily slicing and designing front-end exaclty like on the design gudeline.
See the docs here:
https://tailwindcss.com/docs/font-size#arbitrary-values
What do you think of my thought ? Please let me know.

Hey, understand that tailwind provides great designs but I think plain css is more good and customisable so I recommend using bootstrap only. Bootstrap styles can be overriden by css


Add scaffold for Yunikorn batch scheduler

🛑 Important:
Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!
For guidelines on how to contribute, please review the CONTRIBUTING.md document.
Purpose of this PR
Add an initial scaffold for a Yunikorn batch scheduler implementation. Splitting the PRs so I can incrementally finish work without leaving a mega PR to be reviewed.
Ref https://github.com/kubeflow/spark-operator/issues/2098
Change Category
Indicate the type of change by marking the applicable boxes:

[ ] Bugfix (non-breaking change which fixes an issue)
[x] Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that could affect existing functionality)
[ ] Documentation update

Rationale

Checklist
Before submitting your PR, please review the following:

[x] I have conducted a self-review of my own code.
[x] I have updated documentation accordingly.
[x] I have added tests that prove my changes are effective or that my feature works.
[x] Existing unit tests pass locally with my changes.

Additional Notes
Will close https://github.com/kubeflow/spark-operator/pull/2042 once I've got that functionality merged in separate PRs

@vara-bonthu I'm happy to put everything under one PR with docs, test etc. but thought it might be easier to split the work into separate PRs under this issue to avoid draft PRs sitting around for a while https://github.com/kubeflow/spark-operator/issues/2098

Hi @jacobsalway , this work is great. I have modified the batch scheduler framework in #2072, and we should release v2.0.0-rc.0 soon, so would you mind rebase your work on this new 2.0 version.

Hey @ChenYi015 once your controller runtime PR is merged to release-2.0 I'll rebase and retarget my PR


Android build fails :app:checkDebugDuplicateClasses

Description
Adding rive to a project on RN v0.71.5. The iOS builds fine but Android fails:
[build] Execution failed for task ':app:checkDebugDuplicateClasses'.
[build] > A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
[build]    > Duplicate class kotlin.collections.jdk8.CollectionsJDK8Kt found in modules jetified-kotlin-stdlib-1.8.10 (org.jetbrains.kotlin:kotlin-stdlib:1.8.10) and jetified-kotlin-stdlib-jdk8-1.6.21 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21)
[build]      Duplicate class kotlin.internal.jdk7.JDK7PlatformImplementations found in modules jetified-kotlin-stdlib-1.8.10 (org.jetbrains.kotlin:kotlin-stdlib:1.8.10) and jetified-kotlin-stdlib-jdk7-1.6.21 (org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.21)
[build]      Duplicate class kotlin.internal.jdk7.JDK7PlatformImplementations$ReflectSdkVersion found in modules jetified-kotlin-stdlib-1.8.10 (org.jetbrains.kotlin:kotlin-stdlib:1.8.10) and jetified-kotlin-stdlib-jdk7-1.6.21 (org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.21)

Adding this in the build.gradle fixed the issue:
 implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.8.0") {
        because("kotlin-stdlib-jdk7 is now a part of kotlin-stdlib")
    }
    implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0") {
        because("kotlin-stdlib-jdk8 is now a part of kotlin-stdlib")
    }

I'm experiencing the same issue and I added this but didn't work

Adding this in the build.gradle fixed the issue:
 implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.8.0") {
        because("kotlin-stdlib-jdk7 is now a part of kotlin-stdlib")
    }
    implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0") {
        because("kotlin-stdlib-jdk8 is now a part of kotlin-stdlib")
    }

For ref I'm using expo and this solve my problem
'expo-build-properties',
        {
          android: {
            minSdkVersion: 21,
            compileSdkVersion: 33,
            targetSdkVersion: 33,
            buildToolsVersion: '30.0.3',
            kotlinVersion: '1.8.10', <----- this is here
          },
          ios: {
            deploymentTarget: '14.0',
            useFrameworks: 'static',
          },
        },

@MortadhaFadhlaoui as stated in the documentation here

The Rive React Native runtime does not have support for Expo at this time


Import rev 95381e1892a43a167b0894f583894da2a7067123 of fluxcd/flagger docs

Add nav entries (frontmatter)
Import diagrams and screens - use local images (not hotlink GitHub)
Import redirects too

Addresses: #894
Signed-off-by: Daniel Holbach<EMAIL_ADDRESS>

TODO

[ ] add separate Flagger search
[ ] double-check we caught everything
[ ] Later: replace flagger.app with redirects (we'll have both sites available for some time)

→ https://deploy-preview-903--fluxcd.netlify.app/flagger/

We need to replace Introduction with Flagger

TODO

[ ] add separate Flagger search
[ ] decide on where else to place Flagger in nav
add Flagger main page, use 'intro' for docs content, adjust links
[x] on /flagger show flagger logo in top nav (top left) (need help)
[ ] double-check we caught everything
[ ] Redesign fluxcd.io/flagger page - integrate bits from https://flagger.app/ (I'll need help with this - probably later?)
[ ] Later: replace flagger.app with redirects (we'll have both sites available for some time)