Discussion: Visibility enum vs. IsVisible bool

Is your feature request related to a problem? Please describe.
All other XAML-based frameworks (WPF, UWP, WinUI) use an enum to set the visibility of a control. In the interest of code-compatiblity, should Avalonia support this enum as well?
In WPF:
public Visibility UIElement.Visibility

public enum Visibility
{
  Visible,   // Display the element
  Hidden,    // Do not display the element, but reserve space for the element in layout.
  Collapsed  // Do not display the element, and do not reserve space for it in layout.
}

In UWP/WinUI:
public Visibility UIElement.Visibility

public enum Visibility
{
  Visible,
  Collapsed
}

As can be seen, UWP dropped support for the Hidden value. I would guess Hidden wasn't used much in real-world apps to warrant it being carried over from WPF. This means, in UWP, the property is equivalent to a bool which is what Avalonia has done from the beginning:
Avalonia:
public bool Control.IsVisible

Describe the solution you'd like
Control visibility, like DependencyProperty, is one of the subtle changes that creates significant headache using Avalonia from existing windows code. It necessitates creating a lot of conditional code in places where clean MVVM isn't already used (in that case only the converters change). It can affect nearly every part of the UI. It would be great to discuss some solutions:

Adding Control.Visiblity and the corresponding enum to Avalonia could be done in some proposed compatiblity layers using something like an attached property. This would mitigate concerns with having two properties that do the same thing in Avalonia itself.
IsVisible could be removed from Avalonia and replaced with the WinUI equivalent -- which is a lot of breaking changes for existing Avalonia code.
If IsVisible is removed from Avalonia as it exists now, it could be replaced with the get-only property of the same name from WPF UIElement.IsVisible. WPF's property tells applications if a control is actually visible in the UI. This, along with its corresponding event, is especially useful to tracks when items are scrolled out of view for example.

Describe alternatives you've considered
The alternative is simply to use Avalonia's existing convention.
Additional context
Originally discussed here but broken up into separate issue.

@grokys Commented here

I don't know how deep we could go with this, for example I don't really want to support both the Visibility enum and IsVisible property as that would be confusing. Maybe some concept of "attached properties" in XAML would help here in XAML but that's not going to help in code until C# adds attached properties.

WPF's IsVisible is a PITA because it means that you can't simply bind to a boolean, even though most of the time you have one. In addition, Avalonia has the ! binding operator which makes it easy to manipulate booleans. In UWP it's even more annoying because Visibility is a boolean state.
So I think Avalonia's choice to use a bool IsVisible property is the right one. What remains is the compatibility problem. Regarding the alternatives you mentioned:

An "attached property": would be ideal, but this means we'd have to design and implement that feature.
Removing IsVisible I don't like for the reason you mention and the reasons outlined above

Another alternative is to have both IsVisible and Visibility. The problem with that is potential user confusion and deciding what happens if both get set.

WPF's IsVisible is a PITA because it means that you can't simply bind to a boolean, even though most of the time you have one. In addition, Avalonia has the ! binding operator which makes it easy to manipulate booleans. In UWP it's even more annoying because Visibility is a boolean state.

Agree with the sentiment. I guess the first question is: should Hidden ever be supported? The answer everyone has decided on in the past 10 years is no, it's unnecessary. This means there is no reason it MUST be an enum as it is only two logical states -- so agree with you again.
Using the enum does add some complexity but BoolToVisiblity is a standard converter these days. Since the Visibility in UWP IS a boolean state as you mentioned it is also possible to automatically map to a bool during XAML compilation and remove the need for a converter.

So I think Avalonia's choice to use a bool IsVisible property is the right one. What remains is the compatibility problem. Regarding the alternatives you mentioned:
Removing IsVisible I don't like for the reason you mention and the reasons outlined above

An additional problem aside from a boolean is the name of the property itself. What is Avalonia's plan for an equivalent property to WPF's IsVisible? That is a point of confusion as well for those coming over from that framework. A property of the same name does something different. It is also a missing feature in Avalonia.

Another alternative is to have both IsVisible and Visibility. The problem with that is potential user confusion and deciding what happens if both get set.

Another idea I heard was to add both, but mark Visibility as [Obsolete]. In terms of what happens if both get set, this isn't possible I think? The UI and dependency property system is single threaded and the last property set will apply. Perhaps you mean the circular dependency problem?

An additional problem aside from a boolean is the name of the property itself. What is Avalonia's plan for an equivalent property to WPF's IsVisible?

UIElement.IsVisible isn't present in UWP and personally I've never needed it in WPF, so I don't think it's that important.

The UI and dependency property system is single threaded and the last property set will apply.

IsVisible is a styled property and Visibility probably would have to be as well. This means that the properties have priorities. Combining priorities with two properties that do the same thing could be tricky.

UIElement.IsVisible isn't present in UWP and personally I've never needed it in WPF, so I don't think it's that important.

It has been requested to add this to WinUI https://github.com/microsoft/microsoft-ui-xaml/issues/674. A lot of more advanced cases could use this (especially considering x:Load isn't in Avalonia right now). Granted the cases where it's needed are not simple apps but places where performance is critical. I wouldn't underestimate the long-term need of an equivalent for this in Avalonia based on personal need.

WPF has always had a read-only bool UIElement.IsVisible link and an event IsVisibleChanged link that allowed control developers to effectively stop/pause unnecessary work if a control isn't visibly active. Like stop an animation, pause DirectX rendering etc, and not waste battery at that point in time.

IsVisible is a styled property and Visibility probably would have to be as well. This means that the properties have priorities. Combining priorities with two properties that do the same thing could be tricky.

Interesting, I am not familiar with this concept and don't believe it exists in WPF/UWP. If there is documentation on how this works I would be curious to read up on it.

@robloo how x:Load is related to WPF.IsVisible? First is about control presence in the visual tree, and second is  more about rendering state (is it actually rendered or not).
Indeed, x:Load is important for performance critical applications, where you can delay loading huge parts of the visual tree, or reuse complex components that might manage their children according to the input parameters (so x:Load should also work with bindings in ideal).
I am not sure where WPF.IsVisible may help in similar way. First point that I see is lists, but virtualization should be used there. In my personal experience I have a need for that property only for resize images lazily, when they are actually rendered, but that problem was solved with proper lists virtualization. Alternatively it could be solved with better Image control implementation.
Anyway, WPF naming here isn't really ideal either. In the WinUI discussion there are better proposals such as IsCurrentlyRendered.

Also if x:Load can replace WPF.IsVisible in some cases, it should be easier to implement (assuming that we would like to avoid breaking changes with IsVisible/Visibility props).

how x:Load is related to WPF.IsVisible?

Perhaps I didn't word that very well. As you said, x:Load cannot replace IsVisible in most cases. However, it is useful to lazily load the UI. This can be used in place of the VisibilityChanged event and IsVisible=true check before starting up some more performance-intensive parts of the UI. Again, this is relevant in cases like scrolling or when switching between views. When you discover you need this type of performance optimization you really need it. Granted most apps aren't doing something this intensive.

Anyway, WPF naming here isn't really ideal either. In the WinUI discussion there are better proposals such as IsCurrentlyRendered.

Agree a better name could be found. Compatiblity would then be a concern but much less of one since this property is used much less in actual code.

Also an interesting quote from one of Microsoft's own devs that worked on WPF I believe and is still involved in WinUI. Just some history on Hidden that validates a two-state bool property is actually the best decision.

WPF's Visibility has three states to match the HTML behavior of both display:none (Visibility.Collapsed) and visibility:hidden (Visibility.Hidden). Visibility.Hidden has generally been considered a mistake because you can get the same thing by setting the Opacity to 0, and because the enum is more difficult to work with than a bool.
https://github.com/microsoft/microsoft-ui-xaml/issues/674#issuecomment-520527816

We might want to somehow extend the property system to have "proxy" properties that aren't don't have their own storage and just map to another property with converter applied. If we've had something like that, adding an [Obsolete] Visibility property would be trivial.

You could use corce callback.

We might want to somehow extend the property system to have "proxy" properties that aren't don't have their own storage and just map to another property with converter applied. If we've had something like that, adding an [Obsolete] Visibility property would be trivial.

This would definitely be the safest approach. Managing a property like this without a single source of truth can open up a lot of unforeseen problems or complications. This idea may also be general-purpose enough to use in other scenarios not yet discussed. I'm not sure if anyone has an idea in mind of how to implement this type of proxy property though?

Just an idea below. An IValueProvider could be provided during construction of a PropertyMetadata class within a Styled/DirectProperty just like a coercion callback is.
Also, coercion should apply:

Before SetValue is invoked
After GetValue is invoked

public interface IValueProvider<T>
{
  public T GetValue(...);
  public void SetValue(T value, ...);
}

// Default implementation
public class ValueProvider<T> : IValueProvider<T>
{
  public Action<T> SetValueAction { get; set; }
  public Func<T> GetValueAction { get; set; }

  public T GetValue()
  {
    return (GetValueAction != null ? GetValueAction.Invoke() : default(T));
  }

  public void SetValue(T value)
  {
    SetValueAction?.Invoke(value);
  }
}

The above is just an idea to keep the discussion moving. Changing the signatures to something more like coercion has right now should be considered.

Would someone be kind enough to move this to Discussions?


md-nav-tab-bar tabbing only works in Chrome

Bug, feature request, or proposal:
Bug
What is the expected behavior?
I can tab through the md-nav-tab-bar in every browser.
What is the current behavior?
Only works or shows active selection for Chrome. Firefox, IE and Safari don't allow tabbing through the navigation at all.
What are the steps to reproduce?
See Plunker here:
https://plnkr.co/edit/xTTrFjlWeDe7sRYb11Qm?p=preview
What is the use-case or motivation for changing an existing behavior?
Makes it easier to navigate for a user.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Browsers: Firefox, IE and Safari
OS: Mac and Windows (7|8|10)
Material Version: (2.0.0-beta.5)
Angular Version: 2 and 4

@SargoDarya Your Plunker doesn't work in either Firefox or Chrome. Can you make it work (again)?

@donroyco Sorry, had the wrong template probably. I recreated the plnkr using the current template and updated the link in the original description and for convencience here: http://plnkr.co/edit/o077B6uEiiIgkC0S06dd?p=preview

Weird thing, with the new one it doesn't even work in chrome. Is this intended?

Can you use this template? https://goo.gl/DlHd6U

@donroyco Sure thing. I'm changing the links.
http://plnkr.co/edit/YRvtThQQ8COoOflbyMxu?p=preview

The tabbing doesn't work in the plunker because routerLink isn't being run for real. The routerLink directive applies an href to the <a> element, which causes it to be tabbable. See this non-Angular example.


Add support for sessions

See https://github.com/rob-luke/fnirs-apps-quality-reports/commit/164b860066023d2905240c9818b9b282ae033b8a

Fixed in 85357a5710d8f34eea128e0418714d41222de2e3


flutter upgrade version

Flutter Upgrade from scratch

Flutter Version Upgrade
New version code changes
Android files changes
Package upgrade
Android kotlin version upgrade

please check it and merge @YC

Hi @bhargavraviya, thanks for opening the PR.
While I agree with most of the changes, I would prefer to not review nor accept this as one single PR, given that it touches multiple separate concerns at once (e.g. refactoring, removal of ios, changes to android packaging, changes to flutter packages).
If you're okay with splitting this into multiple PRs, I'd be more than happy to review them separately.
Otherwise, I'd be happy to integrate your changes through a set of commits (giving you credit for the changes as co-contributor).
Happy to discuss further!

Thanks again.
Moving reviews to #15 and #16.


Actions and menu items on the UI are not localized

VSCode Version: Code - Insiders 1.3.0-insider (a2b9738a942237b59cb920940b93a0206f1b61d0, 2016-07-01T19:24:33.352Z)
OS Version: Linux x64 4.4.0-28-generic, Ubuntu 16.04

Actions that are surfaced through the UI should be localized. Many seem to have been overlooked.
Here's an example (--locale=ko):
English x2 in command palette:

Korean translations in menu:

Here's another one in the search viewlet, all title attributes feature English:

I think we just have not yet made a NLS input.

That is true. I did an input on Friday and it takes a week to get them localized. In general our statement is that Insider and Milestones builds partly show English strings because of the time delay of localization.
Moving to @sandy081 to ensure that the strings are proper localized. If so please close.

All strings are properly localized, once we have nls build we can see locale specific strings.


Fix 125: Fix splitting words with uppercase

Fixing issue #125

We definitely need to merge this! 👏

LGTM, thanks for the fix @hullarb!


[Doc enhancement][Restructure-apptemplates]

Please review.

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
132
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit cd6b4a1:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:warning:Warning
View
Details

msteams-platform/samples/virtual-assistant.md
:warning:Warning
View
Details

msteams-platform/samples/app-templates.md

Line 95, Column 1: [Warning-invalid-row] Row has some invalid chars in the ending.
Line 141, Column 3: [Warning-table-syntax-invalid] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 174, Column 1: [Warning-table-syntax-invalid] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

msteams-platform/samples/virtual-assistant.md

Line 580, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#book-a-room' in 'samples/app-templates.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
83
134
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 230a4d1:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:warning:Warning
View
Details

msteams-platform/samples/virtual-assistant.md
:warning:Warning
View
Details

msteams-platform/samples/app-templates.md

Line 95, Column 1: [Warning-invalid-row] Row has some invalid chars in the ending.

msteams-platform/samples/virtual-assistant.md

Line 580, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#book-a-room' in 'samples/app-templates.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
83
134
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 578beb9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
142
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 7f95047:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
142
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 65d9eb7:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/samples/virtual-assistant.md
:warning:Warning
View
Details

msteams-platform/samples/app-templates.md
:bulb:Suggestion
View
Details

msteams-platform/samples/virtual-assistant.md

Line 580, Column 3: [Warning-file-not-found] Invalid file link: 'app-templates.md/'.

msteams-platform/samples/app-templates.md

Line 113, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
142
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 575be29:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:bulb:Suggestion
View
Details

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md

Line 113, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit ae04a1a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:bulb:Suggestion
View
Details

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md

Line 113, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
142
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 17f5ddb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
95
27
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
142
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 66533e8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:bulb:Suggestion
View
Details

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md

Line 115, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit a2707f2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
83
149
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
83
149
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 6e8353e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
83
149
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 75ff7db:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
142
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 7e453f9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:bulb:Suggestion
View
Details

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md

Line 115, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
142
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit ec7e51d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:bulb:Suggestion
View
Details

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md

Line 115, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
112
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 1649c2a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:bulb:Suggestion
View
Details

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md

Line 115, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 5a00f31:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:bulb:Suggestion
View
Details

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md

Line 115, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
112
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 1b3b43f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/samples/virtual-assistant.md
:warning:Warning
View
Details

msteams-platform/samples/app-templates.md
:bulb:Suggestion
View
Details

msteams-platform/samples/virtual-assistant.md

Line 580, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#app-template-code-samples' in 'samples/app-templates.md'.

msteams-platform/samples/app-templates.md

Line 113, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
112
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
95
27
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 4a833ee:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:warning:Warning
View
Details

msteams-platform/samples/virtual-assistant.md
:warning:Warning
View
Details

msteams-platform/samples/app-templates.md

Line 111, Column 3: [Warning-table-syntax-invalid] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

msteams-platform/samples/virtual-assistant.md

Line 580, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#app-template-code-samples' in 'samples/app-templates.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
112
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 02beb16:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/samples/virtual-assistant.md
:warning:Warning
View
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md

Line 580, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#app-template-code-samples' in 'samples/app-templates.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
112
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 42f6f3d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/samples/virtual-assistant.md
:warning:Warning
View
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md

Line 580, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#app-template-code-samples' in 'samples/app-templates.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
112
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit fd794c1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
112
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 11fcc07:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
112
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 599f99f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
112
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit bde517b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
83
113
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 58163de:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f6bb246:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
113
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit f492a7d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
113
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
56
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Hi @shridharp-ms,
Could you please confirm the changes and approve the PR.

@v-abirade I havent yet got confirmation from Dominic to go ahead, please keep it on hold

@v-abirade I havent yet got confirmation from Dominic to go ahead, please keep it on hold

Thanks for the update.

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/app-templates.md
84
110
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
83
52
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 15e0c67:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/samples/virtual-assistant.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Update de.json for "Hide Disabled Effects"

Perfect, thank you. I was going to reach out but you got there first. :)


Use LORA's or Hypernet's

First of, amazing extention, loads of fun playing with it!
I came to wonder though, if it would be possible to use LORA's with it, as for example:
[<lora:someLora_v2:.6>:somekeyword:0,10]
However it won't affect generation, the lora remains enabled throughout.
I'm wondering whether it is the extra :, since it works with Textual Inversions or if LORA's simply can't be turned on/off.
I have tried to use it as variable to get rid of the :, but then again, that could be parsed before it reaches the fusion stage.
Thanks, cheers and good fortune to every reader <3

@Syncriix @caphalorthrow I just stumbled on this: https://github.com/a2569875/stable-diffusion-webui-composable-lora
Have a look at the readme, it seems they allow to interpolate lora weights through sampling steps. Their syntax is quite comprehensive, although it may be a bit hard to get the hang of it IMO. Maybe a good place to start for you guys.

I managed to hack the composable lora extension and prompt fusion to sort of work together; it's really awful code though.
Basically I patched composable lora to check if prompt fusion exists and then uses importlib magic to get references to _parse_tensor_builders and _get_flattened prompts so that composable lora can see the "expanded" prompts that prompt fusion creates. This allows me to use [lyco:xyz:1:0.5] instead of being forced to specify steps "manually"
I feel like this should be a lot easier if prompt fusion did its prompt expansion bit earlier, but I guess that might be difficult to implement given that A1111's internal architecture is very messy, to put it lightly.

Nice work! One way to implement this directly in prompt fusion seems to be to hijack the lora implementation ourselves and use the parsed prompts to infer the weight to apply to the lora file at each step.

I feel like this should be a lot easier if prompt fusion did its prompt expansion bit earlier

Prompt fusion will generate an exponential number of prompts depending on how many interpolations there are, which could be confusing for some scripts as usually len(p.all_prompts) == p.batch_size * p.n_iter. I think there needs to be a secondary hijack that deals with the lora parsing in isolation. Feel free to open a PR if you figure it out, I'll be glad to review!

If I understand the discussion, the extension https://github.com/cheald/sd-webui-loractl does this dynamic weighting, it's very useful and I use it all the time.


Set CP XYZ value to the value when it is created

Currently, the game gets the CP's XYZ value every frame, which changes a lot due to the CP eye bobbing up and down. Instead, get the XYZ value when the CP is created, to prevent networking so much useless data to clients every tick. If you want to have the arrows bob, do that clientsided.

Fixed


Add Treadmill and KRB5Keytab-proxy to Treadmill RPM

@andreikeis @ceache Ready for review.

Sorry, I missed the services-install.yaml in the build. Closing.


Support for Garena servers

is it possible for the observer tool to grab match info from Garena server games, now that the Riot API for these regions has shut down?

al

yea, that's odd indeed, since the pick ban ui picked up the League Client just fine. I ran both of them with administrator privilege, but the observer tool didn't work.

Did you use the current version of the pick ban UI? With some recent updates, both the P&B UI and the observer tool use the same library to connect to LCU. If you were using an older version, there may be an issue with the new library and Garena.

I have same problem. The current version of the pick ban UI still working, but observer tool is not. Is it related to port connection?

I can‘t open the open setting,

I can‘t open the open setting,
Please open a new issue if you have a question. #5 should have the path to edit the settings file directly.


libopenblas.so.0.3: undefined reference to `gotoblas_NEOVERSEN2' 0.3.23

During the build on Ubuntu 18.04LTS aarch64, I get the following error:
[ 89%] Linking C executable openblas_utest
../lib/libopenblas.so.0.3: undefined reference to `gotoblas_NEOVERSEN2'
../lib/libopenblas.so.0.3: undefined reference to `gotoblas_NEOVERSEV1'
collect2: error: ld returned 1 exit status
utest/CMakeFiles/openblas_utest.dir/build.make:407: recipe for target 'utest/openblas_utest' failed
make[2]: *** [utest/openblas_utest] Error 1
CMakeFiles/Makefile2:1048: recipe for target 'utest/CMakeFiles/openblas_utest.dir/all' failed
make[1]: *** [utest/CMakeFiles/openblas_utest.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2
torel@n005:~/workspace/OpenBLAS/0.3.23/OpenBLAS-0.3.23/Build-aarch64$

OS:
torel@n005:~/workspace/OpenBLAS/0.3.23/OpenBLAS-0.3.23/Build-aarch64$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.6 LTS
Release:	18.04
Codename:	bionic

Commandline:
cmake .. -DCMAKE_INSTALL_PREFIX=/cm/shared/apps/openblas/dynamic/0.3.23 -DBUILD_SHARED_LIBS=ON -DBINARY=64 -DDYNAMIC_ARCH=1 -DUSE_THREAD=1
Error:
[100%] Building Fortran object lapack-netlib/TESTING/LIN/CMakeFiles/xlintstc.dir/slaord.f.o
[100%] Linking Fortran executable xlintsts
[100%] Linking Fortran executable xlintstz
[100%] Linking Fortran executable xeigtstd
../../../lib/libopenblas.so.0.3: undefined reference to `gotoblas_NEOVERSEN2'
../../../lib/libopenblas.so.0.3: undefined reference to `gotoblas_NEOVERSEV1'
collect2: error: ld returned 1 exit status
lapack-netlib/TESTING/LIN/CMakeFiles/xlintsts.dir/build.make:4463: recipe for target 'lapack-netlib/TESTING/LIN/xlintsts' failed
make[2]: *** [lapack-netlib/TESTING/LIN/xlintsts] Error 1
CMakeFiles/Makefile2:1904: recipe for target 'lapack-netlib/TESTING/LIN/CMakeFiles/xlintsts.dir/all' failed
make[1]: *** [lapack-netlib/TESTING/LIN/CMakeFiles/xlintsts.dir/all] Error 2
../../../lib/libopenblas.so.0.3: undefined reference to `gotoblas_NEOVERSEN2'
../../../lib/libopenblas.so.0.3: undefined reference to `gotoblas_NEOVERSEV1'
collect2: error: ld returned 1 exit status
lapack-netlib/TESTING/LIN/CMakeFiles/xlintstz.dir/build.make:5217: recipe for target 'lapack-netlib/TESTING/LIN/xlintstz' failed
make[2]: *** [lapack-netlib/TESTING/LIN/xlintstz] Error 1
CMakeFiles/Makefile2:1828: recipe for target 'lapack-netlib/TESTING/LIN/CMakeFiles/xlintstz.dir/all' failed
make[1]: *** [lapack-netlib/TESTING/LIN/CMakeFiles/xlintstz.dir/all] Error 2
../../../lib/libopenblas.so.0.3: undefined reference to `gotoblas_NEOVERSEN2'
../../../lib/libopenblas.so.0.3: undefined reference to `gotoblas_NEOVERSEV1'
collect2: error: ld returned 1 exit status
lapack-netlib/TESTING/EIG/CMakeFiles/xeigtstd.dir/build.make:2773: recipe for target 'lapack-netlib/TESTING/EIG/xeigtstd' failed
make[2]: *** [lapack-netlib/TESTING/EIG/xeigtstd] Error 1
CMakeFiles/Makefile2:2118: recipe for target 'lapack-netlib/TESTING/EIG/CMakeFiles/xeigtstd.dir/all' failed
make[1]: *** [lapack-netlib/TESTING/EIG/CMakeFiles/xeigtstd.dir/all] Error 2
[100%] Linking Fortran executable xlintstc
../../../lib/libopenblas.so.0.3: undefined reference to `gotoblas_NEOVERSEN2'
../../../lib/libopenblas.so.0.3: undefined reference to `gotoblas_NEOVERSEV1'
collect2: error: ld returned 1 exit status
lapack-netlib/TESTING/LIN/CMakeFiles/xlintstc.dir/build.make:5217: recipe for target 'lapack-netlib/TESTING/LIN/xlintstc' failed
make[2]: *** [lapack-netlib/TESTING/LIN/xlintstc] Error 1
CMakeFiles/Makefile2:1638: recipe for target 'lapack-netlib/TESTING/LIN/CMakeFiles/xlintstc.dir/all' failed
make[1]: *** [lapack-netlib/TESTING/LIN/CMakeFiles/xlintstc.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2
torel@n005:~/workspace/OpenBLAS/0.3.23/OpenBLAS-0.3.23/Build-aarch64$

Any suggestions?

The list of affected kernels suggests it is because your compiler does not support SVE instructions - they should have been automatically dropped from the list (definitely are when building with "make"), looks like there is an error in one of our cmake scripts

Ah, CMAKE builds still rely on a compiler version check instead of checking for NO_SVE like the rest of the code :/
Can you please try replacing line 48 in file cmake/arch.cmake
https://github.com/xianyi/OpenBLAS/blob/4d0b7fbec04c95c90291938a5974f00673e10e68/cmake/arch.cmake#L48
with a simple if (NOT NO_SVE) ? Maybe you have a new enough compiler but too old assembler (binutils) for SVE

If you want to have fast package for Neoverse CPU either:
Please read EOL notice and consider upgrading:
https://ubuntu.com//blog/18-04-end-of-standard-support
While no new builds will be provided old "testing" packages for much newer gcc than default are here:
https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test?field.series_filter=bionic


Custom Radio's Active State Not Removed Using Keyboard

When using keyboard navigation, the active state of the custom-control-indicator is set upon pressing space. Not sure if the lighter color behavior is intended on space press, but regardless when you move away from the button it leaves it 'active' and the color stays.

Can't reproduce, so closing. Tabbing to the first radio and hitting space checks the radio, and using left/right arrow keys moves the focus and check across each radio.


Doesn't handle exceptions when writing status to the influx

I am using an internal URL to my influx DB. It's available only for Jenkins slaves.
When I am trying to run the scenario locally, it crashes.
I have the solution/fix, but I don't have right to create pull request.

We will take the task to work, but if you have a solution, you can make a PR from a fork


Generating Routes

Hi yii2mod team,
Thank you for this extension.
I have a query and was unable to find a solution on my own. I am using your extension in the Yii 2 Advance template, for my backend application.
I do not have modules in my backend and it should just list all the actions from the controllers eg SiteController but it going to my vendor directory and fetching actions from the gridview extension i am using.
Can you guide me how I can configure it to get the correct actions.
Regards,
Wenceslaus Dsilva

Also, can you tell me what the routes are used for, like does it create permissions by going to each module controller action

How do you configure your app? Can you please show your configuration for rbac here?

Here is the configuration for your module
 'modules'=>[ 'rbac' => [             'class' => 'yii2mod\rbac\Module', //            'as access' => [ //                'class' => AccessControl::className() //            ],             // Some controller property maybe need to change.             'controllerMap' => [                 'assignment' => [                     'class' => 'yii2mod\rbac\controllers\AssignmentController',                     'userIdentityClass' => 'common\models\Admin',                     'searchClass' => [                         'class' => 'yii2mod\rbac\models\search\AssignmentSearch',                         'pageSize' => 10,                     ],                     'idField' => 'id',                     'usernameField' => 'username',                     'gridViewColumns' => [                         'id',                         'username',                         'email'                     ]                 ],                 'role' => [                     'class' => 'yii2mod\rbac\controllers\RoleController',                     'searchClass' => [                         'class' => 'yii2mod\rbac\models\search\AuthItemSearch',                         'pageSize' => 10,                     ],                 ],                 'rule' => [                     'class' => 'yii2mod\rbac\controllers\RuleController',                     'searchClass' => [                         'class' => 'yii2mod\rbac\models\search\BizRuleSearch',                         'pageSize' => 10                     ],                 ],                 'route' => [                     'class' => 'yii2mod\rbac\controllers\RouteController',                     // for example: exclude `api, debug and gii` modules from list of routes                     'modelClass' => [                         'class' => 'yii2mod\rbac\models\RouteModel',                         'excludeModules' => ['debug', 'gii', 'gridview', 'dynagrid', 'datecontrol'],                     ],                 ],             ]         ], ..... ], 'components'=>[ 'authManager' => [             'class' => 'yii\rbac\DbManager',             'itemTable' => '{{%admin_auth_item}}',             'itemChildTable' => '{{%admin_auth_item_child}}',             'assignmentTable' => '{{%admin_auth_assignment}}',             'ruleTable' => '{{%admin_auth_rule}}',             'defaultRoles' => ['guest', 'user', 'admin'],         ], 'as access' => [             'class' => yii2mod\rbac\filters\AccessControl::class,             'allowActions' => [ //            '/rbac/route', //            '/user/login',                 // The actions listed here will be allowed to everyone including guests.                 // So, 'admin/*' should not appear here in the production, of course.                 // But in the earlier stages of your development, you may probably want to                 // add a lot of actions here until you finally completed setting up rbac,                 // otherwise you may not even take a first step.             ]         ], ...... ]

Also, can you tell me what the routes are used for, like does it create permissions by going to each module controller action

Routes allows you to skip configurations like this
[
    'allow' => true,
    'actions' => ['login', 'signup', 'request-password-reset', 'password-reset'],
    'roles' => ['?'],
],

You need to assign routes to permissions and assign permissions to roles. For example

Cool, Cause i was thinking if it can generate the routes for me through the gui then i dont need to write the migrations for the same if that's the case I shall do it the way you suggested

Yes, you're right


Revert "link updates - remove trailing slash"

Reverts dfinity/portal#182
#182 broke the search function & some of the client side routing

Closing as I don't want to revert all changes - just trailing flag setting. All else work. Revert in PR


[MM-35176] Fixing banner times

Summary
Fixing an issue where the announcement banner time won't match the trial card

/update-branch

@sbishel Is this bug fix needed for v5.35, or the fix version doesn't matter?

@sbishel Is this bug fix needed for v5.35, or the fix version doesn't matter?

I would like to put it in v5.35 if possible?

@BenCookie95 - Could you add the ticket to the description.
If  @furqanmlk - Would you have time to test this quickly. Then we can get it in, but otherwise it can wait for v5.36.

@BenCookie95 - Could you add the ticket to the description.
If @furqanmlk - Would you have time to test this quickly. Then we can get it in, but otherwise it can wait for v5.36.

Sure I am testing now

Cherry pick is scheduled.

/cherry-pick cloud

Cherry pick is scheduled.


[snackager] Add missing externals for @sentry/react-native

Why
<EMAIL_ADDRESS>contains some imports to React Native internals, we need to externalize that to make it bundle in snackager.
How

Ran yarn bundle "<EMAIL_ADDRESS>| yarn bundle locally
Opened the temporary folder and searched for require('react-native
Added found imports to Snack Snackager externals
Added found imports to Snack Runtime aliases
Reran yarn bundle "<EMAIL_ADDRESS>| yarn bundle locally to validate

Test Plan
See if CI passes and staging can bundle<EMAIL_ADDRESS>

Bundle test: https://github.com/expo/snack/runs/7411287031?check_suite_focus=true


Render topics using GOV.UK's breadcrumb component

Changing the way of rendering a topic from an enumerated list of more
specific categories to rendering it like "A > B > C", in the same way
breadcrumb trails are used to show web page path ways to users in other
parts of GOV.UK.

Ah... I hadn't noticed that.  I've fixed it so that the breadcrumbs will use font size 19 instead of the default 16 it would normally use.


Not able to interact with the elements not visible in the form or page even after UCITestMode is set to true

Hi @TYLEROL
We are not able to set / get the value of the field which is not visible on the form (sections below the visible screen) even after setting the UCITestMode to true.
In Testsetting file , we use like below
    public static BrowserOptions Options = new BrowserOptions
    {
        BrowserType = (BrowserType)Enum.Parse(typeof(BrowserType), Type),
        PrivateMode = true,
        FireEvents = true,
        Headless = false,
        UserAgent = false,
        UCITestMode = true,
        UCIPerformanceMode = false
    };

Please note that ,in the XrmApp.Login() method, We have the  @_client.InitializeModes(, where this method uses UCITestMode, that is set as true.
We already referred Easyrepro Issues #489 and #631 and created this issue, considering that even after setting the UCITestMode to true, not able to interact with the elements.
Note: We are using Easyrepro Framework 9.0(NugetSpecs)

Facing the same issue, until last Friday easyrepro was interacting with the elements which were not visible, but suddenly tests have started to fail.

Please let us know when the fix will be available for this issue ?

After getting the latest version of easyrepro UCI library, the issue got resolved.

The issue is resolved after updating with the latest version of UCI Easyrepro library.

I have latest version - <IP_ADDRESS>021. Still i face the issue(unable to find elements not visible, though UCITesMode is true). What version should i upgrade or downgrade to make it work.


Cannot git clone current HEAD

Hello,
i just tried cloning with the following result:
git clone https://github.com/oney/react-native-webrtc.git
Cloning into 'react-native-webrtc'...
remote: Counting objects: 1159, done.
remote: Compressing objects: 100% (39/39), done.
remote: Total 1159 (delta 16), reused 0 (delta 0), pack-reused 1119
Receiving objects: 100% (1159/1159), 38.36 MiB | 730.00 KiB/s, done.
Resolving deltas: 100% (548/548), done.
Checking connectivity... done.
git-lfs smudge 'android/libs/libjingle_peerconnection.so.jar': git-lfs: command not found
error: external filter git-lfs smudge %f failed -1
error: external filter git-lfs smudge %f failed
fatal: android/libs/libjingle_peerconnection.so.jar: smudge filter lfs failed
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'
Is it just me or is there something wrong inside?

git-lfs: command not found

have you install git-lfs locally?
if not, follow the readme in prerequisite section to install it first then try again

Perdon! - was new to me!

no worries, all were new to me, too :smile:

0.13.0 have get rid of annoying git-lfs already.
my bad for using git-lfs in it's so early stage.


MM-14378 Adding configuration to enable release of helm charts with chart-releaser

Ticket -> https://mattermost.atlassian.net/browse/MM-14378

@cpanato @stylianosrigas feel free to merge

ok lets merge and see how it goes 🦀


Align file all navigation buttons

Close #5347

Test URLs
https://github.com/dotnet/runtime/tree/09ff1acdad2e7789908b5db9bb89896144c13042/src/libraries/Microsoft.VisualBasic.Core
Before

After

This works and should avoid this issue forever and for all other extensions, but ideally I'd want to see https://github.com/refined-github/refined-github/pull/4236 again because it's also avoids overflows in some cases.


Update .clang-format

Remote duplication of ContinuationIndentWidth

I've merged you PR.  Thank you.


Issue with predict.py utput

The output of the command /af2_initial_guess/predict.py -silent my_designs.silent still retains a glycine backbone for the binder.
Could you please provide a solution to address this issue?

You might be using the RFDiffusion output for input to predict.py.
If you run dl_binder_design/mpnn_fr/dl_interface_design.py first on your RFDiffusion output, then you will produce a new set of pdbs that have the ProteinMPNN sequences threaded onto the RFDiffusion backbone. These are the structures that you want to provide to predicty.py.


Unable to make ljpeg file

I cloned this repo, then tried to execute this command
cd jpegdir; make
And got this error

c  -O3  jpeg.o codec.o huffman.o io.o chendct.o leedct.o lexer.o marker.o stream.o transform.o -lm -o jpeg stream.o: file not recognized: File format not recognized collect2: error: ld returned 1 exit status makefile:30: recipe for target 'jpeg' failed make: *** [jpeg] Error 1

the same error. have you solved it?


Tdr 2262 fix login page issue

Show a page with a message and a link "Continue to homepage" when the user is already logged in.

Looks good. One minor comment.
I've created an exploratory testing card for this as well: https://national-archives.atlassian.net/browse/TDR-2386 If you could add some testing instructions to it that would be great.
As this issue is user facing, it would be good to double check the functionality before releasing to production.

Right, I will add some scenarios.


openssh-password: add tests for ssh login with password

Description of changes
New regression tests for openssh. Tests to log-in with password.
Sadly some openssh nixpkgs features seem to be broken and therefore some tests are commented out - please fix the features to enable the corresponding tests afterwards.
PermitEmptyPasswords = "yes" seems to be bad.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Commits should probably be squashed, see https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions


reduce deps

Codecov Report
Attention: Patch coverage is 1.28205% with 77 lines in your changes missing coverage. Please review.

Project coverage is 31.60%. Comparing base (6d0cbcf) to head (e445167).
Report is 2 commits behind head on master.

Files with missing lines
Patch %
Lines

lib/g3-fluentd/src/config/mod.rs
0.00%
38 Missing :warning:

lib/g3-daemon/src/log/event/config.rs
0.00%
19 Missing :warning:

lib/g3-fluentd/src/config/yaml.rs
0.00%
8 Missing :warning:

lib/g3-types/src/net/rustls/client.rs
0.00%
2 Missing :warning:

lib/g3-types/src/net/rustls/server.rs
0.00%
2 Missing :warning:

lib/g3-geoip-db/src/vendor/ipinfo.rs
0.00%
1 Missing :warning:

lib/g3-h2/src/ext/response.rs
0.00%
1 Missing :warning:

lib/g3-json/src/value/resolve.rs
0.00%
1 Missing :warning:

lib/g3-resolver/src/resolver.rs
0.00%
1 Missing :warning:

lib/g3-runtime/src/unaided.rs
0.00%
1 Missing :warning:

... and 3 more

:exclamation:  There is a different number of reports uploaded between BASE (6d0cbcf) and HEAD (e445167). Click for more details.
HEAD has 2 uploads less than BASE

Flag
BASE (6d0cbcf)
HEAD (e445167)

lib
1
0

g3proxy
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #428       +/-   ##
===========================================
- Coverage   51.86%   31.60%   -20.27%
===========================================
  Files        1147      715      -432
  Lines      106267    55349    -50918
===========================================
- Hits        55119    17493    -37626
+ Misses      51148    37856    -13292

Flag
Coverage Δ

g3bench
31.60% <1.28%> (-0.01%)
:arrow_down:

g3proxy
?

lib
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Closing unreleased/open streams in certain locations

Fixes #1527

Some open or unreleased streams were closed at certain locations. These locations were identified by a Static code analysis tool.
Formatted as per already existing file's original format
Added loggers to indicate if there are any issues while trying to close the stream

@sourabhsparkala Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@sourabhsparkala Thank you for signing the Contributor License Agreement!

Thanks for the PR @sourabhsparkala. This is now in master.


BLD: remove wheel from explicit build time requirements (not needed in Python>=3.8)

Blocked by #150


Broken searchbar with amoled theme

Also both sorting and clear buttons should be aligned.

I update the last release, I put a custom clear button for black theme only

@AbdurazaaqMohammed Why not for all themes. Should be a better approach imho.

Probably because that custom one is always there, even if there's nothing in the input field...


SDK4 only, not mentioned in README

Hi, pebble noob here. I was struggling with compiling this with SDK3 -- figured out that this code now requires SDK4. I'd recommend either forking an SDK4 version, and denoting that it's SDK4, or at least covering the SDK4 requirement in the README.
Thanks,
Dave

Thanks for the feedback.


chore: update smithy4s-core, smithy4s-json from 0.16.6 to 0.16.8

Updates

com.disneystreaming.smithy4s:smithy4s-core
com.disneystreaming.smithy4s:smithy4s-json

from 0.16.6 to 0.16.8.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.disneystreaming.smithy4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.disneystreaming.smithy4s" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #76.


Allow option to disable overscroll

Currently the draggable state is set to overscroll with resistance when the scroll isn't allowed (here). This can easily interfere with any parent horizontal gestures. Add an option to disable this?

Sounds good! Do you want to send a PR?
I'm also curious about your usecase. Can you share a video?

Sure. The use case is iOS gesture navigation: https://github.com/chrisbanes/tivi/pull/1379

I was thinking more about this today. Shouldn't this be handled automatically by nested scroll? Horizontal gestures intended for the parent shouldn't reach your list items.


Waylens uploads show no OBD despite it being connected

Uploads from my waylens now show no OBD on all tracks even though I always wait for the obd dongle to connect before beginning driving.
See: https://openstreetcam.org/details/2903066/0/track-info

Another example, seems it marks the whole sequence as no obd of the first image doesn't have the dongle connected yet

Another example, seems it marks the whole sequence as no obd of the first image doesn't have the dongle connected yet

Closing as obsolete ( cc #258 )

It should still be classified as an open bug though right? It should still be labeling the images with OBD as still having it. Or does it not track the OBD values at all if it is connected part way?


when run not restore zen mode if it was enabled in previous run

Issue Type: Bug
version 1.64.1 not restores zen mode on start
version 1.63.2 restores zen mode
So why it changed? Please fix back.
or: I need a way to hide tabs line from ui. Then zen mode is not necessary
VS Code version: Code 1.64.1 (d6ee99e4c045a6716e5c653d7da8e9ae6f5a8b03, 2022-02-07T17:16:22.147Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-6006U CPU @ 2.00GHz (4 x 1992)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.88GB (2.52GB free)

Process Argv
--crash-reporter-id 30f4f83a-c290-4fa8-a964-af8b69e10949

Screen Reader
no

VM
0%

Extensions (10)

Extension
Author (truncated)
Version

doxdocgen
csc
1.3.2

better-cpp-syntax
jef
1.15.11

php-symbols
lin
2.1.0

remote-containers
ms-
0.217.1

remote-ssh
ms-
0.70.0

remote-wsl
ms-
0.64.2

cmake-tools
ms-
1.9.2

cpptools
ms-
1.8.4

cpptools-extension-pack
ms-
1.1.0

cmake
twx
0.0.17

(1 theme extensions excluded)

or: I need a way to hide tabs line from ui. Then zen mode is not necessary

"workbench.editor.showTabs": false

@sbatten could this be from layout changes?

@JacksonKearl yes probably

Looks like @deemetrius's issue is solved by "workbench.editor.showTabs": false, we can close this out or leave it open if you want to track zen restore. (I confirmed it is a regression)

Looks like @deemetrius's issue is solved by "workbench.editor.showTabs": false, we can close this out or leave it open if you want to track zen restore. (I confirmed it is a regression)

In case Zen mode is used by someone - I think it should be restored in next run.
Currently I'm fine with workbench.editor.showTabs setting.

Came here to report this bug. Has been failing for a few versions now (didn't check but since 1.64.1 sounds reasonable).
Can someone point to what the layout changes are? maybe I can provide a PR.


unable to measure anything on Windows

When I try to click auto detect the flipper plugin crashes.

If I type in the box it throws up an error after each character.  I was able to put a bundle id in by pasting the full id into the box.
However, the plugin then crashes when I click start measuring.

Is there a configuration option I'm missing?  Not sure what the issue might be.

Hi @mark-zacharias, thanks for raising an issue here!
As it turns out, Flashlight needs a few fixes to make it work with Windows properly 🙈.
I've started with a few fixes, see #77 to see the ongoing work! 🚧
I haven't tried it, but I'm guessing Flashlight works with WSL, however I think the fixes should be simple enough to make it work with native Windows.

Aha, that makes sense. I'll try and pull that code down and give it a test.


Vlv2TbltDevicePkg: port of code from CorebootPayloadPkg adding custom…

… Shell build
Signed-off-by: Piotr Król<EMAIL_ADDRESS>

Boots to menu, but trying to start boot manager results in
ASSERT_EFI_ERROR (Status = Not Found)
ASSERT [BdsDxe] /home/edk2/edk2/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/BBSsupport.c(251): !EFI_ERROR (Status)

@krystian-hebel let's rebase that code to make it work. In general the problem with with commit that #if 0 BootOrder variable.

@krystian-hebel @pietrushnic is this PR reeady to merge or mergable? Do You plan to do anything regarding this change?

@miczyg1 after applying custom shell (trampoline) this will work even with #if 0, and would be compatible with swapping shell on Intel's image, before this concept was abandoned.

@krystian-hebel you answer is not clear to me and I'm not sure about @miczyg1. @krystian-hebel please answer yes/no and then justify.

@miczyg1 @krystian-hebel I think this limitation is fair since ul_4 have to be merged before release.


Can you create more than one file

Can you create more than one file of database if can I have the code
And one question if I have more than one file than how do I edit the file
ex I have money.sqlite and settings.sqlite
I earn money I want to be saved in money.sqlite
I am new on this
so please give me the steps/codes

Yes it's possible you just need to create multiple instances with different path
const { QuickDB } = require('quick.db');
const money = new QuickDB({ filePath: "./money.sqlite" });
const settings = new QuickDB({ filePath: "./settings.sqlite" });

Thanks


Removed docs of model submodules

submodules no longer appear in RTD. This done to increase focus on nodes and reduce cognitive load of readers.

If needed, respective model node docs should mention that the supporting submodules can be found on github.

LGTM


/test/sdf/model_nested_static_model.sdf doesn't define a @canonical_link

This could be related to me not having full knowledge of the @canonical_link resolution rules. The current order that I am aware of is:

If @canonical_link is set, use that link
If @canonical_link is missing, but the model has at least one direct child //link use the first link
If @canonical_link is missing, direct //links are missing, and the model has a nested //model or //include use the nested models's __model__ frame (https://github.com/ignitionrobotics/sdformat/issues/705#issuecomment-926909748)
The canonical_link is undefined / the SDF is faulty

With this in mind, the following SDF (/test/sdfmodel_nested_static_model.sdf) would be invalid in v1.8:
<?xml version="1.0" ?>
<sdf version='1.8'>
  <model name="model_nested_static_model">
    <model name="child_model">
      <model name="static_model">
        <static>true</static>
      </model>
    </model>
  </model>
</sdf>

static_model has neither child //links nor child //models, which makes the canonical link undetermined. The fact that it is //static will make its __model__ frame attach to world, and as such it would be possible to resolve all frame positions again, but - as far as I know - this behavior is currently not part of the spec.
On a tangent: It also strikes me as a bit odd that a __model__ frame can become a @canonical_link in this particular situation ... I believe it is not valid to directly/explicitly set it in this way? The frame is - technically - not a link, but rather a //link is a frame/frame-bearing.
My suggestion for resolving it would be to add a dummy link in static_model.

I just noticed that the same happens for /test/sdf/root_multiple_models.sdf, so I assume that there is another rule to @canonical_link that I am unaware of. In this case, the SDF looks like this
<?xml version="1.0" ?>
<sdf version="1.7">
  <model name="robot1">
    <link name="link"/>
  </model>
  <model name="robot2">
    <link name="link"/>
  </model>
  <model name="last_robot">
    <static>true</static>
  </model>
</sdf>

Perhaps setting //static to true inside a model means that the @canonical_link will be set to that model's __model__ frame?

Our documentation on sdformat.org discusses the different rules for canonical links in static and non-static models. We didn't want models to require a link, but we needed something to which the implicit model frame (__model__) is attached. For non-static models, at least one link is required so it can have a canonical link and well-defined __model__ frame. For static models, the __model__ frame can be attached to the world frame, so a canonical link is not strictly needed.
I believe this was originally added to the proposal for SDFormat 1.7 in https://github.com/ignitionrobotics/sdf_tutorials/commit/6f34b021a1fd8efade453e95f58a9dd502e326f3, but there isn't much explanation there.

Thanks for explaining, @scpeters . I was/am aware of the attachment rules in the presence of //static, but I do seem to have misunderstood that last part of the documentation (The name of the canonical link can be specified in the //model/@canonical_link attribute. If it is not specified, then the first //link tag in the model is chosen as the canonical link.) as @canonical_link will always have a value.
Taking the perspective of "@canonical_link is what the __model__ frame is attached to" it would essentially mean that the @canonical_link of a //static model is world, right? As far as I can see, this would be consistent with the current behavior and might make the logic a bit cleaner:

If //static -> @canonical_link is world
(el)If @canonical_link is set -> @canonical_link is the frame set in the attribute
(el)if direct //link in //model -> @canonical_link is the frame of the first direct //link
(el)if nested model/include -> @canonical_link is __model__ of the first nested child.
Pose of model can't be determined (raise error/exception)

Perhaps this would become even more obvious if @canonical_link is renamed to @attached_to (which would imply frames, not just //links) combined with some documentation detailing how the default is chosen if it is not set explicitly.

an alternative name could be @canonical_frame ... mainly to remove the association with //link and to create an association with //frame.