[FlakyTest] deregister when meeting specified exception *** FAILED ***

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the subtask
https://github.com/apache/incubator-kyuubi/runs/6089008961?check_suite_focus=true
- deregister when meeting specified exception *** FAILED ***
  The code passed to eventually never returned normally. Attempted 15 times over 5.006989376000001 seconds. Last failure message: STARTED did not equal STOPPED. (SparkSQLEngineDeregisterSuite.scala:51)

Parent issue
#1733
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

The SQL type in the error messages will change to uppercase after https://github.com/apache/spark/pull/36233.


K means clustering user guide?

https://github.com/Xilinx/Vivado-Design-Tutorials/tree/2021.1/Device_Architecture_Tutorials/Versal/NoC_DDRMC/04-NoC_Data_Movement_Comparison
It suggests me to take a look at ug1123 for further details on K means clustering, but I don't think there's user guide 1123. What's the correct reference?

This document was planned but never published, so the reference has been removed.


[Improvement]: Improvement of optimizer management UI interface

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?

When we select All Groups, we don't know the optimizer group of each table.

refresh resource info after click Scale-Out button to match actual resource stats.
don't close scale-out dialog after clicking OK before backend returning back
in catalogs module, when catalog list is empty, don't show NO DATA.
modify title of What is arctic to What is Arctic in front page.
logo of arctic dashboard could be linked to front page
stay at former tab page after refreshing optimizers management UI, as well as table details UI.

How should we improve?
Add a new column of Optimizer Group
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Subtasks
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

cc @huiyuanz @hameizi


Should string siblings be required fields?

Follow up to discussion in https://github.com/ocsf/ocsf-schema/discussions/450 for which string siblings were originally discussed.
In https://github.com/ocsf/ocsf-schema/pull/459 string sibling descriptions and purpose has been changed.
Now every id (ex: severity_id) should have an available string version (severity).
As mentioned by @pagbabian-splunk:

One more point- the above proposal didn't make mention of whether the enum label is required in the sibling or whether it is optional. The siblings themselves are all marked as Optional, but would effectively be silently promoted to Required if Other was the enum value.

Could string sibling fields be required so that consumers can rely on them being present?

Some time ago, we made the sibling attributes having the same requirement as the enum attributes, however to keep the data size small we decided to revert that change and make all siblings optional.


Feature request: stream url and/or stream play command

Sometimes you don't want to download, oftentimes you want to stream the file, and you just want the URL for use in a media player or to automatically play the URL in a media player. A link such as: "https://dl-a10b-1234.mypikpak.com/download/?fid=" etc.
So "stream" would make a great addition to the other commands. Someone who knows go well, could probably add this stream command quite easily..? I feel it would take me ages to figure it out...

Thanks for providing suggestions, I will improve this feature later.


Print angent labels in debug mode

because right now there is no way to figure this out in any way

backported:  #4156


Unselecting the selected records is unhandy

Steps:

Go to random list e.g. client list
Select all record
Try to unselect, by mouse clicking

Actual Results:
Unselecting the selected records is unhandy. Look at gif below:

@dawid-g We're planning big improvements to tables & selecting mechanics in next release ( 0.9.4 ).


TSC fails to emit required files when run below node_modules

TypeScript Version:  3.2.0-dev.20181107

Search Terms: node_modules
Code
/tmp/node_modules/tsc-test/tsconfig.json
{
  "compilerOptions": {
    "outDir": "dist"
  },
  "files": [
    "src/index.ts"
  ]
}

/tmp/node_modules/tsc-test/src/index.ts
import { A } from './A';

export const main = () => {
  console.log('A=', A);
};

/tmp/node_modules/tsc-test/src/A.ts
export const A = 'A';

Expected behavior:
Output files:

/tmp/node_modules/tsc-test/dist/index.js
/tmp/node_modules/tsc-test/dist/A.js

Actual behavior:
Output files:
/tmp/node_modules/tsc-test/dist/index.js
"use strict";
exports.__esModule = true;
var A_1 = require("./A");
exports.main = function () {
    console.log('A=', A_1.A);
};

No A.js is output
Notes:
I wanted to build a typescript project as part of an npm postinstall script, to enable installation from npm or from git.  In the case of installation from npmjs, dist/ will already exist.  In the case of installation from git, dist/ will be missing and build will be run.
After setting this up, I noticed that only files listed in my tsconfig files list were being emitted when installing from git.  I looked around for tsconfig or tsc options that may change this behavior, but realized it probably had to do with 'node_modules' being in the path.
I debugged the issue by modifying the built tsc.js.  In my case, the problematic code is in nodeModuleNameResolverWorker/tryResolve, specifically here:
const { path: candidate, parts } = normalizePathAndParts(combinePaths(containingDirectory, moduleName));
const resolved = nodeLoadModuleByRelativeName(extensions, candidate, /*onlyRecordFailures*/ false, state, /*considerPackageJson*/ true);
// Treat explicit "node_modules" import as an external library import.
return resolved && toSearchResult({ resolved, isExternalLibraryImport: contains(parts, "node_modules") });

The call to contains(parts, "node_modules") should likely consider the project root directory, and ignore "node_modules" in the path parts above the root.

This is working as intended since we want to not touch anything in node_modules because of build.

@sheetalkamat There are valid reasons to have a project root within a node_modules folder (hoisting, for example). Maybe we should consider adjusting it? The suggested fix seems reasonable - ignoring node_modules if it occurs in the project root path.

I don't think if it occurs under project root is good enough.. Eg if the project root file references another module from same node_modules but not in projectRoot it needs to skip emitting that and that just makes module resolution depend on too many things then (outside of its resolution

Right, what I'm getting at is that if the project root is /a/b/node_modules/c/d, anything beneath /a/b/node_modules/c/d should be built. /a/b/node_modules/c shouldn't be, /a/b/node_modules/c/d/node_modules/e shouldn't be.

So, if you path begins with the project root, you only check the components after the project root ends for node_modules.

This is working as intended

I hope we can find a way to allow tsc to produce functional builds under these circumstances.  As of now tsc produces a non-functional build, which does not seem like intended/optimal behavior.

Eg if the project root file references another module from same node_modules but not in projectRoot

If /tmp/node_modules/tsc-test/src/index.ts references /tmp/node_modules/project2/src/index.ts, the build in tsc-test should exclude /tmp/node_modules/project2*, since this is not part of the project root.
It seems like the ideal solution is to skip emit under two conditions:

When the built file is not part of project root
When the built file is part of the project root, and under a node_modules directory

Hoping to get further guidance from the TS team after "working as intended", any updates on this?

Since @weswigham seems to have some thoughts around this, we can discuss this in a backlog slog in the future

Someone reported this to ts-node.  A quirk in our case: we pass empty files and includes arrays to the compiler to prevent it from eagerly pulling all sources into the compiler.  Thus, the target of every import statement is unknown to the compiler, and moduleResolution sets isExternalLibraryImport = true
I'm planning to implement the behavior described in https://github.com/microsoft/TypeScript/issues/28432#issuecomment-437498123
Is type-checking affected by isExternalLibraryImport?  In other words, if ts-node takes the nuclear option and always forces that flag to be false, will it break typechecking?  ts-node has its own --ignore pattern that determines which files are compiled and which are skipped, so it's possible that ts-node's option won't always align with TypeScript's behavior.  The nuclear option avoids that problem.


SelfUpdater: Add --no-same-owner to tar invocation

This avoids having tar attempt to set the original owner and access times for files when extracting them as root.  While not best practice on multi-user systems, single-user systems (such as Alpine, or a chroot user namespace) run all processes as root, and it is possible to get a tar on that system that will attempt to set e.g. UID 1000 from a tarball when that doesn't make any sense.  As the Azure Pipelines agent doesn't really care about file ownership in this case, this flag should be completely safe to set, and should have no effect outside of the cases where it is needed.

It does indeed appear that busybox tar does not support the long form --no-same-owner, however it does support the -o flag, as does GNU tar and BSD tar.  Is there any other tar implementation that we must check against?


Theming Fixes

Fix : Theme subset selection can be empty & lead to a crash
Fix : VERTICAL_WHEEL carousel logo position on some themes using rotation by logo size + ensure loading order for themes <= 4
Fix : Rating Component drawing on some themes.
Fix : ImageComponent clipping with rotation

/recalbox/share_init/system/.emulationstation/themes is not a valid directory
the 2 only correct values are :
/userdata/themes
and
/usr/share/emulationstation/themes


kubeconfig instructions & download

Summary
The kubeconfig to connect to the control API in the same environment is displayed and - with the click of a button - can be downloaded or copied to the clipboard. Also lists the prerequisites to use said kubeconfig, and basic instructions on how to use it.
To get to the page with the kubeconfig, a link in the references menu ((?) top right) was added.
The server, --oidc-issuer-url, and --oidc-client-id values can be configured via environment.ts / helm files.
Closes https://github.com/appuio/cloud-portal/issues/105
Checklist

[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking,
as they show up in the changelog
[x] Update tests.
[x] Link this PR to related issues.

I would propose to either add a subtitle in the reference menu, explaining that this is the guide to access the control API using kubectl or add a new CLI icon for it in the toolbar next to the reference icon.

@glrf good point. I like the idea of the CLI icon, but I think it might not be clear what it does (people might expect an actual cmd to open). So I went with the subtitle and added some more explanatory text and an icon to the entry in the info menu to distinguish it from the reference links.


Docker image not working

My docker yaml

services:
  postgres:
    image: debezium/postgres:12-alpine
    ports:
      - "15432:5432"
    environment:
      - POSTGRES_USER=pgsync
      - POSTGRES_PASSWORD=pgsync
      - POSTGRES_DB=pgsync
  redis:
    image: redis
    command: redis-server
  elasticsearch:
    image: docker.elastic.co/elasticsearch/elasticsearch:7.7.0
    ports:
      - "9201:9200"
      - "9301:9300"
    environment:
      - xpack.security.enabled=false
      - network.host=<IP_ADDRESS>
      - http.host=<IP_ADDRESS>
  pgsync:
    build:
      context: .
      dockerfile: Dockerfile
    command: ./runserver.sh
    labels:
      org.label-schema.name: "pgsync"
      org.label-schema.description: "Postgres to elasticsearch sync"
      com.label-schema.service-type: "daemon"
    depends_on:
      - postgres
      - redis
      - elasticsearch
    environment:
      - PG_USER=pgsync
      - PG_HOST=postgres
      - PG_PASSWORD=pgsync
      - LOG_LEVEL=INFO
      - ELASTICSEARCH_PORT=9200
      - ELASTICSEARCH_SCHEME=http
      - ELASTICSEARCH_HOST=elasticsearch
      - REDIS_HOST=redis
      - REDIS_AUTH=

Can you please indicate what version of docker you are running.

Head over to https://labs.play-with-docker.com/ and this works for me
git clone git@github.com:toluaina/pg-sync.git
docker-compose up

I believe the docker file IS working


Build docker image for 0.9.0

Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

/test fluid-e2e-nightly

/test fluid-e2e-nightly

/test fluid-e2e-nightly

/retest

/retest


Save Report and Ad Hoc Report Generate endpoint wrappers

@gschneider-r7 opening per our conversation. A few of the report actions are unfinished: RequestAdHocReportGenerate is only partially written and doesn't handle most of the parameters that the endpoint accepts and RequestReportsSave is not implemented at all.

Started work on report_configs branch: https://github.com/rapid7/nexpose-client-python/compare/report_configs

Progress so far:

[ ] GenerateAdhocReport()

[x] Implement AdhocReportConfiguration class with all supported properties
[ ] Implement GenerateAdhocReport() method in the main nexpose/session class

[ ] SaveReportConfiguration()

[x] Implement ReportConfiguration class with all supported properties
[x] Implement SaveReportConfiguration() method in the main nexpose/session class

[ ] Figure out how to pass generate_now parameter through the magic/reflective method callers

[ ] GetReportConfigurationDetails()

[x] Use ReportConfiguration class instead of ReportConfigurationSummary
[ ] Implement CreateFromXML() for all of the extras (Filters, Schedule, Delivery, Email, etc)


files specified by pattern inside symlinked dir

chokidar seems to not trigger events for files matched by a glob/pattern inside a symlinked dir.
File structure is:
./folder/symlinked/file.js

Working:
  chokidar.watch('./folder/symlinked/file.js', {}).on('all', function(event, path) {
    console.log('trigger by chokidar', path);
  });

not working:
  chokidar.watch('./folder/symlinked/*.js', {}).on('all', function(event, path) {
    console.log('trigger by chokidar', path);
  });

Am I missing something or this a bug?
What I really want to do is watch ./folder/**/*.js. My folder contains dirs which are part symlinks and part regular dirs. That worked for regular dirs, but not for symlinks ..

Appears to be a bug with the filtering on the initial readdirp file tree scan. In fsevents mode with a quick local test, the initial add events I would have expected did not happen, but after the ready event changing one of the files being watched through the symlink did trigger events (first an add, then changes)

+1 Same bug on windwos.

++1 the same on linux and windows

+1 osx too. I just ran into this. =(

+1 causing some headache (OS X, Windows, Linux), arguably unreliable to get the latent add event when it should actually be a change. Have to arbitrarily find the files and add them because of this which undermines chokidar's own features.

+1

+1

+1
Ububtu 12.04

Trying to fix this. The eventual cause is that filter passed to readdirp  matchs paths with the symlink names, while readdirp entry contains the actual physical name. I can't deiced weather this is a feature or a bug in readdirp...
Any way I might have stumbled upon some other issues with symlink related code:
(1)[https://github.com/paulmillr/chokidar/blob/master/index.js#L279]
 statMethod: this.options.followSymlinks ? 'stat' : 'lstat',

isn't it the other way around?
(2)[https://github.com/paulmillr/chokidar/blob/master/lib/nodefs-handler.js#L456] - it's weird if the symlink is the original path the user asked to watch since it watches the symlink parent.
what do you think?

isn't it the other way around?

No, it isn't. stat will return metadata about the target file when given a symlink. In other words it follows the link. lstat returns metadata about the symlink fd itself.
Don't really understand your other question.
You're right about the source of the problem, I mentioned the same thing in an earlier comment. The solution is probably to convert paths coming from readdirp to what they would be if the symlink hadn't been factored out and trying that result against the filters as well. If either passes then the path should be included.

Any progress or workaround on this matter?

@webdif not yet, but I've been picking up my activity lately, so hopefully soon.
Workaround would be to watch the entire parent dir (see glob-parent) without using a glob pattern, and then using the ignored option to filter as needed.

@es128 This workaround works fine with my situation. Thanks a lot!


[NFC] Never synthesize @lvalue in typing judgements

When in a checking context, there is no need (and no sense) in synthesizing @lvalue instead of checking the underlying object type.
The locators for this typing rule and the other parameter binding one below it are still lying, but probably because there's really no good way to indicate that you're an argument to a function/operator without also lying about the index of the argument - which matchTypes has no way of knowing.

@swift-ci please test

@swift-ci please test source compatibility

Build failed
Swift Test Linux Platform
Git Sha - 056ddca2417e92f435043ee98de41a65cfb3c308

Aha, well I'm going to move the @lvalue synthesis to CSGen where it belongs.

Build failed
Swift Test OS X Platform
Git Sha - 056ddca2417e92f435043ee98de41a65cfb3c308

LLDB test timed out
@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please test source compatibility

@swift-ci please test source compatibility

⛵


Clean up the blaze client

closes #402
Address numerous monstrosities of the blaze client design.

Merge Http1ClientStage and Http1ClientReceiver.
Remove move timeout behavior from the Http1ClientStage to the blaze pipeline.
Add support for two different types of timeouts: full request and idle.
Various cleanups

This seems reasonable.


Is there a way to set the editor to readonly mode?

have you tried reading the html from the editor (with editor.getHTML()) and displaying it using?

	{@html editorHtml}


@key throws "Cannot read property name of undefined"

Describe the bug
Attempting to add a @key directive as described in the documentation does not successfully provision when running amplify push using the following schema in my project:
type Action
  @model
  @key(fields: ["id"])
  @key(
    name: "ByActionable"
    fields: ["actionableId"]
    queryField: "actionsForActionable"
  )
  @key(name: "ByTitle", fields: ["title"], queryField: "actionsByTitle")
  @key(
    name: "ByActionableByPosition"
    fields: ["actionableId", "position"]
    queryField: "actionsForActionableByPosition"
  )
  @key(
    name: "ByActionableByTitle"
    fields: ["actionableId", "title"]
    queryField: "actionsForActionableByTitle"
  )
  @key(
    name: "ByActionableBySlot"
    fields: ["actionableId", "slot", "position"]
    queryField: "actionsForActionableInSlotByPosition"
  )
  @key(
    name: "ByActionableByHandler"
    fields: ["actionableId", "handledBy"]
    queryField: "actionsForActionableByHandler"
  )
  @key(
    name: "ByActionableBySlotByHandler"
    fields: ["actionableId", "slot", "handledBy"]
    queryField: "actionsForActionableByHandlerInSlot"
  )
  @auth(
    rules: [
      { allow: owner }
      { allow: groups, groups: ["Guests"], operations: [read] }
    ]
  ) {
  id: ID!
  owner: String
  actionableId: ID!
  actionableType: ActionableType!
  title: String
  type: ActionType!
  subtype: String
  slot: ActionSlot!
  handledBy: ActionHandler!
  position: Int!
  triggerAtTimecode: Float
  data: AWSJSON
  createdAt: AWSDateTime
  updatedAt: AWSDateTime
}

enum ActionableType {
  Collection
  Playlist
  Video
  PlaylistVideo
}

enum ActionSlot {
  BEFORE_START_PLAYBACK
  DURING_PLAYBACK
  AFTER_COMPLETE_PLAYBACK
}

enum ActionType {
  SEND_EMAIL
  CONSOLE_LOG
  ALERT
  DISPLAY_INTERSTITIAL
  PERFORM_HTTP_REQUEST
}

enum ActionHandler {
  CLIENT
  SERVER
  CLIENT_AND_SERVER
}

Output:
$ amplify push --yes

Current Environment: dev

| Category  | Resource name                                  | Operation | Provider plugin   |
| --------- | ---------------------------------------------- | --------- | ----------------- |
| Api       | andoto                                         | Update    | awscloudformation |
Updating input structures for key: {"fields":["id"]}
✖ An error occurred when pushing the resources to the cloud

Cannot read property 'name' of undefined
error Command failed with exit code 1.

Expected behavior
amplify push successfully compiles and provisions changes
Additional context
I tried running on both a brand new model and an existing model with no luck.

Which version of the CLI are you using?

@kaustavghosh06 1.7.0

I was fighting through this same issue (CLI @ 1.7.0).
I can reproduce it with this schema:
type Item @model
@key(fields: ["orderId","status"])
{
    orderId: String!
    status: Status!
    createdAt: AWSDateTime!
    name: String!
}
enum Status {
    DELIVERED
    IN_TRANSIT
    PENDING
    UNKNOWN
}

it seems to be related to having an enum as the sort key. Changing status to String resolves the error.

Can confirm, changing all field references from enum types to String allows the compilation to succeed

We've merged the fix for this issue. It would be a part of our next npm release.


SoundCloud Provider

Short description
Paparajote provider for authenticating with SoundCloud
Implementation

[x] Implement SoundCloudProvider
[x] Test it

GIF

cc @sergigracia  / @isaacroldan

Current coverage is 90.54% (diff: 99.06%)

No coverage report found for master at ddeeca3.

Powered by Codecov. Last update ddeeca3...138e569

👏


Unskip W3C Trace Context parametric tests for Node.js

Depends on DataDog/dd-trace-js#2477
Description
When W3C Trace Context support lands in Node.js these tests should no longer be skipped.
Check list
Your PR is not ready to be reviewed? Please save it as a draft :pray:

[ ] Follows the style guidelines of this project (See how to easily lint the code)
[ ] CI is passing
[ ] There is at least one approval from code owners

Yes to all? Feel free to merge it whenever you want :heart:

DataDog/dd-trace-js#2477 has landed, but the system-tests CI tests against the release version so I'll this after that gets released. Review/approvals would be appreciated though. :)


Suggestion emendation for "ID" text

Request type

[x] Correction or update

Details

At https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id, the prose reads (in part) "(i) This attribute's value is an opaque string: this means that web authors must not use it to convey human-readable information".  "Must not", in my opinion, is incorrect, and might lead a reader to believe that a page that uses meaningful IDs is (a) wrong, and (b) would fail formal validation.  I believe that a better formulation would be "(c) This attribute's value is an opaque string: this means that web authors may not rely on it to convey human-readable information".

@Retired-of-Cornwall yes, I completely agree with you. I've actually gone a little further, and used the following text:

This attribute's value is an opaque string: this means that web authors should not rely on it to convey human-readable information (although having your IDs somewhat human-readable can be useful for code comprehension, e.g. consider ticket-18659 versus r45tgfe-freds&$@).

Thanks very much for pointing this out.


Separate SqsPort/SnsPort settings don't work

In config.go line 49 overwrites line 46, so app.CurrentEnvironment.Port is not getting set. That creates SQS queues with no port in URLs

Fixed under PR #184


Possible error in PLE0605

In https://github.com/astropy/astropy/pull/15385 we are trying to fix some __all__ statements and ran into the following
__all__ = [...]
logging_levels = ["NOTSET", ...]
...
__all__ += logging_levels

My suggested fix was
__all__ = [...]
__all__ += (logging_levels := ["NOTSET", ...])

However PLE0605 is still complaining. I don't think this is correct since the above should be, from the "perspective" of __all__ equivalent to
__all__ = [...]
__all__ += ["NOTSET", ...]

which passes the check.
The inclusion of the walrus operator for assigning to another variable makes the AST more complicated but should be equivalent statically to excluding the walrus.

Thanks for the report!
Hm... in the example:
from first import a, b

__all__ = ["a"]
__all__ += (foo := ["b"])

pyright reports the symbol b as unused and displays the warning Operation on "__all__" is not supported, so exported symbol list may be incorrect (reportUnsupportedDunderAll).
Although I agree this is syntactically equivalent, if it's not supported by type checkers I'm not sure we should treat it as valid.

I think it's reasonable to support if the code changes aren't too tricky :)


Eight S3 backup jobs are created, but 11 backup files are generated

Describe the problem
1、create eight S3 backup jobs

2、11 backup files are generated

To Reproduce
1、copy mysql_v1alpha1_backup.yaml file to create 8 backup jobs，the file path：
https://github.com/radondb/radondb-mysql-kubernetes/blob/main/config/samples/mysql_v1alpha1_backup.yaml
2、rename bakup yaml  file metadata.name，each file has a different metadata.name
3、kubectl apply -f mysql_v1alpha1_backup.yaml
Expected behavior
8 backup files are generated
Environment:

RadonDB MySQL version:

When you Add historyLimit: 10 in the backup yaml file, It do not happened

When backup job Created， they need next reconcile to updateStatus, but When the backup job create, May be after SyncFn the Job is completed， but this time backup Status not change， when  next reconcile it will create job again, Cause this problem.

When it is first created, this s.job.ObectMeta.CreateTimestamp is 0, and the status of the backup will not be updated.


Client/network: make various mods pub

The purpose of this PR is to expose certain mods to allow us to make a custom transactions.rs file.

Duplicate of https://github.com/paritytech/substrate/pull/11355 and also the same question.


correct email for Peter Bengtsson

Thanks for the ack but I'd like to use my non-work email if you don't mind.

Pull Request Test Coverage Report for Build 492

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.161%

Totals

Change from base Build 491:
0.0%

Covered Lines:
2505

Relevant Lines:
2605

💛  - Coveralls

Sure thing!


v1.5 Updated DG and project portfolio page

Coverage remained the same at 79.926% when pulling de6ef4e953cc2d916cac741e51b9082c0c006a55 on inGall:v1.5 into 0a5d3f41c7ad04a168c0dc6ad4eb060d6ccc7dc0 on CS2103AUG2017-T09-B1:master.


remove unnecessary copy

Can one of the admins verify this patch?

If this is an optimization, it's a very small one. Are you sure it improves things? weirdly, I've found this kind of thing can slow down very tight loops since you put a branch in the pipeline.

It's not a deep copy, just assign a new reference which is very cheap, and I'm afraid your extra if branch may hurt the performance.

need JIRA

I actually think this PR should just be closed.

Yeah, this doesn't have a description / explanation of changes, JIRA ticket, or benchmark results. Let's close for now.

ok.close it.


Change namespace

Nimbusoft was the name of one of my businesses that I have now closed.
I would like to move this package to my personal GitHub, but there are a few things that we need to do to make sure this is a smooth transition.

[ ] Transfer ownership of this repo to my personal account (this should create a redirect from this current repo URL to the new one, so it should not affect anyone currently using this package).

[ ] Register chrisnharvey/flysystem-openstack-swift as a new package on Packagist.

[ ] Change the namespace of the project in the source code. Probably from Nimbusoft to ChrisHarvey, or maybe even omitting the vendor all together.

[ ] Tag a 1.0 release under the new namespace and register as a new package on Packagist.

[ ] Mark the old Packagist project as abandoned and suggest install of chrisnharvey/flysystem-openstack-swift

I suggest to use the ChrisHarvey namespace. This is consistent with the new package name.

@mzur Cool! Really appreciate your contributions to this project!


Implement Utility Nodes ☂

Now that we have a decent set of workers, we need to consider some utility nodes.
Definitely:

Combiner:  takes multiple LLM Content arrays from various Specialists and combines them into one array of LLM Content.
Filter: takes an LLM Content array and allows filtering/picking only some.
Tool: invoke wrapped to use LLM Content and invoke a tool. Why call an LLM when you know which tool to invoke?
Multiplier: takes an LLM Content array, a number N and a board, then invokes N instances of a board in parallel with the provided array as argument, then (somehow) reduces it back to one LLM Content array.

Maybe:

Start: simplified input node that outputs LLM Content
End: simplified output node that takes LLM Content as input

Initial issue context:
Now that we have a decent set of workers, we need to consider some utility nodes.
Definitely:

Combiner:  takes multiple LLM Content arrays from various Specialists and combines them into one array of LLM Content.
Filter: takes an LLM Content array and allows filtering/picking only some.
Tool: invoke wrapped to use LLM Content and invoke a tool. Why call an LLM when you know which tool to invoke?
Multiplier: takes an LLM Content array, a number N and a board, then invokes N instances of a board in parallel with the provided array as argument, then (somehow) reduces it back to one LLM Content array.

Maybe:

Start: simplified input node that outputs LLM Content
End: simplified output node that takes LLM Content as input


Quick fix for continuation test

Hopefully -1000 cycles is enough to provide a little headroom for the unit test to pass in CI.

Swapped to draft, exploring the bug a little bit deeper

Closing in favor of #556


Lexical custom block in new document (beta 108 regression)

Link to reproduction
http://localhost:3000/admin/collections/rich-text-fields/create
Environment Info
payload: 3.0.0-beta.108
next: 15.0.0-canary.160
Node: 22.9.0

Describe the Bug
Can not add custom blocks in lexical field in a new document.
This worked fine in beta 107, does not work in 108.
Reproduction Steps
Can be reproduced in payload repo:
Run: pnpm dev fields
Go to http://localhost:3000/admin/collections/rich-text-fields/create
Add any of these custom blocks to the new document:

Expected:
The block to show
Actual:
Just showing shimmer-effect/loader
Adapters and Plugins
No response

@GermanJablo what do you mean you can not reproduce? The video is showing the shimmer-effect only and not the content in the block.
Do the same thing in one of the existing documents, and you will see the difference.

How strange, I can't reproduce it:

Your video does seem to reproduce it though (the blocks are just shimmering)

Oh yes, sorry, I don’t know what I’m saying! I'm going to work on this right now.

Fixed in https://github.com/payloadcms/payload/pull/8378


RuntimeError: repeats must have the same size as input along dim

I am trying to train models with duration prediction but got the following errors:
2022-09-09 23:54:22,490 (trainer:299) INFO: 1/500epoch started
/home/ryuichi/anaconda3/envs/py38_espnet/lib/python3.8/site-packages/torch/functional.py:606: UserWarning: stft will soon require the return_complex parameter be given for real inputs, and will further require that return_complex=True in a future PyTorch release. (Triggered internally at  /opt/conda/conda-bld/pytorch_1659484810403/work/aten/src/ATen/native/SpectralOps.cpp:800.)
  return _VF.stft(input, n_fft, hop_length, win_length, window,  # type: ignore[attr-defined]
/home/ryuichi/sp/Muskits/muskit/layers/stft.py:109: UserWarning: __floordiv__ is deprecated, and its behavior will change in a future version of pytorch. It currently rounds toward 0 (like the 'trunc' function NOT 'floor'). This results in incorrect rounding for negative values. To keep the current behavior, use torch.div(a, b, rounding_mode='trunc'), or for actual floor division, use torch.div(a, b, rounding_mode='floor').
  olens = (ilens - self.win_length) // self.hop_length + 1
/home/ryuichi/sp/Muskits/muskit/svs/feats_extract/score_feats_extract.py:115: UserWarning: __floordiv__ is deprecated, and its behavior will change in a future version of pytorch. It currently rounds toward 0 (like the 'trunc' function NOT 'floor'). This results in incorrect rounding for negative values. To keep the current behavior, use torch.div(a, b, rounding_mode='trunc'), or for actual floor division, use torch.div(a, b, rounding_mode='floor').
  olens = (input_lengths - self.win_length) // self.hop_length + 1
Traceback (most recent call last):
  File "/home/ryuichi/anaconda3/envs/py38_espnet/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/ryuichi/anaconda3/envs/py38_espnet/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/ryuichi/sp/Muskits/muskit/bin/svs_train.py", line 21, in <module>
    main()
  File "/home/ryuichi/sp/Muskits/muskit/bin/svs_train.py", line 17, in main
    SVSTask.main(cmd=cmd)
  File "/home/ryuichi/sp/Muskits/muskit/tasks/abs_task.py", line 1054, in main
    cls.main_worker(args)
  File "/home/ryuichi/sp/Muskits/muskit/tasks/abs_task.py", line 1341, in main_worker
    cls.trainer.run(
  File "/home/ryuichi/sp/Muskits/muskit/train/trainer.py", line 305, in run
    all_steps_are_invalid = cls.train_one_epoch(
  File "/home/ryuichi/sp/Muskits/muskit/train/trainer.py", line 519, in train_one_epoch
    retval = model(**batch)
  File "/home/ryuichi/anaconda3/envs/py38_espnet/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/ryuichi/sp/Muskits/muskit/svs/muskit_model.py", line 361, in forward
    return self.svs(**batch)
  File "/home/ryuichi/anaconda3/envs/py38_espnet/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/ryuichi/sp/Muskits/muskit/svs/naive_rnn/naive_rnn_dp.py", line 380, in forward
    hs = self.length_regulator(hs, ds)  # (B, seq_len, eunits)
  File "/home/ryuichi/anaconda3/envs/py38_espnet/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/ryuichi/sp/Muskits/muskit/layers/fastspeech/length_regulator.py", line 59, in forward
    repeat = [torch.repeat_interleave(x, d, dim=0) for x, d in zip(xs, ds)]
  File "/home/ryuichi/sp/Muskits/muskit/layers/fastspeech/length_regulator.py", line 59, in <listcomp>
    repeat = [torch.repeat_interleave(x, d, dim=0) for x, d in zip(xs, ds)]
RuntimeError: repeats must have the same size as input along dim

To reproduce, run the following command in ofuton_p's or ritsu's recipe:
CUDA_VISIBLE_DEVICES="0" ./run.sh  --stage 6 --stop-stage 6 --train_config conf/tuning/train_naive_rnn_dp.yaml

It seems like a bug. I didn't change any parameters, just used configs in this repository. Could you check it?

Just to make sure, which database are you using?

I use Namine ritus's and ofuton_p's databases.

Hi, any updates on this? I am unable to reproduce results for RNN (w/ G.T. Dur) and Transformer (w/ G.T. Dur) described in the paper https://arxiv.org/abs/2205.04029.

We have found the same bug with the latest branch, trying to fix it. Thanks for the following up.

Hi, sorry, I just review the issue, and find that the issue is from the feature extractor. The one with duration predictor will need to be trained with syllable_score_feats instead of the default frame_score_feats. If you go to the run.sh, you can see the option there, which is default as frame_score_feats

It definitely worths to make a better warning message though~ Thanks for bringing that out

Thank you for the quick response! I'll try to see if it works with syllable_score_feats!

It worked, thank you again!


Highlights are broken at startup on Windows console

Highlights seem broken on Windows command prompt at startup.
It returns to correct color after I :call lightline#highlight() manually.
As far as I researched, this bug comes from commit 7a2d853. This doesn't occur at the previous revision 757fa3d.

Thanks for your detail report, I fixed the bug.


Created API key empty just after uploading a table

Context
This bug has been found using CARTOframes. When a map that uses a private table is published a Maps API key is created.
Steps to Reproduce
Using CARTOframes:

Upload a table to CARTO: to_carto(gdf, 'new_table_name', if_exists='replace')
Create a Map: map_viz = Map(Layer('new_table_name'))
Publish the Map: map_viz.publish(name='New_Table_Name', password='1234', if_exists='replace')

Current Result
If the table has been just uploaded the API key is not properly created (empty tables) and there is no Exception from the backend.

Expected result
API key creation should work or at least raise an Exception.
Additional info
Related to:

https://github.com/CartoDB/support/issues/2375
https://github.com/CartoDB/support/issues/2376

cc @CartoDB/rt-managers

@Jesus89 This seems a bug of CARTOframes itself. If no client has reported this, I think it should be dealt as a CARTOframes issue/bug and not as an RT issue.

Hi @oriolbx. It's a bug in CartoDB because the API keys creation fails and it does not return any Exception. The lib carto-python should be also checked.
CARTOframes is the way we have detected that bug and also, in order to fix this in CF, it must be fixed in CartoDB first.
The RT tag was added by @cmongut so maybe he can explain better the need for this to be in RT.

Oh ok, thanks! Sorry for the confusion.

@Jesus89 I'm not able to reproduce the issue at all.
Do we have a notebook that consistently fails? That would be helpful.
Thanks!

[Notebook sent] :)
You can find more information in the original issues linked in the description. Q: do we have deployed changed related to API keys generation in the last 10 days?

I cannot reproduce the issue, thus I don't know what happened, but I've checked one of the wrong API keys are correct in our metadata database and the pg_role was created, but it hadn't any GRANT.
I'm going to force that very same error introducing an exception in the moment the permissions are granted, and do an E2E test locally to see what happens.

I've checked that any error sent by our API arrives to the client and it's reported to the user, so that's just fine.
Besides that I spotted the issue:
I've been looking at Kibana and I'm seeing several 422 errors in the POST to the api_keys endpoint and then a GET with a proper api_key name, so I'm assuming it is this part of the code which is being executed.
Basically, in CARTOframes the API key name is built from a hash of the layer names, which seems legit in order to reuse API keys. Since the API key name is unique, if the server raises a not valid name error, CF is trying to GET the existing API key by name, assuming it contains the required permissions.
The problem is the table referenced in the API key might not exist, so CF retrieves an API key that does not have any table granted, since the original table was previously dropped, the reference was lost and the API key is never created again.
To reproduce this:

Create an API key from the dashboard and grant any of your tables.
Run a DROP TABLE with the SQL API
Your API key still exists BUT it has no granted table since it was dropped.
Now, since API key names are hashed from the table names granted from CF, anytime you want to publish a map with the referenced table in the API key, it won't work, since it won't create a new api key but get an empty one.

There are a number of possible solutions to this situation:

We could try to delete API keys on DROP TABLES or refresh them on CREATE TABLES. We'll have to stop and think about the implications of this, since it involves triggers and async stuff which we know it ends up being cumbersome and problematic.
OTOH we are making a heavy usage of the Auth API in CARTOframes and we could try to solve this specific case. I think we should stick to the hashed api key names and I can think of a couple of fixes:

Recreate the API key from CF if it exists (create -> error -> delete -> create) on every map publication. It has the advantage of the api key being always up to date, but the problem that the token would change and might break other published maps with the same tables.
Create a refresh or touch endpoint in the Auth API, which basically will keep the same token for an existing api key, but recreate their table permissions. On creation error (due to the API key already exists) CF would call this method instead of the GET api key one. This method would only make sense for CF, since we know for sure two api keys with the same name require the same permissions and it'd work since I the grants metadata is preserved, so besides the tables might have been dropped, we know which were the tables granted for the API key.

After a meeting we found 3 options:

In CARTOframes: Truncate the table if it has the same schema. Then we will avoid DROP+CREATE if the columns are the same. This can be done automatically (implicit) in the 'replace' state, or more explicit using a new 'truncate' option (+1).
In CARTOframes: use a temporary table to keep the API key grants. We need to validate this because if the roles are linked to the table id instead of the name id, this is not an option.
In CartoDB: perform the grants every time an API key is requested (via get or create). Then, the resulting API key will always have working permissions.

Option 1 is an improvement in CARTOframes, and we should evaluate it to improve the to_carto function and include it in the backlog (@cmongut)
Option 2 needs research (@alrocar)
Option 3 can also be implemented, but we need to test it to make sure it helps/solves the issue.

In CARTOframes: Truncate the table if it has the same schema. Then we will avoid DROP+CREATE if the columns are the same. This can be done automatically (implicit) in the 'replace' state, or more explicit using a new 'truncate' option (+1).

If someone deletes the table from their dashboard and then, upload another one with the same name from CARTOframes, will we continue having the same issue?

In CartoDB: perform the grants every time an API key is requested (via get or create). Then, the resulting API key will always have working permissions.

How this will impact the performance?

Yes, I think is someone drops a table with the SQL API or the Dashboard the issue can happen again.
There is no performance impact AFAIK with option 3.

Should we go fo option 3 then? Thoughts @alrocar?

After talking to @cmongut we'll go with option 3, although it's not super-prioritary 😛

ping @alrocar

So we decided to go with option 3:

CartoDB: perform the grants every time an API key is requested (via get or create). Then, the resulting API key will always have working permissions.

ensure the grants on a GET request is not a nice solution. A GET request should not modify the underlying resource. So I'm proposing this other approach:

Create a refresh or touch endpoint like api/v3/api_keys/{id}/grants/touch
It'll be a PUT (or POST), it'll refresh the GRANTS for the api key role
It'll return the api_key + a 200 response code

The detailed steps to implement this (in case it can be implemented inside the CF project, otherwise ask for help to the backend team):

Add the new endpoint in routes similar to this
New method in the controller similar to this
Add a new method refresh_grants or similar in the api_key model. It should do something like this
Once we have this, add the client in carto-python. Similar to this
Last step, change the exception handler, to something like this:

api_key = self._api_key_manager.get(name)
api_key.touch() #or api_key.refresh_grants()

This looks more complicated than it actually is, but I prefer it as a solution, better than doing non-standard things in a GET method. Apart from that, I might be missing something as I've been writing as things came up to my head

In any case, remember this just solves the case of ensuring publication of maps with right api_key grants.
If the map is not re-published, eventually the API key role might have no grants and the map be broken anyway.

Thanks @alrocar

Fixed in https://github.com/CartoDB/cartoframes/pull/1633, https://github.com/CartoDB/cartoframes/pull/1628. Release 1.0.3


feat: adds unit summaries to listings list to backend

Issue

Addresses #1059 in part

Description
This adds unit summaries to the listings list for use on the frontend browse and filtered pages.
How Can This Be Tested/Reviewed?
Reseed the db locally and see that unitSummaries are on the listings.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have reviewed the changes in a desktop view
[ ] I have reviewed the changes in a mobile view
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have assigned reviewers
[ ] I have run yarn generate:client and/or created a migration if I made backend changes that require them
[ ] I have exported any new pieces added to ui-components
[ ] My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
[ ] Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:
Steps to review a PR:

Read and understand the issue
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@pbn4 ,
I've addressed your changes. There are also a couple of unrelated updates, cleaning assets for seeds and a fix on the public side I noticed.


MSL: An error ResType does not refer to a value when converting GLSL to Metal shader

On MacOS 10.14, I tried to convert SPIR-V to MSL and found an issue that when converting the following GLSL fragment shader, the MSL compiler gives an error:
rogram_source:24:36: error: 'ResType' does not refer to a value
    for (; reverse_bits(1) < 1024; ResType _37, _37._m0 = 10u - 1u, _37._m1 = select(uint(1), uint(0), 10u >= 1u), _26 = float(_37._m0))
                                   ^
program_source:6:8: note: declared here
struct ResType
       ^
program_source:24:44: error: expected ')'
    for (; reverse_bits(1) < 1024; ResType _37, _37._m0 = 10u - 1u, _37._m1 = select(uint(1), uint(0), 10u >= 1u), _26 = float(_37._m0))
                                           ^

The GLSL fragment shader:
void main()
{
 uint uselessOutVariable;
 float data[10];

 for(int i = 1; bitfieldReverse(1) < 1024; 1) {
   if (gl_FragCoord.y < 0.0) {
     _GLF_color = vec4(1.0);
    }
   data[i] = float(usubBorrow(uint(10), 1u, uselessOutVariable));
  }

 if (1.0 < data[1]) {
   _GLF_color = vec4(1.0);
  }
}

MSL obtained by SPIRV-Cross:
fragment main0_out main0(float4 gl_FragCoord [[position]])
{
    main0_out out = {};
    float _57;
    _57 = _58;
    for (; reverse_bits(1) < 1024; ResType _44, _44._m0 = 10u - 1u, _44._m1 = select(uint(1), uint(0), 10u >= 1u), _57 = float(_44._m0))
    {
        if (gl_FragCoord.y < 0.0)
        {
            out._GLF_color = float4(1.0);
            continue;
        }
        else
        {
            continue;
        }
        continue;
    }
    if (1.0 < _57)
    {
        out._GLF_color = float4(1.0);
    }
    return out;
}

Versions:

SPIRV-Cross: git-798282d3038b718282bc634059c1900b3ed02cf5 (Most recent version of this writing)
glslangValidator: Glslang Version: 7.12.3226

Steps to reproduce:

Convert the GLSL shader to SPIR-V using glslangValidator with the command glslangValidator -V sample.frag -o sample.spv
Run the SPIR-V optimizer with the command spirv-opt sample.spv -o sample.opt.spv -O
Validate the optimized SPIR-V with the command spirv-val sample.opt.spv
Convert the optimized SPIR-V to MSL using SPIRV-Cross with the command spirv-cross --msl sample.opt.spv --output result.opt.msl

This Archive.zip contains the original fragment shader, the associated optimized SPIR-V, and MSL shader.
Issue found using GraphicsFuzz.

Likely need to use the recent emit_uninitized_temporary, which was designed to support hoisting temporaries out of continue blocks like this.


[CardMedia] objectFit: cover is not appropriate for iframe

When CardMedia is provided with a component prop of 'video', 'audio', 'picture', 'iframe', or 'img', Material UI automatically adds the following styles to the component:
  /* Styles applied to the root element if `component="video, audio, picture, iframe, or img"`. */
  media: {
    width: '100%',
    objectFit: 'cover',
  },

This is good for image components, but not good for embedded iframes with video. Specifically, on iOS, the video no longer stretches from edge to edge, but only to about 80% of the width, the remaining 20% is blank.
The standard styling for an iframe to show a 16:9 aspect ratio video is shown below:
    root: {
        position: 'relative',
        paddingBottom: '56.25%', // 16:9 aspect ratio
        paddingTop: 25,
        height: 0
    },
    frame: {
        position: 'absolute',
        top: 0,
        left: 0,
        width: '100%',
        height: '100%',
    }

Note that width is already set to 100% and there should be no objectFit style applied.
My suggestion is to remove the addition of width and objectFit styles in case of iframe CardMedia components.

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
Video should stretch edge to edge on all browsers including iOS.
Current Behavior 😯

On iOS, video only stretches to about 80% of the width.
Steps to Reproduce 🕹
See this working demo on iOS (Chorme and/or Safari). You should see a blank area on the right.
https://pxjrk.csb.dev/
Here's the source code for that demo:
https://codesandbox.io/s/cardmedia-ios-issue-pxjrk
Your Environment 🌎

Tech
Version

Material-UI
v4.1.3

React
16.8.6

Browser
iOS Chrome or Safari

TypeScript
3.4.5

etc.

@nareshbhatia Interesting, regarding the width prop, it seems to help. What's the harm? I can reproduce the object-fit issue. I'm wondering, what's the behavior when providing a video or audio element?
Here is one possible approach:
diff --git a/packages/material-ui/src/CardMedia/CardMedia.js b/packages/material-ui/src/CardMedia/CardMedia.js
index cc0e24ca7..93e7d1206 100644
--- a/packages/material-ui/src/CardMedia/CardMedia.js
+++ b/packages/material-ui/src/CardMedia/CardMedia.js
@@ -18,6 +18,9 @@ export const styles = {
     // ⚠ object-fit is not supported by IE 11.
     objectFit: 'cover',
   },
+  iframe: {
+    objectFit: 'fill',
+  },
 };

 const MEDIA_COMPONENTS = ['video', 'audio', 'picture', 'iframe', 'img'];
@@ -40,6 +43,7 @@ const CardMedia = React.forwardRef(function CardMedia(props, ref) {
         classes.root,
         {
           [classes.media]: isMediaComponent,
+          [classes.iframe]: Component === 'iframe',
         },
         className,
       )}

Another one:
diff --git a/packages/material-ui/src/CardMedia/CardMedia.js b/packages/material-ui/src/CardMedia/CardMedia.js
index cc0e24ca7..d287f7ea1 100644
--- a/packages/material-ui/src/CardMedia/CardMedia.js
+++ b/packages/material-ui/src/CardMedia/CardMedia.js
@@ -15,6 +15,8 @@ export const styles = {
   /* Styles applied to the root element if `component="video, audio, picture, iframe, or img"`. */
   media: {
     width: '100%',
+  },
+  img: {
     // ⚠ object-fit is not supported by IE 11.
     objectFit: 'cover',
   },
@@ -40,6 +42,7 @@ const CardMedia = React.forwardRef(function CardMedia(props, ref) {
         classes.root,
         {
           [classes.media]: isMediaComponent,
+          [classes.img]: ['picture', 'img'].indexOf(Component),
         },
         className,
       )}

Do you have a specific implementation in mind?

@oliviertassinari no harm in adding width: 100%, it's just that for getting the standard 16:9 aspect ratio, I would have to supply the additional styles to the frame anyway:
frame: {
        position: 'absolute',
        top: 0,
        left: 0,
        width: '100%',
        height: '100%',
    }

The above styles happen to be a defacto standard for the getting videos in iframes (google for it and you will get multiple hits with the same answer), so I wouldn't want half the styles in CardMedia and other half in application code. TL;DR - no harm in setting width: 100% in CardMedia.
As for objectFit: fill, I have mixed feelings. Give the standard set of styles above, there is no need for objectFit at all, so why add an unnecessary style. I can't tell in which use case it may fail.
The reason I am leaning towards CardMedia not adding anything additional for iframe is that the current approach of adding these styles automatically came as a total surprise. It took quite a lot of time to debug (literally had to download the iOS simulator to see which style was causing the issue).
If I were to choose between your proposed approaches, I would go with the first. But I would still prefer the approach where CardMedia adds nothing for iframe and lets the app decide what it wants - it gives better control with no surprises.

If I were to choose between your proposed approaches, I would go with the first.

My preferred approach so far is the last one. I like how it doesn't introduce any breaking change, and how it only applies the necessary style properties.
What's wrong with the introduction of a img style rule?

I am good with the second approach too - introduction of an img rule. We just need to document what each component type is doing to the styling.

OK great, unless somebody has a better proposal, we can go for it. My concern with the initial proposal is the breaking change impact potential. Maybe I'm wrong, it's not a BC?

@oliviertassinari I'd like to work on this.

@neon98 I know you asked Olivier but it would be great if you worked on it :) Let us know if you need any help.

hey @joshwooding! I've submitted the PR with suggested changes. Feel free to look into it.

[_****_](

[ ] @

[ ] @ #1. url
Duplicate of #

)


Query about cell padding

Hi, I recently went through your portfolio due to some issues regarding my own website.
Then I came through the container part of the program, there is no proper padding when two photos are inserted to a single container.
It seemed to be merged, but its only a suggestion about this issue.
@rajaprerak If this issue(not specifically) would be resolved it would be great.

Hello @rajaprerak ,
I hope you are doing well.
Actually I want to work on open source project  and I will be grateful if you will provide me an opportunity working on your project and resolving this issue if you consider it .
Best Regards
Amisha


The "Symfony\Component\Console\Command\Command::$defaultName" property is considered final.

The "Symfony\Component\Console\Command\Command::$defaultName" property is considered final. You should not override it in "Contentful\ContentfulBundle\Command\Delivery\InfoCommand".
The "Symfony\Component\Console\Command\Command::$defaultName" property is considered final. You should not override it in "Contentful\ContentfulBundle\Command\Delivery\DebugCommand".

Resources:

https://github.com/rectorphp/rector-symfony/blob/main/docs/rector_rules_overview.md#commandpropertytoattributerector
https://symfony.com/doc/current/console.html

Fixed in #62.

v7.2 somewhat addresses this, but we can't switch to the new syntax yet as it's not supported in PHP7 and therefore not in Symphony 5.4.

@Sebb767 What is the new syntax if you're on PHP8 ?


black autoformating

Description
What steps will reproduce the problem?

There was a problem using black for autoformating (I could use it once by the default keyboard shourtcut, but when I changed it it stopped to run, even with the default one).
Spyder crashes when I unchecked "enable code style linting"
Traceback
Traceback (most recent call last):
  File "C:\Users\Bassam\anaconda3\envs\tf-gpu27-py39\lib\site-packages\spyder\plugins\editor\plugin.py", line 421, in _rpc_call
    meth(*args, **kwargs)
  File "C:\Users\Bassam\anaconda3\envs\tf-gpu27-py39\lib\site-packages\spyder\plugins\editor\plugin.py", line 1287, in update_source_menu
    state = self.get_option(opt, section=section)
  File "C:\Users\Bassam\anaconda3\envs\tf-gpu27-py39\lib\site-packages\spyder\api\plugins\old_api.py", line 111, in get_option
    return super(BasePlugin, self)._get_option(option, default,
  File "C:\Users\Bassam\anaconda3\envs\tf-gpu27-py39\lib\site-packages\spyder\plugins\base.py", line 71, in _get_option
    return CONF.get(section, option, default)
  File "C:\Users\Bassam\anaconda3\envs\tf-gpu27-py39\lib\site-packages\spyder\config\manager.py", line 459, in get
    raise cp.NoOptionError(option, section)
configparser.NoOptionError: No option ('editor', 'underline_errors') in section: 'editor'

Versions

Spyder version: 5.2.1
Python version: 3.9.7
Qt version: 5.12.9
PyQt5 version: 5.12.3
Operating System: Windows 10

Dependencies
# Mandatory:
atomicwrites >=1.2.0          :  1.4.0 (OK)
chardet >=2.0.0               :  4.0.0 (OK)
cloudpickle >=0.5.0           :  2.0.0 (OK)
cookiecutter >=1.6.0          :  1.7.3 (OK)
diff_match_patch >=20181111   :  20200713 (OK)
intervaltree >=3.0.2          :  3.0.2 (OK)
IPython >=7.6.0               :  7.30.1 (OK)
jedi >=0.17.2;<0.19.0         :  0.18.1 (OK)
jellyfish >=0.7               :  0.8.9 (OK)
jsonschema >=3.2.0            :  4.3.1 (OK)
keyring >=17.0.0              :  23.4.0 (OK)
nbconvert >=4.0               :  6.3.0 (OK)
numpydoc >=0.6.0              :  1.1.0 (OK)
paramiko >=2.4.0              :  2.8.1 (OK)
parso >=0.7.0;<0.9.0          :  0.8.3 (OK)
pexpect >=4.4.0               :  4.8.0 (OK)
pickleshare >=0.4             :  0.7.5 (OK)
psutil >=5.3                  :  5.8.0 (OK)
pygments >=2.0                :  2.10.0 (OK)
pylint >=2.5.0                :  2.12.2 (OK)
pyls_spyder >=0.4.0           :  0.4.0 (OK)
pylsp >=1.3.2;<1.4.0          :  1.3.3 (OK)
pylsp_black >=1.0.0           :  1.0.1 (OK)
qdarkstyle =3.0.2             :  3.0.2 (OK)
qstylizer >=0.1.10            :  0.2.1 (OK)
qtawesome >=1.0.2             :  1.1.1 (OK)
qtconsole >=5.2.1;<5.3.0      :  5.2.2 (OK)
qtpy >=1.5.0                  :  1.11.3 (OK)
rtree >=0.9.7                 :  0.9.7 (OK)
setuptools >=49.6.0           :  59.6.0 (OK)
sphinx >=0.6.6                :  4.3.1 (OK)
spyder_kernels >=2.2.0;<2.3.0 :  2.2.0 (OK)
textdistance >=4.2.0          :  4.2.2 (OK)
three_merge >=0.1.1           :  0.1.1 (OK)
watchdog >=0.10.3             :  2.1.6 (OK)
zmq >=17                      :  22.3.0 (OK)

# Optional:
cython >=0.21                 :  None (NOK)
matplotlib >=2.0.0            :  3.5.1 (OK)
numpy >=1.7                   :  1.21.4 (OK)
pandas >=1.1.1                :  1.3.5 (OK)
scipy >=0.17.0                :  1.7.3 (OK)
sympy >=0.7.3                 :  None (NOK)

Hi @BassamAbdellatif,
Do you mean that Spyder is crashing just by unchecking the option enable code style linting? Or did you change other thing in preferences?

Dedar Stephannie,
I am trying to reformat my python code with Black through Spyder. The
shortcut, listed in spyder preferences, works once or twice. After that it
stopped working. I tried to change back to pep8 autoformatting, and forth
again with black ... but Spyder crashes when enabling/disabling "enable
code style linting" from "Code style and formatting" under "completion and
linting".
I still can not do the style formatting gradually (selected code only) from
within Spyder.
Thanks in advance
Best regards
On Tue, Dec 21, 2021 at 5:50 AM Stephannie Jimenez Gacha <
@.***> wrote:

Hi @BassamAbdellatif https://github.com/BassamAbdellatif,
Do you mean that Spyder is crashing just by unchecking the option enable
code style linting? Or did you change other thing in preferences?
—
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/17055#issuecomment-998448294,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APDDYX2VCDFYYYSA6WC5ZFDUR72Q5ANCNFSM5KNV57DA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--
This message and any attachments are intended for the use of the addressee
or addressees only. The unauthorised disclosure, use, dissemination or
copying (either in whole or in part) of its content is not permitted. If
you received this message in error, please notify the sender and delete it
from your system. Emails can be altered and their integrity cannot be
guaranteed by the sender.
Please consider the environment before printing this email.

Can you please post here a gif with the error to see if I can reproduce it on my end?

Closing due to lack of response.


[system] Extend breakpoints with "not" operator

Allow to easily create styles, which are the inverted version of the only operator
Updated the documentation and included tests
This change is related to issue #29228

[x] I have followed (at least) the PR section of the contributing guide.

I have resolved the problems you mentioned, thank you!
Is it okay this way?


IpRep and GeoIP Playbooks giving null value error

After importing both Get-IPReputation and Get-GeoFromIpAndTagIncident from the git and running against an incident both playbooks report the following error at the "For each 2" loop:
ExpressionEvaluationFailed. The execution of template action 'For_each_2' failed: the result of the evaluation of 'foreach' expression '@body('Alert_-_Get_incidents')?['value']' is of type 'Null'. The result must be a valid array.
screen shot from Get-IPReputation

screen shot from Get-GeoFromIpAndTagIncident

There was an update to the azure sentinel logic app connector. I will update the templates this week and publish a new pull request.


Improve run command output

Run command was too much verbose (we can't click on links, etc.)
Now it can be easily read from:
== Project standards-insights
🚨 Check go-version-latest FAILED
	category: upgrade
	runbook_url: XXXX
	severity: critical
	Message: pattern go 1.22 not found in file go.mod
✅ Check go-deprecated-libs PASS
	category: libraries
	runbook_url: XXX
	severity: major
🚨 Check renovate-bot FAILED
	category: libraries
	level: gold
	runbook_url: XXXX
	severity: minor
	Message: file renovate.json does not exist

#sre


LB not removed when running as module

Hi,
i just ran into an issue where the LB is not removed.
This happened when running as a terraform-module and it seems this is related to the destroy_traefik_loadbalancer using ${module.path}/.. for the kubeconfig?
when removing the on_failure = continue it results in:
│ Error: local-exec provisioner error
│
│   with module.rvg.null_resource.destroy_traefik_loadbalancer,
│   on modules/kube-hetzner/main.tf line 127, in resource "null_resource" "destroy_traefik_loadbalancer":
│  127:   provisioner "local-exec" {
│
│ Error running command 'kubectl -n kube-system delete service traefik --kubeconfig modules/kube-hetzner/kubeconfig.yaml
│ ': exit status 1. Output: error: stat modules/kube-hetzner/kubeconfig.yaml: no such file or directory

regards,
strowi

Good find @strowi, good find, don't hesitate to submit a PR.
Otherwise, will fix ASAP. If I remember correctly there are other places in the code where this problem was fixed.

Fixed in #191, and fix included in v1.1.9.


FieldPanel should use SlugInput widget for Slugfield by default - necessary for correct auto-slugifying titles

Is your proposal related to a problem?
Not a problem, just an inconvenience ;-)
To correctly auto-update a slug field from a title field, it currently requires adding widget=SlugInput to the slug FieldPanel declaration. Without this, the title text is just copied without being slugified.
    title = models.CharField(
        max_length=255,
        verbose_name=_("Menu Title"),
        help_text=_("A descriptive name for this menu (not displayed)")
    )
    slug = models.SlugField(unique=True)

    panels = [
        TitleFieldPanel("title"),
        FieldPanel("slug"),
    ]

Describe the solution you'd like
Specifying the SlugInput widget for the slug field fixes this:
from wagtail.admin.widgets.slug import SlugInput
....
    panels = [
        TitleFieldPanel("title"),
        FieldPanel("slug", widget=SlugInput),
    ]

For fields of type SlugField, FieldPanel should select SlugInput for the widget by default.

@enzedonline what wagtail version are we talking about here. Cause it appears if there was this issue it might have been fixed in later versions of Wagtail. Version 5.1.1, 5.2 I tested locally displays the expected behaviour.

@enzedonline was this in a page model or a non-page model?
By the looks of your screenshot, I'm guessing this is a non-page model.
I think we only set the slug widget on Page models.
I'm not sure on a global default, I guess we do that for tags, dates, choosers and others though.

I've had a recent issue with my CategoryPage model that uses custom TabbedInteface this way:
content_panels = BasePage.content_panels + [
        FieldPanel("description"),
        # ...
    ]

    autodiscovery_panels = []  # many panels here
    promote_panels = [
        MultiFieldPanel(
            [
                FieldPanel("slug", widget=SlugInput),   # Without explicitly defined widget field wasn't working
                FieldPanel("seo_title"),
                # ...
            ],
            _("Common page configuration"),
        )
    ]

    edit_handler = TabbedInterface(
        [
            ObjectList(content_panels, heading=_("Content")),
            ObjectList(promote_panels, heading=_("Promote")),
            ObjectList(autodiscovery_panels, heading=_("Products autodiscovery")),
            ObjectList(
                BasePage.settings_panels, heading=_("Settings"), classname="settings"
            ),
        ]
    )

For some reason FieldPanel("slug") did not pick up the proper widget automatically. Thankfully I was quickly saved by awesome chat support on Slack.

@Temidayo32 it's on Wagtail 5.0.x and 5.1.x, since the synchronisation switched to using Stimulus
@LB yes, this is a snippet model

I just came across this again on a site that had recently been upgraded to 5.x
The promote panel for all pages had always been defined with:
    promote_panels = [
        MultiFieldPanel([
            FieldPanel('slug'),
            FieldPanel('search_image'),
            FieldPanel('seo_title'),
            FieldPanel('search_description'),
        ], _('SEO Page Configuration')),
        MultiFieldPanel([
            FieldPanel('search_engine_index'),
            FieldPanel('search_engine_changefreq'),
            FieldPanel('search_engine_priority'),
        ], _("Search Engine Indexing")),
    ]

The auto slug had stopped slugifying and just copied the title instead. I needed to add the SlugInput widget to remedy.

Adding needs design decision to get feedback from others in the core team.

Discussed in today’s core team meeting – happy for SlugInput to be the default widget for SlugField. Less friction for devs. Clear way to opt out. Needs to be flagged in release notes so the change is clear.

I am not sure on the best way to do this

I was thinking about this as well.

whether we add the widget in the base Page field definition here

I don't think it's possible to set the widget on the Page model (model fields do not accept a widget kwarg, form fields do).

Or on the model's meta widgets (but we are not doing that for Page that I can see at all).

Nor is this possible, I believe Meta.widgets is only available in the ModelForm class, not the model itself.

Or maybe we use a similar approach to how we work with date widgets.

This is one way to do it, but the downside is that it will be applied to all SlugFields by default, not just Page.slug. I don't think it's ideal.
I think the right way to do this would be somewhere in the WagtailAdminPageForm:
https://github.com/wagtail/wagtail/blob/0024751a5380ee36c99b31e77fe4e52c8d586110/wagtail/admin/forms/pages.py#L132
which is nice because the CopyForm mentioned in a previous comment is placed just above this class.
That said, I haven't checked whether this will work or not, considering that the slug is defined via a FieldPanel. As in, I'm not sure if FieldPanel will automatically pick up the widget we define in WagtailAdminPageForm, or if it will override it with some other default widget for example.

Good to hear this will be implemented. Thanks for that.
It's important that this also happens when used on snippets, it's common to need an auto slug field in non-page models.

Ah, I just realised the SlugInput is only responsible for slugifying the input and not auto-syncing with the title field (or at least only half-responsible for that, the other half needs to be done via SyncController which is applied in TitleFieldPanel by default).
In that case, I think the registering the form field override makes sense, which ensures it's also picked up on Snippets (and anything that uses WagtailAdminModelForm).

PR up for review https://github.com/wagtail/wagtail/pull/11341


fix: Separator height

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Closes #5045
[ ] Requires deployment <>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </bsx/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

color to black please, otherwise ok 👍

color to black please, otherwise ok 👍

I also wonder which color should the separator line to be in dark mode.

@Jarsen136
ah, ic.
So, the top one should be solid black - there outlining the box so its not actual separator, but the ones that are not full width are k-grey
dark mode for this stays k-grey

soo, this to k-grey, in dark mode as well
the rest to k-black please
sorry for the confusion :D

@Jarsen136 ah, ic. So, the top one should be solid black - there outlining the box so its not actual separator, but the ones that are not full width are k-grey dark mode for this stays k-grey  soo, this to k-grey, in dark mode as well
the rest to k-black please - in dark mode white
sorry for the confusion :D

Thanks for your clarification. Fixed now

@exezbcz is it visually ok?

@vikiival yes


The descriptions for MSAL are not localized on Settings

Storage Explorer Version: 1.11.1
Build: 20191203.1
Branch: master
Language: Chinese(zh-CN) / Chinese(zh-TW)
Platform/OS: Windows 10/ Linux Ubuntu 18.04/macOS High Sierra
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Launch Storage Explorer.
Open 'Settings' -> Application (Regional Settings) -> Select '中文 (简体)' -> Restart Storage Explorer.
Open '设置' -> 应用程序 ->登录.
Check the descriptions for MSAL.

Expect Experience:
The descriptions for MSAL are localized.
Actual Experience:
The descriptions for MSAL are not localized.

Added 11hours ago.
https://devdiv.visualstudio.com/DevDiv/_git/StorageExplorer/commit/b896f2d0081f96a6c04087c08b5d8d5d31f789f9?_a=compare&path=%2Fsrc%2FStandalone%2Fresources%2Fzh-Hans%2FShell.json

We'll need to validate once it has been translated

On translation now.
File: loc\en\src\Standalone\resources\Shell.json
ID: 0; "DescriptionSignInMSAL"
SRC: If enabled, Storage Explorer will use the new Microsoft Authentication Library (MSAL). Storage Explorer must be restarted for this setting to be applied.\n\nMSAL provides enhanced single sign on, multi-factor authentication, and conditional access support. The MSAL account store is separate from the default authentication library account store, so the first time you use MSAL you will need to sign in. Additionally Azure AD attached connections and some Quick Access items will not work when switching between enabling and disabling MSAL.


feat: internal pre and post creation and post authentication triggers

closes #4908

[ ] I am happy with the code
[ ] Short description of the feature/issue is added in the pr description
[ ] PR is linked to the corresponding user story
[ ] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[ ] No debug or dead code
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[ ] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] Functionality of the acceptance criteria is checked manually on the dev system.

@adlerhurst can you please help me with the linting errors? I can't reproduce them locally.

@adlerhurst can you please help me with the linting errors? I can't reproduce them locally.

Im not aware of goland. The errors are because of wrong formatted imports. You should see the same errors if you run it locally using golangci-lint run ./...

@adlerhurst can you please help me with the linting errors? I can't reproduce them locally.

Im not aware of goland. The errors are because of wrong formatted imports. You should see the same errors if you run it locally using golangci-lint run ./...

Yeah, it don't.

@adlerhurst ctx.v1.ctx has neighter writable nor readable fields. Both (sub-)context fields key and value are unexported.
Example for the instance ID (note the unexported val field):


Auto-create module

My configuration is as follows:
Entry points to include all templates:
    templates: glob.sync("./src/app/**/*.tpl.html"),
Loader to add templates to module:
{
        test: /\.tpl\.html$/,
        loader: 'ngtemplate?module=myapp.templates&relativeTo=' + (path.resolve(__dirname, '/src/app')) + '/!html'
       },

Load order:

Vendor, Templates, App.

This is because the app 'requires' the templates module. I need a way to ask ngtemplate to create the myapp.templates module for me. Is this possible?

your myapp.templates module is created by ngtemplate-loader indeed. But you have to add the module name to your app dependencies manually.
if i understand your problem correctly


Corrected/Updated A Bit

There was no space between a comma and then a word, so I changed it to make it better and a little more accurate by adding the word "images" and changing "document" to "text."
Description
Check the file to see how it is better.

Corrects an error and updates some stuff.

Fixes

Thank you, will send a tip over on Discord!

Wow! Thanks!


Add hdf5

Official?
CMake port? https://github.com/mmarat/hdf5-v16-cmake

Used by: https://github.com/ruslo/hunter/issues/79

@ruslo I have made an initial attempt at porting hdf5 to hunter, it would be great to get some feedback before I create a pull request.
I have started from the official svn repos at
https://svn.hdfgroup.uiuc.edu/hdf5/tags/hdf5-1_8_15
https://svn.hdfgroup.uiuc.edu/szip/tags/szip-hdf5-1.8.15
I've patched the cmakes to use a hunter version of zlib and szip and then uploaded a tarball of the source code to https://github.com/oliverdaniell/hunter-projects
I've create a branch with the projects here
https://github.com/oliverdaniell/hunter/tree/v0.11.6-develop/
It can be tested from this release https://github.com/oliverdaniell/hunter/releases/tag/v0.11.6-seebyte-p5 using the examples/hdf5 folder

I've patched the cmakes to use a hunter version of zlib and szip and then uploaded a tarball of the source code to

Let's do it in more centralized fashion. I've created two projects:

https://github.com/hunter-packages/hdf5
https://github.com/hunter-packages/szip

and added you to the team so you have full access to this repositories.
hdf5 release uploaded as a binary: https://github.com/hunter-packages/hdf5/releases/download/v1.8.15/hdf5-1.8.15-hunter.tar.gz
same for szip: https://github.com/hunter-packages/szip/releases/download/v2.1.0/szip-2.1.0-hunter.tar.gz
Also I guess the best alternative is to have some automatic svn -> git converter so we have smooth update procedure and native github released with tags and merges.

It can be tested from this release https://github.com/oliverdaniell/hunter/releases/tag/v0.11.6-seebyte-p5 using the examples/hdf5 folder

This looks good from the first view. Please send me one pull request per package.

I've set-up https://github.com/hunter-packages/szip as a remote for my local branch but I'm getting a permission denied error. Are the permissions set up properly or am I missing a step?

but I'm getting a permission denied error

Are you trying to make a pull or push? Pull should work fine. If you want to push you have to accept invitation first so you'll be added to team. Currently your invitation has status "Pending".

If you want to push you have to accept invitation first
Got it, Thanks!

Pull request for szip https://github.com/ruslo/hunter/pull/206

Please could you create a pre-release for use in the hdf5 package

Done: https://github.com/ruslo/hunter/releases/tag/v0.12.1

hdf5 pull request https://github.com/ruslo/hunter/pull/208

Once https://github.com/ruslo/hunter/pull/208 is merged we can close this bug

Once #208 is merged we can close this bug

@oliverdaniell Merged, thanks again


modular structure

What is structure i should use, if I make modular application.
For example:
My application will contain

tasks

calendar

mail

Let assume you are now random internet citizen reading your question. Would you really get what are you asking about without any previous context or information? I believe it make sense in your head but sure does not in mine. Can you provide some additional information, what problems are you facing, maybe a bit of code then I am sure people will help you out. I recommend reading about fractal project structure it might be what are you looking for or look at older versions of this project which was then structured differently and pick between these two you can't go wrong

Thanks for the response @GustavRitsch , I appreciate you jumping on this.
@kodermax the issues for this project is not the best place to post questions like this. I'm sure people would love to help, but you'll have better luck on StackOverflow or in our gitter channel (https://gitter.im/davezuko/react-redux-starter-kit). Closing since there is no action to be taken.


WIP - Experimental selenium driver

This is a work in progress to add selenium support and allows the existing test suite to be run against a local instance of geckodriver or chromedriver. This is definitely a work in progress, but will show us how the existing test suite runs against different webdriver backends.

I'd also be interested in how you'd like to see the driver modules designed. Should I be writing each one of the browser interaction functions (like visit, click, etc) in each module to make them easier to customize behavior per driver? Since chromedriver is different than geckodriver and phantomjs (and Appium for that matter), should I have one driver per backend? If so, do you think each module should do something like use Wallaby.WebDriver.Driver to share common boilerplate and then override functions when we need to change something? I'm not sure if using use Wallaby.WebDriver.Driver to share boilerplate functionality would make things to confusing.
I'm looking forward to hearing your ideas so I can build it right the first time.

I think for now we shouldn't try to share functionality between the different driver implementations. Once we have multiple implementations we can see exactly where the common code / patterns are and we can use shared code at that point. Its easier to remove common code once you can see all of it.
For now it would be a good idea to share a common api between the drivers. We should create a behaviour that each driver needs to conform to. If you want I can work on that tonight. Then we can use that as a basis for the other drivers.

I was thinking all of the drivers would share the following functions:
create_session/2
delete_session/1
find_elements/2
set_value/2
clear/1
click/1
text/1
page_title/1
attribute/1
visit/2
current_url/1
current_url!/1
current_path!1/1
selected/1
displayed/1
displayed!/1
size/1
rect/1
take_screenshot/1
cookies/1
set_cookies/3
set_windows_size/3
get_windows_size/1
execute_script/3
send_keys/2
log/1
accept_dialogs/1
dismiss_dialogs/1
accept_alert/2
accept_confirm/2
dismiss_confirm/2
accept_prompt/3
dismiss_prompt/2

If a driver didn't support one of these functions, we could return {:error, :unsupported_command} or raise an exception. Is that what you were thinking?

That looks about right. I think we can get rid of the ! functions. Once #95 lands (which I think @krankin is working on) we can remove logs from that list as well.

I just checked in the Wallaby.Driver behavior and switched Wallaby.Element and Wallaby.Browser to get the current driver off the session in #201. I think this will make adding a Selenium driver much easier.

I finally got the tests passing and this is code should be ready for a review. 🎉
There's quite a bit of changes here, so it might be worth reviewing commit by commit. Here are the highlights.

First and foremost I added Wallaby.Experimental.Selenium. It has most of the basic test cases working but there are a few things I haven't had time to port over from phantomjs. Those are dialogs, getting the file upload tests to work with selenium and screenshots (I don't think selenium supports them).
I set up the build to run the unit tests, and then integration tests for phantom, selenium 2, and selenium 3. It took some tinkering in start_webdriver.sh but I think I have a good build environment now. Here's the build matrix on Travis.

I've gone through and fixed several issues with integration tests that have come up since I started running them against Selenium. The biggest issue was selenium doesn't wait until the page loads (after visit, clicking a link, or clicking a button) before it runs the next command. That was giving us a lot of failures when asserting with the current_url function. The way I solved this was to create a couple page objects with ensure_page_loaded/1 functions that use find/2 to wait until the page has loaded successfully before continuing. I'm sure we can expand the page object paradigm if we want, but this seemed like an ok way to get the tests working.

There's definitely still more to do on this driver (like handling weird responses from BrowserStack), but I am hoping to get this code merged into master so the PR doesn't get huge as I fix more and more issues. I set it to @moduledoc false and it's under the Wallaby.Experimental namespace, so people should realize that it's not ready for primetime, yet. Please let me know if you'd like any changes and I'd love to get it merged as soon as we can.

@aaronrenner Regarding the issue with selenium waiting for page loads we may need to look at this: https://www.w3.org/TR/webdriver/#navigation

@keathley I looked into the webdriver pageLoadStrategy setting that you mentioned in your link, but I am still getting issues with tests to check the current page using the currentUrl function. I was thinking we could add a function like IndexPage.loaded?/1that would find a unique element on the page to ensure the expected page has loaded. Maybe that's something that could be done as part of removing the deprecated Browser.click_button work.
Please let me know if there's anything else you'd like to see on this PR. I think it should be good to go as soon as #209 is merged.

I think I finally took care of the flake tests and it's ready to merge. I added some retry logic to SessionCase.start_test_session and made it so Selenium.start_session can better handle error tuples. Let me know if you see anything else I missed.

I was sort of thinking about giving this another look but honestly 1000 lines is a bit more than my casual evening read :D
If you're both :+1: on it then I'm in as well, otherwise I might get to look at it on the weekend but no promises. :)

Sorry it's such a big PR. I'll make my next one much smaller. 😄

Ran through it one last time. Looks good to me :+1:


Can't move the image vertically in default Android browser

Using version 4.4.2.
Moving fine horizontally.
Moving fine in both directions in Chrome on Android, but not in the default browser.

The same issue on mozilla for android. Moving it vertically scrolls the window

yes. this. same issue with vertical scrolling in default browser and adblock browser.


Added => Data Structures => Tree => Binary_Tree => Right_View => right_view_of_binary_tree.cpp

Assigned Issue Number ?
#1247
Language Opted ?
C++
Number of files added or updated ?
1
Name of these files ?
algo_ds_101 => Data Structures => Tree => Binary_Tree => Right_View => right_view_of_binary_tree.cpp
Checklist

[x] I've read the contribution guidelines.
[x] I've referred the correct issue number.
[x] I've fill up this entire template correctly.

Hi, @ahampriyanshu just wanted to clarify do you mean like this, ie. taking an example tree?
(This is a PR you've accepted)

I've made changes, @ahampriyanshu please review. Thanks.


[Service Bus] Remove tokenProvider from NamespaceOptions used for creating Namespace

Below is the declaration for NamespaceOptionsBase, NamespaceOptions and the 3 different static functions to create a Namespace

Few observations:

The only reason we have the NamespaceOptionsBase and NamespaceOptions separate is to cater to the createFromTokenProvider
The tokenProvider passed to createFromAadTokenCredentials is never used.
Why does createFromConnectionString even support the case of user provided tokenProvider? Can such users not use the createFromTokenProvider directly? Is there a case where one would want to use a connectionString as well as their own tokenProvider?

Fixed with #1422


Add Dygraph support

when using Paddle 2.x, enable static mode

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.daisongtai seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


qemu test cluster: DNS + password

Enhances password strength and makes DNS servers configurable.

I tried to test forcing known older version to get at least v1.11 working, but I get:
Is it so that older Clear gets newer Docker that  it can handle?
i.e. we can not turn back all the aspects of the history but only some, right.
...
        [WARNING SystemVerification]: unsupported docker version: 18.06.1
[preflight] The system verification failed. Printing the output from the verification:
KERNEL_VERSION: 4.18.16-296.kvm
CONFIG_NAMESPACES: enabled
CONFIG_NET_NS: enabled
CONFIG_PID_NS: enabled
CONFIG_IPC_NS: enabled
CONFIG_UTS_NS: enabled
CONFIG_CGROUPS: enabled
CONFIG_CGROUP_CPUACCT: enabled
CONFIG_CGROUP_DEVICE: enabled
CONFIG_CGROUP_FREEZER: enabled
CONFIG_CGROUP_SCHED: enabled
CONFIG_CPUSETS: enabled
CONFIG_MEMCG: enabled
CONFIG_INET: enabled
CONFIG_EXT4_FS: enabled
CONFIG_PROC_FS: enabled
CONFIG_NETFILTER_XT_TARGET_REDIRECT: enabled (as module)
CONFIG_NETFILTER_XT_MATCH_COMMENT: enabled (as module)
CONFIG_OVERLAY_FS: enabled (as module)
CONFIG_AUFS_FS: not set - Required for aufs.
CONFIG_BLK_DEV_DM: enabled
DOCKER_VERSION: 18.06.1
OS: Linux
CGROUPS_CPU: enabled
CGROUPS_CPUACCT: enabled
CGROUPS_CPUSET: enabled
CGROUPS_DEVICES: enabled
CGROUPS_FREEZER: enabled
CGROUPS_MEMORY: enabled
[preflight/images] Pulling images required for setting up a Kubernetes cluster
[preflight/images] This might take a minute or two, depending on the speed of your internet connection
[preflight/images] You can also perform this action in beforehand using 'kubeadm config images pull'
[preflight] Some fatal errors occurred:
        [ERROR ImagePull]: failed to pull image [k8s.gcr.io/etcd-amd64:3.2.18]: exit status 1


One click creation of local validator/faucet

Motivation
Add functionality for #7477 - one click creation of local validator/faucet, one bash script to connect the client to it
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
run docker composes/bash
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/diem/diem/tree/master/developers.diem.com, and link to your PR here.)

@CapCap I noticed that this PR is still in a draft state, which indicated to me that you're still iterating, when you're ready for me to that a look at this move it out of a draft state and let me know!


Feature/wsdev 808 timeline block

Please review and let me know if there is room to improve.
Thanksss

Looks great. Great job!


fix: different domains seo links

Closes: #1167
Edit: I know that I've removed the check for SSL in SSR but I think there is no reason to force that check, maybe making by default HTTPS will be better, not sure.
Another option would be adding secure: true, then forcing HTTPS links by default but you're against that 😄.
Thanks!

Thanks


Add dark mode feature.

Hi!! I am interested to work on this.

please put relevant screenshots during PR

Hello, I have been working on this and I have some queries.. how can I contact you? Discord or somewhere


Create Release Data for Registry Viewer Konflux Component

Which area is this issue related to?

/area ci
/area registry-viewer
Issue Description

As with #1649 and #1640, we'll need to add the release data needed to build and publish a release image for the registry viewer component.
Acceptance Criteria

[X] Change the ReleasePlanAdmission to include the registry-viewer component
[X] Create the tenant data for the registry-viewer component

Merge request for these changes are ready for review.

Set story points to 1 day to complete release data in merge request


pyenvLocator.ts seems to not recognize recent PyPy3 pattern

on Windows the pattern is like below, and seems "missed"
pypy3.7-v7.3.5rc3-win64\pypy3.exe
pypy3.7-v7.3.5-win64\pypy3.exe

indeed, I have parametrized "settings.json" like this
{
"python.interpreterPath": "${env:WINPYDIR}\\\\pypy3.exe",
"jupyter.widgetScriptSources": [
"jsdelivr.com",
"unpkg.com"
],
}

.... pypy3.exe is not said "found"

if I copy "pypy3.exe"  to "python.exe" ... miracle (greuuuuuuuuh)

I would suppose the problem is in there ?
https://github.com/microsoft/vscode-python/blob/main/src/client/pythonEnvironments/discovery/locators/services/pyenvLocator.ts

We don't support detecting and using pypy. This would be a feature request on the extension.
In the pyenvLocator code, we parse the version information as a best effort. But we don't switch the executable type we look for internally to pypy3.exe. s


How to apply dark mode?

How do I apply dark mode? I can't find it in the documentation, but I see it's listed as a feature.

Hi @tdotdm, Drops uses the system-wide appearance, it appears in light/dark mode based on the system's settings
There is not way to toggle this for Drops only at the moment


STM32H745 SRAM Sections Definition

Define multiple SRAM sections within sram0. With this PR each stm32h745 based board can use either whole sram0 (choose zephyr,sram = &sram0;) or only parts of it (choose zephyr,sram = &ahb_sram1; for example).
This step is necessary toward whole SRAM utilization for projects.
Same behavior for SRAM realized in linux kernel.

@gmarull Thank you for your review. I've prepared changes. Please take a look.

These changes do not follow Linux Kernel docs. In their model, SRAM entries are children with relative addresses, I can't see this structure here neither updated bindings.

Fixed. Please see dts/arm/st/h7/stm32h745.dtsi  within latest push.

A use case should also be provided.

You cane take a look at boards/arm/nucleo_h745zi_q/nucleo_h745zi_q_m4.dts for sample usage.
But generally following use case are possible now:

Choose whole sram0 with 864KiB size for stm32h745:

chosen {
zephyr,sram = &sram0;
};

Choose whole ahb_sram2 with 128KiB size for stm32h745 as part of sram0:

chosen {
zephyr,sram = &ahb_sram2;
};

Other use cases are similar to 1 and 2. Both were tested with my nucleo_h745zi_q board and civetweb/websocket_server sample and working fine for me.

For now i'd suggest carving out the sram region for ethernet and putting a phandle property in the ethernet node that references that sram region.
As far as the other regions go, are you trying to treat them as on large system memory pool?  If so, for now we have to fake that out in DTS.

@galak Thak you for your review

For now i'd suggest carving out the sram region for ethernet and putting a phandle property in the ethernet node that references that sram region.

I would prefer to wait with merge instead, untill we're done wit MPU SRAM  #30403 configuration for ethernet. I will be able update this PR continuously.

As far as the other regions go, are you trying to treat them as on large system memory pool? If so, for now we have to fake that out in DTS.

Yes, the purpos of this PR to give access to all SRAM regions to the Zephyr application, if it needs it. Do you have an example, how to fake it out in DT?

@erwango Can you confirm this memory model works on your board (for example with hello_world and/or civetweb webscoket server)?

@erwango Can you confirm this memory model works on your board (for example with hello_world and/or civetweb webscoket server)?

@gmarull Please review

@gmarull Please review

Closed since not generic

Closed since not generic


Hover is always selected

Don't ask me how I got into this state, but my hover always shows its contents fully selected. We should make sure the entire hover is non selectable.

@Tyriar Is this has to be fixed in hover?

The hover is selectable by design so users can copy the text.

Then make sure selection is cleared when the hover appears.

The element get reconstructed so that should already be happening when you hover another element. Did you perhaps have the entire document selected or something, I'd be hesitant to touch the selection unless it was definitely only contained within the hover.

I haven't been able to repro since. I don't know how I did it.

Closing since it's an edge case without a clear fix


Fix table height

I want to merge this change because we changed table cell sizing in https://github.com/mirumee/macaw-ui/pull/24 and this PR fixes it.
PR intended to be tested with API branch: master
Pull Request Checklist

[ ] This code contains UI changes
[ ] All visible strings are translated with proper context including data-formatting
[ ] Attributes [data-test-id] are added for new elements
[ ] Changes are mentioned in the changelog
[ ] The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://qa.staging.saleor.cloud/graphql/

Task linked: SALEOR-3532 Use padding instead of height in TableCell

Task linked: SALEOR-3287 Use Macaw-UI in both Saleor Cloud and Saleor Dashboard


include charge state array

Hello,
I am trying to parse orbitrap data at the MS1 level to plot charge state distributions. Is there a way to read out charge states from the .raw file and write them to mzML using the default charge state array? I am referring to all peaks, not only precursors.
thank you

Hi @grandrea that will be scheduled for the next release

thank you!


Dudley College of Technology

@Brophy First stage of verification passed, official domain is dudleycol.ac.uk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://dudleycol.ac.uk/student-life/login/


ledger: Fix KeyOriginInfo is not subscritable error

Fixes a bug in Ledger sign_tx implementation which would cause it to error with {"error": "'KeyOriginInfo' object is not subscriptable", "code": -13} during change detection.

I've added a test case for this.

I've added a test case for this.

ACK (assuming you get CI to behave)
This is the same fix I came up with independently in #428, which is always a good sign.

ACK (assuming you get CI to behave)
This is the same fix I came up with independently in #428, which is always a good sign.


TryFlatten seems to be missing an export?

I cannot import it when using it in a type alias. The docs for https://docs.rs/futures/0.3.8/futures/future/trait.TryFutureExt.html#method.try_flatten also have it non-clickable. Is it missing an export from the library?

We need to re-export it.


Fix storing integers

Currently, integers and longs are stored as doubles.
This is different compared to the current behavior of Verify.NewtonsoftJson.

thanks will deploy now