HTTPClientRequest.writeFormBody switched to chunked encoding

I'm not sure this is an "issue" per se, but it caused me some hard to track down regressions in one of my applications so it's likely worth documenting at the very least:
A recent-ish change to HTTPClientRequest.writeFormBody indirectly caused it to switch to "chunked" encoding for the request, due to querying the bodyWriter before setting a content length. Strangely, I can't find this code in the repo, but in my dub-acquired 0.8.0-beta.7 I see:
/** Writes the request body as form data.
*/
void writeFormBody(T)(T key_value_map)
{
	import vibe.inet.webform : formEncode;
	import vibe.stream.wrapper : streamOutputRange;

	headers["Content-Type"] = "application/x-www-form-urlencoded";
	auto dst = streamOutputRange(bodyWriter);
	() @trusted { return &dst; } ().formEncode(key_value_map);
}

Interestingly, form.d has a different version that likely doesn't have the same issue:
/**
	Writes a `vibe.http.client.HTTPClientRequest` body as URL encoded form data.
*/
void writeFormBody(HTTPClientRequest req, in string[string] form)
{
	import vibe.http.form;
	import vibe.stream.wrapper;

	StringLengthCountingRange len;
	writeFormData(&len, form);
	req.contentType = "application/x-www-form-urlencoded";
	req.contentLength = len.count;
	auto rng = streamOutputRange(req.bodyWriter);
	writeFormData(&rng, form);
}

Thus it might be that my repo is strangely out of date or something, but as I mentioned since this is something that didn't fail to compile upon upgrading my vibe version but broke the application (a number of servers my application talks to don't support chunked encoding at all) I figured it was something at least mentioning.
Thanks in advance!

Unfortunately for some reason I didn't mention a context for the change, but the responsible commit is b10ae4750099a6f082b5d6a714a662d7bb8fd02c. The whole vibe.http.form module should be deprecated, though. The core functionality is nowadays in vibe.inet.webform and the convenience wrappers can go into vibe.http.client directly.
I'll fix this and put up another RC for 0.8.0.

Ah thanks for the pointer to vibe.inet.webform, I'll take a look. Is there any example code that uses it offhand? Cheers!

There is a small example in the docs: http://vibed.org/api/vibe.inet.webform/formEncode
Other than that, it's just used directly by the above code in HTTPClientRequest.writeFormBody. I've opened a PR and will tag a new RC for 0.8.0 once that is merged.

Fixed by #1819.


Primary Keys are not handled properly during insertion

Auto incrementing primary keys are not handled properly. Insertion should not include the primary key in the SQL. There is also no way to specify this in the table format.

For Auto incrementing column, you can configure HasDefault associated type in the Table class.
By doing so, that column will be become optional during write(Insert & Update).
Example:
https://github.com/byteally/dbrecord-opaleye/blob/master/test/Spec.hs#L97
https://github.com/byteally/dbrecord-opaleye/blob/master/test/Spec.hs#L206-L214
Currently this lib does not make an assumption that Primary Key Column will also be auto-incrementing (ie. will have Default value). As result auto-incrementing primary column needs to be listed in both PrimaryKey & HasDefault of the Table class

That's fine except when the actual SQL is generated it will create something along the lines of
INSERT INTO table ("id",....) VALUES (DEFAULT, ....)

When it should be generating
INSERT INTO table (...) VALUES (...)

Probably I'm not getting the difference between having the DEFAULT in the insert and skipping that column altogether.
For Eg:
CREATE TABLE "User"
(
  uid serial NOT NULL,
  name text,
  age integer,
  CONSTRAINT uid_primary_key PRIMARY KEY (uid)
)

For the above table, following sql is going to produce the same result.
insert into "User" ("uid", "name", "age") VALUES (DEFAULT, 'foo', 30)
insert into "User" ("name", "age") VALUES ('foo', 30)

As far as generation of sql is concerned, to drop that column altogether, we need to make change in Opaleye library itself as this lib rely on Opaleye's query generation.
Regarding tri state, please refer to the following comment
https://github.com/byteally/dbrecord-opaleye/issues/4#issuecomment-250448569
Can you please clarify on

Write representation needs to allow droppign that entire column from the sql when it's nothing

Probably I'm not getting the difference between having the DEFAULT in the insert and skipping that column altogether.

Sorry, for some reason my table was generated incorrectly and the primary key did not set default nextval('posts_id_seq'::regclass).

However the Write representation needs to allow dropping that entire column from the sql when it's nothing.

What I meant is that there needed to be a way to treat it as if there is no id column at all. Given that everything works now that the table is properly generated, that is no longer important.


pytorch_lightning.utilities.upgrade_checkpoint() fail in case of NO GPU

Bug description
Hi,
we uses Comet and download new modell. By starting the Comet with downloaded models we got the message the checkpoints are outdated. We tried to convert, but also the suggest upgrade_checkpoint failed because on the VM has no GPU assigned. All this happen in creation in Dockerfiles (since we uses COMET).
Finally the only way to solve the issue was to patch
pytorch_lightning.utilities.upgrade_checkpoint()
in an quite hacky way:
sed -i 's/torch.load(file)/torch.load(file,map_location="cpu")/g' /usr/local/lib/python3.10/dist-packages/pytorch_lightning/utilities/upgrade_checkpoint.py
Here we patch line #63
from: checkpoint = torch.load(file)
to checkpoint = torch.load(file,map_location='cpu')
This really not nice and not fault tolerant. So the idea is to have a more configuarebale approach to run tools without have a GPU.
Thanks, Thomas
What version are you seeing the problem on?
1.9.5
How to reproduce the bug
No response
Error messages and logs
Upgrade checkpoint break
Environment

Current environment
#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version (e.g., 1.5.0):
#- Lightning App Version (e.g., 0.5.2):
#- PyTorch Version (e.g., 2.0):
#- Python version (e.g., 3.9):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
#- GPU models and configuration:
#- How you installed Lightning(`conda`, `pip`, source):
#- Running environment of LightningApp (e.g. local, cloud):

More info
No response
cc @awaelchli

@ThommySte
What is the error you get? From which version to which version did you upgrade the checkpoint? It would be good to know this at least so we can reproduce that error.
In your message, you referenced this issue https://github.com/Lightning-AI/lightning/pull/63, but could you provide the full link please?
Changing the map_location='cpu' is possible, but I would still like to see where it goes wrong. Thanks!

Hi,
I have retried-  First the installation of comet pick a version below 2.0:
Collecting pytorch-lightning<2.0.0,>=1.6.4 (from unbabel-comet) Downloading pytorch_lightning-1.9.5-py3-none-any.whl (829 kB)
I run the the upgrade in Ubuntu:2204 Docker build.
The error is:
20:05:07  Traceback (most recent call last):
20:05:07    File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
20:05:07      return _run_code(code, main_globals, None,
20:05:07    File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
20:05:07      exec(code, run_globals)
20:05:07    File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/utilities/upgrade_checkpoint.py", line 90, in <module>
20:05:07      main()
20:05:07    File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/utilities/upgrade_checkpoint.py", line 86, in main
20:05:07      _upgrade(args)
20:05:07    File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/utilities/upgrade_checkpoint.py", line 63, in _upgrade
20:05:07      checkpoint = torch.load(file)
20:05:07    File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 809, in load
20:05:07      return _load(opened_zipfile, map_location, pickle_module, **pickle_load_args)
20:05:07    File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 1172, in _load
20:05:07      result = unpickler.load()
20:05:07    File "/usr/lib/python3.10/pickle.py", line 1213, in load
20:05:07      dispatch[key[0]](self)
20:05:07    File "/usr/lib/python3.10/pickle.py", line 1254, in load_binpersid
20:05:07      self.append(self.persistent_load(pid))
20:05:07    File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 1142, in persistent_load
20:05:07      typed_storage = load_tensor(dtype, nbytes, key, _maybe_decode_ascii(location))
20:05:07    File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 1116, in load_tensor
20:05:07      wrap_storage=restore_location(storage, location),
20:05:07    File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 217, in default_restore_location
20:05:07      result = fn(storage, location)
20:05:07    File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 182, in _cuda_deserialize
20:05:07      device = validate_cuda_device(location)
20:05:07    File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 166, in validate_cuda_device
20:05:07      raise RuntimeError('Attempting to deserialize object on a CUDA '
20:05:07  RuntimeError: Attempting to deserialize object on a CUDA device but torch.cuda.is_available() is False. If you are running on a CPU-only machine, please use torch.load with map_location=torch.device('cpu') to map your storages to the CPU.
20:05:07  The command '/bin/sh -c python3 -m pytorch_lightning.utilities.upgrade_checkpoint /models/eamt22-cometinho-da/checkpoints/model.ckpt &&     python3 -m pytorch_lightning.utilities.upgrade_checkpoint /models/wmt22-comet-da/checkpoints/model.ckpt &&     rm *.tar.gz &&     find /models/ -name "model.bak" -exec rm {} \;' returned a non-zero code: 1

The the hacky patch is enabled the upgrade succeed and the patched checkpoints can be used in COMET

I want to add -  setting map_location='cpu' is not the best solution. Maybe make it configurable or add a reliable detection mechanism is maybe better.

Thanks for posting the error. I suspected this and just wanted to make sure it is due to there being tensors in CUDA. So my suggestion is:

We allow user to convert a checkpoint saved with cuda tensor on a cpu only machine.
If we detect torch.cuda.is_available() == False, we set the map_location to cpu and inform the user.
Additionally, we can make it configurable (as you suggested 🎉 ), because it could be that user converts the checkpoints on a machine with not enough GPU memory available and would prefer conversion to cpu

What do you think?

Thanks, @awaelchli,
for your fast response around my reported issue.
We discussed internally and my colleague agreed that the "configurable" approach fit best in the issue we are facing. Since we use models some others (COMET) have created - we have no way influence the model itself.
I'm not fully sure regarding "detect torch.cuda.is_available()" fits for our problem -  because after installing Comet by using PIP also CUDA is downloaded into the image (but not used -  maybe have to ask the COMET development to make this also configurable on COMET side) -  as described we run it in a virtualized docker container without any GPU on our clusters.


Generate own step payout function

Fixes #2288.
Fixes #1834.
Before this PR, we generated a polynomial payout function which would then be transformed by rust-dlc into a step function. This approach was problematic because we could not trust rust-dlc to not mess with the intervals excessively.
Specifically, any changes to the liquidation intervals could cause problems because they represent the collateral reserves, which are used to indicate available balances and are circumstantially needed to complete features such as position resizing.
Now we take full control of the payout function generation, directly generating a step function that can be consumed by rust-dlc without rounding. The payout is calculated by taking the PNL at the half-way point of the interval.
It is important to emphasise that we must opt out of rounding by using a RoundingIntervals with a single element of the form:
RoundingInterval {
    begin_interval: 0,
    rounding_mod: 1,
}

Overall, I think the code is considerably simpler and there are fewer edge cases to handle.
One important thing to consider is that we can now directly control the number of payouts we generate, which has an effect on the number of CETs that will be created. This is currently set by the constant PAYOUT_CURVE_DISCRETIZATION_INTERVALS, but in the future we could make it dynamic.
Additionally, at the moment the majority of the intervals are of equal length in terms of price. Eventually we might want to generate more, smaller intervals around the starting price, and make the less likely intervals bigger as we approach the liquidation zones.
Other notable changes
Since we had to replace a snapshot, we've introduced a dev-dependency to insta^1, a library that makes it easy to write and maintain snapshot tests. There is a companion tool, cargo-insta^2, which can help with this process.

Running the payout_curve example shows that the hard-coded function has not changed after this patch. On the left is before this patch; on the right, after the patch.

Please excuse the late review.
It's been a while that I've been working on this, so please be kind if this is a stupid question for a Sunday night , and I also know that this was built on my initial version. But help me out please:
In this example from payout_curve_csv, the offerer goes long with a leverage of 2 and the and the acceptor short with leverage 2.
If the price goes up, he wins everything from ~60k (short liquidation price).
but shouldn't he be losing everything from ~20k?

Fair question! The example configures the offer party with a fee reserve of 300k sats.
https://github.com/get10101/10101/blob/main/crates/payout_curve/examples/payout_curve_csv.rs#L54-L56
So the offer party's minimum payout is set by that amount.

Please excuse the late review.
It's been a while that I've been working on this, so please be kind if this is a stupid question for a Sunday night , and I also know that this was built on my initial version. But help me out please:
In this example from payout_curve_csv, the offerer goes long with a leverage of 2 and the and the acceptor short with leverage 2.
If the price goes up, he wins everything from ~60k (short liquidation price).
but shouldn't he be losing everything from ~20k?

Fair question! The example configures the offer party with a fee reserve of 300k sats.
main/crates/payout_curve/examples/payout_curve_csv.rs#L54-L56
So the offer party's minimum payout is set by that amount.

aahhh... that makes sense. Thanks for the explanation :D

Awesome work btw. :)


Smart Search and Pagination Combining Error

When pagination is called, smart search again sorts the results.

Issue is fixed.


Missing Hash::int dependency possibly

[PDF::Content] Please note that a 'META6.json' file was found in 't', of which the 'provides' section was used to determine if a dependency is available or not.  Perhaps you need to add 'Hash::int' in the <provides> section of that file?  Or need to specify a directory that does *not* have a 'META6.json' file?
Above message when installing using rakubrew and version says Currently running moar-2023.08
Possible it's another issue with my setup as seemed to be having conflicts with libraries installed with system raku. Installed Hash::int with zef and that issue passed.

From that message, one of the test failed to find Hash::int. The error message suggests that it should be declared  t/META6.json , but Hash::int is used by the PDF module only and is not used by PDF::Content directly.
I haven't been able to replicate this locally with or without rakubrew.


SWE-bench GitHub org doesn't have forks of dev set repos

Hello! I noticed that SWE-bench's evaluation and validation code (in the harness subdirectory of this repo) assumes that the SWE-bench GitHub org contains forks of all the open-source projects on which task instances are based (e.g. this fork of Astropy: https://github.com/swe-bench/astropy__astropy).
Here's the code that assumes this: https://github.com/princeton-nlp/SWE-bench/blob/main/harness/utils.py#L238-L242
However, the SWE-bench org doesn't have forks of the projects used for the dev set. E.g. https://github.com/swe-bench/sqlfluff__sqlfluff doesn't exist.
Do you plan to create these forks? If not, I could submit a PR that changes the evaluation and validation code to fall back to the open-source project's original GitHub repo if no fork exists.
Thanks for your time.

Ah thanks for the catch. The dev set repositories were private at the time of creation.
I have made them public now, so they should be accessible! The sqlfluff/sqlfluff link you correctly surmised should now link to a real repository.

That's great, thank you John!


configure apps using Epic sandbox

@swmuir to push to cloud. @drdavec to QA.

Running into tech issue with login - sent request to tech support


New contributor call to arms

Want to advertise fact that we are actively developing new platform and open to contributions
depends on #6

also need to follow-up with latest slack additions (Thomas and glauberramos)

I can throw it in to the communication team which is currently responsible for writing posts on DH. Maybe they have a cool way of writing about it being specific but without giving away too much.

More help would definitely be appreciated, I’m likely to drag my feet a little on this one until more of the dev priorities are met but keen to contribute what I can

pushing this into the backlog for the next week or so to see how much the new remote devs are able to contribute and get feedback on the current induction system (it's a bit of work but hopefully gets people up and running fairly smoothly)

lots done and now being taken over by mattia so closing


resolve manual_backward

What does this PR do?

Fixes # (issue) <- this links related issue to this PR
Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified
[ ] Check that target branch and milestone match!

Did you have fun?
Make sure you had fun coding 🙃

Hello @tchaton! Thanks for opening this PR.

In the file pytorch_lightning/overrides/base.py:

Line 49:72: W291 trailing whitespace
Line 50:13: E265 block comment should start with '# '
Line 50:74: W291 trailing whitespace
Line 51:57: W291 trailing whitespace

In the file pytorch_lightning/trainer/training_loop.py:

Line 714:121: E501 line too long (128 > 120 characters)

In the file pytorch_lightning/utilities/imports.py:

Line 59:1: W391 blank line at end of file

In the file tests/trainer/optimization/test_manual_optimization.py:

Line 997:121: E501 line too long (124 > 120 characters)
Line 1002:121: E501 line too long (124 > 120 characters)

Do see the Hitchhiker's guide to code style

@tchaton DONT MERGE is not a blocker, use WIP which is blocking merge


Slice output table larger then 5GB

S3 has a 5GB limit on single upload.
https://goo.gl/lGECDZ
Thus, we need to slice the output table:
https://developers.keboola.com/extend/common-interface/folders/#sliced-tables
Check file size when writing to output table and if needed split it into multiple files.

Docker runner now supports multipart upload, so this is no longer issue.


User guide should provide more clarity on reconcile.Result and requeue options used by memcache operator example

Feature Request
Is your feature request related to a problem? Please describe.
The user guide provides the following description of reconcile.Result and requeue options used by memcache operator example:
// Reconcile successful - don't requeue
return reconcile.Result{}, nil
// Reconcile failed due to error - requeue
return reconcile.Result{}, err
// Requeue for any reason other than error
return reconcile.Result{Requeue: true}, nil
Unfortunately, while the memcache operator example shows the above options being used, it does explain the reasoning for why each choice was used in different portions of memcached_controller.go
It would be very helpful to folk who are new at writing operations to explain why each reconcile.Result option was chosen for each portion of code in memcached_controller.go
A clear and concise description of what the problem is. Example: "I have an issue when (...)"
Describe the solution you'd like
I would like to see a short paragraph added to the user guide that explains why each reconcile.Result option is chosen for the situations encountered in memcached_controller.go.
I am willing to add this paragraph if this issue is approved.  I may need some guidance to make sure why I think each option is being used is actually correct.

Hi @bradtopol,
Please, feel free to create any PRs with your suggestions and ideas.
It will be great and you are 100% welcome. Please, let us know if you need any help with.

Thanks @camilamacedo86!  I will create the PR.
/assign


wandb: ERROR Error while calling W&B API: project not found (<Response [404]>)

wandb: Currently logged in as: wangpu19990606. Use `wandb login --relogin` to force relogin
wandb: ERROR Error while calling W&B API: project not found (<Response [404]>)
Problem at: train.py 310 main
Error executing job with overrides: ['dataset=zjumocap_377_mono']
Traceback (most recent call last):
  File "train.py", line 310, in main
    wandb.init(
  File "/home/wangpu/anaconda3/envs/3dgs-avatar/lib/python3.8/site-packages/wandb/sdk/wandb_init.py", line 1189, in init
    raise e
  File "/home/wangpu/anaconda3/envs/3dgs-avatar/lib/python3.8/site-packages/wandb/sdk/wandb_init.py", line 1170, in init
    run = wi.init()
  File "/home/wangpu/anaconda3/envs/3dgs-avatar/lib/python3.8/site-packages/wandb/sdk/wandb_init.py", line 785, in init
    raise error
wandb.errors.CommError: It appears that you do not have permission to access the requested resource. Please reach out to the project owner to grant you access. If you have the correct permissions, verify that there are no issues with your networking setup.(Error 404: Not Found)

I am a Chinese student and our  school’s server cannot connect to the external network. How can I modify the file to bypass wandb for training?

delete "entity='fast avatar'" in the wandb. init() function, maybe this can help you

wandb: Currently logged in as: wangpu19990606. Use `wandb login --relogin` to force relogin
wandb: ERROR Error while calling W&B API: project not found (<Response [404]>)
Problem at: train.py 310 main
Error executing job with overrides: ['dataset=zjumocap_377_mono']
Traceback (most recent call last):
  File "train.py", line 310, in main
    wandb.init(
  File "/home/wangpu/anaconda3/envs/3dgs-avatar/lib/python3.8/site-packages/wandb/sdk/wandb_init.py", line 1189, in init
    raise e
  File "/home/wangpu/anaconda3/envs/3dgs-avatar/lib/python3.8/site-packages/wandb/sdk/wandb_init.py", line 1170, in init
    run = wi.init()
  File "/home/wangpu/anaconda3/envs/3dgs-avatar/lib/python3.8/site-packages/wandb/sdk/wandb_init.py", line 785, in init
    raise error
wandb.errors.CommError: It appears that you do not have permission to access the requested resource. Please reach out to the project owner to grant you access. If you have the correct permissions, verify that there are no issues with your networking setup.(Error 404: Not Found)

I am a Chinese student and our school’s server cannot connect to the external network. How can I modify the file to bypass wandb for training?

delete "entity='fast avatar'" in the wandb. init() function, maybe this can help you

You can add "mode='disabled'" in wandb.init() to completely disable wandb logging.

wandb: Currently logged in as: wangpu19990606. Use `wandb login --relogin` to force relogin
wandb: ERROR Error while calling W&B API: project not found (<Response [404]>)
Problem at: train.py 310 main
Error executing job with overrides: ['dataset=zjumocap_377_mono']
Traceback (most recent call last):
  File "train.py", line 310, in main
    wandb.init(
  File "/home/wangpu/anaconda3/envs/3dgs-avatar/lib/python3.8/site-packages/wandb/sdk/wandb_init.py", line 1189, in init
    raise e
  File "/home/wangpu/anaconda3/envs/3dgs-avatar/lib/python3.8/site-packages/wandb/sdk/wandb_init.py", line 1170, in init
    run = wi.init()
  File "/home/wangpu/anaconda3/envs/3dgs-avatar/lib/python3.8/site-packages/wandb/sdk/wandb_init.py", line 785, in init
    raise error
wandb.errors.CommError: It appears that you do not have permission to access the requested resource. Please reach out to the project owner to grant you access. If you have the correct permissions, verify that there are no issues with your networking setup.(Error 404: Not Found)

I am a Chinese student and our school’s server cannot connect to the external network. How can I modify the file to bypass wandb for training?

delete "entity='fast avatar'" in the wandb. init() function, maybe this can help you

Thank you very very very much🥰! The problem mentioned above is solved by deleting "entity='fast avatar'" bur another problem occurs (the numpy version is too high the do not support the "np.float")🥲, i am trying to solve the new problem.

wandb: Currently logged in as: wangpu19990606. Use `wandb login --relogin` to force relogin
wandb: ERROR Error while calling W&B API: project not found (<Response [404]>)
Problem at: train.py 310 main
Error executing job with overrides: ['dataset=zjumocap_377_mono']
Traceback (most recent call last):
  File "train.py", line 310, in main
    wandb.init(
  File "/home/wangpu/anaconda3/envs/3dgs-avatar/lib/python3.8/site-packages/wandb/sdk/wandb_init.py", line 1189, in init
    raise e
  File "/home/wangpu/anaconda3/envs/3dgs-avatar/lib/python3.8/site-packages/wandb/sdk/wandb_init.py", line 1170, in init
    run = wi.init()
  File "/home/wangpu/anaconda3/envs/3dgs-avatar/lib/python3.8/site-packages/wandb/sdk/wandb_init.py", line 785, in init
    raise error
wandb.errors.CommError: It appears that you do not have permission to access the requested resource. Please reach out to the project owner to grant you access. If you have the correct permissions, verify that there are no issues with your networking setup.(Error 404: Not Found)

I am a Chinese student and our school’s server cannot connect to the external network. How can I modify the file to bypass wandb for training?

delete "entity='fast avatar'" in the wandb. init() function, maybe this can help you

Thank you very very very much🥰! The problem mentioned above is solved by deleting "entity='fast avatar'" bur another problem occurs (the numpy version is too high the do not support the "np.float")🥲, i am trying to solve the new problem.

You can add "mode='disabled'" in wandb.init() to completely disable wandb logging.

Thank you for your amazing project (the performence of your project is the best among the open source code at present) , but adding "mode='disabled'" does not work😔.


Regions availability

Please provide us with the following information:

This issue is a: (mark with an x)

[ x] documentation issue or request

Issue description
I can't find the exact list of regions available , when looked on the product list it says south central is available (screenshot below ) but its not part of the options on portal and on the pricing list it says north , south US are both options but again not available on portal
Screenshots

Hi. We are aware there is an issue with this specific doc. We are working to resolve it.

I also submitted a support ticket back in June for this - and now today South and North Central US shows up. Azure Status Page shows N/A for NC/SC.
Is it officially supported yet?

Hi! These sources of region information can be out of date at times. The most recent list of supported regions can be found by running the following command:
az provider show --namespace Microsoft.App --query "resourceTypes[?resourceType=='managedEnvironments'].locations"


Use Travis to automatically deploy zip files to new releases

https://docs.travis-ci.com/user/deployment/releases

This works now. Whenever a GitHub Release is created via the Web UI, the module is automatically zipped and uploaded.


Add something to cart, reload, lose cart

Not signed in, add something to cart, reload, lose cart
Same when signed in
But if I sign out then back in, cart comes back.

The quick fix for this is doable using configuration:
      state: {
        storageSync: {
          keys: {
            'cart': StorageSyncType.SESSION_STORAGE
          }
        }
      }

which basically syncs cart with session storage (could also be local storage).
But to make it as an official solution, we have to check, if there are no drawback (like not refreshed or stale cart, especially when it will be set to local storage, etc). Storing only cart id (not the whole cart) might be one solution for this.

Quick fix doesn't work correctly. Some race conditions error appear.
I would also go for keeping only cart id, but we need to change store structure, a bit to now have it as object key, but as a value.
I am working on creating working version.

Did a smoke test.  Works well with anonymous user.  It doesn't work for an authenticated user.
I get this:

To repro:

Authenticate
Add a product to cart
From the add to cart modal, go to the cart page
Refresh the page.

Improvement ticket for handling details in cart: https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/3241
Unit test ticket: https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/3242

anonymous user vs. logged in user
loading cart vs. merging cart just after

QA steps:

As an anonymous user add to cart and refresh (veryfy that cart is keeped)
Because big refactor was mede in Cart Service, please do regression tests regarding cart and page refresh for combinations of conditions:

anonymous user / logged in user / just registered fresh user
create cart (add to cart when cart doesn't exist) / add to exising cart / clear cart (by logout or checkout)
change language / currency
login (merge anonymous cart) / logout (drop cart)
anything more you think is worth testing...

I don't see a fix yet for this issue.
Using registered user, I add items to cart, go to cart page, reload page -> cart is empty. 🆖
Logout and re-login -> cart has contents again.
Anonymous user -> once page is reloaded, cart contents are gone.  🆖

kate to retest, gil/radhep say it works, gc still not so, if it works, we'll pass

Tested on dev17, chrome. I still see the issue too, empty cart after reloading.

in summary, GC and Kate see the issue, Gil and Radhep don't.

Adding to the mix:

Chrome: Cleared cache and cookies, anonymous user, go to dev17, add to cart, show cart, reload, cart gone.
Same with Firefox

BUT!
Using modelt, Firefox, signed in, cart is saved on reload.
Same with Chrome, when signed in.

My bad, I tested only using dev version of spartacus (yarn start). The fix doesn't work in production build i.e. yarn start --prod (or yarn build which is used in our deploy script). I confirm that for production build cart is gone after page refresh - both for anonymous and signed in user.
Note: for signed in user, the cart is back when you logout and login again - so cart is persisted on backend, but the refreshing the page causes the local (frontend) version of cart to disappear.

Problem is about storageSync.
cartStoreConfigFactory is not executed at all.
Quick fix for this problem: add cart guid, code keys in auth-store.module.ts. This is not an elegant solution.
A better approach would be fixing the storageSync config providing.
Removing config from auth-store.module doesn't help. Still, cartStoreConfigFactory isn't executed.

Fix because StateModule was missing in cart-store.module.ts
Adding fix to a new PR
Fix in GH-3407

Refresh issue is fixed but there is another bug that should be fixed before this feature is deployed.

Login
Add an item to the cart
Logout
Add an item to cart (as anon user)
Log back in to account and you will see an error message
You will also not be able to place an order with that cart

Test successful 🆗
(But minicart flickers for about 1 second with qty = 0, then updates correctly).


Request for "docker rmi" to support -f flag

I'm using the -f flag with docker rmi on my swarm endpoint but it doesn't seem to be implemented in 0.4.0.

Closed by #1162


salt-repo package is unsigned

Packages from the SaltStack repository are signed, but the salt-repo package used to enable the repository is not.
$ rpm --checksig *.rpm
salt-2015.8.5-1.el7.noarch.rpm: rsa sha1 (md5) pgp md5 OK
salt-repo-2015.8.el7.noarch.rpm: sha1 md5 OK

Please sign the salt-repo packages with the same key as the other packages.

This is true for the RHEL 5, 6, and 7 versions of the package.

Updated signed salt-repo-xxx.rpm ready for test


Symbols do not populate, but layers do in Sketch 64

Which version of the plugin are you using?
[ X ] Data Populator for Sketch
[ ] Data Populator for Adobe XD
Describe the bug
If I detach from a symbol then the data populates correctly, but kept as a symbol it does not work as expected.
To Reproduce
Steps to reproduce the behavior:

I have added a symbol with two fields I want to populate, one text {message}, one image {image} to an artboard.

The JSON displays correctly in the data populator.

The data is not applied correctly.

However, if I detach the symbol so that they are layers, not a symbol.

The data is populated correctly.

Expected behavior
I would expect that symbols could be populated, in the same way that layers are.
Environment (please complete the following information):

macOS Version: macOS Mojave 10.14.6
Sketch Version: Sketch Version 64 (93537)
Plugin Version: 3.0.3

Additional context
This is the first time I have used this plugin, so not sure if this was working before, or if I am doing something wrong.

This is also true in the XD version of the plugin. I know on that end of things, this is actually a limitation of the XD api itself.
That said, some kind of error or warning would be useful.

@chrism do you still have this issue with the latest version of Sketch? Also, can you try turning one of the "Contact Cards" in the Sketch Demo Document into a symbol and retry? https://www.datapopulator.com/sketch/

This is also true in the XD version of the plugin. I know on that end of things, this is actually a limitation of the XD api itself.
That said, some kind of error or warning would be useful.

Yea, Components in Adobe XD are not yet supported (see https://github.com/preciousforever/data-populator/issues/198)


Save project pop-up

Tapping back right after launching the app will always display "Save Project" dialogue.

Oh, I may have to fix that. But I don't know when I can fix that. (D-17 of an important exam(CSAT))  Pull request is welcomed, or I may fix it some day. Thanks!

Will be fixed in next release.


use go-docs for dynamic configuration and static configuraiton

So that users can easily know which configuration are available in which versions.
Do this after this PR is released: https://github.com/uber/cadence/pull/4129
So that the go-docs will contain the exactly same information

And make sure update the links after this PR is released:
https://github.com/uber/cadence/pull/4118

https://github.com/uber/cadence-docs/pull/41

Is this still an issue @longquanzheng ?

Not anymore. Thanks for reminding.


generate bindings for postage stamp smart-contract

Task

generate bindings for postage stamp smart-contract

Acceptance criterea

addressed as part of https://github.com/ethersphere/bee/pull/1599


renderer: fallback on EXT_framebuffer_object if ARB_framebuffer_object is missing

Fallback on EXT_framebuffer_object if ARB_framebuffer_object is missing.
ARB_framebuffer_object does more things than EXT_framebuffer_object so hardware supporting EXT_framebuffer_object may not support ARB_framebuffer_object but it looks like our game does not do crazy things enough and EXT_framebuffer_object seems to be usable as a fallback for missing ARB_framebuffer_object.
This makes the engine run on all Nvidia NV40 (Curie) on Linux with nouveau nv30 driver.
The proprietary nvidia 304 driver emulated ARB_framebuffer_object over EXT_framebuffer_object but nouveau doesn't, and the proprietary nvidia 304 driver isn't provided on Linux distributions anymore, leaving nouveau the only driver for this range of hardware.
I first tried to enable ARB_framebuffer_object on Mesa directly, but it looks like the hardware doesn't support everything required for it and I don't have enough knowledge to emulate it over EXT_framebuffer_object:

https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19513

This is implemented in the form of a struct of OpenGL functions pointers, setting the ones from ARB_framebuffer_object or EXT_framebuffer_object given what extension is provided, and calling them through the struct.
Before this PR is merged and the engine rebuilt and released, people can do the same as this PR with the MESA_EXTENSION_OVERRIDE=GL_ARB_framebuffer_object environment variable.
Note that running the Dæmon engine over a nv40 hardware will suffer from an nouveau nv30 driver bug related to vbo model skinning. One can workaround this bug by setting r_vboVertexSkinning 0 to force the CPU code path for this task:

https://gitlab.freedesktop.org/mesa/mesa/-/issues/7631

Before:
SDL_Init( SDL_INIT_VIDEO )...
Using SDL version 2.0.20
SDL using driver "x11"
Initializing OpenGL display
Using GLEW version 2.2.0
Display aspect: 1.779
...setting mode -1: 640×480
Using preferred context - 24-bit OpenGL 2.1 compatibility
OpenGL Renderer: NV4E
Using GL3 Renderer in OpenGL 2.x mode...
Available modes: '1280x720 1366x768 1360x768 1280x768 1280x800 640x480 800x600 1024x768 1280x960 1280x1024 '
Detected graphics driver class 'integrated'
Detected graphics hardware class 'generic'
Initializing OpenGL extensions
...ignoring GL_ARB_debug_output
...found shading language version 120
...using GL_ARB_half_float_pixel
...GL_ARB_texture_float not found.
...GL_EXT_gpu_shader4 not found.
...GL_EXT_texture_integer not found.
...GL_ARB_texture_rg not found.
...GL_ARB_texture_gather not found.
...using GL_EXT_texture_compression_s3tc
...GL_ARB_texture_compression_rgtc not found.
...ignoring GL_EXT_texture_filter_anisotropic
...using GL_ARB_half_float_vertex
...GL_ARB_framebuffer_object not found.
Warn: Required extension GL_ARB_framebuffer_object is missing.

After:
SDL_Init( SDL_INIT_VIDEO )...
Using SDL version 2.0.20
SDL using driver "x11"
Initializing OpenGL display
Using GLEW version 2.2.0
Display aspect: 1.779
...setting mode -1: 640×480
Using preferred context - 24-bit OpenGL 2.1 compatibility
]Mesa: User error: GL_INVALID_ENUM in glGetIntegerv(pname=GL_CONTEXT_PROFILE_MASK)
OpenGL Renderer: NV4E
Using GL3 Renderer in OpenGL 2.x mode...
Available modes: '1280x720 1366x768 1360x768 1280x768 1280x800 640x480 800x600 1024x768 1280x960 1280x1024 '
Detected graphics driver class 'integrated'
Detected graphics hardware class 'generic'
Initializing OpenGL extensions
...ignoring GL_ARB_debug_output
...found shading language version 120
...using GL_ARB_half_float_pixel
...GL_ARB_texture_float not found.
...GL_EXT_gpu_shader4 not found.
...GL_EXT_texture_integer not found.
...GL_ARB_texture_rg not found.
...GL_ARB_texture_gather not found.
...using GL_EXT_texture_compression_s3tc
...using GL_ARB_texture_compression_rgtc
...ignoring GL_EXT_texture_filter_anisotropic
...using GL_ARB_half_float_vertex
...GL_ARB_framebuffer_object not found.
...using GL_EXT_framebuffer_object
...using GL_ARB_get_program_binary
...using GL_ARB_buffer_storage
...GL_ARB_uniform_buffer_object not found.
...using GL_ARB_map_buffer_range
...using GL_ARB_sync
Warn: SSAO not used because GL_ARB_texture_gather is not available.
Warn: floating point image '_depthtile1Render' cannot be loaded
Warn: floating point image '_depthtile2Render' cannot be loaded
Warn: floating point image '_dlightImage' cannot be loaded
GL_VENDOR: nouveau
GL_RENDERER: NV4E
GL_VERSION: 2.1 Mesa 22.4.0-devel (git-dc08875415)
GL_MAX_TEXTURE_SIZE: 4096
GL_SHADING_LANGUAGE_VERSION: 1.20
GL_MAX_VERTEX_UNIFORM_COMPONENTS 1848
GL_MAX_VERTEX_ATTRIBS 16
Occlusion query bits: 64
GL_MAX_DRAW_BUFFERS: 4
GL_MAX_RENDERBUFFER_SIZE: 4096
GL_MAX_COLOR_ATTACHMENTS: 4
PIXELFORMAT: color(24-bits)
MODE: -1, 640 x 480 windowed hz: N/A
Using OpenGL version 2.1, requested: 2.1
Using OpenGL 2.x context.
Using OpenGL extensions: GL_ARB_half_float_pixel GL_EXT_texture_compression_s3tc GL_ARB_texture_compression_rgtc GL_ARB_half_float_vertex GL_EXT_framebuffer_object GL_ARB_get_program_binary GL_ARB_buffer_storage GL_ARB_map_buffer_range GL_ARB_sync
Missing OpenGL extensions: GL_ARB_texture_float GL_EXT_gpu_shader4 GL_EXT_texture_integer GL_ARB_texture_rg GL_ARB_texture_gather GL_ARB_framebuffer_object GL_ARB_uniform_buffer_object
Using S3TC (DXTC) texture compression.

Some demonstration:

Do you think this is better done in the mesa driver? Is this only required for the nouveau driver?

This is only required on nouveau driver with nv30 range of Nvidia hardware. It is believed the hardware doesn't have all the features to fully implement ARB_framebuffer_object but is OK with the earlier version of it being named EXT_framebuffer_object. ARB_framebuffer_object and EXT_framebuffer_object are not equal, EXT_framebuffer_object is a subset of ARB_framebuffer_object.
The proprietary nvidia 304 driver for those GPUs implements ARB_framebuffer_object but probably at the cost of some emulation, and this driver is incompatible with in current distros, while being very unstable (much more unstable than nouveau, which isn't stellar on this hardware, meaning nouveau is the only usable option. I doubt someone will invest the time, resources, and effort to emulate  ARB_framebuffer_object over the less complete EXT_framebuffer_object.
It happens that if a game only sticks to what EXT_framebuffer_object can do (which is a subset of ARB_framebuffer_object), it is possible to run the game with the same code, like my patch does. It looks like this happens with Unvanquished, I have only tested low presets but anyway such hardware require low presets so that's fine.
The only reasonable implementation in Mesa (other than the very complex task of emulating  ARB_framebuffer_object over the less complete EXT_framebuffer_object) looks to be the patch I proposed to Mesa: a game that knows it can fake ARB fbo over EXT fbo would tell Mesa to fake the availability of ARB fbo while in fact doing EXT fbo with EXT fbo limitations.
Some comparisons between one solution and another:

Implementing such knob in Mesa:

Pros: game knowing EXT fbo is enough only have to set one environment variable before loading the GL subsystem, done.
Cons: every distro on earth has to ship a Mesa update for one game.

Implementing a function pointer layer to call ARB fbo or EXT fbo pointers

Pros: works today on already release nouveau driver on every current distro on earth.
Cons: adds a function call indirection for every call of those functions for every other driver and hardware.

Well, there is a third solution, that can work today without function call indirection neither patching mesa: relying on the non-nouveau specific MESA_EXTENSION_OVERRIDE=GL_ARB_framebuffer_object environment variable. To implement it properly, one has to first load the GL subsystem, detect this is a nouveau driver with EXT fbo, shutdown the GL subsystem, add the GL_ARB_framebuffer_object string to the MESA_EXTENSION_OVERRIDE, since it's a list, one may have to parse it to concatenate the added string, set the environment variable, and restart the GL subsystem… This is the most annoying solution, makes the GL initialization much complex, but would work today on already released drivers without adding any function indirect call on every other driver.
Note: the same mechanism may be usable if OES_framebuffer_object is available, maybe in the future we want to extend this kind of indirect function call to support more GL standards.

In that case, maybe the engine shim might be better. @slipher what do you think?

The approach here seems OK to me.
The function pointers can supposedly be dependent on the context, so make sure they are reloaded if the context is recreated.

The function pointers can supposedly be dependent on the context, so make sure they are reloaded if the context is recreated.

I guess GLimp_InitExtensions is called anytime a context is recreated? I set the function pointers there.

GLimp_CreateContext() is called by GLimp_ValidateBestContext() which is called by GLimp_SetMode() which is called by GLimp_StartDriverAndSetMode() which is then called by GLimp_Init().
The fbo function pointers are set in GLimp_InitExtensions() which is called by GLimp_Init() after GLimp_StartDriverAndSetMode() and then GLimp_CreateContext() is called.
GLimp_CreateContext()  is called and only called when GLimp_StartDriverAndSetMode() succeeds.
So I assume the function pointers are always set after (re)creating a context.
I also fixed the compilation on 64-bit MSVC, errors like that [1], [2]:
C:\projects\daemon\src\engine\sys\sdl_glimp.cpp(1839,51):
 error C2440: '=': cannot convert from 'PFNGLBINDFRAMEBUFFERPROC'
 to 'void (__cdecl *)(GLenum,GLuint)' [C:\projects\daemon\build\client-objects.vcxproj]
C:\projects\daemon\src\engine\sys\sdl_glimp.cpp(1839,34): message :
 This conversion requires a reinterpret_cast, a C-style cast
 or function-style cast [C:\projects\daemon\build\client-objects.vcxproj]

I turned the code to set function pointers for this or that extension to inline functions named glFboSetArb() and glFboSetArb() this way the setting code lives the closest possible to the structure declaration.
I also renamed the struct type from glShim_t to glFboShim_t with an explicit reference to framebuffer objects in the name, same with the object name. I think that if in the future we want to implement a similar shim for something else we would prefer declare another structure instead of putting everything in the same jumbo structure. So this one is dedicated for fbo tweaks.

The code lgtm


Drop rules that ktlint implements

Expected Behavior
Rules that are implemented in ktlint should not be reimplemented in detekt.
Current Behavior
Some rules are duplicated in both tools:

max line length
modifier order
returning Unit from function
unused imports
wildcard imports
indent with spaces not tabs
empty class block
new line at end of file

May be others but that illustrates the point.
Context
Detekt has a wrapper for ktlint rules, so it's easy to apply ktlint's formatting rules when detekt is run. It doesn't make sense to duplicate effort for formatting rules - I understand the direction is for detekt to avoid implementing formatting rules (unless they're not implemented by ktlint for some reason).

Lets first turn them off, see what people will say and one version later remove them?

Could do that, maybe show a deprecation message if they're enabled with a note to comment on this issue?
I think auto formatter should also be disabled by default for all wrapped ktlint rules, users should have to override the default config to enable if they want to.

activate autoCorrect for us in failfast.yml
You want ktlint auto correct enabled for detekt itself?

I would like to leave them as they are. I don't to see a reason to remove them.
However, we shouldn't invest any more time in the development of these rules.

Actually me too. There are teams which do not rely on formatting tools or do not even trust them.
If the eager detekt user wants formatting, he can turn off the suggested rules.


Migrate starknet_estimateFee()

Pull Request type
Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Testing
[ ] Other (please describe):

What is the current behavior?
Issue Number: #226
What is the new behavior?
Migrate the starknet_get_estimate_fee method from beerus_rest_api to beerus_rpc, which given a block_id and a broadcasted_transaction returns the estimate_fee
Does this introduce a breaking change?

[ ] Yes
[x] No

Other information
:warning: This PR replace the older one (https://github.com/keep-starknet-strange/beerus/pull/270)

@phklive also add error handling as in the other rpc methods, if you see that it is necessary to change/add something to the code, please let me know. Thankss

Before approving PR please take example on merged code and use the correct error handling patterns.

Before approving PR please take example on merged code and use the correct error handling patterns. https://github.com/keep-starknet-strange/beerus/blob/main/crates/beerus-rpc/src/lib.rs#L163

Hii, thanks for feedback. Sorry for the delay, I wrote the code based on this method but I see that there are others that directly do the unwrap (like the one you gave me), which one should I go with? and the same with _broadcasted_transaction.
What do you think about this impl?
async fn starknet_estimate_fee(
        &self,
        block_id_type: String,
        block_id: String,
        broadcasted_transaction: String,
    ) -> Result<FeeEstimate, Error> {
        let block_id = block_id_string_to_block_id_type(&block_id_type, &block_id).unwrap();

        let broadcasted_transaction: BroadcastedTransaction =
            serde_json::from_str(&broadcasted_transaction).unwrap();

       Ok(self
            .beerus
            .starknet_lightclient
            .estimate_fee(broadcasted_transaction, &block_id)
            .await
            .unwrap())  // no catch errors here?
    }

I have doubts about what type of error should I use, in BerusApiError there is not one assigned for the estimateFee, should I create a specific one for this case or reuse any of these? Why in some cases do you use the mapping to an error and in others do you unwrap directly? sorry for the questions


[Feature]: Community Page for Sharing Charts made with Rivet

Feature Request
Community Page for Sharing Charts made with Rivet
Request:
I propose the creation of a community page where users can share and collaborate on charts made with Rivet. This would not only foster a sense of community but also help in showcasing the potential of Rivet through real-world use cases.
Benefits:
Having a community page would:

Showcase: Allow users to demonstrate the diverse capabilities and applications of Rivet through their charts.
Collaboration: Foster a platform where users can give feedback, iterate on existing charts, and jointly create new ones.
Learning: New users can learn from experienced ones by observing and dissecting shared charts.
Inspiration: Witnessing the varied use-cases can inspire teams to devise innovative solutions for their unique challenges.

Suggested Features for the Community Page:

User Profiles: Allow users to create profiles showcasing their charts and contributions.
Search & Filter: Provide robust search and filtering options for users to find specific charts or use-cases.
Feedback & Comments: Enable users to leave feedback or comments on shared charts.
Versioning: Allow users to upload different versions of their charts, showcasing the evolution of their work.

Closing:
The addition of a community page would undeniably augment the value proposition of Rivet. It would be a nexus for collaboration, learning, and innovation. I believe this would be a significant stride towards nurturing a thriving ecosystem around Rivet.
Thank you for considering this feature request. I eagerly await feedback from the community and the Rivet team.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@sfdrada I wholeheartedly agree! We definitely would love to have something like this for Rivet and the community. It's just a lot of work to do so we haven't had the time yet! For now you can check out the #share-graphs channel in the Discord, it's fairly active with folks sharing what they've made.


(Docs) Example for specifying the config option with the file name

From the doc "Installing the Managed Plugin"
Create a configuration file. The config file must be located in the /etc/netappdvp directory. The default filename is config.json, however you can use any name you choose by specifying the config option with the file name.
Can someone clarify how this config option with the file name is set and where? It's unclear from the context.

We'll need to update the doc, but until we can do that, hopefully this will help.
$ docker plugin install --help
Usage:	docker plugin install [OPTIONS] PLUGIN [KEY=VALUE...]
$ docker plugin install --grant-all-permissions --alias netapp netapp/ndvp-plugin:17.07 config=myOtherConfig.json
Relevant implementation snippet in container-launch.sh
Can 'plugin set' it too:
$ docker plugin set --help
Usage:	docker plugin set PLUGIN KEY=VALUE [KEY=VALUE...]


PluralSight ExtractorError: No video formats found

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.06.25. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[ x] I've verified and I assure that I'm running youtube-dl 2018.06.25

Before submitting an issue make sure you have:

[x ] At least skimmed through the README, most notably the FAQ and BUGS sections
[x ] Searched the bugtracker for similar issues including closed ones
[ x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ x] Bug report (encountered problems with youtube-dl)

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--username', u'PRIVATE', u'--password', u'PRIVATE', u'-o', u'%(playlist_index)s - %(title)s.%(ext)s', u'--verbose', u'--min-sleep-interval', u'181', u'--max-sleep-interval', u'227', u'--playlist-items', u'0-222', u'https://app.pluralsight.com/library/courses/aspdotnet-core-2-razor-playbook', u'-v']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.06.25
[debug] Python version 2.7.14 (CPython) - CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
[debug] exe versions: none
[debug] Proxy map: {}
[pluralsight:course] aspdotnet-core-2-razor-playbook: Downloading course JSON
[download] Downloading playlist: ASP.NET Core 2.0 Razor Playbook
[pluralsight:course] playlist ASP.NET Core 2.0 Razor Playbook: Collected 62 video ids (downloading 63 of them)
[download] Downloading video 1 of 63
[pluralsight] Downloading login page
[pluralsight] Logging in
[pluralsight] 9090bbd8-a311-4031-a1db-34d337df437c-6: Downloading course JSON
[pluralsight] 9090bbd8-a311-4031-a1db-34d337df437c-6: Downloading mp4-high-widescreen viewclip JSON
WARNING: Unable to download JSON metadata: HTTP Error 404: Not Found
[pluralsight] 9090bbd8-a311-4031-a1db-34d337df437c-6: Waiting for 4 seconds to avoid throttling
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 792, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 501, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/pluralsight.py", line 327, in _real_extract
    self._sort_formats(formats)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 1281, in _sort_formats
    raise ExtractorError('No video formats found')
ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description of your issue, suggested solution and other information
Seems to happen often with newer PluralSight content, sometimes older content... tested with latest version.
Example url the above was tested with... https://app.pluralsight.com/library/courses/aspdotnet-core-2-razor-playbook

Same here

Interestingly.. that url above started downloading yesterday, got about 13videos downloaded...
however I try resuming from video 13 again today and I get the below variation on the above error....
Would be great if pluralsight just offered subscribers a way to download the damn videos for offline and better desktop video playing... instead of forcing us to watch through there own janky system, but right now youtube-dl is the only way and its not working 100% of the time. I hope someone is able to look into it.
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--username', u'PRIVATE', u'--password', u'PRIVATE', u'-o', u'%(playlist_index)s - %(title)s.%(ext)s', u'--verbose', u'--min-sleep-interval', u'181', u'--max-sleep-interval', u'227', u'--playlist-items', u'13-222', u'https://app.pluralsight.com/library/courses/aspdotnet-core-2-razor-playbook', u'-v']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.06.25
[debug] Python version 2.7.14 (CPython) - CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
[debug] exe versions: none
[debug] Proxy map: {}
[pluralsight:course] aspdotnet-core-2-razor-playbook: Downloading course JSON
[pluralsight:course] aspdotnet-core-2-razor-playbook: Downloading JSON metadata
ERROR: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 598, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2211, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python2.7/urllib2.py", line 435, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 473, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 556, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)


Updated examples to use %APPDATA% instead of %USERPROFILE%\AppData\Ro…

…aming
Updated examples to use %APPDATA% instead of %USERPROFILE%\AppData\Roaming

Please update readme

That didn't do what you wanted it to do.


Update README

Fixes issue #20
Can I get some help with adding the routes here?

This should give you what you need: https://github.com/RockefellerArchiveCenter/pictor/blob/development/pictor/urls.py


Accessibility Support in Phaser (screen reader)

This Issue is about: accessibility support in Phaser
Sorry if it's not appropriate to post feature request / questions here --- feel free to take it down if so.
I'm currently working on a Phaser project and there's a requirement on accessibility especially for screen-readers (HTML-DOM aria-label equivalent). I am wondering if there's any plan to support this from the community-side?
Accessibility support is added with PIXI v3. I understand that Phaser uses a fork of PIXI v2, and there has been discussions in the past on migrating to PIXI v3  as well as PIXI v4. Any insight/updates on the current strategy from Phaser to implement PIXI features beyond v2 would be very helpful.
Thanks!
Reference:
PIXI.accessibility API

It's up to the community if they want to try and incorporate Pixi 4 or not. However, as someone who has created many accessible games with Phaser, it's perfectly possible to do it right now. I would argue that the DOM element per Sprite approach that Pixi uses isn't always the best way to handle it - it's usually very game specific. From grid inputs to auto scanning focus rects, to dwell timers, there are so many different ways to approach it that one shoe rarely fits all.


HACS integration stopped working

Maybe "filename" in the config is wrong
https://github.com/Yevgenium/weather-chart-card/blob/0c16ee74a90c8b0902d4a989d883f9d2207331c7/hacs.json#L4

Mine also stopped working right but also notice the .js file is named different than the one that downloads from HACS. The one that downloaded is weather-card-chart.js and the one on the github is weather-chart-card.js

Ok the fix I found was to add the new .js file and rename it to the one in HA. Reboot and then HACS will allow you to reinstall it which fixed the issue. All good now.

Oops. Can you check if it works now?

Oops. Can you check if it works now?

Well actually I jump for joy too early. It failed again so removed it form HACS then tried to add it back into custom repositories but it will not allow you to add your repository. I was able to do it old school by manually added it back in, but I like to have it linked to HACS to do updates. I love this card too so really want it to work.

I also tired to clear cache and reboot HA to see if you can link the repository back in but no joy. I put in your url "https://github.com/Yevgenium/weather-chart-card" for Lovelace installment in custom repositories in HACS but it will not add it to the list when it was working before I deleted it to see if I could get it to update to current version. Not sure why it will not add now since it seems to be all correct now.

There's no file weather-card-chart.js in the repo, it was deleted in a9f795f2fd02028bdad9b771d383fa38c5f3148c. Maybe that's the reason?

Yes, this was probably the reason. I edited the hacs.json file, hopefully this will fix the problem.

I just check but no joy. It still will not let you add it to custom repositories in HACS. Honestly not sure why I put in the URL and Lovelace but you click add and nothing. No errors or anything. Manual install works but better if it was in HACS.

1883526f493b7de2868c7f108da685766a8cc6e9 <-- it works in my repo as expeted. HACS requires the compiled js to exist in the tree. And BTW - your last changes to that file make it failing, I used the js from release 1.0.0

@artemyevav yeah it did work with your fork without any issues. Only thing is will it have the updates as they are pushed out?

Nope. I believe you have to put .js there manually. Maybe it worth creating smth like bin subdir and keep it there.

@artemyevav yeah that is what I thought. I tried again to get this repo to add but no joy for some reason.

Reload hass page maybe and clean the cache. It helps sometimes.

Yeah I did that a few times but same thing. I am just going to use your repo and manually do it.

The only difference of my repo is https://github.com/artemyevav/weather-chart-card/commit/1883526f493b7de2868c7f108da685766a8cc6e9 which means I got weather-chart-card.js from release and put it into  the repo.

same here :)

Hmm. No idea. I've just completely removed it from my HACS and installed it again from my repo - it works.

how did you do this? I uninstalled it, then removed the repo, afterwards i added the repo and tried to install it again, but it couldn't finish the load.
I changed my ressources from weather-card-chart to weather-chart-card and my ui-lovelace.yaml, but the card is no showing.

Try using my fork to see where the problem is: https://github.com/artemyevav/weather-chart-card

It is now working again on this repo so all good now.

It is now working again on this repo so all good now.

it doesn't work for me neither. How did you get it to work?

@yan14 I close the HA window, cleared all the cache and closed out browser. Once I opened it back up it was all good.

After upgrade to 1.0.2 it still doesn't work

I had to completely remove Yevgenium version, clear cache, reboot. Once that is done I just reinstalled it and it started working with all the new chart info. I just did the update and it is still working great.

I had to completely remove Yevgenium version, clear cache, reboot. Once that is done I just reinstalled it and it started working with all the new chart info. I just did the update and it is still working great.
I did the same and it works perfectly.

I had to completely remove Yevgenium version, clear cache, reboot. Once that is done I just reinstalled it and it started working with all the new chart info. I just did the update and it is still working great.

I did the same and it works perfectly.

me too. it works now so this can be closed I guess.


The polling of drop flag and memory allocation method could be improved

the polling of drop flag could slow down the stream when handle a lot of connections. This could be improved by replacing it with a mpsc message.
Create Vec every loop could slow down and leads to a lot of  memory fragmentation. This could be improved by using bytes::BytesMut.

benchmark code here shows the improvement.
and the result:
     Running benches\benchmark_lib.rs (target\release\deps\benchmark_lib-36879d0bb7f740c7.exe)
Benchmarking sample-size-example/normal: Warming up for 3.0000 s
Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 121.1s.
sample-size-example/normal
                        time:   [11.078 s 11.456 s 11.868 s]
                        change: [-81.264% -80.491% -79.680%] (p = 0.00 < 0.05)
                        Performance has improved.

     Running benches\benchmark_optimize_buf.rs (target\release\deps\benchmark_optimize_buf-bfd7c03693bf79e1.exe)
Benchmarking sample-size-example/optimize buf: Warming up for 3.0000 s
Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 79.7s.
sample-size-example/optimize buf
                        time:   [8.5379 s 8.5776 s 8.6159 s]
                        change: [-80.839% -80.737% -80.642%] (p = 0.00 < 0.05)
                        Performance has improved.

     Running benches\benchmark_optimize_drop.rs (target\release\deps\benchmark_optimize_drop-9e46585be99cc901.exe)
Benchmarking sample-size-example/optimize drop: Warming up for 3.0000 s
Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 95.0s.
sample-size-example/optimize drop
                        time:   [9.3510 s 9.3941 s 9.4321 s]
                        change: [-82.663% -81.850% -81.082%] (p = 0.00 < 0.05)
                        Performance has improved.

The optimization of drop method reduce the time from 11.456s to 9.3941s, then the one of BytesMut reduce to 8.5776s.

Looks good, thank you very much.


[UTOPIA-1439] - Update typescript, eslint (FE dev dependency)

🎯 Summary

UTOPIA-1439

update typescript, @typescript-eslint/parser, @typescript-eslint/eslint-plugin

🔰 Checklist

[x] I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.

I have performed a self-review of my code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation where required.
I have tested my changes to the best of my ability.
I have consulted with the team if introducing a new dependency.
My changes generate no new warnings.

Make sure to resolve the type errors


Deployment Failed

ffhttp_GoogleDrive	Apex Class	43	28	Invalid type: ffhttp_Client.Credentials ffhttp_GoogleDriveApps	Apex Class	41	32	Dependent class is invalid and needs recompilation: ffhttp_GoogleDrive: line 43, column 28: Invalid type: ffhttp_Client.Credentials ffhttp_GoogleDriveChanges	Apex Class	41	35	Dependent class is invalid and needs recompilation: ffhttp_GoogleDrive: line 43, column 28: Invalid type: ffhttp_Client.Credentials ffhttp_GoogleDriveChannels	Apex Class	41	36	Dependent class is invalid and needs recompilation: ffhttp_GoogleDrive: line 43, column 28: Invalid type: ffhttp_Client.Credentials ffhttp_GoogleDriveChildren	Apex Class	41	36	Dependent class is invalid and needs recompilation: ffhttp_GoogleDrive: line 43, column 28: Invalid type: ffhttp_Client.Credentials ffhttp_GoogleDriveComments	Apex Class	43	36	Dependent class is invalid and needs recompilation: ffhttp_GoogleDrive: line 43, column 28: Invalid type: ffhttp_Client.Credentials ffhttp_GoogleDriveFiles	Apex Class	50	33	Dependent class is invalid and needs recompilation: ffhttp_GoogleDrive: line 43, column 28: Invalid type: ffhttp_Client.Credentials ffhttp_GoogleDriveModelAbout	Apex Class	33	69	Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelAbstractObject	Apex Class	0	0	ffhttp_GoogleDriveModelAbstractObject: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelApiChannel	Apex Class	33	69	Dependent class is invalid and needs recompilation: ffhttp_GoogleDriveModelAbstractObject: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelApp	Apex Class	33	62	Dependent class is invalid and needs recompilation: ffhttp_GoogleDriveModelAbstractObject: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelChange	Apex Class	33	65	Dependent class is invalid and needs recompilation: ffhttp_GoogleDriveModelAbstractObject: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelChannelStop	Apex Class	33	70	Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelChild	Apex Class	33	64	Dependent class is invalid and needs recompilation: ffhttp_GoogleDriveModelAbstractObject: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelComment	Apex Class	33	66	Dependent class is invalid and needs recompilation: ffhttp_GoogleDriveModelAbstractObject: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelError	Apex Class	32	64	Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelFile	Apex Class	33	63	Dependent class is invalid and needs recompilation: ffhttp_GoogleDriveModelAbstractObject: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelParent	Apex Class	33	65	Dependent class is invalid and needs recompilation: ffhttp_GoogleDriveModelAbstractObject: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelPermission	Apex Class	33	69	Dependent class is invalid and needs recompilation: ffhttp_GoogleDriveModelAbstractObject: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelPermissionId	Apex Class	33	71	Dependent class is invalid and needs recompilation: ffhttp_GoogleDriveModelAbstractObject: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelProperty	Apex Class	33	67	Dependent class is invalid and needs recompilation: ffhttp_GoogleDriveModelAbstractObject: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelReply	Apex Class	33	64	Dependent class is invalid and needs recompilation: ffhttp_GoogleDriveModelAbstractObject: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelRevision	Apex Class	33	67	Dependent class is invalid and needs recompilation: ffhttp_GoogleDriveModelAbstractObject: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelTest	Apex Class	40	73	Dependent class is invalid and needs recompilation: ffhttp_GoogleDriveModelAbout: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelUser	Apex Class	32	63	Dependent class is invalid and needs recompilation: ffhttp_GoogleDriveModelAbstractObject: line 33, column 69: Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveModelWatch	Apex Class	33	65	Invalid type: ffhttp_AbstractJsonSerializable ffhttp_GoogleDriveParents	Apex Class	41	35	Dependent class is invalid and needs recompilation: ffhttp_GoogleDrive: line 43, column 28: Invalid type: ffhttp_Client.Credentials ffhttp_GoogleDrivePermissions	Apex Class	41	39	Dependent class is invalid and needs recompilation: ffhttp_GoogleDrive: line 43, column 28: Invalid type: ffhttp_Client.Credentials ffhttp_GoogleDriveProperties	Apex Class	41	38	Dependent class is invalid and needs recompilation: ffhttp_GoogleDrive: line 43, column 28: Invalid type: ffhttp_Client.Credentials ffhttp_GoogleDriveReplies	Apex Class	43	35	Dependent class is invalid and needs recompilation: ffhttp_GoogleDrive: line 43, column 28: Invalid type: ffhttp_Client.Credentials

Failed :

Hi Tony,
Can you check that you have deployed the Core library (https://github.com/financialforcedev/ffhttp-core), as explained in the configuration section of the Readme file (https://github.com/financialforcedev/ffhttp-googledrive#configuration)? Each of the ffhttp libraries is dependent on this being deployed first.
If you are still having problems then I'm happy to take a further look at this.
Cheers,
Matt

Thank you very much!


dropbox: 111.3.447 -> 185.4.6054; dropbox-cli: 2020.03.04 -> 2023.09.06, add meta.mainProgram

Description of changes
Bump dropbox and dropbox-cli versions
add meta.mainProgram

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2864

Result of nixpkgs-review pr 262194 run on x86_64-linux 1

4 packages built:

dropbox
dropbox-cli
dropbox-cli.nautilusExtension
mate.caja-dropbox

Had this PR bookmarked and originally wanted to wait @ttuegel.
But given they haven't responded to the review ping two weeks ago, I will go ahead and merge this.
Thanks!


Issue when opening OSU! Application

Hi!
Thanks for the great work with this project! Currently, I have been able to use the Osu! Mac Agent software to repair Osu, but every time I try to open it, some application looking like terminal flashes for a second and disappears. I can't do anything else. Is there anything I can do to get Osu working again? For the record, I am on an M1 Mac.
Also, I was able to snag a screenshot of the issue that opens.

Thanks :)

Please see https://github.com/Techno-coder/osu-macOS-Agent/issues/10


Fix ClassCastException or unwanted rounding from <numeric> = <number>

Summary of the changes / Why this improves CrateDB
Currently CrateDB cannot handle = comparison on a NUMERIC type against a NUMBER type. Against a double type, there is an implicit cast to numeric type causing unwanted rounding leading to invalid results. Against an integer type, a ClassCastException is thrown. Please see below queries and results:
cr> create table t (a numeric(4,2));
CREATE OK, 1 row affected (1.708 sec)
cr> insert into t values (1.11);
INSERT OK, 1 row affected (0.159 sec)
cr> select * from t where a = 1.111;
+------+
|    a |
+------+
| 1.11 |  -- 1.111 seems to be implicitly casted to 1.11 and falsely matches
+------+
SELECT 1 row in set (1.171 sec)

cr> select * from t where a = 100;
SQLParseException[Cannot cast `100` of type `integer` to type `numeric(4,2)`]

cr> select a = 1.111 from t;
+------------+
| (a = 1.11) |
+------------+
| TRUE       |
+------------+
SELECT 1 row in set (0.296 sec)
cr> select a = 100 from t;
SQLParseException[Cannot cast `100` of type `integer` to type `numeric(4,2)`]

Also see below Postgres behaviour as references:
postgres=# create table t (a numeric(4,2));
CREATE TABLE
postgres=# insert into t values (1.11);
INSERT 0 1
postgres=# select * from t where a = 1.111;
 a
---
(0 rows)

postgres=# select * from t where a = 100;
 a
---
(0 rows)

The cause the current CrateDB's behaviour is due to the implicit casts that try to resolve the eq-operations on numeric to number to a numeric because numeric has a higher precedence. Going back to the example queries, for a = 1.111, 1.111 was implicitly casted to 1.11 causing a false match. For a = 100, 100 did not fit in numeric(4,2) leading to the exception.
To address this issue, I think we need to resolve such cases to use unbounded numeric types, op_=(numeric(null, null), numeric(null,null)) such that the implicit casting always works without loss of precision/scale.
Fixes https://github.com/crate/crate/issues/16838.
Checklist

[x] Added an entry in the latest docs/appendices/release-notes/<x.y.0>.rst for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in the latest docs/appendices/release-notes/<x.y.0>.rst
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Thank you @mfussenegger, I updated the description first.
Btw, this behaviour is not limited to literals,
cr> create table t (a numeric(4,2), b double);
insert intCREATE OK, 1 row affected (1.650 sec)
cr> insert into t values (1.11, 1.111);
INSERT OK, 1 row affected (0.169 sec)
cr> select * from t where a = b;
+------+-------+
|    a |     b |
+------+-------+
| 1.11 | 1.111 |
+------+-------+
SELECT 1 row in set (0.124 sec)

Postgres returns nothing which is also my expectation.

Thx @jeeminso! Does this also fix the issue with a = b (comparing 2 columns of a table)? If so maybe we need to a test (probably integration) for this?

Thank you, yes, added a test and updated the release entry.


Can't build on OSX (anymore)

Hi Paul,
I've just tried rebuilding the latest master, but it seems the new Makefile is not compatible with OSX anymore (at least not 10.8.5). The problem is with the specified linker options -shared and -fPIC.
I've tried using -dylib instead of -shared, which seems to be the OSX linker's equivalent, however it then complains about the "unknown" -fPIC option...
Alas I've got no real experience w/ dynamic libs on OSX, so can't offer any guidance...

I have pushed a change to master so that the makefile no longer builds a dynamic library by default (It's only needed for Chorth).
If you're on dev, in config.mk, you just comment out the the lines following the comment "Build dynamic library" and things should work just fine.
Let me know if things work out okay!

Yep, that works! Thanks a bunch! :)


Strange resolution issues on macOS

Hi, I've been having issues working with glutin on macOS recently.
I am trying to create a 256x256 window. However, after doing this, I get back a window with inner_size 512x468 and outer_size 512x512. I am assuming the sizes are doubled due to hidpi/retina stuff (I am on a macbook pro), but the real issue is the inner size - why is it 468 instead of 512? The title bar is taking up part of the 256x256 rect that I specified.
I also believe that this is causing my OpenGL viewport to be messed up. A 32x32 pixel square is now being shown as slightly rectangular - because the inner size of the window is incorrect, so the gl viewport gets messed up upon context creation (I think).
Here's the code in question:
        let window = glutin::WindowBuilder::new()
            .with_title("Window")
            .with_dimensions(256, 256)
            .with_min_dimensions(256, 256)
            .with_max_dimensions(256, 256);

        let context = glutin::ContextBuilder::new()
            .with_vsync(true);

        let events_loop = glutin::EventsLoop::new();
        let gl_window = glutin::GlWindow::new(window, context, &events_loop).unwrap();

Can somebody clarify what is going on? I think with_dimensions should be specifying the inner size of the window, not the outer size.

Do things work better using tomaka/winit#548? That PR also fixes max/min dimensions on macOS, since before that they constrained the window size including the title bar.

@francesca64 How would I try that? Do I need to rebuild glutin with your WIP branch as the source for it's winit dependency?
I just tried again after removing the min and max dimension calls, and now I'm getting the expected behavior, so I guess they were the culprits.
If your PR has fixes for that, as well as fixes for the DPI stuff, I will be eagerly waiting for it to be merged 😄

Since there are some breaking changes, it would be easier to use the pre-patched glutin branch: https://github.com/francesca64/glutin/tree/super-dpi
I also didn't document the new API yet, so...
let window = glutin::WindowBuilder::new()
    .with_title("Window")
    .with_dimensions(glutin::LogicalSize::new(256.0, 256.0))
    .with_min_dimensions(glutin::LogicalSize::new(256.0, 256.0))
    .with_max_dimensions(glutin::LogicalSize::new(256.0, 256.0));

let context = glutin::ContextBuilder::new()
    .with_vsync(true);

let events_loop = glutin::EventsLoop::new();
let gl_window = glutin::GlWindow::new(window, context, &events_loop).unwrap();

(you could actually just use (256, 256).into())
Then for rendering, you'd use LogicalSize::to_physical(&self, dpi_factor: f64) -> PhysicalSize to get the physical pixels (DPI factor being acquired from Window::get_hidpi_factor), and either access the width and height members (both f64) or use the Into<(f64, f64)> and Into<(u32, u32)> conversions (the latter of which automatically rounds). GlWindow::resize will be changed to take PhysicalSize, but at the moment you have to remember that's what it needs yourself. All window functions both produce and consume either LogicalSize or LogicalPosition, whereas monitor and context functions produce and consume either PhysicalSize or PhysicalPosition.
This will be merged quite soon; I just need to 1) document it, and 2) release 0.15.1 first. Also, since you seem to be trying to make the window un-resizable, you'll soon be able to use the upcoming with_resizable method: tomaka/winit#540


Resolve Contact Us Email Validation Error

[ ] Currently, the Contact Us page is not accepting email addresses with "." before the @ sign, which needs to be modified to accept this format.

[ ] Email address must meet the email format validation

Testing
Test Case:
Tester: @JanellC


v2.5.0 - Refactor with AutoMLPipeline

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/10997
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
git tag -a v2.5.0 -m "<description of version>" 20e17ad378f0253fc9356e73b9b06b0cd03772db
git push origin v2.5.0


Search-UnifiedAuditLog OutVariable Does not Work

Summary
When running Search-UnifiedAuditLog with -OutVariable parameter, it would not save anything in the variable
Proof

Steps to reproduce
Connect to Exchange Online with PowerShell
Run the following command:
Search-UnifiedAuditLog -StartDate (get-date).AddDays(-1) -EndDate ( Get-Date ).AddDays(-0.5)  -OutVariable a
Expected Behavior
Command should fill variable specified in -Outvariable parameter
Additionally, it is expected to have append functionality with -Outvariable +'VariableName'

Managed to find a solution.
It appears we have to create ArrayList and assign it to some variable before we can use it it -Outvariable
$start = (Get-Date).AddDays(-1)
$end = (Get-Date).AddDays(-0.5)
$auditData = New-Object System.Collections.ArrayList
Search-UnifiedAuditLog -StartDate $start -EndDate $end -OutVariable +auditData | Out-Null

@YuriySamorodov Thank you for this feedback and solution.
@chrisda I wanted to make sure this issue and solution was on your radar.


[BUG]: Crabs missing English text translation

Mod Version
1.18.2-2.0.1
Forge Version
40.1.73
What happened?

latest.log
latest.log

This is already fixed in the following versions.

1.18.2
1.19-1.19.2


Update infra-deployments with identityHashes

include template for APIExport
copy, resolve template and push to infra-deployments

What does this PR do?:
Updates infra-deployments with APIExports

Depends on https://github.com/redhat-appstudio/infra-deployments/pull/783


terraform-providers.gandi: init at 1.0.0

Motivation for this change
Finish  #47246
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Attempted: terraform-providers.gandi
Partial log (click to expand)
installing
post-installation fixup
/nix/store/75sq4axgnj6yryrzxbs6yl3p4mf1ym61-terraform-provider-gandi-1.0.0-bin
shrinking RPATHs of ELF executables and libraries in /nix/store/75sq4axgnj6yryrzxbs6yl3p4mf1ym61-terraform-provider-gandi-1.0.0-bin
shrinking /nix/store/75sq4axgnj6yryrzxbs6yl3p4mf1ym61-terraform-provider-gandi-1.0.0-bin/bin/terraform-provider-gandi_v1.0.0
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/75sq4axgnj6yryrzxbs6yl3p4mf1ym61-terraform-provider-gandi-1.0.0-bin/bin
patching script interpreter paths in /nix/store/75sq4axgnj6yryrzxbs6yl3p4mf1ym61-terraform-provider-gandi-1.0.0-bin
checking for references to /build in /nix/store/75sq4axgnj6yryrzxbs6yl3p4mf1ym61-terraform-provider-gandi-1.0.0-bin...
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip

Success on x86_64-darwin (full log)
Attempted: terraform-providers.gandi
Partial log (click to expand)
find: '/nix/store/a5d3nkz0pj4ka5qig1dqiwyc65n1rww2-terraform-provider-gandi-1.0.0': No such file or directory
find: '/nix/store/a5d3nkz0pj4ka5qig1dqiwyc65n1rww2-terraform-provider-gandi-1.0.0': No such file or directory
find: '/nix/store/a5d3nkz0pj4ka5qig1dqiwyc65n1rww2-terraform-provider-gandi-1.0.0': No such file or directory
find: '/nix/store/a5d3nkz0pj4ka5qig1dqiwyc65n1rww2-terraform-provider-gandi-1.0.0': No such file or directory
find: '/nix/store/a5d3nkz0pj4ka5qig1dqiwyc65n1rww2-terraform-provider-gandi-1.0.0': No such file or directory
find: '/nix/store/a5d3nkz0pj4ka5qig1dqiwyc65n1rww2-terraform-provider-gandi-1.0.0': No such file or directory
find: '/nix/store/a5d3nkz0pj4ka5qig1dqiwyc65n1rww2-terraform-provider-gandi-1.0.0': No such file or directory
find: '/nix/store/a5d3nkz0pj4ka5qig1dqiwyc65n1rww2-terraform-provider-gandi-1.0.0': No such file or directory
find: '/nix/store/a5d3nkz0pj4ka5qig1dqiwyc65n1rww2-terraform-provider-gandi-1.0.0': No such file or directory
/nix/store/iynsg8pyja118rgnww5adbc2ql43mm78-terraform-provider-gandi-1.0.0-bin

Success on x86_64-linux (full log)
Attempted: terraform-providers.gandi
Partial log (click to expand)
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/g6cwxhqzbdz303hr5h7d1plr2hhbf9ky-terraform-provider-gandi-1.0.0-bin
shrinking /nix/store/g6cwxhqzbdz303hr5h7d1plr2hhbf9ky-terraform-provider-gandi-1.0.0-bin/bin/terraform-provider-gandi_v1.0.0
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g6cwxhqzbdz303hr5h7d1plr2hhbf9ky-terraform-provider-gandi-1.0.0-bin/bin
patching script interpreter paths in /nix/store/g6cwxhqzbdz303hr5h7d1plr2hhbf9ky-terraform-provider-gandi-1.0.0-bin
checking for references to /build in /nix/store/g6cwxhqzbdz303hr5h7d1plr2hhbf9ky-terraform-provider-gandi-1.0.0-bin...
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
/nix/store/g6cwxhqzbdz303hr5h7d1plr2hhbf9ky-terraform-provider-gandi-1.0.0-bin


update logo to better ratio version

Miso/nijinot on the forum improved the ratios of the logo slightly:
https://www.grin-forum.org/t/grin-logos-for-community-consideration/155/214
direct link to svg
https://gist.github.com/nijynot/5fc37675abbd53171a41a9f22ae1c710

I wouldn't say there's a consensus around this at the moment, see for example here:
https://www.grin-forum.org/t/grin-logos-for-community-consideration/155/218
If such a change should occur, might be worth to discuss further.

Indeed, I still prefer the original.

If it ain’t broke!


Fix wrong order when ordering by string first/last agg with GroupBy V2

Resolves #7691

@jihoonson OK, I will fix it ASAP.


Attempt to avoid a screensaver when using /desktop, bump to turbovnc 3

It seems the previous strategies to avoid a screensaver wasn't working, and that there is a new version of turbovnc out that seems mainly to be a breaking change for windows users.

Can I just say that this is kind-of hilarious that we have moved all of our workflows into modern cloud infrastructure and yet here we are debugging screensaver behavior 😅


Feat Destiny Game Role menu

Added a Destiny Game Role menu using the Gaminator pattern :+1:
TODO: Potentially some DRY'ing and some discussion

Awesome, thanks for the review Oxy. We could either merge this now and then add the subclass, or feel free to work off this branch also, whatever works. :+1:

Going to merge for now. :+1:


Missing synchronisation in FsVault

deleteSecret method is missing synchronisation. (How about backing the class with a ConcurrentHashMap?)
https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/blob/84bb9597b4ed18ad177fe82e475661a53000d762/extensions/filesystem/vault-fs/src/main/java/org/eclipse/dataspaceconnector/security/fs/FsVault.java#L80

Thanks for reporting the issue! It looks like the method is missing the synchronized keyword, since there is also a file write operation that needs to be taken care of. Are you interested in creating a PR?

Could we use a lock instead? Otherwise we should document the cases where synchronized would be preferred.

I think the answer is whatever is easier for the given situation. In this case, we don't need r/w locks (the FS Vault is not intended to be performant or used in production).

Why not use the FS Vault in production? Is this documented?
On the Provider side we are using it only for storing temporary SAS tokens received from the Consumer. We don't need the overhead of an Azure Key Vault for this.


Source Control

Type: Bug
Not working at all. Cannot stage, unstage changes. Don't see git graph.....
VS Code version: Code 1.85.1 (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:47:11.635Z)
OS version: Linux x64 6.5.0-14-generic
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 5 5625U with Radeon Graphics (12 x 4016)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 2, 1

Memory (System)
14.45GB (8.81GB free)

Process Argv
.

Screen Reader
no

VM
0%

DESKTOP_SESSION
plasma

XDG_CURRENT_DESKTOP
KDE

XDG_SESSION_DESKTOP
KDE

XDG_SESSION_TYPE
x11

Extensions (2)

Extension
Author (truncated)
Version

git-graph
mhu
1.30.0

markdown-all-in-one
yzh
3.5.1

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30899288
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
3biah626:30602489
89544117:30613380
showlangstatbar:30737416
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialogc:30910334
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30902429
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
aa_t_chat:30882232
dsvsc019:30917259

Only downgrade fixed the issue

Git Graph is an extension. Do other source control issues remain after you disable it?

yes, even pure reinstal didn't work. I had to downgrade

Was your pure reinstall running with no added extension?
Which VS Code version did you downgrade to?

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

The source control is broken, I don't know what other details you need to see

@QuaidBartolomei, could you please share the following:

Invoke the "Developer: Toggle Developer Tools command from the command palette and share any errors that you might see there.
Invoke the "Git: Show Git Output" command and share the contents

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Remove title from corp panel

This is completely unnecessary as it is obvious and is just using screen
estate for no real reason. Also we dont do this for any other plugin.
Signed-off-by: Tomas Slusny<EMAIL_ADDRESS>

I thought the title looked nice. I guess I do not care much either way though.