PANIC at Lean.MetavarContext.getLevelDepth

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.
Reduced the issue to a self-contained, reproducible test case.

Description
A panic in Lean.MetavarContext.getLevelDepth.
Steps to Reproduce
-- This file produces:
-- PANIC at Lean.MetavarContext.getLevelDepth Lean.MetavarContext:839:14: unknown metavariable

-- from Mathlib.CategoryTheory.Category.Basic
class Category.{v, u} (obj : Type u) : Type max u (v + 1) where

-- from Mathlib.CategoryTheory.Functor.Basic
structure Functor' (C : Type u₁) [Category.{v₁} C] (D : Type u₂) [Category.{v₂} D] : Type max v₁ v₂ u₁ u₂ where

-- from Mathlib.CategoryTheory.Types
instance : Category (Type u) := sorry

-- from Mathlib.CategoryTheory.Limits.HasLimits
section

variable {J : Type u₁} [Category.{v₁} J] {C : Type u} [Category.{v} C]

class HasLimit (F : Functor' J C) : Prop where
class HasLimitsOfSize (C : Type u) [Category.{v} C] : Prop where
  has_limit : ∀ (J : Type u₁) [Category.{v₁} J] (F : Functor' J C), HasLimit F

instance {J : Type u₁} [Category.{v₁} J] [HasLimitsOfSize.{v₁, u₁} C] (F : Functor' J C) : HasLimit F :=
  sorry

def limit (F : Functor' J C) [HasLimit F] : C := sorry
def limit.π (F : Functor' J C) [HasLimit F] (j : J) : sorry := sorry

end

-- from Mathlib.CategoryTheory.Limits.Types
instance hasLimitsOfSize : HasLimitsOfSize.{v} (Type max v u) := sorry

theorem pi_lift_π_apply {C : Type v} [Category.{v} C] (f : Functor' C (Type max v u)) :
    (limit.π sorry sorry : (limit f) → sorry) sorry = sorry :=
  sorry

Expected behavior:
A typechecking error in the last declaration perhaps (from too many sorries), but no panic.
Actual behavior:
PANIC at Lean.MetavarContext.getLevelDepth Lean.MetavarContext:839:14: unknown metavariable

Reproduces how often:
Consistently.
Versions
Lean (version 4.0.0-nightly-2023-06-22, commit 32e93f1dc1b2, Release)
Additional Information
Minimized from an appearance in the wild on this branch (build log), while trying to forward port https://github.com/leanprover-community/mathlib/pull/19153, needed for defining meromorphic functions on complex manifolds! This panic is not actually blocking progress on that goal!
In the original appearance the PANIC was actually
PANIC at Lean.isLevelMVarAssignable Lean.MetavarContext:393:14: unknown universe metavariable

but during minimization it changed to a different panic without me noticing... If we can fix this but the other persists I can minimize again.

I have experienced this problem as well.


Error

Confession:I'm not a python programmer, just  a newbie wandering around.
I tried  running Sigploit.py and was denied saying that the "fraud" module was missing.
I just deleted the line "import fraud" from Sigploit.py and then was able to execute successfully.
I selected "SS7" module followed by"Simulation mode" I was prompted to run a server(I have no idea what that was).
then, I selected "location tracking" and AnyTimeInterrogation and nothing happened, I was displayed "AnyTimeInterrogation.jar"  failed to launch and the program returned to the main menu.
The same happened when I tried SMS interception and other options.
please help me   Thanks in advance.

@Confidant23 no problem at all we are all newbies :), anyways i have removed the "import fraud" and removed its corresponding function till its ready, thanks for notifying
second find a detailed explanation on how you can use the SS7 module (from the wiki)
Attacking the SS7
In order to attach the SS7 on real life target you should have an access to the SS7 network. It is often provided by VoIP providers, SMS providers, HLR lookup web application providers, you just need to dig deeper to find a suitable provider. The project provides to modes for attacks 1)Simulation Mode 2)Live mode.
Live Mode
In case you succeeded to get the access you can jump into the Live mode and use the parameters that are provided by your provider. The providers will provide you the following parameters
The global title you will use
The point code you will use (client PC)
The peer point code of the provider (Peer PC)
The IP address of the providers peer for SCTP associations and the used port (Peer IP, Peer Port)

All you need to do is to have a static public IP assigned to the sever/machine having the code and the provider will allow it access from its side and route it so you can reach all the operators this provider is connected to
Simulation Mode
In case of no access, and you need to have the sense of attacks and critically of such a threat, you can go to the simulation mode. The project provides the server side code of each and every attack that simulates the corresponding nodes responsible for the requests. The server side jar files be found under "SigPloit/Testing/Server/Attacks/". Each server side code provides the hard coded values that you need to use on the client side to simulate the attack
The brief explanation:

As SS7 needs some access to the SS7 cloud of the operators, i made two modes live and simulation, i have also made the server side codes (source codes and jar files available under Testing/Server/Attacks) along with the used parameters in each case in order for you to simulate and get an idea about the attack, how is run, what are the involved nodes in each attack and what are the expeted data returned

In this case (i.e simulation) you need to run sigploit on two different VMs one for client and other for server, depending on the attack you chose , run the server side jar file to simulate the responses
tell me if you need further assistance

Thanks for your enthusiastic reply.
On Aug 18, 2017 2:37 PM, "Loay Abdelrazek"<EMAIL_ADDRESS>wrote:

@Confidant23 https://github.com/confidant23 no problem at all we are
all newbies :), anyways i have removed the "import fraud" and removed its
corresponding function till its ready, thanks for notifying
second find a detailed explanation on how you can use the SS7 module (from
the wiki)
Attacking the SS7
In order to attach the SS7 on real life target you should have an access
to the SS7 network. It is often provided by VoIP providers, SMS providers,
HLR lookup web application providers, you just need to dig deeper to find a
suitable provider. The project provides to modes for attacks 1)Simulation
Mode 2)Live mode.
Live Mode
In case you succeeded to get the access you can jump into the Live mode
and use the parameters that are provided by your provider. The providers
will provide you the following parameters
The global title you will use
The point code you will use (client PC)
The peer point code of the provider (Peer PC)
The IP address of the providers peer for SCTP associations and the used port (Peer IP, Peer Port)
All you need to do is to have a static public IP assigned to the
sever/machine having the code and the provider will allow it access from
its side and route it so you can reach all the operators this provider is
connected to
Simulation Mode
In case of no access, and you need to have the sense of attacks and
critically of such a threat, you can go to the simulation mode. The project
provides the server side code of each and every attack that simulates the
corresponding nodes responsible for the requests. The server side jar files
be found under "SigPloit/Testing/Server/Attacks/". Each server side code
provides the hard coded values that you need to use on the client side to
simulate the attack
The brief explanation:

As SS7 needs some access to the SS7 cloud of the operators, i made
two modes live and simulation, i have also made the server side codes
(source codes and jar files available under Testing/Server/Attacks) along
with the used parameters in each case in order for you to simulate and get
an idea about the attack, how is run, what are the involved nodes in each
attack and what are the expeted data returned

In this case (i.e simulation) you need to run sigploit on two different
VMs one for client and other for server, depending on the attack you chose
, run the server side jar file to simulate the responses
tell me if you need further assistance
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SigPloiter/SigPloit/issues/106#issuecomment-323301568,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdrLhzH-_GooYXnx3M-jADKol7iJIBCWks5sZVRsgaJpZM4O6-fY
.


README: setup instructions

This issue is reserved for participants of Welcome to Open Source, Atlanta.
If it’s still available after April 2nd, it’s all yours :)

:bug: The Bug
In the testing section of this repository’s README we tell the user to clone the repository using git clone git@github.com:hoodiehq/hoodie-client-task.git. But GitHub itself recommends the https:// protocol instead of the git@ which is SSH (see which remote should I use).
:dart: The Goal
Replace the git clone git@github.com:hoodiehq/hoodie-client-task.git with https://github.com/hoodiehq/hoodie-client-task.git in the README
:clipboard: Step by Step
If this is your first, welcome :tada: :smile: Here is a great tutorial on how to send a pull request

[ ] claim this issue (comment below)
[ ] Clone the repository to your computer
[ ] Edit the README.md file.
[ ] Commit the change docs(README): fixed git clone URL
[ ] Start a Pull Request.  Mention closes #26 in the description of the pull request
[ ] Done :+1: Comment below to ask for a review :)

Ping us in the Hoodie Chat or on Twitter if you have any questions :)

Claimed

done via
https://github.com/hoodiehq/hoodie-client-task/issues/27


Clicking on an entry does nothing

Clicking on an entry highlights it but does nothing
Expected: Show the detailed records of that entry in the side pane

Marked as won't solve - not relevant for a CLI app


App crashes instantly on ios device

Problem
Dioxus app crashes instantly on ios device
Steps To Reproduce
Steps to reproduce the behavior:

Create simple dioxus app
Deploy to ios

Expected behavior
The app to run properly
Screenshots
Cargo.toml
[package]
name = "todos"
version = "0.1.0"
authors = ["Sha-dos"]
edition = "2021"

[lib]
crate-type = ["staticlib", "cdylib", "rlib"]

[[bin]]
name = "todos-desktop"
path = "gen/bin/desktop.rs"

[dependencies]
dioxus = "0.3.2"
#dioxus-desktop = "0.3.0"
dioxus-mobile = "0.3.0"
mobile-entry-point = "0.1.0"
im-rc = "15.0.0"
keyboard-types = "0.6.2"

lib.rs
use dioxus::prelude::*;
use mobile_entry_point::mobile_entry_point;

#[mobile_entry_point]
fn main() {
    dioxus_mobile::launch(app);
}

pub fn app(cx: Scope<()>) -> Element {
    cx.render(rsx!(
        div {
            "Hello from rust!"
        }
    ))
}

Environment:

Dioxus version: [v0.3.2, master]
Rust version: [v1.67.1, stable]
OS info: [MacOS]
App platform: [mobile]

Questionnaire

[x] I'm interested in fixing this myself but don't know where to start
[ ] I would like to fix and I have a solution
[ ] I don't have time to fix this right now, but maybe later

This should be fixed in master now!


Commit comment tests

mr_discussion_test: Add tests for commit comments
Add test for commenting on commits.
Signed-off-by: Prarit Bhargava<EMAIL_ADDRESS>

This MR depends on the deleting notes functionality introduced in #802


sitemap

Describe the requested icon(s)

References

Additional context

example for a sitemap icon

Could tree-structure work for you, or do you need a vertical orientation?

Your choice. One of both variations would be appreciated.
Helena Zhang @.***> schrieb am Mi., 16. Okt. 2024,
02:53:

Could tree-structure work for you, or do you need a vertical orientation?
—
Reply to this email directly, view it on GitHub
https://github.com/phosphor-icons/homepage/issues/574#issuecomment-2415422005,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAP47UTKBL5V5EGA6UH3DETZ3W2ILAVCNFSM6AAAAABN5CMERWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJVGQZDEMBQGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Material component padding on mobile

Material components margins/paddings are well supported on desktop browser but on mobile devices these margins/paddings looks larger and extra spaces are covered on mobile. For eg. left and right margins are by default 16px but this should be lesser in size on mobile devices due to compact screen size.
Is there any way to control these paddings/margins automatically on mob devices?

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.


feat(starknet_gateway): implement sync state reader get block info

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2944
#2942  👈 (View in Graphite)
#2963 : 1 other dependent PR (#2886 )
#2979
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Test get a stake non-extended-key from a stake extended key

Test for node issue https://github.com/input-output-hk/cardano-node/issues/4914


Not able to connect or flash Pixhawk Cube

There have been reports of Pixhawk Cube's not connecting to QGC and not detected for flashing.
https://discuss.px4.io/t/unable-to-connect-with-qgc-with-pixhawk-cube-2-1/12520
Presumably on start no LEDs are on except one orange LED solid on.
Brought up by @RomanBapst.
FYI @davids5

It shows up as:
[291148.647785] usb 1-2: new full-speed USB device number 45 using xhci_hcd
[291148.776486] usb 1-2: New USB device found, idVendor=2dae, idProduct=1001, bcdDevice= 2.00
[291148.776492] usb 1-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[291148.776496] usb 1-2: Product: CubeBlack-BL
[291148.776498] usb 1-2: Manufacturer: Hex/ProfiCNC
[291148.776501] usb 1-2: SerialNumber:<PHONE_NUMBER>51383236333932
[291148.778892] cdc_acm 1-2:1.0: ttyACM0: USB ACM device

And it shows up as:
/dev/ttyACM0
and:
/dev/serial/by-id/usb-Hex_ProfiCNC_CubeBlack-BL_370036000851383236333932-if00
It looks like we don't match for that in our tooling yet, fixed in: #12768.

The link to the fix is probably not correct.

@LorenzMeier thanks for getting me out of that loop :smile:.


Fix Example functions in tests

Example functions in tests do not follow naming conventions of testing
package: https://golang.org/pkg/testing/#hdr-Examples Because of this
examples were not rendered in go docs.

lgtm


Add binder

This PR adds support for binder. 1 thing remains: the environment.yml needs to be populated.
It should contain everything needed to run the .py files and .ipynb, e.g. TensorFlow, Tangram, etc.
I'd use squidpy[all] to handle esda, PyQt (not sure how that will work on binder).
@giovp since you know better what requirements are needed, could you finish this? In the meantime, I will update CSS/conf.py in the main repo.

Let's do it ok, and thanks a lot @michalk8 for setting it up. I'm still not sold about having it tbh...but let's give it a try

Thanks for filling the reqs. Since both repos are now open, I will start cleaning old artifacts, get the docs up.

Quick question: do we really need PyTorch? Also, if yes, the package should be torch.

I've removed PyTorch, because tangram-sc already specifies it.

ping @giovp - awaiting review (maybe also change the merge conditions).

Thanks!


Refactor build system to make configuration switching easier

What is the enhancement?
The Makefile is very coupled to the (libultra-based) Modern SDK. This issue tracks the work of refactoring it so it is easier to switch the toolchain and SDK at build time. There is also an opportunity to fix dependencies.
This will simplify the work of supporting other SDKs (and even potentially other platforms). CMake could be worth using here.

The game is now built using CMake.
This was quite a large undertaking, and I took it as an opportunity to make the build more modular and less error prone (proper dependencies between files, automatic build tool discovery, etc.). It will be much easier to add conditional logic around different build configurations now -- and just easier to use in general.


WIP: Cause ReleaseSuite.TestReleaseImages to fail

This is a dummy PR to trigger ReleaseSuite.TestReleaseImages to fail so we can see why it is taking so long in CI (when I run it manually it takes ~5mins, but it is currently double that in CI).

More recent builds seem to be quicker at running this, but in any case the test takes much less time than the whole test run, so we should aim to parallelise the other tests.


Preserve original comment style when available

Addresses @rwjblue's comment in #382.
This PR is a bit gnarly because I had to string the source through each function. We should rewrite these functions as a methods on a class like these guys.

Hmm why can't we just add a isSafeComment flag to the MustacheComment AST node so that we preserve this information in the AST?

Because it is irrelevant to the semantics of the template, which is what the Abstract Syntax Tree is supposed to capture. For the same reason, we don't capture whitespace into the AST, whether you use {{^}} or {{else}}, etc.

@mmun do you need to rebase?

Will do.

closing due to inactivity and conflicts


checkout shipping address page, when change country, the phone number prefix not follow.

(Please take the time and describe the problem you're having before you propose a solution.)
What I'm trying to achieve
checkout shipping address page,
when change country, the phone number prefix should change too.
but it select +1.
...

Steps to reproduce the problem

when you try to change the address country when checkout.
the phone number country code will not update.

What I expected to happen
it should update. such as I choose UK, it should change to +44
...
What happened instead/how it failed
I change the request POST data to form. and
I follow the code to the saleor/account/i18n.py.
But still not work.
who can show the method it set selected?

I suggest that we change the prefix if the number is not provided. For autofill cases we should provide accurate autocomplete attributes for both subfields:

tel-country-code for the prefix
tel-national for the remainder

yes,  but can't follow the key code, I will try to adjust.


Search name

Try to fix #22
This uses old JavaScript syntax. I am not sure why but it seems you want to support very old JavaScript.

@mafintosh I am blocked on this. If you can solve the issue it would be nice.

Unsure what is blocked and what the feature does.

The goal is to provide a name as the second argument, and the script searches for that package if it was not in the first argument:
var binding = require('node-gyp-build')(__dirname, "my-native-module")

@aminya Can you provide an example? What is the expected directory structure?
Lack of namespacing (other than by node_modules/xyz) is a known problem (https://github.com/prebuild/node-gyp-build/pull/27) but I'm not sure how this PR solves it or that it covers all cases.

@aminya Can you provide an example? What is the expected directory structure?
Lack of namespacing (other than by node_modules/xyz) is a known problem (#27) but I'm not sure how this PR solves it or that it covers all cases.

You can't put index.js anywhere else other than the root of the repository. Builders change the __dirname of a file when they are built. For example, the src code is written to dist.
Here is an example. Try to move index.js to src folder, set the main to dist, and build the code. Everything breaks.
https://github.com/atom-ide-community/fuzzaldrin-plus-fast

I don't think that belongs here. The node-gyp-build interface tells you to pass in the directory where the prebuilds folder is, thats the contract.

Here is an example. Try to move index.js to src folder, set the main to dist, and build the code. Everything breaks.
https://github.com/atom-ide-community/fuzzaldrin-plus-fast

Simple solution: create an /index.js entry point that does module.exports = require('./dist/')(__dirname).


Add Node Evaluation Feedback

Great project!  Looking forward to seeing it grow.  Figure I’d start with a few feature requests.
Would be helpful to have some visual feedback when:

A node/sub graph in the process of being evaluated.
A node evaluation has completed.
A node encounters an error or warning with the evaluation.

Perhaps as well a means to display last eval time of each node.

added moving bubble along wire


Modify rowsToScroll deprecation message to inform about alternatives

Addressing the following discussion: https://github.com/microsoft/terminal/pull/3575#issuecomment-735410139

Given that there's no files changed outside of /doc, automerge will never happen (because CI will never run) :P


Initial setup macie instructions

A reference to the issue / Description of it
New instructions on setting up Macie. Also includes the index to post it to the modernisation-platform instructions.
I have also included some instructions on setting this up using Terraform. This has been tested in Cooker and sets up Macie and includes a sample job. The account should be included in the MemberInfrastructureAccess role so this can be added.
How does this PR fix the problem?
Information

I don't think we should be doing this via the console, it looks like there are all the resources needed to do it via code, did you come across any issues which would prevent us doing it via code?

I did have a look for terraform code to do the implementation and creating the jobs but it was all very limited. The code to create an account was straightforward but linking to other accounts or picking up the correct buckets etc. seemed a little light.

I don't think we should be doing this via the console, it looks like there are all the resources needed to do it via code, did you come across any issues which would prevent us doing it via code?

I did have a look for terraform code to do the implementation and creating the jobs but it was all very limited. The code to create an account was straightforward but linking to other accounts or picking up the correct buckets etc. seemed a little light.

In your guidance I can see you enable Macie, which looks to be possible with this - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/macie2_account
And then create a job which looks to be possible with this:
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/macie2_classification_job
So it seems possible to do what you are advising in the console as code, what were the issues when you tried this?

I haven't actually tried the terraform code, I just looked at it an it looked very limited. I did state that it should be done in terraform and included the examples to do this.
I could give it a go but it would mean opening up Macie elsewhere (30 day trial).
Ewa suggested setting it up in one place to link all of the buckets we want to examine in one place but I think this would also involved setting up Macie in each account you want to use. Again, many account and who would then look at the Macie results? Not us.
If you want I can set up the terraform code in modernisation-platform repo to test it against (somewhere) but I need a location and confirmation you want me to do this.

I haven't actually tried the terraform code, I just looked at it an it looked very limited. I did state that it should be done in terraform and included the examples to do this. I could give it a go but it would mean opening up Macie elsewhere (30 day trial). Ewa suggested setting it up in one place to link all of the buckets we want to examine in one place but I think this would also involved setting up Macie in each account you want to use. Again, many account and who would then look at the Macie results? Not us. If you want I can set up the terraform code in modernisation-platform repo to test it against (somewhere) but I need a location and confirmation you want me to do this. Oh, and I can then post a link in the documentation to some example (maybe use example?) code.

Hi Steve, I wasn't aware you can enable it through code, so if that works, it then does not matter much if we control it from the OU account (like modernisation-platform) or from the member account itself. I would suggest try it with terraform in one of our playground accounts and if that works, then we can roll it out to our users through the member-bootstrap perhaps (or maybe @davidkelliott is aware of a better place for that). If cooker account is the one you used last time, try it in sprinkler or example.

@ewastempel and @davidkelliott I have amended the instructions to list some terraform code (that works if the prerequisite is completed) and posted this. I might need to add something at the top that references this perhaps

I can still see instructions on how to do manually, unless this is absolutely essential, can this be removed please? We are a infra as code first platform, thanks

Will do. I will keep them in place at the bottom unless you have any objections. We may need to look up where the role is set to make sure that is updated but I have not included that in this documentation.

Amended as per comments from Dave Elliott (@davidkelliott )

I don't think we should be doing this via the console, it looks like there are all the resources needed to do it via code, did you come across any issues which would prevent us doing it via code?

Apart from the issue with making sure that the ID has access to the macie2:* I saw no other issues. This, I think, is mentioned in the pre-requisites.

I've added a few changes, I think this needs to be an introduction to what Macie is and does, and a link to code on how to add it to their account.

Where are the changes? Do I need to do a pull to drag them in or have you amended my release?

I've added a few changes, I think this needs to be an introduction to what Macie is and does, and a link to code on how to add it to their account.

I can't see these changes (a release has overwritten them I think). Can you let me know what they were and I will manually put them in or re-enter them into the PR and I will add them

Not to come across as too critical but I don't think this documentation adds a lot of value. We don't go into detail like this on everything we do in our example account. I can appreciate that you want to produce meaningful outputs like this, but a lot of this could be summarised as such:
1. Customers can set up Macie on a per-account basis.
2. We should be aware that this can incur costs.
3. You can see an example of functioning Macie code in example [here](https://a-link-to-the-macie-code-in-example).
4. AWS has documentation [here](https://some-kind-of-link-to-macie-documentation).

Originally I thought you could only do this via the console. After investigating I found it could be done, more easily, through
terraform. This changed the scope a fair bit.
I have kept a copy of the detail I originally wrote in case I need it again but I understand your points


Fix incorrect casing in some Dependabot PR titles

When figuring out which case to use, we were looking at previous Dependabot commit messages.
However, our regexps were trying to match the whole commit messages, not just the commit title, and that was causing some false positives.

Thanks for the swift fix :D


Prepare for Napping

Per https://github.com/babybuddy/babybuddy/pull/325.

Closing until any design changes are implemented in BB.

Closing until any design changes are implemented in BB.

I think it has already been implemented, it would be awesome to have this in the integration though (ive got several zigbee buttons to switch on timer and stop the timer as sleep, but currently it only leaves a note if it was nap or night sleep and later on i need to go through all the entries and change them).

Closed by https://github.com/jcgoette/baby_buddy_homeassistant/commit/5a866bf65721998d6e35b880c6693110f1b07387.


chore: Remove legacy version check in react-native.config.js

Description
Removes legacy version check from react-native.config.js.
Changes
The community CLI is no longer a dependency for React Native, meaning it may not be installed in every project. For example, projects that use Expo won't include the @react-native-community/cli-* packages. Consequently, this check will fail, leading to issues with autolinking components.
This version check can be removed safely, as the 9th version of the CLI was released two years ago.
Tests
This change was tested using expo project on react native 0.76.

Solid points. Will let the CI run, and get it merged if all is good.


[Question] Why Face Analysis Preprocessor stop working with multiple images?

Hi @cubiq, I have a question about multiple reference images.
In previous commits, from 3fa938f (First working version) to 5149a21, Face Analysis preprocessor was working with multiple images, both using single images and video frames.

https://github.com/cubiq/ComfyUI_InstantID/assets/161304036/c395007a-f63f-442a-a3e0-4578233ff942
But after 6938fc7 (bugfix), Face Analysis only recognize the first image. Why is that?
Thanks a lot!

this was done because you can send a batch of reference images that are averaged, but only 1 kps position was used.
now you can send a batch a images for the kps image

Great update, @cubiq! Thank you very much!
Now I go off-topic and start speaking italian (in italic of course):
Volevo cogliere l'occasione per ringraziarti di tutto ciò che fai per questa community, apprezzo moltissimo l'impegno che ci metti nel tuo lavoro e la passione che hai anche nell'insegnare. Sei davvero fantastico, Matteo! Continua così! :)

grazie!


Build app is not loading stories - "Cannot read properties of undefined (reading 'find')"

Describe the bug
I'm using the latest version of histoire with nuxt.
In histoire dev mode everything works ok, but the build app it does not work. I can load the UI just fine, but when I try to click on a story I get the following error in bundle-sandbox-BYbFb-tO.js

Uncaught TypeError: Cannot read properties of undefined (reading 'find')

When I inspect the file all imported name are undefined
import { m as mapFile, f as files, _ as _sfc_main, h as histoireConfig, i as isDark } from "./GenericMountStory.vue2-D3-GW49k.js";

I inspected GenericMountStory.vue2-D3-GW49k.js and it looks ok. The files are there.
I can see that all exported names are set in a promise then. I added a log statement in the then function and I can see that the then resolves after the import, thus the undefined imports.
Reproduction
I currently do not have a reproduction
System Info
System:
    OS: Linux 6.8 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    CPU: (8) x64 Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz
    Memory: 2.46 GB / 15.30 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 20.17.0 - ~/.nvm/versions/node/v20.17.0/bin/node
    Yarn: 1.22.19 - ~/.npm-global/bin/yarn
    npm: 10.8.2 - ~/.nvm/versions/node/v20.17.0/bin/npm
    pnpm: 9.9.0 - ~/.local/share/pnpm/pnpm
  Browsers:
    Chrome: 128.0.6613.119
    Chromium: 128.0.6613.113
  npmPackages:
    @histoire/plugin-nuxt: ^0.17.17 => 0.17.17
    histoire: ^0.17.17 => 0.17.17

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

Further inspection of GenericMountStory.vue2-D3-GW49k.js shows me that in the then function there is no await used. I removed the then wrap around the code and everything is loading again.
let __tla = Promise.all([
  (() => {
    try {
      return __tla_0;
    } catch {
    }
  })()
]).then(async () => {
// no await is used in here! Removing the then around this code fixes the issue.
})


cv2.calcHist interprets image channel differently

When I use (python binding) cv2.calcHist on a 3D matrix Img representing an image, calcHist interprets the first dimension as the channel dimension.
I.e. calcHist used on channels [0] of a (5 x 4 x 3) matrix gives a histogram with a total of 12 counts instead of 20. Inspecting the histogram confirms that calcHist takes slice Img[0 , : , :] to calculate the histogram, where I would expect Img[: , : , 0]. When reading an image Img = cv2.imread(imgfile), the channel information is in the third dim: Img.shape = (400, 600, 3), and depicting Img[: , : , 0] shows it contains one channel of pixels. So it is not an issue of how cv2 expects a multi-channel image to be stored.
Currently, if you simply use cv2.calcHist(img, channels = [0], ...), you get a histogram of the first row over all columns and channels, which is not what you would expect from the documentation.
cv2.calcHist:
cv2.calcHist(images, channels, mask, histSize, ranges[, hist[, accumulate]]) → hist

Code used for testing:
imgname = '/home/beheerder/imgs/img1.jpg'
cvimg = cv2.imread(imgname)
cvimg.dtype
# =>
# dtype('uint8')
cvimg.shape
# =>
# (600, 600, 3)
testim = np.zeros((5, 4, 3), dtype = np.uint8)
testim[:1, :, 0] = 40
testim[:1, :1, 1] = 80
testim[0, :, :]
# =>
# array([[40, 80,  0],
#        [40,  0,  0],
#        [40,  0,  0],
#        [40,  0,  0]], dtype=uint8)
testim[:, :, 0]
# =>
# array([[40, 40, 40, 40],
#        [ 0,  0,  0,  0],
#        [ 0,  0,  0,  0],
#        [ 0,  0,  0,  0],
#        [ 0,  0,  0,  0]], dtype=uint8)

hist = cv2.calcHist(testim, [0], None, [2], [0, 100])
hist
# =>
#array([[ 11.],
#       [  1.]], dtype=float32)
# Fits with making a two-bin histogram of the slice testim[0, :, :],
# not the slice testim[:, :, 0]
histim = cv2.calcHist(cvimg, [0, 1], None, [2, 2], [0, 256, 0, 256])
np.sum(histim)
# => 1800.0

@Lautian , please note that calcHist accepts a list of images, try to call it like this:
hist = cv2.calcHist([testim], [0], None, [2], [0, 100])

You can find some additional information in the tutorial.

That's the problem. The image was silently interpreted as a list of 2D slices, from each of which the first channel (column) is taken, giving the same histogram as for a slice testim[0 , : , :]


Webpack doesn't rebuild when using InjectManifest with a custom service worker

When using the workbox-webpack-plugin with InjectManifest and a custom service worker, the built version (with importScripts) is only created on the initial build. Making changes to the custom service worker source doesn't seem to trigger a rebuild.
When modifying other application files that are used to build bundle or chunk, the service worker is rebuilt correctly. The only issue is no rebuild when changing swSrc.
Library Affected:
workbox-webpack-plugin
Browser & Platform:
Webpack
Issue or Feature Request Description:
When modifying a custom service worker used in InjectManifest, changes to the custom service worker should cause a rebuild.
  const workboxConfig = {
    swDest: 'service-worker.js',
    swSrc: './src/service-worker/sw.js',
    exclude: [/\.map$/, /^(?:asset-)manifest.*\.js(?:on)?$/],
  };

FWIW, I'm using create-react-app with react-app-rewired. Since the initial build works but never rebuilds, I thought the issue might be with the workbox-webpack-plugin.
Please let me know if there's any additional information I can provide to help with this.

Webpack is not watching the customized service worker script, but if you make changes to a file that Webpack is watching, then the change will be reflected.
It is probably possible to force triggering a rebuild when the customized service worker script changes.


Assume features in development in Chrome are also in development in Opera

See also #302.

Perfect! Any ETA on when this will be reflected in https://platform-status.mozilla.org/?

As soon as #319 is merged, I hope today :)

:+1:


Enumeration values don't respect original letter casing in generated C# clients when used in URL query

Enumeration values don't respect original letter casing in generated C# clients when used in URL query
Sample Swagger:
{
  "swagger": "2.0",
  "paths": {
    "/config": {

      "get": {
        "operationId": "getAppConfig",
        "parameters": [
          {
            "name": "include",
            "description": "A comma delimited list of config objects to return.\nIf none specified then all configuration is returned.\n",
            "in": "query",
            "type": "array",
            "items": {
              "type": "string",
              "enum": [
                "sitemap",
                "navigation",
                "general",
                "i18n"
              ]
            },
            "collectionFormat": "csv"
          }
        ],
        "responses": {
          "204": {
            "description": "The list of available pages"
          }
        }
      }
    }
  }
}

The generated enumeration POCO (NSwagStudio v<IP_ADDRESS>):
[System.CodeDom.Compiler.GeneratedCode("NJsonSchema", "<IP_ADDRESS> (Newtonsoft.Json v<IP_ADDRESS>)")]
public enum Anonymous
{
	[System.Runtime.Serialization.EnumMember(Value = "sitemap")]
	Sitemap = 0,

	[System.Runtime.Serialization.EnumMember(Value = "navigation")]
	Navigation = 1,

	[System.Runtime.Serialization.EnumMember(Value = "general")]
	General = 2,

	[System.Runtime.Serialization.EnumMember(Value = "i18n")]
	I18n = 3,
}

The generated C# client method (NSwagStudio v<IP_ADDRESS>):
public async System.Threading.Tasks.Task GetAppConfigAsync(System.Collections.Generic.IEnumerable<Anonymous> include, System.Threading.CancellationToken cancellationToken)
{
	var urlBuilder_ = new System.Text.StringBuilder();
	urlBuilder_.Append(BaseUrl != null ? BaseUrl.TrimEnd('/') : "").Append("/config?");
	if (include != null) foreach (var item_ in include) { urlBuilder_.Append("include=").Append(System.Uri.EscapeDataString(System.Convert.ToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append("&"); }
	urlBuilder_.Length--;

	var client_ = new System.Net.Http.HttpClient();

The requests sent by this method will use property names instead of EnumMember values.
I expect that the same issue may happen in URL paths.

This causes my proxy to fail because the 3rd party API is case-sensitive :-/

The problem here is that System.Convert.ToString(enum) uses the enum name instead of the EnumMemberAttribute.Value... How could we fix that in the simplest way?

looks like there is no specific reusable function to do that in the BCL. All resources I found suggested to use reflection directly, e.g. https://forums.asp.net/t/2050963.aspx?How+to+get+EnumMember+value+

Alternatively we could use some NuGet library to support it, but that would require introducing a 3rd party dependency... https://www.nuget.org/packages?q=string+enum

It’s important that the generated code does not depend on 3rd party libraries except the BCL and Newtonsoft.Json (which cant be avoided). The biggest problem is, that we may need conditional logic for enums which make the templates even more complicated. We could however use:
JsonConvert.SerializeObject(param).Trim(‘“‘)

This is issue still occurs - <IP_ADDRESS> , when creating C# Client

  "someEnum": {
    "type": "object",
    "properties": {
      "someEnumProperty": {
        "description": "",
        "enum": [
          "M",
          "S",
          "R",
          "L",
          "T",
          "m",
          "Y",
          "C",
          "N",
          "W",
          "w"
        ],
        "example": "R",
        "type": "string",
        "maxLength": 1
      }
    }
  }

When generating the C# Client:
`
[System.CodeDom.Compiler.GeneratedCode("NJsonSchema", "<IP_ADDRESS> (NJsonSchema v<IP_ADDRESS> (Newtonsoft.Json v<IP_ADDRESS>))")]
public enum SomeEnumProperty
{
    [System.Runtime.Serialization.EnumMember(Value = @"M")]
    M = 0,
    [System.Runtime.Serialization.EnumMember(Value = @"S")]
    S = 1,
    [System.Runtime.Serialization.EnumMember(Value = @"R")]
    R = 2,
    [System.Runtime.Serialization.EnumMember(Value = @"L")]
    L = 3,
    [System.Runtime.Serialization.EnumMember(Value = @"T")]
    T = 4,
    [System.Runtime.Serialization.EnumMember(Value = @"m")]
    M = 5,
    [System.Runtime.Serialization.EnumMember(Value = @"Y")]
    Y = 6,
    [System.Runtime.Serialization.EnumMember(Value = @"C")]
    C = 7,
    [System.Runtime.Serialization.EnumMember(Value = @"N")]
    N = 8,
    [System.Runtime.Serialization.EnumMember(Value = @"W")]
    W = 9,
    [System.Runtime.Serialization.EnumMember(Value = @"w")]
    W = 10,
}`

The first Case is in Upper, so it generates two W enum item


Decide how we want to handle package-lock.json (and yarn.lock)

We should either add this file to .gitignore because all of our dependencies are part of our build process and we want the latest version and if it breaks it is not catastrophic OR we should check this file in (which should be its own commit).
To complicate things, I've started using yarn rather than npm, which generates yarn.lock instead.
It seems kind of heavy to have two different lock files included, so I guess I'm leaning towards adding both of these files to .gitignore (but I'm open to other opinions).

I have done a quick read of the docs for both yarn.lock and package-lock.json and they both suggest that they should be under source control.
However, in the case of cloning the repo and downloading the packages you can use npm install --no-package-lock or yarn install --no-lockfile.
This says to me, drop it in the .gitignore, like you say it's part of the build process of the theme and you want the latest version.

Thanks for doing the leg work on reading those docs.

This says to me, drop it in the .gitignore, like you say it's part of the build process of the theme and you want the latest version.

Cool, let's plan to add them both to .gitignore

I've updated the title of this issue, now that we have a game plan.

@salcode
This could be something to consider if there is a way to do this for yarn as well.
https://www.codementor.io/johnkennedy/get-rid-of-that-npm-package-lock-json-e0bj7ai42


align updated

@v-hearya,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

patterns-practices/api-prism-v5-201404_pandp_50/api-prism-v5-201404_pandp_50_62188527.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[#Wave-Control: Add NetSuite] Reuse Existing Connection for NetSuite and Sage Intacct

Details

Covers the implementation of Reusing an Existing Connection.
It loads a policy, copies over the requested connection into the new policy, and then saves the new policy.

Prerequisite

Collect workspace with accounting enabled.
NetSuite beta enabled for the user.  You can return true in the canUseNetSuiteIntegration method.
Have NetSuite connected on another workspace.

Fixed Issues

$ https://github.com/Expensify/App/issues/45349
PROPOSAL:
Tests

Open the app.
Have a workspace with NetSuite connected.
Take another workspace not connected to Accounting.
Go to Accounting from the LHS
Verify that you're able to see Net Suite in the available connections along with the Oracle NetSuite logo.
Click on the Connect button.
You should see two options: Create new connection and Reuse existing connection.
Clicking create new connection and verify that the token input steps work as expected.
Disconnect from the policy and repeat Connect with Reuse existing connection.
You should see a list of workspaces already connected to NetSuite with the last successful sync date.
Click on any of the policies, and verify that you're connected to NetSuite.

[ ] Verify that no errors appear in the JS console

Offline tests

Same as Test Steps
QA Steps

Same as Test Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/ed01bdba-bdb5-4b91-8c7c-9651e9e6d8d1

Android: mWeb Chrome
https://github.com/user-attachments/assets/33068ab3-f179-4622-98df-f268665b8170

iOS: Native
https://github.com/user-attachments/assets/aedddb18-8ded-4fb2-8410-f2318ecb685c

iOS: mWeb Safari
https://github.com/user-attachments/assets/cb9cc3b3-5001-4e92-a502-469dfbf64366

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/083bdcaa-c991-4b47-98dc-73682ad1874f

MacOS: Desktop
https://github.com/user-attachments/assets/0cf11917-f9a1-4a23-ad05-28288e140798

@parasharrajat Please ignore this PR.
@shubham1206agra @yuwenmemon For your review.

@mananjadhav Please remove the Intacct portions we'll be adding them in #44850

@yuwenmemon I merged with main that included Intacct code. I still retained the pieces from this PR that refactored the methods.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.8-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.8-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.9-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


add ragged, scalar R-hat function

Add the potential scale reduction convergence statistic that accepts ragged input arrays.

[x] add an R-hat function that takes multiple chains of potentially different lengths and returns the traditional Gelman and Rubin diagnostic (1992) as defined in Bayesian Data Analysis, 3rd edition.
[x] add tests against alternative or known implementations

[ ] stretch goal: add ranked version
[ ] stretch goal: add split R-hat (just splits chains in half and feeds to R-hat; see BDA3)

finished basic function; still need to add ranked and split versions


Prefix for own logging

What do you think of prefixing the plugin's own logging with "[NpmInstallPlugin] " or similar so it's clear where it's coming from?

That'd be great.  I've personally used debug since it seems ubiquitous.

We could have default and make it configurable.
From the perspective of integrating NpmInstallPlugin into toolkits, its output logging becomes part of your UI, which is the primary reason for this and a quiet flag.


Update Bazel Dockerfile [phab:D218]

Created by zarko at 2015-04-23 20:40:01:
We need to pick up the test fix from upstream,
install libcurl, and (as cleanup) remove jq.

schroederc commented inline (context lost during migration) at 2015-04-23 20:42:53:
Why not the latest? 4e09fd671bdcd27428821684d171ede6ed2eb820

zarko wrote at 2015-04-23 21:01:33:

Update bazel hash.

schroederc accepted this revision at 2015-04-23 21:03:08

zarko closed via commit 5ff07d9db478da5f424d9da616b653511aace045 at 2015-04-23 21:03:45


Walkthrough in doc page "Create a C++ extension for Python" does not work

I had some success with using pybind11 for calling Python scripts from the C++ side. But this does not bring solutions for my project nearer. So I returned to creating C++ extensions for Python.
I try to follow the walkthrough in the relevant doc page for Visual Studio 2022, but still without success. I am prepared to note down my experiences here and hope that I get it running in the end and that it contributes to improving the docs.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 40e3b6b1-a3d2-f4f2-b1ad-dd654a062343
Version Independent ID: b2418b84-04f4-60d2-ec1d-291a5d4d0c51
Content: Write C++ extensions for Python - Visual Studio (Windows)
Content Source: docs/python/working-with-c-cpp-python-in-visual-studio.md
Service: visual-studio-windows
Sub-service: python
GitHub Login: @cwebster-99
Microsoft Alias: cowebster

@goofy2k Thanks for filing the issue. Are there specific sections of the tutorial that you are running into issues with so that we can better update the documentation and provide help?

Hi, my issues start when I try to build the fastcode and fastcode2 projects I will prepare a detailed description, but this will take me a while. Appreciate that you are very responsive!

Here is the first part of the walkthrough. I only give details when they are different than in the docs. Maybe this already contains some clues why things are not working.
To be honest:  I have read the Prerequisites section and I am not sure that my existing Python installation contains the recommended debugging symbols. Nevertheless I will describe my experiences.
Create the Python application
After step 2. in creating the Python application I get a warning:
Warning		The reference assemblies for .NETFramework,Version=v4.7.2 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks	Python_app	C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets	1241
But the pure Python script from the docs runs OK.
Create the core C++ projects
My solution header reads Python_app, which is the same as the name of the script file.
Step 2. I had to remove the already existing folders superfastcode and superfastcode2. Did this outside the VS IDE.
Step 4. After this step I have the superfastcode.cpp file. It is an empty file in this stage.
Step 7. Configuration Properties > General > Target Name: $(ProjectName)  (kept this, I don't have python_d.exe or the _d.lib
    C/C++ Preprocessor > Preprocessor Definitions:  was _DEBUG  _CONSOLE   set to NDEBUG, so removed _CONSOLE
    C/C++ Preprocessor > Code Generation: set to Multi-threaded DLL (/MD)

Step 9. debug config builds OK.  release config gives:
Error	LNK2001	unresolved external symbol main	superfastcode	C:\Users\Fred\source\repos\superfastcode\MSVCRT.lib(exe_main.obj)	1
Error	LNK1120	1 unresolved externals	superfastcode	C:\Users\Fred\source\repos\Python_app\x64\Release\superfastcode.exe	1
Debug folder contains superfastcode.pyd.recipe (not superfastcode.pyd)
Release folder does not contain such a file.
NOTE: in this stage the .cpp files are still empty files.
Q: is there a way to make the settings for superfastcode defaults such that I can re-use them for superfastcode2?

For conversion to extensions for Python I prefer the pybind11 option.
Step 5. The superfastcode builds OK in the Debug config
Make the DLL available to Python
Step 2. Only selected superfastcode for now
Did not follow the alternative method (yet)
Call the DLL from Python
Step 1. Only copied the lines for superfastcode
Step 2. gives: ImportError: dynamic module does not define module export function (PInit_superfastcode)

(excuse me for the header format in some of the lines. Don't know how to remove that. In my editor window I don't see markup symbols. )
I tried to repair this last error. Noticed that the code in step 4 under Use PyBind11 contains:
PYBIND11_MODULE(superfastcode2, m) {
I assume that the 2 must not be there for the superfastcode project.
The error does not disappear after rebuilding the superfastcode project.

The error IS resolved after I also removed the 2 in the code under step 4 under Use PyBind11. (the line with PYBIND11_MODULE)
I think it is wise to describe in the doc that for the 2 projects the C++ AND the Python codes are slightly different.
What remains:  the code only runs for the debug config and not for release.
Remark: for COUNT = 500000 the Python calculation takes 0.689 seconds, against 3.00 seconds for the C++ / pybind11 code.

Got the release version of superfastcode running ! The setting Configuration type was still .exe

Now I have project superfastcode running in the 2 configs, debug and release.
Is it posiible to copy/clone this project to have a quickstart for project superfastcode2?

After some time a newbie, like me, starts to learn the workflow....
The steps under Create the core C++ projects could be clearer.
Step 6a. let's the reader select Active (Debug)
Step 9. let's the reader test both configurations
If the reader follows the steps literally, the test of the release config will fail as it was never configured.
So in fact steps 1 to 11 should be done 4 times: for the two projects and, per project, for the two configs.
In the end this is logical to me, but when one starts from scratch it is not clear.
Going through these repetitive configuration tasks helps for learning, but in the end a few words could be spent to re-using already configured matters. E.g. can you copy a project (fastcode) and use it as a template for fastcode2? Or: can you promote settings in one project or one of the configs to default settings that can be re-used.

In step 7. the reader has to change _DEBUG into NDEBUG.
In my setup there was also an entry _CONSOLE.
I had to remove this to get rid of the Error LNK2001 when building.

In the section Convert the C++ projects to extensions for Python it is not clear a priori that it will be project superfastcode that will be converted using CPython extensions   and that superfastcode2 will be done with pybind11.  Am I correct that this is the procedure?
If so, step 1 unde Use CPython extensions should read:
At the top of the module.cpp file of the fastcode project, include Python.h  etc. etc.
Now I have converted both projects with my preferred method (pybind11) and did I run into some of the errors above.

In the end I managed to use the CPython and PyBind11 routes in both the release and debug configurations!

Thanks for the feedback, @goofy2k!
We've made updates to the docs.

Thats great! I will have a look
Fred
(Goofy2k is just an alias....)
Op vr 15 mrt. 2024 20:23 schreef Megha Anand @.***>:

Thanks for the feedback, @goofy2k https://github.com/goofy2k!
We've made updates to the docs.
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/visualstudio-docs/issues/10054#issuecomment-2000313604,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGII3TS2PSDK36SKSI6NKVDYYNDDBAVCNFSM6AAAAABDMW2AO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBQGMYTGNRQGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


generate TypeScript from JSON schema

I believe you already create TypeScript given a JSON schema. Please export to a file.

in 1.29.0


spark3.0 support is not OK

On support spark3.0 branch,The MVN building  get an error like :
[ERROR] Failed to execute goal on project sample_xgboost_apps: Could not resolve dependencies for project ai.rapids:sample_xgboost_apps:jar:0.2.2-SNAPSHOT: Failed to collect dependencies at ai.rapids:xgboost4j_3.0:jar:1.0.0-SNAPSHOT: Failed to read artifact descriptor for ai.rapids:xgboost4j_3.0:jar:1.0.0-SNAPSHOT: Could not transfer artifact ai.rapids:xgboost4j_3.0:pom:1.0.0-SNAPSHOT from/to spark.sw.nvidia.com (https://gpuwa.nvidia.com/artifactory/sw-spark-maven): gpuwa.nvidia.com: Unknown host gpuwa.nvidia.com -> [Help 1]

Hi, please try our new repo: https://github.com/NVIDIA/spark-xgboost-examples.

Hi, please try our new repo: https://github.com/NVIDIA/spark-xgboost-examples.

Thanks a lot！


:bug: fix-backup

Summary
The postgres pvc do not have owner ref label, so we need to use namespace to wath it.
Related issue(s)
Fixes #

/lgtm


Connection Approval: faulty wiki

Inside the Wiki on the Connection Approval site you are missing the "prefabId" in the returning callback statment.
Is;
private void ApprovalCheck(byte[] connectionData, uint clientId, ConnectionApprovedDelegate callback)
{
    //Your logic here
    bool approve = true;
    //If approve is true, the connection gets added. If it's false. The client gets disconnected
    callback(clientId, approve, positionToSpawnAt, rotationToSpawnWith);
}

should:
private void ApprovalCheck(byte[] connectionData, uint clientId, ConnectionApprovedDelegate callback)
{
    //Your logic here
    bool approve = true;
    //If approve is true, the connection gets added. If it's false. The client gets disconnected
    callback(clientId, somePrefabId, approve, positionToSpawnAt, rotationToSpawnWith);
}

also using ConnectionApprovedDelegate foreces me to include a using stametn which doenst seem to be supported by unity.
using static MLAPI.NetworkingManager;
causes an error in unity that states static cannot be used in Language version 4

using
private void ApprovalCheck(byte[] connectionData, uint clientId, MLAPI.NetworkingManager.ConnectionApprovedDelegate callback)

instead of a static using directive seems to work also. so full working code is:
private void ApprovalCheck(byte[] connectionData, uint clientId, MLAPI.NetworkingManager.ConnectionApprovedDelegate callback)
        {
            //Your logic here
            bool approve = true;
            //If approve is true, the connection gets added. If it's false. The client gets disconnected
            // Set spawning position and rotation for players
            Vector3 positionToSpawnAt = new Vector3(0, 5, 0);

            callback(clientId, 0, approve, positionToSpawnAt, Quaternion.identity);
        }


[Feature-7346] [Python]Add workflow as code task type spark

close #7346

PTAL @zhongjiajie

I restart the failing CI test

PTAL @zhongjiajie

I restart the failing e2e test

Looking good.

Thank's for your review.

Thank's for your review.

No, I thank you, Kai, for the contribution. BTW, We still need to waiting CI passed 👀

Codecov Report

Merging #7968 (c5aeb18) into dev (1067444) will increase coverage by 0.19%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #7968      +/-   ##
============================================
+ Coverage     41.10%   41.30%   +0.19%
- Complexity     3705     3726      +21
============================================
  Files           637      637
  Lines         27058    27129      +71
  Branches       3073     3083      +10
============================================
+ Hits          11122    11205      +83
+ Misses        14862    14849      -13
- Partials       1074     1075       +1

Impacted Files
Coverage Δ

...he/dolphinscheduler/common/enums/SqoopJobType.java
0.00% <0.00%> (-88.89%)
:arrow_down:

...er/master/processor/queue/TaskResponseService.java
50.00% <0.00%> (-18.19%)
:arrow_down:

...rver/master/processor/queue/TaskResponseEvent.java
93.54% <0.00%> (-6.46%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...inscheduler/common/task/sqoop/SqoopParameters.java
74.00% <0.00%> (-2.00%)
:arrow_down:

...olphinscheduler/plugin/alert/email/MailSender.java
72.72% <0.00%> (-1.40%)
:arrow_down:

...cheduler/plugin/alert/dingtalk/DingTalkSender.java
34.42% <0.00%> (-0.53%)
:arrow_down:

...er/server/master/runner/WorkflowExecuteThread.java
9.59% <0.00%> (-0.32%)
:arrow_down:

...er/api/service/impl/TaskDefinitionServiceImpl.java
21.99% <0.00%> (-0.06%)
:arrow_down:

...atasource/api/provider/JDBCDataSourceProvider.java
2.22% <0.00%> (-0.06%)
:arrow_down:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1067444...c5aeb18. Read the comment docs.


installation failed

i am trying to install chainercv on linux mint 19, with following configuration.
cuda - 9
linux kernel - 4.15.0-24-generic
nvidia - 390.48
i am getting the following error.
/usr/lib/gcc/x86_64-linux-gnu/7/include-fixed/limits.h:194:15: fatal error: limits.h: No such file or directory
#include_next <limits.h>  /* recurse down to the real one */
^~~~~~~~~~
compilation terminated.
error: command 'gcc' failed with exit status 1
any help would be appreciated.

Please try chainer's examples (e.g. MNIST) first.

I have no idea. Chainer and ChainerCV use very similar configuration.

i am closing it as the issue is happening only inside conda environment. since chainercv does not have any official builds inside conda environment.


refactor: make timemargin applicable to individual engines

@gahtan-syarif it isnt that difficult, is it?^^

lol nvm what i said then :D

btw i noticed the timemargin is no longer stored in the tournament_options header? where is it stored alongside all the other engine config options

there are two main config objects, tournament and engine ones
https://github.com/Disservin/fast-chess/blob/master/src/main.cpp#L17
engineconfig is also in types see:
https://github.com/Disservin/fast-chess/blob/master/src/types/engine_config.hpp


Add support for yandex video searches

Only did a quick read but it looks like it might require returning a video element with the player URL in the initial HTML when it's being crawled by yandex. That definitely would be tricky.
https://yandex.com/support/video/partners/videoplayer.html

Issue moved to OdyseeTeam/odysee-frontend #24 via ZenHub


A couple og missing information about the setup

Hi,

dex.k8s.example.com & login.k8s.example.com

example.com is not a valid domain name, is there a way to run the setup without using theses domain names (minikube will not run the example, as far as I know, so /etc/hosts cannot be used).

--oidc-ca-file=/etc/kubernetes/ssl/letsencrypt.pem: Letsencrypt CA file because we will use automatic certificate requests.

Where do I get the letsencrypt.pem file from? Is this running with staging certificates?

Expected output of commands, and explanation of what they do, is needed. It would be nice if there were more explanation.

Hi @nikolajbrinch,

Yes example.com is an example, you will need to configure your /etc/hosts (and minikube's one) to resolve the name. You can also try nip.io (used by minishift for setting up routes)

You can get the CA file from letsencrypt website. I think this CA is for production certs.
You can also use a custom pki, and generate your own certs. I'll had a full example with a custom CA.

Which commands do you speak about ? Commands used to deploy the helm chart or commands for the kubenertes manifests ?

Regards,

I figured it out :-) I just created a domain-name and used that including som CNAMEs for subdomains (dex, loginapp etc.), and used cert-manager for Letsencrypt. Everything works out fine - but it took a couple of days and a lot of searching around. I used the standard Dex chart and the example-app from dex to get initial bootstrapping done.
I can't get minikube to boot using oidc konfiguration for the API server (latest version), so I droppen Minikube, and used acs-engine on Azure (that is what my company uses).
I never found a way to get trust into K8s, Dex & loginapp for letsencrypt staging certificates (or self signed ones) - maybe there is a way. Getting it up running with pure HTTP to begin with might be an option.
The kubectl commands.

Is the CRD still necessary for the authcodes? I can see that Dex itself creates a lot of CRDs when it starts.
Somewhere in one of the charts, I find that the Dex service account is given cluster-admin role, is this really a good idea og even necessary?
Thank you for your time and a great product!

I can't get minikube to boot using oidc konfiguration for the API server (latest version)
Did you used the following options for minikube ?

[...]
--extra-config=apiserver.Authorization.Mode=RBAC \
 --extra-config=apiserver.Authentication.OIDC.IssuerURL=https://dex.example.com:5554/dex \
 --extra-config=apiserver.Authentication.OIDC.UsernameClaim=email \
 --extra-config=apiserver.Authentication.OIDC.ClientID="minikube" \
 --extra-config=apiserver.Authentication.OIDC.GroupsClaim=groups \
 --extra-config=apiserver.Authentication.OIDC.CAFile="/minikube-host/ssl/ca.pem" \
[...]

Getting it up running with pure HTTP to begin with might be an option.
Kubernetes will refuse to configure a non-https oidc issuer (or maybe there is an insecure option I did not see !)

I will add more doc + an example to easily setup the chart with minikube

Is the CRD still necessary for the authcodes? I can see that Dex itself creates a lot of CRDs when it starts.
I think yes, one of the crd created is used for authcodes.

Somewhere in one of the charts, I find that the Dex service account is given cluster-admin role, is this really a good idea og even necessary?
...where ?

Dex get is own ClusterRole with the following access rules:
rules:
- apiGroups: ["dex.coreos.com"] # API group created by dex
  resources: ["*"]
  verbs: ["*"]
- apiGroups: ["apiextensions.k8s.io"]
  resources: ["customresourcedefinitions"]
  verbs: ["create"]

Closing this issue because of inactivity.
Re-open if you have more questions.


Fixed #28918 -- Fixed Model.refresh_from_db() for instances hidden by the default manager.

https://code.djangoproject.com/ticket/28918

wow


Support for callback function to skip tests

Addition of a skipTest callback function param which provides a higher degree of customization to determine if a test should be skipped or not.

this could potentially make the skipTestNames param redundant earlier but I'd leave it there for backwards compatibility just in case someone has already started using it 👍

There is already a silenceMessage function, could it provide what you need?
Otherwise, it could be nice to extend it to match your needs.

There is already a silenceMessage function, could it provide what you need? Otherwise, it could be nice to extend it to match your needs.

Unfortunately not :x since silenceMessage works for specific error messages like:
Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

which is pretty generic and happens across multiple test suites 😄 we're trying to ignore only specific files and not for all error messages of that kind

Ok I get your point. Let's keep like this. However I would remove the skipTestNames option. I have no issue with bumping a major release to be safe.
One last thing, could you add one test case for th renew option please?

Ok I get your point. Let's keep like this. However I would remove the skipTestNames option. I have no issue with bumping a major release to be safe.
One last thing, could you add one test case for th renew option please?

Added as of previous 2 commits 😄

Hey @ValentinH any word on reviewing this PR? 😄 Just wanted to make sure it wasn't forgotten, no rush if you're busy atm 👍

I'll merge this on Monday. Sorry for the delay .

Released as https://github.com/ValentinH/jest-fail-on-console/releases/tag/v3.0.0 🚀

Released as https://github.com/ValentinH/jest-fail-on-console/releases/tag/v3.0.0 🚀

Yayy thank you! 🙌


Create Reporting Guidelines file

Is your feature request related to a problem?
The project is missing Reporting Guidelines that should be the same in every repository.
Report Guidelines: https://github.com/anitab-org/anitab-org.github.io/blob/develop/reporting_guidelines.md
Describe the solution you'd like
Create a REPORTING_GUIDELINES.md in the root? or .github folder
Describe alternatives you've considered
N/A
Additional context
N/A

https://github.com/anitab-org/mentorship-flutter/pull/5 done, @isabelcosta it looks like i don't have write access to this repo, so i will not be able to review PR's untill requested

added in #6 this also fixed the pull request temlpate issue

@Techno-Disaster in the PRs while we are not using the PR template please put Fixes #issue so that GitHub recognizes that should close the issue


docs: refactor (WIP)

Please describe the changes this PR makes and why it should be merged:
This here will contain changes to the docs based on feedback gotten from Sarah Kim (From Solidjs)
Status

[ ] Code changes have been tested against prettier, or there are no code changes
[ ] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[ ] This PR changes the codebase

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
[ ] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)

[x] This PR only includes non-code changes, like changes to documentation, README, etc.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 25.706%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1257

Relevant Lines:
5082

💛  - Coveralls

Check this out, please @aidenybai, @SukkaW.

A lot of these are mostly nitpicks, so feel free to use them or not. If you have any questions regarding what I suggested, let me know.
Some comments just for overall docs writing:

Try to avoid using contractions (don't, let's). This is mostly just for ease of reading / helping people who are ESL.
Avoid using common "turns of phrase". These can shorten things dramatically and, again, helps with people who are not natively English speaking.
When you are referring to the user, you don't want to assume any of their knowledge. Saying things like "you may have heard" is more something for blog posts vs docs. If you want to "talk" to them specifically, it should be in reference to steps vs what they should / should not know.
For ease of editing, having each sentence on it's own line can make your life easier. That way if you have to edit one thing in one sentence, you don't have to look at a really large suggestion.
Write with certainty unless there are cases that it is not necessary. Saying words like "technically" introduces confusing. If you have you encounter a situation where it is necessary to say something may or may not happen, you can use "while x can occur, y is the expected" or something like that.
Are internals and the reference section different? They may need to be better classified.
I think your structure has improved! It's a lot easier to follow (imo)

With the Rules of Blocks page:

I'd avoid the "you are probably here". Just start with something like "When working with blocks, there are 3 common reasons you may encounter errors:".
You can avoid adding "you" in each bullet point:

1. Breaking [rules of blocks](#link-to-section)
2. Not [adding the compiler](#link-to-section)
3. Encountering [unsupported behaviour](#link-to-section)

This is all I have to say at the moment! This is a bit beefy of a review, but let me know if there's any questions or comments. That includes if you don't agree with me 😁

Thank you very much @LadyBluenotes for these!! I have a quick ask regarding the comments, are there cases in the docs where you've seen this?
I have applied the amazing changes you suggested for the Rules Of Blocks 😁 😁 😁

@tobySolutions Which cases are you referring to me having seen?

Like are there cases in the docs where you've seen that general advice you mentioned weren't applied by me maybe?
I'm just asking generally, really.

I'm going to assume you're referring to avoiding the use of contractions, expressions, etc?
If you're wondering about those specifically, Google has a good technical writing course that helps with foundations (https://developers.google.com/tech-writing/overview). A lot of the information I've gained is reflected in that course. There are a few talks I can forward you, too, that go into what "good" documentation looks like.
Additionally, I learned from a few mentors what they've seen as most effective when they write. With editing, having sentences on their own lines (in markdown, specifically), makes the review process easier, for example. You can better target sentences and it improve readability during the editing process (eg. easier to identify grammar mistakes, sentences that could be shortened, etc. because you don't have to sift through a large paragraph).
If I'm misinterpreting the question, please let me know.

Hmm, thank you very much for these @LadyBluenotes, I'm gonna be adding these feedbacks soon to make the necessary updates.

A lot of these are mostly nitpicks, so feel free to use them or not. If you have any questions regarding what I suggested, let me know.
Some comments just for overall docs writing:

Try to avoid using contractions (don't, let's). This is mostly just for ease of reading / helping people who are ESL.
Avoid using common "turns of phrase". These can shorten things dramatically and, again, helps with people who are not natively English speaking.
When you are referring to the user, you don't want to assume any of their knowledge. Saying things like "you may have heard" is more something for blog posts vs docs. If you want to "talk" to them specifically, it should be in reference to steps vs what they should / should not know.
For ease of editing, having each sentence on it's own line can make your life easier. That way if you have to edit one thing in one sentence, you don't have to look at a really large suggestion.
Write with certainty unless there are cases that it is not necessary. Saying words like "technically" introduces confusing. If you have you encounter a situation where it is necessary to say something may or may not happen, you can use "while x can occur, y is the expected" or something like that.
Are internals and the reference section different? They may need to be better classified.
I think your structure has improved! It's a lot easier to follow (imo)

With the Rules of Blocks page:

I'd avoid the "you are probably here". Just start with something like "When working with blocks, there are 3 common reasons you may encounter errors:".
You can avoid adding "you" in each bullet point:

1. Breaking [rules of blocks](#link-to-section)
2. Not [adding the compiler](#link-to-section)
3. Encountering [unsupported behaviour](#link-to-section)

This is all I have to say at the moment! This is a bit beefy of a review, but let me know if there's any questions or comments. That includes if you don't agree with me 😁

Thank you very much for the Google resource!

It is intended for developers creating their own frameworks. It is not recommended for general use.

Much appreciated. Thanks for this.

@tobySolutions Which cases are you referring to me having seen?

Like are there cases in the docs where you've seen that general advice you mentioned weren't applied by me maybe?
I'm just asking generally, really.

I'm going to assume you're referring to avoiding the use of contractions, expressions, etc?
If you're wondering about those specifically, Google has a good technical writing course that helps with foundations (https://developers.google.com/tech-writing/overview). A lot of the information I've gained is reflected in that course. There are a few talks I can forward you, too, that go into what "good" documentation looks like.
Additionally, I learned from a few mentors what they've seen as most effective when they write. With editing, having sentences on their own lines (in markdown, specifically), makes the review process easier, for example. You can better target sentences and it improve readability during the editing process (eg. easier to identify grammar mistakes, sentences that could be shortened, etc. because you don't have to sift through a large paragraph).
If I'm misinterpreting the question, please let me know.

You answered perfectly. Could you maybe forward those talks and maybe expatiate on the one-line thing? Thanks

So re: structure of the pages.
Tutorial & Guides
Tutorials and guides are hard to distinguish (IMO) but they serve two very different things. They both, as an example of how they're similar, provide directions for the user to follow. They're used as a means to tell the user what to do more than what they need to know.
They do, however, serve different needs.
Tutorial

Someone who is studying and wants to learn the general skills / principles of something
More learning orientated - basically learning skills through the hands on experience
Gets the user familiar with the product (in this case million)
An example of this: Creating a block component
This kind of thing is aimed at just teaching. Meaning you don't introduce any confusion to the person following.
Does not assume any knowledge other than the basics
More specific

Guides

Help the user who already has a basic idea of what is going on complete a particular task.
Directs the users work but can lead to different routes - meaning you can say "you could do x but you can also do y"
Relies on the user's already present knowledge
More general

What I meant by the Usage Guide was more that it follows more of a tutorial-based format than the guide based one (which I don't think is a bad thing, just unsure of what you want of it).
For example, you could split the page up because right now there is a lot happening within the one page and it's hard to follow. What I might do if I were you was:

Tutorial on how to integrate million into an existing application. This can include any information necessary for someone who is looking to integrate into their existing app and wants to know what it would look like explicitly.
Guide on optimizing list rendering. You have this already, just making it into its own page would be a better idea imo. Good opportunity to show how to use <For>.
Guide on blocks. This can start superficial then dive deep into the topic that you mention at the end - Hitting the limit

I think this better represents Million and provides users an easier place to navigate.
References:
Now with regards to the API Reference section and Internals - I think that there is some duplicate knowledge here going on. For example, block() is mentioned twice.
With regards to internals: These are supposed to act as the source of truth for Million. For people who just want to get into the details of certain things, they can go here. This can include typing (if relevant), use cases, and possibly any edge cases that they may run into. These aren't intended to teach just to give facts. This page is a good example of a reference - https://docs.astro.build/en/reference/integrations-reference/ .
I think that you should introduce a general Reference section that includes everything from internals plus <For>. You have the warnings for the functions that are not intended to be used for general use, so you don't really need to separate the both of them.
Regarding structure of them, they should all follow the same "recipe", if you will. I do think you do a pretty good job of this but you want to make sure that you add a bit more information, if possible. I know Solid has some pretty short pages, but having a good reference section can eliminate a lot of questions people ask. This can, hopefully, be shown when people are asking more specific / niche questions vs having to point them to different areas.
I believe right now your API Reference section follows more of a Guide format and that you could probably add <For> into the reference section, too, for people to quickly look them up.
Wrap up
Now all of this is to say, I don't think what you have is bad by any stretch of the imagination, this is simply an observation from what I have seen. If I were to propose a layout change, I might suggest the following (this is just an idea you don't need to follow the names at all lol)
_Getting Started_
Intro
Installation

_Basics_
How Million works
Block rules
Automatic Mode
Using with TypeScript

_Tutorial_
Integrate million into your existing project

_Guides_
Creating a block
Optimizing list rendering
Virtualized lists

_Reference_
`block`
`<For>`
`mount`
`patch`
`mapArray`
`renderToTemplate`

Again this is a very rough structure, so let me know if you have any specific questions on why. It might be a bit more work upfront, but I find it can help in the long run by making it easier to update the docs and, if you need to, remove things if you end up deprecating something.

Now all of this is to say, I don't think what you have is bad by any stretch of the imagination, this is simply an observation from what I have seen. If I were to propose a layout change, I might suggest the following (this is just an idea you don't need to follow the names at all lol)

Hmm, thank you very much for this, Sarah. I really appreciate this. I'm gonna be making the updates this night after all my activities. Thank you very much for real @LadyBluenotes; you're super awesome!

I'll be tackling this in tomorrow's stream!! Live

Finally, the docs is done thanks to this live stream with I and @Drex72:
https://www.youtube.com/watch?v=4YCwRDB8q70
So, we've been able to make updates to the docs and shipped a new and improved documentation for users of Million's tooling.
Thank you @LadyBluenotes for being the best, @Drex72,  @ricardonunez-io, @aidenybai!
I'll merge this now


Issues 20: Queue mechanism for spawn unit

Issues 20: Queue mechanism for spawn unit

Restructure codes into module systems
Add queue mechanism for spawn player with a timer of each 1 sec to check queue, to ensure there are time difference between previous defeated agents' respawn vs new player respawn
Clean up unused codes
Updated logic in Sever side settings to set total unit numbers per team, which can control default bot spawn unit (total - player in that team)

Close the issue with current fix, additional enhancements will be opened as new issue


Don't use Separate Physics Thread in Editor

Reverts only the physics_process stuff from https://github.com/godotengine/godot/pull/67411
Fixes https://github.com/godotengine/godot/issues/94106
This might be a dumb change and I'll delete this PR if it is, but this commit makes it so if you have enabled the Project Setting: "Run on Separate Thread" (physics/3d/run_on_separate_thread) or (physics/2d/run_on_separate_thread), that this still applies when running your game, but not in the Editor.
I think this makes sense as we don't do much physics processing in the Editor for this to be enabled, but I'd love some opinions.

I think this makes sense as we don't do much physics processing in the Editor for this to be enabled, but I'd love some opinion

Depends on what you're doing. I'm working on a project that exclusively runs physics-based simulations in the editor.
I think it would make more sense to implement this comment in the issue you linked: https://github.com/godotengine/godot/issues/94106#issuecomment-2215508064
Which is to use the regular process by default, but fallback to using the physics process when using multithreading (at the sacrifice of smoothness when using high refresh rate monitors).

I think this makes sense as we don't do much physics processing in the Editor for this to be enabled, but I'd love some opinion

Depends on what you're doing. I'm working on a project that exclusively runs physics-based simulations in the editor.
I think it would make more sense to implement this comment in the issue you linked: #94106 (comment)
Which is to use the regular process by default, but fallback to using the physics process when using multithreading (at the sacrifice of smoothness when using high refresh rate monitors).
Edit: You could probably combine the two and have the editor hint be optional, so you still have multi-threading in the runtime, and smoothness in the editor, but also multithreading in the editor if desired with the fallback.

Made a new PR: https://github.com/godotengine/godot/pull/98406


[Launcher] Implement exact phrase

In indexer, implement exact phrase

" "
Search for an exact phrase

This actually works now


Enforces at most one table by type

This tries to match the logic of memory, but fails due to some skew in JIT.

https://github.com/tetratelabs/wazero/pull/294/commits/642017fa23685947ed7ee76f4fd95336aced26f0 this has just been incorporated into #294

https://github.com/tetratelabs/wazero/pull/294/commits/642017fa23685947ed7ee76f4fd95336aced26f0 this has just been incorporated into #294

thanks @mathetake!


I need to add a class to the form group when using character count.

I've put in a PR here: https://github.com/alphagov/govuk-frontend/pull/1553

Closing as we've merged this feature, thanks Emma 👍


support multiple backend

I use Riak with multiple backend(persistence and cached). but riak-scala-client has no way for backend selector. I implements a quick way, but I think there is a better way to open RiakBucketProperty(without seal). How do you think about this?
Sorry for my poor English and thanks for your patience.

Sorry, I did not know about specification.

Hi @seoh,
Thanks for the pull request! :)
It would be useful to have support for backend property ( and some other available props as well http://docs.basho.com/riak/latest/dev/references/http/set-bucket-props/ ).
The only thing that it should be optional, I guess.
And yes, we will need to add some tests (in RiakBucketPropertiesSpec).
Best regards,
Dmitry


Idea for trigger on Gladiator fight of ASS

Hi,
I have been making a custom trigger which helps. Thought you might want to put it into the general update as it might help others too?
You suffer the effect of First in Line.
-> trigger: you are I, edge -> tower
You suffer the effect of Second in Line.
-> trigger: you are II, tower -> edge

There should already be a trigger for this, is it not working?

My apologies, it is. I didn't notice that text come up during the shiva
circles.
I will cancel this idea :)
Cheers
On Mon, Nov 7, 2022 at 1:48 PM xiashtra @.***> wrote:

There should already be a trigger for this, is it not working?
—
Reply to this email directly, view it on GitHub
https://github.com/quisquous/cactbot/issues/5055#issuecomment-1305042967,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQUBXZS43RTOADIV3LATGJDWHBUYBANCNFSM6AAAAAARYYGTXU
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Richard Uhr

already included in current files