Adds a thruster that cannot be moved.

Adds a thruster that cannot be unanchored for use on arrivals, pods, and maybe evac. This does not map it anywhere to appease thy lord Emisse.

About the PR

Adds a thruster that cannot be moved.
To accomplish this I had to play with parenting a bit, so there are now two BaseThrusterDynamic and BaseThrusterStatic prototypes instead of just the old BaseThruster.
Why / Balance

Stops shitters from stealing the pod/arrivals thrusters eventually. Might also stop shitters from unanchoring thrusters on evac to sit outside.
Technical details

Only .yml changes. Biggest change is changing BaseThruster's ID.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase.
(Its the same thruster sprite)

Breaking changes

Changelog

tweak: To curb theft NT has added immovable thrusters to its warehouse.

has to stop deconstructing as well or you can just make a new one

Wouldn't it make more sense to simply create an "unanchorable component" or something like that, and add that to a derived thruster prototype? Then the function could be easily reused if needed for something else

dont add entity prototype localizations

I really should have realized about construction when I had to add a board for it. Well, done now.
As for an unachorable component, while I agree that would be useful, anchoring is rooted in the transform component and I am afraid to touch it.

You mean dont change the BaseThruster, or dont make a BaseThrusterDynamic?

everything touched in locale folder, entity prototypes should not be localized

everything touched in locale folder, entity prototypes should not be localized

If I remove that then it has no description and its name is the the prototype ID. That's fine I suppose, but feels a bit wonky.

Woops, that should say:
BadThruster to ThrusterStatic

Please revise your Changelog based on the Changelog guidelines.
This also doesn't stop shooting a thruster until it gets destroyed either, no?

This also doesn't stop shooting a thruster until it gets destroyed either, no?

It does not. They are still destructible. The aim is just to stop cargo taking them to sell as well as people taking them for shuttle construction.

Is it a problem if people take the thrusters?
The escape pods are far from critical for the game. Reaching one and realizing "oh damn, cargo was poor and sold the thrusters" sounds pretty funny and makes for interesting moments.
For evac, sure, that thing is already modification proof so this would only make it more consistent. But for the rest? there's no need.

Is it a problem if people take the thrusters?

Its a pretty common thing to get stolen from arrivals, but other admins wanted it for pods as well.
Either, way, this doesn't map em. I leave that in mappers hands.

Please re-open if you plan to continue work on this.


[beta] Transfer p!urdef to fun commands and add a serious dictionnary

have to find a good serious dictionnary api though

if possible imma use the same function than for npm search, if not there will be no serious dictionary command 👀

no serious dictionary will be added then


Update aws-java-sdk-core to 1.12.445

About this PR
📦 Updates com.amazonaws:aws-java-sdk-core from 1.12.442 to 1.12.445
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #281.


Support dropout for the fused attention when max seqlen <= 512

This PR introduces the dropout support of fused attention (16 bits, seqlen<512) and fixes a softmax fusion bug.
Dropout support
This PR enables dropout support for both the C API and JAX transformer (automatically enabled). However, there are two discrepancies between the cuDNN fused attention and the current JAX attention dropout:

PRNG: The default PRNG of JAX is threefry2x32, which generates an array with 2 uint32 elements. However, cuDNN dropout accepts 2 int64 values as the key and offset. To resolve this, this PR limits the custom call to accept uint32 PRNG and casts them to int64 before sending them to nvte_fused_attn_fwd_qkvpacked/nvte_fused_attn_fwd_kvpacked. We don't cast them to int64 on the Python side since x64 is not default enabled on JAX (https://github.com/google/jax#current-gotchas).

Dropout shape: The original implementation of core_attention generates the dropout mask with the shape (b, 1, s_q, s_kv) (code). However, cuDNN fused attention currently doesn't allow to configure a different dropout mask shape, and it generates the dropout without the broadcast.

Although theses two discrepancies limits the cuDNN fused attention ability to produce bitmatch results with the non-fused attention, the training curve of the t5x-large model with attention dropout = 0.1 appears to match that of the non-fused attention.
Softmax fusion bug
Fusing the scale and softmax when bias is present is incorrect. This is because the computation flow would become Softmax(scale * attn_weights + bias).

/te-ci

/te-ci

@nouiz , @cyanguwa , and @timmoon10 ,
The cuDNN dropout for fused attention is ready. Please help for review.

/te-ci

Can you confirm the PR description is up to date?

Can you confirm the PR description is up to date?

Yes, it is up to date

/te-ci

/te-ci

If I understand correctly, you handle the RNG state needed by cuDNN by just asking the native RNG to give you seed and offset pair every time? To be honest, I do not like this approach. The problem with it is that you have no guarantees how spread out are the numbers generated by the native RNG, so it is possible for different generations to overlap (keep in mind that each call to the fused attention will use multiple values of seed and offset, since each thread gets its own seed and they generate values for different offsets).
What I would prefer instead is having a global (seed, offset) pair, initialized to (prng seed, 0) passed to all of the invocations of fused attention (we should be able to do that since we control the MHA module that would call those functions) and advancing the offset appropriately. The only problem is with seeding - we would need to somehow catch that the user resets the seed in the main PRNG and reset our seed too. How do we know which PRNG a user would like to use?

If I understand correctly, you handle the RNG state needed by cuDNN by just asking the native RNG to give you seed and offset pair every time? To be honest, I do not like this approach. The problem with it is that you have no guarantees how spread out are the numbers generated by the native RNG, so it is possible for different generations to overlap (keep in mind that each call to the fused attention will use multiple values of seed and offset, since each thread gets its own seed and they generate values for different offsets).
What I would prefer instead is having a global (seed, offset) pair, initialized to (prng seed, 0) passed to all of the invocations of fused attention (we should be able to do that since we control the MHA module that would call those functions) and advancing the offset appropriately. The only problem is with seeding - we would need to somehow catch that the user resets the seed in the main PRNG and reset our seed too. How do we know which PRNG a user would like to use?

The PRNG can be obtained by prng_impl = config.jax_default_prng_impl. I understand your preferred approach, it ensures the dropout mask different across different threads/processes. I didn't dig into how the origin JAX handle the prng across threads/process, I just passed the original JAX rng_state fused attention. I will look into it these days.

Sorry for the late reply. So if I understand correctly, your proposal:
seed = PRNG()  # Possibly identical across GPUs
offset = rank * dropout_size

I think this would work. Perhaps even better would be to use seed = rank + PRNG() * num_ranks or an algorithm like boost::hash_combine, since that eliminates the need to know the number of dropout elements.
That said, I think it might be better to leave this outside of TE. If the user is doing any other random operations, they'll still need to initialize the different ranks with different RNG seeds.

Thank you for helping review the proposal! It appears that I may not have expressed my proposal clearly. Allow me to provide more detailed information.
My proposal is to generate different seeds on different GPUs. Here is the pseudo code for the implementation:
transformer.py
In each MultiheadAttention module, n (the number of GPUs) seeds are generated using jax.random.split:
dropout_key = self.make_rng(self.dropout_rng_name) # the original implementation
splitted_dropout_key = jax.random.split(dropout_key, len(jax.devices)) # generate n seeds (n = number of GPUs)
# Then pass splitted_dropout_key to fused_attn (transformer_engine/jax/fused_attn.py)

It is important to note that self.make_rng generates a new key (seed) with each call. As a result, the key (seed) will be different for different MultiheadAttention modules and different iterations.
transformer_engine/jax/fused_attn.py
To ensure that each GPU has a unique seed, the n seeds are sharded using get_fused_sharding_data.

However, I believe your suggestion of seed = rank + PRNG() * num_ranks is simpler and ensures that the seeds are different across ranks. We can use this approach instead.

That said, I wonder if it might be better to leave this outside of TE. If the user is doing any other random operations, they'll still need to initialize the different ranks with different RNG seeds.

As far as I understand, JAX's native random functions (e.g., jax.random.bernoulli) use only one seed across GPUs since the tensors are in the global view. This means that the shape of a tensor will be something like [num_gpus * batch_size, hidden]. I haven't delved into the underlying implementation, but at the very least, users of native JAX don't need to consider the seed behavior across GPUs.
I believe I can proceed with implementing the details we discussed above so that we can have more concrete code for further discussion. Thanks.

/te-ci


Configure project :react-native-webview Adding a Configuration as a dependency is a confusing behavior which isn't recommended. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0.

Bug description:

To Reproduce:

Expected behavior:

Screenshots/Videos:

Environment:

OS:
OS version:
react-native version:
react-native-webview version:

I am trying to generate apk in react native build failed when I did gradlew --warning-mode all I got this detail how to solve anyone help me out

same here .. having same warning .. anyone resolved this ?


About Mistral-Small-Instruct-2409

Hi there,
Will you test Mistral-Small-Instruct-2409?
22B so not too expensive for a test.

I'm trying to, but keep getting ModuleNotFoundError: No module named 'nemo' even though I'm not using nemo anywhere.

Fixed it but I'm not sure about the engine type.

You are available to use vLLM or HF to run inference. BTW, I just found they change their claimed context length from 128K to 32K.


Add types for compare tree

This commit adds flow type coverage for CompareTree, Node, and Query

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #352   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          25     25
  Lines         866    867    +1
=====================================
+ Hits          866    867    +1

Impacted Files
Coverage Δ

src/compare-tree/node.js
100% <ø> (ø)
:arrow_up:

src/emitter.js
100% <ø> (ø)
:arrow_up:

src/compare-tree/query.js
100% <ø> (ø)
:arrow_up:

src/compare-tree/index.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 542566a...5868682. Read the comment docs.


v0.4.0-beta2 - Instance launch

After trying out the new koolo_v0.4.0-beta2, I noticed it starts the game through executing the d2r.exe which will only launch in offline mode. Is it possible to add to the config to launch manually? Or detect the game is already launched and use that instance?

Had the same problem, opening koolo as admin solved it for me

Hrmm, I thought to try that as well but I am not getting the same results. I tried playing around with a short cut and launch options but always ends not even being able to connect. It's surprising it works for you because from my research, it's not possible via D2R.exe alone.

That's weird, do you have MFA enabled? I think is the only reason that can cause this problem, usually you can launch d2r.exe with -username -password -address parameters (is how koolo is starting the game). And will automatically login, skipping the bnet launcher.

I do actually have Blizzards MFA enabled. Looks like it could be a bit of a process removing it so I'll just play around with Koolo on single player. I'd like to improve the Lighting Sorceress actually.

same issue.
cannot connect

had the same issue and you only need to put your credentials inside the config file, like your email and pw and dont forget to use the correct server. (username = email, pw = pw. realm = the realm you want to play on),

@Sunnyweeb did that but still dont working

stacks on character screen.
log shows:
time=2024-03-25T09:29:40.162+02:00 level=INFO msg="Waiting for character selection screen..."
time=2024-03-25T09:30:07.856+02:00 level=INFO msg="Creating new game..."

stuck on character screen. log shows:
time=2024-03-25T09:29:40.162+02:00 level=INFO msg="Waiting for character selection screen..."
time=2024-03-25T09:30:07.856+02:00 level=INFO msg="Creating new game..."

Are you trying with latest beta4? is game set at 1280x720?

yes im on latest beta4 and game set at 1280x720 windowed.

it doesnt even skipp cutscene before loggin neither clicks to login on battlenet.
I click manually to skip and go to battlenet

Hello, trying this bot first time. I have not tried any previous versions. My game is 1280x720, I don't have MFA/authenticator set up on account.
When I click start, d2r starts but sits at offline screen and I can't click anything. If I stop the bot then I can click things. If I click online, it can't connect. If I run the game normally I can connect. Sounds like same issue. Same thing in logs.
Then I closed battle.net entirely and it did seem to work

Im guessing the email you are trying has . Or - cant remember which one the bot wasnt compatible with


Fix cilium in an ha cluster

Enabling and disabling cilium works on a single node cluster with this PR. I think that was always the case.
Fixes: https://github.com/ubuntu/microk8s/issues/1447

Why do we need to restart flannel in this case?

Deployments following the latest/stable will not be automatically upgraded to an HA setup where calico is used. These deployments will keep using flannel. The restart in https://github.com/ubuntu/microk8s/pull/1453/files#diff-9a6aa719fb63279e55dac696e77f3bd7R45 is because the deployment may have been on of those.

Ok so in a multi node non HA, cilium addon is not seamless.  One has to manually remove the vxlan created by flannel.
But in HA mode, Cilium addon doesn't need to remove any vxlan.
Overall this LGTM.


Support Hitobito and Nextcloud

For upcoming events we are being asked to evaluate allowing access through two open source platforms being used for events and collaboration. Our generic OAuth solution should work out of the box, but it needs some testing. Note that we also did not fully complete the Zitadel/Auth0 evaluation, two popular intermediaries for IAM services.
This task should take around 2 hours of work, and needs someone who can install a dribdat instance, configure endpoints and invite some external users to go through the onboarding process. It would be nice to make sure that user profiles are properly created, and also report on integration possibilities (e.g. like Dribdat being visible in a tab in Nextcloud, or as a Hitobito plugin).
See also:

https://github.com/dribdat/dribdat/issues/280
https://github.com/hitobito/hitobito/issues/247
Hitobito FAQ
Nextcloud Docs

Due to this security note and the prevalent use of GitLab or other supported authentication providers in Nextcloud, I am focusing this issue on Hitobito support only.


Provide inline edit links in the documentation

@edolstra - We want to list an "Edit" link/button at the heading level for each help file, so that users can click the link and access the Github editor directly for that topic.

triage: what is the status?


Is the source of caniuse.com open ?

Hi,
I wondered if the source of caniuse.com is open ?
The reason is that I would have liked to make one or two pull requests. :)
Thanks for maintaining the site, I use it everytime !

The site itself is not, no. Feel free to suggest any fixes or improvements though!


chore: Mount konflux test infra volume to access oci storage

Description
Instead of creating oras-credentials secret in every namespace, start to use the credentials stored in vault to push to OCI- Registry.
Issue ticket number and link
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/approve

No, I can not approve this, but tried :)


[HUDI-2737] Use earliest instant for async compaction and clustering jobs

What is the purpose of the pull request
This PR adds an option to run async compaction and clustering jobs without providing the instant time, using the earliest instant of the corresponding requested action by default, to improve usability.
Brief change log

Adds an API in HoodieTimeline to find the first instant of a specific action and state.
For HoodieClusteringJob, when execute mode is used, if the instant time is not provided from --instant-time, the job automatically finds the earliest scheduled clustering instant for execution.
For  HoodieCompactor, when executing compaction, if the instant time is not provided from --instant-time, the job automatically finds the earliest scheduled compaction instant for execution.

Verify this pull request
This change added tests in TestHoodieDeltaStreamer#testHoodieAsyncClusteringJob.
The change has also been verified by running HoodieCompactor and HoodieClusteringJob with kafka-connect:

Compaction scheduled, run HoodieCompactor, earliest requested compaction instant is executed.
Compaction done, run HoodieCompactor, throws an exception.
Clustering scheduled, run HoodieClusteringJob, earliest requested clustering instant is executed.
Clustering done, run HoodieClusteringJob, throws an exception.

Async compaction command:
spark-submit  \
--class org.apache.hudi.utilities.HoodieCompactor \
hudi/packaging/hudi-utilities-bundle/target/hudi-utilities-bundle_2.11-0.10.0-SNAPSHOT.jar \
--base-path /tmp/hoodie/hudi-test-topic \
--table-name hudi-test-topic \
--schema-file /repo/hudi/docker/demo/config/schema.avsc \
--parallelism 2 \
--spark-memory 1g

Async clustering command:
spark-submit \
--class org.apache.hudi.utilities.HoodieClusteringJob \
hudi/packaging/hudi-utilities-bundle/target/hudi-utilities-bundle_2.11-0.10.0-SNAPSHOT.jar \
--props clusteringjob.properties \
--mode execute \
--base-path /tmp/hoodie/hudi-test-topic  \
--table-name sample_table \
--spark-memory 1g

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@nsivabalan @codope for review

@codope Thanks for the review.  I addressed the comments.


Feature: Database ORM connection

Implemented User and SavedPlace models to represent user and saved place
data.
Configured the application to connect to the Railway database.
Updated .env file with MySQL connection details for Railway.

LGTM ✅


Choice of default color map

This came up in https://github.com/trixi-framework/Trixi.jl/pull/781#discussion_r694199028: Should we change our default colormap? Right now, Plots.jl uses Inferno below. I would slightly prefer "Plasma". Other suggestions?

This is my go-to example for trying plot visualizations:
julia> trixi_include("examples/tree_2d_dgsem/elixir_euler_blast_wave_amr.jl", tspan=(0.0, 1.5))

julia> pd = PlotData2D(sol)

julia> plot(pd["rho"]); plot!(getmesh(pd)) # for inferno

julia> plot(pd["rho"], seriescolor=:plasma); plot!(getmesh(pd), linecolor=:black) # for plasma

julia> plot(pd["rho"], seriescolor=:viridis); plot!(getmesh(pd), linecolor=:black) # for viridis

It might be just being more used to it, but out of the box, to me :inferno is slightly more pleasant (and more badass) to the eye than the others. However, I guess I could live with any of the three if they are used consistently between Plots and Makie :sunglasses:
inferno:

plasma:

viridis:

Thanks for plotting all of those! I also like :inferno the most.
Apart from :inferno, I also like :blues - here's an example from an old KHI run.

:blues looks nice too (see my modified https://github.com/trixi-framework/Trixi.jl/issues/817#issuecomment-904063475 above). However, since color choice can lead to never ending debates, I'd slightly tend to go for one of the "standard" schemes as per @ranocha's suggestion.

That sounds good to me. I mentioned blues specifically because I saw it in https://arxiv.org/abs/2009.06022 and like the "schlieren-ish" quality.
Either way, if we make it configurable via https://github.com/trixi-framework/Trixi.jl/issues/818, it won't matter :)

Keeping inferno is also fine with me. Is there a way to specify the color map using our recipe for Makie.plot?

Yes for single fields, e.g., plot(PlotData2D(sol)["rho"], colormap=:blues) should work. The plot(sol) recipe doesn't allow this yet; i've added this to https://github.com/trixi-framework/Trixi.jl/issues/818.

As discussed today, we use inferno for now for both Plots and Makie recipes, at least until we find a really good reason not to.


Please add release note description on releasing

It would great if you could add a release note description. It's always useful to know changes with the last release before updating.
Thanks

Sorry, I'll do it as soon as I can, thanks.


Not working

Can't seem to get this to work. It installs the dependencies and libreelec; however, there is no method of selecting files to convert? Can you provide an explanation of how to select an OS to convert?

Still not working; how do you download a custom OS to this system?

Hi @ejmorgan55, thanks for report the issue, script fixed and updated.


Whitespace checks flexibility

I'd like to enforce anonymous object declarations that look like this:
{ key: value, key: value }
I think this is currently not possible (except for the space after the comma with WhitespaceAfter and the , token).

Using the : token in WhitespaceAfter doesn't work, since there is no way to differentiate between object declarations and type hints (I still want name:Type for the latter).
Using the { token in WhitespaceAfter doesn't work, since it also triggers on empty blocks {} and reification expressions.
Using the } token in WhitespaceBefore doesn't work, since there is no WhitespaceBefore check yet ;)

How about writing a generic WhitespaceCheck, that has four modes: NoWhitespace, OnlyBefore, OnlyAfter and WhitespaceAround. It also has a list of tokens like in WhitespaceAround and a scope / context that limits where the mode applies. Possible scopes / contexts are ObjectDecl, FunctionDef, FieldDef, ArrayAccess, etc.
Each check instance has one mode, multiple tokens and multiple scopes / contexts.
Depending on coding style WhitespaceCheck would occur multiple times in checkstyle.json, with different mode, token and context combinations, but I think that could cover all cases and we might even incorporate SpacingCheck (by opening up the range of supported tokens).
I have not started development, so if you would like to work on it, go ahead.

Sounds good to me, I actually had something similar in mind!
For the modes I'd suggest different names: Before, After, Around and None.

One question is whether the old whitespace checks should be removed when adding this (breaking change).

Maybe we can keep them (marked as deprecated), but refactor them to use new whitespace check with matching parameters, so they are like dumbed down versions of the full check.

Seems like a good idea!


Consider not using a level conversion table

To increase performance, maybe a conversion table for severity levels can be avoided and the user should take the hit if providing a wrongly named level (uppercase, lowercase, etc..)

After testing this, it appears that the conversion table isn't affecting the performance much. Closing for now.


[stable/hlf-peer] Configure metrics

What this PR does / why we need it:
This PR enable the setup of a metrics server to get more insight of what is happening from an operational point of view.
Which issue this PR fixes
N/A
Special notes for your reviewer:
For the values names/structure I replicated the structure and default values from the core.yaml file.
In the readme.md it was required to resize the columns making the diff not very readable but the added lines are from L116 to L121.
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @alexvicegrab

/ok-to-test

/approve

/lgtm


[DO NOT MERGE] Adding temp workflow to test some nightly workflow

Adding a temp workflow to find why the catalog_test.go is failing : https://github.com/apache/camel-k/actions/runs/7807543550/job/21296122267
This PR will be used to try to fix the workflow
Release Note
NONE

Is this still valid? #5147 should have fixed already.

Is this still valid? #5147 should have fixed already.

Let's wait for tomorrow, I suspect we could be missing java installation in one of the workflows.

Nightly automatic updates is still failing, fix PR is here : https://github.com/apache/camel-k/pull/5150


java 21 string templates for URIs

Java 21 has a new String Template feature in preview. This could serve as the basis to generate URIs from URI templates or something alike

Templates have been removed from Java 23: https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html


Is there a way to select all files at once?

Is there a way to select all moved files to NotchDrop at once? Or for example select one by one, using Option+Shift?

It was not very easy to implement as we do not have that kind of API across draggable annotation. Will keep you up if I find a way to.

thank you for you reply, already got it from AppStore and very happy with it!


Do we have to add External SVG Sprite dependency?

I'm not sure if your README is missing a step, but your current README doesn't work. I don't get any errors, but the SVG sprite is still not injected into the DOM. Am I missing something?

Hi! It's working fine here. Could you please share the SVG file you're trying to import?

I have multiple SVG in a folder. I import them and I see the props (url, viewBox, etc) but they don't work because the Sprite itself is not ever injected into the DOM (like most svg sprite solutions).

Ah, never mind. I messed up the syntax. It's working. Thanks!


Error during tree update

I add my Token and after I try to "open Gist" and it say that there is a Argument Parameter name "index" outside in the rain ;-) Can you fix it ?

Please check if it's fixed in the latest build https://ci.appveyor.com/project/KvanTTT/nppgist/builds/35063667 and reopen it's not.


documentation update

we need to update the documentation to match the new version.

I've done a full pass of restructuring and updating docstrings.  I think we're in good shape for the API reference.
The next step, open to anyone that wants to take it, is updating the quickstart documentation.
We also have automatic doc builds on readthedocs, but they are currently broken since RTD uses sphinx 1.3, which fails on autosummary for some reason.

And now for the really fun to-do on documentation: namespaces!

[ ] beat_beat
[ ] beat_position
[ ] chord_harte
[ ] chord_roman
[ ] key_key_mode
[ ] lyrics_lyrics
[ ] mood_thayer
[ ] onset_onset
[ ] pattern_jku
[ ] pitch_class
[ ] pitch_hz
[ ] pitch_midi
[ ] segment_open
[ ] segment_salami_function
[ ] segment_salami_lower
[ ] segment_salami_upper
[ ] segment_tut
[ ] tag_cal10k
[ ] tag_cal500
[ ] tag_gtzan
[ ] tag_medleydb_instruments
[ ] tag_open
[ ] tempo_tempo

Is there an existing example of what this should look like?

Is there an existing example of what this should look like?

Nope!  And we can't quite autodoc it, since a) json doesn't have comments, and b) sphinx wouldn't parse them out automatically anyway.
It'll just have to be a section within the jams docs, with subsections for tasks, and subsubsections for individual namespaces.
Each namespace should have an explanation of the value and confidence fields, expected interpretation of time+duration, and any additional expected semantics.
I'll bang out the skeleton for this and add a couple of examples to get us started.

:+1:

Ok, I've pushed up a skeleton and written documentation for the beat types.
This should be enough to get everyone started on their respective tasks.

@ejhumphrey I added a quick hack of chord_roman's namespace, but it's missing some things.  Please correct.

@urinieto Can you chip in a namespace doc for pattern_jku?
@justinsalamon Can you do pitch_hz?

@bmcfee have a look, it's a little verbose but I have tried to explain the conventions as succinctly as possible

Seems good.  We could probably trim it a little and reformat, but the entire namespace docs need an edit pass anyway.

Ok, I just finished my part for the pattern_jku.

After resolving #53, I think we're good to go (functionally) on this one.
I'll give the documentation a final editorial pass, but otherwise I think we're ready for 0.2.0!

0f6e0657d0416aaeb082446d312a5dc280d94e04 adds a new doc page that contains a fully worked example using librosa to estimate beats and tempo, and store the results in a .jams file.
Are there any other use-cases that could benefit from a fully-worked example script?  Maybe evaluation?

Are there any other use-cases that could benefit from a fully-worked example script? Maybe evaluation?

Definitely evaluation (with mir_eval), and perhaps also parsing an existing dataset into jams? Or just some type of csv format into jams, since once of jams's main purposes is to store annotations and there still isn't any annotation software out there that will output directly into jams format (should we revisit the conversation with Chris about SV at some point?)

+1.
Also clearly mention/link the jams-data repo from where to get the already
parsed datasets.
On Fri, Aug 21, 2015 at 11:23 AM, Justin Salamon<EMAIL_ADDRESS>wrote:

Are there any other use-cases that could benefit from a fully-worked
example script? Maybe evaluation?
Definitely evaluation (with mir_eval), and perhaps also parsing an
existing dataset into jams? Or just some type of csv format into jams,
since once of jams's main purposes is to store annotations and there still
isn't any annotation software out there that will output directly into jams
format (should we revisit the conversation with Chris about SV at some
point?)
—
Reply to this email directly or view it on GitHub
https://github.com/marl/jams/issues/23#issuecomment-133462019.

Definitely evaluation (with mir_eval), and perhaps also parsing an existing dataset into jams?

I think the latter is best left to the jams-data repo.
A jams-to-jams evaluation example would be easy though.

Or just some type of csv format into jams,

That might be doable.  I worry that providing a coherent example would require too much special-case hackery for data cleaning though, and distract from the main points.  I tend to think the quickstart and beat tracking examples are enough to illustrate the process, and reading CSV isn't really our job.  (If you can read csv, it should be obvious how to drop that into the existing examples.)

Also clearly mention/link the jams-data repo from where to get the already
parsed datasets.

Do we want to do this already, or wait until that repo is done?  I'd rather not link to docs/data that are out of date.

Do we want to do this already, or wait until that repo is done? I'd rather
not link to docs/data that are out of date.
I would at least mention the repo, and make sure to say it is still a work
in progress.

—
Reply to this email directly or view it on GitHub
https://github.com/marl/jams/issues/23#issuecomment-133468387.

Done and done.  We now have an example that shows how to parse isophonics chords into jams, and links out to jams-data.

:+1: :+1: :+1:

Anything else? I'd like to push this out by the self-imposed deadline next week.

I think that should be it!
On Fri, Aug 21, 2015 at 3:16 PM, Brian McFee<EMAIL_ADDRESS>wrote:

Anything else? I'd like to push this out by the self-imposed deadline next
week.
—
Reply to this email directly or view it on GitHub
https://github.com/marl/jams/issues/23#issuecomment-133535239.


Add link to TOC

@Quy you did not need to again and again create a pull request for any changes you made to your code .... just push your changes
with
git push origin HEAD
or,
git push origin <branch-name>


Remove project id requirement for creating a GCS client.

Project id is only required for creating buckets, not operating on them, so it doesn't make sense to make it required for all cases.
I currently have some code that only operates on an existing bucket, and literally set the project id to "devnull" to prevent users from having to provide a valid project id which is not necessary.

Coverage increased (+0.0008%) to 80.883% when pulling 71d854a650646ac52416be230bb11ab747222894 on anuraaga:gcs_noproject into d70f69603963231ca2f31f66514d2cf4f689100c on GoogleCloudPlatform:master.

@shinfan Shortened the PR title, though feel free to edit it further as you see fit.
Don't have write access so will need someone to merge :)


refactor: Message body encoder

Still a work in progress.
Should fix #503 by correctly documenting when 8bit and the rest of the encodings should be used.
Contains a workaround for a base64 bug https://github.com/marshallpierce/rust-base64/issues/148
Removes SinglePart::binary since it isn't a good option. We would first have to check with the SMTP server we are talking to check if it's supported. It's still possible to use it by manually setting the Content-Transfer-Encoding header.
Reduces allocations and implements the auto encoder option mentioned in #495
Thanks to:

https://www.w3.org/Protocols/rfc1341/5_Content-Transfer-Encoding.html
https://stackoverflow.com/questions/25710599/content-transfer-encoding-7bit-or-8-bit

What's missing:

[x] Documentation
[x] More tests
[ ] EncodedBody or some way of providing an already encoded body or recycling it between emails

Other than the panicking APIs we should probably change to errors, this should be ready to review.

I'll change the panicking part in another PR, since I have other things I want to change and I don't want this PR to drag on too much.
I'll wait for the CI to pass and I'll merge.


symlink the built .node files into the "build" dir

Sorta solves the problem of "what to require" when you want to conditionally require the Release or Debug build, depending on that was last built.
/cc @tjfontaine

This issue is approaching 6 years of inactivity. Should it remain open? (Not saying it should or shouldn't. Just honestly asking. For all I know, the issue has been resolved.)

I'm not sure what issue this was trying to solve.  I'll close it out.


fix: allow zero proof height, solo machine discards provided proof height in favor of sequence

Description

closes: #1874
partially: #121

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (see CONTRIBUTING.md)
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Code follows the module structure standards.
[x] Wrote unit and integration tests
[x] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[x] Added relevant godoc comments.
[x] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer
[x] Review Codecov Report in the comment section below once CI passes

Codecov Report

Merging #2746 (36d83c2) into main (fb9dedd) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2746      +/-   ##
==========================================
- Coverage   78.88%   78.87%   -0.02%
==========================================
  Files         178      178
  Lines       12282    12263      -19
==========================================
- Hits         9689     9672      -17
+ Misses       2174     2172       -2
  Partials      419      419

Impacted Files
Coverage Δ

modules/core/03-connection/types/msgs.go
85.00% <ø> (-0.72%)
:arrow_down:

...odules/light-clients/07-tendermint/client_state.go
89.30% <ø> (ø)

...dules/light-clients/06-solomachine/client_state.go
88.18% <100.00%> (+0.59%)
:arrow_up:


Override post patch trigger

Renamed API:

ThingIFAPI#patchTrigger(String, ServerCode, Predicate) -> ThingIFAPI#patchServerCodeTrigger(String, ServerCode, Predicate)
ThingIFAPI#patchTrigger(String, ServerCode, Predicate, TriggerOptions) -> ThingIFAPI#patchServerCodeTrigger(String, ServerCode, Predicate, TriggerOptions)
ThingIFAPI#patchTrigger(String, TriggeredCommandForm, Predicate, TriggerOptions) -> ThingIFAPI#patchCommandTrigger(String, TriggeredCommandForm, Predicate, TriggerOptions)

Add ThingIFAPI#postNewTrigger(TriggeredCommandForm, Predicate)

Add ThingIFAPI#patchCommandTrigger(String, TriggeredCommandForm, Predicate)

Fix API doc

Add small tests for new methods

The reason to rename APIs is that, when patch trigger with null serverCode or null form,  need to call by this way:
// for servercode
api.patchTrigger("trigger id", (ServerCode)null,  predicate);
// for command
api.patchTrigger("trigger id", (TriggeredCommandForm)null, preidcate)

@yongpingchen LGTM!


Create FizzBuzz_Basic_Time_Complexity.py

It has a complete explanation of the time complexity of the basic FizzBuzz code

Hi! Thank you for your PR.
Unfortunately your solution has already been submitted :/
Don't worry, the PR still counts tho :)


Cannot install with cocoapods or Swift Package Manager

Hello,
I'm using latest versions of Swift (5.2) and XCode (11.4) and I wanted to try your charts library.
I tried to install it in a new project with Cocoapods and I get this error :
Framework not found WQCharts
I also tried to install it with Swift Package Manager and I get this error :
because every version of WQCharts-iOS contains incompatible tools version and root depends on WQCharts-iOS 1.1.0..<2.0.0, version solving failed.
Failed to resolve dependancy.
Do you know if I'm doing something wrong or if it's the library setup that has an issue ?
Thank you

Hello
Please check your Profile, Add "use_frameworks!"
target 'YourProjectTarget' do
use_frameworks!
pod 'WQCharts'
end
Enter "pod install" try again

Hello,
thank you for your answer but that's not the problem.
Here is my podfile :
Uncomment the next line to define a global platform for your project
platform :ios, '9.0'
target 'TestCharts' do
Comment the next line if you don't want to use dynamic frameworks
use_frameworks!
Pods for TestCharts
pod 'WQCharts'
end
Le lun. 4 mai 2020 à 09:51, CoderWQYao<EMAIL_ADDRESS>a écrit :

Hello
Please check your Profile, Add "use_frameworks!"
target 'YourProjectTarget' do
use_frameworks!
pod 'WQCharts'
end
Enter "pod install" try again
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CoderWQYao/WQCharts-iOS/issues/1#issuecomment-623312660,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APAUJKOHGAAXO67WAAPWNJTRPZXZRANCNFSM4MXEAAGQ
.

Hello
I fixed a compile error
Please the new version(1.1.1) try again

Thank you, I installed it now with Package Manager and it worked.
Now is time to get into it :)
Le lun. 4 mai 2020 à 13:10, CoderWQYao<EMAIL_ADDRESS>a écrit :

Hello
I fixed a compile error
Please the new version(1.1.1) try again
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CoderWQYao/WQCharts-iOS/issues/1#issuecomment-623401491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APAUJKLCXTYAMV5RSOJGJRTRP2PB3ANCNFSM4MXEAAGQ
.

When I try to run the demo I get this error message. found this on
StackOverflow :
https://stackoverflow.com/questions/36904636/ld-framework-not-found-framework-error?noredirect=1
But I don't fully understand it. Do you know what might be the problem and
if something is still wrong with the package or it's something I'm doing
wrong?
[image: Capture d’écran 2020-05-04 à 20.48.02.png]
Showing Recent Messages
Build target Swift of project WQChartsDemo with configuration Debug
Ld
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Products/Debug-iphonesimulator/WQChartsDemo.app/WQChartsDemo
normal x86_64 (in target 'Swift' from project 'WQChartsDemo')
cd /Users/faridkarioty/Downloads/WQCharts-iOS-master

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang

-target x86_64-apple-ios13.2-simulator -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator13.4.sdk
-L/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Products/Debug-iphonesimulator
-F/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Products/Debug-iphonesimulator
-filelist
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Intermediates.noindex/WQChartsDemo.build/Debug-iphonesimulator/Swift.build/Objects-normal/x86_64/WQChartsDemo.LinkFileList
-Xlinker -rpath -Xlinker @executable_path/Frameworks -dead_strip -Xlinker
-object_path_lto -Xlinker
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Intermediates.noindex/WQChartsDemo.build/Debug-iphonesimulator/Swift.build/Objects-normal/x86_64/WQChartsDemo_lto.o
-Xlinker -export_dynamic -Xlinker -no_deduplicate -Xlinker
-objc_abi_version -Xlinker 2 -fobjc-link-runtime
-L/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphonesimulator
-L/usr/lib/swift -Xlinker -add_ast_path -Xlinker
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Intermediates.noindex/WQChartsDemo.build/Debug-iphonesimulator/Swift.build/Objects-normal/x86_64/WQChartsDemo.swiftmodule
-Xlinker -sectcreate -Xlinker __TEXT -Xlinker __entitlements -Xlinker
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Intermediates.noindex/WQChartsDemo.build/Debug-iphonesimulator/Swift.build/WQChartsDemo.app-Simulated.xcent
-framework WQCharts -Xlinker -dependency_info -Xlinker
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Intermediates.noindex/WQChartsDemo.build/Debug-iphonesimulator/Swift.build/Objects-normal/x86_64/WQChartsDemo_dependency_info.dat
-o
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Products/Debug-iphonesimulator/WQChartsDemo.app/WQChartsDemo
-Xlinker -add_ast_path -Xlinker
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Intermediates.noindex/WQCharts.build/Debug-iphonesimulator/WQCharts.build/Objects-normal/x86_64/WQCharts.swiftmodule
ld: framework not found WQCharts
clang: error: linker command failed with exit code 1 (use -v to see
invocation)
Le lun. 4 mai 2020 à 19:29, Farid Karioty<EMAIL_ADDRESS>a écrit :

Thank you, I installed it now with Package Manager and it worked.
Now is time to get into it :)
Le lun. 4 mai 2020 à 13:10, CoderWQYao<EMAIL_ADDRESS>a
écrit :

Hello
I fixed a compile error
Please the new version(1.1.1) try again
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CoderWQYao/WQCharts-iOS/issues/1#issuecomment-623401491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APAUJKLCXTYAMV5RSOJGJRTRP2PB3ANCNFSM4MXEAAGQ
.

Hello,
do you have any idea on how to make the demo work ?
I don't understand why it cannot find WQCharts.
All help would be greatly appreciated as I would love to use your framework
in my app.
Thank you
Le lun. 4 mai 2020 à 20:49, Farid Karioty<EMAIL_ADDRESS>a écrit :

When I try to run the demo I get this error message. found this on
StackOverflow :
https://stackoverflow.com/questions/36904636/ld-framework-not-found-framework-error?noredirect=1
But I don't fully understand it. Do you know what might be the problem and
if something is still wrong with the package or it's something I'm doing
wrong?
[image: Capture d’écran 2020-05-04 à 20.48.02.png]
Showing Recent Messages
Build target Swift of project WQChartsDemo with configuration Debug
Ld
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Products/Debug-iphonesimulator/WQChartsDemo.app/WQChartsDemo
normal x86_64 (in target 'Swift' from project 'WQChartsDemo')
cd /Users/faridkarioty/Downloads/WQCharts-iOS-master

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang

-target x86_64-apple-ios13.2-simulator -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator13.4.sdk
-L/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Products/Debug-iphonesimulator
-F/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Products/Debug-iphonesimulator
-filelist
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Intermediates.noindex/WQChartsDemo.build/Debug-iphonesimulator/Swift.build/Objects-normal/x86_64/WQChartsDemo.LinkFileList
-Xlinker -rpath -Xlinker @executable_path/Frameworks -dead_strip -Xlinker
-object_path_lto -Xlinker
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Intermediates.noindex/WQChartsDemo.build/Debug-iphonesimulator/Swift.build/Objects-normal/x86_64/WQChartsDemo_lto.o
-Xlinker -export_dynamic -Xlinker -no_deduplicate -Xlinker
-objc_abi_version -Xlinker 2 -fobjc-link-runtime
-L/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphonesimulator
-L/usr/lib/swift -Xlinker -add_ast_path -Xlinker
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Intermediates.noindex/WQChartsDemo.build/Debug-iphonesimulator/Swift.build/Objects-normal/x86_64/WQChartsDemo.swiftmodule
-Xlinker -sectcreate -Xlinker __TEXT -Xlinker __entitlements -Xlinker
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Intermediates.noindex/WQChartsDemo.build/Debug-iphonesimulator/Swift.build/WQChartsDemo.app-Simulated.xcent
-framework WQCharts -Xlinker -dependency_info -Xlinker
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Intermediates.noindex/WQChartsDemo.build/Debug-iphonesimulator/Swift.build/Objects-normal/x86_64/WQChartsDemo_dependency_info.dat
-o
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Products/Debug-iphonesimulator/WQChartsDemo.app/WQChartsDemo
-Xlinker -add_ast_path -Xlinker
/Users/faridkarioty/Library/Developer/Xcode/DerivedData/WQChartsDemo-dvoayxsohhvzslbcghzkuukvyzcl/Build/Intermediates.noindex/WQCharts.build/Debug-iphonesimulator/WQCharts.build/Objects-normal/x86_64/WQCharts.swiftmodule
ld: framework not found WQCharts
clang: error: linker command failed with exit code 1 (use -v to see
invocation)
Le lun. 4 mai 2020 à 19:29, Farid Karioty<EMAIL_ADDRESS>a écrit :

Thank you, I installed it now with Package Manager and it worked.
Now is time to get into it :)
Le lun. 4 mai 2020 à 13:10, CoderWQYao<EMAIL_ADDRESS>a
écrit :

Hello
I fixed a compile error
Please the new version(1.1.1) try again
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CoderWQYao/WQCharts-iOS/issues/1#issuecomment-623401491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APAUJKLCXTYAMV5RSOJGJRTRP2PB3ANCNFSM4MXEAAGQ
.

Hello,
I asked other developers, but your problem didn't appear.
You can try the following, maybe it can help you:
1: Find Target - General - Frameworks ... ,  remove WQCharts.framework And Add again.
2: Find Target - Build Settings - Other Linker Flags, clear setting
You can also create a new project and import WQCharts library and copy demo files.
Please let me know if you can find out the problem, Thanks.

Hello !
your first solution suggestion worked. Now I can build & run the demo.
Thank you so much !
Le lun. 11 mai 2020 à 04:06, CoderWQYao<EMAIL_ADDRESS>a écrit :

Hello,
I asked other developers, but your problem didn't appear.
You can try the following, maybe it can help you:
1: Find Target - General - Frameworks ... , remove WQCharts.framework And
Add again.
2: Find Target - Build Settings - Other Linker Flags, clear setting
You can also create a new project and import WQCharts library and copy
demo files.
Please let me know if you can find out the problem, Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CoderWQYao/WQCharts-iOS/issues/1#issuecomment-626433092,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APAUJKJT7UKHLQXJCPINKIDRQ5MS3ANCNFSM4MXEAAGQ
.


Slider crashing with jQuery UI

Slider function crashing with jQuery UI's slider function.

just go in and change the name of either jquery UI's slider function or ours.


#10 score

Not perfect yet -> view my comment in switch_cars() in the Driver_UI
Is set to only increase score when driving a physical car
Should be tested using a physical car

I find it weird that the coroutine __in_physical_vehicle gets called at two points. This might be causing the issue of the score counter getting faster. My suggestion would be to simply start a coroutine that checks the current car type of every driver and increases their score accordingly at the startup of the whole application.
Please let me know if I'm overthinking this.

I must admit, I already found the main problem: I forgot a "_" in in_physical_vehicle in Driver.py and therefore it is never set to True: I found this when making the attributes private -> I could have found the problem hours ago


bug: Drawing disappears upon fully loading profile

Describe the bug
Whenever I visit a profile that features an ask with a drawing attached, the drawing appears for about a split second before disappearing permanently.
To Reproduce
Steps to reproduce the behavior:

Go to my profile. (@Grimmgall)
Wait for the page to fully load.
Scroll down to the currently only post on the page.
See the drawing completely blank after about a split second of viewing it.

Expected behavior
The drawing should appear permanently.
Screenshots
https://github.com/user-attachments/assets/d208b940-77d5-40f3-9140-31a397281b20
(This shows the #doodle tag, but it also appears on my profile in general. I wasn't able to capture it properly because it disappeared too quickly to properly capture it when I attempted it without the #doodle tag on my general profile page.)
Specifications
Windows 11 HP Laptop
Desktop mode
Google Chrome
Additional context
N/A?

Edited to update the version of the video without my tabs or bookmarks showing. It's nobody's business what I browse. (It's nothing illegal or generally considered immoral, but a little embarrassing, especially a few without proper context.)

Fixed in 80999bc, feel free to reopen if it's still occurring

I manually deleted the first version of this issue because it included a link to the video containing your tabs. It is no longer accessible, but note GitHub stores edit history for every issue and comment!


[Request to Driver] Driver's stops display when driver and passenger stops are the same.

Environment: Android 10, Samsung A7.
Reproducible: always.
Build found: v1.0.445.
Preconditions
The user as a driver is logged into the app and creates a ride (e.g.Chervonohrad - Zakopane, 29.11, 11:23 ). The user as a passenger is logged into the app and opens the homepage.
Steps to reproduce

Go to 'Find a Ride'
Select 'From' and 'To' edit boxes (e.g.Chervonohrad - Zakopane)
Select departure time (e.g. 29.11, 11:23)
Tap 'Search' button
Tap founded ride

Actual result
Driver's stops display when driver's and passenger's stops are the same.
Expected result
IF any of the driver's and passenger's locations are matched (stops are the same), the system shall show only Passenger's stop/stops.
User story #14
Labels to be added
"Bug" ("bug"), Priority ("pri: medium ")
https://user-images.githubusercontent.com/91271776/143880099-e84f81b1-0123-4d87-a4ab-1932bee5db1e.mp4

Verified


rename DocumentDbRepositoryConfigurationExtensionUnitTest.java

Consider renaming file name to shorter name, receiving filename too long error

unit test java file naming convention is testtargetclassname+UnitTest for easy tracking. since no issue found during ci, will close the issue for now. will refine the naming if met issue.


dataMap null after using setState in hook function, causes TypeError

After the 'afterRemoveRow' hook has run this TypeError comes up:
Uncaught TypeError: Cannot set property 'forceFullRender' of null
Version 0.2.1
DataMap.removeRow	@	handsontable.js?732b:6878
alter	@	handsontable.js?732b:4815
Core.alter	@	handsontable.js?732b:5875
callback	@	handsontable.js?732b:16321
(anonymous)	@	handsontable.js?732b:14695
arrayEach	@	handsontable.js?732b:9907
execute	@	handsontable.js?732b:14694
executeCommand	@	handsontable.js?732b:14854
(anonymous)	@	handsontable.js?732b:14806
(anonymous)	@	handsontable.js?732b:11990
arrayEach	@	handsontable.js?732b:9907
runLocalHooks	@	handsontable.js?732b:11989
executeCommand	@	handsontable.js?732b:15320
onDocumentMouseDown	@	handsontable.js?732b:15597
(anonymous)	@	handsontable.js?732b:15169
callbackProxy	@	handsontable.js?732b:9634

Location of error (debugger view):
DataMap.prototype.removeRow = function(index, amount, source) {
  if (!amount) {
    amount = 1;
  }
  if (typeof index !== 'number') {
    index = -amount;
  }
  amount = Handsontable.hooks.run(this.instance, 'modifyRemovedAmount', amount, index);
  index = (this.instance.countSourceRows() + index) % this.instance.countSourceRows();
  var logicRows = this.physicalRowsToLogical(index, amount);
  var actionWasNotCancelled = Handsontable.hooks.run(this.instance, 'beforeRemoveRow', index, amount, logicRows, source);
  if (actionWasNotCancelled === false) {
    return;
  }
  var data = this.dataSource;
  var newData;
  newData = this.filterData(index, amount);
  if (newData) {
    data.length = 0;
    Array.prototype.push.apply(data, newData);
  }
  Handsontable.hooks.run(this.instance, 'afterRemoveRow', index, amount, logicRows, source);
  this.instance.forceFullRender = true;
};

Error thrown in the second to last line:  this.instance.forceFullRender = true;
EDIT: What this problem looks like to me: After using setState in a hook function the dataMap loses it's HOT instance. Both errors are due to missing HOT instance. It sounds plausible to me that setting state could have that effect, making the component state inconsistent with what HOT assumes.

Similar error when using beforeRemoveRow hook:
DataMap.prototype.physicalRowsToLogical = function(index, amount) {
  var totalRows = this.instance.countSourceRows(); // <-- from this line
  var physicRow = (totalRows + index) % totalRows;
  var logicRows = [];
  var rowsToRemove = amount;
  var row;
  while (physicRow < totalRows && rowsToRemove) {
    row = Handsontable.hooks.run(this.instance, 'modifyRow', physicRow);
    logicRows.push(row);
    rowsToRemove--;
    physicRow++;
  }
  return logicRows;
};

This error:
Uncaught TypeError: Cannot read property 'countSourceRows' of null
    at DataMap.physicalRowsToLogical (eval at <anonymous> (application.js:4091), <anonymous>:7044:32)
    at DataMap.filterData (eval at <anonymous> (application.js:4091), <anonymous>:6962:24)
    at DataMap.removeRow (eval at <anonymous> (application.js:4091), <anonymous>:6872:18)
    at Object.alter (eval at <anonymous> (application.js:4091), <anonymous>:4815:19)
    at Core.alter (eval at <anonymous> (application.js:4091), <anonymous>:5875:10)
    at Core.callback (eval at <anonymous> (application.js:4091), <anonymous>:16321:12)
    at eval (eval at <anonymous> (application.js:4091), <anonymous>:14695:23)
    at arrayEach (eval at <anonymous> (application.js:4091), <anonymous>:9907:9)
    at CommandExecutor.execute (eval at <anonymous> (application.js:4091), <anonymous>:14694:5)
    at ContextMenu.executeCommand (eval at <anonymous> (application.js:4091), <anonymous>:14854:34)

The problem only occurs if the hook function run setState on the data source, it seems.

@febeling, first of all, thanks for the detailed problem description, it helped a lot.
The problem occurs because setState calls the shouldComponentUpdate method, which calls Handsontable's updateSettings, resulting in "resetting" the handsontable instance, while still processing the plugin hooks of the "old" instance.
I'll try to figure something out eventually, but for now I think you might try calling setState asynchronously - this way the "old" instance should be able to finish calling all the hooks before being updated.
Take a look at this example: https://codepen.io/js-ziggle/pen/awryaY?editors=0010

@AMBudnik Is there additional info about this? Was there a fix?

Hi @febeling
please check https://github.com/handsontable/react-handsontable/commit/53b21665c610c50f41f2f778fe5ecaa5e6a11fcd

Note that this solution applies to most of the Handsontable hooks. If you want to change the state of your React app (by changing the React component's state, props, hooks, etc), it is recommended to do that asynchrously as presented in the above pen (https://codepen.io/js-ziggle/pen/awryaY?editors=0010)


Fix the broken link in series.md

This PR tries to fix #806 (Dead link to bar series doc)
Currently I only fix series.md (which maps to documentation/api-reference/series), but this issue  actually happens in all markdown generated pages. It causes developers hard to read documentations online.
The root cause is that we're using filename as link destination rather than url. For example, we have following content in series.md:
See the [XYPlot](xy-plot.md)'s `animation` section for more information.

The above xy-plot.md is a filename rather than a link.
This patch works in my local build, and if this is acceptable I can help to further review the rest docs.

Hi, just wonder is there any problem with this PR? I see some similar ones have been merged (#830 #831 #832). Please tell me if anything wrong so I can further improve this, thanks!

@whitedogg13 there's no problem at all! I was on vacation or else I would have merged it sooner. thanks for doing this!!


Updating styles to new version.

HI,
I've switched to the new version of this and it does work, but I'm having difficulty styling the clusters whereas I managed easily with the old version.
In the old version I had it set up like:
                    let markerCluster = new MarkerClusterer({map, markers}, {
                        maxZoom: 14,
                        clusterClass: 'custom-clustericon',
                        styles: [
                            {
                                width: 30,
                                height: 30,
                                className: 'custom-clustericon-1'
                            },
                            {
                                width: 40,
                                height: 40,
                                className: 'custom-clustericon-2'
                            },
                            {
                                width: 50,
                                height: 50,
                                className: 'custom-clustericon-3'
                            }
                        ]
                    });

and styled as so:
.custom-clustericon {
    background: var(--cluster-color);
    color: #fff;
    border-radius: 100%;
    font-weight: bold;
    font-size: 15px;
    display: flex;
    align-items: center;
}

.custom-clustericon:before,
.custom-clustericon:after {
    content: "";
    display: block;
    position: absolute;
    width: 100%;
    height: 100%;
    transform: translate(-50%, -50%);
    top: 50%;
    left: 50%;
    background: var(--cluster-color);
    border-radius: 100%;
}

.custom-clustericon:before {
    width: calc(100% + 10px);
    height: calc(100% + 10px);
    opacity: 0.6;
}

.custom-clustericon:after {
    width: calc(100% + 20px);
    height: calc(100% + 20px);
    opacity: 0.3;
}

// The bigger the number, the more markers/groups are contained within.
.custom-clustericon-1 {
    --cluster-color: hsl(var(--color-highlight));
}

.custom-clustericon-2 {
    --cluster-color: hsl(var(--color-secondary));
}

.custom-clustericon-3 {
    --cluster-color: hsl(var(--color-primary));
}

How can I replicate the older styles using the new version?   I;ve tried to inspect the new cluster markers, but all I see is a div with a single transparent pixel image within.  Nothing to actually help me style.   I just want to replicate the styles I have above.   Custom cluster icon colours and three cluster sizes. I'm not sure what those sizes were specifically as I just used the ones that came as default with the old version.
Thanks,
Neil

@rctneil Thank you for opening this issue. 🙏
Please check out these other resources that might be applicable:

Support Console - If you have a support contract.
Discord - chat with other developers
StackOverflow - use the google-maps tag
Google Maps Platform issue trackers

This is an automated message, feel free to ignore.

@rctneil Please take a moment to fill out this short survey. Thank you!
This is an automated message, feel free to ignore.

@jpoehnelt Sorry, I couldn't find anything to help me out at those links.   Any suggestions to getting this sorted?

I vote for this change too

I don't believe this is possible anymore since you can't add classes to clusters (which are google.maps.Marker instances), only the label (text) of a cluster has a className parameter which isn't very helpful. Now the default clusters are base64 encoded SVG data images used as the URL parameter when you create a cluster (Marker instance). The SVG images are created on the fly since they're relatively easy to make (depending on the shape) but they still do not compare to just having a div/span and manipulating it with CSS, which is quite a shame.
   I'd love the option to customise the cluster markers to match my sites theme.

There isn't a direct way to do this like before, but you can create your own instance of Renderer and have the render function return a Marker instance with the icon and styling of your choice. Then provide that Renderer instance in the options when you create your MarkerClusterer instance.
I'll keep this issue open as an FR to add better styling support.

I agree that it is a basic feature to be able to change the color of the clusters. Currently this is hard coded, in the code from what I gather
palette: interpolateRgb("red", "blue"),

@amuramoto I think this can be closed with the introduction of advanced marker which can contain arbitrary markup

@vicb i think the issue here is that they want to style the cluster marker. In the old version of the lib, you could provide your own arbitrary icons and style them with css but currently we now hardcode the cluster icons.

Do you have any plan to restore this ability?
If not then I think this can be closed as the solution would be to implement a custom renderer generating advanced markers.

I reposted this originally and still would love to be able to style the cluster marker fully.
It's such a shame to see it not be customisable like it was.

The Grid Clusterer library found at:
https://github.com/bdcoder2/grid_clusterer
... has hooks for creating custom cluster markers, see the reference at:
https://bdcoder2.github.io/grid_clusterer/v161/reference.html#i5_prop_cluster_marker_create_handler
Just another option as it does support both "Classic" and "Advanced" markers.  :)

Has anyone managed to do this using the renderer function ?

For anyone who has not figured this out yet
const renderer = {
        render({ count, position }: { count: number, position: any }, stats: any) {
            const color = "#d11100";
            const svg = window.btoa(`
                    <svg fill="${color}" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 240 240">
                        <circle cx="120" cy="120" opacity=".8" r="70" />
                    </svg>`);
            // create marker using svg icon
            console.log(count);
            if (count > 1) {
                return new google.maps.Marker({
                    position,
                    icon: {
                        url: `data:image/svg+xml;base64,${svg}`,
                        scaledSize: new google.maps.Size(75, 75),
                    },
                    label: {
                        text: String(count),
                        color: "rgba(255,255,255,0.9)",
                        fontSize: "12px",
                    },
                    // adjust zIndex to be above other markers
                    zIndex: Number(google.maps.Marker.MAX_ZINDEX) + count,
                });
            }
            return new google.maps.Marker({
                icon: {
                    url: `${window.location.origin}/location-pin.svg`,
                    scaledSize: new google.maps.Size(30, 30),
                },
            })
        }
    }
const markerClusterer = new MarkerClusterer({
    markers: clusters, map: mapRef.current, algorithm, renderer: renderer
});


Missing stashing workflow documentation

Wiki page
https://github.com/arxanas/git-branchless/wiki/Workflow:-stashing
Subcommand
No response
Description
I'm interested in your workflow regarding stashing, as I still find myself using git stash sometimes.
By the way, thanks for git-branchless and for the great documentation!

FYI there has also been discussion of this at https://github.com/arxanas/git-branchless/discussions/979

Unfortunately I never created the --stash flag as discussed in https://github.com/arxanas/git-branchless/discussions/979#discussioncomment-6334488, so the workflow itself is a little clumsy.

Got it, thanks! I somehow missed those discussions.


Create fr-fr

Pull Request Summary
I'm french, si I just added a translation file but it's no finished yet.
Have you...

[x] Checked that your code adheres to our code guidelines?

Contributor License Agreement
We want Postleaf to remain free and open for everyone to use forever, so please don’t submit any code or content that is licensed or copyrighted without first getting written consent.
Before we accept your pull request, we ask that you agree to the following terms to ensure there are no conflicts with Postleaf’s license now or in the future.

I certify that the code I am contributing to this project is completely original or free of any known license or copyright.

I agree to allow the developer of Postleaf, A Beautiful Site, LLC, license or relicense my work at their discretion. By submitting this pull request, I agree to forfeit all copyrights, intellectual property rights, and royalties pertaining to my contribution.

By entering my name in the space provided below, I agree to all of the terms mentioned above.

Signed: [Arnaud Panapadéatchy]
Date: [2016-08-02]

Thanks, looks like it's almost there. I'll accept once it's done :)

Merci!


[core] Replace temp package with node built-ins

Dependency has no changelog, its usage does not require a separate package and is on a 0.x release line.
Resolves(no-github-magic) https://github.com/mui-org/material-ui/pull/23257#issuecomment-716302696

Node 10 doesn't have recursive I guess. I'm so looking forward to node 12 :grin:


How do you set the serverTokenEndpoint?

Hey!
I put this in my config/environment.js:
ENV['simple-auth-oauth2'] = {
  serverTokenEndpoint: 'http://localhost:3000/token'
}

but my app still makes the api calls to http://localhost:4200/token
I am following the readme guide exactly.

You can just set that on the authenticator directly, e.g.:
// app/authenticators/oauth2.js
import OAuth2PasswordGrant from 'ember-simple-auth/authenticators/oauth2-password-grant';

export default OAuth2PasswordGrant.extend({
  serverTokenEndpoint: 'http://localhost:3000/token'
});


Use github actions for auto-generating rendered docs

Looks like you're currently running quarto build or so manually and checking the results into this git repo. There's an easier way -- you just commit the quarto markdown (and images and such), and use github actions to automatically rebuild the docs every time you push. https://github.com/dabreegster/talks/blob/main/.github/workflows/pages.yml is an example of how it works. There's also a few github repo settings to click. Next time I'm in the office, we could take a few minutes and set this up?

sounds good, thanks for taking time for this


Adding 109 visualizing 500 000 subscribers

Let me know if you have improvements in terms of thumbnail. I've used the familiar purple for the circles, but for the map there is less freedom being loaded through Mappa.js and Leaflet.

Thank you so much for all the effort you have put in this!! Great work on the timestamps!
The thumbnail looks good to me, I don't see any harm using it.

I agree, great job!

Wow, incredilble!


On web, Map.containsKey(key) returns true during Map.putIfAbsent(key, ...) in some conditions

Hello!
In beta-master channels of Flutter, a weir bug is happening with containsKey and putIfAbsent, where containsKey return true when it would actually return false
Here is a reproduction code:
import 'package:flutter_riverpod/flutter_riverpod.dart';
import 'package:flutter/material.dart';

void main() {
  final map = <Object?, int>{};

  int value = map.putIfAbsent(provider, () {
    print(map.containsKey(provider)); // true, when it should actually be false

    return map.putIfAbsent(provider, () {
      print('never reached');
      return 0;
    });
  });

  print(value); // null, when "value" is supposed to be non-nullable
}

final provider = Provider<int>((_) => throw UnimplementedError());

Here's a dartpad link https://dartpad.dev/?null_safety=true&id=390dbf79cccb2934af50648dadc510b5&channel=beta
As you can see, this breaks all sorts of things. It even allows non-nullable variables to be null
This bug may be related to https://github.com/dart-lang/sdk/issues/47645.
Before, the reproduction code would fail to compile for some funky reasons. With that bug fixed, it seems like what makes the object that causes problem "unique" also breaks Map.containsKey
I'm not sure how to make the reproduction code independent from riverpod. It seems specific to this Provider object, like with https://github.com/dart-lang/sdk/issues/47645, but I failed to reproduce the issue without using the package

@rrousselGit as the documentation said  Calling [ifAbsent] must not add or remove keys from the map. but as you already said containKey should return false
import 'package:flutter_riverpod/flutter_riverpod.dart';
import 'package:flutter/material.dart';

void main() {
  final map = <Object?, int>{};

  int value = map.putIfAbsent(provider, () {
    print(map.containsKey(provider)); // true, when it should actually be false

    return 0;
  });

  print(value); // 0
}

final provider = Provider<int>((_) => throw UnimplementedError());

That's not the issue here.
The code given works if it's anything other than Provider:
  int value = map.putIfAbsent(0, () {
    print(map.containsKey(0)); // false, as expected

    return map.putIfAbsent(0, () {
      print('actually called');
      return 42;
    });
  });
  print(value); // 42, as expected

Rather than being specific to Provider, it seems to happen for all classes overriding ==/hashCode.
void main() {
  final map = <Object?, int>{};

  int value = map.putIfAbsent(a, () {
    print(map.containsKey(a)); // true, when it should actually be false

    return map.putIfAbsent(a, () {
      print('never reached');
      return 0;
    });
  });

  print(value); // null, when "value" is supposed to be non-nullable
}

final a = Foo();

class Foo {
  operator ==(other) => true;
  get hashCode => 0;
}
``

This doesn't reproduce for me on tip of tree VM/dart2js or in Dartpad. The print(map.containsKey(a)); examples above all print false. How do you run the code? Is it DDC only?
It's tricky code. It really should return false during the call to the value function, because you can't add a key to a map without having a value, and you don't have the value while computing it.
I'm guessing it's an optimization, where we find the place where the key should be, and if it's not there, we immediately put in an entry, then compute the value and store that. That makes the map be in an inconsistent state during the ifAbsent call, but avoids having to re-find the position or check afterwards that the found slot is still valid.
In practice, we probably should just throw a ConcurrentModificationErrror if the map keys change during ifAbsent. Then it's safe to not add anything before calling ifAbsent. The location we found should still be valid after ifAbsent if nothing changed.

This doesn't reproduce for me on tip of tree dart2js (or VM) or in Dartpad.

Here's a dartpad link with the previous snippet that reproduce the issue
https://dartpad.dev/?null_safety=true&id=bae6fa8119f5e4275c0e892953e25ea0
As mentioned, importing flutter is necessary

Ack, by bad. Couldn't read the different layout of the Flutter version of DartPad.
It seems DartPad has two modes, a Flutter mode and a pure Dart mode. The Flutter mode is triggered by having an import of a Flutter library. It's probably checked using a RegExp, because it triggers Flutter mode on a commented out line of // import 'dart:ui'; too. That's sufficient to trigger the bug, you don't need to do the actual import.
In Flutter mode, the bug is there, independent of channel choice.
In Dart mode, the bug is absent, independent of channel choice.
So, being integrated into the Flutter SDK somehow breaks the web versions of putIfAbsent from the Dart SDK.
That is odd.
The platform Dart2JS code for putIfAbsent is:
V putIfAbsent(K key, V ifAbsent()) {
    if (containsKey(key)) return this[key] as V;
    V value = ifAbsent();
    this[key] = value;
    return value;
}

That looks foolproof.
Maybe some compiler optimization triggers which replaces this safe code with something "more efficient", but wrong.
But why only in Flutter?

Someone on Twitter mentioned that this happens only in debug mode.
Apparently in Flutter release mode, the issue doesn't occur
Not sure if that helps though

Thanks for all the details!
You are correct, for odd historical and architectural reasons - flutter-mode uses DDC and dart-mode uses dart2js, so this sounds likely like an inconsistency in the development javascript compiler.

That makes sense. The DDC putIfAbsent is quite a lot more complicated, and probably bugged (in particular, line 183 seems premature).

@rrousselGit As always thanks for your issue report!
I see how the DDC implementation can trigger the behavior that you are seeing but I don't fully agree that there is a bug here based on the example you provided. Calling putIfAbsent() in the ifAbsent function is unspecified behavior according to the documentation. Is that the pattern that appears in real world code as well?

This issue stems from a real-world bug report: https://github.com/rrousselGit/river_pod/issues/980
So it's definitely something that can happen
In my case, the logic was slightly less direct. It was something among the lines of:
node.map.putIfAbsent(key, () {
  final anotherNode = tree.searchForSomeNode();
  ancestorNode.map.putIfAsbent(key, () => Class());
});

In this snippet, it's entirely possible for node and anotherNode to be different, in which case there's nothing wrong with the code.
But they can be the same, in which case this issue happens.
I've changed it already to fix the bug. I now use:
if (!map.containsKey(key)) {
  map[key] = ...
}

But even if we don't want to allow such code, I don't think that the current behavior is OK. It's not consistent with how this code behaves on other targets, and this bug can break null safety.
IMO either the behavior should be aligned with other targets (preferably) or the code should throw. The fact that it currently allows assigning null to Object is problematic

IMO either the behavior should be aligned with other targets (preferably) or the code should throw. The fact that it currently allows assigning null to Object is problematic

@rrousselGit I agree that consistency between backends is better in most cases, but this sounds more like you are requesting that the API be changed so the behavior is specified. I don't think it is a good long term fix to leave it unspecified but expect the unspecified behavior to be the same in different implementations since they can drift over time with updates or optimizations.

The DDC putIfAbsent is quite a lot more complicated, and probably bugged (in particular, line 183 seems premature).

@lrhn It looks like to me the code you pointed out is the causes the observed behavior but I can you elaborate on it being a bug?
In this case the DDC implementation has combined the logic of the contains lookup with the put operation to avoid a few extra checks that are not necessary given the expectation that contents of the map does not change when ifAbsent() is called. If we undo that without adding a test case then it has the possibility of drifting over time and generally we don't want to add test cases for unspecified behavior.
It seems that there are a few options going forward. Here they are in the order of complexity as I see it:

Leave the DDC implementation as is. This is unspecified behavior so anything it does is considered "correct".
Update DDC to have the same behavior as dart2js and the VM. Nice for now, but no guarantee that it will always be consistent in the future.
Update DDC to throw an exception. This helps highlight the potential bug at development time, but only on the web.
Update the documentation and all backends to throw an exception. Best for consistency across implementations and hopefully catching possible bugs.

Anything I missed?

I personally don't care that much about what the fix is, as long as it's not "keep the current behavior"
Albeit unspecified, the current behavior breaks the type system by allowing an unsound assignment.
Being able to assign null to a non-nullable variable sounds like heresy.

It's a bug because map.containsKey(a) returns true while there isn't actually and entry in the map for that key.
For containsKey, that's really an "it had one job!" situation.
That's what causes the inconsistency: If map.containsKey(a) returns true, then map[a] and map.putIfAbsent must return a value that is an instance of the V type. Here it returns null, because there is no entry with that key. The latter has return type V, so it breaks type soundness to return null.
I'll fix this, and I'll add a test.
I'll also add a concurrent modification check, because missing a concurrent modification is acceptable only when the final result is a consistent state for the collection. If some modifications can make you end up with map with an internal state which doesn't satisfy its own invariants, then it should throw. (Also, it's just one number comparison in an otherwise complicated function).

It's a bug because map.containsKey(a) returns true while there isn't actually an entry in the map for that key.
For containsKey, that's really an "it had one job!" situation.

Thanks for pointing this out, I was focusing on the modification of the map and failing to consider that it is valid to check if the map contains the key in the ifAbsent() call.

I'll fix this, and I'll add a test. (Done, well, if the tests run 😁).

Thanks for this too! It looks like there is a test that fails with the new modification check you added.
https://github.com/dart-lang/sdk/blob/6de562dfdebbfbd24383823507a28f8d79cba98c/tests/corelib/hash_map2_test.dart#L139-L148
It appears to be testing that you can change a value for a key that is already present in the map. I suppose that as the method comment is written this should be allowed because it is not adding or removing keys.

My mental model for m.putIfAbsent(k, () => e) is that it behaves like m[k] ??= e, except that (1) it works properly for null values stored in the map and (2) might be be more efficient, including calling hashCode fewer times.
The VM implementation realizes this model and reused the lookup position unless there is an invalidating change, in which case the indexed setter is used. There is the comment "ifAbsent is allowed to modify the map."
  V putIfAbsent(K key, V ifAbsent()) {
    final int size = _index.length;
    final int fullHash = _hashCode(key);
    final int hashPattern = _HashBase._hashPattern(fullHash, _hashMask, size);
    final int d =
        _findValueOrInsertPoint(key, fullHash, hashPattern, size, _index);
    if (d > 0) {
      return _data[d];
    }
    // 'ifAbsent' is allowed to modify the map.
    List oldData = _data;
    int oldCheckSum = _checkSum;
    V value = ifAbsent();
    if (_isModifiedSince(oldData, oldCheckSum)) {
      this[key] = value;
    } else {
      final int i = -d;
      _insert(key, value, hashPattern, i);
    }
    return value;
  }

I think we should make all implementations consistent with the VM behaviour, which has the benefit of being consistent with MapMixin.putIfAbsent.

@nshahan
That test is wrong. It's adding the 4 key inside the putIfAbsent code, a key which does not exist in the map at that time. That's a concurrent modification, and may throw ConcurrentModificationError.
Changing the value of [5] is fine if 5 is already in the map, but 4 definitely isn't, since ifAbsent is called.
So, I'll have to fix that test too :)


Garbage appears on the screen

When the size of screen buffer and one of window , after Ctrl-L was pressed , sometimes garbage appears on the screen.

Made pull-request for the library: go-colorable as below.

When the width of the screen is too large, garbage appears the screen after ESC[2J and some scrooling by zetamatta · Pull Request #30 · mattn/go-colorable

The patch sent to go-colorable was merged !
This issue is fixed with doing make.cmd get.


Beacon quantity limit that can be registered to google beacon dashboard

Hi There
May I know are there a beacon quantity limit that can be registered to google beacon dashboard?
Thank you
David

Are you experiencing a limitation issue?
I don't believe there is a limit as such, at least not one you are likely to reach.
I've worked with a few companies that do beacons large scale and have not heard of any issue with how many beacons can sit in Google beacon dashboard.


Trying same method

Hey so I have made similar python bots to extract comics from apps such as marvel unlimited , manga sites and even Chegg bots.
I tried to make a bot for DC Universe. I was able to sniff the traffic and get the comic pages. But the comic pages of DC Universe are in a .enc format. That is encrypted. I have the asset_keys to unlock it but I don't know how to go about it . Maybe you could help me out?

Il make it easier by showing a sample.
here is the encrypted comic page from dc universe : https://drive.google.com/file/d/1CwCSxOujlWtyaWNPBbQ-mDVWMIcWJCN5/view?usp=sharing
Here is the image decryption bundle DC UNIVERSE uses to decrypt it : https://drive.google.com/file/d/1Lv9MTz1gkMlYogtf6ccV3J4Dga0yEk3F/view?usp=sharing
Im not able to figure out how they decrypt that image.
I see you have been able to figure out the password for the zip file of comixlogy.
Hope you can help me out to figure out how to decrypt that image.
If you need the patched apk of dc universe or a an account let me know.
Need help for decrypting that dc universe comic image.

0 idea, I'm not interested in that service plus this is offtopic. Sorry I couldn't help.


Termination checking doesn't seem to work for deep pattern matches

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.
Reduced the issue to a self-contained, reproducible test case.

Description
Termination checking doesn't seem to work for deep pattern matches, which makes it impossible to write recursive functions for inductive types having, e.g., recursive products as constructor parameters.
Steps to Reproduce
This program termination checks
inductive Tree: Type
  | leaf: Tree
  | node: Tree -> Tree -> Tree

def length: Tree -> Nat
  | Tree.leaf => 0
  | Tree.node left right => 1 + length left + length right

but this equivalent program
inductive MyProduct (A: Type) (B: Type): Type
  | mk: A -> B -> MyProduct A B

inductive MyTree: Type
  | leaf: MyTree
  | node: MyProduct MyTree MyTree -> MyTree

def my_length: MyTree -> Nat
  | MyTree.leaf => 0
  | MyTree.node (MyProduct.mk left right) => 1 + my_length left + my_length right

fails with
fail to show termination for
  my_length
with errors
structural recursion cannot be used

'termination_by' modifier missing

Expected behavior: successful termination checking
Actual behavior: failed termination checking, cannot use structural recursion
Reproduces how often: always
Versions
Lean (version 4.0.0-nightly-2021-12-03, commit c7565c446aa7, Release) on Ubuntu 20.04

Structural recursion currently does not support nested inductive datatypes like the MyTree example above. We want to support nested and mutually inductive datatypes using well-founded recursion. Actually, we can already do it, but the well-founded relation and decreasing proofs have to be manually provided. Example:
inductive MyProduct (A: Type) (B: Type): Type
  | mk: A -> B -> MyProduct A B

inductive MyTree: Type
  | leaf: MyTree
  | node: MyProduct MyTree MyTree -> MyTree

def my_length: MyTree -> Nat
  | MyTree.leaf => 0
  | MyTree.node (MyProduct.mk left right) => 1 + my_length left + my_length right
termination_by sizeOfWFRel -- Well-founded relation to be used
decreasing_by -- The tactic for showing recursive applications are decreasing.
  simp [invImage, InvImage, Prod.lex, sizeOfWFRel, measure, Nat.lt_wfRel, MyTree.node.sizeOf_spec, MyProduct.mk.sizeOf_spec]
  rw [Nat.add_comm, Nat.add_one]
  apply Nat.lt_succ_of_le
  first
  | apply Nat.le_add_left
  | rw [Nat.add_comm 1, Nat.add_assoc]; apply Nat.le_add_right

We want to automate the example above, and make sure users will not need to provide the termination_by and decreasing_by modifiers in simple examples like the one above.

@leodemoura If I may ask, what's the motivation for not just using structural recursion + a termination checker (e.g. Foetus)?

@leodemoura If I may ask, what's the motivation for not just using structural recursion + a termination checker (e.g. Foetus)?

We want the Lean (trusted) kernel to be simple. For example, it does not include a termination checker. The Lean elaborator (aka frontend) is responsible for compiling recursive definitions into fixed primitives accepted by the kernel. There are a few advantages: it is easy to write an external type checker for Lean; separation of concerns (e.g., the "termination compiler" extensions do not affect the trusted kernel).

The definition above is now accepted even when termination_by is not provided.


adding FP list URL for FB

@sweng66 I've merged your PR because Valerio's about to open another PR that we want to merge

Thanks @azurebrd


Merge pull request #9 from BlackrockDigital/master

update to bootstrap 3.3.7

can make the "Scroll Down"better


Negative Profits

Expanding core doesn't work if negative profits are present. Check during initialization.

We have to check for negative profits and weights.


Update wiznote to 2.4.4,2017-03-14

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Verified locally.


docs on what fastplotlib is

notes from meeting with @apasarkar

we should put a few bullet points on the readme that quickly explains what fpl allows you to do

rapid prototyping, realtime analysis
easy API
ship with depedent packages as a standalone distributable - ex: pyinstaller, etc. (this is a medium term goal right now)

somewhere in the docs we should put a comparison with other libraries, pyqtgraph, vispy, napari, bokeh, matplotlib

I think rendering speed is also important, esp as a function of data size

I think some points on what fastplotlib is not would also be useful
* fastplotlib is not related to matplotlib in any way. These are two completely different libraries with their own APIs
    * the fastplotlib way of doing things is different from matplotlib since fastplotlib is an _interactive_ plotting library that runs on the GPU using WGPU. Nonetheless, we want fastplotlib to be easy to use and learn. Hint: bring in your numpy and array intuitions when using fastplotlib rather than any matplotlib intuitions. If you know how to manipulate numpy arrays, you already understand half of fastplotlib! :tada:  We recommend looking at our examples gallery. If you have any questions please do not hesitate posting an issue or dicussion forum post :smile:
* fastplotlib is not meant for creating static publication figures, there are other libraries that are well suited for this task

I think we can add this to the fpl guide, maybe after the section What is fastplotlib? we can have What fastplotlib is NOT


Remove conflicting nullable specifier on init

The nullable specifier on init conflicts with the nonnull specifier on NSObject which generates a warning. This change removes it and throws an exception if init is used.

gentlest of pings @SlaunchaMan — would you mind looking at it? As it currently stands, when using AFNetworking as a CocoaPod, it generates a bunch of warnings in client projects:
https://github.com/wordpress-mobile/WordPress-iOS/pull/8660
Looks like there was #4027 filed about it.

Hi @jklausa! Can you merge master in to get the tests passing?

@SlaunchaMan I'm not the original author of this patch, but I took the liberty of cherry-picking it onto master and filing another one — #4163, in order to save time :)
Hopefully that's ok with you @nrbrook — let me know if I should close my PR if you'd prefer that.

Either is fine, shall I close this then?


RFC Generic automatic record merger

When two (or more) sites exchange records via e.g. OAI-PMH, it is often the case that an update of a record on site A, is going to conflict with updates on site B (e.g. if both site A and site B modified the same record field).
At the moment (in Invenio master) in case of conflict, upon upload, the record is going to be added to the holding pen, waiting for human curation. However, there are several situations where it should be possible to automatically merge the record update, by a configurable set of rules (e.g. to declare which fields have higher priority on which site, or by allowing pluggable merging rules...)
Now that bibupload is being rewritten in pu as a customizable workflow, it should be possible to create a step responsible for resolving merging conflicts (when possible).

Please check https://github.com/inspirehep/json-merger


Error: The system cannot find the file specified. (os error 2)

     Running `target\debug\examples\stable-diffusion.exe --prompt "A very rusty robot holding a fire torch." --cpu all`
Cuda available: false
Cudnn available: false
MPS available: false
Running with prompt "A very rusty robot holding a fire torch.".
Building the Clip transformer.
Error: The system cannot find the file specified. (os error 2)
error: process didn't exit successfully: `target\debug\examples\stable-diffusion.exe --prompt "A very rusty robot holding a fire torch." --cpu all` (exit code: 1)

This is the output I get after running cargo run --example stable-diffusion --features clap -- --prompt "A rusty robot holding a fire torch." in cmd. I am on windows. I ran scripts/download_weights.sh in WSL and moved the /scripts/data directory to /data beforehand as well. I don't know what file it's referring to by "Error: The system cannot find the file specified. (os error 2)", help would be appreciated!

It's indeed annoying that the file does not get mentioned in the error message (which is a limitation of the Rust standard library). My guess is that it's the clip weight files based on the log, but it's the first one to be loaded.
Note that this was recently switched to use safetensors by default, so maybe that's related. Could you check that your data directory contains pytorch_model.safetensors?
If so could you also try overriding the clip weight file to point it at the appropriate place with --clip-weights path/to/clip-weights?

Thanks for the response. I ended up manually logging the filenames, and found out that it expected the stable-diffusion-v2.1 filenames, whereas I had the v1.5 files downloaded. Added --sd-version v1-5 to the command, and it worked.


how can i eval  evaluate expressions  in debugConsole ?

Hi @acodervic , this kind of questions are better suited to the forum or the different community channels.
I'll leave it open for anyone to help you still, but I strongly suggest you to take it there.


@conda-forge-admin, please add bot automerge

Additional comment:
No response

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/pyhanko-certvalidator-feedstock#4.


failed to access kube-dns in the cluster

There're lots of logs like:
microk8s.daemon-proxy[15543]: E0612 22:18:53.558576   15543 proxysocket.go:235] Write failed: write udp <IP_ADDRESS>:48044-><IP_ADDRESS>:53: write: operation not permitted
And other pods can not access kube-dns with the cluster IP.
inspection-report-20190612_220806.tar.gz
Please run microk8s.inspect and attach the generated tarball to this issue.
We appreciate your feedback. Thank you for using microk8s.

@zkuang could you try removing the local containerd you have apt-get remove containerd.io just in case there is something left running there? Can you also check the edge channel where we have introduced coredns (sudo snap install microk8s --classic --edge)?

Sorry for replying late. I tried that, doesn't related.
But later I figure it out. I have to disconnect my vpn before initializing micrk8s (after pulling images). So I'm closing this.


rebooted the system without warning while installing kubernetes

Describe the bug
I am trying to install kubernetes using omnia. While doing that,, it rebooted my device in middle of the installation, for ib drivers.
it checked for the InfiniBand support and it then rebooted and put me out of my master node.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
I think it should not reboot if I am on that system or may be give a warning that it is going to reboot.
Screenshots
If applicable, add screenshots to help explain your problem.

I have attached the pic.

Hi @Khushboodholi ,
Can you please provide inventory format you have used. Can you please confirm omnia.yml is running from manager/head node or not?

@abhishek-sa1: yes I was running from manager node.
I have attached the inventory I used. I had one worker node and one manager code in this cluster.


Report Disk Usage and refactor SystemMeasurement

This contains a refactor of SystemMeasurement since it was really ugly and it was just a mess and it also contains reporting disk usage of the /tmp directory.
The refactor should help in the future if more things about the system want to be queried in the future.

@kolanos Okay, I added a test for the disk usage.


Add Oslo418's Portfolio

Closes https://github.com/Kiran1689/Awesome-Dev-Portfolios/issues/250

@all-contributors please add @Oslonline for code