[go_router] On auth token refresh, GoRouterState.extra comes as null

Is there an existing issue for this?

[x] I have searched the existing package issues
[X] I have read the guide to filing a bug

What package does this bug report belong to?
go_router
What target platforms are you seeing this bug on?
iOS
Have you already upgraded your packages?
Yes
Dependency versions
pubspec.lock
Lock File

Steps to reproduce

Create a class that extends change notifier and use it as a listenable in your go_router instance.
Create a few routes and make sure that at least one of them needs some inputs or props when navigating to it.
Navigate to this route after starting the app.
Wait for your go_router instance to refresh which should be triggered by the change notifier due to some type of state change.

Expected results
Yesterday I was on version 7.1.1 and everything worked fine. My auth provider and the redirect/refresh mechanism behaved correctly i.e. if the Auth state changed, the app would automatically navigate to the appropriate route.
Actual results
Today, I upgraded to version 9.0.3 and when I run the app and wait for 3600 seconds (set in Supabase dashboard) for my auth token to refresh and my go_router instance to refresh consequently, I get the following error:
_TypeError (type 'Null' is not a subtype of type '({bool? isUpdating, SearchedRecipe? searchedRecipe})' in type cast)

in the following piece of code
GoRoute(
        path: MyRoutes.recipeDetails.path,
        pageBuilder: (context, state) => CupertinoPage(
          child: RecipeDetailsScreen(
            props: state.extra as RecipeDetailsProps,
          ),
        ),
      ),

The above code is from where I am instantiating all of the routes. Also, for context, RecipeDetailsProps is a custom type for the record in the error above. This type is irrelevant here because the GoRouterState.extra is coming as null which shouldn't be the case.
Code sample
Code sample
I am working in a large code base and I am not sure what to provide here. If anything in particular is required, please let me know and I will provide it.

Screenshots or Videos
No response
Logs
Logs
Restarted application in 667ms.
flutter: ***** Supabase init completed Instance of 'Supabase'
[GoRouter] Full paths for routes:
             => /landing
             => /login
             => /home
             => /add-food
             => /food-details
             => /create-food
             => /recipe-details
             => /create-recipe
[GoRouter] setting initial location /home
flutter: **** onAuthStateChange: AuthChangeEvent.signedIn
flutter: **** new token from supabase (removed for privacy reasons)
flutter: ***** SupabaseDeepLinkingMixin startAuthObserver
[GoRouter] pushing /add-food
[GoRouter] pushing /recipe-details
flutter: **** onAuthStateChange: AuthChangeEvent.tokenRefreshed
flutter: **** new token from supabase (removed for privacy reasons)
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following _TypeError was thrown building Builder:
type 'Null' is not a subtype of type '({bool? isUpdating, SearchedRecipe? searchedRecipe})' in type
cast

The relevant error-causing widget was:
  AnimatedSwitcher
  AnimatedSwitcher:file:///Users/abdulmuezz/Documents/Projects/iucalorie/lib/main.dart:206:26
When the exception was thrown, this was the stack:
#0      IucRouter._goRouter.<anonymous closure> (package:iucalorie/router/iuc_router.dart:168:32)
iuc_router.dart:168
#1      RouteBuilder._buildPageForGoRoute (package:go_router/src/builder.dart:363:45)
builder.dart:363
#2      RouteBuilder._buildRecursive (package:go_router/src/builder.dart:223:13)
builder.dart:223
#3      RouteBuilder._buildRecursive (package:go_router/src/builder.dart:231:9)
builder.dart:231
#4      RouteBuilder._buildRecursive (package:go_router/src/builder.dart:231:9)
builder.dart:231
#5      RouteBuilder._buildPages (package:go_router/src/builder.dart:162:7)
builder.dart:162
#6      RouteBuilder.tryBuild (package:go_router/src/builder.dart:135:9)
builder.dart:135
#7      RouteBuilder.build.<anonymous closure> (package:go_router/src/builder.dart:106:33)
builder.dart:106
#8      Builder.build (package:flutter/src/widgets/basic.dart:7531:48)
basic.dart:7531
#9      StatelessElement.build (package:flutter/src/widgets/framework.dart:5156:49)
framework.dart:5156
#10     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5086:15)
framework.dart:5086
#11     Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
framework.dart:4805
#12     StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
framework.dart:5162
#13     Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
framework.dart:3686
#14     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
framework.dart:5111
#15     Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
framework.dart:4805
#16     ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
framework.dart:5417
#17     Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
framework.dart:3686
#18     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
framework.dart:5111
#19     Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
framework.dart:4805
#20     StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5)
framework.dart:5162
#21     Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
framework.dart:3686
#22     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
framework.dart:5111
#23     Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
framework.dart:4805
#24     ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
framework.dart:5417
#25     Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
framework.dart:3686
#26     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
framework.dart:5111
#27     Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
framework.dart:4805
#28     ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5)
framework.dart:5417
#29     Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15)
framework.dart:3686
#30     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16)
framework.dart:5111
#31     StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11)
framework.dart:5251
#32     Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7)
framework.dart:4805
#33     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2780:19)
framework.dart:2780
#34     WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:903:21)
binding.dart:903
#35     RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:358:5)
binding.dart:358
#36     SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1284:15)
binding.dart:1284
#37     SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1214:9)
binding.dart:1214
#38     SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:1072:5)
binding.dart:1072
#39     _invoke (dart:ui/hooks.dart:142:13)
hooks.dart:142
#40     PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:359:5)
platform_dispatcher.dart:359
#41     _drawFrame (dart:ui/hooks.dart:112:31)
hooks.dart:112

════════════════════════════════════════════════════════════════════════════════════════════════════
[log] Error: Read failed
flutter: **** onAuthStateChange: AuthChangeEvent.tokenRefreshed
flutter: **** new token from supabase (removed for privacy reasons)
Another exception was thrown: type 'Null' is not a subtype of type '({bool? isUpdating, SearchedRecipe? searchedRecipe})' in type cast
Another exception was thrown: type 'Null' is not a subtype of type '({bool? isUpdating, SearchedRecipe? searchedRecipe})' in type cast

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.10.5, on macOS 13.4 22F66 darwin-arm64, locale en-PK)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.1)
[✓] VS Code (version 1.80.0)
[✓] Connected device (3 available)
[✓] Network resources

• No issues found!

Thanks for the report @muezz
Have you also looked at the recent breaking changes along with migration guide in the package to see if that helps in your case or not ?

@darshankawar I did have a look and I did not find anything that seemed relevant to the error I am facing but I could very well be wrong.
Also, there were no errors in the code as well when I upgraded the package.
If you have a suspicion regarding any particular breaking change, let me know. I'll have a look at it again.

Thanks for the update. If you could provide us a minimal code sample that triggers the error, that'll help us to analyze it properly and make it actionable.

@darshankawar It took some time but I have been able to recreate this bug in this repo.
Some important points:

There is a login page, home page and a child page.
Initial route is home page.
When you first open the app, your auth state will be loggedIn which implies that your auth state was restored from a previous session or through some other method.
Right then a timer starts for 30s. After this, the state changes to loading and then back to loggedIn. This implies that after 30 seconds, the server refreshed the user token. I am trying to recreate the same flow as Supabase where user auth token is refreshed after 3600 seconds.
When this state changes, it triggers the refresh logic.
To actually see the bug in action, restart the app, quickly navigate to the child page and then stay there until the auth state refreshes.

I hope the explanation helps. Let me know if you have any questions

Thanks for the update and taking time to provide the repo. Although it does have third party packages:
  flutter_hooks: ^0.18.6
  provider: ^6.0.5

We usually look for minimal code sample without third party package implementation so as to narrow down the error to go_router and it isn't occuring due to other packages. So if you could check the same just using go_router and see if the reported error still persists.

@darshankawar You can ignore the flutter_hooks package. It got left there by mistake. I am not using it anywhere. As for provider, it is sort of necessary for this use case. I cannot recreate this scenario otherwise (I think).
Moreover, I do not think provider is the problem here because this bug only appears AFTER I upgrade the go_router package from 7.1.1 to 9.0.3.

Thanks for the update. Using the repo and details provided here, it does throw the reported error.

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.10.6, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.10.6 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f468f3366c (5 days ago), 2023-07-12 15:19:05 -0700
    • Engine revision cdbeda788a
    • Dart version 3.0.6
    • DevTools version 2.23.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.13.0-6.0.pre.30, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.13.0-6.0.pre.30 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 33d174d797 (4 hours ago), 2023-07-18 22:36:21 -0400
    • Engine revision 39d60be72f
    • Dart version 3.1.0 (build 3.1.0-324.0.dev)
    • DevTools version 2.25.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

@darshankawar Any updates on this? This is one of the last few bugs that I have to fix before I can launch my app.

I fixed this issue by putting the data i receive from extra in to a variable within a stateful widget's state.
class _ChatPageState extends State<ChatPage> {
  late TextEditingController _textEditingController;

  @override
  void initState() {
    super.initState();
    _textEditingController = TextEditingController(text: widget.data);
  }
}

In this case I was passing in a string, i've also done this with other data types and it works well, The data is stored within the state's variables so it works like a charm.
Also make sure when you cast the value to your data type make it nullable,
ChatPage(
     key: state.pageKey,
     data: (state.extra as String?),
),

although the state keeps your data within the state, extra will keep sending null.
Hope it helps 🙂

I think this would work just fine but it seems like a work-around

@muezz, Yes indeed

I hope the bug gets resolved permanently.

Well a PR has been sent but has not been merged yet, till then this workaround might be best.

Hello @muezz and @Andreigr0 , I fixed this issue by putting the data i receive from extra in to a variable within a stateful widget's state.
class _ChatPageState extends State<ChatPage> {
  late TextEditingController _textEditingController;

  @override
  void initState() {
    super.initState();
    _textEditingController = TextEditingController(text: widget.data);
  }
}

In this case I was passing in a string, i've also done this with other data types and it works well, The data is stored within the state's variables and doesn't get called again because its being initialied within the initState method so it won't reset to null and works like a charm. Also make sure when you cast the value to your data type make it nullable,
ChatPage(
     key: state.pageKey,
     data: (state.extra as String?),
),

although the state keeps your data within the state, extra will keep sending null. Hope it helps 🙂

It works. However, As far as I can see, now that the ChatPage is uncontrolled and loses the ability to rebuild if the arguments change.
So, I did a hack with path paramters.

Using id or key -- "/product/:id" -- the data can be fetched from web or loaded from local storage in the ProductPage.
Converting the argument to json or whatever can be converted to string -- "/details/:data" or "/details?data=$data" -- then the data can be converted back before passing it to the DetailsPage.

I hope this helps if the issue remains unsolved.

I ended up using auto_route package, don't get me wrong this package is great but the number of open issues to closed ones labelled triaged-go_router is unfair, 174 to 15 is just sad for this package, I mean I recently found a huge bug and reported it, mind you this is one of the main functionalities a routing package should do well and it got marked as P2 for the root issue.
And as for this issue a PR has been sent yet not merged. Its as if this package is abandoned but you'll see a minor update just a few days ago 🤨.
Look i'm not being inconsiderate, I know we all have things to do and other issues have higher priorities than others and I also do understand we could help in some manner (i.e PRs) but c'mon 174 to 15, do you see the concern so I decided to move on from go_router and use auto_route instead but regardless thanks for this package.

@JohnF17 I found more bugs myself as well. Ill test auto_route thanks 👍

Hey @muezz, the PR has been merged and a new update has rolled out, go_router: 11.0.0, just letting you know👍.

I myself moved to auto_route for my current project and have been loving it so far. I prefer go_router's route guard mechanism but this bug was creating more problems in our project so T had no choice. I'll check out v11 in a future project.


is there a code that can issue http3 or use quic like this?

this is from fasthttp, it automatically issues all domain names https using letsencrypt
https://play.golang.org/p/yyF3_n4Ag4d

Sure, you can use any tls.Config you like with quic-go.

can it do automatic letsencrypt?


GPU memory is not released after training.

I set batch size to 1, and the GPU usage during training is around 28192MiB. However, when the training finished and eval started, the memory usage would be double. Any way to fix this issue?

I rewrite the code with hugging face accelerator. So I close this issue.

Hi, I use 2 A30 GPUs each get 24GB memory (48GB in total), and I set all the train bs=2, val & test bs=1. The first epoch works fine, but it raises 'out of memory' error on the 2nd epoch. I'm curious about your solution with 'hugging face accelerator'. Could you please share more information about how you solve it?

Hi, I used this lib https://huggingface.co/docs/accelerate/index, but I think a simple solution is just saving the weights for every epoch, and then evaluate them one by one.

Hi, I used this lib https://huggingface.co/docs/accelerate/index, but I think a simple solution is just saving the weights for every epoch, and then evaluate them one by one.

Hello, I also have met this problem, can you explain this solution specifically? I saw this question when used accelerate: 'SequentialSampler' object has no attribute 'set_epoch' .
I felt confused why the memory is not enough after training.

Hi, I used this lib https://huggingface.co/docs/accelerate/index, but I think a simple solution is just saving the weights for every epoch, and then evaluate them one by one.

Hello, I also have met this problem, can you explain this solution specifically? I saw this question when used accelerate: 'SequentialSampler' object has no attribute 'set_epoch' .
I felt confused why the memory is not enough after training.

It seems that I need to rewrite the code for the model train and dataset sections

I think the reason for this problem lies in the eval_psnr() function in train.py, which uses pre_list and gt_list during evaluation to save all the results of val_loader, resulting in memory overflow. My solution is to replace train.py with the code corresponding to eval_psnr in test.py.

the

Hi, I used this lib https://huggingface.co/docs/accelerate/index, but I think a simple solution is just saving the weights for every epoch, and then evaluate them one by one.

Hello, I also have met this problem, can you explain this solution specifically? I saw this question when used accelerate: 'SequentialSampler' object has no attribute 'set_epoch' .
I felt confused why the memory is not enough after training.

It seems that I need to rewrite the code for the model train and dataset sections

I am not very familiar with this accelerator, can you tell me how to change it?

with torch.no_grad():


BFS Writing Tests

Unfortunately, I forgot to write tests for my BFS backend endpoint, so I will do that at some point in my down time.

Also, I need to write endpoint docs.


need to have 2 methods (isUrlAllow, isUrlDisallow) to check is url allow or not

public function isUrlAllow($url)
public function isUrlDisallow($url)

merged https://github.com/bopoda/robots-txt-parser/pull/11


uORB multi-subscription in-built support

@thomasgubler This adds the backend for multi-subscriptions. The interface is done properly mutually exclusive and with priorities, so drivers using it can be started at the same time and the priority in subscribing from them can be inferred via the priorities API. This is unit-tested, but I haven't ported drivers yet or test-flown it.

Closing in favour of #1698.


Chapter-06 test classes fail on Mac Pro M1 chip machine

Hi dear author, I encountered an issue on the testing classes, belows are the fragment  of error message:
o.t.d.DockerClientProviderStrategy       : Could not find a valid Docker environment. Please check configuration. Attempted configurations were:
 '/Users/user/Library/Caches/JNA/temp/jna3778529952029307024.tmp' (fat file, but missing compatible architecture (have 'i386,x86_64', need 'arm64e'))
I found there is issue on testcontainers repo Unable to run test containers with Apple Silicon Mac. The unit test works fine for me after adding testImplementation 'net.java.dev.jna:jna-platform:5.8.0' to gradle build file.

Hello Andy and thanks for reporting the issue!
The codebase of the book does not support running on Apple silicon, e.g. M1, or ARM64 in general.
But I'm working on a number of blog posts where I explain how to upgrade the source code of the book to newer versions, for example to support ARM64 in general and specifically Apple silicon. The blog posts will be published in the README.md file.
When it comes to test-containers, you can simply upgrade the dependency to use v1.16.0 to make them work on M1, see the release notes.
Hope the helps, and let me know if it doesn't :-)

Hi Magnus, thanks for replying and the detailed explanation!
The solution of dependency upgrade works fine for me, and I've seen you publish a blog with regard to dependency upgrading, appreciate your efforts :-)
Best Regards,
Andy


Fix bottle prefix and repository handling

We were previously only looking at the cellar value when pouring bottles and ignoring the prefix and (implicit) repository.
Actually look at these values and set the defaults for each platform.
Also, when we're relocating to create or pour bottles when prefix and repository are equal then skip relocating the repository and always use references to the prefix instead.
Fixes #9453

Review period skipped due to critical label.

Fixes bottling issues on ARM Big Sur (tested on pkg-config libpng freetype)

After this PR, it is no longer possible to install cellar :any bottles in a non-standard prefix. For example:
$ git clone --reference=/usr/local/Homebrew https://github.com/Homebrew/brew ~/.homebrew
$ git clone --reference=/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core https://github.com/Homebrew/homebrew-core ~/.homebrew/Library/Taps/homebrew/homebrew-core
$ ~/.homebrew/bin/brew install hello
Warning: Building hello from source as the bottle needs:
- HOMEBREW_CELLAR: any_skip_relocation (yours is /Users/shaun.jackman/.homebrew/Cellar)
- HOMEBREW_PREFIX: /usr/local (yours is /Users/shaun.jackman/.homebrew)
- HOMEBREW_REPOSITORY: /usr/local/Homebrew (yours is /Users/shaun.jackman/.homebrew)
==> Downloading https://ftp.gnu.org/gnu/hello/hello-2.10.tar.gz
…
$ ~/.homebrew/bin/brew --version
Homebrew 2.6.2-9-g26a59c9
Homebrew/homebrew-core (git revision 1b4630; last commit 2020-12-14)

After this PR, brew install --force-bottle hello fails with Error: undefined method 'stage' for nil:NilClass when Homebrew is installed in a non-standard location like for example ~/.homebrew/. Steps to reproduce on macOS are:
$ git clone --reference=/usr/local/Homebrew https://github.com/Homebrew/brew ~/.homebrew
$ git clone --reference=/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core https://github.com/Homebrew/homebrew-core ~/.homebrew/Library/Taps/homebrew/homebrew-core
$ ~/.homebrew/bin/brew install --force-hello hello
==> Downloading https://homebrew.bintray.com/bottles/hello-2.10.catalina.bottle.
Already downloaded: /Users/shaun.jackman/Library/Caches/Homebrew/downloads/6a8a266068965d3a7ea16bfe4821367cb94c47f904e7fc23ec61fad8a9859c54--hello-2.10.catalina.bottle.tar.gz
Error: undefined method `stage' for nil:NilClass

Issue reported at https://github.com/Homebrew/brew/issues/9521

After this PR, it is no longer possible to install cellar :any bottles in a non-standard prefix.

Fixed in https://github.com/Homebrew/brew/pull/10025


Add template support to Bayesian sensor

Description:
The Bayesian binary sensor currently only supports state and numeric_state, which limits its functionality. This PR adds the template support that allows users to significantly increase its value.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8408
Example entry for configuration.yaml (if applicable):
binary_sensor:
  - platform: 'bayesian'
    prior: 0.5
    name: 'Day'
    probability_threshold: 0.95
    observations:
      - platform: template
        value_template: >
          {{is_state('sun.sun','below_horizon')}}
        prob_given_true: 0.9
        prob_given_false: 0.2

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Thanks! 😎


Font suggestion

Not really an issue, but still.
Rdio used 'Whitney', good alternatives are:
Museo Sans, FF Dagny, FF Meta, or Ratio

Thanks for the suggestions! For the sake of sticking with Rdio's interface choices (because that's what Spotio is all about!) I'm going to keep the type set in Whitney for the future but if you'd like to try out another typeface feel free to fork this and compile your own version.

@devinhalladay Won't this lead to legal issues, as Whitney is not free?

I'm not too worried about it, if I get a DMCA I'll just switch it out for something else. But by that logic I couldn't use Museo of Dagny or Meta either; all of those require licenses


make install fails

Environment

Tesseract Version: 5.0.0
Commit Number: b0e46085f48d206797ad36ba643dbe9f12ad157a
Platform: Linux jordan-laptop 5.10.6-arch1-1 #1 SMP PREEMPT Sat, 09 Jan 2021 18:22:35 +0000 x86_64 GNU/Linux

Current Behavior:
Since commit e1b9f1b446ceaef3825934596aa63981f6a69a12, tesseract builds correctly with make but fails to install with make install. Installation works correctly when built with cmake though.
Expected Behavior:
make install works.
configure.log
make.log
make-install.log

This is fixed in commit 7c5415a2c1c10fa3be9f25763e2300732d5e72e5.

This is fixed in commit 7c5415a2c1c10fa3be9f25763e2300732d5e72e5.


Add /libraries

It would be potentially interesting to add a library oriented resource. Example:
GET /v2/libraries?normname=jquery/jquery (need to use a normalized name here to avoid name clashes (just see all color libs))
[
    {
        "normname": "jquery/jquery",
        "_id": "ey8mGL8Bp7q",
        "created": "2014-02-25T08:48:09.270Z",
        "description": "jQuery is a fast and concise JavaScript Library that simplifies HTML document traversing, event handling, animating, and Ajax interactions for rapid web development. jQuery is designed to change the way that you write JavaScript.",
        "homepage": "http://jquery.com/",
        "github": "https://github.com/jquery/jquery",
        "author": "jQuery Foundation",
        "cdns": {
            "jsdelivr": {
                "name": "jquery",
                "mainfile": "jquery.min.js",
                "zip": "jquery.zip",
                "lastversion": "2.1.0",
                "versions": [
                    "2.1.0",
                    "2.0.3",
                    "2.0.2",
                    "2.0.1",
                    "2.0.0",
                    "1.11.0",
                    "1.10.2",
                    "1.10.1",
                    "1.10.0",
                    "1.9.1",
                    "1.9.0",
                    "1.8.3",
                    "1.7",
                    "1.4.4"
                ],
                "assets": [
                    {
                        "version": "2.1.0",
                        "files": [
                            "jquery.js",
                            "jquery.min.js",
                            "jquery.min.map"
                        ]
                    },
                    ...
                ]
            },
            "cdnjs": {...},
            "google": {...}
        }
    }
]

This simply aggregates the current information in a different format. In the beginning you can see common meta (name, description etc.). CDN specific information is stored to cdns.
Possible additional benefit of the scheme is that it would allow us to aggregate libraries not available in any CDNs yet to the index.

Due to lack of bulletproof normalized names I think we can close this issue as its very hard to do.

Do you think this cannot be done well enough through some hybrid matching:
jquery.x ~~ jquery-x ~~ jquery+x

yes, we have some pretty big differences in some projects. Some are hosted only on a single CDN as well. I dont see a solution to every single problem we would have

Do you think this cannot be done well enough through some hybrid matching:

Or just use all the names in all available CDNs (array)?  Might make some projects easier to find.

What you say sounds more like a /search endpoint that allows the search through all the CDNs we have. But it wont work for the main endpoint to get a project's info.


Missing pumi function to convert from local cell index within a partition to a global cell index

In the current implementation, a point (or particle) position is identified by the index of the submesh isubmesh and by the local cell index icell within that submesh. Some PIC operations require a global cell index kcell, ordered along one of the coordinates. E.g.:
kcell = from_local_to_global_index( isubmesh, icell )

Provided new API to return global cell ID from submesh ID and local cell ID --
int pumi_global_cell_ID(pumi_mesh_t *pumi_mesh, int isubmesh, int local_cell)


net/http: TestTimeoutHandlerSuperfluousLogs flake on dragonfly-amd64

The test added in CL 200518 appears to have flaked on the dragonfly-amd64 builder (https://build.golang.org/log/dbcda17a3616121b8fc8c2efc58cb42e82a6d373):
--- FAIL: TestTimeoutHandlerSuperfluousLogs (1.04s)
    --- FAIL: TestTimeoutHandlerSuperfluousLogs/return_after_timeout (1.04s)
        serve_test.go:6336: Response mismatch
            Got
            "HTTP/1.1 404 Not Found\r\nContent-Length: 0\r\n\r\n"

            Want
            "HTTP/1.1 503 Service Unavailable\r\nContent-Length: 15\r\n\r\ntimed out here!"
FAIL
FAIL	net/http	11.471s

I suspect that the problem relates to the use of a hard-coded timeout (here), although I haven't verified that.
CC @odeke-em @bradfitz

Thanks for the file @bcmills! Sheesh how does one then test a Timeout if 2X the requested sleep time still doesn't time out? I'll send a CL skipping that test to avoid blocking the builders.

The flake rate seems low enough that a Skip probably isn't necessary at this point.
But yeah: never underestimate the slowness of builders.
(It's a corollary of the “infinite monkeys” theorem: “Infinite monkeys simulating TryBot runs will eventually produce an antagonistic schedule.”)

The flake rate seems low enough that a Skip probably isn't necessary at this point.

Cool, thanks! However, this would point to being a runtime problem if the timer for the goroutine that fires insider the handler, fires earlier than the timer of the overall handler. We should investigate that angle too.

But yeah: never underestimate the slowness of builders.
(It's a corollary of the “infinite monkeys” theorem: “Infinitely many monkeys simulating TryBot runs will eventually produce an antagonistic schedule.”)

Hehe, indeed!

if the timer for the goroutine that fires insider the handler, fires earlier than the timer of the overall handler.

Note that with goroutine preemption (#24543), it is in general possible for the two timers to fire “in order”, but for the next statement(s) after the first timer to be preempted immediately and ultimately execute after the statements immediately after the second timer. (If the two goroutines don't have a “happens-before” edge, their execution order is unspecified regardless of wall time.)

freebsd-amd64-race (https://build.golang.org/log/973f4071939084efe638fa859e6473379cdbe698):
--- FAIL: TestTimeoutHandlerSuperfluousLogs (0.55s)
    --- FAIL: TestTimeoutHandlerSuperfluousLogs/return_after_timeout (0.54s)
        serve_test.go:6338: Response mismatch
            Got
            "HTTP/1.1 404 Not Found\r\nContent-Length: 0\r\n\r\n"

            Want
            "HTTP/1.1 503 Service Unavailable\r\nContent-Length: 15\r\n\r\ntimed out here!"
FAIL
FAIL	net/http	14.330s

2019-11-10T17:12:15-40ebcfa/solaris-amd64-oraclerel
2019-11-08T20:50:17-9e914f5/aix-ppc64
2019-11-07T20:14:02-689f6f7/freebsd-amd64-race
2019-11-07T19:20:35-ceca99b/freebsd-amd64-race
2019-11-07T19:14:27-7331708/plan9-amd64-9front
2019-11-07T14:53:38-e8f01d5/plan9-amd64-9front
2019-11-06T09:09:59-0c5d545/plan9-amd64-9front
2019-11-02T19:53:12-bdb5e9d/dragonfly-amd64
2019-11-01T14:48:28-a570fcf/plan9-386-0intro
2019-10-31T20:45:40-d6f2f83/dragonfly-amd64
2019-10-31T15:14:45-02a5502/dragonfly-amd64
2019-10-31T12:02:57-5469770/solaris-amd64-oraclerel
2019-10-31T09:49:57-1085560/dragonfly-amd64
2019-10-30T03:48:03-9e094ea/plan9-amd64-9front
2019-10-29T21:21:09-70331a3/dragonfly-amd64
2019-10-29T19:10:25-1d4369f/windows-amd64-longtest

2019-11-20T04:17:59-8c51b66/freebsd-amd64-race
2019-11-20T04:17:59-8c51b66/solaris-amd64-oraclerel
2019-11-18T14:40:07-afac2c0/freebsd-amd64-race
2019-11-15T21:04:43-440f7d6/darwin-amd64-nocgo
2019-11-15T20:56:53-4160a71/freebsd-amd64-race
2019-11-14T21:33:00-fc3eae5/dragonfly-amd64-5_6
2019-11-14T17:43:48-d3c2b1f/aix-ppc64
2019-11-13T21:24:35-718f553/aix-ppc64
2019-11-12T21:27:38-2de897f/freebsd-amd64-race
2019-11-12T01:09:31-0ee22d9/freebsd-amd64-race
2019-11-11T20:17:03-eb55a0c/darwin-amd64-10_14
2019-11-11T19:56:33-0e312f2/aix-ppc64

@odeke-em, do you plan to address this yourself?

Yes, I'll work on this tomorrow morning or later tonight. Thanks for the ping @bcmills!

I think I have 2 options here:
a) Reduce the minimum sleepTime to say 100 microseconds, increase sleepTime to 200X -- would be odd if the scheduler doesn't hit us back after 200X the sleepTime
b) Use faketime which by virtue is bound to have well organized/synchronized "sleeps" and the test should always pass
Despite us just only needing to ensure that that 503 is returned after the goroutine for the timer in the TimeoutHandler expires,
a) seems like the best horse in the race as it'll properly ensure that we test with common runtimes, but b) will ensure we never get flakes but also that will require us putting the test in a special file guarded with the faketime build constraint and there currently isn't any other test that does that, so perhaps I am overreacting by looking at b).
a) it is! CL coming up shortly.

2019-11-25T19:02:50-7adafc9/freebsd-amd64-race
2019-11-25T15:08:18-01f15b6/windows-386-2008
2019-11-22T19:01:42-c931f1b/solaris-amd64-oraclerel
2019-11-22T16:04:32-1c5bd34/darwin-amd64-nocgo

Interestingly this hasn't happened since 2019-11-25.


CC-14643: Unzer configuration and payment method creation

Ticket: https://spryker.atlassian.net/browse/CC-14646

Please always remove branches after merge etc!


Feature: Add Row Click Action

Adds the ability to perform an action when a row is clicked.
Action parameter is optional.
Able to use async methods.

Rebasing turned the file diffs into nonsense. I will abandon this PR and create a new one.


Make it clear which branch of mev-geth searchers should be running

Currently it is "hidden knowledge," albeit well known, that eth_callBundle is only supported in the callBundle and awsmainnet branches. We should make it clear which branches of mev-geth searchers should run.
e.g.
https://twitter.com/BennyMEV/status/1470222551502790663

this is no longer the case correct?  as the main release now contains eth_callBundle as a valid RPC method again. So no need to make a distinction

@bertmiller we can close it as it is no longer relevant


uu-uptime finds 12 users while gnu-uptime finds only 1

Uutils finds more users than GNU, on a Linux (Gentoo) Systemd KDE single-user desktop:
$ uptime
 12:30:16 up 9 days, 17:36,  1 user,  load average: 19.95, 19.71, 13.36
$ ./target/debug/coreutils uptime
 12:30:21  up 9 days 17:36,  12 users,  load average: 19.23, 19.56, 13.35

Looking at strace, GNU seems to get the info from /run/systemd/sessions (despite /run/systemd/sessions/10 starting with This is private data. Do not parse.), while uutils opens /var/run/utmp.
FWIW, I added some debug in src/uu/uptime/src/platform/unix.rs to get the pid/user/is_user_process and I get (with "work" being my username on this system):
0 "reboot" false
9994 "" false
535036 "work" true
535074 "work" true
536408 "work" true
538194 "work" true
710842 "work" true
544777 "work" true
710988 "work" true
714806 "work" true
536385 "work" false
876606 "work" true
526168 "work" true
874586 "work" true
938703 "LOGIN" false
1014898 "work" true
1032382 "work" false

Using git main branch, 92c3de538755d69b7fa3d79030ca5dff44445809

Nice bug :)

What's the output of uptime --version? My guess is you are using uptime from procps-ng, not from GNU. At least on my machine with Arch Linux it doesn't use the GNU version and I see a similar difference. However, when I use the GNU version I get the same output as with uutils.

Ah, good catch, I'm using uptime from procps-ng 4.0.4, not GNU uptime. My distro doesn't seem to package GNU uptime, but building that from git I get the same behavior between uutils and GNU.
Closing as invalid, sorry for the noise.


Extend reference with reference key

Right now many to one relationship is handled that way: property which is a foreignKey gets type "reference" and system tries to use this propety to find relation by primeryKey. So let say we have User collection and Post collection.
Post has Property (BaseProperty) userId which is a reference set to "User". So when system populates records it knows that after fetching Posts he hast to populate userId with User  model.
But this logic doesn't handle a keys when we have a reference to a different key than a primary. So lets suppose that in our example Posts have property accountId and it is reference to User but not to User.id but to User.accountId. In current implementation handling this is not possible.
In this task we will have to make it happen
How to do this?
We simply have to return from BaseProperty#reference not a stiring but an object: {
model: // old reference
externaKey?: // when not set - it is primary key
}
Also, we will have to allow people to change that in PropertyOptions and change a way how Populator and Filter work.
Blocker: #251

unfortunately this is bigger task. We moved populator logic to the core. Now it has 2 methods for searching: findOne and findMany - both finds by primary key. In order to implement this feature we will have to allow all adapters to find by many for any particular field (not just the primary key)

I assume the only current way to get this to work currently is with a custom component that does the querying manually?
Is there any short-term plans for this to be implemented?

+1

@wojtek-krysiak any updates ?

+1


feat: add section names to problem dataset (FC-0051)

This change introduces a new model, fact_problem_responses_extended, which contains section and subsection names alongside problem results. This also includes interaction_type, which specifies the type of answer the problem accepts (e.g. multiple choice)

Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@SoryRawyer this should be good, but if you rebase you should have your checks fixed then I can thumb it

Well at least it's a legit fail now, docs coverage:
xapi.fact_problem_responses                           14/15     93.3%
xapi.int_problem_results                              13/15     86.7%

@SoryRawyer 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


feat: implement zlib module

Description of changes
Implement a portion of the Node.js zlib module (Convenience methods).
It is still rough around the edges at this point and some TODOs remain.

~Need to support more than just Brotli.~
All except unzip/unzipSync are now supported.
~Options also need to be supported as much as possible.~
For the time being, only the compression level has been addressed.
~Types/Tests/Docs also.~
All have been addressed.

Checklist

[x] Created unit tests in tests/unit and/or in Rust for my feature if needed
[x] Ran make fix to format JS and apply Clippy auto fixes
[x] Made sure my code didn't add any additional warnings: make check
[x] Added relevant type info in types/ directory
[x] Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks @richarddavison  and @Sytten , I believe I have addressed all unresolved conversations. :)


Avoid a crash in getBrOpenType() with Haxe 2 style extends syntax

Codecov Report

Merging #107 into master will increase coverage by 0.09%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage    72.5%   72.59%   +0.09%
==========================================
  Files          39       39
  Lines        3186     3186
  Branches       50       51       +1
==========================================
+ Hits         2310     2313       +3
+ Misses        843      839       -4
- Partials       33       34       +1

Impacted Files
Coverage Δ

src/tokentree/utils/TokenTreeCheckUtils.hx
50.41% <0%> (+0.41%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fef833...3922c7e. Read the comment docs.


Navbar jobs issue

When on jobs, there is an extra square item linking to jobs again (showing mouse hover):

This leads to unforgivable sizing issues:

Thanks for the report! We have a PR open (#4579) that will close this whenever it is merged.


Exception on INSERT inside loop when trying to retrieve lastID

I’m attempting to use the node-sqlite package. I need to bulk insert rows and get the autoincremented id back. It seems to work when I do one, but in a loop, it fails. Can you help with this or point me in the right direction? Thank you in advance for any help you might have to offer.
// forecastLocation.js
const sql = require('./database');
function ForecastLocation() {
}
ForecastLocation.save = async function (forecastLocations) {
try {
sql.sqlite.run('begin transaction');
for (let forecastLocation of forecastLocations) {
  let newDate = new Date();
  newDate = newDate.toISOString();
  let parameters = [forecastLocation.forecastId,
  forecastLocation.lat,
  forecastLocation.lon,
    newDate,
    newDate];

  try {
      let result = await Promise.resolve(sql.sqlite.run(insertStmt, parameters));
      console.log(result); // contains lastID
  } catch (err) {
    console.log(err);
    throw (err);
  }
}

} catch (err) {
console.log(err);
} finally {
sql.sqlite.run('end');
}
}
// database.js
"use strict"
const path = require('path');
const Promise = require('bluebird');
const sqlite = require('sqlite/legacy');
function Database() {
}
Database.open = function() {
let filePath = path.join(__dirname, "../../../");
filePath = path.join(filePath, "resources/db/database-dev.sqlite");
return sqlite.open(filePath, { Promise });
}
Database.close = function() {
sqlite.close();
}
module.exports = {Database, sqlite};
// stack trace
Registered protocol succesfully
3277
://eca/
Statement {
stmt:
Statement {
sql: 'INSERT INTO ForecastLocations (forecastId, lat, lon, createdAt, updatedAt) VALUES (?,?,?,?,?)',
lastID: 1,
changes: 1 },
Promise:
{ [Function: Promise]
TypeError: [Function: TypeError],
RangeError: [Function: RangeError],
CancellationError: [Function: SubError],
TimeoutError: [Function: SubError],
OperationalError: [Function: OperationalError],
RejectionError: [Function: OperationalError],
AggregateError: [Function: SubError],
_peekContext: [Function],
onPossiblyUnhandledRejection: [Function],
onUnhandledRejectionHandled: [Function],
longStackTraces: [Function],
hasLongStackTraces: [Function],
config: [Function],
getNewLibraryCopy: [Function],
is: [Function],
fromCallback: [Function],
fromNode: [Function],
all: [Function],
cast: [Function],
fulfilled: [Function],
resolve: [Function],
rejected: [Function],
reject: [Function],
setScheduler: [Function],
pending: [Function],
defer: [Function],
method: [Function],
try: [Function],
attempt: [Function],
bind: [Function],
PromiseInspection: [Function: PromiseInspection],
join: [Function],
Promise: [Circular],
version: '3.5.0',
map: [Function],
using: [Function],
delay: [Function],
coroutine: { [Function] addYieldHandler: [Function] },
spawn: [Function],
promisify: [Function],
promisifyAll: [Function],
props: [Function],
race: [Function],
reduce: [Function],
settle: [Function],
some: [Function],
_SomePromiseArray: [Function: SomePromiseArray],
filter: [Function],
each: [Function],
mapSeries: [Function: PromiseMapSeries],
any: [Function],
noConflict: [Function: noConflict] } }
TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined
at Function._callee2$ (C:/git/onboard/onboard/electron-out/project/ember-electron/main/api/models/forecastLocation.j
s:68:7)
at tryCatch (C:\git\onboard\onboard\node_modules\regenerator-runtime\runtime.js:65:40)
at Generator.invoke [as _invoke] (C:\git\onboard\onboard\node_modules\regenerator-runtime\runtime.js:303:22)
at Generator.prototype.(anonymous function) [as next] (C:\git\onboard\onboard\node_modules\regenerator-runtime\runti
me.js:117:21)
at tryCatch (C:\git\onboard\onboard\node_modules\regenerator-runtime\runtime.js:65:40)
at invoke (C:\git\onboard\onboard\node_modules\regenerator-runtime\runtime.js:155:20)
at C:\git\onboard\onboard\node_modules\regenerator-runtime\runtime.js:165:13
(node:3052) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: forecast.getFore
castLocations is not a function
(node:3052) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are
not handled will terminate the Node.js process with a non-zero exit code.

I realize that i was killing myself using a foreach type loop instead of a regular for. Solved.


Updated

/lgtm @barkatul maintain the streak

I'll try to make sure that it won't break
On Thu, 17 Feb 2022 at 00:19, Anurag @.***> wrote:

Merged #251 https://github.com/saiyam1814/DevOpsRoadmap2022/pull/251
into main.
—
Reply to this email directly, view it on GitHub
https://github.com/saiyam1814/DevOpsRoadmap2022/pull/251#event-6085052345,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWMMGPZMS53OTNQMZKUYRKLU3PWR7ANCNFSM5OSNZWIQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>


Updates for validation

Summary
Update the qpp_qicore.yaml file to pass qicore validation
New behavior
Generated synthea files pass validation (with a few potential exceptions).
Code changes

Adds or updates flexporter instructions for DeviceRequest, AdverseEvent, and Task

Testing guidance

Create large set of patients using qpp mapping file from https://github.com/projecttacoma/bulk-export-server/pull/52
a.	Use the randomcode_updates branch or main if https://github.com/synthetichealth/synthea/pull/1527 has been merged
b.	Follow additional instructions from the bulk PR above
c.	Set exporter.fhir.us_core_version = 3.1.1 in the synthea.properties file
d.	Use -p to specify the number of patients, i.e. ./run_synthea -fm ../../bulk-export-server/synthea/qpp_qicore.yaml -p 10

Use HAPI FHIR validator to validate the patients.
a.	Use https://github.com/hapifhir/org.hl7.fhir.validator-wrapper/releases/latest/download/validator_cli.jar
b.	Run with java -jar validator_cli.jar synthea/output/fhir/ -ig http://hl7.org/fhir/us/qicore/ImplementationGuide/hl7.fhir.us.qicore|4.1.1 -extension any -display-issues-are-warnings -sct us

Most issues are solved by the settings above, but some remaining issues that don’t effect calculation may include:
i.	"Unknown code 'X9999-"* from the loinc code set

One question:

When I ran the validator, it looks like I got errors with .recorded attributes on Procedure and Immunization resources? Is this expected?

Two suggestions:

I think the -ig parameter in the PR description is wrong- I think it should be -ig hl7.fhir.us.qicore#4.1.1. Not a huge deal, but I mention this because maybe some super quick validator instructions could be added to the synthea/README.md here! Not totally necessary but may be useful info in the future.
IF you end up adding something brief to the README, I would add the -html-output parameter. This is something I found in the Validator docs here and made my life a lot easier. I actually think you probably used this input, it just wasn't reflected in the description.

Update:

No longer get that error! I needed to run the following command: java -jar validator_cli.jar synthea/output/fhir/ -ig http://hl7.org/fhir/us/qicore/ImplementationGuide/hl7.fhir.us.qicore%7C4.1.1 -extension any -display-issues-are-warnings -sct us -html-output output.html -version 4.0.1 (Need the http url, not hl7.fhir.us.qicore#4.1.1 AND -version 4.0.1)
I would still add something to the README so that we can keep track of the -ig, -version, -html-output, and clear-tx-cache inputs.


Textarea width bug in chrome

I have found a bug in chrome with the textarea. When using the textarea with the class .materialize-textarea
When scaling the browser window down from desktop to mobile the textarea overflows on the right making lots of white space. I cannot see this overflow in dev tools however I think it is down to the javascript used on the textarea.
If you reload the page when in mobile view the issue is gone, this only happens when scaling down from a larger screen.
If I copy all the css classes to my own class and remove the materialize-textarea class the bug is fixed however the javascript is now not running on the textarea so it doesn't change its height when entering a new line. Im thinking the bug could be something to do with the javascript?

@jojodadj can you link to your project and or build a codepen showing the issue? The bug you are describing does not happen with the materialize docs page so it suggest there is an error in your code. Did you use the exact markup from the docs?

Textarea

https://materializecss.com/text-inputs.html#textarea
Also, are you dynamically updating the contents of the text area?

advanced note: When dynamically changing the value of a textarea with methods like jQuery's .val(), you must trigger an autoresize on it afterwords because .val() does not automatically trigger the events we've binded to the textarea.

I have just tested in code pen and it works as it should however I have attached here a basic HTML file, if you open this in chrome and then resize the window you will see it does not resize correctly. If you refresh the page once in mobile view it will then work.
If you then comment out the Materialize script tag the window then resizes fine.
test.html.zip

It works fine.  I've attached your html file with the materialize.js uncommented, and it works just as it should. If you can't replicate in a codepen then the issue is coming from somewhere else.
test.html 2.zip

This turns out it is a bug in Chrome for Mac, at the end of the day this is a bug that I found while using Materialize and could reproduce it in my own environment. If anything someone else who is having this issue will find this post and hopefully the next version of chrome will fix this.


update version. Redesign all interface. Now you can switch process, e…

…ngine freely.

Coverage decreased (-5.02%) to 89.429% when pulling a017602c0229dbf96af5677e027bc499177cab5a on yerikzheng:master into ef3a3c33d413056bc57daf8b00c9298a35c7dc14 on arraystream:master.


Bugfixes

Codecov Report

Merging #101 (7dab17f) into main (1e66336) will decrease coverage by 0.21%.
The diff coverage is 79.16%.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   83.79%   83.57%   -0.22%
==========================================
  Files          80       80
  Lines        3029     3038       +9
  Branches      483      484       +1
==========================================
+ Hits         2538     2539       +1
- Misses        388      398      +10
+ Partials      103      101       -2

Impacted Files
Coverage Δ

app/services/messages.py
85.71% <ø> (-2.65%)
:arrow_down:

app/helpers/cloudflare.py
23.63% <25.00%> (+0.10%)
:arrow_up:

app/services/crud.py
91.39% <88.88%> (+0.48%)
:arrow_up:

app/exceptions.py
92.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e66336...7dab17f. Read the comment docs.


adding tests

adding tests to org.symphonyoss.client.events

Sorry for the delay in responding, but there seems to be many updates to the code here I will need to review before accepting and potentially some commercial understanding on diffblue.
This software underpins many financial services bots in the market, so we are trying to make sure there are no impacts around these changes.
With that said, I'm really excited to have new contributors... hope to review shortly.

not a problem. the pull checks still show as not successful. is that because it doesn't refresh the checks?

@ftbb just confirming that @dayoaws does indeed have a CLA with the Foundation, and you should ignore the fact that the verification/cla-signed check above is failing.
cc @copiesofcopies

Hi, I know this is very old. Is there any way to get a new release on this?


[Legacy] Build Error (branch: master)

https://ci.dot.net/job/Microsoft_ChakraCore/job/master/job/daily_dev12_x64_debug/
D:\j\workspace\daily_dev12_x---55cdd258\lib\Jsrt\JsrtHelper.cpp(7): error C2220: warning treated as error - no 'object' file generated [D:\j\workspace\daily_dev12_x---55cdd258\lib\Jsrt\Chakra.Jsrt.vcxproj]
10:57:32 D:\j\workspace\daily_dev12_x---55cdd258\lib\Jsrt\JsrtHelper.cpp(7): warning C4627: '#include <pthread.h>': skipped when looking for precompiled header use [D:\j\workspace\daily_dev12_x---55cdd258\lib\Jsrt\Chakra.Jsrt.vcxproj]
10:57:32           Add directive to 'JsrtPch.h' or rebuild precompiled header

Broken since build 35
https://ci.dot.net/job/Microsoft_ChakraCore/job/master/job/daily_dev12_x64_debug/changes
35 (Dec 22, 2016 10:57:07 AM)

android: ChakraCore compiles to Android ARMv7 (commit: 6811584) — ogbastem / githubweb
silence failures for connecting to jit process (commit: 1f87d7e) — Michael Holman / githubweb
Resolves #1896. Modified Array.prototype.toLocaleString to use the (commit: 1410874) — akatti / githubweb
AutoRestoreFunctionInfo does not handle throw during initialization (commit: 34f70cd) — Tom Care / githubweb
Update Jsrt Utf8 types and naming (commit: adbea39) — ogbastem / githubweb

@obastemur @MikeHolman @atulkatti @tcare

:rofl:  I tried to build a master branch today; hit the very same issue. Switched the header order to
#include "JsrtPch.h"
#if !defined(_WIN32)
#include <pthread.h>
#endif

to only find out afterwards that there is already a PR for this issue. Dang!

Fixed by #2320


Allow Ajax verification BEFORE a second after POST verification

Users were unable to type in the catpcha, so I added an ajax feature to validate it after they type it (securimage didnt support this) So I just added a $noclear parameter so that it wouldn't clear the session or database while validating
->check($mycaptcha, true);   //will not clear the session or database and allow submitting afterwards

I am way late on this because adding this option isn't necessary.  The ajax example form shows how to do Ajax validation, or if not possible to validate the captcha in your Ajax form processor, you should set a session variable in the captcha ajax request telling your application the validation was successful and then check that in your form processor.
These methods are better than modifying the check function for an edge case in my opinion.


Definition Location in Azure Policy?

Whats the need for Definition Location on the policys definition (and on Initiative policys) and why can't you change it afterawards?
For me, trying to see if this is a fit for our compliance framework, across all our subscriptions ( about 200 subsciriptions). As I see it now (since there is cloning inbetween subscriptions) you would manually need to re-create each custom policy you've created, and every initiative policy for each service on all of our subscriptions? Imagine the time this will take...
https://docs.microsoft.com/en-us/azure/azure-policy/create-manage-policy

@NiklasJern Thanks for the feedback! We are currently investigating and will update you shortly.

Hi again guys,
figured out that you could probably work around this if you utlize Management Groups. :)
I still think however it would be a great idea if you could re-assigne policyies inbetween subscriptions and not lock them down :)

#in-process
Looking into this with the engineering team.

@NiklasJern Definition Location defines where the policy or initiative definition is stored. For now, when set, you cannot change it for performance and RBAC reasons. You noted inheritance of policy definitions from Management Groups to allow assignment across subscriptions--that's in development.  The Azure Policy team is working on adding functionality to easily export/ duplicate the policy definitions to make the process more streamlined.

#please-close

We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Fix mixed lineendings issue for webpack compiled assets

Fix mixed lineendings issue for webpack compiled assets and ignore map files in build file

@ravichdev Looks good to me


(#11417) Add EL 6 resource to configure pe-ruby-devel

The whole point of this work and this module is for me to easily get
pe-ruby-devel on the PE system I'm developing on in order to build the
jenkins.rb gem for use with Puppet Enterprise.
To reach this goal, this patch does a number of things.  First, it
manages basic "build essentials" on my CentOS 6.1 system.  gcc, make,
glibc-devel, curl, wget, etc...
Next, the module manages the epel-release package so that we have
additional 3rd party packages available to us.
In the same vein, the module manages
/etc/yum.repos.d/puppetenterprise.repo  This is where Mike might flip
his lid, but I can't wait for him to write this module.  I've configured
the module to use a base URL of
http://links.puppetlabs.com/puppet-enterprise which for the moment uses
a 302 redirect to faro.puppetlabs.lan.  This works great with curl -L
and yum.  In the future we can simply update the link to point to
something public if we choose to do so.
For the time being this module will be BROKEN for anyone who is not
inside the Puppet Labs local area network.  =(
Once the repository is configured, the module uses a normal package
resource to manage pe-ruby-devel which is the whole point of this
effort.
It works:
notice: /Stage[main]/Pe_devel::Redhat/Package[pe-ruby-devel]/ensure:
created

Spec tests are included with this patch to validate the desired behavior
described in the ticket:
% rake spec
(in /Users/jeff/vms/puppet/modules/pe_devel)

pe_devel
  should create Class[pe_devel]
  on redhat el6 os families
    should create Class[pe_devel::redhat]
    should create Package[gcc]
    should create Package[wget]
    should create Package[curl]
    should create Package[glibc-devel]
    should create Package[pe-ruby-devel]
  on debian os families
    should create Notify[pe_devel unimplemented]
    should not create Class[pe_devel::redhat]

Finished in 0.64855 seconds
9 examples, 0 failures

Just amended the README to document how to build the puppet module from source.

running 'rake build' gives no output if the command is not found

puppet apply -e 'include pe_devel'
Failed to parse template pe_devel/puppetenterprise.repo.erb: Could not find value for 'lsbmajdistrelease' at 5:/etc/puppetlabs/puppet/modules/pe_devel/templates/puppetenterprise.repo.erb at /etc/puppetlabs/puppet/modules/pe_devel/manifests/init.pp:108 on node master.vagrant.internal
facter output:
architecture => x86_64
augeasversion => 0.7.2
domain => vagrant.internal
facterversion => 1.6.2
fqdn => master.vagrant.internal
hardwareisa => x86_64
hardwaremodel => x86_64
hostname => master
id => root
interfaces => eth0,eth1,lo
ipaddress => <IP_ADDRESS>
ipaddress_eth0 => <IP_ADDRESS>
ipaddress_eth1 => <IP_ADDRESS>
ipaddress_lo => <IP_ADDRESS>
is_virtual => false
kernel => Linux
kernelmajversion => 2.6
kernelrelease => 2.6.32-71.el6.x86_64
kernelversion => 2.6.32
macaddress => 08:00:27:E7:71:D2
macaddress_eth0 => 08:00:27:E7:71:D2
macaddress_eth1 => 08:00:27:99:0B:B9
memoryfree => 105.56 MB
memorysize => 491.56 MB
netmask => <IP_ADDRESS>
netmask_eth0 => <IP_ADDRESS>
netmask_eth1 => <IP_ADDRESS>
netmask_lo => <IP_ADDRESS>
network_eth0 => <IP_ADDRESS>
network_eth1 => <IP_ADDRESS>
network_lo => <IP_ADDRESS>
operatingsystem => CentOS
operatingsystemrelease => 6.0
osfamily => RedHat
path => /usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin:/root/bin
physicalprocessorcount => 1
processor0 => Intel(R) Core(TM) i7-2635QM CPU @ 2.00GHz
processorcount => 1
ps => ps -ef
puppetversion => 2.7.6 (Puppet Enterprise 2.0.0)
rubysitedir => /opt/puppet/lib/ruby/site_ruby/1.8
rubyversion => 1.8.7
selinux => false
sshdsakey => AAAAB3NzaC1kc3MAAACBAJUUUAaBRV4ccAG7hYAhY0pcCJVYq0uVtNsRIhj3VUaxbk2YRoqE1pqM4KmmZbzV7FIqvjz9DhJ0KP6tkTTe5cPg8Hw9s+ZJE1uXXe0UNnPnQfFBs8aC2kz3EkNOCIi/GmEf92aJhO9XTmjWcwyW//sH6bu/jxEcGA81sh15EWV7AAAAFQDr/7tOYCF0IeqKbFL04jWQtID7jQAAAIEAjXEP7Yk/O94ZdOLl4J0YgY5y8B1BMWuzFHS+kjoP72Ng9wYN0VNPS723WeyYPv/XLjgicVfDbiEw19kCifGCkY9NlI0opbJMRmCApaEOBHef8/rymngkl0oDoBoLdRuLd7WA7I4CybZOSO6wNmsQaOpyGMjLnnJs193df4kshisAAACAbsdL+UFze1KC+XG6P57D9q1owQDsrNms7cYyg+XeiXsPbeuocmJ20VV1/XhCeKBcq++mVZUH4k/WWk0mU1r+KD3OnAm0IFhM8aWKbdJojcxk1qHTupZfjmuD2d9e9ipnR0pK1OBO+obWdeOhIc4vPrhxfVpqNrGSDCMw7fisPMo=
sshrsakey => AAAAB3NzaC1yc2EAAAABIwAAAQEAz2quSd+GRd8wp5NVD4gVS03gSbITBMPMbJ+KdLZX/MAqZj6G5RgcnGg2BhRrOQn0wY2uicUKp5W86bSmnnfjOCDn4pMCzABHet0/zo1vwBtjz9HkMa+kqPTuLQ9rQvM+ffAceIlDI7TyBOOKYvZ20QJ6enYeOtyqaNv2kDGLUjaBQXo9YoPzDBd/5jYUkz/Ia7K0eBDJG0xlrJpNb6qR5pd2xkipvTsr3MQg+lLPrX6pMek95bR0qUyrfChen79DequSxgOtjUnggdRqR7pAc65C+kqUP1safq6OANFLgBSHWA4oubwBoFHMRCN+1RjDHprPf2G6kdQb6B1P2nOE4Q==
swapfree => 674.73 MB
swapsize => 991.99 MB
timezone => CET
uniqueid => 007f0100
uptime => 0:56 hours
uptime_days => 0
uptime_hours => 0
uptime_seconds => 3412
virtual => physical

[root@master modules]# FACTER_lsbmajdistrelease=6 puppet apply -e 'include pe_devel'
notice: /Stage[main]/Pe_devel::Redhat/Package[epel-release]/ensure: created
notice: /Stage[main]/Pe_devel::Redhat/File[puppetenterprise.repo]/ensure: defined content as '{md5}91cd2ca7a148e2338b79797963b83d94'
err: /Stage[main]/Pe_devel::Redhat/Package[createrepo]/ensure: change from absent to latest failed: Could not update: Execution of '/usr/bin/yum -d 0 -e 0 -y install createrepo' returned 1: Error: Cannot retrieve repository metadata (repomd.xml) for repository: pe_base. Please verify its path and try again
 at /etc/puppetlabs/puppet/modules/pe_devel/manifests/init.pp:125
err: /Stage[main]/Pe_devel::Redhat/Package[glibc-devel]/ensure: change from 2.12-1.7.el6_0.5 to 2.12-1.25.el6_1.3 failed: Could not update: Execution of '/usr/bin/yum -d 0 -e 0 -y install glibc-devel' returned 1: Error: Cannot retrieve repository metadata (repomd.xml) for repository: pe_base. Please verify its path and try again
 at /etc/puppetlabs/puppet/modules/pe_devel/manifests/init.pp:124
err: /Stage[main]/Pe_devel::Redhat/Package[wget]/ensure: change from absent to latest failed: Could not update: Execution of '/usr/bin/yum -d 0 -e 0 -y install wget' returned 1: Error: Cannot retrieve repository metadata (repomd.xml) for repository: pe_base. Please verify its path and try again
 at /etc/puppetlabs/puppet/modules/pe_devel/manifests/init.pp:121
err: /Stage[main]/Pe_devel::Redhat/Package[gcc]/ensure: change from 4.4.4-13.el6 to 4.4.5-6.el6 failed: Could not update: Execution of '/usr/bin/yum -d 0 -e 0 -y install gcc' returned 1: Error: Cannot retrieve repository metadata (repomd.xml) for repository: pe_base. Please verify its path and try again
 at /etc/puppetlabs/puppet/modules/pe_devel/manifests/init.pp:122
err: /Stage[main]/Pe_devel::Redhat/Package[curl]/ensure: change from 7.19.7-16.el6 to 7.19.7-26.el6_1.2 failed: Could not update: Execution of '/usr/bin/yum -d 0 -e 0 -y install curl' returned 1: Error: Cannot retrieve repository metadata (repomd.xml) for repository: pe_base. Please verify its path and try again
 at /etc/puppetlabs/puppet/modules/pe_devel/manifests/init.pp:120
err: /Stage[main]/Pe_devel::Redhat/Package[pe-ruby-devel]/ensure: change from absent to latest failed: Could not update: Execution of '/usr/bin/yum -d 0 -e 0 -y install pe-ruby-devel' returned 1: Error: Cannot retrieve repository metadata (repomd.xml) for repository: pe_base. Please verify its path and try again
 at /etc/puppetlabs/puppet/modules/pe_devel/manifests/init.pp:127
notice: /Stage[main]/Pe_devel/Anchor[pe_devel::end]: Dependency Package[createrepo] has failures: true
notice: /Stage[main]/Pe_devel/Anchor[pe_devel::end]: Dependency Package[gcc] has failures: true
notice: /Stage[main]/Pe_devel/Anchor[pe_devel::end]: Dependency Package[wget] has failures: true
notice: /Stage[main]/Pe_devel/Anchor[pe_devel::end]: Dependency Package[glibc-devel] has failures: true
notice: /Stage[main]/Pe_devel/Anchor[pe_devel::end]: Dependency Package[curl] has failures: true
notice: /Stage[main]/Pe_devel/Anchor[pe_devel::end]: Dependency Package[pe-ruby-devel] has failures: true
warning: /Stage[main]/Pe_devel/Anchor[pe_devel::end]: Skipping because of failed dependencies
notice: Finished catalog run in 43.10 seconds


fix: props is initialized but never used

The props variable which holds the authentication tokens from the external provider, is initialized in line 247 but never actually used. Changed line 269 to use it.
Fixes #26651

Replaced by (more correct) #26659


django.template.context_processors.request not listed amongst context_processors?

Since I am new to Django, I'm uncertain whether not listing django.template.context_processors.request amongst context_processors in settings/base.py is intentional or not, but I was trying to get referrer redirect working using request.path inside a template and couldn't figure out why this was null until I stumbled across the requirement for this include.
Regards.

Thanks for pointing this out. It was intentional. This was not included by default until Django 1.7 as mentioned in the docs.
But it is included by default in 1.8. I shall mark this as a bug.


Expose runner type

Hello,
First of all, thanks for your awesome work!
I'd like to ask whether you have any plans about exposing the runner type, defined in runner.go.
As of now, there is a single instance of it, called defaultRunner, which can be controlled by passing flags during command startup, e.g.
example -maxRPS=10 -master-host=<IP_ADDRESS>

I find this to be limiting, becasue

it ties me to use the Go's standard library flag package
it is not possible to control any of the options programatically
it is not possible to change any of the internal dependencies of the runner, e.g. the used logger

Please do let me know if you need any additional details.
Thanks,
Ivan

Yep, I'm working on exposing a Boomer type, then you can create an instance of Boomer instead of using the default one.
See: https://github.com/myzhan/boomer/issues/54

Thanks for the quick response. I’m willing to help so please let me know if there’s something that I could do or test.

It's a huge commit, I'm try to keep backward compatibility. Please test it and send feedback :D

Thanks, will do tomorrow or the day after tomorrow. It looks great at first glance.

Sorry for the delay, I can confirm that the change is OK. Thanks.


Adopt -Osize

Saves a vital 15 bytes

This brings the perf in Conways game of life down from ~30fps (matching C) to ~23fps. As a result many initial users of this library thought swift was inherently slower, which makes me hesitant to add it back (given the saving are trivial)


Unknown endpoint was collected

[ o] I have checked the FAQ, and issues and found no answer.

unrelated endpoint(binance server) was collected by pinpoint-collector

is It possible to collect totally different server endpoints?

endpoint is collected by getServerName(), so this data is correct.
https://github.com/pinpoint-apm/pinpoint/blob/master/plugins/common-servlet/src/main/java/com/navercorp/pinpoint/plugin/common/servlet/util/HttpServletRequestAdaptor.java#L74
@Override
    public String getEndPoint(HttpServletRequest request) {
        String serverName = request.getServerName();
        int serverPort = request.getServerPort();
        return HostAndPort.toHostAndPortString(serverName, serverPort);
    }


The font color on the onfido flow is off

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @coleaeason
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726084405673789
Action Performed:

Complete the connect bank account flow till the onfido page from workspace

Expected Result:
No visual issues
Actual Result:
Onfido logo and Onfido added text are difficult to read
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

closing this issue until the thread is finalized - it looks like this may not be something we can action


Please add i686 iso with Openbox

Please add a community build for i686 and Raspberry with a minimal GUI like Openbox for older hardware

Anything i686 is very unlikely to happen. I do see the benefit of something like this and like to tinker with older hardware myself. In fact, I voted against GhostBSD dropping the i386 platform when that issue was discussed within the team. But there are valid reasons that lead to the opposite stance and I'm standing by the team decision: GhostBSD focuses more than ever on the incredibly useful features that ZFS provides (and the general consensus is: Don't uses ZFS on 32-bit platforms). Other than that, modern GhostBSD is built from TrueOS and the latter has dropped i386 support long ago when it even was a Qt-based desktop spin of FreeBSD under the name of PC-BSD. There literally isn't any support for i386 in the whole TrueOS infrastructure.
For the Raspberry Pi 3 and 4 there might be hope as arm64 (a.k.a aarch64) is a platform that some of the TrueOS devs seem to have interest in. So GhostBSD on newer Raspberrys might eventually happen.
I've been on hiatus for a while now and thus don't know the recent decisions. But there have been ideas of continuing a different spin of GhostBSD not based on TrueOS but on vanilla FreeBSD. That could run on i386 platforms (but would of course not feature things like the OpenRC init system that's part of TrueOS - at least until FreeBSD makes a final decision on including it). Also it would be entirely unsupported as we don't have enough people running it seriously on that platform to even test it properly. The problem here is manpower: Somebody would have to step forward to do it. So if somebody reads this and thinks it's a good idea, go for it! Things like this are a great chance to learn things, BSD people in general (and the GhostBSD developers specifically) are nice and open - as time permits of course.


⚠ K-Thorne has degraded performance

In 815cacc, K-Thorne (https://k-thorne.com) experienced degraded performance:

HTTP code: 200
Response time: 11714 ms

Resolved: K-Thorne performance has improved in 7738f03.


Zulrah Helper Venom Clouds - When do they appear?

I love the zulrah helper plugin!  The fact that they are a sequence of images that simply require user input makes it so beginners have to acknowledge what phase they are on which helps them learn, and makes it easier for programming too since there is no checking the zulrah phases directly (is that even possible?).
My biggest issue is knowing when to run to the next position for the upcoming zulrah phase. The more I fight zulrah, the more I get a grasp for how long each phase is, so I typically run just before zulrah ends its phase or as zulrah ends depending on how far I have to run. This works really well most of the time, especially when zulrah spits out its venom clouds at the beginning of a phase, but sometimes it shoots venom clouds at the end of the phase which forces me to take damage as I run through them to the next position.
I guess what I'm looking for is some indicator for the phase of when venom clouds will appear - whether at the beginning/end of a phase or even at all. There seems to be a lot of empty space at the top of the images for this information. I would also suggest making that information easy to register/decipher to the user at a quick glance as they are busy fighting zulrah and it wouldn't be good if they spent too much time looking at the plugin. It could also be togglable in the settings of whether or not the user might want to see this information? That's just my first brute force thought; maybe there's a better way.

Oh sorry, I didn't mean to imply using game state to help, or doing anything that notifies the user when venom clouds appear, or anything in-game like that. That question about the game state thing was just a curiosity, but wasn't part of my actual question. I should have just been concise.
My question was to simply add a symbol to the images on the plugin pane that signifies whether venom clouds exist in the phase or not. After looking at where jagex draws the line for plugins, I guess it would be too much to ask for the symbol to indicate whether it exists at the beginning or ending of a phase on the plugin pane images, but I don't see an issue with venom clouds exist in a phase or not. Just having that information should be enough for me to learn zulrah better.
If it's still not allowed or don't even want to implement it, I understand. I just didn't want to let the suggestion be turned down on a misunderstanding by either of us. Really love the plugin! :)

Ahh! I see.
To be honest, I haven't played runescape in a few months now.. But if someone is willing to edit the pictures in https://github.com/while-loop/runelite-plugins/tree/zulrah-helper/src/main/resources/phases I'd be more than glad to update the plugin!!
Let me know if this is something you or someone would like to do :)

I'll work on it right now :)
I'll post here again when I'm finished

Ok, I have finished. The images that I added venom clouds are separate images from the original for more flexibility. These images simply have "-venom" added to the end of their file names. This allows venom clouds to be togglable in the settings if you ever want to add that feature. I'm not sure what is needed for this, but I used the venom cloud image from https://www.osrsguide.com/osrs-zulrah-guide/ and scaled it down. After some research, I have added venom clouds to (including the dark versions):

start 1
magma_a 1
magma_a 4
magma_a 7
magma_a 8
magma_a 9
magma_b 1
magma_b 4
magma_b 5
magma_b 8
magma_b 9
normal 1
normal 3
normal 7
normal 9
tanz 1
tanz 3
tanz 5
tanz 7
tanz 10

I'm not sure how you want me to send these images to you, but hopefully it works well. Feel free to change any of this, as it is your plugin obviously.

That's awesome! And even better for making it toggl- able.
A link to the imagines are fine!

magma_a-8-dark-venom

magma_a-8-venom

magma_a-9-dark-venom

magma_a-9-venom

magma_b-1-dark-venom

magma_b-1-venom

magma_b-4-dark-venom

magma_b-4-venom

magma_b-5-dark-venom

magma_b-5-venom

magma_b-8-dark-venom

magma_b-8-venom

magma_b-9-dark-venom

magma_b-9-venom

normal-1-dark-venom

normal-1-venom

normal-3-dark-venom

normal-3-venom

normal-7-dark-venom

normal-7-venom

normal-9-dark-venom

normal-9-venom

start-1-dark-venom

start-1-venom

tanz-1-dark-venom

tanz-1-venom

tanz-3-dark-venom

tanz-3-venom

tanz-5-dark-venom

tanz-5-venom

tanz-7-dark-venom

tanz-7-venom

tanz-10-dark-venom

tanz-10-venom

venom-clouds-zulrah-100x97

magma_a-1-dark-venom

magma_a-1-venom

magma_a-4-dark-venom

magma_a-4-venom

magma_a-7-dark-venom

magma_a-7-venom


Develop

I made a few simple changes while reviewing the code.  These won't conflict with Michael's changes.

Let's put this all on one branch for now, rather than futz with separate development lines here.
I don't think I can edit the PR to PR into his branch instead.


Member-wise constructor generation with visibility control

Rebased version of PR #4854.

Just try to run the CI now to see everything is fine after rebase.


feat: allow override for gitgraphjs options

#173  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nadilas and the rest of your teammates on  Graphite


Runtime error in Detic web demo on Huggingface Spaces

As per the title.
Additionally, the Detic demo on Google Colab, cel 1, yields the following error:
"ERROR: Could not find a version that satisfies the requirement detectron2 (from versions: none)
ERROR: No matching distribution found for detectron2"
Please advise. Much thanks in advance.

Thank you for raising the issue. I have submitted a pull request to Huggingface for fixing. I also updated the Colab demo for installing detectron2 manually.


Updated tests for 4.2

Updated the tests for task 4.2

pls go with testnames following the nameconvention test_whatIsTested

Done :D


Fix test_files_api_read_twice_from_one_download

Changes
This integration test is failing (and likely wasn't passing when I merged the original PR). This PR fixes it by unifying the codepaths for __enter__ and read to call _open, which consistently will check if the response is closed and throw an exception if so.
Tests

[ ] make test run locally
[ ] make fmt applied
[ ] relevant integration tests applied

Codecov Report
Patch coverage is 85.71% of modified lines.

Files Changed
Coverage

databricks/sdk/core.py
85.71%

:loudspeaker: Thoughts on this report? Let us know!.


Bubble Sort

Write ruby code for bubble sort.

hello, i would like to work on this issue.
could you assign this issue to me?

@astitva0011
Assigned.


Specify naming constraints for SQLAlchemy so that alembic just works

Without this, Alembic doesn't generate names in a way that allows both
the upgrade and downgrade paths to work without manual changes.
This specifies naming constraints that match what SQLAlchemy has
used up until now.
This fixes the issue in #67 that meant that that migration couldn't be run backwards.
@xybrnet

:+1:


First open iterm2 has open two windows via shuttle

When i first oepn(there is no iterm2 started) iterm2 via shuttle, it's open two iterm2 windows, and look like that:

.shuttle.json:

  "editor": "default",
  "launch_at_login": true,
  "terminal": "iTerm",
  "iTerm_version": "nightly",
  "default_theme": "basic",
  "open_in": "tab",
  "show_ssh_config_hosts": false,
  "ssh_config_ignore_hosts": [  ],
  "ssh_config_ignore_keywords": [  ],

mac os: mojave
iterm2 versions: 3.2.3

I just want open one windows via shuttle every time
I need your help, Thanks

Thanks for reporting. This should be fixed in the next release.


drainRebalancedActors is mispelled in places

In what area(s)?

/area test-and-release
What version of Dapr?

0.5
Locations:
tests\apps\actorapp\app.go:30:  drainBalancedActors     = true
tests\apps\actorapp\app.go:52:  DrainBalancedActors     bool     json:"drainBalancedActors,omitempty"
tests\apps\actorapp\app.go:60:  drainBalancedActors,
tests\apps\actorfeatures\app.go:31:     drainBalancedActors     = true
tests\apps\actorfeatures\app.go:55:     DrainBalancedActors     bool     json:"drainBalancedActors,omitempty"
tests\apps\actorfeatures\app.go:63:     drainBalancedActors,

I would love to start contributing to Dapr 🙂 This seems to be a good issue to start with, I've raised a PR: #1426.


Fix transmission test cases

addressing the case that the records are less than the limit
Signed-off-by: Ginny Guan<EMAIL_ADDRESS>

close this PR and open another one