Proposal for Exact criterion

Prior Art
Algolia explains the Exact criterion like:

Records with words that match query terms exactly are ranked higher. The more matching words in a record’s attribute, the higher a record is ranked. By default, an exact match occurs when a full word in a query is matched without typos to a word in an attribute. An inexact match is one that has typos or only matches on a prefix.

Additionally, synonym matching and plural/singular matching are considered exact. Thus, a word is considered an exact match if its synonym matches a query exactly.

Adding some exceptions:

[...] single-word matches on multi-word attributes aren’t considered exact matches by default [...]
[...] Multiword synonyms are not counted as exact matches by default [...]

Brief
for each word of the query we match documents:

without typo
without prefix
without ngrams
without complex synonyms
without word split

if the query only contains 1 word, only 1-word attributes can match.
Pro & Con
This behavior of the Exact criterion gives a better rank to documents that match the words of the original query, ranking ngrams, complex synonyms, and word split after.
But the exception if the query only contains 1 word, only 1-word attributes can match will only boost documents that have an attribute that exactly contains the query word and that's all. No boost on non complex synonyms, and non word split.
Useful when an ID is searched but in others cases, it could impact the relevancy.
Moreover, when we a multi-words query, attributes that exactly contains the query are not boosted.
At last, because meilisearch is a search as you type engine, attributes that exactly begin by the original query could be boosted.
Possible Behavior in milli
we could divide Exact into several layers of ranking:
1: Try to match exactly the query in an attribute
Any document that has an attribute that contains exactly the query:

without typo
without prefix
without ngrams
without complex synonyms
without word split
with words in the right order

has a rank of 0 (perfect match)
2: Try to match exactly the query at the start of an attribute
Any document that has an attribute that contains the query at the n firsts positions:

without typo
without prefix
without ngrams
without complex synonyms
without word split
with words in the right order

OR
Any document that has an attribute that contains exactly the query:

without typo
without ngrams
without complex synonyms
without word split
with words in the right order
with the last word considered as prefix

has a rank of 1 (the user didn't finish to tip the search but the final query could be an exact match)
3: Try to match exactly the word of the query anywhere in the document
Any other document has a rank of 2 + 1 for each word that is not an exact match.
a word is considered as an exact match when it matches:

without typo
without prefix
without ngrams
without complex synonyms
without word split

note @LegendreM: forbidding typos in the Exact criterion overlap the work of the Typo criterion, we should think about avoiding this conflict by allowing typos in the Exact criterion. It seems strange, but, thinking about the interaction between criteria, it could be logical.

Huge thanks for this proposal. 🙏

If I'm understanding it the right way the proposal is kind of the TypeSense behavior.
Typesense calculates a _text_match score for ranking the documents about text relevance.
_text_match score is computed from different criteria like frequency, edit distance, proximity and, ordering of query_by fields.
If documents have the exact same _text_match score, TypeSense accepts two more numerical fields in the sort_by parameter to break the tie.
E.g. sort_by=_text_match:desc,price:desc,rating:desc
It is possible to put a numerical field before the _text_match score.
E.g. sort_by=price:desc,_text_match:desc
sort_by parameter is set at query time.

I will open a specification for comment to move the discussion.

The specification has been opened to move our discussions there.


added complete oauth

Thank you, @Moneexa ! I had a brief first look and this seems very promising and close to mergeable. A few things I noticed:

The README  needs to be updated to reflect the changes with running the E2E tests locally and the backend setup
package.json and src/plugins/api.js still contain references to Pizzly. This PR should completely remove Pizzly from the project without losing any functionality. But maybe it's as simple as deleting the references by now?
package.json also contains the dependencies @auth0/auth0-spa-js and @octokit/rest in addition to firebase. Are these two really necessary, especially since most HTTP requests seem to be sent with axios?
Parts of the new code, e.g., ConnectToGitHubButton.vue, don't seem to follow the style conventions of the project (see .editorconfig and .prettierrc.json or best use IDE support to automatically format and fix the code according to the conventions). There also seems to be code that is commented out in some places. Best remove this if it is no longer required for testing.


fix(KFLUXINFRA-777): Adding a readonly variable in install.sh script

Adding a readonly variable for a lock file

/lgtm

/lgtm


Has anyone figured out how to run the Yi series models with mlx?

I've found that the Yi series models from 01.ai work very well when I run them in text-generation-webui, but they become very slow as the context size increases. I converted the Yi-6B-Chat model weights (https://huggingface.co/01-ai/Yi-6B-Chat) from safetensors format to npz, but when I tried running it using the llama.py script from mlx-examples it generated gibberish. Has anyone figured out how to run it with mlx and make it work properly?

Did you use one of the scripts in mlx-examples to convert it? If so which script?

Had a quick look at the Yi model. It seems that if you use tiny_llama to convert the model, it will miss the rope_theta in config. Additionally, the Yi model has different special tokens used in the tokenizer, so the standard sentencepiece tokenizer seems to use the wrong pad token or bos token. I managed to run it via mlx, however, I had to use a modified convert script from deepseek example and use deekseep example to run it.
here is my updated convert.py
import argparse
import copy
import json
from pathlib import Path

import mlx.core as mx
import mlx.nn as nn
import numpy as np
import torch
from deepseek_coder import DeepseekCoder, ModelArgs
from mlx.utils import tree_flatten, tree_map, tree_unflatten
from transformers import AutoModelForCausalLM, AutoTokenizer

def quantize(weights, config, args):
    quantized_config = copy.deepcopy(config)

    # Load the model:
    model_args = ModelArgs(**config)
    model = DeepseekCoder(model_args)

    weights = tree_map(mx.array, weights)
    model.update(tree_unflatten(list(weights.items())))

    # Quantize the model:
    nn.QuantizedLinear.quantize_module(model, args.q_group_size, args.q_bits)

    # Update the config:
    quantized_config["quantization"] = {
        "group_size": args.q_group_size,
        "bits": args.q_bits,
    }
    quantized_weights = dict(tree_flatten(model.parameters()))

    return quantized_weights, quantized_config

def convert(args):
    hf_path = Path(args.hf_path)

    model = AutoModelForCausalLM.from_pretrained(
        str(hf_path), trust_remote_code=True, torch_dtype=torch.float16
    )
    config = model.config.to_dict()

    state_dict = model.state_dict()
    tokenizer = AutoTokenizer.from_pretrained(str(hf_path), trust_remote_code=True, use_fast=False)

    # things to change
    # 1. there's no "model." in the weight names
    state_dict = {k.replace("model.", ""): v for k, v in state_dict.items()}

    # 2. mlp is called feed_forward
    state_dict = {k.replace("mlp", "feed_forward"): v for k, v in state_dict.items()}

    # 3. up_proj, down_proj, gate_proj
    state_dict = {k.replace("down_proj", "w2"): v for k, v in state_dict.items()}
    state_dict = {k.replace("up_proj", "w3"): v for k, v in state_dict.items()}
    state_dict = {k.replace("gate_proj", "w1"): v for k, v in state_dict.items()}

    # 4. layernorms
    state_dict = {
        k.replace("input_layernorm", "attention_norm"): v for k, v in state_dict.items()
    }
    state_dict = {
        k.replace("post_attention_layernorm", "ffn_norm"): v
        for k, v in state_dict.items()
    }

    # 5. lm head
    state_dict = {k.replace("lm_head", "output"): v for k, v in state_dict.items()}

    # 6. token emb
    state_dict = {
        k.replace("embed_tokens", "tok_embeddings"): v for k, v in state_dict.items()
    }

    # 7. attention
    state_dict = {k.replace("self_attn", "attention"): v for k, v in state_dict.items()}
    state_dict = {k.replace("q_proj", "wq"): v for k, v in state_dict.items()}
    state_dict = {k.replace("k_proj", "wk"): v for k, v in state_dict.items()}
    state_dict = {k.replace("v_proj", "wv"): v for k, v in state_dict.items()}
    state_dict = {k.replace("o_proj", "wo"): v for k, v in state_dict.items()}

    weights = {k: v.numpy() for k, v in state_dict.items()}

    config["rope_scaling_factor"] = config["rope_scaling"]["factor"] if config["rope_scaling"] is not None else 1.0
    keep_keys = set(
        [
            "vocab_size",
            "hidden_size",
            "num_attention_heads",
            "num_key_value_heads",
            "num_hidden_layers",
            "max_position_embeddings",
            "rms_norm_eps",
            "intermediate_size",
            "rope_scaling_factor",
            "rope_theta"
        ]
    )
    for k in list(config.keys()):
        if k not in keep_keys:
            config.pop(k)

    return weights, config, tokenizer

if __name__ == "__main__":
    parser = argparse.ArgumentParser(description="Convert Deepseek coder model to npz")
    parser.add_argument(
        "--hf-path",
        help="The huggingface model to be converted",
        default="deepseek-ai/deepseek-coder-6.7b-instruct",
    )
    parser.add_argument(
        "--mlx-path",
        type=str,
        default="mlx_model",
        help="The path to save the MLX model.",
    )
    parser.add_argument(
        "-q",
        "--quantize",
        help="Generate a quantized model.",
        action="store_true",
    )
    parser.add_argument(
        "--q-group-size",
        help="Group size for quantization.",
        type=int,
        default=64,
    )
    parser.add_argument(
        "--q-bits",
        help="Bits per weight for quantization.",
        type=int,
        default=4,
    )
    args = parser.parse_args()

    mlx_path = Path(args.mlx_path)
    mlx_path.mkdir(parents=True, exist_ok=True)

    weights, config, tokenizer = convert(args)

    if args.quantize:
        print("[INFO] Quantizing")
        weights, config = quantize(weights, config, args)

    np.savez(str(mlx_path / "weights.npz"), **weights)
    tokenizer.save_pretrained(mlx_path)
    with open(mlx_path / "config.json", "w") as f:
        config["model_type"] = "deepseek_coder"
        json.dump(config, f, indent=4)%

Did you use one of the scripts in mlx-examples to convert it? If so which script?

I wrote a quick and dirty conversion script. I'm not sure if I'm merging the three safetensors files into one the right way:
import shutil
import torch
from safetensors import safe_open
from safetensors.torch import save_file
import numpy as np
from pathlib import Path

torch_path = Path("/models/yi-6b")
mlx_path = Path("/models/yi-6b/mlx_model")

tensors = {}
with safe_open("/models/yi-6b/model-00001-of-00003.safetensors", framework="pt") as f:
    for key in f.keys():
        tensors[key] = f.get_tensor(key)

with safe_open("/models/yi-6b/model-00002-of-00003.safetensors", framework="pt") as f:
    for key in f.keys():
        tensors[key] = f.get_tensor(key)

with safe_open("/models/yi-6b/model-00003-of-00003.safetensors", framework="pt") as f:
    for key in f.keys():
        tensors[key] = f.get_tensor(key)

weights = {k: v.to(torch.float16).numpy() for k, v in tensors.items()}

# Save weights
np.savez(str(mlx_path / "weights.npz"), **weights)

Had a quick look at the Yi model. It seems that if you use tiny_llama to convert the model, it will miss the rope_theta in config. Additionally, the Yi model has different special tokens used in the tokenizer, so the standard sentencepiece tokenizer seems to use the wrong pad token or bos token. I managed to run it via mlx, however, I had to use a modified convert script from deepseek example and use deekseep example to run it.
here is my updated convert.py
import argparse
import copy
import json
from pathlib import Path

import mlx.core as mx
import mlx.nn as nn
import numpy as np
import torch
from deepseek_coder import DeepseekCoder, ModelArgs
from mlx.utils import tree_flatten, tree_map, tree_unflatten
from transformers import AutoModelForCausalLM, AutoTokenizer

def quantize(weights, config, args):
    quantized_config = copy.deepcopy(config)

    # Load the model:
    model_args = ModelArgs(**config)
    model = DeepseekCoder(model_args)

    weights = tree_map(mx.array, weights)
    model.update(tree_unflatten(list(weights.items())))

    # Quantize the model:
    nn.QuantizedLinear.quantize_module(model, args.q_group_size, args.q_bits)

    # Update the config:
    quantized_config["quantization"] = {
        "group_size": args.q_group_size,
        "bits": args.q_bits,
    }
    quantized_weights = dict(tree_flatten(model.parameters()))

    return quantized_weights, quantized_config

def convert(args):
    hf_path = Path(args.hf_path)

    model = AutoModelForCausalLM.from_pretrained(
        str(hf_path), trust_remote_code=True, torch_dtype=torch.float16
    )
    config = model.config.to_dict()

    state_dict = model.state_dict()
    tokenizer = AutoTokenizer.from_pretrained(str(hf_path), trust_remote_code=True, use_fast=False)

    # things to change
    # 1. there's no "model." in the weight names
    state_dict = {k.replace("model.", ""): v for k, v in state_dict.items()}

    # 2. mlp is called feed_forward
    state_dict = {k.replace("mlp", "feed_forward"): v for k, v in state_dict.items()}

    # 3. up_proj, down_proj, gate_proj
    state_dict = {k.replace("down_proj", "w2"): v for k, v in state_dict.items()}
    state_dict = {k.replace("up_proj", "w3"): v for k, v in state_dict.items()}
    state_dict = {k.replace("gate_proj", "w1"): v for k, v in state_dict.items()}

    # 4. layernorms
    state_dict = {
        k.replace("input_layernorm", "attention_norm"): v for k, v in state_dict.items()
    }
    state_dict = {
        k.replace("post_attention_layernorm", "ffn_norm"): v
        for k, v in state_dict.items()
    }

    # 5. lm head
    state_dict = {k.replace("lm_head", "output"): v for k, v in state_dict.items()}

    # 6. token emb
    state_dict = {
        k.replace("embed_tokens", "tok_embeddings"): v for k, v in state_dict.items()
    }

    # 7. attention
    state_dict = {k.replace("self_attn", "attention"): v for k, v in state_dict.items()}
    state_dict = {k.replace("q_proj", "wq"): v for k, v in state_dict.items()}
    state_dict = {k.replace("k_proj", "wk"): v for k, v in state_dict.items()}
    state_dict = {k.replace("v_proj", "wv"): v for k, v in state_dict.items()}
    state_dict = {k.replace("o_proj", "wo"): v for k, v in state_dict.items()}

    weights = {k: v.numpy() for k, v in state_dict.items()}

    config["rope_scaling_factor"] = config["rope_scaling"]["factor"] if config["rope_scaling"] is not None else 1.0
    keep_keys = set(
        [
            "vocab_size",
            "hidden_size",
            "num_attention_heads",
            "num_key_value_heads",
            "num_hidden_layers",
            "max_position_embeddings",
            "rms_norm_eps",
            "intermediate_size",
            "rope_scaling_factor",
            "rope_theta"
        ]
    )
    for k in list(config.keys()):
        if k not in keep_keys:
            config.pop(k)

    return weights, config, tokenizer

if __name__ == "__main__":
    parser = argparse.ArgumentParser(description="Convert Deepseek coder model to npz")
    parser.add_argument(
        "--hf-path",
        help="The huggingface model to be converted",
        default="deepseek-ai/deepseek-coder-6.7b-instruct",
    )
    parser.add_argument(
        "--mlx-path",
        type=str,
        default="mlx_model",
        help="The path to save the MLX model.",
    )
    parser.add_argument(
        "-q",
        "--quantize",
        help="Generate a quantized model.",
        action="store_true",
    )
    parser.add_argument(
        "--q-group-size",
        help="Group size for quantization.",
        type=int,
        default=64,
    )
    parser.add_argument(
        "--q-bits",
        help="Bits per weight for quantization.",
        type=int,
        default=4,
    )
    args = parser.parse_args()

    mlx_path = Path(args.mlx_path)
    mlx_path.mkdir(parents=True, exist_ok=True)

    weights, config, tokenizer = convert(args)

    if args.quantize:
        print("[INFO] Quantizing")
        weights, config = quantize(weights, config, args)

    np.savez(str(mlx_path / "weights.npz"), **weights)
    tokenizer.save_pretrained(mlx_path)
    with open(mlx_path / "config.json", "w") as f:
        config["model_type"] = "deepseek_coder"
        json.dump(config, f, indent=4)%

Awesome work. I'll give it a try. Thanks!

I have also updated the 4-bit model on Hugging Face (https://huggingface.co/mlx-community/Yi-6B-Chat-4-bit). If you want to skip the conversion step, you can directly download the converted model from there :).

Thanks @mzbac that's awesome!
Closing this as #205 fixes it. Let us know if you have any other issues.


Update vagrantfile to work with release 0.0.6 of fredrikhgrelland/hashistack box

Uuh, what exactly is this?

https://app.vagrantup.com/fredrikhgrelland/boxes/hashistack
Blocker: release 0.0.6 must be live


Mocks appear to persist across context in rspec-mocks v 3.3.2

I have a test setup that runs using the database cleaner style of RSpec tests, keeping tests atomic. The problem with this is that some of my models use the after_commit callback which doesn't get thrown in my test environment. I get around this by manually calling the callback in certain tests. The tests themselves run a Sidekiq job that is used and tested in different areas. The tests work fine when I don't mock out that Sidekiq worker. When I mock that Sidekiq worker (in an entirely different file and context) the tests break saying that the API that should have been called by the worker (mocked using WebMock) has not been called. I'm not sure, but I think this is a bug in rspec-mocks.
Obviously this is a bit of a complex setup so let me know what information I can provide to help debug the issue.

WebMock mocks are not rspec-mocks and are not directly tied in to the rspec example life cycle.  I believe you have to tie them in yourself so that they don't leak between tests.

You need to call WebMock.reset! after each example, this can be done with a configuration hook or by requiring webmock/rspec which will do this for you.

Thanks guys! I will try this later and double check. Hopefully that's all the problem was. I didn't realize WebMock leaked like that.

It's not leaking it just needs to be setup correctly.

WebMock is a generic tool that can be used in any test framework and outside any test framework, and thus it assumes nothing about your environment and you need to configure it to work how you want.

Thanks for the support guys! It appears even after adding in the require statement that the problem persists in my other tests.

You'll have to seek support from WebMock's maintainer then.  If you see that behavior from an rspec mock we'd certainly dig in more.

I appreciate it. I will certainly post in the WebMock issue tracker. The odd part is that the thing that causes the tests to fail is just adding in additional tests that have rspec-mock mocks setup in the individual tests within their own separate context. I think the issue may be separate from WebMocks due to this. I have a couple of objects that have async workers (using Sidekiq) that I mock some methods on in the tests that cause the breaking change. These methods also are the ones that make some API calls in the tests that have WebMock in them in another file. It seems that the mock is persisting outside of the scope of the context these are setup in. I'm not 100% sure though, as I have said the only thing I know 100% for sure is that putting the tests in breaks the suite and removing them fixes it. Very strange.

@illegalnumbers did you get this issue worked out?

Closing during the monorepo migration due a lack of a reproduction for anything we can fix.


0.10.6 break asyncData & this.$router.push

Hello,
With 0.10.5, in an method, I do this.$router.push() to change route.
After update to 0.10.6, my route is well changed, but template is not refreshed, but asyncData is well played.
Thanks,
Gaël

Hi, can you post some code snippet and explain more about your issue?

Is the issue only present in the static generated version of the site or also when you run the site with npm? I think it might be related to #531

Mhhhh, I'm trying to reproduce my issue in a fresh project, but... I don't have the issue in this project. I will check if it's a more complicated use case, I guess that I'm not the only one to see this issue, according to the two 👍, so @alidcastano & @isesol-global, can you help me ?

I have the same problem.
It's a search where for example clicking on page 2 the results are requested via axios and the route is pushed to ?page=2 .
Now what happens then is beyond me and hard to explain. It's like a time machine where everything happens again, just with the store data lost or messed up, so if I had filters set in the store and there were 50 results, after the first axios request, a second one would fire immediately and the search results would jump back to page 1 without filters set. Continuing setting filters also caused a weird mess in the store. So personally I think it has something to do with the store.
After finding this issue and reverting back to 0.10.5 everything works as expected.

I could not reproduce this issue.
Can you create a reproduction ny forking https://glitch.com/edit/#!/nuxt-hello-world please?
Then, I'll re-open this issue.

Maybe like #671, but #671 is not working on 0.10.5

@mindbits : Do you have the last version of vuex ? Is you issue still here on 0.10.7 ? I guess that's issue was linked to an issue on a dependency of nuxt, and may be fixed somewhere.


"+ New Dialog" button should stay at the top, not keep creeping down to the bottom of the dialog list

Describe the bug
When adding more and more dialogs, the "+ New Dialog" keeps staying at the bottom of the list of dialogs and keeps getting harder and harder to get to.  Instead, should stay at the top of the list.
To Reproduce
Steps to reproduce the behavior:

Create a complex bot with many dialogs
Add more dialogs

OBSERVE ISSUE: "+ New dialog" button keep sliding further and further off-screen, becoming harder and harder to access.

Expected behavior
EXPECTED INSTEAD:  New Dialog button should stay docked at the top of the list of the dialogs and not move further away with each new dialog.
Should stay in the same, predictable space. Like so, but with the proper UI look:

Closing. Reference attached issues for updated.


Inconsistent version of Guava

I was concerned with the way the guava version is handled in this build that got no answer
A fresh project created with only spring-cloud-gcp-starter on start.spring.io brings com.google.guava:guava:jar:18.0
This line is useless if you're not using guava yourself as it will fix the version for your build internally but will not promote the fact you have a preference for that version. For that to happen, you have to add a dependency explicitly on guava (which is quite messy if you ask me). Adding that to  spring-cloud-gcp-core might do what you want.
Guava is known to be very problematic so perhaps we should reconsider its usage?

We set guava's version only internally on purpose. The idea was that our project shouldn't promote versions of dependencies that it doesn't manage. Setting the version in our BOM is a can of worms, because other BOMs might take precedence in the dep graph, and our version is not guaranteed to be the final one.
We're almost barely using guava in our project (only some ImmutableMap here and there). We actually don't care which guava version is used. The only reason we're setting the version of guava is because spring-cloud-dependencies sets the version to 18, which breaks our dependencies that use guava.
Let me know if you have other questions.

Note that the Guava dependency is coming from com.google.cloud:google-cloud-core, which we need in the core starter. I think the client libraries team recognizes that versions of Guava are often very problematic and they were going to shade their usage of Guava, but I'm not sure if it has happened yet.
@garrettjonesgoogle

We set guava's version only internally on purpose

Well your build and your tests are executed with a different version as the one that is used by default by any app so, IMO, that's what is asking for troubles.
I know that this project doesn't use guava but other google-related artifacts do and your build overrides the guava version. You either have to mark that preference (as indicated in my original comment) or you should remove that override.
Please note that I never mentioned the BOM and, indeed, let's not even mention that.

+1
I guess we override the version because the build fails otherwise. :smile:
Let's find a better solution like @snicoll suggests.

We had to set guava's version to 20 because google-cloud-java uses guava features higher than 18 and apps break at runtime.
Assuming every project follows the best practice of not promoting versions of dependencies they don't manage, the best fix would probably be to exclude the troublesome BOM, spring-cloud-starter-netflix-archaius. If that works, it would allow us to not set any version for guava at all. This would work, assuming that no one in Spring Boot or Spring Cloud repeats the same mistake of publishing guava's version in a BOM again.

spring-cloud-starter-netflix-archaius is not a BOM. Can you please add a link to the BOM that sets the version of Guava?
(I am not sure I agree with the rest of your comment but let's figure this one first please).

https://github.com/spring-cloud/spring-cloud-netflix/blob/master/spring-cloud-netflix-dependencies/pom.xml#L422
Unfortunately, the latest version of google-cloud-java requires a guava version higher than 18 otherwise the build fails. So any solution here will have to involve a fix to this BOM.

@garrettjonesgoogle That's one option, but what about shading Guava in Google Cloud Java libs?

Opened https://github.com/spring-cloud/spring-cloud-netflix/issues/2854 to remove the guava version from the dependency management.

@meltsufin That would bloat binary size for cases like Android, and it creates a lot of problems to release two variants of a library, one of which shades & one of which doesn't.


Add example of kata-sriov without plugin

Run kata container and sr-iov without usage of clearcontainer plugin. Adds more flexibility, because VF can be configured manually.
Tested with Mellanox connectx-4 NICs

/cc @eadamsintel @devimc

Hi. Thanks for the contribution! The CI is complaining as you did not sign off your commits - have a look at our contributing guidelines for information on how to format the pull requests etc. to keep the CI happy:
https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#pull-requests

I fixed the stuff mentioned in the comments, updated the rebinding to vfio-pci and squashed the two commits to get everything signed off.

Hi @HolyShitMan - Travis is failing with the following error:
ERROR: Commit cafea9b05733d38e4cb6dc17b29d6bafe49872f2: Failed to find subsystem in subject: "Add example of kata-sriov without plugin"
ERROR: checkcommits failed. See the document below for help on formatting
commits for the project.
https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#patch-format

The good news is that it's easy to fix: just prefix the first line of your commits with a "subsystem" which for this PR would be docs:  or maybe sriov:.
In fact, you have two commits, but I would squash these into one as we don't tend to worry about putting review changes into separate commits.

I really don't know why CI is still failing with
ERROR: No "Fixes" found

Do I have to mark the path as a "Supplementary patch" any way, which does not need a "Fixes: #xxxx" comment?

You need to have a Fixes: #nnn style line in at least one of your commits to note which Issue in github you are fixing. The requirement is detailed on the contributing docs.
If you have an Issue already open for this PR, add the relevant Fixes line to your commit. If not, please open an Issue detailing what you are fixing and why, and then reference that....
thanks ... nearly there I think!

If you have an Issue already open for this PR, add the relevant Fixes line to your commit. If not, please open an Issue detailing what you are fixing and why, and then reference that....

I wouldn't call it an issue that there was no second example, but whatever. If your CI needs it, it gets it.

I wouldn't call it an issue that there was no second example, but whatever 😄 . If your CI needs it, it gets it.

Thanks - yeah, 'Issue' is the github term :-) Everything is an 'Issue'. I know, the process can be a bit painful for small and doc updates, but overall it works well for the code base to ensure we have a good history of who changed what and why, and gives everybody a heads up normally on what issues folks are working on etc.

@HolyShitMan thx for the PR -- can you just add comment re: caps?

/test

Hi @HolyShitMan nice Github handle 😂

Hi @klynnrif - I think the PR's been updated so can you check and approve if you're happy?

Hi @HolyShitMan, can you address last comment?
Thanks.

Hi @HolyShitMan - please could you update for the final comment?

Ping @HolyShitMan ?

Looks like @HolyShitMan has mostly fallen off github ... one last shot - one tiny fix @HolyShitMan and you can get some github PR immortality .... :-)

Sry guys. I've really got no good excuse for this. I hope this is fine now.

/test-ubuntu

@grahamwhaley @jodh-intel PTAL

/test

Folks, this PR has been stale and I'm closing it as we're walking towards the final 1.13.0 release of the kata-containers-1.x.
From now on, all the development will happen as part of https://github.com/kata-containers/kata-containers/ and fixes should be provided to that repo.
Thanks a lot for your contribution, we're sorry that for some reason it got stale, and we hope to see you around for new adventures in the kata-containers-2.x land.


app.js: add biweekly interval

Idea to add biweekly recurrence.
Warning: UNTESTED. Haven't set up development environment yet.

Thank you!


add support for adding columns after other columns

Related to #41

Hey @tanner0101, you just merged a pull request, have a coin!
You now have 757 coins.


Release v1.0.7

Describe Request
Release v1.0.7
Fixed #97
Change Type
New feature.

Codecov Report

Merging #98 (a4a1cd6) into main (004553f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   62.49%   62.49%
=======================================
  Files          91       91
  Lines        1501     1501
  Branches      180      180
=======================================
  Hits          938      938
  Misses        550      550
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 004553f...a4a1cd6. Read the comment docs.


tickless and timeslicing don't play well together

Specific bug: wake up a thread (or create a new one) at the same priority as the currently running thread, both of which are at the same preemptible priority and in a situation where no other threads exist at that priority.  In theory, the CPU timer should be adjusted to reflect the new situation and expire in one slicing tick.  In practice, the timer is not adjusted and the new thread won't get any CPU until whenever the next interrupt fires, which could be a long time.
That issue was found via inspection as I stumpled over this code while working on the scheduler.  The more general problem is that we have pretty poor test coverage for both timeslicing and tickless behaviors, this situation needs to be tested and handled, along with (probably) others.

Could the issue https://github.com/zephyrproject-rtos/zephyr/issues/7048 be caused by same root cause?

The bug found by inspection will be fixed.  Probably need some sort of longer term tracking on enhancing tickless (making it default where possible, expanding tests) and coming up with a better set of tests on timeslicing that look for fairness issues like this.

FYI: @pizi-nordic

Fix for the specific bug above is submitted.  Probably should reprioritize rather than close this one, as the rework is if anything needed more now than before, given that we've added another #ifdef TICKLESS case.

Ugh, fixed correctly this time.   No idea what happened earlier, presumably I rebased, but then forgot the "-a" on the commit?

Fixed as of the big timer rework.  Tickless is default and all timeslicing tests pass with it enabled. Closing as I'm the one who opened it to begin with.


Fixed check for MODTRAN convention of OBSZEN to include angle of 0°.

Debugging revealed that the case of 0.0° view zenith angle was not included in the translation to MODTRAN OBSZEN convention. This PR fixes this behavior.

Handled more elegantly in https://github.com/isofit/isofit/pull/611. Closing this one.


feat(codegen): print type_parameters in TaggedTemplateExpression

#5438  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on  Graphite


Find out if we need to use Write-Information or Write-Ouput

I guess we need to stick with Write-Information


fix ArithmeticException in CameraPreview

In version 3.6.0 of the lib, we had crashes of ArithmeticException, since we assume that the view has not yet finished drawing and the previewSized method is called
link Issue #334
link Issue #409

know issue: preview stretching after change screen orientation

@rkistner does the solution look good to you ?

I haven't yet been able to confirm whether this will fully fix the issue; will need to spend more time on this.

Hi @rkistner . I use this beautiful library, but this problem bothers me. Do you intend to merge these patches? Is this library still maintained?

Hi @rkistner . I use this beautiful library, but this problem bothers me. Do you intend to merge these patches? Is this library still maintained?
Is there a planned date for version 3.7.0 ?

I second this. When can your latest changes be merged?

Sorry for the delay, I will look into this and do a new release over the next couple of days.

Sorry for the delay, I will look into this and do a new release over the next couple of days.

No problem @rkistner . I am looking forward to the new version :)


Fix some scrollbar track and border painting issues

Fixes #90310

Why did the github bot land this while the tree is red? @godofredoc @dnfield

You can see here that when it landed, the check was marked as passing.
In the past we've had issues where the API we used had limits around how many times we could change the status - I don't know if such a limit exists with the current API, but @keyonghan or @CaseyHillers might know.

@christopherfujino suggested having the bot check LUCI specifically before merging and not relying on the status on the PR, which might be a good idea. We should fix the status anyway though since it'd be confusing to humans who are wondering why the bot isn't merging their PR.


[reconfig] Add certificate creation trait

At the end of epoch, the checkpoint builder would need to create an authority aggregator on the fly from the system state, and use it to construct a certificate for the advance epoch transaction. Currently this is done explicitly using the network client. However that makes testing difficult. If we want to unit test individual components without having to start a network node and Narwhal, we need to use a local client.
This PR hides the use of network vs local client through a trait object, and provide different implementations for it.

One thing i'm not quite sure of is why do validators need to use this network interface and drive quorum on txns themselves?

What are the alternatives? Talking to a fullnode?

btw I think down the road, when we support storing/executing finalized transactions without certs, we could then get away without having to do this quorum dance

What are the alternatives? Talking to a fullnode?

I suppose i just don't understand which transactions they would even need to do this for.

Oh it's this last transaction of the epoch that advances epoch on-chain and distribute gas rewards. It's a system transaction and each validator builds it independently, but still need to collect signatures from each other to form a cert.

Oh it's this last transaction of the epoch that advances epoch on-chain and distribute gas rewards. It's a system transaction and each validator builds it independently, but still need to collect signatures from each other to form a cert.

Is this necessary? this seems like an unnecessary increase to latency. I would have expected that at the end of an epoch there are some signals from narwhal that we use to signal the ending of the epoch and that we need to form the final checkpoint of the epoch. At that point all validators would independently construct and execute this system transaction without any input from each other. Once that finishes they would finish crafting the final checkpoint, doing the narwhal dance to finalize that checkpoint which will include this system transaction and its effects.

I agree with you. However in the current implementation we require a transaction certificate ever where for any transaction that's committed to the system. Once we do the finalized transaction work where we support executing and storing finalized transactions in raw forms we wouldn't need this anymore. But in today's code base we don't have a choice but to create a cert on the fly.

One thing I don't see we have to do, at least from this PR, is passing TransactionCertifier to CheckpointService. In a unit test setup where we focus on testing stuff like create_advance_epoch_tx_cert, we can pass the certifier when calling it. In non-unit test code path, we could init NetworkTransactionCertifier in e.g. fn augment_epoch_last_checkpoint and avoid passing it all the way from CheckpointService

If create_advance_epoch_tx_cert is the only function we want to test, then yes.
But let's say we want to test that the last checkpoint properly augments itself with the advance epoch tx. How would you test it with a local client setup?


[parallel-deployment] REPORT method not allowed in old webdav endpoints (using oCIS selector)

Describe the bug
REPORT request to old webdav returns 405 Method Not Allowed
Steps to reproduce

REPORT request to webdav root path

curl -XREPORT -ueinstein:relativity "https://host.docker.internal:9200/remote.php/webdav" \
-H"Cookie:owncloud-selector=ocis;path=/;" \
-d"<?xml version='1.0' encoding='utf-8' ?>
<oc:search-files xmlns:a='DAV:' xmlns:oc='http://owncloud.org/ns' >
    <oc:search>
        <oc:pattern>Folder</oc:pattern>
    </oc:search>
</oc:search-files>"

Expected behavior
to return 207 Multi-Status response (like with oc10 selector)
Actual behavior
returns 405 Method Not Allowed response
Setup
oc10-ocis parallel deployment
STORAGE_USERS_DRIVER: owncloudsql
SHARING_USER_DRIVER: owncloudsql

Not going to happen. So closing here.


Fixes relative paths bug in singleMode

Status
READY
Description
Fixes #132, makes correct path generation in singleMode imports.

Hello, can you try with the orval@next should be fixed it's the rc

Fixed with the new release 5.3.2


Add terminal-ubuntu icon

Follow up from https://github.com/microsoft/vscode-codicons/issues/51, we have the assets for it now.

Added terminal-ubuntu:


http - user/password authentication

Is your feature request related to a problem? Please describe.
I am trying to download a file from easybytez.com with my premium account, but Motriz is not prompting user/pwd authentication
Describe the solution you'd like
would like to add credentials for a specific domain i.g.: easybytez.com.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Try .netrc ?
https://aria2.github.io/manual/en/html/aria2c.html#cmdoption-netrc-path

References:
https://gist.github.com/tpope/4247721
https://ec.haxx.se/usingcurl/usingcurl-netrc

shouldn't this be implemented in the UI itself? The end user should not have to do any manual work for something as basic as this


React-component to represent states of components that are unknown

Right now, components with unknown states are represented with a simple message in a Typography. Ideally we would want a re-usable component that can be used across the accordions of all components with more bling to it :sparkles:, or we could also notify operators in other ways, eg: (sms, an ivr?)
Feel free to give suggestions!
Related comment:
https://github.com/osrf/rmf-web/pull/169#discussion_r538964840
Related PRs:
#169
#179

Avoid posting asana links here as that is private.

Updated


Is there any API?

Well, I watched the code, but I can't find if there's an API. I would like to put this application on my server and make requests to it from my client. Whether there is such an opportunity, or push on the right way, I can add this opportunity myself

What you describe seems to be a custodial wallet. And those need more considerations than just putting private keys on a server. This calculator app is not meant to be used like that.
Could you please describe your use-case in more details, maybe you could get recommended another tool for that?

What you describe seems to be a custodial wallet. And those need more considerations than just putting private keys on a server. This calculator app is not meant to be used like that.
Could you please describe your use-case in more details, maybe you could get recommended another tool for that?

Thanks for answer. I need to create many (thousands) P2SH wallets using public keys (ypub....)
I tried to using some python libraries, but nothing worked. Find one PHP script, but same.
The final solution was create wallets using this tool from seed.


Give library users direct access to the Inputstream

This removes our restriction of offering the user a line at a time, see DeployExample for more.

Codecov Report

Merging #321 into master will increase coverage by -0.42%.

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   60.48%   60.06%   -0.42%
==========================================
  Files          65       64       -1
  Lines        1536     1535       -1
  Branches      231      232       +1
==========================================
- Hits          929      922       -7
- Misses        509      517       +8
+ Partials       98       96       -2

Impacted Files
Coverage Δ

...s/appengine/experimental/deploy/DeployExample.java
0% <ø> (ø)
:white_check_mark:

...perimental/internal/process/CliProcessManager.java
84.44% <100%> (+0.8%)
:white_check_mark:

...xperimental/internal/cloudsdk/CloudSdkRequest.java
84.61% <100%> (-2.06%)
:x:

...ental/internal/cloudsdk/CloudSdkRequestFuture.java
40% <40%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d41b30...b106614. Read the comment docs.


Optimize crowdsale contract

🚀 Description
I noticed that the 256 units should be grouped together optimize the contract at compile time. This is a very simple fix that makes sure the 256 variables are grouped together. It doesn't touch anything else other than that.

I just moved a line of code in the crowdsale contract so it's grouped together.

This should decrease the cost to deploy the contract.

Hi @fourcolors! Thanks for taking the time to contribute to OpenZeppelin! By any chance, have you run some tests on the size difference? address variables occupy 160 bits, so there must be a <= 96 bit value (256 - 160) after it for the compiler to be able to pack both into the same slot. Maybe a derived contract can take advantage of this optimization if it manages to put such a value right after the adderss.

@fourcolors thanks for catching this! I'm closing this as a refactor of the Crowdsale code is underway in which the base Crowdsale has no start or end times, but is instead extended by TimedCrowdsale to preserve this functionality. Please see #744 for this change, and feel free to comment there if you find any issues!


Proposal: helm template should also order resources in "useful creation order"

In https://github.com/kubernetes/helm/pull/1238 , Tiller was changed to order resources before sending to k8s, so that e.g. namespaces are created before objects in that namespace.
It would be nice if helm template also did this useful ordering. I'm creating a Helm package for my software, but I also want to keep a "plain" manifest for people who just want to kubectl apply. I can do this by rendering the Helm templates, but it generates the output in a non-deterministic order, which might not be valid.

Hi @danderson
Are you running the helm template plugin? I ask because helm template is now in core and should have iirc "mostly" deterministic ordering just like Tiller. The mostly part is due to unknown types (types not explicitly in the list) being sorted alphabetically. If you are using helm template in core and seeing inconsistencies we should investigate because that sounds like a bug.

This is fixed probably with #5186


Refactor: remove portal

Removed all references to appSelector

Removed all references to portal

Restructured apps/ (ref. #5)

Changed DemoApplication blueprint:

Inherits from system/SIMOS/Application
Added urlPath attribute
Added default uiRecipe: demoApp

Renamed datasource to use consistent name: DemoDS => DemoApplicationDataSource

Now loads <dataSourceId>/<applicationId> from app-settings.json

Fetches app settings from DMSS (entity demoApplication.json, from app/data/DemoApplicationDataSource/instances/)

Now uses UIPluginSelector to load the UiPlugin for the application based on the application settings (DemoApplicationDataSource/DemoApplication)

Linting:

Avoid 'unnamed default exports', e.g. export default [] => const x = []; export default x

Resolves #6

Resolves #5

Awaiting equinor/dm-cli#13


Error importing .nix files using flakes

I get an error every time I try to add a new nix file or directory, despite adding it to my imports. For instance, say I created and added libinput.nix into my home directory. I would import it through /nixos-config/modules/home/default.nix as follows:
{inputs, username, host, ...}: {
  imports =
      [(import ./bat.nix)]
   ++ [(import ./libinput.nix)]
   ...
   ++ [(import ./zsh.nix)];
}

I then run this command:
sudo nixos-rebuild switch --flake /home/neo/nixos-config#desktop --option show-trace true --fast
And then get this error:
at /nix/store/rs4fjbnw4qx7ns2hzzrz2iz52va7vs5z-source/lib/modules.nix:349:12:

348| loadModule = args: fallbackFile: fallbackKey: m:
349| if isFunction m then
   |    ^
350| unifyModuleSyntax fallbackFile fallbackKey (applyModuleArgs fallbackKey m args)

… while calling 'isFunction'

at /nix/store/rs4fjbnw4qx7ns2hzzrz2iz52va7vs5z-source/lib/trivial.nix:991:16:

990| */
991| isFunction = f: builtins.isFunction f ||
   |              ^
992| (f ? __functor && isFunction (f.__functor f));

error: getting status of '/nix/store/fl33dws0knxzfa8yjn4pg6qhw5l02jn2-source/modules/home/libinput.nix': No such file or directory

Again, it does this with any .nix file I try to create and import. I’ve tried importing it in my desktop config and editing my flake.nix but no luck. The workaround is adding my code to a pre-existing .nix file, but this is far from perfect and only a temporary bandaid. Your help is greatly appreciated!

I received the following solution from the nixos forums....
Solution:
cd into the flake and run git status. It will show you ‘untracked’ files in red. You need to add them to git, for example git add . to add everything.
Also, the import keyword here is unnecessary, imports is just a list of paths
  imports = [
    ./bat.nix
    ./libinput.nix

    ./zsh.nix
  ];

Explanation:
Because the flake you’re using is in a git repo, nix will copy the git repo to the store, but only include files in git’s index.
The import keyword is build in to the nix language, and it is treated as the content of the file it imports.
imports = [ ... ]; is part of the module system, and takes a list of paths to include as modules


Bug with first list items wrapped in unneeded View

Using a custom font, I discovered that the list items are not rendered the same way.
The following example markdown is given:
* Test 1 ß
* Test 2 ß
* Test 3 ß

The first list item text is wrapped in another View which makes it ignore setting a custom font:

Clearly visible in RN Debugger:

The text of the first list item is wrapped in another View which receives the style, the others list items are just text nodes.

@winkelsdorf I couldn't replicate this issue,
it works fine on my end.

@andangrd Thanks for your reply! It should be visible in the React Native Debugger when checking the view hierarchy. Let me try to get some sample code for you.. Currently I'm snowed under work.

HI @winkelsdorf
I'm hoping that this issue has fixed by the latest update,

Sorry for the late reply, just had the time to test it again with v1.6.0.
It's still a little buggy when the custom font is NOT defined in text style, but listItemText:

It's working for the last two.
Example markdown:
- Not bold &
- **Manually set to bold &**
- Suddenly bold &

The styles:
const MarkdownStyles = {
  text: {
  },
  paragraph: {
    fontFamily: 'MyCustomFont',
  },
  strong: {
    fontFamily: 'MyCustomFont',
    fontWeight: 'bold',
  },
  listItemText: {
    fontFamily: 'MyCustomFont',
    fontWeight: 'bold',
  },
};

Looks like the following happens:
The first line ignores listItemText completely. And has an issue with the ampersand sign.

Hi @winkelsdorf
This issue has been fixed in the latest version, 1.7.0
Below is the testing result, and please let me know if it still not working on your end..

Hi @andangr!
Thank you for still helping me with this 👍
Looks way better, but the first line still ignores the custom font (have a look at the ß):

hi @winkelsdorf
this issue should be fixed in the latest version, v1.8.0
please let me know if you still facing this bug.
thank you


⚠ Bofrost.ch has degraded performance

In c102c0d, Bofrost.ch (https://www.bofrost.ch) experienced degraded performance:

HTTP code: 200
Response time: 2477 ms

Resolved: Bofrost.ch performance has improved in b53da23 after 312 days, 2 hours, 19 minutes.


chore: delay GISAID download to 16:07 CET

Adjusts the time of the auto-ingest of GISAID from 3pm CET to 4pm CET in order to be more in line with when GISAID seems to be updating their files.
One remaining question - there is no reason to move the Genbank ingest as we pull in realtime, but do we want to keep the ingest times in sync just for neatness? (Currently I modify only GISAID)

Checking recent times it looks like in the past 2 weeks GISAID has mostly been updating later in the afternoon (often around 3-3.20 but that's still missing our current build), so this is probably worth pushing back. Not sure why this seems to be creeping back.

Well the dataset grows and GISAID presumably starts at the same time so it finishes later and later, I would say.


Intermittent Webpacker.dev_server.running? behavior

This bug report was originally filed against rails/webpacker #3269. I'm opening it here even though I've only reproduced this bug with rails/webpacker because I see the problematic default timeout value is identical here as it was in rails/webpacker.

Ruby version: 2.7.3p183
Rails version: <IP_ADDRESS>
Webpacker version: 4.1.0
Expected behavior: Webpacker.dev_server.running? should return consistent answers
Actual behavior: Webpacker.dev_server.running? returns true and false intermittently
As of https://github.com/rails/webpacker/pull/753
Webpacker uses by default a socket connect timeout of 1/100th of a second. I have seen situations developing locally where this is too fast and I get intermittent return values. Thankfully, the value is configurable, but going back to the PR where the change was made, I don't see any conversation specifically around the change from 1 full second to 1/100th of a second. It isn't clear that there was a reason for the change to the default value and basically I think the default value should be longer. Happy to put in a PR, but I'm putting in this issue first to see if there are any objections.
Followup: Actually, I do see a blip of a conversation inline in that PR now, but it seems to be in reference to "slower systems" and I have seen this on a few modern systems now, one of them being a brand new M1 macbook.

@stevecrozz if you can submit a PR with some repo steps, that would be a great contribution.

@justin808 good to close!


Fix some glitches in extract_features.py

Do the following fixing to make the extract_features.py runnable:

Add no_cuda argument
Fix the "not all arguments converted during string formatting" error thrown at line 230

Thanks, I've pushed these fixes in the first release (the organization of the library changed quite a bit).


Wrong Grammar Usage in Azure SQL DB Docs

About
In the Azure SQL DB Docs [here][https://learn.microsoft.com/en-us/azure/azure-sql/database/high-availability-sla?view=azuresql&tabs=azure-powershell#zone-redundant-availability], it says This architecture targets mission-critical applications with high IO performance, high transaction rate and guarantees minimal performance impact to your workload during maintenance activities. when it should actually be This architecture targets mission-critical applications with high IO performance, high transaction rate and guarantees minimal performance impact **on** your workload during maintenance activities. The preposition to should be changed to on.
--
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e2d07885-d3f0-11d9-0a1f-aa9025d60d49
Version Independent ID: 551bdeb1-fc7c-5d7f-4e58-a558d3a39df7
Content: High availability - Azure SQL Database
Content Source: azure-sql/database/high-availability-sla.md
Service: sql-database
Sub-service: high-availability
GitHub Login: @rajeshsetlem
Microsoft Alias: rsetlem

@SohamSen15
Thanks for your feedback! We will investigate and update as appropriate.

Hi @rajeshsetlem,
Could you please look into this document request, thanks.

Hi @SohamSen15 , thanks for catching this and your feedback! I've processed a change to update the documentation that'll be live later this week.  However, please be aware that you can also make these changes to the documentation, you can find more info here: https://aka.ms/editsqldocs.
I'll go ahead and close out this Git Issue but please feel free to comment should you need anything further.
Thanks again for improving our documentation and I hope you have a wonderful rest of your day!
Masha from the SQL Docs team
#please-close
#reassign:MashaMSFT


I can not catch request code Android

I have a problem with the response of my activity. It is a module to react natively. I have this react class and I am trying to get result from my activity. I've tried catching the requestCode like this:
    public CameraOpenerModule(ReactApplicationContext reactContext) {
    super(reactContext);
    getReactApplicationContext().addActivityEventListener(new ActivityEventListener() {
        @Override
        public void onActivityResult(int requestCode, int resultCode, Intent data) {
            Log.e("TEST", "listener start event");
            if (requestCode == 9999) {
                Log.e("TEST", "request code ");
            }

        }
    });
}

and I open the class intent:
    private void openCameraIntent(){
    cameraIntent = new Intent(getReactApplicationContext(), CameraHelpActivity.class);
//    cameraIntent.addFlags(Intent.FLAG_ACTIVITY_FORWARD_RESULT);
    cameraIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
    getReactApplicationContext().startActivityForResult(cameraIntent, 9999,null);
}

and another activity
    @Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.main);
    setResult(1111);
    Log.i("ACTIVITY", "finish !!!!!");
    finish();
}

Everything is ok. But I'm not catching the request code. Does anybody know why? Thanks

solution: http://stackoverflow.com/questions/34290962/i-can-not-catch-request-code/34329678#34329678


Update prod.workflow.yml

As project is not deployed, disabling prod workflow

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (04f23c9) 40.26% compared to head (0b6f3b2) 40.26%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   40.26%   40.26%
=======================================
  Files          11       11
  Lines         457      457
=======================================
  Hits          184      184
  Misses        273      273

Flag
Coverage Δ

unittests
40.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


no longer can change workspaces

Hello, after reboot (didnt update anything) i can do anything with skhd/yabai but it doesnt allow me to change workspace this way. Usually sudo yabai --load-sa was needed to make this last feature going but now it doesnt do anything. I ve been sitting on older versions (like few months) so I tried updating to brew release:
❯ yabai --version
yabai-v5.0.4
❯ skhd --version
skhd-v0.3.7
csrutil status returns: System Integrity Protection status: unknown
And also updated my mac to Sonoma 14.2.1
Any ideas what I might try? Thanks!

Thanks, did it, it got new hash but it still doesnt work ...it acts very strange currently. It feels like sometimes yabai acts but a most of the time it doesnt do anything, not even manages windows. When I tried to run commands in terminal one ran got me error while another went through. What is happening? :(
❯ yabai -m window --space 1
yabai-msg: failed to connect to socket..
❯ yabai -m window --space 1

Like now ...I split my browser with terminal side by side. Then closed the terminal and browser kept its half size for like 5 seconds then it caught up and made it fullscreen
When I use my skhd binds it works once then stops so I can change focus but cant go back.
Note to myself. Do NOT update apple devices until I absolutely have to :/

Please check #2007, where you will find that you need to update to v6.0.2+.

didnt see that one, thanks!


imagenet class labels

are we sure this data is the right mapping for imagenet?
the class ordering looks different than what I remember but I could just have a bad memory. can we confirm what summit used? should be in here.

The order of labels in the data (tfrecord) and the model (modelzoo InceptionV1) are different. Here you can find the both ordered labels.


QCFC.R does not work as intended

Describe the bug
Run qcfc.R with this command:
singularity shell --cleanenv -B /data:/mnt ${tools_dir}/xcpEngine-100219.simg

outputdir=/mnt/picsl/mackey_group/BPD/CBPD_bids/derivatives/xcpEngine_gsr_spkreg_fd0.5dvars1.75_drpvls/

${XCPEDIR}/utils/qcfc.R \
    –c ${outputdir}/qcfc/n74_qcfc_input.csv \
    -o ${outputdir}/qcfc/ \

Cohort file
id0 | id1 | motion | connectivity
-- | -- | -- | --
sub-CBPD0002 | run-01 | 0.1805525 | /mnt/jux/mackey_group/Ursula/projects/in_progress/within_between_network_conn_CBPD/data/imageData/gsr_spkreg_fd0.5dvars1.75_drpvls/schaefer400Networks/sub-CBPD0002_run-01_schaefer400_network.txt
sub-CBPD0015 | run-01 | 0.4495776 | /mnt/jux/mackey_group/Ursula/projects/in_progress/within_between_network_conn_CBPD/data/imageData/gsr_spkreg_fd0.5dvars1.75_drpvls/schaefer400Networks/sub-CBPD0015_run-01_schaefer400_network.txt
sub-CBPD0018 | run-01 | 0.7286503 | /mnt/jux/mackey_group/Ursula/projects/in_progress/within_between_network_conn_CBPD/data/imageData/gsr_spkreg_fd0.5dvars1.75_drpvls/schaefer400Networks/sub-CBPD0018_run-01_schaefer400_network.txt

Error message
Paste your error message between the backticks
Error in parse_args(OptionParser(option_list = option_list)) :
  Error in getopt(spec = spec, opt = args) :
  "–c" is not a valid option, or does not support an argument
Execution halted

Is this eventually planned to be workable? Just curious! Had it on my list to check back on and see if I could use it...

@utooley, not sure if you were able to resolve this bug yet. I copied and pasted your command into my terminal and it appears that there is a typo where you were defining the cohort file: "–c"
The symbol that comes before the "c" looks like a dash but it is not. If you copy the dash that you used for defining the output path then QCFC.R should run to completion.


Localising with moment.js results in massive errors

Like explained in your docs https://vaadin.com/docs/-/part/elements/vaadin-date-picker/vaadin-date-picker-localization.html the localisation via moment.js is not working and gives massive errors.
Localizing manually like described at top of your docs page, everything is fine.
Maybe you can have a look at this issue and see if something in moment.js has changed or a change in the date-picker is causing the errors.

Hi!
Looks like the docs example is missing weekdays: moment.weekdays(), thanks for the report!


website: update ISCA 2024 tutorial speakers, content

Update ISCA 2024 tutorial speakers to include AMD speaker.
Update GPU content portion of tutorial to focus on PyTorch specifically, instead of either PyTorch or TensorFlow -- currently PyTorch is better supported and tested.

Thanks @mattsinc !  See you all soon!


Flutter file and .gitignore

...For some reason i had trouble stopping the .flutter-plugins-dependencies being checked in for all: https://github.com/getcouragenow/packages/pull/150/files#diff-ff0d90454de7682370acad84eb241a8eR74
Maybe you know the secret .gitignore syntax ??
Its will kick us hard if this is not fixed...
@winwisely112 can you fix it as i am sure you know that .gitignore syntax i am missing
Its in all the packages folders maybe...

I think this is not a .gitignore syntax issue. have you tried git rm --cached?


[prost-build] avoid cmake dependency

Today, prost-build tries to find protoc and if it fails, builds it from the vendored sources.
That adds the cmake dependency even though it may not be needed.
Could the default behavior be changed to:

look for protoc in PROTOC or PATH, then fail.
if vendored feature is enable, use this one only.

There is the PROTOC_NO_VENDOR env var but the cmake dep is still required.
On top of removing a dependency in some cases, it would also make clearer what is happening.

#657 fixes this


Feature request: Immutable file editing support (via frictionless pipelines)

Hello! I had a great chat with @romicolman today and she encouraged me to write some quick paragraphs describing features that would help it see adoption by me (and others in my field).
For my work (in the education and social sciences, but this extends to a lot of scientific research in general), tracking changes to data is very important. It is bad practice to edit files directly; instead it is much better to record manipulations as steps in a separate file. Right now, this is done via code (here's a great blog post detailing an example research data cleaning workflow using code)
In order for the ODE to be a viable no-code alternative for this, I need a workflow that allows me to edit data with the ODE but keep my original data file unchanged. One way this could be done would be to record all editing steps as a frictionless pipeline.
How this could look: I'd open a CSV file and make changes as usual, but when I save the file, instead of overwriting the original CSV, it would save a new file that would be a frictionless pipeline definition describing how the original CSV was transformed to accomplish my edits.
Then, I could open the pipeline definition at any point in the ODE and it would open as a regular data table, with my entire edit history loaded from the pipeline. At any point, I could also export my data package into a "rendered" version for distribution, where all the pipelines had been run to produce the "final" version of the files in a separate datapackage that I would distribute.
I realize this is a big feature request, but I cannot emphasize enough how important this capability is to a large number of potential users!

Just looking at this now for the first time, but I completely agree with Kyle on this. While a "no code" editor will undoubtedly be very useful for a lot of researchers (e.g., especially those in the basic or preclinical sciences who often manipulate and analyze their data using things like Excel, GraphPad, etc.), building in some guardrails to (1) prevent them from getting into trouble (e.g., not being able to replicate something they did); (2) yield a process that can be shared and/or plugged-in to existing systems for reproducible, shareable work; and (3) facilitate their learning and in some cases, ultimately migrating to programmatic work would be very valuable. Kyle's suggestion might not be too much work, depending on how the editor is implemented (I haven't had a chance to look at the code yet); it would probably be pretty straightforward to record editing actions one at a time to a file. One limitation is that the resulting code would be very difficult to read (i.e., you could only read it one line at a time, and it would be difficult to get an overall sense of what was being done), and would be very brittle. Nonetheless, this could be a very valuable feature, and there is certainly precedent for this type of thing.
For my part, most important would simply be tight but automatic version control of each version of the file as it is being edited. For relatively small files (and those are, I presume, the most common use case for this type of editor), using git in the background might be adequate here.


Update changelog for v2023.02.07 IDEA & CLion release

Please comment with any important changes that you want to make visible by adding to the Change log.

Bug fixes and internal cleanup.


[Trait]: helm repo support private ca (#4122)

Description of your changes
helm repo support private ca
https://github.com/kubevela/kubevela/issues/4122
How has this code been tested?
use vela addon enable ${me}/addon/fluxcd
Checklist
I have:

[x] Title of the PR starts with type (e.g. [Addon] or [Trait]).
[ ] Updated/Added any relevant [documentation] and [examples].
[ ] Unit/E2E Tests added.

I'm not sure if this pr can work. Maybe we should support this feature also in vela's apiserver. Let's block this pr until apiserver has supported.

I'm not sure if this pr can work. Maybe we should support this feature also in vela's apiserver. Let's block this pr until apiserver has supported.

How does apiserver support it? Do you mean data that supports certificate types? I want to get involved.

I'm not sure if this pr can work. Maybe we should support this feature also in vela's apiserver. Let's block this pr until apiserver has supported.

I think this PR does not fix  https://github.com/kubevela/kubevela/issues/4122, the issue is about addon registry, not Helm Component.


Protocol for closing DLC by mutual consent

The introduction specifies that in a DLC, contract collateral is locked in an output that can only be spent by mutual consent.
However, there is currently no protocol for requesting to close a DLC before cet_locktime with mutual consent.
Additionally, there are some concerns with requesting to close a DLC early. Say Alice wishes to exit her DLC early. Alice could simply provide a mutual close signature to Bob. However, if Bob does not respond this could result in a free option problem where Bob can simply wait for favorable market conditions and sign and broadcast when it is optimal for him.
After chatting with @nkohen it seems the simplest choices to solve this issue are invalidation or revocation (without going into the realm of verifiable encryption).
Invalidation could be solved by having Alice provide her own Input in addition to the DLC Input. If Bob doesn't respond after a certain amount of time, Alice could spend this input, invalidating this close tx.
A close_dlc Message could be formatted as following:

type ??? (close_dlc_v0)
data:

[32*byte:contract_id]
[signature:close_signature]
[u64:offerPayoutSatoshis]
[u64:acceptPayoutSatoshis]
[u16:num_funding_inputs]
[num_funding_inputs*funding_input:funding_inputs]

payout_spk and payout_serial_id from offer_dlc as well as payout_spk and payout_serial_id from accept_dlc could be used for constructing the close transaction
funding_inputs would be the input(s) provided by Alice that could be invalidated after a timeout.
Curious to hear if folks think this should be added to the spec. I personally think there are quite a few use cases for closing a DLC (such as requesting to close a position where a market maker is the counterparty).
This might also make more sense to add as an optional second layer interaction rather than to the core protocol.

I think a PSBT would serve better than a new tlv

PSBT could make more sense, but would still need to be communicated during closing negotiation, meaning a tlv (idk if psbt in a tlv makes sense). Although as mentioned by @nkohen this might make more sense to be part of a second layer interaction section in the spec.
A similar example of closing tlv is closing negotiation in LN #Bolt 2 spec, although this is part of the core protocol.

@matthewjablack What do you think about zero-feerate signature provided by Alice to Bob ?
Let's say at cet_locktime expiration, Alice sends a close_dlc_v0 with her signature to spend the 2-of-2 funding_txo. This signature is committed with SIGHASH_SINGLE | SIGHASH_ANYONECANPAY. It should enable Bob to complete the transaction with 0+ input/1+ output to fan out the remaining value from the funding_txo between feerate and his DLC balance ?

I think a PSBT would serve better than a new tlv

Strong disagree, PSBTs are the worst and shouldn't be used anywhere where we can have a specification instead.

Let's say at cet_locktime expiration, Alice sends a close_dlc_v0 with her signature to spend the 2-of-2 funding_txo. This signature is committed with SIGHASH_SINGLE | SIGHASH_ANYONECANPAY. It should enable Bob to complete the transaction with 0+ input/1+ output to fan out the remaining value from the funding_txo between feerate and his DLC balance ?

Would love a quick description of the details here as I haven't spent the time researching how those sighash codes work :)

Note from May meeting:
Extra input to mutual close to avoid free option, and in the future we will introduce revocation mechanism


Token generation failing when token hashing is enabled

Describe the issue:
During the APIM 4.3.0 release testing effort, we noticed that the token generation when token hashing feature is enabled is not working as expected. Upon further investigation, we found out that this issue was caused by a recent fix [1] done on SP caching. The issue occurs here because the SP is not removed from the AppInfoCache based on a newly added condition[3].
The original issue [2] related to user claims in a federated scenario talks about a possible improvement on the AuthorizationGrantCache. However, the fix done is affecting only the AppInfoCache. Due to this, the outdated SPs are not cleared from the cache after an update to the SP. Token generation when token hashing is enabled is not working as expected due to this as the client credentials comparison happens between the plain text value and the hashed value [4]. The flow works fine when the product is restarted as the cache is cleared upon the restart and the up to date SP configurations are fetched from the database.
In APIM's use cases, we update the SPs after creation so that they can be used even when the hashing feature is enabled. This is applicable to both the SP apps created for UI portals as well as the ones created for consumer apps. However, this flow is broken due to the behavioural change of the cache. The product has to be restarted every time we create a new app in order for the token generation to work.
[1] - https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/1963
[2] - https://github.com/wso2/product-is/issues/15127
[3] - https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/master/components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/internal/OAuthApplicationMgtListener.java#L146
[4] - https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/master/components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/util/OAuth2Util.java#L562
How to reproduce:
Enable token hashing feature and try to log into portals or try to generate tokens using a newly created SP.
Expected behavior:
Token generation works on first try when hashing is enabled.
Related issues:
https://github.com/wso2/api-manager/issues/2545

@JeethJJ are we good to close this issue?

Yes, we can close this.


Pull request for fsr.ac.ma

University official website URL:http://www.fsr.ac.ma
URL of IT related course is offered by the university: http://www.fsr.ac.ma/content/informatique-et-telecommunications

@Azze364 Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.