Add warning if stepped too slow and fix counting of steps.

Print warnings if the step-function of SimTriFingerCubeEnv is called at a too low
rate.  This way the users get some indication if their policy is taking too much time.
Count environment steps instead of robot steps to determine end of the episode.  This
fixes an issue that calling step() at a too low rate could cause in too many
environment steps to be executed.
Bump version to 1.1.1

I think we can ignore the failing flake8 test here (the issues are non-critical and not related to the changes in this PR).


split source and header files

This change should have gone to master actually, the port-to-OSX branch was merged already and should have been deleted.  Could you move the change to master?


parse_name error

<link rel="stylesheet" href="{% cdn "bootstrap/3.3.7" "bootstrap.min.css" %}">
get
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/3.3.7/css/bootstrap.min.css.map">

@n37r06u3 Will fix it. Thanks for reporting.

@n37r06u3 New version is not compatible with the previous one, but contains fix of this problem. Thanks again for reporting.


Do not override default middle click action without movement

Similar to ScrollAnywhere, it would be quite handy to let the middle click pass do its defaut action if released without any movement, or without the minimum amount of pixels.
It's quite the opposite of #5 since I really want middle click to paste some text if I don't move the mouse while clicking. It could be needed by a setting parameter, since it conflicts with the click-and-move default behavior.

I would accept a PR for this to be an option


Unexpected white space inclusion in signature (Pg error: function ... does not exist)

I tried to create a function like the following, with a space between the name and the opening paren:
delete_post	=	PGFunction( schema	= 'public'
				  , signature	= "delete_post (_id INT , _user_id INT)"
				  , definition	= """
RETURNS posts AS
$BODY$
DECLARE
	deleted_post	posts%ROWTYPE ;
BEGIN
	DELETE
	FROM		posts
	WHERE		id = _id
	RETURNING	*
	INTO STRICT	deleted_post
	;

	IF deleted_post.user_id != _user_id
	THEN
		RAISE 'User ID --> % is not the owner of post ID --> %' , _user_id , _id ;
	END IF ;

	RETURN	deleted_post ;
EXCEPTION
	WHEN NO_DATA_FOUND THEN RAISE NO_DATA_FOUND USING MESSAGE = 'Nonexistent post ID --> %' || _id ;
END ;
$BODY$
LANGUAGE plpgsql ;
"""
)

As you can see in alembic upgrade --sql head output, it is actually taking the space as part of the name:
(...)
CREATE FUNCTION "public"."delete_post "(_id INT , _user_id INT) RETURNS posts AS
(...)

So naturally, Postgre was giving me "error it doesn't" exist when trying to invoke the function with the original name

thanks, resolved in https://github.com/olirice/alembic_utils/pull/130
its available on pypi under version 0.8.3


[TODO] to-string for current classes

What needs to be done?
Implement to-strings for current classes, for debug purposes
When should this be done by? (optional)
Next iteration
Any other details? (optional)
Might be __str__ in Python
Task breakdown (optional)
Use this if you need to break the task down into several smaller tasks

[x] entity
[x] npc
[x] player
[ ] item
[ ] map

Player has dish and item inventories that is not coded yet. A placeholder have been placed in its __repr__


#[allow(clippy::assertions_on_constants)] does not work on older versions of Rust

This change: https://github.com/alexcrichton/cfg-if/commit/75e817fa2cdd9d3cb2c558fa91ba3dacdbfa8d73
Broke the build of the [directories](https://github.com/soc/directories-rs) (and dirs) crates:
https://travis-ci.org/soc/directories-rs/jobs/592813734
Could this code be replaced by a normal import of clippy, such that it keeps working on existing Rust versions?

Thanks for the report but this is a change in a test and this crate doesn't work to support 4-year-old verisons of Rust right now.


Docs are not building on docs.rs

Describe the bug
Due to https://github.com/rust-lang/cargo/pull/10343, the cargo args for docs.rs need to be removed.
Also rustdoc-scrape-examples is now enabled by default on docs.rs: https://github.com/rust-lang/docs.rs/pull/1954
To Reproduce
Look at https://docs.rs/crate/async-stripe/0.15.1
Expected behavior
Successful build
Code snippets
No response
OS
n/a
Rust version
n/a
Library version
0.15.1
API version
n/a
Additional context
No response

Thanks for raising this. I'll get it sorted!


WindowsError: [Error 32] The process cannot access the file because it is being used by another process

Description
Found issue with yotta 0.14.1 while using it with in-house CI system:
WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'C:\\Windows\\system32\\config\\systemprofile/.yotta\\cache\\1bea8e6b3fef24a15207945cd81f9be8bd88872422bf56ece08ee96d3dcea6f6'

Jobs affected (Examples):

http://e108747.cambridge.arm.com:8080/job/ybt/250/console
http://e108747.cambridge.arm.com:8080/job/ybt/253/console

Traceback
$ yotta build
info: get versions for core-util
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for greentea-client
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for unity
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for ualloc
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for cmsis-core
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for dlmalloc
info: download<EMAIL_ADDRESS>from the public module registry
Fatal Exception, yotta=0.14.1
Traceback (most recent call last):
  File "c:\python27\Lib\runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "c:\python27\Lib\runpy.py", line 72, in _run_code
    exec code in run_globals
  File<EMAIL_ADDRESS>line 9, in <module>
  File<EMAIL_ADDRESS>line 201, in main
    status = args.command(args, following_args)
  File<EMAIL_ADDRESS>line 46, in execCommand
    status = installAndBuild(args, following_args)
  File<EMAIL_ADDRESS>line 98, in installAndBuild
    install_status = install.execCommand(args, [])
  File<EMAIL_ADDRESS>line 58, in execCommand
    return installDeps(args, c)
  File<EMAIL_ADDRESS>line 126, in installDeps
    test = {'own':'toplevel', 'all':True, 'none':False}[args.install_test_deps]
  File<EMAIL_ADDRESS>line 655, in satisfyDependenciesRecursive
    test = test
  File<EMAIL_ADDRESS>line 440, in __getDependenciesRecursiveWithProvider
    _processed = _processed
  File<EMAIL_ADDRESS>line 440, in __getDependenciesRecursiveWithProvider
    _processed = _processed
  File<EMAIL_ADDRESS>line 419, in __getDependenciesRecursiveWithProvider
    test = test
  File<EMAIL_ADDRESS>line 319, in __getDependenciesWithProvider
    satisfyDep, specs
  File<EMAIL_ADDRESS>line 295, in satisfyDep
    self
  File<EMAIL_ADDRESS>line 640, in provider
    inherit_shrinkwrap = dep_of.getShrinkwrap()
  File<EMAIL_ADDRESS>line 317, in satisfyVersionByInstalling
    name, version_required, install_into, v, type=type, inherit_shrinkwrap = inherit_shrinkwrap
  File<EMAIL_ADDRESS>line 328, in _satisfyVersionByInstallingVersion
    version.unpackInto(working_directory)
  File<EMAIL_ADDRESS>line 447, in unpackInto
    _getTarball(self.url, directory, self.sha256)
  File<EMAIL_ADDRESS>line 100, in wrapped
    return fn(*args, **kwargs)
  File<EMAIL_ADDRESS>line 185, in wrapped
    return fn(*args, **kwargs)
  File<EMAIL_ADDRESS>line 168, in wrapped
    return fn(*args, **kwargs)
  File<EMAIL_ADDRESS>line 149, in wrapped
    return fn(*args, **kwargs)
  File<EMAIL_ADDRESS>line 296, in _getTarball
    origin_info = {'url':url}
  File<EMAIL_ADDRESS>line 137, in wrapped
    pruneCache()
  File<EMAIL_ADDRESS>line 127, in pruneCache
    removeFromCache(f)
  File<EMAIL_ADDRESS>line 190, in removeFromCache
    fsutils.rmF(f)
  File<EMAIL_ADDRESS>line 24, in rmF
    os.remove(path)
WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'C:\\Windows\\system32\\config\\systemprofile/.yotta\\cache\\1bea8e6b3fef24a15207945cd81f9be8bd88872422bf56ece08ee96d3dcea6f6'

@autopulated James, this issue is giving us pretty nasty CI behavior. If you have time please have a look at it. Thanks!

I experience this from time to time. My usual workaround is to execute the command multiple times. I have similar WindowsErrors when I do yt clean or yt up. Most of the time, 2x/3x does the trick

@0xc0170 It';s critical that build system doesn't fail like that. Especially if we run yotta in continuous Integration +100 times per nightly.

Mirrored to IOTSFW-2348.

I believe this is caused by antivirus software locking files for a short period after they're created.
yotta's recursive-remove function already has a workaround for this (retry the deletion in a loop...), so should be fairly straightforward to copy that over to the non-recursive remove.
As a short amelioration you could try increasing the cache size that you have set up (maxCachedModules:<number> in ~/.yotta/config.json), which should cause fewer items to be removed from the cache.

@autopulated James, dozens of instances of yotta in our CI try to access /.yotta/cache/* at the same time. This might not be antivirus thing IMHO, this might be a concurrent access to files.
Do we have in yotta (and in yotta.lib.access_common ) any locking mechanism on top of /.yotta/cache so when multiple instances try to access it they do not compete ?

I also would like yotat to work with maxCachedModules set to any number correctly.

Multiple instances should share the same cache, and it should be safe.
There is no locking mechanism, per se, but the cache is designed to be safe for multiple instance to use (files are only added to the cache via an atomic 'rename' operation once they have been downloaded elsewhere), and removed by an atomic 'unlink'.

@autopulated James, those are issues from today's nightly:
WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'C:\\Windows\\system32\\config\\systemprofile/.yotta\\cache\\tmp3gjhrd'

WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'C:\\Windows\\system32\\config\\systemprofile/.yotta\\cache\\f4c42da210c12354d4f17fa7f1d80953db0b08595ceb3ade466ac1da4d0c2a19'

WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'C:\\Windows\\system32\\config\\systemprofile/.yotta\\cache\\e980c9c9c306b96e3f98402a038d58f27e0c87a6adeea71c73f9f098e0601154'

WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'C:\\Windows\\system32\\config\\systemprofile/.yotta\\cache\\1982ab1f0124dc82bff025a1d757af81b8d8398e258b5259f28f1f824d659c4e'

WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'C:\\Windows\\system32\\config\\systemprofile/.yotta\\cache\\5612353b4bda7f716823f0e717805ed72ebdd830739f3848ed55794ac642c506'

WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'C:\\Windows\\system32\\config\\systemprofile/.yotta\\cache\\tmpdkquaw'

WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'C:\\Windows\\system32\\config\\systemprofile/.yotta\\cache\\d1fb276cb12ebfc9b62e4d8ed647f82a2971a04ed7ae35fc2a6da017a937ad03'

WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'C:\\Windows\\system32\\config\\systemprofile/.yotta\\cache\\1736937df92125787af1f1be88c9570c0419d568ee545450abb6106c48b076cd'

WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'C:\\Windows\\system32\\config\\systemprofile/.yotta\\cache\\b01a427decd3db247ebdf3f46cebbebd63b35c4577489f7da2b7a9fd047b78ed'

All have the same traceback:
Traceback (most recent call last):
  File "c:\python27\Lib\runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "c:\python27\Lib\runpy.py", line 72, in _run_code
    exec code in run_globals
  File<EMAIL_ADDRESS>line 9, in <module>
  File<EMAIL_ADDRESS>line 201, in main
    status = args.command(args, following_args)
  File<EMAIL_ADDRESS>line 46, in execCommand
    status = installAndBuild(args, following_args)
  File<EMAIL_ADDRESS>line 98, in installAndBuild
    install_status = install.execCommand(args, [])
  File<EMAIL_ADDRESS>line 58, in execCommand
    return installDeps(args, c)
  File<EMAIL_ADDRESS>line 126, in installDeps
    test = {'own':'toplevel', 'all':True, 'none':False}[args.install_test_deps]
  File<EMAIL_ADDRESS>line 655, in satisfyDependenciesRecursive
    test = test
  File<EMAIL_ADDRESS>line 440, in __getDependenciesRecursiveWithProvider
    _processed = _processed
  File<EMAIL_ADDRESS>line 440, in __getDependenciesRecursiveWithProvider
    _processed = _processed
  File<EMAIL_ADDRESS>line 419, in __getDependenciesRecursiveWithProvider
    test = test
  File<EMAIL_ADDRESS>line 319, in __getDependenciesWithProvider
    satisfyDep, specs
  File<EMAIL_ADDRESS>line 295, in satisfyDep
    self
  File<EMAIL_ADDRESS>line 640, in provider
    inherit_shrinkwrap = dep_of.getShrinkwrap()
  File<EMAIL_ADDRESS>line 317, in satisfyVersionByInstalling
    name, version_required, install_into, v, type=type, inherit_shrinkwrap = inherit_shrinkwrap
  File<EMAIL_ADDRESS>line 328, in _satisfyVersionByInstallingVersion
    version.unpackInto(working_directory)
  File<EMAIL_ADDRESS>line 447, in unpackInto
    _getTarball(self.url, directory, self.sha256)
  File<EMAIL_ADDRESS>line 100, in wrapped
    return fn(*args, **kwargs)
  File<EMAIL_ADDRESS>line 185, in wrapped
    return fn(*args, **kwargs)
  File<EMAIL_ADDRESS>line 168, in wrapped
    return fn(*args, **kwargs)
  File<EMAIL_ADDRESS>line 149, in wrapped
    return fn(*args, **kwargs)
  File<EMAIL_ADDRESS>line 296, in _getTarball
    origin_info = {'url':url}
  File<EMAIL_ADDRESS>line 137, in wrapped
    pruneCache()
  File<EMAIL_ADDRESS>line 127, in pruneCache
    removeFromCache(f)
  File<EMAIL_ADDRESS>line 190, in removeFromCache
    fsutils.rmF(f)
  File<EMAIL_ADDRESS>line 24, in rmF
    os.remove(path)
WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'C:\\Windows\\system32\\config\\systemprofile/.yotta\\cache\\f4c42da210c12354d4f17fa7f1d80953db0b08595ceb3ade466ac1da4d0c2a19'

Are you able to provide any type of fix for this this os.remove(path) behavior ?

what is maxCachedModules set to on your build server?

Can setting YOTTA_PREFIX make these cache files to be created in separate directory. If true, we can have a directory in Jenkins workspace and isolate concurrent builds.

Settings YOTTA_USER_SETTINGS_DIR will change the cache directory

Will changing user settings directory require yotta login? If yes then can't use in automation.

yotta 0.14.2 is now live, which includes the fix for this. Thanks for your patience!


npm module has no index file?

Hello, I was unable to use the latest release of this and had to use v1.1.0 for it to work. I didn't see an index file in the package..

Thanks @homathko!
Made a mistake in my .travis.yml and it pushed a bad package. Should be fixed in 1.2.1


[WIP] Sage on nixos

Motivation for this change
The current sage package rebuilds all its dependencies with its own build system. Thats a mess:

It takes a long time
Its basically 50% luck it works at all. Probably lots of failing tests too, I never tried.
Its hard to patch
It has to re-invent some nixpkgs features to patch the build system
Its hard to integrate with other sofware (own python etc.)
Its big

So this PR builds all the dependencies with nix instead. All the tests are passing.
It depends on (and includes) #39555, #39405, #38794 (without tests), #38787 and the mpfr update in staging. #39405 is responsible for most of the diff.
It is not quite ready to merge yet, because it updates to sage 8.2.rc4 (last rc) which is not released yet and I still need to fix some FIXMEs, do some TODOs, document patches and remove redundant dependencies.
I'm creating this WIP PR because 8.2 is about to be released and I don't want anybody else wasting time updating sage.
Testing this will take a lot of rebuilding because of the mpfr update (stdenv) and the python patch. If you want to review, your time is probably best spend waiting until I'm finished. If you want to give feedback already, that is of course welcome.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Impressive.

I think among the things to do before removing [WIP] is making sure you don't commit any clearly temporary files.

Thanks :)
Oh right the .orig files. I put the PR up in a bit of a hurry and missed those. Removed.

I'm not sure about the ofBorg error, it appears to have something to do with the node packages. I'm not sure about those anyways, I'm still hoping for some feedback from someone who knows more about node packaging.

@FRidh I am not sure if it is fully correct to call such packages unmaintained, as the Sage team is clearly capable and quite likely to perform maintenance on these packages if unavoidable (of course they can also drop the dependency, in which case we would find out the packages were indeed unmaintained along the way…)
On the other hand, maybe they are not worth putting in the global Python namespace, just as liborcus for LibreOffice lived together with it because nothing else was likely to ever use it.

Can somebody (@7c6f434c, @FRidh?) help me figure out how to avoid all the inherit xyz in default.nix? I think I need some of newScope, makeScope, import pkgs.path { overlays = [ (self: super: {...})] } and python.pkgs.override. But whatever I try, it either eats all my RAM in endless recursion, doesn't recognize the overrides or doesn't allow me to define new packages.
Could someone give me a minimal example how to create a new scope that overrides one python package and one regular pacakge? Something like:
pkgs = nixpkgs.giveMeNewScope (self: super: {
    glpk = super.glpk.overrideDerivation (...); # regular package
    numpy = super.python2.pkgs.numpy.override {}; # python package
    fantasy-py = self.python2.callPackage ./fantasy-py.nix {}; # new python package
});

I am not sure about proper structure of overrides for Nixpkgs nowadays.
Reimporting nixpkgs replacing user overlays with a sage-related one may
also be counterintuitive.
I am pretty sure you want something like:
self: super: rec {
pkg1 = super.pkg1.override {…};
callPackage = super.newScope self;
pkg2 = callPackage … { };
}

That defines a function right? But where do I call that function / give it as an argument?

I am not sure — reimporting with overlays sound dirty, packageOverrides are deprecated…

Yeah reimporting with overlays is what the manual suggested, but I think thats probably a different use-case. Do you know who to ask?

Oh? Maybe look up in git who added that advice to ask if it applies in the case you want…

That would be @grahamc in doc/functions.xml and @nbp in doc/language-frameworks/python.section.md. Any help would be much appreciated.

Alright I think this is ready for review now. The only remaining blocker for merge is #39555. Once thats merged and through staging I will rebase this PR.
If I can clarify anything, let me know.

thanks that's an awesome contribution. I wanted to use sage at some point, had some problems, wanted to fix it but gave up when facing the huge task (plus sage developers don't seem too receptive about packaging concerns). I am no maintainer but I believe merging the new packages in one or several PRs would make things easier. I've seen that a maintainer didn't want merging one (old) python package but I would advocate that sage is worth it ?

thanks that's an awesome contribution.

You're welcome :)

I wanted to use sage at some point, had some problems, wanted to fix it but gave up when facing the huge task (plus sage developers don't seem too receptive about packaging concerns).

There is some work ongoing upstream, but its not as much of an priority as I would like, true. I have also suggested all my relevant changes upstream[1] and at least none of them have been flat out rejected yet. So hopefully it will get better in the future.

I am no maintainer but I believe merging the new packages in one or several PRs would make things easier. I've seen that a maintainer didn't want merging one (old) python package but I would advocate that sage is worth it ?

I have already split most new packages, package fixes and package updates in seperate PRs (lots of them). They've all been merged by now. The only things remaining are the pythong packages @FRidh doesn't want in the main tree, packages that don't make any sense without sage (like pybrial) and sage itself.
I think more or less the only thing blocking this PR is #39555, which is itself only blocked on the staging branch being a mess right now (not sure if thats still the case).
So once staging is cleaned up, #39555 can be merged into staging. Then we have to wait for staging to be merged into master and then this can be merged.
[1] https://trac.sagemath.org/query?status=closed&status=needs_info&status=needs_review&status=needs_work&status=new&status=positive_review&reporter=gh-timokau&order=priority

Finally all the dependencies are in master. I've cleaned up the history and rebased on nixpkgs-unstable for easier testing.
I think this is ready for test/merge.
@GrahamcOfBorg build sage.lib

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: sage.lib
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Failure on aarch64-linux (full log)
Attempted: sage.lib
Partial log (click to expand)
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v92icw9c0xqhml86n5xl1yj7rsdd4q9q-pynac-0.7.16
shrinking /nix/store/v92icw9c0xqhml86n5xl1yj7rsdd4q9q-pynac-0.7.16/lib/libpynac.so.17.1.0
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v92icw9c0xqhml86n5xl1yj7rsdd4q9q-pynac-0.7.16/lib
patching script interpreter paths in /nix/store/v92icw9c0xqhml86n5xl1yj7rsdd4q9q-pynac-0.7.16
checking for references to /build in /nix/store/v92icw9c0xqhml86n5xl1yj7rsdd4q9q-pynac-0.7.16...
cannot build derivation '/nix/store/82rrk0bx5hjv91hbjsj9qfbyyrvjnv82-python2.7-sagelib-8.2.drv': 6 dependencies couldn't be built
error: build of '/nix/store/82rrk0bx5hjv91hbjsj9qfbyyrvjnv82-python2.7-sagelib-8.2.drv' failed

Failure on x86_64-linux (full log)
Attempted: sage.lib
Partial log (click to expand)
100  1340  100  1340    0     0   1413      0 --:--:-- --:--:-- --:--:--  1413
building '/nix/store/c1614jmjiipk1aaswckmjwxhlsrchg3c-zero_division_error_formatting.patch.drv'...

trying https://git.sagemath.org/sage.git/patch/?h=f79070ddd09fa0ad6b340b097bd8d690a7aa35f0
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1631    0  1631    0     0   3294      0 --:--:-- --:--:-- --:--:--  3294
cannot build derivation '/nix/store/vsvv2dadn6mbdf4vzy9h4p09f59zksma-sage-src-8.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ivpj81ax61c5gvp31xj3icidsrg9bzil-python2.7-sagelib-8.2.drv': 4 dependencies couldn't be built
error: build of '/nix/store/ivpj81ax61c5gvp31xj3icidsrg9bzil-python2.7-sagelib-8.2.drv' failed

https://git.sagemath.org/sage.git/patch?id=d6ad2e2ccd7bce3c46cd2ae2f349941808d4d825 seems to be 404

https://git.sagemath.org/sage.git/patch?id=d6ad2e2ccd7bce3c46cd2ae2f349941808d4d825 seems to be 404

I've fixed that link. I'm not entirely sure what caused that, but I've seen similar things happen before with the sage git server. I think it garbage-collects PR/ticket branches on force push or something.
Can we rely on hydras caching here or should I add all those patches to the patches folder? My goal is to ideally not have any patches in the nixPatches category for the next release (still in the process of upstreaming). But package-update backports will always be necessary.
@GrahamcOfBorg build sage.lib

Failure on x86_64-darwin (full log)
Partial log (click to expand)
Merge failed

Failure on aarch64-linux (full log)
Partial log (click to expand)
Merge failed

Failure on x86_64-linux (full log)
Partial log (click to expand)
Merge failed

@FRidh thank you for your review, I know it is asking a lot to review such a big PR. I agree with all your comments and fixed the issues.

On a sidenote, considering you're using Python here a lot, and in various ways (packages, envs, ...) I am interested in knowing how you experienced the tooling. Any issues? Thinks you like to see different? Perhaps better to discuss is in another thread though.

Some things took a while to figure out (especially the problem that makes the empty env necessary as described above). Overall I'm pretty happy though and much prefer the "hand-curated" approach to the completely auto-generated package sets.
In the beginning I used to just set PYTHONPATH manually, but the performance of that is atrocious (adding around a full second to startup time). So I'm glad that python envs exist.
Minor nitpicks/questsions:

Its a bit irritating that some conventions are a tiny bit different than the rest of nixpkgs. Close enough to confuse, but not the same. pname, just using python.pkgs instead of passing everything explicitly as arguments and overridePythonAttrs come to mind. I kind of prefer the way things are done in python, but it does hurt consistency a bit.

I don't quite understand why you do batch updates. Is there any practical reason for it? Why not handle python package updates like updates for any other package? For example the recent batch broke a few things for me and it is a bit hard to find the cause when everything is batched. Of course nobody can reasonably expect you to test every single update. So why not let the regular update bot create the updates and rely on the community to test and merge them?

I don't understand why pypi (with fetchFromPypi) seems to be the preferred source for packages. Wouldn't it be preferrable to pull things directly from source control if available? That cuts out the middle-man and makes it easier to quickly test with an unreleased version.

All in all I'm very happy with it, thank you for maintaining :)

@GrahamcOfBorg build sage.lib
Note that I'm still running the tests for the latest commit locally. Since the changes were pretty minor, I'm confident enough to push it already.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: sage.lib
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Failure on x86_64-linux (full log)
Attempted: sage.lib
Partial log (click to expand)
/nix/store/0qrzsvyxyfif38jsjfcsrnyh31ajf63h-sage-src-8.2/src/bin/sage-upgrade: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/0qrzsvyxyfif38jsjfcsrnyh31ajf63h-sage-src-8.2/src/bin/sage-list-experimental: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/0qrzsvyxyfif38jsjfcsrnyh31ajf63h-sage-src-8.2/src/bin/sage-fix-pkg-checksums: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/0qrzsvyxyfif38jsjfcsrnyh31ajf63h-sage-src-8.2/src/bin/sage-list-optional: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/0qrzsvyxyfif38jsjfcsrnyh31ajf63h-sage-src-8.2/src/doc/common/update-python-inv.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/0qrzsvyxyfif38jsjfcsrnyh31ajf63h-sage-src-8.2/bootstrap: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/0qrzsvyxyfif38jsjfcsrnyh31ajf63h-sage-src-8.2/sage: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/0qrzsvyxyfif38jsjfcsrnyh31ajf63h-sage-src-8.2...
cannot build derivation '/nix/store/h2n1zi1lqy494c82ih4smyfa8qi4b2db-python2.7-sagelib-8.2.drv': 3 dependencies couldn't be built
error: build of '/nix/store/h2n1zi1lqy494c82ih4smyfa8qi4b2db-python2.7-sagelib-8.2.drv' failed

Seems like there is a timeout for the cython build. That's a shame, I'd love to see if ofBorg can build sage.lib (basically sage but no tests or wrappers).

Failure on aarch64-linux (full log)
Attempted: sage.lib
Partial log (click to expand)
shrinking /nix/store/lw4qb9dam1gw6vhls6c2nbl9yfch0vmg-linbox-1.5.2/lib/liblinboxsage.so.0.0.0
shrinking /nix/store/lw4qb9dam1gw6vhls6c2nbl9yfch0vmg-linbox-1.5.2/lib/liblinbox.so.0.0.0
gzipping man pages under /nix/store/lw4qb9dam1gw6vhls6c2nbl9yfch0vmg-linbox-1.5.2/share/man/
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lw4qb9dam1gw6vhls6c2nbl9yfch0vmg-linbox-1.5.2/lib  /nix/store/lw4qb9dam1gw6vhls6c2nbl9yfch0vmg-linbox-1.5.2/bin
patching script interpreter paths in /nix/store/lw4qb9dam1gw6vhls6c2nbl9yfch0vmg-linbox-1.5.2
/nix/store/lw4qb9dam1gw6vhls6c2nbl9yfch0vmg-linbox-1.5.2/bin/linbox-config: interpreter directive changed from " /bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/lw4qb9dam1gw6vhls6c2nbl9yfch0vmg-linbox-1.5.2...
cannot build derivation '/nix/store/3x6255f7545yx5djh0bzq7x5cxld8b1n-python2.7-sagelib-8.2.drv': 3 dependencies couldn't be built
error: build of '/nix/store/3x6255f7545yx5djh0bzq7x5cxld8b1n-python2.7-sagelib-8.2.drv' failed

Does anybody know if the ofBorg evla failure is meaningful?

@timokau Yes, the eval failure is because you removed pkgs/development/python-modules/python-openid/default.nix in ddd67df71d4e3304b094397cc8c1afbd13202d72. See https://github.com/NixOS/nixpkgs/commit/2e41891e6d595b9acf484d7d349b17a7b35b6923.

Oh that must've been a mistake while fixing some merge conflict because I assumed that was my version of python-openid. I've rebased on latest master. Since python-openid for python2 is removed there, the eval should succeed now.

@timokau re: batch updates: when upstream of the language ecosystem has a package manager, it makes sense to track it via batch updates because the outcome is easier to reason about when comparing to the upstream situation.

Why is that? Python packages can depend on specific version (ranges) and if a update builds in nixpkgs and doesn't break any reverse-dependencies, I see no reason not to include it right then.

It's simply that just a small percentage of the python packages would be updated if we didn't have batch upgrades. And since the batch upgrades only happen on the unstable channel, people encountering broken builds should expect that this happens from time to time. Before a new release, we try to stabilize the python package set.
Btw, @FRidh proposed https://groups.google.com/forum/#!topic/nix-devel/koLvsCVjQcA, which would allow maintainers to opt out of batch upgrades.

And a semi-related note: I think you should ask to get commit rights; while it might make sense to keep a Sage update in a PR while it is a WIP, and to discuss with @FRidh if you want a non-default version of a python package from a maintained branch, it is quite likely that reviewing your sage changes is useless because you have learnt about Sage much more than everyone else counted together. Also, I do think you have enough experience that your opinion about a PR «ah, it's just an uncontroversial update and it is ready to merge» is as good as anyone's.

Congrats ! thanks for the awesome work to all involved.

@rbvermaa @domenkozar I think it is a good idea to give @timokau write access.

@timokau in the meantime, do you have 2FA enabled on GitHub?

Yes I have.

@rbvermaa @domenkozar was this ever discussed?


[1.2.1] - Re-Add a 1.17 Version

This does not have to do with the "True 1.17" support I wanna do.

Consider it done!


onRendered() doesn't seem to do anything.

Summary
I was wondering what exactly onRendered() does?
I'm looking for a prop that tells me when a new chapter's HTML is loaded in the Webview. I thought that's what onRendered() does. What does it do, and is there any other way of knowing when the content in the Webview's iframe changes?
What platform(s) does this occur on?
iOS
What workflow(s) does this occur on?
Expo Workflow
Environment (or package.json)
{
"name": "screens",
"version": "1.0.0",
"main": "expo/AppEntry.js",
"scripts": {
"start": "expo start",
"android": "expo start --android",
"ios": "expo start --ios",
"web": "expo start --web"
},
"dependencies": {
"@epubjs-react-native/core": "^1.4.5",
"@epubjs-react-native/expo-file-system": "^1.1.3",
"@epubjs-react-native/file-system": "^1.1.3",
"@expo-google-fonts/lora": "^0.2.3",
"@expo/vector-icons": "^14.0.2",
"@microsoft/fetch-event-source": "^2.0.1",
"@react-native-async-storage/async-storage": "^1.23.1",
"@react-native-community/hooks": "^3.0.0",
"@react-navigation/bottom-tabs": "^6.5.20",
"@react-navigation/native": "^6.1.17",
"@react-navigation/stack": "^6.3.29",
"@types/react": "~18.2.79",
"axios": "^1.7.2",
"eventsource": "^2.0.2",
"expo": "~51.0.14",
"expo-av": "~14.0.6",
"expo-document-picker": "~12.0.2",
"expo-file-system": "~17.0.1",
"expo-font": "~12.0.7",
"expo-image-manipulator": "^12.0.5",
"expo-linear-gradient": "^13.0.2",
"expo-sqlite": "~14.0.4",
"expo-status-bar": "~1.12.1",
"express": "^4.19.2",
"openai": "^4.52.0",
"openai-api": "^1.3.1",
"react": "18.2.0",
"react-native": "0.74.2",
"react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^2.17.1",
"react-native-paper": "^5.12.3",
"react-native-safe-area-context": "^4.10.5",
"react-native-screens": "^3.32.0",
"react-native-svg": "^15.3.0",
"react-native-webview": "^13.10.3",
"react-navigation": "^5.0.0",
"typescript": "~5.3.3",
"ws": "^8.17.1"
},
"devDependencies": {
"@babel/core": "^7.20.0"
},
"private": true
}
Your .epub file
No response
Minimal reproducible example
No response
I confirm that i have

[X] I looked for a solution to my problem in other open and resolved issues
[X] I checked the examples provided solve my problem
[X] I have verified that my problem is not caused by a third-party library
[X] I cloned the project environment examples and still the problem persists
[X] I'm using the latest available version of the library and its complements

onLocationChange provides the section/chapter belonging to the current location, I believe it can meet what you need

the useReader hook also provides information about the current section the reader is in

Amazing, thank you.


Two questions

This seems really cool, but I had a couple questions. Sorry to put these in an issue, wasn't sure how else to ask:

How do you handle resource overrides? By screen dimensions, landscape vs. portrait, etc.
Have you considered connecting the reactivity all the way back to the server, similar to how Facebook is doing it in React native? So a view might be connected all the way back to a json path on a server somewhere and a change on the server could propagate automatically all the way to the UI.

Thanks for doing this project, great to have some strong alternative views on Android dev!

Hi,
Asking here is absolutely fine, I will just use the "question" tag for such issues.

Overridden resources work in the same way as they would work with XMLs - you still can use text(R.string.foo) and your localized string would be set as a text. You still can use values.xml, colors.xml and friends. One thing that is different is layouts (because there is no more XML layouts).
Anvil provides a helper function isPortrait() so you can have two layout functions in code for landscape and portrait and toggle them with a ternary operator or a simple if/then/else. There is also an R() function that returns current Resources instance for the view context, so you can add "responsiveness" to your UI components depending on any suitable constraints (size, dpi, android version, language, phone model, day of week, user mood etc).

The idea is brilliant, but I don't think it should be part of Anvil core (because it will put the INTERNET permission into every Anvil app). But it would be a very helpful library on top of Anvil, great alternative to RetroFit. Currently I do it all manually - make an okhttp request, in the callback update the values and cache them locally, finally call Anvil.render().


Fix: Invoices extension - ( Add delete invoice to UI and api)

This pull request is work in progress to address issue
https://github.com/lnbits/lnbits/issues/1439
The current invoice extension doesn't allow deletion of invoices, and there was some copied code over javascript that was from the TPos extension.
Will fix code formatting and retest, this is a draft

Codecov Report

Merging #1496 (6f505f3) into main (891227b) will decrease coverage by 0.19%.
The diff coverage is 17.64%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #1496      +/-   ##
==========================================
- Coverage   49.58%   49.39%   -0.19%
==========================================
  Files         201      201
  Lines       13211    13227      +16
==========================================
- Hits         6551     6534      -17
- Misses       6660     6693      +33

Impacted Files
Coverage Δ

lnbits/extensions/invoices/crud.py
46.75% <11.11%> (-4.72%)
:arrow_down:

lnbits/extensions/invoices/views_api.py
69.62% <25.00%> (-4.00%)
:arrow_down:

lnbits/extensions/lnurlp/migrations.py
81.48% <0.00%> (-14.82%)
:arrow_down:

lnbits/db.py
81.20% <0.00%> (-10.07%)
:arrow_down:

lnbits/commands.py
61.40% <0.00%> (-1.76%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hey there, this extension has moved to: https://github.com/lnbits/invoices
Would you mind opening this PR there as well?

Hey there, this extension has moved to: https://github.com/lnbits/invoices
Would you mind opening this PR there as well?

OK Will do.


Refactor job names and dependencies

Change-type: minor
Signed-off-by: Kyle Harding<EMAIL_ADDRESS>

@balena-ci I self-certify!


(beta) support for TRPC v10

fixes #52
Description
Adds support for tRPC v10 via an opt-in option.

Hey @mwarger thanks for the PR!
I thought tRPC v10 is stable right now. So, if that was the case, is there any reason to keep this PR behind a flag?

Hey @mwarger thanks for the PR!
I thought tRPC v10 is stable right now. So, if that was the case, is there any reason to keep this PR behind a flag?

Just considering people that may be using this but not upgraded yet.
I also did this because the middleware and shield features aren't implemented. Wasn't sure how to do that yet.
Happy to remove it, or we can later.

Thx for your work ! 🚀

Any news about this PR @mwarger , @omar-dulaimi  ?

Any news about this PR @mwarger , @omar-dulaimi ?

I second that. We're currently just starting new project with trpc v10 and would like to use this generator as well.

@omar-dulaimi @JC-Perso @innellea @sparkinson-vhs This could be published behind a different tag if this is useful - would be nice to have other people test and provide feedback. I'm not familiar with trpc shield so I did not implement that.  I also skipped the middleware because I didn't need it.  I was just trying to get the basics out to start with which is why I put it behind a config option.  I can try to make this more feature complete this week.

Hey everybody, I have been a little bit busy lately. But I promise I'll upgrade the shield and shield generator to v10, so we could merge this PR.
@mwarger I think this project will support v10 only going forward, so there's no need for the flag.

I will take out the flag.

Great! Many thanks to you both.
On Thu, 22 Dec 2022 at 04:42, Mat Warger @.***> wrote:

I will take out the flag.
—
Reply to this email directly, view it on GitHub
https://github.com/omar-dulaimi/prisma-trpc-generator/pull/53#issuecomment-1361866788,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZP5W7OAY53IXJDX5RCTVY3WONFQ5ANCNFSM6AAAAAASZVT43E
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hey all, trpc-shield has been updated to support tRPC v10 now starting with trpc-shield v0.2.0(latest version is 0.2.1).
The other project prisma-trpc-shield-generato requires no changes at all.
Which means @mwarger can proceed with uncommenting the sections related to them after updating the trpc-shield dependency to latest version.
I will add a few comments to this PR since @mwarger is going to need them to use the shield.
We can release as soon as work on this PR is done :)

Hey @mwarger
I see that you have removed the flag. Could you also resolve my comments above so we could merge this?

@omar-dulaimi Changes pushed.  I have not used and am not familiar with trpc shield, so I gave it my best shot.  I have not tested it.  Please review and feel free to push any changes if needed.  Middleware should be good too, I think, but I haven't had a chance to test it.  I just wanted to get the basics out the door based on your comments.
I also updated dependency versions and updated the README.

Looks good to me, thank you @mwarger
Releasing soon

Hey all,
Released in https://github.com/omar-dulaimi/prisma-trpc-generator/releases/tag/0.8.0
Thanks for your work @mwarger.
Guys as you know this is an open source project that I work on in my free time(when I get any). So I really appreciate any help that comes to improve and maintain it.
Also, don't forget to star it and maybe even sponsor it if you find it useful at work :)
Thank you


Support displaying complex mime types in Output Widget

Fixes #9503

Codecov Report

Merging #10327 (1926b76) into main (ca8090c) will decrease coverage by 7%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           main   #10327    +/-   ##
======================================
- Coverage    63%      56%    -8%
======================================
  Files       204      203     -1
  Lines      9295     9289     -6
  Branches   1505     1505
======================================
- Hits       5934     5267   -667
- Misses     2893     3589   +696
+ Partials    468      433    -35

Impacted Files
Coverage Δ

src/platform/export/exportToPythonPlain.ts
21% <0%> (-66%)
:arrow_down:

.../debugger/extension/helpers/protocolParser.node.ts
15% <0%> (-64%)
:arrow_down:

src/platform/errors/types.ts
19% <0%> (-62%)
:arrow_down:

src/platform/api/kernelApi.ts
11% <0%> (-62%)
:arrow_down:

src/platform/progress/statusProvider.ts
18% <0%> (-56%)
:arrow_down:

src/platform/export/fileConverter.ts
33% <0%> (-50%)
:arrow_down:

src/platform/export/exportUtil.node.ts
26% <0%> (-47%)
:arrow_down:

src/platform/export/exportUtil.ts
29% <0%> (-45%)
:arrow_down:

src/platform/errors/kernelProcessExitedError.ts
42% <0%> (-43%)
:arrow_down:

...rc/platform/errors/jupyterKernelDependencyError.ts
57% <0%> (-43%)
:arrow_down:

... and 58 more

to grok your algorithm. I just hope we have enough tests.

Yes, I think we have enough. Wil test a little bit more and look for different output widget usages and add more tests.

@rchiodo I'm going to merge this and will submit feature request (discuss with Rob & Matt) for the enhancements.


Redirect bug, never ending loop

If you have two inline redirects in a row bad things happen.

{@this} is {@ok}
this {@is} {@not}

The problem is actually extra whitespace inside the redirect.
{@this is problematic     }


First node in graph has no mouse event

The first node does not trigger an onClick or a onMouseOver event.

@awaterho Fixed in 1.3.0-beta.3


Feature/integration pytorch tabular

In this PR I have integrated pytorch-tabular inside lightning flash, unsing the Adapter like what is already been done with icevision and pytorch-forecasting.
I have added some parameters inside TabularData in order to have all the info required by the different models implemented in pytorch tabular.
And I have added tests and cli for TabularRegressor
Fixes #950

Thank you @ethanwharris for your comments 😃 I have done the changes that you have suggested, and I have done a refactoring of TabularClassifier, TabularRegressor because I have noticed that before I didn't set correctly metrics, loss functions, etc ... because it is needed to be set in the model defined by pytorch-tabular.
Let me know if you have any other observation 😃


Broken OpenAI composite Pydantic structured-output

Description of the bug:
Here's MRE:
# /// script
# requires-python = ">=3.10"
# dependencies = [
#     "google-generativeai==0.8.3",
#     "openai==1.55.3",
#     "pydantic==2.10.2",
# ]
# ///
import os
from typing import Annotated
from openai import OpenAI
from pydantic import BaseModel, Field

client = OpenAI(
    api_key=os.environ["GOOGLE_AI_API_KEY"],
    base_url="https://generativelanguage.googleapis.com/v1beta/openai/",
)

class FooWorking(BaseModel):
    foo: Annotated[str, Field()]

class Bar(BaseModel):
    bar: Annotated[str, Field()]

class FooNotWorking(BaseModel):
    foo: Annotated[Bar, Field()]

# Will work
client.beta.chat.completions.parse(
    model="gemini-1.5-flash",
    messages=[
        {"role": "user", "content": "What is bar?"},
    ],
    response_format=FooWorking,
)
print("First call worked!")

# Will NOT work!
client.beta.chat.completions.parse(
    model="gemini-1.5-flash",
    messages=[
        {"role": "user", "content": "What is bar?"},
    ],
    response_format=FooNotWorking,
)

Both calls work just fine on the OpenAI API. Just a hypothesis, but maybe handling of $defs is broken/unsupported on Google side. Another thing completely is that the vanilla 400 error message is not informative/helpful:

openai.BadRequestError: Error code: 400 - [{'error': {'code': 400, 'message': 'Request contains an invalid argument.', 'status': 'INVALID_ARGUMENT'}}]

Actual vs expected behavior:
2nd call should work. If this is a limitation, should that be documented in the docs:

https://ai.google.dev/gemini-api/docs/structured-output?lang=python
https://ai.google.dev/gemini-api/docs/openai

Any other information you'd like to share?
No response

still having this issue

This doesn't work for me either. I have a simpler case:
{
  "model": "gemini-1.5-flash",
  "messages": [
    {
      "role": "system",
      "content": "You are a helpful assistant."
    },
    {
      "role": "user",
      "content": "Extract first book r...umane way of living."
    }
  ],
  "temperature": 0.0,
  "max_tokens": 8192,
  "response_format": {
    "type": "json_schema",
    "json_schema": {
      "name": "BookReference",
      "schema": {
        "properties": {
          "title": {
            "title": "Title",
            "type": "string"
          },
          "author": {
            "anyOf": [
              {
                "type": "string"
              },
              {
                "type": "null"
              }
            ],
            "title": "Author"
          }
        },
        "required": [
          "title",
          "author"
        ],
        "title": "BookReference",
        "type": "object",
        "additionalProperties": false
      }
    }
  }
}

and I get the extremely unhelpful error: INVALID_ARGUMENT which doesn't tell me what the invalid argument is!
Tool use doesn't work either because it returns an invalid toolCalls response in the ChatCompletion vs. the valid tool_calls response.
This feels like the openai compat was rushed to ship without any validation of whether non pure text scenarios actually work. For me, structured outputs, tool use, and images are all broken in the OpenAI layer.
I was really hoping to have this as a drop-in replacement, but it doesn't seem to be the case.

It seems like it the API lacks support for certain typing classes like Annotated, Union, Optional. I got it working withclass Location(BaseModel):     city: str = Field(None, description="City of the event")


Encoding error when trying to save a file on Windows

Hello!
I am getting an error when I try to execute the following code to save an agent's information to a json file:
String json = pyCommunicator.toJson(this);
pyCommunicator.run(
	"with open('./model-output/output-exp%s-rep%s.json', 'w', encoding='ISO-8859-1') as f:",
	String.format("  f.write('''%s''')", json),
	"  f.close()"
);

Anylogic console:
at com.anylogic.engine.Engine.error(Unknown Source)
	at com.anylogic.engine.Agent.error(Unknown Source)
	at com.anylogic.engine.Utilities.error(Unknown Source)
	at com.anylogic.libraries.pypeline.PyCommunicator.run(PyCommunicator.java:583)
	at com.anylogic.libraries.pypeline.PyCommunicator.run(PyCommunicator.java:598)
	at prueba.Main.saveOutput(Main.java:640)
	at prueba.ParametersVariation.onEngineFinished(ParametersVariation.java:388)

It only occurs on Windows. I can run it on Linux with no errors, but when inspecting the output json file, I see that latin characters (like ñ or á) contained in the Anylogic model are replaced with question marks.
I think it is somewhat related to encodings, but I have already tried with utf-8, utf-16 and ISO-8859-1 on the open() code line this way:
"with open('./model-output/output-exp%s-rep%s.json', 'w', encoding='ISO-8859-1') as f:",
Thank you😄

Hi!
Looks like my lack of knowledge about handling various string encodings caught up to me!
After looking into this, the problem is with my Python code that handles incoming binary data from Java (i.e., AL models). I have it set to only convert using utf-8 (reference) - what I assumed would be ok for everything - causing it to fail when any latin characters are passed.
For a fix, I've added extra handling to use ISO-8859-1 as a fallback.
And to validate this, I looped thru all characters in utf-8, utf-16, and iso-8859-1 (thanks to this SO post) and checked whether Pypeline would throw an error when running: pyCommunicator.run(String.format("x='%s'", chr)); In each, only 5 failed, but they were due to unhandled syntax reasons (e.g., newline characters, single quote, backslash).
I've pushed the changes but will include this as part of the next release. For convenience, you can download an updated jar file: Pypeline.zip. I'm closing but feel free to let me know if you still have issues with it!


Fix issue where default scopes are not set

Adding default scopes to Operation parameters o initialization
issue : https://github.com/AzureAD/ad-accounts-for-android/issues/827

Should we consider using a Set to hold the scopes? How do we ensure that scopes don't get added multiple times?

Set would have been nicer, but needs some API changes w.r.t Msal and also probably public facing API. For now I have added logic in the set method here to avoid duplication here : https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/383/files#diff-37c9340cd26ba11cb1d207ed29a72f9bR67

Yuck - we should make a backlog item for that. As for that check, you'll want to trim() and do the check as case insensitive -- the case for a Set (with a proper Comparator) getting stronger already 😅

I can make it in the morning, currently on a mobile

Thanks @iambmelt , I will add a backlog item, scopes are case sensitive per rfc here . Trimming is good idea.

I added a comment to your other PR on this topic.  FYI - In AAD scopes are not case sensitive.  One of the reasons that we moved validation of requests to the strategy associated with the issuer.  Some IDPs will follow the spec and others will not.

Closing this , opened a new one here : https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/386


Keep a Changelog .com?

Maybe you should follow https://keepachangelog.com/en/1.0.0/ because it is a standard and it would suggest making your changelog correct markdown. Currently, you have some style errors like more than one top level item (#) and indented lists.

Additionally, if you ever want to automatically generate the changelog, you can check out git-cliff 🐻

example config: https://github.com/orhun/git-cliff/blob/main/examples/github.toml
example output: https://github.com/orhun/git-cliff/blob/main/CHANGELOG.md

Sorry, I don't like the git-cliff commit message style. Changelog is a chore for me that I don't like, and keep forgetting about it. Automated changelog won't be smarter than what commits say, so I encourage you to check the commit history.


Raise default protocol detection timeout

This is to accommodate slow client, fixes https://github.com/istio/istio/issues/24379
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@bianpengyuan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bac575272409b05065fd103046365868a8aec117
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bac575272409b05065fd103046365868a8aec117
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
bac575272409b05065fd103046365868a8aec117
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram @howardjohn @costinm ptal, thanks!

I think inbound is not affected by the default here. It is overridden by a flag or env var.

good point - didn't remember that. So there is still the question of all outbound vs outbound on <IP_ADDRESS> HTTP only. Probably all outbound is fine...

In response to a cherrypick label: new pull request created: #25015

This should probably be cherry-picked to release-1.5 branch too?

IIUC the change add http inspector to outbound listener is only in 1.6: https://github.com/istio/istio/pull/17169 so no need to cherry-pick to 1.5.


Spritesheet Animation added

Fixes
#320

Description
I have added a Spritesheet Animation using html,css,js and spritesheets

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New project (non-breaking change which adds functionality)

How Has This Been Tested?
Tested on local browser

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have included a README.md file
[x] My project follows this structure: Domain Folder/ Project Name Folder/ Project files and Readme.md files
[x] I have added demonstration in the form of GIF/video file
[x] I am a GSSoC'22 Participant

@heet-kumar Kindly review my PR


Cannot send message using return key on iOS WebView

Describe the bug
I'm embedding a web with vue-advanced-chat in an iOS app using the default WebView. Everything works fine except sending message using "return" key on the soft keyboard. When "return" key is pressed, the entire textarea is replaced with "undefined". Sending using send button on the footer works, though. Shift+Enter for multi line also works.
Steps to reproduce
Please see attached GIF and screenshot.
Expected behavior
Hitting "return" key should send the message.
Screenshots
The problem:

Inspecting in safari devtools gives this error:

Device (please complete the following information)

OS: iOS 12 on iPhone 8 simulator
Browser: built-in safari/webkit WebView
Package version: 1.2.1

Update: This issue also happened in iOS' default safari browser (not inside webview). Downgrading vue-advanced-chat to version 1.1.2 solves this issue. So maybe I'll stick to version 1.1.2 for now (I didn't try version 1.2.0).


Missing TOC or Jump-Offs from README.md

What I am missing is a TOC or a set of jumping off links in the README ... right now if I look at the repo, the README is standalone and does not guide me towards the initial chapters.
Look at https://github.com/Haufe-Lexware/api-style-guide for an example.

Ugh,
Can't we just turn it into a gitbook? I created a book here https://www.gitbook.com/book/haufe-lexware/haufe-group-docker-book-startup-guide/welcome
in the Haufe-Lexware Dev domain but I don't have enough juice couple it to the "Docker Style Guide". To do this, you go into
Settings > GitHub
In the GitHub Repo section you should be able to hook up  the style guide repo as the source for this book. Otherwise the links are in SUMMARY.md?.
Scott

From: Holger Reinhardt<EMAIL_ADDRESS>Sent: Wednesday, January 4, 2017 11:25 PM
To: Haufe-Lexware/docker-style-guide
Cc: Subscribed
Subject: [Haufe-Lexware/docker-style-guide] Missing TOC or Jump-Offs from README.md (#15)
What I am missing is a TOC or a set of jumping off links in the README ... right now if I look at the repo, the README is standalone and does not guide me towards the initial chapters.
Look at https://github.com/Haufe-Lexware/api-style-guide for an example.

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/Haufe-Lexware/docker-style-guide/issues/15, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFrBo37Y_15yUrBbL12Y9x_IdUTX__HFks5rPBxrgaJpZM4LbIsN.

We should do both .. look at https://github.com/zalando/restful-api-guidelines for example .. they have the Gitbook at http://zalando.github.io/restful-api-guidelines/ but since some folks come in through the plain repo view they provide a "basic" getting started outline also in the readme.md

Clicking on the URL you provided I get a login page to gitbook

?Ok. Got it. I will add the links today. The first feedback for the book was both good and helpful, so I will include the links with these changes.
Scott

From: Holger Reinhardt<EMAIL_ADDRESS>Sent: Thursday, January 5, 2017 3:08 PM
To: Haufe-Lexware/docker-style-guide
Cc: Speights, Scott; Assign
Subject: Re: [Haufe-Lexware/docker-style-guide] Missing TOC or Jump-Offs from README.md (#15)
We should do both .. look at https://github.com/zalando/restful-api-guidelines for example .. they have the Gitbook at http://zalando.github.io/restful-api-guidelines/ but since some folks come in through the plain repo view they provide a "basic" getting started outline also in the readme.md

You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/Haufe-Lexware/docker-style-guide/issues/15#issuecomment-270651643, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFrBoy4R-zMSMnS6TJ1__3Gb232bA-IEks5rPPlKgaJpZM4LbIsN.

Hi Holger,
OK. I will turn it into “book format”. I need to change the format anyway to something a little more booky and less FAQ-y. So, I have pointed our test candidates at the book on my repo https://sspeights.gitbooks.io/haufe-group-docker-book/content
VG, Scott
From: Holger Reinhardt<EMAIL_ADDRESS>Sent: Wednesday, January 4, 2017 11:26 PM
To: Haufe-Lexware/docker-style-guide<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [Haufe-Lexware/docker-style-guide] Missing TOC or Jump-Offs from README.md (#15)
What I am missing is a TOC or a set of jumping off links in the README ... right now if I look at the repo, the README is standalone and does not guide me towards the initial chapters.
Look at https://github.com/Haufe-Lexware/api-style-guide for an example.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/Haufe-Lexware/docker-style-guide/issues/15, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFrBo37Y_15yUrBbL12Y9x_IdUTX__HFks5rPBxrgaJpZM4LbIsN.

merged pull #16 . very nice


Team table restructure and routing

Consolidated separate NHL, NFL, MLB, NBA tables into a unified Team table structure, implemented cohesive logic. Introduced product tags for teams and established corresponding routes. Conducted thorough testing to ensure proper functionality, including successful seeding of tables. Confirmed server connectivity and responsiveness of leagues and teams routes. Ready for a pull request.

Yes, that's all working and looks good.

I'd like to approve this, so far it's just letting me add a comment.  Green light from me.


Unable to retrieve Server Hardware details  by filter “ServerName” but able to do it through filter “name”

Scenario/Intent
Using python-hpOneView/examples/server_hardware.py
to get server hardware details though method
server_byField=oneview_client.server_hardware.get_by(“filer”, “filterValue”)
WHEN , filer=“ServerName” I am getting empty list.
Environment Details

**OneView SDK Version: release/4.8.0
OneView Client API Version: 4.10.01-0348545
**Python Version: 3.7
**Platform: macOS

Steps to Reproduce

Retrieve a Server hardware details through server_hardwares.get_by(" ServerName”,server_name)

Expected Result
It should return a list with one element
Actual Result
It returns empty list .
But when filter is is “name” instead of “ServerName” it returns a list with one element as expected

@Imranatnisum, Name and ServerName are different fields and values of those fields are not the same.
As per the API doc, please see the difference,
Name :
For blade servers, it is the location-based name of the server, which is formed by concatenating the enclosure name and the bay number. For rack servers, it is the serial number prefixed by word "ILO" e.g. ILOUSE31835LS
ServerName:
The name of the server as reported by the iLO. The iLO gets this information from a running operating system that has monitoring software installed, like Agentless Management Service.
Are you passing the name field value to filter the resource by ServerName ?

I am passing value of ServerName with filter ServerName..But i am getting empty list .I very well acknowledge that values are different for filters "name" and "ServerName"

@Imranatnisum , Thanks for the update.
Basically get_by calls get_all method with filter, Please try the below code update if that working for you?
server_hardware.get_all(filter="ServerName='name of the server'")

@sijeesh , Thank u very much
server_hardware.get_all(filter="ServerName='name of the server'")  works as expected
But , I wonder why  server_byField=oneview_client.server_hardware.get_by(“filer”, “filterValue”) gives empty list!!!

@Imranatnisum , Need to have a look into this, maybe there is some issue with the encoding of the filter value. will update you soon.


Inform users about password change

BSI cloud computing compliance (C5) - PSS-05:
The user is informed about changing or resetting the password
Today, a user is being notified when the password was reset, but not when the password was changed.
Acceptance criteria

[ ] When a password was changed, then the corresponding user receives an email informing about that change

Considerations

Discussion: 2/ Inform users/managers of sensitive actions

fyi @cedegi

@mffap do you know if that only applies to password changes? In my mind it could also be applicable to passwordless and mfa, otp changes.

@mffap do you know if that only applies to password changes? In my mind it could also be applicable to passwordless and mfa, otp changes.

Yes. That's why I linked the original discussion about this feature (considerations). We could expand this. The must requirement for this task is password change.

Ok, good to know 👍

As we start with SCRUM in Janaury I have created a user story for this task.
Feel free to track the following issue, as we close this one to avoid duplicates: https://github.com/zitadel/zitadel/issues/4912


Add to asset pipeline.

This PR makes the NeatJSON JS available in the Rails asset pipeline.
With these changes, including the NeatJSON JS in a Rails app is as easy as adding this to app/assets/javascripts/application.js:
//= require neatjson

Thanks for the idea, work, and pull request. As it stands, the javascript folder has an HTML file that relies on the js library to be relatively present. Renaming the file as you have will break this.


[wallet-ext] - update to wallet

Description
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Current dependencies on/for this PR:

main

PR #11485   👈

This comment was auto-generated by Graphite.


Updated MultiNli, DAC, and BBC Hindi new datasets for text classification

Description

Updated MultiNli, DAC, and BBC Hindi new datasets, and created dataset interface for text classification. The data preprocessing is hidden to users now and use one function call will directly generate training and testing dataset for Transformer models.
Related Issues

Checklist:

[ ] My code follows the code style of this project, as detailed in our contribution guidelines.
[ ] I have added tests.
[ ] I have updated the documentation accordingly.

Close this pull request due to the change of the sequence classification code.


Add omit if null option to MappableField

Some data types requires null fields to be omitted in output json, is it possible to support such behavior via MappableField option?

There is the 'ignoreNull' property on '@MappableClass' for this.

I meant ability to override it for a particular field, rather than whole class, is it possible?

I might add this as a feature in the future.
For now you can always just write a custom hook to do this.

This feature would be appreciated!
Although I don't know what hook could do here, return void value?

There are multiple ways this could be implemented using hooks.
One way could work like this:

@MappableClass(hook: RemoveIgnoredFields())
class Person {
  final String? name;
  // Add this hook to every field that should be ignored if null
  @MappableClass(hook: IgnoreNull())
  final String? age;

  Person(this.name, this.age);
}

class IgnoreNull extends MappingHook {
  const IgnoreNull();

  @override
  Object? afterEncode(Object? value) {
    if (value == null) {
      return _ignore;
    }
    return value;
  }
}

class RemoveIgnoredFields extends MappingHook {
  const RemoveIgnoredFields();

  @override
  Object? afterEncode(Object? value) {
    if (value is Map) {
       return {...value}..removeWhere((_, v) => v == _ignore);
    }
    return value;
  }
}

final _ignore = Object();


WIP Remove replace statement from hive/apis

This is just a proposal, so this is totally up for discussion, just my thoughts:
The existing replace statement doesn't seem to be strictly needed as we can just update the dependency when we are ready with go get -u<EMAIL_ADDRESS>Furthermore, removing it makes importing Hive's API in other modules much easier as the replaces don't need to be carried forward.
E.g. https://github.com/openshift/osdctl/blob/115f5f5b8abea2956ad73845555bcc92bd1728b1/go.mod#L172 needs to maintain a corresponding replace.
Finally, by getting the latest release-4.12 of openshift/api, we also pickup the latest dependencies from upstream K8s as they iterate on golang.org/x/net and golang.org/x/text

No idea why that replace was put there originally; but if your proposal passes tests, I see no reason not to do it.
I think you'll need to make the same changes in the root go.mod as well though. Expect to see a verify failure in modcheck.

/retest

Looks like there are features used that require OCP 4.13, specifically things like machineapi.GCPShieldedInstanceConfig, machineapi.SecureBootPolicyEnabled, and machineapi.SecureBootPolicyEnabled so pinning to 4.13 instead.
The coverage failure is interesting, planning on looking at it a bit tomorrow

I can reproduce it! It's a flaky test due to a race condition:
cd ./apis
# Run this a couple times in a row
go test -race -count 50 -run TestGetName ./helpers

The errors often look like (but are not always consistent themselves):
--- FAIL: TestGetName (0.00s)
    namer_test.go:58: Got unexpected result. Expected: nv3nrxjzgyujzcs8gih1nc4gvx95bzirb13ohr3gdjy5jwlrjksduiakfd6upco4gxn8zb9dee9h3pn0yvlkpo8cw3yyp2j29xc0wrxoka00vdck6devixaoq0q-rzgma1kiyqtursiqmo8uoj3jwaiu9bja4ss92egv2z0ps1e8vtfihxmq2wvqezd-ohfw-i-quwxygmt2yqcmn1xsmp6jjrrb9nra2-iujsativs2bhq75u77-h6-omm0-deploy Got: nv3nrxjzgyujzcs8gih1nc4gvx95bzirb13ohr3gdjy5jwlrjksduiakfd6upco4gxn8zb9dee9h3pn0yvlkpo8cw3yyp2j29xc0wrxoka00vdck6devixaoq0q-rzgma1kiyqtursiqmo8uoj3jwaiu9bja4ss92egv2z0ps1e8vtfihxmq2wvqezd-ohfw-i-quwxygmt2yqcmn1xsmp6jjrrb9nra2-iujsativs2b-13a03bf3-deploy
    namer_test.go:58: Got unexpected result. Expected: nv3nrxjzgyujzcs8gih1nc4gvx95bzirb13ohr3gdjy5jwlrjksduiakfd6upco4gxn8zb9dee9h3pn0yvlkpo8cw3yyp2j29xc0wrxoka00vdck6devixaoq0q-rzgma1kiyqtursiqmo8uoj3jwaiu9bja4ss92egv2z0ps1e8vtfihxmq2wvqezd-ohfw-i-quwxygmt2yqcmn1xsmp6jjrrb9nra2-iujsativs2bhq75u77-h6-omm0-b46f2071 Got: nv3nrxjzgyujzcs8gih1nc4gvx95bzirb13ohr3gdjy5jwlrjksduiakfd6upco4gxn8zb9dee9h3pn0yvlkpo8cw3yyp2j29xc0wrxoka00vdck6devixaoq0q-rzgma1kiyqtursiqmo8uoj3jwaiu9bja4ss92egv2z0ps1e8vtfihxmq2wvqezd-ohfw-i-quwxygmt2yqcmn1xsmp6jjrrb9nra2-iujsativs2bhq75u77-b46f2071

/hold
Should wait for #1979 and be rebased to make sure tests pass

/unhold

Yup, this is passing tests, and is rebased to pick up the go1.20 bump, so I'm happy with it. Thanks for doing this, @mjlshen. It makes our repo better.
/lgtm


chore(deps): update dependency @relative-ci/agent to v2.0.0

This PR contains the following updates:

Package
Type
Update
Change

@relative-ci/agent (source)
devDependencies
patch
2.0.0-beta.0 -> 2.0.0

Release Notes

relative-ci/agent
v2.0.0
Compare Source
BREAKING CHANGE: Update bundle-stats to v3
https://relative-ci.com/releases/2021-05-may-service-update
https://github.com/relative-ci/bundle-stats/releases/tag/v3.0.0

Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled due to failing status checks.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box.

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will now ignore this update (2.0.0). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


Code context when deploying only binary

Hey, maybe I'm doing something wrong or I'm missing some config or whatnot, but I'm not able to get source code context to appear in the Sentrt when running the compiled binary on another machine (typical use: build on CI, deploy to another server (bin only), run there). The paths are relative to where I built the binary and the source code is missing (I see only file/function names).

+1 on being able to resolve context somehow when binary is compiled in CI and run as binary elsewhere

It'd still require source code to correctly map the frames to a given file. Go binaries doesn't provide enough information to do that, as they are compiled down to machine code. It'd be possible to somehow perform mapping to external files, but environment running the binary would still need access to the corresponding files.

Absolutely, but it'd be better than nothing to be able to provide some source code if a user wants a mapping. Like the ability to add sourcemaps for JS.


update informal words

I added new informal words regexs

Hi @reza1615!  Thanks for your pull request.  It looks like you're behind master.  Could you try rebasing and pushing again?  If you're not sure what I mean, let me know and I'll try to see if I can resolve the issues.

Hi @halfak  now it should be ok

Needs rebase

Looks like this is covered by some work that @Ladsgroup did.  I'm going to close, but please re-open if I'm mistaken.


[Improvement/Suggestion] Reset stats button

Checklist

[x] I have read the FAQ
[x] I have checked if this issue already exists (both open and closed issues)
[x] I am using the most recent version of pogom from the master branch
[ ] If this is an installation issue, I am posting my OS, OS version, python version, pip version
[ ] I'm posting the complete log
[x] I'm using a descriptive title for this issue

My Issue
Basically, a button on stats screen to reset the list.
It is good because sometimes I want to know if a pokemon is going to show up in a specific area, and I have to check and see how many I already found, and then check if it is the same after a few hours.
...

It is good because sometimes I want to know if a pokemon is going to show up in a specific area, and I have to check and see how many I already found, and then check if it is the same after a few hours.
I don't see the problem here tbh.

If you want to reset stats, delete the "pogom.db" file (or rename it).


Can't read mail content with out Content-Type

There is my raw mail:
Precedence: list
List-Post<EMAIL_ADDRESS>List-Id: <xxx.com>
Received: from localhost (unknown [xx.xx.xx.xx])
	by mail-m12759.xxx.com (Hmail) with ESMTPA id 504614A019B
	for<EMAIL_ADDRESS>Sat,  3 Sep 2022 07:02:54 +0800 (CST)
To<EMAIL_ADDRESS>Subject:My test subject
X-HM-Spam-Status: e1kfGhgUHx5xxxxxxxxxxgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly
	tZV1koWUFITzdXWS1ZQUlXWQ8xxxxxxxxxxxxhlCTkoZHx5KSkxKQlUTARMWGhIXJBQOD1
	lXWRgSC1lBWU5PVU1DVUhCxxxxxxxxxaDxIVHRRZQVlPS0hVSklLQ05NVUpLS1kG
Message-Id<EMAIL_ADDRESS>Date: Sat, 03 Sep 2022 07:02:55 +0800 (GMT+08:00)
From<EMAIL_ADDRESS>X-HM-Sender-Digest: e1kMHhlxxxxxxxxxx4VD1lBWUc6MzI6HRw6Nj0sIjoZNhAKFyId
	Pi8wCTBVSlVKTU1JSk5xxxxxxxxxxxxVRoXHgkPO0wLEgkxxxxxxxxxxGBQWRVlXWRIL
	WUFZTk9VTUNVxxxxxxxxxxxAFZQUpCSzcG
X-HM-Tid: 0a83xxxxxx342xxxxxxx504614a019b

My test content

duplicate of #352 and/or #357 ?

Indeed, duplicate! Fix is in the pipeline, I let you know whenever it is ready.


Feat: rollout controller is disabled by default

Signed-off-by: barnettZQG<EMAIL_ADDRESS>Description of your changes
The rollout move to the addon registry. https://github.com/oam-dev/catalog/pull/253
In the current, this feature cannot work in multi-cluster mode.
I have:

[x] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer
/cc @wangyikewxgm

/backport 1.2

I've reverted. This is a break change and won't be in v1.2.x. Please add how to migrate from v1.2.x to v1.3 for this feature. @barnettZQG


Prevent persistent connections

Not really an issue, more a question.
Is there a way to prevent persistent connections using rescu?
We have issues with a server, which sends Connection='[keep-alive]'
But we need to drop the connection and create a new one for every request.

I'm not really sure. There's a related issue #5 and the corresponding commit 17761414a4b9c1dd0abd484f9f2a2218d5fd5cc2 though, perhaps check out the code.


Support alarm tags

Support alarm tags

[ ] If this is non-trivial feature, paste the links/URLs to the design doc.

[x] Update the documentation to include this new feature.

[x] Tests(including UT, IT, E2E) are added to verify the new feature.

[ ] If it's UI related, attach the screenshots below.

[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #5124 #6821 .

[x] Update the CHANGES log.

Related  https://github.com/apache/skywalking-query-protocol/pull/56

Should I expect e2e failing as no submodule update? And more importantly, GraphQL changes have not been approved.

Wait a moment, I will check the fail.

Wait a moment, I will check the fail.

You should not to update anything. As the submodule relating to the repo, you don't have the commit id to update.

Yes,  e2e failing as no submodule

@kezhenxu94 Please check on the e2e.
@arugal @EvanLjp @dmsolr Please review on tag-search related codes.

@liqiangz I will wait for the document update before merge.

Thanks for updating. Let's wait for the CI.
@Fine0830 Once this gets merged, I will update this on the demo env, you could work on #6821.


change home dir before run oc login

In openshift CI we do not have permissions to write in $HOME, change HOME to /tmp/ before running oc login

/verified

/retest sonarqube


Project Open Data DCAT Distribution Fields dropped on harvest

The Project Open Data schema defines a whole list of elements that constitute a single Distribution section, including Title, Description, downloadURL/accessURL, format, mediaType, describedBy, describedByType, and conformsTo, but when GeoPortal Server harvests a dcat.json file, only downloadURL/accessURL and mediaType appear to be recognized, the other fields are dropped. Then, when producing the dcat output, the mediaType stored by GeoPortal Server isn't honored, and a default value produced.
Here's an example file we're harvesting:
https://pasteur.epa.gov/metadata.json
An example of what one record with many distribution elements looks like when stored in GeoPortal Server XML:
https://edg.epa.gov/metadata/rest/document?id={6C145F33-CE69-44FA-95E8-9CA320930EB7}
and what the DCAT output from GeoPortal Server is:
https://edg.epa.gov/metadata/rest/find/document?f=dcat&searchText=fileIdentifier%3AA-p2p0-450
We'd also love for the Details page to be able to display all of those Distribution Fields:
https://edg.epa.gov/metadata/catalog/search/resource/details.page?uuid={6C145F33-CE69-44FA-95E8-9CA320930EB7}
but that might be regarded as a separate issue.

When we harvest DCAT into Geoportal 1.2.x, we generate a Dublin Core record for it (since many DCAT files we've seen have limited information). This will require updating our Dublin Core metadata definition to include these elements. Then we can update the mapping from the new Dublin Core definition to DCAT.


Main Stage actions: back button isn't displayed when the action is loading a web page, image or video

This is a regression that has been introduced with V1.7.0 released on February 29th 2016. This issue affect new and existing Map Journal created in ArcGIS Online. This issue does not affect Portal for ArcGIS customer that haven't manually updated the application.
When a Main Stage Action is loading a web page, image or video, the back button that used to appear in the center of the Main Stage to allow to come back to the section initial Main Stage is not appearing.
The back button continues to be displayed when the loaded media is a map.

There is three possible workaround:

navigate away from the section and navigate back to it
refresh the section using the dot navigation bar
include a link to refresh the section to it's initial settings through a button in the side panel, the code below can be used to create such a link for any section in your Journal. Also note this article that describe how you can include and style links in the side panel to look like buttons

Back to section initial view

This issue will be fixed with our next release, currently planned for June 13th. Sorry for the inconvenience. If you would like to obtain a fix for a version that you can install on your own web server please add a comment

This issue has been fixed with the V1.7.1 released on March 16th in ArcGIS Online and as downloadable.


Added a link to the list of commands on the wiki.

Looks good to me! Looks like you've been keeping it up to date too, awesome! I'll try to keep it up to date in the future, too!

Looks like you've been keeping it up to date too, awesome!

I've been trying too.  It's still missing stuff.  At this point it'll take me less time to write some that generates a page with all the commands that it will to find and add the remaining missing pieces.


Android prebuilds?

Hi there! I'd like to run Sharp on Android, but Android doesn't support libvips by default. I've tried to install libvips via Termux, but the package hasn't been ported. Would you be opening to creating prebuilds for Android? I saw this workaround, but I'm concerned about compatibility (for Sharp and other native modules).
Thanks!

I guess these would need to use the bionic libc and be cross-compiled for ARMv7 and ARM64v8. Happy to accept a PR with Dockerfiles that create suitable cross-build environments for this.

Works for me! Out of curiosity, I've noticed that lots of other projects use prebuild, which maintains its own Dockerfiles for a bunch of platforms -- is that something you've explored, or would be interested in using?

sharp already uses prebuild, this repo is to prebuild libvips for sharp, but we might be able to use the same base images it uses though - see https://github.com/dockcross/dockcross

Note that supporting Android devices would require libvips to be cross-compiled with an Android-compatible toolchain such as NDK. It looks like Termux has succeeded in this, see PR https://github.com/termux/termux-packages/pull/6325.
fwiw, as an experiment I tried to reuse the Linux ARM64v8 glibc binaries on Android (with Xamarin), but that doesn't seem to work.

Details
<ItemGroup>
  <PackageReference Include="NetVips" Version="2.0.0" ExcludeAssets="Compile" GeneratePathProperty="true" />
  <PackageReference Include="NetVips.Native.linux-arm64" Version="8.10.6" GeneratePathProperty="true" />
</ItemGroup>
<ItemGroup>
  <!-- Use the Linux variant of NetVips on Android -->
  <Reference Include="NetVips">
    <HintPath>$(PkgNetVips)\runtimes\linux\lib\netstandard2.0\NetVips.dll</HintPath>
  </Reference>
  <!-- Include libvips ARM64v8-A glibc as native Android library -->
  <AndroidNativeLibrary Include="$(PkgNetVips_Native_linux-arm64)\runtimes\linux-arm64\native\libvips.so.42">
    <Abi>arm64-v8a</Abi>
  </AndroidNativeLibrary>
</ItemGroup>

[monodroid-assembly] Trying to load shared library '/data/app/nl.kleisauke.netvips/lib/arm64/libvips.so.42'
[monodroid-assembly] Failed to load shared library '/data/app/nl.kleisauke.netvips/lib/arm64/libvips.so.42'. dlopen failed: library "libpthread.so.0" not found: needed by /data/app/nl.kleisauke.netvips/lib/arm64/libvips.so.42 in namespace classloader-namespace


Add parent/student registration [2]

Story

As a parent

I Want a registration form

So That I can add the details of the student

Acceptance Criteria

Given I am on the website

When I navigate to the registration page
Then I should see a form with an input for firstName, last name, date of birth, email, phone number, password, confirm password

Given I have filled in the form correctly

When I click on submit
Then I should send the information to the backend and get a success notification

Given I have not filled the form correctly

Then I should see the input highlighted

Checklist:

✅  I have defined the user story
✅  I have defined some acceptance criteria
✅  I have included any implementation notes
✅  I have included all relevant links

Use form components from react bootstrap https://react-bootstrap.github.io/forms/overview/

Is this part of my first assignment ??


Propagate renaming of typeRepHash to typeRepFingerprint

This renaming occurred in 842028b4a624e639dc9ee9a4f92fc208c8206e3f
Without this change hashable fails to build with HEAD.

Fyi, the next ghc-7.10 ppa build (to happen today or tomorrow) will already have that renaming done. At that point hashable will require this PR not only for building with GHC HEAD, but also for building with GHC 7.10.1


Add support for micro components

Resolve httpc error
Add support for Micro components
Update the heroicons version specification
Update docs to reflect this update.

I manually merged this PR thank you!


MWPW-159427: Milo Catalog: Ipad specific issues

On iOS version 15 and lower there is a different way of managing the vertical stacking context, which puts the modal below the merch card. Adding z-index on the merch-sidenav resolves this problem.
Related Milo PR: https://github.com/adobecom/milo/pull/2994
Resolves: MWPW-159427
Test URLs:

Before: https://main--cc-–adobecom.hlx.live/products/catalog?martech=off
After: https://mwpw-159427-ipad-issues --cc-–adobecom.hlx.live/products/catalog?martech=off (added a space to hide the link from PSI check)

For PSI check:
https://mwpw-159427-ipad-issues--milo--mirafedas.hlx.live/?martech=off&georouting=off

why is the only change is in minified file?

adobecom/milo#2994

@Axelcureno every time when we make a change in merch-sidenav on Milo, we need to update the minified merch-sidenav in CC to keep it up to date. Here is the respective Milo PR: https://github.com/adobecom/milo/pull/2994

Closing because the needed change will be added in the https://github.com/adobecom/cc/pull/412


gvr-multilight onStep no longer called

The light used to animate in gvr-multilight but it no longer does. The onStep function never gets called in this sample.

This was something wrong with my build. I pulled a completely new tree and it went away. Really weird because multiple branches refused to call onStep.


Overlay Offset in options

added ability to adjust the overlays position through an offset option in the settings using the provided sliders or text boxes.
The settings option is contextual and only shows when Overlay is selected.

I tested it as much as I could, but its probable I missed something.
If you happen to be using a 1440p monitor, a y offset of 130 puts the overlay just under the player names.

After trying it out on scaled dpi, I've opted to also scale the offset values. I think this makes more sense, as users would expect that the displacement should relatively be the same. Its also easier to manipulate when at higher scaling.
As for language issues pertaining to cultures, I couldn't note any while using the JP and KR packs. I'm not 100% on this being the same for Arabic , Sanskrit, Cyrilic etc, but I note that the other input text boxes in settings also ignore culture formatting, so I assume they're only supposed to take and give back the English numerals.
I'll come back to check again if there's anything else. Otherwise, just more general use testing, and something for the docs.

I finally had some time to check it out in further details, there are a few regards I'd like to mention. For the UI:
There is no need to have sliders here, typing a value for an offset is just fine.
If the sliders stay, then they will have to be changed so that they increment per 1 step instead of 10.
Currently the limit on the sliders is 1000 but you can go way over that when entering in a value manually. Adding a check for a value greater than or lower than 1000 would have to be added on-top of the current input detection.
The text "Restart WFinfo" doesn't need to be there as the changes apply with the next check.
Inverting the values would be helpful too, seeing as it is expected that lower values should bring things down, higher values bring things up.

Done. Opted to remove the sliders since I think users would better appreciate the fine tuning that text boxes would bring.
The restart text was my own mistake, since between some of my tests I thought the offset wasn't updating between screens.
Lastly, inverted the Y value where it is facing the user. So it's the correct value for the screen space internally, but the user thinks up is +ve.

Looks great 👍, I'm willing to merge it once there's a limiter for these values. Seeing as 1/2 of a 4k screen height is 1080. a maximum of +/-1000 should be sufficient for all cases. If you want to go the extra step you could also change the maximum depending on the game's height. The value is available in the OCR class as window.height By default this would not be initiated but if it is then you can use half of it instead of the 1000.

I did make it dynamic, with default bounds for -1K : 1K. It should query if warframe is valid, and if so checks if the window has been set, otherwise forces an update itself.

Seems for some reason this commit never got merged into master?

really?

I did get the merged notification hmm, I'll submit again

I think I'll just let the fork exist in perpetuity this time. Maybe deleting it too soon was the issue. But that's pretty weird. I definitely got the notification that it was fine to delete, and this hasn't happened before :(


Fixed Mistral WorkflowSpec missing type attribute

In the orchestra.spec.mistral.v2.workflow.WorkflowSpec the type attribute was missing. According to the Mistral docs https://docs.openstack.org/mistral/latest/user/wf_lang_v2.html this is a valid attribute.
Without this addition, i wasn't able to instantiate() some of my Mistral workflows when trying to convert them to Orchestra.

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   94.33%   94.33%
=======================================
  Files          35       35
  Lines        1908     1908
  Branches      380      380
=======================================
  Hits         1800     1800
  Misses         65       65
  Partials       43       43

Impacted Files
Coverage Δ

orchestra/specs/mistral/v2/workflows.py
82.69% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09be269...4a58de8. Read the comment docs.

One gotcha: Orchestra doesn't support reverse workflows yet.
If it did, Orchestra would need to check the mode and, if in reverse type, add an additional task attribute requires and throw an error for on-* (on-complete, on-success, on-failed...).
I would love to see full support for reverse workflows as I have a reverse workflow I'm using in production (with a patched ST2 to make it work :/ ).

@bigmstone moved the workflow definitions to fixtures like you asked.
I think there is some more work to be done in this area as i see other tests that have workflow definitions in them. I'll leave that for a future PR.

@nmaludy Thank you for your patch. But the Mistral spec in Orchestra is for reference only. We do not support it.  If you're converting to Orchestra, you'll have to rewrite Mistral WF definition to the Orchestra WF definition format.

@cognifloyd We have no plans to support reverse workflow in Orchestra.

@m4dcoder Requested changes have been made.

We add a number of changes and this change is outdated. You will need to rebase with master to resolve conflicts before we can merge. Thanks.

@bigmstone do you have any other concerns here?

Fixed the build, couple small errors.


Minor reporting changes for XML and using get to avoid KeyErrors

Codecov Report

Merging #10 (95ae3af) into master (e498346) will not change coverage.
The diff coverage is 72.72%.

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   82.23%   82.23%
=======================================
  Files          11       11
  Lines         653      653
  Branches       97       97
=======================================
  Hits          537      537
  Misses         99       99
  Partials       17       17

Impacted Files
Coverage Δ

ochrona/reporter.py
82.38% <70.00%> (ø)

ochrona/cli.py
77.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e498346...02c086f. Read the comment docs.


Exception when viewing Job History

Describe the Issue
The Dashboard is throwing the following error when trying to view the history of a job:
Exception calling "Invoke" with "0" argument(s): "Exception calling "Invoke" with "0" argument(s): "Exception calling "Invoke" with "0" argument(s): A parameter cannot be found that matches parameter name 'Top'."""

#### To Reproduce

Steps to reproduce the behavior: (Example)

1. Click Historical
2. Click the name of the script
3. See Error

#### Expected behavior

It should probably behave the same as clicking the ID, which does work.

#### Screenshots

![image](https://user-images.githubusercontent.com/8674240/70204812-f1538980-16ef-11ea-9f5e-9c1e0e0dec07.png)

#### Script Sample

#### Version Information

- **Host Operating System**: Windows Server 2012R2
- **Host PowerShell Version**: PowerShell 5.1
- **Universal Automation Version**: Latest Beta
- **Universal Dashboard Version**: Latest
- **UD Hosting Method**: Powershell

Resolved in last nights build.


SetPass does not create pass entry GoJira/<user>

As stated in PR #91, go-jira does not create pass entry GoJira/<user>. The first time using go-jira asks for my password, but won't store it.
$ jira fields
Jira Password [user]: ********
$ echo $?
0
$ pass show | grep -i GoJira; echo $?
1

Configration is correct as I can use go-jira with pass after manually adding my account to pass.

Hey, thanks for the updates.  I am not ignoring you, just don't have a lot of time to look into this.   I hope to be able to check into the issue this weekend.
-Cory

I think this might have been fixed in #104

Closing, reopen if still an issue.


[Enhancement]: Extend teams app install command with --name option

Currently we only accept the ID of the app, we should extend this so you can also use the name of the app.

Please assign to me to work on it.

All yours @reshmee011 thank you! 👍


Upgrade all GitHub workflow actions currently using node12(deprecated)

What were you trying to achieve?
Running the repo workflows
What are the expected results?
Workflows are expected to run without any warnings
What are the received results?
Workflows were running with save-state  and set-output deprecation warnings

Additional context

An example of a GitHub Action workflow run with the save-state warning is here
An example of a GitHub Action workflow run with the set-output warning is here
This article may provide some context on this.
Sample places where the GitHub actions to update are used include:

https://github.com/airqo-platform/AirQo-api/blob/ec9b7960c71b3da2a4f65e7a5a166fb074bf7d6f/.github/workflows/remove-deploy-previews.yml#L18
https://github.com/airqo-platform/AirQo-api/blob/ec9b7960c71b3da2a4f65e7a5a166fb074bf7d6f/.github/workflows/deploy-apis-to-staging.yml#L393

You can also update all other GitHub actions you notice to be outdated apart from<EMAIL_ADDRESS>The ideal solution addresses this issue in all the workflows

@123MwanjeMike ,

Aren't these Github Actions upgrades the ones which brought us problems sometime back? The time when all PRs refused to be deployed after merge
Anyway, just requesting that we apply some caution as we go about this.


Segmentation for HTC

Thanks for your work.
I was wondering, whether there are some bugs in your configs.

you are using semantic_roi_extractor  and semantic_head  in your config for HTC.
https://github.com/VDIGPKU/CBNetV2/blob/main/configs/cbnet/htc_cbv2_swin_base_patch4_window7_mstrain_400-1400_adamw_20e_coco.py#L24
and, you've used the original '../_base_/datasets/coco_instance.py',, which didn't provide the path of segmentation png.
https://github.com/VDIGPKU/CBNetV2/blob/main/configs/_base_/datasets/coco_instance.py#L37

according to this issue: https://github.com/open-mmlab/mmdetection/issues/3767
with_seg should be True. But once you set this as True, then you should provide some segmentation png path for the training pipeline
so how could you start the training?

Thanks for your error report and we appreciate it a lot. The bug has been fixed in the latest version.
Our HTC config follows htc_r50_fpn_1x_coco.py
Due to limited computing resources, the training config of the large model has not been tested.
If you have any other questions, please feel free to propose issues.