Append with Flush

Continues from https://github.com/Azure/azure-rest-api-specs/pull/18546

@seanmcc-msft yes but I'm not sure why the CI won't finish. Until is passes I can't click the button :(

/azp run public.rest-api-specs

/azp run openapi-pipeline-app

@seanmcc-msft is this an incremental change to a yet-unreleased service version? See the breaking change failure.

This change was introduced several years ago, but was not enabled in production until now.

Then that sounds like this is a breaking change if the production service has changed to add this new optional property...?

This change was introduced several years ago, but was not enabled in production until now.

Then that sounds like this is a breaking change if the production service has changed to add this new optional property...?

The feature may have been active in production for a while already, but not documented.  In some cases, our swagger files represent a subset of the functionality of the service.

@tjprescott can we merge this?

Adding the Approved-BreakingChange label.

It looks like there's a linter rule that might need to be addressed still around an extra x-ms-client-name that's the same as the parameter name?

It looks like there's a linter rule that might need to be addressed still around an extra x-ms-client-name that's the same as the parameter name?

I have removed the x-ms-client-name for the flush parameter.


Deleting space on Android/iOS throws IndexOutOfRangeException

Describe the bug
https://github.com/user-attachments/assets/dd9c665a-1e37-43b6-8e94-2311f6dc0323
To Reproduce
<TextBox>etwas finden</TextBox>, place the caret after the space and press delete.
System.IndexOutOfRangeException Index was outside the bounds of the array.

0xFFFFFFFFFFFFFFFF in Android.Runtime.RuntimeNativeMethods.monodroid_debugger_unhandled_exception	C#
0x1A in Android.Runtime.JNINativeWrapper._unhandled_exception at /Users/runner/work/1/s/xamarin-android/src/Mono.Android/Android.Runtime/JNINativeWrapper.g.cs:12,5	C#
0x1E in Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PP_Z at /Users/runner/work/1/s/xamarin-android/src/Mono.Android/Android.Runtime/JNINativeWrapper.g.cs:45,26	C#
0x10 in Avalonia.Utilities.ArraySlice<Avalonia.Media.TextFormatting.GlyphInfo>.get_Item	C#
0x7 in Avalonia.Media.TextFormatting.ShapedBuffer.get_Item	C#
0x60 in Avalonia.Media.GlyphRun.FindNearestCharacterHit	C#
0x3A in Avalonia.Media.GlyphRun.GetCharacterHitFromDistance	C#
0x74 in Avalonia.Media.TextFormatting.TextLineImpl.GetRunBoundsLeftToRight	C#
0x36 in Avalonia.Media.TextFormatting.TextLineImpl.GetTextBoundsLeftToRight	C#
0x243 in Avalonia.Media.TextFormatting.TextLineImpl.GetDistanceFromCharacterHit	C#
0x42 in Avalonia.Controls.Presenters.TextPresenter.UpdateCaret	C#
0x55 in Avalonia.Controls.Presenters.TextPresenter.MoveCaretToTextPosition	C#
0x76 in Avalonia.Controls.TextBox.DeleteSelection	C#
0x6D5 in Avalonia.Controls.TextBox.OnKeyDown	C#

Expected behavior
Space is deleted.
Avalonia version
11.3.999-cibuild0052531-alpha, 11.1.4
OS
Android
Additional context
No response

Also reproduces in iOS simulator, but only when using the software keyboard, not physical.

@emmauss, you're right. Tried to trigger this in one of my other repro repos with no luck. Here's a solution that does exhibit the issue though - https://github.com/kerams/input2

Are you sure it's because of Skia? I removed the reference and the problem persists.

So can this be reopened? Reproducible across iOS and Android, simulators and real devices, 11.3.999-cibuild0052531-alpha and 11.1.4, with SkiaSharp 2. Text input issues are really bad, not least those that cause crashes.

The crash is caused by Material.Avalonia theme.

Thanks. Any idea what to look for, what thing would manifest in this kind of a problem?

If I remove SelectionForegroundBrush="{TemplateBinding SelectionForegroundBrush}" from TextPresenter Name="PART_TextPresenter", the exception is gone. For the life of me I don't understand why this should cause any issue in code dealing with glyph runs, but in any case, is this really the theme's fault?


Greedy : Add Coin change problem using greedy algorithm in Java

@akgmage provide a link or question

@akgmage provide a link or question

Check readme.md @payalpm

@akgmage please assign me this issue


[3.x] Particles2D visibility rect - only show on selected nodes

This PR is a 3.x backport of #55052 with a small change compared to the 4.0 PR.
I left out the changes on the 3D gizmo alpha as I think it would be better handled in a separate PR for 3.x.

Thanks!


(improvement)  improve keyboard navigation for login page

Description:

because of setting tab-index on both button and icon, focus is set two times on hide/show button and icon, removed tab-index from icon
improve focus style for dropdown
update Alternatively, clear your credentials & and stored data to Alternatively, clear your credentials and stored data

Thank you 👍  This was annoying me too 😄


Ingest streamlit page - finalize library connection

resolves #1053

So you're adding a util to dcpy... which means that it's time to write a test!
Appropriate file is dcpy/tests/utils/test_s3.py. You should go ahead and take a look, but then we actually should have a broader discussion about testing


fix(ObjectSelector): bigger cards on small screens & thin panels

:tada: This PR is included in version 9.1.1-rc.1 :tada:
The release is available on:

GitHub release
npm package (@next dist-tag)

Your semantic-release bot :package::rocket:


GitHub repo address changed yesterday can't reset - build broken!

I filed a support ticket support is being very slow and unhelpful. Build is broken since yesterday! Randomly for 1 of my apps I had to reconnect GitHub now the GitHub repo link points to an old address from like a year ago! Don't know how to change it don't want to lose my build config Please help! Build won't work.

@dgobaud I found your support conversation. Will reach out there and take a look


Swap shufflebags for weighted random

I like shufflebags, but a weighted random function would be better since it still allows for minigames that played previously to play as well, albeit with less chance of that happening.

Added in the latest version. Will close this once the Wiki's updated.


outdated build from source examples

Describe what needs to be documented.
These links look like 10 years old, can they be upgraded?
http://visitusers.org/index.php?title=Compiling_visit / http://visitusers.org/index.php?title=Building_on_Ubuntu_8.04
Is the documentation missing?
If so, please describe where have you looked for the documentation and where you expect to see it.
Is the documentation there but needs improvement?
http://visitusers.org/index.php?title=Compiling_visit
http://visitusers.org/index.php?title=Building_on_Ubuntu_8.04
Additional context
Can they clearly list all supported VTK versions?
or is the cmake output just not clear to me?
-- Checking for VTK in VTK_DIR-NOTFOUND
CMake Error at CMake/FindVisItVTK.cmake:137 (find_package):
  Could not find a configuration file for package "VTK" that is compatible
  with requested version "8.1".

  The following configuration files were considered but not accepted:

    /usr/lib/cmake/vtk-7.1/VTKConfig.cmake, version: 7.1.1

All 3.0.x want VTK 8.1, which is not available in Debian, trying to get https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=395573 fixed.
VTK 8.2 is available via https://salsa.debian.org however that seems to fail as well, according to
https://github.com/visit-dav/visit/issues/3498

I removed the obsolete documentation. VisIt requires VTK 8.1. Unfortunately, VTK changes their interface in subtle ways every time they make a new release, so the VTK 8.x versions are not interchangeable. There is updated building information in the sphinx documentation in:
https://visit-sphinx-github-user-manual.readthedocs.io/en/develop/gui_manual/Building/index.html
There is also some building information in the section about building on docker, that has the packages needed on the various Linux distributions in the Docker files. The link for that is:
https://visit-sphinx-github-user-manual.readthedocs.io/en/develop/dev_manual/Docker.html

I'm going to close this since the obsolete documentation has been removed and there is new documentation on building VisIt.


Create pl-PL-Latn.json

Alternative Polish language file without using diacritics.

I spend too much time reading standards, but the correct IETF Laguage tag for polish without diacritics would be pl-PL-Latn, which specifies only latin letters are used. :)

Is the latin version necessary if the game ends up supporting all the characters needed for polish w/ diacritics?

Unnecessary


script publishWebComponentsToMavenLocal version not work

commit (#2365 ) change COMPOSE_WEB_VERSION to  compose.version , COMPOSE_WEB_VERSION is too.
So, we must change
./gradlew publishToMavenLocal -PCOMPOSE_CORE_VERSION="$COMPOSE_CUSTOM_VERSION" -PCOMPOSE_WEB_VERSION="$COMPOSE_CUSTOM_VERSION" || exit 1

to
./gradlew publishToMavenLocal  -Pcompose.version="$COMPOSE_CUSTOM_VERSION" || exit 1

in https://github.com/JetBrains/compose-jb/blob/master/compose/scripts/publishWebComponentsToMavenLocal

Thanks for fixing!

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Upgrade SCSS syntax

Some at-rules and functions that this project is using will be deprecated soon. Upgrading SCSS syntax is essential.

Solved at #5


How to make a TLS/SSL connection

I can connect to server with var client = net.createConnection({port: 'my_port', host: 'my_host'});
How to adjust the code to connect with TLS? Could you provide an example?
Thanks in advance.

tls/ssl is a bit outside the scope of this package.  This is meant to be an api compatible package of node.js's net.
However, the node.js tls implementation is built upon the 'net' package.  So, it's probably a good starting point.
https://github.com/nodejs/node/blob/master/lib/tls.js


Support Microsoft Windows Server infrastructure in testgrid

Description:
Now that we have Ubuntu 16.04 and CentOS 7.4 (#483) in testgrid, we need to put our focus on Microsoft Windows. For Windows, we can initially target its server versions.
We can possibly start with Windows server 2016 and 2012 R2. [1] Older versions are still in use though.
One major challenge when doing this is that we do not have the necessary installation scripts to support Windows. Since timeline for Windows-supported installation scripts is a bit too far for IET team right now, we have to come up with a rudimentary script that can do this. At a minimum, it can be a single node product deployment of IS/APIM.
Deliverables:

Working installation scripts for a minimal single-node product deployment. We can choose either IS/APIM
A Testgrid job that can execute the installation scripts to provision a product deployment, and then run scenario test scripts against that deployment.

[1] https://en.wikipedia.org/wiki/List_of_Microsoft_Windows_versions#Server_versions

Affected Product Version:
0.9.0-m22
OS, DB, other environment details and versions:
Windows Server 2016, 2012 R2.
Related Issues:
#483

This is completed.


Vuex ^2

with vuex 2.5.0, mixins wont work, use plugins instead

Thanks for pointing me that, my README.md example is wrong.
This is a Vuex plugin and is working over plugins interface.
import Vuex from 'vuex'
import handler from 'vuex-handler'

const store = new Vuex.Store({
  plugins: [ handler ]
})

I've updated README example and published over 0.1.3.


cashscript not working with latest version of vite

when using yarn create vue to initialize a default vue-vite app, cashscript import is broken.
first I ran into
Uncaught TypeError: class heritage import_events.EventEmitter is not an object or null
originating from
var ElectrumSocket = class extends import_events.EventEmitter {
I was able to solve this with
yarn add events
https://github.com/vitejs/vite/issues/2694
but new errors pop up:
Error: Build failed with 1 error:
node_modules/cashscript/dist/utils.js:1:256: ERROR: No matching export in<EMAIL_ADDRESS>for import "bigIntToCompactSize"

and
Uncaught SyntaxError: The requested module 'http://localhost:5173/node_modules/hash.js/lib/hash.js?v=fcabd058' doesn't provide an export named: 'default'

which has the comment // TODO: Replace with libauth

My issue was with using CashScript + Vite version ^5.3.1
Downgrading to Vite version 5.0.12 solved the issue

I having a similar issue with react/next, I can get it with next version 13.... but not 14...

so this issue is related to #222 which has now been resolved and will be published with release v0.10.2 next week

After removing hash-js from CashScript, CashScript works with vite when adding events for electrum-cash
To fix the vite build without any workaround, we need to update the electrum-cash package, as described in issue #224


test: Storage Provider/Store mock

New Storage provider and Store mock
Moved outbound provider mock to /internal/mock folder

Cloes #202
Signed-off-by: Rolson Quadras<EMAIL_ADDRESS>

Codecov Report

Merging #225 into master will decrease coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #225      +/-   ##
=========================================
- Coverage   87.14%   86.6%   -0.55%
=========================================
  Files          35      35
  Lines        1463    1463
=========================================
- Hits         1275    1267       -8
- Misses        104     108       +4
- Partials       84      88       +4

Impacted Files
Coverage Δ

pkg/framework/aries/default.go
66.66% <0%> (-19.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd5594...af6ec71. Read the comment docs.

Should be rebased on master @rolsonquadras


Separators look wrong

Hi (again!) :)
When using certain themes, the separators look wrong:

This example uses gotham-theme.
I don't know if this is a powerline issue, a spaceline issue or a spaceline-all-the-icons issue. Maybe you do?

I just noticed that this glitch apparently goes away when splitting the Emacs window so that there are two windows side by side:

Very strange...

Ah.. Changing spaceline-all-the-icons-separator-type to arrow or any of the other types, makes this go away. That's good enough for me.
I'll leave this open so that you can check if you can reproduce this using the slant separator type, if and when you have time.

That is strange that it goes away...
I'm kind of aware this though, the way the separators work is they're actually a unicode character, so I colour them with a foreground & background like all other text - The problem is when you're transitioning from a dark background to a light background, the character has the dark colour as the foreground and the light colour as the background and since Emacs doesn't aline characters to the bottom, you can end up with a tiny gap 😅
And technically this will be happening for the arrow type, but since it doesn't have a hard line at the bottom you won't see it.
This can also change based on the fonts used and things... I've been thinking of a better solution to this and have a couple of ideas but they're all kind of difficult, so was hoping it wouldn't be too much of an issue for people!


Light Mode

Add light mode to website, perhaps adding an option toggle?

PR #33 works towards this goal but still would like to add toggle


[After MSAL 1.3] Pluggable HTTP in identity/msal

Let's hold this back until MSAL 1.3.0 is released with it's significantly reduced dependency set.

Bump version to 1.3.0 on Jan 10 before merging

/check-enforcer reset

/check-enforcer evaluate


Feature Request: Admin interface

I have installed Identity Server 3 with Entity Framework. That's fine, it is working.
Now, I have to configure a new client to access it and I didn't find any repository that I could install in order to include a new client via web interface.
Do I have to include this new client direct into the database, in the tables "Clients" and "ClientRedirectUris"?

We have a repo here for that: https://github.com/IdentityServer/IdentityServer3.Admin
It's still a work in progress.


Test docker in GitHub actions

What?
A sample test harness for supporting testability of new docker command.
Why?
Beyond unit tests for coverage, verifying that this functionality actually works (given a functional Docker host) is important.
How?
Use a Docker-in-Docker container hosted on a ubuntu image, install python, install the CLI, login, and run the docker up and down commands.
Testing
Since this IS a harness for testing and a Github Action primarily, there is no additional testing other than using it before PyPi releases.

I've juste rebase and squash over master. It is more simple to review.

I will see tomorow with guillaime for .github/workflows/python-package.yml


Bug: Unable to Edit Input in Modular Form in Production Mode (React )

Bug Description:
I've encountered a bug in the modular form implemented using React in production mode. In this form, I'm unable to edit the input fields. The issue is not present in development mode.

Could you figure out why it's not working?

The issue stems from the onChange method integrated into the library. Both the value and the error are susceptible to type unsafety (usage of Preact within the React app).

Maybe this is related to https://github.com/fabian-hiller/modular-forms/issues/104


update total duration in seek bar to add ability to seek in live HLS playlist with new chunks added after playback starts

I have a live HLS playlist.  The playlist has segments being added to it every 10 seconds.  When I open the live m3u8 up and play it in flowplayer with the flowplayer-hls plugin , it nicely lets me seek anywhere in the stream for the number of chunks that existed when the palyer was intiated.  the problem is that after some time the m3u8 playlist is longer than what is reported in the seek bar.
By way of example, lets say when I start to play the .m3u8 it has 4 minutes worth of video.  The far right of the seek bar lets me get to 4 minutes in the .m3u8.  1 minute later the .m3u8 has had 1 minute of video added to it, so now the .m3u8 has 5 minutes of video.  So the .m3u8 that is being played will play for 5 minutes, but since at load time the playlist only had 4 minutes, I can only seek to the first 4 minutes in the flowplayer seek bar.
Is there a way to get this plugin check the currently playing .m3u8 and update the total duration reported in the seek bar?

HLS live DVR is not yet implemented in the core player: https://github.com/flowplayer/flowplayer/issues/950
For the moment you have to make do with setting live: true for player or clip, which has, among other things, the effect that there's no timeline in the controlbar, see http://demos.flowplayer.org/basics/live.html
For consistency this will be implemented for the hlsjs plugin once the core player supports HLS live DVR.

I think live HLS functionality may be in the HLSjs framework to some extent.  As I'm able to get DVR functionality when playing a live HLS playlist (with the exception of the above mentioned issue).
I'm getting around the CORS issue by using my own nginx server equiped with the rtmp/hls plugin.
Basically, the flow of events in my test to simulate a live event is :
1.start encoding a 1 hour video (via ffmpeg) and have the output stream to my nginx server, via rtmp.
2. nginx server creates live adaptive hls playlist out of incoming rtmp stream(s).
3. flowplayer, with hlsjs plugin, plays back the live HLS playlist hosted on private nginx server, as if it were a live event.
I'm happy to send you my ffmpeg commands and even a Docker container containing the setup of my nginx+HLS module server (if you're into the current Docker craze : ) ), if you want to duplicate when taking a look into the above mentioned issue.
FYI, I'm able to get somewhat of a DVR functionality in my live HLS .m3u8 with the following configuration of the player. (with the exception of what I detailed in OP)
window.onload = function () {
flowplayer("#hlsjs", {
splash: true,
embed: false, // setup would need iframe embedding
ratio: 5/12,
clip: {
  sources: [
    { type: "application/x-mpegurl",
      src:  "//<nginx hls server>/live_hls/hlsdvr.mp4_groundcontrol54321.m3u8" }

  ]
}

}).on("ready", function (e, api, video) {
// info for demo purposes
document.getElementById("engine").innerHTML = api.engine.engineName;
document.getElementById("vtype").innerHTML = video.type;
document.getElementById("src").innerHTML = video.src;
});
};

hlsjs would have to do similar things as the core player in generic hls playback, therefore we'll wait until this is implemented in the core player; to avoid needless duplication of code etc.
Thanks for sharing your test setup, but experience tells that to get reasonably solid testing environment we also need a 'real' live stream. I can sort of get something similar to your setup with ffserver, but usually that's not enough.

@blacktrash I can give you access to live stream with Wowza and/or Nimble server for DVR testing. I'm really insterested in this functionality:)

@popler - thank you; as already mentioned, I'll get back once this is implemented in core. You can vote up https://github.com/flowplayer/flowplayer/issues/950 ;-)

To be clear, here's the live DVR functionality that is already working in this framework:
with a the Live playlist in this state when playback starts:
#EXTM3U
#EXT-X-VERSION:3
#EXT-X-MEDIA-SEQUENCE:0
#EXT-X-TARGETDURATION:10
#EXT-X-PLAYLIST-TYPE: EVENT
#EXT-X-DISCONTINUITY
#EXTINF:10.010,
0.ts
#EXTINF:1.477,
1.ts
#EXT-X-DISCONTINUITY
#EXTINF:10.010,
2.ts
#EXTINF:10.010,
3.ts
...
#EXTINF:10.010,
30.ts

the play head looks like this:

notice the time on the left is less than the time on the right. :
a minute later the same live HLS playlist looks like this:
#EXTM3U
#EXT-X-VERSION:3
#EXT-X-MEDIA-SEQUENCE:0
#EXT-X-TARGETDURATION:10
#EXT-X-PLAYLIST-TYPE: EVENT
#EXT-X-DISCONTINUITY
#EXTINF:10.010,
0.ts
#EXTINF:1.477,
1.ts
#EXT-X-DISCONTINUITY
#EXTINF:10.010,
2.ts
#EXTINF:10.010,
3.ts
...
#EXTINF:10.010,
30.ts
...
#EXTINF:10.010,
37.ts

The player's play head looks like this while it continues to perfectly play video frames:

notice that the current time (on the left) is past the total time(on the right)
For my own understanding: You are waiting for Core to create a HLS parser that updates the total duration (on the right side of the blue seek bar), dynamically, before you do so for hlsjs?

The (usually) 'sliding DVR window' must be displayed and updated. And that has to happen e.g. for generic HLS, i.e., in core, too. Then hlsjs will take over as much from core as possible.

Implemented for Flowplayer 7 which introduced DVR support. Closing.


Gettingstarted

Addressed some of the comments in Issue #12. Will determine whether the outstanding comments require changes.

Updated index.markdown to fix #36.


Make Conan optional

I can avoid using Conan with just a few lines of pure CMake:
include(FetchContent)

FetchContent_Declare(range-v3
    GIT_REPOSITORY https://github.com/ericniebler/range-v3
    GIT_SHALLOW True)
FetchContent_Declare(fmt
    GIT_REPOSITORY https://github.com/fmtlib/fmt/
    GIT_SHALLOW True)

FetchContent_MakeAvailable(range-v3 fmt)

At the moment, I have to replicate the logic of src/CMakeLists.txt:
FetchContent_Declare(mp-units
    GIT_REPOSITORY https://github.com/mpusz/units
    GIT_SHALLOW True)

FetchContent_GetProperties(mp-units)
if(NOT mp-units_POPULATED)
    FetchContent_Populate(mp-units)

    add_library(units INTERFACE)
    add_library(mp::units ALIAS units)
    target_compile_features(units INTERFACE cxx_std_20)
    target_compile_options(units INTERFACE -fconcepts)
    target_link_libraries(units INTERFACE range-v3::range-v3 fmt::fmt)
    target_include_directories(units INTERFACE
        ${mp-units_SOURCE_DIR}/src/include)
endif()

I do not believe that CMake is, or will ever be, a good solution for dependency management. On the other hand, everything looks like Conan is the best way to go as of now. I do not believe vcpkg will prove in the long run for corporations and will only stay as an alternative solution to Conan for small OSS projects.
This is why I do not want to overcomplicate the repo code in a way that will make Conan usage harder. I have a solution in mind that hopefully addresses your needs. If not, please let me know.

Turns out that defining conan_init as empty beforehand does the job:
FetchContent_Declare(mp-units
    GIT_REPOSITORY https://github.com/mpusz/units
    GIT_SHALLOW True)

FetchContent_GetProperties(mp-units)
if(NOT mp-units_POPULATED)
    FetchContent_Populate(mp-units)
    macro(conan_init)
    endmacro()
    add_subdirectory(${mp-units_SOURCE_DIR}/src ${mp-units_BINARY_DIR})
endif()

conan_init is my utility function defined in a repository submodule. You should not have to redefine it because it uses Conan only if Its files are found. I believe that the change I did (using Conan targets only if they exist) was the proper solution and enough to make you roll.

Yes, now it's working without redefining conan_init. I'm not sure why it didn't work for me before.

I am using this
FetchContent_Declare(mp-units
    GIT_REPOSITORY https://github.com/mpusz/units
    GIT_SHALLOW ON)

FetchContent_GetProperties(mp-units)
if(NOT mp-units_POPULATED)
    FetchContent_Populate(mp-units)
endif()
add_subdirectory(${mp-units_SOURCE_DIR}/src)  # provides mp-units::mp-units
...
target_link_libraries(my_target PUBLIC mp-units::mp-units)

I understand the comment about CMake not replacing conan, however CMake can be made more friendly to FetchContent by using this rather simple technique https://www.foonathan.net/2022/06/cmake-fetchcontent/.
I guess you don't want to encourage using FetchConent in the first place.
But this is just a little step away from https://mpusz.github.io/units/usage.html#copy-cmake
(Anyway, I have to learn how to use conan, specially if it can be done from CMake.)

Thanks for sharing!
Yes, I don't want to encourage FetchContent as even CMake key developers claim that it is not a good solution for package management. See https://youtu.be/wULu83jQmIQ?t=3262.

(Anyway, I have to learn how to use conan, specially if it can be done from CMake.)

Yes, it can be done from CMake, but it is not the right way to go. This is not only my personal experience but also Conan authors claim the same. Package managers should run on top of build systems and not the other way around.


Starcoder / Quantized Issues

Hey! Thanks for this library, I really appreciate the API and simplicity you are bringing to this, it's exactly what I was looking for in trying to integrate ggml models into python! (specifically into my library lambdaprompt.
One issue, it seems like there's something going wrong with starcoder quantized models.
For the full model, it seems to work great, and I'm getting the same outputs it seems.
What works (full model weights):
 ./build/bin/starcoder -m /workspaces/research/models/starcoder/starcoder-ggml.bin -p "def fibo(" --top_k 0 --top_p 0.95 --temp 0.2

as equivalent to:
from ctransformers import AutoModelForCausalLM
llm = AutoModelForCausalLM.from_pretrained(
    '/workspaces/research/models/starcoder/starcoder-ggml.bin',
    model_type='starcoder')
print(llm("def fibo(", max_new_tokens=30, top_k=0, top_p=0.95, temperature=0.2))

Seem to give equivalent results!
What fails (quantized model weights):
However, when I change to the quantized model (to reproduce the same as this)
./build/bin/starcoder -m /workspaces/research/models/starcoder/starcoder-ggml-q4_1.bin -p "def fibo(" --top_k 0 --top_p 0.95 --temp 0.2

I get a core dumped ggml error
Python 3.10.11 (main, Apr 12 2023, 14:46:22) [GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from ctransformers import AutoModelForCausalLM
>>> llm = AutoModelForCausalLM.from_pretrained(
...     '/workspaces/research/models/starcoder/starcoder-ggml-q4_1.bin',
...     model_type='starcoder')
GGML_ASSERT: /home/runner/work/ctransformers/ctransformers/models/ggml/src/ggml.c:4408: wtype != GGML_TYPE_COUNT
Aborted (core dumped)

Awesome! Thank you @marella this is definitely the issue.
I wish there were more clear ways to version the various quantizations -- I'm new to the ggml toolkit and so I didn't realize how breaking changes to the quantization would manifest.
I'll also add, the ability to pull directly from huggingface makes this super great, thank you!

Hi @bluecoconut  @marella coudl you provide an exmaple, been trying to execute the model but have no luck, none of this prompts work:
/build/bin/starcoder-quantize -m ./starcoder-ggml/starcoder-ggml-q4_1.bin 3
./build/bin/starcoder-quantize -m ./starcoder-ggml/starcoder-ggml-q4_1.bin --type=3

before adding type I was getting:
./build/bin/starcoder-quantize -m ./starcoder-ggml/starcoder-ggml-q4_1.bin -p "def fibo(" --top_k 0 --top_p 0.95 --temp 0.2
And getting:
usage: ./build/bin/starcoder-quantize model-f32.bin model-quant.bin type
  type = "q4_0" or 2
  type = "q4_1" or 3
  type = "q4_2" or 5
  type = "q5_0" or 8
  type = "q5_1" or 9
  type = "q8_0" or 7

Hi @bgonzalezfractal, starcoder-quantize binary is for quantizing models. For text generation you should use starcoder binary:
./build/bin/starcoder -m ./starcoder-ggml/starcoder-ggml-q4_1.bin -p "def fibo(" --top_k 0 --top_p 0.95 --temp 0.2

Apple M1 processor doesn't support AVX2/AVX instructions so it will be slower. You can try increasing the threads parameter to the number of physical cpu cores your system has. For example, if your system has 8 cores, try using threads=7 or threads=8:
llm(..., threads=8)

You can use this command to get cpu cores count:
grep -m 1 'cpu cores' /proc/cpuinfo

Also I just updated the build file in this repo. Can you please pull the latest changes or clone this repo and try building the library from source:
git clone --recurse-submodules https://github.com/marella/ctransformers
cd ctransformers

cmake -S . -B build
cmake --build build

The compiled binary for the library will be located at build/lib/libctransformers.dylib which can be used as:
llm = AutoModelForCausalLM.from_pretrained(..., lib='/path/to/ctransformers/build/lib/libctransformers.dylib')

llm(..., threads=8)

Can you please try this and let me know if you are seeing any improvement in performance.

@bluecoconut Just an FYI: There is a new breaking change in quantization formats added to llama.cpp in https://github.com/ggerganov/llama.cpp/pull/1508 yesterday. Initially I was planning to update to the latest version over the weekend but now I will have to wait for the new breaking changes to be added to the ggml repo.

@marella I was able to get the model tu run with the command line, but I have no success using the library, I get "segmentation fault python" using transformers.
For the build  I used:
git clone --recurse-submodules https://github.com/marella/ctransformers
cd ctransformers/models

cmake -S . -B build
cmake --build build

Since the Cmake files were placed in the models folders.
Using python from the command line or jupyter notebooks, I'm unable to run the models

@bgonzalezfractal Recently I updated the GGML library which has breaking changes to quantization formats. So old models have to be re-quantized. Let's continue the discussion here.

@bluecoconut This is released in the latest version 0.2.0
It includes the latest quantization changes and the recent fix for StarCoder https://github.com/ggerganov/ggml/pull/176 Since it includes breaking changes, old models have to be re-quantized.
It also supports LLaMA, MPT models now.

@marella Can you confirm these steps would work:

First follow the starcode.cpp instructions to quantize model

git clone https://github.com/bigcode-project/starcoder.cpp
cd starcoder.cpp

# Convert HF model to ggml
python convert-hf-to-ggml.py bigcode/gpt_bigcode-santacoder

# Build ggml libraries (Should we build the new version of ggml, since ggml in tag v0.1.2 in ctransformers is the one working)
make

# quantize the model (either starcoder, llama or mpt?)
./quantize models/bigcode/gpt_bigcode-santacoder-ggml.bin models/bigcode/gpt_bigcode-santacoder-ggml-q4_1.bin 3

Once quantized we can use it directly as follows:

./build/bin/starcoder -m $MODEL_PATH/starcoder-ggml-q4_1.bin -p "Write a pandas function that takes in a DataFrame with a 'price' column and calculates the average prices per month and year as new columns.Use matplotlib to plot the results and return the dataframe. \ndef calculate_df_avg_price(" --top_k 0 --top_p 0.95 --temp 0.2

And it should work in ctransformers like this:

from ctransformers import AutoModelForCausalLM
llm = AutoModelForCausalLM.from_pretrained(
    f'{$MODEL_PATH}/starcoder-ggml-q4_1.bin ',
    model_type='starcoder')
print(llm("def fibo(", max_new_tokens=200, top_k=0, top_p=0.95, temperature=0.2))

I don't think starcoder.cpp repo has updated to the latest GGML version so it might not work.
The steps on GGML repo should work with the latest version of ctransformers: https://github.com/ggerganov/ggml/tree/master/examples/starcoder#quick-start

@marella, quantized starcoder again, works at 183.36 ms per token:

Nonetheless, with the latest version of ctransformers and python3.10, the llm loads but seems to be stuck on inference and does not produce any results:

Keeps using memory and CPU:

Any luck?


Re-assert executable bit

From the manual test run, it seems that the Java template projects was failing to build due to executable bit on mvnw script not being set.
This is surprising, as the executable script is set correctly:

In azure-dev repository
In the replicated repoman template repository

Nevertheless, reasserting the executable bit doesn't harm anything and makes the docker image non-susceptible to the source environment.
Fixes #859

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: todo-java-mongo-aca
Remote: azure-samples-staging
Branch: pr/882
You can initialize this project with:
azd init -t Azure-Samples/todo-java-mongo-aca -b pr/882

View Changes | Compare Changes

Project: todo-java-mongo
Remote: azure-samples-staging
Branch: pr/882
You can initialize this project with:
azd init -t Azure-Samples/todo-java-mongo -b pr/882

View Changes | Compare Changes


Strange parse issues in SPCcog file

and have you...

[X] I updated to the latest spin2 version available
[X] I have restarted VSCode and the problem still exists

Version of Spin2 Language Server VScode Extension with the issue
the one... you know the one... with like the colors and the text and the... you know?
Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Hardware, Operating System, Operating System version, VSCode version
Hardware: Sinneslöschen Cross-Development System Mk.3
OS Ver: Concurrent DOS 386 2.0
VSCode Ver: VSCodium 1.85.1
Description of problem
it be brok

Additional information
No response

spcog_v1_2_1.zip

Thank you, as always, for reporting this! But AUGH! I'm deep in some work on this extension that is taking longer than I expected, so I can't get a fix to you quickly. I'll push for another week on my current extension work, and if I don't wrap it, I'll then try to drop an interim fix to you.

Ok, fixes committed and will appear in v2.2.15, and later.


feat: test environment setup

[x] Adds test container services.
[x] Updates mongo.py to use test databases when tests are running.
[x] Added files to .gitignore.

cc: @minhqdao @perazz


[ALTS] Allow key buffer borrowing in alts_zero_copy_grpc_protector

Change the alts_zero_copy_grpc_protector_create(), and its related functions, to optionally borrow the key buffer instead of copying it

Decided to go with a different way as in #34814


Code signing broken with 10.10 Yosemite

Signing the app with codesign appear to be broken with 10.10 Yosemite.
Here's the full output:
Codesign ./build/MacOSX-10.9-Release/Screenmailer.app
./build/MacOSX-10.9-Release/Screenmailer.app: bundle format is ambiguous (could be app or framework)
In subcomponent: /Users/jonas/OSXApps/motion-screenemailer/build/MacOSX-10.9-Release/Screenmailer.app/Contents/Frameworks/Sparkle.framework
rake aborted!
Command failed with status (1): [/usr/bin/codesign --deep --force --sign "D...]
/Users/jonas/.rvm/gems/ruby-2.1.2@motion-screenmailer/gems/motion-sparkle-0.0.5/lib/motion/project/project.rb:43:in `codesign'
/Library/RubyMotion/lib/motion/project/app.rb:86:in `codesign'
/Library/RubyMotion/lib/motion/project/template/osx.rb:49:in `block (2 levels) in <top (required)>'
/Users/jonas/.rvm/gems/ruby-2.1.2@motion-screenmailer/bin/ruby_executable_hooks:15:in `eval'
/Users/jonas/.rvm/gems/ruby-2.1.2@motion-screenmailer/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => build:release
(See full trace by running task with --trace)

Any ideas how to fix this?
Setup:
motion-sparkle 0.0.5
RubyMotion 2.34
OS X 10.10
Xcode 6.1 beta

Hey guys, I am seeing this issue again with RubyMotion 3.3.
rake build:release fails to correctly sign my app when it has motion-sparkle with the same "bundle format is ambiguous (could be app or framework)" error.
Even manually signing App/Contents/Frameworks/Sparkle.framework/Versions/A and Versions/Current doesn't create a valid app.
It had been working fine before.
Are you seeing similar issues or is it something on my end?
Thanks!

@nickyhajal If you haven't, please try to use the master branch and lemme know if this works for you.
#Gemfile
gem 'motion-sparkle', github: 'webcracy/motion-sparkle'

@webcracy Ah, yes I was still on the yosemite-hacks branch. That worked, thank you!


Automated deployments with GitHub Actions and GitHub Releases

Automatically build and upload binaries for Windows (x64), macOS (x64, ARM?) and Linux (x64) to GitHub Releases whenever a tag is pushed.

Implement as of 392cdeede33436284b91ffcfe5c2ce8148efc34a, ARM support is tracked in #67.


Promise polyfill, at least on IE11, has a bad "finally" implementation

The implementation for the Promise polyfill when server for IE11 is wrong. Specifically,
Promise.reject(3).finally(function f() {}).then(function s() { alert('success'); }, function e() { alert('error'); })
Should alert an error, however it alerts 'success'.
The implementation of Promise.prototype.finally would fix this, however if it's loaded in 'gated' mode, it sees the (faulty) implementation provided by the Promise polyfill and doesn't load.

oh, i got you.
Actually, as you can see in the source code, the polyfill of promise is yaku. I just tested the yaku, the polyfill is ok, and finally is supported also. I think the version of yaku used by polyfill.io server is out of date. You can try this link: http://b.alicdn.com/s/polyfill.min.js?features=Promise.

@JakeChampion maybe redeploy the service?


Ligatures

I am working on a code editor and I'm interested in using Allsorts to parse font files and build up a list solely made up of the ligature type subsitutions in the font file. These are particularly important in monospace rendering of latin scripts where other types of substitution are not.
My hope is that by only concerning myself with ligatures and manually applying ligature substitutions in my rendering code, I can speed up the normally very slow operation of text shaping.
Unfortunately I'm struggling to orient myself in the Allsorts codebase and find a way to extract the ligature list out of a given font file. Can you give me some quick pointers to get me on my way?
(Awesome work by the way. I'm very hopeful this library will work for my use case)

I'm not affiliated with this project, but I share an interest in monospace fonts and font shaping.
I've partially implemented the shaping function using allsorts in my terminal emulator.
It's not complete and probably not correct, but the code may help you figure out where you want to look in the allsorts code:
https://github.com/wez/wezterm/blob/master/src/font/parser.rs#L294
FWIW, I haven't found shaping to be a performance bottleneck in practice (using harfbuzz primarily), and because there are a lot of different tables and substitutions to consider when shaping text, I would advise against recreating that logic in your application unless you are (or are prepared to become!) a font expert!

Interesting. Maybe I'm wrong, but I thought in a monospace environment (when it comes to latin based languages) ligatures were the only substitution I needed to worry about.
Your point that it might not be harfbuzz which is the performance block is an interesting one. I will do some deeper profiling to ensure it is the problem. I appreciate the hint.

I have confirmed that not all, but a significant part of my rendering budget is spent on the cpu doing text shaping. I have some evidence: For the absurd test of shaping and rendering an arbitrary binary as unicode with a font size of 7 like so:

And rapidly scrolling the buffer, I get a flamegraph representing the time spent in each function that looks like this:

The red in this case is everything outside of text shaping while the blue is spent on text shaping during the period of the rapid scrolling. Clearly this is not the only area for improvement for me, but it is a place I want to improve none the less. I suspect this may still not be harfbuzz performance problems in general, but problems with text shaping in the skia wrapper I am using. In any case handling it myself opens the door for better caching and the like.
Further the skia harfbuzz wrapper does weird things sometimes like translating certain glyphs down a couple pixels for no visible reason. I suspect this is due to some interesting font positioning rules which I could bypass by doing the shaping myself which is pretty trivial in a grid.

@Kethku As Wez advised I suspect you're better off sticking with full shaping. To answer your question though, GSUB lookup subtable four contains ligature substitions. I suspect if you only implemented support for those substitutions you'd eventually hit fonts or text that doesn't work how you expect though. For example trying edit non-latin text in your editor.

Sounds good. I appreciate the advice! I will close this as I have gotten useful pointers to move forward.


I want to provide an ipk installation package for the openwrt platform

Is your feature request related to a problem? Please describe.
I want to use arkime on my openwrt router, but I can't build the program on my router, and there is no official installation package available on openwrt
Describe the solution you'd like
I hope that the official can provide an ipk program, directly using the opkg package management tool to install in the openwrt system

I'm not sure Arkime makes sense to run directly on a openwrt router
Which device are you targeting, how much RAM does it have, and how much disk space?
I assume you would still run elasticsearch on a different device?

feel free to reopen with answers


DROOLS-6100 - Add PMML asset for clustering

Please try to rebase.

@jstastny-cz
Rebased, but there is still some unexpected exception in PR check. Will try to look at it more tomorrow.

Please try one more rebase.

@jstastny-cz
Hello it seems that PR check is finally green. Can we merge now?


linkPrefix in markdown doesn't work

Hello - it looks like relative links in the markdown are not prefixed using the loader in the starter-default.
My workaround was to modify the markdown-loader and use the markdown-it plugin markdown-it-replace-link:

var isProduction = process.env.NODE_ENV === 'production';

var md = markdownIt({
  html: true,
  linkify: true,
  typographer: true,
  replaceLink: function (link, env) {
    return isProduction ? '/prefix-link' + link : link
  }
})
  .use(require('markdown-it-replace-link'))

And to alter the script in the package.json file to set the NODE_ENV.
"scripts": {
  ...
  "deploy": "NODE_ENV=production gatsby build --prefix-links
}

Then yarn deploy or npm deploy makes it for me, but I was wondering if there was a prettier way to do this by accessing the config.toml from the loader and without explicitly setting the node environment variable.

Oh excellent work! Yes, links are only prefixed in JS environment which doesn't happen automatically (atm) for links in Markdown files.
You shouldn't need to set the NODE_ENV var as Gatsby sets that to production itself when running gatsby build as there's too many things that need that set to leave it to users.
So this could be a good thing to add to the core markdown-loader. I've heard at least one other person complain about this and it does break expectations for how things should work.
Would you be interested in creating a PR to add this? One thing that'd need updated is add a check to see if the link is relative before prefixing it (if the replaceLink plugin doesn't already do this).

I'd be happy to PR, but two questions first (I'm not exactly a pro developer):

NODE_ENV doesn't seem to be accessible from the loader index.js file, console.log(process.env.NODE_ENV) returns undefined).

Actually we should prefix when --prefix-links has been set, independently of running in production mode or not. How do I access this from the loader index.js file? I understand there is a __PREFIX_LINKS__ variable set in webpack, but I'm not sure how to access it.

Oh and I checked... replaceLink doesn't check anything, it parses all links, even absolute URLs... So as you hinted, we'd need to check if the URL is an absolute path before prefixing it. One other solution would be to add ?prefix=true in the URL, but I'm not sure this is a good idea.

Oh... interesting. That should be fixed then. We could use
https://www.npmjs.com/package/is-relative for this.
On Fri, Feb 24, 2017 at 10:21 AM David<EMAIL_ADDRESS>wrote:

Oh and I checked... replaceLink doesn't check anything, it parses all
links, even absolute URLs... So as you hinted, we'd need to check if the
URL is an absolute path before prefixing it. One other solution would be to
add ?prefix=true in the URL, but I'm not sure this is a good idea.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/gatsbyjs/gatsby-starter-default/issues/26#issuecomment-282364773,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEVh4HKHMuGFOjgZnByfBcmTpvqeDEJks5rfx-OgaJpZM4MLNYj
.

Great! What about my comment above?

Which one?

How to access --prefix-links from the index.js file in the loader?

Checkout https://github.com/gatsbyjs/gatsby/blob/66d7bf51e20f5ebcdfeb95c10e857282cd78512f/lib/isomorphic/gatsby-helpers.js
There's the __PREFIX_LINKS__ global which says if --prefix-links was used when running gatsby build and then the config module has the actual link prefix.

I understand but I can't access that global from the index.js file from the loader... console.log(__PREFIX_LINKS__) returns undefined in the terminal...

Oh right... not being too sharp here. Hmmm yeah. We only add the environment variable to the webpack context now not the node.js so it isn't available in node.js code.

Could you add a PR to add the global here as well? https://github.com/gatsbyjs/gatsby/blob/3792215f24b3b87d3fa5ecb5f37e57bad9ebf4c2/lib/bin/cli.js#L45
I think that'd be the right pattern.

Hey @KyleAMathews, thanks for your help! I'm trying to mend pieces together, but I'm not sure how to require the config.toml in the index.js from the loader to get the linkPrefix?

You'd have to read it off the filesystem and parse it. Webpack has a loader
setup for it already.
On Wed, Mar 1, 2017, 1:33 AM David<EMAIL_ADDRESS>wrote:

Hey @KyleAMathews https://github.com/KyleAMathews, thanks for your
help! I'm trying to mend pieces together, but I'm not sure how to require
the config.toml in the index.js from the loader to get the linkPrefix?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gatsbyjs/gatsby-starter-default/issues/26#issuecomment-283290442,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEVh7WkBgSXB3muVWW0ax7XjY799WUsks5rhTt4gaJpZM4MLNYj
.

Hey - checking something before doing the PR to be sure we're on the same page.
This is what I have:
// [...]

var config

try {
   config = toml.parse(fs.readFileSync(path.resolve(__dirname, '../../config.toml')))
 } catch (error) {
   console.log("Couldn't load your site config")
 }

var linkPrefix = config && config.linkPrefix || '/'

var md = markdownIt({
  html: true,
  linkify: true,
  typographer: true,
  replaceLink: function (link) {
    if (process.env.PREFIX_LINK && path.isAbsolute(link)) {
      return linkPrefix + link
    }
    return link
  }
})
  // [...]
  .use(require('markdown-it-replace-link'))

This produces the following results:
linkPrefix = ""

Link to "/" -> /
Link to "/dir" -> /dir
Link to "../dir" -> ../dir
Link to "http://www.google.com" -> http://www.google.com

---

linkPrefix = "/your-project"

Link to "/" -> /your-project/
Link to "/dir" -> /your-project/dir
Link to "../dir" ->../dir
Link to "http://www.google.com" -> http://www.google.com

Is that what you had in mind?

Yeah that looks great! Please just add a test in your PR so we can keep
things working great!
On Fri, Mar 3, 2017, 1:35 AM David<EMAIL_ADDRESS>wrote:

Hey - checking something before doing the PR to be sure we're on the same
page.
This is what I have:
// [...]
var config
try {
config = toml.parse(fs.readFileSync(path.resolve(__dirname, '../../config.toml')))
} catch (error) {
console.log("Couldn't load your site config")
}
var linkPrefix = config && config.linkPrefix || '/'
var md = markdownIt({
html: true,
linkify: true,
typographer: true
,
replaceLink: function (link) {
if (process.env.PREFIX_LINK && path.isAbsolute(link)) {
return linkPrefix + link
}
return link
}
})
// [...]
.use(require('markdown-it-replace-link'))
This produces the following results:
linkPrefix = ""
Link to "/" -> /
Link to "/dir" -> /dir
Link to "../dir" -> ../dir
Link to "http://www.google.com" -> http://www.google.com

linkPrefix = "/your-project"
Link to "/" -> /your-project/
Link to "/dir" -> /your-project/dir
Link to "../dir" ->../dir
Link to "http://www.google.com" -> http://www.google.com
Is that what you had in mind?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gatsbyjs/gatsby-starter-default/issues/26#issuecomment-283908630,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEVh3LFteYAtE5KyivR9pj3zUWS3A_bks5rh97PgaJpZM4MLNYj
.

Err sorry but what tests? This repo doesn't have any tests? Should I fix the default markdown loader from gatsby?

Oh sorry yeah, that's what I meant. And add a PR here (though the tests
aren't necessary here)
On Sat, Mar 4, 2017, 3:53 AM David<EMAIL_ADDRESS>wrote:

Err sorry but what tests? This repo doesn't have any tests? Should I fix
the default markdown loader from gatsby?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gatsbyjs/gatsby-starter-default/issues/26#issuecomment-284146836,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEVh51g5Msdti2f1Si0VEuTFW4dC3G7ks5riVCfgaJpZM4MLNYj
.

This should be fixed by PR https://github.com/gatsbyjs/gatsby/pull/710 on gatsby. Once the PR is approved there, I'll make a PR here on the gatsby-starter-default. By the way @KyleAMathews, any reason why custom loaders can't be written in ES6?


training problem

The loss jitter is large when training your own dataset, how to solve this problem?

Which loss is large?


Fix right click menus not appearing without a date=X param

This died if urlParams.date didn't exist:
isostart.setHours(isostart.getHours() - parseInt(urlParams.date));

fixes issue #740


[Doc Improvement] [Update apps upload]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/apps-upload.md
91
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit b022a18:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/apps-upload.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/apps-upload.md
91
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 4822938:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/build-your-first-app/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/concepts/deploy-and-publish/apps-upload.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 93c8bf7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/build-your-first-app/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/concepts/deploy-and-publish/apps-upload.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/apps-upload.md
91
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/apps-upload.md
91
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 49260a8:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/apps-upload.md
:warning:Warning
View
Details

msteams-platform/assets/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/build-your-first-app/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/concepts/deploy-and-publish/apps-upload.md

Line 41, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/apps-upload.md
92
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit a3e19e5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/build-your-first-app/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/concepts/deploy-and-publish/apps-upload.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/apps-upload.md
92
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 6bd13b4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/build-your-first-app/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/concepts/deploy-and-publish/apps-upload.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/apps-upload.md
92
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit d37bf20:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/build-your-first-app/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/concepts/deploy-and-publish/apps-upload.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/apps-upload.md
92
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit de4c87f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/build-your-first-app/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-teams.gif
:white_check_mark:Succeeded
View

msteams-platform/concepts/deploy-and-publish/apps-upload.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/apps-upload.md
93
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 8b4732d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/build-your-first-app/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-teams.gif
:white_check_mark:Succeeded
View

msteams-platform/concepts/deploy-and-publish/apps-upload.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/apps-upload.md
93
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 17c4a13:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/build-your-first-app/add-teams-apps.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-teams.gif
:white_check_mark:Succeeded
View

msteams-platform/concepts/deploy-and-publish/apps-upload.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Verify build is clean

What this PR does / why we need it:

Add .coverprofile to ignored files, so that travis builds do not mark binaries as "dirty"
Add a basic check which ensures that the binaries are "clean" before pushing to the registry

Release note:
NONE

/kind bug

/hold

Introduced an issue. will update the PR soon.

/hold remove

/hold cancel

@davidvossel @nellyc should be correct now.


pkg/cluster: change API to v1alpha2 for kubeadm >= 1.11

Since k8s v1.11, API version of kubeadm has changed to v1alpha2, and v1alpha1 is deprecated. So it's recommended to use v1alpha2 for kubeadm >= 1.11, and v1alpha1 will be completely removed in the upcoming release 1.12.
We need to introduce a new option for the API version, to conditionally deal with it.
Fixes https://github.com/kinvolk/kube-spawn/issues/280

As k8s v1.12 is going to be released in a couple of weeks, we need to merge this PR.


AWS::UrlSuffix pseudo parameter is not recognized by rule E1019

cfn-lint version: 0.26.3

I am attempting to use a Fn::Sub with the following arguments: https://s3.${AWS::Region}.${AWS::UrlSuffix}/amazoncloudwatch-agent-${AWS::Region}/amazon_linux/amd64/latest/amazon-cloudwatch-agent.rpm and I  am recieving the following error:
E1019 Parameter AWS::UrlSuffix for Fn::Sub not found at Resources/LaunchTemplate/Metadata/AWS::CloudFormation::Init/SharedConfig/files//tmp/amazon-cloudwatch-agent.rpm/source/Fn::Sub
build/sam/template.yml:6178:17

It appears that this rule is too strict or is not aware of the new ${AWS::UrlSuffix} pseudo-parameter.  See the Pseudo Parameter docs for more detail.

Agreed.  Looks like it isn't documented as a supported function inside a Sub.  I'm assuming your template works, correct? https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-sub.html#w2ab1c25c24c59c13

Is AWS::UrlSuffix the only pseudoparameter it complains about?
I thought we handled all pseudoparameters equally now
https://github.com/aws-cloudformation/cfn-python-lint/blob/9504c274b8e36053183f25624b70ecad39c31e49/src/cfnlint/helpers.py#L121-L130

That was the only one it complained about yeah.  The template is valid

Is AWS::UrlSuffix the only pseudoparameter it complains about?
I thought we handled all pseudoparameters equally now
https://github.com/aws-cloudformation/cfn-python-lint/blob/9504c274b8e36053183f25624b70ecad39c31e49/src/cfnlint/helpers.py#L121-L130

Which version supports the AWS::UrlSuffix params?

@kddejong FWIW, CFN to my knowledge has always supported using pseudo parameters in a Fn::Sub.  The doc you mentioned gives examples for just two of the pseudo-parameters but doesn't preclude any others though.

@rstevens011 and @PatMyron  I'm looking at the Supported Functions section.  You may be right about sub supporting all the things but the list of supported functions was originally started from those docs.  I'm guessing some of this has to do when certain functions are processed and whats available to them at the time.
@PatMyron since each function may only support certain functions inside of it we validate it as such.
https://github.com/aws-cloudformation/cfn-python-lint/blob/daf5af68e5e2dfd36b2c92eaeedc80e9b96c0983/src/cfnlint/rules/functions/Sub.py#L46-L57

ugh, and then I realized what I'm missing here.  Hold on.

At least according to cfn-lint as it is today.  AWS::URLSuffix <> AWS::UrlSuffix.

At least according to cfn-lint as it is today. AWS::URLSuffix <> AWS::UrlSuffix. It took me a while but I finally caught up. Sorry.

good catch @kddejong, @rstevens011 I think it should work after capitalizing rl

Looks like that is how CloudFormation handles it too.
Unresolved resource dependencies [AWS::UrlSuffix] in the Resources block of the template

Closing for now.  We can re-open if needed.


request help: How to update crds?

Issue description
Hi, I'm learning apisix-ingress-controller project, I have a question about how to generate the crds under sapmles/ folder if we update the resource field like ApisixRoute.  Can we only manually update it?
Environment

your apisix-ingress-controller version (output of apisix-ingress-controller version --long):
your Kubernetes cluster version (output of kubectl version):
if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (uname -a):

The current process is done manually. There is also a PR in progress to switch it to kubebuilder-based mode.
https://github.com/apache/apisix-ingress-controller/pull/1320

@tao12345666333 Understood, thank you for your answer.


Functional: Avoid duplicating expressions in SimpleAssignTargetPass

The SimpleAssignTargetPass rewrites assignments such as a = b = 0 into single assignments. However, in the process, the right-most hand-side will get duplicated multiple times.
This:
<<first assign target>> = <<second assign target>> = <<very big expression>>

Will become:
<<first assign target>> = <<very big expression>>
<<second assign target>> = <<very big expression>>

To avoid duplicating  <<very big expression>>, we could rewrite it instead to:
tmp = <<very big expression>>
<<first assign target>> = tmp
<<second assign target>> = tmp

(where tmp is a fresh variable name)
https://github.com/GridTools/gt4py/blob/8e9ac25300ac8d4eda920ee206b046ae9edf9d30/src/functional/ffront/ast_passes/simple_assign.py#L50-L80

This works well if <<first assign target>> is just a symbol, but I'm unsure if it's guaranteed that an assignment target can never be a bigger expression. This might be true now (not sure). But we may want to change that in the future.
I think at the Python AST level, we shouldn't make strong assumptions about what the AST will look like. If we support more general cases, we'll be more flexible at later stages (e.g., dialect parser) in the future. I'm quite afraid of Python AST passes restricting possibilities in the future.
Related: #1017

For simplicity of the pass I implemented the temporary approach. Otherwise something like this gets complicated (b, c) = a = (1, 1) as the tuple on the left hand side can not copied to the right hand side without modifying the ctx field of the ast.Name nodes.


Add annotation property to indicate sources that influenced a definition

We have used something like this for some of our past clients.
gist:definitionSourcedFrom
	a owl:AnnotationProperty ;
	rdfs:subPropertyOf skos:note ;
	rdfs:range xsd:string ;
	skos:definition "Indicates a source that influenced the definition"^^xsd:string ;
	skos:prefLabel "definition sourced from"^^xsd:string ;
	.

It will often have a value of datatype, anyUrl

SUGGESTION: Do not implement; use rdfs:seeAlso for this. The RDFS Spec says:

"A triple of the form: S rdfs:seeAlso O states that the resource O may provide additional information about S. "

If more specificity is needed, then properties such as isSourcedFrom can be introduced as subproperties of rdfs:seeAlso

Shall we have an issue to include the use of rdfs:seeAlso in our style guide?


doc typos

Hello, Prof. Zhang,
I can see you have modified part of the website.
However, please check https://github.com/jwzhanggy/tinyBIG/blob/main/docs/examples/image/cifar10.md and https://github.com/jwzhanggy/tinyBIG/blob/main/docs/examples/image/index.md
in these two pages, the "CIFAR10 Object Detection in Images" may be changed to "CIFAR10 Object Recognition in Images"

Thanks, Chenxi. just updated it to reflect the changes.

by the way, if you find any other typos, welcome to reply to this issue, I will keep it open

by the way, if you find any other typos, welcome to reply to this issue, I will keep it open

No problem! Very happy to provide small contributions to this great project.

Thank you for your great work.
https://github.com/jwzhanggy/tinyBIG/blob/main/docs/examples/text/index.md?plain=1#L15-L16
In the index.md file, I noticed that the {{agnews_example_files}} and {{sst2_example_files}} in the Related Files content are swapped.

Thank you for your great work.
https://github.com/jwzhanggy/tinyBIG/blob/main/docs/examples/text/index.md?plain=1#L15-L16 In the index.md file, I noticed that the {{agnews_example_files}} and {{sst2_example_files}} in the Related Files content are swapped.

thanks, just update it

https://github.com/jwzhanggy/tinyBIG/blob/main/tinybig/reconciliation/lowrank_reconciliation.py#L336 and #L409, #L510, #L583.
In the lowrank_reconciliation.py, I noticed small doc typos that "\frac{D}{p}" where it should probably be "\frac{D}{q}".

thanks, just updated it, will also update this typo in the paper as well.

Sorry, I wrote it briefly. In the lowrank_reconciliation.py, there are three more the doc typos "\frac{D}{p}":
https://github.com/jwzhanggy/tinyBIG/blob/main/tinybig/reconciliation/lowrank_reconciliation.py#L409
https://github.com/jwzhanggy/tinyBIG/blob/main/tinybig/reconciliation/lowrank_reconciliation.py#L510
https://github.com/jwzhanggy/tinyBIG/blob/main/tinybig/reconciliation/lowrank_reconciliation.py#L583
I'm sorry to make you do the same thing again.

Sorry, I wrote it briefly. In the lowrank_reconciliation.py, there are three more the doc typos "\frac{D}{p}": https://github.com/jwzhanggy/tinyBIG/blob/main/tinybig/reconciliation/lowrank_reconciliation.py#L409 https://github.com/jwzhanggy/tinyBIG/blob/main/tinybig/reconciliation/lowrank_reconciliation.py#L510 https://github.com/jwzhanggy/tinyBIG/blob/main/tinybig/reconciliation/lowrank_reconciliation.py#L583
I'm sorry to make you do the same thing again.

just update them all, thanks.


Prime Unlimited Photos

Hi,
Even though Amazon Prime gives you unlimited photo storage, this app is only showing the drive as having a capacity of 5GB and will not allow me to attempt to upload more photos once capacity has reached 5GB. I can't be the only Prime user wanting to use this app, surely?
When I log into ACD through the browser, it is confirmed that the photos uploaded so far are not contributing to the storage limit, so this seems to be a problem with the app specifying a 5GB limit on the size of the drive.

I can try to report 100Tb as for unlimited.

That should work, provided I stick to uploading photos.

Problem is I can not test it because I already have Unlimited Everything and cannot register another email for Photos Unlimited with the same credit card even just for free trial.

If you compile for me, i can test it and see if it works.

Ok, try https://github.com/Rambalac/ACDDokanNet/releases/tag/1.5.6

I've used this to up all my photos and it works brilliantly. I may need to test what happens if I accidentally try and upload more than 5GB of non-photos though.

Hello I still have this issue

I am not sure why this can happened.
I try on Both Unlimit photo + unlimit everything (Both trial) account but non of them seem to work.
BTW, i am not amazon prime users.

I think I found the bug, strange it did not fail before. version 1.6.1 should work


Programmatic dismissing SlidingUpPanel via touch on frame above anchor does not work

I have a SupportMap in the top frame and a listview in the bottom frame with an anchor about 3/4 up the map.
If I have the list anchored and I try to hide the list via a click on the map, the panel listener shows that the panel state goes from ANCHORED to DRAGGING,  then DRAGGING to ANCHORED (the setPanelState(HIDDEN) gets lost / overridden).
mMapFrag.setTouchListener(new OnTouchListener()
{
	@Override
	public void onTouch()
	{
		mSlidingUpPanelLayout.setPanelState(PanelState.HIDDEN);
	}

What should be happening is the panel listener should show anchored to dragging, then dragging to hidden.
It appears that the sliding up panel thinks I'm dragging the panel from anchored to anchored when I touch on the map to hide the panel.  This happens even if I setTouchEnabled to be false before setPanelState to hidden.
Another weirdness here is sometimes the sliding panel moves part way down before it stops, so you can touch the map several times and it will make a little progress towards hiding the sliding up panel each time - but it thinks it's anchored.
It looks like if I move the logic to onRelease() instead of onTouch() the slidingUpPanel behaves itself, but there are definitely some weird state issues revealed by the above sequence of events.

It's not the SlidingPanel the problem but it's the map fragment. You have to intercept the imputs before the reach the map fragment, do stuff and only afterward forward them to the fragment itself. Read this: https://goo.gl/vuPcgg


Error

(node:1382) UnhandledPromiseRejectionWarning: Error: Command failed: tesseract stdin stdout
/bin/sh: 1: tesseract: not found
at ChildProcess.exithandler (child_process.js:308:12)
at ChildProcess.emit (events.js:314:20)
at ChildProcess.EventEmitter.emit (domain.js:483:12)
at maybeClose (internal/child_process.js:1022:16)
at Socket.<anonymous> (internal/child_process.js:444:11)
at Socket.emit (events.js:314:20)
at Socket.EventEmitter.emit (domain.js:483:12)
at Pipe.<anonymous> (net.js:675:12)

(node:1382) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:1382) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
events.js:291
throw er; // Unhandled 'error' event
^
Error [ERR_STREAM_DESTROYED]: Cannot call write after a stream was destroyed
at doWrite (_stream_writable.js:399:19)
at writeOrBuffer (_stream_writable.js:387:5)
at Socket.Writable.write (_stream_writable.js:318:11)
at IncomingMessage.ondata (_stream_readable.js:718:22)
at IncomingMessage.emit (events.js:314:20)
at IncomingMessage.EventEmitter.emit (domain.js:483:12)
at IncomingMessage.Readable.read (_stream_readable.js:507:10)
at flow (stream_readable.js:1007:34)
at resume (_stream_readable.js:988:3)
at processTicksAndRejections (internal/process/task_queues.js:84:21)
Emitted 'error' event on Socket instance at:
at errorOrDestroy (internal/streams/destroy.js:108:12)
at Socket.onerror (_stream_readable.js:754:7)
at Socket.emit (events.js:314:20)
at Socket.EventEmitter.emit (domain.js:483:12)
at errorOrDestroy (internal/streams/destroy.js:108:12)
at onwriteError (_stream_writable.js:418:5)
at onwrite (_stream_writable.js:445:5)
at doWrite (_stream_writable.js:399:11)
at writeOrBuffer (_stream_writable.js:387:5)
at Socket.Writable.write (_stream_writable.js:318:11) {
code: 'ERR_STREAM_DESTROYED'
}

Same error here

its caused by tesseract not being installed on your machine

Open a terminal and type in "tesseract", get this to work first.
This is basically what this node module relies upon.


feat: Allow images to be inserted as thumbnails or as linked thumbnails

When inserting an image into a page, the image will be inserted using the original size.
Two new options allow the user to insert thumbnails instead, either with a link or without a link to the original image.
German translations are included.

Looks good, I would like to improve the function for insert media instead of adding a new function. I will check later. thanks


Green Dots test suite failing to run on current HEAD (0c00be1)

I believe this says it all:
brandon@Air phlex % git switch 0c00be1
fatal: a branch is expected, got commit '0c00be1'
hint: If you want to detach HEAD at the commit, try again with the --detach option.
brandon@Air phlex % bundle exec gd gd
bundler: failed to load command: gd (/Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bin/gd)
gd/phlex/callable.rb:4:in `<class:Example>': uninitialized constant Phlex::Callable (NameError)
	from gd/phlex/callable.rb:3:in `block (2 levels) in <top (required)>'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/green_dots-6aa5a700a46c/exe/gd:20:in `class_eval'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/green_dots-6aa5a700a46c/exe/gd:20:in `block (2 levels) in <top (required)>'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/green_dots-6aa5a700a46c/exe/gd:19:in `initialize'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/green_dots-6aa5a700a46c/exe/gd:19:in `new'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/green_dots-6aa5a700a46c/exe/gd:19:in `block in <top (required)>'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/green_dots-6aa5a700a46c/exe/gd:18:in `each'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/green_dots-6aa5a700a46c/exe/gd:18:in `<top (required)>'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bin/gd:25:in `load'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bin/gd:25:in `<top (required)>'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/cli/exec.rb:58:in `load'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/cli/exec.rb:58:in `kernel_load'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/cli/exec.rb:23:in `run'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/cli.rb:451:in `exec'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/vendor/thor/lib/thor/command.rb:28:in `run'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/vendor/thor/lib/thor.rb:527:in `dispatch'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/cli.rb:34:in `dispatch'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/vendor/thor/lib/thor/base.rb:584:in `start'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/cli.rb:28:in `start'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.5.5/exe/bundle:28:in `block in <top (required)>'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/friendly_errors.rb:117:in `with_friendly_errors'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.5.5/exe/bundle:20:in `<top (required)>'
	from /Users/brandon/.rbenv/versions/3.2.2/bin/bundle:25:in `load'
	from /Users/brandon/.rbenv/versions/3.2.2/bin/bundle:25:in `<main>'
brandon@Air phlex % bundle exec gd
bundler: failed to load command: gd (/Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bin/gd)
<internal:/Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require': cannot load such file -- helper (LoadError)
	from <internal:/Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/zeitwerk-2.6.12/lib/zeitwerk/kernel.rb:38:in `require'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/green_dots-6aa5a700a46c/exe/gd:12:in `<top (required)>'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bin/gd:25:in `load'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bin/gd:25:in `<top (required)>'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/cli/exec.rb:58:in `load'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/cli/exec.rb:58:in `kernel_load'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/cli/exec.rb:23:in `run'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/cli.rb:451:in `exec'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/vendor/thor/lib/thor/command.rb:28:in `run'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/vendor/thor/lib/thor.rb:527:in `dispatch'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/cli.rb:34:in `dispatch'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/vendor/thor/lib/thor/base.rb:584:in `start'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/cli.rb:28:in `start'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.5.5/exe/bundle:28:in `block in <top (required)>'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/bundler/friendly_errors.rb:117:in `with_friendly_errors'
	from /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.5.5/exe/bundle:20:in `<top (required)>'
	from /Users/brandon/.rbenv/versions/3.2.2/bin/bundle:25:in `load'
	from /Users/brandon/.rbenv/versions/3.2.2/bin/bundle:25:in `<main>'
brandon@Air phlex % bundler --version
Bundler version 2.5.5
brandon@Air phlex % gem --version
3.5.5
brandon@Air phlex % ruby --version
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [arm64-darwin21]
brandon@Air phlex % rbenv --version
rbenv 1.2.0

I've never used Green Dots before so I wasn't sure if the repetition of gd was correct, or a typo in the source I was working from, so I tried it both ways.
I have not yet tried bisecting.  I'll try that later if time allows...

Let's ignore GreenDots for now and just use bundle exec sus. I don't think there are any GreenDots tests that aren't covered by the Sus suite, but I’ll double-check before I close this issue.


Update process.ts

I am closing this PR, since this doesn't seem like an intentional PR. There are hard-coded values in the PR, which doesn't make a lot of sense.


enhancement for the logfile

Wouldn´t it be nice to have the Filename together with the Macrohash in the logfile instead of the hash only ?
Before:
INFO: [4] The macro hash is: 3fa93227b810d3359f258442
After:
INFO: [4] The macro hash of file Mydocument.doc is 3fa93227b810d3359f258442

Please quote the filename to also cover filenames with spaces properly.


Chart Crash (Psych Engine 0.6.2)

Describe your bug here.
I was doing a cover of fatality, and when I went to test the chart for some reason the game warned that it hears a crash error
the Error:
Note.hx (line 124)
PlayState.hx (line 2353)
PlayState.hx (line 1053)
flixel/FlxGame.hx (line 637)
flixel/FlxGame.hx (line 724)
flixel/FlxGame.hx (line 677)
flixel/FlxGame.hx (line 545)
openfl/events/EventDispatcher.hx (line 402)
openfl/display/DisplayObject.hx (line 1399)
Uncaught Error: Null Object Reference
I can no longer modify or play the chart
Please help me
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No, i didn't change anything in the .HX files

go to your chart's json file and replace every instance of "lengthinSteps": 16, with "sectionBeats": 4,


Cleanup performance logging

Move performance logging into function that need to log their elapsed time.

/azp run

/azp run


Use git gc when packaging for download

git gc --prune=new --aggressive saves over 100MB
It's slow, but likely worth it!
See https://git-scm.com/docs/git-gc

https://cs.opensource.google/flutter/flutter/+/master:dev/bots/prepare_package.dart can be updated to prune the repo. I'm currently running some benchmarks if there's anything more optimal than the defaults in git gc.
One example, I think we can remove commit objects which would get the .git from 190MB to <1MB
\cc @christopherfujino

We could do git clone --depth 1 to remove all the extra commits. However, users that want to become contributors will need to run a git fetch --all to get the missing refs.

We could do git clone --depth 1 to remove all the extra commits. However, users that want to become contributors will need to run a git fetch --all to get the missing refs.

I'm pretty sure we explicitly cannot do this, there are certain git operations that we call that will fail if you're in a shallow clone. I can't remember them off the top of my head. I think we could potentially do it after https://github.com/flutter/flutter/issues/112833 is implemented, though.
git gc --prune=new --aggressive SGTM though!

git gc --prune=new --aggressive saves over 100MB
It's slow, but likely worth it!

cc @godofredoc, who I know would like to speed up packaging.

FYI: should be --prune=now 😄
Also FYI: depending on the machine, gc --aggressive can be MINUTES. Not sure how much that matters.

This is great! I'm definitely up for anything making packaging faster.

Unfortunately running this would actually make the packaging slower, and I was wondering if that would be a deal breaker.

It's a bad comparison, but on my M1 mac it takes <1 min to run. Since it's an O(minutes) I think the trade offs are reasonable, and I'll continue to investigate ways we can shrink the packages.

This is implemented in this weeks release.
Previous: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8801128044821647073/+/u/prepare__create_and_publish_a_flutter_archive/stdout
New: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8799839059726138433/+/u/prepare__create_and_publish_a_flutter_archive/stdout
It saved 100MB+ of space on Mac, and doesn't have a noticeable impact on the packaging time.


The "detektCheck" Gradle task is never UP-TO-DATE

I just realized that running the exact same ./gradlew detektCheck task two times in a row without changing any source code does not show the detektCheck task to be UP-TO-DATE, as expected, but runs the task again. Is that by design? If so, I'd vote for changing that for performance reasons, and because tasks can be easily forced to rerun with the --rerun-tasks Gradle command line option.

The main drawback is that right now it's not incremental which it should be.

So how to change that? Any gradle experts here :)

We need to declare an input. Probably the source files. Gradle will then do the rest of the work.

The tasks should have both inputs and outputs.

Right as output we could use our output.

I can take a pass at the Gradle stuff sometime next week after https://github.com/arturbosch/detekt/pull/719 is completed