How I can get version browsers limit of Shaka Player ( v4.6.3 )

I just can get infomation of version IOS and Safari with this link : https://shaka-player-demo.appspot.com/docs/api/tutorial-upgrade.html

Thank you
@shaka-bot

We currently do not have this information and we do not know it for sure, but here is what should be supported:

WebOS 3.0+
Tizen 2.4+
All Xbox One and Xbox Series S|X
Chrome 38+
Edge Chromium all versions.
Edge legacy all versions.
Safari 9+
PlayStation 4 and 5
Chromecast all versions
Firefox 42+


Add pinning for cargo udeps

The version of cargo udeps should be pinned and locked, so instead of this line:
cargo install cargo-udeps
we would have something like this, where udeps version depends on the rust version:
cargo install --locked<EMAIL_ADDRESS>

This ticket should also include how we will upgrade this version in the future (part of the release process/rust upgrade?)

Implemented in https://github.com/stackabletech/operator-templating/pull/257/files


ra_project_model::json_project::Crate.key_value_cfg doesn't match ra_config::CfgOptions.key_values

In debugging some #[cfg(<feature>)] issues, I discovered that there's a mismatch in how features are handled by the json_project module vs. the CfgOptions struct:
in ra_config/src/lib.rs:23
pub struct CfgOptions {
    atoms: FxHashSet<SmolStr>,
    key_values: FxHashSet<(SmolStr, SmolStr)>,
}

and in ra_project/src/json_project:19
pub struct Crate {
    pub(crate) root_module: PathBuf,
    pub(crate) edition: Edition,
    pub(crate) deps: Vec<Dep>,
    pub(crate) atom_cfgs: FxHashSet<String>,
    pub(crate) key_value_cfgs: FxHashMap<String, String>,
    pub(crate) out_dir: Option<PathBuf>,
    pub(crate) proc_macro_dylib_path: Option<PathBuf>,
}

CfgOptions.key_values is a HashSet<(String, String)>, while Crate.key_value_cfg is a HashMap<String, String>.
The result being that the json_project configuration path only excepts a single feature (or a single value for any named kind of item in the cfg).
I have a quick fix together that switches Crate.key_value_cfg over to a HashSet<(String, String>) to match the CfgOptions, but it needs a different json structure:
Instead of:
"key_value_cfgs": {
    "feature": "alloc",
    "feature": "default",
    "feature": "i128_support",
},

(which when parsed results in a ("feature", "i128_support") tuple as the only "feature" that was loaded),
it becomes:
"key_value_cfgs": [
    ["feature" , "alloc"],
    ["feature" , "default"],
    ["feature" , "i128_support"],
],

But that's a breaking change with respect to anyone currently using the json config method, the old json fails to be parsed entirely.  Anyone using it will need to update their json files to match, at the same time, or I can write a custom Deserialize impl that will support both (and can later be removed in favor of the
I have a couple questions:

Is making key_value_cfgs a hashset of (String, String) the right change?
Is a custom Deserialize impl that bridges the gap for users welcome?
Where can I put the unit-tests for this? (in the same file?)

Excellent catch! Yeah, CfgOptions is right here!
This functionality is tested by a (single) integration test here: https://github.com/rust-analyzer/rust-analyzer/blob/a76d392fe9cb3c8adc67ba3700645e1bc3713f11/crates/rust-analyzer/tests/heavy_tests/main.rs#L372
I think we should extend this test, rather than add a second one alongside -- heavy tests are slow, so, long term, I think it's important to prioritize execution speed over ortogonal factoring here.
In terms of backwards compatability, the current format is not considered stable, so its should be fine to change it without fallbacks (but cc @benbrittain).
Not sure what would be the best json format here. I guess maybe we need to merge atom and keyvalue into simply:
"cfg": [
  "unix",
  "feature=foo",
  "feature=bar",
]

ie, split by = just like rustc does?

I'm fine with dropping it into a single list. It felt more structured the other way but it's not a big deal.
I told @woody77 that I'm fine with a hard transition or soft, whatever is easiest for him and you. We'll need to time our next toolchain role with the rust-analyzer release pretty tightly if we do a hard transition though. I'm looking forward to having rust-analyzer distributed with rustc so that we can vendor a prebuilt.

Ah, haven't realized that you are already aware of this, feel free to unsubscribe from the issue then, Benjamin :)
@woody77, so, if you control both sides of the transition here, than do whatever you find more convenient, with the constraint that, on rust-analyzer's side, we would prefer to remove the fallback in the short/medium term.
I don't have strong preference about the json format, but I still think I am +0 on the single cfg with splitting on the first =.

I like the approach of a single cfg.  It makes for an easy transition, as it doesn't require any custom deserialization, and just a new field, and then atom_cfgs and key_value_cfgs can be removed separately, after a toolchain role.

A question on the integration test at:
https://github.com/rust-analyzer/rust-analyzer/blob/a76d392fe9cb3c8adc67ba3700645e1bc3713f11/crates/rust-analyzer/tests/heavy_tests/main.rs#L372
This doesn't verify the cfgs, just that they they don't cause any issues.  Were you thinking of extending that to include some #[cfg(<feature>)] items that would then be validated in the output?

For the test, I think it's best to verify that goto definition takes cfgs into account, like is done in this PR for cargo-based builds:
https://github.com/rust-analyzer/rust-analyzer/pull/4296/files#diff-6c022a6d0a252a09b52cea16ebcaf287R578
we probably should rename the test itself to something like test_project_json.

Thanks for the pointer to that.  That definitely makes for a better test.  For my prototyping, I've added a few very light unit-tests to json_project.rs and was thinking of adding one to ra_project_model/lib.rs to make sure that CfgOptions is properly set from the json file.
But it looks like you have a preference for integration tests over unit tests in this code?

Unit tests indeed would not harm, but, for those areas where perfectly pure and reproducible rust-analyzer internals are glued to the messy external world, we indeed favor (few) integration tests.

I've been using unit-tests to validate my code changes (using both the previous and the new values).  I'm trying to get a PR up.  It's been a while since I did any PRs with GitHub, so it's taking me time to get that sorted.

I've hit a snag, however.  What's this env var?
https://github.com/rust-analyzer/rust-analyzer/blob/6f2f9049dad24681a5e785555f975bfed8138d45/crates/rust-analyzer/tests/heavy_tests/main.rs#L794

This is a new env introduced in 1.43 :
https://github.com/rust-lang/cargo/pull/7697

That worked, thanks much.

#4382 is a draft PR for this.  I haven't expanded the integration test yet, and I'm still sorting out how to use a locally-build rust-analyzer, but wanted to get feedback on approach and the tests.


How to validate bool

type Thing struct {
  Truthiness bool `json:"truthiness" validate:"required"`
}

Using gin-gonic/gin with this, when it marshals JSON into a struct, this passes:
{ "truthiness": true }

But this fails, b/c it is the golang zero-value for bool
{ "truthiness": false }

I just want to validate that the property exists -- if it exists, I know it will have a value of true or false.
Nothing obvious popped out at me from: https://godoc.org/gopkg.in/bluesuncorp/validator.v5#pkg-variables

I think there may be some small confusion about how this works.
Validator validates the data within the struct after it has been in unmarshalled from JSON.
So the steps that happen are:

JSON post received
during Bind the struct is initialized
the JSON is unmarshalled into the structure variables

Since go is statically typed, regardless if truthiness is passed or not, the structure will always have a value and since go's bool's are not tri-state.
It does not validate the JSON but data after unmarshalling.
Sorry for no samples, answering from my phone.
Doe's this answer your question?

Give me a few minutes, I have an idea that may work for you.
Just tied up at the moment

I was thinking you could make the bool value a pointer, then it would fail when no value was present, but it would still fail ifvaluewas false so that won't work.
I may look into adding a new tag, "exists" it will not have any validation functions associated with it, however will be the failure tag when value is a pointer and is value of nil.
In the mean time however, there really isn't a way to check if a bool is set.

I was going to maybe take a stab at writing a custom validator that could just check if something exists, but I figured I'd ask here first in case I misread the situation.

I'm actually in the middle of adding the "exists" tag it's seem to work well when using bool as a pointer, will let you know when it's released; hopefully tonight.

Awesome!  thanks!

Hey @davisford, guess I was closer than I though lol
Example
if you use "exists" tag like below and bool is a pointer you will get the functionality you are looking for.
NOTE: this works with any Pointer, Interface or Invalid Type.
type Thing struct {
  Truthiness *bool `json:"truthiness" validate:"exists"`
}

Notes
This change was implemented in v6 and back-ported to v5.
I Highly recommend everyone to update to v6 if possible as some things added in v6 already cannot be back-ported to v5 due to the code change between v5 and v6

Awesome -- thank you.  I may have to make my own fork of gin and update to v6.  Might take a bit -- sounds like you tested it out...feel free to close the issue.  I appreciate the super immediate response time.

no problems, yes I tested with your exact scenario with bool as a pointer and using exists flag.
P.S. @davisford I think gin allows for custom/other validation libraries to be plugged in, in this case just the updated version, however I don't have a link to the commit, or documentation.
P.P.S star if you like, just trying to get more stars than the other validators out there, even ones that are unmaintained have more stars :frowning:

Hey @davisford I came across how to add your own validator in gin to avoid forking, it's in this issue 2nd or 3rd comment https://github.com/gin-gonic/gin/pull/224#issuecomment-117567957

Is this still supported in v9 ? I need the same behaviour for HTTP PATCH where I have to distinguish between ommited and set values - therefore the bool pointer. I'm getting the error that exists does not exist as a validator.

Hey @codepushr I dropped exists in favour of just using required and added some nullable checks so required should work just like exists did in this scenario.
if not then it could be a bug, could you provide some sample code and I'll check it out ASAP

Sure! This should demonstrate what I mean. Basically the validation fails although I'm using a pointer to a bool with false as the value. What I'm expecting is that if I use a pointer the validation only checks if it's not nil - but in this case it also checks the underlying value - which MAY work as expected but is different from exists in v8.
package main

import (
	"log"

	v "gopkg.in/go-playground/validator.v9"
)

type Foo struct {
	Bar *bool `validate:"required"`
}

func main() {
	b := false

	model := Foo{
		Bar: &b,
	}

	err := v.New().Struct(model)

	log.Println(err)
}

Hey @codepushr thanks for the code,
I already replicated the issue, just running last minute tests and fix will be out in a few minutes so required will now work as expected.
will tag you and this issue when making the final release.
P.S. thanks for reporting.

ok @codepushr release 9.2.0 should fix this for you.
Please let me know if it works for you 😃
NOTE: the reason I removed exists is that required implies exists and had a number of people mention that it was confusing and so now required handles both, with one tag.

Looking good! Thanks for the amazingly quick response! :)

thanks all

package todos

import (
	"time"

	"github.com/go-playground/validator/v10"
)

// Todo This is a model for TODO
type Todo struct {
	ID        string    `json:"id"`
	Name      string    `json:"name" validate:"required"`
	Completed bool      `json:"completed" validate:"required"`
	CreatedAt time.Time `json:"created_at"`
}

// use a single instance of Validate, it caches struct info
var validate *validator.Validate

// Validate validate input data
func (t *Todo) Validate() error {
	validate := validator.New()
	return validate.Struct(t)
}

Payload:
{
	"name": "Teste",
	"completed": false
}

Response message:
{
  "error": "Key: 'Todo.Completed' Error:Field validation for 'Completed' failed on the 'required' tag"
}

Source: https://github.com/lucassimon/fiber-estudos

Same issue as the above. Could you suggest the best solution for v10?

Reopened in #714.

Reopened in #714.

model
` golang
package models
type Toggle struct {
Status *bool json:"status" validate:"required"
}`
func for validate
`golang
func (s *Validations) ValidateRequest(c echo.Context, payload interface{}) error {
c.Echo().Validator = &models.Validator{Validator: validator.New()}
if err := c.Bind(payload); err != nil {
	s.Log.Errorf("Invalid request. c.Bind() => %s", err.Error())
	return err
}

if err := c.Validate(payload); err != nil {
	s.Log.Errorf("Invalid request. c.Validate() => %s, \terror: %s", StructToString(payload), err.Error())
	return err
}

return nil

}`
and it works. For validate if bool exists, you need make bool as a pointer.
Note: I tested it in v9

Bom dia galera. Mesmo problema com na v10 com o Bool igual a false. Mesmo passando no corpo da requisição, ele retorna que é necessario passar. Alguma sugestão?

Good morning guys. Same problem as in v10 with Bool equal to false. Even passing in the request body, it returns that it is necessary to pass. Any suggestion?

Running v10.9.0 and having the same issue.

If the bool value is set to a pointer, the error is fixed. Version 10.10.0

@harezmii

Status *bool , If the bool value is set to a pointer, the error is fixed. Version 10.10.0

getting this error
cannot use data.IsWrite (type *bool) as type bool in field value

*bool still doesn't work for me. Any ideas to solve this guys?

Same problem here guys. Version v10.11.1:
type BaseMaterialData struct {
	Name        string `json:"name" validate:"required,max=125"`
	Description string `json:"description" validate:"max=256"`
	Active      bool   `json:"active" validate:"required"`
}

When a json with "active: false" arrives, validator fails.

@EduFrazao try remove required, set default value to false

@EduFrazao try remove required, set default value to false

Thanks. I've done that as a workaround and its running.

@EduFrazao try remove required, set default value to false

Hi, man! Can u show me how u did that? I'm experiencing the same error but cant change my type to *bool

if you use Active      bool   json:"active" validate:"required"and if the payload send{"active": false}then it will not pass the validation , but if payload send as{"active": true}` then it will pass the validation, which in both case should pass. I tried it like so:
Active      bool   json:"active" validate:"required,boolean"` the same
I tried it like so:
Active      bool   json:"active" validate:"boolean"it works, but when payload does not contain theactive` then no error occurs which is still not correct
This is my validator version:
"github.com/go-playground/validator/v10"

@nsmosi this has been explained many times in a number of issues. I believe it is a misunderstanding of how Go works.
as defined on your struct is a bool which has two states true and false. In go there is no such thing as an uninitialized variable and so if the value is not defined in the JSON it will be false by default on your struct.
if false being the default state if not in the JSON is desired then theres really no need to validate it at all.
if you need to detect presence then you need a third state. Changing to a pointer *bool is one way to give this third state to ensure it was set.


Obvious clone passes blinky test

Not an issue, but another for your gallery
** Blinky Test **
** Keir Fraser<EMAIL_ADDRESS>** https://github.com/keirf/Greaseweazle
Serial = 39a5:000b:120e:4c30:4a38:004e
Flash Size  = 64kB
Device ID = 0x0410
Revision  = 0x2003
**WARNING**: 10xx8/B device returned valid IDCODE! Fake?
Testing I2C1... OK
Testing I2C2... OK
Testing SPI1... OK
Testing SPI2... OK
Testing TIM1... OK
Testing TIM2... OK
Testing TIM3... OK
Testing TIM4... OK
DMA Test #1... OK
DMA Test #2... OK
DMA Test #3... OK
DMA Test #4... OK
Testing 64kB Flash... OK
Enable TIM4 IRQ... .OK
Testing 20kB SRAM (endless loop).........

Added to wiki. Thanks!


Ingest error when neighbors from bbknn

Ingest tries to search for the metric used when neighbors was called. When this information is not available it fails. Is there a workaround for this?

adata = sc.datasets.pbmc68k_reduced()
adata_ref = sc.datasets.pbmc3k_processed()

var_names = adata_ref.var_names.intersection(adata.var_names)
adata_ref = adata_ref[:, var_names]
adata = adata[:, var_names]

# add fake batch
adata_ref.obs['batch'] = pd.Categorical(np.random.choice(a=[0, 1, 2],    size=adata_ref.shape[0]))

sc.pp.pca(adata_ref)
sc.external.pp.bbknn(adata_ref, batch_key='batch')
sc.tl.umap(adata_ref)
sc.tl.ingest(adata, adata_ref, obs='louvain', embedding_method='umap')

scanpy/scanpy/tools/_ingest.py in _init_neighbors(self, adata, neighbors_key)
    283             dist_args = ()
    284
--> 285         self._metric = neighbors['params']['metric']
    286         dist_func = named_distances[self._metric]
    287

KeyError: 'metric'

Versions:

scanpy==1.4.7.dev83+g5345a50.d20200506

The workaround is to add metric manually to .uns['neighbors']['params']['metric']. However, i'm not sure it is conceptually right to use ingest with bbknn.

Thanks.

Hi @Koncopd
Can you elaborate a bit more on what to set .uns['neighbors']['params']['metric'] to?
Thanks!

I think it's normally just the string "euclidean", but you can just test what is stored in .uns['neighbors']['params']['metric']
after running sc.pp.neighbors() on some test data.


Add or update the Azure App Service build and deployment workflow config

@microsoft-github-policy-service agree [company="yonathan}"]


Make table headers sticky.

Apologies if this is not the correct place to put this.
Someone suggested that the table headers should be 'sticky', so remain in place as you scroll the longer lists (LAs, the tables at the bottom), and I think this should hopefully do it. The extra bits besides the main (which is all that's needed for the bottom tables) are because of the default padding in the tabs panel meaning you can see things above the sticky heading, so I moved the padding from the panel to the header.

 Make table headers sticky.


Release 1.2.0.Beta4

Summary
Release 1.2.0.Beta4 as want to have fixed OT tracing in the Quarkus Test Suite
Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[ ] Refactoring
[x] Release
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update

Checklist:

[ ] Example scenarios has been updated / added
[ ] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

OCP errors are already addressed by this PR: https://github.com/quarkus-qe/quarkus-test-framework/pull/531


Separate builds for production and development/test

e.g. I would like to have:
esbuild app/javascript/*.* --bundle --outdir=app/assets/builds '--define:process.env.NODE_ENV=\"production\"' --minify

for  production. (this is necessary to have the production build of react that is like 3-5x smaller)
And:
esbuild app/javascript/*.* --bundle --outdir=app/assets/builds

for development/test.
seems like there should be yarn build:production hooked into rake assets:prepare instead of yarn build

my temporary solution:
bin/build
#!/usr/bin/env node

require('dotenv').config()

const { exec } = require("child_process")

const logAndExec = (command) => {
  command = `${command} ${process.argv[2]}`
  console.log(command)
  exec(command)
}

if (process.env.NODE_ENV === "production") {
  logAndExec("esbuild app/javascript/*.* --bundle --outdir=app/assets/builds '--define:process.env.NODE_ENV=\"production\"' --minify")
} else {
  logAndExec("esbuild app/javascript/*.* --bundle --outdir=app/assets/builds")
}

and in package.json:
    "build": "./bin/build",

I think that's a fine solution. But I don't think it's something we need/want to add as defaults here. These shims should be just enough to get started and going, and then you can specialize from there.

ok
a better script for reference:
#!/usr/bin/env ruby

def log_and_exec(*args)
  args += ARGV
  puts args.join(" ")
  system(args.join(" "))
end

if ENV["NODE_ENV"] == "production"
  log_and_exec(
    "esbuild",
    "app/javascript/*.*",
    "--bundle",
    "--outdir=app/assets/builds",
    "'--define:process.env.NODE_ENV=\"production\"'",
    "--minify"
  )
else
  log_and_exec(
    "esbuild",
    "app/javascript/*.*",
    "--bundle",
    "--outdir=app/assets/builds",
  )
end

I could see us adding something like this to a wiki here?


Refactor to support metacom3 contract and specs

[x] tests and linter show no problems (npm t)
[x] code is properly formatted (npm run fmt)

Landed in https://github.com/metarhia/impress/commit/64d7444af40a752c0c71d1db110d70a8330932d0


Remove rendering of Past Prime Ministers pages

Once rendering of the Past Prime Ministers index page and the individual Past Prime Minister pages have been migrated to Collections, the rendering can be removed from Whitehall.
Trello card
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

Having a general look through whitehall for historic stuff, I found one additional file that looks like it can also be removed (I think it was just used for foreign secretaries so could have gone before)

Good find.  I'll add that as an extra commit here as it's somewhat related.


Unhandled error during execution of watcher callback    at

<UserButton>
<UserButton.MenuItems>
<UserButton.Action label="Open chat" @click="openChat">
<template #labelIcon>
<Icon />
</template>
</UserButton.Action>
</UserButton.MenuItems>
</UserButton>

When I changed it to this it worked fine

Which version are you on? It should be fixed in 0.5.1

Feel free to reopen if you still encounter the issue


Remove cmd/patchelf.rb [Linux]

Codecov Report

Merging #794 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
+ Coverage   70.42%   70.56%   +0.13%
==========================================
  Files         384      383       -1
  Lines       20632    20592      -40
==========================================
  Hits        14530    14530
+ Misses       6102     6062      -40

Impacted Files
Coverage Δ

cmd/patchelf.rb

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a7ca5a...5e1d49b. Read the comment docs.


Add a method to the geojs viewer to highlight drawn annotations

This is meant to be used for reactive applications to make a single annotation (or element) prominent on the display.  I don't know if "highlight" is the word, but I couldn't think of anything better.
There are performance issues when dealing with a large number of elements, so the opacity toggling behavior is disabled for large annotations.  I'm sure there are a number of performance enhancements we could make if it becomes an issue.

I'm not sure what to make of this build error.  It only happens on one of the python 2.7 build environments.   https://travis-ci.org/girder/large_image/jobs/317032114#L2795

Yes -- it is odd, as we have python-dev installed, so the header file should be there.  I'm looking into it.

I wonder if it needs python2.7-dev.  I'm trying it in another branch.

Nope.  Didn't work.

I cleared the travis cache and the push build succeeded.  If the pr build also succeeds, that was probably all that was necessary.


Aggregate plots and header together

Detailed description about how to use our app still missing

I'll solve the conflicts and send a different pull request.


Add named arguments

Previous discussed on #5.
Work left to do:

[x] Add support for optional arguments
[ ] Review by @csnover and @kitlith
[ ] Whatever bikeshedding needs to be done

Design:

Named arguments are implemented via a typed builder
The typed builder uses 3 types and 1 trait

types: Needed, Optional, Satisfied - all ZSTs used for maintaining type state of the fulfillment of the arguments
trait: SatisfiedOrOptional - Implemented for, as the name implies, Optional and Satisfied. This is used for bounding all the arguments on finalization in order to ensure Required arguments have all become Satisfied

New import syntax: #[br(import( $ident: $ty $( = $expr)? )]

ident - name of arg
ty - type of arg
expr - an optional default value, making this argument non-required

How to use the typed builder manually:

<Test as BinRead>::Args::builder()
     .allow_zero(true)
     .forbid_zero(false)
     .finalize()

How to pass arguments in derive macro:

#[args(allow_zero: true, forbid_zero: false)]

Still need to be done:

Move Vec to the new system
Recursive inner arguments (maybe an args!{} macro?)
Documentation on generated builder types
Look into improving the error messages

typed-builder seems to have their finalizer "implemented" for invalid points to finalize in order to provide a better error message link (note: they also use deprecation notices in order to provide more info, clever!)
it also does the same for double-passing arguments link

I'm also going to expand on our discord conversation a few days ago a bit here, now that I have energy and am a bit more coherent.
The reasoning you presented for re-implementing the type-safe builders inside of binrw instead of using the existing crate consisted of 3 points:

generating macros is gross / codegen should be a single pass

i think we simply have differing opinions on this, generating macros seems like a nice way to reuse code to me. but because of it being a differing opinion, i don't want to push on this point too much.

the existing errors don't fit binrw well

i'd argue that we fork and maintain some simple error message differences, or collaborate with them to produce some better error messages, maybe with some sort of flag that can be passed to toggle the type of error messages produced. idk. I believe either of these options would result in less code that we have to maintain, document, and be responsible for in general.

the implementation would be gross

gen_args_struct_and_builder!(Ident; name: ty = expr, name: ty, ...); feels like a not very difficult macro_rules macro to implement in binrw (pass things through, add attributes where appropriate for e.g. handling defaults and generating the builder) which could then be used from our proc_macro (it only has to provide the name of the struct).

maybe that's still a gross implementation, idk. to me it feels like it's taking most of the complexity outside of the proc-macro, and also making it usable when hand-implementing stuff.

In the end, I leave the decision up to you. I'm willing to take your current implementation and implement it in terms of the other crate if that's what you decide on, and I'm not going to make this some kind of breaking point where i refuse to help with the library if this design goes through (though i might internally grumble a bit).

Encountered an implementation issue while I was working on the macro I'm gonna suggest adding:
this
#[derive(BinRead)]
#[br(import(count: usize, inner: T::Args))]
struct Vec<T: BinRead> {
    c: u8
}

generates:
pub(crate) struct VecBinReadArgs {
    count: usize,
    inner: T::Args,
}

need to (conditionally?) add generics to the argument struct.

Proposal for args! { ... } macro: playground
fn passthrough_helper<T>(_a: PhantomData<T>) -> T {
    panic!("This is a type system hack and should never be called!");
}

fn builder_helper<T: HasBuilder>(_: PhantomData<T>) -> T::Builder {
    <T as HasBuilder>::builder()
}

macro_rules! args {
    ($($name:ident : $value:expr),*) => {
        {
            let __args_ty = PhantomData::<_>;
            if false {
                 passthrough_helper(__args_ty)
            } else {
                let __builder = builder_helper(__args_ty);
                $(let __builder = __builder.$name($value);)*
                //$crate::named_args!(__args; $($entry)*);
                __builder.finalize()
            }
        }
    };
}

Codecov Report

Merging #21 (b0616fb) into master (81b7c78) will decrease coverage by 2.59%.
The diff coverage is 64.72%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   78.22%   75.63%   -2.60%
==========================================
  Files          35       38       +3
  Lines        1488     1740     +252
==========================================
+ Hits         1164     1316     +152
- Misses        324      424     +100

Impacted Files
Coverage Δ

binrw_derive/src/codegen/sanitization.rs
66.66% <ø> (ø)

binrw_derive/src/lib.rs
22.22% <0.00%> (-9.60%)
:arrow_down:

binrw_derive/src/parser/mod.rs
86.11% <ø> (ø)

binrw_derive/src/parser/top_level_attrs.rs
86.72% <ø> (ø)

binrw_derive/src/codegen/mod.rs
66.66% <50.00%> (-6.07%)
:arrow_down:

binrw_derive/src/codegen/typed_builder.rs
51.06% <51.06%> (ø)

binrw_derive/src/parser/types/passed_args.rs
84.21% <60.00%> (+6.43%)
:arrow_up:

binrw_derive/src/codegen/imports.rs
82.85% <82.85%> (ø)

binrw_derive/src/parser/meta_types.rs
92.56% <86.79%> (-4.54%)
:arrow_down:

binrw_derive/src/parser/types/imports.rs
91.30% <92.85%> (+5.59%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81b7c78...b0616fb. Read the comment docs.

Current implementation of args and import handling:
args(a, b + 1, c) // tuple-style args
args { a, b: 2 } // named args
args_raw(a) // raw arguments
args_raw = a // same as above

import { a: u32, b: u16 = 3 } // named args import
import(a: u32, b: u16) // tuple-style args
import_raw(tuple: (u32, u16)) // raw argument imports

There still appears to be issues with generics:
#[derive(BinrwNamedArgs, Clone)]
pub struct VecArgs<B: BinRead> {
    pub count: usize,
    // TODO: provide a default for inner arguments somehow (specialization?)
    pub inner: B::Args
}

causes some weird issues that seem to go away when the BinrwNamedArgs derive is removed.
error[E0433]: failed to resolve: use of undeclared type `B`
  --> binrw/src/binread_impls.rs:74:16
   |
74 |     pub inner: B::Args
   |                ^ use of undeclared type `B`

error[E0107]: missing generics for struct `VecArgs`
  --> binrw/src/binread_impls.rs:71:12
   |
71 | pub struct VecArgs<B: BinRead> {
   |            ^^^^^^^ expected 1 type argument
   |
note: struct defined here, with 1 type parameter: `B`
  --> binrw/src/binread_impls.rs:71:12
   |
71 | pub struct VecArgs<B: BinRead> {
   |            ^^^^^^^ -
help: use angle brackets to add missing type argument
   |
71 | pub struct VecArgs<B><B: BinRead> {
   |                   ^^^

what makes it worse is that somehow the errors aren't associated with the derive/proc macro as i'd expect them to be? from a glance it just looks like "you made a weird mistake while writing this code."
it looks like the reason this is happening is because the builder is generated as
#[allow(non_camel_case_types)]
pub(crate) struct VecArgsBuilder<Field_count, Field_inner> {
    count: Option<usize>,
    inner: Option<B>,
    __bind_generics: ::core::marker::PhantomData<(Field_count, Field_inner)>,
}

which, as you can see, has no generic B on it.

alright, so, we get missing_doc warnings on the generated builder, which leads to all the UI tests failing since, well, there's warnings about missing documentation.
Other than that, the implementation for Vec seems to compile and work okay so far. (though i'm gonna also do punctuated as well)

I think i figured out a way to handle "this member should default if it implements Default" without specialization.
Have additional implementations of finalize on types of the builder that aren't technically fully satisfied, gated on where PossiblyDefaultGeneric: Default

Codecov Report

Merging #21 (008b331) into master (81b7c78) will decrease coverage by 4.19%.
The diff coverage is 61.62%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   78.22%   74.02%   -4.20%
==========================================
  Files          35       38       +3
  Lines        1488     1771     +283
==========================================
+ Hits         1164     1311     +147
- Misses        324      460     +136

Impacted Files
Coverage Δ

binrw_derive/src/codegen/sanitization.rs
66.66% <ø> (ø)

binrw_derive/src/lib.rs
21.21% <0.00%> (-10.61%)
:arrow_down:

binrw_derive/src/parser/field_level_attrs.rs
92.20% <ø> (-1.30%)
:arrow_down:

binrw_derive/src/parser/mod.rs
86.11% <ø> (ø)

binrw_derive/src/parser/top_level_attrs.rs
86.72% <ø> (ø)

binrw_derive/src/parser/types/passed_args.rs
78.94% <50.00%> (+1.16%)
:arrow_up:

binrw_derive/src/codegen/typed_builder.rs
53.75% <53.75%> (ø)

binrw_derive/src/codegen/mod.rs
72.72% <57.14%> (ø)

binrw_derive/src/parser/meta_types.rs
80.16% <58.49%> (-16.94%)
:arrow_down:

binrw_derive/src/codegen/read_options/struct.rs
81.92% <82.75%> (-0.53%)
:arrow_down:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81b7c78...008b331. Read the comment docs.


Add octokit pagination to listForRef/listFiles Github API calls

See #744.

Use the octokit pagination help for check run API call
Noticed that the listFiles API call probably has the same issue so added pagination to that one as well

Tests:

Unfortunately couldn't run the built-in NPM test target since I don't have access to the test repo
Verified the shape of the data in VS Code using types
Ran prettier/eslint

@tianhaoz95 Let me know what I can do here to get this one merged. I can see that there some status checks failing, presumably because this is running from a Github fork?

I think I messed up some CI conditions... give me a bit time, will figure it out and do a few tests.

It looks like fixing the forked testing requires a bit more work. For now, let me merge it into a non-master branch and do some testing there. Will try to fix fork testing following that.

@all-contributors please add @jtbeach for code ideas

@all-contributors please add @jtbeach for code ideas


Change default find highlight color

Currently find highlights are red by default. We should default to NSColor.findHighlightColor or something? There may also be a color defined in the theme that we can use. (The motivation for not using the colors in the theme is that we support multiple 'find groups' with different colors, and want these to be distinct, but I think we should default to an appropriate color for the first group.

@cmyr , @nangtrongvuon added a fix for this here https://github.com/xi-editor/xi-mac/pull/481

cool, thanks!


WIP- refactor Babbage Features test

My idea with this refactoring is to avoid  having to keep "manual" track of what variable to  use/reuse, so that the test case is consistent. So now the testcase is constructing this TestCaseData object and calls a function, and then inside the function, we are using the data to construct circumstances that make sense for the scenario.
I'm sure it's too specific/specialized in some cases, because my understanding of these concepts are quite shallow atm, so I doubt that these abstractions I introduced are sound.. Suggestions welcome!
A few test cases for valid tx missing,  plus the the invalid cases - but the approach seems to work so far :crossed_fingers:

I haven't looked at the changes yet, but I'd recommend modifying the Test.Cardano.Ledger.Examples.BabbageFeatures directly. It will be easier to see what is being changed in the github diff.

Superseded by https://github.com/input-output-hk/cardano-ledger/pull/2872


Attached picture is posted before caption is typed

When attaching a picture to a post, the picture is posted in its own post before I can type a caption. I wanted to post the picture and caption in the same post, but someone else commented on the picture before seeing the context I provided with the text caption.

Thanks for the request! Closing as a duplicate of #4540, fixed in #5474.


Add support for less pre-processor

Hope it's not a dupe, tried to search for it but less is a very generic term.

@rayshan please see https://github.com/bassjobsen/ionic-learn/blob/less/content/formulas/working-with-less/article.md; how to use Less in stead of SASS now.
Motivation and explanation can be found at: http://bassjobsen.weblogs.fm/less-ionic-framework/


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/96849

TagBot fix

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/99217

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/103431

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/109357

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/110792

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/116130


docker-compose is deprecated

docker-compose is deprecated. Should use docker compose which is the v2 of docker-compose.
SO docker-compose vs docker compose

From July 2023 Compose V1 stopped receiving updates
Migrate to Compose V2

When I try to run make run I got this error.
docker-compose down --remove-orphans
make[1]: docker-compose: No such file or directory

I can solve it by installing docker-compose, but I think it's good if the Makefile is using the v2.
What do you think? should we update all the Makefile to use docker compose?

Hello, @Hidayathamir
Nice catch!

What do you think? should we update all the Makefile to use docker compose?

Sure, can you create a PR for it?

I remember we use docker-compose because github action doesn't support v2. But it might support right now


[1.33] Impossible to update. Migration failed

Hello,
I try to update to 1.33 but i have an error now when I start :
12|umami   | ><EMAIL_ADDRESS>check-db
12|umami   | > node scripts/check-db.js
12|umami   |
12|umami  | ✓ DATABASE_URL is defined.
12|umami  | ✓ Database connection successful.
12|umami  | ✓ Database tables found.
12|umami  | ✗ Cannot read property '0' of null

Thanks by advance :)
Regards
Quentin

Try to debug :
pnpm prisma migrate resolve --applied ".*"
Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma
Datasource "db": PostgreSQL database "umami", schema "public" at "localhost:5435"
Error: P3017

The migration .* could not be found. Please make sure that the migration exists, and that you included the whole name of the directory. (example: "20201207184859_initial_migration")

Okay I have fix by running :
prisma migrate resolve --applied "20210320112717_init"

@mikecao maybe you need to add on readme an information to tell on existing database to run this command.


Littlest documentation error

On this page of the docs, you can find the following code snippet in the example on creating a custom component:
return (
      <CustomInput
        onCustomChange={e => dispatch(actions.change(model, e))}
      >
    );

it's missing the / before the closing bracket.

Fixed, thank you!

✌


Yisui/fix windows compilation

Fix the header files on Windows:

inet.h, sys/socket.h, netinet/in.h, -> Winsock2.h, windows.h
<unistd.h> -> win/xdaglib/unistd.h
<termios.h>    -> Disabled on Windows
Adding getopt.h/getopt.c to provide library replacement for Windows.

Thanks for your work !!!!

But windows compilation is already working

where are used getopt.h/getopt.c ? did you notice that they are LGPL licensed ?
So are you pushing a new windows wallet ?

maybe you should divide the improvement to the core from the new wallet and push the new wallet in a separated repo

Closing this, see the new pull request from xDagWallet/yisui/winsupport.


Ensure that the Application is Responsive through Bootstrap

Application needs to be responsive to different screen sizes. Want to accomplish this through the usage of Bootstrap classes to make our lives easier.

Completed.


How would you authenticate and download a file from an ftp server with grab?

The title says it all. Apologies if it's a newbie question :)

Good question! Unfortunately, grab only supports HTTP/HTTPS/H2.
FTP support would be great, but might fairly heavy reimplementation.


Upgrade to Rust 1.83

Massive change due to new clippy lints

let's make sure to remember to upgrade draft too


Dev

demo page

Looks good. I am going to merge it. You can later on add more information into it and use it as CV. I can help you deploy it in your username.


Identify and resolve gaps between sysl transforms and arrai transforms.

@springwiz Can you close this ticket and instead create a separate ticket to identify all gaps between sysl transforms and arrai transforms.
Originally posted by @andrewemeryanz in https://github.com/anz-bank/sysl-go/issues/121#issuecomment-647253848

@springwiz I'll attempt to migrate the first service to get a benchmark of code comparison. I'll then hand this over to you to investigate the remaining services.

@andrewemeryanz you probably want to check on my changes in https://github.service.anz/dcx/anzapp-bff/tree/master/codegen/arrai asI've already fixed a bunch of issues with the rest code

@anz-gordonj7 Thanks.

@anz-gordonj7 Can you point me to issues that you have fixed, in the arrai code included in dcx/anzapp-bff.

diff the dcx/codegen/arrai directory with sysl-go/codegen/arrai. I don't have a list of changes made

Migration complete.


Bump to vs15

The old version works with VS Enterprise 15 preview 2. Since I'm on that, I bumped up the installation target.

Thanks!


Fix git push error for protected CLA branch

The pull request is created from master636885276184293672 to master to fix git push error for protected CLA branch

@opbld16 : Thanks for your contribution! The author, @, has been notified to review your proposed change.


Amm liquidity pool

WIP, dont merge

https://github.com/thales-markets/thales-improvement-proposals/blob/main/TIPs/TIP-99.md


Unable to find audit logging information for IBM Cloud Identity and Access Management from Activity Tracker.

Is your feature request related to a problem? Please describe.
Unable to find audit logging information for IBM Cloud Identity and Access Management from Activity Tracker API.
Describe the solution you'd like
API support for audit logging information for IBM Cloud Identity and Access Management.
Describe alternatives you've considered
Additional context
Is there any other API to fetch audit logging information for IAM.

@pooraniss-ibm Could you please help with this issue?

@bigdatasourav sorry I dont fully understand the ask.. can you please give me more information please

@padamstx @pooraniss-ibm sorry for the delayed response on it, here is what we want in terms of support from you,
The below API for Activity Tracker supports, route & target-related information
https://github.com/IBM/platform-services-go-sdk/blob/main/atrackerv1/atracker_v1.go
We would like to track audit logging information for IBM Cloud Identity and Access Management as per this doc. Any suggestion on how do we achieve this? We are automating a few controls to track these activities as part of IBM CIS (1.18 Enable audit logging for IBM Cloud Identity and Access Management). Any forward direction will help. Happy to provide more information further.


Add "√" character to sqrt()

I saw that this "½" character is accepted in functions, so I believe this "√" can also be accepted for sqrt().

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

I would like to work on this

I would like work on this

I believe the issue should be closed since input accept √


VCS run simulation fail

make --keep-going IBEX_CONFIG=opentitan SIMULATOR=vcs \
ISS=spike ITERATIONS=1 SEED=1 \
TEST=riscv_machine_mode_rand_test WAVES=0 COV=0

Build metadata already exists, not recreating from scratch.
Building RTL testbench
[Errno 2] No such file or directory: 'xrun'
make[1]: *** [scripts/ibex_sim.mk:42: out/metadata/tb.compile.stamp] Error 1
Building randomized test generator
make[1]: *** [scripts/riscvdv.mk:61: out/metadata/instr.gen.build.stamp] Error 1
make[1]: Target 'all' not remade because of errors.
make: *** [Makefile:66: run] Error 2

I used vcs to run the simulation. why scripts tell me i need cadence xelium tool?
I'm confused. Could you help me?

Hi there! I just set up a container so that it didn't have xrun on its path, and your command seems to have worked as I'd expect. I'm going to close this because I can't see anything that we need to fix. If you're still having a similar problem, please could you re-open and give us a little more information about what's going on? Many thanks.


Branch and html feature, bugfixes and improvements

Use stylua format, replace vim script, data folder

stylua formatter changed a bit of code. The config is included
Some autocommand groups where defined in vim script. Converted to lua, for better debugging
Fixed all diagnostic messages with lua language server
moved the json file from .config to .local folder. Some people want .config to just be their settings (e.g. to include in their dotfiles). A log file should be placed elsewhere. I will make it configurable later
added a configuration with optional variables Configuration was previously handled with global variables. It is better to define a configuration that is optional
Add configuration option for json file path
Added the branch tracking - No aggregation  yet https://github.com/gaborvecsei/usage-tracker.nvim/issues/7
fixed wrong port in the telemetry endpoint
Better error handling telemetry, select aggregation The error handling for plenary.curl did not work, because it is an async call. plenary.curl documentation is not easy, but I found this https://github.com/nvim-lua/plenary.nvim/pull/471 and included on_error to handle possible errors
When the user forgets the aggregation key, a selection is called. As it is vim.ui.select, it should be with the picker of choice
plenary test for config
html file generation using chart.js
doc file

@Dronakurl thank you very much for the PR! I'll try to review it in the following week - but this is a huge one.

OK, I will see to it. I am on some other project right now, though. The html file generation could be separated, I think.

I just disabled the plugin in my own environment, because I see these problems you also described in the README. Sometimes, there are periods which are longer than 24h. I think it has something to do with the inactivity detector which does not trigger when I just close my laptop lid or something.
I had a look at wakatime.nvim, they use similar techniques, but I could not find out, how they solved this issue (mainly because it is written in vim script). It might even be possible to integrate the possibility to send "heartbeats" to wakatime as an option.


[BEAM-22] Add ExecutorServiceParallelExecutor as an InProcessExecutor

This is responsible for scheduling transform evaluations and
communicating results back to the evaluation context. The executor
handle PTransforms that block arbitarily waiting for additional input.

R: @bjchambers, @kennknowles
I'm not 100% on the way I'm currently tracking blocked threads, but I'm also not sure if there's a more effective way to do it;

Incidentally, the Jenkins error doesn't seem related. I presume pushing something more onto this PR will get a re-run that will pass.


Publish action chain vars

Action chain vars are published in the result of an action chain under the published property.
Also, added support for a special __context property that can be used in ActionChain, Rules, AliasExecution and Notification sections. This property will help with debugging.

Sample ActionChain
---
    chain:
        -
            name: "c1"
            ref: "core.local"
            params:
                cmd: "date"
            publish:
                date: "{{c1.stdout}}"
            on-success: "c2"
            on-failure: "c4"
        -
            name: "c2"
            ref: "core.local"
            params:
                cmd: "echo \"c2: parent exec is {{action_context.parent.execution_id}}.\""
            publish:
                context: "{{__context}}"
            on-success: "c3"
            on-failure: "c4"
        -
            name: "c3"
            ref: "core.local"
            params:
                cmd: "echo c3"
            on-failure: "c4"
        -
            name: "c4"
            ref: "core.local"
            params:
                cmd: "echo fail c4"
    default: "c1"

Results of an execution
"result": {
        "published": {
            "context": "{'date': u'Mon Jan  4 16:06:59 PST 2016', '__results': {'c2': {u'failed': False, u'stderr': u'', u'return_code': 0, u'succeeded': True, u'stdout': u'c2: parent exec is 568b092332ed354a1d2d19ea.'}, 'c1': {u'failed': False, u'stderr': u'', u'return_code': 0, u'succeeded': True, u'stdout': u'Mon Jan  4 16:06:59 PST 2016'}}, u'i1': u'hi', 'c2': {u'failed': False, u'stderr': u'', u'return_code': 0, u'succeeded': True, u'stdout': u'c2: parent exec is 568b092332ed354a1d2d19ea.'}, 'c1': {u'failed': False, u'stderr': u'', u'return_code': 0, u'succeeded': True, u'stdout': u'Mon Jan  4 16:06:59 PST 2016'}, 'system': <st2common.services.keyvalues.KeyValueLookup object at 0x7f6bfc2c0b90>}",
            "date": "Mon Jan  4 16:06:59 PST 2016"
        },
        "tasks": [
           ...
        ]
    }

Fixes https://github.com/StackStorm/st2/issues/2344

nice

Overall, I like the idea, but I wonder if it should be enabled by default. A runner parameter perhaps?
Many times you pass temporary variables around which are only used by some tasks, but not actually returned in the end result. Some of those variables can contain a lot of data and returning all this data in the result object could potentially cause issues and break things.

but I wonder if it should be enabled by default. A runner parameter perhaps?

I personally do not want to have the response controllable by a runtime property. It would be nice if we could simply make this consistent - can compare to mistral and see what happens in that case.

On a related note - if we enable it by default it would also be a good idea to test and run it on our build server for a while.
On a related note, ?exclude_attributes=result.published would potentially also be useful.

if we enable it by default it would also be a good idea to test and run it on our build server for a while.

This is really an ask by @lakshmi-kannan  - I am mostly meh to this feature. Can put it behind a feature flag or as you pointed previously make it controlled by a runner parameter. I do feel that publishing the computed variables is a good idea but if you suspect that there will be issue I am happy to put up some guard-rails  (not sure what :P)

Yeah, I'm fine if we leave it disabled by default and make it a runner parameter :)

I am +1 for adding published vars to results [by default, or always]; user has control on what to publish and can/should form it so that it doesn't pollute the result.
In mistral we went the other way around offering an option for the task to suppress keeping task results in the context. User does not always have control of what the action returns, and if the action returns tons of data, user can pick the right piece of data, publish it, and supress keeping action output in the context (so no pollution).
This is a case when feature will shape the use: once published variables are part of result, they will likely be used to form the "real, useful" part of result. To be seen.

I am +1 for adding published vars to results [by default, or always]; user has control on what to publish and can/should form it so that it doesn't pollute the result.

Yes, user has control over it, but in a lot of cases, publish is only used to make "temporary" aliases for variables so they can be more easily accessed in tasks further down the chain. Imo, publishing a variable so it's available in the context of the next task(s) is different than returning a result / publishing a variable from the last task in the chain.
Another reason why I'm also not a big fan of it is that it's not really explicit. I think of it as "temporary  variable assignment" in the code which is different then "returning a result" from the function.
Lack of explicitness can be somewhat be offset by good documentation, but I still always strive to keep things explicit when possible (makes it easier to work with, debug, understand, etc.).
In any case, I won't block, but at the very least I just want to make sure stuff won't break with tasks which publish temporary variables which contain a lot of data (weekly github report action chain workflow is a good example of that - temporary published variables contain tons of data and even if the things won't break, included so much data which is not relevant to the result will clutter it).

Have we investigated the possibility of disabling tasks by default too? I'm missing a lot of context at the moment, but I'm assuming this is our end goal for the change.

Have we investigated the possibility of disabling tasks by default too? I'm missing a lot of context at the moment, but I'm assuming this is our end goal for the change.

Not end goal for this change. The end goal is to make @lakshmi-kannan happy. See https://github.com/StackStorm/st2/issues/2344

https://stackstorm.slack.com/archives/stackstorm/p1452019094019933

Another reason why I'm also not a big fan of it is that it's not really explicit. I think of it as "temporary variable assignment" in the code which is different then "returning a result" from the function.

I agree but this PR doesn't address that. Having a runner parameter to enable this or not is indeed a good idea and seems straight forward to add. I am not sure if this immediately would be beneficial. Lot of people on community have issues with this jinja templating part. So maybe we just publish everything for a bit and see.

@Kami good points re meaning of variables vs output however proper definition of actionchain output vs local variables is a matter of ActionChain v2; let's not bloat this one but note and apply when we do v2.
I am stressing that lack of published variables in action chain result has been a confusion already, and this is a quick way to address this confusion. So +1 for the change as is.
OK with a runner parameter to control __context, but as for published variables, it should be clear one behavior, and again, I say, "part of results".

https://stackstorm.slack.com/archives/stackstorm/p1452024546019985

OK with a runner parameter to control __context

This is super secret and internal. Lets not include it in the discussion here ;)

https://stackstorm.slack.com/archives/stackstorm/p1452027288020084

:+1:


Multiple type information on hover

First of all, great package, thanks for everyone who contribute for this package.
Now something I didn't understand is how to view all the hover type information, I can see the first when I hover but the arrows or tab will just act on my code and won't change the hover, that way I can only see the first declartion, am I missing something or is this a missing feature?

Missing feature 🌹
Up for grabs


SolidJS support

Add SolidJS bindings for the Dialog component.

SolidJS support is currently completely blocked by testing issues.
https://github.com/solidjs/solid-testing-library/issues/16
I do not want to break out of Vitest to use Jest just to test SolidJS.
We will have to abandon SolidJS for now until testing with Vitest is fixed.

We'll proceed with SolidJS components without tests for now.


Add test coverage to the PowerShell host

More tests should be added to validate all the interactive scenarios enabled by the new PS kernel host.
The validation tests should cover all the override methods in PSKernelHostUserInterface implementation, including the following:

[ ] public override PSCredential PromptForCredential(string caption, string message, string userName, string targetName)
[ ] public override PSCredential PromptForCredential(string caption, string message, string userName, string targetName, PSCredentialTypes allowedCredentialTypes, PSCredentialUIOptions options)
[x] public override string ReadLine()
[x] public override SecureString ReadLineAsSecureString()
[ ] public override void Write(ConsoleColor foregroundColor, ConsoleColor backgroundColor, string value)
[ ] public override void Write(string value)
[ ] public override void WriteLine()
[ ] public override void WriteLine(ConsoleColor foregroundColor, ConsoleColor backgroundColor, string value)
[x] public override void WriteLine(string value)
[x] public override void WriteErrorLine(string value)
[x] public override void WriteDebugLine(string message)
[x] public override void WriteVerboseLine(string message)
[x] public override void WriteWarningLine(string message)
[x] public override void WriteProgress(long sourceId, ProgressRecord record)
[ ] public override Dictionary<string, PSObject> Prompt(string caption, string message, Collection<FieldDescription> descriptions)
[ ] public override int PromptForChoice(string caption, string message, Collection<ChoiceDescription> choices, int defaultChoice)

The checked ones are covered by tests that come with #202
But a few more tests could be added for the WriteProgress scenarios.


fix: Authenticated datasource passwordExists field added for plugins

Description

Authenticated datasource passwordExists  field added for plugins

Fixes #14783
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=aeace31

/ok-to-test sha=7e0678a

/ok-to-test sha=57c1e75

/ok-to-test sha=5b37aad

/ok-to-test sha=457fb84

/ok-to-test sha=a83304b

/ok-to-test sha=369255a

/ok-to-test sha=6e2a2ab

/ok-to-test sha=25557cd

/ok-to-test sha=2a862ef

/ok-to-test sha=2a862ef

/ok-to-test sha=8a0d6f4

/ok-to-test sha=9199f3efff1de279d905b55fcd5010ebf6894480

/ok-to-test sha=637a1cd

/ok-to-test

/ok-to-test sha=637a1cd


TensorRT model conversion

@chufengt  can we convert the current pretrained or custom model into tensor rt for faster inference ?

@abhigoku10 did you successfully convert the model to tensor rt??

@chufengt  nope i did not go to that phase of conversion , do let me knw if your able to convert

@chufengt @A7med01  i am getting this below error when converting to onnx "RuntimeError: Exporting the operator affine_grid_generator to ONNX opset version 11 is not supported. Please feel free to request support or submit a pull request on PyTorch GitHub"

solved in #44


Can I write JS/TS/(S)CSS + HBS demos in demos folders instead of markdown?

Reason being is that VSCode and WebStorm doen't have support for intellisense in embedded languages in markdown.
(which is funny because in (neo)vim, I have everything :upside_down_face: ).
For (non-vim) authors who need to make demos that are heavily dependent on complex structures, having TS intellisense in demos would be a huge win.
I imagine these'd work just like components? but in the docs/**/demos directories?

You could set up code-import instead of inlining the content in markdown.
https://github.com/kevin940726/remark-code-import
This way you can have all your demo components in a plain file.
(Interesting you can get intellisense in code blocks in neovim, I need to look at your nvim setup. :D)

Maybe instead, is possible to write a docfy plugin to move demo files to the app component folder?
Cause then I'd probably do regular js imports in the markdown and skip all the remark awkwardness for authors


Subtitles disabled on English content pack

Not sure about the reasoning for this, should we release 0.17 with a "known issue" that all the English subtitles are missing?
@mrpau-eduard can you comment on the decision to disable it?
https://github.com/learningequality/ka-lite-content-packs/blob/master/contentpacks/__main__.py#L15
https://github.com/learningequality/ka-lite-content-packs/blob/master/Makefile#L3

I am not sure if we should release  0.17 that all the English subtitles are missing.
If it is a big issue then can we release another English language pack with subtitles? I can build one if you want me to create another en language pack with subtitles.
I think @aronasorman is the right person to ask about this issue.

@mrpau-eduard it would be great if you can start a build with subtitles? That way, we can also figure out if it's disabled because of a technical issue.

Yeah, I will the English language pack with subtitles. Will update you when it is done.

Done uploading the en language pack with subs.
Please grab it here. https://drive.google.com/open?id=0B-E59G3J_sXma1ZfZFdJZ0dMTlE
@radinamatic can you test this en language pack with subs.

@mrpau-eduard There's still something fishy with the English subs: I'm seeing them in OSX but not in Windows with this newest en contentpack. 😞
Tried several times, just to be sure... First of all, it's confusing that after the basic installation there seems to be more than 7000 subtitles, but once you install the en contentpack, it says 0 Subtitles:
Before:

Win 8.1

OSX

After:

Win 8.1

OSX

But the bigger issue is that on PC there's still nothing in C:\Users\IEUser\.kalite\httpsrv\static\srt\en\subtitles folder even after the installation of this newest en contentpack (see image 3. above), while on macOS Sierra there are 7209 subs in the \virtual\.kalite\httpsrv\static\srt\en\subtitles folder:

Confirming now where do we stand in Ubuntu...

English subs not present on Ubuntu either:

Spanish ones are there, but not all... Missing almost all from the /math/early-math/cc-early-math-counting-topic/cc-early-math-counting/ topic, and they used to be available for sure at some point in the past, but now I can't find them even on KA site, so nothing we can do there,  I guess.

Also, when you use an installer, it probably comes bundled with an English content pack without subtitles.
I'm going to put it on Pantry now and make it available for 0.17 testing...

Hi @radinamatic can you test this newly built English language pack with subs.
https://drive.google.com/open?id=0B-E59G3J_sXmcmtBUHR0NGZVWXM
I check the metadata.json and the content of the language pack. The subtitles are there.
{
  "beta": false,
  "code": "en",
  "language_pack_version": 1,
  "name": "English",
  "native_name": "English",
  "percent_translated": 0,
  "software_version": "0.16",
  "subtitle_count": 7864,
  "topic_tree_translated": 0,
  "video_count": 8785
}

Now we are talking... 👍
Windows:

I think we can close this already..
The results are in, the new content pack*) works :)
*) Will be released with 0.17

Thanks @benjaoming! 👍
I would have closed it myself, but somebody should first grant me those creds for this new repo... 😊
(cc @aronasorman)

@radinamatic oh that's silly, you've been added to the "KA Lite Installer" and "KA lite dev" teams!

@benjaoming Much obliged! ❤


abieos-lib can not link when runtime

when I build my project the error happen like: Exception in thread "main" java.lang.UnsatisfiedLinkError: no abieos-lib in java.library.path
Could you help me to explain or fix it?
Thank you so much!

I have the same error too.


Ble reconnects

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[] iOS
[x] Android
[] UWP
[] tvOS
[] macOS
[x] PCL

Version of OS(s) listed above with issue
Only tested in Xamarin Android (Forms Project).
Version of Library
2.0.0 Stable
Expected Behaviour
After a CancelConnection() the device must stay disconnected.
Actual Behavior
If applicable, please include entire exception - type, message, stacktrace
After a CancelConnection() the device must stay disconnected. but it reconnects after a few seconds.
Code of Conduct

No Library Update Requests
No Timeline Requests
Please read through the documentation and FAQs
Please be respectful of my time. I put a lot of effort into my libraries.  I try to support the issue requests within a day.  I'm not psychic, so please take the time to fill out the above form as complete as possible
Contact GitHub

What version of android did you reproduce this on?
Did you call "CancelConnection" during a connection attempt?

Android 6, no I'm calling CancelConnection while already connected, does its supposed to work this way?

It is not supposed to work this way.  I did not reproduce this issue, but the reconnection logic can get complicated, so I've made a few additional checks as part of 2.0.2 which is on nuget now.  Please give that a try.  If there is still an issue, please report back in this issue.

I see the 2.0.2 now, upgrading!

Ive upgraded and now the first disconnection it stays disconnected, if I reconnect w/o closing the app, it connects, but If I try a second disconnection it stays connected forever. Gonna debug more, closing and reopening if necessary.
Thanks for your time.


Make ownership_challenge argument optional (or documented) for cloudflare_logpush_job resources

Current Terraform version
0.14.8
Description
Currently the ownership_challenge argument is required when creating a cloudflare_logpush_job resource. However, it is not a required field (in the API) when creating a Logpush job with a destination of either Datadog or Splunk.
From the docs:

Note: Unlike configuring Logpush jobs for AWS S3, GCS, or Azure, there is no ownership challenge when configuring Logpush to Datadog.

I can see the thinking here, the majority of destinations do require an ownership challenge, though it means when creating a Datadog job a dummy value needs to be provided e.g. 0.
I think either the argument should be made optional and a note added that it's required for the majority of use-cases, or left as is calling out the workaround for Datadog and Splunk. I'm more than happy to raise a PR for either of these.
The Cloudflare API docs for this also seem to be incorrect, again calling out the destination_challenge field as required (I've checked and verified it isn't) not matching up with the Datadog integration guide linked above.
Use cases
Creating a cloudflare_logpush_job with a destination of either Datadog or Splunk
Potential Terraform configuration
N/A
References

https://developers.cloudflare.com/logs/logpush/datadog
https://developers.cloudflare.com/logs/logpush/splunk
https://api.cloudflare.com/#logpush-jobs-create-logpush-job

Sorry for the radio silence on this one @taurelius, it fell off my radar.
I'm 👍 to making the schema attribute optional and instead enforcing the validation in the Create/Update operations themselves looking at the destination_conf value. Something like the following would suffice:
destConf := d.Get("destination_conf").(string)
ownershipChallenge := d.Get("ownership_challenge").(string)
var re = regexp.MustCompile(`^(datadog|splunk)\:\/\/`)

if ownershipChallenge == "" && !re.MatchString(destConf) {
    // we will error out as the destination conf requires a value
}


Use HTTPS version to the IRC color guide

@DanielOaks very nicely and blazingly quickly set up HTTPS (see https://github.com/ircdocs/modern-irc/issues/38) so we can now direct our users to that version!

Due to your osx bindings duplication, there are 2 of these URLs.

Well, that's embarrassing... :man_facepalming:
Fixed, @xPaw.


Conform with Fedora CoreOS

Fedora CoreOS does not identify itself as "CoreOS", but as "Fedora". As the conformance check does nothing on coreos it is worth it to have on Fedora CoreOS but also does not create any issues with a Fedora distribution.

@jlarriba can you copy the contents of /etc/os-release on your node please?

Here you have:
NAME=Fedora
VERSION="31.20200323.3.2 (CoreOS)"
ID=fedora
VERSION_ID=31
VERSION_CODENAME=""
PLATFORM_ID="platform:f31"
PRETTY_NAME="Fedora CoreOS 31.20200323.3.2"
ANSI_COLOR="0;34"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:31"
HOME_URL="https://getfedora.org/coreos/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora-coreos/"
SUPPORT_URL="https://github.com/coreos/fedora-coreos-tracker/"
BUG_REPORT_URL="https://github.com/coreos/fedora-coreos-tracker/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=31
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=31
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="CoreOS"
VARIANT_ID=coreos
OSTREE_VERSION='31.20200323.3.2'


relative references need to (slowly) walk the path

As a legacy from oc10 all clients currently make path based requests, relative to a space root. This forces the decomposedfs to walk the path, which takes time. For a dir https://cloud.ocis.test/files/spaces/personal/admin/f1/f2/f3/f4/f5/f6/f7/f8/f9/f10 on an NFS it might look like this:

This is negligible on local filesystems, but on NFS the Child lookup becomes painfully visible.
For now we only implemented a stat cache in decomposedfs. A direntry cache is certainly possible, but requires invalidation and coordination effort when running multiple storage providers.
As a client, you typically already have the file id when navigating the tree as every PROPFIND response for a directory listing also returns the file id of every child. The easiest way to take load off the server is to not generate it in the first place.
Making a PROPFIND with an id only reference can immediately look up the correct node:

First attempt: delegating the path lookup to the os (instead of walking child by child) does improve the listing of a folder with a relative path of depth 10 by ~40-50ms:

Under the hood the linux kernel still has to make multiple directory lookups to walk the path internally, just as the decomposedfs did.
diff --git a/pkg/storage/utils/decomposedfs/lookup/lookup.go b/pkg/storage/utils/decomposedfs/lookup/lookup.go
index 395559eb3..42e9d4438 100644
--- a/pkg/storage/utils/decomposedfs/lookup/lookup.go
+++ b/pkg/storage/utils/decomposedfs/lookup/lookup.go
@@ -119,10 +119,14 @@ func (lu *Lookup) NodeFromResource(ctx context.Context, ref *provider.Reference)
                if ref.Path != "" {
                        p := filepath.Clean(ref.Path)
                        if p != "." && p != "/" {
-                               // walk the relative path
-                               n, err = lu.WalkPath(ctx, n, p, false, func(ctx context.Context, n *node.Node) error { return nil })
+                               // try to read the target directly
+                               n, err = n.Child(ctx, p)
                                if err != nil {
-                                       return nil, err
+                                       // the shortcut didn't work, potentially due to references. walk the path step by step instead
+                                       n, err = lu.WalkPath(ctx, n, p, false, func(ctx context.Context, n *node.Node) error { return nil })
+                                       if err != nil {
+                                               return nil, err
+                                       }
                                }
                                n.SpaceID = ref.ResourceId.SpaceId
                        }
diff --git a/pkg/storage/utils/decomposedfs/upload/processing.go b/pkg/storage/utils/decomposedfs/upload/processing.go
index 3ba1a0445..b0714645d 100644
--- a/pkg/storage/utils/decomposedfs/upload/processing.go
+++ b/pkg/storage/utils/decomposedfs/upload/processing.go
@@ -453,9 +453,14 @@ func lookupNode(ctx context.Context, spaceRoot *node.Node, path string, lu *look
                p = chunkInfo.Path
        }

-       n, err := lu.WalkPath(ctx, spaceRoot, p, true, func(ctx context.Context, n *node.Node) error { return nil })
+       // try to read the target directly
+       n, err := spaceRoot.Child(ctx, p)
        if err != nil {
-               return nil, errors.Wrap(err, "Decomposedfs: error walking path")
+               // the shortcut didn't work, potentially due to references. walk the path step by step instead
+               n, err = lu.WalkPath(ctx, spaceRoot, p, true, func(ctx context.Context, n *node.Node) error { return nil })
+               if err != nil {
+                       return nil, errors.Wrap(err, "Decomposedfs: error walking path")
+               }
        }

        if isChunked {

The patch is a quickshot and seems to break when renaming folders, I don't think the result justifies looking further into this approach as it also kills persisted cs3 references...

@kulmann @michaelstingl Regardless of any server side changes we might come up with all clients should try to use the fileid with the /dav/space/{fileid} endpoint when making requests. It roughly reduces the execution time by 7ms per path segment that can be omitted.

@butonic I'm currently implementing these id-based requests in the web client. An id-based DELETE (e.g. https://localhost:9200/remote.php/dav/spaces/e42289c1-0d29-4651-b505-d827d17df7c7$8dcb291f-96c3-4e0b-999a-22544fd21727!faa52162-7210-44b6-abe9-b16bd59532f0) however doesn't work, it gives me 405 Method Not Allowed. Am I missing something or is this a bug?


Bug: deletion of keyword - other edits in same form are linked

Describe the improvement
When editing the dataset details, something goes wrong when removing keywords and subsequently changing e.g. the access level. In some cases, after deleting the keywords and subsequently changing the access level (without clicking save in between), the deleted keywords reappear or an existing keyword is re-added multiple times.
A similar behavior for adding/deleting data formats.
example: 10.1594/pangaea.822313
screenshot:

@sdebodt Which browser was this (and which version), so we can reproduce the bug?

in my case Chrome.
It occurs when you delete multiple keywords. If you delete only the last keyword,  everything is fine.

weird. I cannot reproduce this on my local development server. @nics what version is deployed on backend.bibliotest.ugent.be?

I just checked with Kevin as he reported this issue. He tested it on eliot1 and also has the issue there.

on eliot1, the edit form closes when selecting the access level (after deleting some keywords).

@sdebodt Can we have the OS, the browser + version, screenshots and steps to reproduce for each issue (keywords, closing after acces level, ...)?

windows 10
chrome Versie 104.0.5112.102
Steps:

Take a DOI for a dataset with many keywords (e.g., 10.1594/pangaea.822313).
Upload it as a new entry.
Click "Edit" to edit the the Dataset Details.
Delete any number of the keywords using the "garbage can" icon.
Then, without saving those edits, change the access level using the associated dropdown menu.
in biblio test: the deleted keywords will return, and may even appear in a new order (at least in https://backend.bibliotest.ugent.be/).
in eliot1: the edit form closes

it can take a few seconds after selecting the access level to open access before the form disappears.

@sdebodt clear! I was able to reproduce the closing issue ONCE – interesting that it only happens with a new creation and only whenever we've touched the keywords.
Unfortunately I forgot to turn on my console log and haven't been able to reproduce it again. Highly annoying ghost bug.

I still have the issue in eliot1. Have you tried private browsing?

Yes, no result. If you have a screenshot of any errors in the console log, we can get closer.
Right click, inspect element, go to console:

Error did not happen, but this console log was caught in Firefox:

I do not see anything in the console (not in Chrome and not in Firefox). Which element should I inspect?

That's okay, not one specific element – it was just the way to get there. It logs it for the entire app.
I just needed to know whether the console logged any errors while clicking around and the error happens. Thank you.

Note:

doubling has been solved
the accidental closing of the modal has not been solved after clicking on the dropdown

Note: I see this in the logs, when selecting an access level:
{"level":"info","ts":1662364034.134825,"caller":"logging/logging.go:22","msg":"PUT /dataset/01GC69FX8B3XPKF1AKTSH0FH7T/details/edit/access-level (code=200 dt=123.818458ms written=12991)"}

@mietcls issue about access level has been moved to https://github.com/ugent-library/biblio-backend/issues/538

@nicolasfranck if this one is superfluous by the existence of the new issue, you can close it as we still have the reference.

@nicolasfranck Sorry reopening, I now realise the issue you mentioned is part of https://github.com/ugent-library/biblio-backend/issues/440 which I will be rewriting –which is not (or just a fraction is) connected to this random closing if I understand correctly.

@nicolasfranck was this one fixed now?


Upgrade compatibility to Angular@v10

original issue: merlosy/ngx-material-file-input#65.

PR: merlosy/ngx-material-file-input#67.


Sort favorites

Is there a way to sort the favourites?
I could not find the place where the clipboard favorites and history are saved. Potentially it can be sorted there. Any tip?

Not really, it's based on usage. You could click your favorites in the reverse order you want them to be sorted, but they'll get messed up once you use them normally again.

Thank you for the fast reply!
Sayang that there is no way to sort it. Could this be a feature to implement in the future?
Where are the favourites saved?

Could this be a feature to implement in the future?

Probably not: trying to build UI in gnome extensions is a massive pain.

where the clipboard favorites and history are saved

This extension uses a binary format so you're not going to be able to edit it easily. It's in<EMAIL_ADDRESS>That said, there is serialization/deserialization tooling which you might be able to adapt to your use case: https://github.com/SUPERCILEX/gnome-clipboard-history/blob/master/tools/src/main.rs.

Thank you for your interesting answer!

Probably not: trying to build UI in gnome extensions is a massive pain.

This is a pity! Hopefully this will get better as GNOME extensions are handy and hopefully have a bright future.

This extension uses a binary format so you're not going to be able to edit it easily. It's in<EMAIL_ADDRESS>That said, there is serialization/deserialization tooling which you might be able to adapt to your use case: https://github.com/SUPERCILEX/gnome-clipboard-history/blob/master/tools/src/main.rs.

I could indeed find the log and read my copied text and favourites. There is a pattern for the favourites (##text####) but you are right that I can not edit it easily, e.g, with a text editor or LibreOffice.
Unfortunately, I don't know how to use the serialization/deserialization tooling main.rs. Can you give me some hints?

I don't know how to use the serialization/deserialization tooling main.rs

You won't be able to just use it, you'll need to write your own code that fits your use case. If that's too difficult I recommend using the paste/click to reorder method.

Unfortunately I don't have coding skills :see_no_evil:.
"paste/click": You mean "click your favorites in the reverse order you want them to be sorted"?
First tests are promising that the app Ghex (GNOME Hex Editor) can edit the binary format file database.log.
BUT I realised that with paste/click the order would change immediately, e.g. if I select one of the favourites it would jump to the first place. You wrote about this but I did not realise this as I only started to use this extension and with the former extension "clipboard-indicator" the favourites list order is kept, also if you click/select one to paste and only new favourites will be added to the top. I wonder whether the feature of fixed favourites list order can be brought back (e.g. as an option in the settings or generally) as the workflow would be more efficient. When I know the order I can find the specific favourite more quickly and my brain can automatically click on it. And with the constantly changing order editing with Ghex does not make sense.

Hmmm, if you don't want the order to ever change, you could probably just add an && !entry.favorite: https://github.com/SUPERCILEX/gnome-clipboard-history/blob/348685b129f7914edf0bfb48f13df6352506ba5c/extension.js#L874 That shouldn't break anything I think?
The extension code lives in ~/.local/share/gnome-shell/extensions.

If this works, this would be great! I could sort the list with click/paste and then fix it with the added code.
But I could not figure out where I should exactly place && !entry.favorite in the 874th line. I tried all the possible positions but it would not fix the list. But it also did not break anything 😄. Any tip? E.g. if (!isFirst && !entry.favorite) {?
Thank you again for your help!

Oh, nothing will change unless you restart gnome: https://github.com/SUPERCILEX/gnome-clipboard-history#restart-gnome

Thanks for the tip!
Where exactly should I place && !entry.favorite in the 874th line?

if (!isFirst && !entry.favorite) is right

Even after restart it still does not work. I have following for line 874-6:
if (!isFirst && !entry.favorite) {
        this._moveEntryFirst(entry);
      }

When I click on one of the favorites it still moves to the first place of the favorites list (which means the favorites list order is changed).
Any other tip? It would be such a great help to have a fixed/unchanging favorites list with just a bit of code (which I delete when I want to change the list order).

No worries! Even the best can have a flaw in reasoning.
I am still not a coder 😊.  What do you mean with "slap an if statement around this one"?
I tried with following, but it did not work:
if (this._moveEntryFirst(menuItem.entry));

if (!menuItem.entry.favorite) this._moveEntryFirst(menuItem.entry);
It says, if this entry is not a favorite, move it to the top.

Thanks a lot! This did the trick. Here a summary if someone else wants to profit from this hack to fix the order of the favourites. Change Line 644
https://github.com/SUPERCILEX/gnome-clipboard-history/blob/348685b129f7914edf0bfb48f13df6352506ba5c/extension.js#L644
to
if (!menuItem.entry.favorite) this._moveEntryFirst(menuItem.entry);
and restart GNOME Desktop with Alt + F2, then type r.


volume mount point for graylog_data to /usr/share/graylog/data/data ?

The current /open-core/docker-compose.yml and /enterprise/docker-compose.yml have the following configuration to mount the graylog_data volume:
volumes:
  - "graylog_data:/usr/share/graylog/data/data"
  - "graylog_journal:/usr/share/graylog/data/journal"

Is the /usr/share/graylog/data/data correct or should this actually go to /usr/share/graylog/data ?
There doesn't seem to be anything saved under /usr/share/graylog/data/data and it would seem desirable to save the content under /usr/share/graylog/data to a persistent volume.

This has to be wrong. That directory contains nothing. Also the journal-location seems to be wrong, if the intention is to split these into two different volumes. it should be something like this:
The journal should be configured into an other location in gralog.conf
message_journal_dir=journal
And the volume should then be something like this
volumes:
  - "graylog_data:/usr/share/graylog/data"
  - "graylog_journal:/usr/share/graylog/journal"

I have been fighting this issue for a while now, every time I docker compose down and back up I just get errors:
11:37:24.723 [main] ERROR org.graylog2.storage.versionprobe.VersionProbe - Unable to retrieve version from Elasticsearch node: Hostname a84xxxxxx5c3 not verified:
certificate: sha256/plUJdntgAxxxxxxxNsH5q2yXsuPU+YVEIXRM=
DN: CN=b22xxxxxde5e
subjectAltNames: [<IP_ADDRESS>, 0:0:0:0:0:0:0:1, <IP_ADDRESS>, localhost, b225613ede5e, 0:0:0:0:0:0:0:1]. - Hostname a84xxxxxx5c3 not verified:
certificate: sha256/plUJdntgAxxxxxxxNsH5q2yXsuPU+YVEIXRM=
DN: CN=b22xxxxxde5e
subjectAltNames: [<IP_ADDRESS>, 0:0:0:0:0:0:0:1, <IP_ADDRESS>, localhost, b225613ede5e, 0:0:0:0:0:0:0:1].
Seems like a great product when it works, I think I will try and find a different product

Same issue with "hostname not verified" after a restart (after pulling an image update). Any way to fix this?


Index homosaurus subject headings ($2homoit)

User story 1: as a catalog user, I would like to search for records using terms in the homosaurus vocabulary.
User story 2: as a catalog user, I would like to see homosaurus vocabulary terms display in record show pages.
homosaurus vocabulary terms can be identified in the marc record by the combination of:

Tag 650
Second indicator 7
Subfield 2 with a value "homoit"

@kevinreiss is going to get some more clarity and prioritization of this ticket.
This will probably require a full re-index.
Companion ticket in Orangelight: https://github.com/pulibrary/orangelight/issues/3078 -- we may also need a ticket in pul_solr to weight this search field appropriately.

Example record in production: https://catalog.princeton.edu/catalog/99125407041106421

@mzelesky suggested to add in bibdata the homoit_s so that we indicate in the record page the source of the term. previous example for lcgft_shttps://github.com/pulibrary/bibdata/pull/471/files.
@mzelesky also suggests to revisit https://github.com/pulibrary/orangelight/pull/3029 as part of this work.


Handle reusing type reference resolution in resolution cache correctly

With type reference directive resolution API there is never containgSourceFile just containingSourceFileMode. This fixes incorrectly not seeing reused names in the watch mode resolution cache.
Will have separate PR that cleans up of these APIs and deprecating the existing APIs but this fixes current API and usage.

Btw this was issue with how i fixed the merge conflict with change from PartialResolutionInfo to ResolutionInfo in type ref reuse PR rather than old PR.


Add/Enable PWA (Progressive Web App) done !  #101 🟢🌟

Add/Enable PWA (Progressive Web App) done !  #101
🟢Key Features of PWAs:
🔵Offline Capability: Using service workers, PWAs can function offline or in low-network conditions by caching essential assets.
🔵App-like Experience: PWAs behave like native apps, with smooth animations, navigation, and interactions, even on mobile.
🔵Push Notifications: PWAs can send push notifications to engage users, even when the app is not open.
🔵Installability: PWAs can be installed on the user’s home screen, just like a native app, without going through app stores.
🔵Fast Loading: By caching resources and using service workers, PWAs can load quickly, even with slow network conditions.
🔵Responsive: They adapt to any device, whether it's a mobile, tablet, or desktop.
https://github.com/user-attachments/assets/0b99a36d-7c77-4b17-81aa-ea4485789b8d

@Akshat111111 sir done, please merge my PR

@Akshat111111 sir done, please merge my PR

@Akshat111111 sir

@Akshat111111 sir done, please merge my PR

@Akshat111111

kindly resolve the conflicts

@Akshat111111 sir done


T265 Pipeline start/stop and map start/stop

Required Info

Camera Model
T265

Firmware Version
<IP_ADDRESS>9

Operating System & Version
Win 10

Kernel Version (Linux Only)

Platform
PC

SDK Version
2.28.0

Language
C++

Segment
AR

Issue Description
Two questions regarding when T265 maps are created in reference to starting and stopping the pipeline:

Is a new map, meaning a new position of (0, 0, 0), created each time the pipeline is started?
When a pipeline is stopped, and the context goes out of scope, does the T265 continue to track its position in its last map?

Thanks.

@JBBee hello,

Correct. Each session generates a new origin.
To track data stored in previously-recorded maps follow the explanation by @radfordi here, utilizing the  set_static_node/get_static_node API calls.
#4024

Thanks, @ev-mp


fix: :bug: Components CPI caller check

Status
Type
⚠ Core Change
Issue

Ready
Bug
Yes
#29

Problem

Components make use of solana_program::sysvar::instructions::get_instruction_relative to enforce that they are called from CPI and the identify of the caller, This may contains a bug, since a transaction could contain a valid instruction at index [0], but be malicious.

Full description is available: https://github.com/magicblock-labs/bolt/issues/29#issuecomment-2408909957
Solution
To correctly determine if your program was called via CPI, you should:

Use get_instruction_relative(-1, ...): This will attempt to retrieve the instruction that called the currently executing instruction. If the program was called directly, there will be no instruction at index -1, and the function will return an error.

Check for Errors: If get_instruction_relative(-1, ...) returns an Err, it means the program was called directly. If it returns Ok, you can proceed, knowing it was called via CPI.

Closes: #29

cc - @GabrielePicco

@iamnamananand996 the PR looks good to me, but we should enforce that the check is now correct. There are 2 integration tests for the CPI check that were passing with the previous implementation. Is there a case where prev check fails and this pass that we can add>

Hi @GabrielePicco , thanks for pointing out, this a valid check we should add before merging it, I will check for the above suggestion and update this accordingly.

Hi @GabrielePicco, I check all the test, and regarding the test case you mention 2 integration tests for the CPI check, that are passing.

and there where 2 test which where failing, that I have updated. failed test

Thanks @iamnamananand996 ,
What I meant is that we should add a test to verify that this implementation is actually solving a problem. The two integration tests for the CPI check also pass in the current version of the master branch, which means they don't cover the issue this PR is trying to address


setup singleton ensures cm-maps created

to ensure that a controlNamespace is always available for migration
to decouple from isolation needing to be run first

@bitscuit
I am wondering that if we should count the all namespace migration scenario that we did not and will not have this common-service-maps ConfigMap. Also we are going to migrate License service into ibm-licensing namespace.


Adding NPM5 package-lock.json file

Adding the NPM@5 package-lock.json file.
I ran rm -rf node_modules && npm i.

Coverage remained the same at 99.576% when pulling d43995ff11dc4a1c8f78805b3d80c143b8ce46e9 on jessebeach:npm5--add-package-lock-json into 1a633af172962b289e558a99823feaf0c91ef841 on evcohen:master.

Coverage remained the same at 99.576% when pulling d43995ff11dc4a1c8f78805b3d80c143b8ce46e9 on jessebeach:npm5--add-package-lock-json into 1a633af172962b289e558a99823feaf0c91ef841 on evcohen:master.

Coverage remained the same at 99.576% when pulling d43995ff11dc4a1c8f78805b3d80c143b8ce46e9 on jessebeach:npm5--add-package-lock-json into 1a633af172962b289e558a99823feaf0c91ef841 on evcohen:master.

If we do want this file, we should ditch yarn, because it makes no sense to have two competing lockfiles in the same repo (and I do think that npm5's lockfile is a strict improvement over yarn, ftr)

Good points. I have zero opinion here. I'd rather stick with NPM if it's all the same. @evcohen ?

does older versions of npm respect the lock file? that would be my only reason not to

My understanding is that older versions of NPM don't need the lock file.

Older versions of npm don't respect it; they need it just the same (where "need" means, "need it in order to create a deterministic node_modules).
If you want a lockfile despite being a non-app, you want developers but not consumers to be impacted by this lockfile, and you want to support using the lockfile on npm versions older than 5, yarn is the only choice.

i'm missing the point of it then. this doesn't solve the "works on my machine" problem for all users using npm < 5. this requires all of us to upgrade our npm version or else its rendered useless.
i think i am in favor of removing all lockfiles. I've only seen them get in the way of development and rarely have I seen a downstream dependency break this project (especially given its lack of dependencies, three of which one of us owns)

I think "devs must use npm 5+" is the same caliber of requirement as "devs must use yarn". I would definitely prefer to see us remove all lockfiles.

Cool, I'll update the diff and remove the lock files.

Fixed in #261 per discussion above!


Add support for shifting the BPM (useful for syncing two pulses with the same BPM)

Two performers can have their bpms set to 40, but their pulses may be out of sync.
With this new function, bpmShift K, the pulse will shift K milliseconds, enabling the performers to go in-sync or out of sync.
This demo shows it clearly: https://www.youtube.com/watch?v=GBricHd6F1Y
Is a good thing that all the BPM and pulse logic lives in a single file!

hey @gareve thanks contributing this. The bpm syncing definitely needs some improving and this is a good part of that. I'll have a look at this in the next couple of days and aim to get it merged soon :)

hey @gareve I created a new PR for this branch that's rebased ontop of master. https://github.com/davidedc/livecodelab/pull/308
I've merged that in, so I'll close this PR.
thanks for the contributions this is seriously useful.


myjobs package : workers filter options don't have all status

schema from myjob server
state** = "NEW,ERROR,BUSY,WAITING,HALTED" (E)
filter from myjob visualization

so fillter missing busy state and  error and tghere is no  running state

still the same issue that filters states (busy and error) are not shown in filter

second issue is when press in button halted, does not filter halted states , is shown both Waiting and halted state


⚠ Bofrost.lu has degraded performance

In 8e0c4c7, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2108 ms

Resolved: Bofrost.lu performance has improved in 46f7efe after 35 minutes.


[2.0] Docs error in page "Navigation Guards"

This is not a syntax error, it's valid ECMAScript2015, the latest version of Javascript, and it's called an arrow function


Support for Github style alerts

Feature Request:
Github has support for the following style of alerts. https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts
When used today they end up looking like this in Confluence.

But should end up looking like this

Details
Github alerts mapped to Confluence panels

Github
Confluence

NOTE
Note

TIP
Info or maybe Success (Tip is green on Github side so maybe Success?)

IMPORTANT
Info or maybe Success

WARNING
Warning

CAUTION
Error

Potential Solution:
Figure out a way to convert to Admonitions might make sense so its consistent. But also could be its own code path.

This has been implemented on the master branch: Add support for GitHub syntax of alerts/admonitions.


Fix for Issue #158

Fixes:
Issue #158
Changed the .list-group-item{ possition:relative} to possition:inherit
this fixed the list from going over the border of the card
Please notice this is my first time contributing on a repo ever, I'm not sure why the Pipfile and Pipfile.lock got involved here ( sorry)

Coverage remained the same at ?% when pulling 53a9e5fa810fc1cbc2b91d050294fc66e8fb35c6 on jjavierweb:master into 06ffd247021db0c68b3beb48a4b963e7a651e217 on respawner:master.

@coveralls what do you mean? sorry new to the world of git

@jjavierweb coveralls is a bot 😄

@respawner thanks for the info, I'll work on that, please feel free to deny this commit and I'll get the fix on the base.css file


Relax IO.forkAll to accept any traversable structure

I noticed forkAll was the only primitive that only worked on List[A]. There's at least one spot in this library where it is not optimal.

@regiskuckaertz Nice change! Can you also update the forkAll(...toList) you spotted?

@jdegoes sure thing 👍