Automate NPM publish via CircleCI

I think we should automate publishing of packages to NPM via CircleCI. This reduces the amount of effort involved in doing a release and thus I think could motivate us to release more often. (Not clear that it provides a security benefit over a maintainer manually publishing - some day I would love authenticated signed builds for that where you can audit that an NPM package was build from a signed git commit, but that's a bigger ask that we are going to tackle here).
Anyway, here's my suggestion for how to do the publishing via CI:

A repo maintainer / owner (@mayurkale22 or @bg451) creates a new NPM user, say opentelemetry-bot with a long secure password and shares the password with the other owner. Both store the password in a secure password vault.
Maintainer generates a new read/write NPM token for the bot to be able to publish to NPM. This gets saved as a CircleCI secret environment variable, say NPM_TOKEN. The bot is granted ability to publish only to the @opentelemetry packages. This limits the blast radius of a compromise because the maintainer's personal accounts might be able to publish to other NPM repos outside OpenTelemetry (e.g. LightStep stuff, OpenCensus, other packages they might happen to own, etc.).
We set up a CircleCI config with release_tags and publish_npm (see OpenCensus Web CircleCI script for reference). That workflow would run yarn publish which would trigger Lerna to publish all the modules (I think).
That way, to do an actual release, we make a GitHub release and that will trigger a git tag of the branch, and kick off the CircleCI build and publish.

With OpenCensus Web, we used an internal Google system for provisioning and maintaining the tokens for the robot account that publishes to NPM. It has a nice security feature that it generates tokens on a per-repo basis, but then you have to upload N different tokens to the CircleCI build and switch tokens in a script as you publish the different packages. The bigger issue with that though is that it's Google-centric and I think it's very important that we keep an open community model for this project, hence giving all repo owners secure access to the robot account.
What do people think about this suggestion?

That way, to do an actual release, we make a GitHub release and that will trigger a git tag of the branch, and kick off the CircleCI build and publish.

Interesting. By looking OpenCensus repo I see that You have one Github release (one tag) for all packages.

What do people think about this suggestion?
I think it's fine (to me).

How do you manage the changelog ?
initial discussion https://github.com/open-telemetry/opentelemetry-js/issues/372

I think keeping the same release version for all packages simplifies things. It's fine to release a package even if nothing changed to it, but having internal version skew is hard to track.
In OpenCensus (Node & Web), we managed the CHANGELOG manually. But if we can automate that, that would be awesome!
The more of the release process we can automate the better because it would enable us to roll new patch releases quickly when a community member submits a fix or improvement, because then they can pull in the updated package via NPM more quickly.

I think keeping the same release version for all packages simplifies things. It's fine to release a package even if nothing changed to it, but having internal version skew is hard to track.

+1. This will also help us to keep single CHANGELOG.md across the project.

I think keeping the same release version for all packages simplifies things. It's fine to release a package even if nothing changed to it, but having internal version skew is hard to track.

+1. This will also help us to keep single CHANGELOG.md across the project.

Ok. Based on the discussion, I think we could use the first solution described https://github.com/open-telemetry/opentelemetry-js/issues/372
in order to automate a bit... There is still manual things to do but it will be a lot easier for the releaser. WDYT ?

I can assume this can be repurposed to Github Actions https://github.com/open-telemetry/opentelemetry-js/blob/main/.github/workflows/canary.yaml ? https://github.com/open-telemetry/opentelemetry-js/blob/main/RELEASING.md
https://github.com/googleapis/release-please could also be a great fit here for tagging/releasing on github.

Wow I hadn't seen release-please. It might work really well for the API repo, but unfortunately doesn't appear to support lerna repos

There is an existing pair of release actions in the contrib repo which we could repurpose, but we also need to be able to release only some packages and maintain different version numbers between different packages.

I can take a deeper look but I'm almost sure it supports mono repo including Lerna and workspaces: https://github.com/googleapis/release-please/blob/master/docs/manifest-releaser.md
I personally use https://github.com/google-github-actions/release-please-action in one of my projects. It works well.

Example of repo using the manifest releaser with lerna: https://github.com/googleapis/repo-automation-bots

Release Pr example: https://github.com/googleapis/repo-automation-bots/pull/2269

Example of repo using the manifest releaser with lerna: googleapis/repo-automation-bots

That looks really awesome. Sorry if I'm being silly or missing something obvious but I don't see a lerna.json file in there or any other references to lerna? I assume it works with or without lerna and we would probably just switch the lerna mode to independent and they would not interfere with each other?

Example of repo using the manifest releaser with lerna: googleapis/repo-automation-bots

That looks really awesome. Sorry if I'm being silly or missing something obvious but I don't see a lerna.json file in there or any other references to lerna? I assume it works with or without lerna and we would probably just switch the lerna mode to independent and they would not interfere with each other?

I'm still new to RP with lerna but on the manifest-release md it has a section for nodejs:

node-workspace
The node-workspace plugin builds a graph of local node packages configured in release-please-config.json and the dependency relationships between them. It looks at what packages were updated by release-please and updates their reference in other packages' dependencies lists. Even when a particular package was not updated by release-please, if a dependency did have an update, it will be patch bump the package, create a changelog entry, and add it to the list of PR changes. Under the hood this plugin adapts specific dependency graph building and updating functionality from the popular lerna tool.

So I'm assuming it might be compatible. Although from personal experience I've only used one package per repo approach while testing that lib.

I'm thinking about creating a test branch with release-please on it and letting it create a release PR to see what it looks like. If I do, do you know what will happen when I close the PR it has created? Will that cause problems down the line?

I'm thinking about creating a test branch with release-please on it and letting it create a release PR to see what it looks like. If I do, do you know what will happen when I close the PR it has created? Will that cause problems down the line?

It should not be a problem as long as you remove the GitHub label (tag) it will create in the PR.
FYI, if you want to test it as a PR, you need to change the default branch it will be looking for. (I actually added that feature myself a while ago).
For safety and adjustment purposes, I would test it on the API repo first because It's simple enough.

I'm thinking about creating a test branch with release-please on it and letting it create a release PR to see what it looks like. If I do, do you know what will happen when I close the PR it has created? Will that cause problems down the line?

It should not be a problem as long as you remove the GitHub label (tag) it will create in the PR.
FYI, if you want to test it as a PR, you need to change the default branch it will be looking for. (I actually added that feature myself a while ago).
For safety and adjustment purposes, I would test it on the API repo first because It's simple enough.

The final part I'm missing is that it seems like the package.json is modified directly without running npm version to update the version https://github.com/googleapis/release-please/blob/master/src/updaters/package-json.ts
This means our version update script is not run and version.ts file is not updated automatically. I see a section in the readme to add a type with a new releaser/updater but it doesn't seem you can specify your own custom one without adding it to the main repository.

The purpose of this lib is to automatically determine the next version based on conventional commits.
If you need to manually set a version, you can use release-as for both all the packages or individual packages: https://github.com/googleapis/release-please/blob/master/docs/manifest-releaser.md#configfile

For single package repository it's easier: https://github.com/googleapis/release-please#how-do-i-change-the-version-number

We're set to use GHA for now and have written CI probably multiple times at this point after this issue was created. Outdated.


Merge pull request #1 from pazaan/develop-indra

Develop indra

just shoot me will ya...

Lol yeah I have Git meltdowns too! no worries


Text and sound alerts not working.

I am getting no text or sound alerts on e5s or any other raid, I tested Eden Normal and some savage raids, only the timeline works.
The striking dummy timeline and alerts work.
So far I've removed and reinstalled ACT, all the needed plugins and the cactbot plugin via the "get plugins" button.
I've tried adding overlays with the preset "raidboss alerts" and also added custom overlays using the miniparse type selection and the raidboss.html and still get no sound or pop up text alerts.

Are there any errors in your plugin log? What does the config say in Plugins -> OverlayPlugin.dll -> Cactbot -> Raidboss -> Default Alert Output?

No errors, I've been checking. Alert outputs were left as default (text and sound), but I also tried the three other alert output options without success, I couldn't get alerts to happen at all outside of the striking dummy test no matter what setting I tried. I uninstalled and reinstalled ACT and the three required plugins, following the tutorial multiple times without success.
Oddly, I was finally able to fix it by installing cactbot the old way. Instead of using the "get plugins button", I just copied the files from a download cactbt zip to my ACT folder. Then I manually added the cactbot plugin by browsing and selecting the cactbot .dll file and also manually selecting the raidboss.html using custom as the preset for the overlay. Pop up alerts work now flawlessly.
For whatever reason downloading cactbot directly through ACT by using the “get plugin” button and/or adding overlays via ACT too by using one of the presets such as “raidboss alerts” is what seems to completely break the alerts function for me.

Upon updating cactbot, pop ups no longer work for E5S and onward.

Was this fixed with the newer version of the ffxiv plugin?

I'm going to close this.  If this is still happening, please see the #troubleshooting channel.


Removal of internal TypedArrayExtension flag.

This flag was turned on by default (since TH1). No point keeping all the if..else condition around.

@boingoing - please have a look and if there are some related things that need to go away please let me know.

@dotnet-bot test this please

LGTM


There is no function to get the state of [enableEditing] when conditionally set

material-react-table version
1.15.1
react & react-dom versions
18.2.0
Describe the bug and the steps to reproduce it
When the enableEditing is set conditionally  set, there is no way to get the value inside other properties of the MRT ie muiTableBodyCellProps
enableEditing: (row) => row.original.name === 'test' ? true : false
Minimal, Reproducible Example - (Optional, but Recommended)
https://github.com/KevinVandy/material-react-table/tree/v2/apps/material-react-table-docs/examples
Screenshots or Videos (Optional)
No response
Do you intend to try to help solve this bug with your own PR?
Maybe, I'll investigate and start debugging
Terms

[X] I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

Temporary solution
   // Table Columns
   const columns = useMemo(
      () => [
         {
            header: 'New',
            accessorKey: 'new',
                enableEditing: (row) => row.original.name === 'test' ? true : false
         }
      ],
      []
   );

..........
...............

// Inside Material React Table component you can use

..........
...............

muiTableBodyCellProps={({ row, cell }) => {
    const _enableEditing = cell?.column?.columnDef?.enableEditing;
    const enableEditing = typeof _enableEditing === 'function' ? _enableEditing(row) : _enableEditing;

    // ---> Here you can use the enableEditing variable to conditionally check the edit state
 }

 ..........
...............


Detect if the terminal theme is light or dark

It would be very useful to know the type of theme (light/dark) the terminal has.
In this way the dev can properly set the colors:

for light background to have dark colors
for dark background to have light colors

Currently if you want to specify even the generic colors Chalk provides, you end up with unusable ouput because the user might have a theme that do not work well with the colors.

AFAIK, there's no standardized way to detect this, unless you try to add custom detection for every single terminal, which is not feasible. This is why using the named color methods (for example, chalk.red(…)) is recommended. They will correctly adapt to the color theme.
I agree it would be useful though. If you want to see this happen, I suggest you open an issue on some popular terminals to get this going. It could be a standardized environment variable that terminals expose.
Some more info: https://stackoverflow.com/questions/2507337/how-to-determine-a-terminals-background-color?noredirect=1&lq=1

Duplicate of #272


[Question]: can not start infinity service

Describe your problem
uname -a
Linux xxx.novalocal 3.10.0-1160.114.2.el7.x86_64 #1 SMP Wed Mar 20 15:54:52 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
sudo rpm -iv infinity-0.5.2-x86_64.rpm
sudo systemctl start infinity
sudo systemctl status infinity
● infinity.service - Infinity db
Loaded: loaded (/usr/lib/systemd/system/infinity.service; disabled; vendor preset: disabled)
Active: activating (auto-restart) (Result: core-dump) since Sat 2024-12-28 13:39:50 CST; 15s ago
Process: 21762 ExecStart=/usr/bin/infinity -f /usr/etc/infinity_conf.toml (code=dumped, signal=ABRT)
Main PID: 21762 (code=dumped, signal=ABRT)
Dec 28 13:39:50 xxx.novalocal systemd[1]: Unit infinity.service entered failed state.
Dec 28 13:39:50 xxx.novalocal systemd[1]: infinity.service failed.
/var/infinity/log/infinity.log:
[13:43:24.808] [20406] [info] ChangeServerRole from uninitialized to admin
[13:43:24.808] [20406] [info] Start to initialize storage from un-init mode to admin
[13:43:24.808] [20406] [info] Finish initializing storage from un-init mode to admin
[13:43:24.819] [20406] [info] Thrift server is started.
[13:43:24.824] [20406] [info] Peer server is started.

Resolved.

resolved


j.clients/builder.grafana

config manager
implement installer
implement test

also implement j.builder....
look at readme in that builder directory & TEMPLATE dir

implement j.client

learn how to do it in template for client

implement j.builder....

learn how to do it in template


adler32 does not return initial value when buffer has length 0

Instead it returns 1, which is the default initial value. This is different from the actual provided initial value.
zng_adler32(123, NULL, 0) should return 123. Instead it returns 1.

Whoops. Turns out I had a bug in my code that treated everything as NULL, 0. I am sorry for bothering you.


Local and Global search for library

Describe your suggested feature
Hi,
Please add global search feature like tachiyomij2k.
In tachiyomij2k when searching for a manga it filters the manga from the all category in library locally and shows it,
If it's not available then shows an option to search for it globally.
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 0.15.3.
[X] I will fill out all of the requested information in this form.

I am working on it so no need to worry I will deliver it as soon as possible.

I am working on it so no need to worry I will deliver it as soon as possible.

Thank you for your hard work. :)

Doesn't it already do that?
J2K
Mihon
The difference is that you have to look if there is a 1 on any of your categories, since Mihon uses tabs unlike J2K.

I have 13 categories so going through tabs to check the availability is kinda annoying 😕

So what you're asking for is not a global search button when searching the library,

Please add global search feature like tachiyomij2k.

which already exists, but a "hide categories with no search results" feature.

I have 13 categories so going through tabs to check the availability is kinda annoying

It can be done like that as well.


How to debug busted test case in vscode

Can someone give me some suggestions

This doesn't really seem like enough information to understand what you are trying to accomplish. Also wouldn't this be more of a issue for VSCode than any specific library you are working on with it?

@alerque
Hi, After installing busted, I can use the busted command to perform unit tests on the command line, but when I use vscode's lua debug plugin, it prompts me that the busted.runner module cannot be found

@aiverson
Hi, This problem has nothing to do with your busted, it should be a problem with the Lua debug plugin, so I close this issue

it prompts me that the busted.runner module cannot be found

That probably means you have not set the Lua-path settings correctly, see http://www.thijsschreijer.nl/blog/?p=1025


Bug: extension reformats yaml without linting

Describe the Bug
I use a textexpander plain text snippet to create the yaml metadata. When the linter extension is enabled, the yaml is reformatted to invalid yaml even when linting is not run. I haven't been able to identify which linter setting is causing the issue, if that's the problem.

When I disable the Linter extension the behavior goes away (snippet works fine)
I can type the metadata manually with no issue.
I can use the snippet in another text editor with no issue
I can use another program to create the snippet and have the same issue (for example, I can reproduce by adding the snippet to Raycast.

How to Reproduce
Steps to reproduce the behavior:

Create a note in obsidian
Run a snippet or macro that outputs the yaml.
See error

Although the textexpander snippet has date variables, that isn't the cause of the problem. The snippet in Raycast is just this text, and the reformatting still happens:
---
created:
aliases: []
source:
tags: []
updated:
---

Expected Behavior
A clear and concise description of what you expected to happen.
Expected output if applicable:
---
created: "2023-03-17"
aliases: []
source:
tags: []
updated: "2023-03-17T11:51:50-0400"
---

Actual behavior
The 3rd hyphen on the first line and new line are removed
--created: "2023-03-17"
aliases: []
source:
tags: []
updated: "2023-03-17T11:52:15-0400"
---

Screenshots
If applicable, add screenshots to help explain your problem.
Device

[x] Desktop
[ ] Mobile

Additional Context
Add any other context about the problem here.
data.json.zip

@SirSpidey , thanks for reporting this. Could you provide the macro in question or one that creates the issue and an explanation on setting that up so I can recreate the scenario? I as it stands I am not sure how to reproduce what you are stating since I do not have a setup like that personally.

@pjkaufman Yeah, this is a tough one to reproduce if you don't have either app. I tried reproducing with MacOS text replacements and with a free open source package called espanso, but neither one cause the issue. I'm not sure what TextExpander and Raycast snippets do differently when they insert the snippets.
Raycast is free and an awesome new tool. So if you're so inclined 😸 , you could install it and create a snippet like the one here.

But if not, you can just close this issue as not reproducible.

I couldn't reproduce the issue by using the old obsidian plug-in Text snippets, So TextExpander and Raycast, which use keylogger permissions (Privacy & Security -> Accessibility), must be doing something that's interpreted differently in Obsidian when your extension is enabled.
However, I did find a workaround or TextExpander that works with Linter and in other text editors: I added a carriage return to the end of first line

Closing as not reproducible

I will note that I see this problem every once and a while when I paste a value. I need to check and see if this is something the Linter accidentally does.

Looks like I can reproduce this on my personal setup. It is unclear as to why. I am going to reopen this and see about fixing it.

I am guessing this is due to the logic for removing hyphens on paste.

I believe that I have a fix for the problem as I am no longer seeing it. I will push up my change to fix this and it should go out with the next release.


DNS - Network View displays scored connections

When I score an IP, it doesn't dissapear from the Network view

Checking on further detail, this functionality is correct. Only scored queries should disappear, so scoring an IP doesn't affect the network view diagram.


Preserve directives on fragments when merging AST

When a FragmentSpread has a directive, they used to be discarded.
Added a test and a fix. All tests passes

awesome @esquevin, thank you ! one thing to note about signing the CLA, the email in your commits and the email you sign the CLA with have to be the same

one thing to note about signing the CLA, the email in your commits and the email you sign the CLA with have to be the same

I've signed the CLA, using the proper email
On another note there seems to have been an issue in the Test PR step if the CI. I'm not familiar with this repo tooling and don't want to make a mess. What should be done now?

@esquevin this one is almost ready! you just need to run yarn pretty locally and it should be good to go

@acao Seems everything is green, can I do anything to help this get merged?

@esquevin just needs a rebase because of conflicts from the PR of yours we just merged!

Everything should be good now =)

@acao I believe this can be merged, let me know if it ain't the case and what I can do.
I thought it had been merged a while ago 😅 just realised now that it never made it across the finish ine


Add Message support to PipeLineSession

Reporter
Gerrit
Is your feature request related to a problem? Please describe.
Currently pipes often expect session variables to be of a specific type, like String or byte array. This conflicts with the storeResultInSessionKey option, because the results of pipes are messages.
Describe the solution you'd like
Handle user session variables as Messages
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Fixed in https://github.com/ibissource/iaf/pull/1640


Sign Feed

Have the updater check signature of signed feeds.  Use a key pair to sign file.  Give the public key to apps They can verify they are getting a valid and trusted feed.

We will not use a signature file, you can provide a SHA of the feed to be validated against - that would be a nice feature. Pull requests welcome :)

No signature file. I meant the signature would be part of the feed. The
feed builder could generate RSA keys and let the user export the public
key. The app could use the public key to verify feed signature to know it
was published by allowed publisher.
On Sun, Jan 22, 2017, 2:08 PM Itamar Syn-Hershko<EMAIL_ADDRESS>wrote:

We will not use a signature file, you can provide a SHA of the feed to be
validated against - that would be a nice feature. Pull requests welcome :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/synhershko/NAppUpdate/issues/93#issuecomment-274351498,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADdhse9X9Xl38i0vv04pnrH-wPnYc6o4ks5rU6ktgaJpZM4Lqdrg
.

This is a good security feature to prevent spread of malicious updates if the update source is compromised since the attacker won't be able to publish updates if he does not have the private key.
Method 1

Include a signature of the feed file inside the feed file that is validated by the client when looking for updates, if the signature is invalid the update is aborted
Enforce that files are only updated if the checksum of the downloaded file matches the checksum in the feed file (as far as I know this is not done at the moment), this to ensure that you as an attacker can't leave the feed as it is and only modify the binaries.

This is a good method, but is a bit of work and requires that the publisher organizes specific certs for publishing updates.
We have a PR with this method at: https://github.com/synhershko/NAppUpdate/pull/45
Method 2

Create an option where the client validates that each downloaded binary is code signed using the same cert as the currently running version or one that has been white listed in the client

This is an quite straight forward fix, but it requires that the publisher has bought code sign certs and is not applicable to files that cannot be code signed (configuration files etc).

Worth mentioning is that I have seen both methods applied in other update libraries.

I prefer method 1. It solves the 2 issues you mentioned of method 2.
On Tue, Mar 28, 2017, 2:00 AM Robin Andersson<EMAIL_ADDRESS>wrote:

Worth mentioning is that I have seen both methods applied in other update
libraries.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/synhershko/NAppUpdate/issues/93#issuecomment-289671769,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADdhsSxrymvo2DxMJYp5RU8C7mTjZzOsks5rqKIZgaJpZM4Lqdrg
.


Fix optional error

I found an error where when using the default() method, a field that should not be optional becomes optional. z.isOptional() seems to indicate whether the input value is optional, not whether the output type is optional.

We need that check though. Checking if the node's name is ZodOptional doesn’t achieve much. It could still be optional but more deeply nested.

The type that zod-to-ts outputs is what can be passed to the parse method of the schema.
See the following example:
const MySchema = z.object({ value: z.string() });
MySchema.parse({ value: 'abc' });
// MySchema.parse({}); // will fail

const MyDefaultSchema = z.object({ value: z.string().default('hello, world!') });
MyDefaultSchema.parse({ value: 'abc' });
MyDefaultSchema.parse({}); // will NOT fail

@unknownpgr Given this, your case should be considered an error. As you can successfully parse an object without the unOptional property, as it will be defaulted by zod.

@sachinraja Can you confirm this? (A) The type that zod-to-ts outputs is what can be passed to the parse method of the schema. (as oppose to (B) ~The type that zod-to-ts outputs is what comes out of the parse method of the schema~)
If that (A) is confirmed, this would also mean the behaviour described by: https://github.com/sachinraja/zod-to-ts/issues/59 is actually not an issue and is intended.
In my situation (A) is actually exactly what I'm looking for, so it would be great if that's the case. However, I can see why (B) in some situation might be useful too.
Firstly: I think it needs to be clearly stated in the README or documentation which of the two it is.
Secondly: If there is merit for both, that both should have support.

The Record<string|number, any> is redundant as in TypeScript an object is assignable to a type, even if it has properties unknown to the type (https://www.typescriptlang.org/docs/handbook/type-compatibility.html#starting-out). However, this is restricted when using a literal type in an assignment (https://www.typescriptlang.org/docs/handbook/2/objects.html#excess-property-checks).
I'm not entirely sure in which ways Zod can handle unknown properties and whether these properties remain on the output of the parse method. Would have to dive deeper into this to see if that functionality would align between zod-to-ts and Zod align given that (A) is true.


Labels do not show up when overlap false

Hi,
I have a pie chart where in if there are following config options:
position: 'outside',
outsidePadding: 10,
textMargin: 10,
I tried to add overlap: false, but that hides all my labels of the chart.
Is there any solution to this.
My pie chart looks like:

I have the same issue.

I have the same issue, arc: true solve the problem but it's not a valid solution as I don't want my labels to be displayed in an arc

Same problem here : on a doughnut chart, the option overlap: false makes all labels disapear, instead of removing them when overlapping, as expected.


Not Functioning Properly

It does add the mode in, but when I try to use it, my game freezes and stops.
Bonk.io had an update and I am hoping you could make a fix for this?

Fixed :+1:


Internal doc: unpacked directory formats

Closes #170

@fchirigati do you want to take a look?

@remram44: done!


codebeat badge

Is it fine to add codebeat badge to README?
codebeat is automated code review tool for Swift,Ruby,Go & Python that helps get instant feedback on code quality.
"Quick wins" suggested by codebeat could be a nice candidate for a pull request and help other developers become contributors.
FYI. To be fully open and honest. I'm co-founder of codebeat.

 You should sign our Contributor License Agreement in order to get your pull request merged.

You can start by accepting the CLA.

Merged in c50c668

@korzonek having "Block nesting too deep" for 3 levels seems off, even Linus Torvalds have 3 levels in his code.

I'm gonna reopen this. I reverted the merge. In one end I think this is a great tool (I found several easy-to-fix issues with Hugo) -- but I'm a little bit afraid that "people" are going to take all the bullet points you present literally. And 20+ lines functions etc. may in many cases be perfectly fine. Hey, even the  Go  according to your algos.

Lets revisit this when this project get more mature/traction.

@bep please keep codebeat on a radar and maybe give a try  to codebeat in a month time :)
We are moving forward. codebeat grows and becomes more and more mature.
Your feedback together with a very similar message from a few other people was trigger for us to implement "grading" for each issue to present how important issue is... some issues are small and some are more important.
If there are any other things you would like to see in this type of tool, please share. Feedback is great help for us because it defines our priorities in backlog. Thank you!

@bep we have just released a new set of features in codebeat.

Support for pull requests. codebeat will analyse every pull request when you add a new project using Github, and will post a status to provide you seamlessly with information where it matters the most.
Enhanced Slack notifications. You no longer will have to switch context to see how your project or pull requests are performing in codebeat.
Functionality to customise metrics and individual issues
Detection of code smell - too many instance variables
Experimental support for Obj-C. It requires calibration, but it works :)
Support for Java and Kotlin. We want to help Android developers.
We also calibrated support for Swift.

It would be super if you could give a try to codebeat :)
Keep on coding!
#CleanCodeMatters


Accessing images with remote.axd from subdomain

Hi guys,
I have an issue where I getting images from another place, using the remote.axd.
From the staging url (http://www.staging.com/remote.axd?http://www.remax-malta.com/UserImages/24/large/L_878263c333524b61bb336ed6eba363a2_iList.jpg?anchor=center&mode=crop&width=1358&height=800&rnd=131081472090000000?entropycrop=250&width=1358&height=800&mode=crop) WORKING FINE.
Now, we have gone live and the url was changed to http://mysite.remax-malta.com.
Now, for every image, it is saying not found (http://mysite.remax-malta.com/remote.axd?http://www.remax-malta.com/UserImages/24/large/L_878263c333524b61bb336ed6eba363a2_iList.jpg?anchor=center&mode=crop&width=1358&height=800&rnd=131081472090000000?entropycrop=250&width=1358&height=800&mode=crop))
Any idea how I can configure such configs to make it work?
thank . appreciate.
Kind Regards

Im afraid t doesn't work in subdomains... Yet... Waiting on a PR
See #415 and #410

Hi JImBob,
thanks for you reply.
Not the remote.axd, but the general image processor is not working.
Are there any solution?

Hi JimBob,
It is strange because the www is also a subdomain.
So how come http://www.staging.com is working and http://www.mysite.remax-malta.com is not working?
Thanks

It's all in the number of periods in the url. The HttpModule wasn't correctly mapping the application path.
I've just pushed a fix testing against both

.imageprocessor.foo.bar.baz.com
www.imageprocessor.foo.bar.baz.com

and it now works perfectly.
I'll get a release out soon.

Acutally, my url is mysite.remax-malta.com

@simoazzo It shouldnt really matter what the url is now. ImageProcessor.Web will read it correctly.
To answer your other question I need to perform a full set of tests before I release the new version. I'll try and run those tests this evening.

New release available on Nuget now.

Hi JimBob,
I have updated the imageProcessor but no success.
I am trying to access the image wth the following url:
http://commercial.remax-malta.com/remote.axd?http://www.remax-malta.com/UserImages/24/L_3a19d3a0a996448aa2c7f8979ec43d2a_iList.jpg?entropycrop=250&width=1358&height=800&mode=crop

Have you?
I just checked the response headers and your version numbers are the following.
ImageProcessor/<IP_ADDRESS> - ImageProcessor.Web/<IP_ADDRESS>

The version numbers should be.
ImageProcessor/<IP_ADDRESS> - ImageProcessor.Web/<IP_ADDRESS>

I would perform a clean, rebuild, and try again.

I'm quite sure that I have updated them both, through nuGet.
And replaced both .dll files and web.config...

Before I checked your response headers? Those numbers are coming from the version numbers in your application.

Yes. The .dll and  the web.config are need to be changed right, after update? and how can  I check that from the response headers? Through dev tools?

Hi JimBob,
How about the fix regarding the url? In my case, through this url (auctions.remax-malta.com) the imageprocessor is not working.
thank you. Hearing from you

Hi there, my apologies, but I'm super swamped. Have you trued downloading the source and debugging?

Hi JimBob,
Yes, I have checked the code and the issue is because of the url, having two subdomains... because I have www and in my case (auctions.remax-malta.com) I have also the auctions as another subdomain.
I don't know if you can arrange that accordingly to work even with two sub domains, because www is a sub-domain.
Thanks
kind regards

Thanks for checking.
I'll need a lot more detail though Would it be possible for you to tell me where the exception is thrown?

Your url is incorrect. You're using the old double ? and the schema when you shouldn't be. See the documentation.
http://imageprocessor.org/imageprocessor-web/imageprocessingmodule/#remote
I just added bindings to match your url on my local machine and tested the four following combinations.
http://www.commercial.remax-malta.com/remote.axd/www.remax-malta.com/UserImages/24/L_3a19d3a0a996448aa2c7f8979ec43d2a_iList.jpg?entropycrop=250&width=1358&height=800&mode=crop

http://www.commercial.remax-malta.com/remote.axd/remax-malta.com/UserImages/24/L_3a19d3a0a996448aa2c7f8979ec43d2a_iList.jpg?entropycrop=250&width=1358&height=800&mode=crop

http://commercial.remax-malta.com/remote.axd/www.remax-malta.com/UserImages/24/L_3a19d3a0a996448aa2c7f8979ec43d2a_iList.jpg?entropycrop=250&width=1358&height=800&mode=crop

http://commercial.remax-malta.com/remote.axd/remax-malta.com/UserImages/24/L_3a19d3a0a996448aa2c7f8979ec43d2a_iList.jpg?entropycrop=250&width=1358&height=800&mode=crop

Each of them worked perfectly. The only configuration I had to do was in security.config where I added the value.
<add url="http://remax-malta.com/"/>

Here's a picture of proof.

Hi JimBob,
I don't think so that that's the problem, of the remote.axd.. because in auctions.remax-malta.com I do not have remotely images...
And I have tried again, online.. and it does not work.. the last two

I'm using exactly the same url that you provided me with the fixes and it works.
Give me an exact url to query and I'll see what I can determine. You've not provided anywhere near enough information so far.

Hi JimBob,
Ok, let me take this example. For the following site, I have updated the Image Processor to the latest:
URL 1: http://auctions.remax-malta.com/media/1149/a001l05-1-main.jpg?anchor=center&mode=crop&overlay=wm.png&overlay.opacity=80
URL 2: http://www.remaxauctions.jkgroup.casasoft-dev.com//media/1149/a001l05-1-main.jpg?anchor=center&mode=crop&overlay=wm.png&overlay.opacity=80
Both domains binds to the same file system. One is working and the other is not working.
That's what I am referring to that the image processor is changing behavior on domain url.

Right... So you mean the overlay processor is not working on the first url?
That's an entirely different issue.
It's really important when you are raising issues to ensure that you provide all the necessary information in order for me to correctly debug and provide a solution. There are contributions guidelines that I have added to the solution in order to make the process easier for everyone involved.
https://github.com/JimBobSquarePants/ImageProcessor/blob/Core/contributing.md
That said, now I know what I am looking for I should be able to provide you with a solution.

Hi Jimbob,
the above were just an examples with the overlay, you can also try the width and height etc...
May I ask what could be the issue with the server and what type of settings might I am missing in order that they are not working using such urls?

Because I have verified on another server and it is working fine:
http://auctions.remax-malta.hector.casasoft-dev.com/media/81857/auc001l07-2.jpg?anchor=center&mode=crop&width=800

There's something with the server but I don't know exactly. Maybe you can help me out on this after we identified the problem?

But even here is working, on the same server where it is not working:
http://auctions.remax-malta.hector.casasoft-dev.com/media/81857/auc001l07-2.jpg?anchor=center&mode=crop&width=800

This is gonna be tough... I'd start with your web.config and ensure the httpmodules are correctly configured.

The web.config is the same for both, for the one working and for the one that it is not working... the only difference is the url...
http://auctions.remax-malta.hector.casasoft-dev.com (working)
http://auctions-remax-malta.com (not working)

Well I think we've established already that the domain name has nothing to do with it. There must be another difference. OS version, IIS version, Modules within IIS, .NET framework version, external libraries, the list goes on...
This isn't a code issue and I don't have access your servers so I'm afraid I can't be of any help to you.

Hi JimBob,
After get deeply into the issue that we had, after investigation we have found what was causing the problem.
First we tried to match the response headers to see what's difference by the url that it was working and the other that it wasn't. Then we found that the one that was not working was being served by cloudflare.
After determined that Cloudlfare was the problem we then continued to investigate on what was causing the problem from Cloudlfar and then we realized that the Caching of the Cloudflare was set to No Query String. Therefore, that' why it was not working because Cloudflare was acutally caching without query strings, where actually for the image processor to work are necessary. We're still thinking why the caching was set to No Query String. Acutally the client we are working for has somewhat change to No Query String. Then we changed it to Standard
Hopefully, we solved the question. We have posted this comment as a SOLUTION for thosse who might face the same problem.
Don't forget, if you are using image processor and CLoudflare, make sure that the Cloudflare caching setting is set to Standard

FANTASTIC NEWS!!! :tada:
Very glad you found the solution.


python.3 comix.py list function...

When I use "python3 comix.py list" to show a list of the items I own, it always caps out at 700 (the perils of both buying a lot and buying a lot of free items).  My library is larger than 700, so I'm not always seeing the items I want, which is typically ones I've just purchased.
Is this a limit that's built into the script, or something from Amazon's end?  The 700 items it reports aren't always the same, either, although it does tend to show items purchased first near the top of the list (but not all of them).  I just bought a comic a few days ago, and it shows up at the moment, but others purchased the same day don't, and tomorrow those "missing" items might appear but the one showing now might not.  Is there any way to increase this so that the list is complete?

Not quite sure about this, I suspect it's due to the way the the issue infos are acquired in bulk and could be solved by just splitting it into multiple requests for large libraries, but I can't really test it since my library is tiny.

Unfortunately have the same issue with 1800+ comics. Would love to facilitate testing.

A little bit of naive testing suggest that they could just use sinceDate to split the library

Yes, basic alg is:
sinceDate = None
while True:
params = getBaseParams()  #  account_type, lang, deviceType
if sinceDate is not None:
params.append(('sinceDate', sinceDate))
res = getPurchaseTransactions(params)
if len(res) == 0:
break
for purchaseTransaction in res:
buyTime  = (get_buyTime(res)  // 1000)   # API seems to want a real epoch, not js
sinceDate = max(buyTime, sinceDate)
# output protobuf as usual
I suggest caching this data, which will allow you to output the majority of the list without queries, then query for all the transactions since the last one you have cached.
Since the protobuf's .proto file isn't  included in the source, I can't easily make a patch for you, but the buyTime variable is referenced from the protobuf msg that includes the book's ID.  Something like:
message timeMsg {
required int64 buyTime = 1;
}
message bookMsg {
required string bookid = 1;
required timeMsg timeval = 2;
}
message gptMsg {
required int32 numBooks = 1;
optional int32 someNum = 2;
repeated bookMsg booklist = 3;
}


misc/cgo/testgodefs: failing on linux-arm-arm5spacemonkey

Now that #32407 is resolved, on to the next failure!
This one also appears to be due to the read-only GOROOT (#30316), so before proceeding I plan to see if I can fix that on the other linux builders.
##### ../misc/cgo/testgodefs
./test.bash: line 17: anonunion_defs.go: Permission denied
./test.bash: line 17: issue8478_defs.go: Permission denied
./test.bash: line 17: fieldtypedef_defs.go: Permission denied
# misc/cgo/testgodefs/testdata
./main.go:8:8: undefined: T
./main.go:12:10: undefined: Issue8478
2019/11/12 10:47:19 Failed: exit status 2
2019/11/12 10:47:25 FAILED

I changed builder user to "gopher" after I saw the "run by root" message but it failed linux/mips64le too.
https://build.golang.org/log/fa1c19c15a7a5ddf418d576cb2a5ba4c375c54c0
However it's fine when I run them manually.
+ FILE_PREFIXES='anonunion issue8478 fieldtypedef'
+ cd testdata
+ RM=
+ for FP in '$FILE_PREFIXES'
+ go tool cgo -godefs -srcdir . anonunion.go
+ RM=' anonunion_defs.go'
+ for FP in '$FILE_PREFIXES'
+ go tool cgo -godefs -srcdir . issue8478.go
+ RM=' anonunion_defs.go issue8478_defs.go'
+ for FP in '$FILE_PREFIXES'
+ go tool cgo -godefs -srcdir . fieldtypedef.go
+ RM=' anonunion_defs.go issue8478_defs.go fieldtypedef_defs.go'
+ go build -o testgodefs .
+ ./testgodefs
+ EXIT=0
+ rm -rf _obj testgodefs anonunion_defs.go issue8478_defs.go fieldtypedef_defs.go
+ exit 0

Yeah, there are currently some tests that fail with a read-only filesystem. I'm hoping to fix them this week.


[WIP] Add overlay for pipeline-service with minio

Add overlay for pipeline-service with minio. We can't apply overlay for tekton-results from the dev_setup.sh script, because argocd clean up these changes after sync.  That's why in  this pr introduces two argocd pipeline-service apps: base and dev overlay. Proposed project structure:

operator/gitops/argocd
  |
  |-------base
  |.        |
  |.        |---pipeline-service
  |         |               |
  |         |               |---openshift-pipelines
  |         |               |---pipelines-as-code
  |         |               |---tekton-chains
  |         |               |---tekton-results
  |         |               |---kustomization.yaml
  |.        |
  |         |---kustomization.yaml
  |         |---pipeline-service.yaml
  |
  |----overlays/dev
                 |
                 |---pipeline-service
                 |              |
                 |              |---tekton-results (folder with patches)
                 |---kustomization.yaml
                 |---pipeline-service.yaml

Add minio fix to make it working with older 4.5.4 and new minio 4.5.8

If we are going to split up operator/gitops/argocd into base and overlays, we need to clearly define what base contains and that should ideally be the files that are common across multiple overlays. So I propose refining the folder structure to look like below.
operator/gitops/argocd
  |
  |-------base
  |         |
  |         |---pipeline-service
  |         |               |
  |         |               |---openshift-pipelines
  |         |               |---pipelines-as-code
  |         |               |---tekton-chains
  |         |               |---tekton-results*
  |         |               |---kustomization.yaml
  |         |
  |         |---kustomization.yaml
  |         |---pipeline-service.yaml
  |
  |-------overlays/dev
                 |
                 |---../../base
                 |---tekton-results (folder with patches)
                 |---tenant
                 	    |---kustomization.yaml
                 	    |---namespace.yaml
                 	    |---tenant.yaml
                 	    |---tenant-permissions.yaml
                 |---minio.yaml
  |-------overlays/prod
                 |
                 |---../../base
                 |---tekton-results*

Depending on what is most suitable for tekton-results
a. the default version of tekton-results can be first installed from base and then in the dev folder, we could apply patches (in this case, remove tekton-results from overlays/prod)
b. we install different versions of tekton-results in overlays/dev and overlays/prod (in this case, remove tekton-results from base)

@AndrienkoAleksandr I'm adding the WIP tag in the title so we don't merge it. Please remove it when you submit the new version with the changes we talked over during our meeting.

I moved farther work to the pr https://github.com/openshift-pipelines/pipeline-service/pull/461


adopt skill.json for examples

skill.json files are now part of the locale folder of skills and have language support
https://openvoiceos.github.io/ovos-technical-manual/skill_json/
osm should be dropped and those files uses instead https://github.com/OpenVoiceOS/skill-ovos-homescreen/blob/dev/init.py#L211-L226
probably should introduce a new bus api to handle the skill.json files

This could be delegated to the SkillManager since it already manages what skills/intents are loaded (including which languages). This could also be left to another skill to provide the examples via the SkillAPI which was the original implementation here and what Neon does to allow for formatting the examples

yes, a request/response from skill manager should be consumed by this skill
but workshop base skill class should register these files via bus like it does for intents, to account for standalone skills

duplicated... #128


Infer the name of the source from the name of the path for remote sources

update placeholder text to say "source name inferred from file name"
invert order of path & source name
figure out tooltip situation

This could be done a few ways:

short term – parse path and get file
longer term – this should be part of pre-flight wrt globbing, etc.


fixed typo in README

this is mostly to see the PR template :)

@all-contributors please add @eirini-zormpa for review and bug.


chore(package): update aggregation-repository-provider to version 2.6.27

:tada: This PR is included in version 8.5.30 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Wrong text colour when hovering on some buttons

For some buttons e.g. the "Create your account" button on the login page, when you hover on it the button colour changes to black and if the text is also black the text is no longer visible. I've noticed this on two buttons which have a white background (also on the "Login" button on the Create your account page.
I suggest that for buttons with white background and black text where the button colour changes to black the text colour should change to white.
Before hover:

During over:

@adnanzahid89 can you look into this?

@azahid89 can you look into this?

@azahid89 can you look into this?

Sure let me

@azahid89 can you look into this?

Sure let me check this


[feat] New Figma component for portal navigation

Please create a new element for the Figma design library that represents the main navigation on the Red Hat Customer Portal (access.redhat.com).
The component should provide variations for desktop, tablet, and mobile views in both authenticated and unauthenticated states. Refer to the attached screenshots for reference.

@littledezine Hey Cheryl, I have added the following Customer Portal navigation components to the Figma library. The Header navigation component is the Universal navigation and Primary navigation components stacked on top of each other. If you want to know the story of these names, I can tell you somewhere else.
Header navigation

Viewport sizes

Desktop, large (1680px)
Desktop, medium (1440px)
Desktop, small (1200px)
Tablet, large (992px)
Tablet, small (768px)
Phone, large (576px)

(Note: Phone, small (360px) and Phone, extra small (320px) are not included because they degrade to the Primary navigation component because of the lack of space.)

Universal navigation

Viewport sizes

Desktop, large (1680px)
Desktop, medium (1440px)
Desktop, small (1200px)
Tablet, large (992px)
Tablet, small (768px)
Phone, large (576px)

(Note: Phone, small (360px) and Phone, extra small (320px) are not included because they degrade to the Primary navigation component because of the lack of space.)

Primary navigation
Logged out

Logged in

(Note: The avatar in the Logged in state is a slightly newer version of rh-avatar. I updated the design very slightly to match pf-avatar in PatternFly 6. This update has not been coded yet, but the design is current and aligns to PatternFly 6.)


pull request for e2e test at 01/18/2017 02:56:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Deprecated syntax

Example 2 uses incorrect syntax "Get-PnPNavigationNode -QuickLaunch", this should be "Get-PnPNavigationNode -Location QuickLaunch"
Examples 3 and 4 use deprecated syntax - the parameters Location and Title are no longer in the document.  It would be useful if these examples were replaced with one that performs the same job of removing a node with a specific Title, since this is a common task.  I believe the easiest way to do that now is:
Get-PnPNavigationNode -Location QuickLaunch | Where-Object { $_.Title -eq "Home" } | Remove-PnPNavigationNode -Force

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 53df4ad8-9006-4d5c-8829-a1c481dac939
Version Independent ID: 15dfc257-8c5f-63d6-ffe7-f7a7163c25bf
Content: Remove-PnPNavigationNode (sharepoint-pnp)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Remove-PnPNavigationNode.md
GitHub Login: @techwriter40
Microsoft Alias: kirks

@officedocsbot assign @yogkumgit

Hello @James-Noble
How are you? I need to kindly redirect you to this other repo to file issues about PnP PowerShell, as you might know, PnP cmdlets are community-driven, a member of the community will pick your issue there and handle it.
Thank you

I went to the other repo you mentioned, clicked on documentation and the only thing there was was a link back to docs.microsoft.com :)
So I had a bit of further digging around and finally managed to find this:
https://github.com/SharePoint/PnP-PowerShell/blob/master/Commands/Navigation/RemoveNavigationNode.cs
Presumably I should report the issue on that file since I can't report it on the documentation itself, which is hosted here?

Hello @James-Noble
Please use this link to open the new issue on that repo.
Documentation for PnP cmdlets is directly reflected from PnP cmdlets source code, so yes, that is the place 👍
Thank you!

@get-itips  Thank you very much for the contribution and sharing this explanation. @James-Noble
Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Proposal: Empty div with Height to prevent jank when sticking/unsticking

Problem:

The child nodes of <Sticky> component are switched to position: fixed
They go out of their current position and stick to the top
Other divs below them suddenly jump into the now empty space that these child nodes occupied
This causes a jank

Proposal:

When rendering <Sticky>, add a hidden, empty faux
 tag
Before sticky gets activated, set height of this faux div as the current height of Sticky container

For e.g. If Sticky children had 100px height, just before sticky gets activated the faux div gets height set as 100px

After the faux div height is set, the Sticky child nodes now get position: fixed
Now there is no jank. Other divs below the Sticky container don't jump to the top because the faux div now occupies that space
When Sticky gets disabled, simply set height of faux div to 0

When Sticky is not active:

 {sticky children}

 {other divs ...}

When Sticky is active:
Let's say height of the children was 100px,

 {sticky children}

 {other divs ...}

If you think this is fine, I can raise a PR with the changes. So how about this?

Update: I have checked out a branch. During componentDidMount I cache the height of the domNode. And when rendering, I render an empty div with this height whenever sticky is enabled. Its scrolls awesome with zero jank. So the theory works, will send a PR.

Looks good to me. Perhaps use the sticky's clientRect https://github.com/captivationsoftware/react-sticky/issues/29#issuecomment-155994999 as a default value?
Do the sticky children jump/jank, but the content below scrolls smoothly? That is why I put the margin on the top. Perhaps a couple of options like fauxTop || fauxBottom (or scrollMarginTop || scrollMarginBottom)? Something like:

  {this.props.fauxTop &&

}

 {sticky children}

  {this.props.fauxBottom &&

}

+1 looking forward to this!

I'm a bit packed but will work on this over the weekend. Until then, here's a FauxSticky wrapper that I'm using and works very well!
export default class FauxSticky extends React.Component {
  constructor (props) {
    super(props)
    this.state = { isSticky: false, fauxHeight: 0 }
  }

  handleStickyStateChange (isSticky) {
    let fauxHeight = isSticky ? this.refs.sticky.domNode.getBoundingClientRect().height : 0
    this.setState({ fauxHeight })
  }

  render () {
    return (

        <Sticky ref='sticky' {...this.props}
          onStickyStateChange={this.handleStickyStateChange.bind(this)} />

    )
  }
}

NOTE: It uses the height of the Sticky ref domNode. So if you're applying any extra margin/padding to the .sticky CSS class, the faux height will jump up a bit more than usual. Just saying, as long as the .sticky class doesn't have any height manipulated, the above works good.
When we move this inside react-sticky, we'll have access to the original div's height before sticky class is applied. So we can do anything we want with the sticky class after that :smiley:

You will want to move the function bind to the constructor (create function once versus many times):
https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md

I will work on bringing this in this weekend

@dbarbalato thank you so much, sorry I was a bit held up and couldn't make this happen :+1: If you're doing this within the component, then it can be done even before onStickyChange is called, and that would be great :)

The spirit of this idea will be in 4.0.0 via the inclusion of the new StickyContainer tag. Check out the demo and new README to see things in action. It was a really smart idea - good thinking.


Regexify doesn't escape brackets

Hello! I have tried to escape brackets using Faker\Provider\Base::regexify, but looks like it doesn't work.
Examples:
\\(
\(
(()
[(]
/\+7 \([0-9]{3}\) [0-9]{3}-[0-9]{4}/

From the phpDoc:
    /**
     * Transforms a basic regular expression into a random string satisfying the expression.
     *
     * @example $faker->regexify('[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}'); //<EMAIL_ADDRESS>     *
     * Regex delimiters '/.../' and begin/end markers '^...$' are ignored.
     *
     * Only supports a small subset of the regex syntax. For instance,
     * unicode, negated classes, unbounded ranges, subpatterns, back references,
     * assertions, recursive patterns, and comments are not supported. Escaping
     * support is extremely fragile.
     *
     * This method is also VERY slow. Use it only when no other formatter
     * can generate the fake data you want. For instance, prefer calling
     * `$faker->email` rather than `regexify` with the previous regular
     * expression.
     *
     * Also note than `bothify` can probably do most of what this method does,
     * but much faster. For instance, for a dummy email generation, try
     * `$faker->bothify('?????????@???.???')`.
     *
     * @see https://github.com/icomefromthenet/ReverseRegex for a more robust implementation
     *
     * @param string $regex A regular expression (delimiters are optional)
     * @return string
     */

As @ppelgrims said, we won't try to implement more special cases than what's already there.


Deep copy

Just started reviewing :):rocket:

I need to check this in more details :) First I would try to reuse visitProperty method from the base class, and so on.
Thanks, just stay tuned!

Np, thx @igorspasic

Sorry for long reply! I needed some time to fully understand your needs ;)
So this is not exactly the deep copy, as values are not cloned; instead we perform the bean copy. And that is the main reason why we can not proceed with this: detection of the types that are beans is... tricky. You have put them in the list called primitives, and there you can find, besides the real primitives, types like String and Locale. But that is not enough. There are plenty of other Java types that are not beans: Calendar, *Stream, *Reader, StringBuilder, TimeZone, BigDecimal, BigInteger and so on and on. Not to mention 3rd party types. Also, need to cover enums etc.
I don’t see a reasonable way to handle this? Maybe we can exclude all java.* types.
I was going in direction where you can specify for each target property one of the following:

to clone source to target (deep copy)
to copy source reference to target (shallow copy)
to create new instance with optionally specified type and perform bean copy

Also, there is one case not covered in your code, that is when source is eg. a Map and destination is a bean - and vice/versa.
I think such class would be quite complex and at the end not very fall this is not easy neither fast to implement this in generic-it-works-for-all way.


[WIP] Add openapi-schema files to deployment yaml and adjust directory

Currently aimed at merge into my #1680 PR to keep these as two separate bit-sized chunks.

Add the openapi-schema.yaml file generated from ytt.
Adds a ./config subdirectory in the deploy files to make room for later Package enhancements.

TODO:

[ ] pinniped-ci will likely require some similar changes:

pushd pinniped/deploy/concierge >/dev/null
pushd pinniped/deploy/supervisor >/dev/null

these will need the ./config added as well.

Are the branches for this PR correct?

This should wait until the other that adds the /config directory merges.
So I do currently point this PR at the config PR for that reason.
I could collapse it into one PR but figured bite-sized bits makes sense.

Revamping this work, will open a new PR.


Added download counts

Adds a column for total downloads and weekly downloads.
The data for daily and monthly downloads is also saved each time the backend runs.
Need to put the PEPY_API_KEY secret into the .env file to test locally.

Testing locally and then I'll merge.
We should set up a daily action to run the backend and deploy the site, to make sure it stays up to date.

We should be able to add a cron job to the existing workflow right?

I think so!


fix(system): improve query help docs

Pull Request
🤨 Rationale
https://dev.azure.com/ni/DevCentral/_workitems/edit/2485888
👩💻 Implementation

Added query_help.md
Improved field tooltips

🧪 Testing
n/a
✅ Checklist

[x] This PR has a title that follows the commit message format.

:tada: This PR is included in version 3.2.1 :tada:
The release is available on:

v3.2.1
GitHub release

Your semantic-release bot :package::rocket:


[fix](tablet sched) fix delete stale remain replica

we have met a case  a tablet's  multiple replicas  have the same replica id,   but only one of them's  backend id is in current backend ids,  the other's backends are unavailable.  maybe they are stale backend which has be decommissioned.
An example: a tablet contains two replicas:
replica 1: (replica id = 100,  backend id = 1000) ,
replica 2: (replica id = 100,  backend id = 2000).
But the system not contains backend 1000 now.  Then if this tablet is REDUNDANT,  it will pick replica 1 to delete because its backend is not available. Then deleteReplicaInternal will count other replica which replica id is not equals with replica 1, it got 0, then deleteReplicaInternal will fail.
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


After deploying to the vercel, my remix app is only returning a white screen, even though it is working fine on localhost.

What version of Remix are you using?
1.41.1
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce
I have deployed the remix app on vercel and it was working fine. Recently, a couple of days ago, I pushed some changes to the main and the app hosted on to the vercel is only returning a white screen now. Routes are not working either. While, everything is working fine on localhost
Expected Behavior
App should work on vercel like it is working on the localhost
Actual Behavior
The app is displaying a white screen on vercel

Closing in favor of #6092


Missing and outdated documentation

I was pointed to this library over from the classic Android-BLE-Library and was at a loss how to start. Is there no documentation, or am I just unable to find it? The README is quite short, and it is outdated.
To be a bit more concrete:

Scanner: What’s the aggregrator for, how to actually use the found devices when we need a bit more than MAC addresses.
Client: You cannot connect() directly on the device (anymore?), and how do you handle connection changes etc.

I am rewriting the library at the moment, with the native client coming in few weeks. It won't be compatible with the current version. Until then, I recommend using the old Java-based library, despite what it says.
In the new one I hope to have more self-readable API and better doc as well.
I'll be pushing my code when only it gets usable so you can track it.

How is the new library coming?

I aim to have the client ready in June, but at the moment I'm busy with another project so can't promise anything.

See #152.


Address flag not set correctly for uninhabited x

@geoffj-FUG Was incorrectly determining the address flag. Fixed and deployed to test3

Address flag is behaving as expected.
Geoff


simulation: STAR FIELD

Proposed Simulation Name
Brief description of the simulation
Category Proposed: Physics
Additional points/links:
Links and points
https://youtu.be/17WoOqgXsRM

Hii @kmrakash, May I know what to be done in this issue?

@yashlamba  should i work on this part now ??

Starfield isn't a categorizable simulation. I don't think it is something we need in simulate.


fix: use config.root as cwd for fast-glob

Otherwise fast-glob sets cwd to process.cwd().

Would that work to glob files outside of root? (or is that a valid use-case?)

I think fast-glob doesn't search outside of cwd.
Independently of that, the behavior of import.meta.glob() should not depend on process.cwd().
Setting cwd to config.root is a more robust default.


Latest changes course this ?

Declaration of kanban\widgets\ToDo::registerPlugin($pluginName = NULL) should be compatible with simialbi\yii2\widgets\Widget::registerPlugin($pluginName = NULL, $selector = NULL)

I released a version 1.6.4.
It should fix the problem

I released a version 1.6.4.
It should fix the problem


Update Java JDK version to 17 in Azure Functions Maven archetype

Update Java JDK version to 17 in Azure Functions Maven archetype

#assign:karlerickson

#sign-off

@silenceJialuo as a reminder, please remember to use the private repos for pull requests. learn-pr instead of learn. Thanks!

#please-close

@silenceJialuo could you please close this PR? Thanks!

@silenceJialuo ping


modified: homePage mousemove && community module delete repeat message

1、 modify the top title "document" and "asf" when the mouse leave the title I want to close the list.
2、Deleted duplicate content：News

nice work! I will review。

nice work! I will review。

PTAL @GaoTianDuo

@CalvinKirs  please review and merge


rename capd-manager to manager for new kubebuilder

/kind feature
Describe the solution you'd like
kubebuilder v0.2 likes the manager to be called manager
Anything else you would like to add:
Environment:
/assign
/lifecycle active

/priority important-soon


MVAPICH segfaults Scalapack

Describe the bug
Scalapack segfaults if mvapich chosen as mpi provider.
Steps To Reproduce
nix build --impure -L --expr 'with import (builtins.fetchTarball "https://github.com/NixOS/nixpkgs/archive/refs/heads/nixpkgs-unstable.tar.gz") { overlays = [ (final: prev: { mpi = final.mvapich; }) ]; }; scalapack'
Expected behavior
MVAPICH2 should not segfault the standard ScaLapack test suite.
Additional context
Add any other context about the problem here.
Notify maintainers
@markuskowa
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 6.4.16, NixOS, 23.11 (Tapir), 23.11.20230929.f5892dd`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.0`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

I've tried multiple things; building with gcc8Stdenv and gfortran8, directly using openblasCompat instead of the blas and lapack wrappers, downgrading the MVAPICH version, playing around with threading in mvapich, ... None of this changes anything. So I've just disabled the scalapack test suite and saw how far I can get. So, for example I've built CP2K and its dependencies with MVAPICH and a disabled  Scalapack test suite. And somewhat to my surprise every other test passes. CP2K works just fine, the fftw-mpi tests are fine, SIRIUS works as expected. So maybe in practice this is a non-issue? Or the error is in Scalapack rather than MVAPICH?

Which network type have you used for mvapich?

I'm testing on my workstation with ethernet. However, my main goal is to use it on our cluster with OmniPath as CP2K has memory leaks with OpenMPI for some types of calculations (e.g. constrained DFT QM/MM).


[READY FOR REVIEW] IOS Version bump

#256

@teolemon https://github.com/openfoodfacts/smooth-app/pull/257/checks?check_run_id=2087512588#step:8:73

going to merge

👍🏻

It seems to have worked well.

Great, just wonder what is happening with the web workflow https://github.com/openfoodfacts/smooth-app/runs/2159445983


omega: Handles two-element Prod.Lex, but not three elements

@hargoniX  and I just ran into this while proving termination with a rather complex termination measure: omega has some support for Lex.Prod, but breaks when nesting it:
example : Prod.Lex (· < ·) (· < ·) (0, 0) (0, 1) :=
  by omega -- works

example : Prod.Lex (· < ·) (Prod.Lex (· < ·) (· < ·)) (0, 0, 0) (0, 1, 0) :=
  by omega -- fails

Versions
0.4.7
Impact
Add :+1: to issues you consider important. If others are impacted by this issue, please ask them to add :+1: to it.

We're not planning to further increase the scope of omega but to embed it into more general tactics instead


can you put the graphic pack for new super mario bross u + new super luigi u

thanks!

https://github.com/slashiee/cemu_graphic_packs/tree/master/Source/NewSuperMarioBrosU


Implement view: unsupported location

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.
Belonging to Epics:

[EPIC] #312 - View: Landing Page

Blocked By:

#316 - design view: unsupported location

Blocking:

[BLOCKED BY: #315, #316, #317] #316 - Integrate view: landing page

is anyone currently working on this issue? @schowdhury8

I've been assigned and working on it


feature(simulator): support an external scheduler

What type of PR is this?
/area web
/area simulator
/kind feature

What this PR does / why we need it:
support external schedulers.
When EXTERNAL_SCHEDULER_ENABLED is given as true, the simulator doesn't start a scheduler and web UI also doesn't show the gear button like this, because we cannot get and change an external scheduler's configuration.

I'll create the doc for users to use an external scheduler later in another PR.
Which issue(s) this PR fixes:

part of #182
Special notes for your reviewer:
/label tide/merge-method-squash

We also need to consider the Reset feature.

🙇
Fixed

Thanks!
/lgtm


Why the remodal instance removes the jquery methods?

I would like to do this:
$('.remodal').remodal().on('opened', callback);

or this
var remodalInst = $('.remodal').remodal();
remodalInst.on('opened', callback);

:/

Firstly, callback are on $(document) (the descendants of the selected elements .remodal), not on the remodal instance... (Read the doc ...).
$(document).on('opened', '.remodal', function () {
  console.log('Modal is opened');
});

The plugin return remodal instance, so you can call public method.
In the jquery documentation : The .on() method attaches event handlers to the currently selected set of elements in the jQuery object
If you want to keep your code :
var remodalInst = $('.remodal').remodal();
$(document).on('opened', '.remodal', function () {
  callback();
});


[PORT] Update Microsoft.BeginDialog.schema

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/3801

Add a "type" field for BeginDialog.dialog. Otherwise it will cause a error in Composer.

Changed projects

Microsoft.Bot.Builder.Dialogs.Adaptive
Microsoft.Bot.Builder.TestBot.Json

@luhan2017, does this apply to JS? can you close it if it doesn't?
Thanks

@gabog, it doesn't apply to JS, we don't have schema defined in JS yet.


I want to execute wrappers trustlessly (client-side hash verification)

[x] Add tests for IPFS content hash verification
[ ] Check if the they pass, if they don't implement content hash verification

Branch with example test: nerfzael-ipfs-content-verification
IPFS content hash verification does not work out of the box with ipfs-http-client, or with the js-ipfs SDK
Any content verification that happens, happens inside of the IPFS node.
After talking with @dOrgJelli we've decided to remove this from the alpha release since this is standard for all IPFS related projects.
However, I think we should explore it further and if having IPFS content verification built into the resolver is possible, then it should be implemented in the future.


Water rendering

Implement better water rendering, with higher quality water, reflections, refractions, etc ...
Also add underwater rendering, with blurried screen and blue color.

Hi, I would like to contribute. However I don't know where should I begin. May you lead?


Hybrid scan for deleted files using Broadcast join

Feature requested
Currently, Hybrid scan handles the deleted files by using Filter(Not(In(LineageColumn, deletedFiles)))
However, In case there are many deleted files, severe performance would be expected.
For example, N deleted files,

N string comparison occurs for each row in index data.
#200 can relax the regression, but not resolve the problem; there still N iteration for each row.

Instead of using NOT-IN filter, we could use Broadcast join & lineage column to remove the rows from deleted files.
TBD
Acceptance criteria
Success criteria
Additional context

@imback82 @rapoth Could you simply comment why this is not feasible?

If we can also enforce using broadcast join (not affected by config set by user), it should work for BHJ.
But, shall we get some perf numbers using left anti join vs. filter push down to evaluate before moving further?

If we can also enforce using broadcast join (not affected by config set by user), it should work for BHJ.

We could use "hint" to enforce broadcast join - see below log.
BTW BHJ only supports equi-join, so we need to run the query non-deleted file list.
I'll try to run both BHJ with equi-join and BNLJ with non-equi-join for performance validation.
scala> spark.conf.set("spark.sql.autoBroadcastJoinThreshold", -1)

scala> val join = query.join(query2, "id")
join: org.apache.spark.sql.DataFrame = [id: int, name: string ... 1 more field]

scala> join.queryExecution.optimizedPlan
res65: org.apache.spark.sql.catalyst.plans.logical.LogicalPlan =
Project [id#552, name#553, name#589]
+- Join Inner, (id#552 = id#588)
   :- Filter isnotnull(id#552)
   :  +- Relation[id#552,name#553] parquet
   +- Filter isnotnull(id#588)
      +- Relation[id#588,name#589] parquet

scala> join.queryExecution.sparkPlan
res66: org.apache.spark.sql.execution.SparkPlan =
Project [id#552, name#553, name#589]
+- SortMergeJoin [id#552], [id#588], Inner
   :- Project [id#552, name#553]
   :  +- Filter isnotnull(id#552)
   :     +- FileScan parquet [id#552,name#553] Batched: true, Format: Parquet, Location: InMemoryFileIndex[file:/C:/<path>/spark2/table], PartitionFilters: [], PushedFilters: [IsNotNull(id)], ReadSchema: struct<id:int,name:string>
   +- Project [id#588, name#589]
      +- Filter isnotnull(id#588)
         +- FileScan parquet [id#588,name#589] Batched: true, Format: Parquet, Location: InMemoryFileIndex[file:/C:/<path>/spark2/table], PartitionFilters: [], PushedFilters: [IsNotNull(id)], ReadSchema: struct<id:int,name:string>

scala> val join = query.join(query2.hint("broadcast"), "id")
join: org.apache.spark.sql.DataFrame = [id: int, name: string ... 1 more field]

scala> join.queryExecution.optimizedPlan
res70: org.apache.spark.sql.catalyst.plans.logical.LogicalPlan =
Project [id#552, name#553, name#612]
+- Join Inner, (id#552 = id#611)
   :- Filter isnotnull(id#552)
   :  +- Relation[id#552,name#553] parquet
   +- ResolvedHint (broadcast)
      +- Filter isnotnull(id#611)
         +- Relation[id#611,name#612] parquet

scala> join.queryExecution.sparkPlan
res71: org.apache.spark.sql.execution.SparkPlan =
Project [id#552, name#553, name#612]
+- BroadcastHashJoin [id#552], [id#611], Inner, BuildRight
   :- Project [id#552, name#553]
   :  +- Filter isnotnull(id#552)
   :     +- FileScan parquet [id#552,name#553] Batched: true, Format: Parquet, Location: InMemoryFileIndex[file:/C:/<path>/spark2/table], PartitionFilters: [], PushedFilters: [IsNotNull(id)], ReadSchema: struct<id:int,name:string>
   +- Project [id#611, name#612]
      +- Filter isnotnull(id#611)
         +- FileScan parquet [id#611,name#612] Batched: true, Format: Parquet, Location: InMemoryFileIndex[file:/C:/path/spark2/table], PartitionFilters: [], PushedFilters: [IsNotNull(id)], ReadSchema: struct<id:int,name:string>


Sorting in Java

All the Sorting Techniques in Java

Sorting and Linked List in Java

Added for !60


Special IP proxy service timeout problems

#cat checkip.py  #To streamline the code
def check(ip, port, timeout=30):
    proxies = {
      "http": "http://%s:%s" % (ip, str(port)),
      "https": "http://%s:%s" % (ip, str(port)),
    }
    requests.get(check_url, proxies=proxies, timeout=timeout, verify=False)

` #python2.7
>>> import requests
>>> requests.__version__
'2.10.0'
>>> from checkip import check
>>> check("<IP_ADDRESS>",3128,timeout=1)
False
>>> check("<IP_ADDRESS>",3128,timeout=10)
Here is the infinite waiting for...`

#ss  #The state is ESTAB

@toadzhou Does this actually have anything to do with the timeout? If you change the second timeout to 1, does the error still occur?

Of time is very short is no problem, the problem may appear in he has established a connection!

To be clear, if you're calling requests.get then there is no state being shared: there is no way for two calls to requests.get to interact with each other on your machine. The proxy might be screwing it up, but Requests cannot. The only way to have that behaviour is if you're using a Session, which this code is not.

Ok thanks!

I am a single independent connections.
Try the requests.Session() still won't do
What method can solve the problem

@toadzhou Right now it's still not really clear what's happening in your connection. Can you run the script above with something like Wireshark and send me the packet capture?

@Lukasa
#tcpdump -i eth0 -vnn <IP_ADDRESS>
16:54:31.440888 IP (tos 0x0, ttl 64, id 52147, offset 0, flags [DF], proto TCP (6), length 44)
x.x.x.x.62004 > <IP_ADDRESS>.3128: Flags [S], cksum 0x4aa1 (correct), seq<PHONE_NUMBER>, win 5840, options [mss 1460], length 0
16:54:31.749509 IP (tos 0x0, ttl 52, id 0, offset 0, flags [DF], proto TCP (6), length 44)
<IP_ADDRESS>.3128 > x.x.x.x.62004: Flags [S.], cksum 0x203b (correct), seq<PHONE_NUMBER>, ack<PHONE_NUMBER>, win 29200, options [mss 1460], length 0
16:54:31.749549 IP (tos 0x0, ttl 64, id 52148, offset 0, flags [DF], proto TCP (6), length 40)
x.x.x.x.62004 > <IP_ADDRESS>.3128: Flags [.], cksum 0x9338 (correct), ack 1, win 5840, length 0
16:54:31.749663 IP (tos 0x0, ttl 64, id 52149, offset 0, flags [DF], proto TCP (6), length 80)
x.x.x.x.62004 > <IP_ADDRESS>.3128: Flags [P.], cksum 0xd039 (incorrect -> 0x5679), seq 1:41, ack 1, win 5840, length 40
16:54:32.057972 IP (tos 0x0, ttl 52, id 42614, offset 0, flags [DF], proto TCP (6), length 40)
<IP_ADDRESS>.3128 > x.x.x.x.62004: Flags [.], cksum 0x37d0 (correct), ack 41, win 29200, length 0
16:54:32.058005 IP (tos 0x0, ttl 64, id 52150, offset 0, flags [DF], proto TCP (6), length 42)
x.x.x.x.62004 > <IP_ADDRESS>.3128: Flags [P.], cksum 0xd013 (incorrect -> 0x85fc), seq 41:43, ack 1, win 5840, length 2
16:54:32.366473 IP (tos 0x0, ttl 52, id 42615, offset 0, flags [DF], proto TCP (6), length 40)
<IP_ADDRESS>.3128 > x.x.x.x.62004: Flags [.], cksum 0x37ce (correct), ack 43, win 29200, length 0
16:54:32.488958 IP (tos 0x0, ttl 52, id 42616, offset 0, flags [DF], proto TCP (6), length 79)
<IP_ADDRESS>.3128 > x.x.x.x.62004: Flags [P.], cksum 0x2de6 (correct), seq 1:40, ack 43, win 29200, length 39
16:54:32.488986 IP (tos 0x0, ttl 64, id 52151, offset 0, flags [DF], proto TCP (6), length 40)
x.x.x.x.62004 > <IP_ADDRESS>.3128: Flags [.], cksum 0x92e7 (correct), ack 40, win 5840, length 0
16:54:32.490157 IP (tos 0x0, ttl 64, id 52152, offset 0, flags [DF], proto TCP (6), length 337)
x.x.x.x.62004 > <IP_ADDRESS>.3128: Flags [P.], cksum 0xd13a (incorrect -> 0xf979), seq 43:340, ack 40, win 5840, length 297
16:54:32.798673 IP (tos 0x0, ttl 52, id 42617, offset 0, flags [DF], proto TCP (6), length 40)
<IP_ADDRESS>.3128 > x.x.x.x.62004: Flags [.], cksum 0x334e (correct), ack 340, win 30016, length 0
16:54:35.254479 IP (tos 0x0, ttl 52, id 42618, offset 0, flags [DF], proto TCP (6), length 41)
<IP_ADDRESS>.3128 > x.x.x.x.62004: Flags [P.], cksum 0x1d45 (correct), seq 40:41, ack 340, win 30016, length 1
16:54:35.295080 IP (tos 0x0, ttl 64, id 52153, offset 0, flags [DF], proto TCP (6), length 40)
x.x.x.x.62004 > <IP_ADDRESS>.3128: Flags [.], cksum 0x91bd (correct), ack 41, win 5840, length 0
16:54:38.045490 IP (tos 0x0, ttl 52, id 42619, offset 0, flags [DF], proto TCP (6), length 41)
<IP_ADDRESS>.3128 > x.x.x.x.62004: Flags [P.], cksum 0x3044 (correct), seq 41:42, ack 340, win 30016, length 1
16:54:38.045518 IP (tos 0x0, ttl 64, id 52154, offset 0, flags [DF], proto TCP (6), length 40)
x.x.x.x.62004 > <IP_ADDRESS>.3128: Flags [.], cksum 0x91bc (correct), ack 42, win 5840, length 0
16:54:40.817095 IP (tos 0x0, ttl 52, id 42620, offset 0, flags [DF], proto TCP (6), length 41)
<IP_ADDRESS>.3128 > x.x.x.x.62004: Flags [P.], cksum 0x3043 (correct), seq 42:43, ack 340, win 30016, length 1
16:54:40.817125 IP (tos 0x0, ttl 64, id 52155, offset 0, flags [DF], proto TCP (6), length 40)
x.x.x.x.62004 > <IP_ADDRESS>.3128: Flags [.], cksum 0x91bb (correct), ack 43, win 5840, length 0
16:54:43.574452 IP (tos 0x0, ttl 52, id 42621, offset 0, flags [DF], proto TCP (6), length 41)
<IP_ADDRESS>.3128 > x.x.x.x.62004: Flags [P.], cksum 0x2242 (correct), seq 43:44, ack 340, win 30016, length 1
16:54:43.574483 IP (tos 0x0, ttl 64, id 52156, offset 0, flags [DF], proto TCP (6), length 40)
x.x.x.x.62004 > <IP_ADDRESS>.3128: Flags [.], cksum 0x91ba (correct), ack 44, win 5840, length 0
16:54:46.349464 IP (tos 0x0, ttl 52, id 42622, offset 0, flags [DF], proto TCP (6), length 41)
<IP_ADDRESS>.3128 > x.x.x.x.62004: Flags [P.], cksum 0xc140 (correct), seq 44:45, ack 340, win 30016, length 1
16:54:46.349495 IP (tos 0x0, ttl 64, id 52157, offset 0, flags [DF], proto TCP (6), length 40)
x.x.x.x.62004 > <IP_ADDRESS>.3128: Flags [.], cksum 0x91b9 (correct), ack 45, win 5840, length 0
16:54:48.247303 IP (tos 0x0, ttl 64, id 52158, offset 0, flags [DF], proto TCP (6), length 40)
x.x.x.x.62004 > <IP_ADDRESS>.3128: Flags [F.], cksum 0x91b8 (correct), seq 340, ack 45, win 5840, length 0
16:54:48.556321 IP (tos 0x0, ttl 52, id 42623, offset 0, flags [DF], proto TCP (6), length 40)
<IP_ADDRESS>.3128 > x.x.x.x.62004: Flags [F.], cksum 0x3347 (correct), seq 45, ack 341, win 30016, length 0
16:54:48.556358 IP (tos 0x0, ttl 64, id 52159, offset 0, flags [DF], proto TCP (6), length 40)
x.x.x.x.62004 > <IP_ADDRESS>.3128: Flags [.], cksum 0x91b7 (correct), ack 46, win 5840, length 0

My code is to check all kinds of proxy IP is available, the timeout of which is directly to give up. But because the timeout is not effective, result in the process of my pool into a zombie process

Sorry, can you run that tcpdump with body capture turned on? tcpdump -nnvvXSs 1514 -i eth0 <IP_ADDRESS> should do it.

A little more So I can only give a link: http://<IP_ADDRESS>:8000/tcpdump2.log

@toadzhou Is that log with or without Sessions?

requests.get()

requests.get()
r = requests.Session()
r.get()
The result is the same

Or you can try with the local agent <IP_ADDRESS>:3128

@toadzhou The result is the same, but what happens is not. To be clear, I'd like a packet capture where you're using requests.get, not session.get.

I grab bag is running on this code
#!/usr/bin/env python
import requests
import socket
#import eventlet
#eventlet.monkey_patch()
check_url = 'https://xxx.com/'
check_key = 'test_key.'
from requests.packages import urllib3
urllib3.disable_warnings()
def check(ip, port, timeout=30):
proxies = {
"http": "http://%s:%s" % (ip, str(port)),
"https": "http://%s:%s" % (ip, str(port)),
"Accept": "text/html, application/xhtml+xml, /",
"Accept-Language": "zh-CN",
"User-Agent": "Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; rv:11.0) like Gecko",
"Accept-Encoding": "gzip, deflate",
"Connection": "Keep-Alive"
}
try:
    r = requests.get(check_url, proxies=proxies, timeout=timeout, verify=False)
    #import pdb;pdb.set_trace()
    if r.ok and check_key in r.content:
        return True
    else:
        return False
except:
    return False

check("<IP_ADDRESS>",3128,timeout=10)

Ok, and what exactly is the result of running that code? Does it hang forever, raise exceptions, or what?

Relative to the agent timeout does not work

Right, but to be clear, can you break down into a) what you expect this code to do, and b) what it actually does? Try to avoid giving a high level explanation and be as literal as possible.

I'm sorry!Also please forgive me
Verbal ability Determine the need to strengthen

@toadzhou You don't need to apologise, I appreciate that English isn't your first language. =) I'm just trying to find a way to explain what I need from you as clearly as possible.
In this case, I think I need to understand exactly what happens when you run that code, and what you think should happen.

This has been inactive for well over a month. I'm going to close this for now @toadzhou since we're unable to determine what the problem is. If you can gather more information and provide it, we can reopen this if we determine there's a bug in requests.
Thanks for filing this bug!


Updating Projects 100% shows too soon

User Story
As an Automate User, I will use this work when I want to update projects.
When I click the Update Projects, the button incorrectly flashes Updating Projects 100% before showing the expected Updating Projects 0%
recording in slack
Note: Probably need to flush stale data in ngrx/store from last update
Definition of Done

The Update Projects button, on click, should only progress from 0% to 100%, not jump back and forth

Similar bug: turns 100% while update is still in progress.


Local node-red image is not recognized

I tried to add a local node-red image to REDZILLA_IMAGENAME in docker-compose.yml and also config.example.yml
REDZILLA_IMAGENAME: mynode-red-docker:v1.0
time="2018-05-01T11:30:08Z" level=error msg="Internal Error: Error response from daemon: pull access denied for mynode-red-docker, repository does not exist or may require 'docker login'"
Is this as designed? Can we change something to get it to use local images? I tried to change my images
name to official image's tags using docker tag command but its not picking that up.
Thank you for your help

If you use compose you can the example yml.
It should work as I used it before. Does a simple docker run works with that image?

Yes. Directly running the image works. docker run works. I tried with docker compose also and its coming up.
Then I pushed the image to docker hub and tried
For public repository it works - I created an instance. I think there is some checking in docker hub for repository name even if image is present locally because after sometime I changed the repository to private and did a docker login in my system. Then I restarted redzilla and tried to create an instance and it failed with same error message.
I tried adding to config.example.yml also but getting same issue there. I tried with image ID instead of name but got same error.

Thanks for testing,let me check the code then.
If you want to try to fix it an provide a PR it would be very welcome!
sent from my phone
Il gio 3 mag 2018, 06:47 rmvpaps<EMAIL_ADDRESS>ha scritto:

Yes. Directly running the image works. docker run works. I tried with
docker compose also and its coming up.
Then I pushed the image to docker hub and tried
For public repository it works - I created an instance. I think there is
some checking in docker hub for repository name even if image is present
locally because after sometime I changed the repository to private and did
a docker login in my system. Then I restarted redzilla and tried to create
an instance and it failed with same error message.
I tried adding to config.example.yml also but getting same issue there. I
tried with image ID instead of name but got same error.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/muka/redzilla/issues/12#issuecomment-386190737, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA-VVZ-gwno0rWBj_vbGTFVv2kfNItxnks5tuovXgaJpZM4Tt2Xq
.

Hi,
I do not have any experience in Go programming. So cant fix it myself.
But looks like, there is no code for checking if existing. It seems to directly call Image pull in line 168 of docker/client.go. If we call docker pull localimage, we get the same error response
logrus.Debugf("Pulling image %s if not available", cfg.ImageName)
	_, err = cli.ImagePull(ctx, cfg.ImageName, types.ImagePullOptions{})
	if err != nil {
		return err
	}

Maybe something like cli.ImageInspectwithRaw might be useful.
(https://godoc.org/github.com/docker/docker/client#Client.ImageInspectWithRaw)

Should be fixed now @rmvpaps  @RohanAsmat  Please reopen if it is not!
Thanks

Hi Muka,
Thank you for an update @muka,
Can you please provide detailed steps of how to achieve this, as what I have done and which still doesn't work is as follows:

Uncommenting the image name from docker-compose to opny/redzilla
Renaming config.example.yml to config.yml
Updating ImageName in config.yml to rohanasmat/node-red-dashboard-plus-nodes:latest which is pulled from docker hub and it contains additional node palette for Node-RED.
Running docker-compose up

I am getting the following error:
`
Building redzilla
Step 1/4 : FROM scratch
--->
Step 2/4 : ENV GIN_MODE=release
---> Using cache
---> 714a5d49dd7e
Step 3/4 : COPY ./redzilla /redzilla
ERROR: Service 'redzilla' failed to build: COPY failed: stat /var/lib/docker/tmp/docker-builder893982847/redzilla: no such file or directory
`
Please let me know what I might be doing wrong my image contains some Node-RED dashboard nodes etc.
Best Regards,
Muhammad Rohan Ali Asmat


ReferenceError: Msal is not defined

Hi BenBaran,
I was checking out your msal-angular package. I couldn't get it to work, it keeps complaining about Msal is not defined:

AppComponent.html:1 ERROR ReferenceError: Msal is not defined
at MsalAuthenticationService.init (vendor.bundle.js:79288)

Perhaps it cannot find the external msal.js library. Do I need to add a script reference? Any idea what's wrong?
Thank you.

I’ll give it a look tomorrow. It’s possible I have an import in my test
project that hasn’t been integrated yet.
On Wed, Jul 26, 2017 at 3:16 PM Hendrik Wouters<EMAIL_ADDRESS>wrote:

Hi BenBaran,
I was checking out your msal-angular package. I couldn't get it to work,
it keeps complaining about Msal is not defined:
AppComponent.html:1 ERROR ReferenceError: Msal is not defined
at MsalAuthenticationService.init (vendor.bundle.js:79288)
Perhaps it cannot find the external msal.js library. Do I need to add a
script reference? Any idea what's wrong?
Thank you.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/benbaran/msal-angular/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AZ0u1j9EugiAU_HgH6z1-YJfi3ukE_cAks5sR563gaJpZM4Okbr1
.

This has been resolved in the latest version.


Geojson stroke color, stroke width, fill color, and marker color properties preserved

Does any other open PR do the same thing?

No
What issue is this PR fixing?
The GeoJson feature of this library does not preserve the stroke width, stroke color, fill color, and marker color properties from the GeoJson supplied. This PR now preserves all those properties and successfully displays map elements with those styling properties.
While these two issues may not be specifically about GeoJson, much of comments are about the GeoJson styling issue:
#2867 #3057
How did you test this PR?

This PR was tested with Android and iOS simulators, although the same logic was tested in a patch on real iOS and Android devices.
Using a GeoJson creator like https://geojson.io/ - it is easy to create map elements with properties in the GeoJson. From there, it's just a matter of firing up an app that uses the GeoJson you created in a map view.

I tested by just pasting your changes into the Geojson.js file and it seems to have worked. I haven't noticed any more issues. Would love for this to be merged.

I tested by just pasting your changes into the Geojson.js file and it seems to have worked. I haven't noticed any more issues. Would love for this to be merged.

@octagonalsquare Was it a polygon by chance? If a polygon overlaps, on Android this can cause the fill color to not come through. I think I'll need the geojson to debug.

@octagonalsquare Was it a polygon by chance? If a polygon overlaps, on Android this can cause the fill color to not come through. I think I'll need the geojson to debug.

@octagonalsquare please open a new issue if you still have the fill problem


Code Inspection: Tslint on branches

typedef

lib/aspect/node/TsLintAspect.ts:41: (warn) expected call-signature: 'apply' to have a typedef
lib/element/codeOwnership.ts:70: (warn) expected call-signature: 'apply' to have a typedef
lib/element/codeOwnership.ts:76: (warn) expected member-variable-declaration: 'fp' to have a typedef
lib/element/codeOwnership.ts:78: (warn) expected member-variable-declaration: 'extract' to have a typedef
lib/routes/wellKnownReporters.ts:166: (warn) expected call-signature: 'mapping' to have a typedef
lib/routes/wellKnownReporters.ts:319: (warn) expected call-signature: 'aspectGroup' to have a typedef

[atomist:code-inspection:branches=@atomist/atomist-sdm]

Issue closed because branch branches was deleted.

Issue closed because branch branches was deleted.


Fix game of life

update rand to github master, need to lock after new rand released
replace println! with console.log, need nll for more readable code
update example version and author message

@huangjj27 Cool! Thank you for the PR :+1:
I've created and released https://github.com/DenisKolodin/web_logger. Now we could use log crate instead of workarounds.
Could you update this PR to log dependency after #230 will be merged?

All right, it’ll be done by tomorrow.

@DenisKolodin Some advice is deperating the ConsoleService in yew when the web_logger stablized ,

build failed due to #231 in the showcase and a compacity problem in other target is found.
Asking for seperate target build and test stage in .travis.yml.

Let me know when you finish this PR, I want to rebase and merge it.

@DenisKolodin I think my job is done, but there is some campatibility issue from rand crate blocking. So just waiting.

I think we have to wait for this feature https://github.com/rust-lang/cargo/issues/1197 to merge this PR

I've rebased this PR and added some fixes.
I will merge it when dependent crates will be fixed and all tests will be passed.
Thank you :+1:

problem is fixed but PR is waiting for merging

@DenisKolodin I found that you changed the rand to version 0.5-pre.1, which doesn't include the fix. May need to update to next version before the final check.

Fix hasn't merged and in any case we have to use private branch for checking. I'll do it now. Please, don't push updates to this PR.

PR https://github.com/rust-lang-nursery/rand/pull/444 wokrs

And it just merged

I've updated the dependency to the master branch. If test will be passed I will merge it today and won't wait for the release of rand. The support in master is enough for this example.

bors r+


Background Sync

Per https://mozilla.github.io/standards-positions/#background-sync Mozilla considers Background Sync "Harmful" but https://platform-status.mozilla.org/#background-sync shows it as "Developing" which isn't true anymore.

@theSdev I've changed it to "under-consideration" — there is an extensive bug, and we've considered it quite a lot, but we don't like it in it's current state. Does that seem fair? The only other option is really "not-planned", which doesn't sound right.


Cleaner generlization of nnz_or_zip

Currently nnz_or_zip is both defined as an extension trait and as a method for sparse vector iterator,
ideally it should be the former.

Fixed in d060e263682aa6ebf1c9c8bb979f49cfe4b156b7


use eigvals(A), not eig(A)[1]

I just noticed this in the code; seems like an obvious improvement.

Thanks, just made the change with 679bbcf.