Add contributors license agreement

This PR introduces a Contributors License Agreement that will apply to all contributions to the python-crowd project. This is in line with various other open source projects (this particular CLA uses the language of the Ansible CLA).
Previously we've sought agreement from contributors to re-license the project under the BSD 2-clause license (see issue #11). I'm now asking prior contributors to agree to this CLA retroactively to their previous commits as well as future work. Note that the CLA applies in addition to the BSD 2-clause license.
If you agree then please add a comment to this issue stating so.
@ssbarnea @terinjokes @dansomething @lukecyca @akarnani
I haven't made changes to this project for a while in part due to the relation of my employment and the python-crowd module (and I feel bad about letting things slide this long). This CLA clarifies the status of contributions to this project, which helps resolve the complications in relation to my work but also in relation to the use of python-crowd (or forked works) in other projects.

LGTM (y)

Agreed

:+1:

:thumbsup:

Thanks all.


Kai/rebuild graphs interactivity

Rebuild the initial graph to compare Utah with both fast and slow/shrinking states, rather than starting off with a barchart with the breakdown of migration sources for Utah by itself.


chore: bump version to 0.1.2

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.54%. Comparing base (b851001) to head (4a1e3c4).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   99.54%   99.54%
=======================================
  Files           1        1
  Lines         660      660
=======================================
  Hits          657      657
  Misses          3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update README.md

Added many resources, corrected spelling errors, corrected a few resources.

Hmm, not sure why this PR failed. Any ideas?

Thanks for the additions!


buffer-from

buffer-from
https://www.npmjs.com/package/buffer-from?activeTab=readme

I am a bit hesitate about replacing this. This is a very lightweight package (less than 6 KiB), and it does prefer built-in native Buffer.from whenever possible.
We can replace this package, but for now I don't see if it is necessary.


Unable to handle arrays in searchParams

Hello there, I have a few questions about this great library:

Is it possible to handle arrays in searchParams? I tried searchParams.open({'filters[regions]': '1,2,3'}) but I get ?filters%5Bregions%5D%5B%5D=2%2C5%2C4%2C1, so when using decodeURI('?filters[regions][]=2%2C5%2C4%2C1') I get ?filters[regions][]=2%2C5%2C4%2C1
Also, its not possible to manage arrays like many sites/api do: filters[regions]=1&filters[regions]=2
How would you remove searchParams? for example I don't want persons=0 to be in the URL, I would remove the searchParam in that case

Thanks.

Send PR please if you know how to add it without bloating JS bundle (or you can copy-paste store and extend it for your needs, they are very simple inside, don't afraid to write your own)

Hi Andrey, thanks. I was confused because decodeURI doesn't do this but URLSearchParams.toString() yes:
https://github.com/nanostores/router/blob/83699283a01f319e080a97fb1f2eef6801af5349/index.js#L162C56-L162C56
Will do that!
Regards


JBPM-5552 - Remove the double border on subprocesses

@hasys mentioned subprocesses have a single border now - example image: http://imgur.com/a/Mg8Xl

+1


Underlying values of DWM_WINDOW_CORNER_PREFERENCE and its enumeration

Please provide the underlying values of DWM_WINDOW_CORNER_PREFERENCE and its enumeration; DWMWCP_DEFAULT, DWMWCP_DONOTROUND, DWMWCP_ROUND and DWMWCP_ROUNDSMALL so that we can call DwmSetWindowAttribute function with those values by P/Invoke.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6cd4ed11-b246-94af-c310-514326282eaf
Version Independent ID: 5a1dbf05-790d-525b-bcc6-01857c1687de
Content: Apply rounded corners in desktop apps - Windows apps
Content Source: hub/apps/desktop/modernize/apply-rounded-corners.md
Product: uwp
Technology: apps
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

This would be very helpful 👍

Documentation has been updated and linked.


[Footer] Subscribe

Implement subscribe functionality.

The request which happened when I added my own email was:
fetch("https://www.servicenow.com/bin/eloquaFormSubmit", {
  "headers": {
    "accept": "*/*",
    "content-type": "application/x-www-form-urlencoded; charset=UTF-8",
    "csrf-token": "undefined",
    "sec-ch-ua": "\"Chromium\";v=\"118\", \"Google Chrome\";v=\"118\", \"Not=A?Brand\";v=\"99\"",
    "sec-ch-ua-mobile": "?0",
    "sec-ch-ua-platform": "\"macOS\"",
    "x-requested-with": "XMLHttpRequest"
  },
  "referrer": "https://www.servicenow.com/blogs.html",
  "referrerPolicy": "strict-origin-when-cross-origin",
  "body": "postStringToMethod=elqSiteId%3D1133%26hiddenCampaignId%3D14498%26elqCustomerGUID%3D%26elqFormName%3DWS-OptIn-24April2018-Global%26pageurl%3D%2Fcontent%2Fservicenow%2Fwww%2Flocale-sites%2Fen-us%2Fnowforum-london%2Fupdates.html%26referenceSource%3D%26botcapture%3D%26email%3Dtuicu%40adobe.com%26hrefLang%3D%26AdobeIPaddress%3D&newsFeedFormType=newsFeed&newsFeedCampaignId=14498&analyticsdata=%7B%22timestamp%22%3A1697800500%2C%22userAgent%22%3A%22Mozilla%2F5.0+(Macintosh%3B+Intel+Mac+OS+X+10_15_7)+AppleWebKit%2F537.36+(KHTML%2C+like+Gecko)+Chrome%2F<IP_ADDRESS>+Safari%2F537.36%22%2C%22eVar5%22%3A%22%22%2C%22eVar6%22%3A%22%22%2C%22eVar11%22%3A%22%22%2C%22eVar23%22%3A%22%22%2C%22eVar24%22%3A%22%22%2C%22eVar25%22%3A%22%22%2C%22eVar26%22%3A%22%22%2C%22eVar85%22%3A%22bb7692ae-fe25-4251-867e-4f0e000a9b0d%22%2C%22eVar89%22%3A%22false%22%2C%22eVar114%22%3A%22MRT0012259_control%22%2C%22eVar115%22%3A%221%22%2C%22prop2%22%3A%22www.servicenow.com%2Fblogs.html%22%2C%22prop4%22%3A%22www.servicenow.com%2Fcommunity%2Fblogs%2Fct-p%2Fblogs%22%2C%22prop16%22%3A%22Official+ServiceNow+Blog+-+ServiceNow%3A%2Fblogs.html%22%2C%22prop29%22%3A%22www.servicenow.com%22%2C%22prop30%22%3A%22%2F%2F%22%2C%22prop36%22%3A%22no+referrer%22%2C%22server%22%3A%22www.servicenow.com%22%2C%22channel%22%3A%22%22%2C%22pageURL%22%3A%22https%3A%2F%2Fwww.servicenow.com%2Fblogs.html%22%2C%22pageName%22%3A%22%22%2C%22currencyCode%22%3A%22USD%22%2C%22linkType%22%3A0%2C%22linkName%22%3A0%2C%22eVar44%22%3A%22%22%2C%22eVar45%22%3A%22%22%2C%22eVar52%22%3A%22%22%2C%22eVar125%22%3Anull%2C%22eVar93%22%3A%22asserted%22%2C%22eVar94%22%3A%5B1%5D%7D&eloquaRefererUrl=",
  "method": "POST",
  "mode": "cors",
  "credentials": "omit"
});

might come with NaaS, so parked for the moment


vars are vars and consts are consts, and also new way to read/write big-endians. Closes #6

Now compiles with the last Zig development version (zig-network is alreeady up-to-date).

Thank you!


image regression demo/tutorial

Is your feature request related to a problem? Please describe.
would be great to have an image regression demo/tutorial (for example MR to CT conversion using MAE as loss function)
https://github.com/Project-MONAI/MONAI/discussions/1401

I would also be interested in this. I am currently trying to map 16-bit, noisy, low-resolution images to corresponding 16-bit, less-noisy, higher-resolution, same-size, 16-bit images size with an U-Net.
If I use a standard U-Net implementation (directly after Ronneberger et al., 2015), I get the expected output; however, if I use Monai's UNet I get bad results both in the dynamic range (-1.0...1.0 with the expected image background around 0.0, i.e. ~32,000 in 16 bit instead of <<1000) and in the quality of the reconstruction (very dotty appearance of the pixels, with neighboring pixels alternating between strongly negative and strongly positive values).
I am obviously doing something wrong, but I don't understand what.
Thanks!

I would also be interested in this. I am currently trying to map 16-bit, noisy, low-resolution images to corresponding 16-bit, less-noisy, higher-resolution, same-size, 16-bit images size with an U-Net.
If I use a standard U-Net implementation (directly after Ronneberger et al., 2015), I get the expected output; however, if I use Monai's UNet I get bad results both in the dynamic range (-1.0...1.0 with the expected image background around 0.0, i.e. ~32,000 in 16 bit instead of <<1000) and in the quality of the reconstruction (very dotty appearance of the pixels, with neighboring pixels alternating between strongly negative and strongly positive values).
I am obviously doing something wrong, but I don't understand what.
Thanks!

Hi aarpon,
I actually have exactly the same problem with dotty appearances and alternating pixel values. Have you figured out a solution yet? I'd love to use MONAI for image synthesis but haven't figured it out yet

I would also be interested in this. I am currently trying to map 16-bit, noisy, low-resolution images to corresponding 16-bit, less-noisy, higher-resolution, same-size, 16-bit images size with an U-Net.

If I use a standard U-Net implementation (directly after Ronneberger et al., 2015), I get the expected output; however, if I use Monai's UNet I get bad results both in the dynamic range (-1.0...1.0 with the expected image background around 0.0, i.e. ~32,000 in 16 bit instead of <<1000) and in the quality of the reconstruction (very dotty appearance of the pixels, with neighboring pixels alternating between strongly negative and strongly positive values).

I am obviously doing something wrong, but I don't understand what.

Thanks!

Hi aarpon,
I actually have exactly the same problem with dotty appearances and alternating pixel values. Have you figured out a solution yet? I'd love to use MONAI for image synthesis but haven't figured it out yet

As I said, I switched to another implementation of U-Net, that works better but still way worse than other approaches like CARE (Google: csbdeep). One difference is most likely the fact that CARE only uses patches where there is enough foreground signal, while so far I have been sampling randomly (and I have quite a lot of background in my images). But I don't believe that this is enough to explain the vast difference in results. I had to work on other things recently, but I will dedicate some time next week to look carefully into it. I will keep you posted.

perhaps could try the basic unet as well, it's less flexible but easier to config https://docs.monai.io/en/latest/networks.html#monai.networks.nets.BasicUNet

perhaps could try the basic unet as well, it's less flexible but easier to config https://docs.monai.io/en/latest/networks.html#monai.networks.nets.BasicUNet

Indeed, thanks! I will also try the basic U-Net.

Having such a tutorial would be really helpful. I have now heard of several people facing similar problems when trying to use Unets in MONAI for various image-to-image regression tasks.
As a starting point, a good simple demo could focus on image denoising with a UNet backbone. This could be done with a toy example synthetic dataset generated say by adding Gaussian noise to the MedNIST dataset. From a quick look at the default parameters of MONAI's UNets, I guess it would at least require moving away from instance normalization.
@wyli Would you be aware of anyone who could spend some time putting such a demo together?
There are also some related tutorial requests (e.g. #866) but are a bit more complex. I would thus vote to prioritise the easier denoising demo.

This is a great idea. MONAI Label would also benefit from this tutorial.
Another use case can be heatmap regression - like stage two of this multistage approach for vertebra segmentation.

Labels can be easily created from the ground truth segmentation

@rijobro Something spine related to what we're working on could fit here.

@rijobro Something spine related to what we're working on could fit here.

Agree with @ericspod!
FYI, a version of the multistage vertebra segmentation model is now working in MONAI Label. If you fetch the latest version, you should be able to test this model on the VerSe dataset:
monailabel start_server --app sample-apps/radiology --studies PATH_TO_IMAGES --conf models localization_spine,localization_vertebra,segmentation_vertebra
The second stage of this model (localization_vertebra) uses segmentation instead of regression. It'd be good to see how this performs with regression as well.

@diazandr3s Your first stage also uses segmentation rather than regression, right?

Yes, currently all stages are working and they use segmentation. It'd be nice to use regression for the second stage and see how that improves performance


An item being picked out of one snap-zone may be "stolen" by a different snap-zone

The scenario is as follows:

Two snap-zones A and B are fairly close
An object O is in snap-zone A
The player attempts to grab object O
Snap-zone A "drops" object O (so it can be picked up by the player)
Snap-zone B detects object O being dropped in its range, and immediately grabs it

The fix is probably for snap-zones to "defer" their attempted pick-up one frame to allow any direct-grabs to finish.

Pull request fixes the issue


fix: Add kustomize dependency to {cluster,kubevirt}-sync targets

What this PR does / why we need it:
This ensures kustomize is available when running the {cluster,kubevirt}-sync targets.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

None

/approve


FEAT-#5423: Add a NumPy API to Modin

What do these changes do?

[x] first commit message and PR title follow format outlined here

NOTE:  If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

[ ] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[ ] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[ ] signed commit with git commit -s
[ ] Resolves #5423
[ ] tests added and passing
[ ] module layout described at docs/development/architecture.rst is up-to-date

@RehanSD is this ready for reviewing, or should this be considered a draft?

Not yet - will mark as draft!

@vnlitvinov @devin-petersohn @noloerino would appreciate some insight regarding broadcast operations. Operations involving two 2-dimensional array that don't require broadcast follow pretty straightforwardly from Modin's QC code, but when we have a 1D object (object A) and a 2D object in a binary op, or a 2D object (with only one row) (object B) and a 2D object in a binary op, things get a little bit complicated, since we have to both understand the difference between object A and object B when displaying, but also when broadcasting - e.g. on add, object A and object B will broadcast the same, but on a dot product, they will not. I've included a preliminary approach to this in this PR, but would love folks' insight on this. We're also partially blocked here by #5529 .
Some examples:
In [1]: import numpy as np

In [2]: arr = np.array([-1, 0, 1])

In [3]: matrix = np.array([[1, 2, 3], [4, 5, 6]])

In [4]: arr @ matrix
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Input In [4], in <cell line: 1>()
----> 1 arr @ matrix

ValueError: matmul: Input operand 1 has a mismatch in its core dimension 0, with gufunc signature (n?,k),(k,m?)->(n?,m?) (size 2 is different from 3)

In [5]: matrix @ arr
Out[5]: array([2, 2])

In [6]: arr * matrix
Out[6]:
array([[-1,  0,  3],
       [-4,  0,  6]])

In [7]: arr = np.array([arr])

In [8]: arr @ matrix
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Input In [8], in <cell line: 1>()
----> 1 arr @ matrix

ValueError: matmul: Input operand 1 has a mismatch in its core dimension 0, with gufunc signature (n?,k),(k,m?)->(n?,m?) (size 2 is different from 3)

In [9]: matrix @ arr
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Input In [9], in <cell line: 1>()
----> 1 matrix @ arr

ValueError: matmul: Input operand 1 has a mismatch in its core dimension 0, with gufunc signature (n?,k),(k,m?)->(n?,m?) (size 1 is different from 3)

In [10]: arr * matrix
Out[10]:
array([[-1,  0,  3],
       [-4,  0,  6]])

In [11]: arr + matrix
Out[11]:
array([[0, 2, 4],
       [3, 5, 7]])

In [12]: np.array(arr[0]) + matrix
Out[12]:
array([[0, 2, 4],
       [3, 5, 7]])

I guess my two questions are:

Is this something we want to tackle now, or should the prototype just assume we're broadcasting with nice shapes (i.e. only 1D objects and 2D objects, and no nested 1D objects)
What do folks' think of this approach? This is a modified version of @noloerino's approach here for context.

It seems like the actual numpy broadcasting rules (here) are not actually that complicated, especially since our arrays are never going to have more than 2 dimensions.  The 2D -> 1D nested array example you give ([1, 2, 3] vs. [[1, 2, 3]]) would be covered by the case of the last dimension matching, as first array has shape (3,) and the second has shape (1, 3). I imagine we wouldn't support any further nested arrays.
That said, if the pandas query compiler implementation of broadcasting rules isn't working, then it might be worthwhile to just get the simplest cases working from within the numpy frontend prototype, before circling back to make a more robust fix.

@RehanSD, don't we want to have a new hierarchy of the objects for NumPy API (NumPy API, NumpyQC, NumpyOnSmthDataframe, NumpyOnSmthPartitionManager, NumpyOnSmthDataframePartitions)?

@RehanSD, don't we want to have a new hierarchy of the objects for NumPy API (NumPy API, NumpyQC, NumpyOnSmthDataframe, NumpyOnSmthPartitionManager, NumpyOnSmthDataframePartitions)?

Not right now - for now, we'd like to try an API Layer that can use any backend query compiler, so we can hopefully get a bunch of NumPy functionality just based off of the existing QC functionality we have!

@RehanSD, I think we should add the inner layers anyway as, otherwise, that would be kind of incorrect in terms of the logic. The users would use NumPy API but the storage format is pandas, for instance. It looks confusing.

@RehanSD, if we do not want to add the inner layers right now, it seems to me that we should add some notes regarding the execution/processing to the docs.

@RehanSD, if we do not want to add the inner layers right now, it seems to me that we should add some notes regarding the execution/processing to the docs.

That is valid point, as some discussions on implementing NumPy API were "behind the scenes", and some of the reviewers lack the context.

wouldn't it be simpler to just implement __array_ufunc__ and maybe __array_function__?

Thank you @jbrockmendel - this is a good point - I'll do some digging into this!

More or less LGTM. A few unresolved comments are left from my side. Please respond on them.


Update workflow

Issues associated with this PR
Your PR should present related issues you want to solve.
Solutions
You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result.
Code Style

Make sure Goimports has run
Show Golint result

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ad1c7e8). Click here to learn what that means.
The diff coverage is 6.59%.

@@            Coverage Diff            @@
##             master    #1379   +/-   ##
=========================================
  Coverage          ?   56.37%
=========================================
  Files             ?      333
  Lines             ?    26932
  Branches          ?        0
=========================================
  Hits              ?    15183
  Misses            ?    10051
  Partials          ?     1698

Impacted Files
Coverage Δ

pkg/mosn/starter.go
34.43% <0.00%> (ø)

pkg/network/connpool.go
33.33% <ø> (ø)

pkg/server/reconfigure.go
0.00% <0.00%> (ø)

pkg/stream/http/connpool.go
30.06% <0.00%> (ø)

pkg/stream/http2/connpool.go
1.98% <0.00%> (ø)

pkg/stream/xprotocol/connpool_binding.go
0.00% <0.00%> (ø)

pkg/stream/xprotocol/connpool_multiplex.go
0.00% <0.00%> (ø)

pkg/stream/xprotocol/connpool_pingpong.go
0.00% <0.00%> (ø)

pkg/types/network.go
0.00% <ø> (ø)

pkg/upstream/cluster/host.go
45.45% <0.00%> (ø)

... and 341 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad1c7e8...b6b35ad. Read the comment docs.


How to Ignoring one or more fields

Hi.
How can I ignore one or more specific columns when I use this library?
Thanks

Hello @alishmki ,
What do you mean, you want to attach entities but ignore some column? What will be the desired behavior on SaveChanges?
I believe the final answer will be a no but let check first your requirement to be sure.
Best Regards,
Jonathan

Hello @alishmki ,
Thank you for your code. I will try to check during the weekend if something similar already exists or can be implemented.
I will try to get back to you for next Monday.
Best Regards,
Jonathan

@alishmki
GraphDiff sends a complete graph to be updated back to the the database. This is because it handles only disconnected graphs and therefore state management cannot be used on the property level.
If you entity as an Id property you can do:
If (entity.Id == 0)    entity.InsertedDate = DateTime.Now;
So that only new entities will have their InsertedDate set.
@JonathanMagnan
There is currently no support for excluding properties from being ignored in updates.

Hello @cryo75 , thank you for this additional info.
You are right, they are currently no way to doing it.

@alishmki , I took some time this weekend and made some progress.
I can easily ignore some property, not exactly with the code you provided but this is currently possible.
One problem with the solution used is ignored property took the value from the database.
It's something that could work for you?
If we take your example, that will mean the property InsertedDate no matter if you modified it or not will now contain the original value of the database. Since you don't want to have this property in a modified state, I believe it makes some sense.
Best Regards,
Jonathan

Hello @alishmki ,
Could you let us know if that's a solution that will work for you?
Best Regards,
Jonathan


Workbenches recipe editing? (for modpack/server makers)

title kinda explains all
would be neat for alot

Hey, we recently moved repository; would you be so kind to create this feature request here?


Unable to find Community edition installer for Windows

Hello,
I navigated to the site as mentioned and landed at the following site
https://boosty.to/wunjo
But unable to find any installer download link on the page

Hi. I updated the Community Edition code yesterday and have not yet built the installers. To build the installer, I need to rent a virtual machine with Windows, so I will do that later. However, you have three options: I recorded a video on how to build the installer or app, or you try now Pro version with full functionality (7 days trial and cost for a year by price the cup of coffee), or download the installers of version 1.6.


Unable to set REQUEST_URI after getting REQUEST_URI

Laravel Version: 6.2
PHP Version: 7.3
Database Driver & Version: N/A

Description:
I believe this is a caching bug related to modifying the REQUEST_URI. If I use any of the request getter functions to query the REQUEST_URI, such as $request->server->get() it seems to prevent the setters from working, e.g. $request->server->set('REQUEST_URI', "test").
Steps To Reproduce:
I have the following middleware, which works as I want (which I specify in app\Http\Kernel.php):
<?php

namespace App\Http\Middleware;

use Closure;

class Localize
{
    public function handle($request, Closure $next)
    {
        if(substr($_SERVER['REQUEST_URI'], 0, 4 ) === "/es/" || $_SERVER['REQUEST_URI'] === "/es")
        {
            $request->server->set('REQUEST_URI', substr($_SERVER['REQUEST_URI'], 4));
            app()->setLocale('es');
        }
        return $next($request);
    }
}

This middleware checks to see if the REQUEST_URI begins with /es, if so it removes that portion of the REQUEST_URI and changes the locale before continuing on to the routing in web.php.
Notice that I am using PHP $_SERVER['REQUEST_URI'] to query the value of the REQUEST_URI.
If I modify that code to instead use any kind of $request call to a getter method, such as $request->server->get() before I call $request->server->set(), the setter seems to no longer modify the REQUEST_URI as expected for purposes of routing in web.php.
I'm guessing that $request does some sort of caching that is triggered when you use a getter, and doesn't recache as I expect when using a subsequent setter.

This is a little too much magic going on here I think. I have no idea how this would even work with routes already loaded into the router let alone route caching.

Here is an alternative way of doing it. An example is using Lumen, but you can apply it with a little changes.
`<?php
namespace App\Http\Middleware;
use Closure;
use Illuminate\Http\Request;
class SetLocale
{
public function handle($request, Closure $next, $guard = null)
{
$lang = substr($request->path(), 0, 2);
if (in_array($lang, ['es'])) {
config(['app.locale' => $lang]);
$proxy = Request::create(
substr($request->path(), 3),
$request->method(),
$request->all()
);
return app()->dispatch($proxy);
}
  return $next($request);
}

}
`


Anywhere symbol attribute

Reviewer checklist

[ ] Test coverage: stack test --coverage
[ ] Public API documentation: stack haddock
[ ] Style conformance: stylish-haskell

@virgil-serbanuta You're right, actually: the overloaded constructors are marked anywhere because the overloading axioms are considered "anywhere" rules. The frontend should be marking the overloaded symbols injective; the proper fix is there.

@virgil-serbanuta This is ready for re-review. I'm keeping the anywhere attribute, but it no longer implies injective. We won't use it for anything yet, but I'd hate to throw this away.


feat: add size_of

Feature Request
I want to propose adding a size_of function to the language that would return the storage slot size of a specific type.
When writing StorageAccess implementations for custom types, it would be great to programmatically get a value for the offset for use in storage_address_from_base_and_offset instead of hardcoding it. This is a Starknet specific request, I'm not sure if it would be valuable for pure Cairo.
An example:
struct Point {
    x: u32,
    y: u32
}

struct Size {
    width: u32,
    height: u32
}

struct Rect {
    origin: Point,
    size: Size
}

let origin = Point { x: 0_u32, y: 0_u32 };
let square = Rect { origin , size: Size { width: 30_u32, height: 30_u32 } };

assert(origin.x.size_of() == 1_usize, 'u32 size 1');
assert(origin.size_of() == 2_usize, 'point size 2');
assert(square.size_of() == 4_usize, 'rect size 4');

// alternatively
assert(size_of(square) == 4_usize, 'rect size 4');
assert(Rect::size_of() == 4_usize, 'rect size 4');

I'm not sure we really want this - as this depends on the size of the underlying system.
Currently we are felt252 based - but we can be just as well felt64 based.
what is the size of felt252 then?
it is 1 in the current system - but it is 4 on the new system.

Isn't the whole purpose of sizeof precisely to deal with changing memory unit sizes depending on compilation target?
I think a slightly more complicated design of sizeof could still work in context of the issue described by @orizi: first, the layout of a memory segment over which sizeof is applied has to be described.
struct Point {
    x: felt252,
    y: felt252,
}

let layout252 = Layout::felt252();
assert(layout252.sizeof::<Point>() == 2_usize, "felt252");

let layout64 = Layout::felt64();
assert(layout64.sizeof::<Point>() == 8_usize, "felt64");

This is kinda similar to Rust's std::alloc::Layout

@mkaput The idea is that we don't assume the Cairo1 will get recompiled. We want the generated sierra to be felxible, and work for both.
Another problem with this request IMO is that what you want is not really the size of the object. You want the size of its serialization to felt252. I believe the right way to do this, is just to serialize it.

We want the generated sierra to be felxible, and work for both.

Ah, that makes sense! Indeed, in this case, the most straightforward thing would be to do the serialization.
Performance-wise, I do though see a possibility to define a libfunc that would return the size 🤔 In that scenario, the Sierra code will still be independent of target architecture


Removing viewBox breaks scaling in  tag.

If the viewBox is removed the svg does not maintain aspect ratio if used as source for an HTML <img> tag.
This problem exist at least in Chrome and Firefox.
Therefore I think the removeViewBox plugin should be disabled by default.
Test here: https://codepen.io/Huulivoide/pen/NzPKoM

if so, id also add a warning about this in the readme

If you use a PNG file, it will be scaled as well. In other context (e.g. element background) SVG behaves as expected, so it's just an edge case due to wrong <img> element size. Probably, a bug in browsers.

On the second thought it's not a bug, just width and height attributes have no effect in that context. It just behaves if they are absent, since only the sizes of <img> taken in account.

This is because the preserveAspectRatio attribute defaults to "preserve" aspect ratio mode, if viewBox is defined. If no viewBox is defined then preserveAspectRatio attribute is ignored, be it defined or not.
So removing viewBox attrribute also has the side effect of modifying the implied value of the preserveAspectRatio attribute.
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/preserveAspectRatio

Yeah, but usually intrinsic size from attributes width and height are in use, but it's ignored in this specific case. SVGO don't know how image will be used, that's why it is highly configurable. It has to bear reasonable balance between optimization and “safety”, so default options are usually ok, but not 100% fits to everyone. Otherwise, many optimization in 90%+ cases should be enabled manually, which is not user friendly.

It is illogical for an optimization to modify the end result and thus create an unpredictable and unexpected output. When the viewBox attribute is present on an SVG tag it has a specific meaning that defines how that svg is to be displayed and rendered. Removing the attribute changes the render behavior of the SVG

If you'd use a PNG file, it will be scaled as well. In other context (e.g. element background) SVG behaves as expected, so it's just an edge case due to wrong  element size. Probably, a bug in browsers.

We aren't using PNG files, we are using SVG files which use the viewBox to instruct the browser render engine to render the SVG in a specific manner.

Yeah, but usually intrinsic size from attributes width and height are in use, but it's ignored in this specific case. SVGO don't know how image will be used, that's why it is highly configurable. It has to bear reasonable balance between optimization and “safety”, so default options are usually ok, but not 100% fits to everyone. Otherwise, many optimization in 90%+ cases should be enabled manually, which is not user friendly.

It seems to me that the safer option is to not remove such a key attribute when it comes to a render engine rendering the SVG. "Saftey" is not removing critical render instructions from an element in the name of optimization!


lambdarank

Any examples on the setup (query/group) for lambdarank with R ? Can't seem to get this right after much trying ...

@quadpartisan
when you create a lgb.Dataset class, you can pass parameter group to specific your group data.


Rename ThirdPartyNotices to ThirdPartyNotices.md

Docs Build status updates of commit 88c3999:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

ThirdPartyNotices.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


proxy access logs

prerequisite for https://github.com/kuzzleio/kuzzle-proxy/pull/44

This PR implements the new connection registration needed for the access logs.
unrelated / boyscouting
The dummy mode seems useless and is removed.

Current coverage is 100% (diff: 100%)

Merging #8 into master will increase coverage by 1.33%

@@             master    #8   diff @@
=====================================
  Files             1     1
  Lines            75    69     -6
  Methods          13    13
  Messages          0     0
  Branches         12    13     +1
=====================================
- Hits             74    69     -5
+ Misses            1     0     -1
  Partials          0     0

Powered by Codecov. Last update 4b6efcc...f2018d8


interphase and mitotic microtubule nucleation PMID:19001497

Interphase (cytoplasmic) microtubules, can be nucleated from the cytoplasm, or from the SPB.
There are mutants where 'cytoplasmic microtubule nucleation" is abolished, BUT   interphase  microtubules are present in the cytoplasm, because they
"These intranuclear MTs eventually escape into the cytoplasm, acting as progenitors of essentially all cytoplasmic MTs in the mutant cells and forming abnormal MT bundles that often curve around the cell tips"
Also, cytoplasmic (astral) microtubules exist after during mitosis?
so not all cytoplasmic microtubules are interphase microtubules.
Soo....I think we need to make
NTR abnormal interphase microtubule nucleation from cytoplasm
--NTR abnormal interphase microtubule nucleation from iMTOC
--NTR abnormal interphase astral microtubule nucleation (def include: occurs from cytoplasmic side of SPB)
plus "abolished" and "decreased" for all
and
"NTR abnormal/abolished astral microtubule nucleation"
--NTR abnormal interphase astral microtubule nucleation (def include: occurs from cytoplasmic side of SPB)
--NTR abnormal mitotic astral microtubule nucleation (def include: occurs from cytoplasmic side of SPB)

"interphase cytoplasmic microtubule nucleation" might be better wording?

It's going to help a lot if you can define what is and isn't covered by "interphase microtubule".
If some astral microtubules hang around after mitosis, then either (a) "interphase microtubule" includes those astral microtubules, or (b) "interphase microtubule" doesn't simply mean "a microtubule that exists during interphase".

I will need to check what people refer to as interphase microtubules.
@jvhayles do you know? I  can ask Ken...

I have altered the above request a little.
We should probably stop calling them "interphase  microtubules". This can be a related synonym.
We should refer to "cytoplasmic microtubules during interphase" .  But "Interphase cytoplasmic microtubules" can't NOT include  the cytoplasmic microtubules  generated from astral microtubules.
Does this help:
Only a small number of cytoplasmic MTs are present at any given time in fission yeast (Hoog et al., 2007), and these can be imaged by expressing GFP-tubulin at physiological concentrations. During interphase, MTs are nucleated not only from the spindle pole body  but also from several interphase microtubule organizing centre ‘satellite’ particles (iMTOCs) present on the nuclear envelope, in the cytoplasm and on MTs themselves. During late mitosis, cytoplasmic astral MTs analogous to those seen in budding yeast are nucleated from the duplicated SPBs.

OK, I think the existing terms can all be adjusted without much pain to "cytoplasmic microtubules [or microtubule nucleation] during interphase" - def text will need editing too, but that should be straightforward. I may have time to look at it properly tomorrow.

and would this be OK for the new terms?
abnormal cytoplasmic microtubule nucleation during mitotic interphase
-- abnormal microtubule nucleation from iMTOC [is "during mitotic interphase" needed in the name for this one?]
-- abnormal astral microtubule nucleation during mitotic interphase
and
abnormal astral microtubule nucleation
-- abnormal astral microtubule nucleation during mitotic interphase
-- abnormal astral microtubule nucleation during mitosis

Don't worry if it needs to wait until you get back...
Above looks perfect. No need for during interphase from iMTOC .....

Listing ALL the precise terms I need for annotation of this paper
rename
FYPO:0004619	cytoplasmic microtubules nucleated from equatorial microtubule organizing center absent from cell
to
abolished microtubule nucleation from eMTOC?
NTR: abolished astral microtubule nucleation during mitosis
NTR: normal cytoplasmic microtubule nucleation from the SPB during interphase
NTR abolished microtubule nucleation from the iMTOC (these are interphase cytoplasmic but this should be implicit from therm)
NTR: normal protein localzation to mitotic SPB
NTR: abolished protein localization to eMTOC
NTR: abolished protein localization to iMTOC
NTR: decreased mitotic SPB oscillation
NTR decreased cytoplasmic microtubule nucleation during interphase (not sure which MTOC)
NTR: abolished cytoplasmic microtubule nucleation
NTR: abolished cytoplasmic microtubule nucleation from the SPB  during interphase
I think that's it. Phew!

new terms
abnormal microtubule nucleation FYPO:0005692
abolished cytoplasmic microtubule nucleation FYPO:0005693
decreased cytoplasmic microtubule nucleation during mitotic interphase FYPO:0005694
abolished astral microtubule nucleation during mitosis FYPO:0005695
abolished cytoplasmic microtubule nucleation from interphase microtubule organizing center FYPO:0005696
abolished cytoplasmic microtubule nucleation from spindle pole body during mitotic interphase FYPO:0005697
abolished microtubule nucleation from equatorial microtubule organizing center FYPO:0005698
normal cytoplasmic microtubule nucleation from spindle pole body during mitotic interphase FYPO:0005699
abolished protein localization to equatorial microtubule organizing center FYPO:0005700
abolished protein localization to interphase microtubule organizing center FYPO:0005701
abnormal protein localization to microtubule organizing center FYPO:0005702
renamed existing terms from using "interphase microtubule" to "microtubule [x] during mitotic interphase"; adjusted defs accordingly
edit file: 11877ed76fce9ae9583da5947f28b4c5e4ee6c6c
release: db5d4e543f7f6dbe443a927feaedadd5e3158917


Restructuring the codebase

As discussed previously, we have a pretty flat API at the moment.
One proposal would be to split it based on the problems:
- linear
    - initializer.py
    - problem.py
    - solver.py
    - output.py  # not sure if necessary, can be in `solver.py`
    - barycenter.py  # contains both continuous and discrete barycenters
    - math
        - implicit_diff.py
        - momentum.py
    - low_rank
        - initializer.py
        - solver.py
        - output.py
- quadratic  # same as above, except no `low_rank/math`
- nn  # alt. would be to have `ott/linear/nn` or `ott/nn/linear`, though might be too deep
    - neuraldual.py
    - icnn.py
    - layers.py
- math
    - decomposition.py
    - fixpoint_iter.py
    - matrix_square_root.py
- utils
    - dataclasses.py
    - segment.py
- geometry
    - geometry.py
    - point_cloud.py
    - low_rank.py
    - grid.py
    - graph.py
    - epsilon.py  # not sure
    - costs.py  # we could also split them in separate files in `costs/`, but imho not necessary

Or alternatively as:
- problems
    - linear
        - problem.py
        - discrete_barycenter.py
        - continuous_barycenter.py
    - quadratic
        - problem.py
        - gw_barycenter.py
    - something for `nn` traning?
- solvers
    - linear
        - sinkhorn.py  # would also contain the output
        - sinkhorn_lr.py
    - quadratic
        - gromov_wasserstein.py
    - nn
        - neuraldual.py
        - icnn.py
        - layers.py
- initializers
    - linear
    - quadratic
    - nn
# same as above
- geometry
- utils
- math
- geometry

TBD: tools, esp. gaussians, see #124.
My personal preference is to go with something which resembles the 2nd suggestion, but would appreciate comments from both @marcocuturi @ersisimou .

I also prefer the second interface, because we might start seeing a wider variety of problems (more exotic cost functions) and we would not want to start a folder at the base level for each of them.

I am also in favor of the second interface. I think the separation in problems and solvers gives a very clear structure.


text mode renderer is extremely slow

the slowdown in my program was actually caused by calling the loop instructions over and over without delay


Django template support?

Heysir...
This doesn't seem to be compatible with django templates o.O

However, it works fine if it's "pure" html? Maybe the django tags are messing it up perchance

You need to add something like this in your configuration:
htmx = function ()
    local opts = {
        filetypes = { "html", "htmldjango" }
    }
    require("lspconfig").htmx.setup(opts)
end

That didn't work for me... :/

Maybe share how your config looks like, where you setup your LSP

this is a vim specific issue.  please review the documentation to see how to make LSPs trigger for specific file types.


Shared folder tree checks not being adhered to

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

When using a shared folder where there may be some files that have compression issues, encoding issues, etc., I wait until the browser tells me what file is causing a PIL issue and I uncheck the checkbox for that file. However, rerunning the task still attempts to process the file. This isn't always the case, but does happen sometimes.
Expected Behaviour
Unchecking the checkbox next to a file which PIL is unable to process, then clicking Submit, should rerun the task but exclude that file.
Current Behaviour
Unchecking the checkbox next to a file name does not (always) remove the file from the queue process, and so the same file is constantly being queued and then failing.
Error: PIL.UnidentifiedImageError: cannot identify image file "/home/django/share/bourbon/baker's/30F7E9B8CDD03FE52CBE4106228550399E43C564.jpeg"
Possible Solution
I'm confused why this isn't already a feature, but it would be nice if these failures were simply flagged, and at the end a report of the failures was shown. That way the task could finish processing and gives the user the chance to decide what to do. The shared folder I'm trying to process is 13G in size (dataset/categories/brands/images), so it's untenable for me to wait till a file fails, uncheck it and then rerun the task. Hence the idea ofd a report instead of just quitting the job.
On that note it's not your job to make sure my images are all valid, so I'll write a PIL script to pre-validate and report on errors.
Steps to Reproduce (for bugs)

Create a shared path folder
Create a sub-structure in the form root->subfolder->subfolder->images, where you know some of the images are invalid
Create a task which uses the shared folder, and select all of the images (see attached image)
Run the task to create the queue job
When it fails, uncheck the checkbox next to the failed file
Run the task again

Context
I have a dataset that contains 7 folders, each of those contain between 80 and 140 subfolders, and each of those contain approx. 150 images each. I'm looking for a solution that allows me to annotate that much data (>100k images). This will be the backend for a new mobile app my team is creating.
 No
Operating System and version (e.g. Linux, Windows, MacOS): Linux
Code example or link to GitHub repo or gist to reproduce problem:
Docker 'up' command: docker compose -f docker-compose.yml -f docker-compose.dev.yml -f docker-compose.override.yml up -d
Other diagnostic information / logs:

Logs from cvat_worker_default container (just the relevant part)
2023-01-23 22:48:22,404 DEBG 'rqworker_default_1' stderr output:
[2023-01-23 22:48:22,404] INFO cvat.server: create task #14

2023-01-23 22:48:22,405 DEBG 'rqworker_default_1' stderr output:
INFO:cvat.server:create task #14

2023-01-23 22:48:24,846 DEBG 'rqworker_default_1' stderr output:
DEBUG:rq.worker:Handling failed execution of job /api/tasks/14

2023-01-23 22:48:24,885 DEBG 'rqworker_default_1' stderr output:
ERROR:rq.worker:Traceback (most recent call last):
  File "/opt/venv/lib/python3.8/site-packages/rq/worker.py", line 936, in perform_job
    rv = job.perform()
  File "/opt/venv/lib/python3.8/site-packages/rq/job.py", line 684, in perform
    self._result = self._execute()
  File "/opt/venv/lib/python3.8/site-packages/rq/job.py", line 690, in _execute
    return self.func(*self.args, **self.kwargs)
  File "/usr/lib/python3.8/contextlib.py", line 75, in inner
    return func(*args, **kwds)
  File "/home/django/cvat/apps/engine/task.py", line 610, in _create_thread
    manifest.create()
  File "/home/django/utils/dataset_manifest/core.py", line 339, in wrapper
    func(self, *args,  **kwargs)
  File "/home/django/utils/dataset_manifest/core.py", line 605, in create
    self._write_core_part(manifest_file, obj, _tqdm)
  File "/home/django/utils/dataset_manifest/core.py", line 593, in _write_core_part
    for image_properties in iterable_obj:
  File "/home/django/utils/dataset_manifest/core.py", line 196, in __iter__
    img = Image.open(image, mode='r')
  File "/opt/venv/lib/python3.8/site-packages/PIL/Image.py", line 3186, in open
    raise UnidentifiedImageError(
PIL.UnidentifiedImageError: cannot identify image file "/home/django/share/bourbon/baker's/5F168A392BEFDCCA758CB53F03B91F3BB4768592.jpeg"
Traceback (most recent call last):
  File "/opt/venv/lib/python3.8/site-packages/rq/worker.py", line 936, in perform_job
    rv = job.perform()
  File "/opt/venv/lib/python3.8/site-packages/rq/job.py", line 684, in perform
    self._result = self._execute()
  File "/opt/venv/lib/python3.8/site-packages/rq/job.py", line 690, in _execute
    return self.func(*self.args, **self.kwargs)
  File "/usr/lib/python3.8/contextlib.py", line 75, in inner
    return func(*args, **kwds)
  File "/home/django/cvat/apps/engine/task.py", line 610, in _create_thread
    manifest.create()
  File "/home/django/utils/dataset_manifest/core.py", line 339, in wrapper
    func(self, *args,  **kwargs)
  File "/home/django/utils/dataset_manifest/core.py", line 605, in create
    self._write_core_part(manifest_file, obj, _tqdm)
  File "/home/django/utils/dataset_manifest/core.py", line 593, in _write_core_part
    for image_properties in iterable_obj:
  File "/home/django/utils/dataset_manifest/core.py", line 196, in __iter__
    img = Image.open(image, mode='r')
  File "/opt/venv/lib/python3.8/site-packages/PIL/Image.py", line 3186, in open
    raise UnidentifiedImageError(
PIL.UnidentifiedImageError: cannot identify image file "/home/django/share/bourbon/baker's/5F168A392BEFDCCA758CB53F03B91F3BB4768592.jpeg"

2023-01-23 22:48:24,886 DEBG 'rqworker_default_1' stderr output:
DEBUG:rq.worker:Invoking exception handler <function rq_handler at 0x7fd16dd415e0>

Showing outer folder structure

Showing inner folder structure

Showing that the failing file has already been uncheck, yet it was still processed

On the last image, I had checked and unchecked that file multiple times (no console errors) but it was still included in the job.
Thanks - love the software

This simple script reported my failing files in ~30sec, so after I've removed them I'll try again
import os
import pathlib
from PIL import Image, UnidentifiedImageError

walk_dir = '/Users/paul.allsopp/Projects/beverage_classifier/dataset'
img = ''

for root, subdir, files in os.walk(walk_dir):
    for filename in files:
        file_path = os.path.join(root, filename)
        if pathlib.Path(file_path).suffix in ['.jpg', '.jpeg', '.png']:
            try:
                img = Image.open(file_path, 'r')
            except UnidentifiedImageError as err:
                print("Failed to open " + file_path + "\n")
            finally:
                img.close()

print("We are done!")

I couldn't reproduce this, on either 2.3.0 or the current development version. Is this still an issue for you?


Fix clippy::use_self in Xilem Core

All fixes except for removing the expects are results from cargo fix.


Unit-Based Evidence

Currently "resources" are stored globally for the database, and specific resources can only be assigned to a classroom.  They all share the same numbering the same order.
But ideally...

sets of resources can be defined for a unit, e.g. "Wetlands Unit" vs "Climate Change Unit" might use different sets of resources.
the set of resources can be ordered for each unit
the sets of resources can be moved across databases to other servers
a unit should have a name
resources can be repeated among different units (it might be easier management-wise though if they are simply copied)?

See also theRAPTLab/meme-2023#54, theRAPTLab/meme-2023#53

I'd add that it'd be nice to easily edit / share / update individual units on a server / instance?


Added the feature of see faq answer on hover

Issue #161
Demo Video
https://github.com/user-attachments/assets/d90863a1-593c-4768-b340-0f365e83245f

@Utsavladia add better animations and effects, on hover,
it' looking quite basic.

@4darsh-Dev
Its same as before just the functionality is added
I can add if you want .. could you elaborate on what you need the hover effect

@Utsavladia

adjust the box-shadow property to a better look
currently, faq section opens up by clicking button only, add this to the whole question container for a better user exp.
make smoother transition

@4darsh-Dev
Fixed the trnasition to smooth and shadow to whole question-answer
https://github.com/user-attachments/assets/cdbc5410-9217-470f-9e82-bc6fcce496b0

GSSoC 24 has been completed Finally'
It was a great experience working with you all
Thanks💗 for your valuable contributions!
PA nomination has been started, Do fill out the forms soon. Share your experiences and let's connect on socials


Feature request: Add support for ESLint Javascript linter

Would be nice if optionally ESLint could be used instead of JSHint.

The primary reason ESLint was created was to allow developers to create their own linting rules. ESLint is designed to have all rules completely pluggable. The default rules are written just like any plugin rules would be. They can all follow the same pattern, both for the rules themselves as well as tests. While ESLint will ship with some built-in rules to make it useful from the start, you'll be able to dynamically load rules at any point in time.

http://eslint.org/docs/about/

+1

:+1:

:+1:

:+1:
It has much nicer support for ES6, and JSX. It also actually parses the code using espree, which is actively maintained.

:+1:

We're very much aware that eslint is requested, and it is in our backlog. I'm locking this issue to avoid more :+1:'s

Is anyone interested in writing an ESLint service similar to https://github.com/thoughtbot/hound-scss and https://github.com/thoughtbot/hound-go? Now that we've nailed down the architecture we'd happily accept PRs for additional linters or languages.
We could support something like this in .hound.yml:
javascript:
  enabled: true
  linter: eslint

I noticed Bootstrap switched from JSHint to ESLint in their v4 branch: http://blog.getbootstrap.com/2015/08/19/bootstrap-4-alpha/

Actually looks like it uses both ESLint and JSCS.

@salbertson I think you may have it now (written by yourselves?) https://github.com/thoughtbot/hound-eslint
We're using your paid-for hosted hound service, and would love to get this activated. Any idea when it might be fired up?

Hi @hlascelles, It is indeed written by us. We're testing it out internally first to see if there are any kinks before rolling out a public beta. Which should happen soon. We'll get back to you once it does

@teoljungberg we'd also like to be involved in the public beta, for our medium sized code base at IDAGIO.com

@miksago Glad to hear you're excited. Since it's a public beta, anyone can use it once we get there.

@teoljungberg well, in that case, consider us up for the private beta too :P

@teoljungberg I'd also love to beta test ESLint with our hound account :tada:

+1

We're still testing out the ESLint linter, and noticed a few kinks in it, which we now are working on. We're really close to getting it done. So stay tuned.

Thx for the update @teoljungberg. Looking forward to this :) Take all the time you need.

I've got some exciting news for all of you who have waited for ESLint support - it is now in beta!
If you want to try it out, please head over to https://houndci.com/configuration#eslint and see how to enable it.
Please contact us at<EMAIL_ADDRESS>if you have any questions or feedback.
Happy linting!

Awesome! Thanks @teoljungberg


deploy svg for editor

Reference Issue

Should we just use the icon that's in shared-assets in the first place? Would that have avoided this bug? I'm thinking we should refactor our repo to put all assets in shared-assets for this reason, because it's a bit confusing as is.

Should we just use the icon that's in shared-assets in the first place? Would that have avoided this bug? I'm thinking we should refactor our repo to put all assets in shared-assets for this reason, because it's a bit confusing as is.

Should we just use the icon that's in shared-assets in the first place? Would that have avoided this bug? I'm thinking we should refactor our repo to put all assets in shared-assets for this reason, because it's a bit confusing as is.

The icon that's in shared assets is a png. I could put the svg I need into shared assets, and then use it?

Should we just use the icon that's in shared-assets in the first place? Would that have avoided this bug? I'm thinking we should refactor our repo to put all assets in shared-assets for this reason, because it's a bit confusing as is.

The icon that's in shared assets is a png. I could put the svg I need into shared assets, and then use it?

The icon that's in shared assets is a png. I could put the svg I need into shared assets, and then use it?

Yes, sounds good. Is that SVG used anywhere else? Would be nice to consolidate.

The icon that's in shared assets is a png. I could put the svg I need into shared assets, and then use it?

Yes, sounds good. Is that SVG used anywhere else? Would be nice to consolidate.


fix: improve typings

Sunce buyProduct and requestPurchase wrap the same native calls, they should resolve with same type of promise.
And subscriptions are now strongly typed.

@doomsower Sorry I've not meant to close this but just giving an opinion. As I've written in issue, I'll consider this when I am available.


Deciding on how much detailed locations of events will be

We need to decide on this.
Here is how the Project Description mentions:

(...) Moreover, the application should support location-based search. For example, user should be able to filter the events in a city or district.

And here what's written in the Requirements:

<IP_ADDRESS>.1.1 They shall be able to make location-based filtering.

It's better if we set some fields and decide how we can handle this.

I think in order to support location search, city and district are enough. (il ve ilçe) In addition to these fields, we might need to work together with frontend and Android to learn which API they're going to use and which fields we have to support. If everyone is OK for city and district, I'll close this issue and open a new one assigned to frontend and Android.

We can continue location discussion from #77...


teuthology/suite/run.py: Improve ScheduleFail exception

As per: https://github.com/ceph/pulpito-ng/pull/23

Improve teuthology-schedule exceptions  by utilizing  ScheduleFail and GitError
make teuthology.suite.main return job_count such that teuthology-api and Pulpito-ng can use it.
edit teuthology.sh & start.sh such that we -x earlier for better output when watching the docker-compose do it's thing.

Fixes: https://tracker.ceph.com/issues/64820

integration test failed:
Warning: RNING]: Skipping Galaxy server https://galaxy.ansible.com./ Got an unexpected
86.80 error when getting available versions of collection amazon.aws: Unknown error
86.80 when attempting to call Galaxy at 'https://galaxy.ansible.com/api/':
86.80 'CustomHTTPSConnection' object has no attribute 'cert_file'.
86.80 'CustomHTTPSConnection' object has no attribute 'cert_file'
86.80 ERROR! Unknown error when attempting to call Galaxy at 'https://galaxy.ansible.com/api/': 'CustomHTTPSConnection' object has no attribute 'cert_file'. 'CustomHTTPSConnection' object has no attribute 'cert_file'
------
Dockerfile:22
--------------------
  21 |     COPY requirements.txt requirements.yml ansible.cfg bootstrap /teuthology/
  22 | >>> RUN \
  23 | >>>     cd /teuthology && \
  24 | >>>     mkdir ../archive_dir && \
  25 | >>>     mkdir log && \
  26 | >>>     chmod +x /teuthology/bootstrap && \
  27 | >>>     PIP_INSTALL_FLAGS="-r requirements.txt" ./bootstrap
  28 |     COPY . /teuthology
--------------------
ERROR: failed to solve: process "/bin/sh -c cd /teuthology &&     mkdir ../archive_dir &&     mkdir log &&     chmod +x /teuthology/bootstrap &&     PIP_INSTALL_FLAGS=\"-r requirements.txt\" ./bootstrap" did not complete successfully: exit code: 1
Service 'teuthology' failed to build : Build failed

jenkins retest this please


fix: vendor hexoid until v2 is released

Problem:
The v1.0.0 release of hexoid is incompatible with webpack.
main.js
require('formidable');

webpack.config.js
module.exports = {
	target: 'node',
	entry: './main.js',
	optimization: {
		minimize: false
	}
}

Output:
/home/icholy/src/playground/hexoid-webpack/dist/main.js:1381
const toHexoId = hexoid(25);
                 ^

TypeError: hexoid is not a function
    at 211 (/home/icholy/src/playground/hexoid-webpack/dist/main.js:1381:18)
    at __webpack_require__ (/home/icholy/src/playground/hexoid-webpack/dist/main.js:2121:41)
    at /home/icholy/src/playground/hexoid-webpack/dist/main.js:2158:1
    at Object.<anonymous> (/home/icholy/src/playground/hexoid-webpack/dist/main.js:2160:12)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12)
    at node:internal/main/run_main_module:28:49

Root Cause:
Webpack prefers the module entry over the main entry in package.json by default, but hexoid exports incompatible APIs between the commonjs & esm modules. The esm module uses a default export which is not equivalent to the module.exports assignment in the commonjs module.
Solution 1:
The hexoid repo has fixed the inconsistency in their master branch, but haven't published a release in 4 years. I've requested a v2 be published with the new exports. Once this happens, we can upgrade to that: https://github.com/lukeed/hexoid/issues/7
Solution 2:
In the meantime, I propose that we vendor the hexoid code as a helper function.

Would be a great addition, the hexoid issue is very annoying with webpack. @GrosSacASac thoughts?

@mobeigi there's a simpler work-around:
module.exports = {
	// ...
	resolve: {
		alias: {
			hexoid: path.resolve(__dirname, 'node_modules/hexoid/dist/index.js'),
		},
	}
};

@icholy That approach gives me build warnings when doing a production next.js build (although I am using latest canary builds etc). The patch approach does not. Ideally though your PR is merged in and this solves the problem easily for everyone. 🙏

https://github.com/lukeed/hexoid/issues/7 v2 of hexoid has been released.

Closing in favor of https://github.com/node-formidable/formidable/issues/981


Error in lorri-keep-env-hack-*.drv when shellHook returns non-zero

The following shell.nix works with nix-shell but doesn't work with lorri for the reason stated in the title above.
(import <nixpkgs> {}).stdenv.mkDerivation {
  name = "shell";
  shellHook = ''
    echo foo
    $(exit 1)
  '';
}

lorri watch yields:
[...]
            "these derivations will be built:",
            "  /nix/store/bq4f2as76d9hxvsz7afghn27n7lx8fwk-lorri-keep-env-hack-shell.drv",
            "building \'/nix/store/bq4f2as76d9hxvsz7afghn27n7lx8fwk-lorri-keep-env-hack-shell.drv\'...",
            "foo",
            "builder for \'/nix/store/bq4f2as76d9hxvsz7afghn27n7lx8fwk-lorri-keep-env-hack-shell.drv\' failed with exit code 1",
            "error: build of \'/nix/store/bq4f2as76d9hxvsz7afghn27n7lx8fwk-lorri-keep-env-hack-shell.drv\' failed",
        ],
    },
)

Hi @haslersn!
$ nix-shell
foo
$ echo $?
1

The exit code of nix-shell is 1, i.e. it indicates failure - and rightly so. I'm not sure exactly what you mean by "works with nix-shell" in this context.
I appreciate the minimal repro shell.nix, but is there a real-world use case that would help us understand the problem better? It seems to me that both lorri and nix-shell should fail is the shell hook fails (i.e. returns a non-zero exit code), which they do.
Perhaps the issue is that the error message

build of '/nix/store/bq4f2as76d9hxvsz7afghn27n7lx8fwk-lorri-keep-env-hack-shell.drv' failed

could be more specific?

Hi @haslersn!
$ nix-shell
foo
$ echo $?
1

The exit code of nix-shell is 1, i.e. it indicates failure - and rightly so.

No. That's not the exit code of nix-shell, because nix-shell has not even terminated yet. It's just the exit code of the shellHook.
I had a use case where lorri didn't work in our project because of this bug.
nix-shell allows shellHook with exit code 1 and I understand lorri as a nix-shell replacememt.

nix-build runs set +e before running the shell hook; lorri currently does not.
https://github.com/NixOS/nix/blob/2.3.1/src/nix-build/nix-build.cc#L422

Bump for https://github.com/target/lorri/issues/95

I would like to close this issue in favour of https://github.com/target/lorri/issues/273, which is more actionable. See https://github.com/target/lorri/pull/265 for a discussion of why we don't want to ignore command failures in shellHook in lorri.


Rewrite GameException to provide better verbose and use

Done in https://github.com/Esentiel/dx3d/commit/740ee66fd78ddb7f89bdfeb0365cee1150fd51e9


Can tflite model maker be used to train MobileNet models?

Issue type
Support
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
2.8
Custom code
Yes
OS platform and distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
Can tflite model maker  be used to train MobileNetv1 or MobileNetv2 models?I know It can be used to train efficientdet_lite model.
Standalone code to reproduce the issue
Can tflite model maker  be used to train MobileNetv1 or MobileNetv2 models?I know It can be used to train efficientdet_lite model.

Relevant log output
No response

@sawantkumar I tried MediaPipe Model Maker.But I meet some issues, like:https://github.com/google-ai-edge/mediapipe/issues/5557, https://github.com/google-ai-edge/mediapipe-samples/issues/432

Hi, @pkgoogle
Please take look into this issue. Thank you

Hi @libofei2004, you will have to resolve the mediapipe issues as tflite-model-maker isn't working right now.


Bump azdataGraph version to 0.0.31

This PR adds functionality to collapse and expand execution plan nodes to Azure Data Studio

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 2 (50.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.002%) to 42.406%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/executionPlan/browser/azdataGraphView.ts
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/sql/workbench/services/connection/browser/connectionDialogWidget.ts
1
71.43%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
28422

Relevant Lines:
62564

💛  - Coveralls


Resonate CLI reference

We need a published CLI reference.
Currently someone must traverse all the commands using --help to identify all possible behaviours.
A published CLI reference would make it far easier to get a sense of the full scope of functionality.
Additionally we can then link to it from the docs.

MVP CLI reference is available here: https://docs.resonatehq.io/operate/cli-reference/


Import in Java

This is more of an Issue that I am facing and this is probably not an issue on your side. I was wondering why the import would not work for this project. When i try to import in eclipse, it tells me no projects found in import so overall I cannot import any of the files needed to begin my implementation. Any idea on how I can get around this?

Nvm got it to work.

Good to hear. Opening the pom.xml file, having a working Maven environment, should do the trick!


Render sprites in pipeline to control draw order

Did some smaller modifications, mostly for reusing float arrays instead of creating new ones each update.

@GordonTombola Thanks for the help making this a lot better!


Add enableBootDiagnostics field to Azure cloud spec

What this PR does / why we need it:
Boot diagnostics are nice because you can see the console logs if things go wrong and you cannot SSH into your VM for whatever reason. That can be useful for our development, but I imagine users who face stability issues with their Azure VMs might also want to enable this setting.
Azure enables this setting by default on VMs created via the portal, so it seems a good idea to at least provide a setting for this.
Which issue(s) this PR fixes:

Fixes #1291
What type of PR is this?
/kind feature
/kind api-change
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

Add `enableBootDiagnostics` field to Azure cloud spec to enable boot diagnostics on managed storage account

Documentation:

NONE

/retest


confused about packages

In my understanding, this tool exists to compose components, as indicated at various point in the readme. However, this tool only refers to "packages" without ever defining what that is. Looking into the code it seems like everything is a "package" (and not a component). I understood "package" as purely a WIT concept to disambiguate references, but this doesn't seem to be what is meant here (because it makes no sense to me to "compose" them).
Can someone either document what a package is, or point me to an existing documentation?

package is a Wit keyword that is used to name a component. It is the name a component would be published to a registry.
You can think of them meaning the same thing.

I thought a world (within a defined package) names a component.

Worlds describe a concrete component and are the basis of bindings generation.^1

Can't a single package contain multiple worlds, and thus name various components?

You can think of a world as a template for creating one or more components. Represents the shape of a component, with its imports and exports. A component that conforms to that world template would "target" that world.
You can have a Wit package that defines multiple worlds. Each one of those can be used as a template for creating components ("targeting" that world).
So think of a package as a name for a Wasm component binary that could be published to a registry.
But Wasm component binaries could just be type info and represent a "Wit package". Or it could be something that has logic (one or more core Wasm modules) and be executed, which could be called a "component package".

I see. Then if I compose two packages which only contain type information, representing WIT packages, what does it mean to compose or plug these? In my high level understanding, composing means eliminating an imported interface of some component by an exported interface of another component. This is probably not accurate enough, as it only makes sense for component binaries containing logic.

Composition and wac is for working with component implementations.
If you'd like to create a new Wit package and import other types from another Wit package, see the use and include keywords.


Usernames with special characters mean user settings can't be accessed or updated

ConfigMap keys must be confined to the regex [-._a-zA-Z0-9]+
Usernames in OKD/openshift can have special characters such as @ (e.g. when provisioned through SSO, etc.)
kubevirt-user-settings is stored by username, and as such, errors occur accessing/updating settings when the logged-in user has non-confirming characters in their name.
e.g. the following request off to the API...
[{"op":"replace","path":"/data/me@example.com","value":"{\"quickStart\":{\"dontShowWelcomeModal\":true}}"}]

response
{
  "kind": "Status",
  "apiVersion": "v1",
  "metadata": {},
  "status": "Failure",
  "message": "ConfigMap \"kubevirt-user-settings\" is invalid<EMAIL_ADDRESS>Invalid value<EMAIL_ADDRESS>a valid config key must consist of alphanumeric characters, '-', '_' or '.' (e.g. 'key.name',  or 'KEY_NAME',  or 'key-name', regex used for validation is '[-._a-zA-Z0-9]+')",
  "reason": "Invalid",
  "details": {
    "name": "kubevirt-user-settings",
    "kind": "ConfigMap",
    "causes": [
      {
        "reason": "FieldValueInvalid",
        "message": "Invalid value<EMAIL_ADDRESS>a valid config key must consist of alphanumeric characters, '-', '_' or '.' (e.g. 'key.name',  or 'KEY_NAME',  or 'key-name', regex used for validation is '[-._a-zA-Z0-9]+')",
        "field"<EMAIL_ADDRESS>      }
    ]
  },
  "code": 422
}

I'm not sure if the console has access to the uid of the user object but that is alphanumeric, otherwise potentially usernames could be escaped prior to any setting operations?

Hi @GingerGeek thanks for opening the issue.
This have been fixed here. Can you please share which version you are using?

Hi,
I use Kubevirt via the HCO deployment on OKD.
The image of the console plugin pod is quay.io/kubevirt-ui/kubevirt-plugin@sha256:e79027973b09aac75860f267c7d7f830599978c38a081001f404b9a1c3d2990f which is still the latest image tagged with quay.io/kubevirt-ui/kubevirt-plugin:v4.14.0 - dated Sep 11th 2023. I can see there was a cherry pick back to the 4.14 branch, but I'm guessing this didn't seep through to the quay images and HCO operator?
Let me know if there's anything I can do to collaborate!

I think we should create a new tag on github to update the quay image with the latest 4.14
@metalice do you think is safe to create it from the HEAD of 4.14?

@upalatucci yes we should

there is quay.io/kubevirt-ui/kubevirt-plugin:v4.14.3 - closing this issue


Starting teleport by script

In my game the teleport charges up when holding the grip button and will teleport when you release the grip button. How do I start the teleport on grip release?

Also is this the right place to ask this?

To enable the teleporter to work it just needs to receive a destination marker event.
How are you determining where the destination for the teleport should be? E.g. pointing a pointer at the ground where you want to teleport to.

I'm using a bezier pointer. Also in case it makes a difference, I'm using dash instead of teleport.

The way the pointers set the destination is based on a VRTK_ControllerEvents parameter called pointerSetButton but at the moment the button aliases all work on button down.
I'll look to add in an option so you can set an alias as 'button up' as well then you'll just be able to change the pointerSetButton to grip up

Awesome thanks!

Actually looking at the code the pointer set event is thrown when the button is released anyway.
So if you just change the Pointer Set Alias in the VRTK_ControllerEvents script that is on the controller to Grip then you will teleport when you release the grip button.
However, this may not achieve what you're hoping for because the Pointer Set Event will be emitted straight away when you release. so a simple click of the grip will initiate a teleport.

Looking at the code again, having "on button up" for pointer aliases doesn't make sense either.
The pointer alias is checking the state of a button for whether it's being pressed or not, so having "grab" on button up wouldn't make much sense.
I think i'm going to revert the title of this ticket and not implement the button up for aliases.

Sorry for your time, the problem was on my end.
My problem now is how do I only activate the pointer at certain times and then deactivate it after teleporting? Right now I've just set the beamActive bool to public and set that to true after the grip has been held long enough, then false after it has been let go. Doing so causes the beam to stay there after the teleport until I teleport again, so essentially I can walk around and look at the beam from when I teleported. Is there a better way to do this?

This is more of a general question rather than an issue with VRTK. this is probably better off asked in the slack channel at http://invite.vrtk.io

Alright sorry, thanks.


postfix: Only accept mail for the local host

Otherwise, mails meant for another @hashbang.sh user are not dispatched to mail.#! but delivered locally.
This makes the assumption that mail.#! rewrites recipients to user@host.#!, which is implemented in https://github.com/hashbang/docker-postfix/pull/5
As such, this depends on https://github.com/hashbang/docker-postfix/pull/5 being deployed.

MX part deployed.


Loom Icons Missing

Icons for banner patterns don't render.
Steps to reproduce:
use a loom with a banner and dye of choice.
I am using the Quilt version of this mod thus I don't know if this happens on The Fabric version.

Can you illustrate (ideally with a screenshot and your latestl.log) what problem exactly you're after? I haven't been able to reproduce anything similar during my testing
Cheers

Since this issue has now been stale for many months, I'll go ahead and close it. Should the problem persist with the latest releases, please go ahead and reopen it
Cheers


Service interruption after several days

Hello,
I've experienced service interruption twice after several days have passed (~12 days). Checking some logs I've seen that this interruption lasted more than one minute so in terms of reliability this is a big impact on Event-based services, being the case.
Is this an expected behavior or something are you working on?
Thanks in advance,
I.

Hi Isaac, what version of LavinMQ are you running? Do you know the cause of the interruption?

Also, are you using CloudAMQP or are you hosting independently?

If you are currently utilizing CloudAMQP to host your service, it's important to carefully consider the plan that your service is operating on. We advise against using shared plans such as Lemming or Ermine for production services, as the performance can vary and unexpected interruptions may occur during server maintenance. It's possible that you may have experienced downtime due to a recent version upgrade.
If you're looking for better reliability and stability, we recommend upgrading to a dedicated server. With a dedicated server, maintenance activities can be scheduled according to your preferences, leading to better predictability and fewer disruptions to your service.

Hi, Christina,
Yes, you're right, I'm testing on a shared plan, so based on what you said and the info you have on the website, these interruptions are expected behavior. Sorry I haven't get it before opening the issue.
I'll close the issue and will check another plan for production purposes.
Thanks so much,
I.


Problems with tracking pixel in javascript static site generators

I really like tracking pixel feature of Shynet.
I tried to use it in vue based static site generator (Gridsome).
It works similar to SPA. There is no full page load which cause problem with caching.

I tried to solve it by appending url with query parameter but it caused new problem.
Tracking pixel with query parameter is blocked by uBlock

Finally I solve it by adding new url in Shynet to accept random number inside tracking pixel address.
      path(
          "<service_uuid>/random/<random_number>/pixel.gif",
          ingress.PixelView.as_view(),
          name="endpoint_pixel_random",
      ),

Is there a better solution?
Should I create PR with this new url?

I think it isn't typical shynet use case so i'm closing this issue.


Handle NOTICEs in isFromChannel and isFromUser

I don't know what these methods were originally intended to do as it is
not clear whether the word message in the function documentation
refers to PRIVMSGs or IRC server messages in general.
I personally use these two methods to figure out if a IRC messages was
sent from a user or channel and if so map it to the channel specified in
event.Params[0]. For this use case it would be nice if NOTICEs would
be treated the same way as they are automatically mapped to the correct
channel/user as well then.

@lrstanley I don't want to bother you but just in case you missed this: Do you have any opinion on the changes purposed here?


Throw a useful logging message when connection to redis failed.

+1. This just bit me while trying to test Authelia on my stack.

This is done with #89


Hex Sequence Search fails to find any results after searching for non-present sequence then changing search value to a valid sequence

Describe the bug
Occasionally, when searching for a sequence of bytes in hex, if your very first search fails it will cause all following searches that keep the first byte (possibly others) in the search value box to also fail even if the resulting sequence is valid.
To Reproduce
Steps to reproduce the behavior (not very reliably - seems semi-random):

Open the Search Memory dialogue (close and re-open if already open)
Enter a sequence of bytes in hex that are not present in the file, in my case 88 20 happened to not be present (I used the steam version of the game executable for Total Annihilation, Totala.exe)
Observe no matches (correct behaviour)
Without touching the first byte, edit the search value to a valid sequence (88 13 in my case)
Observe no matches (incorrect behaviour)

Expected behavior
Any time a sequence is searched, it should find any that are valid.
Screenshots

Attachments
I will provide the exe this occured with if requested.
Environment (please complete the following information):

OS: Windows 10
Java Version: 17.0.9
Ghidra Version: 11.0.1
Ghidra Origin: Github release

Additional context
This is really quite odd as it seems very inconsistent and the method above has so far been the most reliable way to reproduce it, but so far only this one example of exe, sequences and search order have caused it (I tested a few other cases but they didn't seem to trigger this behaviour).
Either i'm inadvertently gaslighting myself and somehow managing to repeatedly do something very silly without noticing it, or this bug is rare/random/relies on variables I have yet to control for.

I wasn't able to reproduce this behavior by following your given steps.  If you are able to reproduce it, can you maybe do a screen recording so we can see if we notice anything that stands out?
When it is in the failing state, does clicking the "Search All" button also not show the result?


Resetting ul and li inside of nav element

When using the nav element, ul and li are generally custom styled and does not need default margin or padding. Suggesting to remove the padding and margin on ul and li items inside of nav element.
I can't really think of an instance where the nav tag is used for a generic ul.
Also added a postinstall script so that the /dist files are automatically generated when npm install is ran.

Hey there, thanks for the work, but you need to follow the contributing guide, so I'll close this one for now.

Sorry about that. I totally missed the initial paragraph to discuss the issue first. Should I open an issue or email you for discussion or can we discuss here?

The best thing is to create an issue. I get what you're saying about the nav, but fencing list resets on elements with class attributes actually gives more flexibility, so I'll keep it that way 👍


Fix multiple VHD overlapping mount bug LCOW

Every VHD that is mounted inside a container must be mounted in the UVM first. When different containers mount the different VHDs, a unique mount path (unique inside the UVM) should be generated for each such VHD. Existing mount code generates such unique paths but those paths are unique only across the container. Hence, two different VHDs mounted by two different containers will have unique path inside their own container world but can have the same path inside the UVM. Due to this the second mount will end up mounting over the existing mount of the first container.
This change fixes the bug to generate such unique mount paths across the UVM instead of just keeping them unique to the container.

Great job on the PR description and comments, btw!


Use proper lighthouse extends feature to provide headless flag by default

@ChristopherPHolder pls add the details we just discovered

This PR could help us to solve some struggles with headless mode: https://github.com/GoogleChrome/lighthouse/pull/14419


feat: trimming 1 byte from compressed repr of Point

It's possible to trim 1 more byte from compressed repr of a Point.

#7505  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on  Graphite


drivers: flash: nrf_qspi_nor: remove multithreading dependency

Replace semaphores with an atomic ready flag when used without multithreading enabled.
DNM until dependent PR is merged:

[x] #28679

Fixes #26372
Tested manually on samples/drivers/spi_flash and samples/subsys/fs/littlefs.

#28679 is now merged.

@de-nordic @nvlsianpu or @anangl mind helping out with a minor review here?

Is someone stepping up to support CONFIG_MULTITHREADING=n? I'm confused about us adding support for something we will than just remove after v2.5.0 is released.

@galak This is part of a series of trials to assess the feasibility of supporting CONFIG_MULTITHREADING=n.  #28679 passed its trial, because #8393 was agreed to still be a bug and bugs should be fixed.
For CONFIG_MULTITHREADING=n to be useful the normal expectation for the flash subsystem must be that it will work.  Then #26372 is a bug, as it was when originally reported; so this fixes a bug, and should be reviewed and merged.
If attempts to make CONFIG_MULTITHREADING=n work in drivers where it doesn't are not reviewed or not merged because CONFIG_MULTITHREADING=n is deprecated then from my perspective it's already gone.  Any idea that it can be made to work in a topic branch that's merged when the entire problem is solved is, IMO, unrealistic.

For CONFIG_MULTITHREADING=n to be useful the normal expectation for the flash subsystem must be that it will work. Then #26372 is a bug, as it was when originally reported; so this fixes a bug, and should be reviewed and merged.

I agree with @pabigot that as long as CONFIG_MULTITHREADING=n is still there, this PR is valid bug fix that should get processed.

Even if  CONFIG_MULTITHREADING=n will be removed we can still consider multithreading with one thread only application, for which we can cut-out multithreading synchronization primitives like semaphores.

Is someone stepping up to support CONFIG_MULTITHREADING=n? I'm confused about us adding support for something we will than just remove after v2.5.0 is released.

@galak This is part of a series of trials to assess the feasibility of supporting CONFIG_MULTITHREADING=n. #28679 passed its trial, because #8393 was agreed to still be a bug and bugs should be fixed.
For CONFIG_MULTITHREADING=n to be useful the normal expectation for the flash subsystem must be that it will work. Then #26372 is a bug, as it was when originally reported; so this fixes a bug, and should be reviewed and merged.
If attempts to make CONFIG_MULTITHREADING=n work in drivers where it doesn't are not reviewed or not merged because CONFIG_MULTITHREADING=n is deprecated then from my perspective it's already gone. Any idea that it can be made to work in a topic branch that's merged when the entire problem is solved is, IMO, unrealistic.

@pabigot @galak
IMHO the right policy lies somewhere in these lines:

we shall always accept bug fixes for reported bugs, even for deprecated features.
no need to have a topic branch (that is, no need to reject having incremental patches towards "fixing" single-threading mode), as long as the incremental patches do not impact the normal (multi-threaded) mode. So they could be easily removed if we finally decide to remove the feature. In this particular case, I am not against having a topic branch, but don't see is a a requirement.
for any of the above, we do not need commitment from a person/company to maintain the single-threaded mode. If we don't find a maintainer by the deadline, we are going to remove the feature, as voted.


Fix type system logic for detecting if a type param can match itself.

This PR fixes type system logic for detecting if a type param can match itself.
For example, this snippet doesn't compile with current ponyc master, but should:
trait val T[A: T[A]]

class val C1 is T[C1]
class val C2 is T[C2]

primitive Foo[A: (T[A] val & (C1 | C2)) = U64]
  fun apply(a: (A | None)): Bool =>
    match a
    | let _: A => true
    else false
    end

actor Main
  new create(env: Env) =>
    env.out.print(Foo[C1](C1).string())
    env.out.print(Foo[C1](None).string())

Note that this breaks a few methods in Iter that are actually capability-unsafe, so we have to figure out what to do about that. I'm marking as "DO NOT MERGE" and "needs discussion during sync" so we can discuss this aspect.
This may be related to #2584, but I don't think it has the same problem as @Praetonus' solution in #2597. Note that my code example above doesn't have the issue of None being a possible subtype of A. As such, I don't think we have to wait for @Praetonus' RFC to merge this. Still, I'll ask @Praetonus to comment here if he can.
This may also be related to #2646, which had a runtime segfault in Iter.filter_stateful, one of the methods found to be unsafe by this type system fix.

The filter_stateful, filter_map_stateful, filter, filter_map, skip_while, and take_while methods will need to have their return types changed from Iter[X]^ to Iter[X!]^. The current return types are unsafe and impossible to implement correctly on a generic Iter[A], since a predicate {(A): B} cannot be given the result of Iter[A].next().

@jemc the example given now compiles with ponyc master. Do we still need this? Should I spend time getting this capable of passing CI and not have conflicts? Or should we close it?

@jemc and I discussed, I will open a PR with just the regression test in test/libponyc/matchtype.cc added. If it passes CI as expected, then we will merge the new PR and close this. Otherwise, Joe and I regroup.


Help with configuring DefectDojo over HTTPS for docker-compose

Hi,
I need some help w.r.t configuring docker based DefectDojo over https, right now I'm using it at default 8080 port.
Can someone please help me it, that how to do that in docker-compose for DefectDojo.

Hi @bilalk88 ; this PR does it https://github.com/DefectDojo/django-DefectDojo/pull/1581
Is it helping?

@ptrovatelli : thanks for the response. I'm working on it. Once done will update you.

@ptrovatelli Hi, i did changes as per the documentation. I want to run it on port 443 but I'm getting an error .
nginx_1         | 2019/10/17 09:30:38 [emerg] 1#1: bind() to <IP_ADDRESS>:443 failed (13: Permission denied)
nginx_1         | nginx: [emerg] bind() to <IP_ADDRESS>:443 failed (13: Permission denied)

This type of "issue" (request for help) is certainly better suited for Slack, and not a github issue.

This seems like a firewall issue more than anything , the idea is to have nginx's whatever port bound to the host's 443 port , which requires some level of administrative rights on the host machine .

@bilalk88 you need to be root to run a service that listens on port 443 (which is in range 1-1023). by default nginx runs as non-root user. I you really want to use port 443, it may be enough to remove that from Dockerfile.nginx and rebuild, although i haven't tried:
USER 1001
Else you can use a port >1023 and run as non-root.

and you'd need also to be root in the host

Thank you guyz for the tips.


Syntax error; won't compile

When I try to build erlang-katana as part of a rebar dependency for apns4erl, using OTP version R16B03, I get the following error:
deps/katana/src/ktn_recipe.erl:185: syntax error before: '{'
deps/katana/src/ktn_recipe.erl:9: function verify/1 undefined
ERROR: compile failed while processing deps/katana: rebar_abort

Ah, I need OTP 17 or later. Didn't realize that was map syntax in there.


Doesn`t change values in js after change to other .env file

Hello there.
After i run build (in xcode or terminal like ENVFILE=.env.secondconf) GeneratedDotEnv had recompiled, info.plist get new values but in js all still same like before by .env.firstconf
One more time: all work without change to other .env file.

Same here, i was able to make it re-linking and re-building with the variables i was going to use, but anyway, i need to do that every time i update my .env

Same here. Env file does not change

How can i solve this problem?????


Add JSON button to trace page

Well, since the "privileged minority" hasn't done it yet, I figured I would since I keep finding that I need it. :)

Shows prettified JSON in modal dialog
Fixes #1060

I'm very new to the various frameworks that the UI is using, so I'm open to suggestions if there's anything that I did that was a bit wonky.

I had some comments; otherwise, great work!

Thanks for the effort and review folks. This is very popular!

Thanks for the comments, I'll address these tonight or tomorrow.

Comments addressed.

running it locally and will merge (and release) after!

I've got another set of changes coming too dealing with better error messages, just testing it now.

ah ok thx for the heads-up. this is a different PR, right?

Yep. Different PR.

fyi here are some screen shots:

is json raw or merged?

The JSON should be whatever was retrieved from the call to /api/v1/traces/XXX, as it's the same object.

@yurishkuro you have this feature already.. do you default to raw json? any thoughts about what the default should be?

@adriancole  we added two buttons, raw and regular json, as both come in handy. But we just have them as plain links to json documents, not popups, and we leave pretty rendering to browser plugin. That way it's easy to search inside the json, and do a Save As.

interesting. search works fine with the pop-up, but save-as doesn't. It is
a common support case... @virtuald https://github.com/virtuald thoughts
on save-as etc?

Here's a thought. you can add a save or download link to the pop-up. this could point to /api/v1/trace/id for example.

+1 for adriancole's suggestion!

I added a save icon, and also the ability to right click on the JSON button and do a save as (as that's an intuitive option anyways).

Otherwise, LGTM! ship it

yay json button!


Update knative/pkg to v0.23 and k8s.io to v0.20.7

Changes
Bump k8s.io and knative dependencies to v0.20.7 and v0.23.0 respectively, taking latest fixes and features in.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Docs included if any changes are user facing
[ ] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes
Bump k8s.io and knative dependencies to v0.20.7 and v0.23.0 respectively, taking latest fixes and features in.

It looks like this has regenerated openapi / swagger specs with new package names (they've dropped the github.com/ prefix).
Otherwise the dep updates look good to me.

It looks like this has regenerated openapi / swagger specs with new package names (they've dropped the github.com/ prefix).

Arg, all the time it hits me..

/retest

/retest
The build job is green but reporting red.. and the other one seems to be a flaky cluster provisionning...

/retest

/approve

/lgtm

/lgtm


Changed token object name to api_token.

I'm testing the basic authentication with basic token and I'm seeing errors like so below:
2019-06-25T13:09:40.232Z	807fc98a-bb25-48a1-9e40-423d5d4215fe	Error: Missing 'api_token' property.
at new module.exports (/var/task/node_modules/jira-connector/index.js:194:23)
at module.exports.jiratest (/var/task/handler.js:22:14)
I checked the code and it is indeed looking for 'api_token' instead of 'token'
Theres two ways to change this, either change the code or change the readme, I chose the easier route.

Very cool, thank you very much for the corrections.


Make README generic.

Minor cleanups in the lemming README.
 * (M) README.md
  - reference a generically "OpenConfig compliant" device rather than a particular
    operator's requirements.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.517%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
380

Relevant Lines:
580

💛  - Coveralls


BetterRTP and EssentialsX conflicts

Plugin Version:

Version 3.6.12
Describe The Bug:

Hello, I have a small issue with BetterRTP and Essentials' /back feature. After respawning, the plugin should RTP immediately instead of waiting for a few milisec then RTP. This issue prevents players from teleporting to their previous death location and from teleporting back to the world's spawn point (0.500/70/-15.5).
How To Reproduce:

Enable RTPOnDeath function.
Dies (by mob, or just use the /kill command).
The plugin will RTP you to a random location.
Use /back
Back to world's spawnpoint, not previous death location.

Expected Behavior:

Essentials' /back command working normally.
Screenshots/Error Log:

No logs.
Additional Context:

None.

Hi, the essentials plugin is meant for basic servers looking to quickly add a bunch of tools to their server with little setup or customizability. If you need better and more polished functionality, you should look into replacing essentials with a better plugin which solves your problem. It's not up to other plugins to fix the limitations of essentials.


[sd-gauge-less-vote-boost] Add veSDT boost for MS

Fixes : Add veSDT boost for MS

Looks like there are few open proposals at https://snapshot.org/#/sdfxs.eth it is better to wait until these proposals to be closed


Round 8 - Scan a Barcode - Change Name of Button in Food Added Popup

After the user scans a barcode and taps Add to Consumption, a popup box comes up.  Change the button on the left from View Summary to "View Daily Intake Report".  Also change case of FOOD ADDED to "Food Added".

Fixed


Filesystem abstraction for all file related services

This is the summary thread for replacing the current implementation with Filesystem. It all started in #209 (thanks to @jonnyynnoj). Partly for the proxy, work has already been done (details in #221). Things to do:

[ ] add Filesystem abstration to PackageManager
[ ] remove Storage interface
[ ] add Filesystem abstraction to security scanner logic
[ ] remeber to use streams instead of strings
[ ] create example configuration for S3 and other popular storage options

Hi @akondas I would be interested in developing this, is there a way to break down the work here? Seems like a lot of changes for one single MR.
I still didn't dive deep into the code, but wouldn't it be okay for a first iteration to keep the Storage contract and implement the features regarding Filesystem abstraction "under the hood" (e.g. by creating a new implementation of type S3 for Storage).
Please let me know how I can help. I want to deploy this to a Kubernetes cluster and would love to have the storage totally separate from the instance running the application and I would also like to avoid shared volumes.

Hi @pedro-stanaka, you can start with PackageManager and replace Filesystem, AtomicFile and other file related things.
Initially, we started by dividing the storage into a private part and a proxy, but since it can be easily done with directories (this is what it is done now), I would see that there is one filesystem for everything with an appropriate adapter (for example s3).

I believe this is now closed, right?

I believe this is now closed, right?

Yes, will be preparing a release, we only need to add examples to the documentation.

Yes, will be preparing a release, we only need to add examples to the documentation.

Thanks for your help :beers:

Thanks for your help :beers: