unciv: 3.12.13-patch1 -> 3.12.14

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yairm210/Unciv/releases.
meta.description for unciv is: "An open-source Android/Desktop remake of Civ V"
meta.homepage for unciv is: "https://github.com/yairm210/Unciv"
meta.changelog for unciv is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

directory tree listing: https://gist.github.com/69259891145f705061ef91b86f7534ad

du listing: https://gist.github.com/fef9bde748b7e8dfed43d54ea3b420d8

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
unciv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/nr1irz8544pr050vxna9971bm8b789h0-unciv-3.12.14 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unciv https://github.com/r-ryantm/nixpkgs/archive/8a5e196040845e14e36ee8642c9c1b64f4e4fece.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/nr1irz8544pr050vxna9971bm8b789h0-unciv-3.12.14
ls -la /nix/store/nr1irz8544pr050vxna9971bm8b789h0-unciv-3.12.14/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

unciv

Maintainer pings
cc @tex for testing.

Result of nixpkgs-review pr 112841 run on x86_64-linux 1

1 package built:

unciv


Fix 400 Bad Request on Mute/Ban with > 1024 char reason.

Issue #651 was caused by:

Moderation log embed sent to the channel after mute/ban.
The fields being limited to 1024 chars.

This turns out to be an easy fix. Commits in the moderation route have been reverted.
Fixes #651.

We should probably just error here if it's too big, thoughts?

We should probably just error here if it's too big, thoughts?

Realistically, d.py should just truncate it to the 1024 max but it doesn't. Just erroring would probably cause more issues/frustration, since the mute wouldn't be applied.

Although...a better idea would be truncating the reason if > 1024 entirely instead of in the embeds.


Switching to far branches repeats too much work

If the assembler bails out because of of insufficient branch range, the whole pipeline is restarted in far branch mode, including rebuilding the flow graph and optimization passes. It should be sufficient to restart only the code generation.

This is a compile time improvement not performance of generated code.

https://dart-review.googlesource.com/c/sdk/+/399461


Support Angular 6, rxjs 6, and drop database-deprecated

Checklist

Issue number for this PR: #1602, #1538
Docs included?: n/a
Test units included?: yes
In a clean directory, yarn install, yarn test run successfully? yes

Description
Adding rxjs and angular 6 support. Dropped database-deprecated, since there were a lot of changed needed there and it's no longer worth maintaining IMO.
Huge shout out to @jymdman for doing the ground work in each module.

Closing @kawamoto's pull request in favor of this one; I pulled in some of his changes so gave him co-author status. He's signed the CLA as verified in #1582

@jamesdaniels @robertbaker It's not being favored. James has been working on various AngularFire issues and we haven't communicated with each other on this one due to Google I/O.
@jamesdaniels I'm closing this PR because other community members were in the middle of working on this. It also contains the deletion of the database-deprecated module which is something we need clearer notice on before handling.

Can the status of angular and rxjs 6 be clarified please?

@GaryB432 We are clarifying who is working the PR in #1582. Who ever takes the issue first will work on it. We will also check on the status to make sure it is implemented in a timely manner. In the meantime please use the compat library until we get fully up to speed.

@robertbaker I just noticed that @jymdman sent in the PRs which were small and done by feature. This PR looks large because it includes the removal of database-deprecated. The RxJS changes are small. However, the database-deprecated removal should be done in another PR.

@robertbaker sorry for making this look "preferred". I already merged in several of @jymdman's PRs which brought the modules up to speed with pipeable operators. For the most part here I just pulled in the pieces of @kawamoto's pull request that were still needed; largely just updating the paths, build, karma.conf, and getting the tests green and please note I gave him co-contributor status here. I did this simply so I could move faster in merging this work; not to squash any community effort.
@davideast I'll do the work and send another PR which gets database-deprecated up to speed with Firebase JS SDK 5.0 and pipeable operators, update this to get it up to speed with 6, so we can merge this--then put a proposal up for removing database-deprecated.

@robertbaker @GaryB432 and yes, we're sorry for the lack of communication here; both @davideast and I have been very busy prepping for, speaking at, and staffing Google I/O. I'm just trying to jump on this now that we're in the clear. I want everything fixed up so I can cut a new RC Monday AM.

Released as angularfire2@next

Wow, googlebot does not handle branches with co-contributors well at all.

Wow, this mega change gets pushed out in a release candidate?!?!

@maguro AngularFire is a combination of Firebase, Angular, and RxJS. Within a short period of time all libraries had major upgrades with breaking changes. We were already in the middle of a release candidate and were forced to make the changes. We opted to update to the major releases for everyone before going final. If we went final before upgrading then we would have had to break immediately.


Overriding Official/Curated repository with Environment variable

Since VRChat releases VRCSDK in an unreliable way, VRChat official repository is not reliable for some people. Therefore, there is some idea that its reasonable to create alternative repository to distribute VRCSDK. I agree with that VRChat is not reliable so I want to support this idea with supporting alternative VRCSDK repository.
When the de-facto standard alternative repository become real, I think simple config (or environment variable) but currently there are no so supporting overriding Official repository is good way I think.

officualを上書きの形で実装したけど上書きではなくOficcialを無視するってことでも良さそ

vrc-get specific global configurationで上書きしてもいいな

I'm a maintainer of a vpm mirror, and it's hard to teach new users who have network issues to overwrite the default official/curated repository url without gui.
So I would like to ask if there is any plan to implement this feature in gui? thanks!

https://vcc.vrczh.org/repos/official
https://vcc.vrczh.org/repos/curated
Our vpm mirror backend source code: https://github.com/vrcd-community/VPMReposSynchronizer

Maybe it would be time to create a consortium of community tool creators and create our own curated list, showing how we approve new packages and make a proper list that can evolve with the ecosystem.

Maybe it would be time to create a consortium of community tool creators and create our own curated list, showing how we approve new packages and make a proper list that can evolve with the ecosystem.

I agree. The official curated repo have not update for a long long time since it appear, and only provide serval packages.
But the I have some questions

Who will collect packages and make a repo?
How to hosting these packages?
What is the standard of "curated"?

And I think the community curated repo should be a spreated repo instead of replace the official curated repo.

I already have issue for vrc-get-curated repository: #294


feat(icons): add charmander icon

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Scatter plot: rendering fails on inverted horizontal axis

Recreating:
formsPlot1.Plot.Add.Signal(Generate.Sin());
formsPlot1.Plot.Axes.SetLimitsX(0, -100);

This line throws:
https://github.com/ScottPlot/ScottPlot/blob/b12cb0c1ae5ddd76fe4e7a686fac79cc57519fbb/src/ScottPlot5/ScottPlot5/Plottables/Signal.cs#L111
System.ArgumentOutOfRangeException: 'Index was out of range.
Must be non-negative and less than the size of the collection. (Parameter 'index')'

I took a quick look at this. The reason it throws is obviously because there are no points to move to. If you just handle that and return from RenderLowDensity(), it won't throw, but it won't plot anything either.
The reason there are no points to render is much deeper. Signal, by virtue of how it handles the X axis with a period and not actual point values, doesn't easily invert its x-axis. Perhaps it shouldn't either. It is a signal. Inverting it means plotting from the future to the past, which doesn't make sense.
If you do want to handle it, it's going to take a major refactor, from what I can see.
All this code here in SignalBase.cs will need to change because it doesn't expect negative values.
public int MinimumIndex { get; set; } = 0;
public int MaximumIndex { get; set; } = int.MaxValue;

public int MinRenderIndex => Math.Max(0, MinimumIndex);
public int MaxRenderIndex => Math.Min(Length - 1, MaximumIndex);

public double XOffset { get; set; }
public double YOffset { get; set; }

public int GetIndex(double x, bool visibleDataOnly)
{
    int i = (int)((x - XOffset) / Period);

    if (visibleDataOnly)
    {
        i = Math.Max(i, MinRenderIndex);
        i = Math.Min(i, MaxRenderIndex);
    }

    return i;
}


Modify method to get base directory. (IDFGH-4926)

Current method assumes that you are in the esp-idf directory when executing install. This method will get the correct path regardless of where you execute from.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution.

Hi @blakjak44, will #6416 work for you to solve the issue? That PR is already in the merge queue, if it's okay for you we will merge it instead.

Hi @igrr, personally this method is better, as #6416 adds a period into the generated path:
set basedir "$PWD/"(dirname (status -f)) = /Users/<user>/./espressif/esp-idf
set basedir (dirname (realpath (status -f))) = /Users/<user>/espressif/esp-idf

Thank you for the PR @blakjak44, it was cherry-picked as https://github.com/espressif/esp-idf/commit/f5f0648608e2a8dfb96dc1b082d0c6bb87318696!


type VariableValuesObject doesn't handle JSON

When a variable is defined as JSON in the optimizely web interface, there is no associated typing for it on VariableValuesObject. However, the SDK handles JSON.parse-ing variables of this type via getFeatureVariableJSON. This leads to a type mismtach when using useFeature or <OptimizelyFeature />.
I might just be missing a key detail here, let me know if I'm using the SDK in an invalid way.

@timothympace thanks for reporting the issue! We just released a new patch v2.6.3 with the fix.

@yavorona Thank you for the quick fix!


feat: add function to set default values if they are nil or default(0)

Thank you for your pull request.
It will be merged into govalidator package after below modifications:

Always follow Golang comment conventions. You can refer refer to other existing comments in govalidator repo or Golang tip https://tip.golang.org/doc/comment. Your comments are expressive but not in the standard Golang format. e.g: DefaultInt method should have a comment like this:  DefaultInt sets a default value for any pointer to an int thats is passed.
In Golang, comments are typically better when they start with the method, struct, or constant name.

Validator receiver in methods should be a pointer to struct for consistency. e.g: func (v *Validator) DefaultInt(i *int, val int)

It would be preferable if validator methods returned a *Validator struct so users can chain methods for more convenient usage. If possible, please return *Validator as the return value."

your tests are correct but it is good practice to include a name field (in the test struct) describing the purpose of the test and what the users should expect from it.

Always hit 100% test coverage.

Fix Golang linter reported issues:
Error: default.go:3:1: comment on exported method Validator.DefaultInt should be of the form "DefaultInt ..."
Error: default.go:11:1: comment on exported method Validator.DefaultFloat should be of the form "DefaultFloat ..."
Error: default.go:19:1: comment on exported method Validator.DefaultString should be of the form "DefaultString ..."

If you had any problem during the process, feel free to reach me.

all tests are now 100% passing, let me know if you have any feedback/changes

Thank you for your contribution!


[BUG] EncryptedBlobAsyncClient uses block() in async method

Describe the bug
EncryptedBlobAsyncClient uses block() in async method
https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/storage/azure-storage-blob-cryptography/src/main/java/com/azure/storage/blob/specialized/cryptography/EncryptedBlobAsyncClient.java#L448-L449
It would cause runtime error
block()/blockFirst()/blockLast() are blocking, which is not supported in thread reactor-http-nio-5

Exception or Stack Trace
Add the exception log and stack trace if available
To Reproduce
Steps to reproduce the behavior:
Config with AsyncKeyEncryptionKey and upload some file.
encryptedBlobClient.uploadFromFile(file2Path);

Code Snippet
Add the code snippet that causes the issue.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):

OS: [e.g. iOS] Windows
IDE : [e.g. IntelliJ] IntelliJ
Version of the Library used 12.7.0

Additional context
Add any other context about the problem here.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

@weidongxu-microsoft Thank you for pointing this out. It looks like you are correct that we are blocking in an async context. We'll work on getting a fix out for this soon.


login password input

Description:
Login pages' password input font color changed to black
Issue: #8
Screenshot:

Thanks For Contributing


[CPP Graph] KV-Update Optimization

Type of Change: feature
API not changed
Description

The FLASH_ATTN_KV_UPDATE op now uses JIT implementations for first token inference
Update jblas to 21757a4

Expected Behavior & Potential Risk
N/A
How has this PR been tested?

Interference result:
set -ex
#main branch
rm -rf bin && cmake .. -GNinja -DNE_BUILD_TESTS=ON -DNE_PROFILING=ON -DCMAKE_BUILD_TYPE=Release && ninja run_gptj && env ENGINE_PROFILING=1 numactl -m 1 -C 56-111 bin/run_gptj -m /home_local/dingyi/data/gpt-j-6B-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 48 -b 2048 -c 2048 -n 1 -p "$LUOYU_PROMPT"
rm -rf bin && cmake .. -GNinja -DNE_BUILD_TESTS=ON -DNE_PROFILING=ON -DCMAKE_BUILD_TYPE=Release && ninja run_gptj && env ENGINE_PROFILING=1 numactl -m 1 -C 56-111 bin/run_gptj -m /home_local/dingyi/data/gpt-j-6B-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 56 -b 2048 -c 2048 -n 1 -p "$LUOYU_PROMPT"
rm -rf bin && cmake .. -GNinja -DNE_BUILD_TESTS=OFF -DNE_PROFILING=OFF -DCMAKE_BUILD_TYPE=Release && ninja run_gptj && env --unset ENGINE_PROFILING numactl -m 1 -C 56-111 bin/run_gptj -m /home_local/dingyi/data/gpt-j-6B-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 56 -b 2048 -c 2048 -n 32 -p "$GIRL_PROMPT"
#llama has different tokenizer and can only process a slightly shorter prompt
rm -rf bin && cmake ..  -GNinja -DNE_BUILD_TESTS=OFF -DNE_PROFILING=OFF -DCMAKE_BUILD_TYPE=Release && ninja run_llama && env --unset ENGINE_PROFILING numactl -m 1 -C 56-111 bin/run_llama -m /home_local/dingyi/data/llama-7b-hf-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 56 -b 2048 -c 2048 -n 32 -p "$GIRL_PROMPT"

#this branch
rm -rf bin && cmake .. -GNinja -DNE_BUILD_TESTS=ON -DNE_PROFILING=ON -DCMAKE_BUILD_TYPE=Release && ninja run_gptj && env ENGINE_PROFILING=1 numactl -m 1 -C 56-111 bin/run_gptj -m /home_local/dingyi/data/gpt-j-6B-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 48 -b 2048 -c 2048 -n 1 -p "$LUOYU_PROMPT"
rm -rf bin && cmake .. -GNinja -DNE_BUILD_TESTS=ON -DNE_PROFILING=ON -DCMAKE_BUILD_TYPE=Release && ninja run_gptj && env ENGINE_PROFILING=1 numactl -m 1 -C 56-111 bin/run_gptj -m /home_local/dingyi/data/gpt-j-6B-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 56 -b 2048 -c 2048 -n 1 -p "$LUOYU_PROMPT"
rm -rf bin && cmake .. -GNinja -DNE_BUILD_TESTS=OFF -DNE_PROFILING=OFF -DCMAKE_BUILD_TYPE=Release && ninja run_gptj && env --unset ENGINE_PROFILING numactl -m 1 -C 56-111 bin/run_gptj -m /home_local/dingyi/data/gpt-j-6B-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 56 -b 2048 -c 2048 -n 32 -p "$GIRL_PROMPT"
#llama has different tokenizer and can only process a slightly shorter prompt
rm -rf bin && cmake ..  -GNinja -DNE_BUILD_TESTS=OFF -DNE_PROFILING=OFF -DCMAKE_BUILD_TYPE=Release && ninja run_llama && env --unset ENGINE_PROFILING numactl -m 1 -C 56-111 bin/run_llama -m /home_local/dingyi/data/llama-7b-hf-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 56 -b 2048 -c 2048 -n 32 -p "$GIRL_PROMPT"

Main branch

env ENGINE_PROFILING=1 numactl -m 1 -C 56-111 bin/run_gptj -m /home_local/dingyi/data/gpt-j-6B-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 48 -b 2048 -c 2048 -n 1 -p "$LUOYU_PROMPT"

=== GRAPH Profiling ===
perf_total_per_op_us[                     ADD] =  55.135 ms
perf_total_per_op_us[                     MUL] =  15.932 ms
perf_total_per_op_us[                    NORM] =  25.274 ms
perf_total_per_op_us[                 MUL_MAT] =  81.835 ms
perf_total_per_op_us[       MUL_MAT_WITH_BIAS] =  59.493 ms
perf_total_per_op_us[                 RESHAPE] =   0.285 ms
perf_total_per_op_us[                    VIEW] =   0.750 ms
perf_total_per_op_us[                 PERMUTE] =   0.115 ms
perf_total_per_op_us[                GET_ROWS] =   7.722 ms
perf_total_per_op_us[                    ROPE] =  30.034 ms
perf_total_per_op_us[                 MUL_QKV] = 221.504 ms
perf_total_per_op_us[            FFN_ADD_GeLU] = 600.671 ms
perf_total_per_op_us[              FLASH_ATTN] = 209.671 ms
perf_total_per_op_us[    FLASH_ATTN_KV_UPDATE] =  94.790 ms
perf_total_per_op_us[           INNER PRODUCT] =   0.000 ms
========================================

env ENGINE_PROFILING=1 numactl -m 1 -C 56-111 bin/run_gptj -m /home_local/dingyi/data/gpt-j-6B-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 56 -b 2048 -c 2048 -n 1 -p "$LUOYU_PROMPT"

=== GRAPH Profiling ===
perf_total_per_op_us[                     ADD] =  43.585 ms
perf_total_per_op_us[                     MUL] =  11.440 ms
perf_total_per_op_us[                    NORM] =  22.630 ms
perf_total_per_op_us[                 MUL_MAT] =  72.616 ms
perf_total_per_op_us[       MUL_MAT_WITH_BIAS] =  63.080 ms
perf_total_per_op_us[                 RESHAPE] =   0.320 ms
perf_total_per_op_us[                    VIEW] =   0.709 ms
perf_total_per_op_us[                 PERMUTE] =   0.098 ms
perf_total_per_op_us[                GET_ROWS] =   8.266 ms
perf_total_per_op_us[                    ROPE] =  33.194 ms
perf_total_per_op_us[                 MUL_QKV] = 207.260 ms
perf_total_per_op_us[            FFN_ADD_GeLU] = 584.771 ms
perf_total_per_op_us[              FLASH_ATTN] = 194.659 ms
perf_total_per_op_us[    FLASH_ATTN_KV_UPDATE] =  90.783 ms
perf_total_per_op_us[           INNER PRODUCT] =   0.000 ms
========================================

env --unset ENGINE_PROFILING numactl -m 1 -C 56-111 bin/run_gptj -m /home_local/dingyi/data/gpt-j-6B-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 56 -b 2048 -c 2048 -n 32 -p "$GIRL_PROMPT"

Once upon a time, there existed a little girl, who liked to have adventures. She wanted to go to places and meet new people, and have fun. This girl went by the name of LittleRed Riding Hood.
One day Little Red Riding Hood was walking through the forest when she noticed someone following her. She
model_print_timings:        load time =  1083.34 ms
model_print_timings:      sample time =    28.25 ms /    32 runs   (    0.88 ms per token)
model_print_timings: prompt eval time =    89.23 ms /    32 tokens (    2.79 ms per token)
model_print_timings:        eval time =   716.09 ms /    31 runs   (   23.10 ms per token)
model_print_timings:       total time =  1842.00 ms
========== eval time log of each prediction ==========
prediction   0, time: 89.23ms
prediction   1, time: 28.39ms
prediction   2, time: 26.08ms
prediction   3, time: 23.91ms
prediction   4, time: 23.78ms
prediction   5, time: 24.07ms
prediction   6, time: 24.24ms
prediction   7, time: 23.89ms
prediction   8, time: 23.18ms
prediction   9, time: 22.95ms
prediction  10, time: 22.72ms
prediction  11, time: 22.56ms
prediction  12, time: 22.70ms
prediction  13, time: 22.48ms
prediction  14, time: 22.42ms
prediction  15, time: 22.27ms
prediction  16, time: 22.65ms
prediction  17, time: 22.93ms
prediction  18, time: 22.40ms
prediction  19, time: 22.64ms
prediction  20, time: 22.42ms
prediction  21, time: 22.71ms
prediction  22, time: 22.46ms
prediction  23, time: 22.66ms
prediction  24, time: 22.50ms
prediction  25, time: 22.40ms
prediction  26, time: 22.33ms
prediction  27, time: 22.53ms
prediction  28, time: 22.52ms
prediction  29, time: 22.74ms
prediction  30, time: 22.16ms
prediction  31, time: 22.38ms

env ENGINE_PROFILING=1 numactl -m 1 -C 56-111 bin/run_llama -m /home_local/dingyi/data/llama-7b-hf-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 56 -b 2048 -c 2048 -n 1 -p "$(echo "$LUOYU_PROMPT" | cut -d' ' -f 1-1500)"

=== GRAPH Profiling ===
perf_total_per_op_us[                     ADD] =  61.765 ms
perf_total_per_op_us[                     MUL] =  40.942 ms
perf_total_per_op_us[                RMS_NORM] =  60.443 ms
perf_total_per_op_us[                 MUL_MAT] = 149.868 ms
perf_total_per_op_us[                 RESHAPE] =   0.450 ms
perf_total_per_op_us[                    VIEW] =   0.980 ms
perf_total_per_op_us[                 PERMUTE] =   0.115 ms
perf_total_per_op_us[               TRANSPOSE] =   0.103 ms
perf_total_per_op_us[                GET_ROWS] =   7.885 ms
perf_total_per_op_us[                    ROPE] =  50.016 ms
perf_total_per_op_us[                 MUL_QKV] = 285.974 ms
perf_total_per_op_us[                FFN_SILU] = 769.070 ms
perf_total_per_op_us[              FLASH_ATTN] = 223.920 ms
perf_total_per_op_us[    FLASH_ATTN_KV_UPDATE] = 100.957 ms
perf_total_per_op_us[           INNER PRODUCT] =   0.000 ms
========================================

env --unset ENGINE_PROFILING numactl -m 1 -C 56-111 bin/run_llama -m /home_local/dingyi/data/llama-7b-hf-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 56 -b 2048 -c 2048 -n 32 -p "$GIRL_PROMPT"

Once upon a time, there existed a little girl, who liked to have adventures. She wanted to go to places and meet new people, and have fun.
 And she became a woman. A woman with a job, who travelled overseas for work,
model_print_timings:        load time =  1267.53 ms
model_print_timings:      sample time =    18.97 ms /    32 runs   (    0.59 ms per token)
model_print_timings: prompt eval time =   105.54 ms /    34 tokens (    3.10 ms per token)
model_print_timings:        eval time =   783.36 ms /    31 runs   (   25.27 ms per token)
model_print_timings:       total time =  2079.16 ms
========== eval time log of each prediction ==========
prediction   0, time: 105.54ms
prediction   1, time: 26.41ms
prediction   2, time: 25.19ms
prediction   3, time: 25.41ms
prediction   4, time: 25.37ms
prediction   5, time: 25.21ms
prediction   6, time: 25.17ms
prediction   7, time: 25.18ms
prediction   8, time: 25.28ms
prediction   9, time: 25.41ms
prediction  10, time: 25.21ms
prediction  11, time: 25.12ms
prediction  12, time: 25.15ms
prediction  13, time: 25.11ms
prediction  14, time: 25.07ms
prediction  15, time: 25.54ms
prediction  16, time: 25.32ms
prediction  17, time: 24.97ms
prediction  18, time: 25.49ms
prediction  19, time: 25.07ms
prediction  20, time: 25.04ms
prediction  21, time: 25.07ms
prediction  22, time: 25.33ms
prediction  23, time: 25.16ms
prediction  24, time: 25.20ms
prediction  25, time: 25.42ms
prediction  26, time: 25.51ms
prediction  27, time: 25.27ms
prediction  28, time: 25.41ms
prediction  29, time: 25.02ms
prediction  30, time: 25.28ms
prediction  31, time: 25.00ms

This branch

env ENGINE_PROFILING=1 numactl -m 1 -C 56-111 bin/run_gptj -m /home_local/dingyi/data/gpt-j-6B-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 48 -b 2048 -c 2048 -n 1 -p "$LUOYU_PROMPT"

=== GRAPH Profiling ===
perf_total_per_op_us[                     ADD] =  49.759 ms
perf_total_per_op_us[                     MUL] =  14.224 ms
perf_total_per_op_us[                    NORM] =  22.228 ms
perf_total_per_op_us[                 MUL_MAT] =  81.711 ms
perf_total_per_op_us[       MUL_MAT_WITH_BIAS] =  59.821 ms
perf_total_per_op_us[                 RESHAPE] =   0.300 ms
perf_total_per_op_us[                    VIEW] =   0.700 ms
perf_total_per_op_us[                 PERMUTE] =   0.093 ms
perf_total_per_op_us[                GET_ROWS] =   7.708 ms
perf_total_per_op_us[                    ROPE] =  30.821 ms
perf_total_per_op_us[                 MUL_QKV] = 226.942 ms
perf_total_per_op_us[            FFN_ADD_GeLU] = 599.899 ms
perf_total_per_op_us[              FLASH_ATTN] = 146.544 ms
perf_total_per_op_us[    FLASH_ATTN_KV_UPDATE] =  56.004 ms
perf_total_per_op_us[           INNER PRODUCT] =   0.000 ms
========================================

env ENGINE_PROFILING=1 numactl -m 1 -C 56-111 bin/run_gptj -m /home_local/dingyi/data/gpt-j-6B-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 56 -b 2048 -c 2048 -n 1 -p "$LUOYU_PROMPT"

=== GRAPH Profiling ===
perf_total_per_op_us[                     ADD] =  44.710 ms
perf_total_per_op_us[                     MUL] =  11.468 ms
perf_total_per_op_us[                    NORM] =  21.851 ms
perf_total_per_op_us[                 MUL_MAT] =  79.625 ms
perf_total_per_op_us[       MUL_MAT_WITH_BIAS] =  66.223 ms
perf_total_per_op_us[                 RESHAPE] =   0.334 ms
perf_total_per_op_us[                    VIEW] =   0.708 ms
perf_total_per_op_us[                 PERMUTE] =   0.118 ms
perf_total_per_op_us[                GET_ROWS] =   8.470 ms
perf_total_per_op_us[                    ROPE] =  42.760 ms
perf_total_per_op_us[                 MUL_QKV] = 215.438 ms
perf_total_per_op_us[            FFN_ADD_GeLU] = 592.271 ms
perf_total_per_op_us[              FLASH_ATTN] = 154.700 ms
perf_total_per_op_us[    FLASH_ATTN_KV_UPDATE] =  58.654 ms
perf_total_per_op_us[           INNER PRODUCT] =   0.000 ms
========================================

env --unset ENGINE_PROFILING numactl -m 1 -C 56-111 bin/run_gptj -m /home_local/dingyi/data/gpt-j-6B-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 56 -b 2048 -c 2048 -n 32 -p "$GIRL_PROMPT"

Once upon a time, there existed a little girl, who liked to have adventures. She wanted to go to places and meet new people, and have fun. This girl went by the name of LittleRed Riding Hood.
One day Little Red Riding Hood was walking through the forest when she noticed someone following her. She
model_print_timings:        load time =  1040.85 ms
model_print_timings:      sample time =    32.42 ms /    32 runs   (    1.01 ms per token)
model_print_timings: prompt eval time =    88.35 ms /    32 tokens (    2.76 ms per token)
model_print_timings:        eval time =   724.59 ms /    31 runs   (   23.37 ms per token)
model_print_timings:       total time =  1812.39 ms
========== eval time log of each prediction ==========
prediction   0, time: 88.35ms
prediction   1, time: 26.03ms
prediction   2, time: 24.79ms
prediction   3, time: 24.79ms
prediction   4, time: 25.17ms
prediction   5, time: 25.08ms
prediction   6, time: 24.60ms
prediction   7, time: 23.21ms
prediction   8, time: 22.98ms
prediction   9, time: 23.08ms
prediction  10, time: 23.43ms
prediction  11, time: 23.05ms
prediction  12, time: 22.79ms
prediction  13, time: 23.11ms
prediction  14, time: 22.85ms
prediction  15, time: 22.78ms
prediction  16, time: 23.10ms
prediction  17, time: 23.08ms
prediction  18, time: 22.82ms
prediction  19, time: 23.02ms
prediction  20, time: 22.91ms
prediction  21, time: 23.00ms
prediction  22, time: 22.64ms
prediction  23, time: 22.92ms
prediction  24, time: 22.91ms
prediction  25, time: 22.67ms
prediction  26, time: 23.11ms
prediction  27, time: 22.85ms
prediction  28, time: 23.03ms
prediction  29, time: 22.81ms
prediction  30, time: 23.05ms
prediction  31, time: 22.96ms

env ENGINE_PROFILING=1 numactl -m 1 -C 56-111 bin/run_llama -m /home_local/dingyi/data/llama-7b-hf-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 56 -b 2048 -c 2048 -n 1 -p "$(echo "$LUOYU_PROMPT" | cut -d' ' -f 1-1500)"

=== GRAPH Profiling ===
perf_total_per_op_us[                     ADD] =  45.444 ms
perf_total_per_op_us[                     MUL] =  25.363 ms
perf_total_per_op_us[                RMS_NORM] =  47.991 ms
perf_total_per_op_us[                 MUL_MAT] = 135.003 ms
perf_total_per_op_us[                 RESHAPE] =   0.427 ms
perf_total_per_op_us[                    VIEW] =   0.984 ms
perf_total_per_op_us[                 PERMUTE] =   0.108 ms
perf_total_per_op_us[               TRANSPOSE] =   0.102 ms
perf_total_per_op_us[                GET_ROWS] =   8.830 ms
perf_total_per_op_us[                    ROPE] =  50.482 ms
perf_total_per_op_us[                 MUL_QKV] = 277.234 ms
perf_total_per_op_us[                FFN_SILU] = 707.648 ms
perf_total_per_op_us[              FLASH_ATTN] = 187.805 ms
perf_total_per_op_us[    FLASH_ATTN_KV_UPDATE] =  72.886 ms
perf_total_per_op_us[           INNER PRODUCT] =   0.000 ms
========================================

env --unset ENGINE_PROFILING numactl -m 1 -C 56-111 bin/run_llama -m /home_local/dingyi/data/llama-7b-hf-pr347-q4j-sym-int8-fp32-g128.bin --seed 1234 -t 56 -b 2048 -c 2048 -n 32 -p "$GIRL_PROMPT"

Once upon a time, there existed a little girl, who liked to have adventures. She wanted to go to places and meet new people, and have fun.
 And she became a woman. A woman with a job, who travelled overseas for work,
model_print_timings:        load time =  1308.79 ms
model_print_timings:      sample time =    18.67 ms /    32 runs   (    0.58 ms per token)
model_print_timings: prompt eval time =   103.91 ms /    34 tokens (    3.06 ms per token)
model_print_timings:        eval time =   822.86 ms /    31 runs   (   26.54 ms per token)
model_print_timings:       total time =  2160.33 ms
========== eval time log of each prediction ==========
prediction   0, time: 103.91ms
prediction   1, time: 29.13ms
prediction   2, time: 28.06ms
prediction   3, time: 27.99ms
prediction   4, time: 28.03ms
prediction   5, time: 28.10ms
prediction   6, time: 27.85ms
prediction   7, time: 28.10ms
prediction   8, time: 27.98ms
prediction   9, time: 27.91ms
prediction  10, time: 27.99ms
prediction  11, time: 27.92ms
prediction  12, time: 27.93ms
prediction  13, time: 28.07ms
prediction  14, time: 28.06ms
prediction  15, time: 26.11ms
prediction  16, time: 27.22ms
prediction  17, time: 24.95ms
prediction  18, time: 25.32ms
prediction  19, time: 24.98ms
prediction  20, time: 25.28ms
prediction  21, time: 25.05ms
prediction  22, time: 24.94ms
prediction  23, time: 24.98ms
prediction  24, time: 25.09ms
prediction  25, time: 24.97ms
prediction  26, time: 25.02ms
prediction  27, time: 25.34ms
prediction  28, time: 25.38ms
prediction  29, time: 24.99ms
prediction  30, time: 24.75ms
prediction  31, time: 25.36ms

In conclusion, this PR should brings ~40% OP level performance for first-token inference in large scale problems for models that with fused MHA enabled, while not bringing any accuracy compromise. Next token optimization will be investigated later.
Dependency Change?
N/A

can you try more models to verify the performance gain?

can you try more models to verify the performance gain?

This improvement will only benefits models with fused MHA enabled (i.e. gptj & llama only by now).
I have added some test result for llama in the PR description. Looks that the result is similar with that of gptj.

ext test: https://inteltf-jenk.sh.intel.com/view/nlp-toolkit-validation/job/ITREX-cpp-graph-extension/97/

https://inteltf-jenk.sh.intel.com/job/ITREX-cpp-graph-extension/99/


How to check if my nth node of a span tag has class="cusboard-circle-amt"

I need some code like the below to identify if my tab component is rendered with cusboard-circle-amt class in it. ( Some Nth node in the element has particular class)
My test case looks like below , which is not working. i need some equivalent code.
it('If the currency value is zero, circular component should not display any text', () => {
    const wrapper = mount(<Tab {...props} />)
    expect(wrapper.find('#tab-data-pane-0').at(2).hasClass('cusboard-circle-amt')).toBe(true)
  })

i am getting error saying -------> Method “hasClass” is only meant to be run on a single node. 0 found instead.
And My HTML is as below

<button class="dashboard-circle">51$16</button>

Any help would be very much appreciated :)

wrapper.find('#tab-data-pane-0') gives you a wrapper around the only element with that ID, your div. .at(2) selects the 3rd item from a collection of 1 - which means that .hasClass is called on an empty collection.
I would expect that removing the .at(2) fixes your problem.

As you said , wrapper.find('#tab-data-pane-0') as gives wrapper around the only element with that ID. I need to go down to two to three levels down from that ID to check if I have my expected class in it. not able to travers down after having wrapper.find('#tab-data-pane-0').

How about expect(wrapper.find('#tab-data-pane-0').find('.cusboard-circle-amt')).to.have.lengthOf(1)?

It worked. Thanks a lot Jordan Harband. You saved me 👍


Use UID for Virtual Machine instace as the identifier

What this PR does / why we need it:
Change Virtual Machine Instance Identifier from VM name to VM UID.
Now instead of using the VM name in a label that acts as an identifier, the VM uid will be kept in a label and the vm name (domain) will be kept under an annotation :
	CreatedByLabel       string = "kubevirt.io/created-by"
	DomainAnnotation     string = "kubevirt.io/domain"

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1222
Special notes for your reviewer:
Release note:

NONE

/cc @fabiand @rmohr @cynepco3hahue  @davidvossel  @booxter
This fix handles most of the areas where VM name was used for identification and matching (vm-pods, vm -sockets, etc.)
It might need a round of improvements/fixes  but initial code reviews are more than welcomed.

Open issue that this fix doesn't handle :
{NAME} parameter passed to a VM template which is longer than 63 characters (or will eventually comprise a VM name longer than 63 characters)  will fail when the vm name will be used for the template's labels
(https://github.com/kubevirt/user-guide/blob/master/workloads/templates/vm-creation.md#example-template)

Open issue that this fix doesn't handle :
{NAME} parameter passed to a VM template which is longer than 63 characters (or will eventually comprise a VM name longer than 63 characters) will fail when the vm name will be used for the template's labels
(https://github.com/kubevirt/user-guide/blob/master/workloads/templates/vm-creation.md#example-template)

Does template have some validation where it can be handled?

Does template have some validation where it can be handled?

@cynepco3hahue  The potential issue here comes from the template form itself. if the template will have labels which will use the VM name and it will be longer than 63 characters, the creation of the VM out of the template will fail.
We currently use this format in our examples and user guide :
  kind: VirtualMachine
  metadata:
    name: ${NAME}
    labels:
      kubevirt-vm: vm-${NAME}
  spec:
    template:
      metadata:
        labels:
          kubevirt-vm: vm-${NAME}

we can validate all labels , but this might be redundant, creation will fail with a clear message anyway.

Maybe we should consider setting the watchdog file name as the UID, and have the contents in the file represent the namespace/name. I think we still have to be able to derive the name and namespace of a VMI from the watchdog file, but we don't have to represent that data in the file name like we're currently doing.

@davidvossel   Currently there is no harm in a long file name for the watchdog.  We can change the name to contain the UID as suggested for consistency matter , maybe in a different PR if that's really needed.

@davidvossel Currently there is no harm in a long file name for the watchdog. We can change the name to contain the UID as suggested for consistency matter , maybe in a different PR if that's really needed.

excellent, lets just leave the watchdog file the way it is then for now

@mareklibra Does this impact the webconsole?  The label association between VM to VMIs to Pods has changed to use UUIDs instead of VM related names.

@davidvossel yes, it is going to.
@suomiy FYI, the cocpit code will need to be changed to reflect this.


How to access self attention of Transformer Decoder ?

From the forward pass of the Transformer Decoder Layer :
https://github.com/pytorch/fairseq/blob/828c1ca7522278aa6c1eaf91fe0425b8f40dd832/fairseq/modules/transformer_layer.py#L188-L293
attn is used to store self-attention as well as encoder-attention. attn is over-written by encoder-attention, so only the encoder-attention is returned (self-attention seems to be lost ?).
How can I access the self-attention of Transformer Decoder ?

Yep, it'd be better to expose both, please feel free to submit a PR!

Related to #1531


Iterator over all cookies from string

I would like to add parse convenience method to CookieJar that allows a developer to parse a string with multiple cookies. It would most likely be a rather simple method, like the following pseudocode:
pub fn parse<'c, S>(s: S) -> Result<CookieJar, ParseError>
where
    S: Into<Cow<'c, str>>,
{
    s.split(';').try_fold(CookieJar::new(), |mut jar, cow| {
        jar.add_original(Cookie::parse(cow)?);
        Ok(jar)
    })
}

If such a method fit into the design of cookie, I'd like to contribute it.
Background: A developer has requested an iterator over all cookies present in a string as part of a discussion in the Actix Web project.

@SergioBenitez this would be very awesome! I'm too newbie to contribute with a PR! 😄


Date from last message overlaps new message

See gray date on blue bubble

any info about that?

@andrey-pervushin-appus are you still seeing this issue?  On atlas messenger?

I opened a ticket on the Atlas github about this, which has gone mostly ignored. I have a solution there.
https://github.com/layerhq/Atlas-iOS/issues/1067

Continuing conversation in Atlas repo


Use VEP 105 for RD

As a one-off for TOB in the populationgenomics domain, we use the hl.vep() driven by the dataproc backend to annotate, and there we can specifically pin to an earlier version. But for the batch-backend vep workfllow that is used for the RD domain, can keep the default to 105.

Is there any situation where we would use 104 again, or is the annotation data going to be deleted? I was thinking that image('vep') and image('vep_104') can both co-exist

The dataproc backend doesn't call image_path() explicitly, so no need to support it here. We can think of a more generic ways to support multiple versions with image_path and reference_path, but that's down the road! Don't want to hardcode it now :)


Adds pliers, ipyvolume, nodejs

We'll also need to amend the tag in https://neurohackademy.2i2c.cloud/services/configurator/ when https://github.com/neurohackademy/hub-image-2022/actions/runs/2778540423 is done running.

Hub configuration updated! Users will have to restart their servers to see this.


refactor(vue-json): provide schema with Ls configure

We can provide schema with language service configure instead of adding a $schema field by modifying document. This also makes the behavior of this plugin identical to VSCode built-in JSON extension.
This PR also fix an issue by the way. Relative path of schema now bases on the workspace root instead of SFC's folder path.

LGTM, thanks! And I think we can built-in this way to https://github.com/johnsoncodehk/volar/tree/master/plugins/json.


uint overflow

In /Server/StateMachine.cc, function StateMachine::shouldTakeSnapshot, line 599 (version: 1.1.0)
uint64_t curr = 0;
if (lastIncludedIndex > stats.last_snapshot_index())
curr = lastIncludedIndex - stats.last_snapshot_index();
uint64_t prev = curr - 1;
Subtract operation overflows on operands "curr" and "1UL", whose values are unsigned constants, 0 and 1, respectively.

That logic around that log message is a bit odd and probably doesn't do the right thing in all cases. @jujing, do you want to contribute a small patch or pull request for this? I think anything that avoids the underflow would be an improvement.

I wish to do that. But in my working environment, there are some limitations to prohibit me to commit code to github. And I only have a pad at home. I should solve the problem first.
For this issue, I think a simple way to avoid the underflow is that change the type of variables curr, prev, logEntries from uint64_t to int64_t.

Ah. And I'm waiting permission from legal to write code...


Multicast support

Hello, I implemented multicast support and created pull request #64. I tested it on 2 different encoders, everything work fine so far. I think project will benefit from this addition and I may help with issues related to this update if anything comes up.

Hello, thank you very much for your work. I have a lot of questions, but need some free time to discuss it with you. I will try to do it next holidays


Get Sources - Bitbucket Cloud OAuth connection - fatal: could not read Username ...

Environment
Account Name & URL: https://pointman-hq.visualstudio.com
Build Definition: ALL that use our bitbucket cloud OAuth Service connection
Build Number: All since August 13th @ 2:51 EDT
OS of the machine:
Hosted (WIN) 2.116.0 (multiple builds)
Hosted Linux Preview 2.116.0 (multiple builds)
Issue Description
Task Name: Get Sources
Using Bitbucket Cloud OAuth connection, cannot clone any of our repositories for many builds.
Here is the VSTS script that is run to clone the repository:
git init
git remote add origin https://bitbucket.org//project/srsv3_frontend
git config gc.auto 0
git config --get-all http.https://bitbucket.org//project/repo_name.extraheader
git config --get-all http.proxy

# git command that causes the error:
git -c http.extraheader="AUTHORIZATION: basic ***" fetch --tags --prune --progress --no-recurse-submodules --depth=1 origin

Error logs
Git fetch failed with exit code 128
fatal: could not read Username for 'https://bitbucket.org': terminal prompts disabled

Hi @seanbriceland, thank you for letting us know about this.  We have a fix rolling out now.  I expect your account will receive the fix soon (probably the next day or two).
I apologize for the inconvenience.

We are experiencing the exact same issue.
Please advice when done.

We are also experiencing the issue. Can we get an update, please?

Hi @mbn-dk and @martinpolivka, the ETA is still the same (~today).  As a workaround, you can use 'username / password' for authentication instead of OAuth until then.  When did you first notice the issue happening for you?  Also, what are your account names?

Hi @lkillgore ,
We first noticed it today. On vsts we are: https://vstssiteattention.visualstudio.com
Thanks,

Thanks, @mbn-dk.  It appears that your account should have the bits with the fix now.  Could you please verify whether that's the case or not?

Hi @lkillgore ,
I think all builds are failing from yesterday evening.
Our account name is https://summitmedia.visualstudio.com/.
Thanks.

Hi @martinpolivka, it looks like your account has the updated bits now too.  Could you please check whether it's fixed?

Thank you @lkillgore  - working now

It works for us as well. Thanks @lkillgor.

Thanks for letting me know!  And, again, sorry for the inconvenience.

This seems to be happening again.

@jburbach Is the agent hosted or on prem? Can you email debug logs to:
stfrance at microsoft dot com

I just encountered this issue with one of my pipelines. I hadn't used my pipeline build for quite some time now. I just used it to run a CI build and it failed with this exact problem. Any suggestions on what might be the problem?

I did as well on Friday. For now we switched our connection from oauth to use a username and password and it seems to work. The bitbucket oauth integrations seems to be pretty flakey.

For now we switched our connection from oauth to use a username and password and it seems to work.

Same here.

This is a known issue and we're rolling out a fix.  Sorry for the inconvenience.  Switching to username / password should work as a workaround.  Feedback thread is here: https://developercommunity.visualstudio.com/content/problem/529542/bitbucket-checkout-error-could-not-read-username.html


Cannot serialize multiple tables to same directory and then deserialize

With the current serialization implementation, users cannot serialize multiple Woodwork dataframes to the same directory and then deserialize them. This is because typing information is always stored in a file named woodwork_typing_info.json. If you serialize multiple files to the same path, this file will be overwritten making it impossible to deserialize all but the last dataframe that was serialized.
Additionally, the woodwork_typing_info.json is overwritten without warning, so users could potentially corrupt the data needed for deserialization and not know this happened until they attempt to deserialize.
At a minimum, we should raise an error if the woodwork_typing_info.json already exists, giving users the option to specify a different path without corrupting already existing data. It might be better yet to give users the ability to optionally specify a custom name for the typing information file on serialization and deserialization, allowing multiple tables to be serialized/deserialized at the same path.
Code Sample, a copy-pastable example to reproduce your bug.
import pandas as pd
import woodwork as ww
from woodwork.deserialize import read_woodwork_table

df = pd.DataFrame({
    'id': [0, 1, 2, 3],
    'ints': [1, 10, 20, 100]
})
df2 = pd.DataFrame({
    'id': [0, 1, 2, 3],
    'bools': [True, False, False, True]
})

df.ww.init(name="first_dataframe")
df2.ww.init(name="second_dataframe")

df.ww.to_disk('.')
df2.ww.to_disk('.')  # This overwrites the json file from the line above without error or warning

new_df = read_woodwork_table('.')  # This deserializes the second table only
new_df.ww.name

'second_dataframe'

Once https://github.com/alteryx/woodwork/issues/968 is complete, this will be irrelevant

Once #968 is complete, this will be irrelevant

I think this is only true for parquet serialization, or other formats where we can store the metadata in a single serialized file. We will still need to store metadata somewhere for CSV, correct?


elasticdump: use a proper Python web server, with a healthcheck

This rewrites the elasticdump image to be a Python application with a proper web server and healthcheck endpoint, rather than doing it all in bash.
This:

means the elasticdump container can run arbitrarily long, and shouldn't be timed out by the ALB healthchecks
opens the possibility of testing it properly, rather than relying on it “just working” as a shell script

Part of #1778.

A few tests are failing, but I think they’re the ones on master, and I fail to see how this PR could have affected them. Merging anyway!


Add support for dataset discovery from event

What are the schemas that are affected by the issue
context/ExperienceEvent
What are examples of products that are impacted by the issue
ACP
Requirement is to discover the dataset id to disambiguate un-normalized xdm attributes.

Can you share some background why you want to encode the target dataset (which is specific to Adobe Cloud Platform) in the Experience Event ?
Encoding such an information in the event creates a pretty tight coupling.

Exactly my concern, @fmeschbe .  If this is XC specific, then it needs to go into an extension schema and then merged/combined with experienceEvent at runtime.

@rkpandey @fmeschbe @lrosenthol
To step back a bit and use non-adobe terms.
This property is being used to associate a storage instance with each record in that storage instance. The storage management system maintains additional metadata that needs to be looked up based on this identifier.
A common case we see is multiple storage instances being merged together (when they are of a compatible schema). When that happens we loose the link to the metadata specific to each row.
We have a related bit of metadata that is the datasource, which is used to identify the system that mastered the data originally. I think "datasource" is a good name for that case. In this case "dataset" has a good general meaning in that it describes a set of records that have common schemas and consistent meaning.
So I think the meaning is good generically(Adobe is not the only potential implementor that will want to use this property) as is the naming. The description is something that needs to reflect this better. I will propose a new naming in the PR.

Thanks @cdegroot-adobe. Let me try to disect to see, whether I understand this. And I am going to use less generic terminology from traditional databases: database and table and row and column and field.

This property is being used to associate a storage instance with each record in that storage instance. The storage management system maintains additional metadata that needs to be looked up based on this identifier.
A common case we see is multiple storage instances being merged together (when they are of a compatible schema). When that happens we loose the link to the metadata specific to each row.

Is it correct to say, that this property comes into play when tables are merged into a new table to indicate the name of the original table before the merge. Correct ?
What if that resulting table is further merged ?
Is that property to be filled by the original Event sender ? Or is it auto-filled by the process which stores the event in the first table ?
The first option would create the coupling I was mentioning above, the second option would be a by-product of storing the event in the table.
Neither is good; the former definitely worse, of course. I think it should actually be a third option: As tables are merged, this field should be added into the merged table.

@fmeschbe The intent is the second option "auto-filled by the process which stores the event in the first table". It may do this on read rather than write, but that is an implementation detail.

@fmeschbe - Any further thoughts on this? We need to get this into the July 16th milestone, so I would like to make a decision asap on a standard XDM property or an Adobe Extension. I prefer the former and see the general utility of this in non-adobe cases. But given time constraints I can go with the extension if others are not of the same mind set.

Changed to an extension. Should be ready for merge now.

Thanks @cdegroot-adobe, that helps me. And I am now +1 in general.
I see you changed it to be an extension in PR #426. Fine for me. Thanks.

PR #426 is merged, so let's close this issue as well.


ILCE6000 firmware v3.21

Do OpenMemories framework apps still run on v3.21 firmware on A6000?

AFAIK yes.

AFAIK yes.

AFAIK yes.


settings: Don't show last active in deactivated users table.

Fixes: #29894

One small bug that I noticed - when I reactivate a user in "Deactivated users" list, the row of the reactivated user becomes faded, but when I click on any of the column heading to change the sorting, the row is not faded. I think it should still be faded like it is when sorting changes after deactivating a user in "Users" list.

This is fixed by the second commit.
#29986 was mostly correct in its underlying implementation, it was missing the fix for a case noted during testing, for which I've added the second commit.
In terms of changes to the original PR, the variable name has been changed from display_last_active_in_table to display_last_active_column since in_table part was redundant in that context.

Screenshots and screen captures:

Active users table - screen capture

Deactivated users table - screen capture

 Bots page - screen capture - unchanged - No greying out on deactivate there since the page contains both active and deactivated users.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Requesting review from @sahil839 since you reviewed the previous PR.

Started discussion on an existing issue I noticed while working on this: link

@shubham-padia Please add the "maintainer review" label as well when requesting @sahil839 's feedback -- it makes it easier to the status of the PR at a glance.

Looks good to me.

@timabbott Approved by @sahil839 ; I haven't tested.

Merged, thanks @shubham-padia!


conf file for meta port is not correct

some conf files for meta port (default) in conf/ is 45500.

done


support Sort operator auto spill when query memory usage exceed threshold

What problem does this PR solve?
Issue Number: ref #7738
Problem Summary:
What is changed and how it works?
Support sort operator auto spill when query memory usage exceeds the threshold. The basic idea is

MPPQuery will collect all OperatorSpillContext that support auto spill(currently, only SortSpillContext)
During complile time, a callback AutoSpillTrigger will be set to the executor(support both pull model and push model)
During runtime, for each iterator of each executor, it will call AutoSpillTrigger if current query memory usage exeeed the threshold
In AutoSpillTrigger, it check and mark operator to spill if possible
Each operator will be informed to spill in UpdateRevocableMemoryUsage, and begin to spill if needed

Check List
Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-all-tests

/run-unit-test

/run-all-tests


Remove SqlServer TypeMapping for CLR type char

An EntityType with property char is not supported by the SQL Server provider. However SqlServerTypeMapper does have a mapping in _clrTypeMappings for char (mapping it to a SQL Server int column).
The reason for this is to support generation of single character literals in the Query Pipeline e.g. as arguments to functions, or LIKE can take an ESCAPE argument which is a single character - see this test. Query checks that it can interpret each argument (in this case a single character) - if it fails to find a type mapping for that type then it assumes it cannot generate literals for that type.
We should remove the entry in _clrTypeMappings for SqlServerTypeMapper for char so that we will generate the correct error if someone tries to create a property of that type. But we need to provide an alternate means to translate the literal above. We discussed:

Just changing how we deal with LIKE to enforce that the ESCAPE argument is a string, or
Changing the way Query treats arguments in general to specifically allow it to try a string TypeMapping if a char one does not exist.
Updating the TypeMapper to allow a set of types which it can interpret for generation of literals even if it does not allow that type as a property type.

Additional data points:

GetChar is not supported in either SQL Server or Oracle's ADO.NET provider

Currently it is necessary for the provider to know how to generate a parameter, and not just a literal for the escapeCharacter argument.

Another potential approach would be to create some sort of fallback mapping mechanism for types like char and byte:

if char is not explicitly supported by the provider, it could fall back to a 'string' of size 1

if byte is not explicitly supported by the provider, it could fall back to a byte[] of size 1

This feels like it is slowly turning into a short-range version of the type conversions feature, but maybe that is ok.

Note: this came out of the work for #8631.

cc @anpete

Note: decided for preview2 to just to update the way we deal with LIKE to pass in the single character as a string. And remove the char SQL Server TypeMapping.

@lajones Can this issue be closed?

@ajcvickers @divega @anpete @smitpatel I thought the solution to just change the LIKE treatment was for preview2 only and that we wanted to discuss further on how, in general, to treat e.g. DbFunctions which had char parameters, or the issues that @divega raised above, for 2.0.0. So in short I thought we would be moving this to the 2.0.0 milestone but keeping it open.

I'll move it out of a milestone so we can re-triage. @divega Feel free to re-title/re-purpose this issue to cover the type conversion work we talked about, or open a new issue if that's better, or just combine the work into #242.

I have added text in #242 which I think covers the follow up for this (@ajcvickers feel free to review it). Closing for now.


add name_or_path into model

What does this PR do?
transformers.PretrainedModel init method initilaizes this field, while optimum not.
We see compatibility issue in llama-index due to that:
https://github.com/run-llama/llama_index/commit/f037de8d0471b37f9c4069ebef5dfb329633d2c6
AttributeError: 'OVModelForCausalLM' object has no attribute 'name_or_path'

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Add "SUSE CaaS Platform" to "Platforms" box

Project or Product name:
SUSE CaaS Platform
Is it open source? (if you are tempted to say partially, please answer no):
Yes
What are the best URL(s) for it? Repo and homepage (if different) for open source, product homepage for closed source?:
SUSE CaaS Platform for Enterprises is based on the "kubic" project: https://github.com/kubic-project
General product website: https://www.suse.com/products/caas-platform/
What one category does it best belong in?
Platforms
What's the URL for the best logo (and it needs to include the name)?

or: https://drive.google.com/open?id=162F3WwNfdclPkli39E0SwSkxpG5nnOYy
Anything else we need to know?:
SUSE CaaS Platform is an enterprise class container management solution.
It includes:

Kubernetes container orchestration technology
Container engine and image registry
SUSE MicroOS, a purpose built OS to run containers

Hi @cduch we are including SUSE CaaS Platform in the upcoming version, releasing soon! Thanks

Closing as this update was included in the most recent version https://github.com/cncf/landscape#current-version


Contents of the sidebar doesn't refresh

I have a table. On click of some of the rows, a diagram gets generated. Further, on click of each of those diagrams, content associated with those diagrams should be displayed in the sidebar. Content that needs to be displayed is disparate.
When I click on the table rows, and then on the diagram, content in the sidebar doesn't get updated. The same content get displayed for each of the diagrams.
Is there a way to "refresh" the contents of the sidebar?

Hi @AXIMEYE, you do you update the sidebar’s content?

Hi @Banandrew.
The application I'm working on uses Play framework. Everytime  appropriate table rows are clicked, one of the controllers passes data to a Scala template. Necessary html(content to be displayed) is generated by the template. Upon clicking the diagram, the generated html should be displayed in the sidebar.
At the moment, as a temporary workaround, I'm explicitly deleting the "div" that holds the previous content. Sidebar then adds the new content. But if I don't, the content remains the same.

@AXIMEYE Does it append that div after the previous one, or just sees that the div is there and does nothing?

No it doesn't append any div to the previously added div. In fact, when I was debugging, that is when I realized what was happening(the previously added div not getting modified) and came up with the workaround.

@AXIMEYE Unfortunately, there’s nothing SUI can do for you. You either have to remove the sidebar’s contents manually like you do, or use a JavaScript framework to automate all of your front-end manipulations.
Closing the issue as a usage question as per our contributing guidelines. If you’ll have other questions in the future, please use one of our other support resources:

Gitter chatroom
Official forums
StackOverflow


[dv] Fix top_earlgrey failure

X is propagated from dm_top due to lack of reset on jtag reset pin
Add reset at the beginning of run phase in jtag driver
Signed-off-by: Weicai Yang<EMAIL_ADDRESS>

@sriyerg just updated as we discussed offline. PTAL


The markets vs "equality" questions are bad

The difference between the left and the right in terms of economics is not simply how much government the government is involved with the market. What seperates the left and the right are their ideas of ownership and property. What are we supposed to gather from the top economic axis? There's too much roped in this axis for anyone to gather any understanding from the results from it. Is it property rights vs communal ownership? Is it welfare vs no welfare? Is it the big government vs small government? Government regulation vs free market capitalism? Markets vs no markets? What is it? The quiz makes no distinction between private property and government handouts even though they are unrelated. If having high market score means pro capitalism, does pro "equality" mean no capitalism? If it does, why does choosing big government for welfare raise the equality score when it's still capitalistic? How big the state is should not be relevant to the economic axis because it would only make sense in a capitalist system. Here's an example:
It is necessary for the government to intervene in the economy to protect consumers
This is a bad question because it has nothing to do with socialism, capitalism or markets, it's just welfare. Not wanting welfare does not make you pro market. A leftist libertarian would not want the government getting too involved in things but disagreing with it would raise their market score; it forces you to choose between bad options.
It is better to maintain a balanced budget than to ensure welfare for all citizens.
Another biased question. This question would not apply to everybody.

These are very interesting point that are worth the discussion. To the first example:
It is necessary for the government to intervene in the economy to protect consumers.
First let me state what I think a leftist libertarian (LL) wants because if we don't agree on that then we will discuss endlessly. LL wants that the whole population has as much control on the economy as possible, which probably is ideal when the whole population owns it. So in this example a LL answers strongly agree because the government is the population itself.
I agree that the term government can be confusing because as libertarian you don't want a government. So here it would be maybe helpful to exchange "government" with "population" or "society as a whole".
To the second example: It is better to maintain a balanced budget than to ensure welfare for all citizens.
Here I also have difficulty as LL answering. But for sure the welfare is more important than the budget. However, an LL can interpret the question in that way, that one group of people shouldn't owe to much to another one. But still the decision would be in favor of the citizens as there is still no necessity for a budget if everyone is fine. So the answer of an LL is in any case strongly disagree. But maybe there are better formulations of the question.

But what this test implies is that welfare capitalism is more important in determining equality rather than the relationship to people and the means of production which makes this test biased as it is under the false impression that socialism and capitalism exist on a spectrum. The test is framed in a liberal democratic view which makes the results invalid.

@maruseron

I'd like to point out that libertarianism isn't the belief that "there should be no state", or an opposition to the existence of one - libertarianism strongly defends the liberties of the citizens and is opposed to the meddling of the state in these affairs, not to its existence altogether.

To create welfare there would need to be authoritarian measures to collect tax which is inhearntly violent as it requires force to do.


[Candidate 1v1 Dammed Cottages ZH v1] Bottom Oil Derrick has more room to move around

Observed behaviour
Bottom Oil Derrick has more room to move nearby.
Expected behavior
Mirrored Oil Derricks offer equal space for unit mobility.
Screenshots

i dont think that would be a huge problem gameplay wise


support custom log file size and file num

@googlebot I signed it!)

@googlebot I signed it!)

Per README: The repository contains an open source version of the log package used inside Google. The master copy of the source lives inside Google, not here. The code in this repo is for export only and is not itself under development. Feature requests will be ignored.


'package:flutter/src/rendering/binding.dart': Failed assertion: line 308 pos 12: '!_debugMouseTrackerUpdateScheduled': is not true.

Same question here.

Same question here.

@harshabhadra
Please elaborate on the issue you are facing. Check this link and provide the requested details to better address the issue.

@harshabhadra
Please elaborate on the issue you are facing. Check this link and provide the requested details to better address the issue.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.

If I add a PersistentFrameCallback inside a StatefulWidget's State, then we can see this crash.
class ExampleState<T extends StatefulWidget> extends State<T> {
  @override
  void initState() {
    WidgetsBinding.instance.addPersistentFrameCallback((timeStamp) {}
  }
}

======== Exception caught by scheduler library =====================================================
The following assertion was thrown during a scheduler callback:
'package:flutter/src/rendering/binding.dart': Failed assertion: line 326 pos 12: '!_debugMouseTrackerUpdateScheduled': is not true.

Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new?template=2_bug.md

When the exception was thrown, this was the stack:
#2      RendererBinding._scheduleMouseTrackerUpdate (package:flutter/src/rendering/binding.dart:326:12)
#3      RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:321:5)
#4      SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1117:15)
#5      SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1055:9)
#6      SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:971:5)
...
====================================================================================================

@timobaehr
Please file a new issue as suggested in the comment above yours.
Thank you

Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.

'package:flutter/src/rendering/binding.dart': Failed assertion: line 325 pos 12: '!_debugMouseTrackerUpdateScheduled': is not true.
How to check and fix this issue. Kindly suggest. Thanks.

Any update on this issue. I am also facing the same.
`======== Exception caught by scheduler library =====================================================
The following assertion was thrown during a scheduler callback:
'package:flutter/src/rendering/binding.dart': Failed assertion: line 334 pos 12: '!_debugMouseTrackerUpdateScheduled': is not true.
Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.`

Same issue here. When adding a persistent frame callback inside a stateful widget, the error shows. The assertion which is not true can be found here: https://github.com/flutter/flutter/blob/76b2f987b0203e0848e4ba1f23b5dd8c593b92ff/packages/flutter/lib/src/rendering/binding.dart#L336

Is there any progress on this issue recently?

Same issue. Does anyone know how to fix this?
`======== Exception caught by scheduler library =====================================================
The following assertion was thrown during a scheduler callback:
'package:flutter/src/rendering/binding.dart': Failed assertion: line 334 pos 12: '!_debugMouseTrackerUpdateScheduled': is not true.
Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
https://github.com/flutter/flutter/issues/new?template=2_bug.md
When the exception was thrown, this was the stack:
#2      RendererBinding._scheduleMouseTrackerUpdate (package:flutter/src/rendering/binding.dart:334:12)
#3      RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:329:5)
#4      SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1144:15)
#5      SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1082:9)
#6      SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:998:5)
...
====================================================================================================`


cmd/lncli: fix linter complaint by running make fmt

Linter was broken by https://github.com/lightningnetwork/lnd/pull/8053 which didn't run make fmt.

Sry about that!

Sry about that!

No worries. Normally we wait for at least the basic CI checks to pass before merging.


Mailgun.js pollutes global namespace

Hello!
I've recently ran into an issue with global namespace pollution in Node.js which breaks certain packages. The pollution is caused by this https://github.com/mailgun/mailgun.js/blob/9d56b32d3d5f4fc7903dcdb368e338dc7b1a694e/package.json#L44
An example of package that refuses to work with mailgun.js because of this is for instance openpgp

Hello
Can you tell me the Node.js version, environment(where you run the code), and a code example with an error?
I do not fully understand how the namespace pollution issue can be possible in the scope of the package so if you can add more details and help me figure out the issue I would appreciate it.

Hey! Sure, a very simple sample of what's happening:
console.log(global.ReadableStream)
require('mailgun.js');
console.log(global.ReadableStream)

Returns:
undefined
Object [Module] {
  ByteLengthQueuingStrategy: [Getter],
  CountQueuingStrategy: [Getter],
  ReadableByteStreamController: [Getter],
  ReadableStream: [Getter],
  ReadableStreamBYOBReader: [Getter],
  ReadableStreamBYOBRequest: [Getter],
  ReadableStreamDefaultController: [Getter],
  ReadableStreamDefaultReader: [Getter],
  TransformStream: [Getter],
  TransformStreamDefaultController: [Getter],
  WritableStream: [Getter],
  WritableStreamDefaultController: [Getter],
  WritableStreamDefaultWriter: [Getter]
}

On all but LTS node version except for 18. Specifically the package that I've shown above is adding a polyfill to global object and openpgp for instance fails to work with this polyfill.

web-streams-polyfill was needed for ky-universal dependency to support ReadableStream https://www.npmjs.com/package/ky-universal.
Starting from version 7 of Mailgun.js SDK ky libruary was replaced by Axios and I removed web-streams-polyfill from the dependencies list.
I hope it resolves the issue and I plan to close this ticket in a few days but let me know if you still have an issue.


storing run data in temporary directory using tempfile module fails on macOS

should create a temporary directory for storing run data, but on macOS tempfile.gettempdir() creates a unique, persistent directory (ex: /var/folders/<some_identifier>/<letter>)

this is only relevant when not using a RAMdisk

tempfile.gettempdir() works as expected on Linux

tempfile.gettempdir() checks for environment variable $TMPDIR (or some variation of that). On macOS, $TMPDIR is a weird, private file path. Do we want to just point FEAGI to /tmp when there's no RAMdisk?


GetStream is incompatible with auth0 social login userIds

When using auth0, you usually get user IDs such as this:
google-oauth2|12341123123

First, the regex in the utils lib does only support user IDs with characters and dots. Changing from this regex
var validRe = /^[\w-]+$/;

to this fixes that issue.
var validRe = /^[\w-\|]+$/;

However looks like stream-js still doesn't allow those kind of userIds, looks like there is another validation at some point in your backend. Is it possible to allow the | character in userIds?
Maybe this error log is helpful:
{ Error: {"detail":"","status_code":404,"code":16,"exception":"DoesNotExistException","duration":"0.00ms"} with HTTP status code 404
    at StreamApiError.ErrorAbstract (/mnt/c/netly/productnews-graphql/node_modules/getstream/src/lib/errors.js:20:11)
    at new StreamApiError (/mnt/c/netly/productnews-graphql/node_modules/getstream/src/lib/errors.js:87:17)
    at Request.task [as _callback] (/mnt/c/netly/productnews-graphql/node_modules/getstream/src/lib/client.js:161:16)
    at Request.self.callback (/mnt/c/netly/productnews-graphql/node_modules/getstream/node_modules/request/request.js:187:22)
    at Request.emit (events.js:180:13)
    at Request.emit (domain.js:421:20)
    at Request.<anonymous> (/mnt/c/netly/productnews-graphql/node_modules/getstream/node_modules/request/request.js:1048:10)
    at Request.emit (events.js:180:13)
    at Request.emit (domain.js:421:20)
    at IncomingMessage.<anonymous> (/mnt/c/netly/productnews-graphql/node_modules/getstream/node_modules/request/request.js:969:12)
    at IncomingMessage.emit (events.js:185:15)
    at IncomingMessage.emit (domain.js:421:20)
    at endReadableNT (_stream_readable.js:1101:12)
    at process._tickCallback (internal/process/next_tick.js:114:19)
  error:
   { detail: '',
     status_code: 404,
     code: 16,
     exception: 'DoesNotExistException',
     duration: '0.00ms' },
  response:
   IncomingMessage {
     _readableState:
      ReadableState {
        objectMode: false,
        highWaterMark: 16384,
        buffer: [BufferList],
        length: 0,
        pipes: null,
        pipesCount: 0,
        flowing: true,
        ended: true,
        endEmitted: true,
        reading: false,
        sync: true,
        needReadable: false,
        emittedReadable: false,
        readableListening: false,
        resumeScheduled: false,
        destroyed: false,
        defaultEncoding: 'utf8',
        awaitDrain: 0,
        readingMore: false,
        decoder: null,
        encoding: null },
     readable: false,
     domain: null,
     _events:
      { end: [Array],
        close: [Array],
        data: [Function],
        error: [Function] },
     _eventsCount: 4,
     _maxListeners: undefined,
     socket:
      TLSSocket {
        _tlsOptions: [Object],
        _secureEstablished: true,
        _securePending: false,
        _newSessionPending: false,
        _controlReleased: true,
        _SNICallback: null,
        servername: 'api.stream-io-api.com',
        npnProtocol: false,
        alpnProtocol: false,
        authorized: true,
        authorizationError: null,
        encrypted: true,
        _events: [Object],
        _eventsCount: 8,
        connecting: false,
        _hadError: false,
        _handle: null,
        _parent: null,
        _host: 'api.stream-io-api.com',
        _readableState: [ReadableState],
        readable: false,
        domain: null,
        _maxListeners: undefined,
        _writableState: [WritableState],
        writable: false,
        allowHalfOpen: false,
        _bytesDispatched: 921,
        _sockname: null,
        _pendingData: null,
        _pendingEncoding: '',
        server: undefined,
        _server: null,
        ssl: null,
        _requestCert: true,
        _rejectUnauthorized: true,
        parser: null,
        _httpMessage: [ClientRequest],
        _idleNext: null,
        _idlePrev: null,
        _idleTimeout: -1,
        [Symbol(res)]: [TLSWrap],
        [Symbol(asyncId)]: 8791,
        [Symbol(lastWriteQueueSize)]: 0,
        [Symbol(bytesRead)]: 429,
        [Symbol(connect-options)]: [Object] },
     connection:
      TLSSocket {
        _tlsOptions: [Object],
        _secureEstablished: true,
        _securePending: false,
        _newSessionPending: false,
        _controlReleased: true,
        _SNICallback: null,
        servername: 'api.stream-io-api.com',
        npnProtocol: false,
        alpnProtocol: false,
        authorized: true,
        authorizationError: null,
        encrypted: true,
        _events: [Object],
        _eventsCount: 8,
        connecting: false,
        _hadError: false,
        _handle: null,
        _parent: null,
        _host: 'api.stream-io-api.com',
        _readableState: [ReadableState],
        readable: false,
        domain: null,
        _maxListeners: undefined,
        _writableState: [WritableState],
        writable: false,
        allowHalfOpen: false,
        _bytesDispatched: 921,
        _sockname: null,
        _pendingData: null,
        _pendingEncoding: '',
        server: undefined,
        _server: null,
        ssl: null,
        _requestCert: true,
        _rejectUnauthorized: true,
        parser: null,
        _httpMessage: [ClientRequest],
        _idleNext: null,
        _idlePrev: null,
        _idleTimeout: -1,
        [Symbol(res)]: [TLSWrap],
        [Symbol(asyncId)]: 8791,
        [Symbol(lastWriteQueueSize)]: 0,
        [Symbol(bytesRead)]: 429,
        [Symbol(connect-options)]: [Object] },
     httpVersionMajor: 1,
     httpVersionMinor: 1,
     httpVersion: '1.1',
     complete: true,
     headers:
      { 'content-type': 'text/plain; charset=utf-8',
        'content-length': '97',
        connection: 'close',
        date: 'Wed, 21 Mar 2018 11:49:30 GMT',
        server: 'nginx',
        'x-cache': 'Error from cloudfront',
        via: '1.1 ee6ddcd79938825b919ad3220f210cff.cloudfront.net (CloudFront)',
        'x-amz-cf-id': 'FLjosqJw0vT8slOA5qRJNUKGUyKBsNDdbaNpuj39SNbzubP3L0bgDA==' },
     rawHeaders:
      [ 'Content-Type',
        'text/plain; charset=utf-8',
        'Content-Length',
        '97',
        'Connection',
        'close',
        'Date',
        'Wed, 21 Mar 2018 11:49:30 GMT',
        'Server',
        'nginx',
        'X-Cache',
        'Error from cloudfront',
        'Via',
        '1.1 ee6ddcd79938825b919ad3220f210cff.cloudfront.net (CloudFront)',
        'X-Amz-Cf-Id',
        'FLjosqJw0vT8slOA5qRJNUKGUyKBsNDdbaNpuj39SNbzubP3L0bgDA==' ],
     trailers: {},
     rawTrailers: [],
     upgrade: false,
     url: '',
     method: null,
     statusCode: 404,
     statusMessage: 'Not Found',
     client:
      TLSSocket {
        _tlsOptions: [Object],
        _secureEstablished: true,
        _securePending: false,
        _newSessionPending: false,
        _controlReleased: true,
        _SNICallback: null,
        servername: 'api.stream-io-api.com',
        npnProtocol: false,
        alpnProtocol: false,
        authorized: true,
        authorizationError: null,
        encrypted: true,
        _events: [Object],
        _eventsCount: 8,
        connecting: false,
        _hadError: false,
        _handle: null,
        _parent: null,
        _host: 'api.stream-io-api.com',
        _readableState: [ReadableState],
        readable: false,
        domain: null,
        _maxListeners: undefined,
        _writableState: [WritableState],
        writable: false,
        allowHalfOpen: false,
        _bytesDispatched: 921,
        _sockname: null,
        _pendingData: null,
        _pendingEncoding: '',
        server: undefined,
        _server: null,
        ssl: null,
        _requestCert: true,
        _rejectUnauthorized: true,
        parser: null,
        _httpMessage: [ClientRequest],
        _idleNext: null,
        _idlePrev: null,
        _idleTimeout: -1,
        [Symbol(res)]: [TLSWrap],
        [Symbol(asyncId)]: 8791,
        [Symbol(lastWriteQueueSize)]: 0,
        [Symbol(bytesRead)]: 429,
        [Symbol(connect-options)]: [Object] },
     _consuming: true,
     _dumped: false,
     req:
      ClientRequest {
        domain: null,
        _events: [Object],
        _eventsCount: 5,
        _maxListeners: undefined,
        output: [],
        outputEncodings: [],
        outputCallbacks: [],
        outputSize: 0,
        writable: true,
        _last: true,
        upgrading: false,
        chunkedEncoding: false,
        shouldKeepAlive: false,
        useChunkedEncodingByDefault: true,
        sendDate: false,
        _removedConnection: false,
        _removedContLen: false,
        _removedTE: false,
        _contentLength: null,
        _hasBody: true,
        _trailer: '',
        finished: true,
        _headerSent: true,
        socket: [TLSSocket],
        connection: [TLSSocket],
        _header: 'POST /api/v1.0/feed/user/google-oauth2%7C106913991226465822832/?api_key=7t3whdup6txn&location=unspecified HTTP/1.1\r\nstream-auth-type: simple\r\nAuthorization: usergoogle-oauth2|106913991226465822832 EKmXPg1fgZ8n2RZbM9TL_IB910Y\r\nX-Stream-Client: stream-javascript-client-node-unknown\r\nhost: api.stream-io-api.com\r\naccept: application/json\r\ncontent-type: application/json\r\ncontent-length: 510\r\nConnection: close\r\n\r\n',
        _onPendingData: [Function: noopPendingOutput],
        agent: [Agent],
        socketPath: undefined,
        timeout: undefined,
        method: 'POST',
        path: '/api/v1.0/feed/user/google-oauth2%7C106913991226465822832/?api_key=7t3whdup6txn&location=unspecified',
        _ended: true,
        res: [Circular],
        aborted: undefined,
        timeoutCb: null,
        upgradeOrConnect: false,
        parser: null,
        maxHeadersCount: null,
        [Symbol(isCorked)]: false,
        [Symbol(outHeadersKey)]: [Object] },
     request:
      Request {
        domain: null,
        _events: [Object],
        _eventsCount: 5,
        _maxListeners: undefined,
        body: '{"actor":"user:google-oauth2|106913991226465822832","verb":"tweet","object":"story:{ votesCount: 1,\\n  commentsCount: 0,\\n  voters: [],\\n  _id: 5ab246c7cdafdd51c5facb45,\\n  authorId: \'google-oauth2|106913991226465822832\',\\n  comment: \'asdfasdfsadfasdfasd\',\\n  date: 2018-03-21T11:49:27.812Z,\\n  __v: 0 }","foreign_id":"comment:5ab246c7cdafdd51c5facb45","time":"2018-03-21T11:49:27.812Z","tweet":"asdfasdfsadfasdfasd","description":"asdfasdfsadfasdfasd","to":["timeline:cpaentries B1Vj9i6huAPNwcXRiBvuZtD7P8E"]}',
        signature: 'usergoogle-oauth2|106913991226465822832 EKmXPg1fgZ8n2RZbM9TL_IB910Y',
        headers: [Object],
        withCredentials: false,
        method: 'POST',
        callback: [Function],
        readable: true,
        writable: true,
        explicitMethod: true,
        _qs: [Querystring],
        _auth: [Auth],
        _oauth: [OAuth],
        _multipart: [Multipart],
        _redirect: [Redirect],
        _tunnel: [Tunnel],
        setHeader: [Function],
        hasHeader: [Function],
        getHeader: [Function],
        removeHeader: [Function],
        localAddress: undefined,
        pool: {},
        dests: [],
        __isRequestRequest: true,
        _callback: [Function: task],
        uri: [Url],
        proxy: null,
        tunnel: true,
        setHost: true,
        originalCookieHeader: undefined,
        _disableCookies: true,
        _jar: undefined,
        port: 443,
        host: 'api.stream-io-api.com',
        url: [Url],
        path: '/api/v1.0/feed/user/google-oauth2%7C106913991226465822832/?api_key=7t3whdup6txn&location=unspecified',
        _json: true,
        httpModule: [Object],
        agentClass: [Function],
        agent: [Agent],
        _started: true,
        href: 'https://api.stream-io-api.com/api/v1.0/feed/user/google-oauth2%7C106913991226465822832/?api_key=7t3whdup6txn&location=unspecified',
        req: [ClientRequest],
        ntick: true,
        response: [Circular],
        originalHost: 'api.stream-io-api.com',
        originalHostHeaderName: 'host',
        responseContent: [Circular],
        _destdata: true,
        _ended: true,
        _callbackCalled: true },
     toJSON: [Function: responseToJSON],
     caseless: Caseless { dict: [Object] },
     read: [Function],
     body:
      { detail: '',
        status_code: 404,
        code: 16,
        exception: 'DoesNotExistException',
        duration: '0.00ms' } },
  message: '{"detail":"","status_code":404,"code":16,"exception":"DoesNotExistException","duration":"0.00ms"} with HTTP status code 404' }

Thanks for the report; Auth0 is great!
I've asked our API team to see whether we can allow the vertical bar / pipe character. I'll let you know what I learn.
Side-note: the validRe was updated recently relation to a couple issues with resolved in the latest release. Just mentioning in case you wanted to grab the latest.

Thanks a lot, hoping for positive feedback because it's a major blocker for us to migrate to stream :( :)

Yea I see, ok I guess we'll go with this for now. Thanks for the info, hoping to see this in the product soon 😄.
I wonder though if it's actually possible to edit existing stream activities? It looks like it's only possible to view on the dashboard (maybe via API?). E. g. if we want to change all the userIds retrospectively in the activities and get rid of the mapping.
(This is just one use case, I have many use cases where I might want to edit activities retrospectively)

Updates are certainly possible: https://getstream.io/docs/#activity-update
I'll close this ticket for now.


Errors on changing tab

If you press "Play" and then change tab (using React Router), and then you try to return to the tab in which you have the AudioRecorder, you get the following errors:
Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op. Please check the code for the undefined component.
Uncaught NotSupportedError: Failed to construct 'AudioContext': The number of hardware contexts provided (6) is greater than or equal to the maximum bound (6).
Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op. Please check the code for the undefined component.
Uncaught TypeError: Cannot read property 'componentWillUnmount' of null
Then it won't let you return to the recording tab.

This is finally fixed in https://github.com/danrouse/react-audio-recorder/releases/tag/v2.0.0 - the audio context is shared through all instances of the component.


ShapeLabels doesn't show labe when tag has a URI

If you use the Shape Labels plugin and you use the TAG widget (initilialize Annatorious with this option), a label is showed, but the text is "undefined".
See https://codepen.io/r-w-c/pen/abPRBbW
Reproduce:

SHIFT + LEFT MOUSE CLICK to draw a circle
in the tag field, click down arrow on keyboard and select an item from the dropdown
click OK

Expected result: shape label contains text of selected tag
Actual result: shape label contains "undefined

"

Thx. Can reproduce!
This happens only for tags with URIs. P.S.: If anyone wants to pick this up: this would actually be a simple fix.  URI-tags have a slightly different structure than string tags. Fix would have to be here:
https://github.com/annotorious/annotorious-v2-plugins/blob/main/plugins/annotorious-shape-labels/src/index.js#L21


feat: add sentinel enable toggle to config

Issue being fixed or feature implemented

It needs to be possible to separately enable/disable sentinel for upcoming core testing
What was done?

Add sentinel to config
How Has This Been Tested?

Locally with fullnodes/masternodes
Breaking Changes

None
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

Yes, that was the request

We want to disable sentinel even if the node is a masternode?

Yes, this corresponds to changes in Core v20 to pull sentinel functionality directly into Core (https://github.com/dashpay/dash/pull/5525)


Fix error "ResizeObserver loop limit exceeded" in Chrome

This error appears in Chrome if the ResizeObserver callback is executed too frequently. This fix limits its execution with requestAnimationFrame.
Fixes #70
The error is not normally visible in Chrome’s console, only with window.addEventListener('error', e => console.error(e)).

@mayank23 merged in this change as part of PR #93
Thanks for contributing the fix, @TomOne!


Arte subtitles partial

Description of your pull request and other information
Add support for partial captions in ArteTV extractor.
Without :

Language
Type

fr
srt, srt

fr-acc
srt

With the support :

Language
Type

fr
srt

fr-partial
srt

fr-acc
srt

Otherwise you might get the partial as default (quite empty file translating only text appearing on screen), instead of the full captions.
Fixes #9242
Wrong subtitles downloaded

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[ ] I am the original author of this code and I am willing to release it under Unlicense
[x] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

[x] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

I'm assuming the patch is yours and you just checked the wrong checkbox, otherwise please note your evidence for it being in the public domain

On second thought, maybe a more appropriate suffix would be -forced? Since this PR is labeling translated forced subtitles, and since that's how they are labeled in the m3u8

Fixes #9242

Does this PR somehow also fix the "wrong language" problem described in that issue?

On second thought, maybe a more appropriate suffix would be -forced? Since this PR is labeling translated forced subtitles, and since that's how they are labeled in the m3u8

You are right I will change the name to "forced" instead of "partial".

Fixes #9242

Does this PR somehow also fix the "wrong language" problem described in that issue?

No, sorry I have read somewhere that the code for "-acc" subtitle was linked with this issue but now I don't see where I have read that. Forget it.


What's the status of nak and ML algorithms ?

Hey guys,
I'm considering switching to breeze. Therefore I have one question. What's the status of nak and ML algorithms ? Will the be migrated to breeze ?
I'm on Scala 2.11 with plan to switch to 2.12 soon.

Nak is basically dead. Its maintainer got sucked into the Google blackhole.
I'm happy to entertain ports from Nak but I don't have the bandwidth or
inclination to do it myself. (If I was gonna build something it would look
much more like Dynet)
-- David
On Tue, May 9, 2017 at 10:12 AM, unoexperto<EMAIL_ADDRESS>wrote:

Hey guys,
I'm considering swithcing to breeze. Therefore I have one question. What's
the status of nak and ML algorithms ? Will the be migrated to breeze ?
I'm on Scala 2.11 with plan to switch to 2.12 soon.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/scalanlp/breeze/issues/640, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAlofUm-RvEm1pJ6hnqvVff-e026uRQks5r4J6bgaJpZM4NVnde
.

@dlwh That's sad. What would you recommend to use for ML ? I tried MALLET and StanfordNLP in the past but didn't like them much.

It depends on what you need. MLLib in Spark has a lot of nice features if
your problems fit that mode. Epic's a bit on life support, but is pretty
solid if you need a CRF. Factorie is a pretty good graphical models
framework. Dynet-scala is not bad for neural nets
On Tue, May 9, 2017 at 10:24 AM, unoexperto<EMAIL_ADDRESS>wrote:

@dlwh https://github.com/dlwh That's sad. What would you recommend to
use for ML ? I tried MALLET and StanfordNLP in the past but didn't like
them much.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scalanlp/breeze/issues/640#issuecomment-300240011,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAlofYqZ5WcsQZ_9pYtIKhEwXJBQR4Bks5r4KFfgaJpZM4NVnde
.

For neural net, mxnet has good scala and spark integration...


Change ShouldBe to MarkupMatches

The ShouldBe name is too generic and it is not clear with cut.ShouldBe(...) what is actually being verified, i.e. rendered markup. The best alternative ive come up with is cut.MarkupMatches(...) which more clearly signals that it is the markup of cut that should match something else.

Done i beta-4.


Add @azure/functions js package to docs

Was able to test with help from folks offline and looks as-expected to me:

preview: https://review.learn.microsoft.com/en-us/javascript/api/@azure/functions/?view=azure-node-preview&branch=erijiz%2Ftest-azurefunctions
latest: https://review.learn.microsoft.com/en-us/javascript/api/@azure/functions/?view=azure-node-latest&branch=erijiz%2Ftest-azurefunctions

Hi @weshaggard anything else you need from me? I don't have permissions to merge "The base branch restricts merging to authorized users".