arch/risc-v: Add BL602 support

Summary
Add BouffaloLab BL602 support
Impact
Support BL602 SoC, provide UART and Timer driver
Testing
Tested on bl602evb board

@Virus-V As I mentioned in my first review, the register definitions are not at all in the NuttX style.  I would be happy to convert those for you.

I have the Sipeed and the DoIT DT-BL10 boards on hand as well as the BL602EVB on the way so I can do some on hardware testing of this.

@Virus-V it's better to rebase the PR to the latest master:
git remote add apache git@github.com:apache/incubator-nuttx.git
git fetch apache
git checkout dev_bl602
git rebase apache
git push -f origin dev_bl602

to avoid the merge patch in the PR.

Just received my pinecone so I could make a quick test of the functional part of this PR. Can I flash via JTAG?
Also, @Virus-V, I noticed there's a very brief header for BLE HCI interface. Do you think it is possible to integrate BLE with NuttX using this interface? I understand this is part of closed source libblecontroller.a. Or does this code depend on something other RTOS in some way?

@v01d my understanding is that the plan is to expose the HCI interface soon so expect that will just drop in fairly easily. We will have to figure out how we want to handle these blobs. Maybe we can pull them in from the SDK like we so with the ESP IDF.
@Virus-V can we help getting these hardware headers sorted out so they are inline with NuttX? I think that is the biggest hurdle to getting the initial work merged.

Just received my pinecone so I could make a quick test of the functional part of this PR. Can I flash via JTAG?

It is support to flash code via JTAG, but the speed is slower than the serial port.

Also, @Virus-V, I noticed there's a very brief header for BLE HCI interface. Do you think it is possible to integrate BLE with NuttX using this interface? I understand this is part of closed source libblecontroller.a. Or does this code depend on some other RTOS in some way?

We plan to implement BLE HCI as a pseudo-tty device, and may not use the HCI interface provided by Nuttx (Consulted with BLE colleagues).

@Virus-V can we help getting these hardware headers sorted out so they are inline with NuttX? I think that is the biggest hurdle to getting the initial work merged.

Very welcome! To be honest, we have spent a lot of time on formatting the code...  :)

Also, @Virus-V, I noticed there's a very brief header for BLE HCI interface. Do you think it is possible to integrate BLE with NuttX using this interface? I understand this is part of closed source libblecontroller.a. Or does this code depend on some other RTOS in some way?

We plan to implement BLE HCI as a pseudo-tty device, and may not use the HCI interface provided by Nuttx (Consulted with BLE colleagues).

You mean as BLE UART?
From what I understand there is a RAM based interface (calls into the closed binary). To proper approach (in line with how NuttX exposes the on-chip BLE controller) is using a bt_driver, which is based on HCI send/receive interface. BL602 BLE should not be based on an ad-hoc driver if there's an option to send/receive HCI commands to the BLE controller.

Also, @Virus-V, I noticed there's a very brief header for BLE HCI interface. Do you think it is possible to integrate BLE with NuttX using this interface? I understand this is part of closed source libblecontroller.a. Or does this code depend on some other RTOS in some way?

We plan to implement BLE HCI as a pseudo-tty device, and may not use the HCI interface provided by Nuttx (Consulted with BLE colleagues).

You mean as HCI UART?
From what I understand there is a RAM based interface (calls into the closed binary). To proper approach (in line with how NuttX exposes the on-chip BLE controller) is using a bt_driver, which is based on HCI send/receive interface. BL602 BLE should not be based on an ad-hoc driver if there's an option to send/receive HCI commands to the BLE controller.

We use BLE HCI as a pseudo-tty device because of current requirements, which will make it easy to integrate a third-party BT stack.
We will also consider supporting native Nuttx BLE HCI in the future.

@Virus-V NuttX already provide a generic driver to adapter tty device(either real or pseduo) to native bluetooth stack:
https://github.com/apache/incubator-nuttx/blob/master/include/nuttx/wireless/bluetooth/bt_uart_shim.h
https://github.com/apache/incubator-nuttx/blob/master/drivers/wireless/bluetooth/bt_uart_shim.c
Simply call bt_uart_shim_getdevice and btuart_register in soc or board initilize routine:
btuart_register(bt_uart_shim_getdevice("/dev/ttyXXX"));

@Virus-V can we help getting these hardware headers sorted out so they are inline with NuttX? I think that is the biggest hurdle to getting the initial work merged.

@btashton Very welcome! To be honest, we have spent a lot of time on formatting the code...  :)

Great! I'll see what I can do the next day or so I think we can get it in a good place.

Also, @Virus-V, I noticed there's a very brief header for BLE HCI interface. Do you think it is possible to integrate BLE with NuttX using this interface? I understand this is part of closed source libblecontroller.a. Or does this code depend on some other RTOS in some way?

We plan to implement BLE HCI as a pseudo-tty device, and may not use the HCI interface provided by Nuttx (Consulted with BLE colleagues).

You mean as HCI UART?
From what I understand there is a RAM based interface (calls into the closed binary). To proper approach (in line with how NuttX exposes the on-chip BLE controller) is using a bt_driver, which is based on HCI send/receive interface. BL602 BLE should not be based on an ad-hoc driver if there's an option to send/receive HCI commands to the BLE controller.

We use BLE HCI as a pseudo-tty device because of current requirements, which will make it easy to integrate a third-party BT stack.
We will also consider supporting native Nuttx BLE HCI in the future.

Hopefully we can find a way to meet both approaches, based both on Buffalo Labs contributions and NuttX community work.

@Virus-V can we help getting these hardware headers sorted out so they are inline with NuttX? I think that is the biggest hurdle to getting the initial work merged.

@btashton Very welcome! To be honest, we have spent a lot of time on formatting the code...  :)

Great! I'll see what I can do the next day or so I think we can get it in a good place.

Will you be making a PR against buffalo labs fork? I can also give a hand to work on the PR and test.

@Virus-V can we help getting these hardware headers sorted out so they are inline with NuttX? I think that is the biggest hurdle to getting the initial work merged.

@btashton Very welcome! To be honest, we have spent a lot of time on formatting the code...  :)

Great! I'll see what I can do the next day or so I think we can get it in a good place.

Will you be making a PR against buffalo labs fork? I can also give a hand to work on the PR and test.

Yeah that's my plan. I have all the registers maps added just need to need to update the drivers to use them.  Should have that done tonight or tomorrow.

@v01d @xiaoxiang781216 @btashton Is there still some work we need to do?

@v01d @xiaoxiang781216 @btashton Is there still some work we need to do?

@Virus-V I have a fairly large patch on top of this that I am working on right now that I think will get this more in line with the structure / style for inclusion https://github.com/bouffalolab/incubator-nuttx/compare/dev_bl602...btashton:bl602-nxt

@v01d @xiaoxiang781216 @btashton Is there still some work we need to do?

@Virus-V I have a fairly large patch on top of this that I am working on right now that I think will get this more in line with the structure / style for inclusion bouffalolab/incubator-nuttx@dev_bl602...btashton:bl602-nxt
Note: My branch does not build yet, I am working through the drivers

My branch is now building and my commits squashed, but I am sorting out the flash tools to be able to fully test my changes.  I have the evb so I would expect it to not be too difficult.  I did find a couple bugs, but I may have also introduced some as well.
@xiaoxiang781216 what are your thoughts on moving this forward?

@btashton Can you consider merging this PR first and use your modification as a new PR? We can review it together.

@btashton yes, let's go ahead.

@xiaoxiang781216 Ok I do think we should try to get my changes in soon though as there are still a lot of outstanding issues here that I have addressed.


Ensure admin tests can be run without user having to manually execute other scripts

Tests that interact with admin users require an admin user to be provisioned in the sandbox environment to execute successfully. We should automate this process such that tests don't require explicit user setup to execute correctly.
Via @emishur:
We can do two things:

Modify existing flextesa image and bootstrap many test accounts. So, it gets maintained with any flextesa updates
Bootstrap those accounts ourselves when starting the sandbox using taquito

This was closed by #112. An admin account by the name of Eve is bootstrapped when starting the sandbox, but it is passed directly to the flextesa Edobox image as a command line argument. There is no interaction with Taquito.


Tags field missing completely from virtual interface handling

Environment

Python version:  Python 3.6.6
NetBox version:  2.4.4

Steps to Reproduce

Add an interface to a virtual machine
The field for tags is missing, same as #2414
Save the interface
Edit the interface
The field for tags is still missing

Expected Behavior
That the field is rendered while both adding or editing a virtual interface
Observed Behavior
The field is not rendered in either types of operations

Fixed in #2414


Method to query job state for all jobs

It would be great if BE had a method to query the job states for all jobs of a user.
I noticed that it already updates the all job states internally, and for OTP it would be useful to expose that information.

If I understand you correctly, what you want is qstat -u right?
This is already implemented:
Look into JobManagerCreationParameters, there you'll find two fields userIdForJobQueries and trackUserJobsOnly

But there are currently no methods to get the complete results of qstat -u; queryJobStatus requires that you pass a list of BEJobs.
See the methods added in the queryJobStatus branch.


VS2015: System.ArgumentNullException: Value cannot be null. Parameter name: service Provider at Microsoft.AppInsights.GettingStarted.Telemetry.SKUHelper.GetSKU

Hello,
I get this error each time, when I start VS2015 and opening a VB class file (.aspx.vb or .vb) the first time after starting VS2015. The error is only showing one time after each start of VS2015. The error only appears in version 7.18 of AppInsight, regardless if CodeLens is enabled or not. With version 7.12 this error doesn't appear.
The following entry is written in the ActivityLog.xml:
 <entry>     <record>1114</record>     <time>2017/03/06 12:36:50.132</time>     <type>Error</type>     <source>Editor or Editor Extension</source>     <description>System.ArgumentNullException: Value cannot be null.
Parameter name: serviceProvider
   at Microsoft.AppInsights.GettingStarted.Telemetry.SKUHelper.GetSKU(IServiceProvider serviceProvider)
   at Microsoft.AppInsights.GettingStarted.CodeLens.CodeLensVBMarginProvider.CreateMargin(IWpfTextViewHost wpfTextViewHost, IWpfTextViewMargin marginContainer)
   at Microsoft.VisualStudio.Text.Utilities.ContainerMargin.<AddMargins>b__25_1(IWpfTextViewMarginProvider mp)
   at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.InstantiateExtension[TExtension,TMetadata,TExtensionInstance](Object errorSource, Lazy2 provider, Func2 getter)</description>   </entry>

@gardnerjr can you please look at this one?

Can do.  have escalated it internally.  @Twoleeland are you opening an entire solution or just a VB file by itself?

Internally: Bug 941257: System.ArgumentNullException: Value cannot be null. Parameter name: service Provider at Microsoft.AppInsights.GettingStarted.Telemetry.SKUHelper.GetSKU

We were unable to reproduce this issue, tried opening a vb file in a solution and vb file on its own. Are you getting any other errors before this happens?

I'm sorry, but I think, I posted it wrong. :-/ Please, excuse the inconveniences! I didn't mean the SDK, I meant the "Developer Analytics Tools"-extension, which includes AppInsights. I wrote a feedback through VS 2015 for this problem. Thanks a lot anyway! :-)

Closing the issue here

@Twoleeland Can you please reference the ticket you opened through VS2015? I'm seeing this issue as well

@OmerRaviv what's your full repro steps?  (and is this also against 7.18 of the developer analytics tools?)  We're trying to repro this to fix it, but we've never seen the problem so there might just be something subtle in what we're doing that doesn't match what you guys are, or what else you might have installed?

@gardnerjr I actually haven't been able to repro this myself either, still trying. I'm authoring a VS extension (http://www.oz-code.com) and had a customer complain about getting this error right after installing my extension.
The customer has version 7.18.00214.2 of the developer analytics tools installed on VS2015 Enterprise Version 14.0.25431.01 Update 3.

Here's what the customer who's experienced this has installed:
Microsoft Visual Studio Enterprise 2015
Version 14.0.25431.01 Update 3
Microsoft .NET Framework
Version 4.6.01055
Installed Version: Enterprise
Architecture and Modeling Tools   00322-90001-94463-AA979
Microsoft Architecture and Modeling Tools
UML® and Unified Modeling Language™ are trademarks or registered trademarks of the Object Management Group, Inc. in the United States and other countries.
Visual Basic 2015   00322-90001-94463-AA979
Microsoft Visual Basic 2015
Visual C# 2015   00322-90001-94463-AA979
Microsoft Visual C# 2015
Visual C++ 2015   00322-90001-94463-AA979
Microsoft Visual C++ 2015
Application Insights Tools for Visual Studio Package   7.18.00214.2
Application Insights Tools for Visual Studio
ASP.NET and Web Tools 2015.1 (Beta8)   14.1.11107.0
ASP.NET and Web Tools 2015.1 (Beta8)
ASP.NET Web Frameworks and Tools 2012.2   4.1.41102.0
For additional information, visit http://go.microsoft.com/fwlink/?LinkID=309563
ASP.NET Web Frameworks and Tools 2013   5.2.40314.0
For additional information, visit http://www.asp.net/
CodeMaid   10.2.7
CodeMaid is an open source Visual Studio extension to cleanup and simplify our C#, C++, F#, VB, PHP, PowerShell, R, JSON, XAML, XML, ASP, HTML, CSS, LESS, SCSS, JavaScript and TypeScript coding.
Common Azure Tools   1.8
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.
JavaScript Language Service   2.0
JavaScript Language Service
JavaScript Project System   2.0
JavaScript Project System
JetBrains ReSharper Ultimate 2016.1.2    Build 105.0.20160522.80219
JetBrains ReSharper Ultimate package for Microsoft Visual Studio. For more information about ReSharper Ultimate, visit http://www.jetbrains.com/resharper. Copyright © 2017 JetBrains, Inc.
Microsoft Azure Mobile Services Tools   1.4
Microsoft Azure Mobile Services Tools
NuGet Package Manager   3.4.4
NuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.
Office Developer Tools for Visual Studio 2015 ENU   14.0.23025
Microsoft Office Developer Tools for Visual Studio 2015 ENU
Oracle Developer Tools for Visual Studio   <IP_ADDRESS>.4
Oracle Developer Tools for Visual Studio Copyright (c) 2005, 2015
PreEmptive Analytics Visualizer   1.2
Microsoft Visual Studio extension to visualize aggregated summaries from the PreEmptive Analytics product.
Web Essentials 2015.3   3.0.235
Adds many useful features to Visual Studio for web developers. Requires Visual Studio 2015
Windows Installer XML Toolset   <IP_ADDRESS>07
Windows Installer XML Toolset version <IP_ADDRESS>07
Copyright (c) .NET Foundation and contributors. All rights reserved.

I have the same error appearing but with Blend 2015.  VS 2015 is not showing this error for me.
Typically I will select Design With Blend from VS and this error appears.
I've attached the activity log.  Record 508 is where the error occurs.
This only started happening after installing VS2107 RC
ActivityLog.xml.txt

Huh.  our extension shouldn't be loading in Blend, so that's problem 0.  somehow it is loading our editor extension, but not our package.  that should not be happening.  The fact that it started happening in Blend 2015 after installing VS2017 of any flavor would be even more troublesome as the 2 should be completely unrelated.
@johnrah Is the project you're opening in blend configured in any way with application insights?  or you just get this all the time with any project?

I've done a bit of digging around.  The solution itself doesn't have any reference to App. Insights. However, the solution is part of a Visual Studio Team Services project which has another solution in it for an Azure Web Service (WebAPI) and that does have Application Insights as a Service Reference.
Is it possible that the Team Explorer is the culprit?  Even though I'm not loading the WebAPI solution in Blend it is coming up in the list of solutions in Team Explorer.  The error only appears on first launch of Blend, my guess is when it's populating Team Explorer.

@gardnerjr FYI I've had another customer report this issue happening immediately after installing OzCode (in VS), but he reported that after restarting VS, the problem went away and never came back.
As for Blend - it makes sense that this code will cause Blend to fail. The fact that Blend is loading your MEF extensions even though it doesn't load your package is unfortunately just the way Blend works, and there isn't much you can do about it other than rewrite your MEF Components to make them resilient to it (we've had the same problem in the past with OzCode). I'm quoting part of an email discussion with @mgoertz-msft which might be helpful:

Blend currently only knows how to not load packages based on their package guids. By their nature MEF components are unfortunately not part of that logic, at least not yet.
I noticed that your extension is installed via MSI. I know it sounds counterintuitive but if you were to change your install folder from Common7\IDE\Extensions to Common7\IDE\CommonExtensions then Blend would not load any of your components. The reason for that is that Blend only considers certain folders under CommonExtensions but everything under Extensions.
...
Eventually we hope to figure out a way to associate MEF components with packages but for VS 2015 this is probably the best and perhaps even only way.

I have same happening to me every time I open Blend (2015, Update 3):
1 error:
System.ArgumentNullException: Value cannot be null. Parameter name: serviceProvider at Microsoft.AppInsights.GettingStarted.Telemetry.SKUHelper.GetSKU(IServiceProvider serviceProvider) at Microsoft.AppInsights.GettingStarted.Telemetry.SKUHelper.get_IsExpressSKU() at Microsoft.AppInsights.GettingStarted.CodeLens.CodeLensCSharpMarginProvider.CreateMargin(IWpfTextViewHost wpfTextViewHost, IWpfTextViewMargin marginContainer) at Microsoft.VisualStudio.Text.Utilities.ContainerMargin.b__25_1(IWpfTextViewMarginProvider mp) at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.InstantiateExtension[TExtension,TMetadata,TExtensionInstance](Object errorSource, Lazy2 provider, Func2 getter)
2 error:
System.ArgumentNullException: Value cannot be null. Parameter name: serviceProvider at Microsoft.AppInsights.GettingStarted.Telemetry.SKUHelper.GetSKU(IServiceProvider serviceProvider) at Microsoft.AppInsights.GettingStarted.Telemetry.SKUHelper.get_IsExpressSKU() at Microsoft.AppInsights.GettingStarted.CodeLens.CodeLensCSharpMarginProvider.CreateMargin(IWpfTextViewHost wpfTextViewHost, IWpfTextViewMargin marginContainer) at Microsoft.VisualStudio.Text.Utilities.ContainerMargin.b__25_1(IWpfTextViewMarginProvider mp) at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.InstantiateExtension[TExtension,TMetadata,TExtensionInstance](Object errorSource, Lazy2 provider, Func2 getter)

I have the same issue, stock Visual Studio 2015 Update 3 without any 3rd party extensions installed.
System.ArgumentNullException: Value cannot be null. Parameter name: serviceProvider at Microsoft.AppInsights.GettingStarted.Telemetry.SKUHelper.GetSKU(IServiceProvider serviceProvider) at Microsoft.AppInsights.GettingStarted.CodeLens.CodeLensCSharpMarginProvider.CreateMargin(IWpfTextViewHost wpfTextViewHost, IWpfTextViewMargin marginContainer) at Microsoft.VisualStudio.Text.Utilities.ContainerMargin.<AddMargins>b__25_1(IWpfTextViewMarginProvider mp) at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.InstantiateExtension[TExtension,TMetadata,TExtensionInstance](Object errorSource, Lazy`2 provider, Func`2 getter)

We have shipped an update to our tools for VS2015 Update 3, version 7.19:
https://marketplace.visualstudio.com/items?itemName=VisualStudioOnlineApplicationInsights.DeveloperAnalyticsTools
which should fix this.  Unfortunately, i believe that the microsoft signing certificate has been updated, and the VS Auto Updater only allows it to auto update things that have the same certificate as the old version.  So you may have to manually update in the tools->extensions and updates window in VS.

This has fixed my issue, thank you.


Code block improvements

Syntax highlighting/color code blocks, depending on the language.
Investigate good components for this. Maybe:

https://github.com/highlightjs/highlight.js?
https://github.com/markedjs/marked-highlight
https://magidoc.js.org/svelte-plugins/marked

Ability to copy the entire block (with a copy button in the top right corner).

Seems to be done


Wrong glottocodes

Stumbled across those warnings, seems like we still have some wrong glottocodes. I will prepare the minor Pr's and tag accordingly.
WARNING Fulfulde / baf2 / maas1242
WARNING Songhai_Senni / baf2 / humb1244
WARNING Sanapaná (Angaité) / johanssonsoundsymbolic / anga1216
WARNING Pubarong Queyu / lairgyalrong / quey1239
WARNING SanJuanDiuxiMixtec / mixtecansubgrouping / diux1236
WARNING SantiagoTilantongoMixtec / mixtecansubgrouping / diux1236**

@xrotwang Interestingly, those cases did not throw an error during the pylexibank conversion. Somehow I thought such a check would exist, but perhaps we should implement one?

Talking about the creation for the individual datasets. During the lexibank_analysed conversion, we did get the above warnings.

https://github.com/cldf/pycldf/issues/181

Funny enough, we already have that:
$ cldf check ../../cldf-datasets/imtvault/cldf/Generic-metadata.json --glottolog ../../glottolog/glottolog
WARNING Language urad1239 mapped to Bookkeeping languoid urad1239
WARNING Language kang1282 mapped to Bookkeeping languoid kang1282
WARNING Language fumm1238 mapped to Bookkeeping languoid fumm1238
WARNING Language chum1264 mapped to Bookkeeping languoid chum1264
WARNING Language oldp1255 mapped to Bookkeeping languoid oldp1255
WARNING Language bemb1258 mapped to Bookkeeping languoid bemb1258

The fact that I had forgotten about this should probably tell me something, though.

oh, cool, so i should definitly run this against the Lexibank data. I suspect there might be some further cases... hope it's not too many though.

The check from above only finds bookkeeping cases though, and not the non-existing glottocodes. So we should probably refine that.

This is now fixed in branch


Pin hdf4=4.2.12

Unpinning this in #677 seems to be causing problems in unexpected places: build (but not tests), downstream code, and sphinx docs building.
Hoping this fixes those.

Looks good. Can I merge?

I think so, will do...


Laravel 6.x

Hello,
Can somebody please tell me how can i contribute to make this plugin to work with Laravel 6.x ?
Thank You

@YoussF  If you wish to use this package with Laravel 6.x you need to change the dependencies version in the package's composer.json file for Passport and Socialite.
If you've done with these changes and want to contribute to this package, you can simply issue Pull Request.


make a few type aliases in ibc-union-spec public

we want to use them

please edit your commit message to follow conventional commits (contributing guide)


Handle nil RequestCtx inside getValue

Should resolve #15 issue.

Coverage remained the same at 100.0% when pulling 5893f38bea95bdde4c76f615890fc98ea8fc7ec3 on palestamp:master into e26e6aa19420cdd450e1768712879823f29e48ec on buaazp:master.

Coverage remained the same at 100.0% when pulling 5893f38bea95bdde4c76f615890fc98ea8fc7ec3 on palestamp:master into e26e6aa19420cdd450e1768712879823f29e48ec on buaazp:master.


How to access a WSL folder from a new operating system on a separate SSD?

Hi, I had to install Win10 on a new SSD because there were problems with the booting operation of the previous Windows 10 OS.
The SSD on which the previous Windows 10 is installed is OK and all the files can be accessed, this drive named D:\
In the previous Win 10, I have a lot of important works and files in my WSL2 system.
How to access a WSL folder from the new operating system on a separate SSD, while the rest of the previous operating system with WSL2 is on another SSD?
I tried: \wsl$ and get that the network path was not found. Just in case, I tried D:\wsl$ but Windows can't find it.
Thanks.

@AsafYus if you didn't change the default location, WSL installs the VHDX for each distro in C:\Users\<username>\AppData\Local\Packages subfolder corresponding to each WSL distro . Search your old SSD for *.vxdx and import it to a new WSL instance. For Ubuntu on my system the virtual hard driver is at:
C:\Users\tux\AppData\Local\Packages\CanonicalGroupLimited.UbuntuonWindows_79rhkp1fndgsc\LocalState\ext4.vhdx

@elsaco OK, I have this file.
I have number of distros on old SSD, what is important to me is the files that I had in Ubuntu 20.04.
So what I need to do is install WSL2 in the new system, then install Ubuntu 20.04 as usual, it will create a similar folder in drive C and then I will just copy the ext4.vhdx file to the new folder and then all the files I had will appear?
Thanks.

?

Thank you @elsaco You saved me. my WSL2 crashed trying to do an ubuntu dist-upgrade. With your help i was able to mount my old WSL2 install in my new one and recover.


Xcode 7.x support

As Title, Thx and Plz.

xcode 7.2 doesn't work. Don't support???

Should work as soon as #60 is merged. Thanks for the report! :clap:

Version 7.2 (7C68) doesn't work. Try manual and alcatraz.

Version 7.2 doesn't work too

7.3 is coming out.

Im using 7.3, can confirm it doesn't work, really want to try this! it looks awesome.

It's working really well for me. Am currently using Xcode 7.3 and here are the tweaks I've made in order to get the plugin to work.

Go to your plugins directory: CMD+SHIFT+G and enter the following path ~/Library/Application Support/Developer/Shared/Xcode/Plug-ins
Locate the CodePilot3.xcplugin, right-click on it and select 'Show Package Content'
Edit the Info.plist file which is inside the Contents folder and add a value key to the DVTPlugInCompatibilityUUIDs key. The value of the string is ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C
Save the file, quit and reopen XCode, then load the plugin in the prompt window.
That's it. You should now able to see the plugin option in File -> Code Pilot.

Hope it helps :)

@Bionik6 Thanks for you, now it work very well

Xcode 7.2.1. CodePilot is still not working after changing the info.plist. Tried manual and alcatraz. There's no Load Bundle window when reopening Xcode.

Should be fixed with #60


es6 conversion

issue #23
converted string concatenation to template literals and var to let and const

LGTM :+1:


Is it possible to add support for IPCT tags to edit keywords?

I am looking to add the Title, Description and Keywords field to image metadata but the library does not support IPTC tags.  Will it support it in the future?

No.


Reloading on windows seems broken

Checklist

[X] I have read through the manual page (man fzf)
[X] I have searched through the existing issues
[X] For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version
0.52.1 (6432f00)
OS

[ ] Linux
[ ] macOS
[X] Windows
[ ] Etc.

Shell

[ ] bash
[ ] zsh
[ ] fish

Problem / Steps to reproduce
When running the following command on a large codebase on windows:
fzf --ansi --disabled --bind="change:reload:rg --line-number --column --color=always {q} 2>&1"

Changes in input do not trigger a reload. For example entring main the search will stay stuck on m this only happens on windows though testing the same command on Linux yields the expected results.
I tried with setting $env:SHELL=powershell and forcing $env:SHELL=cmd and I still have the issue. Also tried using ctrl-r event rather than change and I have the same issue. I'm wondering if killing the process on windows is somehow broken or not fulling implemented (saw a FIXME in the code regarding process groups but seems to be related to previews)
Rg version:
ripgrep 14.1.0 (rev e50df40a19)
Also tried with older versions of fzf going back to 0.41 without luck.

e042143e3f983d7bd18a89bee1f9c19b7b6bd3b0 should fix the issue (it's on devel branch).
You can test it with this binary:
fzf.exe.zip

e042143 should fix the issue (it's on devel branch).
You can test it with this binary: fzf.exe.zip

Thank you sir! I had to build the branch myself since Windows Defender was acting up with the posted zip and gave it a test, the fix works and have the expected behavior!


refactor!: remove default protocols and iroh-cli

Description
As previously announced and planned, this removes all protocol implementations from the iroh crate, as well as removes the iroh-cli crate.
The core functionality of those protocols, including RPC & CLI now is in the individual crates.
Remove from iroh

[x] iroh-docs
[x] iroh-blobs
[x] iroh-gossip

Examples

[x] Move examples to the appropriate repos: https://github.com/n0-computer/iroh-blobs/pull/15

Tests

[x] Move the remaining tests to the appropriate repos

CLI

[x] Remove

Breaking Changes

iroh-cli removed

the crate itself
the ability to run iroh itself in a docker container, as there is no binary anymore

removed

iroh::blobs use iroh_blobs
iroh::docs use iroh_docs
iroh::gossip use iroh_gossip
iroh::client::blobs use iroh_blobs::rpc::client. a memory client is available on Blobs
iroh::client::tags use iroh_blobs::rpc::client. a memory client is available on Blobs
iroh::client::gossip  use iroh_gossip::rpc::client. a memory client is available on Gossip
iroh::client::docs  use iroh_docs::rpc::client. a memory client is available on Docs
iroh::client::authors  use iroh_docs::rpc::client. a memory client is available on Docs
iroh::node::MemNode, use Node directly
iroh::node::FsNode, use Node directly
iroh::node::Node::local_pool_handle
iroh::node::builder::DocsStorage
iroh::node::builder::Builder::enable_gc_policy
iroh::node::builder::Builder::enable_docs
iroh::node::builder::Builder::register_cb_done
iroh::node::builder::ProtocolBuilder::local_pool_handle
iroh::node::builder::GcPolicy
iroh::util::progress
iroh::util::path::IrohPaths::BaoStoreDir
iroh::util::path::IrohPaths::DocsDatabase
iroh::util::path::IrohPaths::Console
iroh::util::path::IrohPaths::DefaultAuthor

iroh::node::Builder has no more generic parameters anymore
iroh::node::Node has no more generic parameters anymore

Notes & open questions
Change checklist

[x] Self-review.
[x] Documentation updates following the style guide, if relevant.
[x] Tests if relevant.
[x] All breaking changes documented.

So what's the plan now. Ideally we will set up an iroh-net based example which just tests the connectivity & pipes and we plug that back into netsim and sort out the blobs story on its own.
Also the docker files should not be removed as we still build images for iroh-relay and iroh-dns-server which are arguably much more important anyways. I just need to adapt the images & CI.

Also, there seems to be a lot of reformatting of yaml files.

yeah sorry, fighting my temporary editor..


Doc fixes

Status
Ready
Related Issues
fixes: link to the issue
Description
Fix for relative links with <img.. tag.
Screenshots
Paste here any images that will help the reviewer

@ShahafBenYakir small fix to faq doc

@Itay4 fix for broken relative image link can be seen here: https://pull-request-473--demisto-content-docs.netlify.app/docs/reference/integrations/proofpoint-protection-server-v2


Litmus-Docs mobile view has to be fixed

Visit https://docs.litmuschaos.io on your phone. You will see the header and content mixed up a bit.
One option is to remove the links to Github, Slack and Chaos Hub from the header links, as we have already mentioned them in footer.
File to edit is
https://github.com/litmuschaos/litmus-docs/blob/staging/website/siteConfig.js

Is this a BUG REPORT or FEATURE REQUEST?
Choose one: BUG REPORT or FEATURE REQUEST

What happened:
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

May I take up this one?

@aswathkk, you can take it up

Looks like we are using an old version of Docusauraus.
They already resolved these problems in the newer versions.
See this PR

Thanks @aswathkk For upgrading the Docusauraus version

There is still some improvement is required for mobile view anyone can take this UP

@chandankumar4 What are those?
I think we can add it as issues.

Thanks for taking my query @aswathkk
I'll pick this up & try to fix this today.
നന്ദി സുഹൃത്ത്

I WANT TO WORK ON THIS

@gshanbhag525
Sorry, @msj2 is already working on it.

@aswathkk Sorry for not informing prior working on it. I've fixed it in https://github.com/aravindvnair99/litmus-docs/commit/35aee6d797065be335ab6513235446ff43815e1d and submitted a pull request as well at https://github.com/litmuschaos/litmus-docs/pull/70

Is this fixed or still open?@umamukkara

@umamukkara I've fixed this in  https://github.com/litmuschaos/litmus-docs/issues/68

There are some improvements in mobile view post docusaurus upgrade https://github.com/litmuschaos/litmus-docs/pull/44 & https://github.com/litmuschaos/litmus-docs/pull/70, but issues do exist. These will be raised separately & tracked.


CompositeMetadata Metadata Length is one byte less than real length

Any one can tell me why encoding_length - 1
https://github.com/rsocket/rsocket-py/blob/ae62f6222206db9394e224bd4a519fbd800ed3aa/rsocket/frame_helpers.py#L49
For example, if input of serialize_128max_value  is [0x12, 0x34, 0x56], the returned value is [0x02, 0x12, 0x34, 0x56],  does this meet rsocket's requirements

def serialize_128max_value(encoding: bytes) -> bytes:
    encoding_length = len(encoding)
    encoded_encoding_length = encoding_length - 1  # mime length cannot be 0

    if encoded_encoding_length > 0b1111111:
        raise RSocketMimetypeTooLong(encoding)

    serialized = ((0 << 7) | encoded_encoding_length & 0b1111111).to_bytes(1, 'big')
    serialized += encoding
    return serialized

If i remember correctly:
The mime length is encoded as 7 bits. the values which can be encoded in 7 bits are 0 to 127. since the mime-type length cannot be 0 (according to spec) , this value range can be shifted to actually be 1 to 128 by mapping the value to the range 0 to 127, and then mapping it back when decoding. this is the -1 and +1 which happens in the code.
The reverse of this is at the following method, with the same comment of "mime length cannot be 0".
def parse_well_known_encoding(buffer: bytes, encoding_name_provider: Callable[[int], V]) -> Tuple[bytes, int]:
    is_known_mime_id, mime_length_or_type = parse_type(buffer)

    if is_known_mime_id:
        metadata_encoding = encoding_name_provider(mime_length_or_type)
        offset = 1
    else:
        real_mime_type_length = mime_length_or_type + 1  # mime length cannot be 0
        metadata_encoding = bytes(buffer[1:1 + real_mime_type_length])
        offset = 1 + real_mime_type_length

    return metadata_encoding, offset

If i remember correctly:
The mime length is encoded as 7 bits. the values which can be encoded in 7 bits are 0 to 127. since the mime-type length cannot be 0 (according to spec) , this value range can be shifted to actually be 1 to 128 by mapping the value to the range 0 to 127, and then mapping it back when decoding. this is the -1 and +1 which happens in the code.
hence the 2 variables encoded_encoding_length and encoding_length. there can be a better naming convention for this in order for the code to be more clear.
The reverse of this is at the following method, with the same comment of "mime length cannot be 0".
https://github.com/rsocket/rsocket-py/blob/ae62f6222206db9394e224bd4a519fbd800ed3aa/rsocket/helpers.py#L106
def parse_well_known_encoding(buffer: bytes, encoding_name_provider: Callable[[int], V]) -> Tuple[bytes, int]:
    is_known_mime_id, mime_length_or_type = parse_type(buffer)

    if is_known_mime_id:
        metadata_encoding = encoding_name_provider(mime_length_or_type)
        offset = 1
    else:
        real_mime_type_length = mime_length_or_type + 1  # mime length cannot be 0
        metadata_encoding = bytes(buffer[1:1 + real_mime_type_length])
        offset = 1 + real_mime_type_length

    return metadata_encoding, offset

Thanks for your reply, I get it. ^_^


Pure dynamic schedules not working, Schedule empty!
Scheduling environment polling job for -fa1b-4853... (set_schedule)
Scheduling environment polling job for -89c5-40a4... (set_schedule)
Scheduling environment polling job for -8367-4e06... (set_schedule)
(Sidekiq::Scheduler.reload_schedule!)
2016-08-26T18:38:07.849Z 10005 TID-7ltrg INFO: Reloading Schedule
2016-08-26T18:38:07.852Z 10005 TID-7ltrg INFO: Loading Schedule
2016-08-26T18:38:07.852Z 10005 TID-7ltrg INFO: Schedule empty! Set Sidekiq.schedule
2016-08-26T18:38:07.856Z 10005 TID-7ltrg INFO: Schedules Loaded

get_all_schedules shows the dynamic scheduled jobs... however they never fire and I see the error above.
init:
require 'sidekiq/scheduler'

Sidekiq.configure_server do |config|
  config.on(:startup) do
    Sidekiq::Scheduler.dynamic = true
  end
end

If you plan queue jobs from sidekiq thread, try to set dynamic in initializer like so
# config/initializers/sidekiq_scheduler.rb

require 'sidekiq/scheduler'
Sidekiq::Scheduler.dynamic = true

I queue jobs only in Unicorn thread:
# config/initializers/sidekiq_scheduler.rb

require 'sidekiq/scheduler'

Sidekiq::Scheduler.dynamic = true

if Rails.env.production? && (defined?(Rails::Server) || defined?(Unicorn))
  Sidekiq::Scheduler.enabled = true
  scheduler_options = {
    dynamic: true,
    enabled: true,
    schedule: nil,
    listened_queues_only: nil
  }
  schedule_manager = SidekiqScheduler::Manager.new(scheduler_options)
  schedule_manager.start
elsif Rails.env.test?
  Sidekiq::Scheduler.enabled = true
else
  Sidekiq::Scheduler.enabled = false
end

I mannualy start SidekiqScheduler::Manager to dynamicly fetch recurring jobs because this gem start SidekiqScheduler::Manager only in Sidekiq (by Sidekiq.configure_server) see https://github.com/moove-it/sidekiq-scheduler/blob/master/lib/sidekiq-scheduler.rb

i am having a similar issue. I set dynamic to true and added a new worker to scheduler.yml file after the server was running and it was not registered.  Do not how to fix this without initializing another manager object after initialization like suggested  ^

Hello @avongluck-r1soft
As @artem-russkikh, dynamic flag must be set before startup. There was an error in README.md, it's fixed now, the following is just another way to set that flag:
Sidekiq.configure_server do |config|
  # This block only runs when sidekiq is running in server mode
  Sidekiq::Scheduler.dynamic = true
end

You can also specify that flag in config/sidekiq.yml
:dynamic: true

How are you invoking set_schedule? Here's an example:
Sidekiq.set_schedule(
  'bye',
  {
    class: 'ByeWorker',
    cron: '20 * * * * *',
    queue: 'high',
    description: 'puts bye'
  }
)

You should see an output like this in sidekiq logs:
2016-08-30T04:42:23.719Z 1843 TID-osohzpuxo INFO: Updating schedule
2016-08-30T04:42:23.721Z 1843 TID-osohzpuxo INFO: Scheduling bye {"class"=>"ByeWorker", "cron"=>"20 * * * * *", "queue"=>"high", "description"=>"puts bye"}
2016-08-30T04:42:23.721Z 1843 TID-osohzpuxo INFO: Schedules Loaded
2016-08-30T04:43:20.024Z 1843 TID-osohzpuxo INFO: queueing ByeWorker (bye)
2016-08-30T04:43:20.025Z 1843 TID-osohzxgvw ByeWorker JID-d7e3b0530edb4b38f6f8fbd4 INFO: start
bye
2016-08-30T04:43:20.025Z 1843 TID-osohzxgvw ByeWorker JID-d7e3b0530edb4b38f6f8fbd4 INFO: done: 0.0 sec

Thanks, i'll give that a try.  Any known performance hit of creating a large number of scheduled items?  I have a large database of objects (a few thousand) which need poll a REST url every 5 minutes for changes... thinking of creating a scheduled job for each item in the database.

I think you should take into consideration two aspects: memory consumption and jobs execution time.
I made a test with 20_000 scheduled items, the memory usage went from 28MB to 1.7GB (it depends on the size of the schedule metadata you push with set_schedule). The jobs where pushed to sidekiq (sidekiq-scheduler is responsible only of pushing jobs into sidekiq) timely every 5 minutes.
If you have a REST request/response cycle + a DB hit (a SQL UPDATE) of let's say 0.1 sec, and you have 16 sidekiq workers, performing a batch 20_000 jobs will take 125 sec (number_of_jobs * job_time / number_of_workers). If the jobs take 0.5 sec to complete, the whole batch will take 625 sec (10 min) so the next batch will be pushed into sidekiq in a timely manner but sidekiq will execute them with a delay of 5 min and so on (because is busy running the first batch).
You'll need to test your system in order to estimate how long it will take each batch and how much memory will be consumed, perhaps you could have cluster in order to split the workload.
Have you thought of some other alternatives instead of having thousands of schedules?

My old model with resque was 5 workers chewing through a bunch of ActiveJobs.  I pass each database object as the argument to the ActiveJob via a task
task poll_things
  for each thing in database
   queue up new job (thing)
 end
end

cron every 5 minutes, rake things:poll_things

There really doesn't seem to be a way to do this via the scheduler as it operates on jobs directly (and there isn't a task layer to dynamically do multiple Jobs at a specified time.

How about having one job running every 5 minutes, and that job will enqueue another job for each database object?
:schedule:
   poll_things:
     every: ['5m']
     class: PollThingsWorker
     queue: high

class PollThingsWorker
  include Sidekiq::Worker

  def perform
    Thing.find_each do |thing|
       RefresherWorker.perform_async( ... )
    end
  end
end

Having this will resemble your old approach. Instead of having a cron and a rake task, you'll have a cron via sidekiq-scheduler and a worker, that's the main motivation for sidekiq-scheduler: removing the combination of cron + command.
Instead of queueing a new job for every thing, you could send a batch of things to the job that makes the request to the REST API, I'm saying that because enqueing a job has some cost (it needs to send a command to Redis and then fetch the serialized job)

Hello @avongluck-r1soft, do you have any update on this?


Add validation for timestamp

Signed-off-by: Daniel Blando<EMAIL_ADDRESS>
What this PR does: Draft for https://github.com/cortexproject/cortex/issues/4461
Which issue(s) this PR fixes:
Fixes #
Checklist

[ ] Tests updated
[ ] Documentation added
[ ] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Hi @danielblando, thanks for this.
Your draft seems reasonable; if you could add the configuration (default 5 min is fine) and fix the lint error, that would be great!


support larger queries in /buildQuery.json

Calling GET /buildQuery.json with a large query string (>100KB) returns a 400 Bad Request error.
This patch allows posting to the buildQuery.json route and increases the bodyParser.urlencoded size limit from 100KB to 5MB.

wow, what do you have that is > 100kb?  Amazing that even will work.
It didn't pass the lint tests above, can you use === and !== please and then I can merge.


404 in API reference for Docker ID accounts API

File: docker-id/api-reference.md, CC: @johndmulhausen
Docker.io does not work for me, it redirects me to docker.com. Is this documentation still valid. What are the valid endpoints for this API so I can try some examples? Thanks.

This API has been deprecated and the doc removed


mumble: Failed to execute lsb_release

Issue description
OSInfo: Failed to execute lsb_release
It would be nice that the anonymous usage statistics include NixOS, so people see that it exists and is used!
Depends on https://github.com/NixOS/nixpkgs/issues/22729
Steps to reproduce
Start mumble the first time and allow anonymous usage statistics to be sent.
Technical details
mumble is installed from unstable.

system: "x86_64-linux"
host os: Linux 4.14.84, NixOS, 18.09.1446.db561c90ef3 (Jellyfish)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.1.3
channels(davidak): ""
channels(root): "nixos-18.09.1446.db561c90ef3, nixos-hardware, nixos-unstable-19.03pre159472.80738ed9dc0"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Orthogonal to fixing lsb_release, we could also propose the mumble project to use /etc/os-release. It is standardized and easy to parse.

@Mic92 that might be an option here, but generally there might be projects that won't care, so supporting lsb_release would be good. Steam also don't detects the OS, but no idea how they try to detect it.
I will ask upstream.

Upstream will provide a fix for this eventually I hope: https://github.com/mumble-voip/mumble/pull/3571/files


Traccar doesn't work via HTTPS protocol?

Tittle is my question basically, is there any way to work via HTTPS protocol?

I'm using apache mod_proxy, I think you can use nginx also, on some pages it gives warning it is partially encrypted and images are not, maybe because some external http:// content, tiles or something else..

But default web server Jetty

apache mod_proxy example:
SSLEngine On
SSLCertificateFile ....etc etc
SSLProxyEngine On
ProxyRequests off
ProxyPreserveHost On
ProxyPass / http://localhost:8082/
ProxyPassReverse / http://localhost:8082/
I dont know about default web server Jetty.. maybe Owner will know, good luck

Thank you for response

Jetty is embedded server used in Traccar. Although Jetty can support HTTPS connection, there are no plans to enable it at the moment because it makes code and configuration more complicated. As @nelim  pointed out, you can easily set up Apache proxy to enable secure connections.


MINOR, VIZ Remove superficial bracket from tfr image plot title

Closes #6282
@drammock

What's up with the _pytest.warning_types.PytestUnknownMarkWarning errors on Python 3.7? Did anything break with some update?

Yeah looks like a pytest update is angry about our slowtest marker, should be fixable with conftest.py or setup.cfg update, will look now


[QUESTION] The return result changed like this  "faceFeatures"

I use postman post a image get json result. but it add ' \'in the key  \"faceH\": \"136.88063\", \"faceW\": \"129.02844\", \"faceX\": \"1146.832\", \"faceY\": \"144.49599\"}, {\"faceFeatures\"
how can i drop it

I imagine you solved your problem, thanks for closing the issue :+1:


Confirmation of grid algorithm

The h3 docs cite [1] as a reference for the icosahedral discrete global grid system algorithm h3 employs.  That paper mentions a number of algorithms, notably one they call the "Icosahedral Snyder Equal Area aperture 3 Hexagon (ISEA3H) Geodesic DGGS."  This algorithm seems also to be implemented in an R package by Sahr and Barnes.
Does H3 employ the ISEA3H algorithm?  If not, is there a publication describing the algorithm that H3 uses to generate its DGGS?  If so, is there a publication or other documentation of the parameters provided to the ISEA3H algorithm to generate the various levels and orientations of the H3 grids?
Cheers
[1] Sahr, Kevin, Denis White, and A. Jon Kimerling. "Geodesic discrete global grid systems." Cartography and Geographic Information Science 30.2 (2003): 121-134.

No, H3 does not use the ISEA3H algorithm. The base algorithm is described on the page you linked - I don't think we have more in-depth documentation. Key differences between H3 and ISEA3H include:

The aperture - 3 in ISEA3H and 7 in H3
The grid projection - ISEA uses the Snyder Equal Area projection, while H3 uses a gnomonic projection. This means that H3 is not truly equal-area - see this table or this visualization to understand area variation across the grid - but projection is somewhat faster and cell boundaries are proper spherical polygons, with great-arc edges.

@sahrk may have more details here.

So H3 is using an Aperture 7 subdivision with gnomonic projection for each icosahedron face. It is derived from @sahrk's DGGRID but there was no explicit effort to maintain compatibility between the two (the requirement for H3's index to bitpack all of the relevant data into a 64-bit integer essentially required that incompatibility).
H3 does not implement ISEA3H, but I don't remember the exact terminology.

@dfellis hit all the high points. ISEA3H is a pure aperture 3 grid; H3 has an unindexed initial aperture 3 and 4 (to form the base cells) followed by the indexed pure aperture 7 grid. H3 uses a polyhedral face-centered gnomonic. Both are created on icosahedrons, but the orientation relative to the earth is different. ISEA3H uses an orientation which is symmetrical about the equator, while H3 uses Bucky Fuller's Dymaxion orientation that places icosahedral vertexes (and thus the 12 pentagonal cells) in water.
If you're interested in a more detailed description and taxonomy of these types of grids, a better reference (which didn't exist yet when we created H3) would be:
Sahr, K. 2019. Central Place Indexing: Hierarchical Linear Indexing Systems for Mixed-Aperture Hexagonal Discrete Global Grid Systems. Cartographica: The International Journal for Geographic Information and Geovisualization, 54(1):16-29.


[2/2] Add Image Ops for Data Augmentation

Part 1: https://github.com/tensorflow/addons/issues/1333
As part of #1226, relevant image ops need to be added to tfa.image. List of ops tracked in this issue (tick the op only once the corresponding PR is merged):

[x] to grayscale
[ ] color jitter
[ ] color jitter nonrand
[ ] color jitter rand
[ ] compute crop shape
[ ] center crop
[ ] distorted bounding box crop
[ ] crop and resize
[x] gaussian blur
[ ] random crop with resize
[ ] random color jitter
[ ] random blur
[ ] batch random blur

Reference: https://github.com/google-research/simclr/blob/master/data_util.py

@gabrieldemarmiesse, @dynamicwebpaige does this issue is meaningfull for Tensorlfow.

@vinayvr11 Closing #1342, create separate PRs for each op.

Sure @Squadrick i will make seperate PR for all operations.

@gabrieldemarmiesse The list does not contain Canny Edge detection. But it is useful functionality an is contained in almost all Standard image processing libraries. Should it be added?

@gabrieldemarmiesse The list does not contain Canny Edge detection. But it is useful functionality and is contained in almost all Standard image processing libraries. Should it be added?

About image processing I think that we need to think about priorities:

Is the op useful for image (auto)augmentation/preprocessing?
Is the op useful for postprocessing the network output?
if are not in the first two cases what is the use case of that specific op VS a network that learn that task (e.g. in the edge detector case see https://arxiv.org/abs/2003.08235 just to mention a recent work)? Are we planning to contribute a differentiable version of the ops to learn that task?

In the first two case, as an example, see how many Opencv calculators  (search for cv::)  mediapipe still need to implement in its demos other then tensorflow inference.

Per https://github.com/tensorflow/addons/issues/1226#issuecomment-634755922 the autoaugment/randaugment features will be a part of https://github.com/keras-team/keras-cv
Apologies for not being able to present this information sooner to the contributors.


Implement initial FilecoinRecordInterpreter

Implement the initial FilecoinRecordInterpreter specified in #14.
Fixes #15

@hannahhoward a quick heads-up: now that #14 is merged I have reflected the changes in my PR and removed forked code. Thanks


⚠ SceneTime has degraded performance

In 6707b16, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 2834 ms

Resolved: SceneTime performance has improved in 39dceab after 9 minutes.


How to mark field as invalid after server validation?

Hello. Is it possible to add server validation to the form?
Here the description of expected workflow:

User submits the form
Server validates data
On incorrect data server return error messages
Client marks fields as invalid + display error messages per field
On any field value change field is marked as valid and error message is hidden

That's an enhancement. And the problem is that REST doesn't standardize validation error reponses at all. So I guess the answer for that will be #777

After the addition of onSubmitError, is it possible to display error messages below each field? In the example, you only used notification.log('...'), which only set an error message for the whole form.

You'll have to override the default maField template to display these error messages close to the field. We use angular's built-in form validation, which doesn't support this out ouf the box.

Hello,
Please, I am trying to use the onSubmitError handler but I am getting the following error:
users.creationView(...).onSubmitError is not a function

Did you use ng-admin from master branch? #833

No, I have just used it. and the following error appeared
TypeError: t(...) is null


New set_center() implementation and axes in find_origin()

OK, here is the abel.tools.center.set_center() rewritten completely:

Should behave correctly for all reasonable parameters.
Doesn't lose fractional edge pixels (scipy.ndimage.shift() is going to be corrected eventually, but this works with what we have now).
Allows selecting the interpolation order.
Includes a much faster implementation without interpolation.
Allows specifying None in the origin for axes that do not need centering.

Also, the axes argument is added to find_origin...() methods, such that they don't do unnecessary (and potentially unsuccessful) work. Now they return the image center coordinate for unused axis, so passing this to set_center() will have no effect.

Yet another amazing piece of work @MikhailRyazanov!
Your nice code works with my test cases for both integer and float shifts:

One minor comment: scipy.ndimage.interpolation.shift() appears to have moved to scipy.ndimage.shift()

Any chance of adding your image to the docs?

Thanks for reminding! I wanted to but forgot. :–)

Any chance of adding your image to the docs?

Done!
I've also added order to center_image() parameters.

Docs look great.

find_origin_by_slice ... already has the axis parameter ... should be renamed to axes ... adding it to other find_origin...() methods

return the center coordinates

Yes, please do.

OK, done with the axes for find_origin...(). Also corrected the 0.5-pixel shift for even sizes in find_origin_by_slice().

An impressive day's work. Operates correctly for my test cases.

This looks good to me. Are we waiting on anything else to merge?

Thanks, @DanHickstein!

Are we waiting on anything else to merge?

Nothing else. Merging...

Great work on this!!


Concept textarea

Create textarea

[ ] all needed variation
[ ] all necessary states
[ ] dark mode
[ ] keyboard support
[ ] density

Functions

[ ] Can be used in Figma and is available as a component
[ ] Shows all states

Figma

[ ] dev handover
[ ] ux component

documentation

[ ] keyboard support
[ ] property description
[ ] textual documentation
[ ] component grouping

@mj-hof for the first concept, a basic variation is enough, I guess?
Additional functionality like fileupload, quotes, inputadjustemnts (like the github comment box) are not the scope for now, from my pov.


Make to be able select and copy deleted text

I can not select a piece of code that I removed, I can only revert all, but if I need to copy it is not possible

/duplicate of #8226
Please see https://github.com/microsoft/vscode/issues/8226#issuecomment-528103843 for a way that is available at this moment.


Added stop_after_disko and no_reboot to script

This is fixing a bug when running the run-nixos-anywhere.sh script.
Fixes https://github.com/nix-community/nixos-anywhere/issues/389

I cannot find this variable in the script: https://github.com/nix-community/nixos-anywhere/blob/main/terraform/install/run-nixos-anywhere.sh


500 Error with Next-intl Middleware on Vercel Deployment: EDGE_FUNCTION_INVOCATION_FAILED

Description
Encountering a server-side error when deploying a Next.js 14 application with next-intl middleware to Vercel. The deployment fails with a 500 status code, specifically citing EDGE_FUNCTION_INVOCATION_FAILED as the reason. Additionally, a ReferenceError: __dirname is not defined occurs within the ua-parser-js module, as well as in the user-agent and middleware files of next-intl. This error is not present during local development and only manifests upon deployment to Vercel.
Note that previously i worked with next-intl and deployed without a problem. i don't know if it's something to do with the latest next 14 version or next-intl
Mandatory reproduction URL (CodeSandbox or GitHub repository)
https://github.com/Zakisb/aimplifyy
Reproduction description
Deploy to vercel
Expected behaviour
I expected the web app to be deployed.

Can you upgrade to the release candidate and see if the issue persists? The examples in this repo have been updated to Next.js 14 and can be deployed to Vercel flawlessly.

Now during the build i'm getting this error
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './plugin' is not defined by "exports" in /Users/zakisb/Desktop/aimplifyy/node_modules/next-intl/package.json

Updated. now i'm getting this as error

Still the same problem
ReferenceError: __dirname is not defined
at (node_modules/next/dist/compiled/ua-parser-js/ua-parser.js:1:17315)
at (node_modules/next/dist/compiled/ua-parser-js/ua-parser.js:1:17444)
at (node_modules/next/dist/server/web/spec-extension/user-agent.js:27:59)
at (node_modules/next/server.js:8:0)
at (node_modules/next-intl/dist/production/middleware/middleware.js:1:68)
at (node_modules/next-intl/dist/production/middleware.js:1:68)
it's insane.... is there a way to provide a clear middleware in the docs please?

Updated. now i'm getting this as error

The latest release candidate is<EMAIL_ADDRESS>as mentioned at the bottom of https://next-intl-docs.vercel.app/blog/next-intl-3-0. getTranslations was introduced only recently.

In the build logs, i'm getting this warning. i think that's what's causing the error. sorry if that's a dumb question but is it because i'm not using typescript?

I unfortunately don't have any background on that warning, but it shouldn't be related to the usage of JavaScript.
I'll close this issue since there doesn't seem to be an issue with next-intl, I hope you understand.


[JS/JSX][Formatting] Wrong indentation in this very particular case

The Javascript formatter is close to perfection, there is only this particular case where it seems to break.
Before formatting: https://i.imgur.com/JpzSCPS.png
After formatting: https://i.imgur.com/4sz8Wop.png
Extensions list (in case) : https://i.imgur.com/MMV0ZiU.png

VSCode Version: 1.17.2
OS Version: Mac OS 10.12.6

Steps to Reproduce:

Fix manually indentation
Format document

Thank you very much !! :)

what did you expected? JSX is not even a superset of JS.

https://marketplace.visualstudio.com/items?itemName=gogocrow.jsx-beautify

That formatter makes the code looks awful. The original formatter does an awesome job and follows all the ESLint convention 99% of the time. The only exception is my screenshot.
Can it be fixed?
Thank you

Can it be fixed?

its not broken. js-formatter does what it was designed to do - format es-comliant code. JSX is not es-compliant. just because it still does it better in some cases (99% in your case) than a dedicated formatter doesn't mean it has become it's job.

So I am assuming improving it is not an option where only a very little tweak could make it perfectly usable for both kind of project?

According to FAQ, VSC supports JSX natively. Actually I don't know whether this support extends to formatting. If yes then - your bug-report is valid, if not and you are trying to format JSX with JS-formatter - then everything I said is applicable and you are filing a bug report to a wrong place.
If the later is true - a valid JSX code is invalid JS code. "improving" the formatter in such a way would mean the formatter would treat invalid js code as valid and format it accordingly, potentially producing scrambled mess. if you introduce some random unrelated syntax formatting rules into a formatter designed to format a specific sintax - you are opening doors for unforeseen consequences.
Still the best way to go would be to find the formatter code in the VSC repository, fork it into an extension. and improve it accordingly. maybe together with https://github.com/LiShiSangZi.

To be honnest, I would be supprise that the formatter is that good with JSX if it wasn't intended for. I am pretty sure it's only a little bug. If you take a look at the screenshot, you will notice that even the first part of the condition formats properly.
{this.props.readOnly ? ( //Good                               <span>{value}</span>//Good                             ) : ( //Good                               <TextField value={value} type="number" onChange={this.handlePricesChange(width, height)} /> // Wrong                             )} // Wrong

In fact, formatted this way, it is only the inner second condition:
Manually formatted: https://i.imgur.com/5xNjrMF.png
After: https://i.imgur.com/qqLWZ6m.png

Our builtin formatter fully supports jsx. It seems that you are running into this known TypeScript bug: https://github.com/Microsoft/TypeScript/issues/14494
Closing as duplicate of https://github.com/Microsoft/TypeScript/issues/14494


Download all Memories won’t work

Using option « export merged primary + secondary into one image » : it won’t download. After processing the zip, it just prompt « zip will download shortly… » and then nothing happens
tested on mac and windows (800 bereal)

I just tested and it seemed to work for me. Is there any error code in network inspector?


I posted the wrong version for 2.14

This is a fix for that

Greetings,
I'm going to close this Pull Request as there are currently no files being changed. You'll want to submit a PR with your changes.


added scroll animation project and sticky navigation project

Proposed changes:
code of scroll animation project and sticky navigation
Type of change:

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other (please specify)
[ ] This change requires a documentation update

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

LGTM. Nice work @ranjithjupaka


Make sure the node's IP addresses is set in noProxy

Problem:
If you configure httpProxy and httpsProxy, you must also put Harvester node's CIDR into noProxy, otherwise, the Harvester cluster will be broken.
Solution:
Add a webhook to validate the user input; it should reject if the node IP is not included in the no_proxy CIDR range.
Related Issue:
https://github.com/harvester/harvester/issues/4282
Test plan:
The test plan assumes that several hosts are available in the cluster. For the following test cases, the hosts with the following IP addresses are involved:

<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>

Case 1:

Go to Advanced > Settings and then select Edit Settings for http-proxy.
Press Save.
The error message noProxy should contain the node's IP addresses or CIDR. The node(s) <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS> are not covered. is displayed.

Case 2:

Go to Advanced > Settings and then select Edit Settings for http-proxy.
Use <IP_ADDRESS>/27 in the no-proxy form field.
Press Save.
The error message  noProxy should contain the node's IP addresses or CIDR. The node(s) <IP_ADDRESS> are not covered. is displayed.

Case 3:

Go to Advanced > Settings and then select Edit Settings for http-proxy.
Use <IP_ADDRESS>/24 in the no-proxy form field.
Press Save.
The setting is saved and you'll be redirected to the Settings page.

Case 4:

Go to Advanced > Settings and then select Edit Settings for http-proxy.
Use <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS> in the no-proxy form field.
Press Save.
The setting is saved and you'll be redirected to the Settings page.

Hi @votdev,
Could you move the common function (e.g. mpa/slice) to https://github.com/harvester/go-common?
That we could reuse this in various components!
Thanks!

Hi @votdev, Could you move the common function (e.g. mpa/slice) to harvester/go-common? That we could reuse this in various components!
Thanks!

See https://github.com/harvester/go-common/pull/14

LGTM.

@Mergifyio backport v1.2 v1.3


Improve xds logging.

This improves xds logging to make it easier to debug problems interacting with the xds server.
Note that for the code in xds_api.cc that logs the proto messages, I would ideally like to do this using the upb textproto formatting library, and I have code to do that pending in #21941.  Unfortunately, that depends on the upb upgrade in #21905, which is currently blocked on some build issues.  We can't get the upb upgrade done in time for the 1.28 release, but we want better logging to make things debuggable.  So as an interim solution, I have written a bunch of code in this PR to manually dump out the proto files that are of interest to us.
This approach is not nearly as good as using upb's textproto code, for two reasons.  First, it requires a lot more code for us to maintain.  And second, it doesn't print out all fields in the proto, just the ones we've written code to print.  So as soon as the upb upgrade can be completed, we will remove the code that manually prints the protos and replace it with the upb textproto formatter.

Known issues: #22320 #22321 #22322
The objc failure is an infrastructure failure.


Cloud SQL proxy causes significant additional latency

(This may be a duplicate and/or related to #87.)
I've been experimenting with using Cloud SQL Proxy for my PostgreSQL database vs. connecting directly via TCP. To illustrate, here's my Stackdriver Trace latency graph:

Around 18:15 I switched from directly connecting via TCP from GKE to Cloud SQL over to using a Cloud SQL proxy sidecar that my service connects to via a Unix socket (connecting to the proxy via TCP yields very similar results). As one can see, there are a few spikes in latency when the connection pools get warmed up, and then the latency distribution is significantly above the latency before, which was for direct connections.
My Stackdriver Trace spans also indicate that the increase in overall latency can be attributed to an increase in database call latency. Trivial database calls that normally take <=10ms via a direct connection take up to 100ms through the proxy.
Is this expected, can I do anything about it, and, if there is no remedy, what would be the best way to connect to the DB via TCP from GKE? I'm currently using a /16 netmask to allow connections grom GCE, but that's probably bad for production. Also, I'm not sure whether direct traffic to Cloud SQL is encrypted — if you could provide insights into that, that would be appreciated.
FYI, the GKE cluster and the Cloud SQL database are located in the same zone (europe-west3-a IIRC). The database is only ~500 MB right now (fits completely into memory and has appropriate indexes) and has low load. Also, as stated above, I am using connection pooling and have confirmed that that works.

Hi, I checked again and it seems like removing my Pods‘ Kubernetes CPU Limits has indeed resolve die the issue. So the issue was not due to connection pooling, but not due to Cloud SWL Proxy, either.

might be related too: https://github.com/kubernetes/kubernetes/issues/67577
looking at the kernel version in the cos image the available fix should have been backported...


Tests fail because of PEP420 deprecation warnings.

Describe the bug
The following test fails: test_pydev_resolver_plugin.py
Output:
============================= test session starts ==============================
platform linux -- Python 3.10.10, pytest-7.2.1, pluggy-1.0.0
rootdir: /build/source, configfile: pyproject.toml
collecting ... ^Mcollecting 2724 items                                                          ^Mcollecting 5470 items                                                          ^Mcollecting 6883 items / 1 error                                                ^Mcollected 8133 items / 1 error

==================================== ERRORS ====================================
_____________ ERROR collecting tests/test_pydev_resolver_plugin.py _____________
tests/test_pydev_resolver_plugin.py:23: in <module>
    from pydevd_plugins.extensions.pydevd_plugin_omegaconf import (
pydevd_plugins/__init__.py:2: in <module>
    __import__("pkg_resources").declare_namespace(__name__)
/nix/store/qg3jn6cd12kphciq49grn38hk5fzgs0v-python3.10-setuptools-67.4.0/lib/python3.10/site-packages/pkg_resources/__init__.py:2298: in declare_namespace
    warnings.warn(msg, DeprecationWarning, stacklevel=2)
E   DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('pydevd_plugins')`.
E   Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
=========================== short test summary info ============================
ERROR tests/test_pydev_resolver_plugin.py - DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('py...
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 2.21s ===============================

To Reproduce
Run the tests.
Expected behavior
Tests pass.
Additional context

[x] OmegaConf version: 2.3.0
[x] Python version: 3.10.10
[x] Operating system: NixOS
[ ] Please provide a minimal repro

Thanks @GaetanLepage. This is closed by #1069.


enabled hbase region replication (mttr), split commits

Instead of creating a new bespoke node attribute like node['bcpc']['hadoop']['hbase_master']['loadbalancer']['class'], why not simply use the HBase standard hbase.master.loadbalancer.class passed in to node['bcpc']['hadoop']['hbase']['site_xml']?
I would really like to see things like the following all go away in favor of using the direct hbase-site.xml writing ability to avoid having to know custom Chef-BACH-isms which are non-standard to most HBase users.

node['bcpc']['hadoop']['hbase_rs']['storefile']['refresh']['all']
node['bcpc']['hadoop']['hbase_rs']['storefile']['refresh']['period']
node['bcpc']['hadoop']['hbase_rs']['memstore']['lowerlimit']
node['bcpc']['hadoop']['hbase_rs']['meta']['storefile']['refresh']['period']
node['bcpc']['hadoop']['hbase']['client']['primarycalltimeout']['scan']
node['bcpc']['hadoop']['hbase']['client']['pause']
node['bcpc']['hadoop']['hbase']['client']['retries']['number']
node['bcpc']['hadoop']['hbase']['meta']['replicas']['use']
node['bcpc']['hadoop']['hbase']['client']['primarycalltimeout']['scan']
node['bcpc']['hadoop']['hbase']['client']['pause']
node['bcpc']['hadoop']['hbase']['client']['retries']['number']
node['bcpc']['hadoop']['hbase']['meta']['replicas']['use']
node['bcpc']['hadoop']['hbase']['meta']['replica']['count']
node['bcpc']['hadoop']['hbase_master']['hfilecleaner']['ttl']
node['bcpc']['hadoop']['hbase_master']['loadbalancer']['class']

@cbaenziger
I agree it reduces the Chef-Bach-isms if remove the custom attributes and set the site_xml directly.
But I would like to suggest do that in a separate refactoring PR, rather than mix it in this PR.
What do you think?

As the loadbalancer attribute is new it needs to follow the new format; but as this is HBase's default you could also simply drop that attribute. But any settings you are touching should use the calling convention introduced when BACH Friendly was merged.

As long as the region replica placement policy is always included in the default load balancer, I agree we can drop hbase.master.loadbalancer.class in our configuration.
Regarding the calling convention, I agree that following the new guidelines definitely helps, but it still sounds better to me to be consistent with the existing code followed by a refactoring process.

We voted to move all new code and when we touch old code. If we don't do this incrementally it'll keep festering. Luckily itxs a quick change here only affecting a few lines.

Ok, I will update this PR to include the refactoring.

@cbaenziger
Can you please take a look again? Thanks
Meanwhile, I'm testing it.

Hi Lei,
Instead of setting values via generated_values['hbase.region.replica.replication.enabled']          = true in the recipe which can't as easily be overridden or wouldn't be the most expected place to find defaults, I'd recommend setting values via a pattern like site_xml['hbase.region.replica.replication.enabled'] = true in the attributes file.

Agreed

Closing for now due to inactivity. When testing is completed, and we decide to enable MTTR, please feel free to reopen this or create a new version.


References

Hi @adambielski,
I would like to know if you used any literature references to implement the triplet model. I saw that for the triplets selection strategy you used the model referring to FaceNet. Did you base the loss function on any literature reference?
I appreciate if you can help me.

The references I used are listed at the end of the README file ;)


Unrecognised version number: 65

i'm developing an application for android and iOS which communicate with PHP server, i am using RNCryptor to encrypt the data between them.
For both iOS , PHP encryption/decryption are working fine but in android the decryption are not working and giving me org.cryptonode.jncryptor.CryptorException: Unrecognised version number:65.
After tracing your code in Android you are supporting 2 versions of codes "2","3" and my encryption from the server "PHP" is returing 65
So do you have any idea what i'm doing wrong ?

have the same issue(
String to decode: "AwGBfFE6+BAQXP6iS/76r8eyzMlCUrIpGIiCJ1txpMw11hk32ObOniqi41T7BoG7dtXTecn4kOEh8NQQP MUxYzuwCb9kjaDyLcfDcWGh5JxTkA=="
key: "vRmfE690PF8u0123e24W7OdhF37g5e8g"

A (not so wild) guess here, but likely one side is using base64 to encode the output, the other isn't decoding it.

Your guess is correct that decoding money needs to do base64 processing first


Mutualize dynamic channel stuff

This is an effort to mutualize the code of dynamic channels.

@hardening nice! only TSMF and sshagent channels are left :)

Just rebased on last master. I've not done TSMF nor SSH yet (left as exercises for young contributors ;) )

@hardening ready for review or still work in progress?

@akallabeth that's ready for review. It has passed all my tests in valgrind, no leaks so far.


Add setuptools as an explicit dependency

I'm so used to setuptools only being required for building packages that I forgot in this case we actually depend on it directly. So I'm adding it as an explicit runtime dependency.

Ahh yes, common trap… forgetting a dependency.

remote: Resolving deltas: 100% (4/4), completed with 2 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: Changes must be made through a pull request.

… Ohh, tricky.  So I was trying to do the merge from the git CLI.  Protection didn't realise that's what I was doing, and so protectively blocked me.
That said, doing it from the CLI, one must be certain they've got the right branches and that everything is in sync, so lots to get wrong, probably better I get used to doing it through the web interface. :-)

Ah yeah good point, I hadn't even really thought about that, I just set it up to require merge commits out of habit. But I think there is something to be said for forcing certain operations to be done through the website for traceability. One in particular that I did have in mind was forcing releases to be prepared only by CI, not manually. (but that's something you be set up later, of course)

Yeah, no biggie really… historically I've liked to do the merge on the CLI as it's then digitally signed using my key so there's cryptographic proof that I did it and not someone who managed to snatch a Github session token from my browser.
In the scheme of things though, this little detail does not really matter.  The probability of this happening is quite small.  Call it security paranoia. :-)  I think the current set-up will work fine, I've just got to un-train myself from old habits.


proposal: make the internal lockedfile package public

An internal filelock pkg can be found here:
https://pkg.go.dev/cmd/go/internal/lockedfile/internal/filelock
A few projects are implementing file locking [1] but they do not seem to be maintained and I think they are not as nice as the internal filelock pkg I mentioned before. As a result some projects are doing their own version of it [2].
I suggest we make the filelock pkg public as I think this could be beneficial to the mass.
I'd be glad to do it given some pointers, like where to put it ?
Thanks !

[1] File lock projects:
https://github.com/gofrs/flock
https://github.com/MichaelS11/go-file-lock
https://github.com/juju/fslock
[2] Projects that implement their own file locking:
terraform
boltdb

Why not use the exported version at github.com/rogpeppe/go-internal? :)

Hey @mvdan, 🙂  here are a few reasons why I didn't go with it:

the filelock of go-internal is in an internal pkg
importing go-internal makes my go-deps bigger than necessary
it feels wrong, if I find a bug in it then patch it, then I have to make a pull request to go and then wait for it to get merged and then wait for go-internals to update.

the filelock of go-internal is in an internal pkg

I'm not sure why that is, perhaps @rogpeppe or @myitcv can answer. Have you looked at https://godoc.org/github.com/rogpeppe/go-internal/lockedfile? That seems like a public, higher-level version of it.
That aside, sure, there are some upsides to having this in the standard library. But I think the downsides are generally greater:

Once a package is public, it can never have backwards incompatible changes
The standard library can grow, but never shrink in size
Once the number of users greatly outgrows just cmd/go, the maintainers will probably have extra work responding to issues, reviewing patches, and fixing bugs that might not even affect cmd/go

I think a far better proposal would be to include this in one of the official external repos, like x/sync. Once that's worked well for a while, then it can be part of the public standard library. This is the path that context took, for example.

lockedfile fits right to our usage and lockedfile doesn't have the filelock.ErrNotSupported. But yes lockedfile could work here.
Yes, I agree this should probably be in an x/ pkg 🙂, I only suggested we make the filelock pkg public and agree this would be a bit quick to put in the stdlib.

At this point we've been using lockedfile for a full release cycle and it seems mostly fine, modulo what appears to be an AIX kernel bug (#32817). I'd be fine with making it public.
Then the question is where to put it: x/sys, x/exp, x/sync, or someplace else entirely?

It's right at the intersection of sync and sys.
I think lockedfile should be in x/sync/lockedfile
I think that filelock is a bit lower level and could fit in x/sys/filelock ( if we ever make it public ). But these two are may be a bit redundant.

@azr, filelock should remain internal — it's much too subtle to use on its own. (In particular, if you want your program to remain portable, you have to be very careful to stick to a narrow subset of the possible modes of use.)
If folks discover other interesting use-cases for filelock, then we can probably add more ergonomic packages to address those use-cases while still keeping filelock internal.

Given that the author of filelock says it is not ready to be exported, it seems like this is a likely decline.
Leaving open for a week for final comments.

To be clear: I support making the lockedfile package itself public — I just want to ensure that the lockedfile/internar/filelock remains internal to it.

I just want to ensure that the lockedfile/internal/filelock package remains internal to it.

That's fine by me 🙂.
I think I'll put it in x/sync/lockedfile soonish; (unless you think another place is better ).

I misunderstood. Thanks for the clarification, @bcmills. Removing the FinalCommentPeriod label.

I don't think we are ready to add lockedfile to the standard library. It is a peculiar set of functions that does not really line up with the usual things in either os or io. Maybe it would be OK in x/sync but maybe it would be better to start in x/exp to understand if the API needs any adjustments.
If we are going to add a new public package (even in x/exp), I think the next step would be for someone to write a proper proposal doc laying out the API and explaining the decisions, get comments, and so on.
@azr, do you want to do that?

@rsc gotcha ! Yes I want to ! Where should such a proposal doc be written ? Is there a template for that ?

@azr, see https://github.com/golang/proposal#design-documents

Putting proposal on hold for design doc.

Hello there; I created the proposal ( first ever ! ) here https://github.com/golang/proposal/pull/21; I hope it's good enough please feel free to give feedback 🙂 🙂 !

Design doc added at https://golang.org/design/33974-add-public-lockedfile-pkg.

We also now have a solution for the AIX and Solaris EDEADLK bug pending (CL 222277). The workaround is simple (a retry loop), but the justification and regression test are at least non-trivial.

Hello @bcmills, can I already start working on this ? Can I help in any manner ? Thanks !

Hi @bcmills
Jumping in to query the state of this proposal. Since the proposal-hold label has been removed, as per https://github.com/golang/proposal#hold it seems that this proposal could be updated to active

Hi @bcmills
Jumping in to query the state of this proposal. Since the proposal-hold label has been removed, as per https://github.com/golang/proposal#hold it seems that this proposal could be updated to active

It's in the "incoming" list.  We move proposals from "incoming" to "active" as we have bandwidth to handle them.  See https://go.googlesource.com/proposal/+/refs/heads/master/README.md .

It's in the "incoming" list.  We move proposals from "incoming" to "active" as we have bandwidth to handle them.  See https://go.googlesource.com/proposal/+/refs/heads/master/README.md .

@ianlancetaylor I had missed that bit of information. Thank you

@ianlancetaylor I had missed that bit of information. Thank you

any update on making lockedfile package public?

Some the details seem buried...   The proposal process completed and landed the proposal on Mar 10, 2020:  https://github.com/golang/proposal/blob/master/design/33974-add-public-lockedfile-pkg.md
The proposal looks good.  It is unclear how / who to involve to move past proposal.   Any insight @azr ?   Happy to help if there is a need.

@kensipe This proposal has still not been accepted.  I'll put it on the list for faster consideration.

vuln/cmd/govulncheck could also make use of this library.

Is it going to be public anytime soon?


where to put code for flip options

Can Someone tell me where to put this code?
I want to use the flip options
Thank you
{
"name": "Pi Camera",
"id": "Pi Camera",
"rotate": 0,
"verticalFlip": false,
"horizontalFlip": false,
"debug": false
}

If anyone else is still wondering, those options are specified in each camera object you define in your config.json file:
{
"platforms": [
{
"platform": "rpi-camera",
"cameras": [
{
"name": "Pi Camera",
"rotate": 180,
"verticalFlip": true
}
]
}
]
}


remove immutable change for WriteBatch

Signed-off-by: Little-Wallace<EMAIL_ADDRESS>
What have you changed?
I removed some immutable reference of WriteBatch. Because WriteBach does not allow to be change concurrently and every operations put_cf does change content of WriteBatch.
I will add new interface for RocksDB in this issue: https://github.com/tikv/tikv/issues/6724.
And  I need a new WriteBatch to implement this, which need mutable member function. For compatibility with engine_trait, I need to remove Mutable for WriteBatch.
What is the type of the changes?

Misc (other changes)

How is the PR tested?

Unit test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No
Does this PR affect tidb-ansible?

No
Refer to a related PR or issue link (optional)
I will remove the trait Writable and Mutable which both implement for WriteBatch later after this PR has been merged. See Mutable in rust-rocksdb: https://github.com/tikv/rust-rocksdb/pull/438

@brson @hicqu PTAL

At the moment this patch redirects rust-rocksdb to a custom for, so I have tagged it DNM until https://github.com/tikv/rust-rocksdb/pull/438 is merged and this patch updated.

@brson The reason why I need to make WriteBatch into mutable is that I need to implement another type WriteBatch and make them could be unified by one trait. The new type WriteBatch is just like:
struct WriteBatchVec {
     batches: Vec<WriteBatch>;
     idx: u64,
}
impl WriteBatchVec {
   pub fn put(&mut self, key: &[u8], value: &[u8]) {
        if (...) {
            batches.push(WriteBatch::new());
            idx += 1;
         }
          batches[idx].put_cf(key,value);
    }
}

/test

@brson PTAL. The fail test is caused by another case. @hicqu has been working on it.

/test

/run-unit-test

@kennytm PTAL

/run-all-tests

/merge


Release 2.30.1

This .1 release only includes changes to stanc3, the cmdstan sources stay exactly the same, apart from the version change.

[x] Create the Stanc3 Release notes.

- Improved the pedantic mode warning for parameters without priors. The message now highlights when it is safe to ignore it.
- Fixed a bug in the memory pattern optimization where a for loop generated for the function inliner would prevent detection of for loops higher in the control flow graph.
- Fixed an issue with the function inliner when a function local variable had the same name as a variable in the calling scope.
- Fixed an issue where recursive functions which called themselves with a slice of their arguments would lead to infinite template expansion in C++ compilation.
- Fixed a bug in stanc.js where the stanc flags were not listed correctly in the generated C++.
- The imaginary components of complex vectors and matrices are now initialized to NaN to match the real component and behaviour of non-complex vectors and matrices.

[ ] Update the version numbers on CmdStan master branch.
[x] Create the Stanc3 release.
[x] Create x86 CmdStan tarballs (check version, check that the extracted folder is in the cmdstan-version format).
[x] Make sure the CmdStan sources in the tarball have not changed from the 2.30.0 release.
[x] Create non-x86 CmdStan tarballs.
[x] Create conda CmdStan tarballs.
[ ] Make a Stan blog release announcement post (invite users to tests --O1).
[ ] Post an update in the 2.30 release announcement Discourse thread
[ ] Make a Twitter announcement.

Hey, everything should be done now.
FYI we did 2.30.0 from the develop branch last time, so I went in and created a branch v2.30.0 out of it, then branched off that branch to create 2.30.1 + version update
( I will create branch 2.30.0 for math and stan now too )
If someone can double check if everything is fine that would be awesome, thanks!
And as always, thanks @rok-cesnovar for these awesome issues that are super helpful every time!

The tarballs look good at first glance. The stanc3 binaries return the correct version and the cmdstan has the correct version. Running cmdstanr tests now to double-check.
Let's make sure we merge the 2.30.1 branch to the master cmdstan branch once this is confirmed to be good (same for Stan and Math (4.4.0 there)).

As soon as this is done here, I will create PRs and post them here for approval. Thank you for double-checking!

Thanks @serban-nicusor-toptal and @rok-cesnovar! I'm also running the cmdstanpy tests here https://github.com/stan-dev/cmdstanpy/actions/runs/2748213992 but don't expect anything interesting

Tests passed in cmdstanr as well. Tweeted the announcement as well: https://twitter.com/mcmc_stan/status/1552368360670855172
@serban-nicusor-toptal once you merge everything to master, feel free to close this issue. Thanks!

PR for stan: https://github.com/stan-dev/stan/pull/3133
PR for math: https://github.com/stan-dev/math/pull/2799
Seems there are a lot of changes and a few conflicts

For stanc I think we just need a PR to update the release notes

For stan, just the release notes + versions: https://github.com/stan-dev/stan/pull/3134
I see that math is failing, it's trying to run downstream_hotfix (from stan master branch) and failing with
make doxygen
/bin/sh: null: command not found
lib/stan_math/make/libraries:117: *** "Need to set TBB_CXX_TYPE for non-standard compiler other than gcc or clang.".  Stop.
script returned exit code 2

I'm not entirely sure why, I assume because of some discrepancy in code/Jenkinsfile. Does anyone know more about this?
PS: The PR just created is also failing with the same error ( branched-off from master )

I've created a new new PRs:

merge 2.30.1 release into cmdstan develop: https://github.com/stan-dev/cmdstan/pull/1111 ( will need to create a new one after to merge develop -> master )
merge 2.30.1 release into stanc3 master: https://github.com/stan-dev/stanc3/pull/1234

Please find stanc3 PR here: https://github.com/stan-dev/stanc3/pull/1235

PR for merging v2.30.1 cmdstan into master: https://github.com/stan-dev/cmdstan/pull/1112

It seems in this release the minor version is not set properly in compiled executables:
(cmdstan) [brian@FlatTop cmdstan] $ ./bin/stanc --version
stanc3 v2.30.1 (Unix)
(cmdstan) [brian@FlatTop cmdstan] $ ./examples/bernoulli/bernoulli info
stan_version_major = 2
stan_version_minor = 30
stan_version_patch = 0

This also impacts the output.csv version reported.
I don't think this is a critical issue to fix, but it might be important to understand why it occurred

Ah, I think it's because we didn't update stan/src/stan/version.hpp, because we just re-used the Stan branch from 2.30

That is true, please let me know if there's anything we need to do now to fix this or just keep it in mind for future patches ( that follow this specific order I guess ).

I suppose we could now update that in stan-dev/stan so that develop at least reports the minor version of 1, but I don't think this would be worth trying a re-release or anything. @rok-cesnovar?


Regenerate straggling service code.

Looks like this checked in code didn't have some codegen updates. Reran codegen and checked in the code. 😄

Looks good to me!


arabic support

as it mentioned the arabic should use UTF-8 Encoding
but when I try to do it that way after repacking I get question marks instead of the letter I wrote in arabic.
I unpack .subp
edited .xml
repack the .subp using the .xml
unpack .subp again to double check
all thing I translated is shown as ??????? ???? ??? ????

If I remember correctly picking Arabic as the subtitle language isn't officialy supported by the game. There are Arabic bitmap fonts in the archives, but since you can't pick Arabic in the menu the game will continue with the Latin bitmap and fail to look up the Arabic glyphs/characters.
What could work is replacing the Latin font files with the Arabic ones.

yes that right, but I didn't even came to that phase, I'm still on editing .subp but with no luck

this is after editing xml
http://i.imgur.com/HlzP1Ej.png
this is after repacking .subp and unpack it for double check
http://i.imgur.com/c3r3UHC.png

FoxEngine.TranslationTool v0.1.3 should use the encoding specified by the language option (-ara in your case) instead of of the ANSI codepage of your system.
That should fix your issue.


How do you add Html to Table

I have a constructed object that has an html link in it how do I get it to be "clickable" from New-Htmltable

$customobject = [pscustomobject]@{user = 'user1'
name = 'thom'
link = 'https://powershellposse.com'}
new-html -titletext 'test' -useCsslinks:$true -useJavascriptlinks:$true -filepath "c:\temp\thom.html"{
New-HTMLTab -tabname 'summary'{
New-HTMLContent -HeaderText 'summary'{
new-htmltable -DataTable $customobject -InvokeHTMLTags -HideFooter
}
}
}

Use New-htmltable with -InvokeHtmltags switch

You may need to modify that object to add html to it

$customobject = [pscustomobject]@{user = 'user1'
    name                               = 'thom'
    link                               = 'https://powershellposse.com'
    activeLink                         = 'You can use here text or again link'
}
New-HTML -titletext 'test' -useCsslinks:$true -useJavascriptlinks:$true -filepath $PSScriptRoot\Teo.html -ShowHTML {
    New-HTMLTab -tabname 'summary' {
        New-HTMLContent -HeaderText 'summary' {
            New-HTMLTable -DataTable $customobject -InvokeHTMLTags -HideFooter
            New-HTMLTable -DataTable $customobject -HideFooter
        }
    }
}

InvokeHTMLTags is responsible making links and other HTML stuff "active". Otherwise, activeLink would be just a text-based representation of it. But you still need to build that HTML object yourself.

Perfect ... Thank you

Thank you


Projector colors are not correctly shown

in OS 2.0

got to Settings -> Projector
change the background color of the header/footer lines

result: the new color is correctly shown in the projector but not in the projector preview

now go to the main page and refresh also the projector preview

result: the color is still not shown in the preview

I can't reproduce it with current master. Works well for projector live view. (maybe it was an already fixed autoupdate problem)

Confirmed fixed.


logical is_deleted

Is there a reason, why you use an independent field is_deleted instead of querying the deleted_at field for being set?

https://stackoverflow.com/a/35282445/3290946

https://stackoverflow.com/questions/56207631/django-filter-if-field-is-not-none