Cookie Support in Headers through networkConfiguration

Is your feature request related to a problem? Please describe.
Currently it is not possible to provide a cookie using the networkConfiguration of the FhirEngine. Our usecase is for creating patient in the OpenMRS backend.
Overall, when creating a Patient in OpenMRS using POST Patient query, it is required to have a unique OpenMRS Identifier. Out of the multiple ways to create an openMRS Identifier, the most  straightforward way to support offline application is to use location  based identifier generation. Basically a session id is recieved by hitting a REST endpoint & in the POST FHIR request that session-id is added as a cookie.  This way backend generates a unique openmrs ID for that patient.
Describe the solution you'd like
Cookie support in FhirEngine by integrating it in the networkConfiguration.
Possibly something like in this PR: Required changes for cookie support
Describe alternatives you've considered
This would be a straightforward solution. Other alternative would be to make changes in the OpenMRS backend itself.
Additional context
The location based identifier:
 "identifier": {     "extension": [{       "url": "http://fhir.openmrs.org/ext/patient/identifier#location",       "valueReference": {         "reference": "Location/2d9378e3-b99f-42af-a109-f68395141bf3",         "type": "Location"       }     }],     "type": {       "text": "HSU ID"     },     "value": "4444-7"
Would you like to work on the issue?
Yes
cc: @MJ1998 , @jingtang10 & ICRC-team: @icrc-fdeniger , @icrc-psousa, @icrc-jofrancisco

Thanks for your interest in this @parthfloyd
Actually you can provide your own authenticator via ServerConfiguration.
This is what I was looking for in the developer's call. Let me know if it makes sense to you.

@MJ1998 Thanks a ton for looking into this! Actually we are using authenticator for providing the bearer token in header in the application (It's based on FHIR app examples: demo)
However our requirement is to add cookie in the header with the sessionID which indicates the user's location.  We've this requirement to due to the way this unique openMRS identifier generation is handled in the backend.
This commit <MainActivity.kt in particular> gives more context on this: https://github.com/icrc/openmrs-android-fhir/commit/e21843d168270bdfeaebf8097c7f940c4c066424#diff-842352ae1f3d0f4ed093a1c6cbdc3d4a8cac0ba09f6cb56cb8c3010ca7e4b78cR62
Let me know if it makes sense for networkConfiguration to have cookie support in particular or in general a customerHeader support,  incase some backend application have similar requirements. or If I'm off track and we can provide cookie via authenticator.
Let me know your thoughts on this, I'd be down to work on implementation if required.

You are right.
At first I thought the application can provide their own implementation of HttpAuthenticationMethod but its a sealed class.
I am working on probable solutions. I'll get back to you.

@MJ1998 That's great, Thank you so much!
Yes its P1 for us, since its for the patient save. Although it's not a blocker since we've a temporary workaround in a fork, but with this change we can stick to the official repository.

thanks for raising this @parthfloyd. i think we can do this, but i don't know if we should do this.
normally cookies are used for maintaining session on client side, but for restful apis, there isn't the concept of session, so they should be used sparingly. in your case i understand it's used as a seed for a unique id, if this is the case, should you be sending it as part of your http request payload?

@jingtang10 Thank you so much for looking into this!
I agree ideally we shouldn't do this. Hence, we are changing approach & proceeding with change in the backend.
For context, even though the locationId is supplied in the payload, the current implementation of backend expects it to be passed via cookie. We are looking forward to implement change in the backend for the implementation, to accept locationId via the request payload.
cc: @icrc-fdeniger , @icrc-psousa, @icrc-jofrancisco

Closing - feel free to reopen if requirements change - thanks @parthfloyd!


add webserver block to minimal config yaml

added webserver block from example to minimal. without this, the container starts up without a valid listening port on the webserver

The webserver is actually not required and therefore not a minimum configuration value. All the WebUI does is give you a manual run button, show stats in a few graphs, and list the bad files in a table.


Queue name as routing key

This looks like a bug, the queue name is hardcoded as routing key here in Mojo::RabbitMQ::Client::Consumer.

See #5

@kraih Your're right, I believe that all of this:
https://github.com/inway/mojo-rabbitmq-client/blob/4ac402a2f881e0da2b2e1da73ab5e321d97b60bb/lib/Mojo/RabbitMQ/Client/Consumer.pm#L47-L53
should be optional, clearly requested by developer.
IMHO Queue binding is part of RabbitMQ setup, not to be enforced by consumer.
It was made that way as most common case, to speed up some things up for me (100% of my queues have routing_key as queue_name).


⚠ Cioos Pacific CKAN Sitemap has degraded performance

In 583f25b, Cioos Pacific CKAN Sitemap (https://catalogue.cioospacific.ca/sitemap/sitemap-1.xml) experienced degraded performance:

HTTP code: 200
Response time: 11392 ms

Resolved: Cioos Pacific CKAN Sitemap performance has improved in 57c1de9 after 4 minutes.


plasma cutter

About the PR
Plasma cutter
Original pr's by Wizard-Grin and quartuG3
https://github.com/Workbench-Team/space-station-14/pull/208
https://github.com/Workbench-Team/space-station-14/pull/327
BIG THANKS to whateverusername0.
Without his help i would likely give up on making this system work.
Why / Balance
It will improve salvage, sci and everyone else gameplay.
Salvage mines faster -> Sci got more resources -> Station crew got more cool things.
Technical details
The AddCharge method has been added to the BatterySystem. It was introduced to allow quick addition of charge to BatteryComponent, as standard system methods did not allow this.
The GetChargeDifference method has been added to the BatterySystem to fix issue with cutter eating all the plasma.
The TryChangeStorageLimit method has been added to the MaterialStorageSystem to allow changing the maximum capacity of a MaterialStorageComponent
The BatteryRechargeSystem system and its component - BatteryRechargeComponent have been added. This system interacts with MaterialStorage and Battery to add N energy to BatteryComponent and also spawns back any surplus materials that were consumed by MaterialStorage.
Media

Changelog
🆑
add: plasma cutter (can be recharged with plasma sheets)

Is this complete now? In the future don't make a PR until its done or mark the PR as a draft

Is this complete now? In the future don't make a PR until its done or mark the PR as a draft

Yes. It is complete.


2.1.0-preview2 verification: Exploratory testing of inheritance with owned types

@maumar to try inheritance with owned types, combined with:

Data seeding
Value conversions
Enums
Migrations

On a raspberry pi in the cloud :trollface:

@maumar @divega Punt this to RC as well?

Found issue: https://github.com/aspnet/EntityFrameworkCore/issues/11607


Updated api-global.cr to include db manipulations

Added db_list
Added db_create
Added db_drop

Unless I'm mistaken, it appears like the above functions are missing from the driver.

Thanks!


Fixed guest vlan range going missing when using zone wizard

Description

Fixes #4039 - Guest Vlan range will be lost when deploying ZONE

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

This has been tested by creating an advanced zone with the wizard and then checking if the vlan range was set for guest traffic on the physical network.

@blueorangutan package

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔debian. JID-1191

LGTM

2 x LGTMs, functional/manul test OK - regression tests not needed since a simple JS changes.
Merging


Update mr-azure-303.md

OPS Build status updates of commit 450e9f7:
:clock10: Preparing: average preparing time is 50 sec(s)

OPS Build status updates of commit 450e9f7:
:clock10: Incremental building: average incremental building time is 25 sec(s)

OPS Build status updates of commit 450e9f7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/mr-azure-303.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Planet Laika freezes at title (english patch version)

Not sure if this counts as copy protection issue or not since its a English patch but this game would not play it froze at title on cheat cart international v1.3.7 SCPH-7501 verbatim burnt at 8x
after applying
https://www.romhacking.net/translations/6451/
this patch game started freezing using tonyhax international via cheat cart.

you think you will fix this or since its just a patch dose it not really count, anyway I removed video just not going mention it since its a patched game

Is it possible that this patch doesn't work on real hardware? To rule that out I have a mod-chipped SCPH-5501 that I will try to use without any soft-mod.
Does the same happen with UniROM and original Tonyhax v1.4.5?
I looked at the patch notes and I'm not sure if real hardware was ever tried:
Patch Notes/Warnings
We joked a little about this game being an
emulator killer, in that quite a few tried-and-true
emulators just don't work. However, I cleared it
on ePSXe, and others testing it cleared it on
duckstation and Mednafen. If you're having a gameplay issue or
a freeze, feel free to post about it, but also
see if swapping emulators works for you.
Known emulators to break are pcsx and No$psx.
Nothing else so far.
If you happen to find anything, do let us know!

Alright, I just tested this 3 different ways.
SCPH-5501 (non-stealth mod-chip, no soft-mod): Fully playable.
SCPH-5501 (non-stealth mod-chip, with International v1.3.7 GameShark): Fully playable.
Highly think this is a disc read issue so closing for now.

Have a theory on this, hoping it pans out.  Testing possible fix now.

LMAO BRO I FIXED IT FIRST TRY! The downside is that you can't use GameShark codes with this game using my current fix (currently, maybe somehow I might be able to fix that eventually).
So the whole issue is, remember when I first released the gameshark code feature and it only worked on my SCPH-5501 and on no other models of console? That was because the gameshark code feature relies on using 'reserved'/'unused' kernel RAM to store the actual codes it parses during the game by the cheat engine. This area of RAM is 0xD000-0xDF78. Now the issue with the original GameShark code implementation was that every console except the SCPH-5501 was not gaurenteed to have a zeroed out memory region here (even though it is unused for every console model, some garbage AFAICT is stored here in other BIOS/models). That was screwing up the cheat engine parsing routines, which made the gameshark code engine not work on that first build of International that had gameshark support if it was used on literally any other BIOS/model.
So get this, I was looking at this issue and I noticed hey, the SCPH-1000 is working but the SCPH-5501 is not when both are using the same International cheat cart (v1.3.7). So I changed around the code which clears the RAM for the cheat engine to work to only do the clearing of RAM if the cheat engine functionality is active. BOOM! It works on the 5501 now, and every other console!
So how this translation patch works is it is using the 'unused RAM' (the same RAM International needs for the gameshark support, it's literally the same idea, use the unused RAM) for whatever code additions it needs to make the translation work.
v1.3.8 beta 2 works with this game 100% now with all console models. Please confirm for me. This build also has the improved memory card handling for gameshark codes. Just remember, with this specific game, gameshark code functionality will cause this same issue if activated by pressing O to read the memory card.
tonyhax-international-v1.3.8b2.zip
Really great bug report man! Keep it up.


NPM shows the latest package is 2.1.0-preview.0

Even though the latest version is 2.1.0 🙃

Fixed. Thanks for the report!


Add bulk actions

Details
Cleans up the Hold action. This PR does the following:

Adds hold to the bulk action dropdown button
Updates all bulk actions to be available only when all selected items have the specific action available, e.g. only show Delete option when all selected items can be deleted
Navigates user to the Hold reason page
Removes Hold/Unhold as row options since they should only available in the bulk selection dropdown button

Fixed Issues
https://github.com/Expensify/App/issues/39890
https://github.com/Expensify/App/issues/39887
Tests

In App, submit an expense to another user
Open the search page
Select that transaction
Verify that you see the Hold option in the top right X Selected dropdown button
Select hold, enter a reason and submit
Verify that the request to HoldMoneyRequestOnSearch succeeds
Press on the request and verify that you see the Request held RHP

[x] Verify that no errors appear in the JS console

Offline tests
Verify that the Hold option doesn't show up if you're offline
QA Steps
Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos
https://github.com/user-attachments/assets/5c9e8f52-28e4-49fb-adf2-edb12f20b2b5

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@dangrous over to you

I'll just get this merged to continue search development

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.10-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.10-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


"Gallery does not exist" error when using Batch add

Steps to reproduce

Paste gallery link into "Batch add" input box
Press "Add Galleries"

Expected behavior
Gallery is added to library
Actual behavior
Gallery fails to be added to library

Crash logs
No response
Tachiyomi version
1.9.0
Android version
Android 13
Device
OnePlus 9R
Other details

I've tested adding other gallery links using Batch add but they all work fine.
I can also go to my favourites via WebView and find this gallery that the app is saying does not exist.
I've also verified its visibility on two different browser's that I'm signed into E-H on. However, the gallery is shown to be unavailable when I am not signed in.
I've also done a re-login to E-H via the in-app settings for the E-H login.

Acknowledgements

[X] This is a TachiyomiSY specific issue that does not happen in Tachiyomi Preview.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version 1.9.0.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

That gallery is not avalible on E-Hentai, you have to use the ExHentai link to view it

That gallery is not available on E-Hentai, you have to use the ExHentai link to view it

The same error occurs when using the ExHentai link (image of the error), I cannot add it using batch add nor does it show up when I search for it using the source (image link), but I can access it in-app using the WebView from the ExHentai source (image link) (I have used the same search terms for both the in-source search and the WebView search).


Anchor Links

Description
When added to a page, all applicable heading elements in the page between h2 to h6, will have an id assigned if not already present, and anchors will be created for these, where this component has been placed.
Where no id is present on the heading element, one is constructed using the first word of the heading with a counter number postfixed for uniqueness.
Currently no custom css, as default inherited styles are a close match to the visuals provided.
To ignore a heading on the page for the anchor links add data-anchorlinksignore="true" to the heading.
Checklist

[ ] Tested against our testing policy (Resolution, Browser & Accessibility)
[ ] CHANGELOG entry

Hi @Raq-HEE - PR looks Great 👍
Seems like the component creates anchor link for Footer visually hidden heading (
Support links
) as well. Could we not select them if possible ? Thanks!

Hi @Raq-HEE - PR looks Great 👍
Seems like the component creates anchor link for Footer visually hidden heading (
Support links
) as well. Could we not select them if possible ? Thanks!

Have updated code to exclude these.

Added fixes in this to PR to issue reported in the platform PR.

Hi @Raq-HEE - Thanks for the updates. Have added few comments on the platform PR https://github.com/Manifesto-Digital/hee-cms-platform/pull/100. Could you take a look ? Thanks!

Hi @Raq-HEE - Thanks for the fixes, could you resolve the conflict ? Thanks!


Stats: Add the ability to add a StatName to a StatNamePool directly.

Commit Message: Add the ability to add a StatName to a StatNamePool directly.
Additional Description: If one maintains a StatNamePool to reference count symbols, provide a way to add to the pool directly vs needing to stringify.
Risk Level: low / medium
Testing: unit test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@wbpcode for senior maintainer stamp


Floating point precision is limited to 3 decimal places

Floating point values output by Starlark scripts are currently limited to 3 decimal places of precision due to being stored in integer columns by this code:
https://github.com/kentik/ktranslate/blob/159f61bc41f2b6ab5fc537a795c19e5c81d80cb8/pkg/util/enrich/mib_metric.go#L128
Greater precision is desired, should separate storage of floats be added or an arbitrary higher amount of precision selected?

Yes, I think we should add floats map[string] float64 to MibMetric and track them separately. While SNMP doesn't have native floats, there are a number of scenarios for converting SNMP data to float via Starlark.


Adding fail fast var to internal API

I didn't think the internal API would need this fail fast var, but for the internal API to spin up without dependencies it does!

Tested and verified to work in deployment


Reference implementation. Closes #8

Description
This set of changes includes improvements to error handling by raising the CalcError exception with useful error information. It also makes the test_calculator.py (formerly intepreter.py) tests pass and wires the calculator up to the console script entry point given in setup.py. This allows the calculator to be invoked as calc after running pip install -e ..
Check List

[ ] All test passed
[x] Any new functionality or fixes you added is covered by new tests

All tests don't pass? Intentional?

Add a couple of small comments. Potentially add me as a push member on your fork so I can do formatting and code tidying when you're not available?

Yes, all tests don't pass. The token tests are broken.

I'm going to make this a WIP/Don't merge PR instead. I'll change the title again when I feel it's ready.

@rawrgulmuffins: What small comments did you have in mind?

Reading PR now.

This PR was targeted to Red-Green-Refactor:master. Needs to be targeted to red-green-refactor:reference_implementation rather thenmaster.


Add make install target

This PR adds make install target allowing to generate binary version of the Symbiflow toolchain.
Currently it emits all the required binaries and scripts. Architecture definitions files are missing (thus WIP status)

kokoro CI fails because we use quite old cmake (3.7). In the install function I use install(TARGETS) for target defined in a subdirectory. This seems to be supported from cmake 3.13 (https://stackoverflow.com/questions/34443128/cmake-install-targets-in-subdirectories).
@mithro can we update cmake in kokoro? Or should I look for workaround?
(I have tested the arch-defs with cmake 3.13.4 on Debian 10)

@kgugala Does the cmake file specify a minimum version?

@kgugala Does the cmake file specify a minimum version?
right now it says 3.3, but it's too old for the install target.

In kokoro we install cmake with apt. Switching to pip may help - pip has way newer version. If we can update cmake in kokoro I'll bump the minimal required version in cmake file

Should be fixed in https://github.com/SymbiFlow/prjxray/pull/1191 ?

Install target emits all the required files, but pinmap.csv. The problem here is that we generate this file per board, not per device type. Since we switched to non-roi devices we can generate pins.csv file for every device type instead of board.

all the required files seem to be installed correctly. I think this PR is ready for review.

@kgugala Can we test this on CI somehow?

@kgugala Can we test this on CI somehow?

As a concrete example of what we should do:

Run the make install target to a folder
Run a simple Makefile that generates a simple bitstream (e.g. counter) using the outputs
(optional) Convert the bitstream back to a verilog file and run a testbench against the design.

Install target emits all the required files, but pinmap.csv. The problem here is that we generate this file per board, not per device type. Since we switched to non-roi devices we can generate pins.csv file for every device type instead of board.

The current strategy is correct (ish).  The 50T family of designs share the arch/rrgraph, but need a different pinmap.csv, as only the package is different.  If you move the pinmap.csv to the device, you would generate multiple rrgraphs per 50T class device (I believe).
Can you detail what you suggestion is?

How about having TECHMAP_PATH be a property of the device? And then setting the TECHMAP_PATH in the xc7 add_device location?

That's a good idea. Do we have to set it per device? Maybe we should define it in the ARCH? We actually do it for cells sim https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/xc7/make/arch_define.cmake#L22

Maybe we should define it in the ARCH?

Sounds good to me.

Install target emits all the required files, but pinmap.csv. The problem here is that we generate this file per board, not per device type. Since we switched to non-roi devices we can generate pins.csv file for every device type instead of board.

The current strategy is correct (ish). The 50T family of designs share the arch/rrgraph, but need a different pinmap.csv, as only the package is different. If you move the pinmap.csv to the device, you would generate multiple rrgraphs per 50T class device (I believe).
Can you detail what you suggestion is?

here is the tree of the install folder for 50t family
xc7a50t_test/
├── arch.timing.xml
├── channels.db
├── rr_graph_xc7a50t_test.lookahead.bin
├── rr_graph_xc7a50t_test.place_delay.bin
├── rr_graph_xc7a50t_test.rr_graph.real.patched.bin
├── xc7a35tcpg236-1
│   └── pinmap.csv
└── xc7a35tcsg324-1
    └── pinmap.csv

rr_graph_xc7a50t_test.rr_graph.real.patched.bin

It is better to take rr_graph_xc7a50t_test.rr_graph.real.bin as that capnp ensures that edges are sorted correctly.

rr_graph_xc7a50t_test.rr_graph.real.patched.bin

It is better to take rr_graph_xc7a50t_test.rr_graph.real.bin as that capnp ensures that edges are sorted correctly.

fixed

CI is green and I believe all the comments were addressed. @mithro @acomodi can we merge this one?

LGTM. Merging now


Sound Problem

Describe the bug
I made a video call app in react and when someone joining the call from ios device.first time voice not coming if ios user connect headshet and disconnect it then sound coming in the speaker..
To Reproduce
Expected behavior
i want if user join the meeting sound should come to speaker at first
Smartphone (please complete the following information):

Device: [e.g. iPhone5s]

https://www.100ms.live/docs/javascript/v2/how-to-guides/debugging/error-handling#handling-autoplay-error
You should handle this.


componentWillReceiveProps with react 16.9.0

From react 16.9.0, there is now a warning when componentWillReceiveProps is used.
https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

according to the docs, in the nex major release (17.x) the componentWillReciveProps should be removed, making this component not usable in newer projects

Is there any chance this repository will be updated?

@alexkuz Can we move this package to redux-devtools? It's used by redux-devtools-dock-monitor and needs a few updates (including this issue). I just need npm access (methuselah96). Thanks!


Chore/borrow not move

all queries now expect borrowed types
but all helper messages that create various POJO structs still move variables (somehow it didn't feel right to clone them inside, and I preferred to be more explicit about their value consumption, if you see it otherwise do let me know and I'll change it)


Including HTML tags and generating PDF

My descriptions are being generated from HTML text editor and we need to generate PDF considering the description. But when I am including html tags in text , then html tags is being displayed in items
This is what I want to include and should work

var myDoc = new pdf;
		// myDoc.write('downlods')
		myDoc.pipe(fs.createWriteStream('downloads/node.pdf'));
		myDoc.font('Times-Roman').fontSize(24).text('<i>Lorem Ipsum<i> It has survived not only five <i>centuries</i>',100,100);
		myDoc.end();

I have included i tag in the text. How this will work and output will work properly
Please suggest how to achieve it

pdfkit doesn't support html. if you need to render web pages, i'd recommend using wkhtmltopdf or phantomjs which can use an actual web browser engine to generate pdfs.


Server install suggestions with mason still uses LspInstall

As seen here.  However, I believe this is further complicated by the fact that you can't just run :MasonInstall without an argument for a particular server.
This may be something that has to wait until it's available upstream to be able to do something like :MasonInstall lsp or something to have it suggest the correct server for the current filetype, since calculating that is WAY too out of scope for this plugin. Maybe just having it split out some text that says to run the :Mason UI yourself or something so people aren't too confused?
Thank you for this plugin! It saved me hours of frustration after starting a Neovim config from scratch this week.

Glad you liked the plugin.
When using mason.nvim LspInstall is created by the extension mason-lspconfig.nvim. And it works just like nvim-lsp-installer.

Yup, I just realized that right now and was going to close it. I didn't have mason-lspconfig running it's setup().  I'll close this and show myself out.  :)
Thanks again.


html buiding

What is your question?
does html building for this engine work?

why not try to find out?

only 0.6 would work for html5, 0.7+ has abonded the html5 support


How to remove top space in LovelyCustomDialog

use my fork for the project, or maybe just set the background color of the dialog to match your color, just make sure you use the commit version instead of the -SNAPSHOT

It's impossible. If anyone has a similar issue, you're using the library wrong.


Refs #33173 -- Added Python 3.11 to classifiers and tox.ini.

ticket-33173

All green :green_heart: :tada:

Django for workgroups ? 😄

Will this be backported to the 4.1 branch, and the release notes updated to say 3.11 is supported?

Will this be backported to the 4.1 branch, and the release notes updated to say 3.11 is supported?

Yes, I'll do this later today.

See #16230.


chore: add SECURITY.md

Closes: #824
Description

PR author checklist:

[ ] Added changelog entry, using unclog.
[ ] Added tests.
[ ] Linked to GitHub issue.
[ ] Updated code comments and documentation (e.g., docs/).
[ ] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

Just curious if this PR's progress is blocked on anything.

Hey @seanchen1991, we are waiting to be included in the ICF security program - which is due to happen sometime this month.


ESP-IDF 5.1

Hello,
I'm trying to compile some examples using the Visual Studio Extension ESP-IDF, set to 5.1.
Tried setting it to 4.4.x and I get nowhere.
With 5.1 at least it tries to compile.
But it ends with an error, stating some constants are not declared.
Any ideas how to solve this?
~/SenseCAP_Indicator_ESP32/components/bsp/src/boards/sensecap_indicator_board.c:112:25: error: 'GPIO_NUM_45' undeclared here (not in a function); did you mean 'GPIO_NUM_35'?
  112 |     .GPIO_LCD_BL      = GPIO_NUM_45,
      |                         ^~~~~~~~~~~
      |                         GPIO_NUM_35
~/SenseCAP_Indicator_ESP32/components/bsp/src/boards/sensecap_indicator_board.c:166:25: error: 'GPIO_NUM_40' undeclared here (not in a function); did you mean 'GPIO_NUM_30'?
  166 |     .GPIO_I2C_SCL =    (GPIO_NUM_40),
      |                         ^~~~~~~~~~~
      |                         GPIO_NUM_30
~/SenseCAP_Indicator_ESP32/components/bsp/src/boards/sensecap_indicator_board.c:188:29: error: 'GPIO_NUM_47' undeclared here (not in a function); did you mean 'GPIO_NUM_37'?
  188 |     .GPIO_SPI_MISO =       (GPIO_NUM_47),
      |                             ^~~~~~~~~~~
      |                             GPIO_NUM_37
~/SenseCAP_Indicator_ESP32/components/bsp/src/boards/sensecap_indicator_board.c:189:29: error: 'GPIO_NUM_48' undeclared here (not in a function); did you mean 'GPIO_NUM_38'?
  189 |     .GPIO_SPI_MOSI =       (GPIO_NUM_48),
      |                             ^~~~~~~~~~~
      |                             GPIO_NUM_38
~/SenseCAP_Indicator_ESP32/components/bsp/src/boards/sensecap_indicator_board.c:190:29: error: 'GPIO_NUM_41' undeclared here (not in a function); did you mean 'GPIO_NUM_31'?
  190 |     .GPIO_SPI_SCLK =       (GPIO_NUM_41),
      |                             ^~~~~~~~~~~
      |                             GPIO_NUM_31~/SenseCAP_Indicator_ESP32/components/bsp/src/boards/sensecap_indicator_board.c:112:25: error: 'GPIO_NUM_45' undeclared here (not in a function); did you mean 'GPIO_NUM_35'?
  112 |     .GPIO_LCD_BL      = GPIO_NUM_45,
      |                         ^~~~~~~~~~~
      |                         GPIO_NUM_35
~/SenseCAP_Indicator_ESP32/components/bsp/src/boards/sensecap_indicator_board.c:166:25: error: 'GPIO_NUM_40' undeclared here (not in a function); did you mean 'GPIO_NUM_30'?
  166 |     .GPIO_I2C_SCL =    (GPIO_NUM_40),
      |                         ^~~~~~~~~~~
      |                         GPIO_NUM_30
~/SenseCAP_Indicator_ESP32/components/bsp/src/boards/sensecap_indicator_board.c:188:29: error: 'GPIO_NUM_47' undeclared here (not in a function); did you mean 'GPIO_NUM_37'?
  188 |     .GPIO_SPI_MISO =       (GPIO_NUM_47),
      |                             ^~~~~~~~~~~
      |                             GPIO_NUM_37
~/SenseCAP_Indicator_ESP32/components/bsp/src/boards/sensecap_indicator_board.c:189:29: error: 'GPIO_NUM_48' undeclared here (not in a function); did you mean 'GPIO_NUM_38'?
  189 |     .GPIO_SPI_MOSI =       (GPIO_NUM_48),
      |                             ^~~~~~~~~~~
      |                             GPIO_NUM_38
~/SenseCAP_Indicator_ESP32/components/bsp/src/boards/sensecap_indicator_board.c:190:29: error: 'GPIO_NUM_41' undeclared here (not in a function); did you mean 'GPIO_NUM_31'?
  190 |     .GPIO_SPI_SCLK =       (GPIO_NUM_41),
      |                             ^~~~~~~~~~~
      |                             GPIO_NUM_31

Please ignore
I figured how to do it
Setting the target correctly to esp32s3
The esp_coexist.h header is no longer present in 5.1
Commenting it allowed the code to compile
Now to figure how to flash it :)
Thanks


[TEST] run CI1

Why is this PR needed?
run CI
What changes were proposed in this PR?
Does this PR introduce any user interface change?

No
Yes. (please explain the change and update document)

Is any new testcase added?

No
Yes

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4588/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2838/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2846/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4598/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4603/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2853/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4611/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2858/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2863/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4615/


Default download destination should be current directory

Fixes https://github.com/feross/webtorrent/issues/390
I'm not sure if this would be the best way to go about it, but I felt like it didn't belong in the FSStorage module.

Thanks for the PR! Released as 0.57.0.
I also added you as a GitHub collaborator so you can contribute as you see fit. :+1: Nice work!


Version fragmentation problem

Wanted to create a clear place to discuss this. Going to try and outline what the problem is in this description, then going to come back in comments to outline different ways of approaching it, and my idea of how changesets should or shouldn't address this problem.

This problem exists in any instance where you release multiple interdependent packages, and scales with the interdependency of the packages.

The problem
In the simplest form, the problem is that in an interdependent system, you may end up pulling in multiple copies of the same package.
Our first hypothetical:
I am publishing a button component and a modal component. The modal depends on button.
In essence, I get:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
If a user installs both of these packages, modern package managers will 'dedupe' the versions of button, meaning the user has one version.
If however we have:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
If the above user upgrades button, but leaves modal alone, modern package managers will keep the button modal installed 'locked' at 1.0.0 and pull in a new version of button for button itself.
The user now has two copies of the button code that may be nearly identical, and that the semver-ing of modal's dependency on button suggests that there should be no problem with modal using the updated button.
There are two ways this spread occurs:

installing packages released at different times so dependencies cannot be resolved to a single version
installing packages that get 'locked' to resolving transitive dependencies to different versions despite them being semver compatible to dedupe.

How big of a problem is it?
This problem scales very badly with system interconnectivity, system size and release cadence.
Basically the more versions of more packages you have, which have more interdependencies, the worse it will get.
Some monorepo-based projects won't even notice this, or will be completely unaffected. Others may find it a massive drain on their ability to be installed and maintained.
There is also a rare bug case caused by this where in the above, a new version of modal ran and tested in the monorepo might depend on the new feature of button introduced in 1.1.0, but in the release process, modal's dependency on button is not incremented, so someone can upgrade modal and then have a broken code through the transitive resolution.
The solution to this sub-problem seems to be to push version changes from button aggressively into modal, but THIS worsens the fragmentation problem as there are now fewer shared versions between packages.
Tension
Pains with this are completely solved by publishing just one giant mega-package, but that introduces a whole host of other issues:

Upgrading one dependency requires upgrading every dependency, no graceful partial measures
Consumers installing (and shipping if you don't code-split well) code you don't use

Notes
The problem you are trying to solve for is an interrelation between consumer install habits and publisher publish habits.
Most solutions will have trade-offs.

(I need to head home so I'm going to come back and fill this out in a bit)
Ways to lessen the problem
Fewer packages (less interdependency through combining single packages together)
Fewer versions of each package (more changes per version)

(I am considering making this a PR just so I can start making threads of comments off an md doc)

@lukebatchelor you mentioned wanting a larger talk about version fragmentation so I made a thing.
@mitchellhamilton you probably care.


Disable RecentComments not working.

I was wondering how to disable this widget. When starting a new blog and (obviously) nobody has commented yet, the recent comments widget remains empty and tries to load comments that are not there. I disabled recentcomments in the configfile in the gitalk section.
Also, the amount of comments (66 in this case) still seems to correspond with the amount of comments on your own website. https://tridiamond.tech/

Got it, I will look into this one.

Still an issue, I hope you can fix it! :D
Thanks


Optional Docker

Changes

added vscode setup for devcontainer to automatically use our custom Dockerfile
added recommendation for devcontainer in README
added section on Testing to the README
removed Docker check from main.ts
revised README to express that Docker was optional
added git to Dockerfile so /update command works
simplified linting and building npm scripts
prefixed all database-related npm scripts with db:
corrected a few npm script errors
fixed bug where error reporting wouldn't work for interactions that had already been replied to

Closes #67

Sorry guys, one more time.


Fix #443 object merge with same value on same level keys

This solution is a temporary solution as it solves current
problem, but there is still the case for None values.
The best solution for this case would be wrapping all the values
on assignment and give it a full path signature to compare.
Fix #443


Prevent Lucene indexing operations on replicas, gated by an index setting

Description
This change consists of two commits:

Prevent Lucene indexing operations on replica
This change prevents Lucene indexing operations from occurring on replicas, while still writing to the replica translog. Note that the change only affects indexing operations. The logic in IndexShard has been changed to only write to the translog when applying the indexing operation to a replica shard. To allow this, a new addIndexOperationToTranslog API is exposed on the Engine class, which InternalEngine implements using existing translog logic. This code change also refactors the existing indexing logic in InternalEngine into separate internal methods - one that parses the document and prepares the Index object, and another for error handling.
Added index setting for segment replication
For now, this is a boolean final value that simply turns segment replication on/off. The logic in IndexShard has been updated to branch based on this value.

Issues Resolved
N/A
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ x] New functionality has been documented.

[x ] New functionality has javadoc added

[x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Is this a PoC? Trying to understand if you thought of abstracting out a different implementation of Engine and Shard for segment replication instead of using if-else logic.

Consider it a precursor to a POC :) @mch2 is working on the actual segment copy implementation, and we'll all be iteratively pushing up to this feature branch. This change simply disables indexing on replicas as neatly and unintrusively as possible. If-else is definitely not the desired final construct; this will be refined and improved in subsequent commits.


Add github commands in README.md

Actual Behaviour
Git commands are not added to Readme.md.
Expected Behaviour
Git commands should be added to Readme.md so that it helps newcomers to contribute in app.
Would you like to work on the issue?
Yes I would like to work on this issue.

@chashmeetsingh @mariobehling please see to this issue!

@SIMRAN1 You added that to Open Event iOS Readme. The same thing would be good here too.


New package: SimpleClifford v0.1.0

Registering package: SimpleClifford
Repository: https://github.com/Krastanov/SimpleClifford
Created by: @Krastanov
Version: v0.1.0
Commit: ad3ae2446f792f78eb8a9fd731a83161419139b2
Git reference: master

Superseded by #16028


Admin Console:   are not displayed right

  |

Request

Rewriter (Description)
Validator (Description)
|

this was probably a bug in one of the initial 4.X versions and has already been fixed.


Armor and Inserts retrieved from insurance separate from one another

This issue was brought up in the #380-bleeding-edge-reports channel. Not by myself. I am just reporting the issue.
Link to original message: https://discord.com/channels/875684761291599922/1203053345527300176/1203611038084370502
The issue happens when retrieving items from insurance.
When you insure armor, the inserts (the "plates" integrated into the armor) should be insured as well as the armor itself.(worth mentioning they wont have an insured icon as they are combined with the armor)
You can insure the front, back, and side plates all individually. If you insure the armor it automatically insures the front back and side plates (if any are inserted into the armor)
This user is saying that he got the inserts back from insurance, which shouldnt be possible because the inserts and armor are combined. However it is possible to get a front back or side plate and not the armor.
To reproduce:
Insure armor
Wait for insurance to come back
If the issue persists you will eventually get armor inserts and not the armor.
A few things to consider is:
Who you insure with (therapist or prapor)
How you insure (pre-raid screen or from the inventory)
TLDR:
Armor that cant be seperated from its inserts is being seperated and retrieved in insurance in parts.
I do not play SPT, I do not have it installed, I simply help out where I can because I enjoy the project and help my buddies who do not play live play SPT. This will explain why I reported for someone else and attached nothing. Hopefully you have plenty of information to go off of.

Originally written by RubberBandyAndy

Rework of insurance should fix this: https://dev.sp-tarkov.com/SPT-AKI/Server/commit/a2668a96188949b344d378a7e1e9f0be3b0eb2e9

Originally written by chomp

Profile added with issue, items in insurance. New zip should resolve this, just dropping here in case.

Attachments

65bd5b020003c8282b3a4634.zip (73 KiB)

Originally written by bandit

Found something:
Rolling deletion for "HighCom Trooper TFO body armor (MultiCam)" with THERAPIST - Return 85% - Roll: 95.91 - Status: Delete
Processing attachments for parent item: HighCom Trooper TFO body armor (MultiCam)
Child Item - Name: Monoclete level III PE ballistic plate, Max Price: 34306
Child Item - Name: Monoclete level III PE ballistic plate, Max Price: 34306
Rolling deletion with THERAPIST - Return 85% - Roll: 96.46 - Status: Delete
Rolling deletion with THERAPIST - Return 85% - Roll: 31.78 - Status: Keep
Number of successful rolls: 1
Marked for removal - Child Item: Monoclete level III PE ballistic plate, Max Price: 34306

Attachments for a parent item that has been marked as deleted should not be rolled for, they should just be deleted. It looks like the check I'm using to see if the item has children may not be working in the case of plates. Not sure if this is actually causing any issues, because I have yet to actually receive any individual plates back in my testing... even in this case.
I'll keep digging.

Originally written by Refringe

I've just pushed 2aa0054833 and ebbc3e2029 which include a number of improvements to the insurance package processing.
With these changes I've been able to confirm the following:

When armour is rolled for deletion, all of its plates are deleted as well.
When armour is not rolled for deletion, its plates are individually rolled for deletion.
When armour plates are rolled for deletion, the non-moddable plates are never rolled or deleted.

Attached is the profile that I used for testing.

Attachments

65c2c6a1000556885070480a.json.zip (19 KiB)

Originally written by Refringe

Can confirm that armour is now returning with some missing plates still on it when the armor is kept and some plates are deleted.
Haven't had an insurance roll mark the parent armour for deletion yet so will update when that happens

Originally written by acidphantasm


Provide usage example?

It would be very helpful to have an examples/ folder with a sample lambda usage example

Here's a small example (don't mind the providers argument, that's just bcs in my case most of resources needs to go to eu-central regions) :
You use lambda_code_source_dir to point at the folder that contains your lambda code,
In my case I overwrite file_globs to also upload redirects.json file
if you want to quickly create an cloudwatch kms key there is a module for that as well : https://registry.terraform.io/modules/dod-iac/cloudwatch-kms-key/aws/latest
 module "lambda-at-edge" {
   providers = {
    aws = aws.NVirginia
  }
  source  = "transcend-io/lambda-at-edge/aws"
  version = "0.5.0"
  cloudwatch_log_groups_kms_arn = module.cloudwatch-kms-key.aws_kms_key_arn
  name = "origin-request-lambda-edge"
  description = "Used by cloudfront distribution"
  runtime = "nodejs16.x"
  lambda_code_source_dir = "./lambda/origin-request"
  file_globs = ["app.js", "redirects.json"]
  handler = "app.handler"
  s3_artifact_bucket = var.s3_bucket_lambda_code_name
  local_file_dir = "./artifacts"
}


Recieved empty map_object response

Checklist

[X ] I have read the FAQ
[X ] I have checked if this issue already exists (both open and closed issues)
[X ] I am using the most recent version of pogom from the master branch
[X ] If this is an installation issue, I am posting my OS, OS version, python version, pip version
[X ] I'm posting the complete log
[X ] I'm using a descriptive title for this issue

My Issue
When I'm starting pogom with following cmd: "python runserver.py -H "<IP_ADDRESS>" -P 5000 -k "hashkey" its starting logging in top the account. But then it sends me this error over and over oder again:
Recieved empty map_object response. Logging out and retrying. I am trying this since 2 Days

http://imgur.com/a/tQDZ6

"Fast pokemon go map, depreciated. (API 0.53 Beta Integration)". I would suggest trying to setup RocketMap (https://github.com/rocketmap/rocketmap), as this map is no longer updated.


#156 PSR-6 / PSR-16: use serialization with storage plugin

#156 Removed serialization. Throw exception when storage adapter require serialization

@thomasvargiu I've rebased from develop, and made updates based on the feedback I provided. Once Travis is green, I'll merge.
Thanks!

Thanks, @thomasvargiu!


Option to load table data without casting the data

Often I just want the data from a CSV file parsed but not cast - is there an option to do this.
Generally I flag an issue re parsing fields that are dates - often i want the original date structure without it being parsed to dates. (I can explain better if this is not clear).

@rufuspollock
Thanks, it's clear.

I think this is also useful to get the data without running into validation problems (does JTS validate before casting?)

Yes. So I've merged this two. JTS casts data and validates it based on casting results (so it's the same process).

WILL BE IMPLEMENTED in https://github.com/frictionlessdata/tableschema-js/issues/68


Updated Github pages documentation publish URL references

Admittedly this is orthogonal to what this PR is about but I just happened to have a look at these files and the use of "here" everywhere jumped at me. You should never use "here" as the anchor for a link. Instead use some meaningful text.
I can submit a PR to fix that.

@lehors Sure, please do that if you can. (Or make suggestions for me to fix.)


New monthly build has hash mismatch

$ nix develop github:shazow/foundry.nix/monthly
error: hash mismatch in fixed-output derivation '/nix/store/x44lvk4l26d7v3rrwa4bj8rg1myns69f-source.drv':
         specified: sha256-sjUrfnq0vMIgfXhy6Kx2LMQ51Z+3Hhedb0MBA67RCxs=
            got:    sha256-Kgcd4ZZFHZCkkXFiqWXIfHDErcDP5ZPPZDahB80QodI=
error: 1 dependencies of derivation '/nix/store/scda5ij9vn91nmyk7qqpr95zfzviqcrl-foundry-0.0.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/acw9kp658jwkxg7px0i056zpihph2g7x-nix-shell-env.drv' failed to build

Looks like the daily rebuild already fixed this. :)

indeed, it looks like that this happens in the beginning of the month all the time, perhaps some logic issue in monthly update.


TqdmWarning: IProgress not found

The process that installs jupyter the first time a notebook is opened in vscode in a new environment doesn't appear to install ipywidgets. When I run certain code that relies on tqdm for the first time I get the warning

.venv/lib/python3.10/site-packages/tqdm/auto.py:22: TqdmWarning: IProgress not found. Please update jupyter and ipywidgets. See https://ipywidgets.readthedocs.io/en/stable/user_install.html
from .autonotebook import tqdm as notebook_tqdm

It's an easy fix pip install ipywidgets
I believe it can be tested using
from tqdm.autonotebook import tqdm as notebook_tqdm
It would be nice if ipywidgets was installed with jupyter as it seems to be a dependency of many ML libraries.

Jupyter is only installed into an environment to launch the Jupyter application and that is not required on all OS.
Right now Jupyter is only installed on Mac M1 (arm chip) and a few Linux distros.
When running python code against a kernel, users can chose different any different envioronment and that point the user is prompted to install IPyKernel. At this point we could probably prompt the user to also install IPyWidgets
However I'm not convinced this is a good idea as IPyWidgets 8 got release very recently, and the Jupyter extension in vscode does not support that. Users with existing code might be targetting ipywidgets 7, hence even if we supported 8, installing 8 could then cause other issues with the users envionrments and installation of apckages via requirements.txt files or the like.
As IPYwidgets is an add on feature and not crucial for kernel functionality, I think users should chose how to isntall them (and have control over pinning them to specific versions)
Thanks for the suggestion, how ever due to the above reasons, I don't think we're yet in a place to make this a standard recommendation


CMake must be installed to build dlib

This is a very interesting error especially when inside the venv of SD CMAKE is already installed
Looking in indexes: https://pypi.org/simple, https://pypi.ngc.nvidia.com
Requirement already satisfied: cmake

and this is most of the error you recive, the rest is just the same thing over and over again when it trys to load the mask commands.
Couldn't install dlib.
Command: "E:\Artificial-Inteligence\Applications\ImageCreations\ImageGeneration\Automatic1111\stable-diffusion-webui\venv\Scripts\python.exe" -m pip install dlib==19.24.0
Error code: 1
stdout: Looking in indexes: https://pypi.org/simple, https://pypi.ngc.nvidia.com
Collecting dlib==19.24.0
  Downloading dlib-19.24.0.tar.gz (3.2 MB)
     ---------------------------------------- 3.2/3.2 MB 40.9 MB/s eta 0:00:00
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'done'
Building wheels for collected packages: dlib
  Building wheel for dlib (setup.py): started
  Building wheel for dlib (setup.py): finished with status 'error'
  Running setup.py clean for dlib
Failed to build dlib

stderr:   error: subprocess-exited-with-error

  python setup.py bdist_wheel did not run successfully.
  exit code: 1

  [7 lines of output]
  running bdist_wheel
  running build
  running build_py
  running build_ext

  ERROR: CMake must be installed to build dlib

  [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for dlib
ERROR: Could not build wheels for dlib, which is required to install pyproject.toml-based projects

----------------------------------------------
Failed building wheel for dlib
ERROR: CMake must be installed to build dlib
Install cmake from https://cmake.org/download/

It's an easy fix I just launch the env and directly install it pip install dlib and it's done but I thought you would like to know that the script is saying cmake isn't installed when it is so it cant build the wheel, but you can manually do it directly in the env.

In the install.py script I install it in the sd way along with cmake:
run(f'"{python}" -m pip install cmake', desc="Installing cmake", errdesc="Couldn't install cmake")
run(f'"{python}" -m pip install dlib==19.24.0', desc="Installing dlib", errdesc="Couldn't install dlib")

Cmake is required to build dlib wheel. I install it in the venv but it seems that sometimes this do not work so I add this message in the install script to point the users to https://cmake.org/download/
I will look into this, thanks.

changing the dlib version in install.py seems to make it work.
dlib==19.24.1

I must've tried 50 different ways to get dlib installed but nothing seems to work (Windows 10, SD 1.4.0RC).
I have Visual Studio Community 2022 and Visual Studio Build Tools 2022 installed (they seem to be redundant) along with scads of C++ Workloads and Individual Components.
I did try this one that seems to have worked for many but didn't for me:
https://stackoverflow.com/questions/59336845/installation-of-dlib-with-pip-fails-on-windows-10
I think I finally got it working by downloading from source, compiling, and installing:
https://github.com/ageitgey/face_recognition/issues/894#issuecomment-609104862
git clone https://github.com/davisking/dlib.git
cd dlib
mkdir build; cd build; cmake ..; cmake --build .
cd ..
python3 setup.py install
Maybe that'll save someone some time.  dlib REALLY didn't want to install for me.

This was actually really difficult for me to install - probably the one extension I had the most trouble with, and similar to when I started using Diffusion and had issues with WD Tagger and similar extensions (Prompt Travel was a nightmare). I don't use CMake at all, really, and so I was sort of out of my element. I kept getting random errors about CMake not having a compiler, or CMake needs to be installed to install dlib. I also wanted to keep most of the things I use for SD strictly within the python environment.
I had tried for hours probably, to get this extension to work, and just gave up. I came back to it and I was at the point of trying to manually compile dlib with the CMake GUI and I had no clue wtf I was doing. What I ended up doing was completely uninstalling Visual Studio and reinstalling it directly to the SD WebUI folder. For people more fluent with CMake, I'm sure this seems stupid but there are a lot of people, I imagine, that just want to start using SD but are code-illiterate. If you get these types of issues, I think it's important to ensure that your CMake knows where your C++ compiler is, typically installed along with Visual Studio in the installer. It seems my main issue was having Studio and CMake installed in separate drives and having no clue how to point CMake to the proper compiler. I'm also unsure as to whether or not you'd have these same issues if you installed CMake globally, but I was too worn out to try.
After I installed VS to the webUI folder, I deleted the venv folder and restarted it, and it worked flawlessly. This is a great extension @ilian6806 and thank you for your work on it.

After installing VS directly to WebUI folder

Creating venv in directory E:\stable-diffusion-webui\venv using python
venv "E:\stable-diffusion-webui\venv\Scripts\Python.exe"
Python 3.10.6 (tags/v3.10.6:9c7b4bd, Aug  1 2022, 21:53:49) [MSC v.1932 64 bit (AMD64)]
Version: v1.4.0
Commit hash: 394ffa7b0a7fff3ec484bcd084e673a8b301ccc8
Installing torch and torchvision
Looking in indexes: https://pypi.org/simple, https://download.pytorch.org/whl/cu118
Collecting torch==2.0.1
  Using cached https://download.pytorch.org/whl/cu118/torch-2.0.1%2Bcu118-cp310-cp310-win_amd64.whl (2619.1 MB)
Collecting torchvision==0.15.2
  Using cached https://download.pytorch.org/whl/cu118/torchvision-0.15.2%2Bcu118-cp310-cp310-win_amd64.whl (4.9 MB)
Collecting sympy
  Using cached sympy-1.12-py3-none-any.whl (5.7 MB)
Collecting jinja2
  Using cached https://download.pytorch.org/whl/Jinja2-3.1.2-py3-none-any.whl (133 kB)
Collecting typing-extensions
  Using cached typing_extensions-4.7.0-py3-none-any.whl (33 kB)
Collecting networkx
  Using cached networkx-3.1-py3-none-any.whl (2.1 MB)
Collecting filelock
  Using cached filelock-3.12.2-py3-none-any.whl (10 kB)
Collecting pillow!=8.3.*,>=5.3.0
  Using cached Pillow-9.5.0-cp310-cp310-win_amd64.whl (2.5 MB)
Collecting numpy
  Using cached numpy-1.25.0-cp310-cp310-win_amd64.whl (15.0 MB)
Collecting requests
  Using cached requests-2.31.0-py3-none-any.whl (62 kB)
Collecting MarkupSafe>=2.0
  Using cached MarkupSafe-2.1.3-cp310-cp310-win_amd64.whl (17 kB)
Collecting idna<4,>=2.5
  Using cached https://download.pytorch.org/whl/idna-3.4-py3-none-any.whl (61 kB)
Collecting certifi>=2017.4.17
  Using cached certifi-2023.5.7-py3-none-any.whl (156 kB)
Collecting urllib3<3,>=1.21.1
  Using cached urllib3-2.0.3-py3-none-any.whl (123 kB)
Collecting charset-normalizer<4,>=2
  Using cached charset_normalizer-3.1.0-cp310-cp310-win_amd64.whl (97 kB)
Collecting mpmath>=0.19
  Using cached mpmath-1.3.0-py3-none-any.whl (536 kB)
Installing collected packages: mpmath, urllib3, typing-extensions, sympy, pillow, numpy, networkx, MarkupSafe, idna, filelock, charset-normalizer, certifi, requests, jinja2, torch, torchvision
Successfully installed MarkupSafe-2.1.3 certifi-2023.5.7 charset-normalizer-3.1.0 filelock-3.12.2 idna-3.4 jinja2-3.1.2 mpmath-1.3.0 networkx-3.1 numpy-1.25.0 pillow-9.5.0 requests-2.31.0 sympy-1.12 torch-2.0.1+cu118 torchvision-0.15.2+cu118 typing-extensions-4.7.0 urllib3-2.0.3

[notice] A new release of pip available: 22.2.1 -> 23.1.2
[notice] To update, run: E:\stable-diffusion-webui\venv\Scripts\python.exe -m pip install --upgrade pip
Installing gfpgan
Installing clip
Installing open_clip
Installing xformers
Collecting xformers==0.0.20
  Using cached xformers-0.0.20-cp310-cp310-win_amd64.whl (97.6 MB)
Installing collected packages: xformers
Successfully installed xformers-0.0.20

[notice] A new release of pip available: 22.2.1 -> 23.1.2
[notice] To update, run: E:\stable-diffusion-webui\venv\Scripts\python.exe -m pip install --upgrade pip
Installing requirements for CodeFormer
Installing requirements
Installing requirements for diffusers
Installing requirements for segment_anything
Installing requirements for lama_cleaner
Installing requirements for ultralytics

Installing sd-webui-segment-anything requirement: supervision

Installing cmake
Installing dlib

Launching Web UI with arguments: --xformers

Tatsumaki after eye mask


Sync with mdformat 0.7.x

Sync with updated plugin API in mdformat version 0.7.x
Fix rendering of multi-paragraph footnotes
Remove trailing-whitespace pre-commit hook, because trailing space is needed to denote a footnote with no content
Disable inline footnote parsing because we don't have renderer support for them yet

Thank you for the contribution!  Sorry it took me so long to merge it in. I'm not sure how I missed the notification.

No worries at all.
Let me know when you release this and I'll add the plugin to mdformat docs

Oh and if you need/want maintenance help, I'm fairly sure the Executable Books project would be delighted to have this moved under their organization, seeing that their mdformat-myst plugin implements similar code.

@hukkin I've pushed the update to pypi, so it should now be live. I've also updated my pelican-specific mdformat plugin (mdformat-pelican), which deals with not reformatting pelican markdown files.
I would be happy to move it under Executable Books if they're interested.  What's the best route to pursue?

I've pushed the update to pypi, so it should now be live.

Awesome, thanks!

I would be happy to move it under Executable Books if they're interested. What's the best route to pursue?

I had a quick chat with GitHub user chrisjsewell from EBP who said that yes, they are willing to maintain this.
The process would be that you go to Settings -> Transfer ownership in this repository and transfer to https://github.com/executablebooks. Also go to https://pypi.org/manage/project/mdformat-gfm/collaboration/ and add user cjsewell or hukkin as a collaborator there. That would pretty much be it I think.
Do you wish to stay as a co-maintainer? If yes, you'll be given rights after the GH transfer.

@hukkin Sorry about the delay in this. I added hukkin and cjsewell to the PyPi as maintainers.  However, I can't transfer the ownership to executablebooks directly, it needs to go to a user, or an org where I have write permissions.  Let me know how you want me to proceed.
As for co-maintainer, I'd like that. Thanks.

Sorry about the delay in this

No worries at all.
@chrisjsewell do we need to add @gaige to EBP organisation?

Heya, sorry for the delayed response, I just invited @gaige as a member of EBP, then you should be able to transfer it cheers

Thanks. Should be there "in a few minutes" according to Github.


Fix styling of v1.LikeButton

I like how this button shows users who liked the post, but here are a few things we need to fix:

enable this for testnet (<Widget src="mob.near/widget/LikeButton.Faces" props={{ likesByUsers }} /> will work for mainnet and it seems there is no such copy for testnet);
improve styling of overlay so it will have the same styling as other components on near.org

I think we can move on with this PR but let's create tasks for improvement.
cc @charleslavon @roshaans

I'll close this one in favour of #200


[WFLY-18298] Upgrade H2 from 2.2.220 to 2.2.224

https://issues.redhat.com/browse/WFLY-18928
This aligns us with ORM 6.4

@scottmarlow @tadamski please review

Hibernate ORM 6.4.* is also using 2.2.224 so this change will be aligned with that.
https://github.com/h2database/h2database/issues/3944 was reported with 2.2.224 but not clear it the reported database corruption can happen with earlier versions as well so that is something to be aware of but still I think we should move forward to 2.2.224.

Thanks @scottmarlow and @tadamski


Drop channel_axis parameter

🧰 Task
Following discussion in https://github.com/napari/napari/pull/2556#discussion_r659247491 it has been proposed to drop channel_axis parameter from add_image and view_image methods. This would allow for a dramatic simplification for the Viewer._add_layer_from_data approach as now the kwargs for all the add_* methods would be the same as for all the Layer.__init__ methods.
We'd need to update our docs and make it very clear what two lines of code an API user would now have to use to achieve the  same functionality.
GUI users will be able to use the new context menu in #2556 to split channels after a layer has been added
cc @tlambert03 @jni for additional comments

If @jni and @tlambert03 are aligned on this, could be good to give to @nclack - unless @tlambert03 you want to take this on?

go go gadget @nclack

Will be a good issue as @nclack as you'll be refactoring/ deprecating some API to bring it more in line with what we think will be a better / more streamlined approach


Remove reset text from value source badge if disabled

Fixes https://github.com/NASA-AMMOS/aerie-ui/issues/670

We only need to show the reset text if the parameter is enabled

Test:

Make sure the reset set text is not included on parameters on the plan merge review page

@duranb Good catch. Updated!


github/workflows/tests: migrate to maintained setup-ruby.

The previous version was deprecated.
As mentioned in https://github.com/github/opensourcefriday/pull/943#issuecomment-821199019
While we're here: autoformat the YAML, too.

Duplicate of https://github.com/github/opensourcefriday/pull/945


basecli panic on validator hash check

If I hit enter without typing a letter.
ethanbuchman:basecoin$ basecli init --chain-id=test_chain_id --node=tcp://localhost:46657
Loading validator set from tendermint rpc...

Important: if this is incorrect, all interaction with the chain will be insecure!
  Given validator hash valid: EB168E17E45BAEB194D4C79067FFECF345C64DE6
Is this valid (y/n)?

panic: unexpected newline

goroutine 1 [running]:
github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands.askForConfirmation(0xc4200ed9f8)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands/init.go:228 +0x234
github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands.validateHash(0xc420071ba0, 0xc420098e80, 0xc4201407b0, 0x0, 0x0)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands/init.go:192 +0x1e3
github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands.initSeed(0x1c4c1a0, 0x0)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands/init.go:175 +0x434
github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands.runInit(0x1c4c1a0, 0xc420156460, 0x0, 0x2, 0x0, 0x0)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands/init.go:71 +0xd1
github.com/tendermint/basecoin/vendor/github.com/spf13/cobra.(*Command).execute(0x1c4c1a0, 0xc420156420, 0x2, 0x2, 0x1c4c1a0, 0xc420156420)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/spf13/cobra/command.go:656 +0x3f8
github.com/tendermint/basecoin/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x1c4dd40, 0x2, 0x2, 0xc420156380)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/spf13/cobra/command.go:735 +0x339
github.com/tendermint/basecoin/vendor/github.com/spf13/cobra.(*Command).Execute(0x1c4dd40, 0xc4201546c0, 0x16)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/spf13/cobra/command.go:694 +0x2b
github.com/tendermint/basecoin/vendor/github.com/tendermint/tmlibs/cli.Executor.Execute(0x1c4dd40, 0x18c1208, 0x2, 0xc4201562e0)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/tmlibs/cli/setup.go:97 +0x4e
main.main()
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/cmd/basecli/main.go:57 +0x340
ethanbuchman:basecoin$

Fixed on light-client:develop as of e2aeaeb
Need to update deps.

Fixed as of #142


 Add missing indices.
Test Plan
Run migration from 2.2.1 to 2.2.2 and see that the 4 new indices are created and account lookups become fast again.

Blocking migrations finish in about 30s, reducing accounts endpoint from 1.2s to 0.17s in my test. Block import speeds seem consistent for 900 tx/block, at 1.3s.


fixed type hints of hash methods

i do have one problem
hgetall() either returns a dict of bytes: dict[bytes, bytes], or an empty dict
python doesn't have any way to type hint empty dicts
so i either have to do what i did here and just type hint as dict, oe do Union[dict[bytes, bytes], dict]
which do you think is better suited?
p.s: i'll provide examples of this methods' types in a coment

examples:
hset:
>>> v.hset("hash1", "foo", "bar")
1
>>> v.hset("hash2", mapping={"aa": "bb", "cc": "dd"})
2

hget:
>>> v.hget("hash1", "foo")
b'bar'
>>> v.hset("hash1", "baz", 2)
1
>>> v.hget("hash1", "baz")
b'2'

hdel:
>>> v.hdel("hash1", "foo")
1
>>> v.hdel("hash2", "aa", "cc")
2

hexists:
>>> v.hexists("hash1", "foo")
False
>>> v.hexists("hash1", "baz")
True

hgetall:
>>> v.hgetall("hash2")
{}
>>> v.hgetall("hash1")
{b'baz': b'2'}

hincrby:
>>> v.hincrby("hash1", "baz")
3
>>> v.hincrby("hash1", "baz", 4)
7

hincrbyfloat:
>>> v.hset("hash1", "foo", 2.2)
1
>>> v.hincrbyfloat("hash1", "foo", 4.1)
6.3

hkeys:
>>> v.hkeys("hash1")
[b'baz', b'foo']

hlen:
>>> v.hlen("hash1")
2

hsetnx:
>>> v.hsetnx("hash1", "foo", 1)
0
>>> v.hsetnx("hash1", "new", 1)
1

hmset:
>>> v.hmset("hash2", {"a": "b", "c": "d", "e": 3})
<python-input-23>:1: DeprecationWarning: Valkey.hmset() is deprecated. Use Valkey.hset() instead.
  v.hmset("hash2", {"a": "b", "c": "d", "e": 3})
True

hmget:
>>> v.hmget("hash2", ["a", "c", "e"])
[b'b', b'd', b'3']

hvals:
>>> v.hvals("hash2")
[b'b', b'd', b'3']

hstrlen:
>>> v.hstrlen("hash2", "a")
1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.69%. Comparing base (02c2bfe) to head (63ab0a8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   76.22%   73.69%   -2.53%
==========================================
  Files         130      130
  Lines       33940    33907      -33
==========================================
- Hits        25871    24988     -883
- Misses       8069     8919     +850

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Increase SEND_FOR_RECOVERY_TIMEOUT to 5 seconds

Stress tests in my devnets have shown that 1 second is way too low on high load, as it causes many signatures to be sent to many nodes unnecessarily.

as it causes many signatures to be sent to many nodes unnecessarily.

Is this really a problem? With the curent setup, if the MN is down, the CL only gets delayed by one second, in this diff it would delay it by 5 seconds right? Is that worth saving a few messages under high load?

Can't think of any potential issue with an increased cooldown

The problem with an increased cooldown is that if a node goes down, and that node was/is in charge of combining the signature shares, then the Chainlock / IS lock would get delayed by five seconds, which is a pretty big delay considering normally those messages are produced and propagated in about two seconds.

The chance of a CL being delayed by 5 secs is quite low (I assume below 1%), so it's IMHO fine to take this risk. I'm not sure when I'll find time to do more tests with a lower timeout. Long term, we need a solution that is able to adapt to current network load.

Long term, we need a solution that is able to adapt to current network load.

Yeah, would be nice to have some self-diagnosis/self-healing mechanisms. How about smth simple like
diff --git a/src/llmq/quorums_signing_shares.cpp b/src/llmq/quorums_signing_shares.cpp
index 11833bf74e..0adaa18e40 100644
--- a/src/llmq/quorums_signing_shares.cpp
+++ b/src/llmq/quorums_signing_shares.cpp
@@ -1036,7 +1036,7 @@ void CSigSharesManager::CollectSigSharesToSend(std::unordered_map<NodeId, std::v
         }

         if (curTime >= p.second.nextAttemptTime) {
-            p.second.nextAttemptTime = curTime + SEND_FOR_RECOVERY_TIMEOUT;
+            p.second.nextAttemptTime = curTime + SEND_FOR_RECOVERY_TIMEOUT * (attempt + 1);
             auto dmn = SelectMemberForRecovery(p.second.quorum, p.second.sigShare.id, p.second.attempt);
             p.second.attempt++;

for now instead of bumping SEND_FOR_RECOVERY_TIMEOUT?

What about some exponential timeout? If the first 2 attempts failed, then it's very very likely that it's not simply "2 nodes are down" that's causing the delays.

It depends on the actual implementation I guess. An exponential function could be bumping it way too fast e.g. exp(5) = ~148.41 sec (~2.5 minutes) and total timeout (for all 5 attempts) would be ~223 sec (~3.7 minutes). It would be like reducing recoveryMembers to 5 basically (or 7 if we add 2 fast initial attempts). Even for my code above (a simple arithmetic progression) the total timeout for 25 attempts (i.e. IS llmqs) is (1+25)*25/2=325 sec (~5.4 minutes) and for 100 attempts (i.e. CL llmqs) it's (1+100)*100/2=5050 sec (~1.4h). Both are already too high for their use cases in normal conditions. To put it in another way, ~10 minutes total timeout is reached at the 35th attempt. So it probably wouldn't make much sense to have recoveryMembers> 40. This  in its turn would mean that only 10% of CL quorum could be used as recovery members (instead of 25% as of today but maybe that's ok).

I changed the implementation to use an exponential backoff starting with 2 seconds and limited to 10 seconds, so it would be 2, 4, 8, 10, 10, 10, ...


100% should equal 0 HP, but isn't always the case

I have this set up so that tokens switch to an unconscious/dying token at 0 HP, which shows them laying on their back. So I set this module to swap at 100%. Unfortunately there must be some kind of rounding error, because if my token has 58 health and I deal 57 damage to them, they still switch. Could be cool if you don't have it rounding the numbers, or at least make sure that 100% damage means 0 HP.

Actually strike that, I don't understand the math of this at all. If I set it to 100% it swaps tokens even if I deal 1 point of damage.

Okay, sorry for all the comments, the module is very confusing. The language on it is very confusing. The module reads "at ___ Dmg" but I think what you mean for it to say is "at ___ HP." If I set it to 10, and my token has 100 HP, the token won't switch until it drops below 10 HP. So at 10% HP it drops. 10% damage makes it seem like it's only taken 10 damage, not 90. Very confusing!
Also, if you set it to 100% the token doesn't change until you drop below 100%. And if you set it to 0% it NEVER changes. It should definitely change if it's set to 0%.
I suspect the issue is that you have it set to change if it drops below the number, but what you should have it say is if the number is below than or EQUAL TO, then it should fire off. Does that make sense?
Love the module! Again, sorry for the spam messages!

Thank you, no worries on the "spam". I should make the text clearer yes :D
The at is a percentage. By default it uses the regular token image,
It won't switch image until it passes below the percentage. If you set it to 100%, it won't show that image until it drops below 100.
The same with zero, it won't change until it goes "past" 0%.
I agree that this might not be the most intuitive way, so I will change it to be "below or equal".
I will close this issue once that is implemented.

Fixed issue. Added a % sign next to the "at", and changed the algorithm to swap the image when its "at or below" the given percentage.


Downloading manga and trying to install new sources doesn't work

Steps to reproduce

Open anyomi

To manga - open any manga download using the download icon or manually

Expected behavior
The download gets queued and gets downloaded.
The extension page loads the uninstalled extensions
Actual behavior
The download gets queued but the download bar doesn't move I can't download new extension for manga the manga extension page doesn't lose new / not installed extensions.
Crash logs
No response
Aniyomi version
App version: <IP_ADDRESS> (standard, 7722361, 72, 2023-02-09T10:47Z) Android version: 12 (SDK 31) Android build ID: SKQ1.211103.001 test-keys Device brand: Redmi Device manufacturer: Xiaomi Device name: spes Device model: 2201117TG Device product name: spes_global
Android version
Android 12
Device
Redmi note 11
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

There isn't any manga new sources of manga sites, only installed sources are showing. I accedently delete one source and now I don't able to reinstall it . 💀

Same with this but the app is still using storage for the previous downloads but I cant access any of the manga i have downloaded

The manga download doesn't work but the anime download works


Initial support for WorkloadEntry

This provides the initial implementation for WorkloadEntry. Its pretty straight forward - when we convert ServiceEntries to internal models, we also look at selected workload entries and convert those as well. The thing that is missing in this PR is proper event handling - WorkloadEntry updates can/should be similar to Endpoint updates and only trigger EDS really. For now that code is a TODO and just triggers a full push - I can improve before we merge, just wanted to get some eyes on this before I go down that path.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
51abcb6923aa282da444a18d97b37f8d683c8b03
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9c7b4e8b148af85be744babb4cca6e852a3f621a
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1e522292fe2afa8a68306779d2fd4c28b9a1684a
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In testing this i found some bugs in the SE implementation. I am going to break those fixes out + a bunch of testing that I was going to add into this PR in another PR. In the mean time there will be some junk in this PR since I am scared of my computer crashing and losing my git state again

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
1ca32c070f5af49d071993796e8018571a1e85f7
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
1ca32c070f5af49d071993796e8018571a1e85f7
link
/test lint_istio

unit-tests_istio
1ca32c070f5af49d071993796e8018571a1e85f7
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This is in a working state with tests passing, but it is a superset of https://github.com/istio/istio/pull/22712/ so please review that first - this PR will be much smaller once that is merged

@smawson @rshriram @ramaraochavali this is ready for review now


Module attributes break highlighting

Describe the bug
When adding an attribute to a module, it tends to break and mess with the highlighting inside of it. This probably is due to the fact that modules aren't expected to have attributes in the grammar?
To Reproduce
view
/// Some documentation comment here
[<RequireQualifiedAccess>]
module internal Some.Qualified.ModuleName

open System
open System.Collections.Generic

In the above, the open System highlights incorrectly.

Thanks - absolutely legend on the speed of the fix!


feat(planning_validator): add planning validator package

Description
Issue: https://github.com/autowarefoundation/autoware.universe/issues/2605
Add planning validator pkg.
motivation:

invalid trajectory (e.g. contains infinite values, shape is broken, etc) should be detected in the planning module

see this comment for the current supported validations

appropriate handling for the invalid trajectory

Design:

check some metrics
when an invalid part is found,

publish a Diagnostic msg when an invalid part is found.
use previously calculated trajectory

Related links
autoware_launch: https://github.com/tier4/autoware_launch/pull/675
(for TIER IV internal tracker: https://tier4.atlassian.net/browse/T4PB-18620)
Tests performed
Now some metrics can be seen here.
https://user-images.githubusercontent.com/21360593/192083444-fba23943-b17e-432e-996b-79243bb03dde.mp4

Invalid case check:
it is confirmed this PR works for the invalid trajectory. This is the case when the trajectory shape is broken when generating lane change trajectory. (For TIER IV INTERNAL, it can be found in this ticket. )
https://user-images.githubusercontent.com/21360593/210230742-772729bf-db20-4ae9-abf6-f9d35a8ed51f.mp4
Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TakaHoribe
TODO in description is done by planning_error_monitor or maybe by planning evaluator.

@taikitanaka3 right. This package is based on the planning_error_monitor and his all features are (will be) inherited to this package.

@TakaHoribe

@TakaHoribe

In addition, the validation of a generated path is also be done by iteratively simulating the control stack on the given trajectory and seeing how well it can follow it by calculating the error.

invalid trajectory (e.g. contains infinite values, shape is broken, etc) should be detected in the planning module

Is this package going to check for just these?
Maybe it'd be better if we can list the features that this node can validate.

@TakaHoribe
In my opinion, this validator package should use trajectory from obstacle cruise and output trajectory for smoother, because smootheris necessary to calculate desired motion (eg. stop, cruise, accelerate) using previous trajectory.

it'd be better if we can list the features that this node can validate.

@xmfcx Thank you for the good advice. The current implementation checks the following items:
Ported from planning_error_monitor

invalid field (e.g. Inf, Nan)
trajectory points interval (invalid if the distance of trajectory point is too large, like 100m)
curvature (invalid if the trajectory has too sharp turns that is not feasible for the given vehicle kinematics)

Implemented in this PR

relative angle in trajectory points (invalid if the yaw angle changes too fast in the sequence of trajectory points)
lateral acceleration (invalid if the expected lateral acceleration/deceleration is too large)
longitudinal acceleration/deceleration (invalid if the acceleration/deceleration is too large)
steering angle (expected value estimated from curvature)
steering angle rate (expected value estimated from curvature)
velocity deviation (invalid if the planning velocity is too far from the ego velocity)
distance deviation (invalid if the ego is too far from the trajectory)

I'll list them in the readme as well. Any comments are welcome.

In my opinion, this validator package should use trajectory from obstacle cruise and output trajectory for smoother, because smootheris necessary to calculate desired motion (eg. stop, cruise, accelerate) using previous trajectory.

@taikitanaka3 Sorry I don't get your point. Does your idea solve the original motivation: "we don't want to send the invalid trajectory to the controller"?

@TakaHoribe
partly yes, but my concern is Is it possible to drive using previous trajectory without smoother all the time.

Can you share CPU utilization of this package?

@yukkysaito No heavy computational logic is used now. It is just about 2% in planning_simulator on my 4-year-old desktop PC (Intel® Core™ i7-8700K CPU @ 3.70GHz × 12).

@xmfcx Here is the readme, FYI.
https://github.com/tier4/autoware.universe/tree/feature/planning-validator/planning/planning_validator

I'll list them in the readme as well. Any comments are welcome.

scenario test works well: 822/825 -> 821/825

@ito-san Would you take a review as a maintainer of the system_error_monitor? Your review is required.


Check behaviour on Microsoft Edge Browser

The behaviour  when using the edge browser has not yet been documented.
I will test it out.

@ben174 I can't find the demo page, just the GitHub project page.


AdaCore 24 updates

Description of changes

Tested:

[x] gprbuild, xmlada
[x] alire
[x] spark2014
[x] gnatcoll-*
[x] ada-mode

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 269160 run on x86_64-linux 1

1 package failed to build:

gnatcoll-python3

20 packages built:

alire
emacsPackages.ada-mode
gnatcoll-core
gnatcoll-db2ada
gnatcoll-gmp
gnatcoll-iconv
gnatcoll-lzma
gnatcoll-omp
gnatcoll-postgres
gnatcoll-readline
gnatcoll-sql
gnatcoll-sqlite
gnatcoll-syslog
gnatcoll-xref
gnatcoll-zlib
gnatinspect
gprbuild
gprbuild-boot
spark2014
xmlada

</details

Result of nixpkgs-review pr 269160 run on x86_64-linux 1

21 packages built:

alire
emacsPackages.ada-mode
gnatcoll-core
gnatcoll-db2ada
gnatcoll-gmp
gnatcoll-iconv
gnatcoll-lzma
gnatcoll-omp
gnatcoll-postgres
gnatcoll-python3
gnatcoll-readline
gnatcoll-sql
gnatcoll-sqlite
gnatcoll-syslog
gnatcoll-xref
gnatcoll-zlib
gnatinspect
gprbuild
gprbuild-boot
spark2014
xmlada


Convert the server name to lowercase automatically

SQL Azure only allows lowercase server names.  Today, this task will fail if there are any non-lowercase letters in the server name.  A common scenario is to deploy a SQL Azure server using an ARM Template, and name the server the same as the Resource Group, but doing a ToLower() inside the ARM template. If you are trying to create a TFS build that deploys the ARM Template then deploys a DACPAC into the new SQL Server, you likely only have the Resource Group Name as a build variable, and no convenient way to convert it to lowercase from within the build.  If this task would automatically do a ToLower on it as proposed it would solve this problem.

Hi @dylan-smith, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Thanks for contributing.

When I tried to run the tests I get typescript compilation errors.

I'm surprised you guys don't have an automated build that runs for PR's to do the tests (I mean come on! your the build guys!).
Also, something automated to update the patch #'s would be nice, so every contributor doesn't have to remember to do it every single time.  And also so PR's don't keep getting invalidated as soon as a change is accepted into master.

@dylan-smith You might need to rebase onto latest. I would have expected this commit (b22f3dc) to fix the issue you're hitting.

Managed to fix up the typescript, and got the tests to run and pass.

@ericsciple I rebased onto the latest as of 1 hour ago.  Am I maybe using a new typescript version.

@dylan-smith only other thing I can think of (saw the issue with someone else yesterday), is if tsc.exe is in your PATH. That one might be taking precedence over the one the build is supposed to use. If using cmd.exe, "where tsc.exe" resolves a path, then that's probably the issue. ("gcm tsc.exe" in powershell, and i think "which tsc" in bash).

I followed the instructions from here exactly: https://github.com/dylan-smith/vso-agent-tasks/blob/master/docs/contribute.md
They tell me to install typescript globally, which I did.

Hah! Thanks for the info!

@dylan-smith were you able to get your test run successfully? Please confirm me. I will merge the changes.

Yes I commented in the PR after u asked
Sent from my iPhone
On Mar 9, 2016, at 12:08 AM, Muthukumaran Kasiviswanathan <notifications<EMAIL_ADDRESS>wrote:
@dylan-smithhttps://github.com/dylan-smith were you able to get your test run successfully? Please confirm me. I will merge the changes.

Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/vso-agent-tasks/pull/1293#issuecomment-194128970.


feat(frontend): use component to group of dates in AllTransactionsList

Motivation
After PR #3576 , we include the group component into the main transaction list.

[OISY-130]


Fetch branch name from environment variable when necessary

This fixes https://github.com/gradle/gradle-private/issues/1690
Previously we use JGit's branch, which might be not accurate.
Now we prefer BUILD_BRANCH environment variable over JGit.
After the fix, the vcsbranch in DB:

Thanks @jjohannes !