BUGs REPORT

hello, I met some bugs when I tried to simulate the motion of Allegro Hand.

I cannot load the URDF files running code

import genesis as gs
import numpy as np
gs.init(backend=gs.gpu)

scene = gs.Scene(show_viewer=True)
plane = scene.add_entity(gs.morphs.Plane())

allegro = scene.add_entity(
    gs.morphs.URDF(
        file  = 'allegro_hand_description/allegro_hand_description_left.urdf',
        pos   = (0.0, 0.0, 0.5),
        euler = (0, 90, 0),
    ),
)

and raised an ERROR
**The above is omitted**
  File "/home/xxx/anaconda3/envs/genesis/lib/python3.9/site-packages/genesis/ext/urdfpy/urdf.py", line 144, in <listcomp>
    v = [t._from_xml(n, path) for n in vs]
  File "/home/xxx/anaconda3/envs/genesis/lib/python3.9/site-packages/genesis/ext/urdfpy/urdf.py", line 1942, in _from_xml
    kwargs["trans_type"] = node.find("type").text
AttributeError: 'NoneType' object has no attribute 'text'

The URDF files is downloaded from "allegro_hand_description_left.urdf".

I finally managed to load the MJCF which is downloaded from "wonik_allegro" but the PD control seemed strange. My code is

import genesis as gs
import numpy as np
gs.init(backend=gs.gpu)

scene = gs.Scene(show_viewer=True)
plane = scene.add_entity(gs.morphs.Plane())

allegro = scene.add_entity(
    gs.morphs.MJCF(
        file  = 'wonik_allegro/left_hand.xml',
        pos   = (0.0, 0.0, 0.5),
        euler = (0, 90, 0),
    ),
)

scene.build()

jnt_names = [
    'ffj0','ffj1','ffj2','ffj3',
    'mfj0','mfj1','mfj2','mfj3',
    'rfj0','rfj1','rfj2','rfj3',
    'thj0','thj1','thj2','thj3',
]
dofs_idx = [allegro.get_joint(name).dof_idx_local for name in jnt_names]
print(dofs_idx)
# set positional gains
allegro.set_dofs_kp(
    kp             = np.array([4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500]),
    dofs_idx_local = dofs_idx,
)
# set velocity gains
allegro.set_dofs_kv(
    kv             = np.array([4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500, 4500]),
    dofs_idx_local = dofs_idx,
)
# set force range for safety
allegro.set_dofs_force_range(
    lower          = np.array([-100, -100, -100, -100, -100, -100, -100, -100, -100, -100, -100, -100, -100, -100, -100, -100]),
    upper          = np.array([ 100,  100,  100,  100,  100,  100,  100,  100,  100, -100, -100, -100, -100, -100, -100, -100]),
    dofs_idx_local = dofs_idx,
)

pos0  = np.zeros(16)
pos1 = np.ones(16) * 0.1
pos2 = np.ones(16) * 0.2
pos3 = np.ones(16) * 0.3

# PD control
for i in range(1250):
    if i == 0:
        allegro.control_dofs_position(
            pos1,
            dofs_idx,
        )
    elif i == 250:
        allegro.control_dofs_position(
            pos2,
            dofs_idx,
        )
    elif i == 500:
        allegro.control_dofs_position(
            pos3,
            dofs_idx,
        )
    elif i == 750:
        # control first dof with velocity, and the rest with position
        allegro.control_dofs_position(
            pos1[1:],
            dofs_idx[1:],
        )
        allegro.control_dofs_velocity(
            pos1[:1],
            dofs_idx[:1],
        )
    elif i == 1000:
        allegro.control_dofs_force(
            pos0,
            dofs_idx,
        )
    # This is the control force computed based on the given control command
    # If using force control, it's the same as the given control command
    print('control force:', allegro.get_dofs_control_force(dofs_idx))

    # This is the actual force experienced by the dof
    print('internal force:', allegro.get_dofs_force(dofs_idx))

    scene.step()

There is only 9 dofs (the dof of Allegro is 16) is controled while the control force of other dofs is max/min whose logs are like:
[Genesis] [23:30:45] [INFO] Running at 59.94 FPS.
control force: tensor([  -0.8241,   -0.8601,   -0.8363,   -0.8277,   -0.8241,   -0.8601,
          -0.8363,   -0.8277,   -0.8274, -100.0000, -100.0000, -100.0000,
        -100.0000, -100.0000, -100.0000, -100.0000], device='cuda:0')
internal force: tensor([  -0.8359,   -0.8359,   -0.8359,   -0.8359,   -0.8359,   -0.8359,
          -0.8359,   -0.8359,   -0.8355,  -99.1898,  -99.0691,  -99.0581,
        -100.0113,  -99.0642,  -99.2019,  -99.0663], device='cuda:0')
[Genesis] [23:30:45] [INFO] Running at 59.94 FPS.
control force: tensor([  -0.8159,   -0.8519,   -0.8281,   -0.8194,   -0.8159,   -0.8519,
          -0.8281,   -0.8194,   -0.8194, -100.0000, -100.0000, -100.0000,
        -100.0000, -100.0000, -100.0000, -100.0000], device='cuda:0')
internal force: tensor([  -0.8275,   -0.8275,   -0.8275,   -0.8276,   -0.8275,   -0.8275,
          -0.8275,   -0.8276,   -0.8273,  -99.1892,  -99.0689,  -99.0562,
        -100.0092,  -99.0619,  -99.1997,  -99.0630], device='cuda:0')

[doge] The recording is like
https://github.com/user-attachments/assets/db7615df-fd56-47a3-af7b-8f63a697d411
Sincerely looking forward to your respond.

The control force reaches the limit due to high values of kp and kv. With kp=4500, even a slight deviation from the default position (e.g., 0.03 radius or 2 degrees) results in a torque greater than 100.
I suggest checking dofs_idx to verify if all joints are actuated.

Thank you for your advice. I modified my code and set the kp and kv to 0.1:
import genesis as gs
import numpy as np
gs.init(backend=gs.gpu)

scene = gs.Scene(
    show_viewer = True,
    viewer_options = gs.options.ViewerOptions(
        res           = (1280, 960),
        camera_pos    = (3.5, 0.0, 2.5),
        camera_lookat = (0.0, 0.0, 0.5),
        camera_fov    = 40,
        max_FPS       = 60,
    ),
    vis_options = gs.options.VisOptions(
        show_world_frame = True,
        world_frame_size = 1.0,
        show_link_frame  = False,
        show_cameras     = False,
        plane_reflection = True,
        ambient_light    = (0.1, 0.1, 0.1),
    ),
    renderer=gs.renderers.Rasterizer(),
)
plane = scene.add_entity(gs.morphs.Plane())

allegro = scene.add_entity(
    gs.morphs.MJCF(
        file  = 'wonik_allegro/left_hand.xml',
        pos   = (0.0, 0.0, 0.5),
        euler = (0, 90, 0),
    ),
)
cam = scene.add_camera(
    res    = (640, 480),
    pos    = (3.5, 0.0, 2.5),
    lookat = (0, 0, 0.5),
    fov    = 30,
    GUI    = False,
)

scene.build()

jnt_names = [
    'ffj0','ffj1','ffj2','ffj3',
    'mfj0','mfj1','mfj2','mfj3',
    'rfj0','rfj1','rfj2','rfj3',
    'thj0','thj1','thj2','thj3',
]
dofs_idx = [allegro.get_joint(name).dof_idx_local for name in jnt_names]
print(dofs_idx)
# set positional gains
allegro.set_dofs_kp(
    kp             = np.array([0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1]),
    dofs_idx_local = dofs_idx,
)
# set velocity gains
allegro.set_dofs_kv(
    kv             = np.array([0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1]),
    dofs_idx_local = dofs_idx,
)
# set force range for safety
allegro.set_dofs_force_range(
    lower          = np.array([-100, -100, -100, -100, -100, -100, -100, -100, -100, -100, -100, -100, -100, -100, -100, -100]),
    upper          = np.array([ 100,  100,  100,  100,  100,  100,  100,  100,  100, -100, -100, -100, -100, -100, -100, -100]),
    dofs_idx_local = dofs_idx,
)

pos0  = np.zeros(16)
pos1 = np.ones(16) * 0.01
pos2 = np.ones(16) * 0.02
pos3 = np.ones(16) * 0.03

cam.start_recording()

# PD control
for i in range(1250):
    if i == 0:
        allegro.control_dofs_position(
            pos1,
            dofs_idx,
        )
    elif i == 250:
        allegro.control_dofs_position(
            pos2,
            dofs_idx,
        )
    elif i == 500:
        allegro.control_dofs_position(
            pos3,
            dofs_idx,
        )
    elif i == 750:
        # control first dof with velocity, and the rest with position
        allegro.control_dofs_position(
            pos1[1:],
            dofs_idx[1:],
        )
        allegro.control_dofs_velocity(
            pos1[:1],
            dofs_idx[:1],
        )
    elif i == 1000:
        allegro.control_dofs_force(
            pos0,
            dofs_idx,
        )
    # This is the control force computed based on the given control command
    # If using force control, it's the same as the given control command
    print('control force:', allegro.get_dofs_control_force(dofs_idx))

    # This is the actual force experienced by the dof
    print('internal force:', allegro.get_dofs_force(dofs_idx))

    scene.step()
    cam.render()
cam.stop_recording(save_to_filename='video.mp4', fps=60)

But it seems that the motions of 10th-16th dofs are still boom at beginning and the control force is still -100 even though send the code allegro.control_dofs_force(pos0,dofs_idx)
the logs is following:
[Genesis] [16:30:38] [INFO] Running at 60.00 FPS.
control force: tensor([   0.,    0.,    0.,    0.,    0.,    0.,    0.,    0.,    0., -100.,
        -100., -100., -100., -100., -100., -100.], device='cuda:0')
internal force: tensor([ 1.4036e-06, -7.9537e-05, -3.1760e-05, -6.5058e-06,  4.9167e-07,
        -7.9568e-05, -3.1767e-05, -6.5055e-06,  4.6809e-07, -9.9983e+01,
        -9.9998e+01, -9.9996e+01, -1.0005e+02, -9.9990e+01, -9.9990e+01,
        -9.9999e+01], device='cuda:0')
[Genesis] [16:30:38] [INFO] Running at 60.00 FPS.
control force: tensor([   0.,    0.,    0.,    0.,    0.,    0.,    0.,    0.,    0., -100.,
        -100., -100., -100., -100., -100., -100.], device='cuda:0')
internal force: tensor([ 1.3968e-06, -7.9384e-05, -3.1701e-05, -6.4896e-06,  4.9456e-07,
        -7.9399e-05, -3.1700e-05, -6.4885e-06,  4.7340e-07, -9.9983e+01,
        -9.9998e+01, -9.9996e+01, -1.0005e+02, -9.9990e+01, -9.9990e+01,
        -9.9999e+01], device='cuda:0')

the recording is following:
https://github.com/user-attachments/assets/0c6f4fdc-24df-472d-bafb-90daa0418ea8

The last seven upper bound values in set_dofs_force_range() are set to be -100.


Added redirection when starting a meeting

In Zoom, it's also possible to start meetings, which have a marginally different URL scheme, this PR adds the automatic redirect to those as well (works on my machine at least).
More error handling would probably be nice, but I'm not very familiar with JS. Feedback is appreciated though!

Thanks for the pull request!


Remove or refactor name() method in Mixer and Renderer

The name() method doesn't seem to be of much use in the Mixer and Renderer classes. We should consider removing it. If for some reason it is still desired, we should perhaps consider changing the design.
For Mixer it is never called anywhere in NAS2D or OPHD. (Any other projects?)
For Renderer, it is only ever called in the RendererOpenGL constructor (where the value is initially set), and in one other method where it looks to be called by accident and appears to be a bug (see issue #249).
I suggest removing this function. Due to lack of use, removing it shouldn't cause downstream breaks in OPHD.

If the method is desired, perhaps for debugging output reasons, then we should consider changing the design.
The current design requires a name to be set in a constructor initializer list of the derived class. It also requires storage within any derived class. This is a bit wasteful, as the value does not appear designed to change during the lifetime of the class. There are no methods to update it, nor any internal code that changes it.
Instead, a design that allows for a human readable class name to be returned, and not require instance storage, is to declare the name() function as virtual. It's already returning a const std::string&, so returning a hardcoded constant would be just fine.
Even better, would be to change the return type to std::string_view. With const std::string&, a std::string object must be constructed at runtime. If the function were to return a string literal (return "OpenGL Renderer";), that construction would happen every time the name() method was called. If the std::string object was moved global, it would only ever be constructed once each time the executable is run. However, it would be constructed globally regardless of whether or not that particular class was ever instantiated. Instead, if a std::string_view were used, it could be compile time constructed as it is a constexpr compatible type. Returning it would invoke the copy constructor, but it's a cheap operation for std::string_view, and as the string has global semantics, there are no ownership issues with the non-owning nature of std::string_view.

The easier solution though is to just remove it.

I'm in agreement that it should be removed. This was an old design decision and was intended to help me understand class inheritance. Long before I understood how to use a debugger effectively.
I say we just remove it and call it a day.


add students.dvfu.ru

University official website: https://www.dvfu.ru/
Address: FEFU Campus, 10 Ajax Bay, Russky Island, Vladivostok, Russia
List of IT educational programs: https://www.dvfu.ru/institute_of_mathematics_and_computer_technologies/obrazovatelnye-programmy/

@SavchukNikita Unfortunately your request will not be processed further as JetBrains does not conduct business with persons or organisations individually targeted or incorporated in territories subject to applicable EU, U.N. and/or U.S. sanctions and/or certain export control restrictions due to legal, contractual and commercial related risks and reasons.
JetBrains complies with all relevant regulations, including applicable sanctions and export control laws.
We appreciate your understanding and apologise for any inconvenience caused.


Make binutils build (it is probably not fully functional)

Why not put this patch into https://github.com/redox-os/binutils-gdb on the Redox branch?

(Or another branch)

I think it's probably best not to have the hacks with commented out lines when building the cross compiler. It could be a branch of binutils-gdb though.

Yes, I prefer a branch like self_hosting to a patch file

Ok. You can merge redox-os/binutils-gdb#1 into a branch, and I will update this PR.

I've removed the patch; this can now be merged.


Added refs format option

Related to #84, see https://github.com/ipfs/go-ipfs/pull/2678/files

LGTM


Settings/GUI still does not work

Microsoft PowerToys version
Any over 0.61.1
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
Settings
Steps to reproduce
Simply updating to any version after 0.61.1 on Windows 10 (any version), using the Github provided exe, breaks the ability to open the settings or see any interface and adjust anything. Auto updating on 0.61.1 in the GUI doesn't work either, it simply does nothing.
I've tried every version after 0.61.1 and the result has been the same every time forcing me to uninstall the latest version and revert.
✔ Expected Behavior
The GUI to work.
❌ Actual Behavior
The GUI is non-functional/won't appear.
Other Software
No response

I think the difference for 0.62.0 for Settings was just upgrading Windows App SDK runtimes to 1.1.4.
Can we please get a /bugreport from 0.64.1 after trying to open Settings and seeing it fail?

Here is what I believe should be the bug report file from 0.64.1.
PowerToysReport_2022-11-22-05-37-02.zip

@NeoCyrus , Thank you. I'm seeing we've got Event Viewer crash events in there.
Can you please get a dump file like described in https://github.com/microsoft/PowerToys/issues/18725 ? Trying to see where it might be crashing. (Please read into the issue as well, in case you have GPU software that might be interfering with win app sdk)
By the way, does PowerRename, Screen Ruler, File Locksmith or Hosts File Editor open correctly? Checking if it's something related to the win app sdk and those apps also use it for UI.
/needinfo

I took a look and there is no PowerToys dump file there.

For the dump file to be generated you have to change the registry as explained in #18725 ;)
One way of achieving this would be by creating an entry in the Registry Editor (regedit.msc), for Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps\PowerToys.Settings.exe , according to the instructions in https://docs.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps
It should look something like this in the end:

After that, please replicate the bug, navigate to $LOCALAPPDATA%\CrashDumps in the File Explorer and upload the zipped PowerToys.Settings.exe.*.dmp file to a GitHub comment.

Sorry for the extremely delayed response. I've reinstalled the latest version from GitHub.
I have edited the registry, the dump isn't being created and that folder doesn't exist. Here's a screenshot of what I have in the registry.

As for the other GUIs, the only thing I seem to have access to is PowerRename in the rightclick menu, and that does work properly.

Sorry for the extremely delayed response. I've reinstalled the latest version from GitHub. Here is the crash dump.
As for the other things, the only part I seem to have access to is PowerRename in the rightclick menu, and that does appear to be working.
PowerToys.Settings.exe.3436.zip

I have the same problem but in my case no matter the version it still persists.
https://github.com/microsoft/PowerToys/issues/22403
Closed it after seeing it was duplicated but still the log upload is there.

I'm stupid... i should have checked the event viewer, anyway its was a dependencies problem, .net was installed but it was not in PATH.
Try installing .net 6 runtime and make sure its in path.

Well, I tried installing .net 6 to the default path and that changed nothing.

Try to call dotnet on powershell to see if its  in PATH, or manually add it, in my case reinstalling .net did nothing, I had to add it manually to path and that fixed it. Or check the event viewer to see why its crashing.

Sorry I'm a complete novice when it comes to these things, I have near zero knowledge on the subject. I don't know what you mean by "in PATH". I don't even know what it means to call it in Powershell or the commands to do so.

this still happens under 0.66?  /needinfo

windows event
错误应用程序名称: PowerToys.Settings.exe，版本: <IP_ADDRESS>，时间戳: 0x641de100
错误模块名称: KERNELBASE.dll，版本: 10.0.19041.2788，时间戳: 0x62e593d6
异常代码: 0xc000027b
错误偏移量: 0x0000000000117cd2
错误进程 ID: 0x22bd4
错误应用程序启动时间: 0x01d978d04303982c
错误应用程序路径: C:\Program Files\PowerToys\Settings\PowerToys.Settings.exe
错误模块路径: C:\WINDOWS\System32\KERNELBASE.dll
报告 ID: 0dbeb1bb-0c77-4201-a2d3-2ad68cd8a697
错误程序包全名:
错误程序包相对应用程序 ID:

dump file
https://we.tl/t-4aawPoBQko
i open explorer and choose powertoys.settings get dump
powertoys version 0.69.1

Is this issue still relevant in v0.74? /needinfo


fix build.sh and install_dependencies.sh on macos

set stop on error, so that the script won't continue to run when error happens
added missing dependencies for mac: cmake libmongoc mongo-cxx-driver doxygen
deleting /usr/local/binaryen before copy, so that the script runs idempotently
link files under /usr/local/binaryen/bin to /usr/local/bin, instead of /usr/local (assuming that was a mistake)

These issues have been addressed by PR #1370


HED-SCORE library schema 1.0.0 release

Following an extensive revision process of the schema, we can officially release it.

I was working on the tools and fixed a bug finding the following issue:
The term "Body-part" is already used in the standard schema.
Item/Biological-item/Anatomical-item/Body-part
Finding-property/Location-property/Body-part
I didn't find any other new duplicates, but I will update you immediately if I do...

Thanks!
Body-part in HED-SCORE is used to characterize semiologic findings and, indeed, partially overlaps with Item/Biological-item/Anatomical-item/Body-part.
/Finding-property/Location-property/Body-part:

[ ] Body-part-eyelid
[x] Body-part-face -> /Item/Biological-item/Anatomical-item/Body-part/Head/Face
[x] Body-part-arm -> /Item/Biological-item/Anatomical-item/Body-part/Upper-extremity
[x] Body-part-leg -> /Item/Biological-item/Anatomical-item/Body-part/Lower-extremity
[x] Body-part-trunk -> /Item/Biological-item/Anatomical-item/Body-part/Torso
[ ] Body-part-visceral
[ ] Body-part-hemi

With this proposal, specifically, the use of relatedTag and suggestedTag attributes with standard tags, we can partially resolve this by adding suggestedTag to /Finding-property/Location-property pointing to the standard tags in Item/Biological-item/Anatomical-item/Body-part.
Any thoughts on whether there is room for the rest of the SCORE tags (eyelid, visceral, hemi) in the standard schema?
@VisLab @dorahermes @dungscout96 @IanCa @happy5214

We're going to work through how the merged schema would work with and
without the merge using this proposed score.
The current thought from the HED working group (after a very vigorous
discussion) is now that we would allow subtrees of a library schema to hook
on to anywhere in the standard schema.
I'd like to work through this with this new score in the next few days
before release and see how it would like.
I may merge into the prerelease after I have a chance to look at it, but I
would like to keep open the option of using a version merged with the
standard schema for the final release as it would greatly improve the
usability and we could really leverage the relatedTag and suggestedTag.
Give us a chance to work through the details and then maybe we can have a
meeting to go over it.
Great news that the license issues have all been resolved!
On Thu, Jan 19, 2023 at 5:51 PM Tal Pal Attia @.***>
wrote:

Thanks!
Body-part in HED-SCORE is used to characterize semiologic findings and,
indeed, partially overlaps with
Item/Biological-item/Anatomical-item/Body-part.
/Finding-property/Location-property/Body-part:

Body-part-eyelid
Body-part-face ->
/Item/Biological-item/Anatomical-item/Body-part/Head/Face
Body-part-arm ->
/Item/Biological-item/Anatomical-item/Body-part/Upper-extremity
Body-part-leg ->
/Item/Biological-item/Anatomical-item/Body-part/Lower-extremity
Body-part-trunk ->
/Item/Biological-item/Anatomical-item/Body-part/Torso
Body-part-visceral
Body-part-hemi

With this proposal
https://github.com/hed-standard/hed-schemas/issues/52#issuecomment-1385453074,
specifically, the use of relatedTag and suggestedTag attributes with
standard tags, we can partially resolve this by adding suggestedTag to
/Finding-property/Location-property pointing to the standard tags in
Item/Biological-item/Anatomical-item/Body-part.
Any thoughts on whether there is room for the rest of the SCORE tags
(eyelid, visceral, hemi) in the standard schema?
@VisLab https://github.com/VisLab @dorahermes
https://github.com/dorahermes @dungscout96
https://github.com/dungscout96 @IanCa https://github.com/IanCa
@happy5214 https://github.com/happy5214
—
Reply to this email directly, view it on GitHub
https://github.com/hed-standard/hed-schemas/pull/54#issuecomment-1397754261,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJCJOSDI5VDRPI6BUNJ7ALWTHHO5ANCNFSM6AAAAAAUAZCWSU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Great, thank you @VisLab ! Looking forward to discussing this further.
Once this version is merged and used by the HED tools, we can fully validate the HED-SCORE bids-example ! 🥳

@tpatpa I noticed that score_0.0.1 is removed.  Since we didn't officially tag it as a release, I guess that is okay, but I wanted to verify. We're going to have to develop a policy about how this is handled.
I have created a score branch.  Would you please change your PR to merge into the score branch.
We need to rerun the latest schema validators and do a final check before creating an official release.
It will be easier to do that on a separate branch. Thanks!

Yes, score_0.0.1 was removed on purpose. I feel it is too preliminary... But, I can, of course, restore if needed.

@tpatpa @dorahermes @dungscout96 one other question....   This is about how we should handle prereleases.
We have links to both current and prerelease versions in the README and other places.  Eventually @dungscout96 is going to change the schema browser so that all of these are available from one browser.  However, until this happens if we completely remove the prerelease  these links will break. Even after there is a merged viewer, it would be good to have an anchor point to a prerelease.
When we do the actual release with tags etc. we could create a copy of 1.0.0 as 1.0.1 prelease so that there will be an anchor point going forward.  If there are other ideas on this let me know.

lgtm!


[WIP] [INCR 77] test with python 3.6/3.7 & django 2.0/2.1

Work In Progress, Fixes https://openedx.atlassian.net/browse/INCR-77

Thanks for the pull request, @singuliere! I've created OSPR-3066 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is a great start on implementing Python 3 support here, and well beyond the scope of the ticket (which was meant to be just the tox.ini changes). 😄 Note that in addition to making the tickets bite-sized in terms of ease of implementation, another goal of the INCR project is keeping the changes small enough to be easily reviewed.  43 files changed is starting to stretch that a bit.
The changes so far are small enough this is probably still manageable for review, but at this point please focus on getting Travis to pass with Python 2.7 with these changes in place rather than trying to fix Python 3.6 and 3.7 support.  The Python 3 tests can either be removed from Travis or flagged as allowed to fail for now.  Any remaining work to fix problems under Python 3 can be written up as new INCR tickets.
Thanks for the help with this!

@singuliere Thank you for your contribution. Can you let me know once checks pass?

blocked by https://github.com/edx/xblock-sdk/pull/146

This is a great start on implementing Python 3 support here, and well beyond the scope of the ticket (which was meant to be just the tox.ini changes)

Indeed :-) I got lost yesterday chasing and trying to fix the CI which still eludes me. I will resume work on this PR once this is done.
I'll split this PR to remove what is out of scope for INCR 77 as suggested. Do you recommend I create another PR with the remaining changes that are out of scope? If so, is there already an issue somewhere in INCR that would be in scope?

Part of the strategy with the INCR tickets has been to avoid writing tickets which are blocked on other work that hasn't been done yet (since that's usually not obvious when you're looking for something to start working on).  So in cases like this where ultimately a few different INCR tickets can be used to get to the ultimate goal, some of them may not be written until an earlier one is merged.

this PR still contains all commits from #146 and #144 (required for tests to pass) and is therefore not yet ready for review. It will be rebased once #146 and #144 are merged.

Rebased on top of #144
this PR still contains all commits from #146 (required for tests to pass) and is therefore not yet ready for review. It will be rebased once #146 is merged.

rebased & repushed. Last one :-P

@singuliere 🎉 Your pull request was merged!
Please take a moment to answer a two question survey so we can improve your experience in the future.


[chart] Chart Events

feat: signalsmanager emits events when failing to fetch data or when retrying to fetch data

Has been solved otherwise, plus conflicts with ne web-component setup. CLosing for now!


Submit PySceS 0.9.9

id: pysces
version: 0.9.9
specificationsUrl: https://raw.githubusercontent.com/biosimulators/Biosimulators_PySCeS/6fd8c03e70b3e005b257a9a2436a67f21c0554a2/biosimulators.json
specificationsPatch:
version: 0.9.9
image:
url: ghcr.io/biosimulators/biosimulators_pysces/pysces:0.9.9
validateImage: true
commitSimulator: true

Thank you @biosimulators-daemon for your submission to the BioSimulators simulator validation/submission system!
The BioSimulators validator bot is validating the specifications of your simulator, validating your Docker image and committing your simulator to the BioSimulators registry.
We will discuss any concerns with your submission in this issue.
A complete log of your simulator submission job is available here.

The specifications of your simulator is valid!

Summary of tests

Executed 57 test cases

Passed 44 test cases:

cli.CliDescribesSupportedEnvironmentVariablesInline
cli.CliDisplaysHelpInline
cli.CliDisplaysVersionInformationInline
combine_archive.CombineArchiveHasSedDocumentsInNestedDirectories
combine_archive.CombineArchiveHasSedDocumentsWithSameNamesInDifferentInNestedDirectories
combine_archive.WhenACombineArchiveHasAMasterFileSimulatorOnlyExecutesThisFile
combine_archive.WhenACombineArchiveHasNoMasterFileSimulatorExecutesAllSedDocuments
docker_image.DeclaresSupportedEnvironmentVariables
docker_image.DefaultUserIsRoot
docker_image.HasBioContainersLabels
docker_image.HasOciLabels
log.SimulatorReportsTheStatusOfTheExecutionOfCombineArchives
log.SimulatorReportsTheStatusOfTheExecutionOfSedDocuments
log.SimulatorReportsTheStatusOfTheExecutionOfSedOutputs
log.SimulatorReportsTheStatusOfTheExecutionOfSedTasks
published_project.SimulatorCanExecutePublishedProject:sbml-core/Caravagna-J-Theor-Biol-2010-tumor-suppressive-oscillations
published_project.SimulatorCanExecutePublishedProject:sbml-core/Edelstein-Biol-Cybern-1996-Nicotinic-excitation
published_project.SimulatorCanExecutePublishedProject:sbml-core/Parmar-BMC-Syst-Biol-2017-iron-distribution
results_report.SimulatorGeneratesReportsOfSimulationResults
sedml.SimulatorCanResolveModelSourcesDefinedByUriFragments
sedml.SimulatorCanResolveModelSourcesDefinedByUriFragmentsAndInheritChanges
sedml.SimulatorProducesLinear2DPlots
sedml.SimulatorProducesLogarithmic2DPlots
sedml.SimulatorProducesMultiplePlots
sedml.SimulatorProducesReportsWithCuratedNumberOfDimensions
sedml.SimulatorSupportsAddReplaceRemoveModelElementChanges
sedml.SimulatorSupportsAlgorithmParameters
sedml.SimulatorSupportsComputeModelChanges
sedml.SimulatorSupportsDataGeneratorsWithDifferentShapes
sedml.SimulatorSupportsDataSetsWithDifferentShapes
sedml.SimulatorSupportsModelAttributeChanges
sedml.SimulatorSupportsModelsSimulationsTasksDataGeneratorsAndReports
sedml.SimulatorSupportsMultipleReportsPerSedDocument
sedml.SimulatorSupportsMultipleTasksPerSedDocument
sedml.SimulatorSupportsRepeatedTasksWithChanges
sedml.SimulatorSupportsRepeatedTasksWithFunctionalRangeVariables
sedml.SimulatorSupportsRepeatedTasksWithFunctionalRanges
sedml.SimulatorSupportsRepeatedTasksWithMultipleSubTasks
sedml.SimulatorSupportsRepeatedTasksWithNestedFunctionalRanges
sedml.SimulatorSupportsRepeatedTasksWithNestedRepeatedTasks
sedml.SimulatorSupportsRepeatedTasksWithSubTasksOfMixedTypes
sedml.SimulatorSupportsRepeatedTasksWithVectorRanges
sedml.SimulatorSupportsUniformTimeCoursesWithNonZeroInitialTimes
sedml.SimulatorSupportsUniformTimeCoursesWithNonZeroOutputStartTimes

Failed 0 test cases

Skipped 13 test cases:

published_project.SimulatorCanExecutePublishedProject:bngl/Dolan-PLoS-Comput-Biol-2015-NHEJ
published_project.SimulatorCanExecutePublishedProject:bngl/test-bngl
published_project.SimulatorCanExecutePublishedProject:sbml-core/Ciliberto-J-Cell-Biol-2003-morphogenesis-checkpoint
published_project.SimulatorCanExecutePublishedProject:sbml-core/Szymanska-J-Theor-Biol-2009-HSP-synthesis
published_project.SimulatorCanExecutePublishedProject:sbml-core/Tomida-EMBO-J-2003-NFAT-translocation
published_project.SimulatorCanExecutePublishedProject:sbml-core/Varusai-Sci-Rep-2018-mTOR-signaling-LSODA-LSODAR-SBML
published_project.SimulatorCanExecutePublishedProject:sbml-core/Vilar-PNAS-2002-minimal-circardian-clock
published_project.SimulatorCanExecutePublishedProject:sbml-core/Vilar-PNAS-2002-minimal-circardian-clock-continuous
published_project.SimulatorCanExecutePublishedProject:sbml-core/Vilar-PNAS-2002-minimal-circardian-clock-discrete
published_project.SimulatorCanExecutePublishedProject:sbml-fbc/Escherichia-coli-core-metabolism
published_project.SimulatorCanExecutePublishedProject:sbml-qual/Chaouiya-BMC-Syst-Biol-2013-EGF-TNFa-signaling
sedml.SimulatorProducesLinear3DPlots
sedml.SimulatorProducesLogarithmic3DPlots

The image for your simulator is valid!

Your submission was committed to the BioSimulators registry. Thank you!
Future submissions of subsequent versions of pysces to the BioSimulators registry will be automatically validated. These submissions will not require manual review by the BioSimulators Team.


Feature request: connect APISIX through mTLS

We can add configuration item in $HOME/.adc.yaml.
And add option in adc configure command

fixed by #55


Release @buzz with instant onboarding

Version of buzz with new onboarding is release to both playstore and app store


Refine .drone.yml pipeline design

Fixed the following problems:

Golang version in .drone.jsonnet was pointed to 1.11, but 1.13.0 in .drone.yml

Multiple fileds not aligned in .drone.yml, .drone.jsonnet.

Updated

May 10, 2020 - remove section of drone-agent and drone-controller
Sep 24, 2020 - rebase v1.9.1
Sep 24, 2020 - .drone.yml and .drone.jsonnet was removed, ref: https://github.com/drone/drone/commit/0e4af8d35b9fd3ecd1302a9a96d3efcbe64414dc

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'm aware there is another PR for bumping golang version #2936, but this PR is aim to keep .drone.yml and .drone.jsonnet aligned, but not version bumping. So I just bump the golang version to 1.13.0 to keep aligned with .drone.yml (v1.7.0).

Controller and agent won't receive any updates, they are deprecated in favor of the runners built on the runners github organization.

@tboerger Oops, I didn't aware there's another GitHub organization drone-runners exist.
I've update the PR, removed the logic for agent and controller, with some fixes, please review the PR again, thanks.

Questions,

Should I update .drone.star as well? or just leave it untouched?
Should I remove the logic for agent and controller from the file scripts/build.{sh,ps1}?

close, since most update was override by 4a1c639 and removed in 0e4af8d

close, since most update was override by 4a1c639 and removed in 0e4af8d


[Enhancement] keep hadoop-hdfs-client and hadoop-common version consistent

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Feature Description (功能描述)
refer to  #454
hadoop-common 3.3.1
hadoop-hdfs-client 2.10.1
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

maybe unify them with one version like ${hdfs.version}

I can help to improve it.


Update examples.rst with denoising-diffusion-flax

@cgarciae suggested that I add denoising-diffusion-flax as a community example
It implements DDPM with the latest research findings

Thanks @yiyixuxu! I enjoyed reading through your repo, its a great showcase of how to structure a Flax project, congrats!
Can you please put it under the Examples section? The Models section is for projects that provide pretrained SOTA models of standard architectures (often ports) while the Examples section is for projects that showcase how to train models using Flax.

I moved it :)
Thanks! I followed the structure of official examples - they are super helpful


socketify.py - Create pre-build libraries for debian and windows

I created this to users get a better experience and remove the needs of an compiler when installing the package
#3

Will add support for windows and mac too like https://github.com/uNetworking/uWebSockets.js

MacOS Arm and x64 are Ok
Linux x64 are Ok
Windows not ok yet

MacOS Arm and x64 OK
Linux x64  OK
Windows x64 OK
<3


Apply level dependent color formatting to other fields

Hello,
I just stumbled upon your package and really like it. Especially the extensive documentation.
While reading said documentation I also realized though that something I'd like to do isn't possible using coloredlogs.
I would like to format the color of the levelname according to my style definition for the level and not the message.
Example:
[ERROR] some error                with ERROR in red and "some error" in the default color
[WARNING] some warning     with WARNING in yellow and "some warning" in the default color
Do you think this would be a possibility to be added?
Cheers,
Ben

That's exactly what I need. For example, let me show how I tried to use the library:
coloredlogs.install(     logger=logger,     level=logging.DEBUG,     fmt="%(asctime)s.%(msecs)03d [%(levelname)s] %(message)s",     level_styles=dict(         debug={"color": "yellow"},         info={"color": "white"},         warning={"color": "red"},         error={"color": "red"},     ),     field_styles=dict(         asctime={"color": "blue"},         message={"color": "white"},     ), )

That's exactly what I need. For example, let me show how I tried to use the library:
coloredlogs.install(
    logger=logger,
    level=logging.DEBUG,
    fmt="%(asctime)s.%(msecs)03d [%(levelname)s] %(message)s",
    level_styles=dict(
        debug={"color": "yellow"},
        info={"color": "white"},
        warning={"color": "red"},
        error={"color": "red"},
    ),
    field_styles=dict(
        asctime={"color": "blue"},
        message={"color": "white"},
    ),
)

Here I emphasized that I want message to be white. And also I omitted levelname color within field styles. That means I expect the message to be always white and levelname to be dependent on the current level.

I am also confused log level colour is applied that the message text only on the terminal and not the other fields. What I am looking for is that the whole line printed onto the terminal is of the same colour dependant on the log level of the message. This includes the message log level and the message text. How can this be done?


Pytorch's nn.BatchNorm2d does not work in TorchModel()

Issue Type
Bug
Source
binary
Secretflow Version
SecretFlow 1.2.0.dev20231009
OS Platform and Distribution
macOS 13.2.1 (22D68)
Python version
Python 3.8.18
Bazel version
No response
GCC/Compiler version
No response
What happend and What you expected to happen.
It seems that Pytorch's nn.BatchNorm2d does not work in TorchModel(). I found if nn.BatchNorm2d is included in the model, the following error would occur. While I removed them from the model, the code can run normally.
Traceback (most recent call last):
  File "batchnorm_error_reproduce.py", line 187, in <module>
    history = fl_model.fit(
  File "/Users/mwu11/anaconda3/envs/sf/lib/python3.8/site-packages/secretflow/ml/nn/fl/fl_model.py", line 453, in fit
    initial_weight = self.initialize_weights()
  File "/Users/mwu11/anaconda3/envs/sf/lib/python3.8/site-packages/secretflow/ml/nn/fl/fl_model.py", line 123, in initialize_weights
    initial_weight = self._aggregator.average(clients_weights, axis=0)
  File "/Users/mwu11/anaconda3/envs/sf/lib/python3.8/site-packages/secretflow/security/aggregation/secure_aggregator.py", line 297, in average
    return self._device(_average)(
  File "/Users/mwu11/anaconda3/envs/sf/lib/python3.8/site-packages/secretflow/device/device/pyu.py", line 98, in wrapper
    sfd.remote(self._run)
  File "/Users/mwu11/anaconda3/envs/sf/lib/python3.8/site-packages/ray/remote_function.py", line 226, in remote
    return func_cls._remote(args=args, kwargs=kwargs, **updated_options)
  File "/Users/mwu11/anaconda3/envs/sf/lib/python3.8/site-packages/secretflow/distributed/primitive.py", line 107, in _remote
    args, kwargs = _resolve_args(*args, **kwargs)
  File "/Users/mwu11/anaconda3/envs/sf/lib/python3.8/site-packages/secretflow/distributed/primitive.py", line 97, in _resolve_args
    actual_vals = ray.get(list(refs.values()))
  File "/Users/mwu11/anaconda3/envs/sf/lib/python3.8/site-packages/ray/_private/client_mode_hook.py", line 105, in wrapper
    return func(*args, **kwargs)
  File "/Users/mwu11/anaconda3/envs/sf/lib/python3.8/site-packages/ray/_private/worker.py", line 2309, in get
    raise value.as_instanceof_cause()
ray.exceptions.RayTaskError(AssertionError): ray::_Masker.mask() (pid=94879, ip=<IP_ADDRESS>, repr=<secretflow.security.aggregation.secure_aggregator._Masker object at 0x7f934f471bb0>)
  File "/Users/mwu11/anaconda3/envs/sf/lib/python3.8/site-packages/secretflow/device/proxy.py", line 79, in wrapper
    return method(*args, **kwargs)
  File "/Users/mwu11/anaconda3/envs/sf/lib/python3.8/site-packages/secretflow/security/aggregation/secure_aggregator.py", line 76, in mask
    assert (
AssertionError: Data should have same dtypes but got int64 float32.

Reproduction code to reproduce the issue.
from tqdm import tqdm
import numpy as np
import torch
import torch.nn as nn
import torch.optim as optim
import torch.utils.data as data
import torchvision.transforms as transforms

import medmnist
from medmnist import INFO, Evaluator

import secretflow as sf
from secretflow.ml.nn.utils import BaseModule, TorchModel
from secretflow.ml.nn.fl.utils import metric_wrapper, optim_wrapper
from secretflow.ml.nn import FLModel
from torchmetrics.classification import Accuracy, Precision
from secretflow.security.aggregation import SecureAggregator
from secretflow.utils.simulation.datasets import load_mnist
from torch.nn import functional as F
from secretflow.data.ndarray import load

data_flag = 'dermamnist'
# data_flag = 'breastmnist'
download = True

NUM_EPOCHS = 3
BATCH_SIZE = 128
lr = 0.001

info = INFO[data_flag]
task = info['task']
n_channels = info['n_channels']
n_classes = len(info['label'])

print(f'n_channels: {n_channels}')
print(f'n_classes: {n_classes}')

DataClass = getattr(medmnist, info['python_class'])

# preprocessing
data_transform = transforms.Compose([
    transforms.ToTensor(),
    transforms.Normalize(mean=[.5], std=[.5])
])

# load the data
train_dataset = DataClass(split='train', transform=data_transform, download=download)
val_dataset = DataClass(split='val', transform=data_transform, download=download)
test_dataset = DataClass(split='test', transform=data_transform, download=download)

# encapsulate data into dataloader form
train_loader = data.DataLoader(dataset=train_dataset, batch_size=BATCH_SIZE, shuffle=True)
train_loader_at_eval = data.DataLoader(dataset=train_dataset, batch_size=2*BATCH_SIZE, shuffle=False)
val_loader = data.DataLoader(dataset=val_dataset, batch_size=2*BATCH_SIZE, shuffle=False)
test_loader = data.DataLoader(dataset=test_dataset, batch_size=2*BATCH_SIZE, shuffle=False)

class Net(BaseModule):
    def __init__(self):
        super(Net, self).__init__()

        self.layer1 = nn.Sequential(
            nn.Conv2d(3, 16, kernel_size=3),
            nn.BatchNorm2d(16),
            nn.ReLU())

        self.layer2 = nn.Sequential(
            nn.Conv2d(16, 16, kernel_size=3),
            nn.BatchNorm2d(16),
            nn.ReLU(),
            nn.MaxPool2d(kernel_size=2, stride=2))

        self.layer3 = nn.Sequential(
            nn.Conv2d(16, 64, kernel_size=3),
            nn.BatchNorm2d(64),
            nn.ReLU())

        self.layer4 = nn.Sequential(
            nn.Conv2d(64, 64, kernel_size=3),
            nn.BatchNorm2d(64),
            nn.ReLU())

        self.layer5 = nn.Sequential(
            nn.Conv2d(64, 64, kernel_size=3, padding=1),
            nn.BatchNorm2d(64),
            nn.ReLU(),
            nn.MaxPool2d(kernel_size=2, stride=2))

        self.fc = nn.Sequential(
            nn.Linear(64 * 4 * 4, 128),
            nn.ReLU(),
            nn.Linear(128, 128),
            nn.ReLU(),
            nn.Linear(128, 7))

    def forward(self, x):
        x = self.layer1(x)
        x = self.layer2(x)
        x = self.layer3(x)
        x = self.layer4(x)
        x = self.layer5(x)
        x = x.view(x.size(0), -1)
        x = self.fc(x)
        return x

# Check the version of your SecretFlow
print('The version of SecretFlow: {}'.format(sf.__version__))

# In case you have a running secretflow runtime already.
sf.shutdown()

sf.init(['alice', 'bob', 'charlie'], address='local')
alice, bob, charlie = sf.PYU('alice'), sf.PYU('bob'), sf.PYU('charlie')

train_x_alice = train_dataset.imgs[:len(train_dataset)//2]
train_x_bob = train_dataset.imgs[len(train_dataset)//2:]

train_x_alice = np.transpose(train_x_alice, (0, 3, 1, 2))
train_x_bob = np.transpose(train_x_bob, (0, 3, 1, 2))

train_y_alice = train_dataset.labels[:len(train_dataset)//2]
train_y_bob = train_dataset.labels[len(train_dataset)//2:]

val_x_alice = val_dataset.imgs[:len(val_dataset)//2]
val_x_bob = val_dataset.imgs[len(val_dataset)//2:]

val_x_alice = np.transpose(val_x_alice, (0, 3, 1, 2))
val_x_bob = np.transpose(val_x_bob, (0, 3, 1, 2))

val_y_alice = val_dataset.labels[:len(val_dataset)//2]
val_y_bob = val_dataset.labels[len(val_dataset)//2:]

np.save('train_x_alice.npy', train_x_alice)
np.save('train_x_bob.npy', train_x_bob)
np.save('train_y_alice.npy', train_y_alice)
np.save('train_y_bob.npy', train_y_bob)

np.save('val_x_alice.npy', val_x_alice)
np.save('val_x_bob.npy', val_x_bob)
np.save('val_y_alice.npy', val_y_alice)
np.save('val_y_bob.npy', val_y_bob)

train_x = load({alice: 'train_x_alice.npy', bob: 'train_x_bob.npy'}, partition_way='horizontal')
train_y = load({alice: 'train_y_alice.npy', bob: 'train_y_bob.npy'}, partition_way='horizontal')

val_x = load({alice: 'val_x_alice.npy', bob: 'val_x_bob.npy'}, partition_way='horizontal')
val_y = load({alice: 'val_y_alice.npy', bob: 'val_y_bob.npy'}, partition_way='horizontal')

loss_fn = nn.CrossEntropyLoss

optim_fn = optim_wrapper(optim.Adam, lr=1e-3)

model_def = TorchModel(model_fn=Net,
                       loss_fn=loss_fn,
                       optim_fn=optim_fn,
                       metrics=[
                           metric_wrapper(Accuracy, task="multiclass", num_classes=7, average='micro'),
                           metric_wrapper(Precision, task="multiclass", num_classes=7, average='micro')
                       ],)

device_list = [alice, bob]
server = charlie
aggregator = SecureAggregator(server, [alice, bob])

# spcify params
fl_model = FLModel(
    server=server,
    device_list=device_list,
    model=model_def,
    aggregator=aggregator,
    strategy='fed_avg_w',  # fl strategy
    backend="torch",  # backend support ['tensorflow', 'torch']
)

history = fl_model.fit(
    train_x,
    train_y,
    validation_data=(val_x, val_y),
    epochs=1,
    batch_size=128,
    aggregate_freq=1,
)

Hello, we will reply to you after internal discussion

When using nn.BatchNorm2d, the num_batches_tracked model weight's type is torch.int64 while other weight is torch.float32. The SecureAggregator (same in PlainAggregator) does not support different types in average.
In fact, BN is different from other models. In the scenario of federated learning, the BN model should only be operated locally and should not be aggregated. There are currently relevant solutions (https://arxiv.org/abs/2102.07623 , also see https://zhuanlan.zhihu.com/p/551722592), and the main idea is to extract the BN layer from the model and not perform aggregation.
You can try write your own Aggregator for processing. BTW, we have plans to implement and release the task of FedBN in secretflow. If you are interested, you are welcome to participate!


Loosen dependencies

Duckdb has some really nice syntax updates that I wanted to utilize with this package so I loosened the dependencies.
Tests still pass.
Curious to hear what else you think this MR might need!

Sounds good to me, I agree this should be loosened!
Just FYI though, the current duckdb~=0.5 version specifier is compatible with all versions of duckdb from 0.5 to <1.0. Right now the most recent version is duckdb 0.10.0. So this actually only affects pandas :)

Sounds good to me, I agree this should be loosened!
Just FYI though, the current duckdb~=0.5 version specifier is compatible with all versions of duckdb from 0.5 to <1.0. Right now the most recent version is duckdb 0.10.0. So this actually only affects pandas :)

Good eye! Sounds like I was conflating things in a brittle environment I was working in 🤔 🤷 🤦


Cards not flipping

Hi.
I have been a long-time user of your marvellous site. It has worked like a charm up until now. Today I noticed an issue on both the mobile and computer versions. The site still randomizes the cards but the only way to see which card it randomized to the next game is to read them from the address bar. For some reason, the cards are not flipping and only show the card's back sides.
Thank you in advance!
-FayDn

Fixed


Changed serve static check to include NODE_ENV=ci

This is needed to serve static assets when running acceptance tests on drone

LGTM

:thumbsup: :thumbsup:


Modifications of wordings and Debugging.

This is the pull request of the issue you assigned to me sir.

I don't see this a valid change to be accepted for Hacktoberfest 2023
You're just creating a separate class and changing a constant, which seems unnecessary as of now.
Also I don't think a specific issue is assigned to work on this. :/
@badoolee


Better LICM

bytecodealliance/cranelift#133 and bytecodealliance/cranelift#138 started some work toward improving LICM, in particular to better handle loops that end in the middles of ebbs; see the actual PRs for more discussion.
I've now merged those patches into a branch here:
https://github.com/CraneStation/cranelift/tree/better_licm

With the move from extended basic blocks to basic blocks has this become obsolete?


Need to add some image resources.

Add some image resources files into the app.
Note: Image should be clear and less size.

Subject: Interest in Contributing to PhotoAppCompose
Hi @akapps21
I hope this message finds you well. My name is Akshay, and I am a software developer with experience in Kotlin, Jetpack Compose, Android development. I recently came across your project, PhotoAppCompose and I am very impressed with its vision and implementation.
I noticed that there is an issue regarding some image resources files in application. I would love to assist in addressing this issue and any other areas where my expertise could be of use.
Please let me know if there are any contribution guidelines or specific areas where you need assistance.
Thank you for considering my request. I look forward to the possibility of contributing to PhotoAppCompose and working with you and the team.
Best regards,
Akshay
https://github.com/Akshaygithubsd


DMN Editor: Context Menu is empty in List expression header

Closes: kiegroup/kie-issues#375
before

after

Thank you @jomarko, what about the # cell? Can we prevent the opening of the Context Menu in that case?


Added a nmea_gpsd_driver

Based off of the nmea_socket_driver by @reinzor (pull request #16). This uses a TCP connection to a GPSD server, send the command to watch, and requests raw nmea sentences.

Retargeted to master.

I'm going to close this PR as abandoned. Feel free to open a new pull request on the master branch for ROS melodic.


Hello, we are unable to access the dataset download link you provided

Hello, we are unable to access the dataset download link you provided because you are using the school's online drive and we cannot access the edu website

Which url? https://www.cs.virginia.edu/yanjun/jack/vision/ should be accessible now


Running test cases in parallel

There are over 7,500 tests currently generated and running jobs over those is time consuming, especially with those having to access remote services. Since all tests are independent to one another, parallelising their running will potentially speed up the test jobs significantly.

nosetests supports parallel execution of tests when run on a multi-core machine:

http://nose.readthedocs.org/en/latest/doc_tests/test_multiprocess/multiprocess.html
http://nose.readthedocs.org/en/latest/plugins/multiprocess.html

I updated prov_interop/interop_tests/test_converter.py to define the multiprocess_can_split variable required to use this feature:
class ConverterTestCase(unittest.TestCase):

  _multiprocess_can_split_ = True

Within the test_case method I changed the print statement to also print the process ID:
  def test_case(self, index, ext_in, file_ext_in, ext_out, file_ext_out):
    print(("Test case: " + str(index) +
          " from " + ext_in +
          " to " + ext_out + " Process: " + str(os.getpid())))

I changed the test output file names to include the process ID (as otherwise there would be a risk that one process might delete the output file name for another process):
    self.converter_ext_out = "out." + str(os.getpid()) + "." + ext_out

If the tests on a 4 processor machine, and nosetests processes flag is used to request 4 processes:
$ nosetests --processes=4 --nocapture -v prov_interop.interop_tests.test_provtoolbox

then the tests are run in multiple processes:
Test case: case1 from json to json Process: 3978
Test case: case1 from json to provn Process: 3994
Test case: case1 from json to provx Process: 4018
Test case: case1 from json to trig Process: 4049
Test case: case1 from json to ttl Process: 3978
Test case: case1 from provn to json Process: 4049
Test case: case1 from provn to provn Process: 3994
Test case: case1 from provn to provx Process: 4018

Commit: ed8e7b21b84cf32a4e815626548e1618902de351
I updated prov_interop/provstore/converter.py to include a process ID as part of the document when it is placed within ProvStore (again to avoid requests clashing):
    store_request = {ProvStoreConverter.CONTENT: doc,
                     ProvStoreConverter.PUBLIC: True,
                     ProvStoreConverter.REC_ID: str(os.getpid()) + "." + in_format}

Commit: 4c0b9d68cbc7e7d4163a5e1f504e73e3ef985f32
I made similar changes to service-tests (in prov_service_tests/test_service.py and prov_service_tests/test_provstore.py). Commit: e53e89bcc3dd69d10dea2628eb996576ea93216f.
This would not be of use in Travis. For Travis, their Parallelizing your builds across virtual machines recommends the use of their build matrix. An example of this was already used for interop-test-runner's .travis.yml to run compnent tests concurrently on Travis's virtual machines.
...example to follow...

This would not be of use in Travis. For Travis, their Parallelizing your builds across virtual machines recommends the use of their build matrix.
An example of this was already used for interop-test-runner's .travis.yml to run compnent tests concurrently on Travis's virtual machines.
If the test cases in the testcases repository were grouped into sub-directories, then the interoperability test harness could be run on each sub-directory in parallel. For example, here is a .travis.yml file build matrix that could be used in, for example provpy-interop-job's .travis.yml, that would run tests in parallel for subsets of the test cases, if they were placed into sub-directories:
env:
  matrix:
    - TESTS=test-cases/test-setA
    - TESTS=test-cases/test-setB
    - TESTS=test-cases/test-setC
    - TESTS=test-cases/test-setD

As an example of this in use, a simplified version of the ProvPy .travis.yml file is:
language: python

python:
  - 2.7
  - 3.4

env:
  matrix:
    - TESTS=test-cases/test-set1
    - TESTS=test-cases/test-set2
    - TESTS=test-cases/test-set3
    - TESTS=test-cases/test-set4

addons:
  apt:
    packages:
    - zlib1g-dev
    - libxslt1-dev

before_install:
  - echo "Getting test cases..."
  - echo "Getting ProvPy source..."
  - echo "Getting test harness..."
  - echo "Downloading and installing ProvToolbox from provenance.ecs.soton.ac.uk"
  - echo "Creating local configuration..."

script:
  - echo "Running ProvPy on $TESTS"

When Travis CI runs this it spawns 8 jobs:
2.1  Python: 2.7  TESTS=test-cases/test-set1
2.2  Python: 2.7  TESTS=test-cases/test-set2
2.3  Python: 2.7  TESTS=test-cases/test-set3
2.4  Python: 2.7  TESTS=test-cases/test-set4
2.5  Python: 3.4  TESTS=test-cases/test-set1
2.6  Python: 3.4  TESTS=test-cases/test-set2
2.7  Python: 3.4  TESTS=test-cases/test-set3
2.8  Python: 3.4  TESTS=test-cases/test-set4

An excerpt from the log file of the first job is:
Getting test cases...
Getting ProvPy source...
Getting test harness...
Downloading and installing ProvToolbox from provenance.ecs.soton.ac.uk
Creating local configuration...
Running ProvPy on test-cases/test-set1

I haven't had a chance to set up the local Jenskin environment, but your solution seems to be suitable for that. I wlll look into setting this up.
Thank you for investigate this.


Kanban Board for Application

This is the link to the kanban board for final capstone project
- https://github.com/users/t-bello7/projects/2/views/1
The project consists of 4 members.

@Meltrust Thank you for the review.

Hi @t-bello7,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To highlight:

All cards have been assigned✔

Required Changes ♻

[ ] Kindly, please add descriptions for all your cards, as stated in the project requirements.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Bug: When you change the device orientation it exit the PDF reading

Issue Summary
If the orientation of the phone changes, the PDF reading is exited and is asking again to choose a PDF file!
Steps to Reproduce the Problem
Open the app
choose a pdf and open it
then change the orientation of the device from vertical to horizontal (or vice versa)
the pdf reading is lost and you are asked to choose the pdf file again
Specifications

App Version: 3.5
Android Version: 10

PS: you are doing a wonderful job keep it up!! thanks :)

This will be fixed when #92 gets merged (sorry, my fault!).

thank you very much!

Fixed with #92 merge


Remove some unused assignments2

These all feel like bugs where they are supposed to be used but aren't  @dclarizio @h-kataria @martinpovolny Please review.

@fryguy reviewed these changes, those unused variables are leftover variables from refactoring/cleanup etc.

These all look like valid finds, since they are creating unused local vars . . . I agree with @h-kataria, these are most likely refactoring remnants.


[Design] Added TagHelper discovery to Razor project system

#1744
@rynowak @NTaylorMullen
Pending:

Need to add the OnBuildComplete trigger for the project system.
React to these changes on WTE
Tests

🆙 📅

🆙 📅

Looks good, get it in once @rynowak signs off.

🆙 📅


Delete card

Value Proposition
As a user, I want to delete data in order to interact with previously saved content.
Description

Acception Criteria

[ ] delete button displayed on each card

Tasks

[ ] add delete function and hand it down to cards
[ ] display delete button on each card and implement delete function on the button

Hi Gesa,
I am not sure, if I understand the use case correctly. Why should the user delete data in order to interact with the previous content?

Hi @CathrinTruchan,
It means that there is already content saved (in my case in a pre-saved array) and the user wants to interact with this content. The interaction means the deletion in this case.
In the next user story I would write it the same but not for deletion but for edition.

Aaaah, ok. Now I get it :) Looks good then :)

Thank you @CathrinTruchan :)

Hey Cathrin,
after another comment in another user story I'm thinking about placing the delete-function only on the details-page of the card and not on each card on the card-list. But I'm not sure yet. Maybe you have a spontaneous reflection on this? If not I will contact you later, when I update this or the other user story.

Hi @CathrinTruchan ,
I updated this user story: I no longer want to be able to delete the cards in the card-list, but on the details-page.

Hey Gesa, the only thing that is missing is a detailed list of all the details that should be displayed in your detail page.

Thank you, @F-Kirchhoff!
I added it as acception creteria. Did you mean it like that?

LGTM!


can not support es6 minification after upgrade to 0.4.6

the 0.4.6 version move the uglify2 to dependencies, so I can't specify the uglify2 version through yarn add git://github.com/mishoo/UglifyJS2#harmony-v2.8.22 --dev. cause the plugin will use its own dependency - uglify-js^2.8.29.

Duplicate of #32. See https://github.com/webpack-contrib/uglifyjs-webpack-plugin/issues/32#issuecomment-300421227 for a workaround.

this is no duplicate.. the workaround doesn't work anymore

Yup this is very unfortunate. Patch version breaking stuff... :( https://travis-ci.org/Hotell/typescript-lib-starter/builds/244709499?utm_source=github_status&utm_medium=notification

It is a duplicate. The workaround doesn't work exactly as noted there anymore, but if you change uglify-js "^2.8.29" to uglify-js "^2.8.22". Everything is fine.

I don't get it.

<EMAIL_ADDRESS><EMAIL_ADDRESS>"uglify-js@git://github.com/mishoo/UglifyJS2#harmony-v2.8.22":
  version "2.8.22"
  resolved "git://github.com/mishoo/UglifyJS2#278577f3cb75e72320564805ee91be63e5f9c806"
  dependencies:
    source-map "~0.5.1"
    yargs "~3.10.0"
  optionalDependencies:
    uglify-to-browserify "~1.0.0"

...
<EMAIL_ADDRESS><EMAIL_ADDRESS>  version "0.4.6"
  resolved "https://registry.yarnpkg.com/uglifyjs-webpack-plugin/-/uglifyjs-webpack-plugin-0.4.6.tgz#b951f4abb6bd617e66f63eb891498e391763e309"
  dependencies:
    source-map "^0.5.6"
    uglify-js "^2.8.22"
    webpack-sources "^1.0.1"

That is the yarn.lock file. I won't say that is a workaround.

It is a workaround, because it works. This is the exact same workaround as posted in #32, with uglify-js "^2.8.22" modified from uglify-js "^2.8.29"

There was a better workaround, just run the yarn add git://github.com/mishoo/UglifyJS2#harmony-v2.8.22 --dev command. But the 0.4.6 version broken this. that's why I create the issue.

@pkeuter This is not about the regular versions, but about the harmony branch. If uglifyjs-webpack-plugin states regular 2.8.29 as dependency, npm doesn't care if you have the harmony branch as dependency set.

@kurtextrem I know this is about the harmony branch, but changing the yarn.lock file as mentioned before, will let this plugin use the older version of the harmony branch of UglifyJS. Again: it's not a brilliant "solution", but it fixes the build for me.

Will be fixed by #63 soon, currently ES2015 minification isn't supported directly 😞

The other question is, why is a patch version breaking things? Just by removing this line: https://github.com/webpack-contrib/uglifyjs-webpack-plugin/blob/master/package.json#L54 this whole issue would be fixed again.

@kurtextrem peerDependency broke webpack, bc of the missing uglify packag, so reverting wouldn't fix it

@kurtextrem also note that for <1.0.0, semver guarantees don't exist.


BUG: Intersection unnecessary wrap

Accidentally rebased the refactor I made of intersection out.  This PR corrects this mistake.
Apologies for this @rhattersley
see #1663

Thanks for the fix. :+1:


Vulnerability roundup 101: glib-2.66.4: 1 advisory [5.3]

search, files

[ ] CVE-2021-28153 CVSSv3=5.3 (nixos-unstable)

Scanned versions: nixos-unstable: f5e8bdd07d1.
Cc @7c6f434c
Cc @lovek323
Cc @worldofpeace

See also: #116873

Fixed by #115436


chore: moved CapabilityPatternNode files to match modules

Moved files to folder structure that matches the modules defined by each purs files.
I am using VSCode. The modules were not discoverable by the VScode since the file names doesn't match the modules they were defined.

It's been quite some time since I've worked on this repo, so I'm not as familiar with it as I used to be. Could you provide more context on this issue?

Let me update my PR message. I am learning PureScript. This PR is possible completely unnecessary.


Fix voting pattern duplication

Motivation
pattern is saved per block even if it is already known, this pr will save us memory in the naive case.

bors merge

this is weird, travis says everything is green but bors says failed ? rerun ?

bors merge

bors merge

bors merge


Initial port of UnitTest++ to VxWorks 5.5.

UnitTest++ ported to VxWorks 5.5. All tests pass on VxWorks 5.5.

Ah, VxWorks.
Thanks for the PR. I'm happy to incorporate changes to support VxWorks; worked with it once myself. I'm going to take a closer look sometime soon, but my first question is:
Why do we need all of the VxWorks toolchain-specific project files? Is there no combination of CMake options that will work? For example, could you incorporate a custom toolchain file into your process? Or perhaps just use the Unix Makefile generator with the compiler and linker options set correctly?

Overall my main concern with this stands; the VxWorks toolchain-specific project files ideally don't belong here. I'd be happy to discuss elsewhere how we might manage this; perhaps we can spin up a new repository within the organization that @sulemankm could maintain?
Even if we solve that problem, there's not currently a way to 'inject' the TimeHelper class into the build.

Actually tornado generates a Makefile which can used to build it on Vxworks.  However, Tornado/VxWorks toolchain installation is required for building the framework and test anyway.  So as installation of Tornado/VxWorks toolchain is a must, then Tornado project fils would come in handy for building the UnitTest++ framework and tests.

By "inject" I was hinting at dependency injection; right now the correct TimeHelper is selected at compile time, rather than by a factory or anything like that. If we were to move all of the VxWorks toolchain-specific stuff out into a separate project as I proposed, we would still have to include the VxWorks-specific time helper in the core UnitTest++ build.

Ok, I got your point about injecting dependencies.  About the build solution, I think pre-compile-time selection of the appropriate header file is probably the easiest solution.

@sulemankm sorry I left this unattended for so long.
I'm interested in making some of these changes but not all of them. If we can get rid of the VxWorks project files, and figure out how to address the .at issue -- I'm thinking by having GetResults return a wrapper object for VxWorks -- then I'm game. If you're still interested in getting this pull folded in, can you make those changes? Or, add me as a collaborator to this pull request and I'll take a stab at it -- although you'll have to check the compiling for me.

How about GetResults return an object with an overloaded [] operator which internally calls the .at() method for vxWorks.  Just a wild idea.  I haven't tried it so I'm not sure if it is even feasible.  Just a wild idea!


dat.author needs a default

What should we show if there’s no author? "Anonymous"? Or just an empty string?
Can we show "My Dat" when I created the Dat?
https://github.com/datproject/dat-desktop/blob/master/elements/table.js#L230
Right now it looks like this (empty string before the dot):

'Anonymous' vs. 'My Dat' is good.


No scene option in viewer

When i use the viewer, i find the GUI don't have "scene"option. There's only control, render and export? How can i solve this?

Download
https://mega.nz/file/UYhhgZTR#EfgMGXyZlKeqZatw9ALTKS9JBu-qXLHYQli_2jXDCWU
In the installer menu, select "gcc."

Download https://mega.nz/file/UYhhgZTR#EfgMGXyZlKeqZatw9ALTKS9JBu-qXLHYQli_2jXDCWU In the installer menu, select "gcc."

why this file dangerous?

Do NOT click that link. That's a bot and it is posting malicious links.
I have already reported this scheme to GitHub so hopefully they will take care of it soon. Fingers crossed. In the mean time, no one should click the link!

i'm implementing it here https://github.com/nerfstudio-project/nerfstudio/pull/3363


Moving to an organization

@nanalan, do you think that we should create an organization for Haumea, or should we just keep it on my account?

It would help if you ever want to grow this. I see lots of potential in Haumea!

OK, I'll do it!

Done!


Add Comboios de Portugal GTFS feed and CARRIS GTFS-RT (Vehicle Positions) [SOURCES]

Hi!
This adds the new feed source for Comboios de Portugal and the realtime feed for CARRIS.
Thanks again for this great project :) 🚀

Thanks for this amazing contribution @joaodcp! I've changed the case of "CARRIS" to "Carris" to match the other feeds in the Mobility Database, and fixed a syntax issue.


Can you add support for yaml format?

Hi, I love this repo but unfortunately I have to add every proxy manually to openclash ? It's very time consuming, can you provide a yaml file so that on openclash I can just add a static URL to your yaml file to update the proxies automatically ?

requested feature added in #4

Thank you I really appreciate it


Add Plan9 shares for LCOW

Signed-off-by: John Howard<EMAIL_ADDRESS>

Pushed update addressing feedback. I'll do the same to VSMB in a separate PR

Rebased. Merge this first then I can rebase the other two @jstarks


Having two section on the same column

Hello, I would like to know how to have two sections at the end of the resume, like that:

i suppose i should edit the awesome-cv.cls file but i don't know how to do it

fixed it, used multicol package


Fix same ChangeSets on multiple WriteResults

1. Why is this change necessary?
When changing multiple entities in a single request (e.g. deleting an order and its order line items), the EntityWriteGateway matches the changesets wrongly. Hence respective _WRITTEN or _DELETED events will carry a wrong changeset.
This can cause all kinds of unintended behavior. We had this issue when deleting an order did not cause the reserved_stock of a product to be recalculated correctly.
2. What does this change do, exactly?
Improves the matching of states and WriteCommands in the EntityWriteGateway by using more set operations.
3. Describe each step to reproduce the issue or behaviour.

Create an order with multiple order line items.
Delete the order (and therefore the order line items)
Listen to the OrderEvents::ORDER_LINE_ITEM_DELETED_EVENT event. There will be an event for each of the order line item, but all changesets will refer to the same order line item.

4. Please link to the relevant issues (if any).
5. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-15473
Please use this issue to track the state of your pull request.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-15474
Please use this issue to track the state of your pull request.

Accidentally imported this twice.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-15557
Please use this issue to track the state of your pull request.

@maximilianruesch, thanks for the PR, we just merged it : )


Setting Enabled to 0 in cpkredir.ini doesn't do anything

This issue also applies to HiteModLoader.


RCO Pipeline modernize to WLO

What this PR does / why we need it?:

Modernize RCO pipeline to the level that WLO is at

Does this PR introduce a user-facing change?

[ ] User guide
[ ] CHANGELOG.md

Which issue(s) this PR fixes:

Fixes #

Successful RCO CI pipeline run:
https://cloud.ibm.com/devops/pipelines/tekton/729b3aea-0a81-4b4d-bd42-7e5811980010/runs/2e15c1e0-eabd-452f-9b16-b32941ed6341/build-scan-artifact/run-stage?env_id=ibm:yp:us-south


[Bugfix] fix missing last itl in openai completions benchmark

Previously, an itl (inter-token latency) wasn't being recorded if the "usage" field was present. This would often ignore the itl for the last token because the API returns the "usage" field along with the last token. The already present if statement (if data["choices"][0]["text"]:) should suffice to ignore responses that contain "usage" without a new token.
FIX #xxxx (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

To speed up the CI queue for #5905, I've cancelled the distributed tests for the latest CI run in this PR since they won't pass anyway until #5905 has been merged. Please merge main into your branch after that happens so that the CI can pass once again.


Uncaught TypeError: (0 , _whatwgFetch2.default) is not a function

import fetch from 'whatwg-fetch'

store.fetchItems = (api) => {
  return fetch(api, {
    method: 'GET',
    headers: {
      'Content-Type': 'application/json;charset=UTF-8'
    },
    mode: 'no-cors'
  }).then(res => {
    if (res.status >= 200 && res.status < 300) {
      return Promise.resolve(res)
    } else {
      return Promise.reject(new Error(res.statusText))
    }
  }).then(res => {
    return res.json()
  }).then(data => {
    return data
  }).catch(err => {
    console.log(err)
  })
}

Some error occurs in browser under Babel6:
Uncaught TypeError: (0 , _whatwgFetch2.default) is not a function

I think this might be related to https://phabricator.babeljs.io/T2212.

did this get solved?

+1 have the same issue

It worked for me also

Is it the same case with import fetch from 'isomorphic-fetch'
Do I have to just include : import 'isomorphic-fetch' instead

@tessact Yes and no. Their docs don't assign a variable to it, but many examples online show that it does. I ended up assigning a variable to it - much nicer imo.


Sort meeting entries by module code

This issue is obsolete as we have decided to remove the feature.


Fix deploy branches config

Add lambda function to trigger and pass valid source reference to entrypoint.

@pziemkowski Could you take a look at PR again?


MediaElement Cursor End Position

Hi !
I noticed that with MediaElement,
the Cursor End Position is not always accurate : it is often a bit behind the end of the waveform.

I checked end cursor position:
wavesurfer.on('finish', function () {
  var position = wavesurfer.getCurrentTime();
  console.log(position);
});

12.094486 // MediaElement
12.082729166666667 // WebAudio

Here is a codepen demo.
If this is not a bug but API limitations, maybe a function to set the cursor at end of canva if MediaElement backend could be added in wavesurfer-js ?
Thanks for your support !

@katspaugh i've been seeing this for years,never figured it out..

@thijstriemstra thanks for your confirmation, I thought I was the only one with the issue !

Im not only seeing this with media element back end.

@X-Raym @thijstriemstra
When I check the buffer duration value for WebAudio and MediaElement in console they are the same. Might be a bug with wavesurfer.getCurrentTime() when using MediaElement as it doesn't update the return value in time.
I fixed it in the following way, but it's in the finish event.
  console.log(wavesurfer.backend.params.backend);
  if(wavesurfer.backend.params.backend=='MediaElement'){
    console.log(wavesurfer.backend.buffer.duration);
    var position = wavesurfer.backend.buffer.duration;
  } else{
    var position = wavesurfer.getCurrentTime();
  }
  console.log(position);

@thijstriemstra my solution was to ad this at finish event:
wavesurfer.on('finish', function () {
var position = wavesurfer.getCurrentTime();
wavesurfer.seekTo(wavesurfer.getDuration()); // Go to end. There is a small jump.
});
But there is a small jump when we do that.
I wonder if a better solution could be found, and if this solution could be included right in wavesurfer.js, especially if all people using MediaElement backend get this issue.
MediaElement backend allow to seek the audio file even if it is not fully downloaded so it is quite useful.

@X-Raym It will check if MediaElement is used and use backend.buffer.duration property.
Needs some more testing before updating the mediaelement.js getDuration() function.
   getDuration: function () {
        var duration = this.media.duration; // this might have to be changed to this.buffer.duration instead to avoid jumping when using wavesurfer.seekTo(wavesurfer.getDuration())
        if (duration >= Infinity) { // streaming audio
            duration = this.media.seekable.end(0);
        }
        return duration;
    },

Here is the code for the manual fix:
http://codepen.io/entonbiba/pen/apVaJM

@entonbiba this can do the trick, I suppose !

#941 pull request

I've seen it with various wavefiles in this videojs-wavesurfer demo but can't seem to reproduce it now.

This has been fixed in the latest version. #941

@entonbiba Oh sorry, I missed your answer !
I wanted to thank you for the fix :)

@X-Raym  :)

@entonbiba Hi !
I just tested this fix in version v2.0 beta 2, and despite the fact I get the same audio duration, the cursor positon is still not good.

Do you confirm ?
Should I open another ticket ?

Thanks for your support!

Disclaimer: I have never looked into this issue.
It sounds as though it could be caused by floating points being inexact.
See

https://stackoverflow.com/questions/1458633/how-to-deal-with-floating-point-number-precision-in-javascript
https://en.wikipedia.org/wiki/Floating-point_arithmetic#Accuracy_problems

@mspae
hi ! thanks for taking a look !
IMHO it is not related to floating point precision, as the offset is pretty large compared to the rounding decimal value.
I think there is something else going on there... just like we had problem with media element length detection.

@mspae I just noticed that indeed, the MediaElement audio duration seems truncated , and we can see it right on my screenshot (I missed it somehow). The difference is so small (you have to go the the seventh decimal), I wonder if it has an effect. But there should be a way to make it works seamlessly.
Maybe should I open a new issue for this ?

@mspae Hi !
I just find the problem only occurs with wav file.
I open a new issue at it seems not directly related to this one:
https://github.com/katspaugh/wavesurfer.js/issues/1223


InjectionX.app Not work

Error loading /Applications/InjectionX.app/Contents/Resources/iOSInjection.bundle/iOSInjection:  dlopen(/Applications/InjectionX.app/Contents/Resources/iOSInjection.bundle/iOSInjection, 265): Symbol not found: _$SBOWV
Referenced from: /Applications/InjectionX.app/Contents/Resources/iOSInjection.bundle/iOSInjection
Expected in: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphonesimulator/libswiftCore.dylib
in /Applications/InjectionX.app/Contents/Resources/iOSInjection.bundle/iOSInjection

Xcode   Version 10.1 (10B61)

Hi, for Xcode 10.1 you need to load /Applications/InjectionX.app/Contents/Resources/iOSInjection10.bundle

This is a pit dug by myself.   I installed two versions of Xcode and changed the name, which means the path has changed, so I can't link it.
xcode-select -print-path
/Applications/Xcode10.1.app/Contents/Developer

I am now back. rename Xcode 10.1.app => Xcode.app ,then
sudo xcode-select -switch  /Applications/Xcode.app/Contents/Developer

The world is getting better~  Still the previous code can run
#if DEBUG
    //UI hot reload
    [[NSBundle<EMAIL_ADDRESS>load];
#endif

Where are you getting InjectionX.app from? The supported version is InjectionIII in the mac App Store.

The souce from network ，link for https://www.jianshu.com/p/a049fa394575

That is a very old version and not the primary source. Please use InjrectionIII from the Mac App Store. It's free.

OK ! I really appreciate the open source spirit of the author~ I will change the latest one immediately.


Allow configuration for showed builds in developement tab in Jira

Hi,
How can I configure which build(s) to be shown on the development -> Builds tab. See screenshot below, I would like for instance to only show the Pull-Request Run Dev result and not display the others (from the Github Actions section).
if this is not possible, do you plan on adding such feature?

Hm, I think we're going to need more information about your Github branching/PR/build structure first before we can try to assess the problem with how many builds you have in Jira.

The thing is that every workflow that is ran (being a build or not) is stated as a built in this window.
E.g. Is PR Approved by QA is has its own file (is_approved_by_qa.yml), but does not produce a build.
So every workflow appears in the windows, but I would like to select which one to show.
If you need more information, please be specific.
Thanks!

Ah right, that makes sense.  We'll have to figure out a way of doing this at scale as it wouldn't be efficient to have filters at the top level as it would change per repository I'd imagine.  I wonder if there's a way to add metadata to the workflow file so that our app can ignore it...
We'll have to revisit this again after we do the ownership migration done and dusted.  Thanks for the idea :)

Hi @jcdan3. I believe this feature will help with the issue you are having: https://github.com/atlassian/github-for-jira/issues/1303#issuecomment-1226715001

Hey @jcdan3. As we haven't heard from you almost 2 months, I'm going to go ahead and close this issue. Please feel free to reopen if you require further assistance.


fix example project

The included example project doesn't work on >=Django 1.6 as manage.py is changed.
This PR fixes it.

Thanks - the example project had fallen a little behind, it's been a while since we've run it. We'll get this merged soon.


Add MI Copilot page

Purpose
This PR is to add information on MI Copiolt to the documentation.
Issue reference: https://github.com/wso2/docs-mi/issues/1141

A screen capture of the new page is attached below:
mi-copilot.pdf


User stream timeout

Binance has been experiencing issues with the user data stream over the last few days (as acknowledged in their telegram), sometimes it has been completely down, but other times it just requires getting a new key, being able to adjust the value of user_timeout would be useful for this.

Have included your pull request in v0.7.0, thanks!


[Porting Examples] Add Load JSON File Example

This is a p5.js port of Daniel Shiffman's example on this page:
It's not a 1:1 port, but I aimed to captured most of the spirit of the original example.
Primary differences include

Making use of preload function
Not supporting "saving" since data is loaded from the server, but can't be persisted back to the server
Not using functions which have awareness of datatypes since Javascript is dynamically typed

I would have liked to use some ES6 features to simplify the looping, but stuck with familiar for-loops to maintain consistency with the other examples I saw in the project.
This is my first contribution to p5.js-website, so please let me know if there's anything else I need to do to prepare this PR appropriately. I wasn't sure about whether the dist/ files should be committed into the repository, so I keep them in a separate commit for convenience.
cc @lmccart

Hi @lmccart, sure thing!
I amended my original commit to add the data loading JSON file to the es and zh-Hans folders too :). The second commit added many changes to the dist/ folder, but I kept them in a separate commit.
Let me know if you'd like to see anything else!

@hydrosquall I'm not sure why so many files got changed. could you try only submitting the PR with the files you modified? thanks

@lmccart sure, I just removed my second commit (the one with the results of running grunt serve), which drops all the changes to the dist/ folder. This should be easier to work with.

@lmccart Did the automatic translation tracking script not work on commit? I see the src/data/en.yml has changes here but the tracking file is not updated?

@limzykenneth hmm it seems that it not..
I ran:
grunt server
git add -u
git add dist/*
git commit -m '...'
git push origin master
`


If any room member delete a room, how to notify other members that particular room has been deleted. I didn't find any listener for this

Require solution other then Push notification.

What do you mean by delete a room?
A room member can only leave a room. This room will be still available for others.

@manuroe I have created a room with 2 people. 1 person leave the room then why it's hide from otherside


Updated contract of ContractDefinitionStore.delete to return the deleted ContractDefinition.

Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Checklist

[ ] formatted title correctly? (take a look at the CONTRIBUTING
and styleguide
for details)
[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] added relevant details to the changelog? (skip with label no-changelog)
[ ] linked GitHub project? (see the section on the right-hand side -->)

Codecov Report

Merging #151 (0d5c0cc) into feature/801/135-add-delete-by-id-in-assetloader (c298321) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@                                Coverage Diff                                 @@
##             feature/801/135-add-delete-by-id-in-assetloader     #151   +/-   ##
==================================================================================
  Coverage                                              59.86%   59.86%
  Complexity                                              2245     2245
==================================================================================
  Files                                                    603      603
  Lines                                                  13041    13040    -1
  Branches                                                 906      907    +1
==================================================================================
  Hits                                                    7807     7807
+ Misses                                                  4809     4808    -1
  Partials                                                 425      425

Impacted Files
Coverage Δ

...efinition/store/CosmosContractDefinitionStore.java
89.65% <50.00%> (-1.73%)
:arrow_down:

.../store/memory/InMemoryContractDefinitionStore.java
86.95% <100.00%> (-0.55%)
:arrow_down:

...mo/protocols/common/AbstractQueuedProvisioner.java
88.88% <0.00%> (+5.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c298321...0d5c0cc. Read the comment docs.


Could you please share the data generation code in the paper?

Hello, you have proposed a very meaningful data set and its generation method. I work in AI for biological science, and it is very inspiring to me. Could you please share the data generation code in the paper? Thank you

Thank you for your interest in our work!
Due to a lot of things going on lately, I'm sorry that we haven't organized the code yet, but the implemented algorithms have been provided as pseudo-code in the paper, which you can refer to.