subscription support

It looks like this library in its current form doesn't support GraphQL subscriptions. Is that correct? I'm wanting to implement some new websocket-based functionality in one of my vapor/graphql apps, and I'm trying to get a feel for how much work it would be to keep it purely graphql, or whether I should just build this feature outside of graphql for now.  I know the Graphiti library has some support for subscriptions, by subclassing EventStream from the core GraphQL library.
have you thought about this at all, or do you have any plans on implementing this? or thoughts on how it would be accomplished?  if the path forward seemed not to crazy, i thought maybe i could possibly try an initial implementation, if it was something you were interested in adding support for, or could possibly give me a pointer or two how you'd like to see it implemented in the context of this library.

@NeedleInAJayStack really appreciate you taking the time to chime in. 🙏
So, is there a single, shared, singleton-like publisher for your whole app that publishes when something happens (via the SQL trigger)?  Do you then end up basically filtering over the single publisher and emitting events interesting to given web-socket clients based on what they subscribed to?
Or am I misunderstanding, and does each client websocket connection get its own un-shared publisher based on the subscription?
I don't suppose there's any chance your app is open source somewhere where I could poke around the code a bit?  If not, would you mind copy/pasting a few lines of the relevant code for each step you mentioned above?
Thanks again!

No problem!

So, is there a single, shared, singleton-like publisher for your whole app

No, we create a fresh PublishSubject in each GraphQL subscription resolver. This is because we want to create and setup SQL triggers based only on what clients have asked for, and then just wrap their callbacks with RxSwift. Yea, the GraphQLRxSwift tests are a little confusing in this case because we create a global PublishSubject because need to have an external handle to cause an event.

Or am I misunderstanding, and does each client websocket connection get its own un-shared publisher based on the subscription?

Yes, this is what we do.

I don't suppose there's any chance your app is open source

Unfortunately it's closed source. The Graphiti GraphQLRxSwift tests are pretty close to what we are doing though, except that in the subscribe resolver we create the PublishSubject, activate a SQL trigger and then in the trigger event callback we call PublishSubject.onNext. It's probably worth noting that we aren't using Fluent and I don't know much about their SQL triggering mechanism.
Hope that helps!

Thanks a lot @NeedleInAJayStack, that helps a lot.


Add Search History for ZoLa

This, along with #1199, completes #1191

In the interest of maintaining this code as reusable components not coupled to any particular app, I'd really like to avoid having a Zola-specific component. Is there anything about how Zola uses the component that would cause the new functionality to break in other apps? And even if that is the case, we can make these changes to the existing labs-search component, release a new version of the addon to npm, and only update Zola to that version.

@dhochbaum-dcp In the interest of maintaining this code as reusable components not coupled to any particular app, I'd really like to avoid having a Zola-specific component. Is there anything about how Zola uses the component that would cause the new functionality to break in other apps? And even if that is the case, we can make these changes to the existing labs-search component, release a new version of the addon to npm, and only update Zola to that version.

I don't think there's inherently anything that would break in other apps, but I don't know which of our other apps it's used in, and whether we'd want to have Search History automatically enabled in them.  It's also open source, so who knows who else is using it...what I'm going to do is close this PR, and open a new PR which makes the changes to the existing labs-search component, with Search History functionality turned off by default.  Then I'll open a new PR for ZoLa which uses the labs-search component with @useSearchHistory={{true}} added.


SuggestionsPopover Error

Hi, there is a error on line 438 (ui5 version 1.71):
endBbutton -> endButton
https://github.com/SAP/openui5/blob/80a7a43484a9ea7777a08bcda64daaf677f3102b/src/sap.m/src/sap/m/SuggestionsPopover.js#L438
It causes this error in console:

Thanks!

Hello @CarlosOrozco88
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here.
Regards,
Georgi

Hi @CarlosOrozco88
The issue is fixed with the referenced commit. The fix will be available with the next patch release of v1.71.
Thanks for reporting!


Bundles nested components should be query-able

Bevy version
0.12
What you did
I'm writing an orthographic camera. I want to change the orthographic perspective scale. Since Camera3dBundle has a projection component, and that projection enum component holds an OrthographicProjection component I was expecting to be able to query it.
What went wrong
I expected
mut q_camera: Query<(&mut Transform, &mut OrthographicProjection), With<Camera3d>>,

to give me an OrthographicProjection component - it crashed instead.
mut q_camera: Query<(&mut Transform, &mut Projection), With<Camera3d>>,

Just getting the projection and doing a match works okay but doesn't look great.

Perhaps you could do this?
#[derive(Component, ...)
pub struct YourOrthographicCameraMarker;

mut q_camera: Query<(&mut Transform, &mut OrthographicProjection), With<YourOrthographicCameraMarker>>

With your proposal, how would the query distinguish between the OrthographicProjection nested in a Projection enum, and an actual OrthographicProjection directly present on the entity or nested in another enum?

Agreed, I don't think this is possible, or desirable if it is possible. Automatically tunneling down to the fields of components seems like it would badly complicate both the internals and the mental models for users.


korean translate continue...

parent = 부모
but korean manner is [Top people]+님[:nim]
so, 부모님=부모(parent)+님[:nim]

Good job :+1:


What is the solution to this problem

runtime\python.exe trainset_preprocess_pipeline_print.py C:\Users\ABOTRIKA 2022\Desktop\My Sound 40000 8 C:\Users\ABOTRIKA 2022\Desktop\Voice Clone\RVC-beta0717/logs/mi-test False
Traceback (most recent call last):
File "C:\Users\ABOTRIKA 2022\Desktop\Voice Clone\RVC-beta0717\trainset_preprocess_pipeline_print.py", line 8, in
sr = int(sys.argv[2])
ValueError: invalid literal for int() with base 10: '2022\Desktop\My'

The error is caused by spaces in the file path, file paths are not allowed to have spaces and special characters other than "-" and "_".

Now RVC supports paths containing space now. You can try updating RVC codes from github.


Again: go get fails for v2 with libusb v1.0.24

Debian 11
go version go1.17.5 linux/amd64
root@localhost:~# apt-get install -y libusb-dev libusb-1.0-0-dev && go get github.com/gotmc/libusb/v2
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
libusb-dev is already the newest version (2:0.1.12-32).
libusb-1.0-0-dev is already the newest version (2:1.0.24-3).
0 upgraded, 0 newly installed, 0 to remove and 1 not upgraded.
# github.com/gotmc/libusb/v2
go/pkg/mod/github.com/gotmc/libusb/v2@v2.1.0/hotplug.go:87:26: cannot use event (type _Ctype_libusb_hotplug_event) as type _Ctype_int in assignment
go/pkg/mod/github.com/gotmc/libusb/v2@v2.1.0/miscellaneous.go:34:43: cannot use int32(err) (type int32) as type _Ctype_int in argument to _Cfunc_libusb_strerror

try
apt-get install -y libusb-dev libusb-1.0-0-dev && go get<EMAIL_ADDRESS>

try
apt-get install -y libusb-dev libusb-1.0-0-dev && go get<EMAIL_ADDRESS>

I confirm. No error.
Thanks a lot for the tip

It seems like v2.1.1 does not exist anymore:
$ go get<EMAIL_ADDRESS>go<EMAIL_ADDRESS>reading github.com/gotmc/libusb/go.mod at revision v2.1.1: unknown revision v2.1.1

Any idea how to fix this?

It seems like v2.1.1 does not exist anymore:
$ go get<EMAIL_ADDRESS>go<EMAIL_ADDRESS>reading github.com/gotmc/libusb/go.mod at revision v2.1.1: unknown revision v2.1.1

Any idea how to fix this?

you can edit the file miscellaneous.go line 35 - 38 like this:
- func StrError(err ErrorCode) string {
- 	return C.GoString(C.libusb_strerror(int32(err)))
- }

+ func StrError(err ErrorCode) string {
+ 	return C.GoString(C.libusb_strerror(C.int(int32(err))))
+ }

It maybe effective


Test caller and tidy up tests for fieldset component

Suggest walking through commits to review.
https://trello.com/c/RoAonsVP/1290-add-test-coverage-for-form-group-wrapper-to-components-that-use-it

Closing in favour of #934


Updated Kubespray entry

Description
Documentation fix - Kubespray is now supporting more than Google Cloud. Too many to list, easier to just say "with ansible" than list all providers (AWS, GCE, Azure, OpenStack, vSphere, Oracle Cloud Infrastructure (Experimental), or Baremetal).
No testing, etc done as this is purely updating an entry in a markdown file.
None required

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Deploy preview for calico ready!
Built with commit 3d5af2fcacbfaaaa8e3d54a9e564f445a21a97ea
https://deploy-preview-2189--calico.netlify.com

@sethmccombs LGTM - could you also make this change to the corresponding document in the master/ directory? New releases are cut from there, so by making the change there it won't get lost when Calico v3.3 comes out.

@caseydavenport Donezo


Bug Report: Switching to my Custom character Crashes the Game

Now, I already submitted an issue earlier, but this shouldn't be as difficult. I have my Character sprite sheet, Xml file, and code in the characters.hx file, but when i try to test it in the debug menu, my game crashes. I shall provide My Character sprites, icon grid code, and a screenshot of my char.hx

If there's any solution you can recommend, please let me know as soon as possible!

p sure this is a discussion

Oh sorry, I'll move this there


Check the org members if the repo is private

Fixes https://github.com/facebook/mention-bot/issues/104
If the PR is opened on a private repo, we do not want to mention users that are no longer part of that org
requiredOrgs does not work in this case unless every one publically lists that they are part of the org.
So now, if the PR is opened on a private repo
We get the list of all members of that org, and filter out any reviewers who do not appear on that list
Thanks :smile:

Thanks a lot for the high quality pull request!


Investigate some way of auto-importing meshes from Blender as SteamAudioGeometries

Godot supports import hints for turning meshes into colliders (see here). It could be interesting to have something like that but to mark meshes as steam-audio geometries.
(Relevant doc)

What is needed?

What’s described in the OP really. This sounded like an interesting idea but I confess I haven’t actually tried import hints myself yet.


Remove usage of deprecated mongo methods

Related to https://github.com/microsoft/vscode-cosmosdb/pull/1281#discussion_r366617499 and https://github.com/microsoft/vscode-cosmosdb/issues/1298, seems like we're using deprecated mongo methods in a few places. We should go through and fix all of those
A few examples: count, remove, insert

Also we're seeing this in the Mongo output window on activation:

the options [appName] is not supported
[Error - 11:15:02 AM] (node:81124) DeprecationWarning: current Server Discovery and Monitoring engine is deprecated, and will be removed in a future version. To use the new Server Discover and Monitoring engine, pass option { useUnifiedTopology: true } to the MongoClient constructor.

I think the options appName portion is related to a change I made for private endpoints.
https://github.com/microsoft/vscode-cosmosdb/pull/1262

I looked into preventing the output channel from popping up, but it's a little complicated because it's not our default output channel, it's an output channel handled by the "vscode-languageclient" module. There's an option "revealOutputChannelOn", but if I set it to "Never" that hides all errors and I'm not sure I'm ready to commit to that on short notice. Will move to the next milestone
Also - doesn't affect all users of the extension, just ones that have connected a Mongo db.


Fix global option parsing and phase thread error handling

Fixes #1135
Closes #1136 (alternative)
Also changes the phase exception handling to let other hosts finish before reporting exceptions to avoid leaving hosts in unexpected states.

The phases will now finish on other hosts before exceptions are raised.

Conflicts...


Add option for framerate

Please add option for setting framerate for getusermedia (camera).

We do support arbitrary constraints via URL params but I can see that it does not longer work for the new style of constraints.
Thanks for filing.

Any progress?

Sorry have not gotten around to it yet. You could use https://webrtc.github.io/samples/src/content/peerconnection/constraints/ for testing at least. Adding max in https://github.com/webrtc/samples/pull/821.

Closing due to age but URL parameters and getUserMedia constraints most likely need a general overhaul.


Fix example notebooks correcting tff.datetime periods

Updated to the example notebooks to match the new datetime periods.

Thank you for this! Could you please git squash your commits so I can merge it together?

Commits squashed. Thanks.

This is now merged. Thank you!


repos_collaborators: add an option for adding collaborators directly

To send an invitation to a collaborator rather than directly adding them, you must provide a custom media type in the Accept header:

https://developer.github.com/v3/repos/collaborators/#add-user-as-a-collaborator
Header is set for everytime. Its not possible to add a user to the repository as a collaborators without invitation. With this option we can add a user direclty.

Signed it

Hmm, I suspect that the ability to add people directly is going away (to be replaced with invitations that need to be accepted by user, to avoid abuse).
However, the GitHub docs don't say anything explicit about that, so this might be okay. Curious what others think about this.

Currently, its not possible without sending invitation to user when i want to add the user as a collaborator to the repository.
There is 2 document part about issue;
https://developer.github.com/changes/2016-06-14-repository-invitations/
https://developer.github.com/v3/repos/collaborators/#add-user-as-a-collaborator
Besides of it i will update comments to be more clear

So if I understand correctly, you are saying that when this API comes out of Preview period, there will be no way to add a collaborator without sending an invite?  That seems rather odd.  This will require more investigation and/or communication with GitHub Tech Support.

when this API comes out of Preview period, there will be no way to add a collaborator without sending an invite? That seems rather odd.

That seems expected to me. As I understand, the whole reason GitHub is moving towards sending invites that need to be accepted rather than outright adding people is to solve a spam problem. E.g., a spammer creates a repo they want many to see, and gives Linus Torvalds or someone with many followers push rights to it, and that repo shows up in the activity feed of everyone who follows Linus Torvalds.
Also, being made a collaborator creates responsibility, so sending an invite seems fair.
So it seems expected that once the API preview period is done, the old way of adding people as collaborators without their granted permission would no longer be possible.
Unless I'm missing something.

Ah, OK, then.  Since that is the direction that GitHub is moving, and our goal with this repo is to stay current as much as possible with all Preview APIs, then I think we do not want to introduce a change like this. Agree to close?

Agree to close.
Thanks @mehmetalisavas for contributing, but this is not a change we can merge.


The pivot key - atomic:image is not present in blockMap. (when add image)

Just have the example class seperated:
import React, {Component} from 'react';
import {
  Block,
  ImageSideButton,
  addNewBlockAt,
} from 'medium-draft';

import PropTypes from 'prop-types';

class CustomImageSideButton extends ImageSideButton {

  /*
  We will only check for first file and also whether
  it is an image or not.
  */
  onChange(e) {
    const file = e.target.files[0];
    if (file.type.indexOf('image/') === 0) {
      // This is a post request to server endpoint with image as `image`
      const formData = new FormData();
      formData.append('image', file);
      fetch('/upload', {
        method: 'POST',
        body: formData,
      }).then((response) => {
        if (response.status === 200) {
          // Assuming server responds with
          // `{ "url": "http://example-cdn.com/image.jpg"}`
          return response.json().then(data => {
            if (data) {
              this.props.setEditorState(addNewBlockAt(
                this.props.getEditorState(),
                Block.IMAGE, {
                  src: data.url,
                }
              ));
            }
          });
        }
      });
    }
    this.props.close();
  }
}

 CustomImageSideButton.propTypes = {
    setEditorState: React.PropTypes.func,
    getEditorState: React.PropTypes.func,
    close: React.PropTypes.func,
  };

export default CustomImageSideButton;

This is the full console error:
Uncaught (in promise) Error: The pivot key - atomic:image is not present in blockMap.
    at t.addNewBlockAt (bundle.js:29)
    at bundle.js:43
    at <anonymous>

Any help is appreciated :)

@Alexlander You are using wrong function addNewBlockAt instead of addNewBlock.
addNewBlockAt expects the key of the block after which the new block is added as the 2nd argument code here.

It works, thanks for the notice!


OCPP 1.5 compatibility

I would like to explore adding OCPP 1.5 compatibility to the library. Is it technically feasible and compatible with the library's intended design and architecture?

I haven't worked with OCPP 1.5. But from what I understand 0 is OCPP 1.5 subset of OCPP 1.6, so it should work.

I haven't worked with OCPP 1.5. But from what I understand 0 is OCPP 1.5 subset of OCPP 1.6, so it should work.

Thanks. We will give it a try!


[go1.20] tool doesn't recurse into sub-directories

Unsure why but with go1.20 the tool doesn't recurse into sub-directories anymore.
Script is invoked the following way
https://github.com/knative/eventing/blob/main/hack/update-reference-docs.sh
Output is
I0227 10:51:28.226464   96710 main.go:132] parsing go packages in directory knative.dev/eventing/pkg/apis
F0227 10:51:28.242770   96710 main.go:135] no loaded build package for knative.dev/eventing/pkg/apis
exit status 255

gengo - issue  - https://github.com/kubernetes/gengo/issues/241

Workaround is to place an empty go file into the empty directory so that there is always code


10m-pass.sh line 35: instagram-py: command not found

Please fix this

Please ensure that you have the latest version of python3 installed on your machine, if problem persists, please open a new issue and I'll look out at the script for the necessary changes, thanks for using.


77  api post endpoint

Coverage increased (+0.4%) to 97.163% when pulling 1727344ec4da07601e863fd5cdd34e8a4e924581 on 77__api_post_endpoint into 725791c72185aea201c564a2e2163a5167cd7640 on staging.

#77


enable gz compression + php-scoper

When gz-compression is enable the phar-file size will be reduced to just 632 KB instead of 3.24 MB.
It might not be a thing having a dependency on zlib as it is should be enabled/installed by default (on linux/unix).

👍


Static site dump is non-functional

I got the dump_site working and it's downloaded a copy of the site. But the static site is largely non-functional.
In Firefox and Safari the search function doesn't work at all, the date selection bar on the index doesn't do anything, and often when I click page numbers or the next or back buttons, nothing happens.

Did you encounter any errors while dumping the site? I've just tested locally, and the features you mentioned are all working for me.

Ah, it did throw:
"Stringifying...
There was an error: RangeError: Maximum call stack size exceeded
at JSON.stringify ()
at Object.storeCompressed (/Users/markgroeneveld/yahoo-groups-backup/yahoo_groups_backup/subcommands/LocalJSONP.js:89:22)
at /Users/markgroeneveld/yahoo-groups-backup/yahoo_groups_backup/subcommands/generate_search_index.js:57:23
Dumping group files...
Site is ready in 'dump'!
NOTE: Failed to render the following messages from the raw email
data. They may not have rendered properly."
Then listed a few hundred message numbers.

I haven't seen the Maximum call stack size exceeded error before. Sounds like one of the saved messages is malformed in such a way as to cause the JSON parser to get stuck in infinite recursion. Can you share the message if you can track down the culprit?
I have seen the "Failed to render" error before, and spot-checked those IDs in the dumped site. Each message I checked shows up fine in the dump, so I'm not sure what's up with that error.


LightGBM crashes kernel

Sometimes LightGBM crashes the jupyter notebook kernel when running in parallel. This needs a bit of investigation, but just using fewer cores seems to resolve that issue for now, so maybe that should be added to the FAQ / docs.

Hi Martin, we ran into trouble when using auto emulate on an apple M1 Mac, working on a conda environment. We fixed it by installing LightGBM via conda instead of pip (conda install lightgbm)


[netdata] issues when multiple BRs are configured the same prefixes (or routes) with different stable flag

Multiple BRs MAY be configured with the same prefixes (or routes) of different stable flags, different priorities etc. That is, in theory, one prefix may include both stable and unstable borderroutertlv, each of which may also include multiple borderrouterentries.
Current GetNextOnMeshPrefix() would always get the BRs in the first BorderRouterTlv of the Prefix.  Another impact  is onIsOnMeshPrefixConsistent()  evaluation and may cause repeating SRV_DATA.ntf. Similar impact on external routes.

With the change from https://github.com/openthread/openthread/pull/2073, the two methods GetNextOnMeshPrefix() and GetNextExternalRoute() should now iterate over all entries.

@abtink, I think #2073 could iterate all entries in the first BorderRouterTlv of one Prefix. However as stated above, one PrefixTlv may have two BorderRouterTlv (one stable, and one unstable).  Existing code does try to iterate the second BorderRouterTlv.

Ah, I see... Got it. Thank you.

PR: https://github.com/openthread/openthread/pull/2183


Update collection-index.yml with MATLAB Feature

What type of PR is this?

[X] Add a new dev container collection
[ ] Update to an existing dev container collection
[ ] Documentation/spec update
[ ] Other containers.dev site update (UX, layout, etc)

Description
Updates collection with link to MATLAB feature for DevContainer.
Collection checklist
If your PR contributes a new collection, please utilize this checklist:

[X] Collection name
[X] Maintainer name
[X] Maintainer contact link (i.e. link to a GitHub repo, email)
[X] Repository URL
[X] OCI Reference
[X] I acknowledge that this collection provides new functionality, distinct from the existing collections part of this index.

Hi @samruddhikhandale
Requesting your review.
Thank you!


Included notes field on instructor profile update form

Fixes https://github.com/swcarpentry/amy/issues/659

Thanks for your PR, @shubhsingh594. Unfortunately it's still missing "Notes" field on the form accessible by normal users (see https://github.com/swcarpentry/amy/pull/717#issuecomment-191087974). Please update accordingly.
Your change will break tests, so you'll have to fix them too.

@pbanaszkiewicz  hi,
i noticed that forms.ProfileUpdateRequestFormNoCaptcha , is using ' exclude ' instead of fields. so Notes should get included automatically . i also checked and i am able to use the notes textfield, by going to this url - http://<IP_ADDRESS>:8000/workshops/update_profile/

@shubhsingh594 I was wrong, you're right; the field appears where it should be.
Please wrap the field's contents with <pre> tag and I'll merge this.
Thanks & sorry!

Thanks a lot for your contribution, @shubhsingh594!


docs: Add docs for SAQ

Haven't had the opportunity to really test this. Do you know if context vars will restrict state to within individual asyncio tasks @JonasKs? If not, perhaps we would need to create a separate context variable where we register CIDs by task ID instead.

Seems to be the case. Will merge this for now and update if needed in the coming days.


[Android] notifee.getInitialNotification does not return pressAction

Hello, I have a lot of issues in Sentry, that pressAction is undefined.
But documentation and the InitialNotification interface inform that the pressAction field is required.
What can I provide and do to solve this problem?

I only got one reproduction, after ~50 tests I got the following data:
{
  "notification": {
     ....
    "data": {
      ...
    },
    "android": {
      ...
      "pressAction": {
        "id": "...",
        "mainComponent": "..."
      },
      ...
    }
  }
}


Add ReadMe tip for speeding up unit tests

OS?
Windows 10
Version
v1.0.0-beta.20-1
Repro steps

Run ng test with chrome in focus.

Run ng test with chrome minimized.

Test run time can differ by more than an order of magnitude.

Other details that might be useful
I was running ~200 tests (30 of them were component tests). Execution time was either ~0.7s or ~20s and the test runner would eventually crash. Turns out the slow and unstable tests were a result of chrome being out of focus. Chrome windows that are out of focus get throttled.
Looking through the rebuild speed thread, #1980, I noticed some complaints about ng test test speed. Specifically this comment. I'd like to suggest including a tip in ReadMe to keep chrome in focus. Since this is quite a hard to diagnose issue I think it will be very helpful.

The problem with ng test in that thread was mostly fixed by https://github.com/angular/angular-cli/pull/2840, because at the time code coverage was always being added.
A comment like this would be nice, even though there isn't anything else we can do. Would you be interested in adding it?

no blueprint update after https://github.com/angular/angular/pull/16250/files ? @filipesilva

Newer karma-chrome-launcher versions fix this automatically.


Add support for creating configmap directly from file

example
./prombench gke configmap apply -a $AUTH_FILE --name=grafana-provision --namespace=default -f dashboard.json -f datasource.json -v PROJECT_ID:$PROJECT_ID -v ZONE:$ZONE -v CLUSTER_NAME:$CLUSTER_NAME

why do we need this? Can't we use the existing deployment commands?

This is an enhancement and can help with creating configmaps with contents which have conflicting syntax with go templates.
Actual format
"legendFormat": "{{ node }} - Cached",

v/s the escaping that we're using currently:
https://github.com/prometheus/prombench/blob/ce7de2f047789896e1715826d3d8a051b786d8ec/manifests/cluster-infra/grafana_dashboard_prow_bench.yaml#L120

This does not support using DeploymentVars though. mostly can be used for static config files.

lets revisit as if we add to many ways to do same thing it will get confusing very quickly.

okay, just for a reminder for later:
This will help in updating the configmap directly when the file is updated using on:push on branch:master of prometheus/prombench (prombench itself will use github actions for this)
secondly, it will be good but not mandatory to have these config files in a separate configs directory.


torch.sparse.mm breaking API changes

Suddenly, everything stopped working 😱 presumably because of the changes to torch.sparse.
Particularly, I am on PyTorch 1.10, master branch of PyKEEN and torch-ppr 0.0.5.
Problem 1: the allclose() check does not pass now:
https://github.com/mberr/torch-ppr/blob/921898f1a4b7770e6cdd1931e935262e456eb3c9/src/torch_ppr/utils.py#L221-L222
MWE:
import torch
from torch_ppr import page_rank

from pykeen.datasets import FB15k237

dataset = FB15k237(create_inverse_triples=False)
edges = dataset.training.mapped_triples[:, [0, 2]].t()
pr = page_rank(edge_index=torch.cat([edges, edges.flip(0)], dim=-1), num_nodes=dataset.num_entities)

>> ValueError: Invalid column sum: tensor([1.0000, 1.0000, 1.0000,  ..., 1.0000, 1.0000, 1.0000]). expected 1.0

Looking into the debugger:

adj_sum does sum up to the number of nodes
the default tolerance fails the check, but if I reduce rtol=1e-4 or atol=1e-4 - the check passes

Problem 2: the signature of torch.sparse.addmm has changed from the one used in power_iteration so the API call fails with the unknown kwarg error.
https://github.com/mberr/torch-ppr/blob/921898f1a4b7770e6cdd1931e935262e456eb3c9/src/torch_ppr/utils.py#L310
In fact, I can't find where those kwargs input, sparse, dense come from because the current signature has less readable mat, mat1, mat2. I traced to the very Torch 1.3.0 and still can't find where those originated from. Where does this signature come from? 😅
My test env
torch                 1.10.0
torch-ppr             0.0.5

On the current master and with
torch              1.11.0+cu113

the code runs through - though even there, the signature seems to be mat, mat1, mat2 :sweat_smile:

yes, cf. https://tox.wiki/en/latest/config.html#generating-environments

okay up to you

@migalkin , for the first problem: If you do not provide a starting value yourself, it will initialize to
https://github.com/mberr/torch-ppr/blob/921898f1a4b7770e6cdd1931e935262e456eb3c9/src/torch_ppr/utils.py#L260
which should sum up to 1. So I guess this is a numerical problem here.

I played around with it, and the the error seemed to occur when there is large number of non-zero entries in one column. This is intuitive, since the more values we sum, the more error can accumulate.


update android support library to androidx

Summary

Test Plan

What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility

OS
Implemented

iOS
✅❌

Android
✅❌

Checklist

[ ] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

any update?

any update ?

How do we get this merged?

https://github.com/react-native-community/react-native-blur/pull/321 already merged


[runwhen-local-feedback] Bug: Developers can't list namespaces in OpenShift

Observation
Tested on OKD 4.13, OpenShift 4.12.3 (CodeReadyContainers).
As a cluster admin there were no issues in either environment.
As a developer with access to only a few namespaces I ran into RBAC issues because OpenShift prefers projects instead of namespaces by default. The standard user / developer RBAC does not include permissions to list namespaces resulting in a fatal exception. (OpenShift creates an identical Project when a Namespace is created and vice-versa)
Note: Make sure the developer context is not in the kubeconfig or generation will fail with an exception.
Internal Server Error: /run/
Traceback (most recent call last):
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
    return view_func(*args, **kwargs)
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/django/views/generic/base.py", line 70, in view
    return self.dispatch(request, *args, **kwargs)
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/rest_framework/views.py", line 509, in dispatch
    response = self.handle_exception(exc)
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/rest_framework/views.py", line 469, in handle_exception
    self.raise_uncaught_exception(exc)
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
    raise exc
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/rest_framework/views.py", line 506, in dispatch
    response = handler(request, *args, **kwargs)
  File "/workspace-builder/prodgraph/views.py", line 105, in post
    raise e
  File "/workspace-builder/prodgraph/views.py", line 98, in post
    component.run_func(context)
  File "/workspace-builder/indexers/kubeapi.py", line 113, in index
    ret = core_api_client.list_namespace()
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/kubernetes/client/api/core_v1_api.py", line 14721, in list_namespace
    return self.list_namespace_with_http_info(**kwargs)  # noqa: E501
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/kubernetes/client/api/core_v1_api.py", line 14828, in list_namespace_with_http_info
    return self.api_client.call_api(
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/kubernetes/client/api_client.py", line 348, in call_api
    return self.__call_api(resource_path, method,
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/kubernetes/client/api_client.py", line 180, in __call_api
    response_data = self.request(
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/kubernetes/client/api_client.py", line 373, in request
    return self.rest_client.GET(url,
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/kubernetes/client/rest.py", line 241, in GET
    return self.request("GET", url,
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/kubernetes/client/rest.py", line 235, in request
    raise ApiException(http_resp=r)
kubernetes.client.exceptions.ApiException: (403)
Reason: Forbidden
HTTP response headers: HTTPHeaderDict({'Audit-Id': '3b8d84a0-b522-47ed-bfdc-7a4d6324110a', 'Cache-Control': 'no-cache, private', 'Content-Type': 'application/json', 'Strict-Transport-Security': 'max-age=31536000; includeSubDomains; preload', 'X-Content-Type-Options': 'nosniff', 'X-Kubernetes-Pf-Flowschema-Uid': '19a3dc24-ba00-43cc-bd97-8679fcc8ca83', 'X-Kubernetes-Pf-Prioritylevel-Uid': '78b618f3-7def-4784-8cf4-75416a1bd9d0', 'Date': 'Thu, 01 Jun 2023 05:12:03 GMT', 'Content-Length': '264'})
HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"namespaces is forbidden: User \"developer\" cannot list resource \"namespaces\" in API group \"\" at the cluster scope","reason":"Forbidden","details":{"kind":"namespaces"},"code":403}

[01/Jun/2023 05:13:00] "POST /run/ HTTP/1.1" 500 145

Possible Suggestions
If running against OpenShift we should try listing projects if namespaces can't be listed.
  apiVersion: project.openshift.io/v1
  kind: Project
  metadata:
    annotations:
      openshift.io/sa.scc.mcs: s0:c26,c5
      openshift.io/sa.scc.supplemental-groups:<PHONE_NUMBER>/10000
      openshift.io/sa.scc.uid-range:<PHONE_NUMBER>/10000
    creationTimestamp: "2023-06-01T04:49:55Z"
    labels:
      kubernetes.io/metadata.name: test
      pod-security.kubernetes.io/audit: restricted
      pod-security.kubernetes.io/audit-version: v1.24
      pod-security.kubernetes.io/warn: restricted
      pod-security.kubernetes.io/warn-version: v1.24
    name: test
    resourceVersion: "57784"
    uid: ef083331-7581-4b50-8c0c-e3b80c810fcd
  spec:
    finalizers:
    - kubernetes
  status:
    phase: Active

This should now be resolved in this version (https://github.com/runwhen-contrib/runwhen-local/pkgs/container/runwhen-local/99624808?tag=main-6c8a27f0), tested against our demo ocp cluster with a standard developer view permissions to the default namespace with a simple app.


Should kicks contain a key for bridges to pass information to aware clients.

My use case is the classic err_needreggednick kick by the IRC bridge which leaves users confused as to what to do next.
We could provide detailed instructions in the response but then we are relying on your client to be similar to Riot when it could be something like a terminal client, or another bridge!
I'd like to propose that "reason" continues to be freeform text for client's to show as a fallback or user generated reason, but to also include another key (errcode?) for putting a code in (possibly something like org.matrix.irc.needreggednick) ?
I'm also listing bans in here although they are not used yet by the bridge.

Nice! I'm currently in the confused stage and I don't know what to do now :sweat_smile:, but indeed this would help.


Remove Spamcop from the list of Blacklists which should be queried.

Howto remove Spamcop from the list of blacklists which are used? Or how to add a sender domain to a never reject list?

[X] I would like to configure a not documented mail server use case

Description
I have the setup running for a while now. And some users often fails to send e-mails to my users (they are sending from t-online.de which is sometimes listed on Spamcop). So I want to remove Spamcop or set the sender domain @t-online.de to a whitelist. So that emails from this domain are not getting rejected (or get a negative SpamAssasin score to begin with, so that this e-mails are not getting marked as Spam so likely)
Thanks for your support in advance.

Take a look at: https://github.com/tomav/docker-mailserver/wiki/Override-Default-Postfix-Configuration
Try something like this in config/postfix-main.cf:
# 'reject_rbl_client bl.spamcop.net' removed
smtpd_recipient_restrictions = permit_sasl_authenticated, permit_mynetworks, reject_unauth_destination, check_policy_service unix:private/policyd-spf, reject_unauth_pipelining, reject_invalid_helo_hostname, reject_non_fqdn_helo_hostname, reject_unknown_recipient_domain, reject_rbl_client zen.spamhaus.org

This issue was closed due to one or more of the following reasons:

Age
Contributor inactivity
The issue seems to be resolved

If you think this happened by accident, or feel like this issue was not actually resolved, please feel free to re-open it. If there is an issue you could resolve in the meantime, please open a PR based on the current master branch so we can review it.

Take a look at: https://github.com/tomav/docker-mailserver/wiki/Override-Default-Postfix-Configuration
Try something like this in config/postfix-main.cf:
# 'reject_rbl_client bl.spamcop.net' removed
smtpd_recipient_restrictions = permit_sasl_authenticated, permit_mynetworks, reject_unauth_destination, check_policy_service unix:private/policyd-spf, reject_unauth_pipelining, reject_invalid_helo_hostname, reject_non_fqdn_helo_hostname, reject_unknown_recipient_domain, reject_rbl_client zen.spamhaus.org

Thats indeed the correct solution, thanks for the hint and sry for the really late response.


New Login Design

[x] SeverUrl Page
[ ] Login Page

Landscape Screen

Keyboard Up Screen

New ServerURL Screen

@borisyankov @timabbott @neerajwahi Is this all fine?

Found another open PR https://github.com/zulip/zulip-mobile/pull/511. Is this PR replace that one?

@saketkumar95 try to create even more focused PRs.
The more stuff they contain, the more discussions we need to have before merging them.
In this case, I have some concerns about the image, but we keep discussing the text and translations.

Hello @saketkumar95, a Zulip maintainer reviewed this pull request over a week ago, but you haven't updated your pull request since. Please take a look at the requested changes and update your pull request accordingly.
Thank you for your valuable contributions to Zulip!

@borisyankov I will open it when we get some nice design for the image. :)


Adding a database information pane to the connection side panel

This change updates the side panel to add a database information tree view. This new view lists the Labels and Relationships  of the active database.
I've opted to hook into our eventing flow.. since the db schema data is not populated deterministically when a connection is changed.. I've tried to keep this straightforward as possible.. by passing our events object from the schema poller to the metadata poller, and emitting a single schemaFetched event. The vscode extension listens to this event, and refreshes the database information pane. At which point the db schema data will be available on the schema poller reference.

 Add "Database Information" pane to connection panel


⚠ PrivateHD has degraded performance

In e4f7671, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2274 ms

Resolved: PrivateHD performance has improved in 430b302.


Delete the pp_var_utils library

Remove all source files from the "pp_var_utils" directory of the
"common/cpp" library, as all code has been migrated away from using it
(in favor of conversions to/from the toolchain-independent "Value"
type).
This is a pure refactoring commit that contributes to the
WebAssembly/Emscripten migration effort tracked by #185.

Minus 2K LOC - yay!
P.S. This should only be merged after #348 and #349.


Vulkan swapchain never resizes on Wayland

Wayland does not report the swapchain as out of date on resize. I think for Vulkan we should just watch the OnWindowResize event, mark the swapchain as needing to be recreated in the event handler, and then recreate on the next Acquire call. This would have the added benefit of not being behind one frame on resizes.

Fixed by #110


[SPARK-34548][SQL][FOLLOW-UP] Call toSeq to recover Scala 2.13 build in RemoveNoopUnion

What changes were proposed in this pull request?

Call toSeq to fix Scala 2.13 build error.
Why are the changes needed?

It is needed to fix 2.13 build error.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Existing tests.

cc @dongjoon-hyun @HyukjinKwon

The last GA test run in the previous PR failed? I didn't see that though.

Yeah, it did ... https://github.com/apache/spark/runs/2002190893 https://github.com/apache/spark/runs/2018276934

Scala 2.13 build passed .. let me merge this to make other builds pass.

+1, LGTM. Thanks!

Yea, didn't notice it. Sorry for that. Will re-check it next time.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135680/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40262/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40262/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40262/


scrape: remove unused member from cacheEntry

Signed-off-by: Bogdan Drutu<EMAIL_ADDRESS>

Thanks!


Support for VBox driver

This is a legacy driver for Oracle VirtualBox, x86_64 only.
It also has support for shared folders and hostonly networks,
but they are not implemented just yet (sshfs and nat only)
Deletion does not work properly, due to the VM "registry".

There is a fair deal of copy/paste, between pkg/vz/disk and pkg/vbox/disk
And there is some similar cleanup to do, between pkg/qemu and pkg/vbox...

To be moved to an external driver, once framework is available.


Error message: An item with the same key has already been added

Hi,
When trying to produces either word or mark down versions of a flow (attached) I get the following error:

This hapens with both the normal and self contained versions. I am using version 1.0.0.
testjjs_20221230144136.zip

Thanks for reporting this! Saw the same problem in another Flow a few days ago, but thanks to your attached Flow it's much easier to troubleshoot. Figured out what causes the problem, simply need to find some time to fix it properly

Sadly not yet included in the latest release (https://github.com/modery/PowerDocu/releases/tag/v-1.1.0). Tried to fix it, but was trickier than expected. High priority now

Rene,
Appreciate your getting back to me and your diligence.
From: Rene Modery @.>
Sent: Thursday, January 26, 2023 6:40 AM
To: modery/PowerDocu @.>
Cc: smithjj140990 @.>; Author @.>
Subject: Re: [modery/PowerDocu] Error message: An item with the same key has already been added (Issue #68)
Sadly not yet included in the latest release (https://github.com/modery/PowerDocu/releases/tag/v-1.1.0). Tried to fix it, but was trickier than expected. High priority now
—
Reply to this email directly, view it on GitHub https://github.com/modery/PowerDocu/issues/68#issuecomment-1404612640 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A5C6XGVESPY3MUHQURMFPT3WUIL2RANCNFSM6AAAAAATR3VQWE .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/A5C6XGT5TH7XJQRXQSEBYJLWUIL2RA5CNFSM6AAAAAATR3VQWGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSTXCYCA.gif Message ID: @.*** @.***> >

Good news! Think I may have finally fixed this problem. Still need to do a range of reviews (what else may need to be changed; anything that I "broke"?) and testing, but feels like a huge step forward.
This issue is the main task that I'm working on at the moment, as I realised that I made some coding and parsing errors, which resulted in some cases in the wrong output

Rene,Thank you for the update, and you diligence in getting it fixed.CheersJonathan Sent from my Galaxy
-------- Original message --------From: Rene Modery @.> Date: 10/02/2023  05:38  (GMT+00:00) To: modery/PowerDocu @.> Cc: smithjj140990 @.>, Author @.> Subject: Re: [modery/PowerDocu] Error message: An item with the same key has already been added (Issue #68)
Good news! Think I may have finally fixed this problem. Still need to do a range of reviews (what else may need to be changed; anything that I "broke"?) and testing, but feels like a huge step forward.
This issue is the main task that I'm working on at the moment, as I realised that I made some coding and parsing errors, which resulted in some cases in the wrong output
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Latest release is now available. Let me know if the problem still happens
https://github.com/modery/PowerDocu/releases/tag/v-1.2.1


Android Basics: ViewModel

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-viewmodel?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-3-pathway-3%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-viewmodel#6
In which task and step of the codelab can this issue be found?
This issue is first seen in task 7 step 6.  It can also be seen anywhere that the getNextWord() function is detailed
Describe the problem
The while loop of the getNextWord method uses a toString() on a character array.  This appears to return a string that contains the starting address of the CharArray.  I believe that the proper way to convert a CharArray to a String is to wrap the array in a String() function.
As it is written, the while loop will never be entered since the String and the address of the CharArray will never be equal.
Here is the original code:
/*
* Updates currentWord and currentScrambledWord with the next word.
*/
private fun getNextWord() {
    currentWord = allWordsList.random()
    val tempWord = currentWord.toCharArray()
    tempWord.shuffle()

    while (tempWord.toString().equals(currentWord, false)) {
        tempWord.shuffle()
    }
    if (wordsList.contains(currentWord)) {
        getNextWord()
    } else {
        _currentScrambledWord = String(tempWord)
        ++_currentWordCount
        wordsList.add(currentWord)
    }
}

Here is the modified code:
/*
* Updates currentWord and currentScrambledWord with the next word.
*/
private fun getNextWord() {
    currentWord = allWordsList.random()
    val tempWord = currentWord.toCharArray()
    // tempWord.shuffle()

    while (String(tempWord).equals(currentWord, false)) {
        tempWord.shuffle()
    }
    if (wordsList.contains(currentWord)) {
        getNextWord()
    } else {
        _currentScrambledWord = String(tempWord)
        ++_currentWordCount
        wordsList.add(currentWord)
    }
}

Steps to reproduce?

Comment out the first tempWord.shuffle().  This should force the while condition to be true on the first iteration
Put a log statement inside the while loop.
Run the app.  You will see that the words in the app are never shuffled and that the log message doesn't appear

Versions
Android Studio version: 4.1.2
API version of the emulator: 29
Additional information
Include screenshots if they would be useful in clarifying the problem.

Thank you so much for reporting this issue. This is fixed and will be published soon.


[core] Pin GitHub Action to digests

Same as https://github.com/mui/material-ui/pull/34855

It's strange, renovate didn't open a PR on Toolpad as it did in MUI X: https://github.com/mui/mui-x/pull/6739. It would fix the "Pinned-Dependencies" reports in https://github.com/mui/mui-toolpad/security/code-scanning.


为什么每天凌晨都会掉线啊？

为什么每天凌晨都会掉线啊？

Which puppet are you using?
If your answer is wechaty-puppet-padplus.
This problem is due to the update of protocal in WeChat, we are fixing this problem now. Thanks for your waiting.

oh ! I don't know which puppet I using。mabey it's puppetPuppeteer

it's

I have the same issue. Hope it could be solved soon.

FYI I am using "wechaty-puppet": "^0.16.1"

我用的web版本第一次登陆后凌晨会自动下线，不重启程序，再扫码登陆后可以保持几天在线，版本是
"wechaty": "^0.28.3"


Speaker Room for moderators and speakers to communicate logistically 'off screen'

Brought up in today's Streamyard tests -
A central place for moderators and speakers to communicate things like "hey I'm running late", "don't forget to unmute your microphone", et cetera. Probably a single room locked by permissions?
Blocked by being able to flag speakers specifically, #134 .

One question: I know Streamyard has a max of 10 people on-stream, but do we know if there's a limit to the number of people on the site but not actively streaming?
It's sub-par, but a non-code solution to this might be to just tell speakers "come to the Streamyard chat to talk to us"

Another no-code option is to create a Discord and invite everybody on speaker + staff.

Another option: tell them to use /mods on the MUD


Memory leaks

There seem to be major memory leaks somewhere between SCIP.jl, CSIP and SCIP.
See this gist for a script that realiably fills up all memory on my 4GB notebook and instantly freezes the system :-\
@fserra: do you want to debug this on saturday, and get lunch at Risa afterwards?

This applies to:
julia> versioninfo()
Julia Version 0.5.0
Commit 3c9d753 (2016-09-19 18:14 UTC)
Platform Info:
  System: Linux (x86_64-pc-linux-gnu)
  CPU: Intel(R) Core(TM) i5-3317U CPU @ 1.70GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Sandybridge)
  LAPACK: libopenblas64_
  LIBM: libopenlibm
  LLVM: libLLVM-3.7.1 (ORCJIT, ivybridge)

and SCIP.jl on master at ada08a5b.


Internal error on std::process::exit() with --exclude-files

Note that running without --exclude-files works fine.
$ cargo tarpaulin --exclude-files 'tests/**/*'
[INFO tarpaulin] Running Tarpaulin
[INFO tarpaulin] Building project
[INFO tarpaulin] Launching test
[INFO tarpaulin] running /home/joshua/src/rcc/target/debug/deps/stack_overflow-45c7b9c7d0a485f0

running 1 test
    Finished dev [unoptimized + debuginfo] target(s) in 0.06s
F
failures:

---- run_all stdout ----
testing tests/stack-overflow/decl.c
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', src/libcore/result.rs:1165:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

failures:
    run_all

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

Error: "Failed to get test coverage! Error: memory map must have a non-zero length"
[INFO tarpaulin] Launching test
[INFO tarpaulin] running /home/joshua/src/rcc/target/debug/deps/varargs-5b2bb8479dfc0b74
Error: "Tarpaulin experienced an internal error"

Err ... apparently this is unrelated to --exclude-files because running cargo clean just fixed the problem. Probably related to https://github.com/rust-lang/cargo/issues/7767, sorry for the noise.


XLA build error on macOS 10.12.4 Beta

NOTE: Only file GitHub issues for bugs and feature requests.  All other topics will be closed.
For general support from the community, see StackOverflow.
To make bugs and feature requests more easy to find and organize, we close issues that are deemed
out of scope for GitHub Issues and point people to StackOverflow.
For bugs or installation issues, please provide the following information.
The more information you provide, the more easily we will be able to offer
help and advice.
What related GitHub issues or StackOverflow threads have you found by searching the web for your problem?
Nothing seems to be related
Environment info
Operating System:
macOS 10.12.4 Beta
Installed version of CUDA and cuDNN:
(please attach the output of ls -l /path/to/cuda/lib/libcud*):
None
If installed from binary pip package, provide:

A link to the pip package you installed:
The output from python -c "import tensorflow; print(tensorflow.__version__)".

If installed from source, provide

The commit hash (git rev-parse HEAD): 4ac9c09d5ca57a03b8daa5fb9e295947b1619854
The output of bazel version:

Build label: 0.4.4-homebrew
Build target: bazel-out/local-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Thu Feb 2 01:05:15 2017<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

If possible, provide a minimal reproducible example (We usually don't have time to read hundreds of lines of your code)
Enable XLA at configuration and build with bazel build --config=opt
What other attempted solutions have you tried?
Building without XLA is working smoothly.
Logs or other output that would be helpful
(If logs are large, please upload as attachment or provide link).
ERROR: /Users/inflation/workspace/tensorflow/tensorflow/compiler/xla/service/BUILD:108:1: C++ compilation of rule '//tensorflow/compiler/xla/service:versioned_computation_handle' failed: cc_wrapper.sh failed: error executing command external/local_config_cc/cc_wrapper.sh -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -fcolor-diagnostics -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG ... (remaining 93 argument(s) skipped): com.google.devtools.build.lib.shell.BadExitStatusException: Process exited with status 1.
In file included from tensorflow/compiler/xla/service/versioned_computation_handle.cc:16:
./tensorflow/compiler/xla/service/versioned_computation_handle.h:33:19: error: unknown type name 'int64'; did you mean 'tensorflow::int64'?
  using Version = int64;
                  ^~~~~
                  tensorflow::int64
./tensorflow/core/platform/default/integral_types.h:27:19: note: 'tensorflow::int64' declared here
typedef long long int64;
                  ^
In file included from tensorflow/compiler/xla/service/versioned_computation_handle.cc:16:
./tensorflow/compiler/xla/service/versioned_computation_handle.h:38:3: error: unknown type name 'string'; did you mean 'std::string'?
  string ToString() const;
  ^~~~~~
  std::string
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:194:65: note: 'std::string' declared here
typedef basic_string<char, char_traits<char>, allocator<char> > string;
                                                                ^
tensorflow/compiler/xla/service/versioned_computation_handle.cc:22:1: error: unknown type name 'string'; did you mean 'std::string'?
string VersionedComputationHandle::ToString() const {
^~~~~~
std::string
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:194:65: note: 'std::string' declared here
typedef basic_string<char, char_traits<char>, allocator<char> > string;

I believe this was @meheffernan's bug.  Should be fixed in next uplift.
Sorry about the breakage.

 However, when I try to run a small program using XLA, I get an InvalidArgumentError that it can't find the specified device. It runs fine with a regular CPU, and XLA should be enabled according to my build specifications. I've posted here: https://github.com/tensorflow/tensorflow/issues/8141

I believe the relevant uplift has occurred.


v1.0.0

Motivation
Release

Changes Unknown when pulling de5292d2972148ce354cdf24100a9dac82c34df1 on release-1.0.0 into ** on master**.

Changes Unknown when pulling de5292d2972148ce354cdf24100a9dac82c34df1 on release-1.0.0 into ** on master**.


feat(management): users

Running the integration test auto-populates the user table with a service user, it currently UPSERTS a user per call to config:
postgres=# select * from users;
                  id                  | name |           display_name            | email | origin | deleted_at |          created_at           | updated_at
--------------------------------------+------+-----------------------------------+-------+--------+------------+-------------------------------+------------
 cf7903ea-433f-4316-a8b0-fc9718a3247b |      | service-account-iceberg-rest-test |       | config |            | 2024-09-17 11:59:30.048282+00 |
(1 row)

Closed in favor of https://github.com/hansetag/iceberg-catalog/pull/381


SOLR-16141 Upgrade Apache Tika to 1.28.4

https://issues.apache.org/jira/browse/SOLR-16141

I ran all tests, and the only failures I saw was unrelated. The modules/extraction tests all run fine. Will commit tomorrow if no objections, and backport to 9x


[WIP] Add warn_unused_result attribute to catch c++ errors.

Catch errors where get functions are called without using the result. For the selected functions, these will always be errors, and they can be hard to spot in code, so it may make sense to use this extension to flag them.
Introduction
As a result of a small discussion on twitter:
https://twitter.com/lawnjelly/status/1483789213049004033
A few of us discussed that a common bug in Godot is that many of the functions have slightly confusing names, and return values but do not change the underlying object.
For instance Vector3::round() returns a rounded Vector3 but does not round the called object.
Thus:
// This is valid
Vector3 test = myvec.round();

// This is a confusing bug
myvec.round();

Ideally an alternative would be a name like rounded() instead of round(), but given that losing backward compatibility is a bit of a potential problem, we wondered if we could instead flag the errors. There is a mechanism already in gdscript but I had a look for solutions in c++.
It turns out after some investigation that there is an extension in clang and GCC which can catch these errors.
Notes

This is just a first test go as proof of concept, alternating a few functions in Vector3.
If we agree to go ahead, it will probably be worthwhile fixing up all our main classes to support this method of error checking.
I'm conscious it would be nice to not make this too verbose. As such I've experimented here with having an alternative version of _FORCE_INLINE_ macro that also does error checking for unused return value, called _FORCE_INLINE_WR_.
Welcome suggestions on how to better do this. We could alternatively use a global warning if there is one that is appropriate (but it would have to be capable of not giving false flags - some functions you will want to ignore the return argument in some cases).

Ideally an alternative would be a name like rounded() instead of round(), but given that losing backward compatibility is a bit of a potential problem, we wondered if we could instead flag the errors.

I don't see how this is different from all the other things that have been changed without backwards compatibility. Does this have a bigger impact on engine/user code?

Ideally an alternative would be a name like rounded() instead of round(), but given that losing backward compatibility is a bit of a potential problem, we wondered if we could instead flag the errors.

I don't see how this is different from all the other things that have been changed without backwards compatibility. Does this have a bigger impact on engine/user code?

Renaming (for 4.0) is a good option. But the problem is that some of these methods are not easy to turn into a past participle, e.g. ceil (ceiled could work but probably going to confuse more than it helps) or abs (absed definitely doesn't work).

Also while renaming is an option for 4.x, bear in mind it isn't an option for 3.x (and while I've made the PR for 4.x the same problem applies in 3.x), so a warning like this or global warning is the best we can do there.

Although these are normally applied to each function individually, @akien-mga noticed they can be applied to whole classes - whenever the class is returned in a function it will emit the nodiscard warning in this case. This is much less verbose and enables us to catch errors in the main classes, at the cost of some possible false positives.

To clarify what this does for those not familiar (we had to look up some Reddit threads and do some local testing to figure it out):

[[nodiscard]] applied to a method will raise a warning when that method is used and the return value is discard. E.g.:

[[nodiscard]] int some_func() {
	return 42;
}

void main() {
	some_func();
}

[[nodiscard]] applied to a class/struct will raise a warning whenever a method returning an object of that class has its value discarded. E.g.:

class [[nodiscard]] SomeClass {
	SomeClass() {}
};

SomeClass some_func() {
	return SomeClass();
}

void main() {
	some_func();
}

This PR implements the latter for core math types, i.e. it's the same as if we added the [[nodiscard]] attribute to all functions in the codebase that return Vector2, Vector3, Transform3D, etc.
That doesn't apply to members functions of these core class which return a non-Godot type, e.g. int or real_t. These will still need a per-function attribute which will be added where relevant in a future PR. But it still covers a lot of cases and most importantly the cases discussed in the OP where there can be confusion between a method that returns a new object of that class or modifies the current object in-place.

I guess it's OK to remove return from the macOS _get_mouse_pos, and maybe rename it to _update_mouse_pos.
diff --git a/platform/osx/display_server_osx.mm b/platform/osx/display_server_osx.mm
index e3b4333ec8..a12f3b298d 100644
--- a/platform/osx/display_server_osx.mm
+++ b/platform/osx/display_server_osx.mm
@@ -72,14 +72,13 @@ static void _get_key_modifier_state(unsigned int p_osx_state, Ref<InputEventWith
 	r_state->set_meta_pressed((p_osx_state & NSEventModifierFlagCommand));
 }

-static Vector2i _get_mouse_pos(DisplayServerOSX::WindowData &p_wd, NSPoint p_locationInWindow) {
+static void _get_mouse_pos(DisplayServerOSX::WindowData &p_wd, NSPoint p_locationInWindow) {
 	const NSRect contentRect = [p_wd.window_view frame];
 	const float scale = DS_OSX->screen_get_max_scale();
 	p_wd.mouse_pos.x = p_locationInWindow.x * scale;
 	p_wd.mouse_pos.y = (contentRect.size.height - p_locationInWindow.y) * scale;
 	DS_OSX->last_mouse_pos = p_wd.mouse_pos;
 	Input::get_singleton()->set_mouse_position(p_wd.mouse_pos);
-	return p_wd.mouse_pos;
 }

 static void _push_to_key_event_buffer(const DisplayServerOSX::KeyEvent &p_event) {
@@ -668,12 +667,12 @@ static void _mouseDownEvent(DisplayServer::WindowID window_id, NSEvent *event, M
 	Ref<InputEventMouseButton> mb;
 	mb.instantiate();
 	mb->set_window_id(window_id);
-	const Vector2 pos = _get_mouse_pos(wd, [event locationInWindow]);
+	_get_mouse_pos(wd, [event locationInWindow]);
 	_get_key_modifier_state([event modifierFlags], mb);
 	mb->set_button_index(index);
 	mb->set_pressed(pressed);
-	mb->set_position(pos);
-	mb->set_global_position(pos);
+	mb->set_position(wd.mouse_pos);
+	mb->set_global_position(wd.mouse_pos);
 	mb->set_button_mask(DS_OSX->last_button_state);
 	if (index == MouseButton::LEFT && pressed) {
 		mb->set_double_click([event clickCount] == 2);
@@ -774,14 +773,14 @@ static void _mouseDownEvent(DisplayServer::WindowID window_id, NSEvent *event, M

 	mm->set_window_id(window_id);
 	mm->set_button_mask(DS_OSX->last_button_state);
-	const Vector2i pos = _get_mouse_pos(wd, mpos);
-	mm->set_position(pos);
+	_get_mouse_pos(wd, mpos);
+	mm->set_position(wd.mouse_pos);
 	mm->set_pressure([event pressure]);
 	if ([event subtype] == NSEventSubtypeTabletPoint) {
 		const NSPoint p = [event tilt];
 		mm->set_tilt(Vector2(p.x, p.y));
 	}
-	mm->set_global_position(pos);
+	mm->set_global_position(wd.mouse_pos);
 	mm->set_velocity(Input::get_singleton()->get_last_mouse_velocity());
 	const Vector2i relativeMotion = Vector2i(delta.x, delta.y) * DS_OSX->screen_get_max_scale();
 	mm->set_relative(relativeMotion);
@@ -861,7 +860,8 @@ static void _mouseDownEvent(DisplayServer::WindowID window_id, NSEvent *event, M
 	ev.instantiate();
 	ev->set_window_id(window_id);
 	_get_key_modifier_state([event modifierFlags], ev);
-	ev->set_position(_get_mouse_pos(wd, [event locationInWindow]));
+	_get_mouse_pos(wd, [event locationInWindow]);
+	ev->set_position(wd.mouse_pos);
 	ev->set_factor([event magnification] + 1.0);

 	Input::get_singleton()->parse_input_event(ev);
@@ -3364,8 +3364,8 @@ void DisplayServerOSX::process_events() {
 	for (Map<WindowID, WindowData>::Element *E = windows.front(); E; E = E->next()) {
 		WindowData &wd = E->get();
 		if (wd.mpath.size() > 0) {
-			const Vector2 mpos = _get_mouse_pos(wd, [wd.window_object mouseLocationOutsideOfEventStream]);
-			if (Geometry2D::is_point_in_polygon(mpos, wd.mpath)) {
+			_get_mouse_pos(wd, [wd.window_object mouseLocationOutsideOfEventStream]);
+			if (Geometry2D::is_point_in_polygon(wd.mouse_pos, wd.mpath)) {
 				if ([wd.window_object ignoresMouseEvents]) {
 					[wd.window_object setIgnoresMouseEvents:NO];
 				}

Another change to add to @bruvzg's diff:
diff --git a/platform/osx/display_server_osx.mm b/platform/osx/display_server_osx.mm
index e3b4333ec8..ba34d78c5c 100644
--- a/platform/osx/display_server_osx.mm
+++ b/platform/osx/display_server_osx.mm
@@ -317,7 +317,6 @@ static NSCursor *_cursorFromSelector(SEL selector, SEL fallback = nil) {
                CGWarpMouseCursorPosition(lMouseWarpPos);
        } else {
                _get_mouse_pos(wd, [wd.window_object mouseLocationOutsideOfEventStream]);
-               Input::get_singleton()->set_mouse_position(wd.mouse_pos);
        }

        DS_OSX->window_focused = true;

(That's already done by _get_mouse_pos.)

Thanks!


fix linux command deployment when running libcloud on windows

Fix right path composition suited for destination machine
Description
When running libcloud on Windows to deploy a linux machine in the cloud with a ScriptDeployment, it had always promted me an error which was like "stderr: bash: /home/googlelibcloud_deployment_b20d6e1e.sh: No such file or directory". So, the path was not right formatted. The error was in the os.path.join method, which produces a false path on windows like "/home/google\libcloud_deployment_b20d6e1e.sh". So I had to add the .replace("\","/") method to the os.path.join.
Status

done, ready for review

Checklist (tick everything that applies)

[x] Code linting (required, can be done after the PR checks)
[ ] Documentation
[ ] Tests
[ ] ICLA (required for bigger changes)

Closing due to inactivity. In case this issue is still relevant, feel free to re-open it.


Consider moving Unicode properties to separate library

I'm not sure how useful it would be outside of Backrefs to most people, but I know we also use it in Wcmatch.
In Wcmatch we tap into uniprops to enable [[:posix;]] character classes, but we don't actually generate backref regex for 2 reasons:

We expose regular expression translation so the user can covert fnmatch/glob patterns directly to Python compatible regular expressions. We don't want to have to add a disclaimer "Oh, and you have to use Backrefs".

Wcmatch already has to parse the pattern once, and then feed it to Re which has to parse the pattern once. I'd hate to add yet another level of indirection of pattern parsing.

So, would it be helpful to push Unicode property handling to a separate library? And if so, what would that look like?
Currently we store all the properties in strings that are ready to be injected into regular expressions. We could expose a simple API that allows you to test characters etc.  Maybe that would be helpful?
uniprops.is_property('block=basic latin', 'a')

As far as backrefs is concerned, it is pretty much feature complete. If anything, I imagine features will be removed as Python's RE implements things like Unicode properties. Moving Uniprops out will cause less churn here probably.
The real question is whether  it is worth it. Wcmatch works fine as it is, but just wondering if it would be useful to anyone else and expose this stuff as a library. Something to think about.

To make this a practical library, we'd probably want to provide the look up tables in C. That is if we wanted it to be a general purpose library. Again, not sure how motivated I am to do that, but that is probably the way to go for a general purpose library that performs well. If we had functions that compared characters as it is now, we'd have to compile regular expressions to then compare the character...
In the end, considering that both applications in which we are using it is to generate regular expressions, maybe the way we have it now is fine. Wcmatch can keep taking advantage of the undocumented interface behind the scenes and backrefs continues to be what is now, a wrapper to augment regular expression patterns to expose features such as Unicode  and casing in replace patterns.

I'm reopening this as I think it is unfortunate that wcmatch has to include this whole package, but doesn't actually use anything but the Unicode table work. We need the Unicode table work in wcmatch, but we honestly don't need everything else in backrefs.
We could certainly expose a function that returns the re compatible expression instead of compiling it directly to regex and have wcmatch use that to justify the inclusion of backrefs, but we would just be adding an additional preprocessor step for the sole purpose of justifying the inclusion of the package. I'd rather split out the Unicode work and use it directly to keep wcmatch from taking a performance hit. And it makes no sense to expose the Unicode API directly in this package. Backrefs is simply an alternative regex wrapper.
I don't want to duplicate the Unicode work just so wcmatch can use it, but I think it is weird and confusing to people to see this package get included in wcmatch, and yet nothing from the public API is used.
If we split out the Unicode work into a separate repo, even if the only packages to use it are wcmatch and backrefs, that can provide value for us. It doesn't so much matter whether people at large find the package attractive as long as things like wcmatch and/or backrefs is found useful and it makes our lives easier.
To be honest, out of backrefs and wcmatch, I'd venture that wcmatch is the more popular package. backrefs is probably only downloaded as much as it is because wcmatch gets downloaded. This doesn't bother me as I still find this package useful even if no one else uses it.

We don't really have to try and make the Unicode package attractive to others, just a reusable package that plugs into wcmatch and backrefs. We can basically keep the API the same and simply state it is a regular expression Unicode package, or in other words, a package that can provide character groups formatted for regular expression character groups.
re.compile(r'some pattern [' + uniprops.get_unicode_property('Letter') + ']')

It is not a concern to us whether people actually use this pacakge directly or not, frankly, this is what the uniprops code was built to do, and does it great for both backrefs and wcmatch. As long as it serves its intended purposes, I think it is worth it.

I'm reopening this as I think it is unfortunate that wcmatch has to include this whole package, but doesn't actually use anything but the Unicode table work. We need the Unicode table work in wcmatch, but we honestly don't need everything else in backrefs.
We could certainly expose a function that returns the re compatible expression instead of compiling it directly to regex and have wcmatch use that to justify the inclusion of backrefs, but we would just be adding an additional preprocessor step for the sole purpose of justifying the inclusion of the package. I'd rather split out the Unicode work and use it directly to keep wcmatch from taking a performance hit. And it makes no sense to expose the Unicode API directly in this package. Backrefs is simply an alternative regex wrapper.
I don't want to duplicate the Unicode work just so wcmatch can use it, but I think it is weird and confusing to people to see this package get included in wcmatch, and yet nothing from the public API is used.
If we split out the Unicode work into a separate repo, even if the only packages to use it are wcmatch and backrefs, that can provide value for us. It doesn't so much matter whether people at large find the package attractive as long as things like wcmatch and/or backrefs is found useful and it makes our lives easier.
To be honest, out of backrefs and wcmatch, I'd venture that wcmatch is the more popular package. backrefs is probably only downloaded as much as it is because wcmatch gets downloaded. This doesn't bother me as I still find this package useful even if no one else uses it.

We don't really have to try and make the Unicode package attractive to others, just a reusable package that plugs into wcmatch and backrefs. We can basically keep the API the same and simply state it is a regular expression Unicode package, or in other words, a package that can provide character groups formatted for regular expression character groups.
re.compile(r'some pattern [' + uniprops.get_unicode_property('Letter') + ']')

It is not a concern to us whether people actually use this pacakge directly or not, frankly, this is what the uniprops code was built to do, and does it great for both backrefs and wcmatch. As long as it serves its intended purposes, I think it is worth it.

Cleaned up Unicode properties and have it split out and working locally. Adding tests for aliases exposed a number alias related bugs, so glad we got that in now.
Next is just getting the package up on pypi. I May end up tweaking the API a little to have to clean things up a little, but it should mostly remain the same.

Cleaned up Unicode properties and have it split out and working locally. Adding tests for aliases exposed a number alias related bugs, so glad we got that in now.
Next is just getting the package up on pypi. I May end up tweaking the API a little to have to clean things up a little, but it should mostly remain the same.

#156 should close out this issue. We need to make sure wcmatch works with the new package and is separated from this one.

#156 should close out this issue. We need to make sure wcmatch works with the new package and is separated from this one.

Looks like everything is working in this package and wcmatch, so the separation with refactoring worked out great. And we discovered and fixed a number of bugs along the way.

Looks like everything is working in this package and wcmatch, so the separation with refactoring worked out great. And we discovered and fixed a number of bugs along the way.

Before we relase a new version, we are going to dramatically improve testing in the uniprops library. At this point, in backrefs, the only bugs we run into are with Unicode properties, and that is mainly because we are not testing extensively enough. Generating the tables is very complicated, and we sometimes miss subtle things. The most complicated part of this project was/is the Unicode tables. I imagine with those moved out into a separate package that there will be even less churn in backrefs.
Part of the problem is that we don't actually commit the tables, so it is hard to see the differences. We don't commit them because we genrate different tables to match the version of supported Unicode in the varios versions of Python that we support. We can generally do better by Generating a folder with the old results and then make changes and compare against the old results. This is something I'll be doing when moving forward.
Second, we just need to ensure we inspect new tables a bit closer. This is harder to simply catch with tests. If you are generating the table from the Unicode text files, and your assumption is you've parsed them correctly, then your tests will be built with that understanding. The Vertical Orientation bug was an example of this, we should have visually inspected the table data points closer before releasing instead of just making sure it got populated.
Testing wise, we need to dot the following as these were unexpected bugs that shouldn't have happened:

Test that all name and value combinations resolve through the API.
Testing that all aliases resolve through the API.
Test that all keys are cased properly in the structures.
All structures in our Unicode tables are also present in the ASCII tables.

There is so much generated that it is hard to spot check everything, but these can easily be automated and ensure general integrity.
Bugs are part of programming, and parsing Unicode tables can be harder than it has to be sometimes due to how the data is presented at times, so I'm sure occasionally some issues will slip in, but I'd like to ensure moving forward that the dumbest bugs are stammpped out completely. I'd love to be able to focus on just updating the Unicode tables for new Unicode versions instead of fixing old generation 🙂.

Before we relase a new version, we are going to dramatically improve testing in the uniprops library. At this point, in backrefs, the only bugs we run into are with Unicode properties, and that is mainly because we are not testing extensively enough. Generating the tables is very complicated, and we sometimes miss subtle things. The most complicated part of this project was/is the Unicode tables. I imagine with those moved out into a separate package that there will be even less churn in backrefs.
Part of the problem is that we don't actually commit the tables, so it is hard to see the differences. We don't commit them because we genrate different tables to match the version of supported Unicode in the varios versions of Python that we support. We can generally do better by Generating a folder with the old results and then make changes and compare against the old results. This is something I'll be doing when moving forward.
Second, we just need to ensure we inspect new tables a bit closer. This is harder to simply catch with tests. If you are generating the table from the Unicode text files, and your assumption is you've parsed them correctly, then your tests will be built with that understanding. The Vertical Orientation bug was an example of this, we should have visually inspected the table data points closer before releasing instead of just making sure it got populated.
Testing wise, we need to dot the following as these were unexpected bugs that shouldn't have happened:

Test that all name and value combinations resolve through the API.
Testing that all aliases resolve through the API.
Test that all keys are cased properly in the structures.
All structures in our Unicode tables are also present in the ASCII tables.

There is so much generated that it is hard to spot check everything, but these can easily be automated and ensure general integrity.
Bugs are part of programming, and parsing Unicode tables can be harder than it has to be sometimes due to how the data is presented at times, so I'm sure occasionally some issues will slip in, but I'd like to ensure moving forward that the dumbest bugs are stammpped out completely. I'd love to be able to focus on just updating the Unicode tables for new Unicode versions instead of fixing old generation 🙂.

So UniProps' testing is finished I believe and it has never been tested as thoroughly as it is now. TBH, it probably can't be tested too much more without reparsing the Unicode files just to make sure you are parsing them right the first time.
With that said, a couple more small cases arose where "unknown" aliases were backward and one interesting case in regards to order of evaluation.
The Regex library evaluates gc, script, block, and binary shortcuts in this order: gc, script, block and binary. I guess you could maybe argue that binary properties are not really shortcuts, they just have no values, so they seem like the shortcuts of script and/or block as you never actually specify them as binary=name, but I digress.
Perl on the other hand seems to evaluate gc, binary, script, and block. This actually makes more sense than what Regex documents that it does. You can actually have binary aliases that will never resolve, such as idc (id_continue) as there is a block property called ideographic_description_characters that has an alias of idc`.  If we look at Perl, they state:
  \p{Block: IDC}    \p{Block=Ideographic_Description_Characters} (NOT \p{ID_Continue} NOR \p{Is_IDC})

So, with that, we can see binary names should be ensured to resolve. Which makes sense as those are the names of the properties. If you have trouble with block, you can always use the more encouraged form of blk: idc. Binary doesn't have alternate forms to express the same thing, so it should take priority over the block` shortcut.
In short, I think the Python Regex library got this wrong, and we shouldn't follow down this path and instead should model Perl, which Regex is trying to provide a similar form of.

So UniProps' testing is finished I believe and it has never been tested as thoroughly as it is now. TBH, it probably can't be tested too much more without reparsing the Unicode files just to make sure you are parsing them right the first time.
With that said, a couple more small cases arose where "unknown" aliases were backward and one interesting case in regards to order of evaluation.
The Regex library evaluates gc, script, block, and binary shortcuts in this order: gc, script, block and binary. I guess you could maybe argue that binary properties are not really shortcuts, they just have no values, so they seem like the shortcuts of script and/or block as you never actually specify them as binary=name, but I digress.
Perl on the other hand seems to evaluate gc, binary, script, and block. This actually makes more sense than what Regex documents that it does. You can actually have binary aliases that will never resolve, such as idc (id_continue) as there is a block property called ideographic_description_characters that has an alias of idc`.  If we look at Perl, they state:
  \p{Block: IDC}    \p{Block=Ideographic_Description_Characters} (NOT \p{ID_Continue} NOR \p{Is_IDC})

So, with that, we can see binary names should be ensured to resolve. Which makes sense as those are the names of the properties. If you have trouble with block, you can always use the more encouraged form of blk: idc. Binary doesn't have alternate forms to express the same thing, so it should take priority over the block` shortcut.
In short, I think the Python Regex library got this wrong, and we shouldn't follow down this path and instead should model Perl, which Regex is trying to provide a similar form of.

I've created an issue over at Regex here to at least see the author's opinion on this matter (order of evaluation of Unicode properties): https://bitbucket.org/mrabarnett/mrab-regex/issues/398/order-of-evaluation-of-unicode-properties

I've created an issue over at Regex here to at least see the author's opinion on this matter (order of evaluation of Unicode properties): https://bitbucket.org/mrabarnett/mrab-regex/issues/398/order-of-evaluation-of-unicode-properties

It is intersting and It was brought up that PCRE implementations in general may follow after Regex in relation to order of evaluation: GC, Script, Block, Binary. Maybe it does in fact make sense to continue forward with what PCRE does instead of Perl. I imagine they are less likely to break things like Perl does, but who knows 🤷.

It is intersting and It was brought up that PCRE implementations in general may follow after Regex in relation to order of evaluation: GC, Script, Block, Binary. Maybe it does in fact make sense to continue forward with what PCRE does instead of Perl. I imagine they are less likely to break things like Perl does, but who knows 🤷.

And my earlier argument is a big flawed as you can specify binary properties as \p{name} or \p{name: t}, so you can remove the conflict regardless of the order.

And my earlier argument is a big flawed as you can specify binary properties as \p{name} or \p{name: t}, so you can remove the conflict regardless of the order.

So, the way it seems, Regex sounds like it follows closer to PCRE even though it borrows more from Perl than probably other regular expression engines. Most PCRE handles things like General Category and Script, and that is about it. Which makes sense why Regex favors Script right after GC. Block and Binary are just extra. It also explains why Regex favors Script instead of Script_Extensions when when using the shortcut form of script, as that is what PCRE does.

So, the way it seems, Regex sounds like it follows closer to PCRE even though it borrows more from Perl than probably other regular expression engines. Most PCRE handles things like General Category and Script, and that is about it. Which makes sense why Regex favors Script right after GC. Block and Binary are just extra. It also explains why Regex favors Script instead of Script_Extensions when when using the shortcut form of script, as that is what PCRE does.

Turns out wcmatch never enabled Unicode support and has been using the ASCII definition in its character classes all this time. While the documents stated otherwise, we never enabled Unicode support and never tested for it. We only ever tested for ASCII and enabled ASCII.
No one ever complained, and I didn't notice in my use of it either. I don't think wcmatch is going to stick with ASCII tables and drop backrefs support. We don't need to split this out. We just need to ensure all the bugfixes are brought back over here.

Turns out wcmatch never enabled Unicode support and has been using the ASCII definition in its character classes all this time. While the documents stated otherwise, we never enabled Unicode support and never tested for it. We only ever tested for ASCII and enabled ASCII.
No one ever complained, and I didn't notice in my use of it either. I don't think wcmatch is going to stick with ASCII tables and drop backrefs support. We don't need to split this out. We just need to ensure all the bugfixes are brought back over here.

I'm closing this issue as we are no longer going to move out the Unicode stuff. If I change the ordering of property evaluation, it will be in the next major release and not this upcoming bugfix release. The good news is that the Unicode stuff has never been so well tested, so I'm optimistic that we shouldn't have any more surprises.

I'm closing this issue as we are no longer going to move out the Unicode stuff. If I change the ordering of property evaluation, it will be in the next major release and not this upcoming bugfix release. The good news is that the Unicode stuff has never been so well tested, so I'm optimistic that we shouldn't have any more surprises.


jazzfs

The prototype included a filesystem based on jazz.tools but we want to develop it a bit more before adding to an official release.

Ideally we can have a better p2p file/blob replication strategy and just use jazz as a file index and coordinator
Previously there were issues with jazzfs related to file watching (see old open command code), so just make sure file watching works using Jazz subscriptions
It will depend on authentication so we'll need auth/users in Wanix to implement this properly
The Jazz API will be updated, so we want to make sure we're using the latest API

For now we can put off p2p file replication and just use the Jazz blob stream approach from the demo. There is also an issue to track the auth system required by this pass.


Update linked-servers-database-engine.md

Removing outdated reference to Access and Excel as this was only supported when using the Microsoft.Jet.OLEDB.4.0 OLE DB provider. Modern versions of Access and Excel use the Microsoft.ACE.OLEDB.12.0 OLE DB provider which is not supported for server-side, non-interactive user use.

@denniwil : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks @denniwil for contacting Microsoft with feedback about our product documentation. It could take from a few business days to a few weeks to confirm your change internally. We'll contact you if we need further information, and you'll receive an email message each time we "@mention" you in a comment.
By opening a pull request, you're helping the author add your approved change directly to the documentation. If the article is updated with your commit, GitHub will list you as an article contributor.
Thanks again for submitting your feedback. Your suggestions help improve our documentation.

@denniwil It is possible to create a linked server using ACE12 to an .xlsx file using SQL Server 2019, so we won't be publishing this change, but could you be more detailed on the incompatibilities or unsupported scenarios you mention?

Published in https://github.com/MicrosoftDocs/sql-docs-pr/pull/20668


Add Cloudsmith Container Registry to tested registry list

Signed-off-by: Ciara Carey<EMAIL_ADDRESS>
Summary

Ticket Link

Fixes
Release Note

Codecov Report

Merging #1966 (9cb88b4) into main (d14e774) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1966      +/-   ##
==========================================
- Coverage   34.90%   34.87%   -0.03%
==========================================
  Files         153      153
  Lines       10057    10057
==========================================
- Hits         3510     3507       -3
- Misses       6162     6164       +2
- Partials      385      386       +1

Impacted Files
Coverage Δ

pkg/cosign/tuf/client.go
61.98% <0.00%> (-0.83%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14e774...9cb88b4. Read the comment docs.

Welcome!


Secret scanning: 1-click revocation for GitHub tokens

Summary
Users will have the option to revoke GitHub tokens found by secret scanning with 1 click through the secret's UI alert view.
Intended Outcome
We want to enable GHAS customers to efficiently remediate detections of leaked GitHub tokens surfaced by secret scanning.
How will it work?
After taking any initial remediation steps on a detected GitHub token, users can click a Revoke secret button that will authorize GitHub to revoke the detected secret.

After reevaluation, we decided that we can best support our customers and their security teams by re-scoping the initial version of this feature as validity checks for GitHub tokens. This way, we hope that we provide our customers with a better understanding of the state of their alerts before they make the choice to revoke the secret or not.
You can follow our work on validity checks for GitHub tokens here: https://github.com/github/roadmap/issues/531


Better support for symbol information in diffs

It would be nice if symbolic information was retrieved from LSP for non-physical files as well. IntelliJ for instance accomplished that exposing an API that allow to mark any document as "close enough" to some file that exists on disk, so when you view a previous version of this file in a git diff you can still do things like go to definition, view docs, find usages, etc.

Actually this is unrelated to LSP. IMO this would be a general feature in VS Code since it can be fulfilled using the normal VS Code API.
@bpasero assigning to you since this would be a feature in the workbench editor itself.

I think you picked the wrong person.

@bpasero can you help me to decide who owns the diff editor (https://github.com/microsoft/vscode/blob/master/src/vs/workbench/browser/parts/editor/textDiffEditor.ts#L1).
The request ask that we add some sort of button to the diff editor that supports that code navigation features use the workspace file for doing the navigation when compared to the workspace file.

@dbaeumer I wrote that class but in the end it just uses our monaco diff editor from Alex.
I don't think this is about diff editors but about language support in non-file editors. Here is what happens:

git registers a file system provider for files that are on the index or staged
we open a diff of the local file and the staged one or the index one
we compare the 2 files leveraging the file system provider
we have infrastructure in the code editor to provide smart language information (and here I am not an expert anymore)
the extension responsible for showing that smart language information needs to be able to provide this information for these git resources

So I suggest to think about it this way:

there are non-file editors
extensions typically only support file based editos
extensions need to be able to provide language smarts for the non-file based editors

Does that make sense?

@bpasero yes, it does make sense it a perfect world where we can teach language services to understand git resource. However this is most of the time complicated and requires quite some work inside a language server.
The proposed feature (to my understanding) would work differently. Assuming you have a file file:///a.ts and file git:///a.ts and the user want to use code comprehension features in git:///a.ts he can press a button saying that the file is close to file:///a.ts. If the user then for example executes go to definition in git:///a.ts we would use the diff to file:///a.ts to map the position in git:///a.ts to a position in file:///a.ts and would execute go to definition with that position and file:///a.ts.
This might not always work but it would give a user navigation features with a language server understanding git:/// URIs.
The most prominent place of such a feature would be the diff editor.
So it looks to me that this would be a combined effort between workbench diff editor and Monaco diff editor.

I have absolutely no idea how this would work, but I am fine leaving this open as feature request.
To clarify: you might have replaced the contents of the file with something entirely different so how would the "left hand side" of the diff be any helpful in figuring out the symbols for these new contents?

To clarify: you might have replaced the contents of the file with something entirely different so how would the "left hand side" of the diff be any helpful in figuring out the symbols for these new contents?

That is correct. That is why the suggestion adds a button where the user needs to say that the two files are close to each other and the mapping will very likely be correct.

Not as a button pressed by the user, but as a method that extension authors can call. In IntelliJ, we call OutsidersPsiFileSupport.markFile(file, /path/to/physical/file) and that's all it takes to have PSI support in buffers associated with our custom protocol handler.

And again, this is not about git diffs only, but something to offer to any extension that calls workspace.registerTextDocumentContentProvider()

Actually I like the API thing as well.
@jrieken did something like this every come up. It would be a cool trick to get code navigation in files which a language service usually doesn't understand.


Set up nightly builds

@jemc so, would it be reasonable of me to assume, given that with the --static flag passed that this is failing to link, that something is bad with our alpine-release docker images?
Do you have any idea what needs to be done to address?

It appears that --static is broken? I could use eyes to make sure that I'm not doing something very off when I use it.


Remove deprecated rubyforge_project  from gemspec

RubyForge was close more than 5 years ago from what I can tell.

Thanks! For posterity: https://guides.rubygems.org/specification-reference/

@francois-ferrandis was this somehow breaking things for you? do you need a new patch-level release?

@scudco I got the following warning when running a gem command on my system :
NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.

However, I think this only happens when specifying a commit hash in the Gemfile, which I did for some reason.
So to sum up: no, I don't think a new release is necessary. :smile_cat:


Fix UI bugs

@gabrielpoca can you test if both of these are now fixed? I moved to headlessui/react


Keyboard ist not visible on small screens

I've tested it on screen size 797x1018. If you zoom out then it gets visible.

This is the default behaviour. Please have a look at line 97:
https://github.com/the-darc/angular-virtual-keyboard/blob/master/src/angular-virtual-keyboard.js


Horizontal Scrollbar on Off Canvas

I have an accordion menu inside an off canvas. When I upgraded to 6.2rc1 I now have a scrollbar at the bottom of the accordion menu. If you look at the screenshot below, you'll see that as the accordion menu expands, the arrows start to get cutoff. I'm unsure where the issue lies but it was working fine in 6.1.2. Here is a screenshot:

 Home

 Breed Info

About Kerries

FAQ

Description

Description

 Summary

Bark

@Lynda333 is this still an issue with 6.2.1?

@kball - Yes it is.

@JeremyEnglert is this something you can look into?

@Lynda333, could you make a CodePen reproducing this?

@brettsmason was this fixed in the off canvas rework?