Modifying Commit Author

I think this action is really useful 🙌  And you certainly saved the time of many others as well :)
Description
It would be great if one could specify the commit author configuration for the PR.
Existing example
The "Deploy to GitHub Pages" action allows you to do that for example: https://github.com/marketplace/actions/deploy-to-github-pages
See https://github.com/marketplace/actions/deploy-to-github-pages#optional-choices.

Hi @creativecreatorormaybenot!
Glad you think you saved some time using this action 😄
It is the parameters GIT_CONFIG_NAME and GIT_CONFIG_EMAIL you are thinking of, which currently in this action is hardcoded to github-actions and<EMAIL_ADDRESS>

Hi @creativecreatorormaybenot!
Glad you think you saved some time using this action 😄
It is the parameters GIT_CONFIG_NAME and GIT_CONFIG_EMAIL you are thinking of, which currently in this action is hardcoded to github-actions and<EMAIL_ADDRESS>

@FantasticFiasco Yes, exactly. It would be amazing to sign the commits of course, however, I assume that this would be too complicated.
If you look at the commit in my repo (https://github.com/creativecreatorormaybenot/funvas/commit/039e652835701f85b28a65829adb117b769280ab), it looks pretty ugly because of two things: 1. it has @github-actions as the PR author (which is okay), however, it has a user without an icon as the commit author. That should likely have my config instead (i.e. my name and email) 👍

@FantasticFiasco Yes, exactly. It would be amazing to sign the commits of course, however, I assume that this would be too complicated.
If you look at the commit in my repo (https://github.com/creativecreatorormaybenot/funvas/commit/039e652835701f85b28a65829adb117b769280ab), it looks pretty ugly because of two things: 1. it has @github-actions as the PR author (which is okay), however, it has a user without an icon as the commit author. That should likely have my config instead (i.e. my name and email) 👍

I think we can support git name and e-mail without any breaking changes, and I don't foresee any problems with the implementation either.
Regarding GPG signing, please open a new issue regarding that and we'll see what we can do about it. I think I need your input there, because it would most probably require you to save your private key in GitHub, and I would argue that not everybody would be comfortable doing so.

I think we can support git name and e-mail without any breaking changes, and I don't foresee any problems with the implementation either.
Regarding GPG signing, please open a new issue regarding that and we'll see what we can do about it. I think I need your input there, because it would most probably require you to save your private key in GitHub, and I would argue that not everybody would be comfortable doing so.

@FantasticFiasco I agree - I probably do not even want to open an issue because of that.

@FantasticFiasco I agree - I probably do not even want to open an issue because of that.

@creativecreatorormaybenot, would you be able to update your configuration, and replace <your name> and <your e-mail> with relevant values.
- uses: FantasticFiasco/action-update-license-year@66564cc720675678f03c008d254ebbf5f22609ac
      with:
        token: ${{ secrets.GITHUB_TOKEN }}
        path: '**/LICENSE'
        commitTitle: Update copyright year in LICENSE file(s)
        prTitle: Update copyright year in LICENSE file(s)
        prBody: New Year is here and we want to keep up with time :)
        assignees: creativecreatorormaybenot
        commitAuthorName: <your name>
        commitAuthorEmail: <your e-mail>

If you find that the behavior meets your expectations, I'll continue with releasing this officially.

@creativecreatorormaybenot, would you be able to update your configuration, and replace <your name> and <your e-mail> with relevant values.
- uses: FantasticFiasco/action-update-license-year@66564cc720675678f03c008d254ebbf5f22609ac
      with:
        token: ${{ secrets.GITHUB_TOKEN }}
        path: '**/LICENSE'
        commitTitle: Update copyright year in LICENSE file(s)
        prTitle: Update copyright year in LICENSE file(s)
        prBody: New Year is here and we want to keep up with time :)
        assignees: creativecreatorormaybenot
        commitAuthorName: <your name>
        commitAuthorEmail: <your e-mail>

If you find that the behavior meets your expectations, I'll continue with releasing this officially.

@FantasticFiasco will do tomorrow - thanks!

@FantasticFiasco will do tomorrow - thanks!

@FantasticFiasco Worked great! Thank you so much ❤
See https://github.com/creativecreatorormaybenot/wakelock/pull/83 :)

@FantasticFiasco Worked great! Thank you so much ❤
See https://github.com/creativecreatorormaybenot/wakelock/pull/83 :)

You should be able to use @v2 of the action now, since the feature officially has been released.
Thanks for your feature suggestion!

You should be able to use @v2 of the action now, since the feature officially has been released.
Thanks for your feature suggestion!


Add support for free radio stations

Implement support for free radio stations.
As discussed in issue #552.

Thanks for seeing this through! I'd still like to add some tests before cutting a release including this, but this ought to be enough to unblock the people waiting on support.


Navigate to definition is not working correctly

If I cmd+click on walk in
os.walk("<some-path>", walker)

it does nothing.
(it works for builtins like println)
Using latest v and vls on OSX  11.5 and VSCode.

@rasa-silva is there a minimal code that I can use to reproduce the behavior?

module main

import os

fn walker(elem string) {
	println('visiting $elem')
}

fn main() {
	os.walk('<some-dir>', walker)
}

cmd+click works for println but does not for walk

I'm sorry, I was pointing to an old build of vls.
The current problem is actually bigger...I point to the vls binary in vscode along with "Enables the language server" and "enable debug".
Vscode instantiates VLS and the log file is created with
[Trace - 09:19:55] Sending notification 'window/showMessage'.
Params: {"jsonrpc":"2.0","method":"window/showMessage","params":{"type":2,"message":"VLS is a work-in-progress, pre-alpha language server. It may not be guaranteed to work reliably due to memory issues and other related factors. We encourage you to submit an issue if you encounter any problems."}}

[Trace - 09:19:55] Received request 'initialize - (0)'.
Params: {"jsonrpc":"2.0","id":0,"method":"initialize","params":{"processId":79709,"clientInfo":{"name":"Visual Studio Code","version":"1.60.1"},"locale":"en-us","rootPath":"/Users/ricardo.silva/code/vex","rootUri":"file:///Users/ricardo.silva/code/vex","capabilities":{"workspace":{"applyEdit":true,"workspaceEdit":{"documentChanges":true,"resourceOperations":["create","rename","delete"],"failureHandling":"textOnlyTransactional","normalizesLineEndings":true,"changeAnnotationSupport":{"groupsOnLabel":true}},"didChangeConfiguration":{"dynamicRegistration":true},"didChangeWatchedFiles":{"dynamicRegistration":true},"symbol":{"dynamicRegistration":true,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]},"tagSupport":{"valueSet":[1]}},"codeLens":{"refreshSupport":true},"executeCommand":{"dynamicRegistration":true},"configuration":true,"workspaceFolders":true,"semanticTokens":{"refreshSupport":true},"fileOperations":{"dynamicRegistration":true,"didCreate":true,"didRename":true,"didDelete":true,"willCreate":true,"willRename":true,"willDelete":true}},"textDocument":{"publishDiagnostics":{"relatedInformation":true,"versionSupport":false,"tagSupport":{"valueSet":[1,2]},"codeDescriptionSupport":true,"dataSupport":true},"synchronization":{"dynamicRegistration":true,"willSave":true,"willSaveWaitUntil":true,"didSave":true},"completion":{"dynamicRegistration":true,"contextSupport":true,"completionItem":{"snippetSupport":true,"commitCharactersSupport":true,"documentationFormat":["markdown","plaintext"],"deprecatedSupport":true,"preselectSupport":true,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":true,"resolveSupport":{"properties":["documentation","detail","additionalTextEdits"]},"insertTextModeSupport":{"valueSet":[1,2]}},"completionItemKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25]}},"hover":{"dynamicRegistration":true,"contentFormat":["markdown","plaintext"]},"signatureHelp":{"dynamicRegistration":true,"signatureInformation":{"documentationFormat":["markdown","plaintext"],"parameterInformation":{"labelOffsetSupport":true},"activeParameterSupport":true},"contextSupport":true},"definition":{"dynamicRegistration":true,"linkSupport":true},"references":{"dynamicRegistration":true},"documentHighlight":{"dynamicRegistration":true},"documentSymbol":{"dynamicRegistration":true,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]},"hierarchicalDocumentSymbolSupport":true,"tagSupport":{"valueSet":[1]},"labelSupport":true},"codeAction":{"dynamicRegistration":true,"isPreferredSupport":true,"disabledSupport":true,"dataSupport":true,"resolveSupport":{"properties":["edit"]},"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}},"honorsChangeAnnotations":false},"codeLens":{"dynamicRegistration":true},"formatting":{"dynamicRegistration":true},"rangeFormatting":{"dynamicRegistration":true},"onTypeFormatting":{"dynamicRegistration":true},"rename":{"dynamicRegistration":true,"prepareSupport":true,"prepareSupportDefaultBehavior":1,"honorsChangeAnnotations":true},"documentLink":{"dynamicRegistration":true,"tooltipSupport":true},"typeDefinition":{"dynamicRegistration":true,"linkSupport":true},"implementation":{"dynamicRegistration":true,"linkSupport":true},"colorProvider":{"dynamicRegistration":true},"foldingRange":{"dynamicRegistration":true,"rangeLimit":5000,"lineFoldingOnly":true},"declaration":{"dynamicRegistration":true,"linkSupport":true},"selectionRange":{"dynamicRegistration":true},"callHiera

but no functionality of the language server is available and no output "tab" is created for VLS. Also, the message "VLS is a work in progress..." does not show up...

It can work for me on Windows.

Ok, sorry for the confusion. I think I found the issue...

If I use the custom path to VLS it has the behavior of my last comment. It runs the server but somehow it doesn't seem to connect with VSCode
If I use the fetched version of VLS, it has the behavior of my original comment.

The first case seems an issue with the extension. The second seems a problem with the server itself...

@rasa-silva I just tried it just now and is indeed not jumping to the file. This is something I'm clueless about as to what the actual cause for this (even on the VSCode side, it does not show any error logs) but it is something must be investigated and fixed.
https://user-images.githubusercontent.com/7358345/134320188-479963cf-af20-440c-b94c-78b06c9b003e.mov

Well, at least it's reproducible 😅
and thanks for the quick update!

Try https://blog.vosca.dev/meet-v-analyzer/ instead, now that it is released.


fix non-existing "CloudProvider Interface" link

minor change, just get 404 error when clicking the url and try to fix it.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Please delete this note before submitting the pull request.
For 1.13 Features: set Milestone to 1.13 and Base Branch to dev-1.13
Help editing and submitting pull requests:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.
Help choosing which branch to use:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

/assign @chenopis

changing my mind bc this is a complicated situation. The same link exists elsewhere, and it's not clear how to fix or update. Filing an issue to revisit these general cloud provider docs, merging this one for now bc it's better than no fix for a 404.
/lgtm
/approve


ListFields?

Howdy!
I was looking for an analog to ListFields.
From what I can tell with rust-protobuf I have to iterate over every field descriptor and check if a message has that field set using the FieldDescriptor::has_field method.
Am I just missing something?

If I understand you correctly, you are asking about protobuf reflection.
It is implemented, it is actually used for formatting message to string by rust-protobuf itself, have a look at the implementation in text_format.rs.
Probably it is not very convenient to use, suggestions are welcome!
Also note, that at the moment reflection is implemented only for reading, but not for modification.

Yep, I was speaking about reflection. I looked at the C++ protobuf implementation and that method is doing almost exactly was I'm doing in my app so I think I'm all set. :)
The key for me is to be able to know exactly what is set vs default and so far 'has_field' does the trick. I hope that is the intended usage! :)

Note that protobuf 3 has no field presence bit. So rust-protobuf will remove has_ methods for files generated from protos with syntax = "proto3" (it is not implemented yet).

https://github.com/google/protobuf/blob/master/src/google/protobuf/generated_message_reflection.cc#L1051
https://github.com/google/protobuf/blob/master/src/google/protobuf/generated_message_reflection.cc#L2013
Leads me to think they intend to keep the ability to support has_-like methods in the reflection api even without the bits.
Not being able to check if fields were set would break so much code out there (though, perhaps not any rust projects).

Although, my design so far is based on another system that is in production, perhaps I need to reevaluate the approach and avoid reflection.

Now, maybe we can use oneof?
@photex @stepancheg


Roll Flutter Engine from 9b4c3b3d5518 to 10bf02b41462 (1 revision)

https://github.com/flutter/engine/compare/9b4c3b3d5518...10bf02b41462
2024-11-10<EMAIL_ADDRESS>fml: Improve CFTest.SupportsCustomRetainRelease test (flutter/engine#56480)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Fix Cocoapod spec

This PR updates Cocoapod spec file in order to export the project as a framework and not just a list of headers.

🚀

LGTM 👍


User-defined agents

Allow users to enter connection information for their own agents. For now, require authentication once per session. Maybe later we can do keypair gen as described in #46.

Requires https://github.com/Computational-Plant-Science/plantit-cli/issues/29

Added in cd543b3


[BUG] Not able to load Plugin in IPadOS or iOS

Describe the bug
Can download the plugin in iPad but not able to enable it. It say Failed to Load the plugin.

Check out #10 for details about this.


[Websocket] Improve the test coverage of WebSocket

Description:
Check all the existing test cases whether covered all the scenario or not. If that scenario doesn't have, we should add that.

Test coverage is improved by https://github.com/ballerina-platform/module-ballerina-websocket/pull/134


New command: planner tenant settings set

Usage
m365 planner tenant settings set [options]
Description
Sets Microsoft Planner configuration of the tenant
Options

Option
Description

--isPlannerAllowed [isPlannerAllowed
Configure whether Planner should be enabled on the tenant.

--allowCalendarSharing [allowCalendarSharing]
Configure whether Outlook calendar sync is enabled.

--allowTenantMoveWithDataLoss [allowTenantMoveWithDataLoss]
Configure whether a tenant move into a new region is authorized.

--allowRosterCreation [allowRosterCreation]
Configure whether Planner roster creation is allowed.

--allowPlannerMobilePushNotifications [allowPlannerMobilePushNotifications]
Configure whether push notifications are enabled in the mobile app.

Examples
Disable Microsoft Planner in the tenant
m365 planner tenant settings set --isPlannerAllowed false

Disable Outlook calendar sync and mobile push notifications
m365 planner tenant settings set --allowCalendarSharing false --allowPlannerMobilePushNotifications  false

Remarks
To use this command you must be a global admin.
Additional Info
Didn't find any relevant API docs.
However only thing you should do it execute following request:
PATCH https://tasks.office.com/taskAPI/tenantAdminSettings/Settings
Accept: application/json;odata.metadata=none
Prefer: return=representation
{
    "isPlannerAllowed": true,
    "allowCalendarSharing": true,
    "allowTenantMoveWithDataLoss": false,
    "allowRosterCreation": true,
    "allowPlannerMobilePushNotifications": true
}

Looks great @milanholemans, take care to note in the docs what kind of permissions the user needs to execute this.

Looks great @milanholemans, take care to add a note in the docs specifying what kind of permissions the user needs to execute this.

Great idea! Updated the spec.

That's good to hear @milanholemans, please do!


Can't filter a type out of an array of unions

try flow
const foo: Array<string | number> = [];
const bar = foo.filter(n => typeof n === 'string');

bar is still Array<string | number>
I also can't annotate bar to Array<string> without casting it through any first

It's known problem. You can find a lot of issues about this.
As a solution you can use reduce of flatMap which can be refined with actual values instead of magical booleans.

@TrySound - I don't see how either reduce or flatMap is a valid replacement.  Can you give an example?

Sorry, "or".
reduce from array prototype
const a = b.reduce((acc, d) => {
  if (typeof d === 'number') {
    acc.push(d);
  }
  return acc;
}, [])

or flatMap from any library or handwritten or from the future
const a = flatMap(b, d => typeof d === 'number' ? [d] : []);

they are both easy to type.

Performance impact doesn't matter if you don't work with large arrays.

Performance impact with flatMap doesn't matter if you don't work with large arrays.

Like canvas pixel arrays?  :)  I think I'll just cast through any for now, as much as I hate doing that

@MarkKahn Then reduce as more common version of filter will solve your problem. Just don't use filter if you need refinement.

What's your reasoning for pushing towards something like reduce vs. casting through any?
const bar: Array<string> = (foo.filter(n => typeof n === 'string'): any);

.filter has a clear meaning, reduce is being used way outside of it's normal intention here.

Dupe of #1414

any is not safe.

of course not, one of its purposes is to bypass the typechecker in exactly situations like this where it fails.  Perhaps it's just philosophical, but I'd rather keep the intent of my code correct than jump through weird coding patterns to make flow happy.
Though I see your point, and I'd argue for something like this instead:
const filteredAry = [];
ary.forEach(v => (typeof v === 'string') && filteredAry.push(v));


Webcam causing Error

Here is the video am trying to download
For some reason now it works even with webcam but i dont know the first time what happen. Can you help me to prevent this from happening again?
Here is the console log:
`
C:\Users\andre>bbb-dl --verbose --encoder hevc_nvenc --audiocodec mp3 -sw --crf -1 --preset 13 "https://bbb-lb.finki.ukim.mk/playback/presentation/2.3/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753?meetingId=dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753"
Output directory for the final video is: C:\Users\andre
Directory for the temporary files is: C:\Users\andre\AppData\Local\bbb-dl\90a13508ea4c196048af382b9948c393
Downloading meta information
metadata.xml is already present
shapes.svg is already present
Downloading webcams / deskshare
cursor.xml is already present
panzooms.xml is already present
captions.json is already present
deskshare.xml is already present
Downloading events.xml from: https://bbb-lb.finki.ukim.mk/presentation/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753/events.xml
presentation_text.json is already present
slides_new.xml is already present
Downloading notes.html from: https://bbb-lb.finki.ukim.mk/presentation/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753/notes.html
Downloading polls.json from: https://bbb-lb.finki.ukim.mk/presentation/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753/polls.json
Downloading external_videos.json from: https://bbb-lb.finki.ukim.mk/presentation/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753/external_videos.json
video/webcams.webm is already present
Downloading video/webcams.mp4 from: https://bbb-lb.finki.ukim.mk/presentation/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753/video/webcams.mp4
Downloading deskshare/deskshare.webm from: https://bbb-lb.finki.ukim.mk/presentation/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753/deskshare/deskshare.webm
Downloading deskshare/deskshare.mp4 from: https://bbb-lb.finki.ukim.mk/presentation/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753/deskshare/deskshare.mp4
notes.html could not be downloaded: 404 Not Found
Error: 404, message='Not Found', url=URL('https://bbb-lb.finki.ukim.mk/presentation/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753/notes.html')
events.xml could not be downloaded: 404 Not Found
Error: 404, message='Not Found', url=URL('https://bbb-lb.finki.ukim.mk/presentation/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753/events.xml')
external_videos.json could not be downloaded: 404 Not Found
Error: 404, message='Not Found', url=URL('https://bbb-lb.finki.ukim.mk/presentation/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753/external_videos.json')
video/webcams.mp4 could not be downloaded: 404 Not Found
Error: 404, message='Not Found', url=URL('https://bbb-lb.finki.ukim.mk/presentation/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753/video/webcams.mp4')
polls.json could not be downloaded: 404 Not Found
Error: 404, message='Not Found', url=URL('https://bbb-lb.finki.ukim.mk/presentation/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753/polls.json')
deskshare/deskshare.mp4 could not be downloaded: 404 Not Found
Error: 404, message='Not Found', url=URL('https://bbb-lb.finki.ukim.mk/presentation/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753/deskshare/deskshare.mp4')
deskshare/deskshare.webm could not be downloaded: 404 Not Found
Error: 404, message='Not Found', url=URL('https://bbb-lb.finki.ukim.mk/presentation/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753/deskshare/deskshare.webm')
Downloading slides
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-1.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-2.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-3.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-4.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-5.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-6.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-7.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-8.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-9.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-10.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-11.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-12.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-13.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-14.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-15.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-16.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-17.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-18.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-19.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-20.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-21.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-22.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-23.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-24.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-25.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-26.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-27.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-28.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-29.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-30.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-31.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-32.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-33.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-34.png is already present
presentation/77735affeb91e4f68759381cc1a9cee51e0466a9-1602661853914/slide-35.png is already present
Recording title: Глава 1
Recording date: 2020-10-14T09-50-04
Recording duration: 1:05:09
BBB version: 3.7.4+
No desk was shared in this session
Start capturing frames...
Output directory for frames is: C:\Users\andre\AppData\Local\bbb-dl\90a13508ea4c196048af382b9948c393\frames
Initialization takes a few seconds...

Start creating slideshow...
Slideshow does already exist! Skipping rendering!
Mux final slideshow
Running command: ffmpeg -hide_banner -i C:\Users\andre\AppData\Local\bbb-dl\90a13508ea4c196048af382b9948c393\video\webcams.webm -i C:\Users\andre\AppData\Local\bbb-dl\90a13508ea4c196048af382b9948c393\slideshow.mp4 -c:v hevc_nvenc -c:a mp3 -map 0:a -map 1:v -strict experimental -crf -1 -preset 13 -shortest C:\Users\andre\2020-10-14T09-50-04_Глава 1.mp4
Traceback (most recent call last):
File "", line 198, in _run_module_as_main
File "", line 88, in run_code
File "C:\Users\andre\AppData\Roaming\Python\Python312\Scripts\bbb-dl.exe_main.py", line 7, in
File "C:\Users\andre\AppData\Roaming\Python\Python312\site-packages\bbb_dl\main.py", line 1479, in main
bbb_dl.run()
File "C:\Users\andre\AppData\Roaming\Python\Python312\site-packages\bbb_dl\main.py", line 276, in run
result_path = self.final_mux(slideshow_path, webcams_path, webcams_rel_path, metadata)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\andre\AppData\Roaming\Python\Python312\site-packages\bbb_dl\main.py", line 1133, in final_mux
asyncio.run(
File "C:\Python312\Lib\asyncio\runners.py", line 194, in run
return runner.run(main)
^^^^^^^^^^^^^^^^
File "C:\Python312\Lib\asyncio\runners.py", line 118, in run
return self._loop.run_until_complete(task)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Python312\Lib\asyncio\base_events.py", line 687, in run_until_complete
return future.result()
^^^^^^^^^^^^^^^
File "C:\Users\andre\AppData\Roaming\Python\Python312\site-packages\bbb_dl\ffmpeg.py", line 323, in add_audio_to_slideshow
await ffmpeg.execute()
File "C:\Users\andre\AppData\Roaming\Python\Python312\site-packages\ffmpeg\asyncio\ffmpeg.py", line 208, in execute
raise FFmpegError.create(message=tasks[2].result(), arguments=self.arguments)
ffmpeg.errors.FFmpegError: Error opening input files: Invalid data found when processing input`

Can you please remove C:\Users\andre\AppData\Local\bbb-dl\90a13508ea4c196048af382b9948c393\slideshow.mp4 and then send the verbose output of your comand again here.

This is very strange behaviour of bbb-dl. I use it very often and still can't figure it out what happend last night.

I runned the command as you said as you said and finished with success. Here it is.

After this i deleted helper folder that bbb-dl stores slides, webcam, slideshow etc... also deleted the final outputvideo, and I runned the command again (same command from last night--> bbb-dl --verbose --encoder hevc_nvenc --audiocodec mp3 -sw --crf -1 --preset 13 "https://bbb-lb.finki.ukim.mk/playback/presentation/2.3/dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753?meetingId=dda8257dfa2d3b1a88d71054093e9e315e79da98-1602661804753") and it works just fine. But last night i was runninng it for 3-4 times and every time was crashing.

Here is the console this time (second time) runned from scratch and it finished with success again

🤷 Strange. But good that it now works.
Was this the first time, this happend?
My best guess would be that, somhow the webcam.mp4 file was bugged, beacuse of an download error. It could be that I implemented a error in the method to continue downloading after Internet error, and so the final webcam file was corrupted.
But since you are the first one reporting such an error... 🤷 we have to wait for more data

Yes, first time happening.
Bro I found out. There's nothing wrong with the bbb-dl. It was my fault.
My Laptop mode was set to "optimized" instead of "standard" and I guess my graphics card was not running and in the bbb-dl i specifed that i want --encoder hevc_nvenc. I switched to optimized now and i got the same error as the first comment of this issue ticked. I switched to standard and the video finished successfully.


Roll Flutter Engine from a8fefc81188e to 97e990cde9f6 (1 revision)

https://github.com/flutter/engine/compare/a8fefc81188e...97e990cde9f6
2024-08-16<EMAIL_ADDRESS>Manual roll Dart SDK from 44635f897535 to 790fcb755a0a (3 revisions) (flutter/engine#54558)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


[RFC] Side panel on Chrome

How do you envision this feature/change to look/work like?
Thank you for the work! I wanted to create an extension on the new released Chrome side panel, and I am wondering if that can be done with Plasmo.
https://developer.chrome.com/docs/extensions/reference/sidePanel/#overview
What is the purpose of this change/feature? Why?
Basically I want to build an extension for my tabs management, but I will navigate to different tabs often. I want the extension can be kept in the side panel of chrome.
(OPTIONAL) Example implementations
Would it be like the popup layout and we can use it just like creating a sidePanel.tsx, and add manifest override in package.json like this:
permissions: ["sidePanel"]
(OPTIONAL) Contribution

[ ] I would like to contribute to this RFC via a PR

Verify canary release

[X] I verified that the issue exists in plasmo canary release

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

I think this feature will be like sandbox - simply add a sidepanel.tsx and you're good to go, no need to add permission manually.

Thanks for the reply!
May I know that is this planned to work on?

It's open for contribution if you would like to get it done :) @xeroxcsn

LMK if you wanna spearhead it as well or if you're already cooking something for this feat @gotjoshua

basically just looking forward to it! and if you have design decisions to make, i am happy to think along. no extra bandwidth for hacking along at the moment.
cheers...

In the current version, you can use the sidePanel through the following way:
{
  "manifest": {
    "permissions": [
      "sidePanel"
    ],
    "side_panel": {
      "default_path": "tabs/sidepanel.html"
    }
  }
}

// tabs/sidepanel.tsx

function IndexSidePanel() {
  // ...
}

export default IndexSidePanel;

In the current version, you can use the sidePanel through the following way:

thank you! it works!

In the current version, you can use the sidePanel through the following way:
{
  "manifest": {
    "permissions": [
      "sidePanel"
    ],
    "side_panel": {
      "default_path": "tabs/sidepanel.html"
    }
  }
}

// tabs/sidepanel.tsx

function IndexSidePanel() {
  // ...
}

export default IndexSidePanel;

你好，我看了文档说建一个sidepanel.tsx就会跳转，我现在是要实现点击按钮实现跳转

 "side_panel": {
>       "default_path": "tabs/sidepanel.html"
>     }

配置上面的是默认又用html吗

I want to achieve opening the sidebar by clicking a button, but now whenever the icon is clicked, the sidebar opens and the popup.html page does not pop up. How can this issue be resolved?


Connect to app

This enables connecting ThemisML to the app

This PR also includes the changes from #11 because I didn't want to get into a conflict and testing is much faster using the changes there as well


Improving build on Mac and Linux

Now using the proper way of compiling under Mac, and using the yum_requirements.txt on Linux as wcslib so we do not need to install gcc.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

The build on Travis has stalled. Closing and reopening.


Mails are delivered on other domain mails id

Hi,
Mails are delivered on other domain mails id.
Here the screen shot of error. Please Check it.

rediffmal.com has no MX records and for whatever reason your Postal wasn't able to communicate to the email servers of pneumax-india.com


Can't use the plugin: "The labels prop in component overrides has been removed."

Describe the bug
When using the plugin, Astro crashes.
[ERROR] [AstroUserError] The `labels` prop in component overrides has been removed.
  Hint:
    Replace `Astro.props.labels["search.label"]` with `Astro.locals.t("search.label")` instead.
    For more information see https://starlight.astro.build/guides/i18n/#using-ui-translations

Stracktrace:
AstroUserError: The `labels` prop in component overrides has been removed.
    at Object.get (/home/fmilazeck/wsl_projects/_development/wordpress_docs/wordpress-docs/node_modules/@astrojs/starlight/utils/i18n.ts:16:10)
    at /home/fmilazeck/wsl_projects/_development/wordpress_docs/wordpress-docs/node_modules/starlight-versions/components/VersionSearch.astro:19:16
    at AstroComponentInstance.VersionSearch [as factory] (/home/fmilazeck/wsl_projects/_development/wordpress_docs/wordpress-docs/node_modules/astro/dist/runtime/server/astro-component.js:16:12)
    at AstroComponentInstance.init (/home/fmilazeck/wsl_projects/_development/wordpress_docs/wordpress-docs/node_modules/astro/dist/runtime/server/render/astro/instance.js:32:29)
    at AstroComponentInstance.render (/home/fmilazeck/wsl_projects/_development/wordpress_docs/wordpress-docs/node_modules/astro/dist/runtime/server/render/astro/instance.js:42:36)
    at Object.render (/home/fmilazeck/wsl_projects/_development/wordpress_docs/wordpress-docs/node_modules/astro/dist/runtime/server/render/component.js:366:22)
    at Module.renderChild (/home/fmilazeck/wsl_projects/_development/wordpress_docs/wordpress-docs/node_modules/astro/dist/runtime/server/render/any.js:31:17)

To Reproduce
Add the plugin to your Astro config file.
Expected behavior
Dev and build mode should not crash. The page should be displayed accordingly.
How often does this bug happen?
Every time
System Info
No response
Additional Context
No response

Thanks for the report 🙌
The issue was due to a breaking change in Starlight 0.28.0 recently released. The new 0.3.0 version of the plugin that I've just released should fix the issue.


x/tools/internal/lsp: gopls issues on Windows

Created from https://github.com/microsoft/vscode-go/issues/2501

My guess is that this was likely related to #31937 and can be addressed with the workaround mentioned in that issue. Please create a new issue if other problems related to gopls on Windows appear again.


CTrie TNode fix, concurrency test fixes, client_id locking

Please see the attached commits for consideration into master.  In my tests, these changes have improved the stability of the new CTrie implementation under a bit of controlled load.  Discussion encouraged.

Correct if I'm wrong, but substantially you are suggesting to use a locking per client? If it's, it's not what I wanted to implement using the CTrie, as CTrie original paper state, they are trees structures thought to avoid locking by VM and using versioning and CAS operations.

I should have been more clear about the PR.  There are 4 separate changes, each which address a different problem.  I can break this PR into 4 PR's if you would like, so we can discuss each one separately.  I do understand that you have a goal of being as lock-free as possible.  Let me know how to proceed.
First commit - CTrie fix 09ab912c08f656370a01b3ae8bcd27bc03e33276
Our use of the CTrie deviates from the paper in a few ways, some of which are a bug, some which are ok for now.
We allow for a node to exist without any subscriptions, and prior to my recommended change (this commit), we were not compressing TNodes.  This commit compresses just the last TNode after unsubscribe.  This is essential because you can never reuse an INode which points to a TNode, it is tombed forever.  So the next insert would need to handle this condition prior to insert.
There was another issue with concurrency inside the CNode instance itself.  Concurrent access to a single CNode is typical under load, and I did in fact hit concurrency exceptions with subscriptions and clients datastructures.  I make the copy constructor generate new datastructures, I think the code was only passing on the reference to the new CNode before.  We may need to look further into when these concurrency conditions occur, but I am 100% sure they do.
The There are a few remaining improvements that we should probably consider in the future:  Our remove only removes the last node, so if you have a long chain, we are left with unused nodes.  I think the paper also suggests that we check for TNodes in all operations, and handle them prior to any insert, update, or delete.
If you run the unit tests from this commit (without the fixes), you should notice that clients get into a situation where they cannot remove a subscription.  Most other bugs were observed in testing under heavy load.
Commit:  77759768ec4d5714c220a30d66633fb46c3eb6aa
This is a feature we need, I'd like to be able to get all sessions, including transient sessions.  Also, added the client_id to the DTO.
Commit:  3608c76b100618df12cffb89edfbb53804aa0636
Do not allow simultaneous mqtt messages from a given client to enter.  There are a few ideas to discuss here.  First, a session seems like it should have affinity on a NIO channel, or rather TCP socket.  I notice now that you store the client_id as a Netty channel atrib.  So, under normal conditions, the locking should never restrict, would you agree?  I think MQTT restricts a client_id to a single connection at a time anyways.  In practice, under heavy load, with clients attempting to reconnect, I believe that there are possible conditions which a client may attempt to violate these rules.  I see that there are places in publish/unpublish or maybe login, which are potentially not safe to run concurrently for the same client_id.  Since it should not happen anyways, I thought this would be a stability improvement to enforce.  Let me know what you think about this idea.
f4c53822c3cf5ae1ada74842d97cf2aa34a2ee56
Try/Catch around canRead or CanWrite.
If the implementation (embedded use-case) throws an exception, we should probably catch it and deny access.  If we allow the exception to be uncaught all the way to NettyMQTTHandler, then we may leave subscriptionInCourse state stuck in verified, and and at the very least we don't return a failed SUBACK.  This is not moquette's bug, but the implementations of IAuthorizator might be careless and this is a way for us to reduce bugs on their side.

Probably it is best to close this PR, and let me know which commits to bundle together into a new PR.  For example, I could create a PR for all changes except the client level locking.

I think that each commit request a PR, because it's almost unrelated.. But give me some time to review carefully.


btrfs no space cache

Sometimes after adding space with dd,  btrfs partition could not be expanded because of insufficient space.
A few users had hit this, and a user confirmed the problem went away after he rebooted, which makes me think it is some sort of caching issue.
This is an attempt to fix the issue by disabling free space cache on btrfs. As I have not been able to reproduce this, this is more like a guess at this point.

LGTM

It'd be nice to have the PR description as the commit message. It will get lost otherwise


Revert "[spike] DCOS-46215: Error requesting UI Configuration message email is shown as {0}"

Reverts dcos/dcos-ui#3575

:tada: This PR is included in version 2.81.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


error during jsx install (docker)

Restart services during package upgrades without asking? [yes/no] yes
copy installer over from where I install from
Warning: Permanently added '[localhost]:9122' (ECDSA) to the list of known hosts.
 - Installing jumpscaleX
yes
E: Could not get lock /var/lib/dpkg/lock-frontend - open (11: Resource temporarily unavailable)
E: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), is another process using it?
Connection to localhost closed.

EXCEPTION

        /tmp/jsx                                                     : 552 : cli()
        /usr/local/lib/python3.7/site-packages/click/core.py         : 764 : return self.main(*args, **kwargs)
        /usr/local/lib/python3.7/site-packages/click/core.py         : 717 : rv = self.invoke(ctx)
        /usr/local/lib/python3.7/site-packages/click/core.py         : 1137: return _process_result(sub_ctx.command.invoke(sub_ctx))
        /usr/local/lib/python3.7/site-packages/click/core.py         : 956 : return ctx.invoke(self.callback, **ctx.params)
        /usr/local/lib/python3.7/site-packages/click/core.py         : 555 : return callback(*args, **kwargs)
        /tmp/jsx                                                     : 225 : docker.jumpscale_install(branch=branch, redo=reinstall, pull=pull, wiki=wiki)
        /tmp/InstallTools.py                                         : 3230: self.sshexec("apt install python3-click -y")
        /tmp/InstallTools.py                                         : 3080: Tools.execute(cmd2, interactive=True, showout=False, replace=False, asfile=True)
        /tmp/InstallTools.py                                         : 1057: original_command=command,
        /tmp/InstallTools.py                                         : 1064: res = Tools._execute_interactive(cmd=command, die=die, original_command=original_command)
        /tmp/InstallTools.py                                         : 483 : % (original_command, returncode)

Mon 24 14:05:54 core.py          - 762 -                                    : EXCEPTION: ***ERROR EXECUTE INTERACTIVE:
Could not execute:ssh -oStrictHostKeyChecking=no -t root@localhost -A -p 9122 'apt install python3-click -y'
returncode:100

CANNOT CONTINUE

I added self.sshexec("ps aux | grep -i apt") before the failing line and it clearly shows the apt upgrade from the install is still in progress
root        83  0.0  0.1  18372  2904 pts/0    Ss+  07:24   0:00 bash -c apt update; apt upgrade -y; apt install mc git -y
root       458  0.4  3.0<PHONE_NUMBER>4 pts/0    S+   07:24   0:03 apt upgrade -y
root      6381  0.0  0.1   9916  2736 pts/2    Ss+  07:37   0:00 bash -c ps aux | grep -i apt
root      6383  0.0  0.0  11460  1060 pts/2    S+   07:37   0:00 grep -i apt
Connection to localhost closed.
E: Could not get lock /var/lib/dpkg/lock-frontend - open (11: Resource temporarily unavailable)
E: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), is another process using it?
Connection to localhost closed.
```

thanks @robvanmieghem can you please give us

the branch you are working on

the install command

a description of your configuration (virtual machine / macos /ubuntu ...)

master commit e1189167f86433fc27f0bf245d81617cab776b54
command: jsx container-install
on osx

@robvanmieghem could you retry using jsx container-install -d to force the container deletion prior to install?
I have re-run the master install on OSX and it seems fine.
The only way I managed to reproduce your error is when I force to stop the install while apt is still running (and hence the unreleased lock on /var/lib/dpkg/lock-frontend which provokes the corrupt state).

Looks like commit be428e7cdba78cf7f1f553d932d40752d334c751 fixed this

cherry picked it in commit 03c0c225d87fadc43b596479f83289e18dd5b476


Export to CSV

Actually only the changes this time. Sorry I'm bad at Github.

Looks good! (=

Thanks, I'm working on a couple other small changes that came from our group. Dumb things, will put them up in a pull for review when it's cooked.


Fix jobguard for when waiting on main branch

Description
Changes proposed in this pull request:

Fix job guard when waiting on build/image-push when running on main branch

Related issue(s)

/test pull-api-gateway-integration-test


[Add] flagpack

Site URL
flagpack.xyz
Description of the Resource(s)
flagpack  - API??
Category
Backend
Sub Category
api
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

idiot

this is good


New Architecture Support

Goal of this issue is to track new architecture support for Native Bottom Tabs.

Currently, prebuilds on new arch fails with unresolved references of SwiftuiTabviewViewManagerInterface and SwiftuiTabviewViewManagerDelegate

New Arch is gonna be stabilized soon, any updates on this?

@CodeWithShreyans Just started to work on it you can track the progress in #64


Make logging work on M1 Macs

Seems that the provider of our logging library doesn't provide a compiled library for this and isn't in any hurry to fix it:
https://github.com/MicroUtils/kotlin-logging/issues/220
Possible workaround: forcing Gradle to compile from source?
https://blog.gradle.org/introducing-source-dependencies

This was added here: https://github.com/oshai/kotlin-logging/pull/227


Allow to specify specific rds instances that should be monitored

These changes allow you to specify specific RDS instances that you want to have monitored. Instead of depending on the auto-discovery the cookbook has by default.
This PR also adds a bunch of chefspec unit tests for the changed behavior.
Unit test results:
Finished in 1.13 seconds (files took 1.48 seconds to load)
7 examples, 0 failures

The project uses serverspec, and you just introduced ChefSpec. So either:

Rewrite your new tests with ServerSpec
Rewrite the old tests with ChefSpec

Having 2 different test tools doesn't make sense.

The rest is LGTM.

LGTM


RuntimeException: Empty json body:  [200 - ] - https://api.tdameritrade.com/v1/marketdata/quotes?symbol=blahblah1

Hi,
Using:

<dependency>
   <groupId>com.studerw.tda</groupId>
   <artifactId>td-ameritrade-client</artifactId>
   <version>2.4.1</version>
</dependency>

TdaClient client = new HttpTdaClient();
ArrayList<String> symbols = new ArrayList<>();
symbols.add("blahblah1");
List<Quote> quotes = client.fetchQuotes(symbols);

causes:

Exception in thread "main" java.lang.RuntimeException: Empty json body:  [200 - ] - https://api.tdameritrade.com/v1/marketdata/quotes?symbol=blahblah1
	at com.studerw.tda.client.HttpTdaClient.checkResponse(HttpTdaClient.java:852)
	at com.studerw.tda.client.HttpTdaClient.fetchQuotes(HttpTdaClient.java:241)

The code should be able to handle a bad symbol without throwing a RuntimeException.
Thanks

@jschlade  You really think a developer would want to get back an empty response if they pass in a symbol that TDA can't find? I could kind of see this making sense for multiple symbol requests if only one of them is bad, but definitely not in the use case you described above. Otherwise, the dev might not realize that the symbol they've passed is invalid.


Roll engine 9f4341a2b869..ad14574949f5 (1 commits)

git@github.com:flutter/engine.git/compare/9f4341a2b869...ad14574949f5
git log 9f4341a2b869..ad14574949f5 --no-merges --oneline
2019-11-22<EMAIL_ADDRESS>Updated googletest to fix fuchsia build. (#13980)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5925913773998080

Commit queue failed; closing this roll.


Fix shared memory storage features and crates names mismatch

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 98.357%

Totals

Change from base Build<PHONE_NUMBER>9:
0.005%

Covered Lines:
55628

Relevant Lines:
56557

💛  - Coveralls


[nrf noup] scripts: update quarantine

squash! [nrf noup] scripts: add quarantine file
Signed-off-by: Piotr Golyzniak<EMAIL_ADDRESS>

Clang check required a fix, which was merged recently. Please rebase the PR to get the workflow properly triggered. Sorry for an inconvenience.

Quarantine was updated as a result of:

Solving problems with TF-M.
Applying g++-multilib into docker image.
Removing or changing some test names in upstream.
Other minor fixes.


Update sbt to 1.4.6

Updates org.scala-sbt:sbt from 1.4.4 to 1.4.6.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-patch

Codecov Report

Merging #117 (1118b51) into master (c5b8317) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #117   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           41        41
=========================================
  Hits            41        41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b8317...1118b51. Read the comment docs.


of mentions displayed is off

I'm building a scattertext document based on fairly small dataset (~100 responses). Everything seems to be working, except the mention count ("Not found in any " or "Some of the N mentions:...") is clearly incorrect. Any idea how I can debug the issue? I've investigated the corpus and nothing about the metadata (corpus.get_metadata_freq_df('')) seems off. When I try to do corpus.get_term_count_df(), the method call throws back a value error: ValueError: arrays must all be same length.
The number of mentions explicitly indicated by the scattertext document does not agree with the number of mentions that that actually appear when I search for a specific term (

The data is sensitive so I'd prefer not to expose the text in my screenshot // share the code explicitly.
Environment

Scattertext version: '<IP_ADDRESS>':
OS (OSX):
How you installed Scattertext (conda):
Build command you used (if compiling from source):
Python version: 3.9

I'd recommend making sure you're using the latest version of Scattertext.
If that doesn't solve your issue, please include both runnable code and a data set that replicates this term miscount along with an example of what you'd expected to see for a given term and what's happening.

Closing due to inactivity


Data set

Hello,
my question about Dataset, which data set you to use to train chatlearner and where i get the dataset. and any tips to process data
thanks

It is the Papaya Data Set included in this project. Please check README.


Full screening embedded video does not work when scrolled down in notifs

Describe the bug
When scrolled down at least a page or more of view height in the notifs, attempting to full screen an embedded video in a reply completely breaks. It scrolls all the way up and then immediately breaks the embed after it goes off screen which then cancels the fullscreen which makes for a weird flicker effect.
To Reproduce
Steps to reproduce the behavior:

Have a lot of notifications
Somewhere down the way, have a reply with an embedded video
Attempt to fullscreen that video
Observe

Expected behavior
This to not happen.
Screenshots

Details

Platform: Chromium web
Platform version:
App version:

Additional context

I think this is fixed coming up, reworked how the measurements work for the embeds. Please let me know once 1.69 is released!

I think this is fixed coming up, reworked how the measurements work for the embeds. Please let me know once 1.69 is released!

Will do!

@haileyok Forgot to update but issue still persists. Seems to be not just notifications. Example post where it does it: https://bsky.app/profile/cirikino.bsky.social/post/3ko4rfy4g2t25

Thanks for updating me on this. Really annoying situation, will have to do some digging to find a good solution.


Ubuntu *.deb issues (GLIBC)

Hi @lelegard!
Thank you for the great app, it's really DVB rocket!
I've got some issues, so maybe you can share your thoughts here.
I took recent https://github.com/tsduck/tsduck/releases/download/v3.14-894/tsduck_3.14-894_amd64.deb and the installation was OK on my oldie Ubuntu 14.04.3 LTS and Ubuntu 16.04.1 LTS.
Next, both systems TSDuck was failed to run with the following:
tsp: /usr/lib/x86_64-linux-gnu/libcurl.so.4: version 'CURL_OPENSSL_4' not found (required by /usr/bin/tsduck.so)
tsp: /lib/x86_64-linux-gnu/libc.so.6: version 'GLIBC_2.27' not found (required by /usr/bin/tsduck.so)
I google it and fond out that GLIBC_2.27 is the most recent core Unix C-Library provided in Ubuntu 18.XX version starting Feb 2018. Not sure about CURL_OPENSSL_4 but I guess the reason is the same.
I was wondering if you could please rebuild binaries inside of *.deb package with backward-compatibility of Ubuntu 14.04  (uses GLIBC_2.19) or Ubuntu 16.04  (uses GLIBC_2.23)
Thank you!

Hello @dkashin,
The provided .deb packages are built on the latest Ubuntu version (18.04). I am not surprised if the libraries are not compatible in previous versions. I am just a bit surprised that the installation succeeded.
I currently provide binaries for the latest versions of Windows, Fedora, Ubuntu, Raspian and macOS. But, as a free open source maintainer, I do not have the resources to build on several older versions. But, like most open source projects, providing pre-built binaries is just a facility. Everyone is able to rebuild the binaries on any platform.
For TSDuck, this is explained here. You can download the source archive of the latest version here. In the case of Ubuntu 14 or 16, building the binary packages is as simple as:
sudo apt-get install g++ dpkg-dev doxygen dos2unix graphviz curl pcscd libpcsclite-dev libcppunit-dev libcurl3 libcurl3-dev
make deb

The first command installs the prerequisites, if not already done on your system. The second one builds the binaries.

Thank you for fast reply!
Correct, I did everything you said with installing gcc/g++/curl elements from command above.
My config and output:
Ubuntu 14.04.4 LTS (GNU/Linux 4.2.0-27-generic x86_64)
root@tc01:~/tsduck/tsduck-3.14-894# gcc -v
Using built-in specs.
Complete output of GCC: tsduck_err.txt
root@tc01:~/tsduck/tsduck-3.14-894# sudo make
[CXX] tsPacketizer.cpp In file included from tsEnumeration.h:36,                  from tsMPEG.h:38,                  from tsPacketizer.h:36,                  from tsPacketizer.cpp:34: tsUString.h: In member function 'std::basic_string<char16_t>::iterator ts::UString::erase(std::basic_string<char16_t>::const_iterator)': tsUString.h:1799:84: error: no matching function for call to 'ts::UString::erase(std::basic_string<char16_t>::const_iterator&)'          iterator erase(const_iterator position) { return SuperClass::erase(position); }                                                                                ^
Please advise.

Strange. How did you install gcc? Probably not using the standard Ubuntu repositories.
You have GCC 8.1.0 on Ubuntu 14.04.4 LTS while the standard GCC version is 4.8 for this Ubuntu (see here).
The most recent Ubuntu (18.04.1 LTS) has GCC 7.3.0.
Note that TSDuck compiles fine with GCC 8.1 since Fedora 28 has GCC 8.1.1 and TSDuck works fine there.
The oldest GCC for which TSDuck is built is 4.8.5 on CentOS 7.5.
Anyway, there is something unusual with your GCC installation on Ubuntu 14. I cannot answer this issue. But I suggest that you come back to a standard installation to make sure that everything is compatible: operating system, compiler and libraries.

Yes it seems strange. I upgraded GCC from side official repository and it seems working good.
On Ubuntu 16.04 I have GCC 5.4.4 and TSDuck build was flawless. I guess I need to upgrade to Ubuntu 16.04+ anyway. Thank you for your help here! :)


Menu update

It will be better if the menu is centred or right aligned. I think right aligned could work because it will be close to the menu icon...

I will do this and other fix also..if you say..


Add Jobservice bench maxThroughput for noop

What changes are proposed in this pull request?
Add Jobservice bench maxThroughput for noop
Why are the changes needed?
Please clarify why the changes are needed. For instance,

If you propose a new API, clarify the use case for a new API.
If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including

change in user-facing APIs
addition or removal of property keys
webui

Codecov Report

Merging #14193 (40eaa03) into master (fb1f1b8) will decrease coverage by 25.92%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #14193       +/-   ##
=============================================
- Coverage     43.20%   17.27%   -25.93%
+ Complexity     9195     2701     -6494
=============================================
  Files          1426     1438       +12
  Lines         82550    83305      +755
  Branches       9986    10073       +87
=============================================
- Hits          35663    14392    -21271
- Misses        43919    67655    +23736
+ Partials       2968     1258     -1710

Impacted Files
Coverage Δ

...ava/alluxio/master/PollingMasterInquireClient.java
0.00% <0.00%> (-48.06%)
:arrow_down:

...alluxio/metrics/sink/PrometheusMetricsServlet.java
61.53% <0.00%> (-11.19%)
:arrow_down:

...src/main/java/alluxio/job/plan/NoopPlanConfig.java
0.00% <ø> (ø)

...main/java/alluxio/job/plan/NoopPlanDefinition.java
0.00% <ø> (ø)

...alluxio/cli/fs/command/DistributedLoadCommand.java
0.00% <0.00%> (ø)

...a/alluxio/cli/fs/command/DistributedLoadUtils.java
0.00% <0.00%> (ø)

...io/stress/jobservice/JobServiceBenchOperation.java
0.00% <0.00%> (ø)

...o/stress/jobservice/JobServiceBenchParameters.java
0.00% <0.00%> (ø)

...ess/jobservice/JobServiceMaxThroughputSummary.java
0.00% <0.00%> (ø)

...java/alluxio/stress/cli/StressJobServiceBench.java
0.00% <0.00%> (ø)

... and 704 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 093abac...40eaa03. Read the comment docs.


require_java8 function not  defined in the bin/ruby_build script

I was trying to install jruby-<IP_ADDRESS> using rbenv and and error occurred stating
/usr/local/bin/../share/ruby-build/jruby-<IP_ADDRESS>: line 1: require_java8: command not found
I believe if this function is defined, the installation can proceed further.
Can I contribute to this issue by defining this function in the script?
Originally posted by @develop-build in https://github.com/rbenv/ruby-build/commit/7a70a2e35ace611efcd9d4e4cf759484ca3c47b7#commitcomment-31020980

I have realized that commit 7a70a2e was reverted back.
bin/ruby-build now has require_java7

I will add require_java with version argument later.


Change title to NUSocials for app window and jar file

Changed jar file generation to NUSocials.jar
Changed app window title to NUSocials

Codecov Report

Merging #55 (bbff187) into master (99270aa) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #55   +/-   ##
=========================================
  Coverage     64.56%   64.56%
  Complexity      491      491
=========================================
  Files            96       96
  Lines          1820     1820
  Branches        222      222
=========================================
  Hits           1175     1175
  Misses          574      574
  Partials         71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99270aa...bbff187. Read the comment docs.


Signing problems in version 1.3 and 1.4

Problems when upgrade to version 1.3 or 1.4 i get this runtime exception:
Could not load file or assembly 'AsyncFriendlyStackTrace, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=f5fdf019656607c4' or one of its dependencies. Strong name signature could not be verified.  The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key. (Exception from HRESULT: 0x80131045)
Looks like a signing issue, and sn.exe also say that the assembly is not valid:

C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Bin>sn -vf C:\Temp\AsyncFriendlyStackTrace.1.4.0\lib\net45\AsyncFriendlyStackTrace.dll
Microsoft (R) .NET Framework Strong Name Utility  Version 3.5.30729.1
Copyright (c) Microsoft Corporation.  All rights reserved.
Failed to verify assembly -- Strong name validation failed for assembly 'C:\Temp\AsyncFriendlyStackTrace.1.4.0\lib\net45\AsyncFriendlyStackTrace.dll'.

Running .net 4.5.1

Hi. How are you getting this error? I've tried loading the assembly from another strongly signed assembly and it worked. I'm not sure how signing works in project.json projects.

Hi, Im not using project.json project, but a normal .net project 4.5.1 in Visual studio 2015. Our project and libs are not signed. I had tried to remove the publicKey from my project reference to your AsyncFriendlyStackTrace.dll but with out help, it look like the runtime want to check/validate the assembly it loads.

Can you produce a repro? It works for me.

Its our xunit test that throw this exception, and we had not problems with other 3rd party libs that also is signet in our test.
Here is the test class:
public class TestClass
{
    [Fact]
    public void Test()
    {
        try
        {
            ThrowExceptionMethod().Wait();
        }
        catch (Exception e)
        {
            var str = e.ToAsyncString();
        }
    }

    private static async Task ThrowExceptionMethod()
    {
        await Task.Run(() =>
        {
            throw new Exception("fdsf");
        });
    }
}

With hint from this github issue i disabled shadow-copy in reshapper and then the test pass. But why is your assembly special? we had over 40 other nuget reference and many of them is signet and had no issues when run them from xunit.

Thanks for the good work. Unfortunately I see the same warning.
1>------ Publish started: Project: XXXAPI, Configuration: Debug Any CPU ------
1>Connecting to D:\inetpub\wwwroot\XXXAPI...
1>Copying all files to temporary location below for package/publish:
1>obj\Debug\AspnetCompileMerge\Source.
1>C:\Windows\Microsoft.NET\Framework\v4.0.30319\aspnet_compiler.exe -v \ -p D:\XXX\obj\Debug\AspnetCompileMerge\Source -u -c D:\XXX\obj\Debug\AspnetCompileMerge\TempBuildDir
1>ASPNETCOMPILER(0,0): Error ASPCONFIG: Could not load file or assembly 'AsyncFriendlyStackTrace, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=f5fdf019656607c4' or one of its dependencies. Strong name signature could not be verified.  The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key. (Exception from HRESULT: 0x80131045)
1>
========== Build: 0 succeeded, 0 failed, 2 up-to-date, 0 skipped ==========
========== Publish: 0 succeeded, 1 failed, 0 skipped ==========

Hmm. Not sure what to make of this. Can anyone please try compiling the project and verifying the problem still exists?

@aelij when you have merged and released a new nuget package, let me know in this thread.

The package has been pushed (v1.4.1). Thanks everyone.


fix typo in pilot.go

authenication -> authentication

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @eltociear. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


[WIP] Baggage

What this PR does / Why we need it
Work on adding Baggage checkin in backend.
Some questions

[x] I have read the contributing guidelines
[x] I abide by this repository Code of Conduct
[x] I understand that my PR won't be merged until Travis gives a "green light"

Problema amb migrate:
django.db.utils.ProgrammingError: relation "baggage_move" does not exist

Fixes #42, #43


Send proposal to DAO for Ops

Using this template
https://github.com/dOrgTech/Ops/blob/master/proposals/dsp-1.md
Summary
Three roles

Accounting
Facilitation
Communication

Why should we fund this?
This will be a new approach to tackle the internal ops resposibilities by assingin lead roles to avoid the diffusion of efforts and separate  in specific operation areas.
Anything else you'd like to add?
The tasks will be recorded at the Ops Repo
The leads for each role will be as follows

Accounting: Magenta
Facilitation: Ori
Communication: Roberto

Accounting : Maintain and improve systems for keeping dOrg’s finances and transactions healthy and transparent
Facilitation:
Focus on ways to continuously enhance the dOrg builder experience
Communication:
Keep dOrg’s external relationships and communication channels lively and growing
Set a timeframe:

9 weeks (Until January 4th)

Cost
$900 / week ($300 / week per role)

https://alchemy-xdai.herokuapp.com/dao/0x94a587478c83491b13291265581cb983e7feb540/proposal/0xc15fdc2efa9f47a243e75be36889629f0467dcbb4883e77f64286bb3bee5a476


Post-testing GSSAPI edits

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/7b34190fe40f6d25cc274653dd21219d9f354de1/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/7c80db658258f8b1d3221a22d052cf8764f7e04b/

v19.1/gssapi_authentication.md, line 84 at r1 (raw file):
Previously, rolandcrosby (Roland Crosby) wrote…
That seems fine. You're right that the tables/DBs have to exist; maybe you could just show like GRANT ALL ON DATABASE defaultdb TO carl?

Done.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f789f003da8e08ab001c0daa0bd3cd6d63b8069d/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/2ec85d4ce9510afcaa9b3fbff965be4162007c5b/

@jseldess Ready for your review!

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3c7aeb484e0dcdd71df97af05056bd1327c56b29/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/6c981d7a4cbf57d48fd9970cd076bc59a9de9289/


TBOX-186 Update exception caught to be requests.exception.ConnetionError

↪ Pull Request
Changed exeption in get_with_connection_error function from python ConnectionError to requests.exception.ConnetionError
✔ PR Todo

[ ] Add documentation
[ ] Add examples
[x] Ensure you are following the practices in the contributor guide and coding_standards

Use consistent and descriptive name conventions
Uses google-style docstrings
Uses versioned API/client methods only
Avoid global variables
Avoid giant try/catch
Don't use mutable default variables
Use a main() function in your scripts

[x] Added/updated testing for this change (ensure you are testing any changes/new code!)
[x] Update title to link to TBOX issue (i.e. start pull request title with TBOX-xx)
[ ] Approval from first code-reviewer
[ ] Approval from second code-reviewer (only required if a second reviewer has left comments)
[ ] Pass all checks

The last three commits should be identical. I accidentally committed the last two because Git was claiming to be unable to push.

It looks like the only thing left is to make sure linting passes.  I think your IDE might be limiting line length too aggressively.  This codebase enforces a max line length of 99, specified in .flake8.  You should be able to apply the needed formatting changes automatically by running invoke format --fix.

I added the 'os.remove on possible existing file path' in the last commit. I think this may be why it previously failed the Test-Windows (3.6)

I added the 'os.remove on possible existing file path' in the last commit. I think this may be why it previously failed the Test-Windows (3.6)

It's a good thought, but it looks like it still is failing on Windows.  This is probably a strange issue I've seen before here: https://github.com/skalish/tamr-toolbox/blob/f625883cc6c72b9a96be3d3f75e2992c9143871f/tests/utils/test_logger.py#L32-L54.
The solution is to not use the context manager and instead start your test with
    # Create temp directory. Remember to cleanup!
    tempdir = tempfile.TemporaryDirectory()

then end your test with
    # Cleanup temp directory
    try:
        tempdir.cleanup()
    except (PermissionError, NotADirectoryError):
        # Windows sometimes fails so try one more time
        tempdir.cleanup()

This looks good to merge!  Great work!  Go ahead and click "Squash and merge" whenever you're ready.


dendritic spine cytoplasm

I would like to see "dendritic spine cytoplasm” added to the GO ontology under the part_of parent term "dendritic spine” (GO:0043197) and the is_a parent term “cytoplasm” (GO:0005737).  The definition could be "The region of the neuronal cytoplasm located in dendritic spines.” Example can be found in PMID:15673667.

Also changed the logical definition of dendrite cytoplasm to give more automated inferences.
name: dendrite cytoplasm
namespace: cellular_component
def: "All of the contents of a dendrite, excluding the surrounding plasma membrane."  [PMID:15673667]
+intersection_of: GO:0005737 ! cytoplasm
+intersection_of: part_of GO:0043197 ! dendritic spine


Quilljs parser and render

Changes:

Quill Parser QuillParser
Quill  Renderer QuillLabel

Really nice work on this - appreciate adding the tests as well, and separating out the styles to make it easily configurable. I may ask in the future to allow line-height to be configurable on a per-header basis, but for now the 1.2 multiple is great.


Can docker in docker be offloaded to another server?

🔖 Need
The docker in docker situation is hogging a lot of resources which can potentially run externally outside the backstage backend deployment
techdocs:
  builder: 'local'
  generator:
    runIn: 'docker'
    dockerImage: 'spotify/techdocs'
    pullImage: true
  publisher:
    type: 'local' # Alternatives - 'googleGcs' or 'awsS3'. Read documentation for using alternatives.
    local:
      publishDirectory: '/Users/username/backstage_docs/'

🎉 Proposal
Can the docker be deploy outside the container where the backend is running?
techdocs:
  builder: 'external'
  generator:
    externalURL: 'https://url-for-the-pod-to-receive-data'
    runIn: 'docker'
    dockerImage: 'spotify/techdocs'
    pullImage: true
  publisher:
    type: 'local' # Alternatives - 'googleGcs' or 'awsS3'. Read documentation for using alternatives.
    local:
      publishDirectory: '/Users/username/backstage_docs/'

〽 Alternatives
None
❌ Risks
N/A
👀 Have you spent some time to check if this RFC has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Can you expand a little bit on why the existing googleGcs or awsS3 options don't work for your use case? Offloading the work onto another docker pod sounds a lot like the CI solution described here, https://backstage.io/docs/features/techdocs/configuring-ci-cd.
In the interim, take a look at these docs, https://backstage.io/docs/features/techdocs/getting-started#disabling-docker-in-docker-situation-optional. They may help the resource usage.

@sennyeya The documents aren't indexed properly for searching capabilities(or I might have missed a step). But they become read-only which involves additional configuration on the CI (Like : running CI pipeline on every change to generate the docs) where the documents are being generated. I was thinking of a solution where we can have the best of both worlds without additional configuration required

@hybridx I think there's hidden complexity in outsourcing the generate task to a pod though, specifically, where do we store the files? In the case of local, we can add them directly to the host's file system, but in an external context we need a middleman to cache/store the files after processing. That ends up being where S3/GCS would probably come into play. All that to say, I think a CI-based solution would fit better for your use case.
Happy to help walk through config help on discord if needed.


set is_hot upon MouseDown if the target is not already hot.

I'm not sure about this, it seemed tricky to get right in examples/slider
is it correct that we may change child_ctxt but shouldn't recurse?
Anyhow the behavior this patch tries to change is that on at least gtk, if you
start the application, and the mouse is already hovering over a button, and click it without moving the mouse.
Basically because the mouse never moved, the widget is not hot, and it gets ignored by button.
I tried to fix this by setting is_hot, if it isn't already.

Alright, I think that is as clear as I can make the code reflect the intent.
The other alternate way to do this would be to add something to the platform backend druid-shell to get the current mouse position on startup, and make the widget under the cursor hot there, instead of doing so in the event loop, this might be better visually as the widget would then be bordered immediately, but did seem like a lot more work I don't know how to do on most platforms.

@raphlinus can you take a peek at this?

@cmyr should I rebase it onto master?  There shouldn't be any conflicts as is, but either way let me know.

Nope this is fine, I can do a one-click 'rebase and merge'. Thanks!


fix: replace deprecated addListener for oslightdarktheme

Description
The oslightdarktheme recipe uses the deprecated javascript function 'addListener'. It's replaced by the recommended 'addEventListener' function.
Fixes # (noissue)
Type of change

[x] Bugfix
[ ] Feature

Checklist

[x] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
[x] I have added a description following the guideline.
[x] The issue is created in the corresponding repository and I have referenced it.
[-] I have added tests to ensure my change is effective and works as intended.
[x] New and existing tests are passing locally with my change.
[x] I have performed self-review and corrected misspellings.

Additional for Feature type of change

[ ] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

That was fast. Thank you!


Registration Form

Requirement
A. Create registration form with the following fields

Username
Name
Email
Contact
Address
Password
Picture

Registration form done


Embedding the last url when multiple urls are present in the content.

When the content has more than one url, the last url is embedded. Is there any option to embed the first url ?

Currently there isn't.


[Android] Add "pseudoRef" and "itemClick" in Constants.

No JIRA issue needed.

Where will you use these two variables?


Conversion in progress... stuck?

Environment
Microsoft Windows [Version 10.0.19041.264]
Converting from WSL 1 to WSL 2
Steps to reproduce
wsl --set-version Ubuntu 2, --set-default-version 2
Expected behavior
Conversion says its should take a few minutes
Actual behavior
Conversion has now been running for nearly an hour and no sign of activity.
I have checked in a seperate window and it does report that it's still converting.
C:\WINDOWS\system32>wsl -l -v
  NAME                   STATE           VERSION
* Ubuntu                 Converting      1
  docker-desktop-data    Running         2
  docker-desktop         Running         2

Is there any way to check on the actual progress, could I have something in my environment which is either taking a long time or has hung?
I obviously don't want to kill the upgrade as that could cause me to loose all of the work I have in WSL.

Use task manager and see if vmmem is doing any disk activity (the 'Disk' column of the 'Processes' tab). Unless it has totally flatlined, give it as much time as you can stand. Have a look at memory as well, you might be hitting #4669.

Wasn't doing too much disk access but was using 36GB or RAM.
Its just finished so did it did work, but it took 2 1/2 hours.

Closing as duplicate

The title of this issue says it all: Conversion in progress... stuck?
Please consider reopening this issue with the intent of impementing some kind of progress bar.
Slow progress may be caused by insufficient ram #4669 or Antivirus/Window Defender or anything else. But that does not imho make this issue a dup.

I'm updating WSL to WSL 2  wsl --set-version Ubuntu 2 and it's been two hours already. And when I type command wsl --list -v this shows me an error server execution failed. What tf does this means?  Since all of your mentioned the slow progress but not the error at all, am I really stuck?? Thanks for your help.

I'm updating WSL to WSL 2  wsl --set-version Ubuntu 2 and it's been two hours already. And when I type command wsl --list -v this shows me an error server execution failed. What tf does this means?  Since all of your mentioned the slow progress but not the error at all, am I really stuck?? Thanks for your help.

Depending on how large your root file system was, it can take a decent amount of time. it took me about 30 minutes to convert from WSL 1 => WSL 2.

Depending on how large your root file system was, it can take a decent amount of time. it took me about 30 minutes to convert from WSL 1 => WSL 2.

are you sure that it takes 30 minutes or so? Cuz in my case, it never got completed

Yes, it's got completed within 30-40 mins I guess.
Actually, this problem was face by many folks/developers out there, so I think you're not the only one.
Read this thread, you'll understand : Reddit - WSL 2 conversion taking too long
I hope it helps :)

It is faster to install a GNU/Linux distribution in WSL2 than converting from WSL1 (ext4 >>>> NTFS).

There was some discussion of a progress indicator in #5403 (message) ⬅ #5344. Closest thing on the books is #5161.

It had sucked almost one hour and when I was taking a screenshot to post here, it suddenly finished! So I posted the result here to stimulate more patience.
However. The official prompt for the conversion should be warning users that it will takes dozens of minutes rather than some minutes!

Hey all, I left it overnight and am still having STATE: Installing. This is on a work computer which heavily utilizes One Drive. Could this cause the install to be even slower?

It takes me over 3 hour, and it still has not finished yet

I had wsl console (from windows/system32) open in the background (didn't notice) when I started the update in PowerShell. It was running good 30 minutes when I noticed that the wsl console was displaying a message that it's terminated. But wsl didn't close. It kept consuming 20% of the CPU. Disk usage was on 0. I couldn't kill the wsl process any way I tried so I just restarted my laptop and updated in 5 minutes (or less idk).

After about half an hour of Vmmem maxing out the CPU and 8 GB of RAM, memory usage eventually dropped back down to 1 GB.
I almost have up, seeing as there was apparently no CPU activity and no output on the console - but after 10-15 minutes of inactivity, the command finally returned with "conversion complete".
Yeah, there ought to be a progress indicator of some sort for an operation this long.

After about half an hour of Vmmem maxing out the CPU and 8 GB of RAM, memory usage eventually dropped back down to 1 GB.
I almost have up, seeing as there was apparently no CPU activity and no output on the console - but after 10-15 minutes of inactivity, the command finally returned with "conversion complete".
Yeah, there ought to be a progress indicator of some sort for an operation this long.

So I don't know what it's worth but I was stuck for a little while and I simply dragged the Powershell Window into another of my screens and suddenly the conversion was complete ... weird coïncidence may be? But may be it could help other ppl so I have to tell you guys.

While trying to import a 5GB tar file, wsl consistently fails saying "Importing distribution failed" after like 10 minutes trying to convert. Interestingly, when I try to import via LxRunOffline and then try to convert to wsl2, it fails again, with the same error message "Importing distribution failed."

On my machine it says vmmem is suspended, using no memory. Perhaps that's why the conversion is not taking place?

it consistently gets stuck, I let it run for 36 hours multiple times:

at the start, there's some CPU/Disk activity for about 30 mins

VmemmWSL stacks up to 800MB of RAM
I can see bsdtar working

Past that point, it just gets stuck with absolutely no CPU/disk activity, and can remain in this state forever
I've tried disabling Windows Defender real time protection, but it doesn't help.

@syffs hey did it got solved

@arnavmehta7 no, I gave up for now... wsl is a tool for me, can't spend hours/days setting up my tools, delaying the actual work.

Ctrl + c to terminate the process, restart the system, and then try conversion again fixed the issue. It finished in less than a minute after the restart. I was trying to convert from version 1 to version 2 wsl --set-version Ubuntu 2

Same problem here on a 32GB machine and windows 11. I've stopped it after 3 DAYS of conversion. with dots that was coming.. I've restarted it now disabling firewall to see if helps. However a percentage of completition would be useful..

Adding another piece of anecdata - I hit this issue as well. Was waiting for about 30 minutes with no apparent activity in Task Manager.
I pressed CTRL+C to quit the process, restarted laptop, ran wsl.exe --set-version Ubuntu 2 in an Admin Powershell and it completed in two minutes.
I made sure not to start the WSL1 version before doing this, so not sure if it made a difference.
But yes, a progress bar would be nice. :)

WE NEED A PROGRESS BAR!

Mine was running for a while with very little disk activity. In another window I ran wsl --list -v which showed 1 instance running and one instance converting. I then ran wsl --shutdown which caused my first window to output:

Exporting the distribution failed.
Error code: Wsl/Service/WSL_E_EXPORT_FAILED

I've started the conversion again and it's showing heavy disk usage so looks like it is working now.

I figured a way to heuristically measure the progress of this: you can run a du -sh in your Linux root to get its size, and note the size of your C: drive before running the set-version. Then when you start the conversion which basically creates a new FS copying the entire Linux structure. By the amount of extra storage being consumed in C: drive compared to initial you can guess the progress.
For example, if my Linux system had an original size of 8G, and my C: drive had 32G left in the beginning, and during the process 27G is left, the progress so far is (32-27)/8 = 62.5%

I'm sorry, but the mention of Conversion in progress, this may take a few minutes... is no longer applicable at all. Better check in advance how much space there is and available RAM to give a better indication of the duration,
So that you can still cancel it or start at a later time (after the working day...).

I figured a way to heuristically measure the progress of this: you can run a du -sh in your Linux root to get its size, and note the size of your C: drive before running the set-version. Then when you start the conversion which basically creates a new FS copying the entire Linux structure. By the amount of extra storage being consumed in C: drive compared to initial you can guess the progress.
For example, if my Linux system had an original size of 8G, and my C: drive had 32G left in the beginning, and during the process 27G is left, the progress so far is (32-27)/8 = 62.5%

Even better, you can watch the VHDX file being built in this location (though I'm not sure if it's exactly the same hash for everyone):
C:\Users\{YOUR USER}\AppData\Local\Packages\CanonicalGroupLimited.UbuntuonWindows_79rhkp1fndgsc\LocalState
Separately, I came across this issue initially because of the hang but found there were 2 things happening which were going to cause issues with it ever finishing:

I'd downgraded from WSL2 to WSL1 at one point, but there was a lingering VHDX file in that location from the downgrade, and
I ran out of disk partway through the operations, and despite quickly freeing up space, the VHDX completely stopped growing despite there being no indicator on the command line that there was an error.

Much more messaging for this operation would be helpful, both in progress tracking and in communicating errors.  It's so opaque as it stands today.

tl;dr
In my case, no conversion was needed. I've just updated (wsl --update) to the newest version (wls --version = <IP_ADDRESS>) and downloaded the distro from scratch (wsl --install -d Ubuntu-22.04). The downloaded distro was already of v2 (check it with wsl -l -v).
Long story

My first problem was, that I launched upgrade (wsl --set-version <distro> 2) without ensuring, that WML is stopped.
Then I've found out, that the wsl itself should be also updated.

wsl --update
wsl --shutdown
wsl --set-version <distro> 2

Then the conversion finally started, but there was really no CPU load on vmmem.
I killed the process.
Checked my disk space - only few MBs left.
I deleted some apps to have few GBs available.
I've deleted the old  by first uninstalling it with "Add Remove Programs" and then by subsequent call to wsl --unregister <distro>.

Then I've read somewhere, that it's possible to download  ready for WSL 2.
I've checked version of my wsl installation (wsl --version). It was already <IP_ADDRESS> (probably upgraded by previous call to wsl --update).
After all this, I've decided to install Ubuntu-22.04 (wsl --install -d Ubuntu-22.04), which was already of v2.
> wsl -l -v
  NAME            STATE           VERSION
* Ubuntu-22.04    Running         2


Mention uniqueKey requirement for highlighting

This one is hard to catch because there's no error if you set hl=on and there's no uniqueKey. You just don't see a highlighting element in the response.
I didn't think a Jira is required for this small change. I did test my changes with ./gradlew buildLocalSite so the link to the schema page works.

Out of curiosity, do you think an error message by solr should be thrown?  I sort of wish there was a way to know when your query structure doesn't make sense....
I

what happens if you don't have a uniqueKey?   I wonder if we need to change the wording to be "highlighting only works if you have a uniqueKey"

@epugh yes, I think an error would be nice. I mean, if I ask for highlighting and it can't be done, I expect an error. But I guess that's a separate issue.
If uniqueKey isn't there, there's no trace of highlighting whatsoever. It's as if I didn't ask for it at all. And nothing in the logs (at least not with the default INFO level).
I'm not sure how to change the wording to "highlighting only works if you have a uniqueKey" - I suppose that wouldn't be in the parenthesis I added, but maybe in another spot? To be, the current wording is OK, but we can definitely change it if you prefer something else.

@radu-gheorghe what do you think of this edit I made?   If you like it, I can merge this, and if you don't, I can back it out!

Looks perfect to me. Thanks @epugh!


doc: intel_s1000_crb: add picture and link

Add a picture of the kit and a link with more information about the kit.

Codecov Report

Merging #11990 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11990   +/-   ##
=======================================
  Coverage   48.13%   48.13%
=======================================
  Files         281      281
  Lines       43425    43425
  Branches    10406    10406
=======================================
  Hits        20902    20902
  Misses      18368    18368
  Partials     4155     4155

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e7c916...89c2ba8. Read the comment docs.


Add milkomeda algorand mainnet

Network Name: Milkomeda Algorand Mainnet
New RPC URL: https://rpc-mainnet-algorand-rollup.a1.milkomeda.com
Chain ID: 2002
Currency Symbol: mALGO
Block Explorer URL: https://explorer-mainnet-algorand-rollup.a1.milkomeda.com/

Solves: https://github.com/safe-global/safe-deployments/issues/133
Thanks folks :)

Hi @pkakelas could you fill the following form to create the issue and link it with the PR?
https://github.com/safe-global/safe-deployments/issues/new?assignees=&labels=[enhancement]&template=new_chain.yaml&title=[New+chain]%3A+

Done!

Arghh sorry my bad! @moisses89 fixed it :)


Fix #121: Added missing busybox-suid package to Alpine 3.3 and edge

More details are available in the issue #121.

imho it's better to not include bbox-suid in the base image.
if it's in the base image, then i just have to remove it, and
that makes the resulting image larger via layers.
if somebody needs it, the person can add it to their docker image.
there is a discussion beginning at http://lists.alpinelinux.org/alpine-aports/1881.html
in which it was proposed...

If alpine is run as a chroot or docker container or likewise installation , which is no longer uncommon these days, having suid binaries included in installation should no longer be required and is imo quite undesirable if you think about security.

the patch to split the packages is at
http://lists.alpinelinux.org/alpine-aports/1809.html

The original issue was of privilege escalation from a non-root user. What would be the test to solve this issue?

@jumanjiman What are the security issues about this particular bbsuid file? I'm especially interested to here what it can cause in Docker. From my perspective, in this particular case it is completely secure, it has ---s--x--x permissions, so nobody, but root can even read it. If you give a Docker container to run as root, having this small bbsuid binary (9944 bytes, BTW), won't make any difference. On the other hand, if you give a regular user access, the user won't make more harm than on a standalone Alpine Linux (if, for example, there would be a vulnerability in the code of bbsuid), thus it must be patched anyway.
busybox-suid package adds only 0.028MB to the total size of the image:
alpine-bbsuid      latest             014f8d3149c7        6 seconds ago       4.822 MB
alpine             3.3                74e49af2062e        34 hours ago        4.794 MB

I might agree on not adding busybox-suid to the base image (though, I have a little vote here) if there would be added a good documentation of this "feature", and, ideally, the error message ("su: must be suid to work properly"), running su, should be also improved to something pointing to busybox-suid package (since its name is not so obvious when you hit the issue running su command).
Nevertheless, I'm still interested in the real-life examples where bbsuid must be avoided.
Thus, on the one hand, we have good user experience (no regression upgrading from 3.2) + 0.028MB increase of the base image size, and on the other hand, we introduce a regression in the behaviour on upgrade from 3.2 to 3.3 because of a fear of an unknown (at least to me) vulnerability.

The original issue was of privilege escalation from a non-root user. There is a test for it which does pass on edge and 3.3 with the newer patched BusyBox (the original patch was incomplete and it was fixed before 3.3 release). What would be the test to solve this as a separate issue?

to me, the inclusion of bbsuid is completely separate from https://github.com/gliderlabs/docker-alpine/issues/101

If you are adding users to the image with a RUN command I would think it wouldn't be too much overhead to just compound apk --no-cache add busybox-suid to that command.

agree 100%

ideally, the error message ("su: must be suid to work properly"), running su, should be also improved to something pointing to busybox-suid package (since its name is not so obvious when you hit the issue running su command).

the potential breakage in usability was ack'd in the upstream alpine thread.

should bbsuid be in the base image?
it's a question that has many subtle answers.
if we boil it down to simplicity and economics, i would argue that it's easier to add bbsuid for the rare instance when one actually needs it than to remove bbsuid in the vast majority of cases where bbsuid is not needed for an app.
it's also important for compliance in regulated industries, especially with the abundance of breaches and corresponding attention to audits and compliance.
auditors always ask for a list of suid binaries in every deployment, and they follow that up with questions about the need for those bins. from the perspective of simplicity, it's easy to describe that we simply do not have suid binaries in our images. then we can focus on the unusual cases where suid is needed, and we can document in version control why the suid is necessary.

there is another aspect, too. it involves the conversation with junior devs and mgmt around security audits of new container images.
"why should we remove that package? if it weren't important, it wouldn't be part of the base image."
it's much more informative to have a discussion with somebody about how bbsuid enables a functionality that their app requires, rather than have friction about why they don't need bbsuid. (it's easier for somebody to understand how something explicitly helps them, as opposed to talking about ghostly potential vulnerabilities.)

I'm fine with installing busybox-suid myself. Hopefully, those who will bump into the issue will quickly find this thread and will know that they need to install busybox-suid themselves.

Hopefully, those who will bump into the issue will quickly find this thread and will know that they need to install busybox-suid themselves.

ack, and thanks for opening the issue.
it helps to establish the conversation.