make DOTENV setting more robust

While adding django-configuratons to a big project that I'm working on I've noticed a few issues with DOTENV implementation and this PR focuses on fixing them, while still allowing for the old way of doing this. They are:

always failing if DOTENV file is not found (this was faulty due to CI not having this .env)
using setdefault to load variables (this was faulty because in a big project a lot of environmental variables come from a lot of sources and it's sometimes desirable to override them via DOTENV)
DOTENV not reloading on hotreload (this is annoying when you have to restart a docker container to see any changes that you've made in DOTENV)

Than ks for. the contribution and sorry it has taken so long for this to be reviewed. Can you add a small unit test to the tests/test_env.py for using the DOTENV as a dictionary?

Oh wow. I completely forgot about this PR, but I've written a quick test just now and added it to tests/test_env.py as you asked me to

These flake8 issues need sorting:
  ./configurations/base.py:114:29: W291 trailing whitespace
  ./configurations/base.py:121:93: W291 trailing whitespace
  ./tests/settings/dot_env_dict.py:9:6: W291 trailing whitespace

I've added the opposite test since DOTENV being required is the default behavior. It tries to use nonexistent DOTENV path and since required is set to False it shouldn't raise an exception

@pauloxnet - are you happy for this to be merged now?

It seems a change of behaviors to me.
I don't have right now the time to do a deep down review myself, nut I would ask for more consensus in the community here before merge it

It seems a change of behaviors to me. I don't have right now the time to do a deep down review myself, nut I would ask for more consensus in the community here before merge it

Can you provide details on how you think it has changed please?
From my perspective, it is simply an enhancement allowing the existing behaviour to continue burt with the option of an enhanced way of managing the environment variable insertion.
Furthermore, there is no change to any unit tests so I am struggling to see how this has affected existing functionality.
@cclauss - do you have any opinions on this?


Run linter on pre-commit hook

I'm very bad at running prettier, and there is a very easy way to hook it to the git pre-commit in both server/ and client/
https://prettier.io/docs/en/precommit.html

Additionally, I think there are a lot of files in client/component are not formatted

Additionally, I think there are a lot of files in client/component are not formatted

Thanks, I forgot to lint tsx files. Pushed.

I can look into writing a custom hook, iirc its really just a bash script

Yup. But I'm on Windows atm 🙈
So it wouldn't fix my inability to remember to run the linter 😅


 We recommend you to set a value.
Please check https://pkg.go.dev/github.com/gin-gonic/gin#readme-don-t-trust-all-proxies for details.
[GIN-debug] Listening and serving HTTP on <IP_ADDRESS>:8081
2022/07/20 10:22:38 cleanVisitorExpire start...

没有导全吧 有visitor这个table

你的CUP架构是AMD，建议ARM


docs: remove a broken link and update info in CONTRIBUTING.md.

Brief Information
This pull request is in the type of:

[ ] bug fixing
[ ] new feature
[x] others

What does this PR do?
Remove a broken link in CONTRIBUTING.md and update the doc with latest info.
Fixed issues

#17088

Details
Before: What was the problem?

After: How is it fixed in this PR?

Misc

[ ] The API has been changed (apache/echarts-doc#xxx).
[ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs
N.A.
Others
Merging options

[ ] Please squash the commits into a single one when merging.

Other information
Feel free to correct me if I was wrong.

LGTM @Ovilia Do you have some comments?


add metrics-server v0.6.1

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes: #
Describe testing done for PR

Special notes for your reviewer

I think the test.yaml file is extraneous, and it is causing an error with the overlays.
cd addons/packages/metrics-server/0.6.1/bundle/config
ytt -f .

yields the error:
ytt: Error: Overlaying (in following order: overlays/overlay-apiservice.yaml, overlays/overlay-deployment.yaml, overlays/overlay-namespace.yaml, overlays/update-strategy-overlay.yaml):
  Document on line overlays/overlay-apiservice.yaml:5:
    Expected number of matched nodes to be 1, but was 2 (lines: test.yaml:184, upstream/components.yaml:181)

ah I added by mistake, now deleted it


ANSI::CYAN etc are throwing an error on the query_proxy.rb file.

When trying to generate a query ex post.comments I get an error on the query_proxy.rb object.
This is the only place that I can find that ANSI is being used, is there a dependency missing?
2.2.2 :001 > Post.first.comments
 CYPHER 4ms MATCH (n:`Post`) RETURN n ORDER BY n.uuid LIMIT {limit_1} | {:limit_1=>1}
NameError: uninitialized constant Neo4j::ActiveNode::Query::QueryProxy::ANSI
	from /Users/john/.rvm/gems/ruby-2.2.2/gems/neo4j-5.0.13/lib/neo4j/active_node/query/query_proxy.rb:54:in `inspect'
	from /Users/john/.rvm/gems/ruby-2.2.2/gems/neo4j-5.0.13/lib/neo4j/active_node/has_n.rb:27:in `inspect'
	from /Users/john/.rvm/gems/ruby-2.2.2/gems/railties-4.2.3/lib/rails/commands/console.rb:110:in `start'
	from /Users/john/.rvm/gems/ruby-2.2.2/gems/railties-4.2.3/lib/rails/commands/console.rb:9:in `start'
	from /Users/john/.rvm/gems/ruby-2.2.2/gems/railties-4.2.3/lib/rails/commands/commands_tasks.rb:68:in `console'
	from /Users/john/.rvm/gems/ruby-2.2.2/gems/railties-4.2.3/lib/rails/commands/commands_tasks.rb:39:in `run_command!'
	from /Users/john/.rvm/gems/ruby-2.2.2/gems/railties-4.2.3/lib/rails/commands.rb:17:in `<top (required)>'
	from /Users/john/dev/neo4j/bin/rails:8:in `<top (required)>'
	from /Users/john/.rvm/rubies/ruby-2.2.2/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
	from /Users/john/.rvm/rubies/ruby-2.2.2/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
	from -e:1:in `<main>'

Sorry for the delay!
Also sorry for this bug!  This comes from a problem with cherry-picking some code from master into the 5.0.x branch which depended on code which remained in neo4j-core master.  I've just cherry-picked the code which is needed into the 5.0.x branch of neo4j-core and released 5.0.10, so could you bundle update neo4j-core and see if that fixes it?
Thanks

Her there, just FYI I had the same issue when querying a "has_many" association of a node.  Updating to 5.0.10 fixed the problem for me, from 5.0.9 where I had the issue.
Thank you!

Awesome, thanks!  I'll close for now.  FYI there's also a 5.0.15 (it's been a busy week) and we just released 5.1.0.rc.1 if you want to try that out


Can I accelerate simulation clock speed?

Hello,
I want to use CARLA as environment of reinforcement learning.
But I think it will take so long time for learning if simulation clock is same as real-time.
So I'm looking for a way to accelerate simulation clock speed, is there any way?
I remember your team applied RL to CARLA in your paper and hope to know how did you deal with this point.
Thank you for your help.

use -benchmark and -fps=[fps],
then the simulation will go to the next frame whenever the server receives a control package.
e.g. you set -fps=20, and you send the control package 40 times per second. You are actually having a real-time world running in twice of the speed.
see Fixed time-step section for more information.

Thank you for your quick reply! I'm sorry for overlooking it.
Incidentally, do you have any ideas about recommended or maximum FPS in learning?(on the presupposition that we have sufficient PC)

@kanchi0914 the benchmark fps only affects the engine time ticks, so you can set it to be whatever you need in your task. The actually runtime is only affected by the PC hardware/environment. Since you're planning to do reinforcement learning, I think it also applies on any actually runtime if you won't do any HCI.
I don't see any limitation or restriction on FPS in my opinion. you're free to choose any fps you want.

Closing the issue because seems resolved.
You can keep talking anyway :)
Thanks @wzhAptiv.


Event::Moved isn't working

Original: https://github.com/tomaka/glutin/issues/724

WindowEvent::Moved was implemented for X11 back in 22bc119cd76454846266786ed5ca150f872a2a43. It's still not implemented for OS X; the only other backend that implements this is Windows.

Bringing back my note from the original issue : this event simply can't be implemented on wayland, by design of the protocol.


Implement Image Sorting & Classification methods

Below is a todo list, hopefully all will be completed for the 2.1 update:

[x] K-Mean Clustering

[x] Cluster similar color values as well as numerical values
[x] Allow multi-dimensional (point) clustering
[ ] Implement a cluster amount guessing mechanism

[ ] Color-Based Image Categorization

[ ] Categorizing by color groups instead of single colors

[ ] Image Similarity Checker

[ ] Low quality image filterer for similar images

(Items may get added/removed)

tasks 1, 1.1, 1.2: https://github.com/ShaharMS/Vision/commit/b3d9d96ff0d5db8b502d249573eb1316b2776a8e


VideoReader could not decode video frames correctly if the video width is not divisible by 8

🐛 Describe the bug
VideoReader could not decode video frames correctly if the video width is not divisible by 8. Specifically, the pixels in the last columns of each frame could not be decoded correctly. Please use the code below and the data available here to reproduce the bug.
import os
from PIL import Image
from numpy.typing import NDArray
import numpy as np
import torch
from torchvision.io import VideoReader as VR

input_file = 'short_snippet_828x480.mp4'

vr = VR(input_file, stream='video', num_threads=os.cpu_count())
for idx, data in enumerate(vr):
    print(idx)
    rgb_frame: torch.Tensor = data['data']
    rgb_arr: NDArray = rgb_frame.numpy()
    rgb_arr = np.transpose(rgb_arr, [1, 2, 0])

    im_vr = Image.fromarray(rgb_arr)
    im_vr.save('short_828x480_vr_frames/frame{:0>4d}.png'.format(idx))

Expected behavior:
The python code above should decode video frames and save them in short_828x480_vr_frames. However, if we look at the saved images, we can see that pixels in the last columns of each frame are not decoded. To compare, we can also decode the video using ffmpeg cli directly, i.e. running
ffmpeg -i short_828x480.mp4 -pix_fmt rgb24 short_828x480_ffmpeg_frames/frame%04d.png.
By inspecting the saved images in the folder short_828x480_ffmpeg_frames, we can see that the ffmpeg cli is able to decode the pixels in the last few columns correctly.
Versions
Collecting environment information...
PyTorch version: 1.12.1
Is debug build: False
CUDA used to build PyTorch: 11.3
ROCM used to build PyTorch: N/A
OS: Ubuntu 20.04.5 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
Clang version: Could not collect
CMake version: Could not collect
Libc version: glibc-2.31
Python version: 3.8.13 (default, Mar 28 2022, 11:38:47)  [GCC 7.5.0] (64-bit runtime)
Python platform: Linux-5.15.0-46-generic-x86_64-with-glibc2.17
Is CUDA available: False
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
Versions of relevant libraries:
[pip3] mypy==0.910
[pip3] mypy-extensions==0.4.3
[pip3] numpy==1.23.1
[pip3] pytorch-lightning==1.7.0
[pip3] torch==1.12.1
[pip3] torchaudio==0.12.1
[pip3] torchmetrics==0.9.3
[pip3] torchqa==0.2.0
[pip3] torchvision==0.13.1
[conda] blas                      1.0                         mkl
[conda] cudatoolkit               11.3.1               h2bc3f7f_2
[conda] mkl                       2021.4.0           h06a4308_640
[conda] mkl-service               2.4.0            py38h7f8727e_0
[conda] mkl_fft                   1.3.1            py38hd3c417c_0
[conda] mkl_random                1.2.2            py38h51133e4_0
[conda] numpy                     1.23.1           py38h6c91a56_0
[conda] numpy-base                1.23.1           py38ha15fc14_0
[conda] pytorch                   1.12.1          py3.8_cuda11.3_cudnn8.3.2_0    pytorch
[conda] pytorch-lightning         1.7.0                    pypi_0    pypi
[conda] pytorch-mutex             1.0                        cuda    pytorch
[conda] torchaudio                0.12.1               py38_cu113    pytorch
[conda] torchmetrics              0.9.3                    pypi_0    pypi
[conda] torchqa                   0.2.0                     dev_0
[conda] torchvision               0.13.1               py38_cu113    pytorch

This is a duplicate of this issue.
I'll revisit looking into this this week.


playing ll-hls is always seeking

Have you read the Tutorials?
yes
Have you read the FAQ and checked for duplicate open issues?
yes
What version of Shaka Player are you using?
v3.2.1
Please ask your question
I'm using different network serving ll-hls stream, one network plays well and another it cannot play. after checking logs by chrome://media-internals I find that shaka player is always seeking. some of logs are:
00:00:00.454 | pipeline_state | "kPlaying"
00:00:00.465 | pipeline_state | "kSeeking"
00:00:00.285 | duration |<PHONE_NUMBER>
00:00:02.836 | event | "kPlay"
00:00:03.038 | seek_target | 23.536
00:00:03.038 | pipeline_state | "kPlaying"
00:00:03.041 | pipeline_state | "kSeeking"
00:00:06.251 | seek_target | 26.864
00:00:06.251 | pipeline_state | "kPlaying"
00:00:06.253 | seek_target | 26.865
00:00:06.253 | pipeline_state | "kSeeking"
00:00:10.251 | seek_target | 30.844
00:00:10.251 | pipeline_state | "kPlaying"
00:00:10.252 | seek_target | 30.845
00:00:10.252 | pipeline_state | "kSeeking"
00:00:14.251 | seek_target | 34.851
00:00:14.252 | pipeline_state | "kPlaying"
00:00:14.259 | seek_target | 34.858999
00:00:14.262 | pipeline_state | "kSeeking"
00:00:18.262 | seek_target | 38.848999
00:00:18.262 | pipeline_state | "kPlaying"
00:00:18.265 | seek_target | 38.852
00:00:18.267 | pipeline_state | "kSeeking"
00:00:22.251 | seek_target | 42.873
00:00:22.252 | pipeline_state | "kPlaying"
00:00:22.257 | seek_target | 42.879
00:00:22.260 | pipeline_state | "kSeeking"
00:00:26.265 | seek_target | 46.855999
00:00:26.265 | pipeline_state | "kPlaying"
00:00:26.266 | seek_target | 46.857999
00:00:26.276 | pipeline_state | "kSeeking"
00:00:30.251 | seek_target | 50.851
00:00:30.252 | pipeline_state | "kPlaying"
...

I want to know why this proble happen and how to fix it.

I found that with adding enableLowLatency: false on shaka player, It's can play normally. I also found some strange logs when enableLowLatencyis true:
(audio:1) finished fetch and append []
(video:2) finished fetch and append []

it seems like no data uas append to buffer.but I'm sure that shaka player get correct data.
I also find the reason why shaka player is always seeking:
Playhead before start & start is unbuffered
bugsnag.js:2457 Jumping forward<PHONE_NUMBER>4468693 seconds to catch up with the seek range.
2bugsnag.js:2457 Playhead outside safe region & in unbuffered region.
bugsnag.js:2457 Seek to 1191.086999

How do I slove this problem?

I have sloved this problem. Thanks.


Add lrange

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@28c63fa). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #27   +/-   ##
=========================================
  Coverage          ?   73.53%
=========================================
  Files             ?       14
  Lines             ?      801
  Branches          ?        0
=========================================
  Hits              ?      589
  Misses            ?      212
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c63fa...ef9bfb0. Read the comment docs.


Revert "MB-5366 - [CAT II] errcheck: Error return value of function is not checked."

Reverts transcom/mymove#4

Warnings

:warning:

It looks like you are attempting to bypass a linter rule, which is not within
security compliance rules.
** Contains prohibited linter override "#nosec". **
Please remove the bypass code and address the underlying issue. cc: @transcom/Truss-Pamplemoose

Messages

:book:
:link: MB-5366

  Generated by :no_entry_sign: dangerJS against deb082339728165904fe851927c34c1b568d7450


OPtANNe

BIGANN submission for GraphANN using Intel Optane Persistent Memory (high QPS HW)

@sdongaonkar Hey, catching up with the PRs.   Are the two OptANNE PR's intended to be different submissions?  I think we already discussed this in email, but I just wanted to make sure:
https://github.com/harsha-simhadri/big-ann-benchmarks/pull/64
https://github.com/harsha-simhadri/big-ann-benchmarks/pull/63

@sdongaonkar I sent you an email on the same topic.  We are seeing improvement in 2 datasets (text2image and msspacev) but big decrease in the rest ( on the recall benchmark ).  Was that intended?

@sdongaonkar I sent you an email on the same topic. We are seeing improvement in 2 datasets (text2image and msspacev) but big decrease in the rest ( on the recall benchmark ). Was that intended?

Thanks for the heads up. I just sent a reply. It seems for 3 of the datasets the last search window size value was picked for the summary. The attached file has all the values, and I've highlighted the intended search_window_size values for recall and QPS rankings.
Please let me know if your numbers are still different to these ones.
recall_and_qps_results_highlighted.xlsx
y.

@sdongaonkar I sent you an email on the same topic. We are seeing improvement in 2 datasets (text2image and msspacev) but big decrease in the rest ( on the recall benchmark ). Was that intended?

Thanks for the heads up. I just sent a reply. It seems for 3 of the datasets the last search window size value was picked for the summary. The attached file has all the values, and I've highlighted the intended search_window_size values for recall and QPS rankings.
Please let me know if your numbers are still different to these ones.
recall_and_qps_results_highlighted.xlsx y.

OK @sdongaonkar, lets keep it as a github issue/conversation for now.  I'd like to track down what went wrong and what might be wrong.  The following is the algos.yaml we used when we ran the eval.  Does it look correct?
https://github.com/harsha-simhadri/big-ann-benchmarks/blob/t3/eval_optanne_graphann/t3/optanne_graphann/algos.yaml
If it is correct, then something else besides the yaml is wrong.  Thanks.

@sdongaonkar Hey, we are currently unable to run any more evaluations due to this error.  Any thoughts on what to do here?
Trying to instantiate benchmark.algorithms.graphann.GraphANN(['euclidean', {'index_file': '/mnt/data/competition_indexes/bigann1b_index127-superflat.index', 'vectors_file': '/mnt/data/competition_indexes/bigann1b_vectors.bin', 'vectors_location': 'HUGE'}])
Activating environment at ~/BigANN/GraphANN/contrib/PyANN/Project.toml
Precompiling project...
✓ PyCall
7 dependencies successfully precompiled in 217 seconds (58 already precompiled)
1 dependency precompiled but a different version is currently loaded. Restart julia to access the new version
[ Info: Running in an exclusive environment. Populating thread affinities.
[ Info: Running in an exclusive environment. Populating thread affinities.
[ Info: Running in an exclusive environment. Populating thread affinities.
Running graphann on bigann-1B
Got 10000 queries
Copying index to PMem...
Process Process-1:
Traceback (most recent call last):
File "/home/bigann/.pyenv/versions/3.8.12/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
self.run()
File "/home/bigann/.pyenv/versions/3.8.12/lib/python3.8/multiprocessing/process.py", line 108, in run
self._target(*self._args, **self._kwargs)
File "/home/bigann/BigANN/big-ann-benchmarks/benchmark/main.py", line 45, in run_worker
run_no_docker(definition, args.dataset, args.count,
File "/home/bigann/BigANN/big-ann-benchmarks/benchmark/runner.py", line 339, in run_no_docker
run_from_cmdline(cmd)
File "/home/bigann/BigANN/big-ann-benchmarks/benchmark/runner.py", line 230, in run_from_cmdline
run(definition, args.dataset, args.count, args.runs, args.rebuild,
File "/home/bigann/BigANN/big-ann-benchmarks/benchmark/runner.py", line 95, in run
elif rebuild or not algo.load_index(dataset):
File "/home/bigann/BigANN/big-ann-benchmarks/benchmark/algorithms/graphann.py", line 85, in load_index
self.create_index_dir(ds),
File "/home/bigann/BigANN/big-ann-benchmarks/benchmark/algorithms/graphann.py", line 151, in create_index_dir
shutil.copy(self._index_file, graph_file0)
File "/home/bigann/.pyenv/versions/3.8.12/lib/python3.8/shutil.py", line 418, in copy
copyfile(src, dst, follow_symlinks=follow_symlinks)
File "/home/bigann/.pyenv/versions/3.8.12/lib/python3.8/shutil.py", line 275, in copyfile
_fastcopy_sendfile(fsrc, fdst)
File "/home/bigann/.pyenv/versions/3.8.12/lib/python3.8/shutil.py", line 166, in _fastcopy_sendfile
raise err from None
File "/home/bigann/.pyenv/versions/3.8.12/lib/python3.8/shutil.py", line 152, in _fastcopy_sendfile
sent = os.sendfile(outfd, infd, offset, blocksize)
OSError: [Errno 28] No space left on device: '/mnt/data/competition_indexes/bigann1b_index127-superflat.index' -> '/mnt/pm0/public/graph.bin'

I was running the benchmark script on it.
I just logged out.
It should work now.

I was running the benchmark script on it. I just logged out. It should work now.

Ooops.  Apologies...I should have checked if someone was logged in.  Thanks!

@sdongaonkar  @hildebrandmw  We want to merge this branch to main. Could you please make any final changes to the PR before we merge. Could you please not delete or modify data in the common yaml and eval files in your PR?

Hi there! Very, very sorry for the delay! As far as I know, there are unfortunately no plans to make the original code behind this submission publicly available. I'd be happy to try to resolve the merge conflicts, but would honestly recommend closing this PR (and PRs associated with this one) to avoid merging what is now essentially dead code into main.
If in the future the code does become available, I'd be willing to open a new PR any updated interfaces and configurations. What do you think?

Thanks @hildebrandmw for the update. It's a pity, but it would of course be very much appreciated if you were to include it at a later stage. @sourcesync @harsha-simhadri Probably #63, #64, and #103 should be closed following Mark's suggestions.

@Martin Aumüller @.***> I agree unless Mark sees a way to "resolve
the merge conflicts" as he offered.  But even then, I'm not sure how useful
that would be.  I believe also Intel has decided to discontinue making the
Optane hardware, so at some point it will be impossible to reincarnate this
submission.
On Wed, Apr 26, 2023 at 10:21 AM Martin Aumüller @.***>
wrote:

Thanks @hildebrandmw https://github.com/hildebrandmw for the update.
It's a pity, but it would of course be very much appreciated if you were to
include it at a later stage. @sourcesync https://github.com/sourcesync
@harsha-simhadri https://github.com/harsha-simhadri Probably #63
https://github.com/harsha-simhadri/big-ann-benchmarks/pull/63, #64
https://github.com/harsha-simhadri/big-ann-benchmarks/pull/64, and #103
https://github.com/harsha-simhadri/big-ann-benchmarks/pull/103 should
be closed following Mark's suggestions.
—
Reply to this email directly, view it on GitHub
https://github.com/harsha-simhadri/big-ann-benchmarks/pull/63#issuecomment-1523788940,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADL6CM424FIKT7ECPGXKNTXDFKP3ANCNFSM5GRNXZ3A
.
You are receiving this because you were mentioned.Message ID:
@.***>

@sourcesync  I think it's your call to say whether https://github.com/harsha-simhadri/big-ann-benchmarks/pull/103/files#diff-8deadc2d4adf2d0fbfc7cb5dc53dd739b5dc69e68779d7f53999985ec47374a6R59-R100 adds something useful to the infrastructure, independently of the implementation.

@Martin Aumüller @.> Thanks for the diff.  I don't see anything
in there worth keeping for version 2.  I might recommend we keep or archive
the branch and just close the PR.  But also I believe the participant
forked the repository and it lives there as well just in case.  I think @Harsha
Vardhan Simhadri @.> should have the final say, but
I'm good at least closing the PR.
On Wed, Apr 26, 2023 at 10:33 AM Martin Aumüller @.***>
wrote:

@sourcesync https://github.com/sourcesync I think it's your call to say
whether
https://github.com/harsha-simhadri/big-ann-benchmarks/pull/103/files#diff-8deadc2d4adf2d0fbfc7cb5dc53dd739b5dc69e68779d7f53999985ec47374a6R59-R100
adds something useful to the infrastructure, independently of the
implementation.
—
Reply to this email directly, view it on GitHub
https://github.com/harsha-simhadri/big-ann-benchmarks/pull/63#issuecomment-1523804679,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADL6CNSUVIUC7RWXKLPIIDXDFL73ANCNFSM5GRNXZ3A
.
You are receiving this because you were mentioned.Message ID:
@.***>


OSError: [Errno 28] No space left on device

version==2.8.0
my data:
col 300
row 500,000
size 1.5G
my device:
              total        used        free      shared  buff/cache   available
Mem:            31G        419M         22G        508K        8.6G         30G
Swap:            0B          0B          0B

my code:
def pandas_report(data):
    profile = pandas_profiling.ProfileReport(data, title='Pandas Profiling Report', explorative=True)
    profile.to_file('pandas_profiling.html')

Even if I set explorative=False, same error.
error:
  7 joblib.externals.loky.process_executor._RemoteTraceback:
  8 """
  9 Traceback (most recent call last):
 10   File "/installpackages/anaconda3/lib/python3.7/site-packages/joblib/externals/loky/backend/queues.py", line 150, in _feed
 11     obj_ = dumps(obj, reducers=reducers)
 12   File "/installpackages/anaconda3/lib/python3.7/site-packages/joblib/externals/loky/backend/reduction.py", line 247, in dumps
 13     dump(obj, buf, reducers=reducers, protocol=protocol)
 14   File "/installpackages/anaconda3/lib/python3.7/site-packages/joblib/externals/loky/backend/reduction.py", line 240, in dump
 15     _LokyPickler(file, reducers=reducers, protocol=protocol).dump(obj)
 16   File "/installpackages/anaconda3/lib/python3.7/site-packages/joblib/externals/cloudpickle/cloudpickle.py", line 482, in dump
 17     return Pickler.dump(self, obj)
 18   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 437, in dump
 19     self.save(obj)
 20   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 549, in save
 21     self.save_reduce(obj=obj, *rv)
 22   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 662, in save_reduce
 23     save(state)
 24   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 504, in save
 25     f(self, obj) # Call unbound method with explicit self
 26   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 859, in save_dict
 27     self._batch_setitems(obj.items())
 28   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 885, in _batch_setitems
 29     save(v)
 30   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 549, in save
 31     self.save_reduce(obj=obj, *rv)
 32   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 662, in save_reduce
 33     save(state)
 34   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 504, in save
 35     f(self, obj) # Call unbound method with explicit self
 36   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 859, in save_dict
 37     self._batch_setitems(obj.items())
 38   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 890, in _batch_setitems
 39     save(v)
 40   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 549, in save
 41     self.save_reduce(obj=obj, *rv)
 42   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 662, in save_reduce
 43     save(state)
 44   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 504, in save
 45     f(self, obj) # Call unbound method with explicit self
 46   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 859, in save_dict
 47     self._batch_setitems(obj.items())
 48   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 885, in _batch_setitems
 49     save(v)
 50   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 504, in save
 51     f(self, obj) # Call unbound method with explicit self
 52   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 819, in save_list
 53     self._batch_appends(obj)
 54   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 846, in _batch_appends
 55     save(tmp[0])
 56   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 504, in save
 57     f(self, obj) # Call unbound method with explicit self
 58   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 774, in save_tuple
 59     save(element)
 60   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 504, in save
 61     f(self, obj) # Call unbound method with explicit self
 62   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 774, in save_tuple
 63     save(element)
 64   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 549, in save
 65     self.save_reduce(obj=obj, *rv)
 66   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 662, in save_reduce
 67     save(state)
 68   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 504, in save
 69     f(self, obj) # Call unbound method with explicit self
 70   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 859, in save_dict
 71     self._batch_setitems(obj.items())
 72   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 885, in _batch_setitems
 73     save(v)
 74   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 549, in save
 75     self.save_reduce(obj=obj, *rv)
 76   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 662, in save_reduce
 77     save(state)
 78   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 504, in save
 79     f(self, obj) # Call unbound method with explicit self
 80   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 789, in save_tuple
 81     save(element)
 82   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 504, in save
 83     f(self, obj) # Call unbound method with explicit self
 84   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 819, in save_list
 85     self._batch_appends(obj)
 86   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 846, in _batch_appends
 87     save(tmp[0])
 88   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 510, in save
 89     rv = reduce(obj)
 90   File "/installpackages/anaconda3/lib/python3.7/site-packages/joblib/_memmapping_reducer.py", line 339, in __call__
 91     for dumped_filename in dump(a, filename):
 92   File "/installpackages/anaconda3/lib/python3.7/site-packages/joblib/numpy_pickle.py", line 505, in dump
 93     NumpyPickler(f, protocol=protocol).dump(value)
 94   File "/installpackages/anaconda3/lib/python3.7/pickle.py", line 437, in dump
 95     self.save(obj)
 96   File "/installpackages/anaconda3/lib/python3.7/site-packages/joblib/numpy_pickle.py", line 292, in save
 97     wrapper.write_array(obj, self)
 98   File "/installpackages/anaconda3/lib/python3.7/site-packages/joblib/numpy_pickle.py", line 104, in write_array
 99     pickler.file_handle.write(chunk.tostring('C'))
100 OSError: [Errno 28] No space left on device
101 """
102
103 The above exception was the direct cause of the following exception:
104
105 Traceback (most recent call last):
106   File "model.py", line 316, in <module>
107     bm.pandas_report(bm.data)
108   File "model.py", line 33, in _wrapper
109     r = func(*args, **kwargs)
110   File "model.py", line 156, in pandas_report
111     profile.to_file('pandas_profiling.html')
112   File "/installpackages/anaconda3/lib/python3.7/site-packages/pandas_profiling/profile_report.py", line 245, in to_file
113     data = self.to_html()
114   File "/installpackages/anaconda3/lib/python3.7/site-packages/pandas_profiling/profile_report.py", line 348, in to_html
115     return self.html
116   File "/installpackages/anaconda3/lib/python3.7/site-packages/pandas_profiling/profile_report.py", line 168, in html
117     self._html = self._render_html()
118   File "/installpackages/anaconda3/lib/python3.7/site-packages/pandas_profiling/profile_report.py", line 275, in _render_html
119     report = self.report
120   File "/installpackages/anaconda3/lib/python3.7/site-packages/pandas_profiling/profile_report.py", line 162, in report
121     self._report = get_report_structure(self.description_set)
122   File "/installpackages/anaconda3/lib/python3.7/site-packages/pandas_profiling/profile_report.py", line 143, in description_set
123     self._description_set = describe_df(self.title, self.df)
124   File "/installpackages/anaconda3/lib/python3.7/site-packages/pandas_profiling/model/describe.py", line 82, in describe
125     df, variables, correlation_name
126   File "/installpackages/anaconda3/lib/python3.7/site-packages/pandas_profiling/model/correlations.py", line 168, in calculate_correlation
127     correlation = df[selcols].phik_matrix(interval_cols=intcols)
128   File "/installpackages/anaconda3/lib/python3.7/site-packages/phik/phik.py", line 217, in phik_matrix
129     drop_overflow=drop_overflow)
130   File "/installpackages/anaconda3/lib/python3.7/site-packages/phik/phik.py", line 147, in phik_from_rebinned_df
131     for co in itertools.combinations_with_replacement(data_binned.columns.values, 2))
132   File "/installpackages/anaconda3/lib/python3.7/site-packages/joblib/parallel.py", line 1017, in __call__
133     self.retrieve()
134   File "/installpackages/anaconda3/lib/python3.7/site-packages/joblib/parallel.py", line 909, in retrieve
135     self._output.extend(job.get(timeout=self.timeout))
136   File "/installpackages/anaconda3/lib/python3.7/site-packages/joblib/_parallel_backends.py", line 562, in wrap_future_result
137     return future.result(timeout=timeout)
138   File "/installpackages/anaconda3/lib/python3.7/concurrent/futures/_base.py", line 428, in result
139     return self.__get_result()
140   File "/installpackages/anaconda3/lib/python3.7/concurrent/futures/_base.py", line 384, in __get_result
141     raise self._exception
142 _pickle.PicklingError: Could not pickle the task to send it to the workers.

I want to know why the calculated report result is so large that it exceeds 22G. And I cost 1.2h to finish it, whether the calculation speed can be improved, I know that the calculation correlation is n*(n-1)/2 level.
Thanks.

From the error message alone it seems that one of the correlation calculations is writing to disk. You could try to set correlations=None to disable all correlations and see if it solves the issue.


Changed submap radios to a dropdown menu for applicable maps.

Window should show the dropdown when opened.
Preview:

Maps without submaps look like before:

Thanks!  The dropdown does the most space efficient.  I guess I was too fixated on the in-game mini-map using radio buttons to think of anything else haha
Will include this in the new build for patch 5.5.


Update Parlot to 1.0

Fix #35

@sebastienros please approve this workflow to run.
Also this line is throwing an exception
https://github.com/MikeAlhayek/shortcodes/blob/280261cb668e65f6c77c0d967ad0477bde5b85b7/src/Shortcodes/ShortcodesParser.cs#L146

System.ArgumentOutOfRangeException : Specified argument was out of the range of valid values. (Parameter 'start')

Maybe using _scanner.Cursor.Offset is not the correct value for start.

@sebastienros yes that is what I am thinking too. Because the line that is throwing the exception is in Parlot.

You can close this PR, I had to do several changes in Parlot to get all the tests passing


Rebase : doesn't work if there isn't a project

When working through the steps of an issue on Git Rebase that I was writing, I discovered something slightly odd.
While git status works fine if I haven't created a Project (does it look at the path for the current file, maybe?), git rebase gives me a blank page until I actually have a project.
This really confused me for a while - it'd be nice for it to make the same assumption as git status for which repository we're in.

Hmm, you'll have to include more repro steps for this one.  There's only a single mechanism for detecting which git repository to talk to, so I'm not sure what you're describing.

Here you go - this just worked for me:
> mkdir git_test
> cd git_test
> git init
> touch a
> git add a
> git commit -m "A"
> touch b

Open 'b' in Sublime Text
Command Palette -> "git status"

Close Status tab
Command Palette -> "git rebase"

Close Rebase tab
Project -> Save Project As -> "git_test/git_test.sublime-project"
Command Palette -> "git rebase"

BTW - this is all on OSX 10.10.5 using git version 2.4.9 (Apple Git-60)

Weird.  Thank you, I'll take a look.


🐞 follow-redirects version is old

Remove follow-redirects dependencies
Ref:
https://github.com/follow-redirects/follow-redirects/issues/235

addressed by #862


adding mandb suppression logic.

What type of PR is this?

/kind bug
What this PR does / why we need it:
This PR will bring in changes to CSE installation steps to suppress real-time man-db updates when installing dependencies. After CSE installation completes, a background process is spawned that will trigger man-db to update its indices with newly installed dependencies without delaying termination of the CSE installation process.
Which issue(s) this PR fixes:

Fixes #
Currently, when dependencies are installed during CSE execution time, automatic updates are triggered on man-db. This massively increases the time it takes to install each dependency during CSE execution, as it can take man-db a lot of time to update its database for each downloaded dependency.
This PR will prevent man-db updates from slowing down CSE execution by suppressing man-db's auto-update feature and having it update its indices AFTER all dependencies have been installed. This update process will now take place within a background process that does not block CSE execution.
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

@ganeshkumar5699 I didn't end up testing with timestamps across the whole CSE execution, but I did add some adhoc timestamping specifically for the man-db update process after all dependencies have been installed. At the moment it looks like this process takes about ~2 seconds on vanilla and ~5 seconds on gpu.


habitat: 0.32.2 -> 0.62.0

Motivation for this change
The current version in the repo is a year out of date.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

The cargo test doesn't pass for reasons that I don't understand, so it is currently commented out.

@GrahamcOfBorg build habitat

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: habitat
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Failure on x86_64-darwin (full log)
Attempted: habitat
Partial log (click to expand)
          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)

error: aborting due to previous error

error: Could not compile `hab`.

To learn more, run the command again with --verbose.
builder for '/nix/store/01gxpa53wwck33h1pwmpnj508441jc1r-habitat-0.62.0.drv' failed with exit code 101
error: build of '/nix/store/01gxpa53wwck33h1pwmpnj508441jc1r-habitat-0.62.0.drv' failed

I removed the darwin architecture since I have no way to test it myself.

@GrahamcOfBorg build habitat

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: habitat
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: habitat
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: habitat
Partial log (click to expand)
Running cargo test
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0
shrinking /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0/bin/hab
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0/bin
patching script interpreter paths in /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0
checking for references to /build in /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0...
/nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0

@Mic92 Is there anything in particular I need to do to this to get it merged?

I cannot get to this right now.


[staging & production] MFR: Won't render files that have blank names and are only the extension

Reported by @erinspace on the 0.24 Trello board
Steps

In windows, create a file with just spaces for the name
This file will be saved as a file with no name and only an extension
Upload this file to the OSF
Click the file to render

Expected

The file will be recognized and rendered

Actual

The page times out once, and then renders a blank page subsequent times after that.

Not an overly likely scenario -- good to be aware -- defer for now.


Live Migration

[Enter feedback here]
Please talk about and help configure Live Migration network here in this page. Preferably ATC should configure LM on storage intents.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c918dd65-3761-be6b-6e5b-199255402a27
Version Independent ID: 7c33b8ea-f2f5-11f7-f478-42d2d80a220a
Content: Network ATC overview - Azure Stack HCI
Content Source: azure-stack/hci/concepts/network-atc-overview.md
Service: azure-stack
Sub-service: azure-stack-hci
GitHub Login: @dcuomo
Microsoft Alias: jgerend

@iinfi1
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.


Master -> Live

Docs Build status updates of commit 89c3792:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-troubleshooting.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-version-history.md
:white_check_mark:Succeeded
View

mixed-reality-docs/using-visual-studio.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


*.: fix docker path to radondb #147

What type of PR is this?

Which issue(s) this PR fixes?

Fixes #
What this PR does?
Summary:
Special notes for your reviewer?

LGTM


StorjDCS compatibility and their ListObjects implementation

What happened:
Docs states a compatibility with StorjDCS but there is, at least, a problem with their ListObjects implementation API.
It can be verified with juicefs objbench command, it will output:
<ERROR>: The keys are out of order: marker "", last "96" current "12" [sync.go:132]
This will, at least, impact fsck or gc commands as they both call ListObjects.
How to reproduce it (as minimally and precisely as possible):
Create a free StorjDCS account and run juicefs objbench on it.

See also https://github.com/juicedata/juicefs/issues/1655

Also #1755.
We'd better update the doc.


Keras time-series application

Hi all,
I am facing problem in Keras in the input feeding stage. Actually, i cannot envision how to feed my input with different mindset. I have a time series problem and i want to make prediction for the next 24 hour with one step-ahead prediction. My input is 168xfeatures, output is 1 scalar. I will use 168 steps look-back, namely, prediction(in training stage) at timestep t will depend on from t-1 thorugh t-168.  Prediction at timestep t+1 will depend on from t thorugh t-167, and the problem arises here. And t+2,t+3,t+4 and t+23 will be performed. However, i must insert my predictions to the input at each stage for next 24 hour.  It means if i predict  value in timestep t+2 in training stage ,i will use values from t+1 thorugh t-166, and the values t-166 and t-165 for relevant feature (load feature) will be forecast values at time t(yhat_t) and t+1(yhat_t+1). How can i construct this type of input for keras?

@dervishson Please post the questions related to support on Stack Overflow or Keras Slack Channel as this platform is only for meant bug/performance, feature request and docs related issues. Thanks!


Signing mp4-files with external manifest results in faulty mp4-files (not playable, mp4-box-structure broken)

Signing mp4-files with external manifest results in faulty mp4-files (not playable, mp4-box-structure broken)
tested with c2patool 0.9.12 and c2patool 0.9.3
Once I run signing of a mp4-file with an external manifest, created mp4-file shows broken mp4-structure (no moof/mdat) and playback is broken (runs fine with internal C2PA-manifest).
Here's sample:
./c2patool sample_source.mp4 \
-r http://testhost.com/test/manifest.c2pa \
-m test.json \
-f -o ext_dest.mp4

Here are the given files:
https://github.com/user-attachments/assets/805832ee-1a37-472d-853d-6a4b9d879e3d
https://github.com/user-attachments/assets/f6a3771b-9821-48b9-85da-3dc21a5a7a88
(test.json same as https://github.com/contentauth/c2patool/blob/main/sample/test.json and self signed certs)

http://data.streamingexpert.de/issue280.zip


Remove const enums from index.d.ts do it works with --isolatedModules

Prerequisites

[X] I am running the latest version
[X] I checked the documentation and found no answer
[X] I checked to make sure that this issue has not already been filed

Expected Behavior
There should be no typescript errors with --isolatedModules, which is recommended for react-native typescript since typescript const enums don't work with babel
Current Behavior
Currently, every enum on index.d.ts is defines as a const enum. These are not compatible with --isolatedModules(see microsoft/Typescript#207). However, babel does not support const enums (babel/babel#8741) which means that when writing RN projects with typescript, using --isolatedModules guarantess the programmers won't accidentally add in const enums and break code unknowingly.
In practice, react-native-ble-plx doesn't actually use typescript const enums(which is what is declared in the .d.ts), which means that it's fine to run the library without isolatedmodules since we're not really compiling typescript through babel; However, this particular change creates a conflict when using that particular option at no real benefit from what I can gather.
Steps to Reproduce
write any code with isolatedModules enabled on tsconfig.json, and you'll see that your IDE(if it uses the ts language server) will complain when using ble-plx enums.

I'd love PR for that change. I'm not an active Typescript user and I have limited time to do all of the things.


Implement SameSite cookies. 🍪

SameSite attribute set to Lax.
https://tools.ietf.org/html/draft-west-first-party-cookies-07

Build failures?

@whit357 I am not entirely sure how to solve this. This is not a priority so maybe I should have just opened an issue for SameSite cookies.

Looks like a SyntaxError:
    set_cookie(cookies, SESSION, token, expires=new_expires, samesite)
SyntaxError: non-keyword arg after keyword arg

Are you familiar with the distinction between keyword and non-keyword arguments in Python?

Oh, whoops! I see the issue now.

It turns out there isn't a samesite morsel object in https://docs.python.org/2/library/cookie.html#morsel-objects.


Feature request: Nested lists

My project uses drag-and-drop interfaces that are not currently accessible, and I'd love to use dragon drop to replace our current sorting jquery plugin. Many of our interfaces are for creating navigation lists, and so the ability to nest the sortable items is key.

This sounds interesting. Could you go more in depth on how this interaction works? I would like to get a better idea of what this feature would entail.
Screenshots would be helpful too!

+1 for this feature
I've attached a screenshot from a project on which I'm currently working, using a tree structure to manage page position for a website's navigation
In it, the Events page has 3 child pages, called (imaginatively) Event 1, Event 2, and Event 3
I'd love to be able to drag Event 3 to above -say- Event 1 without being able to drag it into Resources (the item above Events) or Faqs (the Item below Events)
Hope it helps!

Ok, thanks for the explanation + screenshot.  I'll probably tag a new release including this feature this evening or tomorrow
p.s. the feature is sitting in this branch. I just need to write some tests and then tag the release

Awesomely quick! Thank you! I'll check it out

Support for nested lists (which turned out to be an extremely easy feature to add (~2 lines of code)) has been added in the latest release!  All you have to do is pass nested: true in the configuration
Please check nested lists demo out.
I want to make sure this is what both of you (@itsterry @kimisgold) were talking about  before closing this issue

False alarm...I've just realized that mouse dragging within sublists is messed up.
Hang tight and I'll update this issue when the problem is resolved

This isn't quite resolved yet, I've added keyboard support for nested lists but not mouse support yet

@kimisgold @itsterry version 3.2.1 supports nested lists there is now also a demo
For now, sublists are locked (as in you can't move an item from one sublist to another but you can reorder sublist items within their original list containers). From what I gathered, this is @itsterry 's desired behavior.  I do however plan on supporting the use case of moving sublist items between sublists. See #11 to track that feature.
I will close this issue if this is what both of you had in mind

@schne324 Awesome: this is exactly what we need. Thank you!

No problem, the configuration needed is a little funky for now.  Once I address  #11 it should be a little more intuitive.
Cheers!

@kimisgold is this the kind of nesting you were looking for?

Hi @schne324, thanks for the fast response on this! My use case is more like what you described, in that I need to be able to to move items in and out of sublists. For an example, you can look at our demo sandbox: http://dev.omeka.org/omeka-s-sandbox/admin/site/s/americanart/navigation (username/password: omekasdemo1@example.com/omekasdemo1). We're currently using jstree as our sorting tool.

@kimisgold this feature sounds cool but may require some decent refactoring. I'll leave this ticket open until full nested lists support is added

Thanks, I look forward to seeing what you do!

closing in favor #11  which has a more descriptive title


Store Benchmarking results in a DB

Please describe the feature you'd like to see
Currently, we store results in a GCS bucket.
via gsutil cp $results_file gs://${GCP_BUCKET}/benchmark/results/
But since we also would like to compare results it would be nice to save them in DB.
Describe the solution you'd like
Standardize the results and save them in DB
Are there any alternatives to this feature?
Open to suggestions
Acceptance Criteria

[ ] There should be a table that at least has columns - dates of the run, dataset, location, duration, and memory consumption.
[ ] Benchmarking script should be modified to save data to the above-mentioned table.

@utkarsharma2 aren't we sending the benchmark results to BQ as well ATM?
https://github.com/astronomer/astro-sdk/blob/main/python-sdk/tests/benchmark/run.py#L89

This may not be needed, let's test this and then close it if the functionality already exists.

The results are exported to BQ and @sunank200 , @pankajkoti have tested this. Closing this.


Max time as current date current time

Hello, Can you give me example how i can set current time as max time so user cannot able to select future time. I have tried using

only-valid="{before: 'today', inclusive: true}

but its only working in date not in time.
Your help would be very help for me .
Thanks in advance.

The whole validation works just for dates. If you want to validate the time, you need to write your own validator on the ngModel.
Let's fix this in the next version which should add more thorough user-defined validations.


allow menubar reload to work

The menubar has a slightly different flow since its BrowserWindow is managed by a plugin. It didn't have the listener for load finishes which would let it bootstrap so this adds that in so it acts more like the other remote windows
@keybase/react-hackers

possible but i've never seen that happen


Remove specific emails from snapshot email

The snapshot email was only ever sending to me, @smunilla, and @jupierce - none of us are involved anymore.

/lgtm

Close. Should be more like the other emails we changed lately though.
https://github.com/openshift/aos-cd-jobs/blob/master/jobs/build/release/Jenkinsfile#L130-L131

@tbielawa<EMAIL_ADDRESS>That's fine with me as long as it gets
updated. I mostly wanted to bring attention to it.
On Mon, Jul 29, 2019 at 8:31 AM Tim Bielawa<EMAIL_ADDRESS>wrote:

Close. Should be more like the other emails we changed lately though.
https://github.com/openshift/aos-cd-jobs/blob/master/jobs/build/release/Jenkinsfile#L130-L131
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openshift/aos-cd-jobs/pull/1904?email_source=notifications&email_token=AAHJV2RJX45GBGBBQXET4QTQB3PIVA5CNFSM4IHRFS52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ARRBQ#issuecomment-515971206,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHJV2UHLZZRJTUVVGQTFUTQB3PIVANCNFSM4IHRFS5Q
.


Simplify build step and update documents.

While trying to resolve this issue: https://github.com/jupyter/jupyterlab/issues/148, it became clear that the first-time developer build instructions in the README were missing a call to npm run build:serverextension, so instead, I'm proposing npm run build:all that will build the source and the server extension. I am reluctant to add another line for a new developer to run.
I would have preferred to have npm run build do this automatically, but building the server extension creates a dependency cycle because it calls npm install which runs the prepublish script, calling build and creating an infinite loop.
cc: @fperez @blink1073 @jasongrout @willingc

LGTM +1 to simplify 😄

I'm not an npm expert so I'm unwilling to merge this myself, but from looking both at the code and the intent, this looks good to me, so +1 from a non-expert.  Thanks a lot @afshin for pushing on this after our work today!

Looks good, thanks @afshin!

+1 to build:all instead of build:serverextension. That name was way too long to type or remember...


doesnt work at all (Unknown command. Type "/help" for help.)

mc 1.16.5 and server is running on Mohist #813 (plugin & forge hybrid (i've also tried this on normal forge)=
https://user-images.githubusercontent.com/47058245/143677711-b4ababb9-6590-4708-9f15-16b7e172aa66.mp4

I don't explicitly support mohist, I would suggest just using a similar plugin instead. I don't know why this is happening but I'm not really concerned

I don't explicitly support mohist, I would suggest just using a similar plugin instead. I don't know why this is happening but I'm not really concerned

same thing is happening without mohist (forge only)

Uh... what. The mod works, so I don't know what's going on there. Could it be one of your other mods?

probably, ill test it out tomorrow


Eradicate all Console Logs modifies node_modules in Windows

Issue
Directory path is tested for node_modules with slashes
  if (dirPath.includes('/node_modules/')) {

In Windows, the path looks something like this, so the test fails
"c:\\Users\\<User>\\test\\node_modules\\js-tokens"

Fix
Test only for node_modules string without slashes

Thanks for this!


Allow negative gravity scale again

I use a negative gravity scale at body definition all the time in v2.4 to make light things like bubbles float upwards, and adjust it per frame for any body in water, allowing certain objects to float. Unfortunately several assertions prevent this from being treated as a valid input, requiring that gravityScale >= 0.0f. I'm hoping this is not intentional.

#119


ARTEMIS-3677 mitigate NPE when browsing messages

More comprehensive unit tests of the actual changes would have been nicer than a systest, the related areas already have unit tests that could be easily adapted. The systest also looks to only use Core and so wouldnt seem to cover the original change at all, given it was in AMQPMessage only.

I added a unit test and an AMQP-specific test via 0bc7bf3f7ca2cd1508291f85ba5589430e5bae27.
To be clear, the original problem was observed with core, not AMQP. The original core systest failed without the fix.


Fix XFA links (bug 1735738)

At the end the anchor tag inside the button wasn't the problem here, after comparing the reference file and this one

https://bug1716758.bmoattachments.org/attachment.cgi?id=9240360

I realized that in the reference file the anchor tag has an inline display and couldn't receive any height. After changing the display to inline-block it started working but since it receives a 100% height the text wasn't showing properly so I added an absolute position and now the reference file it's working in both Firefox nightly and Chrome.
It also solves a bug in this file

https://bug1716758.bmoattachments.org/attachment.cgi?id=9240360

Where the second link in schedule II wasn't working at all, now all links in both files are working just fine.
Thank you @calixteman for explaining me with so much patience!
closes #14139

Can you please provide a bit more detail in the commit message as well (since it's currently a single sentence), and not just in the PR description?
Generally it's always a very good idea if it's possible to understand what a patch does and why from the commit message too, since that's often most helpful when looking at a patch on the Git command line (e.g. during bisecting).


Add support for dropdown answer in detail answer

What is the context of this PR?

Adds support for dropdown answer types in detail answer.
Adds support to override default select field placeholder text.
Initial renames of detail answer schemas to improve consistency.

How to review
Test using test_checkbox_detail_answer_dropdown.json or test_radio_detail_answer_dropdown.json

Ensure a dropdown in a detail answer behaves as expected.

Requires:

https://github.com/ONSdigital/eq-questionnaire-validator/pull/82
https://github.com/ONSdigital/eq-translations/pull/71

Checklist

[ ] New static content marked up for translation
[x] Newly defined schema content included in eq-translations repo

It works as expected, but I am struggling with the tests. There seems to be a lot of functional tests, which some are not needed or could be integration. The ones there could do with a quick second read. I stopped short of the 2nd load of functional tests

I avoided integration tests on purpose. We shouldn't write integration test unless it can't be covered by unit tests which this can. The added functional test is because this is a feature and all features should have functional tests.


added news

added news
Checklist

[x] I followed the indications in the CONTRIBUTING
[ ] The documentation related to the proposed change has been updated accordingly (also comments in code).
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?
[x] Ready for review! :rocket:

superseded by #470


Class name is missing in Function when es6 target is set

I have decorator:
export function Document() {
   return function(objectConstructor: Function) {
        console.log(objectConstructor.name); // when targeting es5 it gives me what I want - the name of my class. When targeting es6 it does not give anything
    }
}

Here is decorator usage:
@Document()
export class User {
}

Im using "User" class name to create a document called "User", I need information how class is called. I always used es5, but now when I switched to es6 compile target I dont have information about class name anymore. Is it a bug, or it by design? If second then what is the way to get the class name?

It sounds like this a bug with your ES6 runtime, not a TypeScript bug.

Did a quick test. Work's fine in node latest foo.js:
"use strict";
class Foo {
}
console.log(Foo.name);
function Bar(){
}
console.log(Bar.name);

Here is what I'm running:
export function Document() {
    return function(objectConstructor: Function) {
        console.log(objectConstructor.name);
        console.log('Hello world');
    }
}

@Document()
export class User {
}
console.log(User.name);

And the result:

and looks like the problems is in the way it generates a "class", it does it without a name:
var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
    var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
    if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
    else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
    return c > 3 && r && Object.defineProperty(target, key, r), r;
};
var __metadata = (this && this.__metadata) || function (k, v) {
    if (typeof Reflect === "object" && typeof Reflect.metadata === "function") return Reflect.metadata(k, v);
};
function Document() {
    return function (objectConstructor) {
        console.log(objectConstructor.name); // when targeting es5 it gives me what I want - the name of my class. When targeting es6 it does not give anything
        console.log('Hello world');
    };
}
exports.Document = Document;
let User = class {
};
User = __decorate([
    Document(),
    __metadata('design:paramtypes', [])
], User);
exports.User = User;
console.log(User.name);

the issue is here: let User = class { };, if I change it manually to let User = class User { }; everything will work.
Im using typescript@next and running this code on node 4.1.2

let User = class { };, if I change it manually to let User = class User { }; everything will work.

Yup that would cause this error.

Here is some background: https://github.com/Microsoft/TypeScript/issues/2836#issuecomment-94581839
The issue is that classes really have two symbols, one visible inside the class, and one outside, if you are using a decorators, and the decorator changes the class constructor, this only affects the outer symbol. all accesses inside of the body of the class still bind to the original class name. the fix is to change the class into a class expression, this way we only have one symbol to bind against. but that means that Function.name is not set. the fix is to set the name property explicitly.
this was the original behavior, but then due to issue with Chrome/V8 this was not working (see issue #2836) so we disabled it in #3063. if V8 has addressed the issue, we should put back the name setting.

:+1:

Hi, @mhegazy thanks for setting #6420 as duplicate and directing me to know the underlying issue. I am struggling for it for a while.
From the comment "if you are using a decorators, and the decorator changes the class constructor, this only affects the outer symbol. all accesses inside of the body of the class still bind to the original class name", I can see why the code like 'let User = class {}' generated.
Currently, I didn't follow the workaround(setting the name explicitly) as I think the typescript code is correct while something wrong with the underlying transpiling mechanism and incorrect behaviour. In my scenario, I will NEVER change a class name as it will confuse others I think. To avoid further changes when the fix comes,  my workaround is:
I forked the typescript source code and made a minor change to let it generate code like 'let User = class User {}'. It works fine for me for now.
Please let me know if it is still dangerous :-)
Thanks again.

@TheLevenCreations, yes this fix is not correct. now decorators, and methods have a different view of the class, and that can cause different problems down the road. @rbuckton should have the correct fix out shortly.

@TheLevenCreations Classes in ES6 are specified to create two bindings for the class name, one in the scope in which the class is defined, and one inside the class body:
class A {
  a() { return A; }
}
let objA = new A();
A = undefined;
console.log(A === objA.a()); // false

This becomes a problem for decorators, if the class decorator replaces the constructor:
function logInstantiation(target) {
  return class extends target {
    constructor(...args) {
      super(...args);
      console.log("instantiated");
    }
  }
}
@logInstantiation
class C {
  newInstance() { return new C(); }
}

let objC = new C(); // logs "instantiated";
let objC2 = objC.newInstance(); // nothing is logged as 'C' is the original class

We at one point tried to address the fact that the Function#name is missing by setting the name on the result using:
Object.defineProperty(C, "name", { value: "C" });

While this is perfectly legal ES6, it only works in strict mode in Node v4. Also, we saw issues when people tried to further transpile ES6 output from TypeScript in Babel.
The only other approach we've considered so far is to create a temp variable and alias all references to the class inside the class body to this temp variable, effectively turning the original example above into this:
// input.ts
@Document
export class User {
  newInstance() { return new User(); }
}

// output.js
export class User {
  newInstance() { return new _a(); }
}
User = _a = __decorate([Document], User);
var _a;

Hi @rbuckton
Thanks for your full detailed explanation. Personally, I like the second approach, although it is a bit difficult to read.
Anyway, hope it will be fixed soon, and I will test my code again. Thank you :-)


deprecate root module

As we haven't maintained the root module for a while, it's time to deprecate the module.
@morgante @danisla  What do you think?

@namusyaka I agree
@danisla Can you approve as well?

LGTM


Version 2.7.2

Milestone: 2.7.2
Merged PRs: 42
Please help in testing this upcoming release!
Checklist:

[X] Draft the release notes
[ ] Update package.json version

See the release process for details.

Thanks for the great chart library.
Is there ETA for 2.7.2 release?


What could cause a problem with pyodbc and SQL Server tempdb?

What could cause a problem with pyodbc and SQL Server tempdb?
When executing a user stored procedure on some database on SQL Server, tempdb properties are not accessible and templog shrinking (for processes running parallel) is somehow blocked. The usp makes use of tempdb during execution.
Therefore, templog is growing infinitely if there is no “close” while debugging (and temporarily during regular execution).
Running the same usp with Excel Power query has no influence on accessing tempdb properties.

Have you tried connecting with autocommit=True to see if that makes any difference?

Thank you for your replies!
With "autocommit=True" the problem is solved in our use case.
Does it mean pyodbc is always using transactions for any executed SQL if auto commit is not set True?
Do I understand this right?


Added Voice assistance

Added voice assistance functionality in our project.
That is, other than typing the city name, we can also speak the city name and weather of that city will get displayed.

Fixed Issue #15

I know you are still waiting on reviews from @DinuBotan and @shravani05 but some of my recent PR's have caused some merge conflicts.
Also, I wasn't able to get the speech to text to work. Every time I clicked the mic icon, the slash would reappear a second or two after clicking it without clicking it a second time... does that make sense?
I'm using the Brave Browser on macOS and no errors occurred in the console.
However, after testing in Chrome it seems to work.
It also might be a good idea to set the search bar after updating the card based on the user's speech.

I know you are still waiting on reviews from @DinuBotan and @shravani05 but some of my recent PR's have caused some merge conflicts.
Also, I wasn't able to get the speech to text to work. Every time I clicked the mic icon, the slash would reappear a second or two after clicking it without clicking it a second time... does that make sense?
I'm using the Brave Browser on macOS and no errors occurred in the console.
However, after testing in Chrome it seems to work. I'd suggest either debugging on the Brave Browser or disabling the feature when !(navigator.brave && await navigator.brave.isBrave()).
It also might be a good idea to set the search bar after updating the card based on the user's speech.

Yaa, I should have taken care of supported browsers. These are the supported browsers -

Chrome (desktop): this is by far the smoothest experience
Safari 14.1
Microsoft Edge
Chrome (Android): a word of warning about this platform, which is that there can be an annoying beeping sound when turning the microphone on. This is part of the Android OS and cannot be controlled from the browser
Android web view
Samsung Internet
I have added a function that only displays the microphone icon if the browser is supported one.
Regarding the displaying value in the search bar actually earlier we were searching weather based on city, but now we are searching based on coordinates so there were some issues regarding that that have been resolved in one of the pull request. I guess it would be good to merge that PR first and then I can make changes to prevent conflicts.

Looks good and the voice assistance works nicely, but it only updates the location name and doesn't actually update the forecast for that location. I think that's because right now the forecast is fetched based on a city's coordinates and not on its name.

If so, then you would need to find a way to get the coordinates of the location that the user is saying or make requests to the API based on the city name instead of coordinates like we were doing initially (but this comes with a small problem that was solved in issue #21 ).
If you decide to go with the coordinates way and need some help, let me know.

Ya, I changed that. I added a function to get the coordinates of the city that we will speak and I am setting those coordinates. So able to fetch the correct data. However, I am not sure how to update the search bar because it is an Autocomplete component so you can set a default value at the beginning but not sure if we can change the value. Any idea about this?

Ya, I changed that. I added a function to get the coordinates of the city that we will speak and I am setting those coordinates. So able to fetch the correct data. However, I am not sure how to update the search bar because it is an Autocomplete component so you can set a default value at the beginning but not sure if we can change the value. Any idea about this?

However, the name of the place of the weather card is showing different, that issue has been fixed by Pratyush in the previous PR.

If you don't have any luck with this I can try looking for a solution tomorrow.
Also, the voice button still seems to show up in Brave (and not work). Maybe the little code snippet I gave you was bad?

Ya actually the npm library that I am using for this had a function to see if the current browser is supported or not, so I used that and it was working as Firefox is not a supported browser so it was not showing the microphone, not sure why it is not happening with Brave. I will put the condition you gave and see

The only thing remaining is to update the search bar with that place name, but I am not able to understand how to change the value as it is an Autocomplete component and has only a default value parameter.

Does everything looks ok now ?


notice of derriviative

thank you so much for prompt quill! I've really enjoyed playing with it.
I've created a minimal cli interface for the prompts_large_meta dataset:
https://github.com/hexive/prompt-cli
I wanted to reach out and make sure you were okay with the name and how I did the Apache NOTICE, etc as a derivative of your work.

Thank for letting me know. Im happy with any usage, and if you point back to me as the source I'm even more happy :) So just keep going and have as much fun with it as you can.


fix: made the COMFYUI_FLUX_FP8_CLIP environment variable bool instead of str

Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:

[x] Target branch: Please verify that the pull request targets the dev branch.
[x] Description: Provide a concise description of the changes made in this pull request.
[x] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
[x] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
[x] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
[x] Testing: Have you written and run sufficient tests for validating the changes?
[x] Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
[x] Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:

BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry
Description
in #4300, I accidentally defined COMFYUI_FLUX_FP8_CLIP as a string instead of a boolean in config.py - which upsets Pydantic when it's not set and therefore is an empty string
Added
n/a
Changed
COMFYUI_FLUX_FP8_CLIP is now expected to be "true" or "false", defaulting to "false".
Deprecated
n/a
Removed
n/a
Fixed
this PR should fix #4328
Security
n/a
Breaking Changes
n/a

Additional Information
I built the Dockerfile and pushed it to ghcr.io/johnthenerd/open-webui:comfyui-fix - something is preventing me from running the GitHub Actions since my last round of PR's (GHCR just 403s in the push stage) and I'd rather get the fix out instead of investigating it.
This does mean I only have the x86 image without CUDA or ollama in that tag above since I just build and push from my laptop, but it should suffice for testing.
Screenshots or Videos
environment variable not set, before this PR:

I'm not able to provide an "after this PR" screenshot with fp16 (which is the default without the variable set) as I do not have enough RAM/VRAM to do so and therefore my entire server starts thrashing when I try. I can however confirm that the error message no longer appears and the ComfyUI request is set correctly regardless of the environment variable.

Thanks!


Tests fail

Hi, visit_test from current trunk produces the following result.
$ ./visit_test

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
visit_test is a Catch v2.5.0 host application.
Run with -? for options

-------------------------------------------------------------------------------
Scenario: single variant visit
      Given: a variant and a visitor
   And when: visited when empty with exception
       Then: visit throws bad_variant_access
-------------------------------------------------------------------------------
/home/fabio/Projects/visit/tests.cpp:80
...............................................................................

/home/fabio/Projects/visit/tests.cpp:82: FAILED:
  REQUIRE_THROWS_AS( rollbear::visit(visitor, v), std::bad_variant_access )
because no exception was thrown where one was expected:

-------------------------------------------------------------------------------
Scenario: multi variant visit
      Given: two variants and a visitor
   And when: visited when empty with exception
       Then: visit throws bad_variant_access
-------------------------------------------------------------------------------
/home/fabio/Projects/visit/tests.cpp:130
...............................................................................

/home/fabio/Projects/visit/tests.cpp:132: FAILED:
  REQUIRE_THROWS_AS( rollbear::visit(visitor, v1,v2), std::bad_variant_access )
because no exception was thrown where one was expected:

-------------------------------------------------------------------------------
Scenario: mixed types visit
      Given: two variants, a unique_ptr and a visitor
   And when: either variant is valueless by exception
       Then: visit throws bad_variant_access
-------------------------------------------------------------------------------
/home/fabio/Projects/visit/tests.cpp:214
...............................................................................

/home/fabio/Projects/visit/tests.cpp:214: FAILED:
due to a fatal error condition:
  SIGSEGV - Segmentation violation signal

===============================================================================
test cases:  3 |  0 passed | 3 failed
assertions: 21 | 18 passed | 3 failed

For reference:
$ c++ --version
c++ (Ubuntu 10.2.0-5ubuntu1~20.04) 10.2.0
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Thank you. I'll look into it.

So, this one's curious. It depends on the version of the C++ standard library. I'm not yet sure why some versions do not cause the invariant to be valueless_by_exception. I think they should be, but maybe I misread the standard, but if I do, it seems like at least some maintainers of the std also do.

Got a response. The libstdc++ devs are clever. The idea is not wrong, but the test code is too trivial for the clever lib devs, so I need to think a bit about how to write better tests.
https://twitter.com/BarryRevzin/status/1361826113543110657

I'm not entirely convinced that the clever dev's of libstdc++ are following the requirements from the standard document, though:
http://eel.is/c++draft/variant.variant#variant.mod-7
As I understand it, .emplace<> must first destroy, and then try to construct.
But my interpretation is kind of meaningless, because the lib is out there and in wide use (and I actually like the implementation better than my interpretation of the standard.)

This was a heck of a lot trickier to fix than I ever thought.

Hey, that was an interesting discussion on Twitter. I tend to agree with what the other guy said: even though the sequence of steps is the one you mention, given that the object is permitted to be in valueless state, but not mandated to do so, an observer can't meaningfully see the difference, unless they know about the internals of the variant.
This means that a test which is implementation-agnostic can't be performed, I guess?
Thanks for your time and effort! I spent the last 4 days digging into variants and visitation thereof, implementing my own stuff and comparing it with yours, the standard and mpark. It's been an interesting learning experience.


Uncaught TypeError: Cannot read property 'dispose' of undefined

[Enter steps to reproduce below:]

close last open file with :q  (no changes in file)
exception thrown
was using autohide-tree-view package

Atom Version: 1.0.19
System: Mac OS X 10.10.5
Thrown From: ex-mode package, v0.7.0
Stack Trace
Uncaught TypeError: Cannot read property 'dispose' of undefined
At /Users/placrosse/.atom/packages/ex-mode/lib/ex-state.coffee:59

TypeError: Cannot read property 'dispose' of undefined
  at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:25:28
  at Set.forEach (native)
  at CompositeDisposable.module.exports.CompositeDisposable.dispose (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:24:26)
  at disableAutohide (/Users/placrosse/.atom/packages/autohide-tree-view/lib/autohide-tree-view.js:72:15)
  at stop (/Users/placrosse/.atom/packages/autohide-tree-view/lib/main.js:117:43)
  at updateActivationState (/Users/placrosse/.atom/packages/autohide-tree-view/lib/main.js:92:45)
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
  at PaneContainer.module.exports.PaneContainer.didDestroyPaneItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:284:27)
  at Pane.module.exports.Pane.removeItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:410:17)
  at Pane.module.exports.Pane.destroyItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:466:16)
  at Pane.module.exports.Pane.destroyActiveItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:443:12)
  at Ex.quit (/Users/placrosse/.atom/packages/ex-mode/lib/ex.coffee:75:36)
  at Ex.q (/Users/placrosse/.atom/packages/ex-mode/lib/ex.coffee:77:10)
  at /Users/placrosse/.atom/packages/ex-mode/lib/ex.coffee:1:1
  at Command.execute (/Users/placrosse/.atom/packages/ex-mode/lib/command.coffee:153:7)
  at ExState.processOpStack (/Users/placrosse/.atom/packages/ex-mode/lib/ex-state.coffee:53:17)
  at ExState.pushOperations (/Users/placrosse/.atom/packages/ex-mode/lib/ex-state.coffee:43:6)
  at ExViewModel.ViewModel.confirm (/Users/placrosse/.atom/packages/ex-mode/lib/view-model.coffee:13:14)
  at ExViewModel.module.exports.ExViewModel.confirm (/Users/placrosse/.atom/packages/ex-mode/lib/ex-view-model.coffee:35:5)
  at ExViewModel.confirm (/Users/placrosse/.atom/packages/ex-mode/lib/ex-view-model.coffee:1:1)
  at ex-command-mode-input.ExCommandModeInputElement.confirm (/Users/placrosse/.atom/packages/ex-mode/lib/ex-normal-mode-input-element.coffee:46:16)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:245:29)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:524:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:347:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:184:20)

Commands
  7x -0:28.7.0 vim-mode:move-down (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:27.5.0 vim-mode:move-up (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
 24x -0:27.2.0 vim-mode:move-down (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:14.7.0 tree-view:toggle (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
  2x -0:12.5.0 tree-view:toggle-focus (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
  4x -0:11.1.0 core:move-down (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -0:09.9.0 tree-view:open-selected-entry (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
  2x -0:07.9.0 vim-shift-movers:shift-text-down (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
  2x -0:06.8.0 vim-shift-movers:shift-text-up (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
  4x -0:05.9.0 vim-mode:undo (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:03.5.0 ex-mode:open (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:03.1.0 core:confirm (atom-text-editor.editor.mini.is-focused)
  2x -0:03.1.0 blur (atom-text-editor.editor.mini.is-focused)
     -0:01.3.0 ex-mode:open (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:01.3.0 blur (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:00.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "autocomplete-css",
      "autocomplete-atom-api",
      "autocomplete-html",
      "welcome",
      "update-package-dependencies",
      "spell-check",
      "package-generator",
      "metrics",
      "link",
      "language-yaml",
      "language-source",
      "language-shellscript",
      "language-sass",
      "language-ruby-on-rails",
      "language-ruby",
      "language-python",
      "language-property-list",
      "autosave",
      "exception-reporting",
      "language-c",
      "language-clojure",
      "language-coffee-script",
      "language-csharp",
      "language-css",
      "language-gfm",
      "language-go",
      "language-hyperlink",
      "language-java",
      "language-javascript",
      "language-less",
      "language-objective-c",
      "language-perl",
      "language-php"
    ]
  }
}

Installed Packages
# User
autohide-tree-view, v0.25.1
clipboard-plus, v0.5.1
ex-mode, v0.7.0
language-rust, v0.4.5
linter, v1.9.1
linter-rust, v0.2.10
minimap, v4.15.0
minimap-git-diff, v4.1.8
racer, v0.17.2
relative-numbers, v0.2.4
remember-file-positions, v0.1.6
rust-api-docs-helper, v0.5.1
vim-mode, v0.62.0
vim-mode-clipboard-plus, v0.1.0
vim-shift-movers, v0.1.3
vim-surround, v0.8.0
web-browser, v1.5.0

# Dev
No dev packages

:white_large_square: https://github.com/jdc0589/jsformat-atom/issues/39


Copy image/webp

Hi there,
the package is awesome and I do have very good results. Thanks for sharing!
On Android I am encountering an Issue. I want to paste a sticker into the keyboard's inputfield while WhatsApp is open. On iOS WhatsApp opens the  image/webp file in WhatApps's sticker view. But on Android it opens the WhatApp's image view. I noticed that you are using image/png as mime type:
https://github.com/Numanshakir/flutter_image_clipboard/blob/ac0882b8271c24ffedd40f57facd68e67e66afe6/android/src/main/kotlin/com/example/flutter_image_clipboard/FlutterImageClipboardPlugin.kt#L69
I forked your pub and changed to image/webp (tried with image/webp.wasticker as well), but still WhatsApp handles the file as normal image and opens the image view and not the sticker view. Any hints?

@sebastianspross  Thanks for your time ! I will check this issue and update the plugin again .


python3Packages.openai: 0.27.7 -> 0.27.8

Description of changes
Update to latest version. No changes that effect build.
Diff: https://github.com/openai/openai-python/compare/refs/tags/v0.27.7...v0.27.8
Changelog: https://github.com/openai/openai-python/releases/tag/v0.27.8
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 236383 run on x86_64-darwin 1

2 packages marked as broken and skipped:

khoj
khoj.dist

2 packages failed to build:

checkov
checkov.dist

15 packages built:

chatblade
chatblade.dist
chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist
imaginer
openai (python310Packages.openai)
openai-full
openai-full.dist
openai.dist (python310Packages.openai.dist)
python310Packages.langchain
python310Packages.langchain.dist
python311Packages.openai
python311Packages.openai.dist
shell-genie
shell-genie.dist

Result of nixpkgs-review pr 236383 run on aarch64-darwin 1

2 packages marked as broken and skipped:

khoj
khoj.dist

2 packages failed to build:

checkov
checkov.dist

15 packages built:

chatblade
chatblade.dist
chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist
imaginer
openai (python310Packages.openai)
openai-full
openai-full.dist
openai.dist (python310Packages.openai.dist)
python310Packages.langchain
python310Packages.langchain.dist
python311Packages.openai
python311Packages.openai.dist
shell-genie
shell-genie.dist

Result of nixpkgs-review pr 236383 run on aarch64-darwin 1

2 packages marked as broken and skipped:

khoj
khoj.dist

2 packages failed to build:

checkov
checkov.dist

15 packages built:

chatblade
chatblade.dist
chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist
imaginer
openai (python310Packages.openai)
openai-full
openai-full.dist
openai.dist (python310Packages.openai.dist)
python310Packages.langchain
python310Packages.langchain.dist
python311Packages.openai
python311Packages.openai.dist
shell-genie
shell-genie.dist

@SuperSandro2000, can you merge if this looks good to you?

@ofborg build python310Packages.openai


Add coverage library

This PR is to facilitate PR 2784 in the compilers repo to add code coverage support

Can you complete the CLA first? Don't forget to log in to it after signing, and cla-check will work fine the next time you commit to rerunning the action.

Already did, will trigger the pipeline by force pushing some time later. BTW I'm that intern working on coverage the last few days.

after second thoughts, the added String::escape is only useful for coverage, we can keep it internal to such package. The PR is good to go modulo my last two comments

Maybe it's useful for debug outputting strings?


Question regarding the high level mechanics of ADOP

Hi Darius, very impressive work!
I'd like to understand better where this fits in in the overall landscape and therefore have some questions:
a) The way I understand it ADOP needs to be trained individually per dataset, correct? If so, how long does such training take, roughly, as a function of # of input points or images?
b) Once trained how large (GBs) will the resulting trained model, descriptors etc. be?
c) If novel views are desired, does each novel view have to be pre-specified at training-time? Or can novel views be synthesized on-the-fly based on user input/navigation and the trained model?
Again, great work and super exciting stuff!
Kind regards

Also have a question about the output result:
Is the result only an .mp4 video or is it also possible to export scenes as some kind of 3d model. For further export may be to 3d max/blender?

The underlying 3D model is a point cloud. You could export that but there would be no real benefit because other software is not able to interpret the neural color of each point.

The underlying 3D model is a point cloud. You could export that but there would be no real benefit because other software is not able to interpret the neural color of each point.

Could you not convert the point cloud to a model with something like Meshlab?
Or would the detail loss be too much?
(Also, even tough I need to intall Linux, I am exited to try this out, it looks very well made, and with lots of potential! Keep up the amazing work!)


feat: Expand environment variables in --args= which contains lowercase symbols, like ${TF_VAR_lowercase}

Put an x into the box if that apply:

[ ] This PR introduces breaking change.
[ ] This PR fixes a bug.
[ ] This PR adds new functionality.
[x] This PR enhances existing functionality.

Description of your changes
Improves https://github.com/antonbabenko/pre-commit-terraform?tab=readme-ov-file#all-hooks-usage-of-environment-variables-in---args
Found in https://github.com/antonbabenko/pre-commit-terraform/issues/718#issuecomment-2347102202
Support of this option probably will not be needed in any observed use cases, but it is cheap to implement, so here we are

This PR is included in version 1.96.0 :tada:


Timesheet - 22/04/2021 - Dmitry Mugtasimov

Task 1
Reviewed PRs
Proof of Work

https://github.com/thenewboston-developers/thenewboston-node/pull/119

Time Spent
0.5 hours

Total Time Spent
0.5 hours
Account Number
757d598308bf1e2943bd1a9fc34ae7b8951ca864d64228b59e62614b27ddefc4

Approved

Approved

looks like you forgot to put the "paid" lable here


Typo Update README.md

Description:
I found a minor inconsistency in the text of the interactive section. The term "variable names" is used throughout, but in one part it says "Reset variables names," which is grammatically incorrect. This should be corrected to "Reset variable names" to ensure consistency and clarity.
Importance:
While this is a small typo, it improves the readability and professionalism of the documentation. Consistency in terminology helps users better understand the functionality and avoids confusion.
Changes:

Corrected the phrase "Reset variables names" to "Reset variable names."

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Move GPL code to gpl subdirectory

WIP
Done:

classifier

#3786

there's a problem actually with the cmake file i think; some ___ gets added from somewhere in the build directory path, see:
build/src/shogun/CMakeFiles/libshogun.dir/__/gpl/shogun/

although this is not related to this PR rather in general of the gpl build

Fine to merge this despite the formatting errors? I will fix the cmake thing after having moved the files ...


Import error: No module named 'models.ops.depthconv._ext.depthconv._depthconv'

Hi, when I try to run train.py, this import error occurs. Any clue why this happens? Thank you.

You have to compile it first. Scripts for that is written in the directory script.

Thanks for the help.
I have already run the scripts and compile submodules. No errors occurred during the procedure. However the problem still exits.