how to handle a PDF(including tables..)

Issue you'd like to raise.
Hello
I have to configure the langchain with PDF data, and the PDF contains a lot of unstructured table.
We have a string and a table, so how do you recommend handling it?
Suggestion:
No response

🤖
Hello @girlsending0! Nice to see you again. I hope your project is going well. Let's take a look at your new issue.
To handle PDF data in LangChain, you can use one of the provided PDF parsers. These parsers include PDFMinerParser, PDFPlumberParser, PyMuPDFParser, PyPDFium2Parser, and PyPDFParser.
For unstructured tables and strings, you might find PDFPlumberParser or PDFMinerParser useful as they are known for their capabilities in handling such data.
Here's how you can import and use one of these parsers:
from langchain.document_loaders.parsers.pdf import PDFPlumberParser

# Initialize the parser
parser = PDFPlumberParser()

# Load your PDF data
data = parser.load('path_to_your_pdf_file')

# Now you can process the data
processed_data = parser.process(data)

Please replace 'path_to_your_pdf_file' with the actual path to your PDF file. The load method reads the PDF file, and the process method processes the loaded data.
Please note that the actual methods and their usage might vary depending on the parser. The above code is a general example and might not work as is. Please refer to the specific parser's documentation or source code for exact usage details.
LangChain provides several PDF parsers, each with its own capabilities and handling of unstructured tables and strings:

PyPDFParser: This parser uses the pypdf library to extract text from PDF files. It can also extract images from the PDF if the extract_images parameter is set to True. The images are then processed with RapidOCR to extract any text. This parser does not have specific handling for unstructured tables and strings.
PDFMinerParser: This parser uses the PDFMiner library. It can concatenate all PDF pages into a single document or return one document per page based on the concatenate_pages parameter. It can also extract images and process them with RapidOCR. This parser does not have specific handling for unstructured tables and strings.
PyMuPDFParser: This parser uses the PyMuPDF library. It can extract text and images (processed with RapidOCR) from PDF files. It does not have specific handling for unstructured tables and strings.
PyPDFium2Parser: This parser uses the PyPDFium2 library. It can extract text and images (processed with RapidOCR) from PDF files. It does not have specific handling for unstructured tables and strings.
PDFPlumberParser: This parser uses the PDFPlumber library. It can extract text and images (processed with RapidOCR) from PDF files. It also has a dedupe parameter that can be used to avoid duplicate characters.
AmazonTextractPDFParser: This parser uses the Amazon Textract service. It can process both single and multi-page documents, and supports JPEG, PNG, TIFF, and non-native PDF formats. It can also linearize the output, formatting the text in reading order and outputting information in a tabular structure or outputting key/value pairs with a colon (key: value). This can help language models achieve better accuracy when processing these texts.

In summary, all parsers can extract text and optionally images from PDF files, but they do not have specific capabilities for handling unstructured tables and strings, except for the AmazonTextractPDFParser which can linearize the output.
You can find more details about these parsers in the LangChain repository.
I hope this helps! If you have any other questions, feel free to ask.
Sources

feat: Add Linearized output to Textract PDFLoader
libs/langchain/langchain/document_loaders/parsers/init.py
libs/langchain/langchain/document_loaders/parsers/pdf.py

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
If you want to continue the conversation, start your reply with @dosu-bot.
what else I need to do for fetching unstructured table in pdf into some meaning ful format?
loader = PyPDFLoader(file_path)
document = loader.load()
text_splitter = RecursiveCharacterTextSplitter(chunk_size=1000, chunk_overlap=0)
texts = text_splitter.split_documents(documents=document)

@girlsending0 did above asked query resolved by you?

@deepak-habilelabs no... that's very simple answer...
can you solve these problem?

@deepak-habilelabs no... that's very simple answer... can you solve these problem?

No till now, can u pls assist me in solving these?
loader = PyPDFLoader(file_path)
document = loader.load()
text_splitter = RecursiveCharacterTextSplitter(chunk_size=1000, chunk_overlap=0)
texts = text_splitter.split_documents(documents=document)
How can I further proceed?

Please add the solution here. This looks like a tricky thing to do, if somehow this loader identifies this tables/charts and extract it's meaning and convert it into string explaining it, generate embedding and then interact with it.
Not sure how a simple loader will do that though.

Please add the solution here. This looks like a tricky thing to do, if somehow this loader identifies this tables/charts and extract it's meaning and convert it into string explaining it, generate embedding and then interact with it.
Not sure how a simple loader will do that though.

@pranjaldoshi96 did any one try UnstructuredPDFLoader?

@dosu-bot.
Is extracting images from pdf feature available in langchain js version as well, or is this something that can be done only with python version ?

@riturajgc for extracting images from pdf, u simply have to set a parameter " extract_images=True" in pypdf loader

https://medium.com/@knowledgrator/extract-custom-table-from-pdf-with-llms-2ad678c26200
just give it a try, I hope this also works for you all :))


fix(startup): Better error handling at startup

:tada: This PR is included in version 7.1.6 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Add an API to get the current fade color of the GUI…

…(for a specific reason)
The reason being, I want to set the GUI alpha to some value, and draw other things from my code using that value, too, which does not rely on raygui's GUI calls, might be a handy edition.
I believe this actually does get used during development of applications that does not use only raygui, but add their own addition of some codes, too.

@anstropleuton Sorry, I think this function is not required by raygui, user can store alpha on user side if really required.


Question: CL Vs GLES on a Mali Midgrad T864MP4

Output of 'strings libarm_compute.so | grep arm_compute_version':
san@san-Thinkpad-T440S:~/san/ComputeLibrary/build$ strings libarm_compute.so | grep arm_compute_version
arm_compute_version=v18.11 Build options: {'embed_kernels': '1', 'gles_compute': '1', 'arch': 'arm64-v8a', 'opencl': '1', 'neon': '1', 'benchmark_tests': '1', 'validation_tests': '1', 'asserts': '1', 'debug': '0', 'os': 'android', 'Werror': '1'} Git hash=3d2d44ef55ab6b08afda8be48301ce3c55c7bc67

Platform: RK3399
Operating System: Android

Problem description: Question: CL Vs GLES on a Mali Midgrad T864MP4
Hi,
We are evaluating CL vs GLES for our graph on a Mali Midgrad (T864MP4) GPU. Our platform supports OpenGL ES 3.2 (which shader compute), that is required for GLES.
As I understand (I'm no GPU/Graphics expert, btw), the Midgrad GPU architecture uses Shader Cores, which handles both the vertex and the fragment processing. It also includes a Tile based renderiung.
I'm using DS-5 Streamline (Ultimate Edition), to see which of the GPU cores are being used for CL and GLES.
To my surprise, the streamline shows same load (or almost simillar) for both CL and GLES.
Streamline output for ./graph_googlenet  --target=CL

Streamline output for ./graph_googlenet  --target=gles --layout=NCHW

The GPU activity (in terms of load) in both of the above streamline output is the same. Meaning, the way the GPU is being used is almost the same, with only 'GPU Vertex-Tiling-Compute" activity showing-up for both CL and GLES. However, there could be some difference in performance between CL and GLES. I was expecting something to show up on "GPU Fragment" Activity for GLES.
Questions:

Is this the expected behaviour on the GPU activity for both CL and GLES on a Midgrad GPU?
Am I missing any important Streamline Counter that differentiates the load usage of CL vs GLES?
The "GPU Fragment" Activity always show 0% usage. Is this the expected behaviour?

Thanks. Appreciate any pointers, inputs, that helps us in evaluating CL Vs GLES on our platform.

Could someone throw some light, please?
@giuseros any thoughts?
Thanks,
San

Hi San,
GPU Vertex-Tiling-Compute and GPU Fragment are just hardware counter names, they don't actually mean they're run on different cores.
The HW counters only show that the GPU utilisation might be similar between the two APIs.
I would recommend highlighting a range on your counters to see what the average utilisation is, as sometimes it might be very different but isn't visible at the zoomed out level.
Assuming both APIs reach a similar GPU utilisation level, you need then to take into account how optimised the code is: OpenGLES and OpenCL are very different APIs, and it's not always possible to implement all the optimisations in both languages, therefore OpenGLES might reach the same level of hardware utilisation as OpenCL but because its code is less optimised it will take longer to process the whole workload.
Hope this helps,

Thanks @AnthonyARM for your inputs.
GPU Vertex-Tiling-Compute and GPU Fragment are just hardware counter names, they don't actually mean they're run on different cores.
Do you mean that these two  counters are doing the same job? If yes, I'm wondering why gatord is exposing two counters for the same Activity. If not,  could you please let me know the difference between  GPU Vertex-Tiling-Compute and GPU Fragment counters? When will something show-up on the GPU Fragment activity counter?
By zooming-in the streamline output I coud see the difference in actual GPU utilization.
therefore OpenGLES might reach the same level of hardware utilisation as OpenCL but because its code is less optimised it will take longer to process the whole workload.
Agree, that makes sense.
Thanks,
San

I think these counters are only meant to describe the nature of the job currently running on the core.
You can refer to Mali Midgard Family Performance Counters for more details

Thanks @AnthonyARM, for your inputs.


Handling older package dependencies

Hi,
My R package requires an older version of a particular dependency. In my package DESCRIPTION, I require Imports: RcppArmadillo (== 0.4.650.1.1)
In my .travis.yml I just use
install:
  ## For installing all CRAN dependencies using DESCRIPTION
  - ./travis-tool.sh install_deps

to install my dependencies.
My package has passed all R CMD check and R CMD BiocCheck but the travis testing is failing due to the following error Package required and available but unsuitable version: ‘RcppArmadillo’
From the travis log file, I can see that RcppArmadillo is being installed but the version isn't being taken into consideration.
Is there a way to have travis install particular versions of an R package instead of the latest?
Thanks for the help!
Best,
Jean

hi jean -- do you have a link to a failing build?

Here you go: https://travis-ci.org/hms-dbmi/scde/builds/74557923
Let me know if you need anything else. Thanks!

Thanks so much for the help, Craig!
Just FYI, I merged your pull but since my package has a few warnings associated, travis failed since you had set 'WARNINGS_ARE_ERRORS=1'. I tried changing to WARNINGS_ARE_ERRORS=0 in this build but still got the following error Found warnings, treated as errors. Clear or unset the WARNINGS_ARE_ERRORS environment variable to ignore warnings. I removed WARNINGS_ARE_ERRORS in the latest build and now the build is passing. I'm not sure if this is a bug, or if I needed to set to 0 in quotes.
Thanks again!

i only added that because you'd had warnings_are_errors: true in the file when I started.
The code will treat warnings as errors if that variable is present at all; the right way to skip it is to drop that line, which it sounds like you hit on. ;)
also, i forgot to mention: there's also the option of switching to language: r, which would simplify your config a little more. however, given that you're not using latex, it'll just slow down your builds a bit (since you'd be installing latex every time). if you end up wanting to start building manuals, lemme know and i'll help you switch over.


Update stlSerializer.ts

Add boolean option to not bake mesh transforms on export

that was fast! 😄

we are code freezing so it was last minute but it made it :)


Allow test success messages to be written to stdout

Closes #18
Macros updated with new parameter, with a default value of false to preserve behaviour of existing implementations.

Thank you for the pull request. But, doesn't the --debug option meet your requirements? It enables us detailed logs on screen.
https://docs.getdbt.com/reference/global-configs/logs#debug-level-logging

@yu-iskw I mentioned on the linked issue that --debug introduces a lot of noise into the console. This change allows only the 'SUCCESS' message to be printed, instead of every other debug-level log event.

I see. I don't completely understand what you want to get information. Indeed, the changes enable us to show SUCCESS. However, we can't get what unit tests are passed. Can you elaborate on the motivateion in detail?
In my case, I use the macro to call all other macros of unit tests. I don't think it gives us meaningful information.
https://github.com/yu-iskw/dbt-unittest/blob/main/integration_tests/macros/tests/test_macros.sql
$ cd integration_tests/
$ bash run_unit_tests.sh

14:19:46  Running with dbt=1.7.2
14:19:46  Installing ../
14:19:46  Installed from <local @ ../>
14:19:47  Running with dbt=1.7.2
14:19:48  Registered adapter: bigquery=1.7.0
14:19:48  Found 0 sources, 0 exposures, 0 metrics, 468 macros, 0 groups, 0 semantic models
14:19:48  SUCCESS
14:19:48  SUCCESS
14:19:48  SUCCESS
14:19:48  SUCCESS
14:19:48  SUCCESS
14:19:48  SUCCESS
...

I saw the same thing as you, then I changed my run_unit_tests() macro to be similar to this:
{% macro run_unit_tests() %}
  {% set unit_tests = ['test_1()',
                       'test_2()',
                       'test_3()',
                       ]
   %}

  {% for unit_test in unit_tests %}
    {% do log("Running " ~ unit_test, info=true) %}
    {% do unit_test %}
  {% endfor %}

{% endmacro %}

So that my console output looks like:
13:11:33  Running with dbt=1.6.9
13:11:33  Registered adapter: snowflake=1.6.5
13:11:34  Found 593 models, 918 tests, 231 sources, 29 exposures, 0 metrics, 892 macros, 0 groups, 0 semantic models
13:11:34  Running test_1()
13:11:34  Running test_2()
13:11:34  Running test_3()

I think it would be more useful to see explicit confirmation that the tests have succeeded, without the console being filled with every single debug-level message:
13:11:33  Running with dbt=1.6.9
13:11:33  Registered adapter: snowflake=1.6.5
13:11:34  Found 593 models, 918 tests, 231 sources, 29 exposures, 0 metrics, 892 macros, 0 groups, 0 semantic models
13:11:34  Running test_1()
13:11:34  SUCCESS
13:11:34  Running test_2()
13:11:34  SUCCESS
13:11:34  Running test_3()
13:11:34  SUCCESS

I've implemented this so that it's off by default – users who don't want to see SUCCESS written to stdout don't have to do anything different in how the implement the macros.

Does that work in your case? I assume the for loop is stopped if {% do unit_test %} is failed. I don't still see strong reasons to support the standard output feature, as we can show full logs using the --debug option. And we may have solutions in your case without the changes as I showed.
  {% for unit_test in unit_tests %}
    {% do log("Running " ~ unit_test, info=true) %}
    {% do unit_test %}
    {% do log("Passed " ~ unit_test, info=true) %}
  {% endfor %}


Fix docker image + CI

Summary
Fixing the Docker images and add a docker CI workflow.
Details

Changed context of the Dockerfiles so that they build from the local sources rather than from an artifact pulled from GitHub. This allows to build/publish images at different tags from the CI (e.g. linbreux/wikmd:v1, linbreux/wikmd:1.2, linbreux/wikmd:main, linbreux/wikmd:pr-3 etc).
Fixed the environment variable that changed WIKI_DATA -> WIKI_DIRECTORY
The docker image does not change the permission of bind mounted volume anymore.
Populate bind mounted volume with the examples if it is empty
Update documentation
Add a docker CI workflow

Build docker image
Test docker image
Publish docker image

The 'publish' part of the CI workflow is disabled for now.
Checks
- [ ] In case of new feature, add short overview in docs/<corresponding file>

[x] Tested changes

Thanks for merging.
The Docker test currently fails on main because the tag 1.6 is not a proper semver: 1.6 is not a valid semver.. I'll give it a look later on.


did we can train the model?

it's a great job, thanks your release.  i want to know is there train code or only inference code release??

Hi. You may refer the exactly same training code to DynamiCrafter. It will also be added to this repo later.


introduce add_key_value_pair to cloud::Client

Bumps to the latest version of cloud-openapi.
Additionally, this PR fixes a few issues with spin login:

spin login with no personal access token will no longer cause an unwrap error
spin login with a personal access token will use the correct API client to list apps (cloud::Client instead of HippoClient)

Old behaviour:
><> ./target/release/spin login --auth-method token
Error: Login using the provided token failed. Run `spin login` or create a new token using the Fermyon Cloud user interface.

Caused by:

New behaviour:
><> ./target/release/spin login --auth-method token
Error: No personal access token was provided.


c: Add missing API to update and query active builtins.

Add missing C API to update and query active builtins to fix https://github.com/KhronosGroup/SPIRV-Cross/issues/1649

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.lukas.taparauskas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Support latest bazel and protobuf

Solve http archive errors with the latest bazel, and possible incompatibility with the latest protobuf library. Because of all of these incompatibilities, the bazel and protobuf dependencies of this project are strictly versioned, but we should update to support the latest versions.

Anything is gonna updates for this issue? I got a building error to use moonlight with conflicts on deprecated bazel components.

Hello,
Unfortunately there's not a lot of planning that goes into making the tensorflow/protobuf/bazel latest releases each play nicely together. If we get the latest bazel running, we probably still won't keep updating support for the latest version frequently, because something will probably break like this again. Now that bazel 1.0.0 is released, we might prioritize upgrading to it and hoping that it won't break again so often.
In the meantime, this should be pretty simple if you download the standalone bazel binary from the 0.20.0 release (linux-x86_64 or darwin-x86_64 with no suffix), keep that binary in your home directory, and use that specific binary to run "bazel build moonlight/..." (shouldn't need to repeat that command often).


Run purgeFilesystem in async way when deleting repo with content

As subject. Also add a test case for it.

LGTM.


Fixed a bug that a part of text is not visible in RichInput

close #69
Thakns in advance. I'm using this useful library. It helps me very well.
I fixed #69. Then, I checked all examples in storybook. It seems that this pull request does not break the examples. Could you take a look?

@junish
Looks nice! Could you fix the tsc error in ci?

@inokawa I fixed the tsc error. Could you taka a look again? Thanks.

Published in 0.22.4. Thanks!


Upgrade flyteidl and preload lb policy

TL;DR
Upgrade flyteidl and preload lb policy.
Type

[ ] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[ ] Smoke tested
[ ] Unit tests added
[x] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
This is to take in https://github.com/flyteorg/flyteidl/pull/301 and preload roundrobin load balancing policy.
Tracking Issue
Partially address flyteorg/flyte#2510
Follow-up issue
NA

@EngHabu Thanks for approving this. I also worked on https://github.com/honnix/flytepropeller/pull/1. Do you prefer we merge that into this PR, or ship this and then rebase? Thanks.

@honnix I agree... let's merge that into this first...

@honnix I agree... let's merge that into this first...

Done.


Upgrade alloyLogs

Towards: https://github.com/giantswarm/roadmap/issues/3518
This PR upgrade alloyLogs in order to fix an issue with component not being properly evaluated when the config changes
This would for example result in the new list of namespaces not being taken into account when selecting pods with discovery.kubernetes component.

Alloy v1.3.1 => v1.4.1
Helm chart v0.7.0 => v0.9.0
Breaking changes are not affecting our current usage, and are listed here https://github.com/giantswarm/alloy-app/blob/main/CHANGELOG.md#changed

Alloy upgrade PR https://github.com/giantswarm/alloy-app/pull/53

Superseded by https://github.com/giantswarm/observability-bundle/pull/248


Let user add their own template.

one fixed template per http server only allow few use cases
allowing users to provide their own template remove this limitation.

closed with commit 37eba52


[parsing error]  Typescript Parsing errors silently on

What did you expect to happen?
The code in

Thank you for posting this issue and sharing the repository.
However, I can't seem to reproduce the problem. Am I doing something wrong?

Got it. I can reproduce it by commenting out DEPRECATED__createDefaultProgram.
The problem is that the virtual files generated by the eslint processor cannot be parsed with types using typescript-eslint/parser.
For now, you must disable type checking for virtual files.
  {
    files: ["**/*.astro/*.ts"],
    languageOptions: {
      parserOptions: {
        project: null
      },
    },
    ...tseslint.configs.disableTypeChecked
  }

It is related to this issue.
https://github.com/ota-meshi/eslint-plugin-astro/issues/240#issuecomment-1687234674

Thank you for your time
Is it possible to provide feedback when it fails? Now it is failing silently and that makes it hard to understand what was going on
I was looking at the internals already, so I could try to help... see if I find how to feed the virtual file information and do a PR?
I don't know if I have enough time, but any hints/guidance on how I might be able to get started?

I don't know yet if there is a way to solve them. Maybe there are other problems besides this plugin, so we need to look into them one by one.


Strange behavior when trying to use onTapDown from Tapable and setting an angle other than zero

class LeafComponent extends SpeedComponent {
LeafComponent() : super('Leaf.flr', 'Show', 50, 50){
angle = math.pi * 2 * leafRand.nextDouble();
}
@override
void onTapDown(TapDownDetails details) {
// TODO: implement onTapDown
controller.Start([SpeedAnimation('Hide')]);
super.onTapDown(details);

}
}
when i change angle property and try to click on area 1 component dont see that, but if i click on area 2 it is ok.

The current tappable implementation doesn't consider the angle for bounding box detection. In fact, toRect never considers the angle because it returns an AA (axis-aligned) rectangle. My idea for fixing this is counter-rotating the point with respect to the anchor point and check collision on that space.
I normally use anchor center in which case this problem is barely noticeable if width ~= height.

This will be solved in v1.0.0-rc3
(Solved in PR #548)


Add animations to Nilesoft shell context menu

Add animations to Nilesoft shell context menu like this
https://user-images.githubusercontent.com/76573761/226189077-e9040283-e409-40e9-bb15-bc070685cc1e.mp4

Hi @muhammadbahaa2001
These effects are for WinUI and not for traditional applications. But I will try to add it in the future.

Any updates?

Not yet. But it will be added in the future

Especially waiting for menu with items, in windows is a smooth animation.
Default Windows 11 Context Menu
https://github.com/moudey/Shell/assets/7759507/f95905ea-032c-43b9-af76-4127c668833e
Nilesoft Shell Context Menu
https://github.com/moudey/Shell/assets/7759507/ae827200-f5eb-4e91-aa93-7e2fdb418619

can't wait for this to become reality! it's the only thing that's keeping this from becoming absolutely perfect.

I would love to see at least simple fade-in opacity transition on popup show up — maybe it could be easier to implement compared to the "unfolding" one from the WinUI?

Hi @muhammadbahaa2001 These effects are for WinUI and not for traditional applications. But I will try to add it in the future.
We're still waiting.

@moudey
We're still waiting.


[WIP] Problem Refactoring

Summary
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

557 of 633 (87.99%)  changed or added relevant lines in 41 files are covered.
105 unchanged lines in 12 files lost coverage.
Overall coverage decreased (-0.5%) to 85.057%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_nature/second_q/algorithms/initial_points/hf_initial_point.py
3
4
75.0%

qiskit_nature/second_q/algorithms/initial_points/mp2_initial_point.py
4
5
80.0%

qiskit_nature/second_q/hamiltonians/fermi_hubbard_model.py
6
7
85.71%

qiskit_nature/second_q/hamiltonians/ising_model.py
25
26
96.15%

qiskit_nature/second_q/hamiltonians/lattices/lattice.py
22
23
95.65%

qiskit_nature/second_q/hamiltonians/quadratic_hamiltonian.py
4
5
80.0%

qiskit_nature/second_q/problems/electronic_structure_problem.py
20
21
95.24%

qiskit_nature/second_q/properties/bases/electronic_basis_transform.py
2
3
66.67%

qiskit_nature/second_q/drivers/electronic_structure_driver.py
62
64
96.88%

qiskit_nature/second_q/drivers/pyscfd/pyscfdriver.py
56
58
96.55%

Files with Coverage Reduction
New Missed Lines
%

qiskit_nature/second_q/drivers/electronic_structure_driver.py
1
96.15%

qiskit_nature/second_q/drivers/gaussiand/gaussian_forces_driver.py
1
64.71%

qiskit_nature/second_q/drivers/vibrational_structure_driver.py
1
87.5%

qiskit_nature/second_q/transformers/active_space_transformer.py
1
91.79%

qiskit_nature/second_q/properties/property.py
4
81.58%

qiskit_nature/second_q/properties/integrals/integral_property.py
7
82.05%

qiskit_nature/second_q/properties/particle_number.py
7
85.58%

qiskit_nature/second_q/algorithms/initial_points/hf_initial_point.py
11
77.78%

qiskit_nature/second_q/drivers/pyscfd/pyscfdriver.py
13
75.33%

qiskit_nature/second_q/properties/integrals/vibrational_integrals.py
17
72.73%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
16518

Relevant Lines:
19420

💛  - Coveralls


Updated validations.py python script.

Fixed the behavior of validate_user function in validations.py
Closes: #1
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

ixed the behavior of validate_user function in validations.py
Closes: https://github.com/google/it-cert-automation-practice/issues/1
Fixes #<issue_number_goes_here>
It's a good idea to open an issue first for discussion.
Tests pass
Appropriate changes to README are included in PR

Great


Non Linear expressions

Hi,
First of all, thanks for the interface, coming from gurobipy, the transition was seamless.
However, I am looking to use non-linear expression, namely a log in the objective function. Looking inside the code and documentation, I couldn't find the correct way to do it.
Is it implemented yet?
Best,
Yoann

Hey Yoann
I am sorry that currently the only nonlinearities that we can handle are
polynomials.
We want to extend it of course, but I think we first have to decide on the
data structure for general expressions.
On Oct 11, 2016 10:03, "ycouble"<EMAIL_ADDRESS>wrote:

Hi,
First of all, thanks for the interface, coming from gurobipy, the
transition was seamless.
However, I am looking to use non-linear expression, namely a log in the
objective function. Looking inside the code and documentation, I couldn't
find the correct way to do it.
Is it implemented yet?
Best,
Yoann
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SCIP-Interfaces/PySCIPOpt/issues/41, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AFNG9v_beY_nDp9gSCfnrlX2i44lt9Nnks5qy0LMgaJpZM4KTWLA
.

Ok, thanks for the update.

Besides the internal datastructure, it's also not clear what the usage will look like.
For polynomial expressions, we can use operator overloading on * and + to hijack the expression parsing in Python. But I wouldn't know how catch a call to log(x) where x is a Expr (there's no log function in the global namespace in Python, only math.log). I guess we would have to provide functions (and types) that user would need to import, as in
from pyscipopt import log
cons = (log(x) == 3)

For the objective function, would it be possible to simply pass a user-defined function as argument of the setObjective call ? Something like:
def eval_f(X):
    return sum(x for x in X)

I don't think we can support general functions. For your example, I could imagine the following:
model.setObjective(sum(pyscipopt.log(x) for x in X))

Hello !
Is there any update on this ? I need to use a log objective as part of my model.
Thanks.

Hi @tarun018
I am sorry to say that here has been 0 activity in this issue.
I hope I have some time to start working on this, but not before the next couple of weeks

general nonlinear functions are implemented now!


A History of Violence - Character Freezing (Save Attached)

OLD TEXT
To complete the Wanderer background quest, you have to knock crates down from the ceiling with arrows, bolts, or cantrips. Whenever I try with any of those, not only does the crate not fall but the character who tried to shoot it down can no longer move--they get stuck in place. I turned off the game completely and reloaded, only to face the same issue. Have also had issues recently where casting Eldritch Blast in a fight would cause the caster's turn to not end, but that was resolved by closing out the game.
NEW TEXT
You have to go the area with the East Cart loader, which is unexplored in the save but will take less than 3 seconds to get to if you just click on the right side of the map. Hop down the scaffolding and try to shoot the crates.
Movie.zip

fixed


Add Integration Profile for Docker Compose

This PR adds an "integration" profile to the docker-compose stack to support LFH route development and integration testing with external systems. Systems supported within the integration profile include IBM and MSFT FHIR Servers.
Updates for Postman examples and integration tests will be submitted in a separate PR.
To test the profile
# start the integration profile
cd connect/container-support/compose
source start-stack.sh integration

# monitor the MSFT FHIR SQL DB and MSFT FHIR Servers to determine when they are running
# the MSFT FHIR Server will restart until the SQL DB is initialized
docker-compose ps

# send a request to MSFT FHIR for it's capability statement
curl -X GET http://localhost:9090/metadata

Resolved merge conflicts and re-tested with a clean setup/teardown of each profile with the HelloWorld route.


Cone detection

coneDetection.py with findCone()
Returns horizontal center position in frame of cone as value between (0,1)
Added centerline detection to conedetection_static notebook

@scottshepard I should've renamed the _static one.  It has all the openCV rendering and displays the marked image.  coneDetection.ipynb is just the function that can take a static image or open/capture with the camera directly when called and output the position without any rendering.  It's the notebook version of the .py


Consul only uses the first recursor

We have noticed in our CF environments that consul recursors option is not working as expected.
It looks like it's just asking the first DNS server:
/var/vcap/packages/consul/bin/consul agent -config-dir=/var/vcap/jobs/consul_agent/config -recursor=<IP_ADDRESS> -recursor=POWER_DNS -recursor=<IP_ADDRESS>

$ dig 0.ccdb-ng.default.lon-fabric.microbosh

; <<>> DiG 9.9.5-3ubuntu0.5-Ubuntu <<>> 0.ccdb-ng.default.lon-fabric.microbosh
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NXDOMAIN, id: 39214
;; flags: qr rd ra ad; QUERY: 1, ANSWER: 0, AUTHORITY: 1, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 512
;; QUESTION SECTION:
;0.ccdb-ng.default.lon-fabric.microbosh.		IN A

;; ANSWER SECTION:
0.ccdb-ng.default.lon-fabric.microbosh.	300 IN A <IP_ADDRESS>

;; Query time: 135 msec
;; SERVER: POWER_DNS#53(<IP_ADDRESS>)
;; WHEN: Wed Jun 08 15:42:12 UTC 2016
;; MSG SIZE  rcvd: 83

This is may be also aggravating  problem explained in this other issue:
https://github.com/cloudfoundry-incubator/diego-release/issues/168

From my tests, I can see that DNS is properly being recursed.
The command my consul is running:
/var/vcap/packages/consul/bin/consul agent -config-dir=/var/vcap/jobs/consul_agent/config -recursor=<IP_ADDRESS> -recursor=<IP_ADDRESS>

Is recursing the addresses which exist in my /etc/resolve.conf
$ cat /etc/resolv.conf
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>

And from these dig commands, you can see that if I do not specify the DNS server, the answer is the same as the commands which I do specify the DNS server:
$ dig consul.service.cf.internal

; <<>> DiG 9.9.5-3ubuntu0.5-Ubuntu <<>> consul.service.cf.internal
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 38647
;; flags: qr aa rd ra; QUERY: 1, ANSWER: 3, AUTHORITY: 0, ADDITIONAL: 0

;; QUESTION SECTION:
;consul.service.cf.internal.		 I tested these commands on the latest develop branch.
Perhaps you can switch the order, and have your POWER_DNS as your first recursor.

The version we use is v40:
0ad37ffa52115a572f91430ee8875c521c4f8575 src/consul-release (v40)
Have you introduced something new regarding recursion since then?

@jszroberto Starting with release v87, we've upgraded our consul version from 0.5.2 to 0.6.4, but nothing specific to recursing DNS.

We digging a little bit more and the problem is the response received from PowerDNS.
More info can be found here:
https://github.com/cloudfoundry-incubator/diego-release/issues/168
We can close this issue


Create dispatch.yml

Codecov Report
Patch coverage has no change and project coverage change: -1.14 :warning:

Comparison is base (682b722) 82.59% compared to head (e463abb) 81.46%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   82.59%   81.46%   -1.14%
==========================================
  Files          12       12
  Lines         793      793
==========================================
- Hits          655      646       -9
- Misses        101      107       +6
- Partials       37       40       +3

see 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[BUG] Swagger $Response methods not linked to chopper response

Describe the bug
in the generated .swagger.dart file i have a generated response called DeviceFirmwaresGet$Response. I expect this class to be used as a response class in the chopper function, however it only generates Future<chopper.Response<Object>> instead of Future<chopper.Response<DeviceFirmwaresGet$Response>>.
  Future<chopper.Response<Object>> deviceFirmwaresGet({String? filters}) {
    return _deviceFirmwaresGet(filters: filters);
  }

To Reproduce
  /v1/device-firmwares:
    get:
      tags:
        - 'Device Firmwares'
      summary: 'Get available devices firmwares.'
      operationId: device_firmwares.index
      parameters:
        -
          name: filters
          in: query
          description: 'Filter on device model'
          required: false
          explode: false
          schema:
            type: string
            example: '[search:test]'
      responses:
        '200':
          description: OK
          content:
            application/json:
              schema:
                properties:
                  status: { type: integer, example: 200 }
                  data: { properties: { device_firmwares: { type: array, items: { $ref: '#/components/schemas/DeviceFirmware' } } }, type: object }
                type: object
      security:
        -
          oauth2: []
          basicAuth: []
          bearerAuth: []

Library version used:
2.11.8

Hi @juliansteenbakker , thanks for raising issue. Fixed


bug: keyboard default accessories do not work

Short description of the problem:
Now that the hideKeyboardAccessoryBar has been disabled in iOS, the left and right arrow accessories that display above the keyboard do not actually move forward and backward between the ion-inputs on the screen. The keyboard normally just closes when the left or right arrows are pressed.
What behavior are you expecting?
Easily be able to navigate forward and backward through the input fields using the keyboard's accessory bar. Note that if there are multiple fields that are shown in different states (hidden or ngIf) this should be taken into consideration.
<ion-content padding class="page1">
    <ion-item>
        <ion-label>Username</ion-label>
        <ion-input></ion-input>
    </ion-item>

    <ion-item>
        <ion-label>Website</ion-label>
        <ion-input type="url"></ion-input>
    </ion-item>

    <ion-item>
        <ion-label>Email</ion-label>
        <ion-input type="email"></ion-input>
    </ion-item>

    <ion-item>
        <ion-label>Phone</ion-label>
        <ion-input type="tel"></ion-input>
    </ion-item>

    <ion-item clearInput>
        <ion-input placeholder="Username"></ion-input>
    </ion-item>
</ion-content>

Which Ionic Version? 2.x
Plugin version? 2.0.1
Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 6.0.0
Ionic Version: 2.0.0-beta.3
Ionic CLI Version: 2.0.0-beta.22
Ionic App Lib Version: 2.0.0-beta.12
ios-deploy version: 1.8.5
ios-sim version: 5.0.7
OS: Mac OS X El Capitan
Node Version: v5.9.0
Xcode version: Xcode 7.3 Build version 7D175

Hey! Thanks for opening an issue with us! Removing the feature that allowed you to hide the accessory bar was necessary to allow people to submit apps to the app store succesffuly again. Unfortunately to get that issue fixed as fast as possible we simply just had to remove that feature all together as a better solution has not been found yet (although its actively being worked on). Therefore this means that there may be some features of the accessory bar which may not work correctly with Ionic as we've always worked off the basis it was hidden. We realize this is irritating and hope to have this hide accessory bar keyboard issue figured out soon. Thanks again!

Fair enough. But what happens if I don't want the accessory bar to be removed? Shouldn't the default functionality of the keyboard's accessories work as expected in that case?

Reopening this issue as it is a valid use case that a user would not want to hide the accessory bar.

hideKeyboardAccessoryBar is now possible with the latest release. Thanks!

can we hide arrows only  of accessary bar in Ionic?


display image on docs

for rendering docs,
How about setting an environment variable to show just an image instead of the widget?
https://gdsfactory.github.io/skywater130/notebooks/intro.html#

fixed with 70dff8cc987a0254621d0f26c7c47bd56f693f50


Investigate printing a log message if starting a crawler takes a long while due to memory storage loading everything

Which package is the feature request for? If unsure which one to select, leave blank
@crawlee/basic (BasicCrawler)
Feature
Title says it all
Motivation
I just had to do a 1.8mil scrape and I paused it at ~1mil requests, and restarting it took:

a whole lot of time
gave 0 feedback that it was loading

Ideal solution or implementation, and any additional constraints
After, say, 30 seconds of no logging period, we should see if we can log something (maybe just a "hey storages are currently loading, this might take a while)
Alternative solutions or implementations
No response
Other context
No response

Note that a similar "idleness" happens at every single iteration of a large scrape when there are way more done requests than there are new URLs being discovered (i.e. towards the "deep end" of a scrape). See #2406 for details. While an actual fix would be better, at least showing a message would be neat!


Banner XML integration is not working

Banner ads are not working via XML, with or with 'plid-'.
It always returns "inMobiBanner could not be initialized. Ignoring your call"
Please fix it!

I have the same problem. Have you solved it?

@ShahoodulHassan This happens when the InMobiBanner object is created before calling init on InMobiSdk. A common cause of the problem is adding InMobiBanner in XML and calling setContentView() before calling InMobiSdk.init(). So move your init code before creating the view.

Hi,
Thanks for replying but don't u think 06 months is an unreasonable response
time?
I'm sorry but I've moved on.
On Sat, 22 Jun 2019, 10:21 Raj Suvariya<EMAIL_ADDRESS>wrote:

@ShahoodulHassan https://github.com/ShahoodulHassan This happens when
the InMobiBanner object is created before calling init on InMobiSdk. A
common cause of the problem is adding InMobiBanner in XML and calling
setContentView() before calling InMobiSdk.init(). So move your init code
before creating the view.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/InMobi/sdk-sample-code-android/issues/25?email_source=notifications&email_token=AHCEBYS6H7SNWQ6Q5MKO6GLP3WZG7A5CNFSM4GCEZKYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYKBD4Q#issuecomment-504631794,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHCEBYRYZ2VIOB7V4EIKN4TP3WZG7ANCNFSM4GCEZKYA
.


add scope options (i.e. focus if tab is in same window)

not a requirement feature ... leaving it out for now


Bump up numpy requirement

See #116.
This restores the minimum numpy requirements to before #105. It does not reintroduce the Python version restriction that was the main motivation for #105.

Could you please make a pypi release soon so that this fix gets into the public releases?


[WFCORE-5510] Upgrade WildFly Elytron to 1.16.1.Final

https://issues.redhat.com/browse/WFCORE-5510
    Release Notes - WildFly Elytron - Version 1.16.1.Final

        Bug

[ELY-2137] -         Possible NullPointerException in AuthenticationConfiguration

[ELY-2140] -         Elytron Tool: Mask command will fail when secret is not provided.

[ELY-2141] -         Elytron Tool: Default platform encoding used in Command.

[ELY-2142] -         Elytron Tool: Default platform encoding used in VaultCommand.

[ELY-2143] -         The constructor of CachingSecurityRealm is not correctly implemented.

[ELY-2145] -         Default platform encoding used in OAuth2IntrospectValidator and OAuth2CredentialSource.

        Task

[ELY-2147] -         SCRAM Timing Attack Hardening

[ELY-2184] -         Refactor the Digest mechanisms to use MessageDigest#isEqual instead of Arrays#equals

        Release

[ELY-2188] -         Release WildFly Elytron 1.16.1.Final

        Component Upgrade

[ELY-2138] -         Upgrade slfj-jboss-logmanager to 1.0.4.GA

[ELY-2139] -         Upgrade JBoss Logging to 3.4.2.Final

[ELY-2148] -         Upgrade MP-JWT API to 1.2.1

@fjuma thanks


We will fix it and release a bugfix version ASAP.


[FEATURE] Support multiple siteAliases for a B2C Commerce Site

The PWA Kit's support for Multiple B2C Commerce sites could be improved by allowing sites to define an array of aliases rather than one:
TODAY
// config/default.js
modules.exports {
  siteAliases: {
    RefArchGlobal: 'global'
  }
}

TOMORROW
// config/default.js
modules.exports {
  siteAliases: {
    RefArchGlobal: ['de', 'mx', 'fr']
  }
}

This approach is common when using a international B2C Commerce site to serve a number of different countries.
It would likely also be nessecary to add additional metadata to site.js to allow the correct local to be specificy, though perhaps that could also live in a more complex "alias".
https://github.com/SalesforceCommerceCloud/pwa-kit/blob/develop/packages/template-retail-react-app/config/default.js
https://github.com/SalesforceCommerceCloud/pwa-kit/blob/develop/packages/template-retail-react-app/config/sites.js

@johnboxall In pwa-kit we do have util to build the url based on this settings, I am wondering if we allow this settings, how should we know which alias to choose from this list to build the urls here?
E.g When the site is RefArchGlobal, how can we determine which aliases ('de', 'mx', or 'fr')to pick here? 🤔


[BUG] Compile error when orchestrion has been installed with a lower go version than the one in use

Version of orchestrion
v0.9.0
Describe what happened:
I was reviewing #292 when I saw this after a fresh clone of https://github.com/traefik/traefik.git on commit d317cd90fcb579722ab29c35410c10b6a135f949 (main)

Describe what you expected:
I was expection the build to succeed because go build . does
Steps to reproduce the issue:

Additional environment details (Version of Go, Operating System, etc.):
 In this case, the go toolchain automatically uses a more recent compiler to "make it work" (because GOTOOLCHAIN was not set to local?).
The issue here is that while we end up using a go 1.23 compiler, the go AST & type checker package being used by orchestrion is the one it was built with, in this case 1.22, which prevents it from properly loading up in this case.
Short term, we should detect this situation and emit a clear warning; or bail out with a clear error indicating what the user should do (likely, re-build their local orchestrion with the proper toolchain).
Longer term, we might consider re-spawning orchestrion with the correct toolchain, since we have a full compiler toolchain available anyway...

Short term answer is to upgrade you Go toolchain and to reinstall orchestrion with it.


gs_audio: Use-after-free crash on exit

Gunslinger apps occasionally segfault when closing. It's not really a big deal since the program is already exiting, but I know users in the Discord have mentioned it before so I thought it should be officially reported.
Tested on Linux w/ GCC.
Address Sanitizer says this crash happens when ma_audio_commit accesses the audio subsystem after the engine instance has been freed.
https://github.com/MrFrenik/gunslinger/blob/fc25815800a012284c548d315d27af331fffe20d/impl/gs_audio_impl.h#L449-L453
https://github.com/MrFrenik/gunslinger/blob/fc25815800a012284c548d315d27af331fffe20d/impl/gs_platform_impl.h#L1397-L1398
GDB backtrace:
#0  0x00005555555699fe in ma_audio_commit (device=<optimized out>, output=0x7fffe465edc0, input=<optimized out>, frame_count=440) at ../../third_party/include/gs/impl/gs_audio_impl.h:449
#1  0x000055555564d430 in ma_device__on_data (pDevice=pDevice@entry=0x555555c189d0, pFramesOut=pFramesOut@entry=0x7fffe465edc0, pFramesIn=pFramesIn@entry=0x0, frameCount=frameCount@entry=440)
    at ../../third_party/include/gs/impl/../external/miniaudio/miniaudio.h:9948
#2  0x000055555565ee3f in ma_device__read_frames_from_client (pFramesOut=0x7fffe465edc0, frameCount=440, pDevice=0x555555c189d0) at ../../third_party/include/gs/impl/../external/miniaudio/miniaudio.h:9976
#3  ma_device_main_loop__pulse (pDevice=0x555555c189d0) at ../../third_party/include/gs/impl/../external/miniaudio/miniaudio.h:21417
#4  0x0000555555578e00 in ma_worker_thread (pData=0x555555c189d0) at ../../third_party/include/gs/impl/../external/miniaudio/miniaudio.h:30577
#5  0x00007ffff7c72299 in start_thread () from /usr/lib/libpthread.so.0
#6  0x00007ffff7b99053 in clone () from /usr/lib/libc.so.6

Relevant address sanitizer output:
=================================================================
==6555==ERROR: AddressSanitizer: heap-use-after-free on address 0x608000000030 at pc 0x55978997b005 bp 0x7fbcffe47050 sp 0x7fbcffe47040
READ of size 8 at 0x608000000030 thread T1
    #0 0x55978997b004 in ma_audio_commit ../../third_party/include/gs/impl/gs_audio_impl.h:433
    #1 0x559789b8fece in ma_device__on_data ../../third_party/include/gs/impl/../external/miniaudio/miniaudio.h:9948
    #2 0x559789bbd489 in ma_device__read_frames_from_client ../../third_party/include/gs/impl/../external/miniaudio/miniaudio.h:9976
    #3 0x559789bbd489 in ma_device_main_loop__pulse ../../third_party/include/gs/impl/../external/miniaudio/miniaudio.h:21417
=================================================================
0x608000000030 is located 16 bytes inside of 96-byte region [0x608000000020,0x608000000080)
freed by thread T0 here:
Direct leak of 270387 byte(s) in 59 object(s) allocated from:
    #0 0x7fbd0b49a0e9 in __interceptor_free /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cpp:123
    #1 0x55978995f3ff in main ../../third_party/include/gs/impl/gs_platform_impl.h:1398
    #0 0x7fbd0b49a639 in __interceptor_calloc /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cpp:154

    #1 0x7fbd05cff9e3  (/usr/lib/libnvidia-glcore.so.460.56+0xd739e3)

I'm currently re-writing large portions of the audio subsystem right now, because it's had issues like this for a while. I'll keep this open, so know that it's actively being worked on.


Feature: ansible package

This PR is an adaptation to the new dagger release of the Ansible package proposed in this PR.

Thanks for your contribution @PaulBarrie
Regarding your linting issue, you say you're getting this error ?

@TomChv brought new improvements following your advices :)


UI created with full responsiveness

https://user-images.githubusercontent.com/107763774/208285479-4929b8dd-34ab-44a2-a244-833f71ef5eec.mp4

Kindly work on open issues only,

Kindly work on open issues only,

this issue is open and is assigned to me ...kindly check @flyingsonu122

This design is not suitable, hence closed
Please discuss design first on issues comments before working and creating pull request

This design is not suitable, hence closed
Please discuss design first on issues comments before working and creating pull request

ok...


Update to Stencil 0.9

https://github.com/kylef/Stencil/releases/tag/0.9.0
Package.swift currently requires 0.8. I had to add an explicit dependency on Stencil 0.9 to my project to use the newer version.

Fixed in https://github.com/IBM-Swift/Kitura-StencilTemplateEngine/tree/1.8.1


Fix tracker daily step distribution

Should assume user column and timestamp index. Should return timestamp indexed array.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cb7b382) 84.92% compared to head (902c8dc) 84.93%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   84.92%   84.93%
=======================================
  Files          49       49
  Lines        3217     3219    +2
=======================================
+ Hits         2732     2734    +2
  Misses        485      485

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Document how one could preload has_many associations

There was some discussion about how one might preload has_many associations in #graphql.
It might be interesting to share some of our AssociationLoader logic or writing a quick tutorial to achieve this in the README.

I think we should make our DerivedKeyLoader builtin functionality, since is something we use to properly implement this in Shopify

Has anyone written this up? Would love to see how you did it.

I created for my own purposes an ArrayLoader, which you use providing a value and a key of a has-many association, like this:
ArrayLoader.for(Comment).load([article.id, :article_id])
class ArrayLoader < GraphQL::Batch::Loader
  def initialize(model, default = nil)
    @model = model
    @default = default
  end

  def perform(keys)
    queries = {}
    keys.each do |key|
      if key.is_a?(Array)
        query_value, query_key = key
        queries[query_key] = [] if queries[query_key].nil?
        queries[query_key] << query_value
      end
    end

    results_cache = {}

    queries.each do |key, values|
      @model.where(key => values).each { |record|
        results_cache[[record[key], key]] = [] if results_cache[[record[key], key]].nil?
        results_cache[[record[key], key]] << record
      }
    end

    results_cache.each do |key, values|
      fulfill(key, values)
    end

    keys.each { |key| fulfill(key, @default || []) unless fulfilled?(key) }
  end
end

This is what I've hit on:
class AssociationLoader < GraphQL::Batch::Loader
  def initialize(model, association)
    @model = model
    @association = association
  end

  def perform(vals)
    ActiveRecord::Associations::Preloader.new.preload(vals, @association)
    vals.each { |val| fulfill(val, val.send(@association)) }
  end
end

Used like so:
AuthorType = GraphQL::ObjectType.define do
  field :books, types[!BookType] do
    resolve ->(obj, _, _) {
      AssociationLoader.for(Author, :books).load(obj)
    }
  end
end

BookType = GraphQL::ObjectType.define do
  field :author, types[!AuthorType] do
    resolve ->(obj, _, _) {
      AssociationLoader.for(Book, :author).load(obj)
    }
  end
end

Here is what we are using, which is a bit longer to:

give better errors if the association doesn't exist
call callbacks right away if the association is already loaded, potentially allows more queries to be batched
make sure records aren't left with an unloaded associations if there is another record in the batch load with the same id

class AssociationLoader < GraphQL::Batch::Loader
  def self.validate(model, association_name)
    new(model, association_name)
    nil
  end

  def initialize(model, association_name)
    @model = model
    @association_name = association_name
    validate
  end

  def load(record)
    raise TypeError, "#{@model} loader can't load association for #{record.class}" unless record.is_a?(@model)
    return Promise.resolve(read_association(record)) if association_loaded?(record)
    super
  end

  # We want to load the associations on all records, even if they have the same id
  def cache_key(record)
    record.object_id
  end

  def perform(records)
    preload_association(records)
    records.each { |record| fulfill(record, read_association(record)) }
  end

  private

  def validate
    unless @model.reflect_on_association(@association_name)
      raise ArgumentError, "No association #{@association_name} on #{@model}"
    end
  end

  def preload_association(records)
    ::ActiveRecord::Associations::Preloader.new.preload(records, @association_name)
  end

  def read_association(record)
    record.public_send(@association_name)
  end

  def association_loaded?(record)
    record.association(@association_name).loaded?
  end
end

something along these lines would be a wonderful addition to either the documentation or stdlib of graphql-batch.

If it helps, I wrote up a gist that shows how you could combine a GraphQL::Batch::Loader together with instrumentation on your fields, in order to give you this nice syntax:
field :comments, !types[!CommentType] do
  preload comments: :author
  resolve -> (post, args, ctx) { post.comments }
end

It looks a little bit nicer than stacking a bunch of AssociationLoader's together in your resolve procs, and is pretty similar to the includes(comments: :author) syntax that Rails gives you.
https://gist.github.com/theorygeek/a1a59a2bf9c59e4b3706ac68d12c8434

@theorygeek above gist worked wonderfully for me. Is this merged into gem?

@theorygeek that gist was also exactly what I was looking for, thanks! 👍
It would certainly be nice to have this merged into the gem, or at least some documentation written up for how to best batch association loading (I came here after spelunking into the tests for this gem to see how the test suite was doing it).

@theorygeek - Thanks!!! I spent most of the day struggling with my crappy code. Finally I ripped out may crappy code and replaced if with your awesome code.
If your code is too specific for this gem, I suggest a new gem, call it active-graphql-batch or graphql-batch-associations.

Hey everyone - I took @theorygeek's excellent work and turned it into a gem. Hopefully you find it useful!

@etripier - Awesome!

@etripier Nice work! 🎉

@timscott  @theorygeek  Awesome just what I was looking for 🤗 👏🏻  this should be added to the GEM

@dylanahsmith's snippet also handled the cache id smartly, IIUC, isn't that needed in the gem?

@riffraff Good point! I went ahead and fixed that in the latest release.

Why bother validating something that will anyway trigger an error if not valid (talking about the validation on the association existence)? If I remove the validate from the class, it will raise the regular ActiveRecord::AssociationNotFoundError.
Why bother giving the model as an argument to the constructor? The following extra light class seems to be working on a has_many:

class AssociationLoader < GraphQL::Batch::Loader
  def initialize(association_name)
    @association_name = association_name
  end

  private

  def perform(records)
    ::ActiveRecord::Associations::Preloader.new.preload(records, @association_name)
    records.each { |record| fulfill(record, record.public_send(@association_name)) }
  end
end

Am I missing something?

Sounds like the questions you're asking lead naturally to the expanded version but with stylistic variations. What motivates the analysis?

I was wondering if my code was breaking something I could not "see" from my basic examples/tests.

Why bother validating something that will anyway trigger an error if not valid (talking about the validation on the association existence)?

Maybe you are right.  I think that validate class method might only matter if you want to use it to validate field preloads when declaring them at initialization time for fields, like in https://github.com/xuorig/graphql-active_record_batcher.

Why bother giving the model as an argument to the constructor?

The model is used for grouping so that you don't end up grouping together loads for the same association name on different models.


Update golang package

This PR updates the version of golang to 1.10.3

@cf-london Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


Bitnami image does not work without DisablePing

NEST/Elasticsearch.Net version:
7.1
Elasticsearch version:
7.0.0
Description of the problem including expected versus actual behavior:
The problem exists when Elasticsearch endpoint is not exposed on the host root path / but under /elasticsearch like on Bitnami ELK image.
Invoking any client method, like client.Indices.Exists, throws an exception Failed to ping the specified node.. Call: Status code 200 from HEAD /. Beside status code 200 response mime type is text/html which indicated that client tries to ping host without path included and gets Bitnami default landing page.
By debugging through ELK http logs assumption was confirmed. GET call was fired to http://HOST instead of http://HOST/elasticsearch/ as configured.
Steps to reproduce:

Bootstrap Bitnami ELK image
Instantiate client w/o calling DisablePing method
Call client.Indices.Exists method for any index (existing or non-existing)

*** Workaround ***
Call DisablePing on the client instance before any Api Call.

Thanks for opening @draganjovanovic1, investigating

I've opened #3975 to address


GAWB-3076: Generifying the general use case

Addresses Jira Story:

https://broadinstitute.atlassian.net/browse/GAWB-3076

Requires
Require an ORSP PR: https://github.com/broadinstitute/orsp/pull/333
Changes in this PR:

Allow for the combination of GRU + anything else.

[ ] Submitter: Include the JIRA issue number in the PR description
[ ] Submitter: Make sure Swagger is updated if API changes
[ ] Submitter: Check documentation and code comments. Add explanatory PR comments if helpful.
[ ] Submitter: JIRA ticket checks:

Acceptance criteria exists and is met
Note any changes to implementation from the description
Add notes on what you've tested

[ ] Submitter: Update RC_XXX release ticket with any config or environment changes necessary
[ ] Submitter: Update FISMA documentation if changes to:

Authentication
Authorization
Encryption
Audit trails

[ ] Submitter: If you're adding new libraries, sign us up to security updates for them
[ ] Tell the tech lead (TL) that the PR exists if they wants to look at it
[ ] Anoint a lead reviewer (LR). Assign PR to LR

Review cycle:

LR reviews
Rest of team may comment on PR at will
LR assigns to submitter for feedback fixes
Submitter rebases to develop again if necessary
Submitter makes further commits. DO NOT SQUASH
Submitter updates documentation as needed
Submitter reassigns to LR for further feedback

[ ] TL sign off
[ ] LR sign off
[ ] Product Owner sign off
[ ] Assign to submitter to finalize
[ ] Submitter: Verify all tests go green, including CI tests
[ ] Submitter: Squash commits and merge to develop
[ ] Submitter: Delete branch after merge
[ ] Submitter: Test this change works on dev environment after deployment. YOU own getting it fixed if dev isn't working for ANY reason!
[ ] Submitter: Verify swagger UI on dev environment still works after deployment
[ ] Submitter: Inform other teams of any API changes via hipchat and/or email
[ ] Submitter: Mark JIRA issue as resolved once this checklist is completed

After discussion with Moran, closing this PR and closing the associated story.


I would like to see more examples about use of signet

My current attempt on accessing Google always ends up with invalid_grant.
Here is the problematic part of the code:
oauth2_client = Signet::OAuth2::Client.new(authentication_uri: "https://accounts.google.com/o/oauth2/auth",
token_credential_uri: "https://accounts.google.com/o/oauth2/token",
client_id: "XXXXXXXXXXX-lotOfGibberish.apps.googleusercontent.com",
client_secret: "clientSecretFromGoogleConsole",
redirect_uri: "urn:ietf:wg:oauth:2.0:oob",
scope: "https://picasaweb.google.com/data/",
refresh_token: "inventedStringHere")
p oauth2_client.refresh!
And end result is always:
gems/ruby-2.1.1/gems/signet-0.6.0/lib/signet/oauth_2/client.rb:947:in `fetch_access_token': Authorization failed.  Server message: (Signet::AuthorizationError)
{
"error" : "invalid_grant"
}
Many OAuth2 errors seem to be related to clock, but that shouldn't be the problem:
$ ntpq -p
remote           refid      st t when poll reach   delay   offset  jitter
*defra1-ntp-002. .GPSs.           1 u    2   64  377   41.766   31.970   8.969

Is it for an installed application or for a server to server application?

I have small ruby script that gets executed from command line, so I guess it falls into installed apps category. Script goes through number of files and local directory tree and determine, which images should be sent in through Picasa API.
Based on my struggles with signet (and Google OAuth2 on that matter), I think the most confusing part of gist was that it doesn't tell you what steps you have to go through to get valid refresh_token.
I think that is going to be my next challenge, since you can't use refresh token from OAuth2 playground.

So at the end it went something like this ...
oauth2_client = Signet::OAuth2::Client.new(
authorization_uri: "https://accounts.google.com/o/oauth2/auth",
token_credential_uri: "https://accounts.google.com/o/oauth2/token",
client_id: client_id,
client_secret: client_secret,
redirect_uri: redirect_uri,
scope: "https://picasaweb.google.com/data/",
expiry: 3600
)
you probably don't need all those parameters, but ...
p oauth2_client.authorization_uri.to_s
visit to the given URL with browser, go through authentication to fetch the code
oauth2_client.code=code_from_browser
oauth2_client.refresh!
store the refresh_token into some configuration file etc., so that you can use the original gist in a future.

Sounds like you should go server-to-server route. I would not worry about the refresh token.
require 'google/api_client'
require 'yaml'
opts = YAML.load_file("your-credentials.yml")
service_account_email = opts['service_account_email']
key_file = opts['key_file']
key_secret = opts['key_secret']
@profileID = opts['profileID'].to_s
@client = Google::APIClient.new(
:application_name => opts['application_name'],
:application_version => opts['application_version'],
)
key = Google::APIClient::KeyUtils.load_from_pkcs12(key_file, key_secret)
@client.authorization =  Signet::OAuth2::Client.new(
:token_credential_uri => 'https://accounts.google.com/o/oauth2/token',
:audience => 'https://accounts.google.com/o/oauth2/token',
:scope => 'https://www.googleapis.com/auth/analytics.readonly',
:issuer => service_account_email,
:signing_key => key)
@client
@client.authorization.fetch_access_token!
puts @client.authorization.fetch_access_token!
@analytics ||= @client.discovered_api


Expand CI to test more versions of packages

We should be testing more versions of software packages to ensure our codebase supports as wide a set of the landscape of tools as possible.


No such thing as HttpRequestMessage as referenced in document page.

Issue description
https://docs.microsoft.com/en-us/aspnet/web-api/overview/error-handling/exception-handling references a class called HttpResponseMessage which is not found in the API reference.
https://docs.microsoft.com/en-us/dotnet/api/?view=aspnetcore-2.1&term=HttpResponseMessage
Software versions

[x] .NET Core 2.1, 2.0

Details

This seems to be a pretty critical documentation failure.
Funny part is that this is found under System.Net.Http, and the other lib needed is under System.Net. The page is just incomplete on key information, and the search tool is missing references to the key information.

Hello @BrianMinister ... Try this one ...
https://docs.microsoft.com/dotnet/api/system.net.http.httprequestmessage?view=netframework-4.7.2


docs: getting started revamp

rewrites the page to use Tabs to provide a more streamlined and less fragmented story for the reader.

@ardatan I wanted to avoid sending one massive PR that changes everything. I am working on follow-up PRs that already address what you pointed out.

I wanted to avoid sending one massive PR that changes everything. I am working on follow-up PRs that already address what you pointed out.
Sure :) Just for the record
As I really love the idea of the tabs,
The supergraph and proxy schema source can be tabs too
Like Hive CDN, GraphOS, Custom Fetcher


feat: output generated changelog blurb to both stdout and file for further processing

Is there an existing issue or pull request for this?

[X] I have searched the existing issues and pull requests

Feature description
Currently when --prepend is provided git-cliff will output the generated CHANGELOG section for the desired release to the file that is provided through --prepend. It would be nice if it could also be send to the STDOUT through a flag so it can be picked up for further processing. It should be noted that if --prepend is not provided then git-cliff does print to stdout.
The motivation for this feature is that I could then use it for @favware/cliff-jumper to capture it and send it to the body of a GitHub release when calling the Create Release API endpoint. Currently, my CLI stops after updating the changelog and creating the Git tag locally, but if I can capture the release body I can make it possible to push the Git tag to the remote repository and create a release from that tag so a full release flow can be automated.
Desired solution

The least breaking way to achieve this would be a flag such as --stdout, which when paired with --prepend ./CHANGELOG.md will write to both the CHANGELOG.md to print to stdout. Documentation would be able to clarify what the behaviour is of combining these 2 options.
A breaking way to achieve this would be to make it so the output always has to be provided, i.e. --output /dev/stdout/ --output ./CHANGELOG.md. The equivalent of only --prepend ./CHANGELOG.md would then be --prepend ./CHANGELOG.md --output ./CHANGELOG.md

Alternatively a way to do this non-breaking would be that if --output is not provided the current behaviour is retained, however in my opinion this becomes confusing because then what is going to happen if the user provides options like --prepend ./CHANGELOG.md --output ./CHANGELOG.md
What also concerns me with this solution is cross-platform compatibility. While Linux and MacOS will work with /dev/stdout/, I do not know for sure if this will work for Windows users. I would prefer if I do not have to do OS checking in @favware/cliff-jumper to account for this. With the former solution of --stdout the advantage is that as a user of git-cliff I do not need to think about how exactly I can write to stdout for my operating system as git-cliff will automatically do that.

Alternatives considered
Running git-cliff twice, first to print to stdout without --prepend and then to CHANGELOG.md file with --prepend. This is less ideal because of the "run twice" factor.
Additional context
Also discussed on Discord here: https://discord.com/channels/1093977388892819553/1093978266135707668/1237529889113112607

Thanks for the issue! The following command works if you want to both prepend and save it to a file:
$ git-cliff -p CHANGELOG.md -l -o OTHER.md

I am guessing if we support - for stdout then it will be even more convenient, e.g. git-cliff -p 1.md -l -o - > 2.md
What do you think of this?

Hm that might work but I'd like to try it from a WIP branch to be sure because I'm not sure how execa from Node handles trailing - to send it to stdout.

Sure, I can implement it soon and you can probably check it out from the PR!

Boop boop #644


Add support for anyoneof object primitive

Description
Addresses issue reported in #889
This adds fix to v2.0.0 branch. Will port to v3 and address the remaining formatting issues.

Results of test:

The particular way we are parsing and handling data types required that we handle object primitives separate from the others.
Here's what I was seeing:

To avoid this, we check to make sure there are no properties, allOf or items present in the schema before handling as a true primitive.


[FLINK-34958] Add support Flink 1.20-SNAPSHOT and bump flink-connector-parent to 1.1.0 for mongodb connector

Add CI support for Flink 1.20-SNAPSHOT.
Bump flink-connector-parent to 1.1.0 for mongodb connector.

@Jiabao-Sun PTAL

Thanks @GOODBOY008 for this contribution.
Can you split it into two commits?


Cant connect to a Mac Mini Share

2018/10/19 17:13:50 - ERROR - RemoteScanner.RemoteScanner - Caught an SshError
Traceback (most recent call last): File "python/controller/scan/remote_scanner.py", line 60, in scan File "python/ssh/sshcp.py", line 143, in shell File "python/ssh/sshcp.py", line 109, in __run_command ssh.sshcp.SshcpError: bash: /tmp/scanfs: cannot execute binary file
2018/10/19 17:13:51 - ERROR - seedsync.ControllerJob - Caught exception in job ControllerJob
Traceback (most recent call last): File "python/common/job.py", line 44, in run File "python/controller/controller_job.py", line 29, in execute File "python/controller/controller.py", line 199, in process File "python/controller/controller.py", line 523, in __propagate_exceptions File "python/common/app_process.py", line 124, in propagate_exception File "python/common/app_process.py", line 30, in re_raise File "python/common/app_process.py", line 87, in run File "python/controller/scan/scanner_process.py", line 71, in run_loop File "python/controller/scan/remote_scanner.py", line 71, in scan common.error.AppError: An error occurred while scanning the remote server.
2018/10/19 17:13:51 - ERROR - seedsync - Caught exception
Traceback (most recent call last): File "python/seedsync.py", line 162, in run File "python/common/job.py", line 77, in propagate_exception File "python/common/job.py", line 44, in run File "python/controller/controller_job.py", line 29, in execute File "python/controller/controller.py", line 199, in process File "python/controller/controller.py", line 523, in __propagate_exceptions File "python/common/app_process.py", line 124, in propagate_exception File "python/common/app_process.py", line 30, in re_raise File "python/common/app_process.py", line 87, in run File "python/controller/scan/scanner_process.py", line 71, in run_loop File "python/controller/scan/remote_scanner.py", line 71, in scan common.error.AppError: An error occurred while scanning the remote server.
2018/10/19 17:13:52 - INFO - seedsync.Controller - Exited controller
2018/10/19 17:18:40 - INFO - seedsync.ServerActionHandler - Received a restart action
2018/10/19 17:18:40 - INFO - seedsync - Exiting Seedsync
Lost connection to service

At this time a Mac remote server is not supported, sorry. It requires compiling the remote scanfs executable for a Mac architecture.


Additional fields on JobController.all_jobs()

Is there a way we can add some additional fields we need on the all_jobs() function?

@ryanxetm,
We already have a few fields to filter the jobs response. Can you please provide us with your requirement here?
You can find the available fields from below link.
https://github.com/CommvaultEngg/cvpysdk/blob/master/cvpysdk/job.py#L425
Thanks,
Sachin

Open commvault support ticket for further changes.


after copy this code, put in your application

what issue??

Hi @JSPlike, can you fill out the issue template in a new issue?
The description here doesn't define a clear problem.


[SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF

What changes were proposed in this pull request?
For HiveGenericUDTF , there are two initialization methods:
  public StructObjectInspector initialize(StructObjectInspector argOIs)
      throws UDFArgumentException {
    List<? extends StructField> inputFields = argOIs.getAllStructFieldRefs();
    ObjectInspector[] udtfInputOIs = new ObjectInspector[inputFields.size()];
    for (int i = 0; i < inputFields.size(); i++) {
      udtfInputOIs[i] = inputFields.get(i).getFieldObjectInspector();
    }
    return initialize(udtfInputOIs);
  }
  @Deprecated
  public StructObjectInspector initialize(ObjectInspector[] argOIs)
      throws UDFArgumentException {
    throw new IllegalStateException("Should not be called directly");
  }

As https://issues.apache.org/jira/browse/HIVE-5737 mentioned, hive provided StructObjectInspector for UDTFs rather than ObjectInspect[], but Spark SQL  still only support deprecated function.
An exception will be reported before fix:

Error in query: No handler for UDF/UDAF/UDTF 'FeatureParseUDTF1': java.lang.IllegalStateException: Should not be called directly
Please make sure your function overrides public StructObjectInspector initialize(ObjectInspector[] args).; line 1 pos 7

This pr will resolve the exception.
Why are the changes needed?
For the migration of  Hive to Spark SQL，we face many UDTF functions throw exception because this issue，It’s really a great improvement for attracting users to Spark SQL.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
manual

Can one of the admins verify this patch?

cc @wangyum

ok to test

Test build #132480 has started for PR 30665 at commit 0e3dca1.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37082/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37082/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37082/

Test build #132480 has finished for PR 30665 at commit 0e3dca1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132480/

@southernriver Could you make pr against master branch?

@wangyum  Thanks a lot,   that's  good catch. I'll  do some fix according to your suggestion.

@southernriver Any update?

@southernriver is busy these days. Let's close this.

@southernriver is busy these days. Let's close this.


use featurizer name in feature name of all featurizers

Hey @kjappelbaum
Please elaborate the issue , Which file needs a change ?
I would like to contribute over this issue

Hey @maddy020, thanks so much for your interest in this issue and thanks for asking for more details.
In all featurizers, we use a class with the following structure
class MyFeaturizer(MOFBaseFeaturizer):
     def _featurize(self, structure):
           ...

     def featurize(self, mof):
         ...

     def feature_labels(self):
         ...

where MyFeaturizer().feature_labels() returns a list of str with the names for the elements of the array that MyFeaturizer().featurize() produces.
Currently, all names start with some string I hard-coded by hand, e.g. "APRDF". However, it would be more useful if it were the class name or something else that can be programmatically inspected.
The simplest improvement might be to include the class name (__name__) as the prefix for all the feature names, e.g.
class MyFeaturizer(MOFBaseFeaturizer):
     def _featurize(self, structure):
           ...

     def featurize(self, mof):
         ...

     def feature_labels(self):
         return [f"{self.__name__}_{a}" for a in oldnames]

hi @kjappelbaum do you meant the result should be in this form f"{class_name}_{name}"

yep, that would make sense!


Fi 2727 inferno ci us core

Summary
Inferno CI on GitHub Actions with inferno execute CLI and US Core.
This is forked from PR #167.
New behavior
Code changes
Testing guidance

Updated Summary
This PR adds US Core v3.1.1 partial Single Patient API tests into CI. The excluded tests are Capability Statement group (because TLS tests cannot pass in CI) and Encounter, Organization, Practitioner, Provenance groups because of a bug that seems to be in the US Core Test Kit (FI-3354 will track this).
This PR is still provides a functional Inferno CI, and we can work towards adding those remaining groups and the other US Core versions incrementally if that's okay with everyone else.
This PR also replaces wait-for-it with wait-for, and addresses some of the feedback on the sister PR for g10.


Component transforms

Exposes the transform function that allows mapping over a component's state and query algebra
Hides the internal representation of SlotConstructor

This second change is to enable us to perform a trick to allow us to hide the state and query algebra of child components in certain conditions:
module PrivateComponent where

data PrivateState
data PrivateQuery a

type State a = { ... private: a ... }
data Query a = ...

mkPrivateComponent :: forall s f g
                    . Component (State s) (Coproduct Query f) g
                   -> s
                   -> SlotConstructor (State PrivateState) (Coproduct Query PrivateQuery) g

This is possible by using transform on the component to pack/unpack PrivateState and PrivateQuery values. The unpacking of these values is partial, but as long as we only export the types and not the data constructors for PrivateState and PrivateQuery this is safe as we can ensure that there is no way for these values to originate from anywhere other than within the component itself, therefore we know we have the right type inside PrivateQuery.
The change to hide SlotConstructor's representation ensures that we can't make two PrivateComponents with different internal state values and then extract their initialState values and swap them over or something. Basically ensuring we keep the guarantee that there is no place a PrivateState value is accessible except during the transformation of the private component.
@jonsterling I decided tweaking Halogen probably was worth it to achieve this - it seems likely we might want to do this existential children trick in other places too, and since this doesn't involve breaking H.slot's interface or introducing yet another variant we almost had the means to it already anyway (H.slot creates a SlotConstructor, so we'll just bypass that when making a parent component for children using this trick and use HTML's Slot constructor directly).

Actually, we could probably provide a module which does exactly what I outlined above, that way neither we nor nobody else will have to do the work to make these partially-private components.

@jonsterling could you review please? I think you're probably best placed to review given our discussions up to this point.

I'm happy to do so
--jon

On Oct 26, 2015, at 7:43 AM, Gary Burgess<EMAIL_ADDRESS>wrote:
@jonsterling could you review please? I think you're probably best placed to review given our discussions up to this point.
—
Reply to this email directly or view it on GitHub.

Sigh. Thought of another case that makes this unsafe: peek lets us get hold of a PrivateQuery value in a way we can do heinous things with it, like storing it in the state and/or using it to query another child, so scratch this too. Will have to go with the FibredEq approach I think.

@garyb Damn it... ugh.

I guess we can probably still provide something like this private module to takes care of the plumbing in a generic way though. We can't do it via transform due to being unable to provide a safe (s -> s') and (s' -> s) (no Plus), but there's probably some core piece we can extract that means we don't have to implement the large chunk of code we have in eval currently. And the user would have to provide their own φ of course.

The only problem being I'm not sure about some of those coercions/failure cases we have in there either...

@garyb I think that the coercions in that nasty code I wrote are safe, and with some effort, could probably be replaced with actual uses of the passed leibniz identification. It may help if we try and disentangle the CellState and Def types a little bit.

Yeah, definitely - I had been looking at that too. We can pass Def into the component instead, although we need to add stateTag to the the CellState then, I think.


scio 0.5.6

Not simple as this. Needs upgrade of google-cloud-bigquery. See #142 .

We still have a users on 0.5.5. I believe users can use 0.5.6 without this change. Am I missing something?
https://github.com/spotify/flo/issues/133#issuecomment-412793087


feature request: updates to internal clock

Hi, looking to see if a couple of updates can be added to the internal clock?
I'm in USA, so our locale is a bit different than what's default.

Can an option be added to adjust date format? Like MM/DD instead of DD.MM.?
We start our week on Sunday. Can an option be added to have a toggle to start week on Sunday?

Thanks!

Hi @poblabs,
yes those are good points, back when I built the PixelIt for myself I just ignored them.
As soon as I can find the time I will take a look at it.


Add PHPDoc so it is easier to develop with autocomplete

Having PHPDoc will make the library easier to use on IDEs with autocomplete and inline help.

That's a great idea. We will do that.

Yes, agree very much. After PhpStorm, can't have anything less.

Do you have any knowledge to setup this. Currently in latest version of KoolReport, we do add PHP Doc Block (following guideline of phpdoc) on each methods and properties but not sure how IDE is able to read them and provide intellisense. If you have any experience, please share!

It's automatic, don't need to do anything specific. As long as you have great code linting in place via phpcs, phpmd etc, just make sure everything is documented in code and that you get build warnings when someone forgets.


Release Tracking

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Minor Changes

#2165 1b8ff1b7 Thanks @camertron! - Add an accessible avatar item to ActionList, NavList, and ActionMenu

Patch Changes

#2164 93344455 Thanks @camertron! - Allow form buttons to be disabled on click with data-disable-with

#2158 0afaecc6 Thanks @jonrohan! - Fix bug in ActionMenu button where return doesn't trigger menu

#2168 45822328 Thanks @keithamus! - Guard tooltip popover calls from Failed to execute 'showPopover' on 'HTMLElement': Not supported on elements that do not have a valid value for the 'popover' attribute.

#2160 8464823b Thanks @langermank! - Fix Dialog backdrop color fallback

#2163 e3aeda1f Thanks @langermank! - Add fallbacks for primary Button

dotcom release https://github.com/github/github/pull/282537


fix(plugin-keychain-vault): no method to_raw found for struct Body

Describe the bug
Merging #2084 broke the container build for the keychain vault plugin.
To Reproduce
Try to build the container and watch it fail.
Expected behavior
Build should succeed.
Logs/Stack traces
ghcr-keychain-vault-compilation-error-ci.log
2022-07-18T00:40:39.7187799Z #17 200.1    Compiling openapi_client v0.3.0 (/cactus-keychain-vault-server)
2022-07-18T00:40:40.1589801Z #17 200.6 error[E0599]: no method named `to_raw` found for struct `Body` in the current scope
2022-07-18T00:40:40.1590651Z #17 200.6    --> src/server/mod.rs:150:35
2022-07-18T00:40:40.1590937Z #17 200.6     |
2022-07-18T00:40:40.1591230Z #17 200.6 150 |                 let result = body.to_raw().await;
2022-07-18T00:40:40.1591550Z #17 200.6     |                                   ^^^^^^ method not found in `Body`
2022-07-18T00:40:40.1591834Z #17 200.6     |
2022-07-18T00:40:40.1592464Z #17 200.6    ::: /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.14.8/src/body/body.rs:36:1
2022-07-18T00:40:40.1593097Z #17 200.6     |
2022-07-18T00:40:40.1593340Z #17 200.6 36  | pub struct Body {
2022-07-18T00:40:40.1593673Z #17 200.6     | ---------------
2022-07-18T00:40:40.1594037Z #17 200.6     | |
2022-07-18T00:40:40.1594554Z #17 200.6     | doesn't satisfy `<_ as Stream>::Item = std::result::Result<bytes::bytes::Bytes, _>`
2022-07-18T00:40:40.1594991Z #17 200.6     | doesn't satisfy `Body: BodyExt`
2022-07-18T00:40:40.1595345Z #17 200.6     | doesn't satisfy `Body: Stream`
2022-07-18T00:40:40.1595616Z #17 200.6     |
2022-07-18T00:40:40.1595949Z #17 200.6     = note: the method `to_raw` exists but the following trait bounds were not satisfied:
2022-07-18T00:40:40.1596354Z #17 200.6             `<Body as Stream>::Item = std::result::Result<bytes::bytes::Bytes, _>`
2022-07-18T00:40:40.1596707Z #17 200.6             which is required by `Body: BodyExt`
2022-07-18T00:40:40.1596999Z #17 200.6             `Body: Stream`
2022-07-18T00:40:40.1597285Z #17 200.6             which is required by `Body: BodyExt`
2022-07-18T00:40:40.1597642Z #17 200.6             `<&Body as Stream>::Item = std::result::Result<bytes::bytes::Bytes, _>`
2022-07-18T00:40:40.1597998Z #17 200.6             which is required by `&Body: BodyExt`
2022-07-18T00:40:40.1598273Z #17 200.6             `&Body: Stream`
2022-07-18T00:40:40.1598569Z #17 200.6             which is required by `&Body: BodyExt`
2022-07-18T00:40:40.1598925Z #17 200.6             `<&mut Body as Stream>::Item = std::result::Result<bytes::bytes::Bytes, _>`
2022-07-18T00:40:40.1599283Z #17 200.6             which is required by `&mut Body: BodyExt`
2022-07-18T00:40:40.1599566Z #17 200.6             `&mut Body: Stream`
2022-07-18T00:40:40.1599868Z #17 200.6             which is required by `&mut Body: BodyExt`
2022-07-18T00:40:40.1600141Z #17 200.6
2022-07-18T00:40:40.1600449Z #17 200.6 error[E0599]: no method named `to_raw` found for struct `Body` in the current scope
2022-07-18T00:40:40.1600859Z #17 200.6    --> src/server/mod.rs:246:35
2022-07-18T00:40:40.1601126Z #17 200.6     |
2022-07-18T00:40:40.1601406Z #17 200.6 246 |                 let result = body.to_raw().await;
2022-07-18T00:40:40.1601717Z #17 200.6     |                                   ^^^^^^ method not found in `Body`
2022-07-18T00:40:40.1602000Z #17 200.6     |
2022-07-18T00:40:40.1602487Z #17 200.6    ::: /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.14.8/src/body/body.rs:36:1
2022-07-18T00:40:40.1602826Z #17 200.6     |
2022-07-18T00:40:40.1603070Z #17 200.6 36  | pub struct Body {
2022-07-18T00:40:40.1603391Z #17 200.6     | ---------------
2022-07-18T00:40:40.1603646Z #17 200.6     | |
2022-07-18T00:40:40.1604124Z #17 200.6     | doesn't satisfy `<_ as Stream>::Item = std::result::Result<bytes::bytes::Bytes, _>`
2022-07-18T00:40:40.1604682Z #17 200.6     | doesn't satisfy `Body: BodyExt`
2022-07-18T00:40:40.1605033Z #17 200.6     | doesn't satisfy `Body: Stream`
2022-07-18T00:40:40.1605304Z #17 200.6     |
2022-07-18T00:40:40.1605622Z #17 200.6     = note: the method `to_raw` exists but the following trait bounds were not satisfied:
2022-07-18T00:40:40.1606031Z #17 200.6             `<Body as Stream>::Item = std::result::Result<bytes::bytes::Bytes, _>`
2022-07-18T00:40:40.1606390Z #17 200.6             which is required by `Body: BodyExt`
2022-07-18T00:40:40.1606679Z #17 200.6             `Body: Stream`
2022-07-18T00:40:40.1606970Z #17 200.6             which is required by `Body: BodyExt`
2022-07-18T00:40:40.1607327Z #17 200.6             `<&Body as Stream>::Item = std::result::Result<bytes::bytes::Bytes, _>`
2022-07-18T00:40:40.1607663Z #17 200.6             which is required by `&Body: BodyExt`
2022-07-18T00:40:40.1607940Z #17 200.6             `&Body: Stream`
2022-07-18T00:40:40.1608233Z #17 200.6             which is required by `&Body: BodyExt`
2022-07-18T00:40:40.1608594Z #17 200.6             `<&mut Body as Stream>::Item = std::result::Result<bytes::bytes::Bytes, _>`
2022-07-18T00:40:40.1609104Z #17 200.6             which is required by `&mut Body: BodyExt`
2022-07-18T00:40:40.1609402Z #17 200.6             `&mut Body: Stream`
2022-07-18T00:40:40.1609704Z #17 200.6             which is required by `&mut Body: BodyExt`
2022-07-18T00:40:40.1610040Z #17 200.6
2022-07-18T00:40:40.1610298Z #17 200.7 error: aborting due to 2 previous errors
2022-07-18T00:40:40.3099927Z #17 200.7
2022-07-18T00:40:40.3100582Z #17 200.7 For more information about this error, try `rustc --explain E0599`.
2022-07-18T00:40:40.3100887Z #17 200.7 error: could not compile `openapi_client`
2022-07-18T00:40:40.3101088Z #17 200.7
2022-07-18T00:40:40.3101393Z #17 200.7 To learn more, run the command again with --verbose.
2022-07-18T00:40:40.3101683Z #17 200.7 warning: build failed, waiting for other jobs to finish...
2022-07-18T00:40:50.3326421Z #17 210.8 error: build failed
2022-07-18T00:40:50.3327524Z #17 ERROR: executor failed running [/bin/sh -c cargo build --release --example server]: exit code: 101
2022-07-18T00:40:50.3465773Z ------
2022-07-18T00:40:50.3466502Z  > [builder 5/6] RUN cargo build --release --example server:
2022-07-18T00:40:50.3468001Z ------
2022-07-18T00:40:50.3468806Z executor failed running [/bin/sh -c cargo build --release --example server]: exit code: 101
2022-07-18T00:40:50.3496406Z ##[error]Process completed with exit code 1.

Cloud provider or hardware configuration:
Are you running the software on a dev machine or somewhere in the cloud?
Operating system name, version, build:
Use this command: printf "$(uname -srm)\n$(cat /etc/os-release)\n"
For example
Ubuntu-20.04
Hyperledger Cactus release version or commit (git rev-parse --short HEAD):
main
Hyperledger Cactus Plugins/Connectors Used
Keychain vault plugin
Additional context
The change that broke the build was the bumping of a dependency. We need to do it because of security vulnerability issues.

Hi @petermetz
I have started working on this.
Upon initial investigation, I found out that the code snippet which is failing is this,

Which was an autogenerated code using openapi-generator 5.2.0
So I tried generating some other openapi file rust-server code using the latest openapi-generator 6.0.1 version, to see what the newly generated code is using, and it seems that it is also using the hyper 0.13.0 version and the same conflicting method

(I tried generating the rust-server code for keychain-vault plugin itself and it had the same hyper version and same to_raw() fx)
Now we have 2 approaches to this,

Either we downgrade the dependency and wait for openapi-generator to upgrade these dependencies and come back to this later again.
If this is a severe issue, I can look into modifying the generated code with the new hyper lib version, but this will take some time as the auto-generated code spans over multiple files and I need to understand some of it, because just modifying the undying conflicting to_raw() method