Million upvotes by a user

Hi
At the moment all the upvotes are saved on user > telescope > upvotedPosts ( lets say )
A user has million upvotes, so does that mean telescope is going to send the million upoted records inside user > telescope > upvotedPosts  to the client ?
I'm just curious how to get around this issue.
This is similar to http://www.wired.com/2015/11/how-instagram-solved-its-justin-bieber-problem/

Yes. Whenever someone does have a million upvotes on a user object, they'll be welcome to submit a PR to fix the problem :)

ook so no premature optimisation ?

is this issue / scale matter on your mind tho ?
Can u guide me how to go about this ? how could one look at this issue and submit a pr before they hit a million records and slowing everything down ? thanks

Yeah it's not very complicated, you'd just need to create a separate votes collection and make a join (and migrate existing data).

You can look at how comments are implemented for example.

tanks, thats what i wanted. some guidance. I will look in to it

Hi Sacha,
I'm trying to find where and how the scaling is taking place with comments,
I still see an array of commenters inside the post object in Telescope.
Is that ok to have million userId's inside an array post > commenters [] ? thanks

You're right that the ids of commenters are stored on the post document, to make it easy to (for example) show the avatars of the 3 most recent commenters. But it could easily be removed, and you'll note the comments themselves aren't stored on the post document.

yes, that is correct. Only the id's are stored.
is this line doing anything ??
https://github.com/TelescopeJS/Telescope/blob/5679ecf7e8324606363dde6a78a7cb4a326bd9cf/packages/nova-comments/lib/custom_fields.js#L28
I was testing and more that 4 ids are stored on a post comments field

This line doesn't change how many IDs are stored, only how many are joined onto the post document at join time on the client (see https://github.com/meteor-utilities/react-list-container).

I think I finally got it.
I just have the count of children documents on the main Document and lets say all the comments in a different collection. When I need to get all the comments for the Main Document I get them through either a method call or a publish/sub
thanks Sacha


rearch: add tutorial for saving query output

Updated per code review

:shipit: !

lol - I was using the VS code in-browser editing and accidentally left a comment instead of a commit message.
I had one follow-up question for you here  @greyscaled


Segment tree

🚀 Feature
(A clear and concise description of what the feature is.)
Create program in python, to create segment tree from array, and create functions to do range sum query and update query.
Have you read the Contributing Guidelines on Pull Requests?
Yes
Motivation
Segment tree are more efficient than squere root decomposition and brute force method
Pitch
I will use iterative method and python lists to achieve this

/assign


Use references

You're making a copy of the data in every call by not using a reference. Consider looking at other instances of this as well.

Apologies for the other closed pull requests.

Thanks for the PR. Just quickly tested it. Works fine but I need to make a commit in libxcorr to change the cross-correlation functions from void *a, void *b to const void *a, const void *b (or alternately, allow -fpermissive in this project).
That's probably an acceptable change to make to libxcorr but I'll check the implications and get back to you.

-fpermissive is a travesty. Do whatever you need to.

Thanks for this.


train on custom dataset

How to train on the custom dataset

I have images from mulitple camera, but I don't have the camera information.
Can I train with out specifying camera id's.

Thanks

If you have no camera information or time information, this code could be not suitable for your scenarios.


Add payments ENV

Go through the PRs below and add all the env mentioned. Also talk to @pcrespov in case of any questions about the ENV values
https://github.com/ITISFoundation/osparc-simcore/pull/4683
https://github.com/ITISFoundation/osparc-simcore/pull/4676
https://github.com/ITISFoundation/osparc-simcore/pull/4715
https://github.com/ITISFoundation/osparc-simcore/pull/4717
https://github.com/ITISFoundation/osparc-simcore/pull/4723

@YuryHrytsuk for https://github.com/ITISFoundation/osparc-simcore/issues/4623 lets set payments scale=0

@YuryHrytsuk for 🚀 Release v1.59.0 osparc-simcore#4623 lets set payments scale=0 after checking that it starts and the env-vars are OK.

It is already set to 0 in aws, dalco and tip: https://github.com/ITISFoundation/osparc-ops-environments/pull/372

All ENV has been added along the way


make setup fails

Description:
I am trying to follow quick start guide: https://github.com/efabless/caravel_user_project/blob/main/docs/source/quickstart.rst
With make setup failed with following errors:
OS: Centos 7
Installing collected packages: pcpp, volare, colorama, certifi, urllib3
Exception:
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/pip/basecommand.py", line 215, in main
    status = self.run(options, args)
  File "/usr/lib/python3.6/site-packages/pip/commands/install.py", line 365, in run
    strip_file_prefix=options.strip_file_prefix,
  File "/usr/lib/python3.6/site-packages/pip/req/req_set.py", line 789, in install
    **kwargs
  File "/usr/lib/python3.6/site-packages/pip/req/req_install.py", line 854, in install
    strip_file_prefix=strip_file_prefix
  File "/usr/lib/python3.6/site-packages/pip/req/req_install.py", line 1069, in move_wheel_files
    strip_file_prefix=strip_file_prefix,
  File "/usr/lib/python3.6/site-packages/pip/wheel.py", line 492, in move_wheel_files
    maker.make_multiple(['%s = %s' % kv for kv in console.items()])
  File "/usr/lib/python3.6/site-packages/pip/_vendor/distlib/scripts.py", line 383, in make_multiple
    filenames.extend(self.make(specification, options))
  File "/usr/lib/python3.6/site-packages/pip/_vendor/distlib/scripts.py", line 372, in make
    self._make_script(entry, filenames, options=options)
  File "/usr/lib/python3.6/site-packages/pip/_vendor/distlib/scripts.py", line 276, in _make_script
    self._write_script(scriptnames, shebang, script, filenames, ext)
  File "/usr/lib/python3.6/site-packages/pip/_vendor/distlib/scripts.py", line 250, in _write_script
    self._fileop.write_binary_file(outname, script_bytes)
  File "/usr/lib/python3.6/site-packages/pip/_vendor/distlib/util.py", line 407, in write_binary_file
    with open(path, 'wb') as f:
PermissionError: [Errno 13] Permission denied: '/usr/local/bin/pcpp'
make[1]: *** [install-volare] Error 2
make[1]: Leaving directory `/home/vijayan/CARAVEL_FLOW/RISCV_Based_BMS'
make: *** [pdk-with-volare] Error 2

Expectation:
make setup should complete without any errors.

There was issue with accessing volare.
Re-installed volate with python3 -m pip install --user --upgrade --no-cache-dir volare
Manually installed openlane and pdks with following steps:
make openlane
make pdk-with-volare


Patch admissions accessible before offical date

By using the right link you can apply before the admissions are supposed to open. Not sure if they actually go through.

Yup they do go through, lol


[R&D] Peer to peer sync capabilities

[ ]  #350
[ ] POC for P2P for to follow

this looks covered by discussion and this issue, https://github.com/opensrp/fhircore/issues/281


ApolloClient 'Access denied for giftCards field'

Issue summary
Shopify-cli create app scope has 'read_gift_cards'/'write_gift_cards'.
Node Api Context set to ApiVersion.April21 (21-04).
const gqlClient = new Shopify.Clients.Graphql('sonity-ltd.myshopify.com', TEST_ACCESS_TOKEN);     const data = await gqlClient.query({       data: {         "query": query getGiftCards {           giftCards(first: 10) {             edges {               node {                 id                }             }           }         }       },     });     const gc = data.body;     console.log("gql client data ", gc)
Expected behavior
GraphQL query/mutation access as per https://shopify.dev/api/examples/gift-cards
Actual behavior
Access denied for giftCards field.
Steps to reproduce the problem

shopify-cli create private node app, serve to test store.
Run afforementioned query using @shopify-api/client.

Leaving this answer behind for anyone who is attempting to interface with gift_cards
You need to have a Plus Account, and ask Shopify Support to enable it as well.


Uninitialized constant Casino::Authenticator

Due to my own fiddling I've caused an exception to be raised during login which in turn causes another exception: Uninitialized constant Casino::Authenticator is thrown at https://github.com/rbCAS/CASino/blob/67ab509a4f6eb9f178da445e5d23475f2dbb4498/app/processors/casino/authentication_processor.rb#L9 when the original exception is handled.
I think you lost the require 'casino/authenticator' when you moved authentication.rb to authentication_processor.rb<EMAIL_ADDRESS>(scroll down to authentication.rb).
I didn't check too hard so not sure on that.

I've created a PR with the require (which fixes it for me) if that's how you want to fix it: https://github.com/rbCAS/CASino/pull/109.


Default document

Is there an option to set the default document ?
Example :
index.html
index2.html -> get this one when no files specified in the URL (http://localhost:8080)

Except for no file specified in the URL. I think it would be very useful to be able to set a default document upon 404. This would be particularly useful for frontend routing like angular or in other frameworks.

My suggestion is similar to the -P option
-P or --proxy Proxies all requests which can't be resolved locally to the given url. e.g.: -P http://someurl.com

I think it would be great if we could proxy a request to a file.

Take a look at #369 which is a clearer proposal for handling a default file scenario than overloading the meaning of "proxy"--which is a protocol term, not a file-related term.
@Robouste @ycmjason give that PR a test run and let me know if it solves your particular needs. If it does, let's move the conversation there and close this one. Cool? 😎 Thanks!

You can use 404.html for this purpose now. See https://github.com/indexzero/http-server/issues/367#issuecomment-471541179


Output buffering during buildFrom* functions

Improves performance by ~ 20 % if there are a lot of files
see the original pull request https://github.com/box-project/box2-lib/pull/21

I did a quick performance test using Symfony and got the following results:
Before PR:
Building...

real    15m51.610s
user    6m55.666s
sys     7m22.764s

After PR:
Building...

real    16m40.861s
user    7m12.818s
sys     7m40.737s

Could you provide me with your own benchmarks with details on what you built to perform the test?

I was finally able to test this. The PR improves performance on HDD but you are right, it really does decrease perf. on SSD (or any other fast IO drive, e. g. /tmp mounted in RAM).
As such, I leave the decision whether to pull this up to you.
Moreover, It may be useful to update the documentation and add some recommendation about creating and building a phar on fast drive/storage and than moving it to the target location.


[Linux] Desktop app does not close

Clicking the red close button in Linux (Arch, GNOME DE) has no effect

Is this still an issue?


Support deletions

We need to have a way to delete rows from a table

I added code that checks for .delete.csv and deletes rows listed there.


Add selfHealing and nodeNotReadyTimeout to nodepool spec

Enable self-healing by deleting nodes after they have been unreachable
for a configurable amount of time

lgtm


Endpoint for getting all users online?

I'd like to create a frontend for my RAS server, but I think it would be really helpful if there was an endpoint that would report how much and who the people that are online.

Sounds good to me. Are you interested in contributing this feature? If so, I can give you some direction on how to start. Otherwise, I can probably pick this up in a week or two.

Sounds good to me. Are you interested in contributing this feature? If so, I can give you some direction on how to start. Otherwise, I can probably pick this up in a week or two.

I'm not familiar with Go, I'll try to implement it on my own if I can.

Now let's say you want to add a GET /user/online endpoint that returns all users currently online. InMemorySessionManager maintains the state of online users. All we need to do is have the endpoint dump the users returned by InMemorySessionManager.AllSessions().
Here's the gist of it:

Add the new route and HTTP handler to server/http/mgmt_api.go. Use the existing handlers as examples.
+ mux.HandleFunc("/user/online", uh.getOnlineUsers)
//...
+ func (uh userHandler) getOnlineUsers(w http.ResponseWriter, r *http.Request) {
+     // ...
+ }

Next, add the InMemorySessionManager dependency to user handler.
type userHandler struct {
    UserManager
+   state.InMemorySessionManager
    logger *slog.Logger
}

You'll need to make make the corresponding change to StartManagementAPI() and in cmd/server/main.go, where the dependencies are injected.

Finally, add logic to the new HTTP handler for pulling the list of users and sending it as a JSON response. (JSON response is not shown here).func (uh userHandler) getOnlineUsers(w http.ResponseWriter, r *http.Request) {
// ...
+ onlineUsers := uh.InMemorySessionManager.AllSessions()
+ var screenNames []string
+ for _, sess := range onlineUsers {
+     screenNames = append(screenNames, sess.ScreenName())
+ }
// ...
}

Let me know if/when you complete this, and then we can proceed to making the code tidy with interfaces, etc before the final commit. But this should guide you towards a working endpoint.

Now let's say you want to add a GET /user/online endpoint that returns all users currently online. InMemorySessionManager maintains the state of online users. All we need to do is have the endpoint dump the users returned by InMemorySessionManager.AllSessions().
Here's the gist of it:
1. Add the new route and HTTP handler to [server/http/mgmt_api.go](https://github.com/mk6i/retro-aim-server/blob/main/server/http/mgmt_api.go). Use the existing handlers as examples.
   ```diff
   + mux.HandleFunc("/user/online", uh.getOnlineUsers)
   //...
   + func (uh userHandler) getOnlineUsers(w http.ResponseWriter, r *http.Request) {
   +     // ...
   + }
   ```

2. Next, add the `InMemorySessionManager` dependency to user handler.
   ```diff
   type userHandler struct {
       UserManager
   +   state.InMemorySessionManager
       logger *slog.Logger
   }
   ```

You'll need to make make the corresponding change to StartManagementAPI() and in cmd/server/main.go, where the dependencies are injected.
3. Finally, add logic to the new HTTP handler for pulling the list of users and sending it as a JSON response. (JSON response is not shown here).
   ```diff
   func (uh userHandler) getOnlineUsers(w http.ResponseWriter, r *http.Request) {
   // ...
   + onlineUsers := uh.InMemorySessionManager.AllSessions()
   + var screenNames []string
   + for _, sess := range onlineUsers {
   +     screenNames = append(screenNames, sess.ScreenName())
   + }
   // ...
   }
   ```

Let me know if/when you complete this, and then we can proceed to making the code tidy with interfaces, etc before the final commit. But this should guide you towards a working endpoint.
Again, if this is too overwhelming, I'll take it on in the next couple weekends :)

Unfortunately, some stuff IRL just happened and I have to deal with that over this weekend. Sorry about that, I hope everything goes well and I hope to see this implemented soon!

No problem. I'm reopening this ticket to track the work.

Implemented in v0.2.0. Please re-open this issue if you have questions or feedback.


[SECURITY] Implement 2FA for Mediawiki

Regarding ‘assurance’ of account access.
We can add another layer of security by adding 2FA with OTP (e.g. via Google Authenticator). https://m.mediawiki.org/wiki/Help:Two-factor_authentication

I tried using https://m.mediawiki.org/wiki/Extension:OATHAuth, but it requires me to relogin using password if I want to enable the 2FA for my account. So this doesn't work out of the box yet.

So we need to replace PW with the other authentication? By using oauth? How
hard is this, what do you think?
On Thu, 4 Nov 2021 at 12:07, rht @.***> wrote:

I tried using https://m.mediawiki.org/wiki/Extension:OATHAuth, but it
requires me to relogin using password if I want to enable the 2FA for my
account. So this doesn't work out of the box yet.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/FantasticoFox/micro-PKC/issues/37#issuecomment-960438730,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKZWZU7TCE4AUEJ4F76HNITUKIIHLANCNFSM5FOZOHMA
.

--
inblock.io
+49<PHONE_NUMBER>4
@.***

Closed and not planned until requested by a customer. Our default login is SIWE-OIDC using Hardware-Wallets with Pins is a very strong way to ensure correct identification.


Add compilation messages and allow customizable verbosity

Currently, when Ammonite is compiling an uncompiled file, there is no message indicating that it is doing anything. It just takes very long (several seconds) until the file is able to start running.
Furthermore, when Ammonite is first resolving dependencies via import $ivy, it prints out the verbose ivy resolution logs, which would mess up any program trying to use the stdout of an Ammonite script as part of a bash pipeline.
This would be solved by making Ammonite print out compilation progress messages, but also making them and the ivy logs configurable: by default it would print everything, but you could pass in a flag -v0 or similar if you are using Ammonite from a script and don't want them.
EDIT: perhaps we could make -v1 the default, and -v2 the "add printlns that echo the source code of every statement before it gets run" flag, similar to set -x in bash

This is basically done: we have both ivy-resolution and compilation log messages, and a new -s flag to shut it up when you're using the scripts and want clean stdout, thanks to @coderabhishek


1password

Flux maintainers who work at different orgs need a secure method for sharing account credentials. For example, for the cncf-flux Zoom account, social media accounts such as twitter #41 etc.
We are using keybase now, but per the list at https://www.cncf.io/services-for-projects/ 1password has a built-in two-factor auth option, which can help make shared accounts more secure. That’s not a requirement but 1password is appealing for this reason.
I had opened a CNCF Service Desk ticket to discuss this, and everyone is on board. I am applying for an open source account at https://github.com/1Password/1password-teams-open-source.

PR open: https://github.com/1Password/1password-teams-open-source/pull/266

Set up vaults for:

Community Team
Security Team
Oversight Committee
Shared (all maintainers will have access to items in this vault)

Added members of each team to those vaults. There may not be much if any passwords that the Oversight Committee needs to share privately, but the vault is set up for that just in case.

We now have an open source promotion on the fluxcd 1password account! 🎉


feat(sqllab): Adds refresh button to table metadata in SQL Lab

SUMMARY
When table metadata changes (e.g. due to queries launched in Superset or other external changes) the user has no convenient way to force a refresh of the data for their TabState. The metadata is persisted even across sessions and will never update if the user stays on the current tab.
This feature is a first step to make this experience better by adding a refresh button for each table that allows a manual refresh.
Future improvements:

Automatically refresh when query is likely to change the metadata
Refresh metadata from time to time
Do not persist the metadata for a SQL Lab tab forever: Maybe remove TableSchema and instead use a shared cache with well defined expiry

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Load SQL Lab and expand a table
Change the table (e.g. add column)
Click refresh button
Expected: New column appears
Refresh the whole page
Expected: Column is still there (asserts the server-side TableSchema was properly updated)

ADDITIONAL INFORMATION

[ ] Has associated issue
[ ] Required feature flags:
[x] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Rebased on master (thought I branched off the latest but apparently that was not the case)


fix(app): update backend url

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Change plot with mode shape

The plot_with_mode_shape() method of CampbellResults has been enhanced to improve user interaction and code maintainability. Key modifications include:

Creation of an internal function that returns the Campbell figure and the update function of the mode shape 3D figure based on the point clicked in the Campbell figure.
Integration of Dash framework to plot both figures, enabling interactive user experience in both web browsers and Jupyter notebooks.
Correction of the issue related to the positioning of the legend when broken into more than one line.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 4.44444% with 43 lines in your changes missing coverage. Please review.

Project coverage is 84.69%. Comparing base (f39e32a) to head (a80933b).
Report is 36 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
- Coverage   85.04%   84.69%   -0.36%
==========================================
  Files          35       35
  Lines        7830     7898      +68
==========================================
+ Hits         6659     6689      +30
- Misses       1171     1209      +38

Files
Coverage Δ

ross/results.py
84.11% <4.44%> (-2.03%)
:arrow_down:

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfd031...a80933b. Read the comment docs.

Hi @raphaeltimbo!
I have already added the extra files to MANIFEST.in. I tested these modifications with pip install and they worked!


Change list to stream

What and why?
How to test?
Trello

/deploy manna

/deploy manna

/deploy manna


Refactor get_tool and run_or_download logic

Context
To have a downloaded wasm-opt work correctly on MacOS, multiple files need
to be extracted (the binary and the binaryen dylib) and those files
have to extracted into different directories. Specifically the binaryen
archive needs to be extracted into an adjacent lib directory. This
seems to necessitate having get_wasm_opt return a cache path that
would be an ancestor of the path to the executable file. Logic in
run_or_download relies on the path to the binary and the cache path
being the same to detect if the path to the tool has been overridden.
Switching get_wasm_opt to return an ancestor path of the executable
would break this check.
What this PR does
To simplify upcoming PRs, I'd like to refactor the stack of code between
get_tool and download_and_run logic to explicitly track whether the
path to the executable has been overridden. Replacing the current
requested != cache_path check will be necessary if cache_path will
have to be different than requested in a situation where there isn't
an override.
Why this approach
The cache_path doesn't seem to be used outside the check to see if the
path has been overridden. So replacing it with a boolean simplifies the
data being passed around.
Alternatives I've considered

Changing wasm-opt's cache_path from wasm-opt to
wasm-opt/bin/wasm-opt and walking back a couple directories in
install_wasm_opt when passing a path to download. That seemed to
spread out knowledge about how the tar file is structured and what
should be extracted where from other alternatives.
Using an enum to represent something like <OverriddenPath<PathBuf> | CachePath<PathBuf>> and then using an if let or matches! check to
detect if the path is overridden instead of (PathBuf, bool). It seemed
like a bit of overhead for what the code is doing but I'd be okay
with switching to this approach.

Seems reasonable to me, thanks!


error in the deployment guide Step 4: Create the Teams app packages

Please update the deployment guide:
Step 4: Create the Teams app packages
Make sure you have cloned the app repository locally.
Open the Manifest\manifest.json file in a text editor.
Change the placeholder fields in the manifest to values appropriate for your organization.
developer.name (What's this?)
developer.websiteUrl
developer.privacyUrl
developer.termsOfUseUrl
Change the  placholders to be the %appDomain% value. There are 2 instances of this placeholder:
The "contentUrl" property of the static tab, e.g. "https://celebrations-xxxxx.azurewebsites.net/Tabs/Events".
The "validDomains" list, e.g. "https://celebrations-xxxxx.azurewebsites.net/Tabs/Events".
[The validDomains has to be in the form: celebrations-xxxxx.azurewebsites.net]
Change the  placeholder in the botId setting to be the %botId% value. This is the same GUID that you entered in the template under "Bot Client ID".
Create a ZIP package with the manifest.json,color.png, and outline.png. The two image files are the icons for your app in Teams.
Make sure that the 3 files are the top level of the ZIP package, with no nested folders.
I spent 2 days going in circles and redoing it all, to realize it is that one line that kept messing up by putting the FQDN in the valid domains
thank you

Thanks for the feedback. We will take care of this.


Duplicate nodes returned in 2023-04 and unstable, fine in 2023-01

What is the location of your example repository?
No response
Which package or tool is having this issue?
Storefront API
What version of that package or tool are you using?
2023-04
What version of Remix are you using?
No response
Steps to Reproduce
The following query, when called against 2023-04 and unstable:
  query {
    metaobjects(first: 4, type: "shops") {
      nodes {
        id
      }
    }
  }

returns two of each metaobject (request ID: 14010230-6cba-4287-88d7-28d7d02587b1):
{
   "data": {
      "metaobjects": {
         "nodes": [
            {
               "id": "gid://shopify/Metaobject/24543329"
            },
            {
               "id": "gid://shopify/Metaobject/24543329"
            },
            {
               "id": "gid://shopify/Metaobject/24576097"
            },
            {
               "id": "gid://shopify/Metaobject/24576097"
            }
         ]
      }
   }
}

Expected Behavior
This request returns correctly on 2023-01 (request ID: d28799fb-e1e9-4e7a-a13a-de97b9f43391)
{
   "data": {
      "metaobjects": {
         "nodes": [
            {
               "id": "gid://shopify/Metaobject/24543329"
            },
            {
               "id": "gid://shopify/Metaobject/24576097"
            },
            {
               "id": "gid://shopify/Metaobject/24608865"
            },
            {
               "id": "gid://shopify/Metaobject/24641633"
            }
         ]
      }
   }
}

This is creating issues on a few live sites that are built to expect uniqueness
Actual Behavior
Too much of a good thing!

Thanks @juanpprieto! Seeing it consistently across all Hydrogen storefronts using 2023-04


fix issues 4

Coverage decreased (-0.7%) to 91.339% when pulling 49ea837ec064cdba718d8eeb4461480500548c0c on unordered:master into 030329cc9f3e307c72fed2642cabb934ba796c40 on react-component:master.

You want multiple dialog support? If so, notice https://github.com/react-component/m-dialog/blob/master/src/DialogWrap.tsx#L79, new dialog  will replace old dialog content

yes, When opening a new dialog, the original happens to be hidden, May be able to join man-made control

I can use difference prefixCls props to show multiple dialog!

@unordered Thanks, but close for https://github.com/react-component/m-dialog/commit/8bd2739f0dc7ade426c2d2c4aa21e6b7f178ddba


✨ Add authentication

🤖 Generated by Copilot at 495d07d
Summary
🌐🔑📊

This pull request adds authentication, authorization and Prisma integration to the app. It updates the package.json file with new dependencies and scripts, the translation files with new strings and fixes, and the next-i18next.config.js file with a new interpolation option. It adds new files for the Prisma schema, seed and TypeScript configuration, the form validation messages, and the components for the invite and user management features. It fixes potential bugs in the AboutModal component and adds a comment to the .env.example file.

This pull request is quite a big deal
It adds Prisma, i18n and bcrypt to the wheel
It also has some UI components
And some validation and permission enhancements
And it fixes some bugs and JSON that were not real

Walkthrough

Add and update dependencies, scripts and configuration options in package.json (link, link, link, link, link, link, link)
Add comment to .env.example file to explain its purpose and usage (link)
Add new configuration option to next-i18next.config.js file to allow interpolation of variables in translation strings (link)
Add new files for Prisma schema, scripts and configuration (link, link, link)
Add new translation strings and files for date formatting and security events in German and English (link, link, link)
Add new files and components for invite creation and management (link, link, link, link)
Add new files and components for user list and permissions (link, link, link, link, link, link)
Fix potential bugs in useInformationTableItems value in AboutModal.tsx file by adding optional chaining operators (link, link, link)
Remove closing curly brace and parenthesis from common.json files (link, link)

Thanks for the feedback @ajnart , but can you maybe wait until this is marked ready for review? It makes no sense to constantly update translation files nor have we decided how we want the UI to be.

Thanks for the feedback @ajnart , but can you maybe wait until this is marked ready for review? It makes no sense to constantly update translation files nor have we decided how we want the UI to be.

Yeah yeah no worries it's just quick feedback in case you still have stuff you are working on and marking code as TODOS

So you expect us to mark everything as TODO? Isn't that what the "draft" marker on the pull request is for?

So you expect us to mark everything as TODO? Isn't that what the "draft" marker on the pull request is for?

No don't touch anything, if you change the code GitHub will show it's outdated so that means it isn't required to be looked at anymore because it has most likely been fixed

Working now on beta instead.


Add backup-cleanup before each backup

If a backup fails, BBR requires you to run a clean-up command or it errors with:
'cannot be backed up: directory /var/vcap/store/bbr-backup already exists'
This commit runs the clean-up command before every backup to ensure
it will be successful.

Hi @z4ce
Thank you for the PR. We think that the bbr backup command should fail when the bbr-backup folder exists. This can be because bbr is currently running, or a previous backup failed.
The bbr documentation recommends running bbr backup-cleanup when bbr backup fails. So we're going to close this in favour of https://github.com/pivotal-cf/bbr-pcf-pipeline-tasks/pull/13.
Emmanouil and @jamesjoshuahill


Use v2 branch to get the Linux CodeQL bundle too

Description
https://github.com/actions/virtual-environments/pull/5307 updated the Windows installer to grab the CodeQL Bundle from the v2 branch, since this is the branch we release the CodeQL Action from.  This PR updates the Linux installer to do the same thing.  Currently this is a no-op, however these branches could feasibly diverge going forward, at which point we'd want the bundle from v2.
Fixes https://github.com/github/codeql-core/issues/2491
Related issue: https://github.com/github/codeql-core/issues/2491
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

@criemen, could you review the PR?

The ubuntu2204 job seems to have failed with a transient error connecting to the PPA repository:
 azure-arm.build_vhd: Err:34 https://ppa.launchpadcontent.net/ondrej/php/ubuntu jammy/main amd64 php8.1-cgi amd64 8.1.7-2+ubuntu22.04.1+deb.sury.org+1
    azure-arm.build_vhd:   Cannot initiate the connection to ppa.launchpadcontent.net:443 (2620:2d:4000:1::3e). - connect (101: Network is unreachable) Could not connect to ppa.launchpadcontent.net:443 (<IP_ADDRESS>), connection timed out [IP: <IP_ADDRESS> 443]

Will try and rerun though not sure whether I have access.

/azp run ubuntu2204


information

Hello, what would be the purpose of the repository? I would like to collaborate with topics in Spanish.

The repo was originally intended as a space to house Ambassador social impact league projects. We will be updating with the projects soon, but in the meantime, we will be using the repository to host a bug bash.


Lunar Teleport GFX

Expected Behavior
Lunar teleports should play a gfx when being cast
Actual Behavior
Lunar teleports do not play a gfx
Steps to Reproduce the Problem

Switch to lunar spellbook (set varbit 4070 to 2)
Use a teleport spell

Added in https://github.com/Tomm0017/rsmod/commit/c0e92482a089b838c3093e336cc1073b9a869520


Downsampling

Hey, I'm trying to get the modivius chip to recognize objects in a 1920x080 image. My current understanding is that the modivius chip will downscale the image to 256x256 (or 160x160) because of the image size of the model. Is it possible to get the modivius chip to not downscale the images and instead run object recognition on the entire image?

There is a downscale step which matches input tensor size, e.g. 160x160 for image classification. This directly depends on your compute graph and its inputs.

Why do you guys downscale? Is there any way to turn this off? So, I'm feeding 1080p30 into the the chip, and I'm trying an object that's farther away. The object already takes up a small number of pixels (because it's far), if the image is downscaled, it may just not show up at all (or be unidentifiable).

hazemati, CNN classification models are trained with fix sized input images, i.e. they can not take images of arbitrary size. However, CNN detection models, if fully convolutional, can take images of various sizes. But due to memory constraint the input images must be tiled if too large. Could you please elaborate in your case, which particular model you trying to run?

My initial tests were run with the MOBILENET, (I was doing image classification). Is it safe to assume that the current object detection models that were provided were not fully convoluted? Since video is coming from the camera into the modivius chipset, then into the rasberry pi, is there anything build into the firmware of the modivius chipset that would perform image tiling?

Also, tilings an ok solution, but what if the object is between the tiles?

Re comment #5:
the current object detection models provided is a fully convolutional model. the constraint on input size is due to the on-chip memory size, not the model architecture. yes, it's possible to do tiling on modivius chip, but it's not implemented in the current version
Re comment #6:
vision kit does not support Yolo model officially, but feel free to try the model compiler on it. if it passes model compilation, with good chance it could be run on vision kit. for how object detection model deal with scale invariance, please refer to the original SSD model paper or any objection detection model paper. usually the model has scale invariance up to some extent. it large scale range is desired, need to apply the model to image pyramid.

So exactly what is the highest resolution that i can go to before I have to do tiling?


Why does fdroid have 5.903 while github has 5.806

There is a changelog and apk for 5.806 in github. But fdroid has 5.903 which is weird? Where did fdroid get those versions?

K-9 Mail versions whose minor version number starts with an odd digit are beta versions. All of them are available on GitHub, too. See https://github.com/k9mail/k-9/releases and https://github.com/k9mail/k-9/wiki/ReleaseNotes
In the future please use the forum for questions like this one.


UrlFor protocol

I'm using urlFor method to get the full URL of a route, but is it not clear to me if it is possibile to set the wanted protocol, it seems always http is given.

Sorry, I just discovered the current UriInterface is used and my server uses http because https is handler by the balancer.

The schema of the request object could be switched using a middleware that you add after the RoutingMiddleware.
$app->addRoutingMiddleware();

$app->add(function(ServerRequestInterface $request, RequestHandlerInterface $handler) {
    $request = $request->withUri($request->getUri()->withScheme('https'));
    return $handler->handle($request);
});

I come back to this topic because it seems getUri()->withScheme('https') doesn't fill the correct port.
had also to add ->withPort(443) otherwise some https URL will be made like https://myhost:80/path and doesn't work.
I don't know if I'm missing something or by design withScheme has to go with withPort method.

@tobiascapin Yes, it makes sense to change these two values (schema and port) together. Thanks for your feedback.


Typescript: Private fields in classes on data properties cause failed type verification since 3.0.8

Version
3.0.11
Reproduction link
https://github.com/tonyfinn/vue-ts-error
Steps to reproduce
There are two projects in the reproduction example.
ts-type-error uses Vue 3.0.8 (but 3.0.11 is also broken). works uses Vue 3.0.7. The two projects are otherwise identical.
Both are using Vue CLI, so can be built by running npm run serve
What is expected?
Both projects would build or fail with the same result.
What is actually happening?
works builds correctly and runs correctly.
ts-type-error fails to build with the following error:
ERROR in src/App.vue:36:15
TS2345: Argument of type '{ readonly bar: string; log: () => void; }' is not assignable to parameter of type 'Foo'.
  Property 'baz' is missing in type '{ readonly bar: string; log: () => void; }' but required in type 'Foo'.
    34 |   methods: {
    35 |     clickHandler() {
  > 36 |       usesFoo(this.foo);
       |               ^^^^^^^^
    37 |     }
    38 |   }
    39 | })

The issue appears to be with the private fields. Inside the component methods, this.foo is not of type Foo as of 3.0.8, only of a type that is effectively the public fields/interface of Foo only. This means that when you use Foo as a type in a function declaration, passing this.foo is rejected, as it is missing the private fields as far as the type checker can see.
This appears to be a type checker issue only, if you change clickHandler to:

    clickHandler() {
      usesFoo((this.foo as any) as Foo);
    }

Then you can observe that the log messages are printed upon clicking the text at runtime.

Yes, It's a bug of type, which related to UnwrapNestedRefs, I'm working on it.

@tonyfinn You can also use this.$data.foo, whose type is Foo. Nevertheless,  that will disable auto unwrapping in type and cause inconsistency between static type and runtime type.

you could close this issue. duplicate with #2981. see fix #3791.

Duplicate of #2981


Raising multiple "Breaking Change" errors when installing nsfwjs in React Js

I am trying to install nsfwjs in my react app (just created for testing nsfwjs) and It is showing bunch of errors right after when I run npm start.
Errors like
Can't resolve 'assert' in **/path/project/**

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "assert": require.resolve("assert/") }'

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "stream": require.resolve("stream-browserify") }'

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "buffer": require.resolve("buffer/") }'
        - install 'buffer'

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "stream": require.resolve("stream-browserify") }'
        - install 'stream-browserify'

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "util": require.resolve("util/") }'
        - install 'util'

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }'
        - install 'path-browserify'

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "zlib": require.resolve("browserify-zlib") }'
        - install 'browserify-zlib'

I have no idea why it is showing these errors. Do I have to install these recommended libraries/packages separately?
My react version is 18.2.0

@Yawan-1 I'm going to take a look at this! How did you create the app? (Some users have had issues with vite)

I didn't create the app using vite but with npx create-react-app.


Don't interpret a touch as a tap if the square has moved since touchesBegan

Fixed in https://github.com/superjohan/contrast/commit/41090034f0e731105104acd90d66348d4b1f4c5a


Updating the program

Hey, I just wanted to say that I absolutely LOVE your program. It's open source and helped me eliminate chattering. Will you update it some more or is it finalized completely (I see last update was pretty far back in December)

Hi!, sorry about the really late response.
I did not continue developing this as I bought a new keyboard without the shattering problem. But since I just see this message maybe I will try to finish some thing that are half done.
Thanks!


this is count pruning, not cost pruning

@manasij7479 this code was added by you. I don't think //TODO comment is relevant anymore. Also, i renamed the function to reflect exactly what it's meant to do.

wait a second, why do we want to do this at all? what's going on here @manasij7479?


Add type checking for boto3

Feature or Bugfix
Feature
Detail
In order to have type checking for boto3-related code, I added boto3-stubs-lite library. I did not make any changes in the code, looks like there are no typing issues. But it could be helpful to have type checking for boto3 anyway.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thank you! I noticed that boto3-stubs were not installed in validate.sh, that is why some return types were incorrectly considered as Any. Fixed.


Support for adding menu items

These items could load other bundled scripts.
This is helpful when especially with "Remain running after initial execution"

This would add another layer of complexity to Platypus, which I'm not keen on. Sorry.


Cannot read property 'x-stream-error' of undefined

Environment
React Native Environment Info:
System:
OS: macOS High Sierra 10.13.6
CPU: x64 Intel(R) Core(TM) i5-4308U CPU @ 2.80GHz
Memory: 30.14 MB / 8.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.8.0 - /usr/local/bin/node
Yarn: 1.9.4 - /usr/local/bin/yarn
npm: 6.4.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
Android SDK:
Build Tools: 23.0.1, 25.0.0, 26.0.1, 26.0.3, 27.0.3, 28.0.2
API Levels: 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28
IDEs:
Android Studio: 3.1 AI-173.4907809
Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
npmPackages:
react: 16.4.1 => 16.4.1
react-native: 0.56.0 => 0.56.0
npmGlobalPackages:
create-react-native-app: 1.0.0
react-native-cli: 2.0.1
I am having this problem when trying to use ipfs-api module on React Native. I am using the ipfs-api version 24.0.1 imported to React Native with rn-nodeify version 10.0.0 with the following steps:
npm i --save rn-nodeify
npm i --save ipfs-api

Then uncomment require('crypto') in shim.js at the root of React Native project.
Then go to this file:
vi ./node_modules/isomorphic-fetch/fetch-npm-browserify.js

and add
var self = this;

before module.exports line in the file.
Finally run:
./node_modules/.bin/rn-nodeify --hack --install
react-native link

Code
I have the following code in my project following the example for ipfs-api:
const ipfsAPI = require("ipfs-api");
...
ipfs = ipfsAPI("<IP_ADDRESS>", "5001", { protocol: "http" });
...
ipfs.files.write(       // Error here
      "/aaa.txt",
      buffer,
      {
        create: true,
        parents: true
      },
      err => {
        console.log(err);
      }
    );

Error
When I tried running the code above in my project I get the following error:

And in the debugger I see the following:

The problem is that there is no res.trailers element for the res variable inside the onRes function.
This function is located at /node_modules/ipfs-api/src/utils/send-request.js

Any thoughts is welcome, thanks for your time!

It seems like the response from ipfs is corrupted or malformed. The picture below shows the Wireshark tracking the packet sent from ipfs to my app and the data is malformed.

This shows that in the packet inside trailer the x-stream-error is specified so there is indeed a x-stream-error to read from. So most-likely the ipfs node running is sending a bad response.
The ipfs version I am running is version 0.4.17.
Again please leave a comment if you have any idea why this happening, thanks in advance!


Vertical Nav Icons are not blue on active

Select one ...  (check one with "x")
[x ] bug
[ ] feature request
[ ] enhancement

Expected behavior
In the demo for the Vertical Nav with icons, the icon for the active link has a blue fill color on active and on hover. (see https://vmware.github.io/clarity/documentation/vertical-nav/icon-links/normal)
Actual behavior
However, on our page, it appears that the blue fill color is only enabled on hover and not on active/selected.
I was expecting that the blue fill color would be enabled on both the active and hover.
Reproduction of behavior
This behavior is also seen in an existing plunker found in issue 1539 (https://github.com/vmware/clarity/issues/1539).
https://plnkr.co/edit/qBTft97DXV8G8bYYBWww?p=preview
Environment details

Angular version: 4.x.x
4.3.6

Clarity version:
v0.10.5 and v0.10.8

OS and version:
Mac 10.11.6

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
Chrome 61

@lthoang101: In the plnkr you have provided, I do not see the router links configured. Without that routerLinkActive will not work. Could you please provide an updated plnkr with the router links so we can reproduce the issue.

@lthoang101: Are you still facing this issue with the routes configured?

@lthoang101: We haven't heard back from you regarding this issue. We are closing the issue assuming that you managed to resolve it at your end. Please feel free to reopen the issue with the routes configured if you continue facing this and we will take a look. Thanks!


Dist build only show a black screen

OS version and name: Windows 10

Hyper.app version: master

Link of a Gist with the contents of your .hyper.js: Default one

Relevant information from devtools
(re)loading renderer plugins
Uncaught TypeError: Cannot call a class as a function
total init time 3174.4800000000005
TypeError: Cannot redefine property: keys
Uncaught TypeError: Cannot match against 'undefined' or 'null'.

The issue is reproducible in vanilla Hyper.app: N/A

Issue
Building a dist build from the current master on Windows (Node v6.9.0) only show a black window when run (the devtools are working fine). Running a terminal from w/ npm run app works as expected. I'm not sure if you're already aware of this bug, but I figured might as well open an issue just in case. The main error seems to be Cannot call a class as a function, which is probably related to the build configuration.

For some reason, removing NODE_ENV=production inside package.json generated a build that worked.

@arcanis thank you for reporting! Could you try the latest master? I'm pretty sure I fixed it 🙏

Nevermind, just got a build from travis and the issue is back


Fix failing tests

Add check to throw if found id collisions + test
Stopped renaming datePlanted as planted since datePlanted is the name of the table column and planted is a key returned by the vector tiles
Uncomment expressErrorHandler to regain central error handler functionality
Add --experimental-vm-modules flag to launch.json so that the Jest supports ESModules in the VS Cdde debugger.
Remove unused and commented code

bodyParser.json() is made redundant by express.json()
deleted variables in trees-router.js that we not being used

What does that vm do in launch.json?
The --experimental-vm-modules flag makes it so that Jest can support ESM projects.

Is there a native fetch version of that axiosAPI test?
I don't know if I fully understand this question, but we can eventually make a function that uses native fetch to replicate the axios call. That would remove the need for axios as an external dependency.

I'd previously commented out the index's error handler because it was returning too generic an error or breaking the sql when it errored. Is that fixed with this commit?
Was the change solely for debugging purposes? If so I can add a quick change so that we log all SQL calls. Also, would like to improve our logging overall. Otherwise I tested the changes (creating and getting a tree) and things seemed fine on my end.

I think when sql returned bad data or something, it would break and not return anything or send back a response other than a 500.

Right I remember now. I think we have to talk about what counts as an expected result unexpected result. In my mind if the sql call is formatted wrong, then we should return a 500 error. But in this case for findTreeById, we can probably change it from db.one() to db.oneOrNone() since it's possible for the tree to only be in the vector tiles. Right now it would throw a 500 error is no tree was found because we coded it so that we expect be one row returned, but it should also be fine if no rows were returned. Then a 500 would be thrown if the sql call was formatted wrong or more than 1 tree with the same id was found. Would do you think?

If we have an id collision, we should probably handle it, return a specific error about the collision, so it gets logged and we can investigate that id. There is some probability of collisions so that's not really an unexpected error (500).

I can change it so we return all rows and then throw a 400? error + message about collision if more than one row is returned.  Otherwise, if 0 or 1 rows are returned, then we do what were doing now.

I added a check for collisions
https://github.com/waterthetrees/wtt_server/pull/101/files#diff-46fb011f2bd00532779ee42889b32096d8caac5b9c6404d89512c072fa30ec30R33-R40
and a test
https://github.com/waterthetrees/wtt_server/pull/101/files#diff-2df4b304dc84eb5f1bad37299d5d1a8a8c83f8e77423da739c97f0e464561babR105-R136

Ok, we can discuss the collisions in more details next meeting. I fixed the tests because I'm looking to aggressively? refactor so that our business logic is separated from external sources. This will hopefully allow for more unit tests and increased confidence in making any changes further down the line. I've been saying I wanted to do this for a while now, and so I think I just need to make quick, iterative changes more often instead of waiting to find the "perfect" solution. So it's possible that I break some things during this process 🙃, but I think it'll payoff when we're making changes in the future.


require-meta-type does not work if create is not a function

The following does not fail linting:
/* eslint eslint-plugin/require-meta-type: error */

function create(context) {
	// ...
}

module.exports = {
	meta: {}, // should fail
	create
};

/* eslint eslint-plugin/require-meta-type: error */

const create = (context) => {
	// ...
}

module.exports = {
	meta: {}, // should fail
	create
};

It looks like the utility for checking if a file contains a rule has a hard check for create being a function. Is this check necessary? Can I submit a PR to either:

Allow identifiers on the right side of create even if they are not functions?
Or follow identifiers on the right side of create if they reference a function in the same file?

Allow identifiers on the right side of create even if they are not functions?
Or follow identifiers on the right side of create if they reference a function in the same file?

personally I prefer the second, but I'm fine either way.  PRs are welcome! 😄

Awesome, I should have time this week to whip something up.


Accessing getGeneratedKeys from QueryExecutionListener

Thank you for this great library !
I am building a custom QueryExecutionListener that will trace all INSERT, UPDATE, DELETE queries in a central database audit table. I need to generate one audit row per atomic statement. This means batch statements of 10 will trigger the creation of 10 audit logs.
Everything is working except for the INSERT queries. For them, I want to be able to trace the database query WITH the generated keys.
I know that my listener is currently triggered twice:

After executeUpdate
After getGeneratedKeys

But my listener can't link the two events, and I have no guarantee that the caller will call getGeneratedKeys after each executeUpdate.
In step 1, if my listener opens the Statement::getGeneratedKeys ResultSet before the caller, the caller throws an exception later when the caller tries to read it a second time.
After much digging, the only solution I see is to pass the getGeneratedKeys resultSet as a RepeatableReadResultSet in ExecutionInfo at step 1 in PreparedStatementProxyLogic and StatementProxyLogic.
Oversimplified change for PreparedStatementProxyLogic:
final ExecutionInfo execInfo = new ExecutionInfo(this.connectionInfo, this.ps, isBatchExecution, batchSize, method, args);

        queryListener.beforeQuery(execInfo, queries);

        // Invoke method on original Statement.
        try {
            final long beforeTime = System.currentTimeMillis();

            Object retVal = method.invoke(ps, args);

            final long afterTime = System.currentTimeMillis();

            // execInfo.setResult will have proxied ResultSet if enabled
            if (METHODS_TO_RETURN_RESULTSET.contains(methodName)) {
                retVal = proxyFactory.createResultSet((ResultSet) retVal, this.connectionInfo, this.proxyConfig);
            }
            // START OF NEW CODE
            // Would set a repeatable resultset
        execInfo.setGeneratedKeys(proxyFactory.createGeneratedKeysResultSet(ps.getGeneratedKeys()));
            // END OF NEW CODE
            execInfo.setResult(retVal);
            execInfo.setElapsedTime(afterTime - beforeTime);
            execInfo.setSuccess(true);

            return retVal;
        } catch (InvocationTargetException ex) {
            execInfo.setThrowable(ex.getTargetException());
            execInfo.setSuccess(false);
            throw ex.getTargetException();
        } finally {
            queryListener.afterQuery(execInfo, queries);
        }

What do you think of that?

Hi @reda-alaoui
Thanks for the PR and detailed explanation about getGeneratedKeys().
I looked at the PR and it makes sence for how it is implemented to support retrieving generated keys.
Can you add some unittests? I'll be happy to merge it.


Use ci_timeout for merging

From https://github.com/hiboxsystems/marge-bot/commit/6fd802c4e0ac86bdd5649d1b0259f3434a7deb24
We get a lot of It is taking too long to see the request marked as merged!, so would be nice to have this change.

Thanks for the PR @vassilisimon!
First of all, this repository is more or less in a permanent maintenance mode, so don't expect too much activity to take place.
Are you actively using our fork? I would suggest you take a look at https://gitlab.com/marge-org/marge-bot too, it has a bit more activity, and our goal is to eventually move over to it as well.


build(test): run mocha directly without separate transpilation

We've been running mocha with separate transpilation step via tsc as we've been experiencing transpilation performance via ts-node (or other mocha's transpiler registration) was not good enough. The current approach is generally fine for the perf, but as it requires 2 stage it makes bit tricky to setup things by pointing /dist, also some tooling side support like watch mode is not cleanly working.
This PR goes back to transpilation registration via mocha directly. But the difference is now this uses swc as transpilation backend instead of typescript itself. I've been trying to use swc for few places and so far our limited usecase (test) it seems working well sufficiently. If not, we can make upstream fix as well.
You may notice this uses ts-node still instead of directly using @swc/register. I choose this to let ts-node interops our tsconfig into swc instead of we maintain another swcrc config.
Please give it a go local run for the performance. So far on my local machine this works quite well.

Description:

BREAKING CHANGE:
Related issue (if exists):

Note this is only for the test, nothing changes regarding actual build output: we'll always use tsc for the actual compilation since we need type check anyway.

Interestingly one test case fails on CI, while locally passes. Will leave it for now while discussing if we want to this change or not - if we want to go, will try to debug further.

I think so, this is an improvement to test. Rebased.


[WIP] ContextSnapshotFactory allowing clearing ThreadLocals upon scope enter

This work is in progress, requires tests for the clearing behaviour.
The current scope:

Added a ContextSnapshotFactory concept, that allows configuring with a ContextRegistry and a boolean flag whether missing mappings in a context object should clear existing ThreadLocals or not touch them.
Deprecated existing static methods in ContextSnapshot and made them use a global instance of ContextSnapshotFactory which does not clear missing values.
Forked the DefaultContextSnapshot test to cover the deprecated methods.
Used a ContextSnapshotFactory.Builder in tests to depict the intended usage.

@rstoyanchev thanks for the suggestion. I applied the change to the draft, let me know your thoughts. Keep in mind the DefaultContextSnapshot and DefaultContextSnapshotFactory implementations need to provide backwards compatibility to allow for the deprecated methods to behave as before.

One more thing, I see the setThreadLocalsFrom static methods are moved to DefaultContextSnapshotFactory but not the capture static methods. I think it would make sense to have that logic in the factory.


Bad setting leading to full load of data regardless of Virtual Mode

There's a vital piece of optimization that is done wrong in this example - the DataGridView.AutoSizeColumnMode is set to .AllCells. That requires loading the entire set of rows, not just the displayed window, to calculate cell widths. That means the CellValueNeeded event is called for every cell in every row of the data upon initialization; hardly the desired behavior for a Virtual Mode table.
The AutoSizeColumnMode should be set to .DisplayedCells or .None, so display only requires fetching a few lines. The speed difference in my code for setting the .RowCount value (~50K rows, 10 columns, 8 lines displayed) was 45 seconds for AllCells versus ~4 milliseconds for DisplayedCells. This should be a key recommendation for Virtual Mode.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aec74745-9e0c-9e4a-d749-d877ea4c3d38
Version Independent ID: 1e13259c-5787-d1d8-06ba-b4d13f7ba011
Content: Walkthrough: Implement virtual mode in DataGridView control - Windows Forms .NET Framework
Content Source: dotnet-desktop-guide/framework/winforms/controls/implementing-virtual-mode-wf-datagridview-control.md
Product: dotnet-framework
Technology: dotnet-winforms
GitHub Login: @adegeo
Microsoft Alias: adegeo

Thank you for the this suggestion. Enhancing this article is a low priority right now. If you would like to contribute, you can submit a fix by editing the original article. Click on the Content Source link at the bottom of your original comment. To learn how to edit, see the Editing files in a repository article from GitHub.

Done. The guide to DataGridView Best Practices already says to avoid .DataGridViewAutoSizeColumnsMode.AllCells, now the edited Cpp, C#, and VB examples use .DisplayedCells instead.
Kevin Ryan
Senior Software Engineer
8700 Morrissette Drive
Springfield, VA 22152
T.<PHONE_NUMBER> x61024
C.<PHONE_NUMBER>
@.***
www.sonix.com
From: Andy (Steve) De George @.>
Sent: Monday, September 12, 2022 2:52 PM
To: dotnet/docs-desktop @.>
Cc: Ryan, Kevin @.>; Author @.>
Subject: [EXTERNAL] Re: [dotnet/docs-desktop] Bad setting leading to full load of data regardless of Virtual Mode (Issue #1501)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Thank you for the this suggestion. Enhancing this article is a low priority right now. If you would like to contribute, you can submit a fix by editing the original article. Click on the Content Source link at the bottom of your original comment. To learn how to edit, see the Editing files in a repositoryhttps://urldefense.com/v3/__https:/help.github.com/articles/editing-files-in-your-repository__;!!KPww_GFiJXw!flgfLPhG4B-2FVvm0T617BbzNeKrMY1CMcxRTblyOc7Wam8nW7VYgoOHPQjvmqk_TJLKk_4USg0XWibpiCy0cG2v$ article from GitHub.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/dotnet/docs-desktop/issues/1501*issuecomment-1244156581__;Iw!!KPww_GFiJXw!flgfLPhG4B-2FVvm0T617BbzNeKrMY1CMcxRTblyOc7Wam8nW7VYgoOHPQjvmqk_TJLKk_4USg0XWibpiM0gm1py$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJMYDSDR5IU5VZGCGSPTO4DV553UXANCNFSM6AAAAAAQG4DGOU__;!!KPww_GFiJXw!flgfLPhG4B-2FVvm0T617BbzNeKrMY1CMcxRTblyOc7Wam8nW7VYgoOHPQjvmqk_TJLKk_4USg0XWibpiBqCyTjg$.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>
Please be advised that this email may contain confidential information. If you are not the intended recipient, please notify us by email by replying to the sender and delete this message.

Hi! I didn't see a PR come through for the changes? Are you sure you made them?

Thank you for putting in the effort :) I can see your updates in your copy of the repository. Those need to be ported into this one through a PR. I can actually open them up for you since you're busy.

PR = Pull request?  Push request? If you can incorporate those, that would be fantastic.
I've had GitHub on my "to learn" list for a while, but haven't had a need to make it a priority... perhaps I should change that.
Kevin Ryan
Sent from my Metro By T-Mobile 4G LTE Android Device
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Andy (Steve) De George @.>
Sent: Tuesday, September 13, 2022 1:16:28 PM
To: dotnet/docs-desktop @.>
Cc: Ryan, Kevin @.>; Author @.>
Subject: [EXTERNAL] Re: [dotnet/docs-desktop] Bad setting leading to full load of data regardless of Virtual Mode (Issue #1501)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Thank you for putting in the effort :) I can see your updates in your copy of the repository. Those need to be ported into this one through a PR. I can actually open them up for you since you're busy.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/dotnet/docs-desktop/issues/1501*issuecomment-1245709349__;Iw!!KPww_GFiJXw!eetNio8JkxxLOXkhTRPDwv5ZQx1sTZGnUEaOh_7IGtRIiUai0zQWPhhH4y0ukfGD1VNFWabCwjU9wK3UTAcGDUYK$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AJMYDSFCUOM4OVR2TQ4LKY3V6CZGZANCNFSM6AAAAAAQG4DGOU__;!!KPww_GFiJXw!eetNio8JkxxLOXkhTRPDwv5ZQx1sTZGnUEaOh_7IGtRIiUai0zQWPhhH4y0ukfGD1VNFWabCwjU9wK3UTNMVJsWE$.
You are receiving this because you authored the thread.Message ID: @.***>

Please be advised that this email may contain confidential information. If you are not the intended recipient, please notify us by email by replying to the sender and delete this message.

Correct, pull request, meaning request that your changes are pulled into the main repository.

With the way that you created your fixes (you did a separate branch for each file) I merged all three branches into a single temp branch here. I think this may remove you from the contributor history 😦 So to fix that, please use this link to open a final pull request from this temp branch to the main branch: https://github.com/dotnet/docs-desktop/compare/temp-merge?expand=1
In the fixes text, you can reference this issue id: 1501 but don't worry, I can edit the text and get it all hooked up for you if you can't figure it out. Just click that link and open the PR

Don’t worry about crediting me – I’ll be satisfied just to see the correction(s) done. That particular setting issue wasted half a day for me; if I can save others that hassle, great.
Kevin Ryan
Senior Software Engineer
8700 Morrissette Drive
Springfield, VA 22152
T.<PHONE_NUMBER> x61024
C.<PHONE_NUMBER>
@.***
www.sonix.com
From: Andy (Steve) De George @.>
Sent: Wednesday, September 14, 2022 4:17 PM
To: dotnet/docs-desktop @.>
Cc: Ryan, Kevin @.>; Author @.>
Subject: [EXTERNAL] Re: [dotnet/docs-desktop] Bad setting leading to full load of data regardless of Virtual Mode (Issue #1501)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
With the way that you created your fixes (you did a separate branch for each file) I merged all three branches into a single temp branch here. I think this may remove you from the contributor history 😦 So to fix that, please use this link to open a final pull request from this temp branch to the main branch: https://github.com/dotnet/docs-desktop/compare/temp-merge?expand=1https://urldefense.com/v3/__https:/github.com/dotnet/docs-desktop/compare/temp-merge?expand=1__;!!KPww_GFiJXw!f3H-oPUB5vn681EyUsPvlRXlgzmAo3VjlfCH48lwy8rP8axVPN56J7GH3T0NgCxI7nRw3HZUdO0b-diFSVdrw7ss$
In the fixes text, you can reference this issue id: 1501 but don't worry, I can edit the text and get it all hooked up for you if you can't figure it out. Just click that link and open the PR
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/dotnet/docs-desktop/issues/1501*issuecomment-1247256539__;Iw!!KPww_GFiJXw!f3H-oPUB5vn681EyUsPvlRXlgzmAo3VjlfCH48lwy8rP8axVPN56J7GH3T0NgCxI7nRw3HZUdO0b-diFSdJ66xp4$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJMYDSGZEOZHYBSW36PSSJTV6IXC5ANCNFSM6AAAAAAQG4DGOU__;!!KPww_GFiJXw!f3H-oPUB5vn681EyUsPvlRXlgzmAo3VjlfCH48lwy8rP8axVPN56J7GH3T0NgCxI7nRw3HZUdO0b-diFSWH8G9QC$.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>
Please be advised that this email may contain confidential information. If you are not the intended recipient, please notify us by email by replying to the sender and delete this message.


vSphere Lookup API pulls all Folders

the /meta/folders endpoint returns all folders including network and should be limited to only VM folders.

https://github.com/rancher/rancher/pull/23951

rancher/rancher:v2.3-head 160e3b691

Folder field in node template correctly shows only VM folders


Encapsulate CSS styling with the code.

"Also. Can you look at ways to avoid explicitly loading css files in the index.html? I think we can bundle them with dbslice.js . e.g. https://www.npmjs.com/package/rollup-plugin-import-css"

Hi @grahampullan,
I included rollup-plugin-import-css which allows us to use the module import syntax to import css from local files. The css is injected into the DOM by appending a style element to the target div. I also encapsulated external css files, they are injected into the DOM as links.
I also changed the box-icon approach to use  elements. Let me know if this makes a change in Safari.
Another aspect is backwards compatibility. I think the approach for external css files should work in older browsers also. Will older browsers support the "rollup-plugin-import-css" approach? Otherwise we can adapt the external approach for local files also.


Basic example page crashes MacOS Safari.

Describe the bug
I am experiencing a crash on mac Safari v.15+ when running the path tracer in my application. As a test, I visited the basic example page and it experiences the same error: "A problem repeatedly occurred with..." I do not experience the same issue on Chrome or on iOS Safari.
Expected behavior
The path tracer should run without crashing the tab.
Screenshots and Repro Model

Platform:

Device: Desktop
OS: MacOS Monterey 12.3.1
GPU: Radeon Pro 555
Browser: Safari
Three.js version: latest sample page version?
Library version: latest sample page version?

Additional context...This is on a 5 year old MacBook Pro, so it's very possible that this is not worth tracking down if it's not happening on newer equipment. This works on iOS Safari on my iPhone SE and my iPad so I assume that it's not Safari, per se, but most likely a GPU issue. Happy to provide the Mac console crash dump if you really want to go into the weeds.

Unfortunately without being able to reproduce the problem I won't be able to do a whole lot but feel free to add any error logs to the issue. I believe Safari v16 fixed a bug that was causing an issue previously -- is it no longer possible to update Safari on that mac to check?
If you'd like to dig in yourself I can give some pointers but I suspect it will come down to device-specific shader compilation issues.

Safari 16 was the fix. What's really interesting is now everything looks great in Safari, but not so great (see #310) in Chrome.

but not so great (see https://github.com/gkjohnson/three-gpu-pathtracer/issues/310) in Chrome.

Might be something to report to Chrome, then. As you can imagine the pathtracer shader is fairly complex and I've found compiler / driver quirks in quite a few platforms.
It could also be reported to #62, as well, if you want to compare your machine specs.

Yep. Looks like exactly the same errors. Basically no shadows in Chrome and botched reflections. I'll track there.


AFTER RELOADING USER IS BECOMING UNAUTHORISED

@thisisarsh1  please make sure for the user ux that if user is login in his browser then it should not became logout unless and until user make logout request or his session of token expire

Done bro


"Update Repo"-related questions

Hi Magnus,
Is it intented that an "Update Repo" loads also duocontrol.py and spiritlevel.py even if these 2 modules were not enabled in the previous version?
E.g., my ESP32 was running RelNo:1.5.a and both modules disabled (i.e. not selected during the setup and not enabled later either). Then I did an "Update Repo" and saw that these 2 modules were loaded. Is this needed in case the user wants to enable them and to ensure that then they are up-to-date?
BTW, after the update, the footer still shows the initial version:

MIT (c) Dr. Magnus Christ (2022) RelNo:1.5.a

I assume that this info is just not updated but I am a bit unsure. Maybe the update was not fully successful? How could I check?
Finally, does the "Update Repo" function always update to your latest Repo main? How about breaking changes that could happen? Would it then be possible to update to some "in-between-version" to keep things running?
Thanks and my best regards
7wells

To use the 2.x versions, you must first flash the ESP32 again. I have also explained this in the readme, because due to the small RAM memory, part of the code is in the flash memory.


Add flutter SelectableText widget

Please Describe The Problem To Be Solved
I need access to selected text in a Text or Markdown element from a flet app. Flutter provides the SelectableText widget for this and from my research it seems to be only option in Flutter.

Text control in Flet already has selectable property which turns the control to SelectableText.
Are you looking for the way to work with selection (like onSelectionChanged)?

Yes, I'm looking for onSelectionChanged (didn't know setting selectable has this effect, using it so cut&paste in the browser works). I'm on 0.21.2. Just found that SelectionArea got a on_change in https://github.com/flet-dev/flet/pull/2882 .

You can do the following(with the latest Flet prerelease or the upcoming v0.22.0):
import flet as ft

def main(page: ft.Page):
    page.add(
        ft.SelectionArea(
            ft.Text("This is some selectable text.!"),
            on_change=lambda e: print(e.data),
        )
    )

ft.app(target=main)


Server Error (500)

Dear @Logan-Ruf,
We are running a public challenge for 2 days on codabench.org starting monday February 15
5 participants reported Server Error (500) when trying to login or accessing the competition (id 237).
Do you have any idea how to fix this?
Thank you very much

Current things I've tried

Logging in as a user is working from my machine
I was able to navigate to your competition and register without any issue
When checking the server logs I wasn't able to find any error 500 logs. Could be too far back, server restart deleted them, or they might not be getting to the server.

I would try sending them another link to double check they are using the right one: https://www.codabench.org/competitions/237/
You could also publish the competition and have them navigate to it from the "Public Competitions" page.
If that still doesn't. You could try having someone who is having issues register with a new account and see if it's a problem with their user account.


Fix: Make the default plot.update function a noop

To restore the original functionality add updater='sync',
Fixes #380
Fixes #issuenumber.
Changes proposed in this pull request:

Make the default plot.update function a noop

Alternative to #421

Closing in favour of #421


[stable/prometheus-operator] serviceMonitorSelector doesn't respect empty list

Describe the bug
Docs says default value for prometheus.prometheusSpec.serviceMonitorSelector is {}
However:
kubectl -n monitoring get Prometheus prometheus-prometheus-oper-prometheus -o yaml:
[...skip...]
   serviceMonitorSelector:
    matchLabels:
      release: prometheus

When I try to set it's value to {} to catch any ServiceMonitor chart also doesn't respect this value and set serviceMonitorSelector: matchLabels: release: prometheus
Version of Helm and Kubernetes:
Client: &version.Version{SemVer:"v2.14.3", GitCommit:"0e7f3b6637f7af8fcfddb3d2941fcc7cbebb0085", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.3", GitCommit:"0e7f3b6637f7af8fcfddb3d2941fcc7cbebb0085", GitTreeState:"clean"}

kubectl get node
NAME                        STATUS   ROLES    AGE    VERSION
cl1f5490vdqdubu1j3md-adab   Ready    <none>   10d    v1.13.10
cl1f5490vdqdubu1j3md-uvaw   Ready    <none>   2d5h   v1.13.10
cl1f5490vdqdubu1j3md-uwem   Ready    <none>   10d    v1.13.10

Which chart:
helm list
NAME            REVISION        UPDATED                         STATUS          CHART                           APP VERSION     NAMESPACE
prometheus      8               Sun Sep 15 05:13:18 2019        DEPLOYED        prometheus-operator-6.11.0      0.32.0          monitoring

What happened:
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
values.yaml
prometheus:
  prometheusSpec:
    serviceMonitorSelector: {}

Anything else we need to know:

I had the same issue. @baznikin did you find a workaround ?

I had the same issue. @baznikin did you find a workaround ?

I just edit kubectl -n monitoring edit prometheus prometheus-prometheus-oper-prometheus:
  serviceMonitorSelector: {}

helm upgrade do not overwrite this edition


add dataloader unit testing to container run

Adds an entry to run unit tests from dataloader repo in the ci script.

rerun tests

rerun tests

rerun tests

rerun tests

notebook test is timing out. Increasing limit from 2 mins to 3 mins seems to work #729 not sure why it's got slower though (and maybe worth a follow-up to check. might be the code, but might also be the environment?). Perhaps we were close to the limit before.
Based on this PR, it does seem like we're now consistently not able to run within the previous time limit.

rerun tests


Added Call to Action

This is per issue #13. It can also address issue #17, but that would involve making the hero box taller (as more lines of text would break the mobile layout).
There are two elements to this addition:
Index
On the index page, I've added an overlay over the hero image box that mimics the look of the main Firehose page.  I've included buttons that link to the main Firehose Page (to learn more) and to the sign up form for Firehose Intro (to sign up). This overlay does not appear on any other page.
To do the typing, deleting, and re-typing, I've used Typed.js, a jQuery plugin that made it super easy.  I've created a new folder called assets, and typed.js lives in the assets folder.
I've tested it using Chrome's device mode for the mobile layout, so it should look alright.  Let me know if there are any problems.
Footer
On every other page, I've added a box to the footer that includes links to the same 2 pages.  I thought it would be a good idea to give visitors a way to find out more from any page.

Looks pretty good. I'll merge it. I really like the call to action JS stuff on the landing page. Still have an issue with the navbar text but I'll change that quickly, it should be hidden on mobile devices.

Love the typed.js stuff! :)  :+1:

@colinrubbert Thanks.  What navbar text do you have an issue with?

@jonathanpike I fixed it already. The Firehose Community text next to the icon, it was bleeding over. I just hid it on xs devices. Looks good now.

@colinrubbert I thought that's what you meant, but I wasn't sure.  I noted that in issue #46, which I'll now close.


apex_ls file incorrect format in registry

apex-jorje-lsp.jar is the LSP file for Salesforce apex lang.
Mason already includes apex_ls in the registry, but it unpacks the downloaded apex-jorje-lsp.jar lsp file.
Instead, it should have been the jar file, which is in turn sourced by mason-lspconfig here
I took a look at the registry package.yaml definition, it seems we need to change to a share node and give the jar file name? Need a bit of guidance here to create a PR.
At the moment, in order to have it working, I download the jar locally and overwrite the apex_ls path in my init.lua
 lspconfig.apex_ls.setup {
     apex_jar_path = os.getenv('HOME') .. '/apex-jorje-lsp.jar',
     ......
 }

Thank you William, it works like a charm now!


Adds support for creating and displaying the transform continuous mode

Signed-off-by: Robert Downs<EMAIL_ADDRESS>Description
This change adds support for the continuous mode for transforms in the front end, following the backend introduction in this PR https://github.com/opensearch-project/index-management/pull/206
The changes consist of:

Adding a radio button to set the continuous mode for transforms

Displays the continuous mode when confirming the transform details before issuing the final create

Displays the continuous mode of transforms in the transform details page

Displays the continuous mode of transforms in the transforms job page

Separates init and started status for transforms. Previously transforms would show as initializing until they finished, now they show as started when running in continuous mode.

Issues Resolved
https://github.com/opensearch-project/index-management/issues/152
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #153 (d42494f) into main (c28acf8) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   63.38%   63.40%   +0.01%
==========================================
  Files         155      155
  Lines        4419     4432      +13
  Branches      690      691       +1
==========================================
+ Hits         2801     2810       +9
- Misses       1402     1407       +5
+ Partials      216      215       -1

Impacted Files
Coverage Δ

...s/CreateTransform/components/Schedule/Schedule.tsx
90.90% <0.00%> (-9.10%)
:arrow_down:

...ainers/CreateTransformForm/CreateTransformForm.tsx
58.22% <0.00%> (-0.58%)
:arrow_down:

...es/Transforms/containers/Transforms/Transforms.tsx
70.49% <0.00%> (ø)

...sform/components/ReviewSchedule/ReviewSchedule.tsx
80.00% <0.00%> (ø)

...ainers/ReviewAndCreateStep/ReviewAndCreateStep.tsx
90.00% <0.00%> (ø)

...ainers/SpecifyScheduleStep/SpecifyScheduleStep.tsx
47.50% <0.00%> (ø)

...nsforms/containers/Transforms/TransformDetails.tsx
75.65% <0.00%> (+0.43%)
:arrow_up:

...n/public/pages/Transforms/utils/metadataHelper.tsx
72.41% <0.00%> (+2.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de197e8...d42494f. Read the comment docs.

We can add a cypress test to ensure that a continuous transform can be created. Or add an issue for this.


[BUG] Website broken, throws exception

Describe the bug
When going to godbolt.org the whole page is white except for the header and I cannot do anything.
Uncaught TypeError: Cannot read property 'indexOf' of undefined
    at b.updateButtons (compiler.js:1159)
    at new b (compiler.js:170)
    at b.compilerFactory (hub.js:187)
    at new <anonymous> (hub.js:88)
    at new p.items.Component (goldenlayout.js:3706)
    at p.LayoutManager.createContentItem (goldenlayout.js:828)
    at p.items.Stack._createContentItems (goldenlayout.js:3599)
    at p.items.Stack.p.items.AbstractContentItem (goldenlayout.js:3104)
    at new p.items.Stack (goldenlayout.js:4381)
    at p.LayoutManager.createContentItem (goldenlayout.js:828)
    at p.items.RowOrColumn._createContentItems (goldenlayout.js:3599)
    at p.items.RowOrColumn.p.items.AbstractContentItem (goldenlayout.js:3104)
    at new p.items.RowOrColumn (goldenlayout.js:3848)
    at p.LayoutManager.createContentItem (goldenlayout.js:828)
    at p.items.Root._createContentItems (goldenlayout.js:3599)
    at p.items.Root.p.items.AbstractContentItem (goldenlayout.js:3104)
    at new p.items.Root (goldenlayout.js:3761)
    at p.LayoutManager._create (goldenlayout.js:1383)
    at p.LayoutManager.init (goldenlayout.js:706)
    at new b (hub.js:152)
    at HTMLDocument.<anonymous> (main.js:337)
    at t (jquery.js:3557)
    at e (jquery.js:3625)
    at t (helpers.js:71)

Screenshots
What I see:

Desktop (please complete the following information):

OS: macOS Catalina v10.15.1
Browser: Brave
Version: Version 1.3.115 Chromium: 80.0.3987.87 (Official Build) (64-bit)

Updated brave version and now it works. Closing issue

This was actually an issue on our end, and you happened to update your browser at the same time I was deploying the fix.
For you and anyone else who may be watching, apologies for the recent issues - we were deploying some large code changes and there was a subtle time delay bug which caused everything to look OK after deploying, but blow up after an hour.
We didn't identify the bug and were unable to reproduce it, chocked up the first failure to a random fluke, and re-deployed the broken revision again tonight.
This should be fixed once and for all now.


update lagoon/tests image to inherit lagoon/python:3.7 and run Python3

Currently the lagoon/tests image used to run the ansible used in tests is running alpine3.10/Python2/ansible and built from scratch.  Can we update this image to build from our python:3.7 image and run python3/ansible?
https://github.com/amazeeio/lagoon/blob/master/tests/Dockerfile#L1

This is starting to generate lots of warnings in CI.