jetty's MutableServeletContextHandler metric reports currentTimeMillis instead of actual duration in case of AsyncResponse

We're facing an issue that the timer metrics family io.dropwizard.jetty.MutableServletContextHandler.requests reports currentTimeMillis instead of elapsed duration in case of AsyncResponse processing while using metrics-jetty9-3.1.2. After some code debugging it looks like:
Request#startAsync and HttpChannelState#startAsync are triggered yet before the AsyncListener listener com.codahale.metrics.jetty9.InstrumentedHandler is being registered thus the method onStartAsync where start is initalized is not being triggered. This results in updateResponses is triggered with start == 0 and calculates the elapsedTime == currentTimeMillis.
I do not understand this code enough to find the root cause, but I believe that above explanation will shed more light on the problem for those who are experts here. Thanks!

I have the same issue using Spring Boot 1.3.5.RELEASE with Jetty 9.2.16.v20160414 and Metrics 3.1.2.
A sample application that illustrates the issue can be found here

I guess it should be fixed by #1074


fix inconsistency with AWS being top level and cloudflare being nested

Just fixes how /docs/start/aws/[slug]/ were top level in the sidebar but /docs/start/cloudflare/[slug]/ were nested under a second tier, small thing that was bothering me when looking through, should also make it cleaner as more providers get added.
Old

New

Holding off on this for now since AWS is far and away the default. But I'll do this eventually.


allow setting random seed for sampling hyperparameters

will solve #192

Codecov Report

Merging #193 (ca7dac1) into master (860cb4a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   95.27%   95.28%   +0.01%
==========================================
  Files         124      124
  Lines        4147     4158      +11
==========================================
+ Hits         3951     3962      +11
  Misses        196      196

Flag
Coverage Δ

unittests
95.28% <100.00%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

domainlab/utils/hyperparameter_sampling.py
93.83% <100.00%> (ø)

... and 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


WIP. Resolved a506677439648195. Fix message for best bid post.

Coverage remained the same at 82.922% when pulling 24f8d289992bdd32fcae9822978a200723ac0df3 on fix_message_best_bid_post into 3ce34c9d75d34488b0b4f40f84bf483b1d726328 on sandbox.


Large string arbitrarily truncated in results grid and record view when editing or copying

System information:

Operating System: openSUSE Tumbleweed 20190402
KDE Plasma Version: 5.15.3
KDE Frameworks Version: 5.56.0
Qt Version: 5.12.2
Kernel Version: 5.0.5-1-default
DBeaver version: <IP_ADDRESS>903101945
OpenJDK 11.0.2 2018-10-16
OpenJDK Runtime Environment (build 11.0.2+7-suse-1.2-x8664)
OpenJDK 64-Bit Server VM (build 11.0.2+7-suse-1.2-x8664, mixed mode)

Connection specification:

Database name and version:
MariaDB
innodb_version	5.5.59-MariaDB-38.11
protocol_version	10
version	5.5.60-MariaDB
Do you use tunnels or proxies (SSH, SOCKS, etc)?: Yes, SSH

Describe the problem you're observing:
When I go to edit or copy a large string from the results grid is arbitrarily truncated. Yet the gird displays the complete of the value. See the following screenshots:
Viewing long string:

Editing long string:

Thanks for the bug report.
By some reason there was a limit for text length in "inline" editor (65535 chars). I can't remember why it was here and it works quite well without this limit. Maybe on some OSes it may cause problems (e.g. older 32bit  Windows which we no longer support anyway).
Anyhow, let's give it a try.

verified

MacOS, DBeaver Version is <IP_ADDRESS>306251800 and the problem is still here 🥲

where do you find this setting?


Update remarks for AppWindowTitleBar supported version

Since the release of Windows App SDK 1.2, title bar customization using AppWindowTitleBar is supported downlevel on Windows 10. The release note page for WinAppSDK has a summary for this under "Windowing" section.
This PR is to update the MSDN doc to capture the latest changes.

#sign-off


can not create react app

call "c:\program file\nodejs\node.exe" "c:\program file\nodejs\node_modules\npm\bin\npm-cli.js" prifix '-g' is not recongnized as an external or internal command
operable program or batch file.

npx: command not found : create-react-app

@km301088 I think you need to install  " create-react-app " globally in your system and then try to do what you were doing
I hope this helps

I install the create-react-app global version  and I update  my npm  but
still showing an error
On Fri, Apr 9, 2021 at 2:11 PM JASKEERAT SINGH @.***>
wrote:

@km301088 https://github.com/km301088 I think you need to install "
create-react-app " globally in your system and then try to do what you were
doing
I hope this helps
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/create-react-app/issues/10795#issuecomment-816523871,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQIE2H7P4KFMEXFSRU2TNR3TH24SZANCNFSM42SJ4MWQ
.

call "c:\program file\nodejs\node.exe" "c:\program file\nodejs\node_modules\npm\bin\npm-cli.js" prifix '-g' is not recongnized as an external or internal command
operable program or batch file.

npx: command not found : create-react-app

@km301088 It looks like you might have some screwed up PATH variables:

https://stackoverflow.com/questions/38277910/error-while-running-npm-prefix-g-is-not-recognized-as-an-internal-or-external
https://github.com/npm/npm/issues/15891

You could try googling a bit more and checking your PATH to see if something there is declared in a wrong way. Also, if you installed create-react-app globally using -g flag, uninstall that global installation and only use npx create-react-app my-app as suggested by create-react-app documentation. Never install create-react-app globally since that might cause more issues and when using it in the future you might use an outdated version because almost no one updates their globally installed npm packages 😄

I think you need to install " create-react-app " globally

@Jassi10000 This can usually lead to more issues and using out of date packages since basically nobody updates globally installed npm packages on their computer. Instructions outlined in create-react-app documentation should be followed and these suggest not using globally installed create-react-app (https://github.com/facebook/create-react-app#quick-overview)

Please try to read error messages you get in the future since this might lead you to your solution quicker than immediately opening a GitHub issue and putting too much burden on maintainers of packages like CRA for issues that might not be related to the package itself.

@marko-hologram Thanks for telling us the correct approach


Add manual trigger for CompatHelper

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   72.03%   72.03%
=======================================
  Files           5        5
  Lines         211      211
=======================================
  Hits          152      152
  Misses         59       59

Flag
Coverage Δ

#unittests
72.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3643b15...5eb7994. Read the comment docs.


Generated file messages_all.dart produce an ERROR: 'lib' isn't a function.

File generated by command intl_translation:generate_from_arb fails to compile with an error 'lib' isn't a function. messages_all.dart:29
Command:
pub run intl_translation:generate_from_arb --output-dir=lib/i18n --no-use-deferred-loading lib/strings.dart lib/i18n/*.arb

messages_all.dart:
// DO NOT EDIT. This is code generated via package:intl/generate_localized.dart
// This is a library that looks up messages for specific locales by
// delegating to the appropriate library.

import 'dart:async';

import 'package:intl/intl.dart';
import 'package:intl/message_lookup_by_library.dart';
import 'package:intl/src/intl_helpers.dart';

import 'messages_en.dart' as messages_en;

Map<String, Function> _deferredLibraries = {
  'en': () => new Future.value(null),
};

MessageLookupByLibrary _findExact(localeName) {
  switch (localeName) {
    case 'en':
      return messages_en.messages;
    default:
      return null;
  }
}

/// User programs should call this before using [localeName] for messages.
Future initializeMessages(String localeName) {
  var lib = _deferredLibraries[Intl.canonicalizedLocale(localeName)];
  var load = lib == null ? new Future.value(false) : lib(); // <-- HERE
  return load.then((_) {
    initializeInternalMessageLookup(() => new CompositeMessageLookup());
    messageLookup.addLocale(localeName, _findGeneratedMessagesFor);
  });
}

bool _messagesExistFor(String locale) {
  var messages;
  try {
    messages = _findExact(locale);
  } catch (e) {}
  return messages != null;
}

MessageLookupByLibrary _findGeneratedMessagesFor(locale) {
  var actualLocale = Intl.verifiedLocale(locale, _messagesExistFor,
      onFailure: (_) => null);
  if (actualLocale == null) return null;
  return _findExact(actualLocale);
}

Yes, the problem is that even though you said --no-use-deferred-loading it's generating an initialize that's trying to do a deferred load. Simple workaround is use deferred loading temporarily. Slightly more complicated, I think if you hand-edit the generated code and have it only do the then() part, that should work.

The same result for command:
pub run intl_translation:generate_from_arb --output-dir=lib/i18n lib/strings.dart lib/i18n/*.arb

messages_all.dart:
// DO NOT EDIT. This is code generated via package:intl/generate_localized.dart
// This is a library that looks up messages for specific locales by
// delegating to the appropriate library.

import 'dart:async';

import 'package:intl/intl.dart';
import 'package:intl/message_lookup_by_library.dart';
import 'package:intl/src/intl_helpers.dart';

import 'messages_en.dart' deferred as messages_en;

Map<String, Function> _deferredLibraries = {
  'en': () => messages_en.loadLibrary(),
};

MessageLookupByLibrary _findExact(localeName) {
  switch (localeName) {
    case 'en':
      return messages_en.messages;
    default:
      return null;
  }
}

/// User programs should call this before using [localeName] for messages.
Future initializeMessages(String localeName) {
  var lib = _deferredLibraries[Intl.canonicalizedLocale(localeName)];
  var load = lib == null ? new Future.value(false) : lib();
  return load.then((_) {
    initializeInternalMessageLookup(() => new CompositeMessageLookup());
    messageLookup.addLocale(localeName, _findGeneratedMessagesFor);
  });
}

bool _messagesExistFor(String locale) {
  var messages;
  try {
    messages = _findExact(locale);
  } catch (e) {}
  return messages != null;
}

MessageLookupByLibrary _findGeneratedMessagesFor(locale) {
  var actualLocale = Intl.verifiedLocale(locale, _messagesExistFor,
      onFailure: (_) => null);
  if (actualLocale == null) return null;
  return _findExact(actualLocale);
}

I have changed implementation of initializeMessages and it works. But it seams more like a workaround:)
/// User programs should call this before using [localeName] for messages.
void initializeMessages(String localeName) {
  initializeInternalMessageLookup(() => new CompositeMessageLookup());
  messageLookup.addLocale(localeName, _findGeneratedMessagesFor);
}

Yes, it's certainly a workaround.
When you say you're compiling this, what are you using to compile it? The error message that something isn't a function doesn't seem like one that comes from the VM. I'd expect the error message that something doesn't have the method 'call'. But also, it seems like there's no way that lib is not in fact a function. So this may actually be a bug or limitation of the thing you're using to compile. Possibly something doesn't think that Function is a function and wants something more specific.

IntelliJ IDEA 2016.3.4
Build #IU-163.12024.16, built on January 31, 2017
JRE: 1.8.0_112-release-408-b6 x86_64
Dart Plugin Version: 163.13137
Flutter Plugin Version: 12.0
The error occurs in IntelliJ in Dart Analysis tab.

You could try upgrading your Dart plugin. I have 163.15188.8
I pasted your code directly in and it doesn't complain for me in WebStorm 2016.3.5 with that plugin and Flutter 12.1 (although I wouldn't expect Flutter to make a difference).

I have the same problem even with Dart plugin 171.4424.63 and Flutter 13.1
The error message comes from dartanalyzer tool (https://github.com/dart-lang/sdk/tree/master/pkg/analyzer_cli) with strong static and strict call checking enabled:
C:\Users\Jerry\IdeaProjects\flutter_news>dartanalyzer -v --strong --enable-strict-call-checks ./lib/i18n/fnews_messages_all.dart
Analyzing lib\i18n\fnews_messages_all.dart...
Using default analysis options
    error - 'lib' isn't a function at lib\i18n\fnews_messages_all.dart:29:54 - invocation_of_non_function
            Try correcting the name to match an existing function, or define a method or function named 'lib'.
1 error found.

dartanalyzer help regarding strict call checking points to this issue: https://github.com/dart-lang/sdk/issues/21938
It is possible to force dartanalyzer to ignore this "error" by adding:
  // ignore: invocation_of_non_function
  var load = lib == null ? new Future.value(false) : lib();

Maybe it would be possible to add this to autogenerated messages_all as a better workaround?

Ah, it's the enable-strict-call-checks which does it, causing the analyzer to emit a false positive.
Adding a null check wouldn't help. The problem is that with strict call checking it doesn't think something of type Function can be called. An appropriate fix would be a more specific type on the map. But not using enable-strict-call-checks would also work.

From the other bug, it seems like the behavior of that option is likely to change anyway.

Seems that both options need to be present otherwise dartanalyzer does not emit this error. This setting is hardwired somewhere in IDEA Dart plugin with no obvious way to change it.
I mean null check is alrady present in generated code, I was thinking about only adding the comment line which supresses static call check for the lib() call.

Seems that code analysis can be configured using config file: https://www.dartlang.org/guides/language/analysis-options
I guess we can just exclude generated files from analysis then.

It's not obvious where that option would be set. @devoncarew , do you know? It doesn't seem to appear in any relevant source code.
Excluding generated files from analysis seems reasonable.

Yes, you can use excludes: to ignore certain files, and you can ignore specific warnings entirely. Without looking into the specific cause of the error above though, you may be better off just changing the code so you don't encounter the error. /cc @bwilkerson

Seems that excluding is currently broken in dartanalyzer: https://github.com/dart-lang/sdk/issues/26212 and also it is acting up in IDEA: https://github.com/dart-lang/sdk/issues/28754
I am quite new to Dart so I might be missing something but how about replacing lib() with Function.apply(lib, null)? Analyzer seems to be happy with this construct.

Yes, there does appear to be a problem with exclude. I saw it the other day but it went away when I restarted the server, so there might be a work-around.

Yep, restart helps, but as soon as I open any analysis_options "excluded" file in editor, analyzer server analyzes it anyway.
I believe I finally found working exclude by setting up lib/i18n folder as excluded in Project Module settings:

Also did a few tests with Function.apply(lib,null) in both deffered and non-deferred modes and it seems to be working fine.

Published a 0.15.0 that should fix this, among other things.


Add typescript-formatter verification to build

suggested by @myitcv
sample usage: https://github.com/myitcv/typescript_test/blob/master/scripts/build.sh#L7

Credit to @vvakame here for developing tsfmt in the first place :+1:

Although tsfmt is awesome, it looks like we've moved to Prettier. Closing as aged away.


[Refactor] toggle should be changed to a more specific name, e.g. toggle_playback

For more details, see comments here: https://github.com/MiczFlor/RPi-Jukebox-RFID/pull/2179#discussion_r1440287453

Already implemented in #2179?

Nope, this was a reminder, as it is a incompatible change


As a user collaborating with other Tether users I want to share an applicant's details

...so that I can update other hiring managers on applicant details

Will do in some future iteration


msrestazure package is deprecated - need to update code samples

Sample code on the page references deprecated msrestazure azure package:
from msrestazure.azure_cloud import AZURE_CHINA_CLOUD as CLOUD

Is there a different way to get azure cloud endpoints, without referencing msrestazure?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c3651a7d-904a-7eaa-2949-43e57fe1a0ce
Version Independent ID: c3651a7d-904a-7eaa-2949-43e57fe1a0ce
Content: Connect to all regions using Azure libraries for Python multicloud - Python on Azure
Content Source: articles/python/sdk/azure-sdk-sovereign-domain.md
Service: azure-python
GitHub Login: @bobtabor-msft
Microsoft Alias: rotabor

Hi @karpikpl -- good point. I'll reach out to our product team. It looks like this still might be an open issue in the code repo: https://github.com/Azure/azure-sdk-for-python/issues/29023. You might want to follow progress in that issue.

Hi @karpikpl -- just an update. I've been working offline with one of our developers to update this topic. We're just finalizing edits. It should go live sometime this weekend or by Monday AM at the latest.
-Jimaco

Hi @karpikpl -- The updated code snippets and some accompanying text changes are now live. Please have a look. I'll leave this issue open for a day or so in case you have additional feedback.
Thanks,
Jimaco

awesome, thank you!
we'll use azure.identity.AzureAuthorityHosts. Hopefully this also helps others doing work in different clouds

Hey @JimacoMS4
one question about the solution
import os
from azure.mgmt.resource import ResourceManagementClient, SubscriptionClient
from azure.identity import DefaultAzureCredential, AzureAuthorityHosts

authority = AzureAuthorityHosts.AZURE_CHINA
resource_manager = "https://management.chinacloudapi.cn" # <----- This value is hardcoded?

Only authority is available from the identity package, but what about other cloud specific endpoints?

sql management
resource management
gallery
AD
graph
etc. ?


Fix orphaned feed slices, handle blocks

Relies on https://github.com/bluesky-social/atproto/pull/2721
Fixes a regression in #4871 where A -> B -> C and A blocks B, we'd see the entire A -> B -> C thread, whereas the intention was to filter out those "orphaned" threads. If we want to show orphaned threads, it's a one-line change in feed-tuners.
Testing
Test the scenarios below using the backend PR. Otherwise test prod, nothing should look different using prod data. Only the backend PR sends down data needed to compute the correct view.
Blocks
A blocks B, or B blocks A. Viewing as C.
See in prod, thread is orphaned (and technically "Reply to test.esb.lol" should say "Reply to blocked post")

In main, you can see through the 3p blocks:

In this PR, C only sees A because the thread view would otherwise be "orphaned"

C blocks A. Viewing as C
In all cases the entire feed slice is filtered out 👍
C blocks B. Viewing as C.
In all cases, only A is visible 👍
Not found posts
In case of B deleting their post, again only A is visible in feeds, and when viewing C author feed, this PR now notes that the post was removed with the following:

I chose "unknown post" instead of "deleted post" because there are multiple reasons a post might be "not found".

Actually should have no effect on main for now, so should be clear to merge this ahead of app view changes


basic API for a check

I stubbed out what I thought the API around a check should be.   This is needed so I can proceed with the scheduler.

doesn't care about serialization yet.
all checks have a run() method that accepts a callback with a CheckResult parameter.

+1

Eventually we will also need define better interface for CheckResult a.k.a. which attributes will it expose, otherwise LGTM.


The system requirements are not satisfied.

Version: 7.7.0
Output folder: C:\Program Files\Intel\HAXM
Extract: checktool.exe... 100%
Execute: C:\Program Files\Intel\HAXM\checktool.exe --verbose
The system requirements are not satisfied.

Thanks for your report. Could you find the installation log in %TEMP% folder and check your system configuration according to the wiki page?

Essentials
Product Collection
9th Generation Intel® Core™ i7 Processors
Code Name
Products formerly Coffee Lake
Vertical Segment
Mobile
Processor Number
i7-9750H
Status
Launched
Launch Date
Q2'19
Lithography
14 nm
Recommended Customer Price
$395.00
CPU Specifications
of Cores
6
of Threads
12
Processor Base Frequency
2.60 GHz
Max Turbo Frequency
4.50 GHz
Cache
12 MB Intel® Smart Cache
Bus Speed
8 GT/s
TDP
45 W
Configurable TDP-down
35 W
Supplemental Information
Embedded Options Available
No
Datasheet
View now
Memory Specifications
Max Memory Size (dependent on memory type)
128 GB
Memory Types
DDR4-2666, LPDDR3-2133
Max # of Memory Channels
2
Max Memory Bandwidth
41.8 GB/s
ECC Memory Supported ‡
No
Processor Graphics
Processor Graphics ‡
Intel® UHD Graphics 630
Graphics Base Frequency
350 MHz
Graphics Max Dynamic Frequency
1.15 GHz
Graphics Video Max Memory
64 GB
Graphics Output
eDP/DP/HDMI/DVI
4K Support
Yes, at 60Hz
Max Resolution (HDMI)‡
4096 x 2304@30Hz
Max Resolution (DP)‡
4096 x 2304@60Hz
Max Resolution (eDP - Integrated Flat Panel)‡
4096 x 2304@60Hz
Max Resolution (VGA)‡
N/A
DirectX* Support
12
OpenGL* Support
4.5
Intel® Quick Sync Video
Yes
Intel® InTru™ 3D Technology
Yes
Intel® Clear Video HD Technology
Yes
Intel® Clear Video Technology
Yes
of Displays Supported ‡
3
Device ID
0x3E9B
Expansion Options
PCI Express Revision
3.0
PCI Express Configurations ‡
Up to 1x16, 2x8, 1x8+2x4
Max # of PCI Express Lanes
16
Package Specifications
Sockets Supported
FCBGA1440
Max CPU Configuration
1
TJUNCTION
100°C
Package Size
42mm x 28mm
Advanced Technologies
Intel® Optane™ Memory Supported ‡
Yes
Intel® Speed Shift Technology
Yes
Intel® Thermal Velocity Boost
No
Intel® Turbo Boost Technology ‡
2.0
Intel vPro® Platform Eligibility ‡
No
Intel® Hyper-Threading Technology ‡
Yes
Intel® Virtualization Technology (VT-x) ‡
Yes
Intel® Virtualization Technology for Directed I/O (VT-d) ‡
Yes
Intel® VT-x with Extended Page Tables (EPT) ‡
Yes
Intel® Transactional Synchronization Extensions
No
Intel® 64 ‡
Yes
Instruction Set
64-bit
Instruction Set Extensions
Intel® SSE4.1, Intel® SSE4.2, Intel® AVX2
Intel® My WiFi Technology
Yes
Idle States
Yes
Enhanced Intel SpeedStep® Technology
Yes
Thermal Monitoring Technologies
Yes
Intel® Flex Memory Access
Yes
Intel® Identity Protection Technology ‡
Yes
Intel® Stable Image Platform Program (SIPP)
No
Security & Reliability
Intel® AES New Instructions
Yes
Secure Key
Yes
Intel® Software Guard Extensions (Intel® SGX)
Yes with Intel® ME
Intel® Memory Protection Extensions (Intel® MPX)
Yes
Intel® OS Guard
Yes
Intel® Trusted Execution Technology ‡
No
Execute Disable Bit ‡
Yes

It is seen supported by all

Could you run below command in Command Prompt and check if the error level is 0?

"C:\Program Files\Intel\HAXM\checktool.exe" --verbose
echo %ERRORLEVEL%

Then try to execute below command in an elevated Command Prompt to disable Hyper-V and reboot your Windows.

bcdedit /set hypervisorlaunchtype off

You are right. All configurations are met to install HAXM. Could you run below command under the folder of the extracted release package in the elevated Command Prompt?

silent_install.bat

Thanks for your reply. Sorry for bringing you inconvenience. We will investigate this weird issue soon.

So I can't install haxm normally?

Have you ever enabled WSL2? Could you run below command in an elevated PowerShell and reboot again?
> Disable-WindowsOptionalFeature -Online -FeatureName Microsoft-Windows-Subsystem-Linux

I am also unable to install haxm on windows; getting the same error that "Hyper-V is not disabled" but there is no way to enable/disable through settings. I do have WSL turned on and I cannot turn it off.

Is your virtualization enabled?  Run the command systeminfo  in the prompt and check Hyper-V Requirements.
I was having the same issue, after i enabled virtualization the installation worked. Have a look here:
https://mashtips.com/enable-virtualization-windows-10/
You can enable it in the BIOS setup.

@macena1989 ,please try 'bcdedit /set hypervisorlaunchtype off' in prompt window with admin and reboot you PC, then try again.

Hyper-V is not an option for Windows 10 Home

@srepollock ,please try 'bcdedit /set hypervisorlaunchtype off' in prompt window with admin and reboot you PC, then try again.

This does not work

I also had the same problem


codec2: 1.0.1 -> 1.0.3

Motivation for this change
New upstream release.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See [Nix manual](https://nixos.org/manual/nix/stable/commnix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"and-ref/conf-file.html))
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Build failure in uhd-<IP_ADDRESS> appears to be unrelated to codec2 update at first glance: 86hk6xv04fzhl0n310n65ykp792khl9p-uhd-<IP_ADDRESS>.log

Build failure in sdrangel-6.17.2 appears to be unrelated to codec2 update:
c8jcccw5v694wskgk631h7n0i5rb6pcr-sdrangel-6.17.2.log
Might be due to a change in the Boost interface.

@GrahamcOfBorg eval


S4ND layer and code

Thank you for the wonderful and insightful repo, are there any plans on releasing the code for S4ND layer?
Roy

Yes, I'm working on a V4 release. I'm not sure when the full release will be done, but I'll start pushing pieces to a branch soon so the S4ND code should be available relatively soon.


Merge in latest changes and update to v2.5.0

Want to pick up fix for https://github.com/sj26/sidekiq-cloudwatchmetrics/issues/16
No breaking changes:
Change log for 2.5.0
Change log for 2.4.0
I'll rebase the branch allow-disabling-of-process-dimensions after this is merged

Closing in favor of using the 2.5.0 version of the regular package


Don't merge! Regression PR perf testing without metadata validation

Docs Build status updates of commit 8faee38:
:clock10: Pending: waiting for processors (5 builds ahead of you)
:warning: Docs Build is busy, currently there are 5 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 8faee38:
:clock10: Full build: the average full build time is 18 min(s) 56 sec(s), this is based on the last 213 build(s) for this repository.

Docs Build status updates of commit 8faee38:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

TestingPullRequest.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Anchor links for FAQ Questions

Hey Primer Brand friends,
We've received a request about how convenient it would be to add anchor links to specific questions inside the FAQ component so they can be easily shared with customers. I see the FAQ has some support for passing around id attributes, but from reading the docs, I don't think it offers any control to detect when a FAQ question is selected to change the URL accordingly. I guess supporting this kind of behavior will need a hybrid approach where certain logic needs to happen on the application side, but some could also be added to the component itself. For example, Primer Brand could facilitate expanding the right question when there are FAQ groups involved.
How do you feel about this functionality? Do you happen to have any directions to make it work today?

👋 @sergioalvz  - thanks for the request. We explored deeplinks a little while back, which sounds similar to what you're asking about. The feature lost traction due to lowered prioritisation, but you can see the progress we made here. If this is what you're looking for, feel free to create a modification request  with the relevant info and we can look to revive that work.


feat: Small optimisations

Replaces a boolean gate which occupies one gate with a range constraint (the cost becomes half a gate). Had to create functionality that checks if variables actually get placed into the circuit for implement this.
Removes an inefficiency in bigfield where mult_madd for remainder = 0 provided that remainder
assert_equal in bigfield in ultra uses more efficient gates for the witness==constant case in an edgecase

Archiving, because without filtering it would introduce a new pitfall that would be hard to debug when encountered


make it clear that each element must be a non empty string

The message indicates that it will accept any string but after inspecting the code and the clients subscriptions it does not support a subscription with an ampty string.
Code: https://github.com/sensu/sensu-settings/blob/v10.14.0/lib/sensu/settings/rules.rb#L113-L123
Example Error:
Mixlib::ShellOut::ShellCommandFailed
    ------------------------------------
    Expected process to exit with [0], but received '2'
    ---- Begin output of /etc/init.d/sensu-client restart ----
    STDOUT: configuration is invalid
    {
      "errors":[
        {
          "object":{
            "name":"dokken",
            "address":"<IP_ADDRESS>",
            "subscriptions":[
              "",
              "base",
              "kitchen",
              "rails_app_testing",
              "rails_app_testing_kitchen",
              "roundrobin:rails_app_testing_kitchen",
              "client:dokken"
            ],
            "keepalive":{
              "thresholds":{
                "warning":200,
                "critical":240
              },
              "handlers":[
                "default"
              ],
              "refresh":1800
            },
            "redact":[
              "password",
              "passwd",
              "pass",
              "api_key",
              "api_token",
              "access_key",
              "secret_key",
              "private_key",
              "secret"
            ],
            "environment":"kitchen"
          },
          "message":"client subscriptions must each be a string"
        }
      ]
    }
    STDERR:
    ---- End output of /etc/init.d/sensu-client restart ----
    Ran /etc/init.d/sensu-client restart returned 2

Signed-off-by: Ben Abrams<EMAIL_ADDRESS>

Thanks @majormoses


android 8.0 can not open hotspot

use following to open hotspot on 8.0,
 Intent intent = new Intent(Intent.ACTION_MAIN, null);                 intent.addCategory(Intent.CATEGORY_LAUNCHER);                 ComponentName cn = new ComponentName("com.android.settings", "com.android.settings.TetherSettings");                 intent.setComponent(cn);                 intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);                 startActivity( intent);

The internal API that is used through reflection was deprecated and the new API seems to be rather difficult to access without root. There are some hints that it may be possible for Android 8.1:
https://groups.google.com/d/msg/automate-user/xy307m-hwvQ/NZERFRJSBgAJ
This seems to be a good starting point code wise:
https://github.com/matejdro/TaskerTetherControl/blob/master/app/src/main/java/com/matejdro/taskertethercontrol/TetherSetupActivity.java
https://github.com/matejdro/TaskerTetherControl/blob/master/app/src/main/java/com/matejdro/taskertethercontrol/TaskerReceiver.java


Update CONTRIBUTING.md

A small update to the contributing guide to be more inline with the wiki

+1. Thanks!

+1


[TF 2.0 API Docs] Docstring for tf.train.experimental.enable_mixed_precision_graph_rewrite

In response to #29241
Improved the docstring for tf.train.experimental.enable_mixed_precision_graph_rewrite:

Added example for using function
Added colab notebook to demonstrate speed-up without performance penalty
Added original graphic for loss scaling (source)
Added more information about graph rewrite operation
Added performance guide
Added exception information
Added more clarification to loss_scale argument

A gist with the rendered docstring is here for ease of review.
Thank you, any feedback or criticism is welcome.

Can you change the colours in the image as well? On my monitor the green and blue look fairly similar its hard to distinguish.

I have made all the requested changes!

@rthadur Can you make sure the links are updated when this is merged?

Fixed the pylint 80 char line limit errors.

Pushed the amended commit with the requested changes.

@tlkh, when enabling "enable_mixed_precision_graph_rewrite", how about the data type of model network when defining the model?
still use FP32? if it is, how to output the FP16 trained model? Thanks!

@tlkh, when enabling "enable_mixed_precision_graph_rewrite", how about the data type of model network when defining the model?
still use FP32? if it is, how to output the FP16 trained model? Thanks!

You define your model as per normal in FP32. Before training (computing of gradients), your graph will be "rewritten" to have some nodes in FP16, others in FP32. This is only used for training, and if you save or export your model, it will be in FP32 as per normal.
This means that training is faster, but otherwise no behavior differs. You will not be able to export the actual "mixed precision model", but you don't have to since it doesn't run faster on CPU, and you can also run the graph rewrite before the next training session.

Thank you very much @tlkh. However, FP16 model can run faster compared to the FP32 one on GPU. you mentioned "you can also run the graph rewrite before the next training session." With this method, FP16 model can be saved? How to do this?
Is there no way to save the FP16 model with auto-mixed precision training? thanks a lot.

Thank you very much tlkh. However, FP16 model can run faster compared to the FP32 one on GPU. you mentioned "you can also run the graph rewrite before the next training session." With this method, FP16 model can be saved? How to do this?
Is there no way to save the FP16 model with auto-mixed precision training? thanks a lot.

There is no way to save the FP16 model, but there is no need to!
Export the model as per normal. The next time you want to use it, just run the graph rewrite again. If loading it for inference, you can manually set it in the TensorFlow session:
# TF1.x
config = tf.ConfigProto()
config.graph_options.rewrite_options.auto_mixed_precision = True
sess = tf.Session(config=config)

# TF2.x
tf.config.optimizer.set_experimental_options({
    "auto_mixed_precision": True
})

@perfinion @martinwicke can you please review new changes.

Thanks a lot, @tlkh. However, if FP16 trained network cannot be saved, it is difficult to use the network outside tensorflow after finishing the training.

In addition, it seems that ops conversion from FP32 to FP16 can happen on new GPU, like Volta. TF cannot do this conversion for old one.

Thanks a lot, tlkh. However, if FP16 trained network cannot be saved, it is difficult to use the network outside tensorflow after finishing the training.
In addition, it seems that ops conversion from FP32 to FP16 can happen on new GPU, like Volta. TF cannot do this conversion for old one.

If you wish to use the network outside of TensorFlow for inference in FP16, typically just converting all the datatypes to FP16 will work. Only for training does there have to be special considerations. There are other toolkits to help with inference optimization outside of TensorFlow, such as TensorRT.
Only Volta and Turing GPUs have the FP16 units and Tensor Cores that can benefit from mixed precision. Older GPUs will not see a benefit, hence the feature is not enabled for them.
@recrusader let's move this discussion to a new GitHub issue if you wish to raise any concerns or suggestions. Keep this thread for discussion specifically about this PR.

I asked this question in official model. However, no one can give me an answer. Thank you very much! I think that I have got the answer.

@perfinion @martinwicke requesting review once again.
Changes made:

image and example notebook is now hosted by NVIDIA
docstring wording has been improved, and updated/merged with recent changes from master

Thank you!

@martinwicke thanks for pointing that out. Let me fix that anyway.

Sorry about that! I fixed it.

Hi @tlkh,
It looks like you miss understood @martinwicke's comment.
All the Args/Returns/Raises blocks need to be indented, or they will not be recognized by our linters, and will render incorrectly on tensorflow.org (They will be interpreted as markdown which will just flatten them into a single paragraph).
Thanks.

Hmm I've addressed the changes but I'm not sure why GitHub is still complaining about "1 change requested".


403 Forbidden. CSRF token missing or incorrect.

When I try to convert HTML to PDF I have this error: "CSRF token missing or incorrect."

Reason given for failure:
CSRF token missing or incorrect.

In general, this can occur when there is a genuine Cross Site Request Forgery, or when Django's CSRF mechanism has not been used correctly. For POST forms, you need to ensure:
Your browser is accepting cookies.
The view function passes a request to the template's render method.
In the template, there is a {% csrf_token %} template tag inside each POST form that targets an internal URL.
If you are not using CsrfViewMiddleware, then you must use csrf_protect on any views that use the csrf_token template tag, as well as those that accept the POST data.
The form has a valid CSRF token. After logging in in another browser tab or hitting the back button after a login, you may need to reload the page with the form, because the token is rotated after a login.

You're seeing the help section of this page because you have DEBUG = True in your Django settings file. Change that to False, and only the initial error message will be displayed.
You can customize this page using the CSRF_FAILURE_VIEW setting.

This is a Django error, not xhtm2pdf error, please set {% csrf_token %} in your form.
If the problem it's in demo site, please let me know, but if it's in other code out of xhtml2pdf is not a relevant issue for this repo.


Improve user documentation of the spec

After some preliminary discussions (with @k-dominik @Tomaz-Vieira @esgomezm @akreshuk @cfusterbarcelo and others),
it is clear that should improve the user documentation of the spec.
Concretely https://github.com/bioimage-io/spec-bioimage-io/blob/main/scripts/generate_spec_documentation.py needs an update
and we should try to export an intermediate json file with the content of the spec documentation.

Hi! I checked but I'm struggling to understand this file, sorry. In particular, what's the input to the file? If it's the code (bioimageio library itself), where can we start editting it?

the current md user docs are generated by https://github.com/bioimage-io/spec-bioimage-io/blob/main/scripts/generate_spec_documentation.py

relates to https://github.com/bioimage-io/bioimage.io/issues/439


X axis direction bug

great work
though there is a bug if the device language is configured to an RTL language and not LTR language:
in that case, when you drag the joystick on the X axis, the circle is being dragged to the opposite side. so if you drag left, the circle moves right for example.

@SodaSurfer Thanks for reporting, I will work at fixing it


Color based on entity state

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Support for coloring entiies based on their state. This could be set on entity object level.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I was thinking of creating a dependency graph (if possible, otherwise a tree) between the different entities.
E.g. heating in a room depends on the Zigbee temperature sensor that depends on the Zigbee-wifi bridge that depends on MQTT. Other sensors also depend on the zigbe-mqtt, etc.:
mqtt - device_tracker.zigbee_bridge - sensor.zb_temp ----- climate.heat
                                 \ \ sensor.zb_door_window /
                                  \ sensor.zb_water_leak

So if a device/entity in this dependency graph fails this card could be used to make it visible what other entities are affected. Most visibly the color based on state could do that.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
none yet, I just found this card today.
Additional context
Add any other context or screenshots about the feature request here.

I am not sure I completely understand your use case but dynamic color is a great idea in any case.

Thanks for your quick reply and your work on the card.
For now I'm just experimenting with your card.
For some reason some of the sensors are not displaying and other entity tpes (device_trackers, covers, switches, binary_sensors, input_booleans) don't display either: neither as branches nor as leaves. Is there any limitation to specific sensors only?
Once I figure it out and display them I'll show you the dependency graph/tree that I was thinking about (of course without the colors based on states).

Only numeric state is supported and even then only positive values are displayed.

Thanks for the clarification, you spared me a lot of time trying to figure out why specific entities do not show up.
Based on your comment, the dynamic color support could be based on 0 and non-0 values (that simplifies things).
It would be good to mention the conditions somewhere in the README.

Promised you a use case:


implement segmentation method for green view score

Created a new module to calculate GVI based on the method from the StreetView-NatureVisibility project
README provides steps to install and run locally.

can you please resubmit this against this PR against main? i find it confusing to have some already merged commits showing as changes alongside the changes you've made. the branch you've submitted against is 4 commits behind main.
the readme instructions should build on our existing readme. for example, we already have a "Setup" section.
what's the purpose of including a streamlit app?
this process should be a simple swap for our treepedia based option in 3. Assign a Green View score to each image/feature - when @dragonejt in #42 is tackling having 2 options for step 2, he has gone the route of including an argument for the method. that is, when running python -m src.download_images the user can include a MAPILLARY or LOCAL argument. similarly, for step 3 calculating green view, we may want to let users include an argument defining their preferred analysis method, something like TREEPEDIA or MASK2FORMER

Changed to main branch
Streamlit app provides a way to visualize how the segmentation works. It is open source and runs locally.
This part sounds like a new feature, since we would be editing the main script and pipeline.  Let's have this PR be for integrating the standalone module.
We can then can create a new issue to migrate the module into the existing pipeline with the desired functionally (and the README update) (This also provides a good first issue for folks wanting to contribute!)

Agree with Jay, here's how I did something similar for image sources in #42 :

Add a submodule for this step of the project (src.gvi)
Add an interface (AbstractBaseClass) that both the classical GVI method and new segmentation GVI method will inherit from. Something like src/gvi/gvi_scorer.py, and there should at the very least be a common constructor and a get_gvi_for_image(image_path: Path) abstract method
Add an Enum to select which GVI Scorer to use, and add it as a CLI argument

this PR addresses #10

it would also be good to save the green score from this segmentation method to a column with a specific header so that the user could run both the "pixel-counting" method and this method on the same files, end up with both result columns, and then compare.

this is superseded by #55


A fix for running the AnimalsLoader from the command line by itself when the animal's age is empty

Summary Change Description

See affected issue(s).
Affected Issues/Pull Requests

Resolves #1299
Merges into PR #1302

Review Notes

See comments in-line.
Checklist

This pull request will be merged once the following requirements are met.  The
author and/or reviewers should uncheck any unmet requirements:

Review requirements

Minimum approvals: 1
No changes requested
All blocking issues resolved by reviewers
Specific reviewers: @add_username_here

Review period: 2 days

Associated issue/pull request requirements:

[x] All requirements in affected issues marked "resolved" are satisfied
[x] All required pull requests are merged (or none)

Basic requirements

[x] All linters pass
[x] All tests pass
[x] All conflicts resolved

Overhead requirements

[x] New/changed method tests implemented/updated (or no change)
[ ] Updated Unreleased section of changelog.md (or no change)
[x] Migrations created & committed (or no change)

I'd like to get eyes on this PR to see if anyone has any suggestions with the code, so I'm tagging @narzouni.

Hello @hepcat72 , I just started looking at this PR. I am trying to reproduce the same error the pandas value error that you mentioned in the issue. Which file in cold_exposure folder I should use when I try using load_animals? I looked at .xlsx files, but I was not sure which one. Should we use the file TraceBase Animal and Sample Table Templates_coldExposure.xlsx????

Hello @hepcat72 , I just started looking at this PR. I am trying to reproduce the same error the pandas value error that you mentioned in the issue. Which file in cold_exposure folder I should use when I try using load_animals? I looked at .xlsx files, but I was not sure which one. Should we use the file TraceBase Animal and Sample Table Templates_coldExposure.xlsx????

Yes, but you should either use the one from the rabinowitz repo branch v3_cold_exposure or update your version of main from that repo (because that branch was merged the other day).

Hello @hepcat72 , I just started looking at this PR. I am trying to reproduce the same error the pandas value error that you mentioned in the issue. Which file in cold_exposure folder I should use when I try using load_animals? I looked at .xlsx files, but I was not sure which one. Should we use the file TraceBase Animal and Sample Table Templates_coldExposure.xlsx????

Yes, but you should either use the one from the rabinowitz repo branch v3_cold_exposure or update your version of main from that repo (because that branch was merged the other day).

And note that you have to load the dependencies first (if you are working from an empty database), so you have to run load_studies, load_compounds, load_protocols, load_tracers, load_infusates... I think that's all of them.
But if you're working from a DB that already has the cold exposure data loaded, you can just run the animals one.


Video does´nt play in Learning pathways in Teams, but in the web.

PROVISIONING NOTE: If you are having issues with the SharePoint look book while trying to provision M365 learning pathways please do not post that issue to this repo as we cannot help you here. Please post all questions and issues for the SharePoint look book to SharePoint/sp-provisioning-service GitHub Issues List.

WEB PART NOT LOADING: If you are getting the error: "Microsoft 365 learning pathways has a configuration issue. Ask your administrator for assistance". Please review the Diagnosing Pre-Check guidance before submitting your bug.

Describe the bug
The video  is posted as a link from Stream, and I am the owner. Neither I, nor other people in the organisation kan play the video. The link is posted as "View" for everyone within the organisation. There are several similar videos posted by link showing the same issue.
To Reproduce
I was noticed by a user, and have the same issue myself and a colleague. I tried restarting Teams, same issue. Have not yet tried restarting the computer...
Expected behavior
I expected the video to play.
Screenshots

If applicable, add screenshots to help explain your problem.

Learning Pathways version number

Please share the version number of learning pathways in your tenant app catalog.

Additional context

Add any other context about the problem here.

@PiaStider I am not sure based on this description what the issue is. Can you please provide more details on how you are using Learning Pathways, how to replicate the issue, and how this relates to the video you are referencing?

Closed as inactive


Utilize BlockSize property in the block store queue

Minor blockstorequeue optimization which allows us to avoid serialization of every block in order to get block size.

Looks good, NTNS

NTNS?

Not tested, not synced I guess

Are the integration tests passing for you @noescape00 ?

One moment, let me check that. I only synced the chains.

Not tested, not synced I guess

yes

@bokobza fixed the unit tests. Integration tests are failing but not because of this PR.


Add the possibility to delete a dataset

This is most probably a UI only issue. But needs to be checked on backend.

The PR (#136) is dedicated for this feature.
Now an admin can delete a dataset.


Mongo.Collection.embeds_one/3 doesn't save type information

Hi @zookzook, thanks one more time for maintaining this library and merging my contributions!
I'm not sure yet what's the use for the types when defining a module with use Mongo.Collection. Is it just for documentation/humans?
There doesn't seem to be any form of validation, nor does it seem to influence the default encoding/decoding process (and I'm okay with that).

Nonetheless, I noticed that calling SomeCollection.__collection__(:types) includes some info about a document attribute set with embeds_many, but missed a similar attribute set with embeds_one.
https://github.com/zookzook/elixir-mongodb-driver/blob/6071f18eeabffab634db509f85a734ddcf9eb2a6/lib/mongo/collection.ex#L888-L894
https://github.com/zookzook/elixir-mongodb-driver/blob/6071f18eeabffab634db509f85a734ddcf9eb2a6/lib/mongo/collection.ex#L905-L911
In embeds_many the type is derived as type = unquote(Macro.escape({{:., [], [mod, :t]}, [], []})). I'm not sure what would be expected for the embeds_one case, any advice?

The type spec is just for documentation. I need some time to look at it and to remember how it works.


[Bug] Menu widget needs to show transparent background

The menu widget continues to show white colour even when you choose no background colour. I think it'll be better if the colour is transparent, then the button can fit into the background.
@Tooluloope @jsartisan @somangshu

@wmdev0808 here we will also change the background / text colour property inline to the button widget style customisation changes.

Box shadow
Menu styles (Primary, Warning, Danger, Info, Secondary, Custom)
border radius
get all style attributes inside style section

We will cover all this with the above fixes


Documentation

Add documentation for managed identity

Forgot to close this at the time, but docs for Managed Identity were updated after the GA release: https://learn.microsoft.com/en-us/entra/msal/java/advanced/managed-identity


Documentation Changes

Fixed a few missing links and changed some wording.
Also, my editor removed some whitespace.

Current coverage is 70.29% (diff: 100%)

Merging #830 into release-0.15.x will increase coverage by 0.79%

@@           release-0.15.x       #830   diff @@
================================================
  Files                 211        211
  Lines                4626       4626
  Methods              4178       4178
  Messages                0          0
  Branches              448        448
================================================
+ Hits                 3215       3252    +37
+ Misses               1411       1374    -37
  Partials                0          0

Powered by Codecov. Last update 876dd25...b454836

I made a couple changes, but looks good.  Thanks!

ROFL, can't believe I put those middleware links in backwards....  Glad you caught that!


Ensure recurse and purge is maintained in conf.d directory

At present, file resource for conf.d does not have the purge and recurse flags on and so the settings from the parent directory do not seem to be propagated.

Can one of the admins verify this patch?

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

Can one of the admins verify this patch?

+1 I'm really needing this patch! Please!

For Logstash 5.X, the module has been heavily rewritten. As a result, all outstanding pull requests (some of which are very old) are unfortunately suffering from severe merge conflicts, and many of them are probably no longer needed.
With the release of the new version, the time has come to close out all the pull requests that have, in all honesty, been neglected. Starting with a clean slate will help us focus on new pull requests that come in against the new code base and the much-improved acceptance test suite.
I apologise for the lost work that is represented in this pull request and will strive, as the current maintainer, to not let pull requests get into a state like this in future.


Setting initial_country does not work

Hello
My website uses https and i try to set initial_country to something else than 'auto' like 'BE' or 'FR' but that does not work.
Do you have a solution for that ?
Thanks a lot!
Thomas

Hi @tomzi I have just released version 2.0.2 which fixes this issue. (you had to use lower case country codes before this fix.) Cheers


[Question] How to persist notes using the docker image?

Hi there,
thanks for this great app! I'm running takenote as a docker image and would like to persist my data using a volume mount.
docker run \
-e CLIENT_ID=xxx \
-e CLIENT_SECRET=xxxx \
-e NODE_ENV=development \
-p 5000:5000 \
-v $(pwd):<path??>
takenote:mytag

Where does takenote save files within the image?
Cheers
Chris

Hi there,
TakeNote does not persist anything currently - it's just using local storage.

Hi there thanks for your fast reply! Is there another way to backup notes?

This application is still a work in progress. Discussion on GitHub integration and persistence is here: https://github.com/taniarascia/takenote/issues/165

Interesting! Thanks for sharing! :-)


[fix] Fix example notebook unit tests

Description of changes:
After PR #180, we've been consistently running into issues where pip installing fmeval from pypi within the example notebooks (this installation is always included as the first cell of the notebooks) is causing dependency version issues that cause the test_custom_model_hf_notebook test to fail.
Specifically, tokenizers is getting re-installed to be a lower version (0.12.1) that is used by the current release of fmeval , but transformers somehow isn't also getting re-installed to its lower version (4.22.1); it's still 4.37.2 as dictated by pyproject.toml.
This PR updates the example notebook unit tests so that they do not install fmeval from pypi. Rather they will continue to use the fmeval package installed by poetry during poetry install, i.e. the same fmeval package that the rest of the unit tests run against.
In order to accomplish this desired behavior, I have updated the unit tests to skip the execution of the first code cell.
The for loop that iterates through tb.cells and runs execute_cell() is directly copied from the body of execute(); I simply added a couple lines of extra logic to skip the first code cell.
While this is a bit hacky, the testbook library doesn't provide a good way to skip cells that get run during the test (there is a way to specify cells to run before the test, but that's not what we want to do).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for fixing the issue!


Embed on lists

How can I embed on lists, for example /posts/1?_embed=comments works fine.
But /posts?_embed=comments doesn't work.
There's a way to embed on lists?

Not yet, but it's a planned feature.

Just released v0.7.26, lists should now support _embed and _expand query parameters :)

:clap: :heart_eyes: :clap:


Clear data on exit flag doesn't work anymore

OS/Platform
Fedora and CentOS
Installed
Flatpak
Version
116.0.5845.96
Have you tested that this is not an upstream issue or an issue with your configuration?

[ ] I have tried reproducing this issue in Chrome and it could not be reproduced there
[ ] I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there
[ ] I have tried reproducing this issue in ungoogled-chromium with a new and empty profile using --user-data-dir command line argument and it could not be reproduced there

Description
Flag doesn't work anymore
How to Reproduce?
Enable #clear-data-on-exit, go to a few websites, close Ungoogled Chromium, open it back up, browsing history shows multiple items that aren't deleted.
Actual behaviour
Browsing history is saved
Expected behaviour
Browsing history is cleared upon exit
Relevant log output
No response
Additional context
Not sure how long it's been going on but stopped working somewhat recently.

Please follow https://github.com/ungoogled-software/ungoogled-chromium-windows/issues/259 since it was first.


Fix cfg conditions for wasm

In the src/lib.rs file, there were cfg conditional compilation flags around the imports of use_eval which were written as
    #[cfg(all(target = "wasm", feature = "web"))]

which were meant to only enable the following code on the wasm target, but these were setup incorrect. The correct way to check if on wasm is the following:
    #[cfg(all(target_arch = "wasm32", feature = "web"))]

Thank you :)


StandardMaterial flat values

Added support for 'flat' values (i.e. that do not vary across the surface, so no textures) in StandardMaterial. I just got this working with the 3d_scene_pipelined example. I haven't implemented sorting by material and I'm just naively rebinding on for every mesh. I don't really like the way I had to munge the StandardMaterial's BufferId and Option<BindGroupId> into ExtractedMesh and I'd love to hear suggestions for better ways of managing that. I don't really understand why the ExtractedMesh are added to a Vec<> member in ExtractedMeshes which is inserted as a render world resource, instead of them being inserted as individual entities, as then I would have added a component to those entities. I'm guessing it has something to do with queries not guaranteeing order or something.

I don't really understand why the ExtractedMesh are added to a Vec<> member in ExtractedMeshes which is inserted as a render world resource,

I made this call for performance reasons. I tried swapping over to per-entity spawn commands for sprites and got a pretty major performance dip.
However ultimately I think spawning as entities is probably the way to go, as it allows people to attach custom data to extracted entities and easily correlate it to the data we extract for entities (like mesh data).
I also think we have a number of options to cut down on overhead:

Theres a "command optimization" PR in the main bevy repo that gets small-ish wins ~20% iirc
We could use a single spawn_batch command, although we don't currently have something like "spawn_at_batch", so we can't currently re-use entity ids. Additionally, spawn_batch won't currently work because by default the Commands entity allocator is tied to the app world (this is very bleh and what necessitated the spawn_and_forget hack from before).
We could directly pass in the RenderWorld as a resource during the extract step (and directly spawn entities there to avoid Command overhead).
We could implement the "Commands -> SubWorlds" proposal, which would allow us to reuse allocations made in subworlds.

I don't really like the way I had to munge the StandardMaterial's BufferId and Option into ExtractedMesh and I'd love to hear suggestions for better ways of managing that

I want to experiment with doing "asset extraction" in the extract step to protect against this kind of thing. I think we can make it perform just as well, and it would be much more clean / consistent that way.

I don't really understand why the ExtractedMesh are added to a Vec<> member in ExtractedMeshes which is inserted as a render world resource,

I made this call for performance reasons. I tried swapping over to per-entity spawn commands for sprites and got a pretty major performance dip.
However ultimately I think spawning as entities is probably the way to go, as it allows people to attach custom data to extracted entities and easily correlate it to the data we extract for entities (like mesh data).
I also think we have a number of options to cut down on overhead:

Theres a "command optimization" PR in the main bevy repo that gets small-ish wins ~20% iirc
We could use a single spawn_batch command, although we don't currently have something like "spawn_at_batch", so we can't currently re-use entity ids. Additionally, spawn_batch won't currently work because by default the Commands entity allocator is tied to the app world (this is very bleh and what necessitated the spawn_and_forget hack from before).
We could directly pass in the RenderWorld as a resource during the extract step (and directly spawn entities there to avoid Command overhead).
We could implement the "Commands -> SubWorlds" proposal, which would allow us to reuse allocations made in subworlds.

Sounds good. I’m fine with it being a resource for now and making an iterative change later when ECS performance is good enough for this.
It also feels a bit strange to have multiple copies of data - in the app world, extracted in the render world, converted from that to std140, written into a staging buffer, and copied to VRAM. That’s possibly 4 copies in system RAM and one in VRAM. I appreciate that we need to have at least one in the app world, one in the render world, and one in VRAM but is there a way to avoid the 2 additional copies? I was thinking about extracting directly into std140 buffers. And then I wonder if the staging buffer actually makes a copy or just holds a reference. The copying is inefficient, and takes space.

I don't really like the way I had to munge the StandardMaterial's BufferId and Option into ExtractedMesh and I'd love to hear suggestions for better ways of managing that

I want to experiment with doing "asset extraction" in the extract step to protect against this kind of thing. I think we can make it perform just as well, and it would be much more clean / consistent that way.

What do you mean here? I was thinking that the BufferId is only used to insert into the bind group so I could move the bind group creation into the extract step and remove the BufferId member from ExtractedMesh, only storing the BindGroupId. But it sounds like you maybe mean handling the staging and buffer copy or texture creation and upload, similar to how uniforms are handled, rather than running app world systems to do it.

I was thinking about extracting directly into std140 buffers.

This would require direct access to a centralized UniformVec resource (which is doable if we insert the render world as a resource, but would require running such systems serially). The main reason not to do it is if there is expensive work required to make it happen (ex: computing the inverse of a matrix). We want to keep the extract step as short as possible to allow the next frame update to start running as quickly as possible.
I honestly doubt that the extra step costs us much. But its worth benchmarking.

And then I wonder if the staging buffer actually makes a copy or just holds a reference. The copying is inefficient, and takes space.

Afaik this is a direct memory-mapped pointer.

What do you mean here? I was thinking that the BufferId is only used to insert into the bind group so I could move the bind group creation into the extract step and remove the BufferId member from ExtractedMesh, only storing the BindGroupId. But it sounds like you maybe mean handling the staging and buffer copy or texture creation and upload, similar to how uniforms are handled, rather than running app world systems to do it.

Basically:

Listen for asset changes in the Extract step and extract them into new Handle->ExtractedAsset maps
Instead of extracting BufferIds for things like mesh entities, extract the handle instead
Write new/changed assets to the gpu in the Prepare step
Lookup the BufferIds for each entity's handle in the Queue step

And then I wonder if the staging buffer actually makes a copy or just holds a reference. The copying is inefficient, and takes space.

To be clear: we can definitely remove the intermediate buffer, it just puts a restriction on when/how we map the staging buffer. Without the intermediate vec it would be hard to queue things up across systems. But thats not really a major loss in this context.

And then I wonder if the staging buffer actually makes a copy or just holds a reference. The copying is inefficient, and takes space.

To be clear: we can definitely remove the intermediate buffer, it just puts a restriction on when/how we map the staging buffer. Without the intermediate vec it would be hard to queue things up across systems. But thats not really a major loss in this context.

Perhaps it's possible to support both ways of doing things. A sort of deferred staging buffer that holds a copy of the data, and an immediate zero copy version?

Let me know if there's anything else you'd like me to change before this is possible to merge. :)

Looks good to me!


Removed the default option touchControls of the swImageSlider plugin

Regarding the PR #1118
It is really sad, that you just close the pull requests without a feedback, that the PR can be discussed. It was just closed, no way to discuss the issue. In my opinion, the problem is, that the fix for the underlying issue, is probably very complicated and may even introduce a bc break. This PR fixes one issue which exists at the moment and even removes redundant code. It is not that there is more code added for a workaround etc.
So please reconsider your communication with the community, since we are doing the same thing when we write the PR messages. Otherwise I will probably no longer create PRs since they are time consuming to create (message) and then will just be closed with a standard message. I am a bit disappointed.
Description

Questions
Answers

Why?
The image slider will be destroyed and reinstantiated. In our case it sometimes came to a race condition where trackThumbnailControls was already executed but the plugin was "destroyed" and thus the function resulted in an error Uncaught TypeError: Cannot read property 'position' of null. Where the line of failure was pos = $slide.position(),. This is probably a deeper issue which should also be looked into.

BC breaks?
No

Tests exists & pass?
None exist

Related tickets?
-

How to test?
Create a template with an image slider (instantiated by data-image-slider="true") and then for example load an shopping world.

Requirements met?
Yes

We are trying to keep the number of pull requests as small as possible and give you feedback in a short time. We did not intend to disappoint you. 😞
Back to your issue:
We've tried to reproduce this issue and the only thing we've noticed is, that the init function only executes once. But we are still not able to reproduce your described issue.
Can you provide us with a reproducible sample scenario to verify the issue?

Thank you, if I know you cannot reproduce the problem I can look into it more closely :-) In fact I did look at the problem more closely and the issue was unfortunately not as I said, that the plugin configuration was different, but in the state manager, has me._previousState = "". Therefore StateManager._getPluginConfig(me._previousState, selector, pluginName) will return an empty object, which obviously differs from {touchControls: true}. That is why the patch fixed the issue.
I have created an demo plugin which has the issue, see here: SwkweSliderTouchControllsBug As soon as the Emotion Shopping World is loaded the plugin swImageSlider is destroyed.
Unfortunately I was not able to reproduce the race condition. There is another plugin on the page which manipulates the swImageSlider plugin. Maybe there is the issue, but this modifications the site has no more errors. I also created some screenshots that hopefully help.

I suggest the following fix, change: https://github.com/shopware/shopware/blob/5.2/themes/Frontend/Responsive/frontend/_public/src/js/jquery.state-manager.js#L926 to: previousState = me._previousState = me._currentState || state,
I have not tested this or checked for any other problems.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-18939.
Please use this issue to track the state of your pull request.

Hi @aragon999   yes it fix my problem.
FYI The issue still exist in shopware 5.4.1 when i use shopware Quickview (Professional Edition plugin)
Thanks


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/236 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target.git

Docs Build status updates of commit a0b46fa:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-11-21-01-04-22 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Archive_master_2019-11-21-01-04-22

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


All template files open as a tab upon new project creation

The OpenInEditor="true" attribute should be removed from the ProjectItem elements.

Fixed in 4fed27eaa1b1b36099680124db01ab0564d32ef5


Support for AWS SDK PHP Instrumentation

Hi!
This PR builds on the work completed in #72 and contains the implementation that allows for instrumenting the AWS SDK in PHP. The runkit7 library is used to patch methods from the AWS Client class and create spans.
Depends on #797 in opentelemetry-php to get access to TracerProvider.

Looking good. Because this is dependent on https://github.com/open-telemetry/opentelemetry-php/pull/797 let's make sure we wait for that to be merged first (and a new release tagged). I think you should also bump the version constraint on the main otel package to >= 0.0.15 (the next version).

there are a couple of PRs in the main repo (800 and 797) that need to be merged and in a tagged release prior to this, so I'll hold off merging until then.


[dv] Chip env SV function invokes an external command with multiple shell pipes

See hw/top_earlgrey/dv/env/chip_env_pkg.sv :: sw_symbol_get_addr_size() function. It invokes an external command like this:
      string cmd = $sformatf("/usr/bin/readelf -s %0s | grep %0s | awk \'{print $2\" \"$3}\' > %0s",
                             elf_file, symbol, out_file);

Multiple pipes are not a good idea. Alternative is to do DPI-C + libelf programming.

@sriyerg can this issue be updated?

This was pointed out by @rswarbrick. This has not been an issue for over a year now. Perhaps ok to close?

My take is that we'll probably tidy this up one day, but there's no real need to keep an issue open. Let's close this and fix it if we come across the code and feel motivated :-)


[TASK]: Agree on and potentially document a process for recording outcomes of off-GitHub discussions

What needs to be done?
Following on from discussion in thread of #288. We sometimes have conversations about this project off-GitHub - for example during the semi-regular in-person hackathon events we've been running or on the internal ARC Slack workspace. To make sure those not present in these discussions are aware of the points raised and the rationale behind any decisions made, I would suggest we should have some minimal process around ensuring we sufficiently document such conversations to allow everyone the chance to contribute.
We generally already create issue corresponding to any decision about changes to be made, but sometimes these have been very barebones and not had any summary explaining why a decision was made. I would suggest we just ensure that in any such issue we give a (potentially very brief) summary of the points made in the initial issue comment. We could potentially even have an issue template specifically for this, though not entirely sure that makes sense?

I acknowledge that #254 could have done with more text in the leading comment.
But FWIW I'm also OK with the workflow that we ended up having. It seems sane to me...

Potentially contentious changes were explicit in the name of the issue and PR,
comment challenging the decision on the PR was raised and PR marked as "changes requested" because changes were requested,
...discussion ensued.

Modulo that I disagree with the comment here. In-person decisions are not final. Differing opinions are welcome. This is now explicitly codified in line 21 of our CoC.

I would suggest we just ensure that in any such issue we give a (potentially very brief) summary of the points made in the initial issue comment.

I'm 👍 this - it makes it much more inclusive as a project if everyone can see why decisions have been taken, and I don't think it adds much more effort on top of in person discussions to jot reasons behind a decision down. Indeed, it also helps remember why a decision has been taken later - I think someone who was in person commented on a thread somewhere that they had forgotten why a decision had been made!

Notes from hackmorning 2024-10-22
We will write hackmorning discussion in a comment. These summaries are de-facto agreed by all attendees of the hackmorning.
We try to ensure we have a summary of the discussion and section for decision:
# Notes from hackmorning 20YY-MM-DD

## Discussion

Longer section with bullet points covering main discussion points

## Summary

For people who want the gist of the discussion.

## Decisions

What are we going to do.


Make instructions for setting up local instance of project clearer

While trying to set up the project locally, I had some problems so I am suggesting these improvements to make the documentation better.

The third instruction says to "install mariadb" but it is already listed in the package.json file as a dependency and will be installed with other packages when npm i is run. I think the repetition can get contributors confused.
On running npm run dev I got an error because I did not have nodemon installed. Stating that nodemon is a requirement for setting up the project and clearly stating how it can be installed (npm install -g nodemon) can fix this.

This is open to a review by a maintainer and if the proposed changes are approved, I would love to be assigned to this issue:

I love it, feel free to update the readme

I love it, feel free to update the readme

Thank you! I worked on it.


Document how to use in github actions

Users might get the following error in CI:
💀 Engine error: No such process 💀

The specified process cannot be traced. This could be because the tracer
has insufficient privileges (the required capability is CAP_SYS_PTRACE).
Unprivileged processes cannot trace processes that they cannot send signals
to or those running set-user-ID/set-group-ID programs, for security reasons.
Alternatively, the process may already be being traced.

If your uid matches the uid of the target process you want to analyze, you
can do one of the following to get 'ptrace' scope permissions:

* If you are running inside a Docker container, you need to make sure you
  start the container using the '--cap-add=SYS_PTRACE' or '--privileged'
  command line arguments. Notice that this may not be enough if you are not
  running as 'root' inside the Docker container as you may need to disable
  hardening (see next points).

* Try running again with elevated permissions by running 'sudo -E !!'.

* You can disable kernel hardening for the current session temporarily (until
  a reboot happens) by running 'echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope'.

Rather than waiting for them to get the error to notice it, document that when running in github actions they should have a step that runs echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope.
We can add this in a section of the README file.

You need indeed to do the step recommended on the error message:

You can disable kernel hardening for the current session temporarily (until
a reboot happens) by running 'echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope'.

See https://github.com/bloomberg/pytest-pystack/blob/1e19e00c80efe5b678ea530bc34d38c28579e1eb/.github/workflows/validate.yaml#L50 fir ab example


USER_INPUT response from Archivematica is not being handled correctly

USER_INPUT response from Archivematica is not being handled correctly
USER_INPUT response should render a message to the user and continue ingesting other objects
Ingest is stalling as a result of USER_INPUT message

resolved.  The record is flagged as a failed.


Fix: updated Navbar Items btn bg

What does this PR do?
This pull request updates the background of the navbar items in the Next.js project using Tailwind CSS, ensuring improved visual consistency and a more appealing user interface.
This Particular PR Fixes #1314 From the Repo - responsively-org/responsively-app - as per needed!
Mandatory Tasks (DO NOT REMOVE)

[ ] I have self-reviewed the code (A decent size PR without self-review might be rejected).
[ ] I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
[ ] I confirm automated tests are in place that prove my fix is effective or that my feature works.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@esprush & @themohammadsa - Guy's Please Give it a Merge!
Majorly, I've fixed what needed to be, if something don't go right - please lemme know!


Training Scheme on Waymo

Dear authors,
thanks for sharing your nice work!
I am currently also trying to train Monodepth2 on waymo and I am running into some stability issues.
Did you modify the training code for Monodepth2 in any way when training it on Waymo?
Many thanks in advance!
Best,
Felix

Hi Felix,
Thank you for your interest in our work!
As far as I can recall, when evaluating Monodepth2 on Waymo Open, we just followed the official codebase and training procedure. From our investigations, small variations in learning rate, schedule, and number of epochs didn't appear to affect Monodepth2 performance at convergence.
Can you elaborate on the stability issue that you are running into? From our experience, the predominate errors that we observed are for dynamical regions, as shown by Figure 2 in the paper.
Hope this helps!

Closing this issue due to inactivity. Feel free to reach out if you have additional questions!


[Bingo] Killing Megas of a bingo-mon (Mawile) counts as a bingo catch.

To Reproduce
Steps to reproduce the behavior:
1.Have Mawile on your bingo.
2. Kill a Mega Mawile.
3. See it's been crossed off of bingo, despite you never catching it.
 If this is an intended feature, that's nice honestly. I'm just unsure if it even is.
Screenshots
I don't have any, sorry.
Username:
BUGJUUICER/BUG-JUICER#0940
Server name (all applicable):
Orion, likely all.

Having tested this issue on Beta and Orion just now, I am unable to trigger this issue, so I am thinking something has fixed it in the past few months.  Sorry for the delay, but thanks for the ticket, Buggy!


Infinite loop when parsing invalid HTML

I found a piece of invalid html that is causing infinite loop (and maximum execution time issues).
similiar issue was #179 that was closed already but this example shows that similiar cases exist, how we could fix it without having access to change the html?
<img src="www.example.com/image.jpg" data-caption="How did <i>

I understand it is an invalid html but the parser should not stuck when trying to parse it and fail gracefully rather than causing infinite execution time

Thanks for the report.
I have added this to the release in 2.1.1 and, once I confirm the issue with a test, I'll see to a fix.
If you can provide a PR with a fix and test I would also appreciate that.
Thank you.

I'm having the same issue with a broken html.

I update to 2.1.1 and it's still Infinite loop

I think I have the same problem with this url: https://www.business-solutions.telefonica.com/en/products/security/cloud-security/

@paquettg
I understand that some of the things were fixed to stop infinite loops but an example that I had in my integration tests with this library is still failing for:
'<the thing broke itV'

I'll try this out on the 3.0.0 dev branch later tonight

Fixed this issue in the 3.0.0 branch. Now the string <the thing broke itv will parse into <the thing broke itv></the> and will not result in an infinite loop.


Created README

Current dependencies on/for this PR:

main

PR #20   👈

This comment was auto-generated by Graphite.


added min versions for torch as suggested by Gong

Sweep was unhappy about unqualified requirement. Updated the docs/mnist_example requirement file to suggestion by @gongsu832

Good discussion here, way beyond this poor nminst example. I picked a max from not too recent a version. It's an example, so it should be fine.
https://pytorch.org/get-started/previous-versions/

@jenkins-droid test this please

Jenkins Linux s390x Build #9782 [push] added min versions for t... started at 14:54

Jenkins Linux amd64 Build #9763 [push] added min versions for t... started at 13:54

Jenkins Linux ppc64le Build #8828 [push] added min versions for t... started at 14:58

Jenkins Linux amd64 Build #9763 [push] added min versions for t... passed after 1 hr 35 min

Jenkins Linux s390x Build #9782 [push] added min versions for t... passed after 3 hr 11 min

Jenkins Linux ppc64le Build #8828 [push] added min versions for t... passed after 3 hr 35 min


Add mollie payment module

I'm able to complete / pay an order through a Mollie api test key.
Still needs some work.
For example; when the payment fails and another attempt is made after being sent back to the confirm order step, the redirect URL needed by Mollie is missing.

Yes, it can be merged. I'll see if I can improve it but I'm not actively working on it (only when I have some free time)


[REG2.066] Issue 14853 - DMD segfaults with the cast from mutable struct new to shared

https://issues.dlang.org/show_bug.cgi?id=14853
A trivial bug, lack of NULL check.

Thank you, Kenji, for the quick work!


Fixed some spelling and grammar errors

As per email from professor.

That was quick !! Thanks :)
On 24 November 201100:01, Luke Kysow
<EMAIL_ADDRESS>wrote:

As per email from professor.
You can merge this Pull Request by running:
git pull https://github.com/lkysow/Markus spelling-fix
Or you can view, comment on it, or merge it online at:
https://github.com/MarkUsProject/Markus/pull/589
-- Commit Summary --

Fixed some spelling and grammar errors

-- File Changes --
M config/locales/en.yml (6)
-- Patch Links --
https://github.com/MarkUsProject/Markus/pull/589.patch
 https://github.com/MarkUsProject/Markus/pull/589.diff

Reply to this email directly or view it on GitHub:
https://github.com/MarkUsProject/Markus/pull/589


Remove "binding site" from extensions in GAF output

The new GAF writing code is putting things like "binding site(488-499)" in column 16:
PomBase   SPAC6F6.16c tpz1        GO:0005515  PMID:24013504   IPI PomBase:SPAC26H5.06 F           protein taxon:4896  20131112    PomBase binding site(488-499)

There are 7 incorrect GAF lines.

Fixed for tonight's load.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/34729

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/35229

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/71300

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/104416


Remove unnecessary mutex in InChI wrapper

This is an updated version of #3474 with merge conflicts fixed and adjustments for InChI v1.06
@jinpan: If you have time please take a look to see if you agree with my minor changes to your original PR.

The new changes look good to me, though I probably will not have a chance to run the tests firsthand.
Thanks for getting this change over the line!


Valkyrie stacks not showing

I tried, i think, every setting, i just cant show Valk runes on tcc, can you help me?

I just checked and they correctly show in Valk class window.

I'll reinstall the mod this third time, give you updates, but I'm still
having problems
On Sat, 15 Feb 2020, 16:49 Foglio<EMAIL_ADDRESS>wrote:

I just checked and they correctly show in Valk class window.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Foglio1024/Tera-custom-cooldowns/issues/249?email_source=notifications&email_token=AG5EYK6M7SBFSZKMR5URKLDRDBBN7A5CNFSM4KV3UDI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL3VPNA#issuecomment-586635188,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG5EYK3EFJXT7KV7ICO5KADRDBBN7ANCNFSM4KV3UDIQ
.


CoreFx #15622 New overload Dictionary.Remove(K, out V)

Changes equivalent to those in dotnet/corelr PR #10203 for the dotnet/corefx Issue #15622, PR #18109
@safern @danmosemsft @jkotas @karelz @stephentoub Please review.

@safern Thanks much for pointing out. I had forgotten this PR! Please reviewthe changes that I have submitted...

LGTM. Thanks!


[CIT-474] check version before removing package

Proposed changes
The code changes fix the issue related to removing the module without checking the version when a specific module version has to be removed.
Types of changes
What types of changes does your code introduce to thin-edge.io?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (general improvements like code refactorings that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[ ] I have signed the CLA (in all commits with git commit -s)
[ ] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

Merging #377 (4291716) into main (b887406) will decrease coverage by 0.25%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   68.15%   67.89%   -0.26%
==========================================
  Files          98       98
  Lines        5897     5919      +22
==========================================
  Hits         4019     4019
- Misses       1878     1900      +22

Impacted Files
Coverage Δ

sm/plugins/tedge_apt_plugin/src/main.rs
0.00% <0.00%> (ø)

tedge/src/cli/connect/bridge_config_c8y.rs
94.59% <0.00%> (ø)

common/mqtt_client/tests/mqtt_pub_sub_test.rs
92.98% <0.00%> (ø)

common/mqtt_client/tests/packet_size_tests.rs
90.90% <0.00%> (ø)

common/mqtt_client/tests/rumqttd_broker.rs

common/tedge_utils/src/test_mqtt_server.rs
84.61% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b887406...4291716. Read the comment docs.


Support clean-css v4

https://github.com/jakubpawlowicz/clean-css/blob/master/README.md#important-40-breaking-changes

@lukeapage: how do you want to handle the upgrade? IMO we should remove advanced etc and keep clean-css's O1 defaults.

@XhmikosR
Just chiming in here: imho, ideally you'll want to detect the version in use for CleanCSS and switch on that, continuing support for the old API as people may be stuck using the 3.x branch for some reason or other.
While afaict CleanCSS doesn't have a version member on its exported object, you can still grab it from the package.json file. Very easy to do, actually:
var cleanCssVersion = require("clean-css/package.json").version;

For the CLI options in v4, you can probably directly copy a large part of the argument parsing logic from the clean-css-cli package as well.

Well, all this is nice and all, but 1) this repo has no tests and 2) I don't want to make so many changes myself. So we need someone to submit a working PR for the current clean-css version and if/when there is a bump we decide how to proceed with old versions.

Upgrading would also fix #26.


After hitting "Reload Profiles", add a message "Profiles reloaded", then make that fade away

After hitting "Reload Profiles", add a message "Profiles reloaded", then make that fade away.  Otherwise it's not obvious that anything happened.

Implemented in 9147931d3e001c3364aab60b873d3577007eae0a.


How to spend from 1 of 1 wallet?

Does anyone have an example for spending some bitcoins from a single user wallet? I cannot get it working via the createTxProposal function. It crashes when I try to sign it, saying that the signature of the proposal is missing.

Okay. I got it working. Workflow is:
create, PUBLISH, sign and then broadcast the proposal. Kinda pointless to do the broadcasting and then "downloading" but at least this works.

Please can you tell How to create Tx ?
Thank you