Error handling for file scanning problems is not handled well

I think this is wrapped up.  There is now a -e switch which will display a list of files/directories that had scanning errors.  These are listed at the end output and will default to be off.


Wrong Results for Triangle Query

Wrong Results for Triangle Query
TuGraph 3.5.0 provided wrong results on Finding Triangles in a graph when executing cypher on web interface.
To Reproduce
I used tugraph/tugraph-runtime-centos7  with tag "latest", image ID 1152289e2d3e.
And started this image by
sudo docker run -d -p 7070:7070 -p 9090:9090 --name -v /mypath:/home/root/ tugraph_demo tugraph/tugraph-runtime-centos7 lgraph_server -c /mypath/lgraph.json
My dataset is a randomly tag social network based on SNAP graph LastFM.
The graph files are
Person.csv
knows.csv
import.config.txt
Then i imported the graph by
lgraph_import --online false -c import.config.txt -d /mypath-to-data -g LastFM -u admin -p 73@TuGraph
Then I log in localhost:7070, and executed a cypher query:
match (p1:Person{community:0})-[:knows]-(p2:Person{community:1})-[:knows]-(p3:Person{community:2}), (p1)-[:knows]-(p3) RETURN DISTINCT p1.id,p2.id,p3.id ORDER BY p1.id,p2.id,p3.id;
Tugraph generated a results, and said there are 21759 triangles:

However, there are only 3433 triangles, which is verified by at least 2 other graph database.
For example, (13,1937,252) is a result tuple provided by tugraph. But there is no edge connecting Person 13 and Person 252.

Currently, spaces are required around the "AND".
You can try modifying the "oC_AndExpression" in Lcypher.g4.
oC_AndExpression : oC_NotExpression  ( (SP)* AND (SP)* oC_NotExpression )* ;

tugraph generated an incorrect execution plan, and I will make modifications soon.


Arcsight test fix

Package test fixed

There is probably a check error:

previous PR check was green, but test failed,
now I fixed this test and it's now locally green, bit it fails on check.
maybe check run on master instead of branch?


Feature/fixed grid pchip fourier integral

Depends on #1
Copy of #2 to get comparison against current state of main.
Implements a function fourier_integral_fixed_sampling_pchip which takes an array of frequencies $f$ and an array of corresponding function outputs for some function $g(f)$ and calculates the fourier integral of $g$ at times $t$ also given as an input.
The calculation approximates the function as a piecewise cubic Hermite interpolating polynomial (PCHIP) and calculates the fourier integral analytically for this interpolating polynomial.
Heavily based on section 1.6.3 in N. Mounet. The LHC Transverse Coupled-Bunch Instability, PhD thesis 5305 (EPFL, 2012)

Performance
Using realistic intermediate value from the C++ code, i.e. by taking a snapshot of all arrays after the bisection algorithm has finished, this is how the newly implemented functions perform compared to IW2D. This is using IW2D/examples/input_files/WakeFlatChamberInputFile.txt with the tolerance changed to 1e13
Phi and psi

Fixed grid fourier integral
Disclaimer: I'm a little worried this relatively large error is partly due to how I extract the numbers from C++, will look more into it

EDIT: So as far as I can tell, the reason for the error is that scipy's pchip and the IW2D pchip apparently disagree quite a bit, with a similar error magnitude as in transform above. Will investigate further

EDIT2: So the discrepancy in PCHIP derivatives seems indeed to be the primary reason for the large differences between the two. I will put up an issue detailing it later. Added a commit where I changed the PCHIP to treat the real and complex parts separately. This is not what IW2D does, so the results are still quite different, but now I think that is due to the way it is implemented in IW2D, and not any bugs in the implementation here.

EDIT 3: So as to not only compare to IW2D - here are some plots comparing the results against analytically computed integral, more specifically $\frac{1}{\sqrt{\omega}}$:
1k frequencies

10k frequencies

New input and output range, 1k frequencies

10k frequencies


Bug - Button config input not registering

Newest 1.6.0 update causes controls that are mapped to backbone or 3rd party controllers become unresponsive aside from the L3 button to trigger the menu
iOS 18 dev beta 2
13 Pro Max
https://github.com/zodttd/GammaSupportDocs/assets/164794137/812a1838-9d06-4f8c-9529-6687efcb6709

Solved with new 1.6.1 update


Mess when using Angular CLI

I'm using webpack 4 (backend) and Angular CLI (frontend) in one repo, and this is what I get when using concurrently:

When I'm using repos separately without concurrently, Angular CLI doesn't spam like that.

What's the concurrently version you're using?

{
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.6.3",
    "@angular/cli": "6.0.3",
    "concurrently": "^3.5.1", // this
    "webpack": "^4.7.0",
    "webpack-cli": "^2.1.3",
    "webpack-watch-server": "^1.2.1"
  }
}

Same issue here (webpack 4). Using raw fixes it, but at the loss of the prefix option.

Unfortunately same issue here with webpack 4.16.3 and concurrently 3.6.1 but without angular-cli on Windows cmd and powershell.

Unfortunately I do have a problem when using --raw option on Windows OS. If used with angular cli (e.g. ng serve or ng build, etc) it's getting stuck and command never gets executed. So, temporary workaround for me it's to add --no-progress to the ng command and do not use --raw option for concurrently.

Hi folks, can any of you isolate the issue, please?
Also provide Node, npm and Windows versions so that I can run it locally and find a fix, unless you can submit a PR.

Issue seems not to be reproducible anymore in angular CLI 6.1.3. However it's reproducible in angular cli 6.0.0. Here is a project generated with angular cli v 6.0.0
In order to reproduce issue:

Clone repo
run npm install
run npm run start:concurrently


Review 14px text size

There are a couple of places in the UI where we use 14px text size - namely form help text and some tables.
This should be reviewed.

Note: this is controlled in the SCSS by the variable $small-font-size

The only requirement is that you leave the user with the ability to increase the size by 200%. Best practice is to specify the font-size using em so that the font size can be adjusted independently of browser magnification.

https://webaim.org/discussion/mail_thread?thread=7051

Problem: Changing the 'font size' in Google chrome settings does not affect the fonts for the site.

Line height should also be set in em, so that the height of elements adjusts with the increased font size setting


feat: Update build pipeline

This introduces docker buildx to build vhs.
This allows us to build multiarch docker images and hopefully save some time with caching the build layers between builds.
I saw a reference for dependabot and thought Id include it, not sure how beneficial itll be.
Signed-off-by: Brad Beam<EMAIL_ADDRESS>

I'll do a followup to revert dockerignore changes.


CODEOWNERS: Add Profpatsch to /lib/generators.nix

I’d like to be notified of changes so I can ensure the API always follows the same patterns.
Later (more specific) files replace more general codeowners according to the documentation, so I also listed edolstra and nbp again.

The CODEOWNERS file has one clear purpose: to describe who owns what.

Well, since I wrote that module and am the only contributor so far (apart from a few minor treewide changes), I do consider myself the “owner”, insofar as I have an substantial interest in reviewing proposed changes to the file.

I do consider myself the “owner”

That was not obvious from the PR.

That is perhaps the same reason your nick is bound to the python modules?

I'm as maintainer not so much interested in the actual modules, that is up to the module maintainers (when they have one), but I am, in the structure.

That was not obvious from the PR.

Yes, I should have clarified that.


Daemonize bugsnag-agent

Bugsnag agent should fork off to a daemon process, detach it's STDIN/STDOUT/STDERR, and use proper logging, thus allowing it to run as a daemon.
Once this is complete, a proper SysV init script, and possibly a systemd script should be provided.

@protoCall7 Daemonizing makes sense, thank you for the suggestion.


CNV-37371: New setting for change bootable volumes default ns

📝 Description
Now bootable volumes by RH, can be moved between namespaces, the default namespace is openshift-virtualization-os-images
🎥 Demo

/lgtm


HBASE-22596 [Chore] Separate the execution period between

CompactionChecker and PeriodicMemStoreFlusher

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
27
Docker mode activated.

_ Prechecks _

0
findbugs
0
Findbugs executables are not available.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1
mvninstall
142
branch-1 passed

+1
compile
38
branch-1 passed with JDK v1.8.0_212

+1
compile
41
branch-1 passed with JDK v1.7.0_222

+1
checkstyle
76
branch-1 passed

+1
shadedjars
159
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
31
branch-1 passed with JDK v1.8.0_212

+1
javadoc
37
branch-1 passed with JDK v1.7.0_222

_ Patch Compile Tests _

+1
mvninstall
110
the patch passed

+1
compile
42
the patch passed with JDK v1.8.0_212

+1
javac
42
the patch passed

+1
compile
42
the patch passed with JDK v1.7.0_222

+1
javac
42
the patch passed

+1
checkstyle
79
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
174
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
213
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1
javadoc
30
the patch passed with JDK v1.8.0_212

+1
javadoc
41
the patch passed with JDK v1.7.0_222

_ Other Tests _

+1
unit
6727
hbase-server in the patch passed.

+1
asflicense
22
The patch does not generate ASF License warnings.

8213

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-319/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/319

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux fab9af106cc5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
branch-1 / 9472d6e

maven
version: Apache Maven 3.0.5

Default Java
1.7.0_222

Multi-JDK versions
/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_212 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_222

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-319/1/testReport/

Max. process+thread count
4817 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-319/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Approved in HBASE-22596


Color crimea as part of Ukraine

Adds a GeoJSON polygon overlay over crimea such that it has the same color as Ukraine. This is maybe not the cleanest technical solution, but it solves the problem for now.
This change was discussed in a Technical Steering Committee meeting a few months ago and is approved by the MapLibre Governing Board.

Looks like this

Thank you for approaching this so quickly!


Drop watchonly wallet migration for old Windows datadir

It was introduced as a temporary hack in v2 (released in August 2023) for migrating datadirs created on Windows using Liana v1 (May 2023).
Presumably Windows users wouldn't have used the beta versions which preceded v1 release with any real funds. This removal would go in v5, released around end of January / early February. Presumably any Windows user who created a mainnet datadir within the 3 months period where the bug was present would have opened its Liana at least once in the following 6 months after the migration was released.
In the unlikely case a user on Windows created a mainnet wallet on the very first release of Liana, funded it, didn't touch it for more than 6 months and tried to open it later using the latest version of Liana available they are instructed to first run Liana v4 (so the migration is performed automatically at startup) before running the latest version of Liana.
Nits on the wording welcome!

The GUI ci failure looks unrelated.


Disallow boolean test on promise

Rule Suggestion
Is your rule for a general problem or is it specific to your development style?
General problem.
What does your suggested rule do?
Prevents an always positive boolean test.
List several examples where your rule could be used
if you have a Promise disallow an if test against it.
It will ALWAYS return true and is almost certainly not what you want. You almost certainly want to await it first.
This just bit me hard and I spent 2-3 hours trying to track this down before I realized my mistake.

Duplicate of #3983; should be better documented per #4117.


private_pem should explicitly zeroize before free

in libspdm_responder_data_sign function, private_pem at line 1769 and 1784 should explicitly zeroize before free.
https://github.com/DMTF/libspdm/blob/178bb19c58e40747def7f494d03a62b57d406d06/os_stub/spdm_device_secret_lib_sample/lib.c#L1766-L1771
https://github.com/DMTF/libspdm/blob/178bb19c58e40747def7f494d03a62b57d406d06/os_stub/spdm_device_secret_lib_sample/lib.c#L1784
similar case in libspdm_requester_data_sign function, private_pem at line 1704 and 1719 should explicitly zeroize before free.
https://github.com/DMTF/libspdm/blob/178bb19c58e40747def7f494d03a62b57d406d06/os_stub/spdm_device_secret_lib_sample/lib.c#L1699-L1706
https://github.com/DMTF/libspdm/blob/178bb19c58e40747def7f494d03a62b57d406d06/os_stub/spdm_device_secret_lib_sample/lib.c#L1719
similar case in libspdm_gen_csr function, prikey at line 1099 and 1112 should explicitly zeroize before free.
https://github.com/DMTF/libspdm/blob/178bb19c58e40747def7f494d03a62b57d406d06/os_stub/spdm_device_secret_lib_sample/lib.c#L1096-L1101
https://github.com/DMTF/libspdm/blob/178bb19c58e40747def7f494d03a62b57d406d06/os_stub/spdm_device_secret_lib_sample/lib.c#L1112

I will check it.


PDB 'libponyrt.pdb' was not found

Every time I compile, the compiler emits a slew of warnings (as seen here.) The programs themselves work fine, but I'm unsure as to what the warnings mean. I'm using Windows 10 and compiling with version master-0.9.0-19c1111 of the compiler.

Thanks for the report.
I suspect this is an issue with the way Bintray binaries are packaged.

@Lordovos can you try this again with a new build, please?  I have not seen these linker warnings with the new build system.

@kulibali Just installed 0.10.0-1c33065 [release] and tried it. It gives off those warnings for the very first time I compiled my project, but then never did it again even after closing and re-opening my terminal.

That build is still too old -- there haven't been any releases yet that use the new build system.  You'll need to try one of the master branch builds, like https://bintray.com/pony-language/ponyc-win/download_file?file_path=ponyc-master-0.10.0-2199.3278261-win64.zip
That build does not give me any link warnings when I build packages\stdlib.

Ah, my mistake. Using that version, the warnings no longer occur.

Cool, thanks!  @SeanTAllen I guess we can close this.


Only web: process types get assigned $PORT and default routing

It would appear that only web: process types get assigned a default routed $PORT
https://github.com/flynn/flynn/blob/45d70b5369f0a7068b8d7d5ade3d14ccc92d98ea/receiver/flynn-receive.go#L108
This came as some surprise to to me, I was anticipating that any process type would be assigned a unique $PORT and that I would be able to assign routes to these additional processes.
related to: https://github.com/flynn/flynn/issues/423

#933 will partly address this by making service registration much easier, but how should we address this? It's a fair assumption that a web proctype will have a (single) TCP port, but for other services, we cannot be so certain (sure, a single TCP port is the most common configuration, but still).
I'm going to start adressing this after #933 is merged and after I figure out a good way for declaring such things (ports, services and checkers).

It is an interesting problem for sure... I had actually thought heroku assigned $PORT to non-web, but they also have this limitation. One issue I see with this in general is that it might be entirely out of the realm of what flynn is suppose to provide... for example, if the goal is to match heroku in feature parity, and nothing further, then this ticket really is just a sidetrack. But if the goal is to go above and beyond... there is no map for how the feature should work.
I would not be opposed to having to "assign / map" a port to a process-type, but then the question of multiple ports per process raises another problem with the use of ENV variables to pass data between the layers ... do we setup $PORT1 .... $PORT2, or is it a range $LOWER_PORT $UPPER_PORT.
In the short-short term just having the clause on this line: https://github.com/flynn/flynn/blob/45d70b5369f0a7068b8d7d5ade3d14ccc92d98ea/receiver/flynn-receive.go#L108 re-worked so that it accepted a case switch of multiple types determined via convention, or possibly matched some other ENV like $PROCESS_WITH_PORTS=web,xmpp,nntp and you did:
if Contains(release.Env["PROCESS_WITH_PORTS"], t) {
   // assign $PORT
}

Resolved by #2002.


Generate a documentation page with a list of UI's and API's provided by the stack

Generate a documentation page with a table for the API's and another table for the UI's offered by the stack.
The information can be retrieved from the labels in the generated docker-compose.ymlfile. This will be added by #36.
Medatadata for a webui will look like shown below
  kafka-manager:
    image: trivadis/kafka-manager:latest
    container_name: kafka-manager
    hostname: kafka-manager
    labels:
      com.mdps.service.webui.url: http://${PUBLIC_IP}:28038

The documentation could be as part of a Markdown file or as an web-application started as a separate container.

this has been implemented by #236


ARROW-8136: [Python] More robust inference of local relative path in dataset

See https://github.com/apache/arrow/pull/6643#discussion_r393802530

So with this, we are back at the Windows path failure ..

@pitrou there is now an error on Windows for the S3 URI string test that I added:
E   OSError: [WinError 123] Failed querying information for path 's3://arrow:apachearrow@mybucket/data.parquet?scheme=http&endpoint_override=localhost%3A1283'. Detail: [Windows error 123] The filename, directory name, or volume label syntax is incorrect.
This is coming from passing the S3 URI to LocalFileSystem().get_target_infos([..]). I can put a try block around that call to "solve" this. But is the error expected? For local (absolute or relative) paths that don't exist, it doesn't given an error. Also this only fails on Windows (on linux such a path just gives a NonExistent file)

As the message says, Windows doesn't like the syntax of the path. You should probably ignore OSError.

OK, all green now


Missing rights to execute install script for <IP_ADDRESS>-EE

Hi,
There was a problem with executing install script during build of docker image <IP_ADDRESS>-EE.
It seems that there is missing execution bit set on  installDBBinaries.sh.
Line related to that issue:
83 RUN $INSTALL_DIR/$INSTALL_DB_BINARIES_FILE $DB_EDITION
Fix to have a complete and successful build is to add line as below before switching to user oracle:
RUN chmod ug+x $INSTALL_DIR/$INSTALL_DB_BINARIES_FILE
Working part of code:
# Copy DB install file
COPY --chown=oracle:dba $INSTALL_FILE_1 $INSTALL_RSP $INSTALL_DB_BINARIES_FILE $INSTALL_DIR/
RUN chmod ug+x $INSTALL_DIR/$INSTALL_DB_BINARIES_FILE
# Install DB software binaries
USER oracle
RUN $INSTALL_DIR/$INSTALL_DB_BINARIES_FILE $DB_EDITION`
Regards

Analysis: The chmod was lost with the introduction of multi-stage builds which happens in the stage before the DB binaries installation.


Change Stocker to avoid warning errors.

According to the lastest Pandas, .ix format is deprecated. And it will cause warnings if I follow the instructions. I change the .ix format to .loc format to avoid it.
Also, I find it really hard to install fbprophet on Windows10. But by "conda install -c conda-forge fbprophet" it can be installed easily. So I add it in README.md.
It's my first time to pull request and plz forgive me if I did something wrong. Really love this project.  :)

Thanks for this. I'll have to review the code, but you are right that .ix should no longer be used for indexing in Pandas (instead it should be .loc or .iloc). Also, installing fbprophet on Windows can be quite a challenge. Thanks for addressing both of these points!

I think the best way for accessing the last row of a dataframe using .loc might be df.loc[df.index[-1], :]. This seems a little more stable than df.loc[len(df) - 1, :] because the index might not be numeric.

Some of the .date() are not removed completely. I removed them.
And also, I encounter a problem that when i use evaluate_prediction

RuntimeWarning: invalid value encountered in sign
test['correct'] = (np.sign(test['pred_diff']) == np.sign(test['real_diff'])) * 1

I find out that it happens due to the first row is nan, so i change it to
test['correct'] = (np.sign(test['pred_diff'][1:]) == np.sign(test['real_diff'][1:])) * 1
It seems you are busy. Good luck!


Are these labs deprecated?

It seems like this labs repo is not maintained any more? I have been trying to get through the setup op lab 1, but the instructions seem to be faulty at some steps. There are also different tools being used compared to the main ibex repo, e.g. openFPGALoader instead of fusesoc. Where could i get support if i wanted to get this labs working?

There may be some stale instructions in these labs. The best way to get these fixed is opening up an issue with the specific problem that you're having. You can also check the Ibex demo system repository to see if any instructions have updated there.
openFPGALoader is used to program bitstreams onto FPGA. FuseSoC is a build environment that can be used to build simulators and bitstreams. Both are still used in the Ibex demo system.


How to implement autoencoder with keras

Please direct this question to the keras google group as it is not a bug in the code.


Improve safety of enforce periodic boundary conditions function

A warning should be issued in the event that any position x > 2Lbox or x < -2Lbox

This is now resolved by the check_multiple_box_lengths feature.


Style declaration is generating a wrong result

Declaring a style like below:
<Box style={[
  "background(Color.Green, CircleShape)",
  "size(Dp(100))"
]}/>

It's generating the following styles in the styles file:
%{
  "background(Color.Green, CircleShape)" => [
    {:background,
     [
       file: "user_registration_live.jetpack.ex",
       line: 1,
       module: "",
       source: "background(Color.Green, CircleShape)"
     ],
     [
       {:., [], [:Color, :Green]},
       {Elixir,
        [
          file: "user_registration_live.jetpack.ex",
          line: 1,
          module: "",
          source: "background(Color.Green, CircleShape)"
        ],
        {:CircleShape,
         [
           file: "user_registration_live.jetpack.ex",
           line: 1,
           module: "",
           source: "background(Color.Green, CircleShape)"
         ], Elixir}}
     ]}
  ],
  "size(Dp(100))" => [
    {:size,
     [
       file: "user_registration_live.jetpack.ex",
       line: 1,
       module: "",
       source: "size(Dp(100))"
     ],
     [
       {:Dp,
        [
          file: "user_registration_live.jetpack.ex",
          line: 1,
          module: "",
          source: "size(Dp(100))"
        ], [100]}
     ]}
  ]
}

I'm expecting something like:
{:background, [], [{:., [], [:Color, :Green]}, {:., [], [:CircleShape]} ]}

@carson-katri suggested that it might be better to have that encoded as:
{:background, [], [{:., [], [:Color, :Red]}, :CircleShape]}

@NduatiK if you note the output you'll see Elixir literal AST nodes


feat: Add initial dockerfile

We want to be able to distribute mocktimism via a docker image. Add dockerfile to be used for this and CI

Add initial dockerfile to build mocktimism as a docker image

Addresses first 2 items in https://github.com/ethereum-optimism/mocktimism/issues/27

Current dependencies on/for this PR:

10-18-feat_Add_cli_action_config

PR #41   👈

PR #42

PR #43
PR #39

This comment was auto-generated by Graphite.

Related to https://github.com/ethereum-optimism/mocktimism/issues/11


Stop dispatching a "localized" event from the webL10n library, since it's unused and may clash with the default viewer

Currently this leads to confusing behaviour with eventBusDispatchToDOM = true set, since then there's two different "localized" events being fired.

/botio-linux preview

Looks good!


The fps is very low

  If there is an other window in the rect of the game window, the fps is very low

This is a normal behavior when you "sends" torque3d to the background. You can disable this behavior, see this link: http://wiki.torque3d.org/scripter:controlling-framerate-when-the-window-is-unfocused

I have set $Platform::backgroundSleepTime to 1 and the problem is still.I will sends this to the forum.

I suspect that if you want the game to run at 100% while not the foreground task then you will have to do some tinkering at the Operating System level as it automatically reduces the CPU and GPU task time of all applications unless specifically ordered otherwise.
This should not be considered a bug or an issue given that you appear to want very custom behaviour.

Yeah, this sounds like some customized behavior that falls outside of the regular focus/window timing. The forums will be your best bet in trying to figure out how to customize this to your needs. For now, I'll close this issue.


Add support for reactive streams with mongodb.

Description (Note: This is a draft pull req. Changes are still in progress.)

Replace mongodb driver with reactive mongodb driver. Change APIs accordingly.
Use webflux + reactor framework to execute mongodb queries in event loop model.

Fixes appsmithorg/appsmith #1480
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
In Progress.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

raised new request: https://github.com/appsmithorg/appsmith/pull/1720


Styles add gradient mixin

🙌 Needed gradient and now we have it! Next up: box shadow, opacity, easing, transform/transition, border radius.

👍


chore: use borrowed row in iter_scan()

What kind of change does this PR introduce?
This PR is to use borrowed row in iter_scan() to improve performance, see #46 .
What is the current behavior?
Currently in each call of the iter_scan() function, an empty new row needs to be created and values are copied over to Postgres, this can be slow when reading large number of rows.
What is the new behavior?
The new iter_scan() function will pass a pre-allocated row and FDW can optionally use mem::replace() to directly move data in.
Additional context
See more details in #46 .

@burmecia I took a look but memory safety stuff is over my head. I pinged @yrashk to take a look when he gets a sec
concept sounds great!

No safety issues pop out for me here, but I think there may be further room for improvement. replace_with is still a byte copy of Row. Rows are still being created, moved, and copied.
I'd suggest establishing a benchmark test and iterating over this design further. Happy to assist there.

The byte copy of row is needed anyway, the saved cost is actually the repetitive row creation and data movement from fdw instance to supabase-wrappers, use borrowed row can remove that.


order of classes on html element should not matter (in this instance)

Challenge Add Font Awesome Icons to our Buttons has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.111 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
<link href="http://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">

CatPhotoApp

      <button class="btn btn-block btn-primary">Like</button>

      <button class="btn btn-block btn-info">Info</button>

      <button class="btn btn-block btn-danger">Delete</button>

Things cats love:

cat nip

laser pointers

lasagna

Top 3 things cats hate:

flea treatment

thunder

other cats

  <form action="/submit-cat-photo">
    <input type="radio" name="indoor-outdoor"> Indoor
    <input type="radio" name="indoor-outdoor"> Outdoor
    <input type="checkbox" name="personality"> Loving
    <input type="checkbox" name="personality"> Lazy
    <input type="checkbox" name="personality"> Crazy
    <input type="text" placeholder="cat photo URL" required>
    <button type="submit">Submit</button>
  </form>

In working thru the above example I noticed that I was not able to validate my input and move to the next challenge if I changed the order of classes for the  element. In trying to apply font awesome classes of  "fa" and "fa-thumbs-up", I could not be allowed to enter  it would only allow . This could have been very frustrating to someone with less experience, although the sample does show the "fa" class first, this really shouldn't be required for the validation of this challenge, it may confuse those who think it must this way, when they work on future projects.

You're technically right (which is the best kind of right), but I don't know if we can be bothered to fix it.  Every single instance of using font awesome on the web shows them using fa fa-icon-name.  I suspect that doing it any other way would actually be really unusual.
We can probably fix the first test without too much trouble, but fixing the second would be miserable, on an already miserable test.
Did you actually have this as a real problem, or was this just you fooling around?

No, I had it as a real problem. I knew the basics of how font awesome worked and I saw the instructions, and I went ahead and added the classes in the order in which I prefer to use them, (more specific first - "fa-thumbs-up fa"), and it didn't work. I tried some other things and it didn't work. Then I thought, "What could be the issue?", and of course I looked at the example and realized that I should copy it exactly to see if that helped, which of course it did.
Yes, you are of course correct that all examples on the internet currently show the order as you have it "fa-thumbs-up fa", but that is part of the issue, where someone coming into this training might assume that is the way it has to be, instead of just the 'traditional' way of doing it. And they may never discover why.
I understand not feeling like it is worth fixing it, but I thought I could mention it so that if possible you could help save someone the trouble of beating their head against the wall for too long.
Thanks for the response.

@FreeCodeCamp/issue-moderators
Do we think this is worth fixing?

@SaintPeter There doesn't seem to be any con to leaving this open for folks who wanna contribute something, in my opinion.
Besides, in one of the CSS challenges, it said that the order of class names in HTML elements don't matter. It would be strange if it mattered now.

Ok, flagged as help wanted.
To potential PR submitters:  http://stackoverflow.com/a/2214962/1420506


chore(package): update kronos-service to version 4.17.2

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ads1x15: add cmd for ads1015 AD converter with voltage divider calculation

Add a simple cmd to show the use of the ADS1015 AD converter. I added calculation for a voltage divider which is used for example in the automation-hat. The code is taken mainly from the example_test.go but for my development it is useful to have a main.

gohci


Test kit

Refactored the common HTTP header and builder tests into a shared "test kit" framework so that alternate client implementations can be tested in the same manner without duplicating code.
Merging this into development since it's just test changes that can wait for the next release.

Coverage decreased (-0.7%) to 75.486% when pulling cea89db0b0ee2bb08fd96161fbf67e0b75ab3263 on test-kit into fdc5052bfa36ce613d5445a5f5adc8c394f96fd1 on development.


Place Portal page

\places\templates\places\place_portal_new.html
v3 localhost: http://localhost:8001/places/portal-new/
v2 example: https://whgazetteer.org/places/12346428/portal
class PlacePortalViewNew(TemplateView)

Just a layout so far. Code to arrive from search results page with necessary context is prepped, needs to be folded into other work on the search results page.

TODO:

[ ] Interlink Sources table and map features
[ ] Implement temporal filtering


pvsystem.Array.get_irradiance raises an error if solar_zenith is passed as a float

Bug Description
pvsystem.get_irradiance documentation says solar_zenith can be passed as a float or a Series. However, if dni_extra is not defined and solar_zenith is passed as float, then solar_zenith.index is not defined and the call to irradiance.get_extra_irradiance with solar_zenith.index as an argument fails.
To Reproduce
Steps to reproduce the behavior:
test_sys = pvsystem.PVSystem()
test_sys.get_irradiance(0.0, 0.0, 0.0, 0.0, 0.0)
Error message
AttributeError: 'float' object has no attribute 'index'
Expected behavior
Return a DataFrame containing the irradiance components, as specified in the documentation.
Possible solutions

Ask for datetime if dni_extra is not passed as argument
Remove float from supported types for solar_zenith

Versions:

pvlib.__version__: 0.9.0
pandas.__version__: 1.3.3
python: 3.9

Confirmed bug. Thanks @lucasschn.
The PVSystem.get_irradiance method is a convenience wrapper for irradiance.get_total_irradiance which is common front end for the set of sky diffuse models, some of which require dni_extra. Currently, PVSystem.get_irradiance uses solar_zenith.index to calculate dni_extra if the user doesn't provide dni_extra.
Here's a few options I see:

change the PVSystem.get_irradiance docstring to specify that solar_zenith (and solar_azimuth, for consistency) be Series. Not sure I like this but I like the following less:
inspect all the potential Series inputs for an index and use the first one found. Raise an error if none are found.
require dni_extra as input if solar_zenith isn't a Series
add datetime as a new parameter (trend has been to remove this kind of parameter).

I think the important goal is that PVSystem.get_irradiance remains convenient to use.

Thanks @cwhanse for the feedback. I personally find Option 3 (require dni_extra as input if solar_zenith isn't a Series) the most elegant. I could implement it and open a PR if this solution is indeed the preferred one.

Quibble: technically it is Array.get_irradiance (not PVSystem.get_irradiance) that calculates dni_extra if it is missing:
https://github.com/pvlib/pvlib-python/blob/90013a5ce43611c43224b3a2f3ef72f54ad527af/pvlib/pvsystem.py#L1468-L1469
I think I also lean towards option 3.  I think changing that condition to dni_extra is None and hasattr(solar_zenith, 'index') would result in ValueError: dni_extra is required for model haydavies, which seems ok to me.
Just curious, what's the use case for passing scalars?  I personally can't recall a case where I've used anything other than Series.

@kanderso-nrel You are right in pointing out that the invoked function  is Array.get_irradiance, but it's not possible to instantiate a simple Array with array=pvsystem.Array(), as a mount needs to be defined. That's why I used the wrapper PVSystem.get_irradiance in my simple example for reproducing the bug.
About the use case, I passed scalars whereas I was exploring the module and testing it in a Jupyter notebook, without making real calculations. I can imagine it's not a typical use case but I believe that if the documentation says it is a supported case, then it should really be :)

Most or all of the bottom layer function work with scalars and I think that's important.  May be less so for the classes, but still desirable.

In order to give clearer inputs to the user, I suggest to implement the following:
if dni_extra is None:
            if isinstance(solar_zenith, pd.Series):
                dni_extra = irradiance.get_extra_radiation(solar_zenith.index)
            elif isinstance(solar_zenith, (int, float)):
                raise ValueError('If solar_zenith is passed as a float, then dni_extra must be defined.')
            else:
                raise TypeError(f'Argument solar_zenith must be a float or a pandas Series. Currently is a {type(solar_zenith)}.')

Invalid inputs
If solar_zenith is neither a float nor a pandas Series, an error is raised:
pv_sys.get_irradiance(solar_zenith='hello', solar_azimuth=0, dni=12, ghi=43, dhi=12)

TypeError: Argument solar_zenith must be a float or a pandas Series. Currently is a <class 'str'>.
If solar_zenith is passed as a float, dni_extra must be defined and an error is raised:
pv_sys.get_irradiance(solar_zenith=0, solar_azimuth=0, dni=12, ghi=43, dhi=12)

ValueError: If solar_zenith is passed as a float, then dni_extra must be defined.
Valid inputs
If solar_zenith and dni_extra are defined, the function returns an OrderedDict:
pv_sys.get_irradiance(solar_zenith=0, solar_azimuth=0, dni=12, ghi=43, dhi=12, dni_extra=10)

OrderedDict([('poa_global', 24.0),
             ('poa_direct', 12.0),
             ('poa_diffuse', 12.0),
             ('poa_sky_diffuse', 12.0),
             ('poa_ground_diffuse', 0.0)])

If solar_zenith is passed as a pandas series, the function returns a pandas DataFrame:
tz = 'Europe/Zurich'
lat, lon = 46.2, 6.15

times = pd.date_range('2020-01-01 00:00:00', '2021-01-01', closed='left',
                      freq='H', tz=tz)
solpos = solarposition.get_solarposition(times, lat, lon)
pv_sys.get_irradiance(solar_zenith=solpos.zenith, solar_azimuth=0, dni=12, ghi=43, dhi=12)

| poa_global | poa_direct | poa_diffuse | poa_sky_diffuse | poa_ground_diffuse
-- | -- | -- | -- | -- | --
11.89816 | 0.0 | 11.89816 | 11.89816 | 0.0
11.89816 | 0.0 | 11.89816 | 11.89816 | 0.0
11.89816 | 0.0 | 11.89816 | 11.89816 | 0.0
11.89816 | 0.0 | 11.89816 | 11.89816 | 0.0
11.89816 | 0.0 | 11.89816 | 11.89816 | 0.0
... | ... | ... | ... | ...
11.89816 | 0.0 | 11.89816 | 11.89816 | 0.0
11.89816 | 0.0 | 11.89816 | 11.89816 | 0.0
11.89816 | 0.0 | 11.89816 | 11.89816 | 0.0
11.89816 | 0.0 | 11.89816 | 11.89816 | 0.0
11.89816 | 0.0 | 11.89816 | 11.89816 | 0.0

Is that the expected behavior?
If yes, then the documentation still needs a small update: the function can also return an OrderedDict, not only a pandas DataFrame.

How about
if dni_extra is None:
    try:
        dni_extra = irradiance.get_extra_radiation(solar_zenith.index)
    except AttributeError:
         raise ValueError('If dni_extra is None then solar_zenith must be a Series.')

My hesitation is that AttributeError could occur in other ways than solar_zenith missing an index.
I agree, the docstring should communicate that an OrdereDict can be returned.

*must be a Series with a DatetimeIndex.
I also like @kanderso-nrel's suggestion in https://github.com/pvlib/pvlib-python/issues/1338#issuecomment-967232590

@cwhanse looking at the documentation about Python's built-in exceptions, I don't see any other case where an AttributeError could be raised, other than solar_zenith.index not being defined. And if solar_zenith is a pandas Series, it must have an index. Am I missing something? Do you see any other caveat?

@wholmgren Yes, you are right. What about this:
if isinstance(solar_zenith, pd.Series) and isinstance(df.index, pd.DatetimeIndex):
            if dni_extra is None:
                dni_extra = irradiance.get_extra_radiation(solar_zenith.index)
        elif isinstance(solar_zenith, (int, float)):
            if dni_extra is None:
                raise ValueError('If solar_zenith is passed as a float, then dni_extra must be defined.')
        else:
            raise TypeError(f'Argument solar_zenith must be a float or a pandas Series. Currently is a {type(solar_zenith)}.')

About @kanderso-nrel's suggestion in #1338 (comment), indeed hasattr(solar_zenith, index) could be an additional check, but I don't think it replaces `isinstance(solar_zenith, pandas.Series), because (as already mentioned above):

I think there is also a risk that solar_zenith has an attribute named index without necessarily being a pandas.Series.

Therefore I would say that isinstance(solar_zenith, pandas.Series is more robust than hasattr(solar_zenith, index), but of course we could put both checks. Do you guys see a case where it could be better to user hasattr only?

You could perhaps just use the solar constant as dni_extra when all else fails.  Then you don't need to raise anything.

You could perhaps just use the solar constant as dni_extra when all else fails. Then you don't need to raise anything.

That's a good idea. Variance is at most 4%.


Add class then value is selected

Add class then value in muitiselect.vue selected, please.
For case where need change border-color if value was selected. Thx in advance.

Let's put it in your methods @select:
var e = document.getElementById('your-class')
e.classList.add('your-class-adding')

Interesting. Will think about it!

@shentao Maybe I close this?


updated and now homebridge is not starting

Describe Your Problem:
updated and now homebridge is not starting
connecting to the pi with ssh works but on commands i get Illegal instruction
Logs:
when trying to get the logs get Illegal instruction
Show the Homebridge / Homebridge Config UI X logs here.

Homebridge Config:
Show your homebridge config.json here

Screenshots:

Environment:

Node.js Version:
NPM Version:
Homebridge Version:
Homebridge Config UI X Version:
Operating System: Raspbian / Ubuntu / Debian / Windows / macOS / Docker / other
Process Supervisor: Docker / Systemd / init.d / pm2 / launchctl / hb-service / other / none

solved after upgrading node.js


Doesn't seem to work for flutter 3.16/dart 3.2.

I get issues with this package with the new flutter upgrade, i don't really know whats not working unfortunately, but here's the error messages
/C:/Users/rotek/AppData/Local/Pub/Cache/hosted/pub.dev/themed-4.0.0/lib/src/themed.dart:765:21: Error: The method 'TextStyleRef.getParagraphStyle' doesn't have the named parameter 'textScaler' of overridden method 'TextStyle.getParagraphStyle'.
ui.ParagraphStyle getParagraphStyle({
^
/C:/tools/flutter/packages/flutter/lib/src/painting/text_style.dart:1328:21: Context: This is the overridden method ('getParagraphStyle').
ui.ParagraphStyle getParagraphStyle({
^
/C:/Users/rotek/AppData/Local/Pub/Cache/hosted/pub.dev/themed-4.0.0/lib/src/themed.dart:798:16: Error: The method 'TextStyleRef.getTextStyle' has fewer named arguments than those of overridden method 'TextStyle.getTextStyle'.
ui.TextStyle getTextStyle({double textScaleFactor = 1.0}) =>
^
/C:/tools/flutter/packages/flutter/lib/src/painting/text_style.dart:1273:16: Context: This is the overridden method ('getTextStyle').
ui.TextStyle getTextStyle({
^
/C:/Users/rotek/AppData/Local/Pub/Cache/hosted/pub.dev/themed-4.0.0/lib/src/themed.dart:783:7: Error: No named parameter with the name 'textScaleFactor'.
textScaleFactor: textScaleFactor,
^^^^^^^^^^^^^^^
Target kernel_snapshot failed: Exception

(because of update)


Move Linux CI builds off travis-ci.org

This change was anticipated, but our builds are no longer running:

Since June 15th, 2021, the building on travis-ci.org is ceased. Please use travis-ci.com from now on.

We need to move those to either .com, where we think we'll run out of free minutes pretty quickly; or to github actions; or to some other free CI - circleci has a "free credits" system, like travis-ci now has.

Hmm. Let's try travis-ci.com and see if the "free minutes is sufficient"?

Sure. There's AppVeyor too... we didn't pursue them further because they already limited stuff more than the old travis-ci

This is done, right?

Yup!


有没像ng-select2一样的下拉多选搜索

I'm submitting a...

[ ] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Support request => Please do not submit support request here

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Angular version: X.Y.Z

ng-zorro-antd version: X.Y.Z

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] IE version XX

For Tooling issues:
- Node version: XX
- Platform:

Others:

please read the doc
https://ng.ant.design/#/components/select


Export mock client

Export the mock client and json fixtures, so other apps (eggl, rested, core) can all use the same mock client.
Step one of card 4414.

Coverage increased (+5.2%) to 90.0% when pulling 99265813f26bfa071e586968326511c3f5c3d902 on export_mock_client into c9dd6e94ee2cdbfab9ee13a7a76dd5efc459041f on master.

Coverage increased (+5.2%) to 90.0% when pulling aad81f1fdfaf0984a928f01fa97660e2cd7807a7 on export_mock_client into 7335030a84a95b83f52bdbdab37c00aa524d3f41 on master.

Coverage increased (+5.2%) to 90.0% when pulling b9ad77b2f960356e55933a4b97651ac535ba8234 on export_mock_client into 7335030a84a95b83f52bdbdab37c00aa524d3f41 on master.

@samphilipd using mock client in other apps works 👍

LGTM with some minor feedback.
Make sure to add a simple example to the README

Coverage increased (+0.7%) to 85.542% when pulling b4cd520610fc6f93e1677ba855276666b9d5a3a4 on export_mock_client into 7335030a84a95b83f52bdbdab37c00aa524d3f41 on master.

Coverage increased (+2.9%) to 88.095% when pulling 7b9e40658662723ee0180d2f1bb3c752f29eeb81 on export_mock_client into 875fc009826a6c0999554b05fb33f399b76a8928 on master.


Concourse pipeline linting

What
Pipecleaner is a small tool I wrote to help spot concourse pipeline errors quickly before we actually run them in concourse. It was written during another story to help with refactoring pipelines and made the whole process substantially faster.
It can check for the following issues:

Resources being used in a job that have not been defined in the resources: block. (Fatal)
Resources that have been defined in the resources: block and are not used in the pipeline. (Warning)
Resources being used in an input: block that have not been get:-ted. (Fatal)
Resources that have been get:-ted and are not used in the job. (Warning)
output:s that are not used later in the job. (Warning)

By default it will exit with a nonzero exit code for any Fatal errors, and will exit with a nonzero code for Warnings if you pass the --fatal-warnings flag.
If some checks are not desired (e.g. unused outputs) they can be disabled with the --ignore-types flag.
Travis is configured to test all concourse pipelines by default, but will only fail the tests on Fatal, not Warning level errors.
How to review
Run make lint_concourse, you should see warnings for minor problems in our pipelines:
==  paas-cf/concourse/pipelines/create-bosh-cloudfoundry.yml  ==
* Unused Output: job='smoke-tests', resource='smoke-tests-log'
* Unused Output: job='performance-tests', resource='tests-results'
* Unused Fetch: job='generate-cf-secrets', resource='concourse-tfstate'
* Unused Fetch: job='generate-cf-secrets', resource='vpc-tfstate'

==  paas-cf/concourse/pipelines/destroy-microbosh.yml  ==
* Unused Fetch: job='bosh-init-delete', resource='bosh-tfstate'

Who can review
Someone who isn't @jonty.

If this tool is used in an automated process then we should run it with the --fatal-warnings flag, otherwise we would not be forced to clean up code which is sub-standard. Exiting non-zero for warnings seems more like a default behaviour for something called a 'cleaner'.

The documentation for this script seems to only exist in the PR and commit message. Is there a more visible place for it?

@HenryTK:

I have not turned on --fatal-warnings as we currently have ~5 warnings in our main manifests and I want to get this merged before fixing them. Also, one of the warnings is non-trivial to fix (Unused Output: job='smoke-tests', resource='smoke-tests-log') as it is due to a shared file between jobs.
I was going to write a README.md for it, but that would involve moving it to another directory or repo. Suggestions on where it can live are welcome - perhaps I should just add a large docblock to the head of the file?

@Jonty:

Reasonable. You can disregard my comment. It came from a worry that these useful warnings will just become ignored if we only use the script via Travis. We as developers always have the option of running it manually for quality control.
A docblock should suffice. README.md may be a bit overkill.

@HenryTK I've added doc to the top of pipecleaner.py, does that look ok?

@Jonty: looking good.


UUID package moved

Project hosting on code.google.com shutdown on January 25, 2016. This package was migrated to github.com

@froz - thanks for the update.


Preserve selection

Hi,
How to preserve selection rows when use pagination with ajax?

https://github.com/OneWayTech/vue2-datatable/issues/63

Marked as an unresolved bug


Creating LCE compatible TFLite iOS apps

TFLite provides a collection of example mobile apps for specific DL applications. We already have a setup in place to build LCE Lite AAR to support Android (see #238) . No process (and documentation) is currently in place to support iOS. what needs to be done:

[ ] setting up the LCE build process for iOS
[ ] building the LCE Lite package with integrated LCE custom operators for iOS
[ ] integrating the LCE Lite for iOS in one of TF Lite example apps and test on an iOS device

to setup the LCE build process for iOS, first we need to create a LCE C API library similar to TF Lite C API. The LCE C API will be used in TensorFlow Lite for iOS and its swift interface.

I have this working locally, and will make a PR to add support.


Randomized scheduler branch

This schedules dash to run at different randomly selected times over the hour.
Maybe there should be a new branch for testing this.

utACK

Question: Is there a danger that sentinel runs overlap each other? Is that a problem? And if locks are used, can that end up stacking sentinel instances up?
I randomized sentinel runs just by adding random sleep to my crontab call. Crude, but worked. But I always had to ensure the baseline (non-random) schedule was a larger interval than the random component. Why? Because I didn't know what the behavior was if you ran multiple sentinel instances.
Has the overlapping sentinel instance scenario been vetted?

The randomized scheduler doesn't cause runs to overlap.  sentinel is still invoked by cron every 1 or 2 minutes but if the time at invocation doesn't match the schedule it simply exits without doing any work.
As far as other cases where more than one sentinel instances attempt to run at the same time there is an existing protection mechanism to prevent that.
In any case it looks like this PR will likely be closed in favor of a different implementation by @nmarley .

Closing in favor of PR #8.


[ISSUE #1138]Deprecate admin interface exposed in producer/consumer

What is the purpose of the change
Simplify Producer and Consumer to avoid potential risks mentioned in this issue
Brief changelog
（1）Deprecate admin interface exposed in producer/consumer
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.005%) to 49.47% when pulling 7d7d886a8d97f1f2357b72c07f5f91879c3cafdd on duhenglucky:issue_1138 into b80c26292d1e1424b4246f525bcf1a6e8b96399a on apache:develop.

LGTM


chef-provisisioning does not work with new license acceptance framework

chef-provisioning itself works fine on chef15, however bootstrapping nodes with v15 from omnibus will currently fail due to the new license acceptance requirement on the clients.  three workarounds:

set :convergence_options/:chef_version = 14
change chef_command to "chef-client --accept-license" so that the first chef run does this
custom install.sh which runs with the accept license parameter and/or copies a license

See https://github.com/chef/chef-provisioning/pull/625/files


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_588ac459-6147-4e9c-ae4f-1b884f91c09a/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_588ac459-6147-4e9c-ae4f-1b884f91c09a.git

Docs Build status updates of commit 8b177da:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-ServiceAccountCannotAccessRepository] Your repository https://github.com/VSC-Service-Account/docs-archive-test-source has enabled Docs Build service account. It seems that at least one of the accounts, e2ebd2, does not have Read permission to the repo. Please ask your repo admin to grant correct permission to service accounts (refer to this document: https://review.docs.microsoft.com/en-us/engineering/projects/ops/engdocs/how-to-grant-service-account-permission-in-your-repository?branch=master#ops-e2e-ppe) and then retry the build. Don't know who to contact? Refer https://repos.opensource.microsoft.com/VSC-Service-Account/repos/docs-archive-test-source/permissions/ to get admin list of the repo if the repo is in one of the organizations Microsoft owns.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


run fmt on vscode ext

Ran the formatter on vscode extension.
It should fix the CI

This change is

@spapinistarkware 🙏

"Some checks were not successful
1 failing and 14 successful checks"
The one failing was
"VSCode Cairo Extension CI / format and lint (pull_request)"
Just ran
npm run fmt
on the vscode extension to fix it.


instant.io broken in firefox nightly

I get following in the console:
TypeError: asm.js type error: expecting argument type declaration for 'e' of the form 'arg = arg|0' or 'arg = +arg' or 'arg = fround(arg)'
Then when it tries to hash a file:
AssertionError: false == true
I guess it might be related to this: https://github.com/subrosa-io/subrosa-client/issues/39

The asm error appears to only be a warning. I opened an issue on Rusha (https://github.com/srijs/rusha/issues/27). The site still works for me, and I can send/receive files from Firefox. I'm seeing an error when trying to receive a file in Firefox (NS_ERROR_UNEXPECTED). Is that what you see?
What file are you attempting to hash? How big is it?

I try to create a torrent by giving the app a file to hash via the browse button. It shows "Creating .torrent file..." but nothing happens afterwards. With current nightly build I get: "Error: Invalid torrent identifier" in bundle.js or "AssertionError: false == true".

Fixed the asm.js warning, see: https://github.com/feross/webtorrent/issues/281
Still unsure about the other error.

Yes, the asm warning is fixed indeed: Console says "Successfully compiled asm.js code (total compilation time 5ms; not stored in cache (too small to benefit))".
But creating a torrent still doesn't work. I still get "AssertionError: false == true" in . Perhaps it's a firefox issue in the end.

I released new versions of webtorrent-tracker and webtorrent-swarm to fix this issue. Please try https://instant.io one more time and confirm that it's working now.

If it's not working, please leave a comment and I'll re-open.

Unfortunately this doesn't seem to have fixed the issue. Creating a torrent hangs somewhere in the process and I still get the "AssertionError: false == true" message.

How large is the file you're using?
On Wed, Mar 18, 2015 at 1:50 AM beingalink<EMAIL_ADDRESS>wrote:

Unfortunately this doesn't seem to have fixed the issue. Creating a
torrent hangs somewhere in the process and I still get the "AssertionError:
false == true" message.
—
Reply to this email directly or view it on GitHub
https://github.com/feross/instant.io/issues/22#issuecomment-82824993.

I tried files starting from a few KBs to a few (<5) MBs.

Can you email me the files you're using<EMAIL_ADDRESS>I can't seem
reproduce the issue on my end.
On Wed, Mar 18, 2015 at 2:42 AM beingalink<EMAIL_ADDRESS>wrote:

I tried files starting from a few KBs to a few (<5) MBs.
—
Reply to this email directly or view it on GitHub
https://github.com/feross/instant.io/issues/22#issuecomment-82854270.

I just sent you 2 small test files but I doubt it's about the files I used. If it works for you with current firefox nightly build, I guess it might be an issue with the mac version (I'm on a macbook) or some setting I use.

I just tested on FirefoxDeveloperEdition from 03-18 and it works fine there.

Oh, you should disable "Electrolysis" in Firefox Nightly since it breaks
all kinds of things.
https://wiki.mozilla.org/Electrolysis#Enabling_and_Disabling_Electrolysis
See if that fixes the issue in Nightly for you.
On Wed, Mar 18, 2015 at 3:05 AM beingalink<EMAIL_ADDRESS>wrote:

I just tested on FirefoxDeveloperEdition from 03-18 and it works fine
there.
—
Reply to this email directly or view it on GitHub
https://github.com/feross/instant.io/issues/22#issuecomment-82864620.

I already tried with and without e10s enabled. That doesn't seem to make any difference. I even cleared the cache and shift reloaded several times but this doesn't help.

I just checked the console with e10s disabled. There's a different error message now: "Error: Invalid torrent identifier" in "bundle.js:4:334". Perhaps that helps you to identify the issue.

Looks like Fx Nightly broke something, my guess is that they broke the crypto.subtle api which does sha1 hashing when on https: origins. It works in all other versions of Fx.

I filed a bug on bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1145058

Seems like the bug has been fixed.

Yep – thanks for finding and filing the issue!


Update markdown-links-verifier to 0.1.0

Changes:

Validate heading links. See PR #71.

Closing as this version seems buggy 😕


Trouble with latest ctrulib

I get this, trying to compile CTRXplorer with citrus:
c:/devkitPro/citrus/lib\libcitrus.a(gpu.o): In function ctr::gpu::safeWait(GSPGPU_Event)': C:\GitHub\citrus/source/citrus/gpu.cpp:516: undefined reference to gspEvents'
collect2.exe: error: ld returned 1 exit status
make: *** [output/CTRXplorer.elf] Error 1
gspEvents is not in a visible interface (anymore), so that's where that problem most likely comes from:
https://github.com/smealum/ctrulib/blob/master/libctru/source/services/gspgpu.c#L18

Fixed.


firestore: create-if-missing still supported

This WriteOption is obsolete.
/cc @schmidt-sebastian

@jba This already exists as #4111. Which issue would you like to close?

This one.


[BUG] Unpredictable resources usage in AWS Lambda

chrome-aws-lambda Version:6.0.0
puppeteer-core Version:6.0.0
Lambda : nodejs12

Each time with testing the lambda the 'Max memory used' stats is increased even though the input is the same per start. When the code uploaded lambda hits the lowest max memory value (around 550 MB) and increases with each next test up to 750 MB.
The browser starts with the following parametres:
let browser = await chromium.puppeteer.launch({
args: chromium.args,
defaultViewport: chromium.defaultViewport,
executablePath: await chromium.executablePath,
headless: true
});

But there are still interesting why the difference is so unpredictable. Especially that the first run is always the lowest and all others are using more memory.

I also see a steady increase in memory usage with warm lambdas,


Bump the version on master post-release

The idea is, the master branch would have the version of the next major release. Ie. the next target.
Eg. If the latest released version is 0.2.4 the master branch should be versioned 0.3.0.
Any minor release should be forked off of 0.2.4. Sometimes the minor/major specific changes might be intertwined. If a clean separation isn't possible, all the changes would be going out in the next major release.
A significant advantage of this is that the code on the master branch would be considered a different version on its own, and any packages depending on the master for development will be forced to take the new version into consideration.
This can wait until 0.3.1 is out. Post releasing 0.3.1 we can bump the version.
@harendra-kumar @wismill

We can bump the version on master to ensure we are not using a released one, but following you example I would bump only to 0.2.5 and not to 0.3.0, unless we included a backward-incompatible change (see PVP).
Note that 0.3.1 has been released on September 28th. So we could bump master to 0.3.2. Then:

Merge #92.
We should then have 0.4.0 on master.
Make a 0.4.0 release.
Bump to 0.4.1 on master.

The idea of bumping the major version is that the folk importing the package from the master are well aware of the change as they would need to bump the major release version.
It is possible that our changes may not include any breaking changes. Even then, the set of major targets that we should be working on post-release, although internal, can be considered large enough for bumping the major release version.
I believe it is OK to bump the major version even without a breaking change.
If it is a minor change, like, updating some version bounds or some minor fixes that we need to push to the previous release, we can possibly branch off the last release and apply those changes.
I am not very fixated on this workflow if there is a better alternative. Your input is highly appreciated.
GHC bumps its major version twice. Once, post-release (odd number) for master (unstable). Once before release (even number) for any stable distribution.
@wismill

Looking at https://github.com/composewell/unicode-data/issues/82#issuecomment-1259014101
We can bump B on the master post-release. We should still avail of all the PROs you mentioned.

@adithyaov We can try. I propose #96 to facilitate the process.


[ie/AfreecaTV] downgrade api protocol to http

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

AfreecaTV's vod API is not compatible with the TLS v1.2 cipher option used by yt-dlp.
Rather than modifying the cipher in yt-dlp core to solve the problem, I think it would be simpler to use HTTP for AfreecaTV's Vod API. Therefore, this is a patch that downgrades existing API requests from https to http.
I will submit a PR to revert this commit when the API server problem is resolved.
Fixes #8187
Template

Before submitting a pull request make sure you have:

[X] At least skimmed through contributing guidelines including yt-dlp coding conventions
[X] Searched the bugtracker for similar pull requests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[X] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[X] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

I'm not a fan of downgrading the request. The user may be passing cookies, and this would invite security issues.
What about using impersonation (via curl_cffi) instead?
diff --git a/yt_dlp/extractor/afreecatv.py b/yt_dlp/extractor/afreecatv.py
index bcfb02cb9..7e628396f 100644
--- a/yt_dlp/extractor/afreecatv.py
+++ b/yt_dlp/extractor/afreecatv.py
@@ -189,7 +189,7 @@ def _real_extract(self, url):
             headers={'Referer': url}, data=urlencode_postdata({
                 'nTitleNo': video_id,
                 'nApiLevel': 10,
-            }))['data']
+            }), impersonate=True)['data']

         error_code = traverse_obj(data, ('code', {int}))
         if error_code == -6221:

@bashonly how about adding require_impersonation=True?
I think it would be nice to make it so that the user can explicitly know that it won't work without curl_cffi.

how about adding require_impersonation=True?
I think it would be nice to make it so that the user can explicitly know that it won't work without curl_cffi.

It can work without curl_cffi, though, if the user passes --legacy-server-connect. curl_cffi may not be available for all users (e.g. architectures not supported by curl_cffi or linux_exe build users).
If the user does not have curl_cffi installed and require_impersonation=False, then the user will first get a warning that if they encounter errors they should install curl_cffi, and then the SSL cipher error will also let them know they can pass --legacy-server-connect as a workaround.

Thanks.


update Visual studio gitignore for qt add-in

this VisualStudio.gitignore have no ignore files for qt-vs-addin. such as moc_.cpp qrc_.cpp ui_*.h

There's a couple of details I need before closing this out:

a link to the QT add-in for VS as an intro
a link to an explanation for what these entries represent, and why they should be ignored in source control

1.Here is the wiki about QT add-in for VS :
https://wiki.qt.io/Visual_Studio_Add-in

moc_*.cpp---------http://www.qtcentre.org/threads/22644-what-is-a-moc-file
moc files are just generated files by Meta-Object-Compilor of Qt. they are similar to *.obj files for temporary during building time.
qrc_*.cpp-------------here is a link to the resource system of qt: http://doc.qt.io/qt-5/resources.html
qrc files are just  generated files by Qt-Resource-Compilor  for temporary during building time.
ui_.h------------------here is a link to the User Interface Compiler (uic) http://doc.qt.io/qt-4.8/uic.html
ui_.h  files are just generated files by UIC.exe for  temporary during building time. it represent the layout of User Interface in C++
GeneratedFiles/------------This is a folder generated by Qt VS add-in. moc,qrc,ui files are all under this folder

GeneratedFiles/
This is a folder generated by Qt VS add-in. moc,qrc,ui files are all under this folder

So does this mean GeneratedFiles/ will include all the other rules?

Reply:"So does this mean GeneratedFiles/ will include all the other rules?"
Yes,it will include all the other files I mentioned above.

Okay cool, so can we drop the other rules here and just leave GeneratedFiles/ as the only addition?
I'm not sure how I feel about linking to an SO answer which explains this rather than some official documentation, but this is a good summary:
http://stackoverflow.com/a/18930469/1363815
@arcresu thoughts?

Yes,SO answer which explains this rather than some official documentation. I agree.
OKay,We can drop the other rules here and just leave GeneratedFiles/ as the only addition,I think it is a good idea.  :+1:

Official documentation is better because it somewhat constitutes a contract, but it's not realistic to expect any official docs about this stuff to exist for every tool. SO answers or even examples of file contents are a lot better than nothing when there's no obvious official source.

OKay,We can drop the other rules here and just leave GeneratedFiles/ as the only addition

I'd be happy with that.

I'm trying to clear out the backlog of PRs here, and given the comments haven't seen a reply I'm going to close this out.
@AlexiaChen please let me know if you're interested in working together so this can get merged in.

@shiftkey  Yeah, I am here, I was interested in working together as always.

@shiftkey  Maybe, I need to repost a new PR for

OKay,We can drop the other rules here and just leave GeneratedFiles/ as the only addition

?

this PR need to delete some extra rules, we just leave only one rule of "GeneratedFiles/"

@AlexiaChen that sounds good!

@shiftkey   soooo?  so I need to repost a new PR for this as I mentioned above?

@AlexiaChen yes please!

@shiftkey   OK. Thank you from my heart


Add support for custom metrics

Users can import metricClient function from openapm and use it any of the files in app code to define custom metrics.
This function internally uses prom-client's client so the same DSL is supported.

Need to update the changelog. Will do it in the morning.


Improve isatty check

use os.isatty(sys.stdout.fileno()) is much better than sys.stdout.isatty()

Fixed:

#40
#41

Thanks for the PR, please could you explain how this is better?

The os.isatty(sys.stdout.fileno()) is do more low-level check than sys.stdout.isatty()

Why is the CI failing with io.UnsupportedOperation: fileno?

Why is the CI failing with io.UnsupportedOperation: fileno?

Weird

Let me do more test

@hugovk Just update the test_termcolor.py to make it pass the check

Thanks for the PR, please could you explain how this is better?

The os.isatty(sys.stdout.fileno()) is do more low-level check than sys.stdout.isatty()

But why is this better?

Please could you fix the mypy error?
Also it looks like some other people also check for io.UnsupportedOperation - should we do that too?
https://github.com/pdm-project/pdm/blob/99e7877c98bf9beaa8468b1e6ee3365778a63c72/install-pdm.py#L167-L170

But why is this better?
I can't explain this sorry, but it actually works better than sys.stdout.isatty(), so I think it do more deep low-level check.

Why the workflow stucked here XD

Why the workflow stucked here XD

I need to approve it for first-time contributors:

I need to approve it for first-time contributors:

XD
So I think it can be merged, how do you think of it?

Thank you!


crash in the file ocpp-config.jsn

Hi @matth-x,
I am using ESP-IDF in my project,
During the start-up flow, after mocpp_initialise, there are sequence of files opened using the spiffs filesystem ws-conn.jsn, bootstats.jsn, ocpp-config.jsn and so on.
However during subsequent restarts I'm having issues in writing content to ocpp-config.jsn. But the same issue is not observed with ws-conn.jsn, bootstats.jsn.
When I investigated further, I found that when I try to write the value into the ocpp-config.jsn (like heartbeatInterval configuration), the appication crashes sometime, when json doc of capacity 1459 is passed to the function "storeJson" in 'ConfigurationContainerFlash::save()').
Thanks to support.
Regards,
Aylaa

Hi @matth-x , is there any update on this issue? could you please prioritize.
Thank you,
Aylaa

Hi @Aylaa1,
To change configurations programatically, use the Configuration API like here:
https://github.com/matth-x/MicroOcpp/blob/735efa29805d33723d80cd351e4ca773b0d96a3e/tests/Metering.cpp#L98-L99
The first call gets a handle for the Config, the second call effectively changes its value. The same functions exist for strings and bools.
Also #include <MicroOcpp/Core/Configuration.h> to get access to the Configuration API. Perform the changes after mocpp_initialize().
Manually manipulating the contents of the JSON files is without effect after initialization of the library. And before initialization it is risky, because I do not test such interaction with the firmware.

Hi @matth-x,
Thanks you for the response,
the sequence you have mentioned is followed the same way, i.e., mocpp_initialize() is called first and later the configuration related apis.
The actual problem is when the ocpp-config.json file is reaching the size above 1024(eg 1031), the application crashes.
If I restrict the jsonCapacity to 1024  in (DynamicJsonDocument doc {jsonCapacity}), but the jsonCapacity calculated in the runtime is 1031, json file would be invalid and the application still crashes.
The crash still persists if I increase the jsonCapacity to Max json capacity(4096).
Basically I observe crash if I try to write anything more than 1024 bytes to ocpp-config.jsn file.
The problem does not occur, if I reduce the number of key-value pairs written to the ocpp-config.jsn file in such a way that the file size will not cross 1024 bytes.
(All other jsn files are below 1024 bytes except ocpp-config.jsn file, throughout the application like bootstats.jsn, ws-conn.jsn, sc-tx-1-0.jsn, ...)
PFA, the crash scenario log snips

Thanks,
Aylaa

Hi @Aylaa1,
Sorry, I'm still lacking an idea what could happen here. The most suspicious thing I see is that the application crashes due to a stack overflow. Normally, the stack stack size should rarely grow with payload data. Did you integrate a custom filesystem adapter which has payload buffers on the stack by any chance?
However, it is true that the default stack size in esp-idf is too small to run MicroOcpp. I increased it to 8192 in the example project:
https://github.com/matth-x/MicroOcpp/blob/735efa29805d33723d80cd351e4ca773b0d96a3e/examples/ESP-IDF/sdkconfig#L505


[Bug]: Github Resolver cannot push to the SAME PR

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Describe the bug and reproduction steps
It happens when you follow-up a comment on a PR: https://github.com/All-Hands-AI/OpenHands/pull/5181
See detailed Github action: https://github.com/All-Hands-AI/OpenHands/actions/runs/11959703763/job/33342073747#step:13:375
OpenHands Installation
Docker command in README
OpenHands Version
No response
Operating System
None
Logs, Errors, Screenshots, and Additional Context
No response

@openhands-agent Check the issue history - Maybe you should modify the code to automatically git pull before git push - if it fails due to exit code non-zero, be sure to send an error message via Github comment.


Bump wasmtime to 24.0.0

wasmtime 24 adds a host implementation of the wasi:config/runtime interface. Using the upstream implementation in favor of our temporary implementation.

Great to see, thanks.


bump pydantic to 2.x

pydantic v2 is out - among other things, the support for computed properties w validation looks nice, probably some other stuff too.
migration guide: https://docs.pydantic.dev/latest/migration/
Assumptions:

Acceptance Criteria
Given..., when..., then...

And convert the property setters in ModelMetadata.init to real computed properties while we're at it

Marking as blocked because there's not much we can do with the Globus Compute dependency pinned to < 2

Closing as stale - not actionable rn

globus compute relaxed their pydantic constraint, so we're free to (finally) migrate to pydantic 2.x


Opening a method that requires scrolling sometimes does not work

Searching for a method like BlElement>>#zIndex: does not scroll to the method.
Steps to reproduce
Spotter
Open the World Spotter, type BlElement>>#zIndex: followed by an enter key press.

Coder
It opens a coder with a correct class BlElement. The issue is that the method #zIndex: is not visible (scrolling does not happen).

A working example for the BlElement>>#zIndex: method.
https://user-images.githubusercontent.com/465505/233122478-5ce908c9-8572-43f9-82ec-deb6ec8ec045.mov
Another example for the BlElement>>#position:extent:context: method.
https://user-images.githubusercontent.com/465505/233122510-784018c9-4cf0-4f9d-a7b5-f80720a7ba0c.mov


Update PoeMap regexp

New map tiers were introduced for unique maps and fragments: U and F. It can be extended at any time. It is not enough to capture tiers using T\\d+.
Message example:
@From <Guild> User: I'd like to exchange my U: (Mao Kun), F: (Fragment of the Phoenix), T9: (Castle Ruins) for your U: (Poorjoy's Asylum), F: (Fragment of the Hydra), T9: (Lighthouse) in Hardcore Legion.

I just spent some time figuring out why poemaps stopped working (it uses roman numerals now), then found that this PR from months ago fixes that too.  (I used \S+ instead of .*, but it doesn't really matter.)


Failed to zfs unmount stopped container, target is busy.

 Manually unmounting it with 'zfs unmount neo-root/data/lxd-storage/containers/c1' does work after the container was stopped. I can confirm that deleting a container, is also properly destroying the filesystem. Also, upon viewing lxc info, it appears the lxc features are all disabled.
Steps to reproduce

lxc launch ubuntu:18.04 c1
lxc stop c1

Information to attach
Here is some output from daemon log.
`May  3 22:01:17 neo lxd[5239]: t=2020-05-03T22:01:17-0400 lvl=info msg="Shutting down container" action=shutdown created=2020-05-03T22:00:50-0400 ephemeral=false name=c1 project=default timeout=-1s used=2020-05-03T22:00:55-0400
May  3 22:01:38 neo lxd[5239]: t=2020-05-03T22:01:38-0400 lvl=eror msg="The stop hook failed" container=c1 err="Failed to run: zfs unmount neo-root/data/lxd-storage/containers/c1: umount: /var/lib/lxd/storage-pools/default/containers/c1: target is busy.\ncannot unmount '/var/lib/lxd/storage-pools/default/containers/c1': umount failed"
May  3 22:01:38 neo lxd[5239]: t=2020-05-03T22:01:38-0400 lvl=info msg="Shut down container" action=shutdown created=2020-05-03T22:00:50-0400 ephemeral=false name=c1 project=default timeout=-1s used=2020-05-03T22:00:55-0400`

Does 'lxc stop --force' hit the same issue?

Does 'lxc stop --force' hit the same issue?

Yes, it does.

Ah, that's somewhat unusual. We've had some cases where clean shutdown cause some processes to somehow create kernel references to files on zfs, preventing the unmount for a while until the kernel is done expiring things. But force usually doesn't hit the same issue.
In any case, we used to have retry logic for unmount when it hits EBUSY, we should probably re-introduce that and see if that helps. Ultimately this is either a legitimate issue on your system (an active process having an open file from that dataset) or more likely a kernel bug keeping such a reference.

Ah, that's somewhat unusual. We've had some cases where clean shutdown cause some processes to somehow create kernel references to files on zfs, preventing the unmount for a while until the kernel is done expiring things. But force usually doesn't hit the same issue.
In any case, we used to have retry logic for unmount when it hits EBUSY, we should probably re-introduce that and see if that helps. Ultimately this is either a legitimate issue on your system (an active process having an open file from that dataset) or more likely a kernel bug keeping such a reference.

Thank you for your time on this issue, could you refer me to some patch to add this retry logic back? Will test further. Thank you!


Standard User is able to activate/deactive node drivers

Rancher versions: 2.0 master 1/23
Steps to Reproduce:

Create a standard user
Log in as that user
Go to Node Drivers and deactivate/activate them

Results:  Can activate/deactivate drivers.

Version - 2.0 master 4/26
Verified fixed


Removed SecureRadom dep

I don't think we need this dependency anymore since it was only being used to generate a random hash to the auth_token field on users which was already removed and if we want to go back to this approach again we can use guardian or bcrypt to generate random token.

Love it!
I love deleting code!
good job!


Pluggable congestion control

As discussed in #693. ~Draft until the abstractness of the interface has been validated by the addition of at least one other controller (probably CUBIC/HyStart++).~

I think I'm okay with the config Arc now. Can you sketch what your explicit trait alternative for the factory thing would look like?
(Otherwise, things look pretty good to me, though I'll do a final pass once we figure out the factory thing.)

The explicit trait approach:
pub trait CongestionControllerFactory {
    fn new_controller(&self) -> Box<dyn CongestionController>;
}
// ...
impl CongestionControllerFactory for Arc<NewRenoConfig> {
    fn new_controller(&self) -> Box<dyn CongestionController> {
        Box::new(NewReno::new(self.clone(), Instant::now()))
    }
}

In use:
config.congestion_controller_factory(Arc::new(config));

How would the maybe_rebinding case look for that? I think it'd need a separate impl? How do you feel about current approach vs explicit trait?

(self.config.congestion_controller_factory)() would be replaced with self.config.congestion_controller_factory.new_controller(); no other changes. A trait with one method that takes &self is always algebraically equivalent to an analogous Fn.
Between the two, I'm leaning towards the explicit trait right now, because config.congestion_controller_factory(Arc::new(config)); seems like considerably less ceremony than config.congestion_controller_factory(|| Box::new(NewReno::new(config, Instant::now()))). It's more boilerplate if you want to invoke complicated custom logic, but that seems like an extremely niche case.

Cool, I think I agree.

Updated with an explicit factory trait. I also refactored things to make the congestion module public, to ease discoverability of different algorithms we add in the future, and limit growth of clutter in the root namespace.


Document how to use Capsule with GCP

Describe the feature
This issue tracks the work to document how to use Capsule in a GCP environment with GKE and GCP IAM.
What would the new user story look like?
As an adopter I'd like to understand how to setup GCP and Kubernetes resources to make Capsule work in GKE with Tenant users as Google Users.

This is a work in progress

Create/update GKE cluster enabling the Google Groups for Kubernetes RBAC GKE feature
Create a GCP IAM Group "gke-security-group"
Create a GCP IAM Group wich will be a Capsule Group, e.g.:

email<EMAIL_ADDRESS>name: capsule-group

Add the capsule-group GCP IAM Group above as a member the gke-security-group GCP IAM Group
Add the Google Users of the Capsule Tenant Owners as member of the capsule-group GCP IAM Group
Create a GCP IAM Role to enable the Tenant Owner Google Users to authenticate to GKE (and Kubernetes) with permissions:

containers.clusters.get
containers.clusters.GetCredentials

Assign IAM Role above to Tenant Owner IAM User
Create/update the used CapsuleConfiguration with as Capsule group the email of the GCP IAM Group capsule-group (i.e<EMAIL_ADDRESS>


dotnet core nuget packages outdated

The targeting of .Net Framework 4.5.2. causes problems when trying to upgrade nuget references; specifically the "Microsoft.Extensions.Logging" package which does not any longer provide "shims" for 4.5.2. It requires .Net Standard 2.0 compliancy, which is from .Net Framework 4.6.2 and onwards.
Generally there are a lot of outdated packages, and the project seems a bit stale at the moment.
I have updated the targeting to .Net Standard 2.0 and .Net Framework 4.6.2. in a pending PR which is not yet committed. The thing is that one in reality can remove all 4.6.2 specifics, as it already is .Net Standard 2.0 compliant. At least to my understanding.
The RavedDB code has a few preprocessor directives that distinguished between different API versions. Except for that the upgrade seems pretty straight forward.
Any thoughts on this? Was there a particular reason that 4.5.2 is still targeted? Anyhow; the world moves forward and protoactor need to follow along to be relevant... :)

BTW; worth mentioning that upgrading to .Net Framework 4.7.2 is recommended, even though nuget considers 4.6.1 -> to be "pretty" compliant ;)

@kenavn Thank you for remind! I'll try make a PR to strip away 4.5.2! = )

@kenavn Should be addressed in #466


Command System

Some important points we talked about:

Platform neutral code (IE allow to work with CLI / Bungeecord / Velocity etc)
Have a command context class
Ensure stability using unit tests

[ ] Base class for commands
[ ] Argument parsing hints
[ ] Serializers receive argument param context and return the context that they've used to serialize, if successful (can be validations on min max numbers or parsing settings like array start and end indicators)
[ ] Built in serializers (both java types and platform dependent types)
[ ] Return CommandResult from whole command, each platform handles differently


How to change gpu ?

This is a very good work！But when i run you cod, I find don't change gpu id?

Thanks for your issue. You can specify the GPU id when running main.py with the --GPU option.  For example, when you want to run code with GPU 2, you can use:
 python main.py --gpu 2 --[other options]


Modbus RTU 32-bit Floats Not decoded in correct order

I'm talking to a SolarEdge SE7600 on a Modbus RTU connection. When I read the CosPhi register using this library (register address 0xF002) which has a default value of 1.0 (0x3F800000) and which is reported in the RTU Modbus device reply packet as 0x010304 00003F80 EA63 the decode_32bit_float isn't correctly interpreting this as a 1.0 (probably due to inconsistencies in Modbus 32bit float conventions), but it's interpreting it 16-bitwise backwards as best I can tell. I also tried this for other registers (the handling for which haven't yet been implemented here) in the  "Technical Note – Power Control Protocol for SolarEdge Inverters" document and the results are consistent in that it appears that the 32bit floats are decoded out of order (16-bitwise backwards).

Thanks for reporting this. If you modify solaredge_modbus/__init__.py line 403 to read self.wordorder = Endian.Little, does that resolve the cosphi issue? Ignoring for a second that all the other values are then incorrect...

Thanks kindly for the prompt reply!!
I tested this and that fix does cause that specific read request to return the expected result, and doesn't appear to corrupt other reads I'm doing via this library (though since there aren't any other 32 bit reads with known values I'm not certain whether there are any other issues related to this). I haven't tried writing float values yet. I was also concerned that this issue might have been coming from an address misalignment (if the registers on both sides of the MSBs were both reading 0x0000 this could also look like that, but I'm not certain). Given that the prior register F001 1 R/W Active Power Limit Uint16 0-100 % behaves as expected I'm inclined to not think it's an address misalignment issue, however the float order I'm seeing would seem to be contrary to that reported in the Sunspec 32bit float specification: https://sunspec.org/wp-content/uploads/2015/06/SunSpec-Information-Models-12041.pdf

Thanks kindly for the prompt reply!! I tested this and that fix does cause that specific read request to return the expected result, and doesn't appear to corrupt other reads I'm doing via this library (though since there aren't any other 32 bit reads with known values I'm not certain whether there are any other issues related to this). I haven't tried writing float values yet. I was also concerned that this issue might have been coming from an address misalignment (if the registers on both sides of the MSBs were both reading 0x0000 this could also look like that, but I'm not certain). Given that the prior register F001 1 R/W Active Power Limit Uint16 0-100 % behaves as expected I'm inclined to not think it's an address misalignment issue, however the float order I'm seeing would seem to be contrary to that reported in the Sunspec 32bit float specification: https://sunspec.org/wp-content/uploads/2015/06/SunSpec-Information-Models-12041.pdf

Update, I have written and reread the CosPhi register using this library mechanism after making the suggested Endian adjustment, and it appears to behave as intended. I'll update with any further developments I see with it.

Thanks kindly for the prompt reply!! I tested this and that fix does cause that specific read request to return the expected result, and doesn't appear to corrupt other reads I'm doing via this library (though since there aren't any other 32 bit reads with known values I'm not certain whether there are any other issues related to this). I haven't tried writing float values yet. I was also concerned that this issue might have been coming from an address misalignment (if the registers on both sides of the MSBs were both reading 0x0000 this could also look like that, but I'm not certain). Given that the prior register F001 1 R/W Active Power Limit Uint16 0-100 % behaves as expected I'm inclined to not think it's an address misalignment issue, however the float order I'm seeing would seem to be contrary to that reported in the Sunspec 32bit float specification: https://sunspec.org/wp-content/uploads/2015/06/SunSpec-Information-Models-12041.pdf

Update, I have written and reread the CosPhi register using this library mechanism after making the suggested Endian adjustment, and it appears to behave as intended. I'll update with any further developments I see with it.

Thanks for the update. The other object which has float registers is the battery (starting at 0xe100). These values are read with a little endian wordorder. So it makes sense that the inverter model also uses little endian. But, as you say, there aren't that many 32bit float register to test with. Can you confirm the energy_total register still returns valid values?
Also, have you had any luck polling the other power control registers mentioned in the document you referred to?

Can you confirm the energy_total register still returns valid values?
On inspection it appears that this is NOT decoded correctly with the aforementioned wordorder set to Endian.Little, and decodes out of order as would be expected (packet reply 0x010304000000D27A6E which should be decoded as 210 is instead decoded as 13762560 as would be expected for having the wordorder set incorrectly).

However, regarding:

Also, have you had any luck polling the other power control registers mentioned in the document you referred to?

Those that my testing was aimed at primarily fall within the range 0xE000 - 0xE192 (as battery control is my main focus). Those DO appear to behave as desired across the range of registers tested. I've tested the following registers for both reading (and writing where applicable) with the wordorder = Endian.Little configuration:
0xE000
0xE004
0xE005
0xE006
0xE008
0xE00A
0xE00B
0xE00D
0xE00E
0xE010
And all seem to behave correctly (and have been exercised as such in my testing with the expected behavior registering at the inverter and measured power flow direction).


[MATLAB] Rename arrow.array.Array Length property to NumElements

Describe the enhancement requested
We would like to rename the Length property of arrow.array.Array to NumElements because MATLAB has a function called length(A), which returns the length of the largest array dimension in A.
Because arrow.array.Array inherits from matlab.mixin.Scalar, it's size is always 1x1, so the length() function always returns 1. This may confuse users because the Length property of arrow.array.Array returns the number of elements within the array, which may not be 1.
>>  array = arrow.array([1 2 3 4 5]);

% The length property returns the number of elements in the array
>> array.Length

ans =

  int64

   5

% The length method returns the length of the largest dimension
>> length(array)

ans =

     1

I suspect this inconsistency will confuse users, so we should rename the Length property to NumElements.
Component(s)
MATLAB

take


Silence unused_variables warning with empty enums

Deriving Serialize or Deserialize on Void-like enums triggered an unused_variables warning.

Thanks! Looks good. Can you add a test for this?

Where? And do we even have compile tests?

You can add a normal test and add #![deny(unused_variables)]

Oh right, good call.

@oli-obk Done.

I'm not sure if that test does what it's supposed to (you can test if it errors before your changes, then it's fine). I suggest to add the deny with a ! to the entire module to make sure nothing in the tests ever produces unused variables.

A  deny on the whole module without any specific type to test this can easily not test what really needs to be tested. And I would still need to allow dead_code because that empty enum will still not be used.
As for your first remark, that's exactly what triggered the warning in some code I wrote.

As for your first remark, that's exactly what triggered the warning in some code I wrote.

ah, wonderful


New Command Timeout triggerred on older session even if it was deleted

The problem
In our UWP tests we're deleting the previous session by calling Driver?.Close() (if it existed), then we reinstall the application via a PowerShell script and after that we create a new Driver.
All this because the ResetApp() is not implemented on WDA.
The issue is that even if we delete a previous session, at some point during the test execution, New Command Timeout is triggered on it.
As you can see in the gist https://gist.github.com/cosminstirbu/80341821dd5df91f3301411ea4f9d3bf#file-wda-new-command-timeout on line 9 session EBA4D3AF-CA65-4CD8-95A3-CF89E00DCE7F is deleted, and after a while, on line 2832 it is deleted again due to New Command Timeout of 120 seconds expired.
Environment

Appium version (or git revision) that exhibits the issue: 1.14.0
Last Appium version that did not exhibit the issue (if applicable): not applicable
Desktop OS/version used to run Appium: Windows 10
Node.js version (unless using Appium.app|exe):
Npm or Yarn package manager:
Mobile platform/version under test: UWP
Real device or emulator/simulator: Windows 10 Machine
Appium CLI or Appium.app|exe: CLI

The major issue is that after that the WDA stops and no longer accepts connections:
7/24/2019 11:13:36 AM [debug] [WinAppDriver] WinAppDriver changed state to 'stopping'
7/24/2019 11:13:36 AM [WD Proxy] Got an unexpected response: {"errno":"ECONNRESET","code":"ECONNRESET","syscall":"read"}

So none of our tests works any longer.
I've copied this from here - https://github.com/appium/appium/issues/12966

In case anyone else is running into this issue, as a temporary workaround we're passing the new command timeout a value larger than the total duration of our tests (in our case, 4 hrs in seconds).

I think this can be closed because I've recently realised (while investigating a different issue) that I was actually calling Driver.Close() which deletes the window... (which can be seen in the logs DELETE /wd/hub/session/b17b9cc0-05c5-42f7-b1d4-5bdc999239a8/window), instead of calling Driver.Quit() which delete the session...
I will close this as not a bug.


Merge pull request #1 from flleeppyy/patch-1

Patch 1
Please check if the PR fulfills these requirements:

[ ] The PR title and message describe the solution briefly.
[ ] Documentation has been updated/added if relevant

What is the current behavior?

What is the new behavior?


Change  accepted type based on the requested url

Change the accepted application type header based on the file ending in the requested url.

@B-Stefan,
Thank you for the PR. Sorry for the delay, I've just been back today.
My mind is very hazy on this API library as it's been so long ago. I will need some time to look into this and test it with the ProvStore API.
Cheers,
Dong.

@trungdong Did you had time to review the change?
I try to clean up my GitHub dashboard and PR requests ;)

@B-Stefan ,
Sorry, I completely forgot about this. Thanks for pinging me.
I've had a look at the PR and now realised that the suggested change is not for provjs, but the support file api.js.
The purpose of that file was to allow us to submit the output of provjs to the ProvStore at Southampton. I have cannot think of a case where we will need to use that file to submit content other than PROV-JSON (in the context of this repository). In addition, the Southampton ProvStore will be closed down imminently. Therefore, I don't understand the purpose of the change and am inclined to reject it.


Fix failing CI

I have updated setup.cfg to use copier instead of cookiecutter.

Closing in favor #13