[Feature Request] closeable calendar pane

I'd like to close calendar pane after choosing date range like at element.io
Add this option please.

You mean autoclose right?

Yes. Autoclose after loosing focus.

Hi, have you looked at the "Open in Menu" example here - http://vuetify-daterange.surge.sh/ ?
The daterange picker itself doesn't do any sort of handling like that. You can put this component inside any other overlay-ish component to get the same effect.
Will that do the job? let me know.
It still doesn't solve the "Select two dates to auto close" use case. If that's something you are looking for, let me know.

Hi!
I built a new version from ground up keeping simplicity of use in mind. Can you please try it out and let me know if that works for you?
P.S - I still need to add the option to pass in presets.
https://vuetify-daterange-picker.gitbook.io/docs/

Hi Praveen!
I tested version 3 and it completely solves this issue.
Date-picker is closed by default and appears after a click on the input.
Thank You!

Closing this then! :)


OpenSSL failed to nmake due to error LNK2019: unresolved external symbol _gcm_init_clmul referenced in function _CRYPTO_gcm128_init on windows with MSVC

Environment:
Windows Server 2016 + VS2017 + openssl master branch latest source code.
Issue description:
I tried to build openssl using VS2017 on Windows Server 2016. We found that openssl failed to nmake due to error LNK2019: unresolved external symbol _gcm_init_clmul referenced in function _CRYPTO_gcm128_init. It can be reproduced on latest master revision a6dd3a3. And it can build pass on revision 3b2f8c7. Could you please help take a look at this? Thanks in advance!
Repro steps:

git clone https://github.com/openssl/openssl D:\openssl\src
cd D:\openssl\src
perl Configure VC-WIN32
nmake clean
where cl.exe
nmake

log_x86_build_2.log
Actual result:
libcrypto-shlib-gcm128.obj : error LNK2019: unresolved external symbol _gcm_init_clmul referenced in function _CRYPTO_gcm128_init
libcrypto-shlib-gcm128.obj : error LNK2019: unresolved external symbol _gcm_gmult_clmul referenced in function _CRYPTO_gcm128_init
libcrypto-shlib-gcm128.obj : error LNK2019: unresolved external symbol _gcm_ghash_clmul referenced in function _CRYPTO_gcm128_init
libcrypto-3.dll : fatal error LNK1120: 3 unresolved externals
NMAKE : fatal error U1077: 'link' : return code '0x1'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\HostX86\x86\nmake.exe"' : return code '0x2'
Stop.
[command took 448 seconds]

Hi All,
Could someone look at this issue? It still can be reproduced on latest master revision.  Thanks in advance!
Thanks,
Lin

@spacelg : please send the ouput of perl configdata.pm --dump.
I remember seeing this recently too.

It's problem the same issue as here:
https://github.com/openssl/openssl/issues/10075
Also includes a workaround.

@FdaSilvaYY  Thanks for your reply. Output of perl configdata.pm --dump as below:
Command line (with current working directory = .):
C:\Perl\bin\perl.exe Configure VC-WIN32

Perl information:
C:\Perl\bin\perl.exe
5.24.1 for MSWin32-x86-multi-thread-64int

Enabled features:
aria
asm
async
autoalginit
autoerrinit
autoload-config
bf
blake2
camellia
capieng
cast
chacha
cmac
cmp
cms
comp
ct
deprecated
des
dgram
dh
dsa
dso
dtls
dynamic-engine
ec
ec2m
ecdh
ecdsa
engine
err
filenames
fips
gost
idea
legacy
makedepend
md4
mdc2
module
multiblock
nextprotoneg
pinshared
ocb
ocsp
padlockeng
pic
poly1305
posix-io
psk
rc2
rc4
rdrand
rfc3779
rmd160
scrypt
seed
shared
siphash
siv
sm2
sm3
sm4
sock
srp
srtp
sse2
ssl
static-engine
stdio
tests
threads
tls
ts
ui-console
uplink
whirlpool
tls1
tls1-method
tls1_1
tls1_1-method
tls1_2
tls1_2-method
tls1_3
dtls1
dtls1-method
dtls1_2
dtls1_2-method

Disabled features:
ktls                    [default]   OPENSSL_NO_KTLS
afalgeng                [not-linux]
asan                    [default]   OPENSSL_NO_ASAN
buildtest-c++           [default]
crypto-mdebug           [default]   OPENSSL_NO_CRYPTO_MDEBUG
crypto-mdebug-backtrace [default]   OPENSSL_NO_CRYPTO_MDEBUG_BACKTRACE
devcryptoeng            [default]   OPENSSL_NO_DEVCRYPTOENG
ec_nistp_64_gcc_128     [default]   OPENSSL_NO_EC_NISTP_64_GCC_128
egd                     [default]   OPENSSL_NO_EGD
external-tests          [default]   OPENSSL_NO_EXTERNAL_TESTS
fuzz-libfuzzer          [default]   OPENSSL_NO_FUZZ_LIBFUZZER
fuzz-afl                [default]   OPENSSL_NO_FUZZ_AFL
md2                     [default]   OPENSSL_NO_MD2 (skip crypto\md2)
msan                    [default]   OPENSSL_NO_MSAN
rc5                     [default]   OPENSSL_NO_RC5 (skip crypto\rc5)
sctp                    [default]   OPENSSL_NO_SCTP
ssl-trace               [default]   OPENSSL_NO_SSL_TRACE
trace                   [default]   OPENSSL_NO_TRACE
ubsan                   [default]   OPENSSL_NO_UBSAN
unit-test               [default]   OPENSSL_NO_UNIT_TEST
weak-ssl-ciphers        [default]   OPENSSL_NO_WEAK_SSL_CIPHERS
zlib                    [default]
zlib-dynamic            [default]
ssl3                    [default]   OPENSSL_NO_SSL3
ssl3-method             [default]   OPENSSL_NO_SSL3_METHOD

Config target attributes:
AR => "lib",
ARFLAGS => "/nologo",
AS => "nasm",
ASFLAGS => "",
CC => "cl",
CFLAGS => "/W3 /wd4090 /nologo /O2 /WX",
CPP => "\$(CC) /EP /C",
HASHBANGPERL => "/usr/bin/env perl",
LD => "link",
LDFLAGS => "/nologo /debug",
MT => "mt",
MTFLAGS => "-nologo",
RANLIB => "CODE(0x25d6ac4)",
RC => "rc",
aroutflag => "/out:",
asflags => "-f win32",
asm_arch => "x86",
asoutflag => "-o ",
bin_cflags => "/Zi /Fdapp.pdb",
bin_lflags => "/subsystem:console /opt:ref",
bn_ops => "BN_LLONG",
build_file => "makefile",
build_scheme => [ "unified", "windows", "VC-common", "VC-WOW" ],
cflags => "/Gs0 /GF /Gy /MD",
coutflag => "/Fo",
cppflags => "",
defines => [ "OPENSSL_SYS_WIN32", "WIN32_LEAN_AND_MEAN", "UNICODE", "_UNICODE", "_CRT_SECURE_NO_DEPRECATE", "_WINSOCK_DEPRECATED_NO_WARNINGS" ],
disable => [  ],
dso_cflags => "/Zi /Fddso.pdb",
dso_scheme => "win32",
enable => [  ],
ex_libs => "ws2_32.lib gdi32.lib advapi32.lib crypt32.lib user32.lib",
includes => [  ],
ldoutflag => "/out:",
lflags => "",
lib_cflags => "/Zi /Fdossl_static.pdb",
lib_cppflags => "",
lib_defines => [ "L_ENDIAN" ],
module_cflags => "",

Use of uninitialized value $x in substitution (s///) at configdata.pm line 16561.
Use of uninitialized value $x in concatenation (.) or string at configdata.pm line 16561.
module_cxxflags => "",
module_ldflags => "/dll",
mtinflag => "-manifest ",
mtoutflag => "-outputresource:",
perl_platform => "Windows::MSVC",
perlasm_scheme => "win32n",
rcoutflag => "/fo",
shared_cflag => "",
shared_defflag => "",
shared_defines => [  ],
shared_ldflag => "/dll",
shared_rcflag => "",
shared_target => "win-shared",
sys_id => "WIN32",
thread_defines => [  ],
thread_scheme => "winthreads",
unistd => "<unistd.h>",
uplink_arch => "common",
Recorded environment:
AR =
ARFLAGS =
AS =
ASFLAGS =
BUILDFILE =
CC =
CFLAGS =
CPP =
CPPDEFINES =
CPPFLAGS =
CPPINCLUDES =
CROSS_COMPILE =
CXX =
CXXFLAGS =
HASHBANGPERL =
LD =
LDFLAGS =
LDLIBS =
MT =
MTFLAGS =
OPENSSL_LOCAL_CONFIG_DIR =
PERL =
RANLIB =
RC =
RCFLAGS =
RM =
WINDRES =
__CNF_CFLAGS =
__CNF_CPPDEFINES =
__CNF_CPPFLAGS =
__CNF_CPPINCLUDES =
__CNF_CXXFLAGS =
__CNF_LDFLAGS =
__CNF_LDLIBS =

Makevars:
AR              = lib
ARFLAGS         = /nologo
AS              = nasm
CC              = cl
CFLAGS          = /W3 /wd4090 /nologo /O2 /WX
CPP             = $(CC) /EP /C
CPPDEFINES      =
CPPFLAGS        =
CPPINCLUDES     =
CXXFLAGS        =
HASHBANGPERL    = /usr/bin/env perl
LD              = link
LDFLAGS         = /nologo /debug
LDLIBS          =
MT              = mt
MTFLAGS         = -nologo
PERL            = C:\Perl\bin\perl.exe
RANLIB          = ranlib
RC              = rc
RCFLAGS         =

NOTE: These variables only represent the configuration view.  The build file
template may have processed these variables further, please have a look at the
build file for more exact data:
makefile
build file:
makefile

build file templates:
Configurations\common0.tmpl
Configurations\windows-makefile.tmpl
Configurations\common.tmpl

Thanks,
Lin

I can confirm https://github.com/openssl/openssl/issues/10075#issuecomment-542722966 .
Running Configure with -DOPENSSL_IA32_SSE2 :
perl Configure ... -DOPENSSL_IA32_SSE2
fix Visual Studio builds.

I confirm that #10222 fully fix this issue, with commit
de1581988f4a6b6e25f1e01474c63dc55f004c2a :  "windows-makefile.tmpl: Convert all /I and /D to -I and -D"

Cool.  Closing this


refactor: generate receive

Signed-off-by: Goren G<EMAIL_ADDRESS>Proposed changes in this pull request

make sure all accounts opened

Type

[x] Bug fix: (Link to the issue #{issue No.})
[ ] Feature (Non-breaking change)
[ ] Feature (Breaking change)
[ ] Documentation Improvement

Checklist
Write a small comment explaining if its N/A (not applicable)

[x] Read the CONTRIBUTION.
[x] All the tests are passing after the introduction of new changes.
[x] Added tests respective to the part of code I have written.
[ ] Added proper documentation where ever applicable.
[x] Code has been written according to Golang-Style-Guide

Duplicate of #20


Support pluggable network protocol

Resolves #107
Listen() now takes in a net.Listener

See https://github.com/perlin-network/noise/pull/131 on getting travis CI to pass

Is this ready for review? Can't seem to pass the test

closing for now working on perlin-go


Consider making Codec error an associated type

It doesn't make much sense that every Codec's decode method returns io::Result, given that the vast majority of Codecs shouldn't be performing any IO at all, but might instead return application-specific encoding/decoding errors.

The use of io::Result here is related to the fact that codecs are used in the transport layer of protocols, which currently operates entirely in terms of I/O errors; it is, after all, the I/O layer. It's possible to embed custom errors into I/O errors.
Part of the impetus for sticking with I/O errors, also, is the fact that tokio-proto requires the transport layer to generate I/O errors. I think we should make a change here only if we also change tokio-proto. It's not clear to me offhand how painful such a change would be in practice.
@Ralith, if you felt like exploring a PR against tokio-proto generalizing the transport error type, just so we could gauge the fallout, that's be helpful!

The use of io::Result here is related to the fact that codecs are used in the transport layer of protocols, which currently operates entirely in terms of I/O errors; it is, after all, the I/O layer.

Be that as it may, the responsibilities of Codec in and of itself have nothing to do with I/O per se at all. As far as I can tell, most reasonable implementations will never produce a real I/O error, although some may instead produce some sort of higher-level decoding error. My current uses of Codec can't even produce any errors at all, but this API forces me to place misleading unwrap calls wherever they're used.

It's possible to embed custom errors into I/O errors.

If the intention is to have the user package an arbitrary error value in a heap-allocated trait object, rather than to expose genuine system-produced errors, why not represent that accurately by using Box<Error + Send + Sync> or something instead? IMO encouraging people to stuff everything into a single universal type like this is severely unidiomatic, but if that's what the design calls for, it would be much clearer to be up front about it.

Part of the impetus for sticking with I/O errors, also, is the fact that tokio-proto requires the transport layer to generate I/O errors. I think we should make a change here only if we also change tokio-proto. It's not clear to me offhand how painful such a change would be in practice.

If Codec is intended to serve the needs of tokio-proto over the needs of tokio-core users in general, wouldn't it be better for it to be part of that library instead of tokio-core, with tokio-core instead having a more general helper? That might be a good opportunity to unbundle encoding and decoding, too.

@Ralith, if you felt like exploring a PR against tokio-proto generalizing the transport error type, just so we could gauge the fallout, that's be helpful!

I've never used tokio-proto. I might take a look if I get the time (I expect it's just a matter of introducing enum TransportError<T> { Io(io::Error), Transport(T) }), but mainly I'm concerned about tokio-core's API suffering for the sake of a downstream library that may not even be in use in any given tokio-core using project.

I agree with @Ralith. The error type should be associated. I need to pass my own errors and don't want to put them behind Box<Error + Whatever>.

As another data point, I perform serialization/deserialization with bincode in the codec, and right now I propagate deserialization errors by doing type In = Result<Decode, bincode::Error>;, which seems hacky. It also feels hacky to return io::Error::new(io::ErrorKind::Other, serialize_error) when serialization fails.

Done upstream in tokio-io: https://github.com/tokio-rs/tokio-io/issues/12


gaphor: mark as broken

Motivation for this change
Application is broken because of the updated dependencies. Still not able to package the newest version.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Was able to find a way to find the icons from the application. PR is located at #161856. Closing this one.


Link does not display a button

Link
does not display a button. I except to see the default button.
Link
works of course but the is no way to display the "default" button as we can with a "button" tag.

Thanks

bootstrap doesn't aim to replicate the default vanilla look of a <button> - particularly as that is browser/platform dependent, so that wouldn't be possible in any case.


[9.x] Add Custom Path to Env Encryption Command and Add Test

This PR proposes 1 new argument for commands; env:encrypt and env:decrypt which provide custom path of environment file.
Why? because sometime developers located their .env for staging / production for CI on another folders instead of base project path.
We may utilise our own path by using the --path option.
php artisan env:encrypt --path=docker/dev/environment --key=abcdefghijklmnopabcdefghijklmnop

php artisan env:decrypt --path=docker/dev/environment
php artisan env:decrypt --path=docker/dev/environment --key=abcdefghijklmnopabcdefghijklmnop

I added tests for this PR

Why? because sometime developers located their .env for staging / production for CI on another folders instead of base project path.

That's not supported.

I don't think this approach is necessary - the command could be updated to call $app->environmentPath() to get the path instead of hard-coding base_path though.


Suppress StackTrace and add logging when pub key can't be recovered

Hello ... sometimes we saw in logs the next error
vert.x-eventloop-thread-1 | ERROR | VertxPeerDiscoveryAgent | Encountered error while handling packet
java.lang.IllegalArgumentException: Could not recover public key
at org.hyperledger.besu.crypto.SECP256K1.recoverFromSignatureNative(SECP256K1.java:495)
at org.hyperledger.besu.crypto.SECP256K1.recoverPublicKeyFromSignature(SECP256K1.java:370)
at org.hyperledger.besu.ethereum.p2p.discovery.internal.Packet.(Packet.java:90)
at org.hyperledger.besu.ethereum.p2p.discovery.internal.Packet.decode(Packet.java:126)
at org.hyperledger.besu.ethereum.p2p.discovery.VertxPeerDiscoveryAgent.lambda$handlePacket$6(VertxPeerDiscoveryAgent.java:221)
at io.vertx.core.impl.ContextImpl.lambda$executeBlocking$2(ContextImpl.java:313)
at io.vertx.core.impl.TaskQueue.run(TaskQueue.java:76)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Unknown Source)
This traces appears a lot of time and very quickly, but later dissapears and Besu back to works well. Any idea about this trace?

We think we fixed this with a released version, re-open if it's not working.
https://github.com/hyperledger/besu/issues/2143


Fix typo

a -> an

@changeworld : Thanks for your contribution! The author, @KumudD, has been notified to review your proposed change.

Verified editorial corrections


Using Intel GPUs with Microshft

Identify Intel GPUs supporting Microshift - Intel hardware suitable for edge devices.
Try out the installation and document the steps needed (e.g if any special drivers installation is required during installation etc.)

Let's break down between  Discrete vs Integrated GPU as well.


test: 100% coverage

Hello @bagxi! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tests/test_factory.py:

Line 103:1: E302 expected 2 blank lines, found 1

In the file tests/test_functional.py:

Line 370:1: E303 too many blank lines (3)


changed int64 values to float64

Seems the latest version of the unifi api is returning float values now, and not integers. Tested with the stable RC of 5.5.9.

LGTM


Incomplete PR to support new RF and SeleniumLiumrary

Should not be pushed to master. Only some experimental code how to fix plugin to support RF and SL.

Hi, what should be done about this PR, please?

Well work from someone. Also there is #231 which takes the work further. I think in this point I would stop supporting Python 2 and support only Python 3.
In reality this project would need new maintainer. Robot Framework has syntax has changed quite a lot and most likely will change more in the future releases. Also the new parser in RF 3.2 offers new possibilities and work done for supporting language server protocol, https://langserver.org/ is also tempting. Would you happen to know if someone is interested?

@aaltat While I do understand issues, branches and PRs and can somewhat comprehend diff + code review concepts and testing a branch out to see if it works, I don't have enough of an understanding of Sublime Text 3, Robot Framework or the languages these are running in, to be an actual, useful maintainer.

Well, I could say: When I started my maintenance sift for the plugin, I don't have either. I was driven by a need and rest can be learned along the way.


Support multiple source/target Document in camel-atlasmap

An option I have in mind is here:

Source mapping

If IN message body is a Map, then take those keys as docId and put corresponding values as Document
Otherwise, put the IN message body as a default source Document, and look for others in IN message headers.

Target mapping

If IN message body was a Map, then just put the target Documents into Map and put that Map as an OUT message body
Otherwise, put the default target Document into OUT message body and others into OUT message headers

The option forceTargetDocumentsAsMapBody could be added in case it doesn't want to populate OUT message headers anyway.

go with #67 anyway


Non-latin words support

Currently receipt only shows lating words in top words. Can we maybe somehow use unicode aware regex or somehow else allow words with non-latin characters to be shown in results. By unicode aware I mean using u  flag:
https://mathiasbynens.be/notes/es6-unicode-regex
UPD: sorry, I'm not familiar with JS much, and looks like this flag does not affect \w  so some other solution should be used )=

Yup, great idea. Thanks for pointing out that obvious oversight. I'll fix it soon.

You make a good point, I can filter 1 letter words, my only concern being some languages like Japanese may have some 1 letter kanji characters that express a whole meaningful phrase by itself. 2 letters being more risky when they can even make a complete sentence.
I will go ahead and exclude 1 letter characters for now as I do think it provides more meaningful insights for the majority of users anyways

yeap 1 symbol word exclusion may totally not work for some languages, so it might be required to differentiate different symbols...
In any case: thanks for quick fix, initial issue is resolved and common words is a completely different thing

@wriddhi minor followup: in the upcoming stopwords==3.1.2 there will be a lot more Ukrainian stopwords, so ukrainian "Favorite words" should become better after that
https://github.com/fergiemcdowall/stopword/releases/tag/v3.1.2

@imposeren absolutely, I'll keep an eye on their next release


Using depends_on_past in conjunction with trigger_rule='all_done'

It seems that depends_on_past will override a task's trigger_rule='all_done' if the task instance of the previous day has failed. Is that the case and expected behavior?

depends_on_past mean "Don't move forward if the previous schedule has not succeeded, unless this current run is the the start_date". The logic that should be applied is : depends_on_past AND trigger_rule, is that not what you see?

BTW when I designed trigger_rule I thought about a much more complex design where many trigger rules could be applied and potentially AND/OR and parenthesis could have been used to combine the rules. depends_on_past would have then become just another trigger rule that could have been applied as part of a more complex combination or rules.
But I ended up keeping it simple as we've been solving 90% of cases with just "all_done" and the current options probably bring us to 99.x% of our use cases..

The logic in using trigger_rule AND depends_on_past I was hoping for in our workflow would be: schedule today's task if the previous day's task instance is in a state defined in the current day's trigger_rule e.g. failed and not necessarily succeeded. That might not be desired for most people so I'm not surprised I don't see that behavior.
On a related note, we've been testing mostly with airflow backfill CLI and I've had trouble using merely trigger_rule='all_done' on a task downstream of multiple dependencies. If the tasks upstream of the trigger_rule='all_done' fail, they retry a few times and the relaxed trigger state task gets skipped. (note all my testing has been done off a pip install version of a few weeks ago.)
Our dag: even if all 90 anom tasks failed today and yesterday, we'd want dri to run. Also would prefer dri for today ran before yesterday's.

I'm not sure if I understand "they retry a few times and the relaxed trigger state task gets skipped"
I just read the code to review the definition of all_done and right now it correspond to either: SUCCESS, FAILED, UPSTREAM_FAILED, SKIPPED. If all the task instances are in one of those states, only then the downstream task should trigger (well if depends_on_past and wait_for_downstream are met, independently from this). Let me know if you've observed otherwise or if you think the logic should be changed.

So I think I've narrowed down an unexpected behavior on my end.
When executing a backfill, if there is a task upstream in a failed state, the backfill correctly triggers the downstream tasks with the specified trigger_rule='all done'. However when the upstream task fails again after a retry (I've forced this for testing purposes), the backfill throws an exception, immediately skips all the still-unscheduled tasks and quits with error:
Traceback (most recent call last):
  File "/usr/local/bin/airflow", line 10, in <module>
    args.func(args)
  File "/usr/local/lib/python2.7/site-packages/airflow/bin/cli.py", line 66, in backfill
    ignore_dependencies=args.ignore_dependencies)
  File "/usr/local/lib/python2.7/site-packages/airflow/models.py", line 2195, in run
    job.run()
  File "/usr/local/lib/python2.7/site-packages/airflow/jobs.py", line 159, in run
    self._execute()
  File "/usr/local/lib/python2.7/site-packages/airflow/jobs.py", line 659, in _execute
    "Some tasks instances failed, here's the list:\n"+str(failed))
airflow.utils.AirflowException: Some tasks instances failed, here's the list:
[('one_day', 'opc14', datetime.datetime(2013, 2, 1, 0, 0))]```

Thanks for all your thorough responses so far.

I found this code in airflow.jobs.py in https://github.com/airbnb/airflow/blob/master/airflow/jobs.py#L676.
A downstream task with a depends_on_false='all_done' should not be skipped, correct? This occurs during a backfill.
if ti.state == State.FAILED:
    failed.append(key)
    logging.error("Task instance " + str(key) + " failed")
    del tasks_to_run[key]
    # Removing downstream tasks from the one that has failed
    for t in self.dag.get_task(task_id).get_flat_relatives(
            upstream=False):
        key = (ti.dag_id, t.task_id, execution_date)
        if key in tasks_to_run:
            wont_run.append(key)
            del tasks_to_run[key]

Hi @timeisapear and @mistercrunch,
I believe @thoralf-gutierrez and myself have found an easy way to reproduce this issue as part as the unit tests.
We created a small "end-to-end dag tester" that rely on a BackFillJob to execute a DAG and then validates some post-conditions. We believe this is already super useful now and can grow into a great tool that continuously validates the robustness of Airflow! The corresponding PR together with some examples of sucessfull tests is here: https://github.com/airbnb/airflow/pull/670.
We used this framework to test the trigger rules ALL_FAILED, ALL_DONE and ONE_FAILED (when executed in a BackFillJob) and noted that none of them trigger the execution of the corresponding task since the BackFillJob systematically removes it from the tasks_to_run list, in the code identified by @timeisapear above.
We're not submitting these 3 tests in a PR yet since they would break the build, though the code and the corresponding Travis build failure on our fork are visible below:
https://github.com/RealImpactAnalytics/airflow/commits/testing_trigger_rules
https://travis-ci.org/RealImpactAnalytics/airflow/builds/92954257
We suggest the following resolution path:

please review https://github.com/airbnb/airflow/pull/670 and let us know if there's anything more we should do in order to have this validation framework included the master branch

we could then submit another PR with the 3 supplementary tests above + a fix that, as suggested by @timeisapear, would simply allow downstream tasks to stay in the tasks_to_run list if they can be triggered by failures.

What do you think ?

@svendx4f Please submit a PR!

Thanks @r39132. There is an open PR regarding the end to end testing, which is the first necessary step in order to reproduce everything described above.
The PR is here: https://github.com/airbnb/airflow/pull/748
It's regularly consuming energy on our side to rebase it and keep it current, so any support and lobbying to get approved and merged is more than welcome :)

Thx. Will do.. let me share it with the committers and ask for thoughts and feedback. BTW, you can also do the same on the gitter channel if you feel your PRs are getting lost in the noise.

@r39132 or @svendx4f can you please convert this to a Jira issue and close this after warts


Frequently Asked Questions Doc Update

Re: Frequently Asked Questions
Issue Description
Add JSONB key ordering statement to FAQ due to it's common nature.
Suggested Resolution
This question has been asked a few times and the general response is that there isn't a concept of ordering among json fields
10:47
the internal representation changes the ordering to enable more efficient access into the fields, and can do it because jsonb doesn't have any ordering gaurantees on its fields

Closing in favor of https://github.com/cockroachdb/docs/issues/6654.


Mark table column as having database default

As a developer working with Orchid ORM that operates against a third party managed database, I would like to mark certain database columns as having a database-level default without having to provide that default.
Example use case:
import { BaseTable } from "../base"

export class UserTable extends BaseTable {
  readonly table = "user"

  columns = this.setColumns((t) => ({
    id: t.integer().primaryKey(),
    data: t.json().hasDefault(), // <----- the proposed method
  }))
}

// This will work, and it should not generate type errors:
await db.user.create({ id: 1 })

Without .hasDefault(), the code emits a type error:
// Error: Property 'data' is missing in type '{ id: number; }' but required in type ...
await db.user.create({ id: 1 })

Unless it's called with a function, the default method is actually not doing anything other than affecting the type to allow omitting the column from create.
But still, it serves a good purpose to let programmers see what default is meant to be in there.
  columns = this.setColumns((t) => ({
    arr: t.json().default([]), // we can see it's an empty array by default
    obj: t.json().default({}), // it's an empty object by default
    text: t.text().default('specific string'),
    num: t.integer().default(123),
  }))

So the hasDefault doesn't seem to be a good idea IMO.

Yes, I realise that .default(value) only has runtime effect in migrations.
The use case I have in mind is the database with a text column with a default value which may change over time (outside of the development cycle of the app). Currently, I see these options:

t.text().default("small") — this will become a false hint to the developer when the default is later changed to "large".
t.text().default("") — this is a false hint that the default is an empty string (which it's not)
t.text().default("<configured by the backend>") — this is more or less readable, but how is it better than .hasDefault()? Also, what would be the equivalent for t.integer()?

That's why I was proposing to add a method that knowingly tells that the default is unknown to the ORM, yet it exists.

It's better to have hints than not. I'm imagining how I'm reviewing PRs where coworkers used hasDefault just because they're lazy to write a hint and it annoys me.
If the default value is out of your control, let the hasDefault be named unknownDefault(). So the name suggests it's for a special "unknown" case, not meant to be used out of laziness.

Added hasDefault, after some consideration, it seems to sound better than unknownDefault.


GAK kMeans Question

Hey Romain,
i have a question related to GAK k-means clustering.
Its not an actual issue, but i was wondersing how the centroids of k-means are calclated in this implementation using GAK?
If the centers are the most representative time series, wouldnt it have to be called k-medoids instead of k-means?
Thanks :)

Are you talking about Global Alignment Kernel kmeans? If so, there are no centroids available, only assignment of each time series to a cluster.

Hello, thanks for your answer! Yes, but to assign time series towards a cluster, the cluster somehow needs to be represented by a time series, or am i wrong? I thought Global Alignment Kernel kmeans is just kmeans appield with a GAK kernel. In kmeans there are usually some initial time series are chosen as center of some initial clusters, then time series are assigned and a new center of the resulting clusters is calculated. How is this new center chosen? is it the average of the time series?

In kernel kmeans, there is no explicit barycenter, contrary to kmeans.
If you need such explicit barycenter, I would suggest you use kmeans with softdtw as the metric. Softdtw is closely related to gak, you could read the associated paper if you want more information.

Oh okey, thank you, i did not notice that... thats probably why i missed it because i only knew about the standard kmeans and thought kernels are just some sort of similarity measure exchange. I was primarily searching in the kernel kmeans for single center update step in the paper. I guess i will have to read it more elaboratively. Thank you!


refactor: golf TileExistence.lean

I should have addressed all the review comments.
Thank you for your review, @grunweg.

Thanks! (And thanks for the review.)


Notification of change of source

Add notification when the output change / input by keyboard shortcuts.
For example : 'Current output: Realtek Digital Output'

This has been implemented in 2.0, see screenshot below. Is entirely configurable too (as per the script)

Script to Generate Notification:
icon = lib('NotificationIcon');
_ = lib('AudioSwitcher');

icon.ShowBalloonTip('info', _.getDefaultDevice('PLAYBACK').name, 'Default Playback Device')

@xenolightning Is the new version available anywhere?


Stories: Comments

This PR fixes #222
Changes

Add comments in Stories

Tests

[x] Tested on mobile
[x] Tested on dektop

This PR should be manually tested by @obernardovieira @PauloSousapt @psoaresbj , included on reviewers.

@obernardovieira

allows me to write unlimited text (I tried 5 paragraphs), but fails (same behaviour as 1.)

I talked with João rn and he said there's a backend limit for 256 characters. Do you want me to limit to those 256 or should we limit to a higher number?

256 sounds good 👍

ops, sorry. I think it was cache. It asks me to connect, all good.
But I realize I can't scroll to see stories on mobile.

ops, sorry. I think it was cache. Now it asks me to connect, all good. But I realize I can't scroll to see comments on mobile.

solved


Added poster for uri attr filtering

Introduced in HTML 5, there's a  attribute expecting URL:
https://developer.mozilla.org/en/docs/Web/HTML/Element/video

CLA is valid!

We need to treat data attribute of object tag too. But instead of including data attribute here, I think we need to ban some dangerous tag names such as object when an output placeholder is there.

do u mean that we should ban the "object" tag or some attributes defined in "object" tag?

i prefer flagging the developers when output expressions are placed inside , , , ,

please create the feature request for it.


v-model assigner is cached

Version
3.0.0-alpha.11
Reproduction link
https://jsfiddle.net/an4cbzd9/4/
Steps to reproduce
This very specific and I know how to work around it but I'm reporting it anyway:
The assigner used by v-model is cached during onBeforeMount and not updated during onUpdate.
If you assign onUpdate:modelValue manually, it won't reflect changes.
Bonus bug: getModelAssigner doesn't expect an array (i.e. more than on listener under the key onUpdate:). It crashes if you register additional listeners.
Easiest fix seems to be not caching assign in onBeforeUpdate and call getModelAssigner in onUpdate. It currently doesn't do much anyway.
What is expected?
When you type in the textbox, an id is logged in console.
This id should change everytime you click on the button.
What is actually happening?
Id stays the same, even after clicking the button.

I don't really understand why you'd write code that is shown in the repro, but that's not how v-model is designed to be used. The vModelText directive is strictly internal and assumes compiler usage only. Note not everything exported on Vue is part of the public API.

Believe it or not, it came naturally while building a reusable component that wraps an <input>.
I believe it doesn't have to be that convoluted, though.
Problem 1, cached assign
For the cached assign problem, I'd like to ask you a question:
Are you supposed to be able to build a v-model from a render function?
Should I be able to do something like that in JS code (sorry not a JSX user here)?
function MyComp(props) {
 return <input v-model='props.model.name' />;
}

If yes, what would the code look like?
I'm pretty sure that code can be written in a way that exposes this issue.
If not, it's an unforunate limitation, isn't it?
Problem 2, multiple listeners
Documentation is very explicit about how v-model works, in particular that onUpdate:modelValue is the event that updates stuff.
Let's say you want to listen to this event to log the changes, like so:
https://jsfiddle.net/gb4q0j7p/4/
It fails with assign is not a function (the multiple listeners problem I mentionned in issue).

Yeah, this does expose a problem that can happen even in compiled usage. Although I still strongly suggest not relying on any of the internals / undocumented exports. They may break without notice in any release.

@yyx990803 what's the recommended way to write a renderer that creates a v-model?


Bug: taking screenshot doesn't work as expected

Are you requesting a feature or reporting a bug?
reporting a bug
What is the current behavior?
I'm taking two screenshots (pre-login and post-login)
The only screenshot being save is the pre-login and the content of the image is of post-login screen
What is the expected behavior?
having two screenshots. one of the login page and one of the app main page
How would you reproduce the current behavior (if this is a bug)?
run the test
Provide the test code and the tested page URL (if applicable)
Tested page URL:
https://app.rookout.com/
Test code
fixture`Rookout E2E Regression & Demo Flow`.page`https://app.rookout.com/`
test("sanity rookout", async t => {
    await t.takeScreenshot("pre-login")

    await login(t) // I obviously can't help you reproduce that

    await t.takeScreenshot("post-login")
})

Specify your

operating system: Windows 10
testcafe version: 0.20.3
node.js version: 8.11.1

BTW the screenshot works perfectly on your site (https://testcafe.devexpress.com)
It just breaks on our site

Hi @amits1995,
I've reproduced this issue and will investigate it. I think it can be related to a redirect from https://app.rookout.com/ to https://app.rookout.com/web_login. You can use one of two workarounds:

Change the target page from .page`https://app.rookout.com/`  to .page`https://app.rookout.com/web_login`
Place the .navigateTo("/web_login") step before .takeScreenshot("pre-login")

Thank you very much!
Workaround #1 seems to work

Hi @amits1995! I think I've found the reason of the problem: the redirect to the login page happens too late to be detected by TestCafe. I've increased the amount of time that TestCafe waits for a possible redirect request, so could you please try to install a debug build and report the feedback here? Just specify the following URL:
https://github.com/AndreyBelym/testcafe/releases/download/gh-2508/testcafe-0.20.2-1.tgz
as a version of TestCafe in your package.json file.

After discussing in private, we decided to convert this bug to an enhancement.

Hey guys,
We have migrated our authentication logic to Auth0 which means we redirect to a dedicated login page.
This change seems to break the screenshots mechanism as t.takeScreenshot("screenshot") raises a null exception.
I tried running our tests with the testcafe version you mentioned and it still doesn't work.
Any idea?
I'm working on a public site to help you guys reproduce my problem, will publish once it's done

OK @AndreyBelym your custom version is the only version that works for us right now.
When is this feature planned to get in?
thanks

@miherlosev @AndreyBelym As a result, our tests run super slow (like x4 slower).
Is there any progress with this?


fixed links within the document

fixed some broken links

@polkhe great to see you here! Welcome!

@bgruening thank you :)

Thanks a lot for this first PR


Why Language Statistics show Ruby and Shell only?

Language Statistics of Linguist shows it is written in 99% in Ruby and 1% in Shell but the sample folder contain code for 267 languages so why it does not show those languages in Language statistics.

Hi @pawandeep2155 - Linguist ignores any file paths defined in this file
In this case the samples folder is ignored because of this line:
https://github.com/github/linguist/blob/master/lib/linguist/vendor.yml#L210-L211


Queues: tidy testing

This PR simplifies the testing harness for our three kinds of queues.
As a reminder, the queues are tested by:

Using a Python script to generate long lists of commands and values and dumping these to the Calyx-standard .data format.
Using a queue-specific Python "oracle" to read these .data files, execute the commands requested, and dump Calyx-standard .expect files. Here "queue-specific" is referring to the fact that we need one oracle each for FIFOs, PIFOs, and PIFO Trees. The .data file can actually remain identical across these cases.
Using our standard runt setup to test our code against the .data and .expect files generated as above.

Steps 1 and 2 are performed very occasionally, when we actually need to change something major. The resultant .data and .expect files are committed to the repo, and I imagine we will want good reason for ever changing them. Good reasons include improvements to the capabilities of the queue types!
The main thing folks may appreciate in this PR is a little bash script that runs steps 1 and 2 afresh for all our queue types. No more copy-pasting lines of code and sometimes forgetting to.
This PR also does away with magic constants for queue length and the maximum number of commands. These are both passed as command-line arguments instead. The bash script does this for you for now, passing queue length of 16 and crafting a test suite of 20,000 commands each time. However, someone who is seeking to debug experimental code may well want to replace that 20,000 with something like 8!
Our runt.toml also has a tweak, since our eDSL programs also take the maximum number of commands from the command line.
Will be immediately useful to @csziklai, and useful shortly to @KabirSamsi and @polybeandip!

We briefly discussed changing the no_err version of data gen to add the peek command back in. I am actually now thinking that I will leave it as it is, i.e., testing just a mix of pushes and pops. I think I will remove the peek command from all the queues. It is not all that useful and does add a little more complexity all over.

I'm merging this. @csziklai I do hope you find it useful! Please let me know if the script doesn't make sense. You run it by simply writing the .sh file's name, but if the .sh file it right in front of you, you need to say the name like this:
./scriptname.sh

You may need to execute
chmod +x scriptname.sh

Before executing. It should run silently, but it should (re)generate a bunch of .data and .expect files in the background. Useful to cut down the test from 20000 to something more manageable as you hack!


Updated Durable Functions, Logic Apps Table

Corrected the point against Logic Apps to show that it runs anywhere

@shankarvrp : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @shankarvrp, could you please accept the proposed edits? Would be great to get these merged before any merge conflicts arise. Thanks!

Hi @shankarvrp, do you still plan to complete this PR? If yes, please make the suggested changes. Otherwise, this PR will be automatically labeled inactive and then closed. Thanks!

Proposed edits were incorporated internally.
@ggailey777: #please-close


fix hide on hover, always show playback position

fixed hide on hover (state.video.location should be state.playing.location)
showing scrubber without needing to hover on playback bar
added 5px of margin right to full screen button to even things out a bit

Now hover looks like this (same):

Without hover (playback time is now visible):

After 2 seconds (controls hide after delay again as they should):

LGTM!


When the server aborts a connection any readers should get an OperationCanceled exception instead of an IOException

Sometimes when the connection is aborted by the server with the libuv transport, uv_write will fail with ECANCELED which will cause any attempt to read from the connection to throw an IOException instead of an OperationCanceledException like you would see from the Socket transport or even the libuv transport if the connection wasn't aborted mid-write.

Hi.
I am running an AspNetCore Server (Kestrel + IIS) on Windows 2012 R2, and it started to produce this ECANCELED exception in the websocket receiveasync loop after upgrading to Core 2.0. Its websocket connections are supposed to stay alive for weeks. The problem is when this exception occurs, client-side websocket does not recognize that the connection has been lost, and the client does not run its reconnection logic. I am wondering why the server is producing ECANCELED exception and if it is normal and expected behavior.


metadata property access simplification

To get the custom "owner" value of a test's metadata, you have to write test.getMetadata().toMap().get("owner")
Ideally, custom reports could just use test.metadata.owner
Previous attempts:
test.metadata["owner"] => groovy.lang.MissingPropertyException: No such property: owner for class: com.twosigma.webtau.reporter.WebTauTestMetadata
and
entry.metadata.get("owner") =>
No signature of method: com.twosigma.webtau.reporter.WebTauTestMetadata.get() is applicable for argument types: (String) values: [owner]
Possible solutions: getAt(java.lang.String), grep(), grep(java.lang.Object), wait(), any(), wait(long)

Are you on the latest? I see get is defined:
public <E> E get(String key) {
    return (E) metadata.get(key);
}

I think method we added right after the release. Added test to confirm that access works as expected

confirmed locally against 1.19-SNAPSHOT


Fix typo

methood -> method

Hi @JonCanning, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/csharp/csharp-7.md
:white_check_mark:Succeeded
View
Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Good catch! Thanks @JonCanning!


fix(sysinfo): not enough return values

Signed-off-by: zhouruiapple<EMAIL_ADDRESS>

thx @zhouruiapple


RP2 process runs after "DONE"

When I run rp2_us, even after the reports are generated and the logs say INFO: Done the process continues to run for a very long time with actual CPU utilization (0.3% - 1.7% typically). Eventually it stops on its own. (I don't know exactly how long it runs after INFO: Done, as I left the computer, but it was at least 10 minutes.)
Is it still doing actual "work" during this period, or is there something wrong? Thanks.

After logging "Done", RP2 exits and does nothing else. Can you paste info on how you observed the behavior (i.e. ps aux or similar)?

OK, weird. So here is an execution of rp2 in the background terminal. Notice how the prompt has not yet returned. It shows INFO: Done, but is seemingly still running. I then did a ps in the foreground terminal, and it shows it is still running. It has been like this for 5+ minutes now.

For what it's worth, this is running in a VirtualBox guest (Linux Mint 21). It doesn't have a lot of resources and is kind of slow (though it got to INFO: Done fairly quickly). It has access to 1 CPU, and is using swap space for virtual memory as actual memory is limited. (I'm using a VM rather than running on the host because the version of Linux Mint I'm running on the host has both python 2 and python 3, and I was running into issues with getting rp2 to run properly.)

I anticipated you might ask, so I freed up resources on the host and allocated much more to the guest. 4 CPUs and 4 GB of total RAM. This time it executed fine and ended promptly. So it seems it was purely a resources issue and not related to rp2. Sorry for the hassle. Please feel free to close the ticket. Thanks.

After some further tests I settled on 2 CPUs and 2.5 GB RAM for the guest VM. That seems to perform quite well (and exits promptly). I could probably even reduce more, but that seems fine for now.

Sounds good: it does sound like an issue with low resource systems.


Error Installing Laravel with composer using franken's php-cli

Following the discussion here https://github.com/dunglas/frankenphp/issues/470#issuecomment-1898094157
I'm trying to use frankenphp php-cli to run composer commands.
I just ran ./frankenphp php-cli ./composer.phar create-project laravel/laravel example-app In an Empty Folder.
And get the following error. This is a composer command to install laravel project.
Edit 1

Very strange behavior just unfolded.
Note: I've system-level composer & php8.3 already installed
I renamed php folder /etc/php/8.3 to 8.3.off to be sure it is using Franky's build-in php
Hence the error after the above command. BUT If I keep the system php as it is (not renamed off), then
the installer worked fine.
To me this feels like the composer or franken php-cli used system's php somehow, maybe?

Edit 2

I ran php version and path in a file and here's the output.
$ ./frankenphp php-cli info.php
PHP Version: 8.3.1
PHP Path: /var/www/html/test/./frankenphp
$ php info.php
PHP Version: 8.3.1
PHP Path: /usr/bin/php

Edit 3

/frankenphp php-cli uses Web SAPI
php uses CLI
That difference is the cause maybe?

> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi

Fatal error: Uncaught ReflectionException: Class "config" does not exist in /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Container/Container.php:912
Stack trace:
#0 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Container/Container.php(912): ReflectionClass->__construct('config')
#1 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Container/Container.php(795): Illuminate\Container\Container->build('config')
#2 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(957): Illuminate\Container\Container->resolve('config', Array, true)
#3 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Container/Container.php(731): Illuminate\Foundation\Application->resolve('config', Array)
#4 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(942): Illuminate\Container\Container->make('config', Array)
#5 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Container/Container.php(1454): Illuminate\Foundation\Application->make('config')
#6 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(560): Illuminate\Container\Container->offsetGet('config')
#7 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(611): Illuminate\Log\LogManager->getDefaultDriver()
#8 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(124): Illuminate\Log\LogManager->parseDriver(NULL)
#9 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(681): Illuminate\Log\LogManager->driver()
#10 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Foundation/Exceptions/Handler.php(317): Illuminate\Log\LogManager->error('Call to undefin...', Array)
#11 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Foundation/Exceptions/Handler.php(278): Illuminate\Foundation\Exceptions\Handler->reportThrowable(Object(Error))
#12 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(523): Illuminate\Foundation\Exceptions\Handler->report(Object(Error))
#13 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(203): Illuminate\Foundation\Console\Kernel->reportException(Object(Error))
#14 /var/www/html/test/example-app/artisan(35): Illuminate\Foundation\Console\Kernel->handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#15 {main}

Next Illuminate\Contracts\Container\BindingResolutionException: Target class [config] does not exist. in /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Container/Container.php:914
Stack trace:
#0 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Container/Container.php(795): Illuminate\Container\Container->build('config')
#1 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(957): Illuminate\Container\Container->resolve('config', Array, true)
#2 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Container/Container.php(731): Illuminate\Foundation\Application->resolve('config', Array)
#3 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(942): Illuminate\Container\Container->make('config', Array)
#4 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Container/Container.php(1454): Illuminate\Foundation\Application->make('config')
#5 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(560): Illuminate\Container\Container->offsetGet('config')
#6 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(611): Illuminate\Log\LogManager->getDefaultDriver()
#7 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(124): Illuminate\Log\LogManager->parseDriver(NULL)
#8 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Log/LogManager.php(681): Illuminate\Log\LogManager->driver()
#9 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Foundation/Exceptions/Handler.php(317): Illuminate\Log\LogManager->error('Call to undefin...', Array)
#10 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Foundation/Exceptions/Handler.php(278): Illuminate\Foundation\Exceptions\Handler->reportThrowable(Object(Error))
#11 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(523): Illuminate\Foundation\Exceptions\Handler->report(Object(Error))
#12 /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(203): Illuminate\Foundation\Console\Kernel->reportException(Object(Error))
#13 /var/www/html/test/example-app/artisan(35): Illuminate\Foundation\Console\Kernel->handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#14 {main}
  thrown in /var/www/html/test/example-app/vendor/laravel/framework/src/Illuminate/Container/Container.php on line 914
Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 255

composer.phar
Downloaded from the site directly.

frankenphp v1.0.3
Downloaded from the git directly.

How to reproduce on Ubuntu 22.04
$ mkdir test
$ cd test
# copy composer.phar & frankenphp here
$ ls > composer.phar frankenphp
$ ./frankenphp php-cli ./composer.phar create-project laravel/laravel example-app

Laravel installer runs fine untill it reaches pro-install script and error outs
This also happens on an existing project.
Using system-level php with composer works fine so it seems to be frankenphp php-cli's issue maybe.

I suspect (without digging into laravel's template repo), that some script is using:
{
  "scripts": {"example": "composer do-stuff"}
}

instead of
{
  "scripts": {"example": "@composer do-stuff"}
}

The former would use a globally installed composer (if available) while the latter should call back into itself. It'd be interesting to test both these variations in a project and see what happens.

I didn't now what the @ sign did in composer file, just got the info from your comment, Thank you.
Every command in laravel's composer has @php, but I think the error is in postAutoloadDump.
composer.json
"scripts": {
        "post-autoload-dump": [
            "Illuminate\\Foundation\\ComposerScripts::postAutoloadDump",
            "@php artisan package:discover --ansi"
        ],
        "post-update-cmd": [
            "@php artisan vendor:publish --tag=laravel-assets --ansi --force"
        ],
        "post-root-package-install": [
            "@php -r \"file_exists('.env') || copy('.env.example', '.env');\""
        ],
        "post-create-project-cmd": [
            "@php artisan key:generate --ansi"
        ]
    },

This has gone out of my current knowledge of composer & the internal framework.
This is an interesting outcome, and most probably at Laravel's end itself.
I'm not sure if I can help any further, but let me know.
And maybe close this issue as it seems out of Franky's scope.

Ah, interesting. It's possible that FrankenPHP doesn't let composer know how to call @php.
If we take a look at composer it is actually trying to execute a php binary, which would default to frankenphp in this case.
It then tries to call frankenphp with -d arguments, which will fail.
So, it looks like if we want full php-cli support, we'd need to have a php binary that can be used by composer (can use environment variable: PHP_BINARY).

@dunglas ^
We might need to possibly extract the static php binary to a location on disk and set PHP_BINARY env var when executing cli scripts (particularly composer).

That's a great find, you are awesome.
I know dunglas mentioned php parameters are not supported yet, so this would require some extra work.
Glad my discussion helped in pointing out some not-so-common use cases.
Simple approaches are not so simple after all :)

Thanks for the investigation!
In my opinion we should:

add support for the unsupported options (basically, we'll just have to copy/paste some code from php-src)
make Composer aware of frankenphp php-cli

WDYT?

Composer uses the PHP_BINARY env variable if it's set, we just need to test that it handles spaces for our case. Meaning will it call "frankenphp php-cli" script.php or "frankenphp php-cli script.php".

I ran into the same problem - in a laravel project, composer wants to a call php binary e.g. to do package discovery. As a workaround, I created a shell script in /usr/local/bin/php to strip the -d parameters and call frankenphp:
#!/bin/bash

# iterate over<EMAIL_ADDRESS>if the current argument is -d, remove the argument and the next one
for i in "$@"
do
    if [ "$i" == "-d" ]; then
        shift
        shift
    fi
done

/usr/local/bin/frankenphp php-cli "$@"

With this, the composer install goes through.

Nice one. Would you mind opening a docs PR to mention this trick? Maybe in the known-issues.md file?

Closing for now: https://github.com/dunglas/frankenphp/pull/610


Supporting jakarta namespace

Are there any plans to support jakarta namespace (jakarta ee 9) in swagger? With each passing day there are more libraries that have migrated to the jakarta namespace which is incompatible with javax namespace.
The namespace incompatibility will slowly lead to developers having to choose between using swagger or remaining on older versions of libraries that are still compatible with jakarta.
For example, the latest version of Jetty supports Jakarta namespace and is now incompatible with the javax namespace which means that one cannot upgrade to the latest version of Jetty and continue using swagger.

This is a quite delicate issue and has not been decided yet, and any comment or contribution in this area are more than welcome, however IMO the best direction and the current plan (no ETA yet) is aiming for support of both javax and jakarta namespaces at least for the short - medium term (until things stabilize).
The idea is to have parallel releases of original (let's say javax based) and modified (jakarta based) artifacts, using either direct bytecode manipulation and/or existing specific tools (e.g.
https://github.com/eclipse/transformer), with minor refactoring beforehand (e.g. hardcoded javax etc).
A more comprehensive solution - again depending on how things evolve - would include refactoring the next major version to introduce a compatibility layer, this would however need much more effort than artifact transformation at build/deploy time.
I would say that in any case it's not an option to maintain 2 parallel major release lines for javax and jakarta, if not based on artifact transformation.
Again and as always contributions are appreciated.

see also https://github.com/swagger-api/swagger-core/issues/3849#issue-779412695

see also https://github.com/swagger-api/swagger-core/issues/3849#issue-779412695

See my PR #3852
@frantuma I see your reasoning regarding the support of both namespaces and agree that it would be good from a maintainers POV. However I feel that neither transformer nor a compatibility layer are good solutions from a users perspective.
Looking at Swaggers main dependencies and how they solved this:
JAXB: Clear cut with v3.0.0
Jersey: Clear cut with v3.0.0
Jakarta WS: Clear cut with v3.0.0
Jackson: Supporting both namespaces with shaded JARs (ugly in my opinion). They now provide different JARs seperated by classifier. This is a pain to work with.
I personally would prefer to maintain two major releases for the time being and deprecate the javax version as soon as reasonable.
The future will be jakarta if we like it or not ;)
I'm really willing to support you on this, so please let me know if this is a step towards a solution or not.

See my PR #3852
@frantuma I see your reasoning regarding the support of both namespaces and agree that it would be good from a maintainers POV. However I feel that neither transformer nor a compatibility layer are good solutions from a users perspective.
Looking at Swaggers main dependencies and how they solved this:
JAXB: Clear cut with v3.0.0
Jersey: Clear cut with v3.0.0
Jakarta WS: Clear cut with v3.0.0
Jackson: Supporting both namespaces with shaded JARs (ugly in my opinion). They now provide different JARs seperated by classifier. This is a pain to work with.
I personally would prefer to maintain two major releases for the time being and deprecate the javax version as soon as reasonable.
The future will be jakarta if we like it or not ;)
I'm really willing to support you on this, so please let me know if this is a step towards a solution or not.

@strangelookingnerd thanks a lot for your contribution in this area!
We are still identifying the best achievable solution, considering both user experience and maintenance effort, and while I see your point in having 2 "clean" separate release lines until javax fades away, we still think that this would mean considerable maintenance effort and duplication, and we still think that an artifact transformation within the same release lines makes more sense for this project.
I feel we are more in a position like Jackson's, as its maintainer says in a comment for a slightly related ticket, and their solution seems to address similar problems, until next major release.
I can understand that it doesn't look so clean, but I'd say this whole thing has not been really "clean" from the start..
Can you maybe elaborate on This is a pain to work with.? Just to have a broader view on impact.

I am adding here as reference a set of links related to Jackson work in this area for 2.12 (shading with package renaming and different classifier), even though probably the eclipse transformer tool gets a bit further (e.g. OSGi related changes, etc)
as possible solution see also what applied by Jackson in 2.12, shading with package renaming and different classifier, see:

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.12
https://github.com/FasterXML/jackson-modules-base/pull/116
(but) https://github.com/FasterXML/jackson-jaxrs-providers/issues/132

and

https://github.com/FasterXML/jackson-jaxrs-providers/pull/124
https://github.com/FasterXML/jackson-modules-base/pull/95
https://github.com/FasterXML/jackson-modules-base/issues/112
https://github.com/FasterXML/jackson-modules-base/issues/96

and

https://github.com/FasterXML/jackson-jaxrs-providers/issues/129
https://github.com/FasterXML/jackson-databind/issues/2910
https://github.com/FasterXML/jackson-dataformat-xml/issues/408

and
https://github.com/search?q=org%3AFasterXML+jakarta

@strangelookingnerd thanks a lot for your contribution in this area!
We are still identifying the best achievable solution, considering both user experience and maintenance effort, and while I see your point in having 2 "clean" separate release lines until javax fades away, we still think that this would mean considerable maintenance effort and duplication, and we still think that an artifact transformation within the same release lines makes more sense for this project.
I feel we are more in a position like Jackson's, as its maintainer says in a comment for a slightly related ticket, and their solution seems to address similar problems, until next major release.
I can understand that it doesn't look so clean, but I'd say this whole thing has not been really "clean" from the start..
Can you maybe elaborate on This is a pain to work with.? Just to have a broader view on impact.

I am adding here as reference a set of links related to Jackson work in this area for 2.12 (shading with package renaming and different classifier), even though probably the eclipse transformer tool gets a bit further (e.g. OSGi related changes, etc)
as possible solution see also what applied by Jackson in 2.12, shading with package renaming and different classifier, see:

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.12
https://github.com/FasterXML/jackson-modules-base/pull/116
(but) https://github.com/FasterXML/jackson-jaxrs-providers/issues/132

and

https://github.com/FasterXML/jackson-jaxrs-providers/pull/124
https://github.com/FasterXML/jackson-modules-base/pull/95
https://github.com/FasterXML/jackson-modules-base/issues/112
https://github.com/FasterXML/jackson-modules-base/issues/96

and

https://github.com/FasterXML/jackson-jaxrs-providers/issues/129
https://github.com/FasterXML/jackson-databind/issues/2910
https://github.com/FasterXML/jackson-dataformat-xml/issues/408

and
https://github.com/search?q=org%3AFasterXML+jakarta

I feel it's hard to work with the BOMs and transitive dependencies. For example:
https://github.com/strangelookingnerd/swagger-core/commit/364d5cb6b0c026a33f391479c18011e8e1b57b16?branch=364d5cb6b0c026a33f391479c18011e8e1b57b16&diff=split#diff-efd347097616fc97c8d51278e2eaa1c78fb3effd19ff3c167e907572b4db58d3R203-R229
Maybe I did it all wrong but to my understanding:
<dependency>             <groupId>com.fasterxml.jackson.jaxrs</groupId>             <artifactId>jackson-jaxrs-json-provider</artifactId>             <version>${jackson-version}</version>             <classifier>jakarta</classifier> </dependency>
still has transitive dependencies to the "non-jakarta" modules and I would not know how they could change that to be fair.
Shaded JARs are shady...(yes I went there, sorry)...and always come at a cost. Identifying and fixing problems in the transitive dependencies is never fun.
Thinking of a clean solution for a transformation to achieve what was done in my PR gives me a major headache. But maybe thats just me.

I feel it's hard to work with the BOMs and transitive dependencies. For example:
https://github.com/strangelookingnerd/swagger-core/commit/364d5cb6b0c026a33f391479c18011e8e1b57b16?branch=364d5cb6b0c026a33f391479c18011e8e1b57b16&diff=split#diff-efd347097616fc97c8d51278e2eaa1c78fb3effd19ff3c167e907572b4db58d3R203-R229
Maybe I did it all wrong but to my understanding:
<dependency>             <groupId>com.fasterxml.jackson.jaxrs</groupId>             <artifactId>jackson-jaxrs-json-provider</artifactId>             <version>${jackson-version}</version>             <classifier>jakarta</classifier> </dependency>
still has transitive dependencies to the "non-jakarta" modules and I would not know how they could change that to be fair.
Shaded JARs are shady...(yes I went there, sorry)...and always come at a cost. Identifying and fixing problems in the transitive dependencies is never fun.
Thinking of a clean solution for a transformation to achieve what was done in my PR gives me a major headache. But maybe thats just me.

This is good feedback, thanks. I will analyze this a bit more and share some thoughts probably next week, whatever additional comment/thought in the meantime is welcome, particularly on further drawbacks of the transform solution.

This is good feedback, thanks. I will analyze this a bit more and share some thoughts probably next week, whatever additional comment/thought in the meantime is welcome, particularly on further drawbacks of the transform solution.

Any updates on this?

Jakarta support is planned for upcoming release, probably within next week; we have also considered @strangelookingnerd input and work on this, and we dropped idea to take Jackson path with classifier.
The planned solution still makes use of transformers, but providing a separate artifactId (with -jakarta suffix, e.g. swagger-core-jakarta) along with its own POM with correct dependency hierarchy.
In the medium term we will probably have the default artifacts supporting jakarta, and maintaining a transformed version for javax.
Will keep updates in this ticket

@frantuma This is great news and +1 for the planned solution. Any way I could contribute?

@strangelookingnerd thanks! I'll ping when I have the PR ready / merged, what will be missing is possibly some swagger-jakarta-test module providing tests for the jakarta versions and/or one or more samples added to https://github.com/swagger-api/swagger-samples/tree/2.0/java with some jakarta env, e.g. Jersey, Grizzly, etc
(The PR will introduce a new module swagger-project-jakarta holding in turn the set of jakarta modules swagger-annotations-jakarta, swagger-models-jakarta, etc..)

please see #3881 implementing what mentioned above.

Closing as Jakarta artifacts are available since version 2.1.7, see wiki, maven readme and gradle readme.

FWTW, Jackson 2.13 drops classifier path and does a full fork instead, so that there are 2 modules on
https://github.com/FasterXML/jackson-modules-base/
namely

"jackson-module-jaxb-annotations" for old javax/jaxb annotations
"jackson-module-jakarta-xmlbind-annotations" for new jakarta xmlbind annotations

These live in different Java packages (as well as have different Maven coordinates), so upgrade would not be fully transparent to users; but on plus side both can co-exist if need be.
I assume it is also possible to just use (1) and do fancy auto-magic bytecode manipulation. But thought I'd mention the new alternative in case it might be of interest, one Jackson 2.13 gets released (within a month or two).

@cowtowncoder Thanks for the heads up! Reopening ticket to keep track of work needed when updating to Jackson 2.1.3+

The current version of the swagger-jaxrs2-jakarta module is referencing the the jackson module with the 'jakarta' classifier.
It seems that the publication of this artifact is revoked, breaking the module.
As a workaround, i'm currently ignoring the dependency and manually importing it.
    implementation group: 'com.fasterxml.jackson.jakarta.rs', name: 'jackson-jakarta-rs-json-provider', version: '2.13.0-rc1'

    implementation (group: 'io.swagger.core.v3', name: 'swagger-jaxrs2-jakarta', version: '2.1.10') {
        exclude group: 'com.fasterxml.jackson.jaxrs', module: 'jackson-jaxrs-json-provider'
    }

@jsikkes not sure what you mean by "revoked"; 2.12.1 (to 2.12.4) version with jakarta artifact is available on maven central, and as mentioned by Tatu above, it's 2.13 which drops classifier.

As mentioned in wiki the jackarta artifacts are using the jakarta suffix, e.g. swagger-core-jakarta


Sugar Cane fails when trying to add as a bonsai

Bonsai Trees version: v1.1.3-b156
Forge version: v<IP_ADDRESS>38
Optifine: Yes
Link to Crashlog: None
Screenshot (if possible): Below
Description of the problem including expected versus actual behavior:
For my custom modpack, I decided to make sugar cane growable in Bonsai Pots, but am unable to plant the sugar cane into a Bonsai pot.
The following script fails to work even though it should be correct. The mod doesn't seem to recognize minecraft:reeds as an item at all. Changing the sapling to something besides reeds works completely fine, but for some reason, adding reeds doesn't work.
I have had this problem for a long time now, but only recently realized that it could be a bug.
{
    "name": "minecraft:reeds",
    "mod": "minecraft",
    "sapling": {
        "name": "minecraft:reeds",
        "data": 0
    },
    "growTimeMultiplier": 1.5,
    "drops": [
        {
            "name": "minecraft:reeds",
            "data": 0,
            "type": "WOOD"
        },
		{
            "name": "minecraft:reeds",
            "data": 0,
            "type": "SAPLING"
        },
        {
            "name": "minecraft:sugar",
            "data": 0,
            "type": "FRUIT"
        }
    ],
	"compatibleSoilTags": [ "sand", "grass", "dirt" ]
}

The following image shows what the output is once I change the sapling tag to the quark:reed_block. It now registers as a sapling type, but the output doesn't seem to recognize minecraft:reeds as a valid item output for WOOD or SAPLING.

(Just ignore the weird texture bugs from the Dark Theme mod...)
Steps to reproduce:

Add shapes for sugar cane.
Create a types.d file for sugar cane using the above code.
Try to plant sugar cane into a Bonsai Pot.

I found out the same also seems to happen with nether wart

Was just about to put this, before I saw this. Have been adding all non-standard mushrooms/plants from other mods, as well as the standard Minecraft giant mushrooms. I found this out myself as well. Sugar cane simply cannot be added.


Update Operator SDK to 0.8.1

This PR is divided in two commits: the first is to move from dep to go modules, as that's the new default for the Operator SDK. Note that it requires Go 1.11 with GO111MODULE=on or Go 1.12, where modules is activated by default. For my local development environment, I opted for using Go 1.12.
The second commit is to implement changes that I see when a new operator is generator, including the new tools.go at the root of the project and a new Dockerfile with a couple of scripts.

Tests are passing. I got some failures with the streaming tests at first, but manually removing the Kafka my-cluster after the first failed run, made the subsequent runs to complete successfully.
$ make test
Running unit tests...
?   	github.com/jaegertracing/jaeger-operator/cmd	[no test files]
?   	github.com/jaegertracing/jaeger-operator/cmd/manager	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/account	0.034s	coverage: 100.0% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/apis	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/apis/io/v1alpha1	0.063s	coverage: 15.7% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/apis/jaegertracing/v1	0.079s	coverage: 15.9% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/cmd/start	[no test files]
?   	github.com/jaegertracing/jaeger-operator/pkg/cmd/version	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/config/sampling	0.085s	coverage: 94.1% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/config/ui	0.029s	coverage: 94.1% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/controller	[no test files]
?   	github.com/jaegertracing/jaeger-operator/pkg/controller/deployment	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger	2.159s	coverage: 69.2% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/controller/legacy	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/cronjob	0.079s	coverage: 97.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/deployment	0.044s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/ingress	0.054s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/inject	0.041s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/inventory	0.057s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/route	0.044s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/service	0.026s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/storage	0.932s	coverage: 93.6% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/strategy	0.108s	coverage: 92.8% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/util	0.008s	coverage: 100.0% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/version	[no test files]
Formatting code...
Building...
Sending build context to Docker daemon  185.6MB
Step 1/9 : FROM centos
 ---> 1e1148e4cc2c
Step 2/9 : ENV OPERATOR=/usr/local/bin/jaeger-operator     USER_UID=1001     USER_NAME=jaeger-operator
 ---> Using cache
 ---> a395a96ebf1b
Step 3/9 : RUN INSTALL_PKGS="       openssl       " &&     yum install -y $INSTALL_PKGS &&     rpm -V $INSTALL_PKGS &&     yum clean all &&     mkdir /tmp/_working_dir &&     chmod og+w /tmp/_working_dir
 ---> Using cache
 ---> 218935571c9a
Step 4/9 : COPY scripts/* /scripts/
 ---> Using cache
 ---> 29a672333030
Step 5/9 : COPY build/_output/bin/jaeger-operator ${OPERATOR}
 ---> 059237215f54
Step 6/9 : COPY build/bin /usr/local/bin
 ---> c08e4261e5d9
Step 7/9 : RUN  /usr/local/bin/user_setup
 ---> Running in 34861effd84e
+ mkdir -p /root
+ chown 1001:0 /root
+ chmod ug+rwx /root
+ chmod g+rw /etc/passwd
+ rm /usr/local/bin/user_setup
Removing intermediate container 34861effd84e
 ---> 97fee10f78c9
Step 8/9 : ENTRYPOINT ["/usr/local/bin/entrypoint"]
 ---> Running in 00c4bef69cc1
Removing intermediate container 00c4bef69cc1
 ---> 4bfaa4358fdf
Step 9/9 : USER ${USER_UID}
 ---> Running in 5e55df7d4f87
Removing intermediate container 5e55df7d4f87
 ---> c1c3ed3be812
Successfully built c1c3ed3be812
Successfully tagged jpkroehling/jaeger-operator:latest
Pushing image jpkroehling/jaeger-operator:latest...
Running Smoke end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	182.174s
Creating namespace default
Running Cassandra end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	105.714s
Running Elasticsearch end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	156.104s
customresourcedefinition.apiextensions.k8s.io/prometheusrules.monitoring.coreos.com configured
customresourcedefinition.apiextensions.k8s.io/servicemonitors.monitoring.coreos.com configured
serviceaccount/elasticsearch-operator unchanged
clusterrole.rbac.authorization.k8s.io/elasticsearch-operator configured
clusterrolebinding.rbac.authorization.k8s.io/elasticsearch-operator-rolebinding configured
customresourcedefinition.apiextensions.k8s.io/elasticsearches.logging.openshift.io configured
deployment.apps/elasticsearch-operator configured
Running Self provisioned Elasticsearch end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	0.147s
Creating namespace kafka
customresourcedefinition.apiextensions.k8s.io/kafkas.kafka.strimzi.io configured
rolebinding.rbac.authorization.k8s.io/strimzi-cluster-operator-entity-operator-delegation unchanged
clusterrolebinding.rbac.authorization.k8s.io/strimzi-cluster-operator configured
rolebinding.rbac.authorization.k8s.io/strimzi-cluster-operator-topic-operator-delegation unchanged
customresourcedefinition.apiextensions.k8s.io/kafkausers.kafka.strimzi.io configured
clusterrole.rbac.authorization.k8s.io/strimzi-entity-operator configured
clusterrole.rbac.authorization.k8s.io/strimzi-cluster-operator-global configured
clusterrolebinding.rbac.authorization.k8s.io/strimzi-cluster-operator-kafka-broker-delegation configured
rolebinding.rbac.authorization.k8s.io/strimzi-cluster-operator unchanged
clusterrole.rbac.authorization.k8s.io/strimzi-cluster-operator-namespaced configured
clusterrole.rbac.authorization.k8s.io/strimzi-topic-operator configured
serviceaccount/strimzi-cluster-operator unchanged
clusterrole.rbac.authorization.k8s.io/strimzi-kafka-broker configured
customresourcedefinition.apiextensions.k8s.io/kafkatopics.kafka.strimzi.io configured
deployment.extensions/strimzi-cluster-operator configured
customresourcedefinition.apiextensions.k8s.io/kafkaconnects2is.kafka.strimzi.io configured
customresourcedefinition.apiextensions.k8s.io/kafkaconnects.kafka.strimzi.io configured
customresourcedefinition.apiextensions.k8s.io/kafkamirrormakers.kafka.strimzi.io configured
kafka.kafka.strimzi.io/my-cluster created
Running Streaming end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	66.036s


Move to MCP?

Since collection2 has been moved to MCP should we move this as well to have it all in one place? @aldeed

Done

@aldeed thank you!


Having trouble getting it running on a raspberry pi

I keep getting an issue when Im trying to startup the bridge (from one of the dependencies).  Its acting like it didn't compile or something.  I've tried it with and without sudo and rebuilding as well as a whole bunch of other things I've tried but no luck.  Any idea what I'm missing?
sudo ./bridge display
-- Flower Bridge --
module.js:485
process.dlopen(filename, module.exports);
^
Error: /home/pi/node-flower-bridge/node_modules/flower-power-ble/node_modules/noble-device/node_modules/noble/node_modules/bluetooth-hci-socket/build/Release/binding.node: undefined symbol: node_module_register
at Object.Module._extensions..node (module.js:485:11)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:362:17)
at require (module.js:378:17)
at Object. (/home/pi/node-flower-bridge/node_modules/flower-power-ble/node_modules/noble-device/node_modules/noble/node_modules/bluetooth-hci-socket/lib/native.js:3:15)
at Module._compile (module.js:449:26)
at Object.Module._extensions..js (module.js:467:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)

nvm.  It looks like it was an issue where I couldn't run as sudo but I had to make some changes to run without sudo (https://github.com/sandeepmistry/noble#running-on-linux).


Make Q&A custom commands handle different channels

659506930c7025a01abd2a0b744ca669c162c2af and 0e4ef7b098538caa555ea22c3600136d79d11ecc are also part of this Issue.


Revert to using the module source method

We cannot rely on the _source attribute being on the module, so we go back to using the source() method with some documentation about its known limitations.

Thanks!


Added Catalan language translation file

Added Catalan "ca" language translation file.

Thanks a lot ! I will include this when the next version will come out :-)

Codecov Report
Base: 71.48% // Head: 71.48% // No change to project coverage :thumbsup:

Coverage data is based on head (fcb7f37) compared to base (8a00372).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   71.48%   71.48%
=======================================
  Files          13       13
  Lines         540      540
=======================================
  Hits          386      386
  Misses        154      154

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update brp.mcrl2, this has been changed recently.

We do not use the brp.mcrl2 anymore, instead we use a smaller mcrl2 now: c5b19c1614a86a20065d10c134ad9d0355b0039f.


Adjust preference key naming for 3 keys : cell-ui.previewMatchedCells, googleReadTimeOut & googleConnectTimeOut

For consistency, some preferences keys could be adjusted, IMOO.

cell-ui.previewMatchedCells
googleReadTimeOut
googleConnectTimeOut

They do not respect the general convention, that is not very defined, I must admit.
Proposed solution
Rename them, while still reading the old key if the new is not present, i.e. being backward compatible.

Now
Correction suggested

cell-ui.previewMatchedCells
ui.browsing.previewMatchedCells

googleReadTimeOut
google.read.timeOut

googleConnectTimeOut
google.connect.timeOut

Agree we should probably make preference categories more defined and consistent.
Why the "browsing" subcategory?  Shouldn't that be "reconciliation.previewMatchedCells"?  As in https://github.com/OpenRefine/OpenRefine/blob/0990531908187e2756cdc6c437e32579f8f54d6d/main/tests/server/src/com/google/refine/preference/PreferenceStoreTests.java#L46


mtl: Image format properties

Fixes #1948 (several CTS errors)
PR checklist:

[X] make succeeds (on *nix)
[X] make reftests succeeds
[X] tested examples with the following backends: Metal

Some notes:

Resource size still labeled as TODO: maximum texture size is unknown, so I've increased it for now. I think this is probably okay because it's still possible for image creation to fail (see the note about this in the Vulkan specification). I've filed a bug report with Apple to ask whether the feature set tables could be expanded to include this information. The only maximum resource size listed at the moment is for buffers, which doesn't apply to textures that aren't backed by a MTLBuffer, see for example this forum post discussing this limit.
It appears we were using the wrong value for max_levels (it's supposed to be max mipmap levels). I don't see a value for this in the feature set table either, so until this can be clarified I simply calculated the number of expected mipmap levels using the formula in the Vulkan specification (maxMipLevels must be equal to ⌈log2(max(width, height, depth))⌉ + 1).
Vulkan restricts 3D images to only support a single layer (see valid usage for VkImageCreateInfo - If imageType is VK_IMAGE_TYPE_3D, arrayLayers must be 1). I've added the restriction here too, although we could add that in the portability layer instead if it's preferable. I don't know what the semantics are for 3D image layered images in Metal, but it seems we don't have that option in Vulkan for now at least.

I can't find that validation error, and neither the docs section describing this limitation.
Let's merge this now, and I'll fix it later if it becomes a problem.
bors r+


NVIDIA Jetson nano install - Unable to locate package ros-crystal-rosidl-typesupport-connext-cpp

When installing ROS2 (Building ROS 2 on Linux) on a NVIDIA Jetson Nano running Ubuntu 18, I am seeing the following error when running the "Install dependencies using rosdep"
Ubuntu Version

lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.2 LTS
Release:	18.04
Codename:	bionic

These are the steps I ran to see the issue

sudo rosdep init
rosdep update
# [Ubuntu 18.04]
rosdep install --from-paths src --ignore-src --rosdistro crystal -y --skip-keys "console_bridge fastcdr fastrtps libopensplice67 libopensplice69 rti-connext-dds-5.3.1 urdfdom_headers"

Error seen

 rosdep install --from-paths src --ignore-src --rosdistro crystal -y --skip-keys "console_bridge fastcdr fastrtps libopensplice67 libopensplice69 rti-connext-dds-5.3.1 urdfdom_headers"
executing command [sudo -H apt-get install -y ros-crystal-rosidl-typesupport-connext-cpp]
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package ros-crystal-rosidl-typesupport-connext-cpp
ERROR: the following rosdeps failed to install
  apt: command [sudo -H apt-get install -y ros-crystal-rosidl-typesupport-connext-cpp] failed

If I run the apt-get help, this is what is reported

 sudo -H apt-get install -y ros-crystal-rosidl-typesupport-connext-cpp
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package ros-crystal-rosidl-typesupport-connext-cpp

connext is not supported on arm in crystal: see rmw_connext_cpp in  http://www.ros.org/reps/rep-2000.html#crystal-clemmys-december-2018-december-2019
You will want to use a different rmw implementation like rmw_fastrtps_cpp.


Default log always gets created

This is a bug bc:
The following code
#include <easylogger++.h>
INITIALIZE_EASYLOGGINGPP

int main(int argc, char **argv)
{
    START_EASYLOGGINGPP(argc, argv);
    el::Loggers::configureFromGlobal("logging.conf");

with
* GLOBAL:
   FILENAME             =  "main_program.log"

should be expected to only create main_program.log, however it also creates logs/myeasylog.log which is completely unwanted.
And hence "NO_DEFAULT_LOG" would crash the app ( see #327 ) we have no way to disable this behaviour except hardcoding a DEFAULT_LOG_FILE, which is pretty dirty again (that would drive parts of the idea of a configuration file nuts, if you hardcode it partly..)

Have you seen https://github.com/easylogging/easyloggingpp/blob/master/samples/STL/no-default-log-file.cpp ? also you need to define the macro on compiler level so that it's available throughtout your project (i.e, in sample it's defined in main file but if you have multiple files project please define it using -D flag of compiler

Keeping it open until resolved

Ups, yes i forgot to mention that this macro ELPP_NO_DEFAULT_LOG_FILE
was defined before including easylogging++.h, still it got created.
Can't try with compile flags atm, maybe someone else is able to reproduce it

I'd like to support this too.
I require that the log file is never created sometimes and the ELPP_NO_DEFAULT_LOG_FILE option crashes the application on windows.

Can by fixed by applying this patch: https://github.com/easylogging/easyloggingpp/pull/350
and defining ELPP_NO_LOG_TO_FILE
(thats what I do...)

This is fixed in v9.85


Incorrect control flow analysis for typeof x == undefined

Example from real bug
var x: number | undefined;
if (typeof x !== undefined) {
    var y = x + 1; // no error, but should be
}

Actually not a bug, just with vscode something happens

Same bug in the complier https://github.com/Microsoft/TypeScript/pull/16663


Add SMS Content Item Category and Tag Snippets

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

47 of 47 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2130

Relevant Lines:
2130

💛  - Coveralls


Cursor lost after KeyboardInterrupt

I'm on macOS using iTerm/zsh and have tested with the latest commit: https://github.com/Mckinsey666/bullet/commit/eaf1fb7a2b82bb6a27416ef0b22f5884b8af17e0

If I break out of a Bullet list via ctrl+c, I see the following stack trace:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/Browning/.pyenv/versions/3.7.1/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File ".../scripts/controller.py", line 6, in <module>
    from framework import config, shared

  ...

  File ".../framework/data.py", line 30, in env
    value = getter()
  File ".../.venv/src/bullet/bullet/client.py", line 223, in launch
    ret = self.handle_input()
  File ".../.venv/src/bullet/bullet/keyhandler.py", line 41, in handle_input
    return handler(self)
  File ".../.venv/src/bullet/bullet/client.py", line 207, in interrupt
    raise KeyboardInterrupt
KeyboardInterrupt

And the terminal I am returned to no longer shows a cursor. Presumably bullet is not restoring the color scheme on KeyboardInterrupt?

I can't make the change myself at the moment, but it seems like cursor.show_cursor() should be moved out of accept() and put into the finally block of a try/finally around the while loop in launch(). (Also, this applies to a few classes, don't just get the first one.)


How to create prior_boxes_ssd300.pkl?

How to create this pkl file ?

please refer to this issue

@oarriaga
Oh, I missed it... Thanx 😀


Society Checking - 16963 - Iatmul

All songs assigned to 16963 except 9955, 9956, 887, 870, and 869 seemed to have appropriate lat-lons for Iatmul territory, and were close to lat lons for xd813 and language iatm1242. So I did not check those. Below are my notes for the 5 outliers listed above.
Songs 9955 and 9956:
Location in tape notes and metadata is listed as Aibom Village. However, metadata incorrectly locates Aibom Village on Kiriwina Island, and lat-lons are incorrect. Aibom Village is actually in Sepik Region, which corresponds better to Iatmul territory. Lat-lons should be corrected to -4.27, 143.19.
Note: Original Lomax tape notes say: "I put down culture as Iatmul-- M. Kirk says "Aibom is within Iatmul culture area and part of same language group. But has its own culture, music etc. Each village is a family."
Given that, it could be possible to separate songs 9955 and 9956 out and assign a new culture, "Aibom" to them. But not sure if necessary. If not, keep matched to xd813 and language iatm1242. @annalwood, what do you think?
Songs 887, 870, and 869:
Location and lat-lons in current metadata correspond to Baluan Island. Tape notes clarify that the performers are Iatmul plantation workers from Mindimbit Village, recorded on Baluan Island. So lat-lons should be corrected to -4.29, 143.39, and location should be corrected to "Mindimbit Village, East Sepik Province, Papua New Guinea [Recorded in Baluan Island, Admiralty Islands, Papua New Guinea]". Keep matched to xd813 and language iatm1242

Lat-lon corrections made, and Lomax note added to metadata. Songs 9955 and 9956 remain matched to Iatmul for now.