feat(table): add configurable fullSizeBp setting

Description
The LgTable currently always uses the non-mobile layout at and above the md breakpoint. However, if the table is placed in a container that does not fill the width of the screen then it can be desirable to show the mobile layout at larger screen widths.
This PR adds a new input which allows the consumer to specify at which breakpoint the full size layout should be displayed:
[fullSizeBp]="'sm'" or [fullSizeBp]="'md'" or [fullSizeBp]="'lg'"
It defaults to using md if not provided, so should not introduce a breaking change. I also improved the LgTable storybook Knobs to make them easier to use.
Requirements
Storybook link: https://deploy-preview-146--legal-and-general-canopy.netlify.app/
Checklist:

[x] The commit messages follow the convention for this project
[x] I have provided an adequate amount of test coverage
[x] I have provided a story in storybook to document the changes
[x] I have provided documentation in the notes section of the story

looks good and works well. just a few minor comments/questions @pauleustice  :-)

looks good and works well. just a few minor comments/questions @pauleustice  :-)

Nice one @pauleustice 👍
For everyone else, I used stack as an input for the radio buttons component but Paul rightly pointed out that that's not really mobile friendly. I'll be updating the radio component in a separate PR so that it's consistent with this approach.

@elenagarrone are you able to elaborate on that a bit? Do you mean you'll be changing the name of the input or is there more to it? I didn't quite pick up why it's not very mobile friendly.

Nice one @pauleustice 👍
For everyone else, I used stack as an input for the radio buttons component but Paul rightly pointed out that that's not really mobile friendly. I'll be updating the radio component in a separate PR so that it's consistent with this approach.

@elenagarrone are you able to elaborate on that a bit? Do you mean you'll be changing the name of the input or is there more to it? I didn't quite pick up why it's not very mobile friendly.

Nice one @pauleustice 👍
For everyone else, I used stack as an input for the radio buttons component but Paul rightly pointed out that that's not really mobile friendly. I'll be updating the radio component in a separate PR so that it's consistent with this approach.

@elenagarrone are you able to elaborate on that a bit? Do you mean you'll be changing the name of the input or is there more to it? I didn't quite pick up why it's not very mobile friendly.

@thatguynamedandy It's not mobile friendly as it is not applying the stacking (which should be the mobile/default layout of the component) by default. So the work would involve reversing the way the styles are applied, effectively.

Nice one @pauleustice 👍
For everyone else, I used stack as an input for the radio buttons component but Paul rightly pointed out that that's not really mobile friendly. I'll be updating the radio component in a separate PR so that it's consistent with this approach.

@elenagarrone are you able to elaborate on that a bit? Do you mean you'll be changing the name of the input or is there more to it? I didn't quite pick up why it's not very mobile friendly.

@thatguynamedandy It's not mobile friendly as it is not applying the stacking (which should be the mobile/default layout of the component) by default. So the work would involve reversing the way the styles are applied, effectively.

Sorry @pauleustice , just testing this again and I've found a slight inconsistency.
When in non-column mode on large mobile and the author label deselected the author label is not visible

however when in column mode still on large mobile and the display author label still deselected the author label is now visible

Sorry @pauleustice , just testing this again and I've found a slight inconsistency.
When in non-column mode on large mobile and the author label deselected the author label is not visible

however when in column mode still on large mobile and the display author label still deselected the author label is now visible


Unsubscribe link is broken.

The first unsubscribe link of the "Code caffeine - kata with your coffee!" messages redirects to a URL like
https://www.codewars.com/unsubscribe/newsletter?email=
which gives a 400 error page.
I just used the second link instead, but you probs wanna fix.

Thanks. I've removed the link for now (the 2nd one is now the only one).


Missing BaseBanner on sample app

I'm porting the library to Xamarin, but I can't find the BaseBanner class used by the sample app,
can you please commit BaseBanner source file?
Thanks!

https://github.com/H07000223/FlycoBanner_Master

I ended up by creating another example which doesn't require FlycoBanner.
Btw, here's the Xamarin port https://github.com/ararog/FlycoPageIndicator


/usr/local/include/google/protobuf/wire_format_lite_inl.h:352:17: error: comparison of integers of different signs: 'const uint32' (aka 'const unsigned int') and 'int'

/usr/local/include/google/protobuf/wire_format_lite_inl.h:352:17: error: comparison of integers of different signs: 'const uint32' (aka 'const unsigned int') and 'int'
[-Werror,-Wsign-compare]
if (new_bytes != length) return false;
~~~~~~~~~ ^  ~~~~~~
/usr/local/include/google/protobuf/wire_format_lite_inl.h:420:1: note: in instantiation of function template specialization
'google::protobuf::internal::WireFormatLite::ReadPackedFixedSizePrimitive<double, google::protobuf::internal::WireFormatLite::FieldType::TYPE_DOUBLE>' requested here
READ_REPEATED_PACKED_FIXED_SIZE_PRIMITIVE(double, TYPE_DOUBLE)
^
/usr/local/include/google/protobuf/wire_format_lite_inl.h:411:10: note: expanded from macro 'READ_REPEATED_PACKED_FIXED_SIZE_PRIMITIVE'
return ReadPackedFixedSizePrimitive<
^

git tag : v1.0.0
git commit: 2a69139aa7f609e439c24a46754252a5f9d37500

I'm sorry, but that error is a protobuf one, not a gRPC one. Please file a bug on the appropriate repository instead: https://github.com/google/protobuf
Thanks!

Updating to the most recent protobuf version should fix it.
https://github.com/google/protobuf/issues/1813


display better errors, including parsing and transformation errors in rapid CLI tool

The infrastructure is build as part of #151 .
It needs to be used more in a few places (semantic validation uses custom exceptions in a few places) when changes are made to these areas of code. Closing this issue for now


qa_crowbarsetup: nic net-name not working on cloud6

commit c209e28b added unrelated changes that cause breakage on cloud6:
ERROR (CommandError): Invalid nic argument 'net-name=fixed'.
Nic arguments must be of the form --nic
<net-id=net-uuid,v4-fixed-ip=ip-addr,v6-fixed-ip=ip-addr,port-id=port-uuid>,
with at minimum net-id or port-id (but not both) specified.

+1

why do we need to specify that anyway? it is launching in the tenant that has only one network. this was part of the test..

:+1:

:-1: there should be only one network visible, this is papering over some other bug somewhere.

+1

@dirkmueller: It is needed to be sure that we boot new instance in fixed network in case when there are some leftovers from previous run of mkcloud. We should be able to re-run mkcloud testsetup.

I pushed the revert to master for now to unbreak cloud6 and then we should discuss if/why this change is needed and where the 2nd network in this tenant comes from.

@bmwiedemann: thank you, I'm fine with that

closing as the commit that broke it was reverted


Feature Request: Allow trace root context in Dynamic Sampler FieldLIsts

Is your feature request related to a problem? Please describe.
Not a problem, just an enhancement of the current use of root context that can be added to Rule conditions.
Describe the solution you'd like
Currently, in rule conditions, you can prefix a field with root. to indicate that you only want the condition met if the attribute value is on the root span of a trace.
It would be really nice to add this to the capability of the FieldList in the dynamic sampler configurations, so that you can use a trace's root span data only, to reduce cardinality in the dynamic sampler keyspace.
Describe alternatives you've considered
Currently, users do this in instrumentation or with the collector with the transform processor.  But it would support automatic instrumentation better and be less work for customers to just be able to specify the desire to only use the root span in dynamic sampler field lists.
Additional context

Another request here: https://honeycomb.productboard.com/all-notes/notes/40970788

Further request for this in team internal slack. There seems to be some momentum behind this idea. Let's try to make it happen soon.

Also another here: https://honeycomb.productboard.com/all-notes/notes/41039789
It's an avalanche of feedback!


[ Do not merge ][Product Partnerships] Updated Amazon Sagemaker Dashboard

Relevant information

Checklist

[ ] I've read the guidelines and understand the acceptance criteria.
[ ] The value of the attribute marked as identifier will be unique and valid.
[ ] I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

LGTM

LGTM!!


[Trivial] Fix manual offer test

I broke this manual test with this commit: https://github.com/ripple/rippled/commit/e8d02c1333a1e72edadab4af629c49e848bfe16e This commit fixes that mistake.

Jenkins Build Summary
Built from this commit
Built at 20180501 - 21:08:27
Test Results

Build Type
Log
Result
Status

docs
logfile
1 cases, 0 failed, t: 2s
PASS :white_check_mark:

clang.debug.unity
logfile
1022 cases, 0 failed, t: 248s
PASS :white_check_mark:

msvc.debug
logfile
1018 cases, 0 failed, t: 564s
PASS :white_check_mark:

coverage
logfile
1022 cases, 0 failed, t: 617s
PASS :white_check_mark:

clang.debug.unity, PARALLEL_TESTS=false
logfile
1022 cases, 0 failed, t: 485s
PASS :white_check_mark:

clang.debug.nounity
logfile
1020 cases, 0 failed, t: 281s
PASS :white_check_mark:

gcc.debug.unity
logfile
1022 cases, 0 failed, t: 244s
PASS :white_check_mark:

gcc.debug.nounity
logfile
1020 cases, 0 failed, t: 253s
PASS :white_check_mark:

clang.release.unity
logfile
1021 cases, 0 failed, t: 328s
PASS :white_check_mark:

gcc.release.unity
logfile
1021 cases, 0 failed, t: 351s
PASS :white_check_mark:

gcc.debug.unity -Dstatic=true
logfile
1022 cases, 0 failed, t: 244s
PASS :white_check_mark:

msvc.debug, PROJECT_NAME=rippled_classic
logfile
1018 cases, 0 failed, t: 1168s
PASS :white_check_mark:

msvc.release
logfile
1017 cases, 0 failed, t: 509s
PASS :white_check_mark:

Codecov Report

Merging #2497 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2497   +/-   ##
========================================
  Coverage    70.67%   70.67%
========================================
  Files          696      696
  Lines        54440    54440
========================================
  Hits         38473    38473
  Misses       15967    15967

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a442d3f...f7e4be1. Read the comment docs.

Closed. Part of https://github.com/ripple/rippled/pull/2517 now.


Php-cs-fixer acts like "file fixed" but nothing changed

Hi,
I'm using Windows 10 x64. When I try to beautify a .php file, for example:
<!DOCTYPE html>
<html>
<body>

<?php

    $x = 10;
$y = 6;

echo                   $x + $y;
?>

</body>
</html>

Though the verbose message seems perfectly fine:

C:\Users\LAMFM95>php-cs-fixer -vvv fix "L:##Inspiration\L's Projects\N WEB\atom-etady\test.php"
You are running php-cs-fixer with xdebug enabled. This has a major impact on runtime performance.
.
Legend: ?-unknown, I-invalid file syntax, file ignored, .-no changes, F-fixed, E-error
Fixing time per file:
[0.314 s] L:##Inspiration\L's Projects\N WEB\atom-etady\test.php
Fixed all files in 0.320 seconds, 8.000 MB memory used

Nothing is changed in the test.php

In Atom, there're no issues on syntax notified. When run php-cs-fixer, it said "Your code look perfect... Nothing to fix!". I tried Atom-Beautify with necessary configuration but my code wasn't fixed.
I tried running php-cs-fixer using both .phar distribution and composer's installation but the problem was still there.
I switched between some PHP versions (5.5 5.6 7.1) but no help :(

Hi,
I think you setup might actually be fine. Could you try to modify this line
echo                   $x + $y;

into this;
echo                   $x     +   $y   ;

and run the tooling again? I would expect the fixer to fix the spacing after $x, + and $y.
The white space after echo and before $x is not fixed by the fixer ATM (but I tried mast branch only).
Kindly note that the fixer will report Fixed all files even if it didn't change anything. You can check the exit code if you want to know if something is changed (0 - nothing changed, 1 - something changed (for the 1.x releases)). Also if something is changed by a fixer it will show up in the output (as you are running the tooling with -vvv), so the absence of a list changes tells you nothing has changed on the file ;)

ping @lamnguyen95

@SpacePossum I have this same issue - Fixed all files in 0.087 seconds, 6.000 MB memory used
I purposely jacked up to code to make sure.
 <?php
			endwhile;
			 ?>
							<?php wp  _reset_pos tdata();?>
						</div>
			<?php } ?>

no change

@rgfx thanks for the follow up!
Looking at your example, the following would be the best outcome after fixing I think
 <?php
    endwhile;
?>
							<?php wp  _reset_pos tdata();?>
						</div>
			<?php } ?>

although the wp _reset... doesn't look like valid PHP to me.
What needs clarification on the issue is whether or not the fixer states that something does not need to be fixed while it does (would be a bug). Or the end user expected changes while there aren't (would be a missing feature, i.e. feature request). I suspect the later.

ping @lamnguyen95 and @rgfx , more details would help here :)

I'm closing this because the details to resolve this issue are not provided.
The request to fix more indent cases is notes, however this is not what the issue is about.
Thank you all for reporting, feel free to comment more on this if I missed something :)

@SpacePossum I have been experiencing this same issue for quite some time. I am on MacOS Sierra, not Windows, but I have the same results. PHP-CS-Fixer never proposes any changes. It's possible I'm a PHP rockstar, but I doubt it! I tried the basic example proposed by the @lamnguyen95 and added spaces after the $x and + and $y as you suggested. No changes by PHP-CS-Fixer occurred.

I have the very same issue

are you able to prepare full report with steps to reproduce ?

@keradus, I was wrong. php-cs-fixer is making changes to my code, just not helpful changes. I'll look into configuration.


Categorize returned data from Plaid

closing issue, not being tracked by developer; task process not determined or shared by SM as of yet


chore(deps): update devdependencies (non-major)

Looks like it's failing in ecosystem-tests using 3.15.0-integration-renovate.3
In dataproxy (cloudflare-workers, dataproxy, ubuntu-latest)
https://github.com/prisma/ecosystem-tests/runs/6396873000?check_suite_focus=true#step:6:163
👀<EMAIL_ADDRESS>Module not found: Error: Can't resolve 'child_process' in '/home/runner/work/ecosystem-tests/ecosystem-tests/dataproxy/cloudflare-workers/node_modules/@prisma/client/runtime'
resolve 'child_process' in '/home/runner/work/ecosystem-tests/ecosystem-tests/dataproxy/cloudflare-workers/node_modules/@prisma/client/runtime'
  Parsed request is a module
  using description file<EMAIL_ADDRESS>(relative path: ./runtime)
    Field 'browser' doesn't contain a valid alias configuration
    resolve as module
      /home/runner/work/ecosystem-tests/ecosystem-tests/dataproxy/cloudflare-workers/node_modules/@prisma/client/runtime/node_modules doesn't exist or is not a directory

and
dataproxy (vercel-edge-functions, dataproxy, ubuntu-latest)
https://vercel.com/prisma-orm/e2e-vercel-edge-functions/8Z9AbstMm5vjJtmJLxKP5yi9osfH

Link to 3.15.0-integration-renovate.4 which just started ⏩
https://github.com/prisma/ecosystem-tests/actions/runs/2312033019


[Feature]: Improve error reporting and command enablement in more cases when config cannot be loaded

Describe the feature you would like
Currently, when the config cannot be loaded, but we have the .taq folder, the TVsCE shows a JSON dump of the relevant parse error, and enables all commands.
While this unblocks the user, there might be specific parse errors where we can selectively enable/disable commands to give the user a better experience in case of such errors.
Also, the reported error details could be improved for some of those failure cases.
Is this feature solving a problem?
Details about the problem your feature solves
Please share any additional details you have?
Details about the problem your feature solves
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@Innkst @jevonearth
You can add details of any specific cases you might have in mind.
If not, I'll implement some that seem a reasonable balance of effort/value to me.

We are not aware of any more important conditions in which this change is necessary.
Closing.


Mime type header always returns original files mime type instead of new image mime type

Describe the bug
The original file is a PNG and my request is changing it to a WebP. The file returned is indeed a WebP, but in the response headers from AWS the "Content-Type" is still set to "image/png".
To Reproduce
Deploy version xxx to AWS with Auto WebP disabled.
Upload a PNG to S3
Request the file with the below parameters
{"key":"original.png","edits":{"webp":{"quality":80}}}
Expected behavior
I expect the "Content-Type" header to respond with "image/webp" matching the file type that has been returned.
Please complete the following information about the solution:

Version: v6.2.3
Region: eu-west-2
Was The solution deployed was unmodified.

Thanks for your report. We will investigate it and reply soon.

@MaxGiting
Can you try the following to see if this does what you need?
key: 'original.png', edits: { "toFormat": "webp","webp":{"quality":80}}

I am seeing a content-type: image/webp in the response headers.

Thank you yes that fixed the issue for me


selenium-webdriver: Update webdriver.WebDriver

This PR is still work in progress.
Target

javascript/webdriver/webdriver.js

Docs

selenium-webdriver

I'm trying to implement webdriver.By.Hash, but I'm not sure how to implement it.
webdriver.By.Hash is a Closure Llibrary style type alias.
If we assign webdriver.By.Hash, we get an undefined.
I think the assignment should have an error, because it have no meanings.
I want to implement the behavior, but I got the errors by the following code.
And strangely, the type definitions worked fine on the TypeScript playground page.
Please help me.
The code I tried
// minumum example
declare module webdriver {
	interface ILocatorStrategy {
		id(value: string): Locator;
                // ...
	}

	var By: ILocatorStrategy;

	module By {
		type Hash = { id: string } | { className: string } /* | ... */;
	}

	class Locator {
		using: string;
                // ...
	}
}

const By = webdriver.By; // ok
const locator = webdriver.By.id('a'); // ok
const locatorHash: webdriver.By.Hash = { id: 'a' }; // ok
const expectedFail = webdriver.By.Hash; // should be a compile error

The error I got by npm test
# npm test
...
selenium-webdriver/selenium-webdriver.d.ts(4784,9): error TS2300: Duplicate identifier 'By'.
selenium-webdriver/selenium-webdriver.d.ts(4786,12): error TS2300: Duplicate identifier 'By'.
...

const locatorHash: webdriver.By.Hash = { id: 'a' }; // ok
const expectedFail = webdriver.By.Hash; // should be a compile error

Note that webdriver.By.Hash is a type, if you can use it to be assigned, maybe you are doing it wrong. You should choose if it is either a type definition or a property, not both.

const locatorHash: { [key: string]: any } = { id: 'a' };

I don't believe this should be a type error, in this case, the property doesn't seem to be monotyped, it can either carry or don't carry a value, it isn't responsability of the type system per se. This could be fixed with monads - and also Haskell, with a powerful type system, has types and typeclasses to deal with computations that may fail:

data Maybe = Just t | Nothing
data Either = Left a | Right b
division :: Int -> Int -> Maybe Int
division 0 _ = Just 0
division _ 0 = Nothing
division x y = Just (x / y)

I appreciate your help, @haskellcamargo .

Note that webdriver.By.Hash is a type, if you can use it to be assigned, maybe you are doing it wrong. You should choose if it is either a type definition or a property, not both.

I meant that webdriver.By.Hash is a type definition.

I don't believe this should be a type error, in this case, the property doesn't seem to be monotyped, it can either carry or don't carry a value, it isn't responsability of the type system per se. This could be fixed with monads - and also Haskell, with a powerful type system, has types and typeclasses to deal with computations that may fail:

No, I think it should be a type error.
Because methods related the type (such as webdriver.WebDriver#findElement family) require a record that have only a property. We can pass a record that has multiple properties to the dynamic assertion and it make no errors, but it seems coincidence.
However, my implementation was not enough.
It pass invalid locators that have multiple properties.
I'm going to improve the definition to the following.
type Hash = { id: string, css?: void } | { css: string, id?: void };

// ok
const valid1: Hash = { id: 'a' };
const valid2: Hash = { css: 'b' };

// ng
const invalid1: Hash = {};
const invalid2: Hash = { id: 'a', css: 'b' };

I solved the issue.
I was misled into thinking that following code is impossible without using import declaration.
declare module webdriver {
    module By {
        function id(id: string): Locator;
    }
}

const By = webdriver.By; // can work!

I tried my best, but there are too large diff to me.
So types not updated are still remaining.
Would you review the current changes please?
And next time, I'm going to try to update the remained.

Hi, @BillArmstrong
I tried to update part of important types of WebDriverJS.
I'd like to review my changes, because I'm not sure this changes are right.
Would you review it please?

@BillArmstrong could you review this pull request?

I took a quick look last week, but it is a pretty significant change. I don't really have the time to give it the thorough review that it deserves.

@BillArmstrong okey! I try to wait until the next Sunday.

@vvakame, What can I do for merging it?

@BillArmstrong can you review now? I'll merge this pull request tomorrow.
@Kuniwak please add your name into definition header.

@vvakame Done.

@Kuniwak thanks mate!


[Question] Font Rendering

Is it normal that the subtitles takes several seconds to load after the video starts?
im checking the dev console and the fonts are preloaded the subs are preloaded but when the video starts it takes quite a while to render the subtitles after it starts

May i also ask why its using specific commits of libass, freetype, fribidi?

Is it normal that the subtitles takes several seconds to load after the video starts?
im checking the dev console and the fonts are preloaded the subs are preloaded but when the video starts it takes quite a while to render the subtitles after it starts
That's depends how many fonts you've preloaded. But with reasonable amout of fonts that shouldn't take so long (several seconds) to render subtitles after video starts. Even more, as you may see in example https://dador.github.io/JavascriptSubtitlesOctopus/videojs.html subtitles rendered before video even started.

So, do you experience same problem in example? If so, then what browser do you use?

May i also ask why its using specific commits of libass, freetype, fribidi?
There is no special meaning in them. I'm planning to update them to last version but that can make some troubles (like breaking patches) so I'm not done this yet.

There is no special meaning in them. I'm planning to update them to last version but that can make some troubles (like breaking patches) so I wasn't done this yet.

Ive been using the latest version of libass, i haven't touched the other commits due to most of them breaking when i do (mostly fribidi)

So, do you experience same problem in example? If so, then what browser do you use?

Im fine with the loading (did some testing with different players, JWPlayer and VideoJs seems to perform better in rendering the subtitles with minimal impact to time, flowplayer however suffers from this dillema.)
A question i had want t ask is with the implementation of the new way the fonts can be listed by name ( the question i had asked way back and then you put it in an update), Would it be possible to put those list of font names in a file that way everyone doesn't have to be inline?

A question i had want t ask is with the implementation of the new way the fonts can be listed by name ( the question i had asked way back and then you put it in an update), Would it be possible to put those list of font names in a file that way everyone doesn't have to be inline?

You can load fonts map via AJAX and then pass it to Octopus.
For example with jQuery:
 $.getJSON("http://link-to-json-with-fonts-map/", function (fonts) {
        window.SubtitlesOctopusOnLoad = function () {
            var options = {
                video: video,
                subUrl: '/example/test.ass',
                availableFonts: fonts, // All available fonts (font name should be lower case). It will load only fonts really used in sub.
                //onReady: onReadyFunction,
                //debug: true,
                workerUrl: '/js/subtitles-octopus-worker.js'
            };
            window.octopusInstance = new SubtitlesOctopus(options); // You can experiment in console
        };
        if (SubtitlesOctopus) {
            SubtitlesOctopusOnLoad();
        }
    });

thanks

this is general question, but is to possible to load this in chromecast?

I'm not sure about styled subtitles (don't know nuances how chromcast works). But looks like you can add simple subtitles (vtt):
https://developers.google.com/cast/docs/chrome_sender_advanced
https://github.com/benjipott/video.js-chromecast

Yes: https://support.google.com/chromecast/answer/3228332?hl=en

I'm closing this issue as question seems to be resolved.


Retire nunjucks?

I'm finding I'm spending more time fighting with nunjucks than getting things done, when I want to use macros, variables, globals, etc.
I don't remember it being this way in the past, and troubleshooting is problematic.
Maybe it's time to consider an alternative?

webc | github
liquidjs

See time to move on from nunjucks.

Looks like the problem was the markdown rendering engine which was changing quotes, breaking nunjucks interpretation of things like macros. So... not a nunjucks problem.


fix(set): map uniqueness

Description

When mapping over a set it is possible to introduce duplicate values which is undesirable.
$set = new \Ramsey\Collection\Set('integer', [1, 2, 3]);
$set->map(fn () => 42);

Motivation and context

This change is so that the behavior of the implementation is respected such as in this case the duplicate values in a Set.
How has this been tested?

Tests have been added for the Set and Collection implementations that a instance of themselves is returned and that when mapping over an existing Set not duplicate values can be introduced.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to change)
The actual return types as declared have not changed but in the case of the Set a new Set is now returned instead of a Collection as well as the new mapping behavior for the Set that does now not allow duplicate values anymore.

PR checklist

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING.md document.
[X] I have added tests to cover my changes.

I'm not sure map was meant to preserve the class implementation. It just maps all the values to a generic collection (you can also see the value type is mixed instead of using the current type). It will likely break things for a few projects.

I see the BC concern but I also feel like when I'm manipulating a set I want it to behave like a set. Maybe this can be merged into a v3 branch but I think this is an important change.

Laravel's collections have a mapInto function accepting the collection class name as a second parameter. If the maintainer is open to something like that maybe it could be a good compromise for your use case.

I think the best approach would be to override the map() method on the Set class, rather than introducing the protected $collection property.
That said, map() returns a CollectionInterface. It's not intended to make guarantees about the data it returns. The library is designed to be generic and flexible, allowing you to extend it for your application's needs. I think you could extend it with something like this to achieve your goals:
/**
 * @extends \Ramsey\Collection\AbstractSet<Foo>
 */
class MySet extends \Ramsey\Collection\AbstractSet
{
    public function getType(): string
    {
        return MyType::class;
    }

    /**
     * @param callable(MyType): TCallbackReturn $callback A callable to apply to each
     *     item of the collection.
     *
     * @return MySet
     *
     * @template TCallbackReturn as MyType
     */
    public function map(callable $callback): \Ramsey\Collection\CollectionInterface
    {
        return new self(array_map($callback, $this->data));
    }
}

I see your point about not introducing a $collection property but I found the map implementations too similar to override them, alternatively one could in the AbstractCollection create a new static collection this way you'd automatically get the correct implementation, although we would then have to take care with the constructor arguments.
I don't think this change would take away any flexibility of the library we would simply ensure the correct behavior for any implementation of a collection and it still allows users to extend any collection they want to add their own behavior.

we would simply ensure the correct behavior

Is is correct behavior for the map function to always return the same type of collection?

I would argue so yes, when I create a new Set I expect it to behave a certain way and until I explicitly say make this Set into a Collection, or Whatever I want to be sure in the assumption that I am working with a Set.


php version colision in 1.5.0 tag

In 1.5.0 tag (major under 2.0.0) specified php>=5.5.5, but it depends on sabre/uri with version gap >=1.0,<3.0.0. sabre/uri version >2.0.0 depends on php>7. Thus, if i try install sabre/xml<2.0.0 with php < 7, it's fails with not satisfy requirement.

No when you install it on PHP 5.x it will automatically install sabre/uri 1.x. if this is wrong l, please produce proof.


[Android] Always apply configured Actions.IconSize

Related Issue
Fixes #5567
Description
Fixes Android renderer to match JS behavior of applying HostConfig.ActionsConfig.IconSize always, not just when placement is above title. Previously, we were setting image height to match text height when placement is left of title.
However, this change results in a poor default (see screenshot below), because the default is arbitrarily set to 30 in the shared model. So, any host currently using iconPlacement: LeftOfTitle will need to newly configure their iconSize to restore the previous size.
If this is not a default we want, we could remove the arbitrary default in the object model (and make it optional), to allow the renderer to use a good default (i.e. icon height matches text height).
Sample Card
v1.2\Elements\Action.IconUrl.TwoActions
How Verified
(using default host config values)
Before PR:

After PR:

Microsoft Reviewers: Open in CodeFlow

I think the choice of 30px as a default is what is problematic here. The typical size of a button icon is 16px. I think you should change the default to 16px, which is what JS uses.

I think the choice of 30px as a default is what is problematic here. The typical size of a button icon is 16px. I think you should change the default to 16px, which is what JS uses.

@dclaux
mobile platforms (iOS & Android) and probably UWP use the title height of the button for the image height when iconPlacement is LeftOfTitle. I don't have objections to change to use the iconsize for the icon even it's for LeftOfTitle. We probably have good reasons why we did this way. c.c. @jonmill @matthidinger @RebeccaAnne @paulcam206 @almaasrawi @golddove

My recollection was that it was intentional to use text height rather than icon size when the icon is left of the title, and in general I think that's a good approach. What would the above title button look like if we size the default down to 16? I suspect it would look a little too small in that case. For what it's worth the default of 30 is consistent with the documentation (ActionsConfig).
That said, it is weird to have an iconSize property but not always respect it (especially given that that behavior is not documented). I like @golddove's idea of having it be optional and having the renderer default to text height for left of title and the documented default (30) for above title. That seems like the best of both worlds in terms of letting us do the reasonable default but also respecting any explicit value from the host.
In any case, if we stick with the approach in this PR we'll need to check the other platforms as well as I suspect everyone except JavaScript is doing it the way Android was. We should also make sure to update the docs with whatever we land on.

What would the above title button look like if we size the default down to 16? I suspect it would look a little too small in that case. For what it's worth the default of 30 is consistent with the documentation (ActionsConfig).

16 looks fine on Android:

I only suggested using 16 in place of 30 where 30 is currently used as a default, not to change other logic such as using title height.

Documenting outcome from standup: match current JS behavior (i.e. always respect iconSize, and default to 16 when unset)

If you haven't already could you log bugs to update the other renderers to use this behavior and reference this PR so we've got breadcrumbs back to the decision making? Otherwise looks good.

Logged UWP bug, and added comment to existing iOS bug,


[FLINK-21254] Add Created state for DeclarativeScheduler

What is the purpose of the change
Declarative Scheduler consists of a number of internal states. This PR is based on #14852 (the first two commits are from #14852, remaining commits are to be reviewed here).
Note that this change is currently not usable as-is, as the other parts of declarative scheduler are not merged yet (See for the prototype this PR is based on: https://github.com/tillrohrmann/flink/tree/declarative-scheduler)
Verifying this change

The change is adding unit tests.
Note that integration tests for the declarative scheduler will cover additional functionality.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation
Will be handled in a separate PR.

Thanks a lot for the review. I addressed all your comments and rebased to the latest master, which now contains the WaitForResources PR stuff.

Thanks a lot for your review! Merging ...


How to cite this robothor env

I use this env in my paper and I wonder how cite it.

Please refer to the following page: https://github.com/allenai/ai2thor#citation


Terraform scripts to manage the AWS CloudFront deployments for all Data Browser instances

Configure a default root object per #3006.

Completed.


Smoothstate.js & Velocity.js

I'm trying to make a smooth fade with smoothstate and velocity.
;(function($) {
  'use strict';
  var $body = $('html, body'),
      content = $('#main').smoothState({
        // Runs when a link has been activated
        onStart: {
		      render: function (url, $container) {
		        $("#main").velocity("fadeOut", { duration:1000 });
		      }
        }
        onEnd: {
        	render: function (url, $container) {
    			$("#main").velocity("reverse");
       	 	}
       	}
      }).data('smoothState');
})(jQuery);

It almost works. The small problem ist, that the page fades out and never fades back in. Why is that?
Shouldn't onStart fade the old page out and then onEnd fade the new page back in?

Hello @Seppentoni, do you have a live testing site we can refer to?

Not yet. But I'll push it today.

just notice a small mistake in the code u post,
u missed a " , " comma before the onEnd:
;(function($) {
  'use strict';
  var $body = $('html, body'),
      content = $('#main').smoothState({
        // Runs when a link has been activated
        onStart: {
              render: function (url, $container) {
                $("#main").velocity("fadeOut", { duration:1000 });
              }
        },
        onEnd: {
            render: function (url, $container) {
                $("#main").velocity("reverse");
            }
        }
      }).data('smoothState');
})(jQuery);

Hi @Jonathlee
Alright. I pushed the alpha onto the server: http://stage.aare.guru/
The first two links are triggered "Luft" and "Wasser". If you click one of these, the page will fade and then thats it. What is the issue there?

plz try this code, it works on my side.
;(function($) {
  'use strict';
  var $body = $('html, body'),
      content = $('#main').smoothState({
		  prefetch: true,  development : true,
		  pageCacheSize: 4,

		  // in progress of loading
			onProgress : {
				duration: 0, // Duration of the animations, if any.
				render: function (url, $container) {
					$body.css('cursor', 'wait');
					$body.find('a').css('cursor', 'wait');
					}

			},
			onEnd : {
				duration:4000, // Duration of the animations, if any.
				render: function (url, $container, $content) {
					$body.css('cursor', 'auto');
					$body.find('a').css('cursor', 'auto');
					$container.html($content);
					$('#content').velocity("fadeIn", { duration: 3500 });
					$(document).ready();
					$(window).trigger('load');

				}
			},

			// Runs when a link has been activated
			onStart: {
			  duration:4000, // Duration of our animation
			  render: function (url, $container) {
				$('#content').velocity("fadeOut", { duration: 3500 });
			  }
			}
		  }).data('smoothState');

      //.data('smoothState') makes public methods available
})(jQuery);

It works :) Great! What exactly does the additional code do?

prefetch = when your mouse hover to certain link, smoothstate will fetch the content from the link to be to replace the content.
development = meant for debugging in console, please remove this line when you publish it.
pageCache = size of page cache file,
you can refer to most of the stuff in the document page.


Need better instructions on adding Windows support for native modules

microsoft/react-native-windows#4993 renamed the package react-native-windows-override-tools to react-native-platform-override. However RNW 0.62 still uses the old name which is not available on npmjs/yarnpkg
Repro:

clone a native module repo to add support for windows (e.g. clipboard)
follow the instructions and run yarn add<EMAIL_ADDRESS>--peer
cd node_modules\react-native-windows and run yarn, you get a error about missing package:
error An unexpected error occurred: "https://registry.yarnpkg.com/react-native-windows-override-tools: Not found".

If I replace the entry in RNW's package.json with react-native-platform-override then I get prompted for what version to use. If I choose 0.0.1 then yarn build later fails when trying to build react-native-windows-codegen because the published package doesn't include a built-to-javascript cli.js so I have to manually go into clipboard\node_modules\react-native-windows\node_modules\react-native-windows-codegen\ and run yarn build there manually

Steps here should be made to be correct: https://microsoft.github.io/react-native-windows/docs/native-modules-setup#adding-windows-support-to-an-existing-library
It's suspected that these steps may be creating issues for modules migrating from 0.62 to 0.63. The instructions set you up to work for exactly 0.62.0, not 0.62 and greater.
Side note, that isn't the most discoverable document. I'd argue it should be a top-level document, not a part of another one.

Duplicate of #253


如何通知GNet关闭某个链接？[Question]:

Actions I've taken before I'm here

[X] I've thoroughly read the documentations about this problem but still have no answer.
[X] I've searched the Github Issues/Discussions but didn't find any similar problems that have been solved.
[X] I've searched the internet for this problem but didn't find anything helpful.

Questions with details
如何通知GNet关闭某个链接？gnet v2.3.1
场景：
一个用户开多客户端 重复链接服务器，要断开前一个链接，保持后一个链接
在收到一个后一个用户的链接数据登陆请求识别到用户id后，直接用前一个链接的gnet.Conn 的Close 关闭链接不行吧？
Code snippets (optional)
No response

直接用前一个链接的gnet.Conn 的Close 关闭链接不行吧？

为什么不行？


Add a "multi-sensor" examples + library code

Multiple different/independent sensors
Multiple sensors (used in cooperation) (sensors with different ranges)

Fixed in https://github.com/jeroendoggen/Arduino-distance-sensor-library/pull/7


default_port() takes a scheme but not a protocol()

auto const myurl = url("https://exampe.com");
url::default_port(myurl.protocol()).has_value(); // false

So, protocol() returns https: but default_port() needs a scheme (no ':'). Plus, there is no url::scheme() provided. Is this some overlooking ? Having to strip the ':' every time is annoying.

That's a simple fix, I'd appreciate a short review of #136 to make sure I captured what you asked for.

Fixed in #136


Question: How do I properly use BITFIELD! contained within a UNION! ?

I am trying to figure out how to finish out iphlpapi.h and related files. In shared/ifdef.h there is a union that has a struct with bitfields in it. This is causing me some grief as I am very noob, both with public contributing and C/FFI.
Here is the block from ifdef.h:
typedef union _NET_LUID_LH
{
    ULONG64     Value;
    struct
    {
        ULONG64     Reserved:24;
        ULONG64     NetLuidIndex:24;
        ULONG64     IfType:16;                  // equal to IANA IF type
    }Info;
} NET_LUID_LH, *PNET_LUID_LH;

Here is what I am trying to do in rust:
UNION!{union NET_LUID_LH {
    [u64; 1],
    Value Value_mut: ULONG64,
    Info Info_mut: ULONG64,
}}

BITFIELD!{NET_LUID_LH Info: ULONG64 [
    Reserved set_Reserved[0..24],
    NetLuidIndex set_NetLuidIndex[24..48],
    IfType set_IfType[48..64],
]}

The issue is, the compiler complains about using "Info" as a value instead of calling it as a method. When I look at the UNION macro code, (I can barely understand macros), it looks like each field is turned into a method. So to access the "Info" field on the union, it would technically be calling a method, if I understand correctly. However, I can't call Info() within the BITFIELD macro as it doesn't expect those characters.
Here is the error message in rust, which appears to be the result of the macro
error[E0615]: attempted to take value of method `Info` on type `&mut shared::ifdef::NET_LUID_LH`
  --> src\shared\ifdef.rs:76:23
   |
76 | BITFIELD!{NET_LUID_LH Info: ULONG64 [
   |                       ^^^^
   |
   = help: maybe a `()` to call it is missing?

Can someone help me understand how to properly write this?
EDIT: Atteched Error output from cargo

I think I may have figured out the correct way to do it. I've been taking a new look at this and comparing it to existing usage of UNIONs and BITFIELDs.
This is what I have come up with and so far seems to test OK.
STRUCT!{struct NET_LUID_LH_s {
    bitfield: ULONG64,
}}
BITFIELD!{NET_LUID_LH_s bitfield: ULONG64 [
    Reserved set_Reserved[0..24],
    NetLuidIndex set_NetLuidIndex[24..48],
    IfType set_IfType[48..64],
]}
UNION!{union NET_LUID_LH {
    [u64; 1],
    Value Value_mut: ULONG64,
    Info Info_mut: NET_LUID_LH_s,
}}
pub type PNET_LUID_LH = *mut NET_LUID_LH;

From original C source:
typedef union _NET_LUID_LH
{
    ULONG64     Value;
    struct
    {
        ULONG64     Reserved:24;
        ULONG64     NetLuidIndex:24;
        ULONG64     IfType:16;                  // equal to IANA IF type
    }Info;
} NET_LUID_LH, *PNET_LUID_LH;

Can someone confirm if that looks correct?

Awesome! That was a bit of a learning curve for me. Thank you for the help @retep998 !


FIX: windows package fails with: AttributeError: SECP256K1_CONTEXT_SIGN

The windows build process requires the integer definition of the SECP256K1 #define flags

@ofek How can we verify that it actually fixes the issue?


Nuxt 3.7.0 Two component files resolving to the same name ProsePre

Environment

Operating System: Darwin
Node Version:     v18.16.1
Nuxt Version:     3.7.0
CLI Version:      3.7.3
Nitro Version:    2.6.2
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools, modules
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
package.json
{
  "name": "nuxt-app",
  "private": true,
  "scripts": {
    "build": "nuxt build",
    "dev": "nuxt dev",
    "generate": "nuxt generate",
    "preview": "nuxt preview",
    "postinstall": "nuxt prepare"
  },
  "devDependencies": {
    "@nuxt/content": "^2.8.2",
    "@nuxt/devtools": "latest",
    "nuxt": "^3.7.0"
  }
}

nuxt.config.ts
// https://nuxt.com/docs/api/configuration/nuxt-config
export default defineNuxtConfig({
  devtools: { enabled: true },
  modules: ["@nuxt/content"]
})

Describe the bug
Nuxt 3.7.0 With Nuxt Content 2.8.2 Show warning in terminal Two component files resolving to the same name ProsePre
<EMAIL_ADDRESS><EMAIL_ADDRESS>Additional context
No response
Logs
No response

Have same Error.

This is because nuxt/content assumes the creation of files like ProseImg, ProseP and others. But Nuxt implements experimental support for components on the server and a check for the same names is written in the component auto-registrar. This needs to be edited on the nuxt/content side I think.
Create there issue for this https://github.com/nuxt/content/issues/2285

This might be a duplicate of https://github.com/nuxt/nuxt/issues/22876 🤔

@manniL duplicate, but not solved at all

@wokalek did you try it on the edge channel? The linked PR should solve the issue but is not yet released.

@wokalek did you try it on the edge channel? The linked PR should solve the issue but is not yet released in a stable version.

It looks like the problem with the 502 error was due to the fact that Nuxt now requires the --host flag to be specified when creating the server. And since I have it inside Docker, it was necessary.
However, warnings about duplicate components remain, but they do not carry any danger, they only inform about it.

It looks like the problem with the 502 error was due to the fact that Nuxt now requires the --host flag to be specified when creating the server. And since I have it inside Docker, it was necessary.

See https://github.com/nuxt/nuxt/issues/22150

However, warnings about duplicate components remain, but they do not carry any danger, they only inform about it.

Exactly 👍

If you use Nuxt content, you want to follow https://github.com/nuxt/content/issues/2266. A fix PR is up already but it should not influence your code.


chore: automatic backport

Backport b401cce30f686e903dc48d65fe8cb7be97135462 from #498

@iliapolo Looks like the DCO check is failing... I guess this is a bug with the GitHub action? Maybe it's possible we can fix this upstream with a small PR


Title: Add Netflix home page clone in basic web development project

Initiative (Required)
GSSoC (Girl Script Summer of Code) 🌸
Is your feature request related to a problem? Please describe.
It's beginners friendly and a good project to practice webdev
Describe the solution you'd like.
I would like to work on this project. Please assign this issue to me.
Add any other context or screenshots about the feature request here.
No response

Hey I am the mentor of this project
@MaahiVaghela  Hello Thank you for opening the pull issue and you can opening new issue by creating the new concept those are not exist in the project !!
@Kushal997-das kindly close the issue since it already exist in our project.


Bug - Fix case for azureIotPrivateDnsZoneId parameter in policy assignment

Overview/Summary
A case difference in a policy parameter vs a policy assignment was causing an idempotency issue with Terraform. This PR corrects the casing and fixes the bug.
This PR fixes/adds/changes/removes

#699

Breaking Changes
None
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[ ] Performed testing and provided evidence.
[x] Updated relevant and associated documentation.

/azp run update

LGTM thanks @jaredfholgate

/azp run unit


Connection problems with 9.01

I realize that release 9.01 has been pulled from GitHub. Could you elaborate on the reasons? I currently run 9.01, at first without problems, but suddenly I've got massive connectivity problems. Might this be connected to the issues because of which you pulled 9.01?

Nukihub looses connection to MQTT broker all the time
Homeassistant seems not to pick up the MQTT connection again even if Nukihub is connected, so the Nuki devices are offline most of the time.
Flashing from scratch with the web flasher always gives me 9.01 and not 9.0
Updating from the integrated updater to the latest beta or some development version does not work at all. Basically this bricks the NukiHub and it has to be re-Flashed from scratch.
Using the Wifi configuration menu to connect to another Wifi network does not work, the AP is reachable, but the configuration page does not show.

Some of the symptoms seem to be related to constant Wifi connections losses, because issues 1 and 2 can be cured by re-positioning NukiHub away (!) from the router, (however, it has worked in its original position literally for years without flaws). So maybe these are different problems only occuring at the same time by chance.

I have to correct myself: Trying to flash to a beta from 9.01 does not brick the device. After some relatively long wait the hub returns online, but still with 9.01.

9.02 is on track to be released soon, maybe it's a good idea to just wait for it. Also, it's hard to tell what's going on with flashing, be it OTA or web flasher. After that much trying to flash back and forth, the easiest thing to do maybe is to erase your ESP and do a factory reset to start with a clean slate, and then flash to 9.02 when it's released.

I have the same issues.
Upgraded to latest beta - 9.02-beta7 but still get those restarts due to NetworkTimeoutWatchdog. Would love to help resolve this

This didn't happen before 9.01 ofcourse

We will not be debugging issues with 9.01, it was pulled for being to unstable.
Flash 9.0 using the release on GitHub and esptool or wait for 9.02 or flash a 9.02 beta.
Retrying OTA update to 9.02 beta should also work (there was an issue with converting WiFi settings going from 9.0/9.01 to 9.02 which required you to trigger the OTA update twice).
@regevbr: If you are having issues with 9.02 beta's create your own issue and provide USB/serial logs right before the NetworkTimeoutWatchdog triggers and follow the issue template to share your current settings.

I was not able to upgrade to a newer beta version from a configured 9.01. Which was a bit awkward, as the web flasher still always flashes 9.01 and not 9.0 (which means that currently everybody following the installation instructions will end up with an problematic firmware version).
However, I was able to upgrade from 9.01 to a newer revision as long as the 9.01 installation was not yet configured.

We will not be debugging issues with 9.01, it was pulled for being to unstable. Flash 9.0 using the release on GitHub and esptool or wait for 9.02 or flash a 9.02 beta. Retrying OTA update to 9.02 beta should also work (there was an issue with converting WiFi settings going from 9.0/9.01 to 9.02 which required you to trigger the OTA update twice).
@regevbr: If you are having issues with 9.02 beta's create your own issue and provide USB/serial logs right before the NetworkTimeoutWatchdog triggers and follow the issue template to share your current settings.

@technyon web updater of 9.0 firmware propose to update to 9.0.1, so many people colud update to this version and come in problems of 9.01...there is a way to stop it? you already removed 9.01 from stable version, but why web updater propose again 9.0.1 as the lastest stable version?

Since updating to 9.0.2 I have 4 devices unable to connect to MQTT, what's the needed information to be able to resolve this?

Seems to be a different problem than mine. Once I was able to get rid of 9.01 (which was not so easy),  I was able to use NukiHub again with more recent betas and also  9.02.
But the configuration has changed a bit, the common hub options are now separate from locks and openers, and I have the feeling that something got messed up here.
But as I currently have a working 9.02(beta) setup (from scratch),  I'm closing my report now.


Getting this exception when running tests

com.netflix.zuul.exception.ZuulException: 429
I m not sure that if it is the normal behavior, because, mvn test phase ends successfully, but not sure at all.
install phase ends successfully too.
$ java -version
openjdk version "1.8.0_242"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_242-b08)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.242-b08, mixed mode)
$ mvn -version
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec
Java version: 1.8.0_242, vendor: AdoptOpenJDK, runtime: /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre
Default locale: es_ES, platform encoding: UTF-8
OS name: "mac os x", version: "10.15.5", arch: "x86_64", family: "mac"

Hi @alonsoir,
This exception is thrown by GreetingControllerUnitTest#whenRequestExceedingCapacity_thenReturnTooManyRequestsResponse test case. It verifies that 429 error code is returned when the rate limit is exceeded (one request per 2 sec in our case).
So yeah the exception looks OK.


[NEMO-64] Fix map stage hang under DataSkewPolicy

JIRA: NEMO-64: Fix map stage hang under DataSkewPolicy
Major changes:

Data for dynamic optimization is aggregated at DynOptDataHandler in Scheduler instead of a variable in MetricCollectionBarrierVertex. Updating MetricCollectionBarrierVertex as data arrives in RuntimeMaster clashed with serializing IRDAG for scheduled Tasks, which caused ConcurrentModificationException and silently killed the Scheduler

Minor changes to note:

Removed now unused entries in dataSizeMetricMsg
Added DataSkewMetricProperty and MetricFactory to make task hash ranges of shuffle edges as an execution property, so that RuntimePass can optimize the given IR DAG

Tests for the changes:

N/A(No new features, covered by PerKeyMedianITCase)

Other comments:

Data for dynamic optimization will be aggregated in designated vertex and not in the RuntimeMaster via upcoming PR for NEMO-99

resolves NEMO-64

@seojangho Please also take a look at this PR. 😄

It'd be also nice to add a unit test that hangs with the current master branch code, and does not hang with this PR.

@johnyangk Thanks for the review, I've addressed most of your comments.
As there are upcoming PRs for refactoring dynamic optimization which change current execution model of dynamic optimization. Can I resolve the left issues, such as adding the suggested unit test, with those PRs?


fix field: add ctor for base type

Codecov Report

Merging #33 (f0438da) into master (9fd6668) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   99.68%   99.68%
=======================================
  Files          26       26
  Lines         631      631
=======================================
  Hits          629      629
  Misses          2        2

Impacted Files
Coverage Δ

include/protopuf/field.h
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd6668...f0438da. Read the comment docs.


Issue/add deprecated short code

Summary
BEN:
I'm proposing we use a {{< deprecated-in-version "3.11" >}} shortcode and deprecated_in_version: "3.11" Front Matter to mark deprecated features, and we write a custom {{< warning "This feature will be deprecated on Cloud in January >}} in content if necessary to provide additional information. We might have deprecated features that don't apply to certain distributions, so it's better not to over engineer that warning.
I've pushed commits that produce the following:
Card:

Content page:

OLD:
Proposing short codes for deprecation warning and inline Deprecated label. Also labeling Pub/Sub integration as deprecated.
Reference #106
Changes
Examples of usage in the documentation:

Checklist

[x] Scope: The referenced issue is addressed, there are no unrelated changes.
[x] Run Locally: Verified that the docs build using make server
[ ] New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
[ ] Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
[ ] Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

@nejraselimovic , please add a Front Matter element for this as well. You can see exactly how I did it for "new-in-version" here -> https://github.com/TheThingsIndustries/lorawan-stack-docs/pull/109/files
Basically, you change the html shortcode you have in to a partial (so that you can reuse it in both the shortcode and in the layout).
In the shortcode, you simply call the partial, and then in the layouts for list and single, you also call the partial so that you get markup on the page from the Front Matter. Take a look at the PR and then lemme know if you need a hand

I'm proposing we use a {{< deprecated-in-version "3.11" >}} shortcode and deprecated_in_version: "3.11" Front Matter to mark deprecated features, and we write a custom {{< warning "This feature will be deprecated on Cloud in January >}} in content if necessary to provide additional information. We might have deprecated features that don't apply to certain distributions, so it's better not to over engineer that warning.
I've pushed commits that produce the following:
Card:

Content page:

@benolayinka I pushed a fixup for PubSub because it is only about to be deprecated in January 2021. I can update the warning after #108 is merged


Add a user activity page to highlight suspicious activity

Currently on PyPI, whilst there is a per-package activity table, there isn't anything that shows user activity.
To make account compromise more obvious, it would be great to have a user activity page on Warehouse, that shows:

Recent failed login attempts
Recent successful login attempts
2FA enabling/disabling/adding of new devices (once we have #996)
Recent actions performed against packages under the user's control (eg new version uploads, owner/maintainer addition/removal)
Timestamp, IP addresses and geolocation for all of the above

I'd like to make something similar to what GitHub has, where they have a "Security" page in the user settings (and in the organization settings, which we should also mimic once we get organizations) that shows all of this information. Example:

Clicking on one of the entries shows information like:

This is almost certainly going to be a post-launch task though.

What would be awesome would be to have some event bus backend (Kafka or similar) that could service dispatched events (perhaps aggregated by statsd). Then, we could have consumers that would be responsible for reading the data and sending it along to various sources, one of which could be a service such as the above. We could then also take a look at feeding that data into Graphite (or some other metrics system) to provide an overall view of system health.
@dstufft: Is there currently architecture for something along those lines, or would that need to be investigated?

I'd like to make something similar to what GitHub has

Perfect - their security page was exactly what I had in mind when I filed this issue.

This is almost certainly going to be a post-launch task though.

Yeah I imagined this and the other issues I filed would be post-launch - I just wanted to make sure we had something on file to track the future work :-)

I think this is a great idea but I'm marking it for a future milestone to indicate that we shouldn't block launching the new PyPI on this issue. :)

I'm pretty sure this depends on, and thus is blocked on, #5863. Heads-up @woodruffw -- once you get to that issue, I'd love you to leave a comment here clarifying what subset of the requests above are supported by the new logging.

Now unblocked! @edmorley see #6339 for events currently being logged. Is that enough to close this issue? I think it is but I want you to double-check.

@brainwane Hi! Yeah that list of now-logged events looks great - thank you :-)


upload to test.pypi should not be triggered on PR

However, it is triggered and fails in #49

this is test for test.pypi should be triggered to validate if change do not brake build and deploy


Derived roles don't work

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Derived roles are not applied to principals and policies based on derived roles don't work.
Expected Behavior
Derived roles should be correctly applied.
Steps To Reproduce

Go to Cerbos Playground: https://play.cerbos.dev/new?generator
Generate a new project
Add a derived roles file /derived_roles/common_roles.yaml

# yaml-language-server: $schema=https://api.cerbos.dev/latest/cerbos/policy/v1/Policy.schema.json
# docs: https://docs.cerbos.dev/cerbos/latest/policies/derived_roles
apiVersion: api.cerbos.dev/v1
derivedRoles:
  name: common_roles
  definitions:
    - name: owner
      parentRoles:
        - user
      condition:
        match:
          expr: request.resource.attr.ownerId == request.principal.id

Edit the test resouces file resource_policies/testdata/resources.yaml to add the ownerId: user#1 attribute to the resource.

# yaml-language-server: $schema=https://api.cerbos.dev/latest/cerbos/policy/v1/TestFixture/Resources.schema.json
# docs: https://docs.cerbos.dev/cerbos/latest/policies/compile#_sharing_test_fixtures

resources:
  basicResource#1:
    id: basicResource#1
    kind: basicResource
    attr: {
      ownerId: user#1
    }

Edit the resource policy for any action to allow the 'owner' role instead of the 'user' role and import the created derived common_roles.

# yaml-language-server: $schema=https://api.cerbos.dev/latest/cerbos/policy/v1/Policy.schema.json
# docs: https://docs.cerbos.dev/cerbos/latest/policies/resource_policies

apiVersion: api.cerbos.dev/v1
resourcePolicy:
  importDerivedRoles:
    - common_roles
  resource: basicResource
  version: default
  rules:
    - actions:
        - create
      effect: EFFECT_ALLOW
      roles:
        - user
        - admin
    - actions:
        - read
      effect: EFFECT_ALLOW
      roles:
        - owner
        - admin
    - actions:
        - update
      effect: EFFECT_ALLOW
      roles:
        - user
        - admin
    - actions:
        - delete
      effect: EFFECT_ALLOW
      roles:
        - admin

When the tests now run, user#1 will not be allowed to read basicResource#1 even though basicResource#1 has the correct ownerId attribute.

Adding the condition request.resource.attr.ownerId == request.principal.id in the resource policy itself does work as expected.
Environment
- Cerbos Playground: https://play.cerbos.dev/new?generator

Anything else?
No response

Hello. You need to be explicit in the resource policy that you're trying to use a derived role. So, the rule should read as follows:
    - actions:
        - read
      effect: EFFECT_ALLOW
      derivedRoles:
        - owner
      roles:
        - admin

Hi, thanks, this indeed does the trick.
It's super easy to miss this in the docs, I've only found it once in a snipped in an example now that I've searched the docs on derivedRoles. Might be a good idea to make this more explicit somewhere in the documentation.
Thanks again!


Readme fix: provide users instructions how to use custom key pair for publishing messages

update readme file with helpful instructions for users who want to sign a message from a specified account when publishing messages.

you should add the .from_npub and .from_nsec functions too. They allow you to load the keys in the bech32 format


JsonLayout - EscapeForwardSlash should be nullable

Trying to resolve  #3741. But it will only apply to direct sub-attributes.
If a nested attribute embeds a JsonLayout using encode="false", then it will not inherit the configuration from the top-JsonLayout (There is no guaranteed of the order of initializing NLog Layouts)

Great!

Great work thank!

How is this done via API?

@chazt3n Think you have to explain what you want to do, since I cannot guess what you want. EscapeForwardSlash is property you can assign on JsonLayout and JsonAttribute:
https://nlog-project.org/documentation/v4.7.0/html/T_NLog_Layouts_JsonLayout.htm
https://nlog-project.org/documentation/v4.7.0/html/T_NLog_Layouts_JsonAttribute.htm
See also: https://stackoverflow.com/a/61033465/193178

@snakefoot my question was how would I set EscapeForwardSlash property via the fluent API. (i.e. code)
It is actually right on the JsonLayout object! Which is so super awesome. Thank you

I see now that it may be a recent addition to the API's? My brand new things have it and older things the same code doesn't compile.
Remember to upgrade to the latest version of NLog in your older project to access the latest NLog-features.

@chazt3n please open a new issue and provide more details (see explanation).


stdenv: cleanup darwin bootstrapping

Motivation for this change
I finally spent some time to clean this up. 😄
Also gets rid of the full python and some of it's dependencies in the stdenv build closure.
db, gdbm, openssl, readline, sqlite and python2 no longer cause an stdenv rebuild.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Attempted: stdenv
Partial log (click to expand)
copying path '/nix/store/pvi2gcj6ld1110hq50jvvpgbx5vqqlsf-gnutar-1.30' from 'https://cache.nixos.org'...
copying path '/nix/store/md8970cv4wx2f372phrchv2kkpncy3b4-glibc-2.27-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/67nqds5kzci6cdd83l333m978kj0vjsa-patchelf-0.9' from 'https://cache.nixos.org'...
copying path '/nix/store/6klshpgrh4pzvj4vry2gghcg3fr7v38c-gcc-7.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/sbg5zpv22yx42ybams9lhzkl6338gsa3-diffutils-3.6' from 'https://cache.nixos.org'...
copying path '/nix/store/wy50l2hng1qgz9hcn9al5phbzpzkgkyx-findutils-4.6.0' from 'https://cache.nixos.org'...
copying path '/nix/store/92l7k9z192gicq286mfdsv00h765w5ci-binutils-wrapper-2.30' from 'https://cache.nixos.org'...
copying path '/nix/store/py7iw171q6zigwl9vf25ac7d14n6visx-gcc-wrapper-7.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/wkxcvf9babisn0hvwl51krkq3p042088-stdenv-linux' from 'https://cache.nixos.org'...
/nix/store/wkxcvf9babisn0hvwl51krkq3p042088-stdenv-linux

Success on x86_64-linux (full log)
Attempted: stdenv
Partial log (click to expand)
/nix/store/pvnkb8ppsg71h2z95vza5fff4m98l7gi-stdenv-linux

Failure on x86_64-darwin (full log)
Attempted: stdenv
Partial log (click to expand)
cannot build derivation '/nix/store/ksli2gy5754vghw5yxvr9xadyykgmysf-cctools-port-895.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/94mc2w0f2rckrra8yv9qlks0r0whx3zs-hook.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/rwk5ysfscqmvx7vgn63qvxgzchcn2ngq-ICU-osx-10.10.5.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/hdb410czybrizzhk1bir4didiik0jrk9-cctools-binutils-darwin.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/4247sjj27d99farlqj2xn825mdzxxib2-gnutar-1.30.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/7wwkil47mci10643vpq0q4vh1bk86b47-CF-osx-10.10.5.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/r8wf4ykc3ayzgsnjmrx1lncqx2h9f6xw-cctools-binutils-darwin-wrapper.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/50k0av854hw9wmcyp0ydx0f2h4129ib7-clang-wrapper-5.0.2.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/pl96777bczlhxf6p58qzf3psdyi9r83s-stdenv-darwin.drv': 36 dependencies couldn't be built
error: build of '/nix/store/pl96777bczlhxf6p58qzf3psdyi9r83s-stdenv-darwin.drv' failed

Success on aarch64-linux (full log)
Attempted: stdenv
Partial log (click to expand)
/nix/store/wkxcvf9babisn0hvwl51krkq3p042088-stdenv-linux

Success on x86_64-linux (full log)
Attempted: stdenv
Partial log (click to expand)
/nix/store/pvnkb8ppsg71h2z95vza5fff4m98l7gi-stdenv-linux

Failure on x86_64-darwin (full log)
Attempted: stdenv
Partial log (click to expand)
make[1]: Leaving directory '/private/tmp/nix-build-gnutar-1.30.drv-0/tar-1.30'
post-installation fixup
gzipping man pages under /nix/store/a9mva9v73fpdf93n2id1ayi32jz7l68x-gnutar-1.30/share/man/
strip is /nix/store/4q1c84f1ynfvsd85a932375sg0jc89v8-bootstrap-tools/bin/strip
stripping (with command strip and flags -S) in /nix/store/a9mva9v73fpdf93n2id1ayi32jz7l68x-gnutar-1.30/bin
patching script interpreter paths in /nix/store/a9mva9v73fpdf93n2id1ayi32jz7l68x-gnutar-1.30
strip is /nix/store/4q1c84f1ynfvsd85a932375sg0jc89v8-bootstrap-tools/bin/strip
patching script interpreter paths in /nix/store/dy6q32qi8zsqkima952f71y5syawn5dr-gnutar-1.30-info
cannot build derivation '/nix/store/vrpijb7qxp3w0iyf8k94yd03nkllv5hr-stdenv-darwin.drv': 5 dependencies couldn't be built
error: build of '/nix/store/vrpijb7qxp3w0iyf8k94yd03nkllv5hr-stdenv-darwin.drv' failed

Great work!


chore(master): release 1.2.15

:robot: I have created a release beep boop
1.2.15 (2023-08-04)
Miscellaneous

deps: update dependency wayofdev/cs-fixer-config to v1.2.37 (cdcb133)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/laravel-symfony-serializer/releases/tag/v1.2.15 :sunflower:


Loss function optimizations

Hi,
According to this thread, one should not keep adding the loss to itself as it creates a Variable each time. I have seen out of memory issues while doing that, this PR fixes it.
Thank you.

That might be true in other situations, but for RNNs we need the entire graph in order to backpropagate through time. This will only backprop on the very last state.


BondGraphTools v0.4

Control/modulation network.
Measurement (effort/flow to control variable) functionality.
Proper logging functionality.
User-made libraries.
Tutorials:

Using control and modulation to implement an Op-Amp (ala Metamodelling - P. Gawthrop)
Making a new component: Suspended ball (ala pH - van Der Schaft et al).

descoped


Only works on one-to-one of which was to be many-to-many, webrtc

I am developing a conference style application (many-to-many) for video calls this style: http://spaceify.net/talk/. He even is available on GitHub but I can not for my nodejs to work, which is not much novelty, hence I decided to create my own using PHP that never leaves me.
I created the server using WebSockets, is simple he receives the message and forwards it to all connected .. Just that, nothing more nothing less.
But my problem is that it does not connect with more than one person, to connect with the third person other streams fail. You can only connect one-to-one.
I do not know consider whether the error is in JavaScript or some need to improve server .. What can I do to make it connect to all who come?
See my code:
var socket = new WebSocket('ws://<IP_ADDRESS>:1805/');
var stunServer = "stun.l.google.com:19302";
var localStream = null;
var peerConn = null;
var started = null;
var mediaConstraints = {
    'mandatory': {
        'OfferToReceiveAudio': true,
        'OfferToReceiveVideo': true
    }
};

function createPeerConnection() {
    var servers = [];
    servers.push({
        'url': 'stun:' + stunServer
    });
    var pc_config = {
        'iceServers': servers
    };
    peerConn = new webkitRTCPeerConnection(pc_config);
    peerConn.onicecandidate = function(event) {
        if (event.candidate) {
            sendMessage({
                type: 'candidate',
                label: event.candidate.sdpMLineIndex,
                id: event.candidate.sdpMid,
                candidate: event.candidate.candidate
            });
        }
    };
    peerConn.onaddstream = function(event) {
        console.log("Added remote stream");
        $("body").append('<video width="320" height="240" autoplay="true" src="' + window.URL.createObjectURL(event.stream) + '"></video>');
    };
    peerConn.onremovestream = function(event) {
        console.log("Remove remote stream");
    };
}

function sendMessage(message) {
    var mymsg = JSON.stringify(message);
    console.log("SEND: " + mymsg);
    socket.send(mymsg);
}

function connect() {
    if (localStream) {
        console.log("Creating PeerConnection.");
        createPeerConnection();
        console.log('Adding local stream...');
        peerConn.addStream(localStream);
        started = true;
        peerConn.createOffer(setLocalAndSendMessage, null, mediaConstraints);
    }
}

socket.addEventListener("message", function(evt) {
    console.log("RECEIVED: " + evt.data);
    processSignalingMessage(evt.data);
}, false);

function processSignalingMessage(message) {
    var msg = JSON.parse(message);
    if (msg.type === 'offer' && localStream && !started) {
        started = true;
        createPeerConnection();
        console.log('Adding local stream...');
        peerConn.addStream(localStream);
        peerConn.setRemoteDescription(new RTCSessionDescription(msg));
        console.log("Sending answer to peer.");
        peerConn.createAnswer(setLocalAndSendMessage, null, mediaConstraints);
    } else if (msg.type === 'answer') {
        peerConn.setRemoteDescription(new RTCSessionDescription(msg));
    } else if (msg.type === 'candidate') {
        var candidate = new RTCIceCandidate({
            sdpMLineIndex: msg.label,
            candidate: msg.candidate
        });
        peerConn.addIceCandidate(candidate);
    }
}

function setLocalAndSendMessage(sessionDescription) {
    peerConn.setLocalDescription(sessionDescription);
    sendMessage(sessionDescription);
}

function startVideo() {
    try {
        navigator.webkitGetUserMedia({
            audio: true,
            video: true
        }, successCallback, errorCallback);
    } catch (e) {
        navigator.webkitGetUserMedia("video,audio", successCallback, errorCallback);
    }

    function successCallback(stream) {
        $("body").append('<video width="320" height="240" autoplay="true" src="' + window.URL.createObjectURL(stream) + '"></video>');
        localStream = stream;
    }

    function errorCallback(error) {
        console.log('An error occurred: [CODE ' + error.code + ']');
    }
}

full code here: http://pastebin.com/3iWDLU9Y

This is not the place for these kinds of reports, please use https://groups.google.com/forum/#!forum/discuss-webrtc for this.


It is a bad design to put model and view in a single class AbstractItem.

For a model, developers probably have multiple viewHolder to display it.

@Alchemist0823 for this case there is the GenericItemAdapter

https://github.com/mikepenz/FastAdapter/blob/develop/app/src/main/java/com/mikepenz/fastadapter/app/GenericItemActivity.java
https://github.com/mikepenz/FastAdapter/blob/develop/app/src/main/java/com/mikepenz/fastadapter/app/MultiTypeGenericItemActivity.java


WEST MIDLANDS COMMUNITY/MILLENA MESFIN/Module-User-Focused-Data/week#2

Learners, PR Template
Self checklist

[x] I have committed my files one by one, on purpose, and for a reason
[x] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[x] I have tested my changes
[x] My changes follow the style guide
[x] My changes meet the requirements of this task

Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.

Hello, I appreciate if someone could review my work please.
Thank you.


to find greatest integer and fractional part of a number

The user will enter a number and i will performthe greatest integer function and also the fractional part function

can you show me a example

@sairish2001 FOr example -
the greatest integer function applied for 8.3 will be 8 i.e. the nearest integer left to the number
and fractional part will be 0.3
there are also some of their properties
We also have to know that greates integer function of -1.7 will be -2 and not -1
and similarly its fractional part will be 1 - 0.7 = 0.3
So it works differently for both negative and positive parts

Go ahead
Deadline 21 April, 2021 11:59 PM IST

@sairish2001 Could you suggest me a place to fit this in please? I am bit confused

add under general maths category


update Dangerfile with latest standards

Description
Update Dangerfile with contents from https://github.com/sous-chefs/repo-management/blob/master/Dangerfile
Issues Resolved
N/A
Contribution Check List
N/A

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

I'm reopening later, I messed the branches on my local.


Different methods to get detections for image and video

Hi all,
I realized that while getting a detection from a single image, detect.py script uses:
boxes, scores, classes, nums = yolo(img)
However while doing the same thing from the webcam, detect_video.py script uses:
boxes, scores, classes, nums = yolo.predict(img)
Could someone explain me why there are 2 ways to get the detection and what is the main difference? Thanks in advance.

From the README:

model(x) vs. model.predict(x)
When calling model(x) directly, we are executing the graph in eager mode. For model.predict, tf actually compiles the graph on the first run and then execute in graph mode. So if you are only running the model once, model(x) is faster since there is no compilation needed. Otherwise, model.predict or using exported SavedModel graph is much faster (by 2x). For non real-time usage, model.predict_on_batch is even faster as tested by @AnaRhisT94)


Yeelight fix updates on hsv mode

Description:
Related issue (if applicable): fixes #6473
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

@rytilahti
Thanks for your excellent work. This fix works perfectly with my Yeelight colorbulb now.
No issues found!
Great Job


Please run npm deprecate

https://docs.npmjs.com/cli/deprecate

This project has already been deprecated. You are likely seeing an error because some project you are using still depends upon gulp-util.


Add image to README

Add logo image
Center the Fedimint title

Preview

IMO, badges look best when on top, but LGTM


Fail Gracefully When Installed Binaries Present

Currently when a user runs the yarn devphase init twice the second time will be met with a panic! though this should just return with a log stating that the binaries are already downloaded and the project directory is already setup and valid. This becomes a problem for the Swanky CLI integration and will return an error like below with ./bin/dev phala init
└─[$]> ./bin/dev phala init new-project
? Which contract template should we use? pink
? Which contract template should we use? sample_oracle
? What should we name your contract? sample_oracle
? What is your name? hashwarlock
? What is your email<EMAIL_ADDRESS>? Do you want to download Phala node components for local testnet? Yes
Initializing
✔ Copying template files OK
✔ Processing templates OK
✔ Initializing git OK
✔ Setting up repo... OK
✖ Error Downloading Phala binaries for local testnet...

When running the yarn devphase init in the directory that is created successfully a user will see an error message like below:
└─[$]> yarn devphase init
yarn run v1.22.17
$ /home/hashwarlock/Projects/Phala/Workshop/Sub0/swanky-plugin-phala/new-project/node_modules/.bin/devphase init
[Init] Initiation
/home/hashwarlock/Projects/Phala/Workshop/Sub0/swanky-plugin-phala/new-project/node_modules/devphase/dist/cli/index.js:959
          throw new Exception("Project already initiated",<PHONE_NUMBER>755);
                ^
Throwable: Project already initiated
    at Initializer.init (/home/hashwarlock/Projects/Phala/Workshop/Sub0/swanky-plugin-phala/new-project/node_modules/devphase/dist/cli/index.js:959:17)
    at async command (/home/hashwarlock/Projects/Phala/Workshop/Sub0/swanky-plugin-phala/new-project/node_modules/devphase/dist/cli/index.js:992:3) {
  code:<PHONE_NUMBER>755
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

There can be a couple solutions on this where we return instead of throw an exception or overwrite the files with the latest binaries & packages. Let me know if you have other ideas on how to handle this.
Code where exception thrown:
https://github.com/l00k/devphase/blob/69813b8d6fabe24f1df3d885c917b03659667da4/src/service/project/Initializer.ts#L32-L36

Fixed in v0.0.30


Parsec with multiple authenticators

With #200 and #232 we can imagine a future where we will have three possible authentication methods:

Direct authentication using the parsec-cliens group to restrict access on the socket
Unix Peer Credentials authentication
SPIFFE/SPIRE based authentication

This raises multiple questions:

How will each one of them be activated? What is the default one?
What is the impact on the threat model (both service and client) and the recommendations for secure deployment?
What is the impact on the permission checks that we do in the service under the no-parsec-user-and-clients-group feature?
What is the impact on the permission checks we do in the client under the no-fs-permission-check feature?

As our threat model and code assume that the deployment is secure enough for direct authentication, we can securely add more authenticators in the code base respecting the same requirements.
However, if we want to loosen those requirements when using other authenticators and remove the current restrictions for Parsec clients:

they have to trust each other
they have to be part of the parsec-clients group

The questions above will have to be answered and modifications done in the code and the documentation.

Adding a possible threat: if multiple authentication methods are concurrently allowed how to deal with two authenticators returning the same application name? Should that allow using the same keys or should we add one more layer in the key store for authenticator name?
Another level of isolation could protect the keys created with other authenticator from one with a vulnerability.

We will only first allow one and only one authenticator at a time. There is a possible threat if an authenticator is re-configured while keys are stored in Parsec. If that happens then the same keys will be accessible with another authentication method, with different security protections. For now, we will add a WARNING notice in the configuration file to warn the admin not to re-configure the authenticator if there are existing keys.
See #271 for reference.


python38Packages.castepxbin: 0.1.0 -> 0.2.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.castepxbin is: "A collection of readers for CASTEP binary outputs"
meta.homepage for python38Packages.castepxbin is: "https://github.com/zhubonan/castepxbin"
meta.changelog for python38Packages.castepxbin is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.2.0 with grep in /nix/store/cv9f8z7vlahg6xkiilggg74za6zk1cjh-python3.8-castepxbin-0.2.0

found 0.2.0 in filename of file in /nix/store/cv9f8z7vlahg6xkiilggg74za6zk1cjh-python3.8-castepxbin-0.2.0

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
python38Packages.castepxbin
python38Packages.sumo
python39Packages.castepxbin
python39Packages.sumo

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/cv9f8z7vlahg6xkiilggg74za6zk1cjh-python3.8-castepxbin-0.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.castepxbin https://github.com/r-ryantm/nixpkgs/archive/acc45cf8b294cb81d8d475ece963ff66a5fc6ffc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cv9f8z7vlahg6xkiilggg74za6zk1cjh-python3.8-castepxbin-0.2.0
ls -la /nix/store/cv9f8z7vlahg6xkiilggg74za6zk1cjh-python3.8-castepxbin-0.2.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages failed to build:

python38Packages.sumo
python39Packages.sumo

2 packages built:

python38Packages.castepxbin
python39Packages.castepxbin

Maintainer pings
cc @dotlambda for testing.

Result of nixpkgs-review pr 145930 run on x86_64-linux 1

2 packages failed to build:

python38Packages.sumo
python39Packages.sumo

2 packages built:

python38Packages.castepxbin
python39Packages.castepxbin

closing, as stale


Why entering the local variable _nul to never use it again?

dear Barbolani
_nul and null -  is not special variables
_nul = [] spawn , _nul = [] execVM,  etc - you entering local variable to never use it
you 237s "_nul = ..." is wrong, if you not using variable _nul in check, delete it pls)

Will check it. Most of those _nul = come from oldschool scripting, old script copypastes etc.. It's not a big deal, that kind of thing is very cheap for the memory / cpu, and for debugging purposes sometimes is useful (you may check return variables or scriptDone command)

"and for debugging purposes sometimes is useful" - this is if you use variables unique, not the same 237 times

can I help you with this, with merge requests?

and in general, your programming style is terrible, have you thought about how to bring your code in order?

I may be terrible, but again, for your personal opinions I think this is not the place. The code is in order, without order it wouldn't work.
If you want to replace the code with a functional, non-terrible program with the same functionalities and better performance, this is the place, post it and explain it for terrible programmers so we will be able to provide support in future.
This terrible programmer also knows that if you spawn a function with "_nul = [] spawn.." after that you may do something like "waitUntil {scriptDone _nul}" or if you call the function with "_nul = [] call..." you may check the function return with "If (_nul)", and it doesent matter you name it _nul, _nil or _betterSpendYourTimeOnConstructivePeople as long as they are private variables which won't be affected by anything if there are no other variables with this name spawned in the same scope.
I also know removing this won't have any micro-even noticeable impact on nothing, so I will do, no worries, but I have other priorities.
I don't think your mood is still the right. You still persist on spamming on extremely unrelevant things and making personal comments.
If you continue, I suggest you to leave and build your own mission with your superior skills, but your own please, Im tired of super clever programmers that just fork my work and modify it to leave it with no success. You would be like the seventh.

Dude, you're always in your repertoire, variables nul do not apply to my statement that the code is terrible), it's strange that you do not admit your mistakes and perceive everything with hostility, but apparently you do not fix, and I did not want to. I'll try to start sending you my changes, what will be the reaction I guess, but I'll try to take a chance) don't take all the hostility, reduce the degree, I'm your friend and not the enemy)

"after that you may do ..." - and there can be placed a submarine, but it's not there)

don't make excuses

Alex, if you speak this way to your friends, I don't want to think how you do with the others.
In none of my replies I said those variables are not a mistake, they are indeed, and I explained you why are still there, and also the extremely low impact of removing them. If you take your time to remove them, it's welcome.

And proof of thinking they shouldnt be in the code it's I didn't close the issue, isn't it?

https://github.com/edgarordonez/books/blob/master/Code/The Robert C. Martin Clean Code Collection - Robert C. Martin.epub

"If you continue, I suggest you to leave and build your own mission with your superior skills, but your own please, Im tired of super clever programmers that just fork my work and modify it to leave it with no success. You would be like the seventh."

i am not programmer, i am server admin, and i dont want to programming, you got it wrong my frend)
i want to help you, thats all

"Im tired"

you're tired because you misinterpret our desire to help, and you perceive every problem as a personal claim

You say quite the right things, but the code is really terrible.
Templates mechanisms, missions, directory structure, local parts of the code sometimes cause serious problems in understanding and reading.
By the way, it primarily slows down third-party developers to contribute.

In none of my replies I said those variables are not a mistake, they are indeed, and I explained you why are still there, and also the extremely low impact of removing them. If you take your time to remove them, it's welcome.

Ha, are you talking about time?
How many times during the entire existence of these variables did people spend precious time waiting for the mission to load (initialize)?
At the moment, I am watching 203 commits. Presumably, for each it took to load the mission at least 3 times. Let these variables change the boot time by an average of 1000 milliseconds. At the output we get 609 seconds (10 minutes) of the time spent waiting. How long will it take to fix this problem (deleting variables)? In 10 minutes, this will be done by a first-year student who first saw the code, if he was correctly assigned a task and given a tool for this.


Issue maintaining party association into the cart on mobile

Expected behavior
The party should still show once you go to the cart.
Actual behavior
No party appears when you go to the cart just the consultant
Steps to reproduce behavior
Device: iOS (likely all mobile devices)
Browser: Chrome
Open Mobile Menu, choose Find Party (or Switch Party)
Select a State, then select a party
Shop for an item and add to Cart.
Go to cart, no party appears on cart just the consultant.
https://tastefullysimple.sharepoint.com/sites/Phase1Relaunch/Shared Documents/PSST/video-20201003-143200-fac2c83a.mp4
repeating same sequence on desktop, chrome, gets appropriate result -- showing both party and consultant.
Consultants reporting:
jacki Pitkow
Brook Myers
Teams Notes:
[11:13 AM] wbyrne (Guest)
Looking into this one. Have you guys tried this with other mobile devices & mobile browsers? I don't think this is specific to iOS & Chrome, I'm also seeing it on iOS Safari and Desktop chrome (with mobile emulator enabled).
[11:14 AM] wbyrne (Guest)
My question would be... do we have ANY mobile device showing the selected party on the cart?
[11:15 AM] Julie Cabinaw
Not so far wbyrne (Guest)  Is it actually persisting in the data, but the UI isn't reflecting it?
[11:16 AM] wbyrne (Guest)
That's what it seems. Here's a screenshot from desktop chrome in mobile mode. I don't know if it was ever even implemented to show the party on the cart.

[11:17 AM] wbyrne (Guest)
If I had any screenshot or example of this working properly in the past (even on tech sandbox) that would be helpful
[11:17 AM] wbyrne (Guest)
I'm trying to determine if this is something that was implemented and is not working properly... or if it was never implemented.
[11:24 AM] Sue Hamre
wbyrne (Guest), I just checked in the tech sandbox and I am only seeing the party bar/affiliation if I am within the menu and not within the cart.
[11:26 AM] wbyrne (Guest)
Ya, so it sounds like this isn't something that's broken, it's something that wasn't implemented.
[11:26 AM] jwise (Guest)
Sue Hamre correct it's in the menu on every page along with the consultant bar
[11:29 AM] wbyrne (Guest)
Seems like this is related:
https://github.com/tastefully-simple/cornerstone/issues/223
[11:30 AM] wbyrne (Guest)
But ya... I'm not seeing anything about mobile cart page party bar
[11:30 AM] wbyrne (Guest)
Just having it in the mobile menu

@mandi920 to implement this, can we get a mockup for how it will look like?

@jsmnglng-w Here is a link to the mock-up. The one thing that hs changed since that mock is that the party area should be green, not tan, as it shows in comp.  https://tastefullysimple.sharepoint.com/sites/Phase1Relaunch/Shared Documents/Cart/Comps/TSOP1_ConsultantAffiliation_061820_Final/comps/M in party with consultant.png

Created a ticket for this issue: TST-231

@mandi920 I finished implementing the party bar in the cart page in mobile, but how do we want it to look like when there is no party selected yet? Currently, I just made it the same as the consultant:

[10:22 AM] Julie Cabinaw
my recommendation as a first step: Change color of party bar to soft red (style guide error state color of #FFDDDD) if no party selected and message should read :
You have not selected a party (Find a Party)

fixed, closing


[question] is posible decode uuid to data back ?

Feature description

import { v5 } from "uuid";

   v5(<isData>, <namespace>); /** -> 32ABF614-5646-5448-B514-EE0E3DB6F833 **/

now, is possible get back isData from 32abf614-5646-5448-b514-ee0e3db6f833 to isData ??
Additional information
No response

No, v5 uses a SHA-1 hash, which is not reversible.
https://stackoverflow.com/questions/2235079/is-it-possible-to-reverse-a-sha-1-hash


Refactoring (May 2024 planning meeting) - Connectors and Integrations

Description
Development of integration points with external systems.
Tasks

[ ] Identify systems to integrate
[ ] Develop connectors
[ ] Integration testing
[ ] Partner documentation

Technical Points

Data export formats
Partner APIs
Exchange security

Here is the whiteboard content:

My thesis for datawarehouse:
https://publications.polymtl.ca/2116/1/2016_PîerreLeoMongeonBourbonnais.pdf


"Reports property names that do not follow the recommended naming conventions." from intellij inspections

Intellij marks top level properties as warnings. In detekt we allow them to be treated as constants. Should we also change the defaults?

Yes. I think so.

Working on this.