Update Training a MEGNet Formation Energy Model with PyTorch Lightnin…

…g.ipynb
Bug fix: Resolved parameter input issue in MEGNetDataset from v0.8.3 and higher versions Description:
This pull request addresses the problem of parsing input parameters when constructing MEGNetDataset in this scenario.  The issue arose due to the refactoring of MEGNetDataset in v0.8.3 and higher versions.  The modifications made here ensure compatibility with the syntax of the new version.
Summary
Major changes:

feature 1: ...
fix 1: ...

Todos
If this is work in progress, what else needs to be done?

feature 2: ...
fix 2:

Checklist

[ ] Google format doc strings added. Check with ruff.
[ ] Type annotations included. Check with mypy.
[ ] Tests added for new features/fixes.
[ ] If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:
pip install -U pre-commit
pre-commit install

Thanks.


chore(package): update @types/jest to version 23.0.1

Closes #7

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 885a85e...b15ed94. Read the comment docs.


Can't resolve 'dgram'

Hi, I have an empty react with typescript app
after doing the import and creating the client I get the error
Module not found: Error: Can't resolve 'dgram' in 'D:**\node_modules\f1-2021-udp\build\src'

doesn't run on web

does not run on web, because  dgram is not available in the browser, and that is not the only thing missing.
You can run it in an Electron app it will work no problem, or on a nodejs server.


Observe state changes of PassThroughSubjects which is published inside a Task block.

I am trying to write test cases for my ViewModel, In my ViewModel I am doing the following:
My Code:

Calling an API, and getting some data from the server (providing mock JSON for test cases).
After the result, I assigned some value via ViewModel to one of the references existing in that ViewModel and also published changes via Subject (PassThroughSubject).

Required Test:

In my test, I want to subscribe my publisher and wait for the expectation to be completed and then I will verify the values and compare those values to check either test is passed or not.

Problem:
I tried to perform test for getAppConfigurationSettings function but as this function already contained a Task so I tried to wait for the task value with await task.value, now the problems I am facing are:

Task value returns only when try await passes to the next statement or completes its operation in getAppConfigurationSettings, so still my values are not updated, in XCTest we can add expectation waiting time and fulfill any alternate?
How can I subscribe stateSubject and check if I receive the correct state?

`
var stateSubject = PassthroughSubject<State, Never>()
func getAppConfigurationSettings(isFetchAfterOtp: Bool = false) {
    Task {
        do {
            stateSubject.send(.loading)
            let response = try await self.httpClient.asyncRequest(endpoint: LaunchingEndPoint.getConfigurations, responseModel: AppHomeSettingsResponseModel.self)
            if response.status ?? false {
                self.configureAppSettings(model: response.result)
            }
            if !isFetchAfterOtp {
                self.stateSubject.send(.successWithSettings)
            }
        }  catch let error as ApiResponse {
            handleApiError(error)
        }
    }
}`

I tried to write test like this.
`
var viewModel: LaunchingViewModelProtocol = LaunchingViewModel(httpClient: MockHttpClient(),
                                                               userContext: UserContext.getInstance())
@Test func getAppConfig() async throws {
    let task = Task {
        viewModel.getAppConfigurationSettings(isFetchAfterOtp: false)
    }
    await task.value
    // SUBSCRIPTION FOR STATE CHANGES
}

`

Looks like you're using Combine, right? This is maybe a question more suited for the Swift or Apple Developer forums as it has to do with using the Combine framework, not so much to do with Swift Testing. I suggest starting a thread on the forums! 🙂

Hey @grynspan,
I hope you are doing well.
Thanks for the reply, I think you got me wrong here, What my point is in XCTest we can add Expectations which has a wait function as well, I want to use a similar functionality with Swift Testing, is it possible? also I am also pasting the code of XCTest maybe it will help to understand the question.
`
class LaunchVMTestCase: XCTestCase {
var viewModel: LaunchingViewModelProtocol = LaunchingViewModel(httpClient: MockHttpClient(),
userContext: UserContext.getInstance())
var cancellable = Set<AnyCancellable>()

func testGetAppConfig() async {
    let expectation = expectation(description: "wait for the changes in subject")
    self.viewModel.stateSubject.sink { state in
        if state != .loading {
            expectation.fulfill()
            XCTAssertTrue(state == .successWithSettings)
        }
    }.store(in: &self.cancellable)

    let task = Task {
        viewModel.getAppConfigurationSettings(isFetchAfterOtp: false)
    }
    await fulfillment(of: [expectation])
}

}`
In testGetAppConfig function we have expectation and at the end of the function we are waiting for fulfillment of that expectation, how can we convert this to the new swift testing framework, do we have any replacement for expectation and fulfillment?

We discuss similar patterns in Go further with Swift Testing. This particular pattern is often better-modelled as a Swift continuation rather than as a blocking call to wait(for:) or fulfillment(of:).


Use PyArrayModule::py instead of taking Python as argument

Since PyModule has PyObjectWithToken implementation, sometimes we don't need take Python as function as argument(becausePython is just a marker, pyo3 allows retrieve it for native types, with lifetime restriction).
Though this is a really breaking change, I think it enhances our API ergonomics.

Though this is a really breaking change, I think it enhances our API ergonomics.

I totally agree. py causes several problems e.g. on error handling.

pyo3 allows retrieve it for native types, with lifetime restriction

This is the point where I gave up to switch PyO3 from rust-cpython.
In our case, can we drop all py argument because np: PyArrayModule has 'py lifetime?

In our case, can we drop all py argument because np: PyArrayModule has 'py lifetime?

I think so, but maybe my explanation that 'pyo3 allows retrieve it for native types, with lifetime restriction' was incorrect.
PyObjectWithToken::py itself doesn't have lifetime restriction, but since almost all Pyo3 API returns &'py PyObject, it works well.

GILGuard          |=====================================|
GIL actually held |==========|         |================|
Rust code running |=======|                |==|  |======|

https://github.com/PyO3/pyo3/blob/10ef6cd1113c5d8fbcea01481babf1d327c2bbd6/src/python.rs#L26
This AA help me to understand how it works.
BTW, do you plan to drop &np argument? It may possible since it only holds a pointer to the NumPy C API entrypoint.

This AA help me to understand how it works.

Thanks :slightly_smiling_face:

BTW, do you plan to drop &np argument? It may possible since it only holds a pointer to the NumPy C API entrypoint.

Sounds a good idea.
I think to store it into global (like pyo3's datatime ffi do so) is good idea.
If we do so, we can reduce import overhead and remove this hack.

In addition, since almost all users write PyArrayModule::import, now I feel there's no need to let users write it manually.


python310Packages.deprecations: fix tests

Motivation for this change
related: https://github.com/briancurtin/deprecation/pull/57
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

cool, all the downstream dpendencies still use unittest2... lol
https://github.com/NixOS/nixpkgs/pull/154666

1 package marked as broken and skipped:
python310Packages.skein

34 packages failed to build:
python310Packages.ansible-kernel python310Packages.atomman python310Packages.cufflinks python310Packages.einops python310Packages.elegy python310Packages.ipydatawidgets python310Packages.ipympl python310Packages.ipyvue python310Packages.ipyvuetify python310Packages.ipywidgets python310Packages.jupyter python310Packages.jupyter-server-mathjax python310Packages.jupyter-sphinx python310Packages.jupyterlab python310Packages.jupyterlab-git python310Packages.jupyterlab-widgets python310Packages.jupytext python310Packages.kmapper python310Packages.lightparam python310Packages.nbclient python310Packages.nbdime python310Packages.papermill python310Packages.potentials python310Packages.pydeck python310Packages.qiskit-aer python310Packages.qiskit-aqua python310Packages.qiskit-finance python310Packages.qiskit-ibmq-provider python310Packages.qiskit-ignis python310Packages.qiskit-nature python310Packages.qiskit-optimization python310Packages.qiskit-terra python310Packages.treex python310Packages.vega

4 packages built:
python310Packages.deprecation python310Packages.eyeD3 python310Packages.jupyter-packaging python310Packages.pyhs100

Result of nixpkgs-review pr 154666 run on x86_64-linux 1

1 package marked as broken and skipped:

python310Packages.skein

34 packages failed to build:

python310Packages.ansible-kernel
python310Packages.atomman
python310Packages.cufflinks
python310Packages.einops
python310Packages.elegy
python310Packages.ipydatawidgets
python310Packages.ipympl
python310Packages.ipyvue
python310Packages.ipyvuetify
python310Packages.ipywidgets
python310Packages.jupyter
python310Packages.jupyter-server-mathjax
python310Packages.jupyter-sphinx
python310Packages.jupyterlab
python310Packages.jupyterlab-git
python310Packages.jupyterlab-widgets
python310Packages.jupytext
python310Packages.kmapper
python310Packages.lightparam
python310Packages.nbclient
python310Packages.nbdime
python310Packages.papermill
python310Packages.potentials
python310Packages.pydeck
python310Packages.qiskit-aer
python310Packages.qiskit-aqua
python310Packages.qiskit-finance
python310Packages.qiskit-ibmq-provider
python310Packages.qiskit-ignis
python310Packages.qiskit-nature
python310Packages.qiskit-optimization
python310Packages.qiskit-terra
python310Packages.treex
python310Packages.vega

4 packages built:

python310Packages.deprecation
python310Packages.eyeD3
python310Packages.jupyter-packaging
python310Packages.pyhs100

Well, this is still an improvement, see as all of these were failing before.


If a single model instance is passed to inv_abel_fitted_model for a sample of objects the results will be completely invalid

The fault lies in the convenience function "model_check()", which is designed to make sure that the number of models passed to one of the density calculation methods is consistent with the number of sources. Unfortunately in the case where a single instance of a model is passed, the model_check function will just put it in a list of models the length of the sample being analysed - for some reason I didn't think to copy the model so they are actually all pointing to the same instance.
That means that every fit performed uses the same model and it just gets overwritten, hence for a sample of objects results will be very very similar, for instance:

The fix is simple, do a copy of the model instance rather than how I did it originally

Actually I mis-read my own code and I DO do copies of models in this situation - so I'm back to having no idea again

The problem shown above does not originate in XGA, but rather in my own use of it. I declared a density model instance and passed that into the fit() method of the density profiles generated by inv_abel_fitted_model, but I did not make copies of that and so the problem I described above occurs.

Though its not strictly related to this issue, I'm going to try and ensure that this doesn't happen again. I think this will take the form of making models aware of what profile they're associated with, that way the fit() method can throw an error if you try to use a model already associated with a profile on it.


Font size settings for different displays/resolutions

I have two screens which I regularly switch between. My font size is configured to be just right on one of them, but it appears far too large on the other monitor.
This is probably an advanced feature request, but I would like to have a way to configure the font size differently for each display I have.

Are you using Windows? Maybe you could set the interface scaling factor on one of the monitors to something like 1.5?

To keep the number of issues in our inbox at a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: we look at the number of votes the issue has received and the number of duplicate issues filed. Thank you for your time and understanding.
P.S. If you disagree and feel that this issue is crucial: we're happy to listen and to reconsider.


fix cookbook for Chef 14 - prefix new_resource

https://docs.chef.io/release_notes.html#breaking-changes

Property names not using new_resource.NAME

Hey @jtimberman #166 should fix the build environment and allow this one to go green as long as you rebase.  However, once this gets merged in, I won’t be able to do a release until after the weekend.

Odd. Everyone should have been able to see.
/pipeline/source/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout
RuboCop failed!
Running RuboCop...
Inspecting 27 files
.................W.........

Offenses:

resources/user.rb:28:39: W: Unused block argument - permission. You can omit the argument if you don't care about it.
    new_resource.permissions.each do |permission|
                                      ^^^^^^^^^^
resources/user.rb:37:35: W: Unused block argument - db. You can omit the argument if you don't care about it.
  new_resource.databases.each do |db|
                                  ^^
resources/user.rb:38:39: W: Unused block argument - permission. You can omit the argument if you don't care about it.
    new_resource.permissions.each do |permission|
                                      ^^^^^^^^^^

27 files inspected, 3 offenses

Btw, you can run the following with the latest chef-dk:
rake # Quick tests only (rubocop + minitest)
rake test:complete # All tests (rubocop + minitest + kitchen)

I can't see it either @bdangit - getting a 401 (although not a very clear one!)

@fishnix et al, I think wercker wants you to login so you can see the logs.  very bad form.  I'm open to porting this over back to travis if this CI builder doesn't have this limitation.

hey @jtimberman, I left some comments in a github review.  Let me know if you need help to finish this off.

@bdangit Thanks!

@jtimberman the new error I see now is:
Running RuboCop...
Inspecting 27 files
...........................

27 files inspected, no offenses detected
Starting Foodcritic linting...
Checking 16 files
.........xxx.x.x
FC085: Resource using new_resource.updated_by_last_action to converge resource: /pipeline/source/resources/admin.rb:25
FC085: Resource using new_resource.updated_by_last_action to converge resource: /pipeline/source/resources/admin.rb:34
FC085: Resource using new_resource.updated_by_last_action to converge resource: /pipeline/source/resources/admin.rb:50
FC085: Resource using new_resource.updated_by_last_action to converge resource: /pipeline/source/resources/continuous_query.rb:31
FC085: Resource using new_resource.updated_by_last_action to converge resource: /pipeline/source/resources/continuous_query.rb:37
FC085: Resource using new_resource.updated_by_last_action to converge resource: /pipeline/source/resources/database.rb:19
FC085: Resource using new_resource.updated_by_last_action to converge resource: /pipeline/source/resources/database.rb:24
FC085: Resource using new_resource.updated_by_last_action to converge resource: /pipeline/source/resources/retention_policy.rb:24
FC085: Resource using new_resource.updated_by_last_action to converge resource: /pipeline/source/resources/retention_policy.rb:28
FC085: Resource using new_resource.updated_by_last_action to converge resource: /pipeline/source/resources/retention_policy.rb:35
FC085: Resource using new_resource.updated_by_last_action to converge resource: /pipeline/source/resources/user.rb:26
FC085: Resource using new_resource.updated_by_last_action to converge resource: /pipeline/source/resources/user.rb:30
FC085: Resource using new_resource.updated_by_last_action to converge resource: /pipeline/source/resources/user.rb:48

Keep in mind this is using the Chef docker image you gave me.

Any news on this?
It seems that you should not call new_resource.updated_by_last_action but use use_inline_resources in the resource file instead (cf http://www.foodcritic.io/#FC085)

Well it seems that use_inline_resources is not needed since Chef13, so the use of it might no even be needed, depending on which chef version this cookbook supports.

fixed this in #168. going to accept this and merge in #168.


Create CODE_OF_CONDUCT.md

As discussed in #5281 this adds the code of conduct statement.

check-manifest --ignore .circleci*,doc,logo,mne/io/*/tests/data*,mne/io/tests/data,mne/preprocessing/tests/data
lists of files in version control and sdist do not match!
missing from sdist:
  CODE_OF_CONDUCT.md

OK, this means I just include this file in MANIFEST.in, right? Also, I created this PR on the GitHub website, which means that this is now a branch of upstream instead of my fork. Now git doesn't know my credentials and I don't want to set it up (two factor and what not). I'd prefer to close this and start from scratch.

Continued in #5301.


feat: instrument lock

lock should be within a span as it's a critical component of the backend and it should be easy to follow when a code is within a lock or not

Instead of instrumenting just the lock we could generally add instrumentation to the service layer like we go for app layer. Then we don’t need to add individual spans but all the exported functions would be wrapped


smallfile hangs if filesystem runs out of space

should not do this if any exception happens in a worker thread

not reproducible anymore.


setup for mirroring

Codecov Report

Merging #427 into master will decrease coverage by 0.28%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
- Coverage   97.95%   97.67%   -0.29%
==========================================
  Files          33       33
  Lines        1956     1976      +20
  Branches      128      131       +3
==========================================
+ Hits         1916     1930      +14
- Misses         27       31       +4
- Partials       13       15       +2

Impacted Files
Coverage Δ

...dControllerAbstraction/proxy/faucet/test_parser.py
100% <100%> (ø)
:arrow_up:

...hBoundControllerAbstraction/proxy/faucet/parser.py
100% <100%> (ø)
:arrow_up:

...hBoundControllerAbstraction/proxy/faucet/faucet.py
92.5% <75%> (-7.5%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1debda6...b9c490d. Read the comment docs.


Authentication: Phone-number-verification-success-UI

Authentication: Phone-number-verification-success-UI #8

kindly resolve your conflict

Hello @modibboyusuph please fix the conflict on your PR

Do this to resolve the conflicts
file can’t be merged right now
Why:
You have a conflicts to resolve.
proTip: To resolve, first if you forked the repo then sync it with i4g repo so everything is up to date
Second: checkout to the develop branch and do git pull.
third: checkout to a new branch called resolve conflicts, then if you can copy the code you already did in old branch that conflicts then do else you can code afresh, when done, checkout to this branch that has conflicts then merge this new branch called resolve conflicts you created earlier then you can now see all conflicting files to resolve it.
To make it simple in vscode open all files showing the conflicts then hovering on them will ask you to either accept incoming changes, keep both Changes or compare changes, here click on accept incoming changes after all this, you will see a button that say mark as resolve click it, do so in all conflicting files, you should be good, then commit your changes

You're almost there @modibboyusuph. You just need to make a few changes.

Fix the merge conflict by updating your code with the develop branch.
The route to your components comes up blank can you fix this
Also make the routes pathname to your components all lowercase

@modibboyusuph please fix this merge conflict so that your PR can be merged


Question about setting up migration table

Hi
I am struggling to understand the mapping a bit.
In my event index I have
 Index::create('events', function (Mapping $mapping, Settings $settings) {
            $mapping->search_as_you_type('name');
            $mapping->date('published_at');
            $mapping->integer('rank');
            $mapping->date('closingDate');
            $mapping->text('priceranges');
            $mapping->integer('category_id');
            $mapping->geo_point('location_latlon');
            $mapping->text('shows');
            $mapping->text('genres');
            $mapping->boolean('hasLocation');
        });

However it doesn't work when I try to do search for name. I am using the same database and have your old elasticsearch plugin on one server and the new one locally. So on the old one when I use
$event = Event::search($request->keywords)
             ->rule(EventSearchRule::class)
             ->take(5)
             ->get();

And in EventSearchRule.php

return [
            'must' => [
                'multi_match' =>  [
                    "query" =>  $this->builder->query,
                    "type"  =>  'bool_prefix',
                    "fields"    =>  [
                        'name',
                        'name.2gram',
                        'name.3gram'
                    ],
                ]
            ]
        ];

If I type in 'c' it returns cairn, curiousor, and 3 more. However in the new system when I use that migration above and
$a = Event::multiMatchSearch()
        ->fields(['name', 'name.2gram','name.3gram'])
        ->query($request->keywords)
        ->execute();

        return $a->models();

if I type in 'c' it returns only one C(ovell) In The C(loud). If I type in a full word like 'chaos' it will then find that name and returns that event named chaos.
Do I need to do $mapping->dynamicTemplate()? If so, how would that setup be for geo_point or search_as_you_type?
Thanks so much!!

Hey @chrisgrim, you should use camelCased method names, i.e.:
$mapping->searchAsYouType('name');
$mapping->geoPoint('name');

You can find the full list of supported types here.

Hi @babenkoivan
Thanks so much for the quick response and information. That list was very helpful! Sadly it didn't seem to fix my problem.
My new migration file is
final class CreateEventsIndex implements MigrationInterface
{
    /**
     * Run the migration.
     */
    public function up(): void
    {
        Index::create('events', function (Mapping $mapping, Settings $settings) {
            $mapping->searchAsYouType('name');
            $mapping->date('published_at');
            $mapping->integer('rank');
            $mapping->date('closingDate');
            $mapping->text('priceranges');
            $mapping->integer('category_id');
            $mapping->geoPoint('location_latlon');
            $mapping->text('shows');
            $mapping->text('genres');
            $mapping->boolean('hasLocation');
        });
    }

Then I ran php artisan elastic:migrate:refresh and then php artisan scout:import "App\Models\Event". It said Imported [App\Models\Event] models up to ID: 471 All [App\Models\Event] records have been imported.
Then in my controller I double checked and I have
$a = Event::multiMatchSearch()
        ->fields(['name', 'name.2gram','name.3gram'])
        ->query($request->keywords)
        ->execute();

        return $a->models();

which should do the type ahead. However if I start to type in 'chaos', it doesn't return a result until I have completely typed in the word, then returns the event object for the event named chaos.
I realize this might be a question now for elastic-scout-driver-plus but I figured I had already started the question here.
Thanks again!!

Hey @chrisgrim, if we have a look at the example on this page, we can see, that the search fields are:
"my_field",
"my_field._2gram",
"my_field._3gram"

It looks like you are missing the underscore. But you are right, it's better to check first if the documents are in the index or not. Your index name is events (the first argument in Index::create). You can still do http://<IP_ADDRESS>:9200/events/_search?pretty=1&size=100, this driver doesn't change how ES works 🙂
Also please make sure, that your actual mapping matches what you have in the migration. Maybe you should delete the index and create it again via elastic:migrate:refresh.

Hi @babenkoivan
Sorry for all the questions if I can do anything to help with this project please let me know. I am happy to write documentation or help with things like that.
Good catch with the _2gram. I am having an interesting problem and I am wondering if it was because I originally had your old plugin on this project. I figured out I had to delete the old event indeces I had created before using curl -XDELETE localhost:9200/event; Then I did the migrate refresh and it worked. But now I am having something strange happen. In my event model I have:
/**
* What events should be searchable for scout elastic search
*
* @return \Illuminate\Database\Eloquent\Relations\belongsTo
*/
public function shouldBeSearchable()
{
return $this->isPublished();
}
/**
* Determines which events are published for Laravel Scout
*
* @return bool
*/
public function isPublished() {
    return $this->status == 'p';
}

/**
 * Get the indexable data array for the model.
 *
 * @return array
 */
public function toSearchableArray()
{
    return [
        'name' => $this->name,
        'published_at' => $this->published_at,
        'showtype' => $this->showtype,
        'rank' => $this->rank,
        'closingDate' => $this->closingDate,
        'priceranges' => $this->pricerangesSelect,
        'category_id' => $this->category_id,
        'location_latlon' => $this->location_latlon,
        'shows' => $this->showsSelect,
        'genres' => $this->genreSelect,
        'hasLocation' => $this->hasLocation
    ];
}

and in my migration I now have

final class CreateEventsIndex implements MigrationInterface
{
/**
* Run the migration.
*/
public function up(): void
{
Index::create('events', function (Mapping $mapping, Settings $settings) {
$mapping->searchAsYouType('name');
$mapping->date('published_at');
$mapping->integer('rank');
$mapping->date('closingDate');
$mapping->text('priceranges');
$mapping->integer('category_id');
$mapping->geoPoint('location_latlon');
$mapping->text('shows');
$mapping->text('genres');
$mapping->boolean('hasLocation');
});
}
If I run migration refresh and import events the indeces will be empty. However if I comment out

return [
'name' => $this->name,
'published_at' => $this->published_at,
'showtype' => $this->showtype,
'rank' => $this->rank,
// 'closingDate' => $this->closingDate,
// 'priceranges' => $this->pricerangesSelect,
'category_id' => $this->category_id,
'location_latlon' => $this->location_latlon,
// 'shows' => $this->showsSelect,
// 'genres' => $this->genreSelect,
'hasLocation' => $this->hasLocation
];
Then it imports 12 events and a lot of them and some of the options are null

{
"_index": "events",
"_type": "_doc",
"_id": "83",
"_score": 1,
"_source": {
"name": "Off The Table",
"published_at": null,
"showtype": "o",
"rank": 1,
"category_id": 13,
"location_latlon": null,
"hasLocation": false
}
},
However, if I comment out the entire migration table

Index::create('events', function (Mapping $mapping, Settings $settings) {
// $mapping->searchAsYouType('name');
// $mapping->date('published_at');
// $mapping->text('showtype');
// $mapping->integer('rank');
// $mapping->date('closingDate');
// $mapping->text('priceranges');
// $mapping->integer('category_id');
// $mapping->geoPoint('location_latlon');
// $mapping->text('shows');
// $mapping->text('genres');
// $mapping->boolean('hasLocation');
});
and then uncomment out the tosearchable array and run migration and import it seems to work as it should.

{
"_index": "events",
"_type": "_doc",
"_id": "9",
"_score": 1,
"_source": {
"name": "Adventures in the Mind's Ear",
"published_at": null,
"showtype": "a",
"rank": 1,
"closingDate": "2020-12-12 00:46:16",
"priceranges": [
{
"price": "3.50"
},
{
"price": "12.00"
}
],
"category_id": 10,
"location_latlon": null,
"shows": [
{
"date": "2020-12-12 00:46:16"
}
],
"genres": [
{
"name": "ASMR",
"pivot": {
"event_id": 9,
"genre_id": 26
}
},
{
"name": "Audio",
"pivot": {
"event_id": 9,
"genre_id": 27
}
},
{
"name": "Immersive",
"pivot": {
"event_id": 9,
"genre_id": 1
}
},
{
"name": "Intimate",
"pivot": {
"event_id": 9,
"genre_id": 12
}
},
],
"hasLocation": false
}
},
Do I actually need to make a migrations table? It seems like it fills in the indices correctly with the toSearchableArray.

I did a bit more testing and I realized that it regardless of what I name the migration table, if I run
php artisan scout:import "App\Models\Event"

It will make an events indices and fill it with my events. So its almost like if I create the events migration table it conflicts with the import instead of having the import fill it up.

Hi @babenkoivan
I have done more tinkering today and figured out some things/ have new questions.
I realized I do have to create a migrations table because when I do http://<IP_ADDRESS>:9200/events/_mapping I can see that if I don't setup the migration table correctly then it does the wrong mapping types. This also led me to figure out why it wasn't filling out my entire indices, since I was using the incorrect migration type for some of my fields. This does lead me to another question.
Some of my fields like shows and genres return an array of shows assigned to the event. I was able to get this to work by using $mapping->nested('shows'); however when I look at the mapping this brings up a new issue.
"shows": {
"type": "nested",
"properties": {
"date": {
"type": "text",
"fields": {
"keyword": {
"type": "keyword",
"ignore_above": 256
}
}
}
}
},

How do I control the field types inside the nested and what gets pulled into the nested? Date shouldn't be a text field. I also can't control what parts of the model to bring in. This was accomplished with your older plugging using
protected $mapping = [
        'properties' => [
'shows' => [
                'properties' => [
                    'date' => [
                        'type' => 'date',
                        'format' => 'yyyy-MM-dd HH:mm:ss'
                    ],
                ]
            ],

How do I accomplish the same thing?

Sorry for the tons of comments, I figured it out! My final migration table looks like
 Index::create('events', function (Mapping $mapping, Settings $settings) {
            $mapping->searchAsYouType('name');
            $mapping->text('showtype');
            $mapping->integer('rank');
            $mapping->integer('category_id');
            $mapping->geoPoint('location_latlon');
            $mapping->boolean('hasLocation');
            $mapping->object('priceranges', ['properties' => ['price' => ['type' => 'integer']]]);
            $mapping->object('shows', ['properties' => ['date' => ['type' => 'date', 'format' => 'yyyy-MM-dd HH:mm:ss']]]);
            $mapping->object('genres');
            $mapping->date('closingDate', ['format' => 'yyyy-MM-dd HH:mm:ss']);
            $mapping->date('published_at', ['format' => 'yyyy-MM-dd HH:mm:ss']);
        });

in case this helps anyone else.
Now off to figure out the elastic scout driver plus plugin :)


lint_xml_file could support multiple files

The lint_xml_file only accepts one possible report file. If the project has several android modules, it should be possible to process multiple lint report files.
Any possibility to accept a list of files?

Please check this


Add Template information in the function node.

Fix: #295

Codecov Report
Base: 74.69% // Head: 74.55% // Decreases project coverage by -0.14% :warning:

Coverage data is based on head (22aeb6d) compared to base (b87e6ef).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   74.69%   74.55%   -0.15%
==========================================
  Files          89       89
  Lines        3730     3733       +3
  Branches      634      636       +2
==========================================
- Hits         2786     2783       -3
- Misses        944      950       +6

Impacted Files
Coverage Δ

.../functions/function-tree-view/functionsTreeItem.ts
35.00% <33.33%> (+1.10%)
:arrow_up:

src/functions/func.ts
93.90% <100.00%> (+0.15%)
:arrow_up:

src/util/platform.ts
88.23% <0.00%> (-11.77%)
:arrow_down:

src/cli/cmdCli.ts
42.16% <0.00%> (-3.62%)
:arrow_down:

src/util/watch.ts
93.33% <0.00%> (-3.34%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: download timed out

https://github.com/longhorn/longhorn/issues/6256

Test results

This PR should also fix https://github.com/harvester/harvester/issues/3383, thanks @c3y1huang

@c3y1huang Please follow up with @bk201 to see when the PR will be merged and new image will be ready, then make the longhorn PR ready for review. Thanks.


Can I use negative values for snapPoints or set a top margin in pixels?

Hello, I'd like to set the maximum height of snapPoints to be 40px less from the top. I'm wondering if there's a way to use something like calc(100vh - 40px) within snapPoints.

This behavior can work by adding !h[100dvh] onto Drawer.Content and then h-[calc(100dvh-40px)] on the child inside the content.  h-[calc(100dvh-40px)]  is conditionally applied to the content when the snappoint is 1.

Thanks! I'll close this issue.


iPhone drag'n'drop

Drag'n'drop works on iPad, but not iPhone.
According to a comment in https://github.com/timruffles/mobile-drag-drop/issues/127 HTML5 drag'n'drop only works on iPad.

I've confirmed that drag/drop works on the iPad, doesn't work on the iPhone and I can't find any documentation that says it shouldn't.

Some (possibly) helpful info at https://stackoverflow.com/questions/8766052/drag-drop-on-safari-ios-wont-drag-wont-respond-to-drop-on-desktop-ipad although it contradicts the statement that Safari Drag and Drop is supported from iOS 11.


Need Help

I trying compiling on Xcode 10.1 with Unity3D 2018.3.5f1 but no work.. the message I received "Invalid bitcode signature"

Same here. Building with Unity3D (5.6.4f1) works, even building directly on a device via xCode. But we get the same error when archiving.
Already went through every error-solution - still not working.

Disabling bitcode does not work, since its a static library

Do a fresh pull and it should archive fine with bitcode disabled now.
Seems like the lesser of 2 evils to disable bitcode in the static library, then if anyone really needs it they can rebuild it using the Xcode project and their desired architectures.

Hi Ryan, thanks for the update. Unfortunately we want to build with bitcode. Gladly we found the 'UnityNativeGallery' plugin for Unity and it seems to work with bitcode. Maybe you can get connected with them to make yours possible with bitcode as well?
Anyway, thanks for your work!


add application uris feature + tests

Is there a related GitHub Issue?

What is this change about?
That change add application routes as property "uris" of the env variable VCAP_APPLICATION.
Does this PR introduce a breaking change?
No
Acceptance Steps

Deploy a CF application: cf push my-application
check environment: cf env my-application
check property "uris" of env variable VCAP_APPLICATION
The list shall be not null and contain application routes. If no routes are configured, it shall be an empty list []

Tag your pair, your PM, and/or team
@danail-branekov @georgethebeatle

@szeort thanks for the PR. Overall looks good, I have left minor comments in the test.
Besides that, could you get rid of the merge commit so that the PR only contains the commit that actually implements the feature? You can do that by resetting your local branch to main and then just cherrypick commit a5c6d244 add application uris feature + tests


sqlite 3.0.0 release

Hey @tanner0101, you just merged a pull request, have a coin!
You now have 812 coins.


Replace ethers with Viem?

We have received a request to replace Ethers with Viem which is much faster than Ethers and more space efficient but the Snowbridge API we implement uses Ethers as a Dependency so we are unable to proceed. Would Snowbridge consider moving to Viem library for EVM tasks? Many thanks for your answers in advance!
With kind regards,
Team ParaSpell✨
Associated links:
https://github.com/paraspell/xcm-tools/issues/329
https://viem.sh/docs/introduction

@alistair-singh totally understood. It is hard to migrate such important dependency. The project should have been built on the other one to begin with so other teams would have adopted it during implementation already. However for speed improvements at least please look into it and if possible please consider supporting both. Thanks!
With kind regards,
Team ParaSpell✨


new command line parameter -g, --get-only

this is just shortcut for --http-methods GET
this is useful for me to test standard django admin

Codecov Report

Merging #3 into master will decrease coverage by 0.97%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   96.23%   95.26%   -0.98%
==========================================
  Files           5        5
  Lines         186      190       +4
  Branches       24       25       +1
==========================================
+ Hits          179      181       +2
- Misses          6        7       +1
- Partials        1        2       +1

Impacted Files
Coverage Δ

...ngo_smoke_tests/management/commands/smoke_tests.py
95.23% <66.66%> (-4.77%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ceac3c...d916017. Read the comment docs.


Script should exit with an error code on ESLint processing failures.

Describe the bug
A clear and concise description of what the bug is.
To reproduce
Steps to reproduce the behavior:
Check out https://github.com/cindyli/preferencesServer/tree/proxy-sso-impl currently at commit 98871b705a67523f2869d511d6c75380ee72b6ad
run npm install
run npm lint
Expected behavior
There is a failing ESLint check in this repository. The lint run should be marked as a failure -
The output from the run is as follows:
buntu@ubuntu2004:~/preferencesServer$ npm run lint

><EMAIL_ADDRESS>lint /home/ubuntu/preferencesServer
> fluid-lint-all

Infusion at path /home/ubuntu/preferencesServer/node_modules/infusion is at top level
04:49:45.989:  Registering module preferencesServer from path /home/ubuntu/preferencesServer/
04:49:45.991:  Registering module infusion from path /home/ubuntu/preferencesServer/node_modules/infusion/
04:49:45.991:  Registering module infusion from path /home/ubuntu/preferencesServer/node_modules/infusion
Resolved infusion from path /home/ubuntu/preferencesServer/node_modules/fluid-lint-all/node_modules/infusion/src/module to /home/ubuntu/preferencesServer/node_modules/infusion
04:49:45.999:  Registering module fluid-lint-all from path /home/ubuntu/preferencesServer/node_modules/fluid-lint-all
Resolved infusion from path /home/ubuntu/preferencesServer/node_modules/fluid-glob/node_modules/infusion/src/module to /home/ubuntu/preferencesServer/node_modules/infusion
04:49:46.378:  Registering module fluid-glob from path /home/ubuntu/preferencesServer/node_modules/fluid-glob
Resolved infusion from path /home/ubuntu/preferencesServer/node_modules/markdownlint-config-fluid/node_modules/infusion/src/module to /home/ubuntu/preferencesServer/node_modules/infusion
04:49:46.976:  Registering module markdownlint-config-fluid from path /home/ubuntu/preferencesServer/node_modules/markdownlint-config-fluid
04:49:47.113:
04:49:47.113:  ======================================================
04:49:47.113:  fluid-lint-all: Running all checks.
04:49:47.113:  ======================================================
04:49:47.113:
04:49:48.644:  ERROR: ESLint check failed: Object.values(...).flat is not a function
Occurred while linting /home/ubuntu/preferencesServer/src/dbOps/postgresOps.js:28
04:49:49.150:  eslint.js: 0% (0/23) files checked are valid.
04:49:49.150:
04:49:49.150:  eslint.json: 100% (16/16) files checked are valid.
04:49:49.150:
04:49:49.151:  eslint.md: 100% (3/3) files checked are valid.
04:49:49.151:
04:49:49.151:  json5lint: 100% (3/3) files checked are valid.
04:49:49.151:
04:49:49.151:  jsonlint: 100% (12/12) files checked are valid.
04:49:49.151:
04:49:49.151:  lintspaces.jsonindentation: 100% (15/15) files checked are valid.
04:49:49.152:
04:49:49.152:  lintspaces.newlines: 100% (51/51) files checked are valid.
04:49:49.152:
04:49:49.152:  markdownlint: 100% (3/3) files checked are valid.
04:49:49.152:
04:49:49.152:  mdjsonlint: 100% (3/3) files checked are valid.
04:49:49.152:
04:49:49.152:  stylelint: 100% (1/1) files checked are valid.
04:49:49.153:
04:49:49.153:  Summary: 82.31% (107/130) files checked are valid.
04:49:49.153:
04:49:49.153:  ======================================
04:49:49.153:   PASS - All linting checks succeeded.
04:49:49.153:  ======================================

It seems that all eslint checks have failed, and 23 files are marked in error - but the overall run is marked as a success.
ubuntu version 20.0.4, node version 10.19.0, npm version 6.14.4 fluid-lint-all version 1.1.5

It looks like the root failure is caused by running a version of node that is too old to actually execute current eslint correctly (the 10.x version mentioned) - but the overall run should still be flagged as a failure

Yes, there's a single line to change, I'll test for side effects and ask you to confirm that it behaves as expected for you.


Support DP with a download pattern

Support DP with Download - DP is working on a download pattern. The DS do not have much documentation around a download button or a pattern. https://service-manual.ons.gov.uk/design-system/components/button
How does it look if there are several file types available to download?
How does it look if there are several version available to download?

In the DS guidance we use a secondary button. In a DS example er use a primary button?
https://service-manual.ons.gov.uk/design-system/components/button
https://service-manual.ons.gov.uk/icons/download

Download should be a link!? - not a button
https://css-tricks.com/building-good-download-button/

For Joe and Dina to Refine.

I will add this to the UCD Jira board.

UCD Board: https://jira.ons.gov.uk/browse/CU-65

This is in the UCD prioritised backlog.

New Website Team will be working on this solution, we will apply the same approach.


Don't redirect en. subdomain anymore

This is for people who have the browser / OS language set to something other than EN, but would like to see the site in English. They can't go to the apex domain because then the locale detection / subdomain redirect will kick in.
However, we don't want to redirect all EN apex requests to the en. subdomain, though.

Thanks.
I'm gonna merge and test it on staging.
https://en.crimethincstaging.com


Android resource linking failed

Your Environment

Plugin version: ^3.0.3
Platform: Android
OS version: 9
Device manufacturer and model: Oneplus 6

Running in Simulator: no
Cordova version (cordova -v): 9.0.0
Cordova platform version (cordova platform ls): android 8.0.0
Plugin configuration options: Standard from Readme
Link to your project:

Context
I installed the plugin with the default config from the readme (for config.xml) and tried to generate the APK.
Expected Behavior
The APK gets generated properly and the app functions the same way as before.
Actual Behavior
I get a compile error:
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processReleaseResources'.
> Android resource linking failed
  /project-path/platforms/android/app/src/main/res/xml/authenticator.xml:2: AAPT: error: resource mipmap/icon (aka app.package.name:mipmap/icon) not found.

  error: failed linking file resources.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 8s
23 actionable tasks: 1 executed, 22 up-to-date
/project-path/platforms/android/gradlew: Command failed with exit code 1 Error output:
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processReleaseResources'.
> Android resource linking failed
  /project-path/platforms/android/app/src/main/res/xml/authenticator.xml:2: AAPT: error: resource mipmap/icon (aka app.package.name:mipmap/icon) not found.

  error: failed linking file resources.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 8s

Possible Fix
There seems to be something missing in my project I think.
Steps to Reproduce

run the installation command from README
add the config entries to config.xml
deleted plugins and platforms folder content
run cordova prepare to regenerate plugins and platforms
run cordova build android --release

Context
At this stage, I just want the APK to generate with the plugin being installed
Debug logs
Relevant compile output is shown above.

Is this solved?

Yes, I had to configure the plugin to use ic_launcher instead of icon.


Users refactor index page

add pagination to user props
remove backbone users app
allow props api endpoint to receive kaminari parameters

IMO you should extract API requests, parse json and camelize them there.

Some of those components can be turn into functional components - it will clean the code. Consider migrating here or create new PR for that:)


About dataset

I am a new researcher.  Can you provide me with a case for each of the ’‘objaverse-xl’‘ and ’‘objaverse-1.0’‘? The original data is too large to download. Thank you

You can download examples here without downloading the whole dataset. I also kindly redirect your request to the Objaverse authors; this is off-topic here.


Make last_pushdata a standalone function

We are attempting to move the Script type to primitives, doing so requires usage of the extension trait mechanism recently introduced. Private methods cannot be created using traits only private traits. An alternative to creating a private trait is to make a method into a function and use the concrete type as a parameter instead of taking self.
Make Script::last_pushdata a standalone function, this is only an internal change.

Fixed the incorrect terminology, no other changes.

Closing as we went for adding a private extension trait instead in #3155


Skytap virtuaclassroom setup script

Any and all feedback would be appreciated.  I initially wrote this all in one script and then decided it would be better to have a series of methods.  Is there anything else I should be doing to make this more idiomatic for ruby?


<-  or get-arrow  in demo.rye fails

I am testing demo.rye with the latest rye-fyne.exe  on my Windows laptop but it gives an error on the next line:
chk .set-checked 0 <- i <- Data/tasks

Otherwise if you would get a similar error you could use function probe that displays a value it receives and returns it also, so you can use it completely inline. Or you could call enter-console "debuging ..." above error and you would enter into console when script comes to that point and you can test the expressions and see the values in live situation.
But this was obviously a bug in release 23, so please just use the new one 26.

If bug persists with release 26 please reopen the issue.


Fix Mount's wrapper propType

This PR fixes the Mount's wrapper propTypes definition. I believe this is the intended behavior, as the wrapper prop is passed as the first argument to React.createElement which can only be a string, function, or class (in this case, PropTypes.func covers both a function and class).
cc @mlunoe @orlandohohmeier

Good catch @jfurrow ! ✨


Ifram issue

why my ifram is not rendered on the browser

Take a look at a valid example with a blog theme https://github.com/shuding/nextra/tree/main/examples/blog


Improve documentation.

Coverage remained the same at 100.0% when pulling 75a2eb6ceb8d4c66f51d3121c98bdb839c2c70f1 on improve-documentation into 19d3bfb190ecdbd52fd5981bda640ac86e169c16 on master.


plotjuggler: init at 3.6.0

Description of changes
Add plotjuggler package. I had to remove the executable bit from the plugins, because the qt5 wrapper also applies to libraries. This should probably be fixed in the wrapper
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 201492 run on x86_64-linux 1

1 package built:

plotjuggler

3.9.2 is out


at_c: make pkam_authenticate more atomic by accepting secondary address as a parameter instead of root_conn

Allows reusability of this function to things like running an atServer locally

This is probably not a good idea cause it needs keys


Mention feed channels in README

Also mention them in CONTRIBUTING.md (if they aren't already mentioned there)?


Is there any way to debug gulp's build process using node-inspector?

I have a huge gulpfile with complex logic and gulp fails on some of watch tasks. Is there any way to debug gulp's build process using node-inspector?

@chicoxyzzy's solution works for me. Thanks for that!

@chicoxyzzy's solution works for me as well, but unfortunately if I ctrl-c while the browser was still at a breakpoint, the gulp process will hang forever and I'll have to ps aux | grep gulp kill <p_id>


builder at the wall don't work

builder at the Wall don't work, he doesn't provide his reduction on nw location or attechement

He wasn't implemented, but will be soon. #945

As above


Suggestion

Hey i was wondering if you could make it work as a bookmark because i cant use extensions and really want to use it.

You can make bookmarks for individual add-ons with the instructions here (https://cookieclicker.fandom.com/wiki/Cookie_Monster_(JavaScript_add-on)#Bookmarklet)


[PRP-278] Update infra to support participant portal doc upload

Ticket
https://wicmtdp.atlassian.net/browse/PRP-278
Changes

What was added, updated, or removed in this PR.

Add new environment variables needed for doc upload in the participant portal
Grant participant ECS task IAM higher level permissions to s3 bucket
Set participant max file limit and max file size lower in dev and staging
Always define a task IAM role for ECS tasks, even though sometimes they won't need it
Attach the s3 permissions to the task role, not the task executor role

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

Testing

Screenshots, GIF demos, code examples or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

These changes have been deployed to the dev environment. To test:

Navigate to dev.wic-services.org/gallatin/recertify/changes and upload a document
The upload should work and not error in the browser
Go to the s3 bucket and see your document has been uploaded

I'll add an inline @TODO to note that we should tidy up the code so that terraform creates the bucket and remix doesn't call create bucket.


[TUIViewer]: Mode Indicator

Since there are more and more features landed in TUIViewer, I think we can at some mode indicator in the bottom of the tui viewer.

Main Report: Session View
Log Report: Log View
Detail View: Detail View

ex.
Session [20/30]
Log        [90/300]
Detail

By the way, since there may be some big changes in the proxy itself. I suggest we start work on new feature in the next release.

Got it, this make sense!


What do the samples mean?

This is more of a question than an issue, but what do the samples mean that are generated during training? I would be really grateful if someone could explain, please

This helps you understand how well the network is perfoming:
What you can see are the two cycles: A --> B --> A and B --> A --> B
So on the top row the first image is an image from category A. Then the middle picture in the top row is the same image translated into category B. And finally the last image in the top row is another translation back into category A.
The bottom row is the same but starting with an image from category B.

That makes sense, thanks


Vendor libnetwork v0.6.0-rc3

Fixes docker/docker#19576
Fixed embedded DNS to listen in TCP as well
Fixed a race-condition in IPAM to choose non-overlapping subnet for concurrent requests

Signed-off-by: Madhu Venugopal<EMAIL_ADDRESS>

LGTM

LGTM if janky is happy

Its greeeeeeen \o/


Add CLI support

Closes #1. Tried using clap, but ended picking structopt as it supports env vars out of the box and doesn't introduce unwrapping hell when default values are present.
Bad news: make run doesn't work hence WIP title, trying to find clean way to fix it, but putting args = ["run", "--${E_ARGS}"] here seems to be ugly trickery - any ideas? And is there a formal test procedure to check if something else is broken?

Great!
Formally there are not unit tests. But I thinks it's time to try to incorporate those.
So probable as a reference could be https://github.com/iron/iron/blob/master/iron/src/middleware/test.rs
But it should be come in another PR.

Bad news: make run doesn't work hence WIP title, trying to find clean way to fix it, but putting args = ["run", "--${E_ARGS}"] here seems to be ugly trickery - any ideas?

The project uses cargo-make for development. You can try to install if you want.

Suggestions for cargo run welcome.

FWI: Only the current output of static binary using x86_64-unknown-linux-musl of course:
~> make prod.release
....
Release build completed!
1,8M	./static-web-server

The binary increased 0.4MB. Ranging from 1.4MB to 1.8MB.
But I thinks it's fine due to structopt which uses clap under the hood.

Only an idea that comes into my mind. Why not rename ./src/env.rs to ./src/config.rs. Could make more sense now that we have CLI support too?

Thanks :+1:

FYI: make run issue fixed by 4712b9cc3bc47cf5f87af6bcf8d989181d12004d

Apologies for the delay, was too busy last days to apply suggestions and I see you did it yourself: thanks.


Basic features

In this feature I implemented 3 error checks for markdown files.
The program comes with a default markdown file to test, but the user can check his own md files too by copying them inside the lib directory and editing the main.rb file in bin.
This is a linter for markdown files. It was specifically built for README.md files that typically go inside GitHub repositories.
It currently detects three types of errors:

Heading errors
Paragraph indent errors
Italics in middle of a word

After you run the program, it will return a list with all errors in your md file, with the following information:

Code line
Character position
Copy of code where error was detected
A brief description of the error, and correction steps to fix it

Once you fix an error, the program won't show this error again if you run the program.

I refactored the whole code. I implemented the use of private methods and greatly simplified the md_linter.rb

I refactored the whole code. I implemented the use of private methods and greatly simplified the md_linter.rb


Attempting to acces Node net module in client.js

I'm attempting to access the Net module in client code.
Accessing the OS module works just fine (const os = require('os')), but accessing the net module seems more difficult (const net = require('net') returns undefined).
Any pointers would be greatly appreciated!

When I import net (import net from 'net') in .desktop/modules/example/index.js it is working fine though, so I'm going to try to pass it from there into the client/access it there.
Pointers still appreciated!

Ok, so I figured out I can use Desktop.sendGlobal(Desktop.getEventName('example', 'testEvent')) to trigger the event in the module,

Hey, glad you have figured it out.
Sorry for no help from me.  Usually I respond faster but this week is hectic for me 🙂
Best regards

Hi wojtkowiak, not a problem at all!
I simply figured why re-invent the wheel, but I managed to find out without investing too much time :)
Now I'm trying to figure out how to make the app launch fullscreen and remove the File, Edit, etc. buttons (kiosk mode) ;)

Now I'm trying to figure out how to make the app launch fullscreen and remove the File, Edit, etc. buttons (kiosk mode) ;)

In settings have sth like:
    "window": {
        "fullscreen": true,
        "kiosk": true,
        "alwaysOnTop": true,

and remove the File, Edit, etc. buttons

Those are removed automatically in the build (they are added by Electron runing in dev mode). You can check it by packaging or building installer: npm run desktop -- package or npm run desktop -- build-installer - they should not be present in the packaged version.

I found those options indeed, but when I press F11 to resize the window back from kiosk/fullscreen it renders an all-black window on Windows 10 (with which I can't interact anymore).
Any ideas?
I'm diving into the Electron docs/issues to see whether I can find a fix, but should you have prior experience with this issue, do tell ;)

https://github.com/electron/electron/issues/6036

I'll take it up there :)


[CRN-1043] alumni badge shared research list/details

Closing as an attempt to fix pipeline/schema issue


fix env expansion

Fixes #3961 and #1841
Fix environment expansion so we don't expand unnecessary variables - don't save the process.env or parent environment to the environment field of the cache.
Don't re-expand configure presets in the associated build/test/etc presets.
Fix expansion reporting issues with reporting an invalid config preset, and changing for each loop to a traditional for loop to make sure we dont have async issues with reporting.

We tried to verify this issue on CMake tools: v1.19.45, but we don't have detailed reproduction steps to reproduce it.


Question: enable-developer-mode flag

I'm testing my extension extensively (haha) with Puppeteer; but to debug background scripts I need each time to go to chrome://extensions and enable developer mode:

Maybe knowledgeable guys here know if there's a command line option for chromium that I can use in puppeteer.launch() to have this on by default? I googled it but didn't find any.

Me too need this flag

For the time being - here's a beautiful script I'm using rite now:
  // Enable browser dev-mode for extensions.
  const [chromeExtenstionsTab] = await browserInstance.pages();
  await chromeExtenstionsTab.goto("chrome://extensions");
  await chromeExtenstionsTab.waitFor(100);
  const devModeToggle = await chromeExtenstionsTab.evaluateHandle(
    'document.querySelector("body > extensions-manager").shadowRoot.querySelector("extensions-toolbar").shadowRoot.querySelector("#devMode")'
  );
  await devModeToggle.click();

I also need this functionality, the workaround script works for headless = false, but when you go to headless = true, it throws an error that "page.goto: net::ERR_INVALID_URL at chrome://extensions/"


Remove unneeded &mut

Message.data is changed in place, and so should by definition be mutable. however, many other traits and functions may not require mutability. Message::new(&mut ) for instance may not require mutability.

it is worth considering though that explicitly requiring the mut keyword is intent revealing and forces the caller to explicitly consider the data the pass in as mutable. still, some function arguments (anything taking in a password, for example) should be evaluated for a mutability requirement.

this mostly affects the password. We don't consume it and it shouldn't change so it probably shouldn't be mut.

I disagree with the past version of myself. Explicitly requiring &mut is idiomatic and intent revealing. Since only one mutable reference can exist at a time in rust, we create it right here and move on with our lives. Closing this issue.


style not work in BitDataPicker

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
i use persian calender of BitDataPicker but the monthes not shown completely.

Expected Behavior
No response
Steps To Reproduce
No response
Exceptions (if any)
No response
.NET Version
No response
Anything else?
No response

Please complete the expectations part of the issue.
You can make month names or you can use a small font size or you can use ۰۱ for فروردین and ۲ for اردیبهشت and ۱۲ for اسفند

@adver501
this is by design, if the month name is too big for the month container, it will be cut off to be short enough for the container to hold it correctly. as @ysmoradi suggested you can use a custom culture with arbitrary month names to resolve it as you want.

Closing due inactivity


Update the azurerm version contraint from 3.105 to 5.0

Description
Update the azurerm version contraint from 3.105 to 5.0

Type of Change

[ ] Non-module change (e.g. CI/CD, documentation, etc.)
[ ] Azure Verified Module updates:

[ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:

[x] Someone has opened a bug report issue, and I have included "Closes #79" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
[ ] Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
[ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[ ] My corresponding pipelines / checks run clean and green without any errors or warnings
[ ] I did run all  pre-commit checks

avm pre-commit done
avm pr-check has the following error i'm not able to understand:
------------------------------------------------

The preceding files contain terraform blocks that do not comply with tflint requirements.

make: *** [avmmakefile:43: tflint] Error 1

avm pre-commit done avm pr-check has the following error i'm not able to understand:
------------------------------------------------

The preceding files contain terraform blocks that do not comply with tflint requirements.

make: *** [avmmakefile:43: tflint] Error 1

Can you share the whole output from that command? In the meantime I will run it in the PR too and see if I can see the issue.

avm pre-commit done avm pr-check has the following error i'm not able to understand:
------------------------------------------------

The preceding files contain terraform blocks that do not comply with tflint requirements.

make: *** [avmmakefile:43: tflint] Error 1

Can you share the whole output from that command? In the meantime I will run it in the PR too and see if I can see the issue.

I see the error in the log:
Error: `modtm` provider should be declared in the `required_providers` block (provider_modtm_version)

  on terraform.tf line 1:
   1: terraform {

Thank you @jaredfholgate, have the following error now even when the provider 'modtm' is not used by the module.
When I declare it as a required module it prints the following message --> provider 'modtm' is declared in required_providers but not used by the module.
1 issue(s) found:

Error: `modtm` provider should be declared in the `required_providers` block (provider_modtm_version)

  on terraform.tf line 1:
   1: terraform {

------------------------------------------------

The root module . contains terraform blocks that do not comply with tflint requirements.

==> Checking that sub modules comply with tflint requirements...
==> Checking that examples comply with tflint requirements...
==> Running tflint for example ./basic
Plugin "terraform" is already installed
Plugin "avm" is already installed
==> Running tflint for example ./developer
Plugin "terraform" is already installed
Plugin "avm" is already installed
==> Running tflint for example ./default
Plugin "terraform" is already installed
Plugin "avm" is already installed
------------------------------------------------

The preceding files contain terraform blocks that do not comply with tflint requirements.

make: *** [avmmakefile:43: tflint] Error 1

Thank you @jaredfholgate, have the following error now even when the provider 'modtm' is not used by the module. When I declare it as a required module it prints the following message --> provider 'modtm' is declared in required_providers but not used by the module.
1 issue(s) found:

Error: `modtm` provider should be declared in the `required_providers` block (provider_modtm_version)

  on terraform.tf line 1:
   1: terraform {

------------------------------------------------

The root module . contains terraform blocks that do not comply with tflint requirements.

==> Checking that sub modules comply with tflint requirements...
==> Checking that examples comply with tflint requirements...
==> Running tflint for example ./basic
Plugin "terraform" is already installed
Plugin "avm" is already installed
==> Running tflint for example ./developer
Plugin "terraform" is already installed
Plugin "avm" is already installed
==> Running tflint for example ./default
Plugin "terraform" is already installed
Plugin "avm" is already installed
------------------------------------------------

The preceding files contain terraform blocks that do not comply with tflint requirements.

make: *** [avmmakefile:43: tflint] Error 1

Apologies for the delay. With customers all week. Will try to fix this ASAP if you don't figure it out in the meantime.

Hi @jaredfholgate I think we are good to go now, the pre commits checks are ok, to solve the latest issue I had to update the provider to include modtm for telemtry usage.

Move to a release branch to fix issues and run e2e tests. New PR here: https://github.com/Azure/terraform-azurerm-avm-res-network-bastionhost/pull/81


Any expected date when npm package will be available?

I have recently came across your framework and it looks great. I am in the middle of active development of my project and currently using Material-UI. However, your framework looks promising and I was wondering when the NPM package will be available?

Hi @mairh
We have updated README.md file which include the NPM install information.


CC064 invalid error

I believe that an error is being generated incorrectly
The code:
Public Shared Function ToEnum(Of TEnum)(ByVal value As Object) As TEnum
    Dim rawValue As String = value.ToString()
    Dim result As TEnum
    Try
        result = DirectCast([Enum].Parse(GetType(TEnum), rawValue), TEnum)
    Catch ex As ArgumentException
        result = Nothing
    End Try

    Return result
End Function

The issue is that 'GetType(TEnum)' is being shown as CC0064 Object reference not set to instance of an object, when it is valid.
@adraut is working on it.

Bug confirmed. CC0064 is incorrectly being raised on Enum.Parse. A simpler repro:
    Public Sub Foo()
        [Enum].Parse(GetType(String), "")
    End Sub

@giggio Should I add to the analyzer to also cover the TryParse method or should that be done in a different issue?

@adraut Seems like a different issue to me.

Same goes for other Parse() functions (Integer.Parse, Double.Parse, Byte.Parse).

@mc0re This should not affect other parse functions after the fix on #418. We have not yet published this update. I am thinking of releasing an RC2 before 1.0, so this bugs already fixed don't have to be waiting.


Stable Cadence preview release support

Description
With the Stable Cadence milestone approaching (Cadence 1.0) and preview releases of Flow CLI, emulator, flow-go SDK, etc. enabling devs to compose next version Cadence code, developers will need to be able to test their updated implementations using existing tests.
Suggestion
This testing framework is often used across many Flow projects, including standard and core repos - flow-nft, nft-storefront, flow-core-contracts to name a few. It would be very helpful to run the same tests passing with a current Cadence version against an updated Cadence 1.0 implementation using a flow-js-testing pre-release.
Context
Working on stable cadence updates to the NFTStorefront contracts and will continue to update contracts moving forward.

Working on it. Planning on posting a PR tomorrow.
(Currently mocking it with jest internally, will copy over changes upstream)

We will also need to setup a release process/separate branch/CI actions for this functionality.  I will create a feature/stable-cadence branch which releases to<EMAIL_ADDRESS>

<EMAIL_ADDRESS>has all of the latest Cadence 1.0 changes


FEATURE - Use NavigationSplitView rather than TabView for iPad

Describe the feature you want the app to have that it currently doesn't

Using a NavigationSplitView would look better on iPad rather than a TabView
Make this change at the BasicCarMaintenanceApp level depending on the OS

Describe alternatives you've considered

Comment any other alternatives you think would look good as well (comment if you're going to do something other than NavigationSplitView)

Additional context

N/A

I can take this one if it's still open 😀

@AndreasInk are you still working on this? If not, I can assign it to someone else, and you're welcome to work on a different issue

@mikaelacaron thanks for checking in, I completed this locally the day I took the task but forgot to push and open a PR, I'll do this later tonight, the alarm is set to remind me :)

lol you could've been one of the first contributors
if you haven't updated your branch since you did this, you'll 100% need to do that and probably resolve conflicts before making the PR

lol yeah I can imagine that's the case, luckily it's will not be a huge PR

@mikaelacaron as per comment on other issue, happy to pick this up and see it home if it helps still?
Would need your guidance on how to get the changes from the PR into my repo though.

You got it! Look at the changes of the other PR #178 and just manually copy / paste it, that's the easiest

I misunderstood your last message!  I thought you meant you already had it
in hand and were going to tidy it up as part of your final wrap up before
pushing to the App Store.
I can sort it out if you'd like me to, but might not be before the weekend.
On 4 Dec 2023 at 02:12:01, Mikaela Caron @.***> wrote:

@darrengillman https://github.com/darrengillman any update on this? if
not I'll be un-assigning you, thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/mikaelacaron/Basic-Car-Maintenance/issues/6#issuecomment-1837729023,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADBVZGRXUTPYE6SVRYNYJQ3YHUWPDAVCNFSM6AAAAAA5M2H4ZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXG4ZDSMBSGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

wait which email exchange....? I don't think I've emailed you before? @darrengillman

I think there are some inconsistencies in the original PR, so it's more than a copy / paste and fix the style / lint it change, and I'm not going to have the time to get into the detail this week.  So going to un-assign myself rather than hold up your schedule.

Sure, just to clarify you would like to use NavigationSplitView everywhere instead of TabView for iPad? Other than that I can take the task! @mikaelacaron

@windrunner21  The word "everywhere" here is tripping me up haha
I want to use the NavigationSplitView on iPad, because the 3 tabs at the bottom just feel kinda clunky to me
So it would use the Split View when it's in landscape or portrait

@mikaelacaron I've just started working on the feature, hope it's not a problem. When is the deadline? 😅 I wanted to ask you one question - should NavigationSplitView work on iPad and Mac as well, or only iPads?

Only do iPad right now, the Mac target doesn't even build at the moment, so don't worry about it
@windrunner21 could you finish this by next week Dec 22?

@mikaelacaron opened a PR already!


add back to top link

user needs to be able back to the list again. this will make it easier  😀

Thanks @sayjeyhi for PR. It is really helpful.


Closes #220: Rename NamedInterval (back) to CytobandInterval; "taxono…

…my:9606" is species default

@ahwagner : I resolved the conflicts with master. Ready for review.


fix: more clang compile/link errors.

Not sure about the lambda captures. clang throw "Non-local lambda expression cannot have a capture-default"
tests doesn't compile (temp excluded from build):
/usr/include/c++/v1/__random/uniform_int_distribution.h:235:5: Static_assert failed due to requirement '__libcpp_random_is_valid_urng<Catch::RandomNumberGenerator, void>::value' ""
rocky/src/tests/catch.hpp:1630:49: Use of overloaded operator '<<' is ambiguous (with operand types 'std::ostream' (aka 'basic_ostream') and 'const rocky::optional')
Adding "nlohmann_json::nlohmann_json" to target_link_libraries could be a cmake issue. I don't use VCPKG, because it doesn't work really on other platforms then windows.

Remo, I incorporated most of these changes and pushed them separately.
I did not include your build-specific changes for now. Best to keep those local until we can get GitHub Actions functioning for all platforms.


Implements mars.tensor.kron

Implements Kronecker product for tensors, just as numpy.kron does. This is required by module tensorly.

Hello @wjsi, I would like to contribute to this issue but I am not sure how to do it. Could you please provide me some guidance regarding this function (similarities in the execution of other functions in linalg, etc) and also let me know how I can create the appropriate tests for the same?

Hello @wjsi, I would like to contribute to this issue but I am not sure how to do it. Could you please provide me some guidance regarding this function (similarities in the execution of other functions in linalg, etc) and also let me know how I can create the appropriate tests for the same?

You may take a look at https://docs.pymars.org/en/latest/development/operand.html and take a look at how other operands are imlemented, for instance, mars.tensor.linalg.tensordot.

Better to understand the function itself. If we know how to parallelize it, it's actually workable, we need to implement an Operand with tile and execute method. We can help you if you find it's workable.

Hello @wjsi @qinxuye. Firstly, I am very sorry for the late message.
I was busy due to other commitments and could not give time to this. I was trying to implement the code and I have reached here-
import numpy as np

def kron(*args):
    """Replica of numpy Kronecker product of two arrays."""

    if len(args) != 2:
        raise TypeError (f"_kron_dispatcher() takes 2 positional arguments but {len(args)} were given")
    else:
        x = args[0]
        y = args[1]

        if len(x.shape) != 1:
                return np.block([
            [x[i, j] * y for j in range(x.shape[1])]
            for i in range(x.shape[0])
        ])

        else:
                return np.block([
            x[i] * y for i in range(x.shape[0])
        ])

# Test
a = np.random.rand(3)
b = np.random.rand(4, 5)
assert np.array_equal(kron(a, b), np.kron(a,b)) == True

However, I am not sure if I am going in the right direction. Could you please provide me with some guidance as to how I can go about implementing the function?


Flaky playwright test visual-regression/pages/pages-single-result.spec.ts:30:13

Description

visual-regression/pages/pages-single-result.spec.ts:30:13 › image ltr single-result page snapshots › screen at breakpoint lg with width 1024 › from search results is flaky: https://github.com/WordPress/openverse/actions/runs/4663921765/jobs/8255702950?pr=907
Reproduction

See the linked failure.

I don't think this is the case any more? @obulat I'm closing this but please reopen if you're aware of this still being an issue.


bleachbit: 2.0 -> 2.2

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/bleachbit/versions.
meta.description for bleachbit is: '"A program to clean your computer"'.

Checks done (click to expand)

built on NixOS
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 2.2 with grep in /nix/store/g8pgf3qmlh4889a60bvsdscjxyjrf32d-bleachbit-2.2
directory tree listing: https://gist.github.com/6b3750f3b96a0f9f5f1c400555be76c5
du listing: https://gist.github.com/fcf54ab4f11d9f8823190b293cb92723

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
bleachbit

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/g8pgf3qmlh4889a60bvsdscjxyjrf32d-bleachbit-2.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A bleachbit https://github.com/r-ryantm/nixpkgs/archive/06e846b34880958212a4c4a84a6916087ab464d8.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/g8pgf3qmlh4889a60bvsdscjxyjrf32d-bleachbit-2.2
ls -la /nix/store/g8pgf3qmlh4889a60bvsdscjxyjrf32d-bleachbit-2.2/bin

cc @leonardoce for testing.

duplicate https://github.com/NixOS/nixpkgs/pull/58152

Duplicate of https://github.com/NixOS/nixpkgs/pull/58152


Better handling of subfolders in module.txt

Hi,
I started using Cassette today (great job btw) and it lacked some functionality for my particular script folder structure, which is:

/scripts

/lib

jquery
jqueryui
...

/app

/shared

some-common-functionality.js

/views

home.js

I want to use PerSubDirectorySource, but also want to make sure that scripts from /app/shared folder get loaded first.
So I added this functionality to module.txt config file, it now can look like this in my 'app' module:
shared/*
*
I also added a change that allows both slashes and backslashes to be used in module.txt as dir separators.
Cheers,
Maciej Aniserowicz

Thank you very much for this. I really appreciate the inclusion of tests as well :)
I'm actually in the middle of large refactoring for v1.0. Unfortunately this has altered the code you've patched here, so I don't think it'll cleanly merge. I certainly want the functionality though, so I'll manually add it into the new code instead.

Great, thanks for the info. Keep up the good work:)


chore(changelog): update changelog type

https://konghq.atlassian.net/browse/FTI-6200

Summary

Checklist

[ ] The Pull Request has tests
[x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

The corresponding PR of Kong-ee is https://github.com/Kong/kong-ee/pull/10728


ValueError when time is floating point in _select_lp

Hi, when I gave floating point time instances, random.randint() gives Value error. Is there a particular reason for using random.randint() instead of random.uniform() ? [I locally replaced it with random.uniform(), and it worked with floating time also].
https://github.com/sdu-cfei/modest-py/blob/d539a94449547f7e8b07dec617c82003bb2ce949/modestpy/estimation.py#L612
Note that I did not give lp_frame explicitly, so it took the time from "ideal". (If the choice is related to performance, maybe rounding can be made?)
Thanks in advance

Hi, this is probably a bug. Could you make a PR with a fix including a simple unit test for this case?
https://jarv.is/notes/how-to-pull-request-fork-github/
If not, I will try to find some time to do it, but I cannot promise any deadline. I have limited time for maintaining this project.


Deploy to Geoplatform AWS

Addresses issue #97 - adding workflow to deploy to Geoplatform AWS.

Marking draft for now - still figuring out permissions on the IAM role

Merging for now; we'll want this regardless of eventual CloudFront setup. Filed #107 to work through some bugs this has introduced, likely related to HTTPS


How to do session handling with middleware?

@mtdowling, in your SymfonyLive Portland 2013 session Building web service clients with Guzzle you had a slide with an example of using event listeners to transparently manage token-based authentication. The example looks great, but my project uses Guzzle 6, which means I need to use middleware instead. I'm reading the Migrating to Middleware Upgrade Guide instructions, but this is all very new territory to me (this being my very first use of Guzzle) and I can't quite put the pieces together. Could you explain how to intercept a response exception in the new paradigm or recommend a resource that could help me toward my goal of seamless token-based authentication management? Thanks so much!

Here's a short example. Use the mapRequest middleware to modify your requests before they go out. Here I'm adding a header, but you can just as well add it as a query parameter using a similar method call on $request.
// Modify request.
$this->config['handler']->unshift(Middleware::mapRequest(function (RequestInterface $request) {
    // Add token parameter to all requests.
    $request = $request->withHeader('token', $this->token);

    return $request;
}), 'mapRequestMiddleware');

Where do you get $this->token? If it's an API token, then you'll have to provide it yourself.If your token is a CSRF token, you'll have to retrieve the CSRF token separately.
// Save token.
$this->config['handler']->unshift(Middleware::tap(null, function (RequestInterface $request, array $options, PromiseInterface $response) {
    if ($this->isAuthenticateRequest($request)) {
        $response->then(function (ResponseInterface $response) {
            // Save token from authenticate request.
            $this->token = $response->getBody()->getContents();
        });
    }

    return $response;
}), 'tapTokenMiddleware');

And there you have it. If you want to maintain session using something like a cookie jar, see https://github.com/guzzle/guzzle/tree/master/src/Cookie

Thanks, @EAnushan! I'll give this a try.


Ignore exceptions on socket close

The #422 overwrote #379 which had the same fix. Although, it was applied to __del__ method only, and the idea to add this try-except in close method was dismissed as we excepted to get this error only during garbage collection (which is not the case since #422).
Fixes #538.

This gives me flashbacks to the reason I started maintaining mcstatus. The first PR I merged looked very similar to this.

I am unsure that we care about any exceptions there. I think that it's something wrong with the user OS, but who cares, the socket is used and needs to be only closed. So if the socket failes to close, and we got all info that we need - let's just ignore that.

I'd say we generally do want the socket to get closed properly, the __del__ method is called on garbage collection, i.e. when the instance goes out of scope, it's important to ensure that the OS recognizes the socket as closed, and removes that resource from the process. That's because most kernels have limitations for processes, such as a maximum amount of file descriptors, which sockets do take up. (See: #337)
Because of that, I'm still not sure it's such a good idea to just blindly ignore all exceptions here, and it's probably worth investigating why this actually occurred, and looking into it a bit more.

Errno 107 means that the socket is NOT connected (any more).
https://stackoverflow.com/a/4668710

Would it be okay to something, like here?

Yes! That looks like a much better way to handle this, with the rest of the exceptions still getting raised, but do notice that this handling is done in socket.shutdown, not in socket.close, instead, close is still called without any handling below.
So I suppose what's going on is that if some internal flag in the socket instance, representing connection status is on, shutdown is getting called as a part of close, but if it's done manually like this, that flag gets toggled, even if we get an exception later. So calling close afterwards is safe, and that's what then makes the syscall, telling the kernel to remove that socket from the process.
I quite like this solution, but I'm not sure if I'm correct about this internal flag, if this is the case, we can use this solution.

We shutdown socket too, just in other function.

Then the handling should be done in that function, not in the exit functions

Sorry for the delay, VRChat is more interesting that I excepected


Filter available versions shown with ls

I often use nvm's ability to filter the output of nvm ls-remote to versions that start with the supplied optional argument.  For example nvm ls-remote 10.2 shows 10.2.0 and 10.2.1.
Would it be useful to add similar functionality to fnm?

Is it possible somehow to filter by name (e.g. nvm ls boron nvm ls latest nvm ls lts)?

@jgierer12 Nope. The query is limited to the version number.


Add "Box2d - Basic" test

I have only build-win32 tested
Maybe the CMakeLists.txt is incomplete for the others?

thanks, and ready to merge?

For the moment yes. You can merge. (I commented the unused stuff)


Add IDIC to Collaborative Technology chapter

It would be great, sensitive to any licensing issues, to have a picture of the IDIC from Star Trek in the Collaborative Technology chapter.

 Gov4Git notices
On Friday, 01-Mar-24 00:00:20 UTC by Gov4Git dev
Notice qvydrm
Started managing this issue as Gov4Git concern 140 with initial priority score of 0.000000.
This project is managed by Gov4Git, a decentralized governance system for collaborative git projects.
To participate in governance, install the Gov4Git desktop app.
Notice 7yn4zk
This issue's priority score is now 0.000000.
The cost of priority is 0.000000.
The projected bounty is now 0.000000.
Notice 5564r5
The set of eligible proposals claiming this issue is empty.

 Gov4Git notices
On Friday, 01-Mar-24 20:45:00 UTC by Gov4Git dev
Notice vaq44y
This issue's priority score is now 70.000000.
The cost of priority is 4900.000000.
The projected bounty is now 140.000000.
Notice cg5owx
The set of eligible proposals claiming this issue is empty.


feat(MockDataContributor): Add support of generic types

See #497
Allow entity data (newData, updatedData and mockEntry) that extends object.
Current Problem:
Type definition:
addEntry?: (mockEntry: object, odataRequest: ODataRequest) => void;
Implementation
import {MyEntity} from "../../types/MyTypes";
[…]
addEntry(this: MockDataContributor, mockEntry: MyEntity, odataRequest: ODataRequest) {
Error: Type '{}' is missing the following properties from type 'MyEntity': foo, bar
Solution:
Adjusted type definition in this PR:
addEntry?: (mockEntry: T extends object ? T : object, odataRequest: ODataRequest) => void;

merged separately


Full text versions

Is there a downloads page where people can download the full text files for all printed versions of the standard (for example: for diff'ing)

Isn't this what the Git is for?
Or do you mean a generated document with design? If so the generated print.html might be what you are looking for.
In theory concatenating the text files is not hard to do, however in my opinion Git is a better tool for most of the use-cases I can think of.

Use case is for the Dutch translation: if there is a new version of the standard, I'd like to have the complete texts (previous EN and new EN) to see what was changed in that version, so I can easily walk through that for the NL version. Maybe there are better ways of doing this?

Doesn't the Dutch translation use the same file structure as this repo? If it does, it is easy to see which files changed and how. If it does not, why?

You can easily diff between any two versions, commits or tags in Git and GitHub using Compare. This can be used to show the differences since the last version that one has translated.
-------- Oorspronkelijk bericht --------
Op 10-08-2024 07:55, schreef Jan Ainali :

Doesn't the Dutch translation use the same file structure as this repo? If it does, it is easy to see which files changed and how. If it does not, why?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

I suggest that this is a call to have better documentation to translators on how to easily generate a focused list of changes.
Using GitHub's web-UI is an option.
For example, this is how to see what has changed since the 0.8.0 tag:
https://github.com/standard-for-public-code/standard-for-public-code/compare/0.8.0…develop
However, this may not be well-matched to the needs of translators.
The git command line interface is quite powerful for comparing two version, and allows one to look a whole repository, a particular file, or a subdirectory.
For example, to look at just how the criteria have changed between two tags:
git diff 0.7.1 0.8.0 -- criteria

Documentation of what commands would guide a translator would be valuable.


How to determine if a cell contains the pole

Is there any way to determine if a cell contains the north or south pole?
By looking at the code a bit, it would seem a rule could be "base cell is 4 or 117, and it's a pentagon", which at the base resolution would be "8009" and "80d7" but when I try to map the cells onto a plate carree, those cells do not look like good candidates, e.g. (pentagons in different color to ease their location)):

The icosahedron vertices don’t like up with the poles as you noted. For this specific question it seems like you could determine the specific cell by calling geoToH3 with the polar coordinates and the resolution of the grid you want the answer for. (I.e. res 3 if you need to determine if res 3 indexes contain the South Pole)

Oh, the answer was pretty obvious, how didn't I think about it! Thanks for showing me the way :+1:


Support HDR games now that we have NV Vulkan drv with HDR support..

Hi,
today NV released a dev driver which seems to expose VK HDR support (sadly Windows only):
August 31st, 2018 - Windows 399.17, Linux 396.54.02
New Extensions:
VK_EXT_swapchain_colorspace (Windows only)
VK_EXT_hdr_metadata (Windows only)
Altough DXVK is meant for Linux, as DXVK can be used also on Windows, no pressure but perhaps it's good good to start implemeting it?
sadly first HDR games were using NVAPI extensions (in that case HDR NVAPI extensions should be added to Wine-Staging which has "some" NVAPI support)..
anyway by now we have some AAA games using DXGI HDR if not mistaken like Mass Effect Andromeda or Battlefield 1, right?

What's the point if this isn't supported on Windows? Also, I can't test this at all.

I think Windows support only limitation maybe temporal.. this extensions are also on Shield TV (Android)..
HDR and WCG APIs
no expert on HDR but:
https://docs.microsoft.com/en-us/windows/desktop/direct3ddxgi/dxgi-1-6-improvements
https://docs.microsoft.com/en-us/windows/desktop/direct3ddxgi/high-dynamic-range-and-wide-color-gamut
In order to enable HDR and WCG in your app, refer to the following APIs.

    IDXGISwapChain4::SetHDRMetaData : sets High Dynamic Range (HDR) and Wide Color Gamut (WCG) header metadata.
    DXGI_HDR_METADATA_HDR10 : structure containing the metadata settings.
    DXGI_HDR_METADATA_TYPE : enum identifying the type of header metadata.
    DXGI_COLOR_SPACE_TYPE : defines the colorspace (sRGB, YCbCr), color range, gamma settings, and other details of the color format.

some minimal samples:
first D3D12 API but almost all HDR code is in DXGI calls which will OK also for D3D11
https://github.com/Microsoft/DirectX-Graphics-Samples/tree/master/Samples/Desktop/D3D12HDR
here you have also D3D11 HDR sample:
https://github.com/Microsoft/Xbox-ATG-Samples/tree/master/PCSamples/Graphics/SimpleHDR_PC
in addition to D3D12:
https://github.com/Microsoft/Xbox-ATG-Samples/tree/master/PCSamples/Graphics/SimpleHDR_PC12

Yeah, this requires extremely new DXGI revisions. I won't support them (and with the current state of mingw headers I cannot support them).

no problem.. only wanted to know if was possible to "easily" add or not..
thanks..

just pointing out that latest AMDVLK supports VK_EXT_hdr_metadata on Linux!
so first HDR Vulkan driver..
@doitsujin can share, if that fact, updates your interest to implement HDR on DXVK?
curiously today also tested latest Unity 2019.3.0a8 adds Windows D3D11 and D3D12 HDR support.. so maybe we may see Unity indie titles supporting HDR not too far away..

Sorry to be writing on a supposedly Closed issue, however I am really wishing for HDR support in DXVK due to its great benefits to performance on Windows in select game (eg. Assassin's Creed Origins). This game supports HDR and it would be lovely if the developers of DXVK could implement an optional config flag for HDR for those that really want it. :)

Hi there.
This isn't a priority for the devs as HDR is pretty much not supported on Linux at the moment (as far as i know) and so i don't think any of the devs even have the hardware for it.
Also see https://github.com/doitsujin/dxvk/issues/2832


[ja] Replace deprecated fullversion shortcode

fixes https://github.com/kubernetes/website/issues/41486
Related to https://github.com/kubernetes/website/issues/41005

cc: @seokho-son @sftim

/area localization

/assign

@rolfedh
There are some comment from other reviewer, could you update the contents?

/cc @atoato88

Hi @kubernetes/sig-docs-ja-reviews and @kubernetes/sig-docs-ja-owners
I am SIG-Docs localization subproject co-lead, and hope to handle this PR quickly to finalize https://github.com/kubernetes/website/issues/41005 .
PTAL :)

Almost LGTM.
Could you update the content according to the comment above?

@atoato88 I'm happy to see this land even with the nit. We can clean up that last detail in a fixup PR.

@nasa9084
Could you review this?

Relevant changes since https://github.com/kubernetes/website/pull/41527#issuecomment-1631431739 are trivial.
/lgtm

sorry for late reviewing
/approve


Lz retdec 54

Let's run TC tests.

@ladislav-zezula Code and tests look ok, but features.windrivers.Test regression tests is failing across all the architectures. I hoped it is some small detail, but it looks like after this change, there are major differences in the underlying data. I'm adding outputs before and after the change. There is much less code in the output C after the change. In .dsm files, we can see that before the change, there were much more data that got decoded into instructions. After the change, these bytes are zero and we don't get instruction, functions, etc.
I'm not sure if this is ok - i.e. it was bad before, or if your changes have some bad side effects. Can you please have a look - you know more about it than I do. If you won't know right away, we may investigate it together.
out.zip

Let's run TC tests.