Dropdown not populated with options

I'm attempting to add a dropdown to one of my forms, and it appears that I'm either missing something, or the functionality is broken.
In order to illustrate what I'm trying to do without lots of irrelevant code, I've attempted to add a field to a fork of the helloworld module, as per this commit: https://github.com/pv2b/plugins/commit/f10d4e26a66588e4864a0b1700d93fdcbcfe45c6
Expected result: A form dropdown field appears labelled "color" with three options being red, green, and blue.
Actual result: A form dropdown field appears, but it's just listed as "Nothing selected" with no other selectable options as per the screenshot below:

@pv2b see https://github.com/opnsense/core/blob/16.7.1/src/opnsense/mvc/app/views/OPNsense/Proxy/index.volt#L38
Your frontend component (selectpicker) requires a refresh after load.
Maybe its better to move this kind of questions to the forum / irc, they pollute our actual workload too much.


[vite] error while transforming /app/client/vite.config.ts with esbuild in Docker image

Describe the bug
Following error when trying to run vite build  in a docker container. I tried to convert the config file to a JS file but then it throws an error on my main.ts. On my (windows) development pc the build command works perfectly.
> vite build --debug

vite v1.0.0-rc.4
[vite] error while transforming /app/client/vite.config.ts with esbuild:
Error: The service was stopped
    at /app/client/node_modules/esbuild/lib/main.js:405:31
    at Socket.afterClose (/app/client/node_modules/esbuild/lib/main.js:331:7)
    at Socket.emit (events.js:326:22)
    at endReadableNT (_stream_readable.js:1252:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)
2020-10-03T10:43:26.410Z vite:esbuild options used:  {
  loader: 'ts',
  sourcemap: true,
  sourcefile: '/app/client/vite.config.ts',
  target: 'es2020',
  jsxFactory: undefined,
  jsxFragment: undefined
}
2020-10-03T10:43:26.422Z vite:config env mode: production
2020-10-03T10:43:26.424Z vite:config env: { VITE_API_URL: 'http://localhost:3000' }
2020-10-03T10:43:26.424Z vite:config config resolved in 116ms
Building for production...
[vite] Build errored out.
Error: Could not resolve entry module (index.html).
    at error (/app/client/node_modules/rollup/dist/shared/rollup.js:5210:30)
    at ModuleLoader.loadEntryModule (/app/client/node_modules/rollup/dist/shared/rollup.js:18295:16)
    at async Promise.all (index 0) {
  code: 'UNRESOLVED_ENTRY'
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: `vite build --debug`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Vite: 1.0.0-rc.4
Docker image: https://hub.docker.com/_/node (tried multiple)
Dockerfile:
#BUILD
FROM node:14-alpine AS builder

WORKDIR /app

COPY ./server/package*.json ./server/
COPY ./client/package*.json ./client/

RUN cd server && npm install
RUN cd client && npm install

COPY . .

RUN cd server && npm run build
RUN cd client && npm run build

#SERVE
FROM node:14-alpine

WORKDIR /app

COPY --from=builder /app ./

EXPOSE 3000

WORKDIR /app/server

CMD ["npm", "run", "start:prod"]

Reproduction/System Info
I have tried tens of different docker containers with node installed, they all give me this error.
Logs (Optional if provided reproduction)
I ran with the --debug flag.

Maybe you can try this...

your docker could be missing some dependencies, use ubuntu instead of alpine image...

build your frontend first on the host rather than in the container...

You should add index.html into your container.

@underfin its there, I copy all of it to the container, hence

Maybe you can try this...

your docker could be missing some dependencies, use ubuntu instead of alpine image...
build your frontend first on the host rather than in the container...

I tried a bunch, maybe I need to try some more.
I'd like to publish the docker image from a github action, don't think building outside the container will work then. Or am I wrong here?

@underfin Also: running the same on my develop pc does work.
Why close this issue?

Seems related to:  but propose solution doesn't work. @gioxoay

Changed the location of the index.html.
Error now:
`vite v1.0.0-rc.4
[vite] error while transforming /app/client/vite.config.ts with esbuild:
Error: The service was stopped
at /app/client/node_modules/esbuild/lib/main.js:405:31
at Socket.afterClose (/app/client/node_modules/esbuild/lib/main.js:331:7)
at Socket.emit (events.js:326:22)
at endReadableNT (_stream_readable.js:1252:12)
at processTicksAndRejections (internal/process/task_queues.js:80:21)

Building for production...

[vite] error while transforming /app/client/src/main.ts with esbuild:
Error: The service is no longer running
at /app/client/node_modules/esbuild/lib/main.js:405:31
at sendRequest (/app/client/node_modules/esbuild/lib/main.js:337:14)
at start (/app/client/node_modules/esbuild/lib/main.js:399:11)
at Object.transform (/app/client/node_modules/esbuild/lib/main.js:441:9)
at /app/client/node_modules/esbuild/lib/main.js:557:78
at new Promise ()
at Object.transform (/app/client/node_modules/esbuild/lib/main.js:557:37)
at Object.exports.transform (/app/client/node_modules/vite/dist/node/esbuildService.js:60:38)
Generated an empty chunk: "index"

Building for production...

[vite] error while transforming index.553e494c.js with esbuild:
Error: The service is no longer running
at /app/client/node_modules/esbuild/lib/main.js:405:31
at sendRequest (/app/client/node_modules/esbuild/lib/main.js:337:14)
at start (/app/client/node_modules/esbuild/lib/main.js:399:11)
at Object.transform (/app/client/node_modules/esbuild/lib/main.js:441:9)
at /app/client/node_modules/esbuild/lib/main.js:557:78
at new Promise ()
at Object.transform (/app/client/node_modules/esbuild/lib/main.js:557:37)
at Object.exports.transform (/app/client/node_modules/vite/dist/node/esbuildService.js:60:38)
[write] dist/_assets/index.553e494c.js 0.00kb, brotli: 0.00kb
[write] dist/index.html 0.74kb, brotli: 0.26kb
Build completed in 0.72s.`

Using the 14-buster-slim image to build fixed it for me

I managed to get this work by running
RUN node node_modules/esbuild/install.js

before the build command.

I managed to get this work by running
RUN node node_modules/esbuild/install.js

before the build command.

Thank you very much. It works for me too.


Fixed the broken test case, migrated it to use typetest

Another bug was found that nullable decimal was not working correctly that was also fixed.

Looks good! You just forget to remove one todo comment :)


refactor init and use size adapter

remove the core validation collection method (using the size adapter is preferable)
move validation initialization outside of generated adapter
annotation attribute map is now string object (for array values and other stuff)

I'll merge it in.  Definitely a few thoughts to discuss.


Add initial codeowners for timestamp-codeowners

Also cleaned up rekor-monitor to not allow force pushing.
Signed-off-by: Hayden Blauzvern<EMAIL_ADDRESS>
Summary

Release Note

Documentation

cc @priyawadhwa @bobcallaway

Added @malancas to triage for the repo


For a 0.11.8 release

[x] (bug) Remove multithreading race conditions in resampling (use of evaluate!) (#169)

[x] (testing) Fix and re-instate all CPUThreads and CPUProcesses tests in resampling

[x] (enhancement) Add progress meter to all forms of accelerated resampling

[x] (testing) Increase number of workers in travis testing to 2 (3 processes); increase number of threads to 2.

Codecov Report

Merging #202 into master will increase coverage by 2.21%.
The diff coverage is 97.56%.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage    80.9%   83.11%   +2.21%
==========================================
  Files          31       31
  Lines        1985     2008      +23
==========================================
+ Hits         1606     1669      +63
+ Misses        379      339      -40

Impacted Files
Coverage Δ

src/MLJBase.jl
100% <ø> (ø)
:arrow_up:

src/resampling.jl
88.55% <97.56%> (+1.23%)
:arrow_up:

src/parameter_inspection.jl
100% <0%> (ø)
:arrow_up:

src/hyperparam/one_dimensional_ranges.jl
95.12% <0%> (ø)
:arrow_up:

src/composition/networks.jl
68.94% <0%> (ø)
:arrow_up:

src/equality.jl
90.9% <0%> (ø)
:arrow_up:

src/utilities.jl
75% <0%> (ø)
:arrow_up:

src/show.jl
16.03% <0%> (ø)
:arrow_up:

src/distributions.jl
84.31% <0%> (ø)
:arrow_up:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07be1b5...39c7058. Read the comment docs.


Update rdf_scheme.md

Leyla, I've rearranged the rationale section. Let me know what you think.

Oh sry I merged that too quickly - it still looks good to me

On 19/02/2015 11:38, Seb wrote:

Oh sry I merged that too quickly - it still looks good to me
—
Reply to this email directly or view it on GitHub
https://github.com/biojs/biojs.net/pull/10#issuecomment-75038228.

It looks good to me too, thanks for merging it Seb


[BUG] AUR Release failed

---------------- AUR Package version rancher-k3d-bin/3.2.0 ----------------
 # aur.archlinux.org:22 SSH-2.0-OpenSSH_8.4
base64: invalid input
Error: Process completed with exit code 1.

@iwilltry42 Is the private key correctly added to the action? with | base64 -w0?

Yep, my fault, fixed it, re-ran the job and it worked :+1:
Thanks for this pipeline :rocket:


Sidebars size doesn't save after restarting PC

🧐 Have you read the FAQ and viewed similar issues?

[ ] I have read the FAQ
[X] I have checked older issues, open and closed
[X] I did a clean install of SpotX as described in the FAQ

Сountry of your account
United States
What is your Spotify Plan?
Free
Do you have Spicetify installed?
No
ℹ Computer information
- Spotify: <IP_ADDRESS>7.gf6e7cff9
- Windows: Windows 10 22H2 19045.3324
- PowerShell: 5.1.19041.3031

📝 Description

Resize the sidebars and restart your PC

You resize the sidebars (playlist/now playing) and it does not save how big/little you resized it too.

I would expect it to save whatever size I resized it too, and not change unless I changed it myself.
📸 Screenshots
BEFORE (what I resized it too):

AFTER (I restarted my PC):

Before creating an issue, you are asked to read the FAQ and also complete the actions outlined in the first question of the FAQ.

Thanks, I've been dealing with this issue for a minute!

you didn't reply so i closed it, did it resolve after a clean install ?

Just tried it and it still does it when I restart my PC.


actions: generated Action type is unknown and export let form is not populated

Describe the bug
Not sure whether this is just me missing something. But a couple of things seem not to be working in a route with actions.
In the page component:

The generated ActionData type seems stubbornly unknown.  I tried restarting the typescript and svelte language servers, stopping and restarting npm run dev, npm run check and restarting VSCode, all to no avail.
The export let form: ActionData never seems to get populated after an invalid submission. The form does work when it  is valid, however. The action does work as I wrote it, however, redirecting on success and staying on the same page when I return invalid(...).

Here's what I'd expect to happen:
For (1) I'd assume that the generated ActionData would be inferred from the return type of my default action.
For (2) note that I've only gotten so far as trying a plain POST request, with no enhancement. I'd expect that export let form would contain something other than undefined after an invalid submission. Without resolving (1) it's hard to know what that something should be.
Anyway, I think I've read the docs correctly, but let me know if I've missed something.  Thanks.
Reproduction
https://github.com/cdcarson/issue-sveltekit-generated-actiondata-type-undefined.git
The relevant route is in src/routes/prefs.
To see that ActionData is unknown:

Run the app to generate types
Open src/routes/prefs/+page.svelte
Hover over form to get the type

To see that form never gets populated:

Run the app and navigate to http://localhost:5173/prefs
Enter "kapoor black" as your favorite color and submit. This is a forbidden color, so the action returns invalid(...). But somehow nothing is getting into the template, AFAICT.
Enter "blue" and submit. This will work and you will be redirected to the home page.

Logs
No response
System Info
System:
    OS: macOS 12.5.1
    CPU: (8) arm64 Apple M1
    Memory: 148.02 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.17.0 - ~/.nvm/versions/node/v16.17.0/bin/node
    npm: 8.15.0 - ~/.nvm/versions/node/v16.17.0/bin/npm
  Browsers:
    Chrome: 105.0.5195.52
    Safari: 15.6.1
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.71
    @sveltejs/kit: next => 1.0.0-next.472
    svelte: ^3.44.0 => 3.50.0
    vite: ^3.1.0 => 3.1.0

Severity
blocking an upgrade
Additional Information
No response

Experiencing the same. Related : #6597
Before the update. The errors object could have an unknown/undefined type but the object would still be populated when running the server.
Now the object has an unknown type and is not populated at all.

@williamviktorsson Thanks. I thought I was going off the deep end.

Now the object has an unknown type and is not populated at all

"is not populated at all" -- is that the same as me saying, above...

The export let form: ActionData never seems to get populated after an invalid submission.

... something else?

@williamviktorsson Thanks. I thought I was going off the deep end.

Now the object has an unknown type and is not populated at all

"is not populated at all" -- is that the same as me saying, above...

The export let form: ActionData never seems to get populated after an invalid submission.

... or something else?

Can't rerproduce the type issue, will push a fix for the form props issue.

@dummdidumm That worked for the props. Thanks. Side note: I really like where this is headed, having been a skeptic of the changes at first. Appreciate your work & patience.
As for the types issue, this seems to be coming up for typescript users (e.g. me, and the folks who raised #6597.) I'm pretty sure it's a VSCode/extensions issue. I'll try some things, but do you guys have an VSCode devcontainer.json, or just a list of extensions, that you could share?

Thank you!
Don't know what you mean by that VSCode devcontainer thing. Svelte files are handled through the Svelte for VS Code extension. There have been other issues raised with this not getting updated properly sometimes, but so far nothing that is reproducible. I'll try myself after things settle down a bit.

I'm experiencing the type issue as well, but I'll need to investigate more to isolate a repro. Iirc from the top of my head: it appeared when the action could return an invalid() response or a plain object { success: true } in different paths. Typescript merged the result type into any for whatever reason and that seems to cause ActionData to become unknown.

One more thing, then I'll let this go.
Looking at a route in my main project, where I originally encountered this issue, here's ActionData from ./$types...
// .svelte-kit/types/src/routes/(web)/auth/sign-in/$types.d.ts
export type ActionData = Kit.AwaitedActions<typeof import('./proxy+page.server.js').actions>;

This is using 472.
After updating the reproduction for this issue to use 473, ActionData looks like this:
// .svelte-kit/types/src/routes/prefs/$types.d.ts
export type ActionData = Kit.AwaitedActions<typeof import('../../../../../src/routes/prefs/+page.server.js').actions>;

It doesn't make a difference to whether the types are picked up (either in .svelte or .ts) but it looks like something flaky is happening.
Anyway, cheers.

I'm still seeing type errors on ActionData on 1.0.0-next.474. I have the following form and action:

{#if form?.success}

Success

{:else}
  <form method="POST">
    <button type="submit">Submit</button>
  </form>
{/if}

// src/routes/(site)/contact/+page.server.ts

export const actions: Actions = {
  default() {
    return { success: true }
  },
}

This appears to actually work correctly, but Typescript isn't happy about it. VSCode is saying the type of form is unknown and svelte-check seems to agree.
→ npm run check

><EMAIL_ADDRESS>check
> svelte-kit sync && svelte-check --tsconfig ./tsconfig.json

====================================
Loading svelte-check in workspace: /home/ben/Projects/Personal/myhearingsolution
Getting Svelte diagnostics...

/home/ben/Projects/Personal/myhearingsolution/src/routes/(site)/contact/+page.svelte:5:12
Error: Property 'success' does not exist on type '{}'. (ts)

{#if form?.success}

Success

====================================
svelte-check found 1 error, 0 warnings, and 0 hints

Digging into the types it appears type UnpackValidationError<T> = T extends ValidationError<infer X> ? X : T; isn't working properly.
// Expected this to be `{ success: boolean }`, VSCode reports it's actually `unknown`
type Test = UnpackValidationError<{ success: boolean }>

It seems that typescript can't resolve the types from '../src/runtime/control.js' in @sveltejs/kit/types/index.d.ts.
Creating a new d.ts file in the @sveltejs/kit/src/runtime directory and importing the ValidationError there seems to work.
@sveltejs/kit/src/runtime/test.d.ts:
import { ValidationError } from './control.js';

type UnpackValidationError<T> = T extends ValidationError<infer X> ? X : T;

type ValErr = ValidationError<{test: string}>

type UnpackedValErr = UnpackValidationError<ValErr>
// UnpackedValErr = { test: string; }


Add DefaultEnv

Thank you for contributing to the CF CLI Plugin Repository!
This repo contains both the plugin repo server and the metadata for CLI
community plugins.
Some of the requirements for PRs will apply to only one of these parts.
We're not allowed to accept any PRs without a signed CLA, no matter how small.
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
Submitting Plugins
If you haven't yet, please review our contributing guidelines:
https://github.com/cloudfoundry/cli-plugin-repo#submitting-plugins
In particular ensure the following requirements are being met:

[ ] The plugin's name field in repo-index.yml matches the Name field in the plugin's plugin.PluginMetadata section
[ ] The plugin's url field in repo-index.yml contains the same version from the version field

Submitting PRs to CLIPR (the CLI Plugin Repo server)
All new code requires tests to protect against regressions.
Description of the Change
We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.
Why Is This PR Valuable?
What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?
Applicable Issues
List any applicable Github Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
Who else is affected by the change?

Thanks for submitting this PR @saphanaacademy -
We'll be happy to take a look at this once the PR has passed all the checks.
Please go through the EasyCLI authorization process and take a look at the failures in the contrinuous-integration/travis-ci and see if you can resolve those.
If you're having problems, you can reach out to us in the CloudFoundry Slack #cli channel

Hey @saphanaacademy - since we haven't seen any action from you on this since my last comment/request, I'm going to go ahead and close it out.
Feel free to reopen and address the issues I mentioned previously if you'd like us to move ahead.
Thanks very much!


wrong bytes send as file data

In code of
https://github.com/Baekalfen/ICAP-avscan/blob/27e147be94f4251e2f30375ec5328d721786326d/Java/ICAP/src/icap_samplecode/ICAP.java#L187
we can see this lines:
while ((fileInStream.read(buffer)) != -1) {
sendString(Integer.toHexString(buffer.length) +"\r\n");
sendBytes(buffer);
But method InputStream.read() may not read full buffer. This method returns the total number of bytes read into the buffer, and this value should be used in next lines. For send string and as parameter for sendBytes() call.
In current state this method is sending additional bytes from buffer which were not filled by read() call.

There might very well be some missing or faulty code. I haven't had access to any ICAP hardware in years, so I rely on others to make pull-requests with fixes.

I ran into the same issue. By sending the entire buffer instead of only the remaining bytes our ICAP server didn't recognize the eicar.com testfile because it's hash was changed.


Set Page.changed_by correctly in cms.api.publish_page()

Fix for issue: https://github.com/divio/django-cms/issues/3845
Since I'm not entirely sure of the repercussions of touching cms.utils.permissions._thread_locals, I wrote a little contextmanager that uses get_current_user and set_current_user and then used that in publish_page. I figured this was least likely to have surprising effects.
I also didn't see a test for publish_page at all, so I added one that does a basic test of permissions checking, and a regression test for this bug.

Nice job!
Tests failures are related to the unicode function; In this case use the mentioned get_username method
Generally speaking in Django projects just use force_text from django.utils.encoding.

Ah; thank you for the pointers. Should've read the docs before using the model...

Thanks @morganwahl!


End-to-End OCR with LayoutReader

Describe
Model I am using (LayoutReader)
Thanks for open-sourcing such amazing work!!!
I want to do OCR on invoices, resumes.... structured documents. Could you please help me out on how can I achieve this using the LayoutReader model? If you can share scripts or approaches on how this can be done it would be helpful. I am looking for more end-to-end things like taking images and giving output as OCR does. If you can also add on how the model can be fine-tuned it would be helpful full

Thanks for your interest in our work! It is still an open question to do the doc AI in an end-to-end way. It must be a very promising direction and we believe LayoutReader can be a really helpful part of such a pipeline. So please follow up with our works and see whether you can find some potential direction to conquer the task.


Setting Points per Update

Hi,
we are receiving about 10K metrics per seconds on our go-carbon hosts.
We had max-updates-per-second = 0 and our disk utilisation was really high.
The carbon.agents.$Cache.persister.pointsPerUpdate metric was most of the time 1.
The recommanded os tuning part from the readme (https://github.com/lomik/go-carbon#os-tuning) is already in place, write-strategy = "noop"
We then set max-updates-per-second = 2000 to "force" the pointsPerUpdate to be about 5.
This worked as expected. Disk utilisation was considerably lowered, and the cache is now better used.
But I am not sure this is really a good way to force go-carbon doing "bigger" whisper update operation, reducing IO load.
Is there a better parameter to set into the config for that ?
Many thanks !

Limiting of max-updates-per-second is exactly a recommended way to lowering disk load and raising PPU. Not sure if go-carbon has another parameter for that.

okay!
But what if the amount of incoming metrics suddenly increases to, say, 100k metrics per second (so a 10x factor) ? Or x100 ?

Then metrics will be cached in the cache. If your cache is too small - then it will overflow and you start to loose metrics.
Go-carbon is a nice software but all software has limitations.

You can use Clickhouse-based setup -  https://github.com/lomik/carbon-clickhouse + https://github.com/lomik/graphite-clickhouse. It has no cache and sending metrics directly to CH.


Update settings_panel_menu.js

This PR finds the element to focus on the settings panel menu and focuses it to fix setting shortcuts. The major problem seemed to be with the personal menu tab.
Fixes: Issue #19355
Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Closing as the original issue seems to have been fixed since this was open, and I also don't understand how these code changes address the issue.


Proofreading - Optimize Retrieve Activities

Update the doc after feedback: https://github.com/mendix/docs/pull/5125/commits/0c1e945398a8903dd3140155ba9b6ba09457507d


Markdown cells in edit mode get closed when switching to another application

Steps to reproduce:

Open a jupyter notebook with markdown cells.
Double click some markdown cell to edit, and move the focus to somewhere inside it.
Press Alt+Tab to switch to a different application.
Return to vscode with Alt+Tab.

Expected behavior: should leave the markdown cell open in edit mode, as it was before switching to a different application.
Actual behavior: the markdown cell is closed (is not in edit mode) when switching back to vscode.
Setup: vscode 1.55.0, jupyter extension 2021.5.702919634, running on debian linux.

Thanks for the issue.
This should be addressed when we switch over to VS code's new notebook API. Please track this issue for when we switch:
#1231.
You can try it yourself if you use VS code insiders.


Making it available at music.box instead of musicbox.local

Many Wifi-Routers are accessible through easy.box or fritz.box etc.
It would be great if the pi musicbox was available at music.box
I couldn't find the setting or piece of code in this repo, so I was not able to do it in my personal version.
I wonder if anyone can tell me, how to achieve this, or if there is someone willing to implement this for everybody.

Hi,
I have to disappoint you.
.local addresses are configured are resolved via mDNS, which is a server and (more important) client side setting. See https://en.wikipedia.org/wiki/.local & http://web.archive.org/web/20160608083415/http://avahi.org/wiki/AvahiAndUnicastDotLocal
So, you can change the avahi configuration to announce music.box , but you need to adjust every client to resolve.
The other thing is the resolution of a normal domain name like .box or .lan. This name resolution is driven by your dhcp & dns server (most cases the Internet router). Every client receiving an IP address is registered at this device and sending over the client's hostname.
The dhcp server takes this name and adds it to the name resolution list together with a search domain.
On fritzbox, you have the (search) domain "fritz.box". A client gets the FQDN client: client.fritz.box
In another case, you can run OpenWrt as router, which runs ".lan" as the search domain for the local network, so the client is known with the FQDN client.lan.
This setting is mostly related by your setup at home. Especially on FritzBox you are not able to add custom hostname entries, which will resolve another FQDN then *.fritz.box :-(
TL;DR It is not possible to influence the complete name in the network out of a client like pimusicbox
best regards Matthias

Thanks for that explanation, sounds like we can close this.


rename and test fixes

:tada: This PR is included in version 9.0.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Livebook not working on window 10

This will be fixed in a new Livebook release. You can also use nightly build in the meantime:
https://github.com/livebook-dev/livebook?tab=readme-ov-file#desktop-app
I'm gonna close this but please let us know how it goes.

Ok, i will do it, thanks.👍
El mié, 10 de abr de 2024, 9:00 a. m., Wojtek Mach @.***>
escribió:

This will be fixed in a new Livebook release. You can also use nightly
build in the meantime:
https://github.com/livebook-dev/livebook?tab=readme-ov-file#desktop-app
I'm gonna close this but please let us know how it goes.
—
Reply to this email directly, view it on GitHub
https://github.com/livebook-dev/livebook/issues/2559#issuecomment-2047478946,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALA3ET73SIMXSYLNJZU7M23Y4UZXRAVCNFSM6AAAAABGAMTHECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBXGQ3TQOJUGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Yotta dumps traceback on invalid target name

Doing the following sequence of commands will cause yotta to dump a traceback.  A friendlier message, such as "invalid target name" would be nicer.
yotta target a.b
yotta update

Yup, see https://github.com/ARMmbed/yotta/issues/443 and related issues.

http://jira-dev0.cambridge.arm.com/browse/IOTSFW-892


INFRA-2908 Update URLs for new home in jenkinsci

https://issues.jenkins.io/browse/INFRA-2908

I'm heading away for a few days, feel free to merge this yourselves


Compatibility with @hapi/joi 17

Reza, anyone in process here on getting up to 17 or need a PR?

Nope. A PR would be great! 🙏

K, we recently had to upgrade multiple Hapi backends but it wasn't much work as I recall.  @maratvmk could you submit a PR for Joi 17? Least we can do for you maintaining these repos for so long, thanks Reza.

@jedireza please check my PR https://github.com/jedireza/mongo-models/pull/50/files
with Joi 17 and other package updates. All test passed

Thanks folks. Published as<EMAIL_ADDRESS>


TFRecords

Switch dataset formatting to TFRecords, from current version which just uses a .pt files within a directory. This should make streaming possible, which may important for real training. Slightly awkward because the preprocessing is in PyTorch and the training is in JAX. I'm told the best way to read off TFRecords during training is through tf.data

Working on this on the tfrecords branch.


Expose ConnectionId on SignalR Clients

We've had users ask about how to get a client's connectionId Our current guidance to users on how to get it is to create a Hub method to return it to them e.g.
public string GetConnectionId()
{
    return Context.ConnectionId
}

Which is less than ideal.
Another thing we planned on doing for the onReconnected events is making it have a single parameter which would be the client's new connectionId.

[x] .NET
[x] Java
[ ] JavaScript

Still have JavaScript to do here right? Is this going to land for preview 4 (end of this week)?


increasing requestTimeout to allow requests to complete

It seems like there are some requests that take longer than 5 seconds to resolve (cypress's default value), which end up on intermittent failures.
This change will allow cypress to wait for the requests to complete before proceeding with next validations/steps.

This looks like duplicate of #621


pagination not in alpha

First off, thank you for the time and energy you've devoted to this project. I have been using your alpha version to get some access to some very handy features (replaceQueues, clean all in completed, etc). I had to rollback to 0.9.0 though because pagination is necessary since I'm handling thousands of jobs sometimes. Not having clean all in completed though then becomes a real annoyance. Is there any chance we could see an update to alpha that brings in pagination?

hey, thank you very much for your comment!
I've been a bit busy but today I managed to review/merge some PRs and released a new alpha version. I'll try working this weekend on porting pagination to the alpha, you can follow the progress in this same issue!

Has pagination not made into 1.0.1 as well? Im only seeing the first 11 jobs.

Has pagination not made into 1.0.1 as well? Im only seeing the first 11 jobs.

You are right, I'v missed this feature, I will review on how it can be returned.

@felixmosh any updates on this?

Not yet, I'm working on #265, it consumes some time from me.


Express: Foreign key constraint validation issue when trying to remove entry

I get the following foreign key constraint validation issue when trying to remove an express entry:
An exception occurred while executing 'DELETE FROM ExpressEntityEntries WHERE exEntryID = ?' with params [1081]: SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (`concrete5_dummy`.`FormSubmissionNotifications`, CONSTRAINT `FK_E7B6BE406DCB6296` FOREIGN KEY (`exEntryID`) REFERENCES `ExpressEntityEntries` (`exEntryID`))

Is this happening on the develop branch?

Yup.

This join column should probably have the onDelete parameter set to it:
https://github.com/concrete5/concrete5/blob/7ea66de749faa8a6793d6ab24f74353e2c6051c4/concrete/src/Entity/Notification/NewFormSubmissionNotification.php#L20


Add library to Maven central

This library would be a great addition to mavencentral so Android studio (Gradle) users can just add something like
"compile 'antistatic:spinnerwheel:+' " to their gradle file. This will increases ease of use and popularity of this library.
I found a guide which shows you how to do that. Im not doing it myself because I don't own the library but I'd really appreciate it if you publish it to maven.
Url to the guide:
http://www.survivingwithandroid.com/2014/05/android-guide-to-publish-aar-to-maven-gradle.html

+1

Would be easy to publish on https://JitPack.io. Don't even need to upload anything. All that's needed is a GitHub release of android-spinnerwheel and a build.gradle


InAppBrowser plugin renamed

Installing InAppBrowser
cordova plugin add org.apache.cordova.inappbrowser
I get this message
WARNING: org.apache.cordova.inappbrowser has been renamed to cordova-plugin-inappbrowser. You may not be getting the latest version! We suggest you 'cordova plugin rm org.apache.cordova.inappbrowser' and 'cordova plugin add cordova-plugin-inappbrowser'
all "if" statement like this
if(cordovaMetadata.hasOwnProperty("org.apache.cordova.inappbrowser") === true) ...
fail.
Now InAppBrowser plugin is registered with this name: cordova-plugin-inappbrowser
Previous line become:
if(cordovaMetadata.hasOwnProperty("cordova-plugin-inappbrowser") === true) ...

+1
Updated to cordova 5, and I'm also changing that line.
Probabli you will need to leave both validations to keep it compatible with older cordova builds.

This was merged in the latest master.  @pbernasconi can close this ticket.


Menus add icons and helper text, like keyboard shortcuts, as well as controls like checkmarks

It seems that there is currently no support for icons etc in menu items.
It would be good to get this added to the MDL menu support.
See : https://www.google.com/design/spec/components/menus.html#menus-menu-items
I have tries to add check boxes to a menu item in MDL without much success, the text and checkbox do not line up, the menu does not seem to scale in width with the size of the text and it does not seem to matter if I put the checkbox before or after the label span the result is the same.
Obviously I am doing something wrong in the way I am trying to add this within the current MDL menu scope.
See this codepen for an example.
http://codepen.io/smcardle/pen/qOEXBZ
Regards

Ignore the comment about not scaling width as the current MDL menu items actually do....

Thanks for the issue. You are right, our menu does not fully support the spec just yet. This will be addressed in the future.
Just as a side remark, we do support icons in the menus, as can be seen on the dashboard template


Use only one address in Reply-To

We allow multiple values for the 'userslist' field, and then use that in the 'Reply-To' field for the OSS/ASF emails. We should perhaps only list the first one there?

we do, but they hadn't comma separated the list


Add Pact Swift proof of concept

Oh great catch! I'll get rid of that .log file.

tests failed with
MockService.swift:68: error: -[consumerTests.ConsumerTests testEditAssignmentGradingType] : Error setting up pact: Error

The Xcode setup is not at all ideal. That error means the pre test action script failed with either:
- not pointing to the right version of Ruby
- pact-mock_service gem not found
- or it couldn't find the start_server.sh script

I'll look into automating the pre/post action setup.

I tried automating the start/stop scripts using Fastlane which half worked. The tests passed, and pact generated a log file. But it failed to output the pact files. Manually starting and stopping the server also allowed tests to pass but pacts files were not written to disk. So far I've only been successfully able to generate pact files by using the Xcode scheme's pre/post test action scripts.

I'm wondering if we should wait on this until we have Pact working in production for mobile. It sounds like there are a few issues to resolve in the process.
The vision I had for test_advisory_board is that it's examples based on what we're using in production. I think we'd want an experimental folder or similar for projects that aren't there yet.

Thanks for the clarification. I'll close this PR.


Download page on README.md is broken

Expected behavior
When I click on the link in this line: "Get gauge installers from the download page", I expect to go to the download page.
Actual behavior
Page not found
Steps to reproduce

Open https://github.com/getgauge
Click on the link: "Get gauge installers from the download page"

Thanks for reporting, I've fixed the broken link.


Build(deps-dev): Bump @babel/core from 7.19.6 to 7.20.5 (#4469)

Pull request opened by the merge tool on behalf of #4469

Merged in 28041f45e190bc91b9c8a8d88a6184cc3d75b6c4


[QAE1168] Server setup tweaks

AWS SQS and shoryuken corrects
AWS SES mailer settings
Carrierwave AWS S3 bucket support for staging/production
AWS ElasticCache Redis Cluster support for staging and production environments
Moved current "dev" and "demo" server to separated envs as 'dev' and 'demo'
Capistrano fixes

PS: these changes also require to make some updates on "dev" and "demo" servers, as they both used "production" env and currently use own envs ("dev" and "demo")

config.force_ssl = true should be uncommented in staging and production env

config.force_ssl = true

I think right after we will apply SSL certificates for staging and prod

Ok, lets add it as an issue though.

yep


Refactoring to prep for service-based variable resolultion

Prep for integration with https://github.com/stateful/runme/blob/main/internal/api/runme/runner/v1/runner.proto#L262.
Mostly consolidating/encapsulating logic that's been a bit spread.

Please review, @pastuxso.


Determine currency of cached WMS tiles based on response headers

When MapProxy caches the response of a WMS request it should use either max-age within the Cache-Control header (preferable), or the Expires header, to compute a timestamp to store in its cache. When a second request is made for the same tile the stored timestamp should be consulted first to determine if the request needs to be reissued to the service providing the WMS.
Note: This was unabashedly borrowed from a MapCache issue request, but is equally as valid (https://github.com/mapserver/mapcache/issues/36).

This would be a treat... imagine all the time saved for not using mapproxy-seed tool to clean caches...


headlamp-plugin: v0.6.1, latest api docs, plugin/examples updated

I wonder if the semver bump is correct as we have introduced new methods, etc. that are now newly available to the plugin lib. So this would mean 0.7.0 rather than 0.6.1, right?

Yes, you're right. We could do better next time, or I could do another 0.7.0 release.


Add lessons

Thanks

thanks to God and you
On Wed, Apr 18, 2018 at 4:58 AM, Mahmoud Samir Fayed <
<EMAIL_ADDRESS>wrote:

Merged #612 https://github.com/ring-lang/ring/pull/612.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ring-lang/ring/pull/612#event-1580449044, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AiTk4dLBxIY5rBu-T9CD568uJuY7fLYqks5tpqvzgaJpZM4TZT26
.


REST metadata

Replacement PR for #11311 re-based on 3.2.x.   I'm targeting main for this PR since that's the GitHub default. Am I supposed to target 3.2.x?
Proposed changes:
The REST channel should by default load the metadata key.  I thought this worked in the past but can't seem to find when it was dropped.
Status (please check what you already did):

[ ] added some tests for the functionality
[x] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

@rgstephens Likewise here, please target 3.2.x branch instead of main.

Changed target branch to 3.2.x


running lightning cli via admin not working "lightning-cli: Connecting to 'lightning-rpc': Connection refused"

so i followed the instructions per:
https://raspibolt.org/guide/bonus/lightning/cln.html#allow-user-admin-to-work-with-cln
and i'm still receiving "lightning-cli: Connecting to 'lightning-rpc': Connection refused"
i restarted services ( bitcoind and lightningd) i reboot nothing...any suggestions?
thanks in advanced

Can you share your config file? (https://raspibolt.org/guide/bonus/lightning/cln.html#config-file)
Also which outputs do you get when you run
sudo journalctl -f -u lightningd
and
lightning-cli getinfo
?

Most likely bitcoind has not finished starting up or chain is not completely synced.

This is typically because Bitcoind or LND isn't running.
Verify that bitcoin is running. As admin user:
bitcoin-cli getblockchaininfo
if this returns an RPC error, then it's not running and you need to restart it.
sudo systemctl restart bitcoind
then enable, start and unlock LND
sudo systemctl enable lnd
sudo systemctl start lnd
systemctl status lnd
remember to also restart Electrum server and RTL and Blockexplorer.


Add support for openid for authentication

The implementation is being dogfed with gitlab as the OpenID issuer.
In order to work, the issuer needs to:

be discoverable (with GET /.well-known/openid-configuration)
have a userinfo_endpoint in the openid configuration

Authentication is done through white-listing. If there are no whitelist
fields, then anyone can create an account, therefore can publish and own
crates in the registry.
When ktra is built with openid, all the user management endpoints are
disabled to avoid tampering through unauthenticated POST calls.
Also, there is no point storing a password, but as the password
interface is strongly coupled with the DbManager trait, for the time
being a dummy password is inserted for users. This is deemed not
dangerous as all authenticated routes aren't compiled when the "openid"
feature is present
A user_by_login function has been added to the DbManager trait because
the login is now dynamically computed from the OpenId issuer.

Other notable changes

A test workflow, mostly to test all db implementations with/without openid (it should at least compile)
Bumping the docker base image to Rust 1.56, latest stable version
Push extra docker images with openid enabled

Notes
I tried to keep the code somewhat generic in order to allow other issuers to plug in easily, but the changes are still geared towards my company's usecase (being "we want to use gitlab openid for user authentication"). This shows mostly in 4 different points :

requiring a discoverable config
requiring a userinfo_endpoint
adding extra fields in models::Claims which (optionally) match the extra claims from gitlab OpenId I want to use
adding extra fields in config::OpenIdConfig which (optionally) describe the authorized gitlab entities on the registry

As is, I think it's ready for this usecase, so I'm pushing the PR here if anyone wants to review it/start using it, modifications are welcome. (I know I can build a docker image from it for my use case so that's good enough for me even if the PR doesn't make it)
Example
With this config
[index_config]
remote_url = "[redacted]"
https_username = "gagbo"
https_password = "[redacted]"
branch = "master"

[openid_config]
issuer_url = "https://gitlab.com"
redirect_url = "http://registry.szl"
client_id = "717dc...."
client_secret = "[redacted]"
additional_scopes = ["openid", "profile", "email"]
gitlab_authorized_groups = [ "firm/groups/crate_owners" ]
gitlab_authorized_users = [ "gagbo" ]

[server_config]
port = 80

The client_id/client_secret pair is coming from Gitlab where I added an application to my profile for test purpose, with the scopes openid, profile, and email

Upon going to registry-url/me I arrive at the sign on for Gitlab where I authorize the app, and then after redirection firefox is showing me my token :

(The username has since been modified to gitlab.com:gagbo instead)
and I can use it locally :

@gagbo, I have been setting up a ktra server using this PR, and it is very pleasant to use. Thank you!
Do you have plans to enable adding/deleting users from API endpoints instead of defining the authorized users/groups directly from the config file/CLI options?

I recently got invited to the organisation to get this merged first with the few other changes that were pending, I'll need to find time to finish this first.
Currently I don't plan to add extra endpoints to deal with it, but PRs are of course welcome. I suppose the main point here would be to actually use the db_manager to add extra functions related to permission handling, it was easier for me as a first PR to just stuff everything in the config file. I'll try to take a look into this, but I don't expect to have much time for ktra features before ~2 months I think
Glad you like it :) I've been using this as well for our startup and it definitely fits the bill

Oh absolutely no problem, I was just throwing ideas out there. As I use ktra I might start contributing as well :)

I changed the base branch of this PR to develop.
So could you also rebase your working branch?


Update to terser v4

v4.0.0 of terser has been released. It would be nice to see this PR merged and released.

@stefanpenner - ping. :)

https://github.com/ember-cli/broccoli-uglify-sourcemap/releases/tag/v3.2.0


[release-4.15] OCPBUGS-39099: Avoid Shared Access Key usage for Azure Storage Account when using Managed Identity based auth

note that other than running go mod vendor (second commit in this PR), I also needed to bump go.opentelemetry.io/otel/exporters/otlp/otlptrace and go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc to v1.19.0 as per https://github.com/open-telemetry/opentelemetry-go/issues/4586 to fix an issue when running go mod tidy, this is why the vendored changes are bigger in this PR than in comparison with its sibling backports.

Note for QE
Because 4.15 is GA, we cannot backport the "containers/delete" permission. @rajdeepc2792 has wrote the code in a way that storage account deletion should still proceed [when setting managementState: Removed] even after container deletion fails due to lack of permission, so please double check that is the case. If you find that not to be the case, we will still go ahead with this backport but we will create a pre-emptive bug describing the issue with a documented workaround (which we will need to figure out). Though I'm hoping it won't come to that 😅

/label cherry-pick-approved

/jira refresh

@flavianmissi , I didn't face the problem when running go mod tidy after just performing the cherry-pick and running go mod vendor on my machine.
Although when upgraded the go get<EMAIL_ADDRESS>I faced the issues similar to https://github.com/open-telemetry/opentelemetry-go/issues/4586, but the resolution to update go.opentelemetry.io/otel/exporters/otlp/otlptrace and go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc to v1.19.0 doesn't work for me.
Although the changes after the vendoring in this particular PR looks correct.

/label qe-approved

/unlabel qe-approved

/remove-label qe-approved

Sorry @flavianmissi  I removed the label, can you see my comments in the bug, not sure if it's an effect scenario? thanks

/retest

/label qe-approved

failures look unrelated to changes
/retest

Closing in favor of https://github.com/openshift/cluster-image-registry-operator/pull/1111, which does not include a bump to otel.
/close


HDDS-5761. should not shutdown om when setting a bigger bucket quota  than volume quota

What changes were proposed in this pull request?
failed with exception
java.lang.IllegalArgumentException: Total buckets quota in this volume should not be greater than volume quota : the total space quota is set to:256000. But the volume space quota is:102400
at org.apache.hadoop.ozone.om.request.bucket.OMBucketSetPropertyRequest.checkQuotaBytesValid(OMBucketSetPropertyRequest.java:281)
at org.apache.hadoop.ozone.om.request.bucket.OMBucketSetPropertyRequest.validateAndUpdateCache(OMBucketSetPropertyRequest.java:172)
at org.apache.hadoop.ozone.protocolPB.OzoneManagerRequestHandler.handleWriteRequest(OzoneManagerRequestHandler.java:246)
at org.apache.hadoop.ozone.om.ratis.OzoneManagerStateMachine.runCommand(OzoneManagerStateMachine.java:472)
at org.apache.hadoop.ozone.om.ratis.OzoneManagerStateMachine.lambda$2(OzoneManagerStateMachine.java:291)
at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1604)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
2021-09-17 19:50:35,317 [shutdown-hook-0] INFO org.apache.hadoop.ozone.om.OzoneManagerStarter: SHUTDOWN_MSG:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5761
How was this patch tested?
unit test

@ayushtkn thanks for the review, i will modify current tests to cover this issue

@ChenSammi @ayushtkn  PTAL!

Thank You @JacksonYao287 for catching this bug and fixing this.

@ayushtkn I missed your comments, looks like tests are fixed with latest code changes. If any, we can open a new Jira and fix this.

@bharatviswa504 @ayushtkn thank you for the review!


npm start error

Hi, I built nodeos using the instructions on the website. Everything build fine, but when I go to run npm start I get this error:
  return binding.readlink(pathModule._makeLong(path), options.encoding);
                 ^

Error: ENOENT: no such file or directory, readlink 'out/latest'
    at Error (native)
    at Object.fs.readlinkSync (fs.js:1014:18)
    at Object.<anonymous> (/home/johnroper100/NodeOS/scripts/start:11:15)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:394:7)

I looked in the files, and there is not a folder named out anywhere.

Try npm install first on a fresh clone and then npm run build, the instructions are a little bit outdated.

It should be fixed in master, sorry for the delay. Clossing.


Dependency error: @valapi/* packages

Hey! I'm interested in this package because it says it supports MFA
I tried the following command
yarn add @ing3kth/val-api

Which yielded this error:
error Couldn't find package "@valapi/api-wrapper@latest" required by "@ing3kth/val-api" on the "npm" registry.

followed by these errors:
Error: Couldn't find package "@valapi/riot-api@latest" required by "@ing3kth/val-api" on the "npm" registry.
Error: Couldn't find package "@valapi/lib@latest" required by "@ing3kth/val-api" on the "npm" registry.
Error: Couldn't find package "@valapi/riot-client@latest" required by "@ing3kth/val-api" on the "npm" registry.
Error: Couldn't find package "@valapi/valorant-api.com@latest" required by "@ing3kth/val-api" on the "npm" registry.

Also, when I visit the npm page, I get redirected to the login page, has if I didn't have permissions.
Are the packages private ?

try this first
yarn --registry https://npm.pkg.github.com
then reply to me.

.npmrc
create .npmrc
Example

project 1/

node_modules/
src /
package.json
.npmrc

project 2/

registry
then put this text to .npmrc
Example
@ing3kth:registry=https://registry.npmjs.org
@valapi:registry=https://npm.pkg.github.com

I think it will work
or not!??

Ok I'll try this
But I'm wondering, isn't this supposed to be done by you in the KTNG-3/valorant-api/.npmrc, so that anyone that wants to use your project can do it right away without looking for this issue?

probably yes, I just want to try

[x] if it works, great

[ ] if not, I just try another method until getting the best of the best.

What my project looks like
.
├── src/
├── node_modules/
├── package.json
├── .npmrc
└── yarn.lock

.npmrc
@ing3kth:registry=https://registry.npmjs.org
@valapi:registry=https://npm.pkg.github.com

manually set yarn config
~ yarn config set "@valapi:registry" "https://npm.pkg.github.com/"
yarn config v1.22.17
success Set "@valapi:registry" to "https://npm.pkg.github.com/".
~ yarn config set "@ing3kth:registry" "https://registry.npmjs.org"
yarn config v1.22.17
success Set "@ing3kth:registry" to "https://registry.npmjs.org".

result of yarn config
~ yarn config list
yarn config v1.22.17
info yarn config
{
  ...
  '@ing3kth:registry': 'https://registry.npmjs.org',
  '@valapi:registry': 'https://npm.pkg.github.com/'
}
info npm config
{
  '@ing3kth:registry': 'https://registry.npmjs.org',
  '@valapi:registry': 'https://npm.pkg.github.com'
}

install
~ yarn add @ing3kth/val-api
error Couldn't find package "@valapi/api-wrapper" on the "npm" registry.
Error: Couldn't find package "@valapi/lib" on the "npm" registry.
Error: Couldn't find package "@valapi/riot-client" on the "npm" registry.
Error: Couldn't find package "@valapi/riot-api" on the "npm" registry.
Error: Couldn't find package<EMAIL_ADDRESS>on the "npm" registry.

With npm
~ npm config set "@valapi:registry"="https://npm.pkg.github.com/"

~ npm config list
; "user" config from /root/.npmrc

; @valapi:registry = "https://npm.pkg.github.com/" ; overridden by project

; "project" config from /app/.npmrc

@ing3kth:registry = "https://registry.npmjs.org"
@valapi:registry = "https://npm.pkg.github.com"

; node bin location = /usr/local/bin/node
; cwd = /app
; HOME = /root
; Run `npm config ls -l` to show all defaults.

~ npm install @ing3kth/val-api
npm ERR! code E401
npm ERR! Incorrect or missing password.
npm ERR! If you were trying to login, change your password, create an
npm ERR! authentication token or enable two-factor authentication then
npm ERR! that means you likely typed your password in incorrectly.
npm ERR! Please try again, or recover your password at:
npm ERR!     https://www.npmjs.com/forgot
npm ERR!
npm ERR! If you were doing some other operation then your saved credentials are
npm ERR! probably out of date. To correct this please try logging in again with:
npm ERR!     npm login

I find a problem when going to npm.pkg.github.com it says you need to login to GitHub first IDK why but
I change all package paths to NPM.
so delete all hard work and use the default.

Haha ok, thank you for trying, i'll retry with the default way when you push.
Then, i'll close the issue if it works.

A simple yarn add @ing3kth/val-api does the trick now !
Sorry for the trouble

np


eap74-rhel84-standalone-byos-patch4

Fixed the storage kind issue. Now user can select "StorageV1 or StorageV2" as per desire.

Need to resolve conflict above

Need to resolve conflict above

I think since the file location have changed. I need to fork the repo again and then raise the PR.


change datetime format prior to json dump

This is to address the issue with datetime objects being converted to UNIX time stamps when being serialized. This occurs when the temporal column is used as the group by key.
This is discussed here and here.

I'd rather see an approach closer to TableViz.json_dumps. The solution should be around here:
https://github.com/apache/incubator-superset/blob/master/superset/viz.py#L582
I don't understand why there's condition there, but removing the condition an following the True branch might just do the trick.

Codecov Report

Merging #5365 into master will increase coverage by <.01%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master    #5365      +/-   ##
==========================================
+ Coverage   61.31%   61.31%   +<.01%
==========================================
  Files         369      369
  Lines       23497    23508      +11
  Branches     2715     2715
==========================================
+ Hits        14407    14415       +8
- Misses       9078     9081       +3
  Partials       12       12

Impacted Files
Coverage Δ

superset/connectors/druid/models.py
80.68% <100%> (+0.11%)
:arrow_up:

superset/viz.py
81.22% <50%> (-0.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b15592...0c104f6. Read the comment docs.

Understood @mistercrunch, I've moved it like you suggested and it makes much more sense now.

"stale[bot]" marked this inactive. However, this PR appears to still be open. What would it take to get this merged in? Thanks!


Not working with the new Chrome version 72.x

Everything was fine until Chrome version 72.x came. Now, there's no scrolling in my project, which makes it totally not useful. I tried tweaking the configs but nothing is working. Have you had a chance to test it with Chrome 72.x? How can I get it to work again as it did with versions < 72?
Thanks in advance.

Hey. I just tested the examples on http://echa.github.io/ng-scrollable/ in Chrome 72.0.3626.96 (Official Build) (64-bit) on OSX 10.14 and scrolling seems to work just fine.
You have to send a more specific bug report for me to be able to help you. Make a minimal stand-alone example page that shows the bug and I'll have a look at it.


Tests changes

See commit log for details.
This would hopefully make it easier for people to contribute to Wagtail

Thanks, @kaedroho. Why have you removed the drone config, out of interest?

@tomdyson I removed it so we didn't have to update two CI configs. Will add it back if people found Drone useful though

:+1: on SQLite by default


Broken map previews

When a user hosts a map which is not in the map vault, other FAF users will recieve a blank/broken preview image for that map. When the map is uploaded to the vault, or a map with the same name is uploaded, this preview image is never changed. This results in one of the scenarios which creates users having broken/missing preview images in the find games tab for certain maps..

If a map is not in the map vault, there's nothing we can do but display a fallback image (which we currently do correctly?)
As every fetched map preview is cached for the lifetime of the client (also if there is none), the client needs to be restarted in order for the map preview to be fetched again.
I see this as a very rare edge case.

The issue mainly occurs when someone making a map tests it through the faf client before uploading. Its actually quite common as most map makers do not attempt to avoid this problem or are unaware of how it occurs. Even some of the most popular maps have had this issue (crimson fued). While it can be worked around by testing a map under a different name its extremely tedious.
While the issue is avoidable, fixing it would greatly improve the experience of new, and even experienced, map makers, as there is already a long list of do's and dont's for making a map work properly.


Added convas.io

Convas is a feedback page for companies and projects. We have a free plan for open source projects.

Thank you! 👍


Fix ec2 VPNConnection Tags to support list as well as Tag object

Recent update altered the way tags were supplied to the VPNConnection resource which broke pre-exisitng scripts that used a list for adding tags. Adding list to Tags property of VPNConnection

I don't have access to create a branch. In ec2.py, I propose to change line 699  from "'Tags': (Tags, False)," to "'Tags': ((Tags, list), False),"

Agreed on regression. I just pushed a fix out. Although I would encourage people to migrate from using list to Tags.

@archercrichton just pushed release 2.4.9 with the fix. Thanks for the issue.


"Try this" suggestion includes trailing comments

Prerequisites
Please put an X between the brackets as you perform the following steps:

[x] Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues
[x] Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries.
[x] Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)

Description
If I have this code
theorem foo (h : 1 = 1) : 1 = 2 := sorry

theorem bar : 1 = 2 := by
  simpa? using foo (by simp)
  -- This is a comment
  -- This is another comment

Then the "Try this" suggestion in the infoview looks like this:

After accepting the suggestion, the code is turns into this:
theorem foo (h : 1 = 1) : 1 = 2 := sorry

theorem bar : 1 = 2 := by
  simpa only [Nat.reduceEqDiff] using
    foo
      (by simp)  -- This is a comment
          -- This is another comment
  -- This is a comment
  -- This is another comment

Now the comments are duplicated
Steps to Reproduce

Paste the above code into the Lean 4 web editor

Expected behavior: Comments are not included in the suggestion
Actual behavior: Comments are included, leading to duplication upon accepting the suggestion
Versions
4.10.0-nightly-2024-06-27
Impact
Add :+1: to issues you consider important. If others are impacted by this issue, please ask them to add :+1: to it.

Jujian Zhang just ran into this while demoing Lean to a bunch of people in Durham :)


HDSI Scholarship Blog Post

@TQZhang04 @Ludwigvsch received HDSI Undergraduate Scholarships for AY24-25.  Submit blog post in style of https://e4e.ucsd.edu/news-and-updates/2021-hdsi-undergraduate-scholarship-recipients
Additionally, post on the following:

[ ] Facebook
[ ] Instagram
[ ] Linkedin

@TQZhang04 @Ludwigvsch would you like to draft the posts?


MSSQL Dialect: Create() fails with LastInsertID error

As of this recent commit to https://github.com/denisenkom/go-mssqldb/commit/44cdfe8d8ba9a7322b38cd8fbb0f2cb445e65a69 LastInsertID is no longer supported when using Go 1.0 and later.
Since the GORM mssql dialect depends on go-mssqldb, this causing some issues when using the .Create() ORM method, e.g.:
if newObj := tx.Create(&fakeRecord).Error; err != nil {

    app.log.Error("Error creating record: ", newObj.Error)

    tx.Rollback()
}

The following error (from go-mssqldb) is logged:

LastInsertId is not supported. Please use the OUTPUT clause or add select ID = convert(bigint, SCOPE_IDENTITY()) to the end of your query.

Perhaps this is something that can be patched using LastInsertIDReturningSuffix?

Hi
Im facing the same issue. For now i manually changed the go-mssqldb package code (downloaded from this commit https://github.com/denisenkom/go-mssqldb/tree/db2462fef53bd29c619fe40f73cbfcc12be79d9f).
Should be a temporary fix until it is patched.
Cheers

@tentone Can you please show what changes you made?
Thanks

I havent changed anything code wise. Just rolled bad manually the package.
You can achieve this by installing dependencies using "go get" as usuall and then go the gopath and replace the go-mssqldb code with the one you downloaded from the link above.
Run "go get" on the go-msqldb directory and youre good to go. This is not a fix its just a temporary workaround.

You can now force that specific version of the mssql driver using golang's new modules dependency manager. Just came out with Go 1.13


Always pass through timeout when creating a process

The Symfony\Component\Process\Process class allows setting a null value for the timeout, indicating the process does not have a timeout.  The generator class only configures the timeout when it is a non-null value, making it impossible to configure the generator to run without a timeout (i.e. in a command line context as a system job where a long-running process is intended).
This change allows configuring the process to have no timeout by always passing through the timeout value from the generator.
This will have no B/C impact as the generator's constructor has an explicit $this->setTimeout() call with a default timeout.

Thanks Michael, good catch in thisn PR.
p.s: thank for your work on Pagerfanta :)


Potential missing data in transfer / migration

Comparing the live site and test, it seems that perhaps not all of the templates have transferred.
This is the St Andrew's admin area on the live site

And on test

The template called "EPSRC template (Full version)" is missing. Is this perhaps because of bad data i.e. an indication of whether this template is published or not being invalid?
Could we perhaps run some queries to check that the #templates #guidance_groups #organisation #suggested_answers etc match across current live data and test?

This doesn't only appear to be linked to invalid data. Having changed my affiliation to Strathclyde uni, see these comparisons:

This now appears fixed. Every comparison I have made has given a matching template list. Closing out


document PodSecurity admission settings

kubernetes 1.24 turns on PodSecurity admission on by default. Our plugin deployments need hostPath mounts so the baseline policy fails by default.
We want to document how to comply with Pod Security Standards when using the plugins.
https://kubernetes.io/docs/concepts/security/pod-security-admission/

Our plugin deployments need hostPath mounts so the baseline policy fails by default.

Looks like the default configuration is not baseline after all but privileged so there's no immediate blocker for running the plugins with defaults. Closing.


Icon request: Revolt

URL for the brand / site / app
https://revolt.chat/
Logo resources for the icon
https://revolt.chat/_next/static/media/revolt-logo.24213514.svg or https://revolt.chat/favicon.ico (the favicon is quadratic, the other one not)
Anything else?
No response
Confirmation

[X] I have read and followed the issue guidelines.

Here you go!
https://github.com/aegis-icons/aegis-icons/blob/master/SVG/Revolt.svg

:question: How to add icon(s) to Aegis?
:star: Support this project by giving a star! Just adding like to this comment is also appreciated.


Refactor styles.css

Is your feature request related to a problem? Please describe.
The custom css after the intial bulma import and global sass variable declaration is a bit messy from the first draft and my newness to bulma
Describe the solution you'd like

[ ] Considering design feedback, look for places to replace customized css with existing bulma structures.
[ ] refactor any remaining css as possible to create a more usable and concise structure.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Not really what needs to happen now - need to tweak around the mobile mockup.


Specify Path of Chrome To Run?

Summary
What:
Not enitely sure how this would be done, or if it can be, but i think it'll be good to specify what chrome version to use (and at a later point, which other browser versions to use when more are supported)
Why:
When you're running browser tests, the browser version is key - something might break or might not work on one version, but work on another. For example, if i have a prod app, i might want to tell it on the following browsers:

Chrom v68
Chrome latest
Chrome v67 (maybe i want to support users using this version, so i wanna make sure everything works here too)

Acceptance Criteria
Below is a list of tasks that must be completed before this issue can be closed.

[ ] Write documentation
[ ] Write unit tests
[ ] Write integration tests
[ ] Da feature

Example Pseudo Code (for implementation)
// Add example pseudo code for implementation

Don't think it's possible, in the sense of being able to do const Sinco = new HeadlessBrowser({ version: 68 }) because the chrome. browser points to the users installation
But maybe we could allow a path for the config, eg from a users perspective:
$ alias chome_v68="/Users/.../chrome.68.exe" # or export CHROME_V68="..."
$ cat app_test.ts

const Sinco = new HeadlessBrowser({ path: "chrome_v68" }) # or path: "$CHROME_V68"

Internally, the above would look like:
constructor (configs) {
  this.path = configs.path
}
public start () {
  Deno.run({
    cmd: [..., this.configs.path]
  })
}

There's literally no information anywhere, and most posts are just like this: https://stackoverflow.com/questions/47874959/firefox-remote-debugging-using-websocket, a perfect question with no answer


It's not work with Mhook_Unhook

Only hook one api, and call the Mhook_Unhook to restore it, It's bad to TrampolineGet return NULL.

In function Mhook_SetHook, *ppSystemFunction is assigned to pTrampoline->codeTrampoline.
In Mhook_Unhook, *ppSystemFunction is passed to TrampolineGet, by comparing with pCurrent->pHookFunction to get owned pTrampoline.
In my test, unhook always return FALSE because TrampolineGet always return NULL.
This bug can be fixed by modifying function TrampolineGet pCurrent->pHookFunction to pCurrent->codeTrampoline


Allow Spanish chars in Legal first and last name

@madmax330 @eVoloshchak PR is ready for review.
Details
Spanish alphabet not accepted for Legal first name and Legal last name field on personal details page. So in this PR we corrected ui logic, so now it allows Spanish alphabet for input and does not show ui error if Spanish characters entered.
Note: In this PR we corrected UI logic, but it needs to correct backend logic also. Because at present PersonalDetails.updateLegalName() api is returning 200, but name isn't saved If first or last name contained a Spanish character and during save name is replaced with an empty string by server side api. So internal team will take care of it by updating backend logic. Refer this comment.
Fixed Issues
$ https://github.com/Expensify/App/issues/17628
PROPOSAL: https://github.com/Expensify/App/issues/17628#issuecomment-1514078154
Tests

Go to Profile > Personal Details > Legal name
Input Spanish chars in Legal first name and Legal last name
For example, Input "Ronaldinho Gaúcho" or "Begoña" etc.
Verify that input fields (Legal first name and last name) allow Spanish chars and does not show ui error.
During this QA no need to click Save button, because backend logic needs to update by internal team, so backend will accept Spanish chars too.

[x] Verify that no errors appear in the JS console

Offline tests

Go to Profile > Personal Details > Legal name
Input Spanish chars in Legal first name and Legal last name
For example, Input "Ronaldinho Gaúcho" or "Begoña" etc.
Verify that input fields (Legal first name and last name) allow Spanish chars and does not show ui error.
During this QA no need to click Save button, because backend logic needs to update by internal team, so backend will accept Spanish chars too.

QA Steps

Go to Profile > Personal Details > Legal name
Input Spanish chars in Legal first name and Legal last name
For example, Input "Ronaldinho Gaúcho" or "Begoña" etc.
Verify that input fields (Legal first name and last name) allow Spanish chars and does not show ui error.
During this QA no need to click Save button, because backend logic needs to update by internal team, so backend will accept Spanish chars too.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Chrome
https://github.com/Expensify/App/assets/7823358/3f29e2d2-86d3-4a52-bdd7-8e9c7aae869d
Safari
https://github.com/Expensify/App/assets/7823358/ecb48a27-4e5c-431e-8792-4df66eda9bab

Mobile Web - Chrome
https://github.com/Expensify/App/assets/7823358/6f8dd068-6e65-4070-b074-59cf3d472f1d

Mobile Web - Safari
https://github.com/Expensify/App/assets/7823358/d8fe6820-6fce-44e6-a304-0579c54cafa0

Desktop
https://github.com/Expensify/App/assets/7823358/228cb876-6045-4425-8d90-0d8842981763

iOS
https://github.com/Expensify/App/assets/7823358/555b71bb-3e6a-43a7-ab2d-e3d28b98bdaf

Android
https://github.com/Expensify/App/assets/7823358/e4fbb808-d77e-4c5e-b100-7c476c4dafe6

@eVoloshchak @madmax330 Just request, can we review and merge this PR asap, so will not miss timeline bonus. Thank you.

Reviewing this shortly

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@PrashantMangukiya, did you confirm that Spanish localization is correct? I can ask someone from the team to confirm this if not

@PrashantMangukiya, did you confirm that Spanish localization is correct? I can ask someone from the team to confirm this if not

I took Spanish translation from google translate. It looks ok for me, but I think we can ask someone from team to confirm it is correct. So in future there will be no need of any correction. Thank you.

@madmax330 any suggestion about the comment https://github.com/Expensify/App/pull/18786#pullrequestreview-1426538952

@PrashantMangukiya I will make the backend updates this week. So I think we're good to merge. Also note that we're not going to be doing any deploys today, tomorrow and Friday due to EC3 (an accounting conference we're holding) so I will have plenty of time to get the backend changes done.

@madmax330 Thank you for update.

@madmax330, friendly bump on this

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.18-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.18-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.18-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.18-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


merge from arlac77/npm-package-template-esm-only

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 -x 'tests/**/*' --temp-directory build/tmp ava && c8 report -r lcov -o build/coverage --temp-directory build/tmp

Codecov Report

Merging #602 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #602   +/-   ##
=======================================
  Coverage   87.61%   87.61%
=======================================
  Files           6        6
  Lines        1001     1001
  Branches       82       82
=======================================
  Hits          877      877
  Misses        124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b50b7fe...475ab45. Read the comment docs.

:tada: This PR is included in version 3.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Questions about the rnn states

Hi @magehrig
This time when I reviewed your code about the function training_step in modules/detection.py, I got some confusion about the rnn state:

In the config/dataset/gen4.yaml file, the sequence_length parameter has been set to 5. This means that the dataset will always be sent to the model in groups of five consecutive elements. My interpretation of this setting is that the LSTM's state will reset when it receives the first input of each group of five, and the prev_state of the fifth input will not have a direct influence on the subsequent group. In other words, the state of the model for each quintuple is not directly related because each quintuple is not continuous, especially when in random mode.

What confuses me is the function code function training_step in modules/detection.py:

self.mode_2_rnn_states[mode].reset(worker_id=worker_id, indices_or_bool_tensor=is_first_sample)
prev_states = self.mode_2_rnn_states[mode].get_states(worker_id=worker_id)
self.mode_2_rnn_states[mode].save_states_and_detach(worker_id=worker_id, states=prev_states)

In each of the workers, the initial state of the recurrent neural network (RNN) is consistently set to None at the outset, which is straightforward to comprehend. However, when processing subsequent groups within the same worker, the RNN state continues to leverage the prev_state computed during earlier groups. I can't understand this. Aren't each five-tuple discontinuous? Why can they pass rnn state to each other at this time? In my understanding, it is reasonable that after each group runs the reset code, its rnn state should be None, but during the debugging process, I found that this does not seem to be the case.
My understanding and description may have some issues. If possible, I would appreciate it if you could provide me with some clarification and explanations.

I'm using Truncated Backpropagation Through Time (TBPTT) to manage the RNN states across different groups. Detached states from a previous group initialize the RNN states for the subsequent group, providing a form of continuity even when the groups themselves are discontinuous. This avoids resetting the RNN state to None for every new group.
Using TBPTT is crucial to get good performance when the scene is mostly static which is the case quite often on the Gen4 dataset.

Hi @magehrig
Thank you for your response. Your explanation has clarified most of my doubts, but I would like to confirm two points with you:
Regarding your statement about "providing a form of continuity even when the groups themselves are discontinuous," would this concept apply to a scenario where we have a 60-second sequence divided into multiple 5-second groups? Even though these groups may not be continuous in terms of time, they still pertain to the same general time period and share similar contexts, creating a certain degree of connection between them. Especially when dealing with static scenes,  this approach will yield noticeable benefits.
Did you choose a sequence length of 5 with computational resources in mind? If computational power were not a constraint, would setting it to 10 or 15 potentially yield better performance? This adjustment could potentially capture longer temporal information.

I am not sure what you mean with "divided into multiple 5-second groups". Is this a question regarding how dataloading is performed? Maybe it would be easier for me to answer a more concrete question where I can point you to code.
Yes, I chose a sequence length of 5 because of computational reasons. I have never tried 10 or 15 simply because that would be to slow for me.

OK, "divided into multiple 5-second groups" is just an example. In the gen4 data set, the length of each sequence is about 60s. Here you divide it into multiple groups, each group is a sequence of length 5 (this is what I meant by the sequence of 5s in the example before). These sequences of length 5 are not absolutely continuous in the time dimension, but they are all in a similar time period and a similar location. So there is actually some continuity between them. Especially in a static environment, this continuity is more obvious. In turn, it can bring greater performance improvement in a static environment. I want to know if my understanding of this is correct.

I am attempting to answer your question by explaining at a high level what happens.
During training we sample from two dataloaders (see comment). They are returned by the datamodule.

There is a streaming-sampling dataloader that goes through the whole sequence (typically up to 60 seconds) and reads out consecutive chunks of 5 samples for each iteration. Assuming we have a sequence like [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] and read out sequences of length 5; then the first iteration reads out [0, 1, 2, 3, 4] and the second one [5, 6, 7, 8, 9]. This is why we can detach the hidden state in the first iteration and initialize the rnn states with that detached hidden states for the next iteration. Just to make clear, the only "gap" in the stream is when the full sequence (the long 60 seconds one) ends and a new one starts.
There is also the random-sampling dataloader which just randomly samples a sequence of length 5 from anywhere in the dataset. As a consequence, we don't initialize the rnn states from the previous iteration if we receive data from that dataloader.

For completeness sake: These two data streams are merged here in the training step.
I suggest you write a simple script that goes visualizes what comes out of the dataloader to understand better how this works. Or look closely at the code ;)

Thanks again for the clear explanation you provided me. I think I understand the principle so far. I didn't notice before that this line of code batch = merge_mixed_batches(batch) differentiates these two different dataloaders. Now I know that these two dataloaders use different methods to update RNN state!


Node.js freezes on stdin buffer larger than 163840 bytes

Hey guys, I have been experiencing a very odd issue where node is simply freezing whenever calling cmd.stdin.end() with data larger than 163840 bytes.
Perhaps this can be related to #1774, however I decided it's best to open a new issue, since it may as well be a different thing.
The code below works fine on OSX and Linux, but surprisingly fails on WSL runnnig Ubuntu.
const spawn = require('child_process').spawn;
const cmd = spawn('wc', ['-c']);
const stdin = Buffer.alloc(163841); // works when using 163840
cmd.stdout.pipe(process.stdout);
cmd.stdin.write(stdin);
cmd.stdin.end();

I also noticed that when piping a large stdin directly with process.stdin.pipe(cmd.stdin) the problem didn't occurr at all, however, whenever manipulating stdin like the above, will cause this unexpected behaviour.
specs

Windows 10 - 1803 (build 17686.1003)
Ubuntu 16.04 LTS (build 20180510.1)
Same behaviour on Debian 9
Node.js 10.4.1

You deleted the template. strace -f -o yourthing.strace node yourthing.js. Please link a gist.

nvm. Spins on epoll_wait(). This is a right repro of #3191

Fixed on build 17704 as per https://github.com/Microsoft/WSL/issues/3191#issuecomment-400877977
Thanks, so much!


HMR not starting with HTTPS

Hi,
SSL is needed for my project so i would like enable https with Webpack. But when i do that, HMR doesn't start (empty console).
My configuration
maba_webpack:
    config:
        parameters:
            dev_server_public_path: https://my_project/compiled/
    bin:
        dev_server:
            arguments:
                - --hot
                - --inline
                - --https
                - --host
                - <IP_ADDRESS>

Any idea?

For those interested, I finally fix my problem by using this configuration :
devServer: {
        https: true,
        headers: { 'Access-Control-Allow-Origin': '*' },
        overlay: {
            warnings: false,
            errors: true
        }
    }

and by replacing
publicPath = DEV_SERVER ? 'http://localhost:8080/compiled/' : '/compiled/';

with
publicPath = DEV_SERVER ? '//localhost:8080/compiled/' : '/compiled/';

CORS headers were fixed with #62.
Additionally:

links were changed to start with // as you've suggested;
added configuration option in default webpack.config.js to pass https: true from config.yml if needed.

Thanks!


correct build and inject instructions

Daniel would have added this if he wanted to because they made this. Current one is fine people can use whatever they want to inject

you cannot use whatever injector. I tried xenos and project hacker 2 and they both didn't work

process hacker fixed after updates and never heard xenos before probably usong old method

Maybe you should include that after you say to just use any injector? It's not like it can affect the project in a bad manner

@Ferryistaken mad?

@bastquu  not really just trying to help the project. People who don't know shit about cheats won't be able to inject this

i just thought to put it there since I couldn't inject it and had to open an issue, some guy told me to use that injector and it finally worked


workers: link out to native integrations

Make it easier to find Native Integrations for databases in the nav.
Future work will refactor this and likely bring https://developers.cloudflare.com/workers/learning/integrations/databases/#native-database-integrations-beta up underneath /databases as we expand these.

Approving but we wanna link out rather than refactor now?

Actually, no this makes sense lol. Made a ticket to track this work.