Problem rendering a polygon when I modify its vertices

I've built a simple editable polygon which works fine, but when I move one of it vertices, part of polygon disappears. I've made a video of the issue. https://imgur.com/wk2KJcK
What I did was create a Fill with 4 vertices and 4 draggable Circles on each vertice of Fill, then I start to listen drag events of those Circles using CircleManager and update the corresponding vertice of Fill with the new coordinate.
        @Override
        public void onAnnotationDrag(Circle annotation) {
          ArrayList<LatLng> temp = new ArrayList<>();

          for (int i = 0; i < poligonVertices.size(); i++) {
            if (i == currentIndex) {
              temp.add(annotation.getLatLng());
            } else {
              temp.add(poligonVertices.get(i));
            }
          }
          List<List<LatLng>> latLngs = new ArrayList<>();
          latLngs.add(temp);
          polygon.setLatLngs(latLngs);
          fillManager.update(polygon);
        }

Thanks

Hey, thanks for testing out the plugin!
Could you verify, that first and last Point in your fill's coordinate list are the same? Per GeoJSON spec, the coordinates for any polygon need to be enclosed, see https://github.com/mapbox/mapbox-gl-native/issues/11469#issuecomment-374652946 and an example in our test app.


Re-register WSL distribution when user updates Stevedore

Subj. Currently, we do not automatically update WSL image at all

Stevedore is no longer providing support for Linux containers. See why. I recommend switching to Rancher Desktop, Container Desktop or Colima.


Fix broken link for examples in README.

Seriously @damianh, sort it out :p

lol
thx @ianbattersby  :)


add idtg to send file

add the possibility to send the file from id telegram

Manually squashed and merged in https://github.com/pietroalbini/botogram/commit/5a5cf5bfd65c9658cf7ab75bbd3f2171d63d4d9d :tada:


How to set this up?

Not sure how i test and run this

I'd very much like to know as well, would like to dedicate some time to help developing as well.

It's still very proof of concept stage (currently only things working is a server host GUI - and running a UDP server). I'll write how to set it up after Christmas, along with my goals with the project and how it should work :)

I've started work on the wiki here: https://github.com/DominicMaas/Tango/wiki
I briefly explain the mod and how to set it up. I'll be adding more information in the coming days.

i dont know how to intall this project someone can help me
even whith the guide on https://github.com/DominicMaas/Tango/wiki
i dont undrstand

There is now a powershell script that will automatically grab the required files, build the project and install it. You will need: Visual Studio (2017), Cities: Skylines and Powershell. Instructions can be seen on the readme file.
I should note that it does not currently work (rewriting some networking stuff, but I'm going to try fix that). I'll also start work on building the project on commit, so all the latest changes are automatically complied.

Connect and Disconnect now work, but that's about it. Feel free to follow #7 for future updates.


Add functionalTestDashboards to OpenSearch Dashboards test manifest

Signed-off-by: Tianle Huang<EMAIL_ADDRESS>Description
Add functionalTestDashboards to OpenSearch Dashboards test manifest
Issues Resolved
Resolves https://github.com/opensearch-project/opensearch-build/issues/1171
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1173 (26786b8) into main (475a23a) will decrease coverage by 24.63%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1173       +/-   ##
=============================================
- Coverage     93.75%   69.11%   -24.64%
  Complexity       10       10
=============================================
  Files           104        8       -96
  Lines          2611       68     -2543
  Branches          9        9
=============================================
- Hits           2448       47     -2401
+ Misses          153       11      -142
  Partials         10       10

Impacted Files
Coverage Δ

src/test_workflow/test_recorder/log_recorder.py

src/run_ci.py

src/git/git_repository.py

src/sign_workflow/signer.py

src/system/console.py

src/ci_workflow/ci_check_lists.py

src/test_workflow/test_component.py

src/checkout_workflow/checkout_args.py

src/test_workflow/bwc_test/bwc_test_suite.py

src/test_workflow/dependency_installer.py

... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 475a23a...26786b8. Read the comment docs.

This component is already part of the build manifest per https://github.com/opensearch-project/opensearch-build/tree/main/scripts/components/functionalTestDashboards

Should these files be versioned and going into manifests/... and be called consistently opensearch-1.3.0-test.yml? I think so as they will vary release-by-release?


[$2000] Choosing group members change the search input and it's label style

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
1.Click on the FAB and create New group
2.Start adding the group members and notice the search input and it's label
Expected Result:
Choosing group members shouldn't change the search input and it's label style for better UX.
Actual Result:
Every time we choose a member we change the search input and it's label, because of the search input refocus
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.40-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screencast from 13-07-23 05_23_15.webm
https://github.com/Expensify/App/assets/43996225/358c55d1-b9d8-445f-8241-26c76b07f216
Expensify/Expensify Issue URL:
Issue reported by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689216766939829
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f1e32514bd8c7aa9
Upwork Job ID:<PHONE_NUMBER>913671680
Last Price Increase: 2023-08-07

Proposal
Please re-state the problem that we are trying to solve in this issue.
Toggling group members changes the search input and its label style
What is the root cause of that problem?
When user selects the members, search input lose the focus, and the focus is set here again
https://github.com/Expensify/App/blob/28acc0267738c3c9305c412cd56d5f93ab8066b3/src/components/OptionsSelector/BaseOptionsSelector.js#L267
The search input changes if it loses the focus. Refocusing is the root cause
What changes do you think we should make in order to solve the problem?
We can prevent the lost of focus by preventing default action of mouse events
Add the following code above this line
            onMouseDown={(e) => e.preventDefault()}
            onMouseUp={(e) => e.preventDefault()}

This works as expected.

Result

What alternative solutions did you explore? (Optional)

Also happens in split bill
Screencast from 15-07-23 05:02:59.webm

Reproduced easily. And it has the same effect on desktop, so I'm gonna check that box in the Platforms: section of the GH.

Lol why does it say I added the Overdue label back... Melvin you lie.

What is the root cause of that problem?

Your RCA is correct but only onMouseDown will suffice.

@Talha345
Maybe. But it might cause other issues as in https://github.com/Expensify/App/issues/21727

@0xmiroslav can you please review the proposal provided?

If none are applicable, I will double the price of this job.

still looking for ideal solution

We're using this way in BaseTextInput and ReportActionCompose and other several places. I think this is a good choice

@0xmiroslav any update on the latest proposals?

Note: I'm preparing to go OOO for ~2 weeks, and need a BZ buddy to oversee this while I'm gone.
The next step is for us to field proposals until a winning one is chosen by the C+ @0xmiroslav. If no winning proposals by 08/07, you can double price again from $2k -> $4k to get more activity here.
Thanks in advance @tjferriss

@michaelhaxhiu the C+ member has been MIA and  hasn't provided any feedback on the previous proposals!

@Talha345 your proposal changes the behavior. I don't think we should lose focus on search while choosing group members if already focused.

Well, it is the default behavior and as I mentioned in my proposal that we cannot predict the user's next action so IMHO it doesn't make sense to refocus it after every member selection.

@0xmiroslav
My solution doesn't refocus(what @Talha345 is concerned), rather prevent losing focus. What's the drawback of my solution?

If we want to prevent loss of focus in the first place, @s-alves10 's first solution makes the most sense to me.We should keep it simple in this case and not create an entire state just for this purpose and bloat the code unnecessarily.

@0xmiroslav can you take a look at the above comments and offer some guidance? Thanks!

I'd like to take this as C+ based on discussion

@situchan
Please let me know your though on my proposal

Proposal
Please re-state the problem that we are trying to solve in this issue.
Avoiding label style and search input on selecting group numbers on the BaseOptionsSelector component.
What is the root cause of that problem?
https://github.com/Expensify/App/blob/a03a21d25832760cf9db4235b0fbc88cc08bd490/src/components/OptionsSelector/BaseOptionsSelector.js#L333C1-L338C19
The onBlur event returns here if this.props.shouldFocusOnSelectRow is false. This is incorrect because if any selectRow is focused then onBlur event should not switch the currentTarget.
This will make sure that it will not break on any component using BaseOptionsSelector
What changes do you think we should make in order to solve the problem?
If this can be toggled, i.e., returning when this is true and only changing focus when this is false, will solve the problem.
What alternative solutions did you explore? (Optional)
NA
Results:
https://github.com/Expensify/App/assets/98523623/03c329f7-765a-444c-b107-0d24c1d149fc

@trjExpensify can you please assign me here?
And I suggest to put this on hold for #22856 as the select behavior might change.

I think that's for @tjferriss :)

I think that's for @tjferriss :)

Ah sorry meant to tag @tjferriss :)

@situchan you're assigned.

The holding issue will be closed as won't fix.
We can now resume this issue.

@situchan Can you please review the proposals above and let us know your thoughts?

@situchan friendly reminder on the proposals.
@michaelhaxhiu do you want to take this back over now that you're back from OOO?

@tjferriss let's remove Hold from title

@s-alves10's proposal looks good to me.
I don't see any other better solution to prevent blur on focused search input.
🎀 👀 🎀 C+ reviewed

Reviewing now

Proposal looks good, but I feel it is not necessary or required to keep focus on search text input, while options are being selected.
looks like we have that in Workspace > Invite members. We don't keep focus on input while selecting workspace invitees. We can do similar here, I think cc @tjferriss

@MonilBhavsar Invite page (uses SelectionList) is different than search/new chat/new group pages (uses OptionsList).
There was full discussion search and option focus behavior here - https://expensify.slack.com/archives/C01GTK53T8Q/p1692122623311399?thread_ts=1689954073.865489&cid=C01GTK53T8Q.
And also updated test rail - https://github.com/Expensify/Expensify/issues/311312

Proposal looks good, but I feel it is not necessary or required to keep focus on search text input, while options are being selected.

@MonilBhavsar Yes that is what I suggested too because it feels kinda hacky to me to persist the focus even though the user has moved to another element and we do not know if the user will come back again to the search field or not.I have explained this in detail in my proposal https://github.com/Expensify/App/issues/22812#issuecomment-1658437718.
@situchan If it is decided to move forward with what @MonilBhavsar and I suggested, you can have a look at my proposal using which we can achieve this with minimal changes.

Taking this back over. @MonilBhavsar do you agree with @situchan's comment (above) about how the SelectionList =/= OptionsList, and thus the behavior may not need to be equivalent. The next step lies with you to unblock us :)

Commented in the thread. Looks like all agree with keeping dual focus. I think then we should do it similar for all elements across the App https://expensify.slack.com/archives/C01GTK53T8Q/p1692122623311399?thread_ts=1689954073.865489&cid=C01GTK53T8Q

Commented in the thread. Looks like all agree with keeping dual focus. I think then we should do it similar for all elements across the App https://expensify.slack.com/archives/C01GTK53T8Q/p1692122623311399?thread_ts=1689954073.865489&cid=C01GTK53T8Q

@MonilBhavsar Apart from this,everywhere we have the standard behavior.I think we should re-think this and instead of changing the behavior at all other places, we should make the behavior in this issue consistent with the entire app and not vice versa.Just my 2 cents.

@Talha345 There are only 2 components which have both search input and selectable list: OptionsList, SelectionList.
They represent the entire app.

Agree, @Talha345 feel free to share your thoughts in the slack thread

@Talha345 There are only 2 components which have both search input and selectable list: OptionsList, SelectionList.
They represent the entire app.

@situchan Yes you are right! I was simply talking in terms of behavior without going into the technical terminology to make it consistent across the app.Having focus on multiple elements at once doesn't make sense to me logically but we can proceed with whatever the team decides.

I think keeping focus in search input is a good choice from the view of UX

Right, but looks like we want to do something new from industry standard, and allow users to keep typing while also navigate through the list options.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Choosing group members change the search input and it's label style
What is the root cause of that problem?
The root cause of the issue is that when the user clicks on the list item, the focus moves out of the TextInput which is the default behaviour. We focus back on the TextInput in the line below. The time-lag between blur and focus causes the flicker.
https://github.com/Expensify/App/blob/57b76067cd3d7b59e84c4a387d11ad33e6a97d05/src/components/OptionsSelector/BaseOptionsSelector.js#L302
What changes do you think we should make in order to solve the problem?

TextInput component already has forceActiveLabel prop that allows us to keep the label active. We can use that to prevent the label flickering.
We can define a new state variable keepActive in BaseOptionsSelector.js and pass it to TextInput component.
Set keepActive to true when TextInput is focused
keepActive is set to false when users click outside the TextInput or the Checklist
In BaseTextInput.js apply styles.borderColorFocus if keepActive is true

Idea is to use the existing options in the application to achieve the result with minimal change.
The following code changes can be made to achieve this.
BaseOptionsSelector.js
     /**
     * @param {Boolean} status
     */
    updateKeepActive(status) {
        this.setState({keepActive: status});
    }
    ...
    <TextInput
        keepActive={this.state.keepActive}
        forceActiveLabel={this.state.keepActive}
        onFocus={() => this.updateKeepActive(true)}
        ...
    />
    ...
    <View
        style={[styles.flexGrow1, styles.flexShrink1, styles.flexBasisAuto]}
        onClick={() =>this.updateKeepActive(false)}
    >

BaseTextInput.js
    const textInputContainerStyles = StyleSheet.flatten([
        ...
        (props.keepActive || (!props.hideFocusedState && isFocused)) && styles.borderColorFocus,
        ...
    ]);

Result :
https://github.com/Expensify/App/assets/2232432/62ea888e-582e-419d-8e36-17cc37d93092
What alternative solutions did you explore? (Optional)
None

@kameshwarnayak thanks for your proposal. Label seems to be in fixed position but input cursor still flickers.
I don't think your solution is better and straightforward than preventDefault approach.

Still waiting for a correct proposal to generalize things as we discussed in slack.

Still waiting for a correct proposal to generalize things as we discussed in slack.

@MonilBhavsar can you please share the expected behavior finally landed on?

Still waiting for a correct proposal to generalize things as we discussed in slack.

What is the expected behavior? If something was changed, please share here

It is in the thread that was linked here https://github.com/Expensify/App/issues/22812#issuecomment-1702566251
We should fix it in more wider way and not just for this group members list. Also, we should explore having a generic component except two different components - OptionsList and SelectionsList
Please see this comment from tgolen in the thread. I agree with this

I'd love for both pages to have consistent UX and I think we should take the time right now to make them such. Is the proposal to make a generic component that can be used on both pages?

And we had couple of thumbs up on this -

Looks like, we agree with doing something different and focussing on both inputs at the same time, then I agree with the point Tim brought above to use similar component or style and have consistency across all elements in the App. If we agree having focus on two elements, then I think we should do it now for all usages inside the App.

Waiting for proposal here

Proposal
Please re-state the problem that we are trying to solve in this issue.
Choosing group members change the search input and it's label style
What is the root cause of that problem?
Note
The UI is diffrent now than when the error was reported.
Now we have same menu for startign a chat or a group.
Also now in Main the search bar is not being refocus.

How its working
https://github.com/Expensify/App/assets/16781411/2be83dc2-8430-4345-a86b-268ad84e913f

When user select members click on add to group or unselect the selected member focus is lost on search bar.
What changes do you think we should make in order to solve the problem?
In this lines setUp  onMouseDown={(e)=>{e.preventDefault()}} to prevent onfocus on the search bar.
https://github.com/Expensify/App/blob/9533031c7795567392cca0b295212b342c9acdfe/src/components/OptionRow.js#L279-L284
and in
https://github.com/Expensify/App/blob/9533031c7795567392cca0b295212b342c9acdfe/src/components/OptionRow.js#L286-L291

Solution Working
https://github.com/Expensify/App/assets/16781411/6243b205-eb37-4377-81f8-4848aa2e7670

Refactor to use OptionsList instead of SelectionsList
Right now the Selections List is being used in the following components

https://github.com/Expensify/App/blob/main/src/components/NewDatePicker/CalendarPicker/YearPickerModal.js
https://github.com/Expensify/App/blob/main/src/components/CountryPicker/CountrySelectorModal.js
https://github.com/Expensify/App/blob/main/src/components/StatePicker/StateSelectorModal.js
https://github.com/Expensify/App/blob/main/src/pages/settings/Preferences/LanguagePage.js
https://github.com/Expensify/App/blob/main/src/pages/settings/Preferences/PriorityModePage.js
https://github.com/Expensify/App/blob/main/src/pages/settings/Preferences/ThemePage.js
https://github.com/Expensify/App/blob/main/src/pages/settings/Profile/PronounsPages.js
https://github.com/Expensify/App/blob/main/src/pages/settings/Profile/TimezoneSelectPages.js
https://github.com/Expensify/App/blob/main/src/pages/workspace/WorkspaceInvitePage.js
https://github.com/Expensify/App/blob/main/src/pages/workspace/WorkspaceMemebersPage.js

We need to change the SelectionsList for the OptionsList in this components. It will require de development of the select All in the Options List. and to test thorughly the features.
@MonilBhavsar currently the UX of both components are diffrent are we goign with the UX of OptionsList correct?
What alternative solutions did you explore? (Optional)

We recently changed the workflow around creating groups and this issue is not visible any more.
The options list in Creating group and splitting money and selection in workspace member settings loses focus when we try to select the options.
If we want to pursue the idea of keeping the focus on search while selecting the option, that could be a feature request I think. @michaelhaxhiu should we consider working on this issue as a feature request, or close it and open new issue, as this bug is not reproducible anymore.

The pages have been refactored but we can still apply solution to these badges:
https://github.com/Expensify/App/assets/108292595/950757e9-52f0-4b08-85cf-26c932a74263

And that's what native app already does:
https://github.com/Expensify/App/assets/108292595/f3a6c2d1-6b33-4f8f-9ec1-a5932daa722c
So good to fix for consistency

Proposal
Updated

@situchan  Sorry, I didn't get
The issue reported originally is not reproducible, is it?
https://github.com/Expensify/App/assets/32012005/5cf27831-44c2-4ef5-a316-7d39e83c5cad

The issue reported originally is not reproducible, is it?

Correct because UX changed and selecting row navigates to another page always.
But code still remaining
https://github.com/Expensify/App/blob/41ddd7428340fd8d347e8160980809e76a93899b/src/pages/NewChatPage.js#L201

@MonilBhavsar it is reproducible, as i show on the videos of my [Proposal] (https://github.com/Expensify/App/issues/22812#issuecomment-1727743878)

I'm confused myself. Does the bug still exist and need fixing? Or are we saying the bug is fixed from UX perspective and we just need to clean up the code now?
cc @MonilBhavsar

This is not reproducible because of recent regression.
Context: https://expensify.slack.com/archives/C01GTK53T8Q/p1695863206217249?thread_ts=1689954073.865489&cid=C01GTK53T8Q
Seems like we're going to fix as bug

I'm re-assigning this to another BZ as part of my preparation for Sabbatical (starting Friday).
Next steps:

Sherpa this forward with @situchan and @MonilBhavsar
After that regression is fixed, this bug will return to exist and so we may need to wait a few days till that it shows itself again.

Looks like the regression is because of https://github.com/Expensify/App/pull/25564/files

@MonilBhavsar am I reading this correctly that the regression has not been corrected? If it hasn't, are we solving it in this issue or do we need to locate/open a separate issue for the regression before fixing this bug?

There's no GH created and no one is working on it to fix that "regression". I think we can fix here.

@sonialiap @situchan This bug can now be reproduced again. I believe the regression responsible for its disappearance has been fixed.
Screencast from 04-10-23 08:43:39.webm

@Ahmed-Abdella Ah, good catch!
I just confirmed that PR which fixes https://github.com/Expensify/App/issues/28070 was merged 2 days ago, which made this bug reproducible again.

@s-alves10 can you update your proposal based on latest codebase?

Proposal
Updated

@s-alves10's updated proposal looks good.
cc: @MonilBhavsar
🎀 👀 🎀 C+ reviewed

@s-alves10 @situchan this does not persist focus on Invite members page that uses selectionList, right?

@s-alves10 @situchan this does not persist focus on Invite members page that uses selectionList, right?

right. We can apply same logic if needed, but that page always not persisted focus from the beginning.

Oh I just noticed that refocus logic implemented in https://github.com/Expensify/App/pull/27497 and merged recently.
So now this bug happens on selection list as well.
@s-alves10 you may need to update your proposal again to cover these pages which use selection list.

So good timing of this issue to start

Okay. I'll update soon

So good timing of this issue to start

Right 👍

Okay. I'll update soon

Thank you! Looking forward to it. Would be great to avoid code deduplication i.e. not pass similar props and handle the logic in two different components in a similar way.

@situchan @MonilBhavsar
Proposal
Updated

Would be great to avoid code deduplication i.e. not pass similar props and handle the logic in two different components in a similar way.

@s-alves10 does your proposal take this feedback into account?

Both SelectionList and OptionsSelector have shouldFocusOnSelectRow props. I used them.
I don't think deduplication is needed

Currently, there's no refocus logic on Invite new members page.
https://github.com/Expensify/App/pull/27497 handled Members page only.
I think we can fix it here.
@MonilBhavsar I am fine with updated proposal.

Thank you @s-alves10 and @situchan for carrying this forward!
Looks good to me 👍

Why the offers were not sent automatically
Because it was Internal, may be 🤔

Why the offers were not sent automatically Because it was Internal, may be 🤔

@MonilBhavsar Now it's External & Help Wanted so unassign and reassign @s-alves10

@situchan
PR is ready for review https://github.com/Expensify/App/pull/29084

Sorry @MonilBhavsar , @sonialiap but this issue was reported before changing the rate, it should be at 250$.

@situchan review + bonus = $3000 - paid ✔
@s-alves10 fix + bonus = $3000 - offer sent
@Ahmed-Abdella report = $250 - new offer sent with the correct amount

@sonialiap I accepted the offer, Thanks.

I'm OOO Oct 16-23. Adding leave buddy
Status: waiting to issue payment https://github.com/Expensify/App/issues/22812#issuecomment-1765319825

Bumping to weekly!

Flicking this one back to daily so that it's in the right spot in my k2 dashboard

Due 10/23

Payment is due today. @situchan could you please take a look at the checklist

False comment, Melvin

@situchan review + bonus = $3000 - paid ✔ https://github.com/Expensify/App/issues/22812#issuecomment-1763272663
@s-alves10 fix + bonus = $3000 - paid ✔
@Ahmed-Abdella report = $250 - paid ✔

@situchan last step is to do the checklist. I scrolled through the issue and I don't think it's been filled out yet but let me know if I missed it

@situchan could you please take a look at the checklist. Thanks!

There were several changes on this behavior but the original root cause existed from the beginning as it's web's default behavior to blur element when another one is clicked. So no regression.
This is minor UI issue so I don't think it's worth adding to regression test which should run on every deploy.
And the refactor will not likely to happen again so the fix won't be reverted.

I would say we should add regression test, as we usually update callback functions with lists and could probably cause regression

Regression Test Proposal
Case 1:

Go to FAB > Start chat
Focus on search input if not focused
Select multiple users by tapping "Add to group" button
Deselect users again by tapping ✅ button
Verify that the style of search input and label doesn't change

Case 2:

Go to FAB > Request money
Input any amount in manual tab and tap Next
Focus on search input if not focused
Select multiple users by tapping "Split" button
Deselect users again by tapping ✅ button
Verify that the style of search input and label doesn't change

And also Workspace settings > Members page please

Updated.

New regression test addition submitted


Enable automated license detection

Hi @pascaldekloe 👋 WDYT about inserting the standard CC0 text here, so that automated scanners such as GitLab's underlying tools, or google/licenseclassifier can correctly identify your CC0 decision?

Seems reasonable. You probably want to remove the current text then, instead of adding those lines to the end.

Line 124+ is no longer needed then, right?

Thank you Katrin. I will do the same for other projects now.


ExtendsContentIntoTitleBar and wrong window top border color

Describe the bug
In WinUI 3 project, the top border of window is drawn black when ExtendsContentIntoTitleBar is true.
Steps to reproduce the bug

Create 'Blank App, Packaged (with WinUI 3 in Desktop)'
Set ExtendsContentIntoTitleBar to true in the MainWindow constructor

Expected behavior
No response
Screenshots

NuGet package version
WinUI 3 - Windows App SDK 1.0
Windows app type

[ ] UWP
[x] Win32

Device form factor
Desktop
Windows version
Windows 10 (21H2): Build 19044
Additional context
No response

Any progress on this issue?

bump

This bug is still present in the 1.1 version.

Any developer's comment? Nope?

A workaround:
using System;
using System.Runtime.InteropServices;
using WinRT.Interop;

public sealed partial class MainWindow : Window {

  [StructLayout(LayoutKind.Sequential)]
  struct MARGINS {
    public int cxLeftWidth;
    public int cxRightWidth;
    public int cyTopHeight;
    public int cyBottomHeight;
  }

  [DllImport("dwmapi")]
  static extern long DwmExtendFrameIntoClientArea(IntPtr hWnd, ref MARGINS pMarInset);

  public MainWindow() {
    var handle = WindowNative.GetWindowHandle(this);
    var margins = new MARGINS { cxLeftWidth = 0, cxRightWidth = 0, cyBottomHeight = 0, cyTopHeight = 2 };
    Activated +=
      (object sender, WindowActivatedEventArgs args) => DwmExtendFrameIntoClientArea(handle, ref margins);
    ExtendsContentIntoTitleBar = true;
  }

  // ...

}

Additional bug related to this wrong border.
If you want to disable resizing for your app and add the code:
if (appWindow.Presenter is OverlappedPresenter p)
       p.IsResizable = false;

then the side and bottom borders will not support resizing and won't show the resizer cursor, but the top border will still show the resize cursor (but resizing will not actually work):

@pavel-zhukov  your fix deals with both issues - it fixes the color and also gets rid of the wrong resize cursor.
I hope the team will do something about it; these hacks are ugly.

This is still an Issue, not sure if its WinUI 3 related, or WinAppSDK
https://github.com/microsoft/WindowsAppSDK/issues/3752

I would close this issue because the other issue mentioned here is more accurate : in high contrast setting, parts of top border is missing. I would follow that issue to track it. Closing it as dup.

So where exactly is this going to be fixed?

It is in the pipeline of the team and should be done in a future release. The developers will update the high contrast bug if it is fixed internally and with the tag of build it will be coming in .

A workaround:
using System;
using System.Runtime.InteropServices;
using WinRT.Interop;

public sealed partial class MainWindow : Window {

  [StructLayout(LayoutKind.Sequential)]
  struct MARGINS {
    public int cxLeftWidth;
    public int cxRightWidth;
    public int cyTopHeight;
    public int cyBottomHeight;
  }

  [DllImport("dwmapi")]
  static extern IntPtr DwmExtendFrameIntoClientArea(IntPtr hWnd, ref MARGINS pMarInset);

  public MainWindow() {
    var handle = WindowNative.GetWindowHandle(this);
    var margins = new MARGINS { cxLeftWidth = 0, cxRightWidth = 0, cyBottomHeight = 0, cyTopHeight = 2 };
    Activated +=
      (object sender, WindowActivatedEventArgs args) => DwmExtendFrameIntoClientArea(handle, ref margins);
    ExtendsContentIntoTitleBar = true;
  }

  // ...

}

This workaround no longer works for at least WASDK 1.4/1.5. I have not tried older versions.

The workaround still works for me. Win10, WASDK 1.5.

A workaround:
using System;
using System.Runtime.InteropServices;
using WinRT.Interop;

public sealed partial class MainWindow : Window {

  [StructLayout(LayoutKind.Sequential)]
  struct MARGINS {
    public int cxLeftWidth;
    public int cxRightWidth;
    public int cyTopHeight;
    public int cyBottomHeight;
  }

  [DllImport("dwmapi")]
  static extern IntPtr DwmExtendFrameIntoClientArea(IntPtr hWnd, ref MARGINS pMarInset);

  public MainWindow() {
    var handle = WindowNative.GetWindowHandle(this);
    var margins = new MARGINS { cxLeftWidth = 0, cxRightWidth = 0, cyBottomHeight = 0, cyTopHeight = 2 };
    Activated +=
      (object sender, WindowActivatedEventArgs args) => DwmExtendFrameIntoClientArea(handle, ref margins);
    ExtendsContentIntoTitleBar = true;
  }

  // ...

}

This workaround still works as of WASDK 1.6, but with a small caveat: the following does not work
// Some Microsoft.UI.XamlWindow

// Assume that all the PInvoke and MARGINS struct stuff is defined above

var titleBar = AppWindow.TitleBar;
titleBar.ExtendsContentIntoTitleBar = true; // <-- Doesn't work with the DwmExtendFrameIntoClientArea workaround!
Activated +=
    (object sender, WindowActivatedEventArgs args) => DwmExtendFrameIntoClientArea(handle, ref margins);

Whereas this following DOES work:
// Some Microsoft.UI.XamlWindow

// Assume that all the PInvoke and MARGINS struct stuff is defined above

this.ExtendsContentIntoTitleBar = true; // Using the property directly on `Window` *does* work!
Activated +=
    (object sender, WindowActivatedEventArgs args) => DwmExtendFrameIntoClientArea(handle, ref margins);

Not sure what the underlying difference is, but using AppWidnow.TitleBar.ExtendsContentIntoTitleBar seems to not play nicely with DwmExtendFrameIntoClientArea().

thanks!
2024년 12월 4일 (수) 오전 8:29, Neil McAlister @.***>님이 작성:

A workaround:
using System;
using System.Runtime.InteropServices;
using WinRT.Interop;
public sealed partial class MainWindow : Window {
[StructLayout(LayoutKind.Sequential)]
struct MARGINS {
public int cxLeftWidth;
public int cxRightWidth;
public int cyTopHeight;
public int cyBottomHeight;
}
[DllImport("dwmapi")]
static extern IntPtr DwmExtendFrameIntoClientArea(IntPtr hWnd, ref MARGINS pMarInset);
public MainWindow() {
var handle = WindowNative.GetWindowHandle(this);
var margins = new MARGINS { cxLeftWidth = 0, cxRightWidth = 0, cyBottomHeight = 0, cyTopHeight = 2 };
Activated +=
(object sender, WindowActivatedEventArgs args) => DwmExtendFrameIntoClientArea(handle, ref margins);
ExtendsContentIntoTitleBar = true;
}
// ...
}
This workaround still works as of WASDK 1.6, but with a small caveat: the
following does not work
// Some Microsoft.UI.Xaml Window
// Assume that all the PInvoke and MARGINS struct stuff is defined above
var titleBar = AppWindow.TitleBar;
titleBar.ExtendsContentIntoTitleBar = true; // <-- Doesn't work with the DwmExtendFrameIntoClientArea workaround!Activated +=
(object sender, WindowActivatedEventArgs args) => DwmExtendFrameIntoClientArea(handle, ref margins);
Whereas this following DOES work:
// Some Microsoft.UI.Xaml Window
// Assume that all the PInvoke and MARGINS struct stuff is defined above
this.ExtendsContentIntoTitleBar = true; // Using the property directly on Window does work!Activated +=
(object sender, WindowActivatedEventArgs args) => DwmExtendFrameIntoClientArea(handle, ref margins);
Not sure what the underlying difference is, but using
AppWidnow.TitleBar.ExtendsContentIntoTitleBar seems to not play nicely
with DwmExtendFrameIntoClientArea().
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/microsoft-ui-xaml/issues/6901#issuecomment-2515799535,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGHMCWXEVTLSIX3IUBBA5W32DY5FXAVCNFSM6AAAAABS63YX56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJVG44TSNJTGU
.
You are receiving this because you commented.Message ID:
@.***>


Blog's Footer links point to invalid URLs (404 error)

🐛 Bug Report
On a freshly created website, all local links at the footer of the Blog page are broken. The supposedly same links section works just fine at the main page.
Have you read the Contributing Guidelines on issues?
Yes, I did.
To Reproduce
Presuming linux, node, blc and docusaurus (v1.14.4) are installed correctly...

docusaurus-init
npm run start
blc --exclude-external http://localhost:3000/blog
blc --exclude-external http://localhost:3000

Expected behavior
All links should work, as in the following images:

Actual Behavior
Blog's Footer links are invalid, as seen on the following image:

Main Page's Footer links are OK and should remain OK:

Here's how a sample of how the links are generated at the Blog.

And here's a sample of how the links are generated at the Main Page.

I believe all links should be the same, or at least provide the same result.
Reproducible Demo
Nothing was customized. It's the result of a plain call docusaurus-init.
There's a "working" sample running at Surge.

A workaround for this bug is to create a languages.js file on the website root folder that exports an empty array, something like this:
module.exports = [];

It's ugly, but it works.


spellchecker tries to use an incorrect dictionary and does not work.

Description
There are several similar issues but I could not find the solution in any of them. Most of them were installation problems, but my extensions seem to be properly installed.
When starting jupyterlab with the spellchecker extension, this message is printed:
[I 2021-10-08 10:20:40.938 ServerApp] Looking for hunspell dictionaries for spellchecker in ['/home/ramon/.local/share/jupyter/dictionaries', '/home/ramon/anaconda3/share/jupyter/dictionaries', '/usr/local/share/jupyter/dictionaries', '/usr/share/jupyter/dictionaries', '/usr/share/hunspell', '/usr/share/myspell', '/usr/share/myspell/dicts']
[W 2021-10-08 10:20:41.018 ServerApp] jupyterlab_spellchecker | extension failed loading with message: [Errno 2] No such file or directory: '/home/ramon/anaconda3/lib/python3.7/site-packages/babel/locale-data/ca_ES_valencia.dat'

I live in Catalonia and I may have set ca_ES somewhere, but my locale is in English, and this is the language I want to use in jupyterlab:
(base) ramon@xoriguer:~$ locale
LANG=en_US.UTF-8
LANGUAGE=
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC=en_GB.UTF-8
LC_TIME=en_GB.UTF-8
LC_COLLATE="en_US.UTF-8"
LC_MONETARY=en_GB.UTF-8
LC_MESSAGES="en_US.UTF-8"
LC_PAPER=en_GB.UTF-8
LC_NAME=en_GB.UTF-8
LC_ADDRESS=en_GB.UTF-8
LC_TELEPHONE=en_GB.UTF-8
LC_MEASUREMENT=en_GB.UTF-8
LC_IDENTIFICATION=en_GB.UTF-8
LC_ALL=

The jupyter lab shows English as the only available language (but it is shaded):

However the spell-checker does not work as it does not highlight incorrect words.
I've checked the advanced settings and English is selected there. I do not see where ca_ES_valencia  comes from:

Reproduce
I am using conda

Start jupyterlab with: (base) ramon@xoriguer:~$ jupyter lab

Expected behavior
The English dictionary should be used by loading the file en_US.dat which is located here:
/home/ramon/anaconda3/lib/python3.7/site-packages/babel/locale-data/en_US.dat
This file came with the spell-checker installation. I did not install it manually.
Context

Python package version:

(base) ramon@xoriguer:~$ conda list jupyterlab-spellchecker
# packages in environment at /home/ramon/anaconda3:
#
# Name                    Version                   Build  Channel
jupyterlab-spellchecker   0.7.1              pyhd8ed1ab_0    conda-forge

Extension version:

(base) ramon@xoriguer:~$ jupyter labextension list
JupyterLab v3.1.10
/home/ramon/anaconda3/share/jupyter/labextensions
        @jupyter-widgets/jupyterlab-manager v3.0.1 enabled OK (python, jupyterlab_widgets)
        @ijmbarr/jupyterlab_spellchecker v0.7.1 enabled OK (python, jupyterlab-spellchecker)
(base) ramon@xoriguer:~$ jupyter server extension list
Config dir: /home/ramon/.jupyter

Config dir: /home/ramon/anaconda3/etc/jupyter
    jupyterlab enabled
    - Validating jupyterlab...
      jupyterlab 3.1.10 OK
    jupyterlab_spellchecker enabled
    - Validating jupyterlab_spellchecker...
      jupyterlab_spellchecker 0.7.1 OK
    nbclassic enabled
    - Validating nbclassic...
      nbclassic  OK

Config dir: /usr/local/etc/jupyter

Operating System and its version:  Ubuntu 20.04.1 LTS

Browser and its version: Firefox 81.0

Command Line Output

Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.

[D 2021-10-08 10:52:01.878 ServerApp] Searching ['/home/ramon', '/home/ramon/.jupyter', '/home/ramon/anaconda3/etc/jupyter', '/usr/local/etc/jupyter', '/etc/jupyter'] for config files
[D 2021-10-08 10:52:01.878 ServerApp] Looking for jupyter_config in /etc/jupyter
[D 2021-10-08 10:52:01.879 ServerApp] Looking for jupyter_config in /usr/local/etc/jupyter
[D 2021-10-08 10:52:01.879 ServerApp] Looking for jupyter_config in /home/ramon/anaconda3/etc/jupyter
[D 2021-10-08 10:52:01.879 ServerApp] Looking for jupyter_config in /home/ramon/.jupyter
[D 2021-10-08 10:52:01.879 ServerApp] Looking for jupyter_config in /home/ramon
[D 2021-10-08 10:52:01.880 ServerApp] Looking for jupyter_server_config in /etc/jupyter
[D 2021-10-08 10:52:01.880 ServerApp] Looking for jupyter_server_config in /usr/local/etc/jupyter
[D 2021-10-08 10:52:01.880 ServerApp] Looking for jupyter_server_config in /home/ramon/anaconda3/etc/jupyter
[D 2021-10-08 10:52:01.880 ServerApp] Looking for jupyter_server_config in /home/ramon/.jupyter
[D 2021-10-08 10:52:01.881 ServerApp] Loaded config file: /home/ramon/.jupyter/jupyter_server_config.py
[D 2021-10-08 10:52:01.881 ServerApp] Loaded config file: /home/ramon/.jupyter/jupyter_server_config.json
[D 2021-10-08 10:52:01.881 ServerApp] Looking for jupyter_server_config in /home/ramon
[D 2021-10-08 10:52:01.884 ServerApp] Paths used for configuration of jupyter_server_config:
    	/etc/jupyter/jupyter_server_config.json
[D 2021-10-08 10:52:01.884 ServerApp] Paths used for configuration of jupyter_server_config:
    	/usr/local/etc/jupyter/jupyter_server_config.json
[D 2021-10-08 10:52:01.885 ServerApp] Paths used for configuration of jupyter_server_config:
    	/home/ramon/anaconda3/etc/jupyter/jupyter_server_config.d/jupyterlab.json
    	/home/ramon/anaconda3/etc/jupyter/jupyter_server_config.d/jupyterlab_spellchecker.json
    	/home/ramon/anaconda3/etc/jupyter/jupyter_server_config.d/nbclassic.json
    	/home/ramon/anaconda3/etc/jupyter/jupyter_server_config.json
[D 2021-10-08 10:52:01.885 ServerApp] Paths used for configuration of jupyter_server_config:
    	/home/ramon/.jupyter/jupyter_server_config.json
[D 2021-10-08 10:52:01.902 LabApp] Config changed: {'NotebookApp': {}, 'ServerApp': {'log_level': 'DEBUG', 'ip': '*', 'password': 'sha1:eb37537254f0:e0b3a2c97c859ad619fe9cf771059a2dbbc2706e', 'jpserver_extensions': <LazyConfigValue {'update': {'jupyterlab_spellchecker': True, 'nbclassic': True}}>}, 'ExtensionApp': {'log_level': 'DEBUG'}}
[I 2021-10-08 10:52:01.903 ServerApp] jupyterlab | extension was successfully linked.
[I 2021-10-08 10:52:01.903 ServerApp] jupyterlab_spellchecker | extension was successfully linked.
[D 2021-10-08 10:52:01.914 NotebookApp] Config changed: {'NotebookApp': {'open_browser': False}, 'ServerApp': {'log_level': 'DEBUG', 'ip': '*', 'password': 'sha1:eb37537254f0:e0b3a2c97c859ad619fe9cf771059a2dbbc2706e', 'jpserver_extensions': <LazyConfigValue value={'jupyterlab': True, 'jupyterlab_spellchecker': True, 'nbclassic': True}>}, 'ExtensionApp': {'log_level': 'DEBUG'}}
[D 2021-10-08 10:52:02.130 ServerApp] Paths used for configuration of jupyter_notebook_config:
    	/home/ramon/.jupyter/jupyter_notebook_config.json
[D 2021-10-08 10:52:02.131 ServerApp] Paths used for configuration of jupyter_notebook_config:
    	/etc/jupyter/jupyter_notebook_config.json
[D 2021-10-08 10:52:02.132 ServerApp] Paths used for configuration of jupyter_notebook_config:
    	/usr/local/etc/jupyter/jupyter_notebook_config.json
[D 2021-10-08 10:52:02.133 ServerApp] Paths used for configuration of jupyter_notebook_config:
    	/home/ramon/anaconda3/etc/jupyter/jupyter_notebook_config.d/jupyterlab.json
    	/home/ramon/anaconda3/etc/jupyter/jupyter_notebook_config.d/jupyterlab_spellchecker.json
    	/home/ramon/anaconda3/etc/jupyter/jupyter_notebook_config.json
[D 2021-10-08 10:52:02.134 ServerApp] Paths used for configuration of jupyter_notebook_config:
    	/home/ramon/.jupyter/jupyter_notebook_config.json
[I 2021-10-08 10:52:02.134 ServerApp] nbclassic | extension was successfully linked.
[D 2021-10-08 10:52:02.136 ServerApp] Config changed: {'ExtensionApp': {'log_level': 'DEBUG'}, 'NotebookApp': {'open_browser': False}, 'ServerApp': {'log_level': 'DEBUG', 'ip': '*', 'password': 'sha1:eb37537254f0:e0b3a2c97c859ad619fe9cf771059a2dbbc2706e', 'jpserver_extensions': <LazyConfigValue value={'jupyterlab': True, 'jupyterlab_spellchecker': True, 'nbclassic': True}>}}
[D 2021-10-08 10:52:02.136 ServerApp] Raising open file limit: soft 1024->4096; hard 1048576->1048576
[W 2021-10-08 10:52:02.151 ServerApp] WARNING: The Jupyter server is listening on all IP addresses and not using encryption. This is not recommended.
[I 2021-10-08 10:52:02.156 ServerApp] nbclassic | extension was successfully loaded.
[I 2021-10-08 10:52:02.157 LabApp] JupyterLab extension loaded from /home/ramon/anaconda3/lib/python3.7/site-packages/jupyterlab
[I 2021-10-08 10:52:02.157 LabApp] JupyterLab application directory is /home/ramon/anaconda3/share/jupyter/lab
[I 2021-10-08 10:52:02.160 ServerApp] jupyterlab | extension was successfully loaded.
[I 2021-10-08 10:52:02.161 ServerApp] Looking for hunspell dictionaries for spellchecker in ['/home/ramon/.local/share/jupyter/dictionaries', '/home/ramon/anaconda3/share/jupyter/dictionaries', '/usr/local/share/jupyter/dictionaries', '/usr/share/jupyter/dictionaries', '/usr/share/hunspell', '/usr/share/myspell', '/usr/share/myspell/dicts']
[D 2021-10-08 10:52:02.237 ServerApp] Traceback (most recent call last):
      File "/home/ramon/anaconda3/lib/python3.7/site-packages/jupyter_server/extension/manager.py", line 356, in load_extension
        extension.load_all_points(self.serverapp)
      File "/home/ramon/anaconda3/lib/python3.7/site-packages/jupyter_server/extension/manager.py", line 236, in load_all_points
        return [self.load_point(point_name, serverapp) for point_name in self.extension_points]
      File "/home/ramon/anaconda3/lib/python3.7/site-packages/jupyter_server/extension/manager.py", line 236, in <listcomp>
        return [self.load_point(point_name, serverapp) for point_name in self.extension_points]
      File "/home/ramon/anaconda3/lib/python3.7/site-packages/jupyter_server/extension/manager.py", line 229, in load_point
        return point.load(serverapp)
      File "/home/ramon/anaconda3/lib/python3.7/site-packages/jupyter_server/extension/manager.py", line 155, in load
        return loader(serverapp)
      File "/home/ramon/anaconda3/lib/python3.7/site-packages/jupyterlab_spellchecker/__init__.py", line 34, in _load_jupyter_server_extension
        setup_handlers(server_app.web_app, url_path, server_app)
      File "/home/ramon/anaconda3/lib/python3.7/site-packages/jupyterlab_spellchecker/handlers.py", line 27, in setup_handlers
        dictionaries = discover_dictionaries(server_app)
      File "/home/ramon/anaconda3/lib/python3.7/site-packages/jupyterlab_spellchecker/dictionaries.py", line 124, in discover_dictionaries
        dictionaries.extend(_scan_for_dictionaries(path, server_app.log))
      File "/home/ramon/anaconda3/lib/python3.7/site-packages/jupyterlab_spellchecker/dictionaries.py", line 89, in _scan_for_dictionaries
        display_name = locale_data.get_display_name()
      File "/home/ramon/anaconda3/lib/python3.7/site-packages/babel/core.py", line 381, in get_display_name
        retval = locale.languages.get(self.language)
      File "/home/ramon/anaconda3/lib/python3.7/site-packages/babel/core.py", line 482, in languages
        return self._data['languages']
      File "/home/ramon/anaconda3/lib/python3.7/site-packages/babel/core.py", line 364, in _data
        self.__data = localedata.LocaleDataDict(localedata.load(str(self)))
      File "/home/ramon/anaconda3/lib/python3.7/site-packages/babel/localedata.py", line 143, in load
        with open(filename, 'rb') as fileobj:
    FileNotFoundError: [Errno 2] No such file or directory: '/home/ramon/anaconda3/lib/python3.7/site-packages/babel/locale-data/ca_ES_valencia.dat'

[W 2021-10-08 10:52:02.237 ServerApp] jupyterlab_spellchecker | extension failed loading with message: [Errno 2] No such file or directory: '/home/ramon/anaconda3/lib/python3.7/site-packages/babel/locale-data/ca_ES_valencia.dat'

I'll first answer your previous message.
The files ca_ES_valencia.* are indeed located in /usr/share/hunspell/. They are put there by the hunspell-ca package of the Ubuntu distribution.
Concerning the new version, it works flawlessly! Thanks a lot!


Additional checks for when Play Billing is enabled

Check that enableNotifications is true
Check that alphaDependencies are enabled

Code looks good. However, it sounds to me that this check belongs in update, not build. The first takes twa-manifest.json and generates the Android project, which is where these configurations matter, and the latter will just build the project.

 Thanks for pointing it out. It'd be too late to point out in build that the setup isn't consistent because update would've already propagated those changes into the Android project. I've moved the checks to update instead. Thanks!


support for GIFs in avif format

Please Describe The Problem To Be Solved
# -*- coding: utf-8 -*-

import flet as ft

def main(page: ft.Page):
    page.add(ft.Image(src='https://pic2-cdn.creality.com/comp/model/av/de101a6531342d02ac8b212c51bdf4c3.avif'))

ft.app(target=main)

(Optional): Suggest A Solution
https://pic2-cdn.creality.com/comp/model/av/de101a6531342d02ac8b212c51bdf4c3.avif is an animation file and you can see the effect in the web browser. However, flet 0.22.1 does not currently support animation avif file, and only displays a static image.

https://pub.dev/packages/flutter_avif


history and update review writeup chroot systemd

https://wiki.archlinux.org/title/systemd-nspawn
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux_atomic_host/7/html/managing_containers/running_containers_as_systemd_services_with_podman_
https://github.com/smaknsk/servicectl
https://github.com/Supervisor/supervisor

no work has started on this it may not happen


fix: handle unknown operations

Not the cleanest solution, but as you already plan to drop usage of this library (https://github.com/Mic92/cntr/issues/78), I think this is fine.
Fixes: https://github.com/Mic92/cntr/issues/263

Thanks!

Published a new cntr release as well.


Update docs of Accordion

Description
The description of Accordion in documentation has explained the type of prop data as just array, and used wrong example of prop data. The type of prop data actually is:
Array<{
  title: string;
  bodies: string[];
}>

The previous description could not explain enough about prop data, in my opinion. So I updated documentation of prop data, and data example in usage.
Test Plan
N/A
Related Issues
N/A
Tests
N/A
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] Run yarn test:all and make sure nothing fails. You can run yarn test -u to update snapshots if needed.
[x] I am willing to follow-up on review comments in a timely manner.

Thanks PR. I agree with your opinion.
while enhancing this component, I was organized data type definition.
I think you can refer to #108.

@luke-hanwook
Thank you for your reply! I agree and will apply your suggestion now.

I would like to additional work together on this PR!
I planned for [Accordion] docs.

consistent usage
update props
basic accordion
controlled animation (sholudAnamate, animDuration)
styled accordion (style, styles)
customization (renderTitle, renderBody, toggleElement)
add snack
how about it?

I'd love to! What could I do more for helping this additional work?

I'd love to! What could I do more for helping this additional work?

I think you combine your update commit into one and write commit msg in detail. 😃
and about collaboration I think you can refer to tutorial for git rabase

I think it would be good to refer to the documentation of other components or git log
And I think you can update all props refer to [Accordion] type definition for good first issue. 👍🏻

Thank you for your kind comments, but I am afraid I do not properly understand. Could you explain more detail if you don't mind?

Thank you for your kind comments, but I am afraid I do not properly understand. Could you explain more detail if you don't mind?

Yes! i am ready to explain more detail to you. Could you tell me what do not you understand?
if you want to communicate in korean, let's look for other channel.

Yes! i am ready to explain more detail to you. Could you tell me what do not you understand?
if you want to communicate in korean, let's look for other channel.

I really appreciate that! Points that I do not understand are:

I think you combine your update commit into one and write commit msg in detail. 😃

Does this mean I have to squash my 2 commits('Update docs of Accordion', 'Update docs of data of Accordion') into one commit, or is there other meaning?

and about collaboration I think you can refer to tutorial for git rabase

May I ask you what does your comment about rebase mean? I could not find reason why I have to use rebase in this case.

Even I asked questions here, I'd love to communicate also in Korean for proper understanding if you don't mind. Please let me know if there are way(channel) to contact that you feel comfortable.

This is a just my opinion! 😄
it's mean to squash two commit and rewrite commit message. to do that you need to git rebase.
I think we would better write a neat logs for reference or code review because i will add my work for collaboration.

fully understood 👍 I think I was little confused because I have not used rebase after push, to protect comments on PR. thank you! All my questions seem to be solved before contacting in Korean fortunately 🥠 but still need conversations about collaboration, so I will contact by mail in a moment and back to here when we are ready to collaborate.

@aube-dev
Sorry for confusing. if you have any suggestion or feedback, please feel free to leave any comments. it's not rule and i am a contributor too like you. 😄 for more information, refer to the e-mail. thanks~

We decided to collaborate in new PR!
@hyochan Sorry to mention but our conversation is now over, so please feel free to review this PR. thank you!


Tribute.js integration not working

Background: Tribute was used to implement @mention feature within CodeMirror (https://github.com/zurb/tribute)

I'm getting the data remotely to fetch the list of suggestions for @mention.
What worked: I've implemented a KeyMap handler to take care of down/up/enter keys to be ignored when the @mention's suggestion list is open, so that I can use the arrow keys & enter to select the right person/content, instead of cursor moving around within the editor.
What's not working: The problem is with left/right arrow keys & backspace. Because element that gets passed when the key is pressed is not textarea, but an editor, it stops calling the servers and the suggestion list no longer updates.

Has anyone successfully implemented Tribute.js to implement @mention feature within CodeMirror?

Because the TextArea gets reset when backspace/left arrow/right arrow is pressed, Tribute.js is using an empty string to look things up, causing no changes to the suggestion/result list.
Need a way to prevent TextArea reset for those keys during Tribute.js menu is open. So far, not sure how to do that without changing CodeMirror code. :'-(

This is out of scope for this bug tracker. 3rd party tools directly interacting with the editor's hidden textarea aren't something we support, so I'm not going to debug this.


Make release_linux.sh configurable for python version

Fix #1179

https://stackoverflow.com/questions/44967202/pip-is-showing-error-lsb-release-a-returned-non-zero-exit-status-1/44967506 May solve the issue


Incorrect logo for Ubuntu

Description
On Ubuntu systems the 3 colour 'circle of friends' is used. This is the (very) old, and now incorrect logo. The new single colour logo was introduced in March 2010.
I tested this with neofetch 2.0.1

Neofetch 2.0.1 already includes the new logo.
https://github.com/dylanaraps/neofetch/blob/master/ascii/distro/ubuntu

Yay! I wonder why I'm not seeing it in 2.0.1 here?

You might be using the 2.0 ascii art with 2.0.1. Neofetch first checks /usr/share/neofetch for the ascii art before falling back to the script directory.


pspamm is still not installing the wheel requirement on the latest version

Just tested by Claudia

Adding install issue, maybe related to the one above... pip3 is expecting setup.py file.
Install instruction comes from: https://seissol.readthedocs.io/en/latest/installing-dependencies.html#installing-pspamm
which differs from the one on PSpaMM github.


Adjust Size of labels in UMAP,  Feature plots

When labels are enabled on umaps and feature plots, they sometimes are too close together to be readable (extreme example below). This could be controlled to some extent by changing the size of the labels.

If labels can be modified with themeing, this is an easy fix. If not, the underlying plotting function will have to be modified. A categorical slider interface like the legend size selectors could be useful here.


Sending unexpected http get request when clicking back button on  react component

Framework7 version: 5.7.11
React.js version: "^18.2.0"
Platform and Target: Web
Reproducible repo:   https://github.com/JaosnHsieh/framework7-router-issue-reproduce ( for debug purpose, I copied while node_modules/framework7 to /src for vite to bundle it with source map on production.

Describe the bug
Back button in framework7 <Navbar backLink={'Back'} .../> React component unexpected sending XHR request to HTTP GET /fruits-select which adding by smartselect.
To Reproduce
To reproduce this router related issue:

Click "map" icon and go to Page "A" by clicking A smart select popver
Click back from A
Click "gear_alt" icon to Page B and click again to Page C, click back in C and Click back in B
See console, router unexpected request url "/fruits-select/

Expected behavior
When clicking Back button on Nav, go back to previous page.
Actual Behavior
No page changing, sending HTTP Request to /frutis-select route only.
Screenshots

Is there a way to not push the route to the router history when using smart select popover?


expansion-list with more than two levels

Hi,
can you give me an example of an expansion-list with more than two levels?
I tried the following code and it does not work:

			<md-list>
			    <md-list-item>
				    <md-icon>whatshot</md-icon>
				    News

			       <md-list-expand>
				        <md-list>
				            <md-list-item` href="#" class="md-inset">World</md-list-item>
				            <md-list-item href="#" class="md-inset">World</md-list-item>
				            <md-list-item class="md-inset" >News
						         <md-list-expand>
						        	<md-list>

						          		<md-list-item href="#" class="md-active">teste </md-list-item>
						          		<md-list-item href="#" class="md-active">testes</md-list-item>
							        </md-list>
						      	</md-list-expand>
				            </md-list-item>
				        </md-list>
			        </md-list-expand>
			    </md-list-item>
			</md-list>

Please disregard, it works, it was just my own css that was interfering; thanks


stop talking about payroll

Payroll is specifically used for employees. You should avoid that term for contractors.

https://github.com/gratipay/gratipay.com/issues/3994#issuecomment-216836470
Punchlist

[ ] modify about pages
[ ] modify terms
[ ] modify team sign-up flow
[ ] modify SQL (this could/should happen in #4012)

Yes, demand and distribution is all that matters when you can't get enough for food and shelter. It is not about payroll anymore when most jobs in the world can already be automated.

Closing in favor of #4037, and a new PR for user-facing mentions (including the terms of service, I'm afraid).


November prototype

What is the context of this PR?
Further docs on the design system overrides
How to review
Run the docs locally and check there are no typos.

closing - wrong branches


More core compilation fixes for 3.0.0-M3

I thought I did all these already, but I can't find them now.

Merging by executive order as it's blocking others, and I think these are old commits.  If you see a problem, you know where the pull request button is!


 This should be opaquely handled.

There should also be versions of functions with _must prefix, which crash program on error occurence. Of course, they should print verbose error message whenever possible.

There should also be versions of functions with _must prefix, which crash program on error occurence. Of course, they should print verbose error message whenever possible.

There should also be versions of functions with _must prefix, which crash program on error occurence. Of course, they should print verbose error message whenever possible.

Actually, no, with NULL-tolerant error library dumb error handling is already exteremely easy, no need for boilerplate functions.

There should also be versions of functions with _must prefix, which crash program on error occurence. Of course, they should print verbose error message whenever possible.

Actually, no, with NULL-tolerant error library dumb error handling is already exteremely easy, no need for boilerplate functions.


Stop emit dag load duration metrics

Ran into a case that we dynamically create hundreds of DAGs from a single file and that caused buffer overflow on statsd. Also, I have confirmed that this metric was already removed from upstream.

👍


Autofocus input on search field of modal popup

My assumption is that when you open a modal to search, you are wanting to type without clicking into the search field.
When I click a modal popup currently, I must again click into the input field to search.
This PR is meant to save clicks when opening a Modal to search.

basically, auto focus into the search box when the modal include search.
for example:
go to swap
click the token to select a new one
expected: mouse focus should be in the search box to allow immediate typing of the token you wish to find.

basically, auto focus into the search box when the modal include search.
yes!


Provide mechanism for overriding styles

Some users wish to override the styles used by Puck. Some examples

Removing position: fixed from the editor (is this even required)
Changing the background color
Changing other colors
Changing the hover / selected colours in DropZones (i.e. for sufficient contrast)

Implementation TBD

Closing in favour of #139


Add Allan Blakeney Adult Campus

Allan Blakeney Adult Campus
https://adultcampus.rbe.sk.ca/

Please kindly provide the full name of your school on the first line of the file in your request

Hello
I hope this email finds you well
The full name of the school is Allan blakeney Adult campus and it's in the
first line of the rbe.txt
On Mon, Sep 16, 2024, 2:43 PM Philip Torchinsky @.***>
wrote:

Please kindly provide the full name of your school on the first line of
the file in your request
—
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/23629#issuecomment-2353993495,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BHZGBXY6QWSNEA35AV5SPXDZW47HBAVCNFSM6AAAAABOJQUAU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJTHE4TGNBZGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

@Sonra0 Pull request merged. Please start requesting the licenses in about an hour, to let the changes to propagate through our system. Thank you.


Remove extra character

Also, match the bold style of the other options.

@andresnava : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


SAK-40749: Kernel > realms refresh queue uses a HashMap

https://jira.sakaiproject.org/browse/SAK-40749
The queue that is used for scheduling realm refresh tasks is a HashMap that has it's values iterated over. The order of a HashMap is not intended to be defined, and as of Java 8 is no longer predictable. This causes jobs in the queue to be executed in "random" order. This should to be changed to a LinkedHashMap.

Yep, though there was never meant to have an order as during normal conditions all realms are refreshed. It's only when things slow down that this would come into play. The largest advantage here is using that of a Map as you won't queue duplicate sites.

@ern, you forgot to use rebase+merge on this one :(


zed: replace npm2nix with node2nix

Motivation for this change
Further effort on #31032
Unfortunately zedapp is not available in the NPM registry, so the old derivation had to be kept.
I kept the versions used by zedapp (which aren't the latest ones), see deps.json and https://github.com/zedapp/zed/blob/master/app/package.json for further reference
I cleaned up the meta section a bit and added myself as maintainer to make sure there are more people to ping if this breaks before one of the next releases.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

(/cc @svanderburg)

Very cool @Ma27 that you fixed this!
Could you make a few subtle changes? I can't find the node2nix command line instruction that you used to generate the package set. Could you also include a shell script that describes how to regenerate the expressions? This would be useful to allow others to repeat the packaging process.
Another thing I noticed is that you include yet another copy of node-env.nix in the package directory. This is strictly not needed since such a copy already exists in the Nixpkgs repository. It would be more space efficient if we reuse it.
You can reuse the existing node-env.nix file from the NPM package set, by adding the following parameters to node2nix:
node2nix -e ../../../development/node-packages/node-env.nix --no-copy-node-env

The first parameter specifies the relative path to the existing node-env.nix from the NPM package set, the second parameter specifies that we should not copy this file from the node2nix toolset.

1.: I added the used command in a coment above the 'import ./node.nix' expression, however a shell script might be way better...
2.: ah, didn't know about this option, so :+1: for deduplication!

On 8. Nov 2017, at 11:25 AM, Sander van der Burg<EMAIL_ADDRESS>wrote:
Very cool @Ma27 that you fixed this!
Could you make a few subtle changes? I can't find the node2nix command line instruction that you used to generate the package set. Could you also include a shell script that describes how to regenerate the expressions? This would be useful to allow others to repeat the packaging process.
Another thing I noticed is that you include yet another copy of node-env.nix in the package directory. This is strictly not needed since such a copy already exists in the Nixpkgs repository. It would be more space efficient if we reuse it.
You can reuse the existing node-env.nix file from the NPM package set, by adding the following parameters to node2nix:
node2nix -e ../../../development/node-packages/node-env.nix --no-copy-node-env
The first parameter specifies the relative path to the existing node-env.nix from the NPM package set, the second parameter specifies that we should not copy this file from the node2nix toolset.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Consider checking out this fetcher and see if it works for you:
https://github.com/NixOS/nixpkgs/blob/1925b4c1a06c6c03431ab45f10ef369125d57f6f/pkgs/applications/networking/instant-messengers/rambox/fetchNodeModules.nix

@Ma27 I just noticed that a validation step in the Travis CI build is failing.
The fix is quite simple. Can you change the following line in default.nix:
nodePackages = import ./node.nix {};

into:
nodePackages = import ./node.nix { inherit pkgs; system = stdenv.system; };

Then it should work fine. The validation error is caused by the fact that there is a <nixpkgs> reference that should not be called in strict mode.

@svanderburg just out of interest: what do you think of the fetcher @yegortimoshenko built?
The latest NPM versions are deterministic, they secure their sources with SHA hashes and (IIRC) the NPM registry is immutable (no re-push/delete for published tags) since the left-pad incident, so it should be possible  to use NPM without fearing side-effects as soon as NodeJS 4 and 6 are EOLed, right?
However I'm a bit hesitant to use this approach for zed as I think it's better to bring this to a consistent state (by dropping npm2nix) for now and discuss such things in a seperate issue (as @yegortimoshenko built this, you might want to open one?)

@Ma27 @yegortimoshenko I haven't studied this solution in detail yet. I think it's a practical/workable solution for some categories of NPM packages (most notably end-user packages without any complex dependencies), but I don't think it is a robust solution for every project -- I can already think of some projects where more is needed than just a drop-in replacement for thenode_modules/ folder.
However, since packaging support for NPM 5.x is still missing in node2nix (I'm still working on this, but this requires a very different kind of solution), this fetcher (so far) is the only solution we have for integrating the newest NPM with Nix to some extent.
So the fetcher is not a useless solution, but I also believe we need a more robust facility with features on par with what node2nix currently provides.
I will come back to this (hopefully) soon.

While older Node.js versions don't come with a usable npm, all that it takes to use this fetcher with older NodeJS versions is a npm package (npm install npm@latest). Also, since it doesn't run scripts, I believe that node_modules fetched with nodejs-8_x package should be usable with any Node.js version.
This shouldn't be much of a problem, as 8.x is now the stable branch: https://nodejs.org/en/download/

@Ma27 I have integrated your changes. Thanks!
I think my former research colleague @zefhemel would like it!

While older Node.js versions don't come with a usable npm, all it would take to support this is a npm package (npm install npm@latest).

Right, this is why I said "as soon as NodeJS 4 and 6 are EOLed".
I didn't intend to replace node2nix immediately, I've just realized while reading through this code (and the linked issues) that NPM made a huge progress regarding deterministic builds (that actually work in comparison to all these weird npm-shrinkwrap issues I had in NPM 3.x :-D).

I can already think of some projects where more is needed than just a drop-in replacement for thenode_modules/ folder.

you mean node packages where you need extra dependencies that need to be adjusted using the override-capabilities or are there any further issues?
The reason why I asked about this is because it seems to be an interesting approach, however I we should discuss any further details about this in a special ticket :-)


feat: add function to calculate serviceClusterIPRange

The goal of this MR is to add support to calculate the serviceClusterIPRange as it was before Kops 1.28, more context can be found here: https://github.com/kubernetes/kops/pull/15866

LGTM


Index mangement says "No embeddings found. Go to the 'Add Document' tab to insert your docs."

I have checked all the resources they are up and running . But it shows Index mangement "No embeddings found. Go to the 'Add Document' tab to insert your docs." . Even i can see uploaded files in Document Viewer Section.

I got the same error too. The chatbot is only able to pull information from sources that are uploaded in the same session. If I stop the containers and docker compose up again, the chatbot can't find the uploaded sources anymore.


Documentation submission for the Magnite-Streaming: Batch Destination

Submission for the Magnite Streaming: Batch destination.
Note that the doc will call link to a document for a Real-time destination that is part of another PR, so that specific link will be broken until the other PR is merged.
Will include PR in comments once it is made.

@vfalon Ready for re-review. Thanks!

adding @vgiurgiu as well

@vgiurgiu The batch destination is updated.


ESP32: matter build issue for ESP32 C6 DevKitC 1 (CON-661)

Hi,
I am getting the following error message during the idf.py build
/home/manamohana/ESP/esp-matter/examples/light/build/config/sdkconfig.h:452:37: error: invalid conversion from 'int' to 'uart_port_t' [-fpermissive]
452 | #define CONFIG_ESP_CONSOLE_UART_NUM 0
|                                     ^
|                                     |
|                                     int
../../../../../connectedhomeip/connectedhomeip/config/esp32/third_party/connectedhomeip/src/lib/shell/streamer_esp32.cpp:61:35: note: in expansion of macro 'CONFIG_ESP_CONSOLE_UART_NUM'
build_error.txt
61 |     if (!uart_is_driver_installed(CONFIG_ESP_CONSOLE_UART_NUM))
Please find the attached file for complete console log.

I see an error setting up target. You will have to clean the stale files manually and give it another try. Please do rm -rf build sdkconfig and then do idf.py set-target esp32c6 and idf.py build.
manamohana@manamohana-HP-Laptop-15s-fq2xxx:~/ESP/esp-matter/examples/light$ idf.py set-target esp32c6
Adding "set-target"'s dependency "fullclean" to list of commands with default set of options.
Executing action: fullclean
Directory '/home/manamohana/ESP/esp-matter/examples/light/build' doesn't seem to be a CMake build directory. Refusing to automatically delete files in this directory. Delete     the directory manually to 'clean' it.

Due to this error the build target is now ESP32 and not C6.
Also, looks like you are using esp-idf master branch, and we have not tested esp-matter on master branch. I would suggest you to please use the latest stable v5.1 release. i.e. v5.1 tag.

@manamohan1 In addition to @shubhamdp 's comment - In the attached log, your install.sh command has failed for pkg-config. Please refer this section in the documentation and install the pre-requisites for ESP-IDF and Matter: https://docs.espressif.com/projects/esp-matter/en/latest/esp32/developing.html#host-setup

@manamohan1 you need to typecast it on the connectedhomeip repository

I did "git checkout ea5e0ff" and this issue resolved for me.
git clone --recursive https://github.com/espressif/esp-idf.git
cd esp-idf; git checkout ea5e0ff; git submodule update --init --recursive;
./install.sh


Find with "fields" list?

Is it possible to send a fields object to find to get back a subset of attributes?
The mongo command-line client takes a second argument like this:
db.records.find({}, {_id: 0, column1: 1, column2: 1})
Is this possible in deno_mongo?

At present,project operation can only useaggregate

try using this
db.records.aggregate([{$match:{}}, {$project:{_id: 0, column1: 1, column2: 1}}]);
where $match  will be your query and $project will be your fields.

Thanks! That worked. Still learning mongo.


support typechecker generated identifiers that contain $

The typechecker may create identifiers with $ while de-sugaring, but since $ is not a valid for Ceylon identifiers, ceylon.ast.redhat/ceylon.ast.core will throw.
See https://github.com/ceylon/ceylon/commit/a65b81e363da72989a854abd8b9dbb2171fe0de4#commitcomment-18904016.

Okay, how about this: LIdentifier will accept identifiers that begin with $pattern$param$ (see https://github.com/ceylon/ceylon/commit/27d27b7d8de067eaa34bbe8b4e9b1eaa0d2a7026) only if the immediate caller (via exception stack trace) is the appropriate ceylon.ast.redhat function, called via the parameter convert function. In all other situations, such names continue to be rejected – if the typechecker uses them in more situations, update LIdentifier as needed, but only then.

via exception stack trace

way too slow. How about $s are allowed if the identifier starts with some_rare_unicode_char that will be added by ceylon.ast.redhat and stripped by ceylon.ast.core.

Perhaps. Something from one of the private use areas, then. But I’d still restrict this to the very specific pattern $pattern$param$*.

I’d still restrict this to the very specific

It's the same to me either way, but I think the potential for abuse is near zero, but there may be more $ scenarios in the future.

See https://github.com/ceylon/ceylon/commit/899a41e77adaa87554127c8469563816f95fd441 for updated prefix w/counter.

Actually I reverted that commit. :)

Alright, so on Gitter we decided to add a second constructor to LIdentifier (and also UIdentifier, I guess), probably called internal, which also allows $ in identifiers. Identifier would also gain a Boolean flag to distinguish between internal and non-internal identifiers.
(Should it require at least one $ in the identifier? In an attempt to ensure that internal and non-internal identifiers can’t collide?)

(Should it require at least one $ in the identifier? In an attempt to ensure that internal and non-internal identifiers can’t collide?)

I would say no, since it seems like a restriction without a clear benefit or standard use. But also, while it seems to make sense to reify the constructor, I can't really think of a use for it.

Actually, maybe it should indicate whether the identifier is valid, independent of the constructor used. That seems more useful to me, to help you determine if an AST is valid.

@lucaswerkmeister the latest patch works great. Thanks!

I actually remembered that it’s incomplete… the flag is missing, and RedHatTransformer should probably not generate tokens for internal identifiers, right?

Should the flag just be a computed property that returns true if the identifier is valid?
Regarding tokens, I'm not convinced their presence or absence is or should be an indicator of anything. But since I haven't done any codegen or desugaring with ceylon.ast yet, I guess I don't have strong argument to make.

Well, the absence of the token is how identifierToCeylon detects that it should use the internal constructor. So if the conversion should be lossless both ways, then the flag needs to record which constructor was used, and RedHatTransformer needs to set text without assigning a token.

Why not always use internal? I'm just not convinced that exists token is exactly the same as "is synthetic".

I’d still like to keep these two things completely separate:

Regular identifiers, from user code (therefore with a token in the RedHat AST), without any dollar signs.
Internal identifiers, from the compiler (therefore without a token – which is a reasonable assumption IMO, because it’s cumbersome to create a valid token, calling the constructor isn’t enough, so I don’t see why the compiler would go through that trouble), and must contain at least one dollar sign.

It just seems like a nice division to me, dunno…

I don’t see why the compiler would go through that trouble

I don't know if this makes sense yet, but to preserve some original program text in early de-sugaring stages of backend compilation with the goal of providing better error messages, IDE support, sourcemaps, etc.

keep these two things completely separate

But for that to be achieved, you are placing a burden on clients to always use the right constructor, even when imperfect information is available (i.e. typechecker de-sugaring if a token might at some point be present), or due to some abstraction such as the use of a utility function to create nodes in backend code.

must contain at least one dollar sign

I really don't like forcing you to have a dollar sign if you use internal(). Maybe I want to generate code that uses an identifier that may be from the original source file. I'd probably need to hack in an if (id.contains($)) then useInternalCtor some places.
To be clear, I don't think this (at least the first two items) would impact anything I'm currently doing, but I see the potential for not wanting this structure much greater than the potential for it being valuable to me in writing a backend.

Okay, I can see that you might want to create tokens for source maps and such.
I still don’t see how you would be in a situation where you don’t know which constructor to use. If you don’t know that, how do you make sure that your new identifier doesn’t collide with a user-specified name? The $ is your protection against that!
If internal doesn’t enforce the $ constraint, and the flag doesn’t indicate which constructor was used, then I don’t know if there’s even a point to using a separate constructor. Why not change the existing constructor to accept a $ as well (and document that), and add the valid flag to check if the constructor is valid Ceylon code or not? I could live with that, and it seems much simpler to me.

I still don’t see how you would be in a situation where you don’t know which constructor to use

Because I use utility functions for stuff, similar to your ceylon.ast.create, that could possibly instantiate identifiers from a String. But yes, if an identifier is created from scratch, it has to be done carefully.

if there’s even a point to using a separate constructor

I thought it was to keep the "regular user" api strict. But yeah, I don't really know how important that is.

Well, who is the regular user? It sounds like both ceylon.ast.redhat and your Dart backend will exclusively use internal… :)

I mean someone using ceylon.ast for code generation for their enterprise application or something. But yes, I'd just want to use internal.

I guess that still makes sense, okay. So two constructors, a valid flag, *identifierToCeylon always uses internal, create always uses the regular constructor.

Hm, I guess internal will have to get the prefixed parameter as well.

New version pushed.

@jvasileff any comments before the release tomorrow?

I'll give the patch a try.

Well, I’ll try my best… :) though I suppose the formatter is more important, and the release takes a bit with the reproducible build.

@lucaswerkmeister the patch works for me, and looks great aside from the missing !. Thanks!

Alright, then with the latest version we’re done!


Install php56-intl and php56-xdebug

Hello. After updating the BREW I started to get errors:
`Failed loading /usr/local/opt/php56-xdebug/xdebug.so:  dlopen(/usr/local/opt/php56-xdebug/xdebug.so, 9): image not found
PHP Warning:  PHP Startup: Unable to load dynamic library '/usr/local/Cellar/php56-intl/5.6.33_14/intl.so' - dlopen(/usr/local/Cellar/php56-intl/5.6.33_14/intl.so, 9): image not found in Unknown on line 0
Warning: PHP Startup: Unable to load dynamic library '/usr/local/Cellar/php56-intl/5.6.33_14/intl.so' - dlopen(/usr/local/Cellar/php56-intl/5.6.33_14/intl.so, 9): image not found in Unknown on line 0
PHP Warning:  PHP Startup: Unable to load dynamic library '/usr/local/opt/php56-intl/intl.so' - dlopen(/usr/local/opt/php56-intl/intl.so, 9): image not found in Unknown on line 0
Warning: PHP Startup: Unable to load dynamic library '/usr/local/opt/php56-intl/intl.so' - dlopen(/usr/local/opt/php56-intl/intl.so, 9): image not found in Unknown on line 0
PHP 5.6.36 (cli) (built: Apr 26 2018 22:02:57)
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2016, by Zend Technologies`
But I can not install these modules using the command.
brew install php56-intl
brew install --build-from-source php56-intl
Please tell me how I can solve this problem. To my still use versions above 5.6 I can not because Symfony 2.7 can not work with them.

From the issue template:

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you do not read fill out the issue template repeatedly you will be blocked from ever submitting issues to Homebrew again.


Export PageContextProvider

Resolves #71

Putting this on hold until we resolve the discussion in the issue #71

Closing, but let me know if you still need something.


API Exceptions

My api runs with below exceptions, could tell if there are critical or ?

2017-02-14 16:09:41,113 ERROR c.c.d.rest.RestApiExceptionHandler - invalid hexadecimal representation of an ObjectId: [{timestamp:1487059701768,status:500,error:Internal Server Error,exception:java.lang.StackOverflowError,message:No message available,path:/api/build}]
java.lang.IllegalArgumentException: invalid hexadecimal representation of an ObjectId: [{timestamp:1487059701768,status:500,error:Internal Server Error,exception:java.lang.StackOverflowError,message:No message available,path:/api/build}]
at org.bson.types.ObjectId.parseHexString(ObjectId.java:519) ~[mongo-java-driver-3.0.2.jar!/:na]
at org.bson.types.ObjectId.(ObjectId.java:233) ~[mongo-java-driver-3.0.2.jar!/:na]
at com.capitalone.dashboard.service.BinaryArtifactServiceImpl.create(BinaryArtifactServiceImpl.java:99) ~[api.jar!/:2.0.5-SNAPSHOT]
at com.capitalone.dashboard.rest.BinaryArtifactController.create(BinaryArtifactController.java:40) ~[api.jar!/:2.0.5-SNAPSHOT]

2017-02-14 16:08:21,757 ERROR o.a.c.c.C.[.[.[.[dispatcherServlet] - Servlet.service() for servlet [dispatcherServlet] in context with path [/api] threw exception [Handler processing failed; nested exception is java.lang.StackOverflowError] with root cause
java.lang.StackOverflowError: null
at java.nio.charset.CharsetDecoder.(Unknown Source) ~[na:1.8.0_91]
at java.nio.charset.CharsetDecoder.(Unknown Source) ~[na:1.8.0_91]
at sun.nio.cs.UTF_8$Decoder.(Unknown Source) ~[na:1.8.0_91]
at sun.nio.cs.UTF_8$Decoder.(Unknown Source) ~[na:1.8.0_91]
at sun.nio.cs.UTF_8.newDecoder(Unknown Source) ~[na:1.8.0_91]
at java.lang.StringCoding.decode(Unknown Source) ~[na:1.8.0_91]
at java.lang.String.(Unknown Source) ~[na:1.8.0_91]
at java.lang.String.(Unknown Source) ~[na:1.8.0_91]
at org.bson.io.ByteBufferBsonInput.readCString(ByteBufferBsonInput.java:124) ~[mongo-java-driver-3.0.2.jar!/:na]

I have to upload the log for your further investigation
api-log.log.txt

Do you have something POSTing builds to Hygieia? The build POST endpoint accepts a json that has a field called "buildId". If present it needs to correspond to a mongo object id (12 byte hex string).

Yes, I am running an Artifact Collector, I'll try disable it and come back to you if still has issue.

@MarkRx I am now running without artifact collector and still there are exceptions. What I could point out is that the GitLab collector is failing to get data in UI without Exceptions.

@MarkRx @satishc1  Hi still I have the exception on the latest code where cause gitlab collector not showing the data. Could you help ?
As below screenshot, not data shows on the widget of gitlab

@xpdable Ping me on https://gitter.im/capitalone/Hygieia and we can setup a time to troubleshoot the issue you are having.


Hide Episode Spoilers

Is your feature request related to a problem? Please describe.
A lot of episode title card images often have spoilers for what happens in the episode (i.e. competition shows final episode image can show who is in the final and who isn't).
Describe the solution you'd like
To be able to take the background image of the show/season and apply it to each of the episodes within the show/season. This could be either library-wide or for specific shows.
Describe alternatives you've considered
Tautulli already provides a similar functionality but it relies on media being recently added - you cannot call out specific shows for it to apply to.
https://github.com/blacktwin/JBOPS/blob/master/utility/hide_episode_spoilers.py
Additional context
Add any other context or screenshots about the feature request here.

I just wanted to follow this up with an expansion to the idea ahead of the overlay and asset rework.
Similar to Dynamic Collections, a neat idea would be Dynamic Posters/Title Cards.
This touches slightly on @chazlarson's poster-thing idea: https://github.com/chazlarson/poster-thing
The general idea is that for the identified shows, you take the episode banner image from TMDB, apply the episode text to it and then attach it to the episode within Plex. There could be another variant of this to avoid spoilers which does the same thing, but uses the season's banner image rather than specific episode banners to avoid spoilers.
The logo could also be applied to the image, similar to this:

Credit: https://www.reddit.com/r/PlexTitleCards/comments/tfnziq/station_eleven_title_cards/
Lots of example layouts available here:
https://www.reddit.com/r/PlexTitleCards/


Show progress on the taskbar

Is your feature request related to a problem? Please describe.
Not really. In File Explorer, it will show the progress of current primary operation in the taskbar. It'd be great to have such a feature in Files UWP so that I don't need to switch to Files UWP to see the progress of an operation.
Describe the solution you'd like
UWP doesn't support this feature yet however I've opened a proposal in the Project Reunions repository. See https://github.com/microsoft/ProjectReunion/issues/68.
Describe alternatives you've considered
None.

Files UWP should be able to have a progress bar or status box that shows the progress of transferring files/ folders from one directory to the another directory opened in Files UWP

It has been already implemented in the latest version.

It has been already implemented in the latest version.

Yes, I am running the latest version. Isn't version <IP_ADDRESS> the latest?

0.11.0 is the latest version on the Store. Note that progress is only shown when you copy/move/delete a large file or large files.

@Jaiganeshkumaran @saint4eva This hasn't been implemented and is still not available to users.

I don't think we should have progress on the taskbar as it is distracting for users. There's a reason why it wasn't implemented in WinRT APIs to begin with.

@Jaiganeshkumaran @saint4eva This hasn't been implemented and is still not available to users.

Thank you for the information.

I don't think we should have progress on the taskbar as it is distracting for users. There's a reason why it wasn't implemented in WinRT APIs to begin with.

What about progress on the dialog box?

I like the progress bar on the taskbar. It's the flashing that annoys users.

I don't think we should have progress on the taskbar as it is distracting for users. There's a reason why it wasn't implemented in WinRT APIs to begin with.

That's not the real reason. Windows 8 didn't show Metro apps in the taskbar and Windows 8.1 did but apps were running in full screen so showing progress on the taskbar would not make sense. Now with Windows 10, all apps are windowed so it's useful.

I love the progress bar on the taskbar, because I may have a file transfer or download but not always have the applications window open in the foreground. With the progress on the taskbar, it allows me to just take a quick look and see how it is going.
A word from a user.
Sent from my T-Mobile 4G LTE Device

From: Jaiganesh Kumaran<EMAIL_ADDRESS>Sent: Friday, July 24, 2020 12:24:49 AM
To: files-community/files-uwp<EMAIL_ADDRESS>Cc: minecraftchest1<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [files-community/files-uwp] Show progress on the taskbar (#1344)
I don't think we should have progress on the taskbar as it is distracting for users. There's a reason why it wasn't implemented in WinRT APIs to begin with.
That's not the real reason. Windows 8 didn't show Metro apps in the taskbar and Windows 8.1 did but apps were running in full screen so showing progress on the taskbar would not make sense. Now with Windows 10, all apps are windowed so it's useful.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/files-community/files-uwp/issues/1344#issuecomment-663352434, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKIAII626GD2PWHJMXPQJLDR5ELKDANCNFSM4OQHTUAQ.


Link in user index should be show for non admins

Originally created by Tom Smyth at 2015-08-19 01:17, migrated from redmine-#2870

Priority changed from 4 to 3

By Tom Smyth at 2015-08-19 07:19

Status changed from New to Closed

By Tom Smyth at 2015-08-29 17:22

Priority changed from 3 to 2

By Tom Smyth at 2015-08-27 18:10


Distribute Pomsky as a native library

Distributing Pomsky not only in the CLI format, but also as a native library (.so, .dll), allows tools to compile and receive an output in a standardized format which can be interpreted through interfaces like JNI or JNA.
Example usage: compilation and error reporting inside of an IDE.
I think a project like this https://github.com/Dushistov/flapigen-rs might come handy.

My idea was to add a CLI flag to print compilation results as JSON, which could be used by IDEs. However, that is not implemented yet.
But to make your IDE extension work, I think all you need is jni-rs. You can follow this tutorial (maybe there are better ones, this is just the first one I found) and make a crate that exports a Java_Pomsky_compile function for the JNI. Then you just need to map Rust types to Java types. For example, a CompileError can be returned as two integers for the Span and a string.
By the way, I was planning to look at your lexer and BNF grammar but didn't have time until now. I'll try to give you some feedback tomorrow.

@Aloso JSON is a good idea. However, are we sure it's ok performance wise? I would like to call it every time there is an edit, like in the playground, and it has to report errors as fast as possible.
Playground uses a WASM module, so it's basically a native interaction.
If I make a crate, do I have to recompile each time a new version comes out? I believe the answer is yes, which means it becomes a bit cumbersome.

This is how an IDE would handle this situation.

Allow the user to select a CLI executable
Extract the Pomsky version from the CLI
If the user enables the enhanced error reporting, the native library is downloaded through Github
A native call is performed and errors are overlayed

Creating a process takes less than a millisecond on recent hardware, I think, so it's not that expensive to call pomsky's CLI. But to get the best performance, using something like JNI would be better. Yes, that requires recompiling the dynamic library every time a new version comes out, but maybe that can be automated somewhat.

@Aloso just keep in mind extensions should just inherit from the tool. If extensions have to carry their own compiled versions of Pomsky, it becomes a binary hell.


Functions Not Defined

Description:
The newly (been a while to be honest) added templates are considered not defined, hence failing the workflow run suite.
Steps to reproduce:
Configuration stub:
- uses: jo3-l/action-check-yag-tmpl-syntax@v2
  with:
    include: '**/*.gotmpl'

Template stub:
{{ dbDelMultiple (sdict "userID" .User.ID "pattern" "test%") 100 0 }}
{{ dbRank (sdict "userID" .User.ID) .User.ID "test" }}

See error:
function "dbDelMultiple" not defined
function "dbRank" not defined

There's probably more templates not defined (yet), but these were the ones that I caught.

Thanks for the report; fix released in v2.0.1.


Keyboard shortcuts on Windows show Mac shortcuts

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: Windows
- Continue: Latest
- IDE: VS Code

Description

Oh, and you're assuming my computer's make lol.

Some of us use Windows machines. So shortcuts showing Mac keys is not very inclusive.

From user on r/LocalLlama here
To reproduce
No response
Log output
No response

I just had the exact same problem, installed and tried to do the tutorial that auto-opens, and the shortcut keys are all wrong. I had to come to the docs to find out what the equivalent windows keys were.

Fixed in https://github.com/rootedbox/continue/commit/1f0ecdf49877fd3b577e5e8b02b4ad0e94a4ab7f

I just had the exact same problem, installed and tried to do the tutorial that auto-opens, and the shortcut keys are all wrong. I had to come to the docs to find out what the equivalent windows keys were.

Could you share the docs you refered to for the shortcut keys? Thanks in advance!

@Dorish pretty sure it was the extension page in VScode!
Anyway since then many people have bagged that I use windows, alas I am not a "real" dev on linux or Mac,. I only do this as a hobby and for entertainment / enjoyment / occasional self torture.

@Dorish @ewebgh33 I just went through the tutorial to make things a bit clearer and double-checked that we use the correct version for each OS: https://github.com/continuedev/continue/commit/d4d1a8eec9fa253e34d650316a73172bcdec3cac
Going to close the issue, but I know that we've slipped up before and forgotten to parametrize in some of the many many places where we show our shortcuts. Goal is to get it right everywhere, so if you find a mistake please re-open and let me know!

Hey @sestinj
Just reopening this, since the code suggestions in the editor still show mac shortcuts on Windows. See

I'm on the latest stable v0.8.25

@nebula-it Just changed: https://github.com/continuedev/continue/commit/6b9de715a3f683b4cc0771b3ccdbe107a5eb90b2
Was using the symbol for Alt, but this is probably too esoteric


pub list-package-dirs command

If pub get has not been run, then pub list-package-dirs returns an error. list-package-dirs should figure out what needs to be done to return a list of packages and not wait on user interaction.

This issue has been moved to dart-lang/pub#963.


Soundex question

Can you please read on, because I can't repopen a closed issue by my self (read second link).
https://github.com/olivernn/lunr.js/issues/221
http://stackoverflow.com/questions/21333654/how-to-re-open-an-issue-in-github#answer-21333938

Closing this, as it isn't something that is going to be implemented soon, feel free to keep the discussion going on the original issue though.