Error parsing record for TLD queries

👋 ! Thanks for this library -- it's been very useful to me as I've been building out spiry but I found a show-stopping bug while updating my dependency on it (in the hopes of not using a vendored/forked copy of whois-parser-go any longer).
The problem
BSD and GNU whois clients (and the IANA whois resolver) support looking up the canonical resolver for a given TLD (country code or otherwise):
$ whois -h whois.iana.org .edu
% IANA WHOIS server
% for more information on IANA, visit http://www.iana.org
% This query returned 1 object

domain:       EDU

organisation: EDUCAUSE
address:      282 Century Place, Suite 5000
address:      Louisville, CO  80027
address:      United States

contact:      administrative
name:         Information Services Administration
organisation: EDUCAUSE
address:      4772 Walnut Street, Suite 206
address:      Boulder Colorado 80301
address:      United States
phone:        +1-303-449-4430
fax-no:       +1-303-440-0461
e-mail<EMAIL_ADDRESS>
contact:      technical
name:         Registry Customer Service
organisation: VeriSign Global Registry
address:      12061 Bluemont Way
address:      Reston Virginia 20190
address:      United States
phone:        +1-703-925-6999
fax-no:       +1-703-948-3978
e-mail<EMAIL_ADDRESS>
nserver:      A.EDU-SERVERS.NET <IP_ADDRESS> 2001:503:a83e:0:0:0:2:30
nserver:      B.EDU-SERVERS.NET <IP_ADDRESS> 2001:503:231d:0:0:0:2:30
nserver:      C.EDU-SERVERS.NET <IP_ADDRESS> 2001:503:83eb:0:0:0:0:30
nserver:      D.EDU-SERVERS.NET <IP_ADDRESS> 2001:500:856e:0:0:0:0:30
nserver:      E.EDU-SERVERS.NET <IP_ADDRESS> 2001:502:1ca1:0:0:0:0:30
nserver:      F.EDU-SERVERS.NET <IP_ADDRESS> 2001:503:d414:0:0:0:0:30
nserver:      G.EDU-SERVERS.NET <IP_ADDRESS> 2001:503:eea3:0:0:0:0:30
nserver:      H.EDU-SERVERS.NET <IP_ADDRESS> 2001:502:8cc:0:0:0:0:30
nserver:      I.EDU-SERVERS.NET <IP_ADDRESS> 2001:503:39c1:0:0:0:0:30
nserver:      J.EDU-SERVERS.NET <IP_ADDRESS> 2001:502:7094:0:0:0:0:30
nserver:      K.EDU-SERVERS.NET <IP_ADDRESS> 2001:503:d2d:0:0:0:0:30
nserver:      L.EDU-SERVERS.NET <IP_ADDRESS> 2001:500:d937:0:0:0:0:30
nserver:      M.EDU-SERVERS.NET <IP_ADDRESS> 2001:501:b1f9:0:0:0:0:30
ds-rdata:     28065 8 2 4172496CDE85534E51129040355BD04B1FCFEBAE996DFDDE652006F6F8B2CE76

whois:        whois.educause.edu

status:       ACTIVE
remarks:      Registration information:
remarks:      http://www.educause.edu/edudomain

created:      1985-01-01
changed:      2018-10-16
source:       IANA

But using whois-parser-go 1.9.0 I recieve the following error when I try to resolve a TLD:
Domain whois data invalid.

Reproduction case
Here's some example code to reproduce the problem:
package main

import (
	"fmt"

	"github.com/likexian/whois-go"
	whoisparser "github.com/likexian/whois-parser-go"
)

func main() {
	resolver := "whois.iana.org"
	tld := "com"
	record, err := whois.Whois(tld, resolver)

	fmt.Printf("raw record: %+v\nerror: %+v\n\n",
		record, err)

	result, err := whoisparser.Parse(record)
	fmt.Printf("resolver: %+v\nerror: %+v\n",
		result.Domain.WhoisServer, err)
}

I've tracked the problem down to this instruction (https://github.com/likexian/whois-parser-go/blob/master/parser.go#L223), from this commit: https://github.com/likexian/whois-parser-go/commit/e0a4accab8ef93d57c256f2bec705c4697e82642
This functionality worked previously so this is a new bug. It looks like there's an assumption that every whois record will contain a domain name, but that's not always going to be true -- top-level domain records appear to only list the bare TLD in the domain field.
Oh also while I'm here
I also noticed that it looks like you're using regular expressions to match domain roots and top-level extensions -- have you considered using a library like https://godoc.org/golang.org/x/net/publicsuffix to do this instead? That page goes into more detail about the difficulty of the problem and how companies like Mozilla have solved it.
I'm happy to help with these bugs, but I didn't know if you were already working on anything related to these and didn't want to duplicate effort if you already had something in mind.
Thanks!

Hello @mckern
Thanks for your feedback, I have fixed this issue.
Please update to the latest version and have a try.
The code below works for me:
package main

import (
	"fmt"

	"github.com/likexian/whois-go"
	whoisparser "github.com/likexian/whois-parser-go"
)

func main() {
	tld := "com"
	record, err := whois.Whois(tld)

	fmt.Printf("raw record: %+v\nerror: %+v\n\n",
		record, err)

	result, err := whoisparser.Parse(record)
	fmt.Printf("resolver: %+v\nerror: %+v\n",
		result.Domain.WhoisServer, err)
}

Confirmed that this appears to be resolved now. Thanks!


Dynamical show / hidden EditButton

I have a list table and I want to only show Edit button for super user. for example, I would like something as following

   isSuperUser &&
Is it possible to implement this in list view ?
Thanks.

Yes, it's possible, but you'll have to do it yourself. My advice is to use React Context, and a special component that you should write called OnlyForRole, something like:
class OnlyForRole extends Component {
    render() {
        const { name, children, ...rest } = this.props;
        const { roles } = this.context;
        return roles.includes(name) ? React.cloneElement(children, rest) : null;
    }
}

OnlyForRole.contextTypes = {
  roles: React.PropTypes.ArrayOf(React.PropTypes.string),
};

Then use it as a wrapper around Field and Input components:
const PostList = (props) => (
    <List ...props>
        <Datagrid>
           <TextField source="id">
           <OnlyForRole name="manager">
                <EditButton>
           </OnlyForRole>
         </Datagrid>
    </List>
);

The roles array stored in context is your responsibility - initialize it on login.

Thank you. It make sense.


Include Explanation of relations with Account-level identity.

This page could use some improvement in explaining how to "Configure managed identities in Batch pools". Specifically, how it relates to Batch Account 's identity (account level).
In Azure Portal, I can setup Batch's Identity as either "None", "System Assigned" or "User Assigned". However, in the example that this page shows, I can only use "User Assigned" identity in the pool configuration.
The page should include explanation of how the 2 identities (Account level and Pool level, or even include Task-level identity) relate to each other. And how, if possible, to use the Account-level identity in all the nodes in the pool.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 228d18a3-37c6-ab13-5efe-f3496fe70012
Version Independent ID: 68baaeb5-384c-37bb-5b62-2498a5306806
Content: Configure managed identities in Batch pools - Azure Batch
Content Source: articles/batch/managed-identity-pools.md
Service: batch
GitHub Login: @prkannap
Microsoft Alias: prkannap

Hello @stack247 , thanks for reaching out. I have assigned this to the doc-author who will look into it and further update. Thank You.

#reassign @alfpark


Nav glitch?

Every now and then on desktop, mobile and tablet, the Nav bar appears and then doesn't appear.
https://main--mammotome--hlxsites.hlx.page/us/en/portfolios/gamma-detection

This happened due to a test section metadata in the Word doc. I removed the table and nav is shown properly.


Issue with Speech SDK on Raspberry Pi: Runtime Error and Initialization Failure

IN ORDER TO ASSIST YOU, PLEASE PROVIDE THE FOLLOWING:

Speech SDK log taken from a run that exhibits the reported issue.
See instructions on how to take logs.
Unfortunately, I was unable to extract specific logs using the provided instructions, but I have detailed the error messages and conditions under which the error occurs below.

import os
import azure.cognitiveservices.speech as speechsdk

def main():
    speech_config = speechsdk.SpeechConfig(subscription=os.getenv("AZURE_SPEECH_KEY"), region=os.getenv("AZURE_SPEECH_REGION"))
    speech_config.speech_synthesis_voice_name = os.getenv("VOICE_NAME", "zh-CN-XiaoxiaoMultilingualNeural")
    audio_config = speechsdk.audio.AudioOutputConfig(use_default_speaker=True)
    try:
        synthesizer = speechsdk.SpeechSynthesizer(speech_config=speech_config, audio_config=audio_config)
        print("Synthesizer initialized successfully.")
    except Exception as e:
        print(f"Failed to initialize synthesizer: {e}")

if __name__ == '__main__':
    main()

Describe the bug
When attempting to initialize the SpeechSynthesizer on a Raspberry Pi (ARM architecture), the SDK throws a runtime error indicating a failure to initialize the platform. The error message received is "Runtime error: Failed to initialize platform (azure-c-shared). Error: 2176".
To Reproduce
Steps to reproduce the behavior:
Set up a Raspberry Pi with the latest Raspbian OS.
Install the latest version of the Azure Cognitive Services Speech SDK via pip.
Run the above Python script.
Observe the error during the initialization of SpeechSynthesizer.
Expected behavior
I expected the SpeechSynthesizer to initialize successfully without any errors, allowing further actions like synthesizing text to speech.
Version of the Cognitive Services Speech SDK
azure-cognitiveservices-speech 1.37.0
Platform, Operating System, and Programming Language

OS: $ uname -a
Linux mir 6.6.28+rpt-rpi-v8 #1 SMP PREEMPT Debian 1:6.6.28-1+rpt1 (2024-04-22) aarch64 GNU/Linux
Hardware - arm64
Programming language: Python

Additional context
Failed to synthesize speech: Exception with error code:
[CALL STACK BEGIN]
/lib/python3.12/site-packages/azure/cognitiveservices/speech/libMicrosoft.CognitiveServices.Speech.core.so(+0x1ec00c) [0x7fad18c00c]
/lib/python3.12/site-packages/azure/cognitiveservices/speech/libMicrosoft.CognitiveServices.Speech.core.so(+0x20c5e4) [0x7fad1ac5e4]
/lib/aarch64-linux-gnu/libc.so.6(+0x83e08) [0x7fadc93e08]
/lib/python3.12/site-packages/azure/cognitiveservices/speech/libMicrosoft.CognitiveServices.Speech.core.so(+0x20d564) [0x7fad1ad564]
/lib/python3.12/site-packages/azure/cognitiveservices/speech/libMicrosoft.CognitiveServices.Speech.core.so(+0x1bc394) [0x7fad15c394]
/lib/python3.12/site-packages/azure/cognitiveservices/speech/libMicrosoft.CognitiveServices.Speech.core.so(+0x1b9ec0) [0x7fad159ec0]
/lib/python3.12/site-packages/azure/cognitiveservices/speech/libMicrosoft.CognitiveServices.Speech.core.so(+0x1f2d0c) [0x7fad192d0c]
/lib/python3.12/site-packages/azure/cognitiveservices/speech/libMicrosoft.CognitiveServices.Speech.core.so(+0x2066d0) [0x7fad1a66d0]
/lib/python3.12/site-packages/azure/cognitiveservices/speech/libMicrosoft.CognitiveServices.Speech.core.so(+0x1dbc88) [0x7fad17bc88]
/lib/python3.12/site-packages/azure/cognitiveservices/speech/libMicrosoft.CognitiveServices.Speech.core.so(+0x1094dc) [0x7fad0a94dc]
/lib/python3.12/site-packages/azure/cognitiveservices/speech/libMicrosoft.CognitiveServices.Speech.core.so(+0x1f2d0c) [0x7fad192d0c]
/lib/python3.12/site-packages/azure/cognitiveservices/speech/libMicrosoft.CognitiveServices.Speech.core.so(+0x1b9a0c) [0x7fad159a0c]
/lib/python3.12/site-packages/azure/cognitiveservices/speech/libMicrosoft.CognitiveServices.Speech.core.so(+0x225290) [0x7fad1c5290]
/lib/python3.12/site-packages/azure/cognitiveservices/speech/libMicrosoft.CognitiveServices.Speech.core.so(synthesizer_create_speech_synthesizer_from_config+0x10c) [0x7fad0621a4]
/lib/python3.12/lib-dynload/../../libffi.so.8(+0x6ec0) [0x7fad676ec0]
/lib/python3.12/lib-dynload/../../libffi.so.8(+0x6438) [0x7fad676438]
/lib/python3.12/lib-dynload/_ctypes.cpython-312-aarch64-linux-gnu.so(+0x13a78) [0x7fad6a3a78]
[CALL STACK END]
Runtime error: Failed to initialize platform (azure-c-shared). Error: 2176

Hi, Raspbian OS / Raspberry Pi OS is not supported by the Speech SDK (and there's no plan for it). You should install Ubuntu or some other supported Linux distribution as documented in https://learn.microsoft.com/en-us/azure/ai-services/speech-service/quickstarts/setup-platform?tabs=linux&pivots=programming-language-python#platform-requirements
Also note that currently a Linux environment still needs to have OpenSSL 1.x (as the distributions listed in the platform requirements do) in order to use the Speech SDK. Support for 3.x will be added in the next SDK release.


fix kongingress CRD openAPIV3Schema validation error

What this PR does / why we need it:
fix kongingress CRD openapiv3schema validation error
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
https://github.com/Kong/kubernetes-ingress-controller/issues/1807
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Good catch. Switching to source.

deploy/single-v2/* files are autogenerated using the hack/deploy/build-single-manifests.sh script. Changing files under deploy/single* directly is not the right way - you need to change the source file instead, and regenerate deploy/single* only then.
@shaneutt: how does this interact with #1763?

I have been thinking parity cleans up only, the invalid found in this PR breaks deployment, regard this as a bug (https://github.com/Kong/kubernetes-ingress-controller/issues/1807)

deploy/single-v2/* files are autogenerated using the hack/deploy/build-single-manifests.sh script. Changing files under deploy/single* directly is not the right way - you need to change the source file instead, and regenerate deploy/single* only then.
changed a1191e2a10cdb9cbd6ce66fd651bce5927b9a9b2
@shaneutt: how does this interact with #1763?

This can't go in yet because the autogeneration consistency check (in the lint CI job) complains. @ccfishk

This fix was covered by previous merged PR. close as it is.


Update php-autoload-override version

This PR updates the version for the php-autoload-override library.

Coverage remained the same at 100.0% when pulling bc6a3f7572dbb792d95f4c04d4176e7829b49ea0 on adriansuter:patch-override into b2c2883a864dde9a471c92dab0224aa1c5537010 on slimphp:4.x.


added sd-sdr

Lots of boiler-plate code, probably a better way is to use an if onto si-sdr for distinguishing between SI-SDR and SD-SDR. Like instead of scale_invariant=True --> scale_dependent=False
What do you think ?
pull requesting only to foster discussion

Closing, added a new branch on master pit_losses with new losses API. Still needs tests.


Update allowselfservicepurchase-powershell.md

Added syntax to update service point manager security protocol to TLS1.2 (tested)

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/2681

@JohanFreelancer9  Please copy review

@cmcatee-MSFT Please merge this PR. Thanks.

@yogkumgit I'm waiting on confirmation from the PM before I approve this PR.

@cmcatee-MSFT  Have we got any update, Please merge this PR. Thanks.

@cmcatee-MSFT Gentle reminder.

@cmcatee-MSFT Gentle reminder.


Playing with miniKanren

Thanks for this repo.  I've played with it a bit; renamed some types to fit my previous attempts, and reformatted.  Still need to do a bit more work to make the interface easier to use, including printout out the environment including the negative bindings.

Hi, good work!
I am not so much into programming languages anymore so I will probably don't do any work on this anytime soon.
To simplify your work, should I transfer this repo over to you?
Cheers, Janik


Elm language syntax color

Hi
Great job !
Can you add ELM language syntax coloration ? (http://elm-lang.org/)
Thank you :)

Thanks for opening the first issue! 🎉
Elm should be on the public site now, too, if you do a hard refresh.  I don't know the language at all (and I'm just using the Codemirror plugin from here) so hopefully it works well!

Thank you! It works :)


Input with iconRight bad UX when toggling hasSpinner

https://github.com/salesforce/design-system-react/blob/71c00bd8b75195c2c90552804eb5b4f40cb223a3/components/input/private/inner-input.jsx#L303-L316
This causes re-mounting of props.rightIcon each time the hasSpinner prop changes, which is bad for performance. Also, due to that, different styles get applied in both cases, causing the icon to jump left-right

This is most likely a new components or component feature request.

not really


Problem About Inference Engine Neural Network Builder

Hi,
I have tried the builder api and there are some problems with the ConcatLayer builder. For example this code bellow will be core dumped when connect input layer with concat layer
Exception: EXC_BAD_ACCESS (code=1, address=0x20)
I have tested this in my Mac with openvino_2019.2.275.
Builder::Network graph("test");
auto input_id = graph.addLayer(Builder::InputLayer("in").setPort(Port({1, 3, 224, 224})));
auto concat_id = graph.addLayer({{input_id, 0}, {input_id, 0}}, Builder::ConcatLayer("concat").setAxis(1));

Another thing I want to know is when does builder do shape inference.

Dear @junluan
Can you kindly attach your code to this ticket and let me try to reproduce your error ? It may not have anything to do with Mac OSX actually.
Thanks,
Shubha

Dear @junluan
Is your code exactly like this file ?
C:\intel\dldt\inference-engine\tests\unit\builders\concat_layer_test.cpp ?
Please study that file for guidance. That test should work (but definitely let me know if it doesn't).
thanks,
Shubha

Please try to use setInputPorts to specify number of inputs.
You may check OpenCV source code for reference of how to use DNNBuilder: https://github.com/opencv/opencv/blob/master/modules/dnn/src/layers/concat_layer.cpp.

Thank you very much. @shubha-ramani @dkurt
ConcatLayer needs setInputPorts to work.
Another thing I want to know is that can builder infer shapes when I build the network. For example, when I add one layer, can I get the layer output port shapes.
I have test this code below. The relu layer's output port's shape will be empty.
Builder::Network graph("test");
auto input_id = graph.addLayer(Builder::InputLayer("in").setPort(Port({1, 3, 224, 224})));
auto relu_id = graph.addLayer({input_id}, Builder::ReLULayer("relu").setNegativeSlope(0.f));
auto relu_layer = graph.getLayer(relu_id);
auto shape = relu_layer.getOutputPorts()[0].shape();

I think there may have some functions to do shape inference. What I found is getShapeInferImpl function in ie_context.hpp. Is this the only way I can get layer output shapes?
Thank you.

Dear @junluan
There is also getShapeInferTypes . Kindly take a look at the tests under C:\intel\dldt\inference-engine\tests\unit\shape_infer\
Hope it helps,
Thanks,
Shubha


HDFS-16891 Avoid the overhead of copy-on-write exception list while loading inodes sub sections in parallel

If we enable parallel loading and persisting of inodes from/to fs image, we get the benefit of improved performance. However, while loading sub-sections INODE_DIR_SUB and INODE_SUB, if we encounter any errors, we use copy-on-write list to maintain the list of exceptions. Since our usecase is not to iterate over this list while executor threads are adding new elements to the list, using copy-on-write is bit of an overhead for this usecase.
It would be better to synchronize adding new elements to the list rather than having the list copy all elements over every time new element is added to the list.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 46s

trunk passed

+1 :green_heart:
compile
1m 29s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 33s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 27s

trunk passed

+1 :green_heart:
shadedclient
25m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 24s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 51s

the patch passed

+1 :green_heart:
mvnsite
1m 20s

the patch passed

+1 :green_heart:
javadoc
0m 50s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 15s

the patch passed

+1 :green_heart:
shadedclient
25m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
298m 12s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

415m 57s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5300/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5300

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 604e84c5cdea 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8d6faadf6d80b26128e1308b7ad987ceb4f61d74

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5300/1/testReport/

Max. process+thread count
3151 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5300/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@jojochuang @sodonnel could you please review this PR?

CC @sodonnel and @jojochuang who originally authored/reviewed this code in HDFS-14617 / #1028 , just in case they had some reason I haven't considered to prefer CopyOnWriteArrayList for this.

I don't recall my reason for using a copyOnWrite list, but the list is only used in the case of an exception, which will result in the image failing to load and the NN aborting, so its an exception that we really don't expect to happen. Therefore as it stands, the CopyOnWrite list has basically zero overhead. Even if there are exceptions, the total number of entries is equal to the parallel loading threads, so low tens of entries at the most.
Using Collections.synchronizedList does seem simpler or synchronizing on the exceptions object rather than having a separate lock object probably makes sense to simplify this change further.

Thanks for the reviews @cnauroth @sodonnel.

which will result in the image failing to load and the NN aborting, so its an exception that we really don't expect to happen.

That is correct. As such this is going to lead to failure eventually. The only reason I came across this sometime back was due to profiling of a purposeful failure asserting test. We would like to use this parallelism of inodes loading with hadoop 3 upgrades (still running hadoop 2 for majority clusters), and hence running some tests around this.

Can the code be simplifed to this?
final List exceptions = Collections.synchronizedList(new ArrayList<>());

Using Collections.synchronizedList does seem simpler or synchronizing on the exceptions object rather than having a separate lock object probably makes sense to simplify this change further.

Sounds good, thanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 49s

trunk passed

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 23s

trunk passed

+1 :green_heart:
shadedclient
25m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 23s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 51s

the patch passed

+1 :green_heart:
mvnsite
1m 19s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 15s

the patch passed

+1 :green_heart:
shadedclient
25m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
306m 56s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

424m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5300/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5300

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2e2dd3ae5836 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f205782b8ee24449b5dcf91db00f726398eb7ca0

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5300/2/testReport/

Max. process+thread count
3066 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5300/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

I have committed this to trunk and branch-3.3. I did not commit to branch-3.2, because the original HDFS-14617 changes for parallel fsimage loading are not present in branch-3.2.
@virajjasani , thank you for contributing this improvement. @sodonnel , thank you for the help with code review.


update pre-commit

pin version
turn-off autocommit

@kjappelbaum  Turn it off, it manipulate file and install doesn't work.

Turn autocommit off, it manipulate file and install doesn't work.

Thanks for your comment. The answer to this is more nuanced. It will only manipulate the files if you didn't already run the pre-commit locally

Turn autocommit off, it manipulate file and install doesn't work.

Thanks for your comment. The answer to this is more nuanced. It will only manipulate the files if you didn't already run the pre-commit locally

Thanks for replying and for being there. I PR via browser, I was annoying from what happen. I PR data yesterday and it manipulate every time I upload file again and again. It fail it PR due to identifier was 0 and when I take a look on the file I find that it change it's indentation  and added --- on the top of the file. Some file when I upload it again it work and doesn't change and setup work. I stop PR until now. I was happy that I find the reason behind \ and \n that was in my PR and I hope after you fix this all data can install right. Wait until you finish and thanks again for you attention.


Update imported packages to resolve CVE-2020-26160

What would you like to be enhanced
Update imported packages to resolve CVE-2020-26160
https://github.com/cloud-barista/cb-spider/security/dependabot/go.sum/github.com%2Fdgrijalva%2Fjwt-go/open
Packages in go.mod should be updated.
Why is this needed
CVE-2020-26160
Proposed solution
Check github.com/dgrijalva/jwt-go dependency for packages in go.mod

Fix it with https://github.com/cloud-barista/cb-spider/commit/78882afb68433dec81ea438867dba240bfccbfd3


Repairs timeout with error state in case of nothing to repair

The source code seems to ignore return value 0 from triggerRepair in JmxProxy. This value indicate a "nothing to repair" scenario. However, its handled as a regular commandId by SegmentRunner. Eventually the task will end up in an error state after a timeout.
I've tried to fix this issue with the following code. However, tests will still fail due to a wrong repair state and I can't really figure out whats why.
        commandId = coordinator.triggerRepair(segment.getStartToken(), segment.getEndToken(),
                                              keyspace, repairRun.getRepairParallelism(),
                                              repairUnit.getColumnFamilies());

        if(commandId == 0) {
          LOG.info("Nothing to repair for keyspace {}", keyspace);
          context.storage.updateRepairSegment(segment.with()
                  .coordinatorHost(coordinator.getHost())
                  .state(RepairSegment.State.DONE)
                  .build(segmentId));
          segmentRunners.remove(segment.getId());
          return;
        }

Hi, I've applied your change plus an accompanying change in RepairRunner.intensityBasedDelayMillis. Check if this fixes your issue.

Looks good, the repair job will now finish with DONE state in case nothing had to be repaired. Quickly tested with a new 2.0 cluster bootstrapped with CCM.


Actions to release binaries on release creation

Codecov Report

Merging #176 (72dbdb4) into main (721ca7d) will decrease coverage by 42.64%.
The diff coverage is n/a.

:exclamation: Current head 72dbdb4 differs from pull request most recent head 969e7f3. Consider uploading reports for the commit 969e7f3 to get more accurate results

@@             Coverage Diff             @@
##             main     #176       +/-   ##
===========================================
- Coverage   81.38%   38.74%   -42.64%
===========================================
  Files          35       34        -1
  Lines        2466     2431       -35
===========================================
- Hits         2007      942     -1065
- Misses        339     1431     +1092
+ Partials      120       58       -62

Flag
Coverage Δ

integration-test
?

unittests
38.74% <ø> (-0.34%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 27 files with indirect coverage changes


feat: modify "first parent only" option names to match

@RemiCELLARD  Sorry, I missed this in the PR review. I'd like to keep the cli and file option names the same to minimize confusion. Trying to obey the following documentation snippet as closely as possible (unfortunately there are already a few that don't match, so I guess we can consider those in the next major release).

Any of the command line parameters accepted by versionize can be provided via configuration file leaving out any -. For example skip-dirty can be provided as skipDirty in the configuration file.

Before
--first-parent-commits
FirstParentOnlyCommit

After
--first-parent-only-commits
FirstParentOnlyCommits

This is technically a breaking change but v2 was released less than 24 hours ago and this is a brand new command, so I'm fine with bending the rules a bit by only making this a minor version bump.

NOTE: I changed
_testSetup.Repository.Branches["master"]
to
defaultBranch
because the default branch name is gitconfig dependent. The test failed locally because mine is set to "main" rather than "master"

Oops, I'll have to fix that failing test when I get time.

@cabauman
A small change to make in this PR (that I forgot): add the new option in the README.md ?
https://github.com/versionize/versionize/blob/master/README.md#usage

Yep, we'll get that included too!


feat: Add kyverno a policy manager for k8s

https://kyverno.io/docs/introduction/

Kyverno is already ready for deploy. Just need to find use for this in my cluster.


Upgrading api version to fix presubmit tests

What this PR does / why we need it:
E2e tests fails now because it fails to fetch swagger spec. Upgrading the api version to fix this issue
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

This change is

/cc @hougangliu
/cc @ellis-bigelow

Thanks. I will rebase now


Feature Request: Show formatted reference when hovering over a citation

It would be wonderful to see the formatted reference when hovering over a citation.

You can do this with Pandoc Reference List plugin. It will also render the citation properly in your exported PDF with Obsidian's native export.

Apparently, Zotlit can show a hover preview of an existing literature note, when you hover over a citation and hold cmd/ctrl. It can also create literature notes this way, if the citekey doesn't have a literature note associated already. This really ought to be documented, because it's a great feature!


Check revision ID in API

For #37

This is slightly blocked on https://github.com/ProfessionalWiki/PageApprovals/pull/33 because of the change from PageIdentity to WikiPage, which is going to conflict with changes here. Once that PR is done it will be quick to implement this.


Non minified release / build ?

I would like to use a readable / non minified version of Peggy. How can I build it from source ?
npm run-scripts make / build always construct a minified version.

Do you want to use it on the web, or in node?  All of the build steps take lib/**/*.js and transform and minify them, with the entry point being lib/peg.js.  The minified files aren't used at all in node.  If you're going to do your own build stuff for the web, you should just be able to npm install peggy and treat it like any other dependency, but if that doesn't work, we'll fix it.
Another big thing: you often don't need Peggy as a runtime dependency.  Unless you need to compile dynamic grammar files on the fly (like the online editor), it's usually MUCH better to pre-compile your grammar using the Peggy CLI as a devDependency.

You can npm install peggy then just take the min file from node_modules/peggy/browser/peggy.min.js.

Closing because no response to questions.  Please reopen if you want more information.


Fix a typo and fix the link to the INS Registry implementaton

@Spl3en Thank you for point out this typo


Component with @push

Hello,
I have a Livewire component that contains JavaScript, which I push using @push('scripts'). When I use this component on any page, it functions as expected. However, if the component is used within an openModal, the JavaScript doesn't load. I noticed this issue after upgrading to Livewire v3. In v2, the component worked both outside and within modals. Also, when I nest this component inside a parent component, it functions properly.
Can anyone help identify the problem?

An example, for a simple component:
`
Test
@push('scripts')

@endpush

`
If I use this component like @livewire('test') is working correctly.
But if I use it like: <button onclick="Livewire.dispatch('openModal', { component: 'test'})">Open Imatge</button>
Javascript @push is not processed. And component not work.

@push doesn't work inside modals because the main layout is already rendered. This also didn't work in v2. I recommend adding your scripts to app.js so that they are globally available.

That used to work in v2, 100%.

having same problem, some alternative? i dont want to add some big script for all website, only load first when navigated to some especific page

having same problem, some alternative? i dont want to add some big script for all website, only load first when navigated to some especific page

Did you figure something out? I'm stuck as well because my textarea is within the modal component and even setting things globally doesn't work into the modal component :/

having same problem, some alternative? i dont want to add some big script for all website, only load first when navigated to some especific page

Did you figure something out? I'm stuck as well because my textarea (ckeditor) is within the modal component and even setting things globally doesn't work into the modal component :/

Livewire works best with AlpineJS, any alpine invocation is triggered when a modal is opened.
So you can do something like<div x-init="ClassicEditor.create(...)">

I figured out a better approach as sometimes I can't include the JavaScript globally, other times using alpine just doesn't seem to work right for me.
The better approach is dispatching...
Put your typical @push code in your global scripts under a dispatch so it's accessible but doesn't fire until called, and then when opening the modal, fire the dispatch in the mount method
This helped me fix an issue with using Stripe inside a wire-elements modal
Just in case someone comes across this in the future


[Suggestion] Marked Tiles Option: Ability to add text or numbers

Is it possible to have the ability to add text/numbers to the tile markers so we could leave notes on tiles for future times

Just out of curiosity... what is the usecase for this?

i use markers for a lot of things and some times i forget y i put them there or what order to use them in

I think this would be too much for Jagex to handle...
This would make many PvM tasks much easier.
No.

I think this would just clutter the screen way too much + distract from other (more important) overlays (ground items, player indicators etc)

FWIW I think being able to label marked tiles with numbers or short words/acronyms would be helpful without adding too much clutter. It only needs to be as visually noisy as the user decides to make it

I mentioned this on Discord, but I feel this can largely be covered by using different-colored markers already. (mark things in a certain color order, or with different opacities) Furthermore, I can't imagine any UX for this which is both (a) good, and (b) not complicated.

Was thinking maybe hold down another modifier key to make it pop up a text input when you mark the tile. Probably not the best but it'd work

This was added as an external plugin Ground Markers with Labels


NLog didn't install on WinPhone + UWP + PCL

Hi,
I tried installing NLog nuget to a Xamarin.Forms Portable Solution
Type

Bug

NLog version: 4.3.4
Platform: WinPhone + UWP + PCL
In case of a BUG:

What is the current result?
Could not install package 'NLog 4.3.4'. You are trying to install this package into a project that targets '.NETPortable,Version=v4.5,Profile=Profile111', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

What is the expected result?
I thought that it will install in WinPhone + PCL and was hoping for UWP.

Is there a version in which it did worked?
first try

Can you help us by writing an unit test?
There is no need as this is an installation.

Too bad PCL isn't supported. With nlog 4.4 there is support for netstandard, which replaces PCL

See https://github.com/dotnet/corefx/blob/master/Documentation/architecture/net-platform-standard.md

So could you try the latest NLog beta?

yes, this error after trying to install the beta to all projects:
Could not install package 'NLog 4.4.0-beta11'. You are trying to install this package into a project that targets '.NETPortable,Version=v4.5,Profile=Profile111', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
And this was given when trying to install it on only the .Droid + .iOS projects:
Could not install package 'Microsoft.NETCore.Runtime.Native 1.0.2-rc2-24027'. You are trying to install this package into a project that targets 'Xamarin.iOS,Version=v1.0', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
and this is what came after trying with only .Droid Project:
Could not install package 'Microsoft.NETCore.Runtime.Native 1.0.2-rc2-24027'. You are trying to install this package into a project that targets 'MonoAndroid,Version=v6.0', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
and this is what came after trying with only .iOS Project:
Could not install package 'Microsoft.NETCore.Runtime.Native 1.0.2-rc2-24027'. You are trying to install this package into a project that targets 'Xamarin.iOS,Version=v1.0', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
and this is what came after trying a normal PCL class library:
Could not install package 'NLog 4.4.0-beta11'. You are trying to install this package into a project that targets '.NETPortable,Version=v4.5,Profile=Profile111', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

the netstandard is a fail then. It should support Xamarin, but it doesn't it seems. Not sure if that will be fixed in .NET Core RTM.
The "bait and switch" for PCL could work, but I dunno if I can generate the "the bait", see http://log.paulbetts.org/the-bait-and-switch-pcl-trick/

Is this in Visual Studio or Xamarin Studio? Is Visual Studio 2015 up-to-date (update 2) and with the latest NuGet?

Yes, the "Bait" idea/trick needs rethinking.
and I am using VS 2015 u2, And the latest Nuget "<IP_ADDRESS>5".

Is it possible to test with Xamarin Studio?

I don't have Xamarin Studio, and i have never used it, only used VS, and with VS i am developing Xamarin.Forms apps.

Do you have experience with "bait and switch" PCL's?

No, But i read about it before.

closing this, feature request is at https://github.com/NLog/NLog/issues/155


Package invalid

What is your question?
Whenever I try install psychic engine it tells me the package is invalid
Any way?

rename the apk to base.apk, zip it, rename to base.apks and install

rename the apk to base.apk, zip it, rename the zip to base.apks and install

a-
I'm confused 💀 but I will try
Thanks

It won't let me rename....?

move apk to downloads guh

move apk to downloads

I tried changing the name from apk to base.apk still invalid

move apk to downloads

I tried changing the name from apk to base.apk still invalid

as I said add the apk to zip and rename zip to base.apks after install and send screenshot of the error

move apk to downloads

I tried changing the name from apk to base.apk still invalid

as I said add the apk to zip and rename zip to base.apks after install and send screenshot of the error

U can also check if I did anything wrong in the rename

apk file corrupted. reinstall


Update UG

Will fix the whitespace issue after all merged

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2132975) 80.79% compared to head (39b79be) 81.67%.
Report is 18 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #241      +/-   ##
============================================
+ Coverage     80.79%   81.67%   +0.87%
- Complexity      587      593       +6
============================================
  Files            78       78
  Lines          1755     1746       -9
  Branches        178      174       -4
============================================
+ Hits           1418     1426       +8
+ Misses          305      294      -11
+ Partials         32       26       -6

see 8 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Bug?] Electromagnet hotkey to deactivate doesn't work when placed on the baubles inv

The electromagnet isn't responsive of the hotkey to deactivate itself when is on the baubles inventory, also can't be placed it when isn't active. Is this a bug, or intended behaviour?

The second one is the intended behavior. The first one only if the inventory is full.
There is a config setting to allow a deactivated magnet into the Baubles slot.

The magnet won't turn on with the hotkey in a baubles slot if I have the config set to allow a deactivated magnet in the slot.


Date and Time Pickers are within mui-x not mui lab

Hi, thanks for the awesome package! I just wondered if it would work to redirect the paths for the Date and Time pickers as they don't exist in lab now?
https://mui.com/blog/lab-date-pickers-to-mui-x/
as per the following:?
https://github.com/mikful/streamlit-elements/blob/main/streamlit_elements/frontend/components/modules/mui/Lab.tsx
e.g. change in Lab.tsx
DatePicker: dynamic(() => import("@mui/lab/DatePicker"), { loading: ElementsLoading, ssr: false }),

to
DatePicker: dynamic(() => import("@mui/x-date-pickers/DatePicker"), { loading: ElementsLoading, ssr: false }),

If not, is there another way?

I agree with Mikful, it would be awesome to be able to use pickers and add every components needed such as adapters like DateAdapterJs, etc... Your work on this combination between Streamlit and MUI is incredible, thanks for that !


File upload popup is not popping up from Microsoft.Toolkit.Wpf.UI.Controls.WebView in xaml

webview.xaml

<UserControl xmlns:WebViewControls="clr-namespace:Microsoft.Toolkit.Wpf.UI.Controls;assembly=Microsoft.Toolkit.Wpf.UI.Controls.WebView">     <StackPanel>    <WebViewControls:WebView Name="webViewValidate" />   </StackPanel>   </UserControl>

webview.xaml.cs

webViewValidate.IsScriptNotifyAllowed = true; webViewValidate.IsJavaScriptEnabled = true; webViewValidate.Navigate("someURL");
The url is having a file upload control and the pop up is not showing up when I try to upload a file? Do we have any workarounds for this?

The issue is not

I see the issue only if I use Webview in toolWindow extension

FYI @pagoe-msft
Hi @dk511 can you try the new WebView2 Preview and see if it has the same problem?  If so, you'd want to file an issue on their repo pointed to in the doc.

@dk511 are you still having this issue?

Closing this as the issue should be resolved by WebView2 and If it is still persistent then it should be moved to Webview2


use DenseElementsAttr::reshape to implement foldOrEmit

Simplified the implementation of foldOrEmitONNXSqueezeV11Op, foldOrEmitONNXUnsqueezeV11Op.
Question: Is it ok to change the logic to create an ONNXConstantOp of tensor type and fix the lit test accordingly? In my view, it's a mistake that the old logic created ONNXConstantOps with memref type.
Signed-off-by: Soren Lassen<EMAIL_ADDRESS>

abandoning this PR, will go with PR #1954 instead


Add moderation status behind a feature flag

https://emurgo.atlassian.net/browse/YOMO-485
https://emurgo.atlassian.net/browse/YOMO-484

@stackchain is the SonarQube checking coverage on all components and if so, should we start adding unit tests for components?

we are still configuring it.


Use raw distributions from importlib_metadata

This PR resolves #135

Currently, testing in Python 3.8 is failing. I will address this issue at a later date.
[2022-11-14T13:11:52.162Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

Related Links:

Upload Issues (Unable to locate build via Github Actions API) - Support - Codecov
Codecov Uploader

OK, I see that the token was used and the job was successful.
failure log
  Codecov report uploader 0.3.2
[2022-11-14T13:13:47.319Z] ['info'] => Project root located at: /home/runner/work/pip-licenses/pip-licenses
[2022-11-14T13:13:47.321Z] ['info'] -> No token specified or token is empty
[2022-11-14T13:13:47.411Z] ['info'] Searching for coverage files...
[2022-11-14T13:13:47.473Z] ['info'] => Found 1 possible coverage files:
  ./coverage.xml
[2022-11-14T13:13:47.473Z] ['info'] Processing ./coverage.xml...
[2022-11-14T13:13:47.476Z] ['info'] Detected GitHub Actions as the CI provider.
[2022-11-14T13:13:47.477Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-3.1.1-uploader-0.3.2&token=*******&branch=fix-output-with-system-in-v4&build=3461764854&build_url=https%3A%2F%2Fgithub.com%2Fraimon49%2Fpip-licenses%2Factions%2Fruns%2F3461764854&commit=7631f76d66ccc84218c74ed5dd381190c820dd19&job=Python+package&pr=136&service=github-actions&slug=raimon49%2Fpip-licenses&name=codecov-umbrella&tag=&flags=&parent=
[2022-11-14T13:13:48.721Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

success log
  Codecov report uploader 0.3.2
[2022-11-19T09:05:24.443Z] ['info'] => Project root located at: /home/runner/work/pip-licenses/pip-licenses
[2022-11-19T09:05:24.444Z] ['info'] ->  Token found by environment variables
[2022-11-19T09:05:24.537Z] ['info'] Searching for coverage files...
[2022-11-19T09:05:24.591Z] ['info'] => Found 1 possible coverage files:
  ./coverage.xml
[2022-11-19T09:05:24.591Z] ['info'] Processing ./coverage.xml...
[2022-11-19T09:05:24.595Z] ['info'] Using manual override from args.
[2022-11-19T09:05:24.596Z] ['info'] Detected GitHub Actions as the CI provider.
[2022-11-19T09:05:24.597Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-3.1.1-uploader-0.3.2&token=*******&branch=fix-output-with-system-in-v4&build=3502871440&build_url=https%3A%2F%2Fgithub.com%2Fraimon49%2Fpip-licenses%2Factions%2Fruns%2F3502871440&commit=5cf467b52a84b5703d04bd09ff0badb2146fc797&job=Python+package&pr=136&service=github-actions&slug=raimon49%2Fpip-licenses&name=codecov-umbrella&tag=&flags=&parent=
[2022-11-19T09:05:25.085Z] ['info'] https://app.codecov.io/github/raimon49/pip-licenses/commit/5cf467b52a84b5703d04bd09ff0badb2146fc797
https://storage.googleapis.com/codecov/v4/raw/2022-11-19/E13974577919ABF094EC6B6E5BF61C93/5cf467b52a84b5703d04bd09ff0badb2146fc797/77dd22e1-1e5f-4d2a-9d05-df84926751a4.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=GOOG1EJOGFN2JQ4OCTGA2MU5AEIT7OT5Z7HTFOAN2SPG4NWSN2UJYOY5U6LZQ%2F20221119%2FUS%2Fs3%2Faws4_request&X-Amz-Date=20221119T090525Z&X-Amz-Expires=10&X-Amz-SignedHeaders=host&X-Amz-Signature=f72baacd21161e70a52aa620aafd85f5a6ec549333e0c06791b5ab5e8691d227
[2022-11-19T09:05:25.086Z] ['info'] Uploading...
[2022-11-19T09:05:25.298Z] ['info'] {"status":"success","resultURL":"https://app.codecov.io/github/raimon49/pip-licenses/commit/5cf467b52a84b5703d04bd09ff0badb2146fc797"}


server: fix for wrong affinity group count

Description
Fixes wrong count in listAffinityGroup API.
API was returning the count of AffinityGroupJoinVO records.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?
With a running environment,
Before fix - count is equal to VM count for the affinity groups
(local) 🐱 > list affinitygroups
{
  "affinitygroup": [
    {
      "account": "admin",
      "domain": "ROOT",
      "domainid": "1db59a3e-b131-11ea-94f6-645d8651f45a",
      "id": "b878f4e6-fbcd-44f3-9a95-ad8102fd14da",
      "name": "bvcn",
      "type": "host anti-affinity",
      "virtualmachineIds": [
        "0c6bee5e-2d50-4b7a-b26f-30bff5818777"
      ]
    },
    {
      "account": "admin",
      "domain": "ROOT",
      "domainid": "1db59a3e-b131-11ea-94f6-645d8651f45a",
      "id": "10b78b41-8fe4-47c1-8972-3bedd0690fd3",
      "name": "hfd",
      "type": "host anti-affinity",
      "virtualmachineIds": [
        "0c6bee5e-2d50-4b7a-b26f-30bff5818777",
        "f4ca8c20-4887-4bc1-a532-b39cf140c4e4"
      ]
    },
    {
      "account": "admin",
      "domain": "ROOT",
      "domainid": "1db59a3e-b131-11ea-94f6-645d8651f45a",
      "id": "63d02962-ac8a-419a-bb88-eabec223828d",
      "name": "dfsf",
      "type": "host anti-affinity",
      "virtualmachineIds": [
        "0c6bee5e-2d50-4b7a-b26f-30bff5818777",
        "f4ca8c20-4887-4bc1-a532-b39cf140c4e4",
        "cf8d9565-b1c5-40f0-a436-56a52fc86106"
      ]
    }
  ],
  "count": 6
}

After fix - actual count of affinity groups
{
  "affinitygroup": [
    {
      "account": "admin",
      "domain": "ROOT",
      "domainid": "1db59a3e-b131-11ea-94f6-645d8651f45a",
      "id": "b878f4e6-fbcd-44f3-9a95-ad8102fd14da",
      "name": "bvcn",
      "type": "host anti-affinity",
      "virtualmachineIds": [
        "0c6bee5e-2d50-4b7a-b26f-30bff5818777"
      ]
    },
    {
      "account": "admin",
      "domain": "ROOT",
      "domainid": "1db59a3e-b131-11ea-94f6-645d8651f45a",
      "id": "10b78b41-8fe4-47c1-8972-3bedd0690fd3",
      "name": "hfd",
      "type": "host anti-affinity",
      "virtualmachineIds": [
        "0c6bee5e-2d50-4b7a-b26f-30bff5818777",
        "f4ca8c20-4887-4bc1-a532-b39cf140c4e4"
      ]
    },
    {
      "account": "admin",
      "domain": "ROOT",
      "domainid": "1db59a3e-b131-11ea-94f6-645d8651f45a",
      "id": "63d02962-ac8a-419a-bb88-eabec223828d",
      "name": "dfsf",
      "type": "host anti-affinity",
      "virtualmachineIds": [
        "0c6bee5e-2d50-4b7a-b26f-30bff5818777",
        "f4ca8c20-4887-4bc1-a532-b39cf140c4e4",
        "cf8d9565-b1c5-40f0-a436-56a52fc86106"
      ]
    }
  ],
  "count": 3
}

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔debian. JID-1416

Packaging result: ✔centos7 ✔debian. JID-1417

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-1762)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31688 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4154-t1762-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_vpc_privategw_static_routes
Failure
191.03
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
179.04
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Failure
257.65
test_privategw_acl.py

Request for review - @davidjumani @DaanHoogland @GabrielBrascher @ustcweizhou @nvazquez @Spaceman1984

Tested by adding an affinity group from the ui and then running the list affinitygroups api from cloudmonkey. LGTM

@davidjumani can you test and review please
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔debian. JID-1425

LGTM. Tested creating affinity groups across domains and querying them.


Support windows

Summary of changes

On windows, it is common to build 32-bit native modules on a 64-bit host machine. For most node modules, this can be done with the command npm install --arch=ia32. This PR changes neon build such that when it is run as part of npm install, it recognizes the arch flag and passes the corresponding target to cargo build.
This also updates neon new to generate one additional file: a build.rs that allows the native module to link against the correct version of node.lib on windows.

OK, this has been split up into PR #42 and issue #43, so we can close this one.


Add chatter count to viewer list popout

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable

Description
Closes #2993
Adds the chatter count to the viewer list popout

Also could this get the hacktoberfest-accepted label

IMO you should also format the number to use short notation, ie 1k instead of 1000. There is already a helper function for this.

IMO you should also format the number to use short notation, ie 1k instead of 1000. There is already a helper function for this.

Using the existing helper function rounded the chatter count too much for my liking, however in the latest commit I pushed I localized the chatter count to match the /chatters command


DHCP example fails to get an IP address on ESP32-C3

Hi, I tried running the DHCP example (commit a0a6b5fbcf7) on my esp32-c3-mini and it appears as though the code is racy. It fails to get an ip address, unless I do some random permutation of dump_packets, wifi_logs, and manually putting in for i in 1000 {} style loops.
I'm working with @ImUrX and he also cannot get the example working on his PCB, although his is a lolin_c3_mini v1.0.0 (which may have hardware issues with wifi, so could be a red herring).
If I use --release it works consistently.

as mentioned in #88 we had similar problems before which were related to wrong timestamp calculations which shouldn't be the case now (unfortunately I was never able to reproduce it with any of my APs)
Important thing to know: which was the last commit which worked for you? No need to git-bisect - just a commit that works would be a good hint

@bjoernQ this was on the latest main, commit a0a6b5fbcf7. When you say "wrong timestamp calculations which shouldn't be the case now" did you mean that this was solved in another branch?

the fix back then was #44
just to double check: a0a6b5fbcf7 broke things for you while it was working before?
Interesting, since that commit just makes sure the USB keeps enabled 🤔

just to double check: a0a6b5fbcf7 broke things for you while it was working before?

I cant speak for how things worked in the past because I haven't really tried to get wifi working until now. I can confirm that on the commit referenced in my original message, it does not work.
Which range of commits should I be testing? I can try them out tomorrow and get back to you.

That would be great!
Probably it won't work between https://github.com/esp-rs/esp-wifi/commit/69956d42d2ddf00dd7021e429ed815f982e35319  and a0a6b5fbcf7  for you since you are not using the internal USB
So maybe it would already be interesting if 7bd248777dfefc4891a9dc9fc92f4fad0ac26218 works for you - unfortunately there were many, many changes after that
Probably I should try harder finding an AP that shows the same behavior here

My router is an Asus RT-AX92U btw.

I'm using fortigate with latest firmware

Just tested latest commit fe6fcfd in debug mode. It worked the first time I tried it, after that it didn't work anymore.
Commands:
    CTRL+R    Reset chip
    CTRL+C    Exit

ESP-ROM:esp32c3-api1-20210207
Build:Feb  7 2021
rst:0x15 (USB_UART_CHIP_RESET),boot:0xc (SPI_FAST_FLASH_BOOT)
Saved PC:0x4004c518
SPIWP:0xee
mode:DIO, clock div:1
load:0x3fcd5820,len:0x16ec
load:0x403cc710,len:0x95c
load:0x403ce710,len:0x2dc0
SHA-256 comparison failed:
Calculated: 25af9e3d109d88d02c90be5fb57af4df4234571b6f90ea288a6f8f2da8742ea7
Expected: 9fafed52ab0387e903bde368d0d6bfffe0dcc3d2f90dca069a4db891108c387c
Attempting to boot anyway...
entry 0x403cc710
I (43) boot: ESP-IDF v5.0-beta1-764-gdbcf640261 2nd stage bootloader
I (43) boot: compile time 11:30:26
I (43) boot: chip revision: V003
I (46) boot.esp32c3: SPI Speed      : 80MHz
I (51) boot.esp32c3: SPI Mode       : DIO
I (56) boot.esp32c3: SPI Flash Size : 4MB
I (61) boot: Enabling RNG early entropy source...
I (66) boot: Partition Table:
I (70) boot: ## Label            Usage          Type ST Offset   Length
I (77) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (84) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (92) boot:  2 factory          factory app      00 00 00010000 003f0000
I (99) boot: End of partition table
I (103) boot_comm: chip revision: 3, min. application chip revision: 0
I (111) esp_image: segment 0: paddr=00010020 vaddr=3c0c0020 size=1a5e0h (108000)
map
I (136) esp_image: segment 1: paddr=0002a608 vaddr=3fc83848 size=01a80h (  6784)
load
I (138) esp_image: segment 2: paddr=0002c090 vaddr=40380000 size=03844h ( 14404)
load
I (145) esp_image: segment 3: paddr=0002f8dc vaddr=00000000 size=0073ch (  1852)
I (151) esp_image: segment 4: paddr=00030020 vaddr=42000020 size=ba608h (763400)
map
I (282) boot: Loaded app from partition at offset 0x10000
I (282) boot: Disabling RNG early entropy source...
is wifi started: Ok(true)
Start Wifi Scan
AccessPointInfo { ssid: "The Internet", bssid: [4, 217, 245, 228, 52, 64], channe
l: 3, secondary_channel: None, signal_strength: -28, protocols: EnumSet(), auth_m
ethod: WPA2Personal }
AccessPointInfo { ssid: "SpectrumSetup-07", bssid: [164, 151, 51, 76, 171, 5], ch
annel: 1, secondary_channel: None, signal_strength: -66, protocols: EnumSet(), au
th_method: WPA2Personal }
AccessPointInfo { ssid: "SpectrumSetup-10", bssid: [164, 151, 51, 69, 98, 241], c
hannel: 6, secondary_channel: None, signal_strength: -68, protocols: EnumSet(), a
uth_method: WPA2Personal }
AccessPointInfo { ssid: "MySpectrumWiFi40-2G", bssid: [216, 167, 86, 143, 42, 70]
, channel: 1, secondary_channel: None, signal_strength: -82, protocols: EnumSet()
, auth_method: WPA2Personal }
AccessPointInfo { ssid: "Spectrum Free Trial", bssid: [32, 88, 105, 152, 99, 72],
 channel: 6, secondary_channel: None, signal_strength: -82, protocols: EnumSet(),
 auth_method: None }
AccessPointInfo { ssid: "Spectrum Mobile", bssid: [32, 88, 105, 24, 99, 72], chan
nel: 6, secondary_channel: None, signal_strength: -83, protocols: EnumSet(), auth
_method: WPA2Enterprise }
AccessPointInfo { ssid: "Spectrum", bssid: [32, 88, 105, 88, 99, 72], channel: 6,
 secondary_channel: None, signal_strength: -83, protocols: EnumSet(), auth_method
: WPA2Enterprise }
AccessPointInfo { ssid: "SpectrumSetup-13", bssid: [164, 151, 51, 4, 90, 17], cha
nnel: 6, secondary_channel: None, signal_strength: -83, protocols: EnumSet(), aut
h_method: WPA2Personal }
AccessPointInfo { ssid: "homepv", bssid: [24, 177, 105, 27, 143, 5], channel: 1,
secondary_channel: None, signal_strength: -87, protocols: EnumSet(), auth_method:
 WPA2Personal }
Call wifi_connect
wifi_set_configuration returned Ok(())
Ok(EnumSet(Client))
wifi_connect Ok(())
Wait to get connected
Ok(true)
Wait to get an ip address

Running with --release works however.

Commit 7bd248777dfefc4891a9dc9fc92f4fad0ac26218 worked first time in debug, then never again. Same place that it hangs on: "wait to get an ip address". Running with --release works.
So its the same story regardless of which of the three commits I tried. Debug mode fails (95 percent of the time), --release works

Tested commit 3f9df3956722b00a69401e2624952438345be116. Same thing.

Thanks for all the effort!
So, the bottom line is, it is useable with --release but only rarely works in development mode? That's less than ideal
For some reason I can now reproduce this (in dev mode) .... I see it tries to send a discovery request which never actually ends up in the tx-done-callback called (by the wifi driver) - however I see the interrupt fires

I was able to get it working for me again in #90
In general dev-mode isn't really expected to work - some targets won't even get over the connect step and for BLE even basic advertising won't work

Well at least #90 aims to improve things, and the reliable workaround is to compile in release mode.
That should probably be made clear in bold letters in the README and docs.rs btw

This package hasn't been published so I'm not sure we can have anything on docs.rs 😉

Ok - probably the sentence "In general you should use the release profile since otherwise the performance is quite bad." isn't scary enough - will update the README in the linked pull-request
If it is able to connect or not in dev-mode (i.e. with debug-assertions) probably depends on how strict an AP is about timeouts

I guess we can close this now after #90 is merged


Add option to enable smart case matching.

This PR enables smart case matching.

LGTM, thanks again for your contribution:) Highly appreciate!

I think I didn't implement this properly, at least not in the same way Vim does it. Help says this for smartcase:
'smartcase' 'scs'	boolean	(default off)
			global
	Override the 'ignorecase' option if the search pattern contains upper
	case characters.  Only used when the search pattern is typed and
	'ignorecase' option is on.

Since now we default these settings to &ignorecase and &smartcase, i think we should be doing the same thing built in functionality does. What are your thoughts @haorenW1025 ?


Update tensorflow-addons to ~0.11

Proposed changes:
Update tensorflow-addons to ~0.11 to get rid of the warning
UserWarning: Tensorflow Addons supports using Python ops for all Tensorflow versions above or equal to 2.2.0 and strictly below 2.3.0 (nightly versions are not supported).
 The versions of TensorFlow you are currently using is 2.3.0 and is not supported.
Some things might work, some things might not.
If you were to encounter a bug, do not file an issue.
If you want to make sure you're using a tested and supported configuration, either change the TensorFlow version or the TensorFlow Addons's version.
You can find the compatibility matrix in TensorFlow Addon's readme:
https://github.com/tensorflow/addons

Also set tfa.options.TF_ADDONS_PY_OPS = True to avoid https://github.com/tensorflow/addons#gpu-and-cpu-custom-ops-1
Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

@wochinge can you help me resolve Warning: The lock file is not up to date with the latest changes in pyproject.toml. You may be getting outdated dependencies. Run update to update them.. Locally everything is fine. I also updated my poetry version locally, but nothing seem to be working. Can you please try to update the poetry file locally? Thanks.

I think I found the issue on my side. Somehow poetry was not fully updated. Hopefully it is working now.

🎉 Sorry, was a bit swamped and just saw the message now.


fix(Link): 'to' maybe undefined

Technically, null == undefined in JS. But this reads a little better. Thanks!

to == null would also match undefined. Now it fails for empty string.
So <Link to=""> doesn't work anymore and has to be replaced with <Link to="/">.

Whenever I use to == null, I do it intentionally. It's not the same as !to.


Sahar

👷 Deploy Preview for crpp-ai-oncology processing.

Name
Link

🔨 Latest commit
5b47f2b51df787e4a76cf278f37cb8179d0c08fd

🔍 Latest deploy log
https://app.netlify.com/sites/crpp-ai-oncology/deploys/6353f73823c4c200080c1503


Bug: Graph-node killed after a subgraph deployment in a MacBook Pro 2021 M1

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
After deploying a subgraph to graph-node started locally with docker, the following error appears:
docker-graph-node-1  | /usr/local/bin/start: line 52:   162 Killed                  graph-node --node-id "${node_id//-/_}" --postgres-url "$postgres_url" --ethereum-rpc $ethereum --ipfs "$ipfs"
docker-graph-node-1 exited with code 137

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Use a MacBook Pro 2021 M1 to graph create and graph deploy a subgraph to a local running graph-node with docker

hi @0xTimepunk - I think Graph Node Docker images now work on M1 macs per https://github.com/graphprotocol/graph-node/issues/2325
What versions of:

Docker Desktop
Graph Node
Are you running?

What does the memory usage look like on your M1? 137 is out of memory, Mac doesn't kill processes over that but I speculate that docker might when running a linux image.

Hey @azf20 @leoyvens
Using docker 4.2.0 (70708)
Tried both graph-node version from the master branch and this release https://github.com/graphprotocol/graph-node/releases/tag/v0.24.2. (docker-compose up in the docker folder, without any changes to yaml file)
My M1 has 32 gigs of Ram, This is the usage just before it is killed

Docker is setting a limit to the containers memory, not sure how but you need to increase that.

I increased the memory limit to 16gb, yielding the following usage:

Subgraph deploys with no issue, but this memory usage/need is completely abnormal @leoyvens
I noticed even when deploying and making the entity changes the subgraph logs are slow, as if things are taking time, whereas with an old Windows machine with intel and 12gb of ram everything was super fast.

The issue with the M1 is that we don't currently build native images for M1, if you're able to build your own image, that might resolve the issue.

The issue with the M1 is that we don't currently build native images for M1, if you're able to build your own image, or build and run graph node natively, that might resolve the issue.

Would the instructions for this still be https://github.com/graphprotocol/graph-node#running-a-local-graph-node?
Thanks

@0xTimepunk yes those look right.

I had the same issue on my MacBook M1 machine. I rebuild the image and it solves the issue for me.
# Remove the original image
docker rmi graphprotocol/graph-node:latest

# Build the image
./docker/build.sh

# Tag the newly created image
docker tag graph-node graphprotocol/graph-node:latest

docker tag graph-node graphprotocol/graph-node:latest

Thank you! This solves my issue as well. @azf20 and @leoyvens can you mark this answer as the accepted and maybe include it in the readme for now? At least until you build native images for m1. Might help other people.
Thanks

Thanks @flowfree and @0xTimepunk ! Closing this, and proposing a README update here @leoyvens: https://github.com/graphprotocol/graph-node/pull/3097


Feature/ted 1051

Codecov Report
Base: 98.59% // Head: 98.61% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (59572ad) compared to base (8961b37).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
+ Coverage   98.59%   98.61%   +0.01%
==========================================
  Files         136      136
  Lines        6637     6699      +62
==========================================
+ Hits         6544     6606      +62
  Misses         93       93

Impacted Files
Coverage Δ

ted_sws/core/model/transform.py
100.00% <100.00%> (ø)

ted_sws/mapping_suite_processor/__init__.py
100.00% <100.00%> (ø)

...r/entrypoints/cli/cmd_conceptual_mapping_differ.py
100.00% <100.00%> (ø)

...te_processor/services/conceptual_mapping_differ.py
100.00% <100.00%> (ø)

...te_processor/services/conceptual_mapping_reader.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Home Assistant Cloud is disabled but configuration entry is still visible

Home Assistant release with the issue:

0.102.3
Last working Home Assistant release (if known):
unknown
Operating environment (Hass.io/Docker/Windows/etc.):

Docker
Integration:

https://www.home-assistant.io/integrations/cloud/
Description of problem:
I'm currently seeing the Home Assistant Cloud configuration panel though I have disabled the both the cloud and default_config in my configuration.yaml (you can see it here)

This is obviously not a big issue at all, I just wanted to point this out as on previous version this was not showing up!
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

https://github.com/PedroLamas/home-assistant-config/blob/master/config/configuration.yaml
Traceback (if applicable):

Additional information:

The mobile_app integration depends on it.


feat: return full nextQuery object in paginated calls

[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Combine a nextPageRequest from server with user provided custom options, this way user can just pass it to the next call as it is documented in the examples
https://github.com/googleapis/nodejs-spanner/blob/d835ba21489885f1fc092011d955c9ca5ef162ca/src/instance.ts#L1159-L1171

@AVaksman should we merge, or do we need to wait for another review?

It seemed mergeable. Hopefully that wasn't a mistake!


Learn Recursion by Building a Decimal to Binary Converter - Step 104: Typo

Describe the Issue

In the first paragraph, on the 2nd phrase, you can read:

"(...). Now you can get those the paragraph elements (...)."

Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-recursion-by-building-a-decimal-to-binary-converter/step-104
Your code
.
Expected behavior

Rectify to the following:

"(...). Now you can get those paragraph elements (...)."

Screenshots
No response
System
.
Additional context
No response

Thanks for opening this issue.
This looks something that can be fixed by "first time" code contributors to this repository. Here are the files that you should be looking at to work on a fix:
List of files:

https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-recursion-by-building-a-decimal-to-binary-converter/6464ad3c9b2e6cf58224cfa9.md

Please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in our chat room or the forum if you need help contributing, our moderators will guide you through this.
Sometimes we may get more than one pull requests. We typically accept the most quality contribution followed by the one that is made first.
Happy contributing.

I would suggest we remove "those" and keep "the" so we are not repeating "those".
I would also suggest using "attribute value"

You used the inputVal property as the id attribute value for your paragraph elements. Now you can target the paragraph elements with those ids.

The next paragraph reads pretty bad as well. It's just confusing to read. Maybe we can come up with something better.

You set the id attribute value for your paragraph elements to the inputVal property.
Now, use getElementById to select the element with that attribute value using the inputVal property.

Or something like that?

I know the first line already mentioned "paragraph elements", so it is presumed that the second line is referring to that type of element. But as a newbie, when I read "to select the element with that attribute value", it seems any kind of element.
Could we be more specific, and edit to "(...) to select the paragraph element (...)"?

You have set the id attribute value for your paragraph elements to the obj.inputVal property.
Now, use getElementById to select the paragraph element with that attribute value, again using the obj.inputVal property.

when I read "to select the element with that attribute value", it seems any kind of element.

It is selecting by id so the element type doesn't matter. Saying what the element type is seems redundant to me.
But if you or anyone else feel it would make it more clear, then I wouldn't be opposed to it.

Yes, you are right. Mentioning id is what matters.


Kanister does not find Secret without "kind" in reference

I was trying out Kanister on my local machine with Docker Desktop for Windows I stumbled over the following issue:
When omitting kind: Secret in the object reference of the postgres secret I get the following error (with "kind" key and value it works totally fine):
Failed to execute phase: v1alpha1.Phase{Name:"takeDatabaseBackup", State:"pending", Output:map[string]interface {}(nil)}: template: config:16:29: executing "config" at <.Secrets.postgres.Da...>: map has no entry for key "postgres"
github.com/kanisterio/kanister/pkg/param.renderStringArg
	/go/src/github.com/kanisterio/kanister/pkg/param/render.go:101
github.com/kanisterio/kanister/pkg/param.render
	/go/src/github.com/kanisterio/kanister/pkg/param/render.go:32
github.com/kanisterio/kanister/pkg/param.render
	/go/src/github.com/kanisterio/kanister/pkg/param/render.go:36
github.com/kanisterio/kanister/pkg/param.RenderArgs
	/go/src/github.com/kanisterio/kanister/pkg/param/render.go:18
github.com/kanisterio/kanister/pkg.(*Phase).Exec
	/go/src/github.com/kanisterio/kanister/pkg/phase.go:44
github.com/kanisterio/kanister/pkg/controller.(*Controller).runAction.func1
	/go/src/github.com/kanisterio/kanister/pkg/controller/controller.go:382
github.com/kanisterio/kanister/vendor/gopkg.in/tomb%2ev2.(*Tomb).run
	/go/src/github.com/kanisterio/kanister/vendor/gopkg.in/tomb.v2/tomb.go:163
runtime.goexit
	/usr/local/go/src/runtime/asm_amd64.s:1333

Cutout of the objects I deployed:
apiVersion: cr.kanister.io/v1alpha1
kind: Blueprint
        ...
        command:
          - bash
          - -o
          - errexit
          - -c
          - |
...
            PGPASSWORD="{{ index .Secrets.postgres.Data "postgresql-password" | toString }}"
...

apiVersion: cr.kanister.io/v1alpha1
kind: ActionSet
...
    secrets:
      postgres:
        # kind: Secret - works with this line
        name: postgres-secret
        namespace: default

Software Versions
Kanister 0.20.0
Docker Desktop <IP_ADDRESS>
Kubernetes 1.14.3

The main problem / side effect is that I can't use kanctl. As far as I understand it is not possible to specify the object "kind" with kanctl

@gouglhupf - thanks for reporting this and the Blueprint/ActionSet snippets.
kind: Secret is redundant information so we should be able to make it available in TemplateArgs even if it wasn't specified. I'll take a look at the logic there and follow up.

@gouglhupf - Fixed with #222 .
Validated using the following:
apiVersion: cr.kanister.io/v1alpha1
kind: Blueprint
metadata:
  name: testbp
  namespace: kanister
actions:
  backup:
    type: Namespace
    phases:
    - func: KubeTask
      name: test
      args:
        namespace: "{{ .Namespace.Name }}"
        image: kanisterio/kanister-tools:0.20.0
        command:
          - bash
          - -o
          - errexit
          - -c
          - |
            kando output "password" "{{ index .Secrets.postgres.Data "postgresql-password" | toString }}"

Secret:
apiVersion: v1
kind: Secret
metadata:
  name: pgsecret
type: Opaque
data:
  # value is "helloworld"
  postgresql-password: aGVsbG93b3JsZA==

ActionSet creation:
kanctl create actionset --action backup --blueprint testbp --namespacetargets kanister --profile s3-profile-4ml5t --secrets postgres=kanister/pgsecret
actionset backup-9wg2d created

ActionSet output:
ubectl get actionset backup-9wg2d -oyaml
apiVersion: cr.kanister.io/v1alpha1
kind: ActionSet
...
status:
  actions:
  - artifacts: null
    blueprint: testbp
    name: backup
    object:
      apiVersion: ""
      group: ""
      kind: namespace
      name: kanister
      namespace: kanister
      resource: ""
    phases:
    - name: test
      output:
        password: helloworld
      state: complete
  state: complete

Thanks for fixing this.
When can I expect a new release with this fix?


React Capstone Project

React Capstone Project 🗿 📦
I have managed to implement a number of features in this project:
Setup ⚙ ⚙

I created the app using CRA.✔
Linked my project to GitHub. ✔
Followed git-flow ✔
Installed linters for React and Redux.✔
Created the formal document structure.✔
Set up redux and the redux store in my App. ✔
Consumed an API to get the data and displayed it as an MVP.✔
Set up react-router.✔
Data filtering. ✔

Styling 🎨 :art

I used regular CSS to style the components. ✔
I fixed the theme color provided from the designs. 🎨
I added a background image to the cards and header sections. 🪦

Testing 🧪
I also tested the following components and got all green 🟢

App component. 🧪
Navigation component 🧪
Home component  🧪
Details component  🧪
Homecard component  🧪

Documentation 📝
I also update the Readme with the essential data like:

Live video walkthrough
Live link
License
Features
Authors
Future features.

@KayLemba I have seen several contradicting reviews. What changes would you like me to effect kindly? I am lost 😃

@KayLemba Hello Good Sir, I have seen several contradicting reviews. What changes would you like me to effect kindly? I am lost 😃 I can also engage in a call if that would help.

They are not contradicting reviews its an error I made I think you can read in the comments section what you missed out on if you are unsure call me on zoom.

You can call me on zoom if you are unsure

Changes effected and pushed @KayLemba

Hi 👋 @Bennyjoez,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉
Highlights
👍 You did a great job of acknowledging the author for the designs used as requested by the previous reviewer.
Optional suggestions
* [ ]  Kindly note that a good GitHub workflow should always be followed as per project requirements. In this case, Gitflow was supposed to be used and not GitHub flow. You should have created a feature branch from a development branch.

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

@elisha2kyakpo1 the student used correct gitflow he created seperate branches and merged all of them in the development branch so he compared the main branch and development branch which is his default branch for the final submission

Hello @elisha2kyakpo1
I used git-flow for this project. This can be confirmed on the screenshot sent. 🏁 The default branch is the develop branch. and I have been making my changes to feature branches and then merging them to develop. @elisha2kyakpo1
Thank you for approving my project. 👍🏾

Thank you Sir @KayLemba


Support multiple compose files

In my environment I have multiple docker-compose files: one "base", and then some more to enable additional services/options. These additional docker-compose files override/modify the base image settings.
It would be nice if kompose supported this natively: kompose -f base.yml -f mod.yml -f other-mod.yml convert.
Currently it simply ignores all but the last-mentioned file.

Currently it simply ignores all but the last-mentioned file.

This probably counts as "input argument validation", i.e. https://github.com/kubernetes-incubator/kompose/issues/87 is related.

@ankon or this could also look like
kompose -f base.yml,mod.yml,other-mod.yml convert

In principle, yes. But I think it would be good to stay consistent with docker-compose's behavior here.

I can work on this once #304 is merged :) Add supported for multiple file import.


Replace go-auth0 package imports

for our own repo to avoid using a replace in the go.mod.

Related: #83 krakend/krakend-ce#766


Customize values.yaml using Bueprints and GitOps

Hi,
I'm exploring the use cases of AWS Blueprints, and when trying to deploy Vault using GitOps, the customization options are virtually non-existant compared to the Terraform managed flow. In particular, I'm trying to do:
  enable_vault = true
  vault_helm_config = {
    create_service_account_secret_token = "true"
    values = [templatefile("${path.module}/helm_values/vault_values.yaml", {
      iam_role_arn = module.vault_irsa_iam_role.iam_role_arn,
      region       = var.region,
      kms_key_id   = aws_kms_key.vault.id
    })]
  }

but the only option that seems to propagate to the ArgoCD app of Apps used here is simply to toggle enabled. Am I missing something here, or does the GitOps approach not cover 1:1 the customizable settings?
Thank you for the development of the add-on and for taking the time!

I am having the same issue while deploying vault with eks blueprints addons and argocd (argocd_manage_add_ons=true).  The issue comes from this code. See similar implementation for external-dns. I will make a PR to address this.


Can't add any information from the admin ui

Hi everyone,
I completed installation for apigility. However, I can't add new apis or any other information from the admin user interface. For example, if I try to add "status" as a API, I alway get: "I cannot create the API module, please check if already exists" (and there are no APIs yet).

I'm running Linux on Centos 7 with PHP 5.4.16, opcode is not enable.
"AllowEncodedSlashes On" was enable in vhost.
Composer was installed and updated.
'ZF\Apigility\Admin' added in config/application.config.php
zf-development-mode was also installed.
Most file permissions are 775.

Any advice will be highly appreciated.
Diego

Fixed, the config and the module folders needed 777 permission. Thanks.

For people with SElinux enabled, you can sort this out by setting the security context with httpd_sys_content_rw_t
ex:
chcon -R -t httpd_sys_content_rw_t /var/www/html/apigility/module


Integrate with Micronaut AOT

This commit introduces a new io.micronaut.aot plugin which integrates
with the Micronaut AOT module. If applied, this plugin will configure
the build to:

register some prepareXXXOptimizations tasks for optimizing apps
for JIT and native
register new optimizedRun task which executes a Micronaut app
with the result of the AOT optimizations
register new nativeOptimizedRun task which executes a Micronaut
app natively (with GraalVM) with the result of the native optimizations

The AOT optimization configuration is exposed with an aot sub-extension
in the micronaut extension. Currently there's no opt-in because all
the tasks which are being created are isolated from the standard tasks:
it just makes the AOT optimizations visible, without interfering with
the standard execution.
Future work may include an option to replace the standard tasks with
the optimized versions, but it will require more work to get there (in
particular, we need to think what it means for test execution).

Well the issue is similar to testing in native mode: in order to gather the list of tests, test must be executed first in "JVM" mode so that we can introspect what's going to run and build a list for the "native" execution. Here it's similar: just analyzing the classpath isn't enough to understand what MicronautTest is going to be called, nor how the application contexts are going to be executed. So we'd have to run the tests in a first step, possibly with a custom JUnit engine which only triggers MicronautTest configuration, then use this information somehow in AOT.
Alternatively, we need to figure out a way to change micronaut-test so that it uses ContextConfigurer. However, this is a semantic change since ContextConfigurer is unconditional, and that @MicronautTest isn't.

@graemerocher I have created a 3.0.x maintenance branch, and master is now 3.1.x. Are you ok if I merge this and do follow-ups as individual PRs?

fine by me


Add md5(fileName: string): Promise<string>

[x] tests and linter show no problems (npm t)
[x] tests are added/updated for bug fixes and new features
[x] code is properly formatted (npm run fmt)
[x] description of changes is added in CHANGELOG.md
[x] update .d.ts typings

Landed in https://github.com/metarhia/metautil/commit/630808cdea927292961c530296ee2e65cae6ed2f


push command should push contents and start a build

I want to be able to start a build when push command is executed. If the component is configured to  use local or binary content, the content will be uploaded to the build process. If the build is configured with git source, the build will just start.
Depending on how the implementation is done, the build will not be an "OpenShift build" but rather a sync and build with a supervisor process in the container.
Subtask of #169
Dependencies on #219, #220, #221

This user story is already in place. For the purpose of the MVP release, we are fine.
If we have time to address the different refinements that we are looking for, that would be wonderful, but I think we should postpone those to after the mvp release.
Maybe we should be splitting this story, between the user story (already implemented) and the improvements to clarify that here we need to iterate to make the user story better.

@kadel We should have added documentation for functionality. I did not see any documentation in the PR. @surajnarwade pointed me to https://github.com/kadel/bootstrap-supervisored-s2i but a normal user can not find out unless documentation is added.


Items are not being reordered in the index

Items are not being reordered in the index after user reorders items in the dashboard

resolved

issue resolved


New event node priority system

added new functions to EventNode
setChildPriority declares absolute or relative priorities for children of the event node. the priorities are resolved into integer priorities in the "old" system.

May be better to move the enums as subclasses in EventNode. Like EventNode.AbsolutePriority and EventNode.RelativePriority

May be better to move the enums as subclasses in EventNode. Like EventNode.AbsolutePriority and EventNode.RelativePriority

done refactoring. should I open a new request?

I do not think that this should go into the main repo. It just sets priorities anyway so could be done as an external library and imported. I'm not a fan of adding a new graph solving library just for this.
Additionally, I do not believe this solves a problem for many people. For example, a library cannot use this because it does not have knowledge of event nodes beyond the ones it creates, so must default to absolute priorities which do not make much sense. For example, consider library A with events 1, 2, 3 with 1 before 2 before 3. Using this change it may assign for example priorities 1, 2, 3 respectively. Then library B might need to run a node between 1 and 2 for a completely unrelated reason (cancellation ordering, for example). In this case it is impossible for library B to correctly order that node without a hard dependency on library A which makes no sense.


Improve 'service not ready' errors after a deploy

When starting a deploy, even if all the data is synced, it takes time for a service to start. If another service depends on it there are some error's like:
Gridproxy
2023-03-15T17:06:36Z error failed to connect to endpoint, retrying error="node 'ws://tfchain-public-node:9944' is behind acceptable delay with timestamp '2023-02-21 02:56:18 +0000 UTC'"
2023/03/15 17:06:36 Connecting to ws://tfchain-public-node:9944...
2023-03-15T17:06:36Z error failed to connect to endpoint, retrying error="node 'ws://tfchain-public-node:9944' is behind acceptable delay with timestamp '2023-02-21 03:01:36 +0000 UTC'"
2023/03/15 17:06:37 Connecting to ws://tfchain-public-node:9944...
2023-03-15T17:06:37Z fatal failed to create server: failed to connect to substrate: node 'ws://tfchain-public-node:9944' is behind acceptable delay with timestamp '2023-02-21 03:06:55 +0000 UTC

Activation service
2023-03-15 17:05:35          API-WS: disconnected from ws://tfchain-public-node:9944: 1006:: connection failed
..
Figure out if it's feasible to add docker-compose health checks for the proper services to eliminate these error's. So only start a service (that otherwise generates errors), if another services passes the health check.
https://docs.docker.com/compose/compose-file/#healthcheck

Hi @coesensbert
A farmer had an error like this lately.

As I understand, this should be fixed in the upcoming release?
Let me know. Thanks!

OK thanks. So what could the farmer who had this error do in the meantime?
Should he only wait for the public tfchain node to start fully?

All public tfchain nodes are fine and all the hosts are perfectly in sync via ntp. Can also not reproduce the issue, only when I introduce clock scew on my own client. So most likely this will be the issue, since others are also not reporting it. Confirmed by dev.
Could you ask the user to make sure his clock is in sync with his local timezone. Many different guides can be found online for each os.

    depends_on:
      service_name:
        condition: service_started

Resolved for now


Move cookie parsing into dedicated class

By moving this code into a dedicated class we prepare for future changes required by RFC's, and don't grow the ServerRequest class beyond what it purpose it.

Closed via https://github.com/reactphp/http/commit/57b259e51c7ec1ca2854fcf9cccafc1a5308ad0c

This might still be useful in the future, but lets cross that bridge when we get to it


⚠ Digital Ocean - https://status.digitalocean.com/ has degraded performance

In 8ff79b4, Digital Ocean - https://status.digitalocean.com/ (https://status.digitalocean.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 315 ms

Resolved: Digital Ocean - https://status.digitalocean.com/ performance has improved in 3f2375b.


CI flake: "provided port is already allocated" occassionally happens during e2e cross cluster tests

We have seen this flake a few times, it is unclear why it is happening.
In all of the cases the error is provided port is already allocated
In the following two cases the error is on the below line.

https://github.com/defenseunicorns/zarf/actions/runs/8100430794/job/22138566751
https://github.com/defenseunicorns/zarf/actions/runs/8160962762/job/22308786570

_, initStdErr, err := e2e.Zarf("init", "--components="+initComponents, "--nodeport", "31337", "-l", "trace", "--confirm")
require.NoError(t, err)

We also see a similar error here on here on test 99:

https://github.com/defenseunicorns/zarf/actions/runs/8012041029/job/21886586280

stdOut, stdErr, err = e2e.Zarf("init", "--components=k3s", "--confirm")
require.NoError(t, err, stdOut, stdErr)

We believe that during the first two occurrences of the the problem was the registry port 31337 assigned in the test conflicted with the randomly generated trafeik ports created by k3d. This will be solved by disabling trafeik during e2e tests in #2282.
The third issue is an actual bug in zarf. It is caused by the fact that the injector (seed registry) selects a random port and this port could conflict with the registry port. Looking at the logs here confirms this as the seed registry matches the registry in the logs https://github.com/defenseunicorns/zarf/actions/runs/8012041029/job/21886586280.

Hit this again: https://github.com/defenseunicorns/zarf/actions/runs/8841615794/job/24279036176?pr=2456#step:7:494

Yeah it's only like a 1 in 3000 chance, but it's still worth fixing for the init case. Especially since this can also happen to real uses if they have the proper luck or lack thereof


add special subscription support for skims

When defining the subscriptions for workflow output, allow to define different subscriptions for skims. Needed by Tier0. Basically, skims can have the same data tier as regular workflow output but need different subscriptions. As such, the usual selection by primary dataset and data tier isn't enough.
@ticoann please review

And where is the special subscription handling when isSkim/useSkim is True?

There is no special subscription handling. This is just a way to select when subscription info should be used and when not. For an example see
https://github.com/hufnagel/T0/blob/skim-subscription/src/python/T0/RunConfig/RunConfigAPI.py#L810

retest this please

retest this please